wine-devel July 2012

69 participants
314 discussions

Re: sxs: Use inline wrappers for calling COM methods.
by Marvin 31 Jul '12

31 Jul '12

1 0

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 3.
by Dmitry Timoshkov 31 Jul '12

31 Jul '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > This time with even more relaxed comparison of precalculated values (0.5 => 0.6). To make things clearer: I was working on this test under Windows with PSDK compiler, and once I replaced division 1/72 by multiplication to 72.0 the calculated values started to almost exactly match the ones returned by gdiplus APIs. Apparently testbot uses gcc and that change didn't improve things much, so I had to relax the test to pass under testbot. -- Dmitry.

1 0

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 2. Resend.
by Marvin 31 Jul '12

31 Jul '12

1 0

Re: gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 2.
by Marvin 31 Jul '12

31 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20479 Your paranoid android. === WXPPROSP3 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W2K3R2SESP2 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === WVISTAADM (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W2K8SE (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PRO (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PROX64 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === TEST64_W7SP1 (32 bit graphics) === graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333328, got 133.203125 graphics.c:3606: Test failed: Expected 133.333328, got 133.203125 graphics.c:3592: Test failed: Expected 66.666664, got 66.601563 graphics.c:3606: Test failed: Expected 66.666664, got 66.601563 graphics.c:3592: Test failed: Expected 555.555542, got 555.012939 graphics.c:3606: Test failed: Expected 555.555542, got 555.012939 graphics.c:3592: Test failed: Expected 277.777771, got 277.506470 graphics.c:3606: Test failed: Expected 277.777771, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 370.370361, got 370.008606 graphics.c:3606: Test failed: Expected 370.370361, got 370.008606 graphics.c:3592: Test failed: Expected 185.185181, got 185.004303 graphics.c:3606: Test failed: Expected 185.185181, got 185.004303 === W7PROX64 (64 bit graphics) === graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333344, got 133.203125 graphics.c:3606: Test failed: Expected 133.333344, got 133.203125 graphics.c:3592: Test failed: Expected 66.666672, got 66.601563 graphics.c:3606: Test failed: Expected 66.666672, got 66.601563 graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939 graphics.c:3592: Test failed: Expected 277.777802, got 277.506470 graphics.c:3606: Test failed: Expected 277.777802, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 === TEST64_W7SP1 (64 bit graphics) === graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 1.851852, got 1.850043 graphics.c:3606: Test failed: Expected 1.851852, got 1.850043 graphics.c:3592: Test failed: Expected 133.333344, got 133.203125 graphics.c:3606: Test failed: Expected 133.333344, got 133.203125 graphics.c:3592: Test failed: Expected 66.666672, got 66.601563 graphics.c:3606: Test failed: Expected 66.666672, got 66.601563 graphics.c:3592: Test failed: Expected 555.555603, got 555.012939 graphics.c:3606: Test failed: Expected 555.555603, got 555.012939 graphics.c:3592: Test failed: Expected 277.777802, got 277.506470 graphics.c:3606: Test failed: Expected 277.777802, got 277.506470 graphics.c:3592: Test failed: Expected 47.037037, got 46.991096 graphics.c:3606: Test failed: Expected 47.037037, got 46.991096 graphics.c:3592: Test failed: Expected 23.518518, got 23.495548 graphics.c:3606: Test failed: Expected 23.518518, got 23.495548 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 370.370392, got 370.008606 graphics.c:3606: Test failed: Expected 370.370392, got 370.008606 graphics.c:3592: Test failed: Expected 185.185196, got 185.004303 graphics.c:3606: Test failed: Expected 185.185196, got 185.004303

1 0

A milestone of sorts...
by Dan Kegel 31 Jul '12

31 Jul '12

I just ran into a CAD app whose 64 bit version runs better than its 32 bit version on Wine (the 32 bit version hangs with http://bugs.winehq.org/show_bug.cgi?id=31358 but the 64 bit version gets past that and seems to actually do something). Not very important, but kind of cool.

1 0

wine/windows/tchar.h - error "You must use msvcrt when building in Unicode/MBCS mode"
by Ilya Konstantinov 30 Jul '12

30 Jul '12

In 2004, somebody has asked a question: http://www.winehq.org/pipermail/wine-devel/2004-October/030349.html The reply from Alexandre was: > > Either there should be a overriding "wine/include/msvcrt/tchar.h" > > file with different defintions. Or the error message "You must use > > msvcrt when building in Unicode/MBCS mode" is simply superfluous. > It's not superfluous, but it probably needs a !defined(__MSVCRT__) in > there. >From what I see, today the situation is still the same. Is it simply because nobody has dealt with it? In any case, I've implemented Alexandre's change locally (in tchar.h). Now I'll be trying to use winelib's msvcrt with my code. It seems like a "damned if you do, damned if you don't" kind of thing. One issue I'm having now is wine/msvcrt being in the system includes path, thus causing libstdc++ to load winelib's <wchar.h>. Of course, this didn't go too well :-) My goal is to have a Linux app that's, generally speaking, a native app. I have the cooperation of the codebase developers, so they can follow directions to keep the code reasonably portable. At the same time, I don't want to burden them with mundane changes, so if Winelib can bridge over the two worlds sometimes, it'd be great. Perhaps we can have tchar.h operate in two modes: 1) a MSVCRT mode, where all the MSVCRT goodies are available, 2) a glibc mode, where it tries to map as many functions to glibc as possible?

1 0

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active
by siro＠das-labor.org 30 Jul '12

30 Jul '12

1 0

Re: winex11.drv: xrandr1.2 don't assume CRTC 0 is active
by Alexandre Julliard 30 Jul '12

30 Jul '12

Patrick Rudolph <siro(a)das-labor.org> writes: > @@ -279,15 +279,34 @@ static int xrandr12_get_current_mode(void) > return 0; > } > > - if (!resources->ncrtc || !(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[0] ))) > + if (!resources->ncrtc) > { > pXRRFreeScreenResources( resources ); > wine_tsx11_unlock(); > - ERR("Failed to get CRTC info.\n"); > + ERR("No CRTCs found.\n"); > return 0; > } > + for(i=0;resources->ncrtc;i++) > + { > + > + if (!(crtc_info = pXRRGetCrtcInfo( gdi_display, resources, resources->crtcs[i] ))) > + { > + pXRRFreeScreenResources( resources ); > + wine_tsx11_unlock(); > + ERR("Failed to get CRTC info.\n"); > + return 0; > + } > + /* verify that crtc i is active */ > + if((!crtc_info->mode) && (!crtc_info->width) && (!crtc_info->height)) > + if(i+1 < resources->ncrtc) /* crtc i is disabled, test for more crtcs */ > + pXRRFreeCrtcInfo( crtc_info ); > + else > + break; > + else > + break; > + } This clearly needs a helper function. -- Alexandre Julliard julliard(a)winehq.org

2 1

Incompatibilities between different versions of msvcp dlls
by Piotr Caban 30 Jul '12

30 Jul '12

Hi, There are many small differences between functions exported by different versions of msvcp. Currently only msvcp60 contains a partial copy of msvcp90 dll but it needs to be done for other dlls as well. There are classes that are very similar but have different virtual functions table depending on version of the dll. E.g. ctype class (doesn't contain *_s functions in msvcp71 and msvcp100) and basic_streambuf (in msvcp100 it contains _Lock/_Unlock and lacks *_s functions). In current way of implementing such differences it will lead to keeping a copy of ios.c and locale.c files in msvcp60, msvcp71, msvcp90 and msvcp100. The changes in code are minimal in these cases (e.g. in ctype class case it's enough to remove _s functions in vtable and change offsets in call_* macros for msvcp71/msvcp100). Do you have any ideas about solving this problem? Is it acceptable to add version specific defines to make the files identical between dlls? Piotr

2 1

Re: [PATCH] ntdll: add mmap caching
by Alexandre Julliard 30 Jul '12

30 Jul '12

Michael Blumenkrantz <michael.blumenkrantz(a)gmail.com> writes: > Hi, > > Attached is a patch that I wrote a year ago with the help of Bernhard Loos > (jhgf). For various reasons, I didn't get around to submitting it until now. > > This patch adds caching to NtMapViewOfSection() to reduce the frequency of > blocking server requests which occur, instead replacing them with lookups to a > wine rbtree, which is populated during NtCreateSection() and cleared during > close_handle(). While I don't have any performance statistics to show, this > should yield some definite benefits in nearly every modern game given that they > all repeatedly read mmapped sections of files. > > Bernhard suggested to me, at the time of writing this, that there could be some > potential compatibility issues with regard to sharing, but I don't know nearly > enough about the internals here to speculate. There are worse issues, like the lack of locking, and the fact that you are slowing down the close handle path, which will impact every application for a debatable benefit in a few cases. You'll need to show very convincing benchmarks if you want to pursue this further. -- Alexandre Julliard julliard(a)winehq.org

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2012