wine-devel September 2012

wine-devel@winehq.org

54 participants
188 discussions

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller 14 Sep '12

14 Sep '12

On 14.09.2012 11:07, Nozomi Kodama wrote: > Hello > > one remark about this patch. > > Test in real windows shows that D3DXSHEvalDirectionalLight accepts order > > D3DXSH_MAXORDER or order < D3DXSH_MINORDER. > But in these cases, the colour outputs are unpredictable. For the same > calling arguments, D3DSXHEvalDirectionalLight returns different colours. > > That explains the simplicity of the implementation of this function. > > Nozomi. > + FLOAT s, temp[max( 1, order * order )]; Is this allowed in c and does it really work the way one would expect? + for (order = D3DXSH_MINORDER; order <= D3DXSH_MAXORDER; order++) ... + if ( ( order == 0 ) || ( j >= order * order ) ) Why would you check for order == 0? That's imho never the case that this is true. At least if you only test from D3DXSH_MINORDER onward. + unsigned int j, order, start[] = {0, 4, 13, 29, 54}; Using the start[] looks a bit ugly ... why don't you calculate the index? + expected = table[start[order - 2] + j]; ! You've again trailing white spaces. What happens in the following test case? Which result is returned? D3DXSHEvalDirectionalLight(order, &dir, 1.7f, 2.6f, 3.5f, rout, rout, rout); Well the implementation seems to be correct, but it may be nice to test for this as well. Maybe in another patch. Cheers Rico

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 14 Sep '12

14 Sep '12

I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything wrong with this one? -- Sergey

2 1

Re: [PATCH] advapi32: Eliminate dead stores (Clang).
by Alexandre Julliard 14 Sep '12

14 Sep '12

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b > attr_list.count = 0; > attr_list.attr = NULL; > } > - status = SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > - preserve_blob ? 0 : strlen(password), > - preserve_blob ? NULL : password); > + SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > + preserve_blob ? 0 : strlen(password), > + preserve_blob ? NULL : password); I expect you'd want to handle that error instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] windowscodecs: Implement Graphic Control Extension metadata reader.
by Marvin 14 Sep '12

14 Sep '12

1 0

Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.
by Marvin 14 Sep '12

14 Sep '12

1 0

Re: vcomp: better stub for _vcomp_fork
by Alexandre Julliard 13 Sep '12

13 Sep '12

Dan Kegel <dank(a)kegel.com> writes: > @@ -41,6 +42,80 @@ double CDECL omp_get_wtime(void) > return GetTickCount() / 1000.0; > } > > +/* Call helper with the ncount args after ncount */ > +extern void WINAPIV _vcomp_fork(DWORD parallel, int ncount, void *helper, ...); > +#ifdef __i386__ > +__ASM_GLOBAL_FUNC( _vcomp_fork, > + "push %ebp\n\t" > + "movl %esp,%ebp\n\t" > + > + /* Push varargs */ > + "movl 12(%ebp),%ecx\n\t" /* if (nargs > 0) */ > + "test %ecx,%ecx\n\t" > + "jz copyend\n\t" > + "leal 20(%ebp),%edx\n\t" /* dx -> first vararg */ > + "leal (%edx,%ecx,4),%edx\n\t" /* dx += nargs * sizeof arg */ > + "copyloop:\n\t" /* while (nargs-- > 0) */ > + "sub $4,%edx\n\t" > + "pushl (%edx)\n\t" /* push next vararg */ > + "dec %ecx\n\t" > + "jnz copyloop\n\t" > + "copyend:\n\t" > + > + /* Call helper and return */ > + "call *16(%ebp)\n\t" > + "movl %ebp,%esp\n\t" > + "pop %ebp\n\t" > + "ret\n\t" > + ) > +#endif There are several places that already implement that sort of thing the right way, you should copy one of them instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 1/2: try 2]: Implement D3DXSHEvalDirectionalLight
by Alexandre Julliard 13 Sep '12

13 Sep '12

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -2231,6 +2231,40 @@ FLOAT* WINAPI D3DXSHEvalDirection(FLOAT *out, UINT order, CONST D3DXVECTOR3 *dir > return out; > } > > +HRESULT WINAPI D3DXSHEvalDirectionalLight(UINT order, CONST D3DXVECTOR3 *dir, FLOAT Rintensity, FLOAT Gintensity, FLOAT Bintensity, FLOAT *Rout, FLOAT *Gout, FLOAT *Bout) > +{ > + FLOAT s, temp[36]; > + UINT j; > + > + TRACE("Order %u, Vector %p, Red %f, Green %f, Blue %f, Rout %p, Gout %p, Bout %p\n", order, dir, Rintensity, Gintensity, Bintensity, Rout, Gout, Bout); > + > + if ( order > D3DXSH_MAXORDER ) > + { > + FIXME("This case is not implemented yet. Anyway, following to MSDN, this case should not happen\n"); > + > + return D3D_OK; > + } You should test the expected results for that case too, the implementation should be easy either way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation
by Alexandre Julliard 13 Sep '12

13 Sep '12

James Eder <jimportal(a)gmail.com> writes: > @@ -2261,7 +2242,19 @@ NTSTATUS WINAPI NtInitiatePowerAction( > SystemAction,MinSystemState,Flags,Asynchronous); > return STATUS_NOT_IMPLEMENTED; > } > - > + > +#ifdef linux > +static int have_cpufreq(void) > +{ > + FILE* f = fopen("/sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq", "r"); > + if(f) > + { > + fclose(f); > + return 1; > + } > + return 0; > +} > +#endif You don't want to open a file just to see if you will be able to open it for real later on. You'll need to check the subsequent open anyway, so you can do the fallback at that point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] jscript: Don't leave current scope in return statement before evaluating the expression
by Marvin 13 Sep '12

13 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21565 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] mshtml: Added IHTMLDocument4::fireEvent implementation
by Marvin 13 Sep '12

13 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21559 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
19
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel September 2012