wine-devel January 2013

wine-devel@winehq.org

69 participants
275 discussions

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23866 Your paranoid android. === WXPPROSP3 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === WVISTAADM (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PRO (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PROX64 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === TEST64_W7SP1 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PROX64 (64 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === TEST64_W7SP1 (64 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation.
by Marvin 11 Jan '13

11 Jan '13

1 0

Re: [PATCH 2/2] d3d8: Return D3D_OK from the palette setters
by Marvin 11 Jan '13

11 Jan '13

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters
by Marvin 11 Jan '13

11 Jan '13

1 0

Re: kernel32/tests : try2 added tests for copyfileex
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

siro(a)das-labor.org wrote: > OK, but how do I know that the old behavior is broken ? WindowsXp behaves > like msdn quotes while newer windows don't. Do you always assume that the > latest implementation is correct ? Should wine just match the latest > test-results and ignore osversioninfo at all ? It's reasonable to assume that a later Windows implementation should be considered as the one to follow. Changing the reported Windows version in winecfg doesn't change an API behaviour (there are exceptions, but they don't apply in this case). -- Dmitry.

1 0

Re: kernel32/tests : try2 added tests for copyfileex
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Patrick Rudolph <siro(a)das-labor.org> wrote: > try2: > check the os version in case of PROGRESS_STOP > + ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, (void*)&fileInfo); > + > + /* Windows Vista and newer delete the file, while prior versions don't */ > + ok((!ret && info.dwMajorVersion > 5) || (ret && info.dwMajorVersion <= 5), > + "GetFileAttributesEx return-value wrong, got %u and MajorVersion is %u\n", ret, info.dwMajorVersion); Then you should mark old behaviour as broken() and don't check Windows version at all. -- Dmitry.

2 1

Re: d3dx9: Implement D3DXSHEvalConeLight (resend)
by Marvin 11 Jan '13

11 Jan '13

1 0

Re: user32: fix non-BOOL returns in BOOL functions
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * user32: fix non-BOOL returns in BOOL functions GetClassInfo is special, it actually returns class atom on success, not just a boolean value. So it's better to leave it as it is now. -- Dmitry.

1 0

Re: [PATCH 2/4] kernel32/path : try2 implement copyfileexW progressroutine callback
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Patrick Rudolph <siro(a)das-labor.org> wrote: > try 2: > set progress routine pointer to NULL to disable progress reporting > test osversion and delete destination file on PROGRESS_STOP on vista > and newer This kind of version check is useless in Wine. -- Dmitry.

1 0

Re: [2/2] comctl32/listview: Add a special case for deselect all attempt when nothing is selected
by Marvin 10 Jan '13

10 Jan '13

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2013