wine-devel October 2013

wine-devel@winehq.org

60 participants
246 discussions

Re: [01/02] d3d9: update locked_rect only if wined3d_surface_map succeeds
by Henri Verbeet 21 Oct '13

21 Oct '13

On 21 October 2013 10:46, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 02b4174..51835c8 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -5402,8 +5402,12 @@ static void test_lockrect_invalid(void) > > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(SUCCEEDED(hr), "Failed to lock surface with rect NULL, hr %#x.\n", hr); > + locked_rect.pBits = 0xdeadbeef; > + locked_rect.Pitch = 1; > hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, 0); > ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + ok(locked_rect.pBits == 0xdeadbeef, "pBits changed on double lock.\n"); > + ok(locked_rect.Pitch == 1, "Pitch changed on double lock.\n"); > hr = IDirect3DSurface9_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > This introduces warnings: device.c: In function ‘test_lockrect_invalid’: device.c:5405:23: warning: assignment makes pointer from integer without a cast [enabled by default] device.c:5409:26: warning: comparison between pointer and integer [enabled by default] Also applies to the d3d8 test.

1 0

Re: [03/23] kernel32/tests: Fix console tests compilation with __WINESRC__ defined.
by Marvin 21 Oct '13

21 Oct '13

1 0

Re: server: Implement job objects (try 3)
by Alexandre Julliard 21 Oct '13

21 Oct '13

Andrew Cook <ariscop(a)gmail.com> writes: > It's been another 3 weeks with zero response. You keep sending more and more versions of the same patches, so it seems clear that this stuff is not ready yet. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [02/23] kernel32/tests: Fix file change notification tests compilation with __WINESRC__ defined.
by Marvin 21 Oct '13

21 Oct '13

1 0

Clang Static analysis
by C.W. Betts 21 Oct '13

21 Oct '13

I have been doing a Clang static analysis of Wine on OS X using the one provided at http://clang-analyzer.llvm.org and storing the results on my PogoPlug drive. If someone wants to see the results, please tell me and I'll set up your e-mail. You will need a free PogoPlug account to view them. While the contents are zipped, they expand to about 1.2 GB. They are displayed as basic HTML pages, so you don't need anything special other than a web browser to see the results. Or you could click on this link for the analysis of 1.7.4: http://ppl.ug/ND-7PZ3cSzM/

2 1

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex]. (try 2)
by Marvin 20 Oct '13

20 Oct '13

2 1

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].
by Marvin 20 Oct '13

20 Oct '13

1 0

Re: shell32: Avoid leaks and add parameter checks in SHCreateShellFolderView[Ex].
by Nikolay Sivov 20 Oct '13

20 Oct '13

On 10/20/2013 21:01, Thomas Faber wrote: > + if (0) > + { > + // crash on win7 > + pSHCreateShellFolderViewEx(NULL, NULL); > + pSHCreateShellFolderViewEx(NULL, &psv); > + pSHCreateShellFolderViewEx(&csfv, NULL); > + } Please no cpp comments. > + MAKEFUNC_ORD(SHCreateShellFolderViewEx, 174); > + MAKEFUNC_ORD(SHCreateShellFolderView, 256); These call are exported by name at least on XP, probably 2000 too, so it makes no sense to use ordinals here. > + if (!pSHCreateShellFolderView || !pSHCreateShellFolderViewEx) > + { > + win_skip("SHCreateShellFolderView or SHCreateShellFolderViewEx missing.\n"); > + return; > + } I don't think it's really possible to have *Ex version without non-Ex one. > + hr = SHGetDesktopFolder(&desktop); > + ok(hr == S_OK, "got (0x%08x)\n", hr); > + if (FAILED(hr)) > + { > + skip("No desktop folder\n"); > + return; > + } It's not going to fail, so a ok() test is enough. > + memset(&sfvc, 0, sizeof(sfvc)); > + sfvc.cbSize = sizeof(sfvc); > + sfvc.pshf = desktop; > + psv = (void *)0xdeadbeef; > + hr = pSHCreateShellFolderView(&sfvc, &psv); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + ok(psv != NULL, "psv = %p\n", psv); > + if (psv && psv != (void *)0xdeadbeef) > + { > + refCount = IShellView_Release(psv); > + ok(refCount == 0, "refCount = %u\n", refCount); > + } It's simpler than that. Set 'psv' to NULL and test for it being set after a call. > + test_SHCreateShellFolderView(); You're testing two calls here, so they probably deserve two separate test functions.

1 0

Re: shell32/tests: Use BOOL type where appropriate
by Marvin 19 Oct '13

19 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2879 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:1197: Test failed: expected 1 args, got 4 shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec.', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%nasty% $file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\%NASTY~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:/DOCUME~1/winetest/LOCALS~1/Temp/wt1.tmp/test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.noassoc.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~2.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1538: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\masked file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\MASKED~1.SHL' shlexec.c:1631: Test failed: argvA4 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1939: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:1947: Test failed: argvA4 expected 'C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.shlexec', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SHL' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2250: Test failed: argvA3 expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.sde', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\TESTFI~1.SDE' shlexec.c:2240: Test failed: argcA expected 5, but got 4 === wvista (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1530: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC34E.tmp\test file.noassoc', but key not found or empty === w2008s64 (32 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wt9F4A.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wt9F4A.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wt9F4A.tmp\test2.exe' === w864 (32 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt4E1F.tmp\wt4E20.tmp" Exec") succeeded: rc=42 === w2008s64 (64 bit shlexec) === shlexec.c:1538: Test failed: argvA4 expected 'C:/Users/ADMINI~1/AppData/Local/Temp/wtDF85.tmp/test file.shlexec', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test file.shlexec' shlexec.c:2606: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2619: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' shlexec.c:2631: Test failed: longPath expected 'C:\Users\ADMINI~1\AppData\Local\Temp\wtDF85.tmp\test2.exe', got 'C:\Users\Administrator\AppData\Local\Temp\wtDF85.tmp\test2.exe' === w864 (64 bit shlexec) === shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1506: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1538: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:137: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:137: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") WaitForSingleObject returned 258 shlexec.c:2059: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wt9DA5.tmp\wt9DA6.tmp" Exec") succeeded: rc=42 === w864 (64 bit shlfolder) === shlfolder: unhandled exception c0000005 at 000007F851EBABDC

1 0

Re: server: Implement job objects (try 2)
by Andrew Cook 18 Oct '13

18 Oct '13

On 17/10/13 15:11, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 172 ++++++++++++++++++++++- > dlls/ntdll/sync.c | 127 +++++++++++++++-- > server/process.c | 313 > ++++++++++++++++++++++++++++++++++++++++++ > server/process.h | 3 + > server/protocol.def | 33 +++++ > 5 files changed, 636 insertions(+), 12 deletions(-) > > Is there something wrong with this patch?

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel October 2013