December 2013 - wine-devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer 22 Nov '20

22 Nov '20

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong 28 Sep '18

28 Sep '18

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird 14 Jun '18

14 Jun '18

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart 16 Jun '16

16 Jun '16

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger 05 Jul '15

05 Jul '15

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard 23 Apr '15

23 Apr '15

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard 23 Aug '14

23 Aug '14

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

What happened to the Fedora packages?
by Neal Gompa 02 Aug '14

02 Aug '14

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

Better managing icons files names
by Pedro Henrique Lara Campos 02 Jan '14

02 Jan '14

Can Wine or could it in newer versions, use a prefix for their icons, like wine_56BA_Tcharam.png, or maybe their own folder? My ~/.local/share/icons is like... full of bottles, every corner I look, I find an icon from wine :P

3 2

Re: winex11: Implement X11DRV_FLUSH_GDI_DISPLAY ExtEscape command
by Alexandre Julliard 31 Dec '13

31 Dec '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This patch implements an additional ExtEscape command > X11DRV_FLUSH_GDI_DISPLAY, which can be used by external applications in > order to flush all drawing operations to the Xserver. > > This patch is necessary for a new feature of Pipelight: In NPAPI > windowlessmode the browser provides an X11 drawable, and expects the > plugin (= the wine application) to draw on it. The current > implementation uses CreateDCA() to create a new hDC and then > X11DRV_SET_DRAWABLE to draw on an arbitrary X11 drawable. The additional > command implemented in this patch is required to ensure that the drawing > is finished before the PAINT event returns. Normally an XSync would be > even better, but a lot of testing shows that XFlush is also sufficient > (and faster), thats why we decided to use this approach. You should call MsgWaitForMultipleObjects or some similar function instead of adding private escapes. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] ntdll: Dynamically grow buffer in read_changes_apc
by Alexandre Julliard 31 Dec '13

31 Dec '13

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/ntdll/directory.c | 35 +++++++++++++++++++++++++++-------- > 1 file changed, 27 insertions(+), 8 deletions(-) You can't allocate memory inside an APC callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Status of WineD3D on Windows
by Peter Lehmkuhle 31 Dec '13

31 Dec '13

Hi all, I'm not sure if this is the right list for this question, but I guess I'll find out soon. :) On http://wiki.winehq.org/WineD3DOnWindows it is written that "DirectDraw [..] can't be used at this point due to a conflict with opengl32.dll." I guess that's the current status, because the ddraw.dll is not included in the last build. Are there any plans to change this in the near future? TIA for an answer. Best regards, Peter

2 1

Re: [PATCH 1/4] ole32: Fix parameter validation for CreateClassMoniker()
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3908 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000041F2CA === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000041F2CA

1 0

Re: kernel32/tests: Add test for FindFirstFileA
by Zhenbo Li 31 Dec '13

31 Dec '13

2013/12/30 Zhenbo Li <litimetal(a)gmail.com>: > As MSDN[1] mentioned, "This parameter should not ... end in a trailing > backslash (\)." So I think I should add this test case. > > [1]: > http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418%28v=vs.85%… > --- > dlls/kernel32/tests/file.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Sorry, I made a mistake while reading the previous code. Please reject this patch, and I'll send another patch later. Sorry for this inconvenience.

1 0

Re: winhttp/tests: Constify a character string
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3905 Your paranoid android. === w7pro64 (32 bit winhttp) === winhttp.c:859: Test failed: failed to send request 12175

1 0

Re: [4/4] ws2_32: Cope with invalid hints in getaddrinfo/GetAddrInfoW
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3900 Your paranoid android. === wxppro (32 bit sock) === sock.c:554: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === wvista (32 bit sock) === sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost === w2008s64 (32 bit sock) === sock.c:554: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost === w2008s64 (64 bit sock) === sock.c:554: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost sock: unhandled exception c0000005 at 000007FEFE4C9CD9 === w7pro64 (64 bit sock) === sock.c:554: Test failed: oob_server (980): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support (try 2, resend)
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3899 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 1/6] qcap: Added IPersistPropertyBag::Load implementation.
by Marvin 30 Dec '13

30 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3892 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: msrle32: Added tests.
by Marvin 30 Dec '13

30 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3886 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Win32_PnPEntity WMI class
by Luke A. Guest 29 Dec '13

29 Dec '13

Hi, Is anybody working on this at the moment? I need this working for bug 35224. If not, what do I need to be looking at to get this to work? I know nothing about this API tbh. Thanks, Luke.

1 1

Help about implementing WSACleanup (ws2_32)
by Bruno Jesus 29 Dec '13

29 Dec '13

Hi, in an attempt to fix bugs 18670 and 26031 I would like to try implementing WSACleanup more properly. My limited knowledge in the interactions between the ws2_32 dll and wine server makes me think this is easy. The idea is to add the created socket in WSASocketW in a list and remove it from the list when closesocket is called. When the last WSACleanup is called it would iterate through the socket list and destroy the remaining sockets. When WSASocketW is called it calls the server to create the socket, when closesocket is called the server is also called and the function sock_destroy takes care of shutting down the socket. Currently I'm thinking about doing this in the dll side because the server is not aware of WSACleanup, but maybe it should because it needs to avoid calling any async operation completion. My questions are: 1) When I open 2 programs that use ws2_32 dll the global variables memory is not shared, right? Otherwise the WSAStartup/Cleanup count could be messed up if one application didn't call the Cleanup function. I hope this true so the socket list would not have to take care of different processes id. I understand that one application can have multiple threads and that's what the struct per_thread_data is about, but I hope the dll is not shared among different processes. 2) Is this a reasonable approach? If yes, is there any example of a critical protected list (add, iterate, remove items) that I could use? Best wishes, Bruno

1 0

Re: [PATCH 2/2] dmusic/tests: Add some COM tests for IDirectMusic/IDirectMusicCollection
by Marvin 28 Dec '13

28 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3877 Your paranoid android. === w2008s64 (32 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 00401FDE === w2008s64 (64 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 0000000000401EC2

1 0

Re: qedit/tests: Constify some character strings
by Marvin 28 Dec '13

28 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3869 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 0040185A === w2008s64 (64 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017C3

1 0

Re: wtsapi32: partial implementation of WTSEnumerateProcessesW (resend)
by André Hentschel 28 Dec '13

28 Dec '13

> diff --git a/dlls/wtsapi32/wtsapi32.c b/dlls/wtsapi32/wtsapi32.c > index 898b95d..53c6325 100644 > --- a/dlls/wtsapi32/wtsapi32.c > +++ b/dlls/wtsapi32/wtsapi32.c > @@ -18,9 +18,13 @@ > #include "config.h" > #include <stdarg.h> > #include <stdlib.h> > -#include "windef.h" > -#include "winbase.h" > +#include "ntstatus.h" > +#define WIN32_NO_STATUS > +#include "winternl.h" > #include "wtsapi32.h" > +#include "wine/library.h" > +#include "wine/server.h" > +#include "wine/unicode.h" > #include "wine/debug.h" do you need that all? > WINE_DEFAULT_DEBUG_CHANNEL(wtsapi); > @@ -84,14 +88,65 @@ BOOL WINAPI WTSEnumerateProcessesA(HANDLE hServer, DWORD Reserved, DWORD Version > BOOL WINAPI WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD Version, > PWTS_PROCESS_INFOW* ppProcessInfo, DWORD* pCount) > { > - FIXME("Stub %p 0x%08x 0x%08x %p %p\n", hServer, Reserved, Version, > - ppProcessInfo, pCount); > + SYSTEM_PROCESS_INFORMATION *spi; > + ULONG size = 0x4000; > + void *buf = NULL; > + NTSTATUS status; > + DWORD i,lcount = 0; > + WTS_PROCESS_INFOW *linfo; can't you use sizeof(*spi) or a multiple of it for size? or clean it up somehow else... > if (!ppProcessInfo || !pCount) return FALSE; > > *pCount = 0; > *ppProcessInfo = NULL; > > + if (hServer != WTS_CURRENT_SERVER_HANDLE) > + { > + FIXME("Only WTS_CURRENT_SERVER_HANDLE is impemented\n"); > + return FALSE; > + } > + > + do { > + size *= 2; > + HeapFree(GetProcessHeap(), 0, buf); > + buf = HeapAlloc(GetProcessHeap(), 0, size); > + if (!buf) > + return FALSE; > + > + status = NtQuerySystemInformation(SystemProcessInformation, buf, size, NULL); > + } while(status == STATUS_INFO_LENGTH_MISMATCH); > + > + if (status != STATUS_SUCCESS) > + { > + HeapFree(GetProcessHeap(), 0, buf); > + SetLastError(RtlNtStatusToDosError(status)); > + return FALSE; > + } > + > + spi = buf; why not dropping buf completely? > + do { > + lcount++; > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); > + } while(spi->NextEntryOffset != 0); isn't there an easier way to get the count? > + linfo = HeapAlloc(GetProcessHeap(), 0, lcount * sizeof(WTS_PROCESS_INFOW)); > + if(!linfo) > + return FALSE; > + > + for(i = 0, spi = buf; i < lcount; i++) > + { > + linfo[i].SessionId = 0; > + linfo[i].ProcessId = HandleToUlong(spi->UniqueProcessId); > + linfo[i].pProcessName = spi->ProcessName.Buffer; > + linfo[i].pUserSid = NULL; > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); > + } > + *ppProcessInfo = linfo; > + *pCount = lcount; > + FIXME("pUserSid not filled\n"); > + > + HeapFree(GetProcessHeap(), 0, buf); > return TRUE; > } > > diff --git a/include/wtsapi32.h b/include/wtsapi32.h > index f4bab56..0476478 100644 > --- a/include/wtsapi32.h > +++ b/include/wtsapi32.h > @@ -135,6 +135,8 @@ typedef struct _WTS_SERVER_INFOW > DECL_WINELIB_TYPE_AW(WTS_SERVER_INFO) > DECL_WINELIB_TYPE_AW(PWTS_SERVER_INFO) > > +#define WTS_CURRENT_SERVER_HANDLE NULL > + maybe some more WTS_ defines while you're at it > void WINAPI WTSCloseServer(HANDLE); > BOOL WINAPI WTSConnectSessionA(ULONG, ULONG, PSTR, BOOL); > BOOL WINAPI WTSConnectSessionW(ULONG, ULONG, PWSTR, BOOL); >

2 1

Re: kernel32/tests: add test for RemoveDirectory
by Dmitry Timoshkov 28 Dec '13

28 Dec '13

Zhenbo Li <litimetal(a)gmail.com> wrote: > + /* remove a nonexist directory */ > + rc = RemoveDirectoryA(directory); > + todo_wine > + ok(!rc && GetLastError() == ERROR_FILE_NOT_FOUND, > + "Expected ERROR_FILE_NOT_FOUND, got ret=%d, gle=%d\n", rc, GetLastError() ); This kind of test for several values simultaneously is really very awkward as a starting point for any person who is going to work on this, or just is looking for a simple bug to fix and greps for todo_wine in the tests. First of all it's not clear where the failure is: is it the API failing to return correct return value, or is it just last error which is set differently? I admit that the error message mentions both values, but it's often more useful to spot areas with todo_wine statements and clearly see the reason of a failure without actually running the test. -- Dmitry.

3 3

Re: Bruno Jesus : ws2_32: Do not convert EAI_xxx return in case of success.
by Bruno Jesus 27 Dec '13

27 Dec '13

On Fri, Dec 27, 2013 at 5:31 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: fc5884c23296c0f121442d0832b0187074e95a10 > ... > @@ -5365,6 +5365,8 @@ static int convert_aiflag_u2w(int unixflags) { > static int convert_eai_u2w(int unixret) { > int i; > > + if (!unixret) return 0; > + > for (i=0;ws_eai_map[i][0];i++) > if (ws_eai_map[i][1] == unixret) > return ws_eai_map[i][0]; Hi, Alexandre. I just would like to say that my patch was based on the other use case of the convert_eai_u2w function, that is just call the function to convert EAI results. Zero is not an EAI result (there is no EAI_SUCCESS or something like that) so in my patch I just avoided calling the conversion function. I'm talking about this use case: http://source.winehq.org/source/dlls/ws2_32/socket.c#L5488 In summary, I think my original patch [1] could get a new reviewing. [1] - http://source.winehq.org/patches/data/101198 Best wishes, Bruno

1 0

Re: [4/4] ws2_32: Add extended IPX protocol support (try 2, resend)
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3867 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9D54

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support (try 2)
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3866 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (194): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: loader: bump XP 64-bit to service pack 2
by Qian Hong 27 Dec '13

27 Dec '13

Hi Austin, you forgot the patch? On Sat, Dec 28, 2013 at 4:04 AM, Austin English <austinenglish(a)gmail.com> wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=35084 > > (follow up to 0463d01f151fb3d7c7acf26c7628683fefb6c130) > > > -- > -Austin > > -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: [4/4] ws2_32/tests: Fix some test message typos
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3861 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (5a8): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 71AB3F3A === wvista (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 000007FEFE4C9CD9 === w7pro64 (64 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3860 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 71AB3F3A === wvista (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (32 bit sock) === sock.c:522: Test failed: oob_server (578): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (64 bit sock) === sock.c:531: Test failed: oob_server (988): not at the OOB mark: 1 sock.c:2101: Test failed: Expected 10043, received 10047

1 0

Re: ws2_32/tests: Add some IPX socket tests
by Bruno Jesus 27 Dec '13

27 Dec '13

On Thu, Dec 26, 2013 at 8:11 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > It looks like testbot does not support IPX but I manually tested this in XP SP3 and NT4 and the tests are OK. > > These are initial tests to find the problem for bug 6941. Please ignore this patch, I have a better one. Best regards, Bruno

1 0

Re: ws2_32/tests: Add some IPX socket tests
by Marvin 26 Dec '13

26 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3859 Your paranoid android. === wxppro (32 bit sock) === sock.c:521: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:521: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:521: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: msxml3/tests: Constify some character strings
by Marvin 26 Dec '13

26 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3855 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Implementing support for MFPlat.dll and MFReadWrite.dll
by Alexandre Bique 25 Dec '13

25 Dec '13

Hi, I'm trying to make Ableton Live works better with wine, and as stated in this bug: https://bugs.winehq.org/show_bug.cgi?id=35105 setting wine version to win8 will make Ableton Live crash. I first though that it was an issue with the OpenFileDialog being replaced by IFileDialog because it was something that changed and it was visible, but after second thought, I'm thinking about something else. I noticed that ableton tries to load these libraries: err:module:import_dll Library MFReadWrite.dll (which is needed by L"C:\\users\\Public\\Application Data\\Ableton\\Live 9 Suite\\Program\\VideoExportMMF.dll") not found err:module:import_dll Library MFPlat.DLL (which is needed by L"C:\\users\\Public\\Application Data\\Ableton\\Live 9 Suite\\Program\\VideoExportMMF.dll") not found and they're part of Microsoft Media Foundation ... And just after IFileDialog returns with valid data, the application crash and we can see on the output: fixme:commdlg:IServiceProvider_fnQueryService Interface {e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service {e07010ec-bc17-44c0-97b0-46c7c95b9edc} fixme:shell:ViewModeToListStyle ViewMode 0 not implemented fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a003, 0, 0x23d5b8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a004, 0, 0x23d5b8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a003, 1, 0x23d5b8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a004, 1, 0x23d5b8) fixme:nstc:NSTC2_fnSetControlStyle2 mask & style (0x00000004) contains unsupported style(s): 0x00000004 fixme:commdlg:IServiceProvider_fnQueryService Interface {e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service {e07010ec-bc17-44c0-97b0-46c7c95b9edc} fixme:shell:ViewModeToListStyle ViewMode 0 not implemented fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a003, 0, 0x23d248) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a004, 0, 0x23d248) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a003, 1, 0x23d248) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a004, 1, 0x23d248) fixme:shell:IShellBrowser_fnOnViewWindowActive stub, 0xea510 (0x1574fa60) fixme:commdlg:IServiceProvider_fnQueryService Interface {e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service {e07010ec-bc17-44c0-97b0-46c7c95b9edc} fixme:shell:ViewModeToListStyle ViewMode 0 not implemented fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a003, 0, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a004, 0, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a003, 1, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a004, 1, 0x23d3a8) fixme:shell:IShellBrowser_fnOnViewWindowActive stub, 0xea510 (0xef860) fixme:commdlg:IServiceProvider_fnQueryService Interface {e07010ec-bc17-44c0-97b0-46c7c95b9edc} requested from unknown service {e07010ec-bc17-44c0-97b0-46c7c95b9edc} fixme:shell:ViewModeToListStyle ViewMode 0 not implemented fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a003, 0, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1026, a004, 0, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a003, 1, 0x23d3a8) fixme:shell:IShellBrowser_fnSendControlMsg stub, 0xea510 (2, 1025, a004, 1, 0x23d3a8) fixme:shell:IShellBrowser_fnOnViewWindowActive stub, 0xea510 (0xeb240) fixme:dbghelp:elf_search_auxv can't find symbol in module So what do you think? Is MFPlat.dll and MFReadWrite.dll a good candidate? If so, how to implement the library? What are the guidelines? Thanks and happy Christmas, -- Alexandre Bique

2 1

Re: [PATCH] ddraw: add dsurface dimension tests, try 5
by Patrick Rudolph 25 Dec '13

25 Dec '13

How much physical memory does each test VM have ? more than 2 GByte ? On 64bit Windows I should be able to allocate 2GByte of virtual memory using the pagefile, shouldn't I ? Regards, Patrick Am 2013-12-14 13:10, schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new > failures. > Being a bot and all I'm not very good at pattern recognition, so I > might be > wrong, but could you please double-check? > Full results can be found at > https://newtestbot.winehq.org/JobDetails.pl?Key=3756 > > Your paranoid android. > > > === w2008s64 (64 bit ddraw4) === > ddraw4.c:5910: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w7pro64 (64 bit ddraw4) === > ddraw4.c:5910: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w2008s64 (64 bit ddraw2) === > ddraw2.c:5313: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w7pro64 (64 bit ddraw2) === > ddraw2.c:5313: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w2008s64 (64 bit ddraw1) === > ddraw1.c:4254: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w7pro64 (64 bit ddraw1) === > ddraw1.c:4254: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w2008s64 (64 bit ddraw7) === > ddraw7.c:5804: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e > > === w7pro64 (64 bit ddraw7) === > ddraw7.c:5804: Test failed: Creating an offscreen plain surface with > width 0x2001 and height 0xffff returned 8007000e

2 1

Re: infosoft/tests: Constify a character string
by Marvin 24 Dec '13

24 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3827 Your paranoid android. === wvista (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === w2008s64 (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === w7pro64 (32 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === w2008s64 (64 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed === w7pro64 (64 bit infosoft) === infosoft.c:183: Test failed: failed infosoft.c:197: Test failed: failed

1 0

COMDLG32: native color picker on mac os x
by Žiga Željko 23 Dec '13

23 Dec '13

Hello, I have made a patch for comdlg32 on Mac OS X that replaces Wine's own color picker dialog with the native one. Bellow are the sources for colordlg.c, cocoa_colordlg.m and Makefile.in (without comments). -------------------- colordlg.c -------------------- static BOOL ChooseColor_CocoaCommon(COLORREF *color, BOOL init); BOOL WINAPI ChooseColorW( CHOOSECOLORW *lpChCol ) { if (!lpChCol) return FALSE; return ChooseColor_CocoaCommon(&lpChCol->rgbResult, lpChCol->Flags & CC_RGBINIT); } BOOL WINAPI ChooseColorA( LPCHOOSECOLORA lpChCol ) { if (!lpChCol) return FALSE; return ChooseColor_CocoaCommon(&lpChCol->rgbResult, lpChCol->Flags & CC_RGBINIT); } struct RGBColor { unsigned short red; unsigned short green; unsigned short blue; }; int cocoa_run_color_dialog_modal(struct RGBColor *color); static BOOL ChooseColor_CocoaCommon(COLORREF *color, BOOL init) { struct RGBColor rgb = { 0, 0, 0 }; if (init) { rgb.red = GetRValue(*color) * 257; rgb.green = GetGValue(*color) * 257; rgb.blue = GetBValue(*color) * 257; } BOOL ret = cocoa_run_color_dialog_modal(&rgb); if (ret) *color = RGB(rgb.red / 257, rgb.green / 257, rgb.blue / 257); return ret; } -------------------- cocoa_colordlg.m -------------------- #import <AppKit/AppKit.h> #import <Carbon/Carbon.h> int cocoa_run_color_dialog_modal(RGBColor *color) { __block int ret = 0; void (^block)(void) = ^{ ret = GetColor((Point){ 0, 0 }, (const unsigned char *)"Color", color, color); }; if ([NSThread isMainThread]) block(); else dispatch_sync(dispatch_get_main_queue(), block); return ret; } -------------------- Makefile.in -------------------- MODULE = comdlg32.dll IMPORTLIB = comdlg32 IMPORTS = uuid shell32 shlwapi comctl32 winspool user32 gdi32 advapi32 DELAYIMPORTS = ole32 EXTRALIBS = -framework AppKit -framework Carbon C_SRCS = \ cdlg32.c \ colordlg.c \ filedlg.c \ filedlg31.c \ filedlgbrowser.c \ finddlg.c \ fontdlg.c \ itemdlg.c \ printdlg.c RC_SRCS = comdlg32.rc SVG_SRCS = \ pd32_collate.svg \ pd32_landscape.svg \ pd32_nocollate.svg \ pd32_portrait.svg OBJC_SRCS = \ cocoa_colordlg.m IDL_R_SRCS = comdlg32_classes.idl @MAKE_DLL_RULES@ ------------------------------------------------------------ Any comments are welcome.

2 1

D3D command stream abandoned?
by Forest 23 Dec '13

23 Dec '13

I haven't seen any news of the command stream lately. The last thing I read was the mention of "more preparation work" in the 1.7.4 release announcement. Has the project been abandoned? I maintain a wine build for gamers, and currently have it frozen at version 1.7.1 with Stefan's September 2 command stream patches, because they seem to boost performance quite a bit for some folks. I'd love to get something more mature into my users' hands if it's available.

2 1

Re: add japanese man page(try 2)
by Akihiro Sagawa 23 Dec '13

23 Dec '13

On Fri, 20 Dec 2013 00:00:38 +0900, Akira Nakagawa wrote: > Subject: [PATCH] add japanese man page(try 2) Looks mostly fine. Please review following five points. 1. Changes for loader/Makefile.in was forgotten in try 2. 2. There were typos. Double punctuations, 「、、」 (two points) > +CUIの実行可能プログラム(Windows コンソールプログラム)を実行するには、、 > +は単にそれぞれ小さなヘルプメッセージ、、またはバージョン情報を表示して終了します。 3. Please don't use `タイプ' for different meanings. The former should be updated. > +はすべてのdll をロードするのに使用されるdll の上書きとロード順位のタイプを定義します。 > +Wineプロセスのアドレス空間にロードされるライブラリには現在2つのタイプがあります。 4. You added a space character after almost half-width characters, but some points not updated. For instance, you might need to add a space character after `X11'. > 使用するX11のディスプレイを指定します。 And you didn't insert a space character *before* a half-width character. Are they intentional? 5. There is still `.UE .' in the document. > +多くのアプリケーションのステータス報告が > +.UR http://appdb.winehq.org > +.B Wine Application Database > +にあります。 > +.UE . This should be: 多くのアプリケーションのステータス報告が .UR http://appdb.winehq.org .B Wine Application Database .UE にあります。 Regards, Akihiro Sagawa

1 0

Re: [2/4] taskschd: Add registration for TaskScheduler interfaces.
by Alexandre Julliard 23 Dec '13

23 Dec '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +[ > + threading(both), > + progid("Schedule.Service.1"), > + vi_progid("Schedule.Service"), > + uuid(0f87369f-a4e5-4cfc-bd3e-73e6154572dd) > +] > +coclass TaskService { interface ITaskService; } This should go in the public header, with the correct name. It's also supposed to be a typelib. -- Alexandre Julliard julliard(a)winehq.org

1 0

ldd for wine dll- Sorry for preview spell errors,
by 逸天不羁 23 Dec '13

23 Dec '13

hello every one, I have write a application just like ldd of GNU/Linux, I don't how to push it to the upstream. Here is the patchs.

3 2

Re: [PATCH] oleacc: Added DllGetClassObject() stub
by 中川祥 22 Dec '13

22 Dec '13

You need to add registry for it. And why don't you implement it? Some other dlls did it. 2013/12/22, Nikolay Sivov <nsivov(a)codeweavers.com>: > --- > dlls/oleacc/main.c | 6 ++++++ > dlls/oleacc/oleacc.spec | 1 + > 2 files changed, 7 insertions(+) > > >

2 1

ldd for wine dll---cpp codes removed
by 逸天不羁 22 Dec '13

22 Dec '13

hello, Every one , although we have the winedump, this little tool can be useful sometime. And I have remove all the cpp codes .

1 0

ldd for wine dll
by 逸天不羁 21 Dec '13

21 Dec '13

hell every one, I have write a application just like ldd of GNU/Linux, I don't how to push it to the upstream. Here is the patchs.

2 1

Fwd: ldd for wine dll
by David Quintana (gigaherz) 21 Dec '13

21 Dec '13

(forwarding to the list) ---------- Forwarded message ---------- From: David Quintana (gigaherz) <gigaherz(a)gmail.com> Date: 21 December 2013 12:16 Subject: Re: ldd for wine dll To: 逸天不羁 <yitianbuji(a)qq.com> Read this guide: http://wiki.winehq.org/SubmittingPatches On 21 December 2013 12:12, 逸天不羁 <yitianbuji(a)qq.com> wrote: > hell every one, > I have write a application just like ldd of GNU/Linux, I don't how to push > it to the upstream. Here is the patchs. > > > >

1 0

Re: [3/5] ntdll: Allow passing NULL buffer to printf functions
by Alexandre Julliard 20 Dec '13

20 Dec '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -72,7 +73,12 @@ static inline int pf_output_stringW( pf_output *out, LPCWSTR str, int len ) > > if( len < 0 ) > len = strlenW( str ); > - if( out->unicode ) > + if (!out->buf.X) > + { > + out->used += len; > + return len; > + } > + else if (out->unicode) That's not correct for Unicode conversions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] port: MSVC provides a correct getenv prototype.
by Stefan Dösinger 19 Dec '13

19 Dec '13

Am 19.12.2013 um 15:23 schrieb Jonas Maebe <jonas.maebe(a)elis.ugent.be>: > Shouldn't the title of this patch read "getopt" instead of "getenv"? Uh, now that you mention it, the title isn’t quite right. It should be more like "port: MSVC does not provide a conflicting getopt prototype." - It doesn’t provide a getopt prototype at all. The stdlib.h include is needed for getenv, which is used in the file. I misread the "getopt" in the comment as "getenv" on my quick read. (And yes, I did wonder how this code is supposed to work without defining getenv at all, but my conclusion was that maybe a warning about undefined getenv was considered better than a compile error. It makes a lot more sense with a conflicting getopt.) I took the liberty to CC wine-devel on my reply.

1 0

Re: taskschd: Add new dll.
by Saulius Krasuckas 18 Dec '13

18 Dec '13

* On Tue, 17 Dec 2013, Dmitry Timoshkov wrote: > 4 files changed, 123 insertions(+) > create mode 100644 dlls/taskschd/Makefile.in > create mode 100644 dlls/taskschd/taskschd.c > create mode 100644 dlls/taskschd/taskschd.spec Could you please tell what app does need it? I find zero bugs with the bugzilla query. [*] S. [*] http://bugs.winehq.org/buglist.cgi?query_format=advanced&longdesc=taskschd&…

3 3

Wine + ICC (Intel XE Compiler)
by jordan 18 Dec '13

18 Dec '13

Hey List, I've been playing around with ICC and i am curious if anyone has instructions and/or Patches for building Wine using Intel's XE Compiler?? ...I'm using the latest version; icc version 14.0.1 (gcc version 4.8.0 compatibility) I've noticed older link on winehq; http://wiki.winehq.org/icc ... It seems he was able to get wine32 to build on x86_64, but obviously, 2008 was a little early for wine64 / ICC tests... Currently, it doesn't get to far through configure; checking for gcc... icc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether icc accepts -g... yes checking for icc option to accept ISO C89... none needed checking whether we are using the GNU C++ compiler... yes checking whether icpc accepts -g... yes checking for cpp... cpp checking whether icc supports __builtin_ms_va_list... no configure: error: You need gcc >= 4.4 to build Wine as 64-bit. (and then it terminates). ICC is setup properly on my machine(s), ie: i have used it to compile other packages. (mostly 64bit, but i did test 32bit, which worked fine too). Anyway, If anyone has any tips and/or patches they could share, I would be very grateful / interested. :) ... Jordan

3 4

Launchpad project for Wine
by Tae Wong 18 Dec '13

18 Dec '13

There's a Launchpad project for Wine: https://launchpad.net/wine But there's a misspelling: ...a compatability layer... It says compatability instead of compatibility. The account https://launchpad.net/~seotaewong40 has been disabled. How to enable this account to file bugs? When trying to visit the page, it says: Page gone. There’s no page with this address in Launchpad. If this is blocking your work, let us know by asking a question at Launchpad Support . Otherwise, complain to the maintainers of the page that linked here.

2 1

Travel sponsorship for Wine to FOSDEM
by Jeremy White 17 Dec '13

17 Dec '13

Folks, I neglected to put this out there, but the Wine party fund is able to provide travel sponsorships for Wine contributors (where contributors is not limited to programmers, and can be fairly loosely defined). If you are interested in such a sponsorship, please write me privately. We could still use some novel presentations in our dev room; so if you want to get sponsored to come talk about Wine users or pitch the use of Wine on the lunar lander, I'd be delighted by the combination. Cheers, Jeremy

1 0

Re: [PATCH] msxml3: Store document url in properties so every instance could see it
by Marvin 17 Dec '13

17 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3762 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: taskschd: Add new dll.
by Nikolay Sivov 17 Dec '13

17 Dec '13

On 12/17/2013 13:30, Dmitry Timoshkov wrote: > +WINE_CONFIG_DLL(taskschd,,[implib]) Does it really need implib?

1 0

Re: winemenubuilder: Return error for missing link in InvokeShellLinkerForURL function
by Dmitry Timoshkov 16 Dec '13

16 Dec '13

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > --- a/programs/winemenubuilder/winemenubuilder.c > +++ b/programs/winemenubuilder/winemenubuilder.c > @@ -3030,7 +3030,7 @@ static BOOL InvokeShellLinkerForURL( IUniformResourceLocatorW *url, LPCWSTR link > if ( !link ) > { > WINE_ERR("Link name is null\n"); > - return TRUE; > + return FALSE; > } This doesn't follow the behaviour of other failure cases in this helper. -- Dmitry.

2 1

Re: [PATCH] ddraw: add dsurface dimension tests, try 5
by Stefan Dösinger 15 Dec '13

15 Dec '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-12-14 12:34, schrieb Patrick Rudolph: > + /* Test maximum surface width */ + memset(&desc, 0, > sizeof(desc)); + desc.dwSize = sizeof(desc); + desc.dwFlags = > DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH; + desc.ddsCaps.dwCaps |= > DDSCAPS_OFFSCREENPLAIN; + desc.dwHeight = 1; + desc.dwWidth = > 0xffff; + ret = IDirectDraw_CreateSurface(lpDD, &desc, > &dsurface, NULL); + if(!(ddcaps.ddsCaps.dwCaps & > DDSCAPS_VIDEOMEMORY)) + { + ok(ret == > DDERR_INVALIDPARAMS, "Creating an offscreen plain surface with > width 0xffff and height 1 returned %08x\n", ret); + } + else > + { + todo_wine ok(ret == DD_OK, "Creating an offscreen > plain surface with width 0xffff and height 1 returned %08x\n", > ret); + } I found the reason for this behavior. Some drivers seem to have a pitch limit of slightly under 128kb, specifically 131008 bytes. If you use a P8 pixel format here, the test passes on at least my Nvidia machine with this behavior. The same machine still has the 0xffff width limitation. So a 0x10000 width P8 surface isn't allowed, even though the pitch stays below the limit. I guess you could test for the pitch limit by setting DDSD_PITCH, either in CreateSurface, if it works, or pass it to SetSurfaceDesc. I don't think we have to test this unless we know an application that depends on this limitation - which I guess is unlikely because not all Windows drivers have it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSrZ1sAAoJEN0/YqbEcdMw6S0P/iZxvm5yH7hVoRJySKTtlDdD JB5JgGnG64ghBFX3SNRY38WP5iJT/Sgq2J8ueN2m/J5r83Ms7gtVz/2e0dm8ENgs MI2ln+0rXeC9vIAXNaM3VRTLKoOKql3sYSXEGvQNPtS56kvENz/2Mgfk00d6MfTJ 7tVtrgqfewR4KUjRzPnVDZO1Ofu4SiILFIYV75qAPO0ZQbEpqJGhxxJqoBYhpcpR GM9bD+4zajM9NJhZR4w3G8p23JVpUySso3xEXiV9RL16SvODnedf5o69wEB6ihyl zbSoyvntqDDiFkUSbrjPdu89TNVJ9vYRQsxEm/56P6DtN9SqHkQpQVBAFC370Tbd fAHQQWVnG0yr7/YAhRcB5+8hoyeX7H8p5Vk8nbcYNNQouKFVLMmRICGoaRLHPnqC 7cnrXw6/fL583FgsnevuX/n+ENsqwa7OkkVzlNLm746SPTnF1I+14ERHe8ADh25l 3ushOkUCJvQISDmRAzV0T4m8if6ljMPIIfMCPR0xNDTAFt5tBcYaHexw0GOh9UCD jGp9d6NYRuEf49jH3oYwVcdleGY8e1HrhT/N/s8pbMIWctgu/1s3RAERy5DEd8Hl otUR9I4DbCD4qWcaF3tW1K3syL8E3UTYjzlQ1GBlc018MsaIfebH7ds44oE1tVgk m0KcynUFCzigbONka3IB =XDx8 -----END PGP SIGNATURE-----

1 0

Re: add japanese man page
by Akihiro Sagawa 15 Dec '13

15 Dec '13

On Thu, 12 Dec 2013 16:57:58 +0900, Akira Nakagawa wrote: > diff --git a/loader/wine.ja.UTF-8.man.in b/loader/wine.ja.UTF-8.man.in > new file mode 100644 > index 0000000..8c6f851 > --- /dev/null > +++ b/loader/wine.ja.UTF-8.man.in Great work! Updated man page is almost good. This includes much improvements from previous one. But some issues are remain. Typical issue is line length. Because groff, used for formatting man-pages, doesn't handle Japanese non-spacing line-breaking well. I have two suggestions about this: 1. Insert a space character between half-width character and full-width one. e.g. Windows のプログラムを Unix で実行します 2. Insert a space character between English words. e.g. Windows コンソールプログラム Other (mistranslation, nit-picking) issues as follows. > +.SH 説明 > +.B wine > +は引数に指定されたDOS、Windows > +3.X、 Win32またはWin64の実行可能なプログラムを読み込んで実行します(64bitシステム上の場合)。 How about reorder parenthesis text near by Win64? I feel a reader can't find where the end parenthesis depends on. In other words, he or she can't find out what application can be run on 32-bit systems. Please use 「64-bit」 like others, but I prefer 「64 bit」(without hyphen) or 「64ビット」(translate `bit' to Japanese transcription). > +CUIの実効可能プログラム(Windowsコンソールプログラム)を実行するには, > +.BR wine の代わりに > +.B wineconsole > +を使用してください。 Conversion error: 実効可能 -> 実行可能 Last comma, 「実行するには,」, should be Japanese punctuation mark. > +これはすべての出力を別々のウィンドウに出力します(これを実行するには > +X11が必要です)。 CUIプログラム用の > +.B wineconsole > +は非常に制限されたコンソールのサポートを提供するだけで、 > +プログラムはおそらく正しく機能しないでしょう。 The original text says `Not using wineconsole... ', but your translation says `wineconsole for CUI programs provides...'. > +.PP > +.B --help > +または > +.B --version > +だけを引数として実行した場合、 > +.B wine > +はただ小さなヘルプメッセージまたはバージョン情報をそれぞれ表示して終了します。 A reader might not get a meaning at the first reading. Because 「ただ」(simply)～「表示して」(print) are separated in the translation. > +.B wine > +を実行する際にコマンドラインの最後尾に実行するプログラムの引数を付け加えることで、 > +そのプログラムに引数を渡すことができます。 > +(例えば: \fIwine notepad C:\(rs\(rsTEMP\(rs\(rsREADME.TXT\fR). > +注:シェル上でWineを実行する際には、 > +エスケープシーケンス「\(rs」(とスペース)を付ける必要があります。 I think this is misleading. The original text mentions the need for escaping, and that is for special characters and spaces (because this might not be a character). Your translation just says need to add escape-sequence '\' (and spaces). > +.TP > +.B WINESERVER > +.B wineserver > +のパスと名前を指定します。 > +binary. これを指定しない場合、Wineは > +.IR @bindir@/wineserverを > +ロードしようとします。 Delete `binary.', please. > +.TP > +.B WINELOADER > +が新しいWindowsプロセスを立ち上げるためには > +.B wine > +のバイナリのパスと名前を指定します。 This text is unnatural and wrong. > .PP > .I クラス > はオプションで、次のいずれかです。 > .BR err > .BR warn > .BR fixme > .BR trace Please add punctuations for each keywords, and use a column at the end of the sentence. > +If > +.I クラス > +が指定されない場合、指定されたチャンネルのすべてのデバッグメッセージが表示されるようになります。それぞれのチャンネルは固有のWineのメッセージを出力します。 Please delete `If.' line. > +.TP > +WINEDEBUG=warn+dll,+heap > +はDLLの警告メッセージとすべてのヒープメッセージ有効にします。 > +.br メッセージ有効に --> メッセージを有効に > +.TP > +.B WINEDLLOVERRIDES > +はすべてのdllをロードするのに使用されるdllの上書きとロード命令のタイプを定義します。 You might think there is a load instruction type, but the original just says [override type] and [load order]. So, there is no types for load order. Additionally, in this case, I prefer to use 「ロード順序(=load sequence)」 for translating `load order', not 「ロード命令(=load directive)」. > +現在2つのタイプのWineプロセスのアドレス空間にロードされるライブラリがあります。 A reader might not get a meaning at the first reading. How about reordering like this? 「Wineプロセスのアドレス空間にロードされるライブラリには現在2つのタイプがあります。」 > +つまり、ネイティブのwindows dll.RI ( native ") とWine内蔵版dlls (" builtin )です。 This line needs to break before `.RI'. Plural word (dlls) is not common in Japanese text, please use `Wine内蔵版dll'. > +Ｗindowsのサポートするアーキテクチャを指定します。この変数は The first `W' is full-width form, please use half-width form like others. > +.TP > +OSSのサウンドドライバを設定する変数 A colon is needed at the end of this line. > .SH 製作者 > Wineは多くの開発者の働きによって成り立っています。製作者を一覧するには、ソースディストーションの最上層ディレ > クトリにあるテキストファイル > .I AUTHORS > を参照してください。 Unknown word: ディストーション (distortion?) Please reconsider to use this word. > +WineはLGPLライセンスの下で発布されています。ライセンスのコピーは Less commonly usage. Please consider to use following words, `発布' (distribute) -> `配布' `コピー' (copy) -> `写し' > +バグ報告は > +.UR http://bugs.winehq.org > +.B Wine bug tracker > +で行えます。 > +.UE . There is a redundant dot at the end of the sentence. How about changing as following: バグ報告は .UR http://bugs.winehq.org .B Wine bug tracker .UE で行えます。 > +最新のバージョンの > +.B wine > +はWineHQ > +.UR http://www.winehq.org/ > +.B Wine development headquarters > +から入手できます。 > +.UE . ditto. Regards, Akihiro Sagawa

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 5
by Stefan Dösinger 14 Dec '13

14 Dec '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks for your persistence on this issue. I'll try to run those tests on some of my Windows machines to spot any card / driver dependent results. Some of your tests could be fragile, but I'll have a better opinion on that after trying them myself. Overall, you could reduce the number of lines of code here by organizing the test data in a table. Try something like static const struct { DWORD flags, width, height; HRESULT expect_hr; } test_data[] = { {DDSD_HEIGHT, 0, 128, DDERR_INVALIDPARAMS}, {DDSD_WIDTH, 128, 0, DDERR_INVALIDPARAMS}, {DDSD_WIDTH | HEIGHT, 128, 128, DD_OK}, {DDSD_WIDTH | HEIGHT, 0, 128, DDERR_INVALIDPARAMS}, {DDSD_WIDTH | HEIGHT, 128, 0, DDERR_INVALIDPARAMS}, etc. } Some things, like the video memory size exhaustion checks and the primary surface size checks are hard to handle this way. You can keep them in separate code blocks. Here are a few more issues, mostly minor style points: > + IDirectDrawSurface *dsurface = NULL; + IDirectDraw *lpDD; Please don't use the hungarian notation. I recommend to use the names ddraw and surface. > + ok(ret == DDERR_INVALIDPARAMS, "Creating an offscreen plain surface without a size info returned %08x (dsurface=%p)\n", ret, dsurface); This is a minor issue, but please add interpunctuation for consistency's sake. I don't think there's a reason to write dsurface here, other tests already establish that it should be NULL in case of an error. > + if(dsurface) + { + trace("Surface at %p\n", > dsurface); + IDirectDrawSurface_Release(dsurface); + > dsurface = NULL; + } The trace looks like it is a debugging leftover. > + /* Sanity check */ + memset(&desc, 0, sizeof(desc)); + > desc.dwSize = sizeof(desc); + desc.dwFlags = DDSD_CAPS | > DDSD_HEIGHT | DDSD_WIDTH; + desc.ddsCaps.dwCaps |= > DDSCAPS_OFFSCREENPLAIN; + desc.dwHeight = 128; + desc.dwWidth > = 128; + ret = IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, > NULL); This isn't really necessary, if surface creation fails here many other tests wouldn't work. If you use a test data table like described above I'd leave it in to make sure the test loop works properly. > + desc.dwHeight = 1; + desc.dwWidth = 0xffff; + ret = > IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, NULL); + > if(!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) + { + > ok(ret == DDERR_INVALIDPARAMS, "Creating an offscreen plain surface with width 0xffff and height 1 returned %08x\n", ret); > + } + else + { + todo_wine ok(ret == DD_OK, > "Creating an offscreen plain surface with width 0xffff and height 1 returned %08x\n", ret); > + } You can drop the curly brackets here, the existing code doesn't use them for single-line code blocks. (Well, mostly. It's not entirely consistent). I don't really like the DDSCAPS_VIDEOMEMORY check. I'll see how my Windows boxes behave, then we'll know if there's any deeper relationship between software-only ddraw and a maximum surface size. > + ret = IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, > NULL); + todo_wine ok(ret == DDERR_INVALIDPARAMS, "Creating an > offscreen plain surface with width 0x10000 and height 1 returned %08x\n", ret); > + if(dsurface) + { + > IDirectDrawSurface_Release(dsurface); + dsurface = NULL; + > } If all possible paths expect a failure from CreateSurface, there's no need to try to release the surface. Just leak it, the test fails anyway. > + ret = IDirectDraw_SetCooperativeLevel(lpDD, NULL, > DDSCL_NORMAL); + ok(ret == DD_OK, "SetCooperativeLevel failed > with %08x\n", ret); I don't think this is needed. Also, is there a reason why you're not passing the window to the first SetCooperativeLevel call? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSrIlaAAoJEN0/YqbEcdMw48UP/R686XgOaYmgwxP23u5AUpM2 +zemL+zkTAmQdLXA0yrFTmXvQcEvJtd1j7Pbg32hCh1P4X27ygBO5L+XJ4oxfTwH ymYYyIJsU96iTIDqojOlqzAvQ/Z/aibIfrfmviWx0LIClUymu5+VWYgYmONqbf5p QAkVrAV12DRrQq1sJPXoqSZDaDvtsuj5hjuZbGdZBoP0vJygl+yZXgxdNsrfDh3l TIRrYyETdWdCFjjxEbJyFeB6lrFweAHOel54cuvAlGjErlSczdj8oCMGoHHGtnNr JOD5dK0LI1o9ngkbmIMSHfRo4Sk6Ug6476B9zNR/fETRXsBEPCVQfWoUIV3h0RI0 RjX5NMFRHANYRjXSQd8yXcpdyNWYONu0BhyBrMnHBNln+CpXyUJ8PM0nMptnVSKD 1fWzQfnQNnaklxYuHVvSuVctOPLmbf5PIHNSE333Xj0ddDA2uCtEzOkSH1aMStjV TMZUa7ggY0wCjeLP1NKOY6jN7ExhANx8ItzXn4h8n9eWNMyqJXi9kpfiVGJA9/v8 /Xmi2nWivBBWUh8qq5nPUGnWcLgeKuvFTobGq3jUbCYEf3/T7sZz58xuFdAp/xUt Yzg2ztvP9DUi8BuJuk51c0dtujgtIRMKkNCG/ISe7za2QhGloAGs0T/LWdUmrTxo ++uOj6zpdlFWCapAen6e =13rk -----END PGP SIGNATURE-----

1 1

Re: [PATCH] ddraw: add dsurface dimension tests, try 5
by Marvin 14 Dec '13

14 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3756 Your paranoid android. === w2008s64 (64 bit ddraw4) === ddraw4.c:5910: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w7pro64 (64 bit ddraw4) === ddraw4.c:5910: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w2008s64 (64 bit ddraw2) === ddraw2.c:5313: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w7pro64 (64 bit ddraw2) === ddraw2.c:5313: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w2008s64 (64 bit ddraw1) === ddraw1.c:4254: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w7pro64 (64 bit ddraw1) === ddraw1.c:4254: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w2008s64 (64 bit ddraw7) === ddraw7.c:5804: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e === w7pro64 (64 bit ddraw7) === ddraw7.c:5804: Test failed: Creating an offscreen plain surface with width 0x2001 and height 0xffff returned 8007000e

1 0

Re: Ken Thomases : user32: Respect monitor work area when sizing or moving a top-level window.
by Ken Thomases 14 Dec '13

14 Dec '13

Hi Alexandre, This doesn't do the same thing as what I submitted. May I ask why you changed it? For instance, you shouldn't be able to drag the title bar even partially behind the menu bar. On Windows, I don't believe you can drag the title bar partially off the top of the screen. I'm certain that, if you position the task bar at the top of the screen, you can't drag the title bar partially behind it, either. (I tested both but my memory of the former isn't certain.) -Ken On Dec 13, 2013, at 12:46 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 03f8f85ddae0cb7d7ff85d0478f1d9a77c88b26b > URL: http://source.winehq.org/git/wine.git/?a=commit;h=03f8f85ddae0cb7d7ff85d047… > > Author: Ken Thomases <ken(a)codeweavers.com> > Date: Thu Dec 12 16:49:48 2013 -0600 > > user32: Respect monitor work area when sizing or moving a top-level window. > > This prevents dragging a window's title bar behind a menu bar across the top > of a screen, for example. > > --- > > dlls/user32/winpos.c | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c > index 22ee290..7cae0ad 100644 > --- a/dlls/user32/winpos.c > +++ b/dlls/user32/winpos.c > @@ -2625,6 +2625,7 @@ void WINPOS_SysCommandSizeMove( HWND hwnd, WPARAM wParam ) > BOOL moved = FALSE; > DWORD dwPoint = GetMessagePos (); > BOOL DragFullWindows = TRUE; > + HMONITOR mon = 0; > > if (IsZoomed(hwnd) || !IsWindowVisible(hwnd)) return; > > @@ -2673,6 +2674,7 @@ void WINPOS_SysCommandSizeMove( HWND hwnd, WPARAM wParam ) > { > parent = 0; > mouseRect = get_virtual_screen_rect(); > + mon = MonitorFromPoint( pt, MONITOR_DEFAULTTONEAREST ); > } > > if (ON_LEFT_BORDER(hittest)) > @@ -2749,6 +2751,24 @@ void WINPOS_SysCommandSizeMove( HWND hwnd, WPARAM wParam ) > pt.y = max( pt.y, mouseRect.top ); > pt.y = min( pt.y, mouseRect.bottom ); > > + if (!parent) > + { > + HMONITOR newmon; > + MONITORINFO info; > + > + if ((newmon = MonitorFromPoint( pt, MONITOR_DEFAULTTONULL ))) > + mon = newmon; > + > + info.cbSize = sizeof(info); > + if (mon && GetMonitorInfoW( mon, &info )) > + { > + pt.x = max( pt.x, info.rcWork.left ); > + pt.x = min( pt.x, info.rcWork.right ); > + pt.y = max( pt.y, info.rcWork.top ); > + pt.y = min( pt.y, info.rcWork.bottom ); > + } > + } > + > dx = pt.x - capturePoint.x; > dy = pt.y - capturePoint.y; > > > >

2 1

Re: wined3d: Ensure wined3d_ftoa() exponent is 2 digits on Windows.
by Henri Verbeet 14 Dec '13

14 Dec '13

On 14 December 2013 06:28, Jonathan Liu <net147(a)gmail.com> wrote: > > This fixes a regression introduced by commit > 12f16f2127ffce9a05eedf008c3aa3732751a7e3 where the returned exponent > is 3 digits on Windows instead of 2 digits which results in rendering > errors. The printf implementation in the Microsoft Visual C runtime > uses three digits for the exponent by default. > If the issue here is that the buffers the callers pass are too small, I think that's what should be fixed, perhaps with a comment added to wined3d_ftoa(). Ideally we wouldn't use fixed size buffers there to begin with though.

1 0

Re: winealsa.drv: midiSeq must be protected by a mutex
by Alexandre Julliard 13 Dec '13

13 Dec '13

Alexandre Bique <bique.alexandre(a)gmail.com> writes: > @@ -95,6 +95,7 @@ static int MODM_NumDevs = 0; > /* this is the total number of MIDI out devices found */ > static int MIDM_NumDevs = 0; > > +static CRITICAL_SECTION midiSeqLock = { NULL, -1, 0, 0, 0, 0 }; Please add debug information like it's done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bugzilla attachment links arriving with &action=edit
by Bruno Jesus 13 Dec '13

13 Dec '13

Hi all, since the update yesterday all links in emails received from the bugzilla have the action=edit so it's not no longer possible to directly open the attachements. Examples: --- Comment #8 from The Source <xxx(a)mail.ru> --- Created attachment 46837 --> http://bugs.winehq.org/attachment.cgi?id=46837&action=edit Launcher log (local.log) --- Comment #1 from Bruno Jesus <xxx(a)gmail.com> --- Created attachment 46835 --> http://bugs.winehq.org/attachment.cgi?id=46835&action=edit standard output --- Comment #3 from Travis Greenman <xxx(a)cartman-2000.net > --- Created attachment 46833 --> http://bugs.winehq.org/attachment.cgi?id=46833&action=edit Console output, with gl error and nvidia-smi output. Regards, Bruno

8 11

Re: [PATCH 3/5] ddraw: Change surface pitch before width.
by Henri Verbeet 13 Dec '13

13 Dec '13

On 13 December 2013 12:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + switch(hr) > + { > + case WINED3DERR_INVALIDCALL: > + wined3d_mutex_unlock(); > + return DDERR_INVALIDPARAMS; > + default: > + break; /* Go on */ > + } That's called hr_ddraw_from_wined3d(). On its own this patch is perhaps innocent enough, but it looks like this is supposed to make 4/5 safe, in which case that patch ends up depending on a somewhat obscure implementation detail. I think it may be better to merge wined3d_surface_set_mem() into wined3d_surface_update_desc(), at least as far as the public interface is concerned. (And in the long term we really want that to be wined3d_texture_update_desc().)

2 3

Re: [PATCH] ddraw: add dsurface dimension tests, try 4
by Marvin 13 Dec '13

13 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3751 Your paranoid android. === build (build) === Patch failed to apply

1 0

Firefox says mirrors.ibiblio.org is a reported attack page
by Rosanne DiMesio 13 Dec '13

13 Dec '13

A forum user reported that they got a "Reported Attack Page!" warning when they tried to download the Wine source tarball from mirrors.ibiblio.org. I checked, and I got the warning from Firefox, too. Chrome and Opera don't have a problem going to the site from the link here, but googling ibiblio.org brings up a warning that "This site may harm your computer" in all three browsers. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: kernel32/tests: Remove some expected values for test_DeleteFileA()
by Dmitry Timoshkov 12 Dec '13

12 Dec '13

Zhenbo Li <litimetal(a)gmail.com> wrote: > There're too many expected values from GetLastError(), and I think it > might be confusing. Usually there was a reason why there are so many different results in ok() statements, it would be a good idea to check git history and find out that reasons it out instead of simply declaring them as confusing and removing them altogether. -- Dmitry.

2 1

Re: [3/4] secur32/tests: Add a test for QueryCredentialsAttributes(SECPKG_CRED_ATTR_NAMES). Take 2.
by Nikolay Sivov 12 Dec '13

12 Dec '13

On 12/12/2013 09:13, Dmitry Timoshkov wrote: > + > + st = pQueryCredentialsAttributesA(&cred, SECPKG_CRED_ATTR_NAMES, &names); > + ok(st == SEC_E_NO_CREDENTIALS || st == SEC_E_UNSUPPORTED_FUNCTION /* before Vista */, "expected SEC_E_NO_CREDENTIALS, got %08x\n", st); > + Second possible return code should be broken(), otherwise your code change in next patch won't make any effect on tests.

2 5

Re: [PATCH 3/6] d3d9/tests: Test user memory and getdc interaction.
by Henri Verbeet 11 Dec '13

11 Dec '13

On 11 December 2013 12:22, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + data = HeapAlloc(GetProcessHeap(), 0, sizeof(data) * 16 * 16); > + memset(data, 0xaa, sizeof(data) * 16 * 16); I think you meant "sizeof(*data)" here.

2 1

Re: [2/2] programs/msiexec: MSI service should report SERVICE_STOPPED when appropriate.
by André Hentschel 11 Dec '13

11 Dec '13

Am 11.12.2013 09:16, schrieb Dmitry Timoshkov: > --- > programs/msiexec/service.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/programs/msiexec/service.c b/programs/msiexec/service.c > index 4b72fe0..fdd29bd 100644 > --- a/programs/msiexec/service.c > +++ b/programs/msiexec/service.c > @@ -81,6 +81,8 @@ static BOOL UpdateSCMStatus(DWORD dwCurrentState, DWORD dwWin32ExitCode, > > static void WINAPI ServiceCtrlHandler(DWORD code) > { > + DWORD state = SERVICE_RUNNING; > + > WINE_TRACE("%d\n", code); > > switch (code) > @@ -89,13 +91,14 @@ static void WINAPI ServiceCtrlHandler(DWORD code) > case SERVICE_CONTROL_STOP: > UpdateSCMStatus(SERVICE_STOP_PENDING, NO_ERROR, 0); > KillService(); > + state = SERVICE_STOPPED; > return; Hi, setting the variable here seems to have no effect i just have seen that from the patch without a look at the code, so i still might be wrong...

1 0

Bugzilla emails in html format after update
by Bruno Jesus 11 Dec '13

11 Dec '13

Hi, after the bugzilla update today I started receiving all emais in html format even with the preferences set to text email (double checked). For some reason gmail/firefox uses very small fonts to display the bug comments in this new format and it's quite unreadable for me. Is anyone else receiving html emails even with text emails configured in preferences? Or is there any other preference that need to be changed in order to have the text emails back? Best wishes, Bruno

3 3

Re: [PATCH 2/5] wined3d: Recreate DIB sections in wined3d_surface_update_desc().
by Stefan Dösinger 11 Dec '13

11 Dec '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-12-11 14:32, schrieb Henri Verbeet: > Since commit 6bc69c271bf440b4ecad012dc57888fdffc075d5, the GDI > implementation assumes DIB sections always exist. Actually the idea behind this patch was that all paths that need a DIB section create one if necessary. Is there a place where that's not true? If it's about x11_copy_to_screen I think the better fix is calling surface_getdc from there. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSqHuLAAoJEN0/YqbEcdMwreEP/RCg6dr20bqTzc+P3HB+mvIO JCURzQz25PzWTnIn4+M3f8a/NcHP0Fu6621Te71Y2kk+be1ncIDMI9SAEAOzP4cW ELwmSlxgDUgZIx8w+cR8ce56Jg+ESesNEfPqwT7oWSVHnJqZnouo8IBp8xXCHc3K J+ACLw8PWZoorXg9YVVLrVWwEyxr1mamQE/35WlXEMRJ/6gqZwdML6bCY/wVJ/Vf 18lBebBy9aluiXKyuEUQA1rz1n4Ji7Cz6IFiK+TGGkiPk9WHJekG3tREI9LoT4Hi VFrktfl/3P1wNb4/ab2U0xjbVOPdtqHqSU6RWfB+jjI3VvzLjjtinI/5I5ip2f8u f7XFm8EV2+0czBjXwgaIouWYYEKIEE1wZKZBPjUU+RQUKfdohuSD/QCNC9E3uf7f qhR01J3M4O6z41RJGwBMBwI2lHsEQWZaj3rsryJzo2mxRoMvv/ksV7oB75mgPQaz jShTnEvs4SMFh9PMkANNpRVUWvVu0b27hUeIvlo2GbNDhJKsnll0YFQfL6eKm29y Kr7ltkqRoWyeA/2Q3IGBTFF0l1a1F9JAgZxy8SRqpykglfc0ekCazGhQUku0Vi1/ 1lvnzf2K9RkT5gIPlMmxuHTmEunc4wdk2T7SsEZK8htnMTqIyV+XoaSyjezg1K2R uDCAYLqI+6lx9j5r31xR =tLfE -----END PGP SIGNATURE-----

2 2

Re: [5/5] ws2_32: Move the buffer used by inet_ntoa into the per thread data.
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3722 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (4c0): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:520: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Re: [4/5] ws2_32/tests: Add a test for inet_ntoa called from two threads.
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3721 Your paranoid android. === wxppro (32 bit sock) === sock.c:520: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:520: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:520: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: [4/4] secur32: Make schannel implementation of QueryCredentialsAttributes(SECPKG_CRED_ATTR_NAMES) return SEC_E_NO_CREDEN
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3720 Your paranoid android. === wxppro (32 bit schannel) === schannel.c:305: Test failed: expected SEC_E_NO_CREDENTIALS, got 80090302 schannel.c:800: Test failed: expected SEC_E_NO_CREDENTIALS, got 80090302

1 0

Re: [3/4] secur32/tests: Add a test for QueryCredentialsAttributes(SECPKG_CRED_ATTR_NAMES).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3719 Your paranoid android. === wxppro (32 bit schannel) === schannel.c:306: Test failed: expected SEC_E_NO_CREDENTIALS, got 80090302 schannel.c:802: Test failed: expected SEC_E_NO_CREDENTIALS, got 80090302

1 0

Re: [PATCH 5/5] d3d9: shared_handle must be NULL in non-ex d3d9 (try 2).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3709 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9: Implement user memory for offscreen plain surfaces (try 4).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3708 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9: Buffers do not support user memory (try 4).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3707 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9: Volume and cube textures do not support user memory (try 4).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3706 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3705 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9: shared_handle must be NULL in non-ex d3d9.
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3704 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9: Implement user memory for offscreen plain surfaces (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3703 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9: Buffers do not support user memory (try 3).
by Marvin 11 Dec '13

11 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3702 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9: Volume and cube textures do not support user memory (try 3).
by Marvin 10 Dec '13

10 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3701 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/2] gdi32: Return ANSI character code as glyph index for bitmap fonts.
by Alexandre Julliard 10 Dec '13

10 Dec '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -5975,7 +5975,7 @@ static FT_UInt get_GSUB_vert_glyph(const GdiFont *font, UINT glyph) > return GSUB_apply_feature(header, feature, glyph); > } > > -static FT_UInt get_glyph_index(const GdiFont *font, UINT glyph) > +static FT_UInt get_glyph_index(const GdiFont *font, UINT glyph, BOOL ret_char_code) > { > FT_UInt glyphId; > It would be better to have a separate function instead of having the same function return two different types of index. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add taskschd.idl.
by Jacek Caban 10 Dec '13

10 Dec '13

Hi Dmitry, On 12/10/13 10:12, Dmitry Timoshkov wrote: > + HRESULT get_Connected([out, retval] VARIANT_BOOL *connected); > + HRESULT get_TargetServer([out, retval] BSTR *server); > + HRESULT get_ConnectedUser([out, retval] BSTR *user); > + HRESULT get_ConnectedDomain([out, retval] BSTR *domain); > + HRESULT get_HighestVersion([out, retval] DWORD *version); Those should use [propget] attribute instead of explicit get_* prefix. Same for other get_* and put_* methods (with [propput]). Cheers, Jacek

1 0

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 2).
by Henri Verbeet 10 Dec '13

10 Dec '13

On 10 December 2013 12:23, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @Henri: I'm not sure what kind of control flow you had in mind here. The > best understanding I could come up with was a nested if (first check for > D3DPOOL_DEFAULT, then handle the D3DPOOL_SYSTEMEM special case), which I > think is ugly. I removed the case check for D3DPOOL_SCRATCH, at the cost > of not writing a visible FIXME for pool 0x6. ... > if (shared_handle) > { > - if (pool == D3DPOOL_SYSTEMMEM) > + switch (pool) > { > - if (levels != 1) > + case D3DPOOL_DEFAULT: > + FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); > + break; > + > + case D3DPOOL_SYSTEMMEM: > + if (levels != 1) > + { > + WARN("Trying to create a mipmapped user memory texture.\n"); > + return D3DERR_INVALIDCALL; > + } > + set_mem = TRUE; > + break; > + > + default: > + WARN("Trying to create a texture with pool %#x and shared_handle %p.\n", > + pool, shared_handle); > return D3DERR_INVALIDCALL; > - set_mem = TRUE; > } > - else > - FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); > } > + { + if (pool != D3DPOOL_DEFAULT) + { + WARN("Trying to create a shared texture in pool %#x.\n", pool); + return D3DERR_INVALIDCALL; + } FIXME("Resource sharing not implemented, *shared_handle %p.\n", *shared_handle); + }

1 0

Re: [PATCH 1/5] d3d9/tests: Test user memory with D3DPOOL_SCRATCH (try 2).
by Marvin 10 Dec '13

10 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3700 Your paranoid android. === build (build) === Could not copy the patch to the VM: Unable to connect to testnet.winehq.org:22001:10.42.42.130:4242: No route to host

1 0

Implementing msvcrt.__CxxFrameHandler
by Alexandre Bique 09 Dec '13

09 Dec '13

Hi, I found that __CxxFrameHandler is not implemented for wine64, and I'd like to fix this because I think it is the reason why Ableton Live 9.1 is crashing at start up. If someone can implement it, then it is great! Otherwise if someone can give me guidelines, I can try to understand how it works and do it myself. Here is a previous email talking about this: http://www.winehq.org/pipermail/wine-devel/2011-April/089617.html Here is the bug about Ableton Live 9.1: http://bugs.winehq.org/show_bug.cgi?id=35092 Regards, -- Alexandre Bique

1 0

Re: [PATCH 1/4] d3d9/tests: Test user memory with D3DPOOL_SCRATCH.
by Henri Verbeet 09 Dec '13

09 Dec '13

On 9 December 2013 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The undocumented d3d9ex managed pool with enum value 6 does not allow > user memory textures either. I'm not including tests for that yet > until our d3d9 can handle this pool. I'm not quite sure I see the point of this test. The way the docs say this works is that in the general case resource sharing only works with default pool resources. Creating system memory textures with user memory backing is an exception to that. So I'd expect this test to fail in the first place because the resource is not in the default pool, and in the second place because the handle you're passing is most likely not a valid resource handle.

1 0

Re: [PATCH 2/4] d3d9: Volume and cube textures do not support user memory (try 2).
by Henri Verbeet 09 Dec '13

09 Dec '13

On 9 December 2013 13:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > if (shared_handle) > + { > + if (pool != D3DPOOL_DEFAULT) > + { > + WARN("User memory is not allowed on volume textures.\n"); Similarly, I don't think this warning really represent what's going on. The issue is that resource sharing is only allowed with default pool resources. (And quite possibly only on d3d9ex devices.)

1 0

Mobile version input methods (on-screen buttons, keyboards, virtual joysticks)
by WineBuG 08 Dec '13

08 Dec '13

How would you deal with lack of the keyboard and mouse in the future ARM (Android) version of Wine? Will one be able to add virtual on-screen buttons and joysticks in some way? Are you going to analyze controls solutions of other mobile apps (for example, games)? Regards, WineBuG

1 0

Build issues with winemac.drv and Mavericks
by C.W. Betts 08 Dec '13

08 Dec '13

I’ve run into issues when building winemac.drv on Mavericks. Attached is the log.

3 3

Mobile version input methods (on-screen buttons, keyboards, virtual joysticks)
by WineBuG 07 Dec '13

07 Dec '13

How would cope with lack of the keyboard and mouse in the future ARM (Android) version of Wine? Will one be able to add virtual on-screen buttons and joysticks in some way? Are you going to analyze other mobile apps (for example, games) controls solutions? Regards, WineBuG

1 0

Re: [PATCH] user32: Don't send message to get window text, avoid a deadlock.
by Dmitry Timoshkov 07 Dec '13

07 Dec '13

Qian Hong <qhong(a)codeweavers.com> wrote: > - Fixed http://bugs.winehq.org/show_bug.cgi?id=27282, affects Arcania: > Gothic 4 and online bank of abchina and > - Makes Anastasius happy :p This patch needs at least some tests. -- Dmitry.

2 1

Re: [PATCH 2/5] ole32: Simplify enumeration cloning using duplicated key
by Alexandre Julliard 06 Dec '13

06 Dec '13

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > - new_this->IEnumCATEGORYINFO_iface = This->IEnumCATEGORYINFO_iface; > - new_this->ref = 1; > - new_this->lcid = This->lcid; > - /* FIXME: could we more efficiently use DuplicateHandle? */ > - open_classes_key(HKEY_CLASSES_ROOT, keyname, KEY_READ, &new_this->key); > - new_this->next_index = This->next_index; > + cloned->IEnumCATEGORYINFO_iface = This->IEnumCATEGORYINFO_iface; > + cloned->ref = 1; > + cloned->lcid = This->lcid; > > - *ppenum = &new_this->IEnumCATEGORYINFO_iface; > + if (!DuplicateHandle(GetCurrentProcess(), This->key, GetCurrentProcess(), (HANDLE*)&cloned->key, 0, FALSE, DUPLICATE_SAME_ACCESS)) > + { > + IEnumCATEGORYINFO_Release(&cloned->IEnumCATEGORYINFO_iface); > + return E_FAIL; > + } Using DuplicateHandle is not a good idea on registry keys, particularly for HKEY_CLASSES_ROOT keys. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32/tests: Use GetVersion() to skip Timeout test (try 2)
by Nikolay Sivov 06 Dec '13

06 Dec '13

On 12/6/2013 09:10, Zhenbo Li wrote: > I'm using win_skip() for Vista&Win2008 this time. > > --- > dlls/shell32/tests/shlfileop.c | 36 +++++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 17 deletions(-) > > Hm, it's the same issue. Please don't use GetVersion().

1 0

Re: shell32/tests: Use GetVersion() to skip Timeout test (try 2)
by Marvin 06 Dec '13

06 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3671 Your paranoid android. === wvista (32 bit shlfileop) === Timeout === w2008s64 (32 bit shlfileop) === Timeout === w2008s64 (64 bit shlfileop) === Timeout

1 0

Re: wined3d: Use BOOL type where appropriate
by Henri Verbeet 06 Dec '13

06 Dec '13

On 5 December 2013 23:14, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > Note: in surface.c, used "?1:0" construct to avoid implicit BOOL arithmetic > --- > dlls/wined3d/arb_program_shader.c | 19 +++++++++---------- > dlls/wined3d/context.c | 20 ++++++++++---------- > dlls/wined3d/device.c | 2 +- > dlls/wined3d/gl_compat.c | 4 ++-- > dlls/wined3d/shader.c | 20 ++++++++++---------- > dlls/wined3d/stateblock.c | 22 +++++++++++----------- > dlls/wined3d/surface.c | 8 ++++---- > dlls/wined3d/utils.c | 8 ++++---- > 8 files changed, 51 insertions(+), 52 deletions(-) > I don't think so, most of these are bitfields, and the surface.c change is actually making the code worse.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel December 2013