wine-devel March 2013

wine-devel@winehq.org

73 participants
120 discussions

Re: winemac: fix compilation on Lion and later
by Ken Thomases 08 Mar '13

08 Mar '13

On Mar 7, 2013, at 4:15 PM, C.W. Betts wrote: > This patch defines __gltypes_h_ so that the Mac header doesn't get included. Thanks! -Ken

1 0

Re: [PATCH 1/7] winemac: Implement OpenGL support.
by C.W. Betts 07 Mar '13

07 Mar '13

It seems like there's conflicting types for GLhandleARB, one defined by Wine, the other by OS X, on Mountain Lion. I assume that the #define __gl_h_ is a try to work around the issue, but OS X's gltypes.h still gets included. On Mar 6, 2013, at 3:59 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/Makefile.in | 4 +- > dlls/winemac.drv/cocoa_opengl.h | 32 + > dlls/winemac.drv/cocoa_opengl.m | 154 ++++ > dlls/winemac.drv/cocoa_window.m | 187 ++++ > dlls/winemac.drv/gdi.c | 2 +- > dlls/winemac.drv/macdrv.h | 10 + > dlls/winemac.drv/macdrv_cocoa.h | 15 + > dlls/winemac.drv/opengl.c | 1912 +++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/window.c | 11 +- > 9 files changed, 2322 insertions(+), 5 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_opengl.h > create mode 100644 dlls/winemac.drv/cocoa_opengl.m > create mode 100644 dlls/winemac.drv/opengl.c > > <0001-winemac-Implement-OpenGL-support.patch>

2 3

Re: [2/2] winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO.
by Alexandre Julliard 07 Mar '13

07 Mar '13

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -25,6 +25,9 @@ > > #include "windef.h" > #include "winbase.h" > +#define USE_WS_PREFIX > +#include "winsock2.h" > +#include "ws2ipdef.h" > #include "winhttp.h" > #include "wincrypt.h" > #include "winreg.h" This breaks the Mingw build here: In file included from ../../../wine/dlls/winhttp/session.c:39:0: ../../../wine/dlls/winhttp/winhttp_private.h:124:29: error: field ‘sockaddr’ has incomplete type ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:238:66: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:594:44: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:596:21: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:598:10: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:598:10: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/winhttp/session.c:604:39: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:605:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:609:10: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:615:40: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:616:44: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:617:49: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:627:283: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: In function ‘request_query_option’: ../../../wine/dlls/winhttp/session.c:731:25: error: storage size of ‘local’ isn’t known ../../../wine/dlls/winhttp/session.c:732:9: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:746:9: warning: implicit declaration of function ‘getsockname’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:748:9: warning: passing argument 1 of ‘convert_sockaddr’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:594:13: note: expected ‘const struct sockaddr *’ but argument is of type ‘const struct sockaddr *’ ../../../wine/dlls/winhttp/session.c:731:25: warning: unused variable ‘local’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1230:63: warning: ‘struct sockaddr_in’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘printf_addr’: ../../../wine/dlls/winhttp/session.c:1233:15: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:1233:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1234:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1235:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1236:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1239:41: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c:1248:66: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘build_wpad_url’: ../../../wine/dlls/winhttp/session.c:1252:15: error: ‘NI_MAXHOST’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:20: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:35: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:63: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:80: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1259:5: warning: passing argument 1 of ‘reverse_lookup’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:1239:12: note: expected ‘const struct addrinfo *’ but argument is of type ‘const struct addrinfo *’ ../../../wine/dlls/winhttp/session.c:1252:10: warning: unused variable ‘name’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1205:14: warning: ‘get_computer_name’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1221:13: warning: ‘is_domain_suffix’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1230:13: warning: ‘printf_addr’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1248:15: warning: ‘build_wpad_url’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:630:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalConeLight
by Nozomi Kodama 07 Mar '13

07 Mar '13

hello Still problems with this patch? Nozomi.

2 1

wiki.winehq.org is down
by Michael Stefaniuc 07 Mar '13

07 Mar '13

Hey Dimi, the wiki is down: <puk> is the wiki down? <puk> it pings <puk> but with high latency <puk> and while port 80 connects a GET / doesn't returns thanks bye michael

1 0

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Sergey Guralnik 07 Mar '13

07 Mar '13

On 2013-03-04 10:39, Sergey Guralnik wrote: > This patch demonstrates the most interest case from previous > versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It stays queued since Monday without any reply. Is something wrong with it? -- Sergey

1 0

Re: Use accented letters in their names.
by Frédéric Delanoy 06 Mar '13

06 Mar '13

> On 3/4/13, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: >> On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: >>> The authors file is outdated and you want this updated with the >>> missing authors. Andrej Znidarsic should have Slovenian accented >>> letters for his last name. >>> >>> On 2/4/13, Tae Wong <seotaewong40(a)gmail.com> wrote: >>>> You will want to use accented letters in their authors names. >>>> >>>> Caolan McNamara >>>> Ferenc Wagner >>>> Marko Nikolic >>>> >>>> Every once and a while the GNOME Live website is down with an error on >>>> Netscape called “The operation timed out when attempting to contact .” >>>> - This paragraph should have a website name. You want to be unbanned >>>> in Amaterasu Translations and the DOS ain’t dead forums. >> >> Feel free to send a patch to wine-patches fixing those issues. >> On Wed, Mar 6, 2013 at 3:02 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: > You’ve sent a patch to wine-patches but never got them fixed! I didn't send a patch, but you did (well, sort of, this wasn't really a patch, but a mere email) See http://wiki.winehq.org/SubmittingPatches for instructions (http://source.winehq.org/patches/ helps you see what is the status of your patch, in this case 94687) Note however that this authors list is likely autogenerated from git.("John Doo <email address>") email addresses, so it's up to the patch submitter to correctly spell his/her own name to begin with. Rewriting the history to fix this seems overkill to me. Hence, if you fix the AUTHORS file, your changes might be overwritten the next time the file is generated. Frédéric

1 0

ntdll: make NtDelayExecution a bit more efficient
by Joerg-Cyril.Hoehle＠t-systems.com 06 Mar '13

06 Mar '13

You may try and find that MSDN or blog page where people explain the subtle differences of Sleep(0) and Sleep(1) on multi-core machines. Regards, Jörg Höhle

1 0

Re: [1/3] Make mac driver the default on OS X
by Ken Thomases 06 Mar '13

06 Mar '13

On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote: > --- > dlls/gdi32/driver.c | 102 +++++++++++++++++++++++++++++++++++++++++++-- > dlls/gdi32/gdi32.spec | 1 + > dlls/gdi32/gdi_private.h | 2 + > dlls/user32/driver.c | 27 ++++++------ > include/wine/gdi_driver.h | 11 +++++ > 5 files changed, 125 insertions(+), 18 deletions(-) > > <0001-Track-and-report-multiple-errors-loading-display-drive.txt> As I believe you're aware, I think that the Mac driver should not be made the default until OpenGL and clipboard support are in. So, maybe this was just submitted in preparation for that time, but there should probably have been a note to that effect. Also, this patch seems exceedingly complex for a relatively simple problem. Just because it has historically been user32 that reported failure to load the driver doesn't mean it must remain so, at least to my way of thinking. Why not just print out the diagnostics directly in gdi32 as each attempt to load a driver fails? In user32, there can be a secondary, driver-agnostic message about failure to create a window. > + case ERROR_DLL_INIT_FAILED: > + load_err->err_msg = "Make sure you have permission to create \na window or check for errors with Console.app. \n(The Mac driver cannot do remote display: try X11 if you need that.)"; > + break; "Make sure you have permission to create a window" doesn't mean anything to me. Checking Console.app isn't very useful either. If the user sees this message, then they're already looking at wherever the process's output is going. Running Wine from a shell won't write anything to the console logs. As of Mountain Lion, running it from a GUI app won't either; Apple changed things so that stdout and stderr of GUI apps go to /dev/null rather than console logs. (Only things like NSLog() or asl_log() go to the console log.) Probably it's just best to say that the Mac driver is running in a non-GUI session such as a remote login. -Ken

2 1

Re: qcap: Fix compilation on systems that have v4l1 but not VIDIOCMCAPTURE & co.
by Alexandre Julliard 06 Mar '13

06 Mar '13

Francois Gouget <fgouget(a)free.fr> writes: > In particular this fixes compilation on FreeBSD 8.1. > > configure | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 18 +++++++++++++ > dlls/qcap/v4l.c | 4 +-- > include/config.h.in | 3 +++ > 4 files changed, 97 insertions(+), 2 deletions(-) It's not very useful to add a configure check for a #define, you can check for it directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2013