June 2013 - wine-devel

Re: ntdll: Add stub for LdrResolveDelayLoadedAPI and reference it in kernel32
by Dmitry Timoshkov 10 Jun '13

10 Jun '13

André Hentschel <nerv(a)dawncrow.de> wrote: > diff --git a/include/delayloadhandler.h b/include/delayloadhandler.h > new file mode 100644 > index 0000000..e48e415 > --- /dev/null > +++ b/include/delayloadhandler.h I don't see such file in PSDK 7.1, where does it come from? > diff --git a/include/winnt.h b/include/winnt.h > index 171141e..393f5a7 100644 > --- a/include/winnt.h > +++ b/include/winnt.h > @@ -3052,6 +3052,28 @@ typedef struct _IMAGE_RELOCATION > > #define IMAGE_SIZEOF_RELOCATION 10 > > +typedef struct _IMAGE_DELAYLOAD_DESCRIPTOR > +{ > + union > + { > + DWORD AllAttributes; > + struct > + { > + DWORD RvaBased:1; > + DWORD ReservedAttributes:31; > + }; > + } Attributes; > + > + DWORD DllNameRVA; > + DWORD ModuleHandleRVA; > + DWORD ImportAddressTableRVA; > + DWORD ImportNameTableRVA; > + DWORD BoundImportAddressTableRVA; > + DWORD UnloadInformationTableRVA; > + DWORD TimeDateStamp; > +} IMAGE_DELAYLOAD_DESCRIPTOR, *PIMAGE_DELAYLOAD_DESCRIPTOR; > +typedef const IMAGE_DELAYLOAD_DESCRIPTOR *PCIMAGE_DELAYLOAD_DESCRIPTOR; Same question here about IMAGE_DELAYLOAD_DESCRIPTOR. Besides, the structure contains namesless structure which is not compatible with some compilers and needs to be fixed. -- Dmitry.

3 2

Main sources of Wine complexity
by Ivan 10 Jun '13

10 Jun '13

(short summary: why is emulation of Windows environment so difficult). First of all, my apologies if this is an off-topic question for this list but I hope it will be useful for others in the similar situation. I need to port fairly large WinAPI-heavy application to Linux. After some googling it becomes clear that there's nothing except for Wine/Winelib which is *huge*. However for at least most basic WinAPI functions it looks fairly easy to just re-implement it via Boost/STL/libc/Linux syscalls. Why there's nothing small like this already? Why only Wine with like 3 millions LoC and run-time dependencies? Is the approach described above make some sense for at least most common functionality (threading, IPC, file operations) w/o things like UI, graphics and registry. For instance, we need to either re-implement around 200 WinAPI functions (mostly events, mutexes, semaphore, sockets, file and folder operations) or to rewrite the entire thing from scratch. Using Winelib directly is not an option due to the nature of the app. Any help/advices are greatly appreciated. Thank you.

3 2

re: Main sources of Wine complexity
by Dan Kegel 10 Jun '13

10 Jun '13

>I need to port fairly large WinAPI-heavy application to Linux. After some >googling it becomes clear that there's nothing except for Wine/Winelib >which is *huge*. However for at least most basic WinAPI functions it looks >fairly easy to just re-implement it via Boost/STL/libc/Linux syscalls. Why >there's nothing small like this already? >... we need to either re-implement around >200 WinAPI functions (mostly events, mutexes, semaphore, sockets, file and >folder operations) or to rewrite the entire thing from scratch. Using >Winelib directly is not an option due to the nature of the app. I think there have been several such compatibility layers. http://chiharu.haun.org/peace/ for instance. Wine's the only one that has really tried tor run everything. Why can't you just bundle wine? - Dan

1 0

Re: [PATCH 1/1] wined3d: Explicitly use the C locale for generating shaders.
by Alexandre Julliard 10 Jun '13

10 Jun '13

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Specifically, we always want to use '.' as decimal separator. Reported on IRC. That's not very portable: x86_64-w64-mingw32-gcc -c -I../../../wine/dlls/wined3d -I. -I../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -Wno-format -g -O2 -o glsl_shader.o ../../../wine/dlls/wined3d/glsl_shader.c ../../../wine/dlls/wined3d/glsl_shader.c:92:5: error: unknown type name ‘locale_t’ ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_pshader’: ../../../wine/dlls/wined3d/glsl_shader.c:4695:5: warning: implicit declaration of function ‘uselocale’ [-Wimplicit-function-declaration] ../../../wine/dlls/wined3d/glsl_shader.c:4697:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c:4697:15: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_vshader’: ../../../wine/dlls/wined3d/glsl_shader.c:4771:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘find_glsl_geometry_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:4811:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_vertex_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:5662:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_find_ffp_fragment_shader’: ../../../wine/dlls/wined3d/glsl_shader.c:5685:15: error: ‘LC_GLOBAL_LOCALE’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c: In function ‘shader_glsl_alloc’: ../../../wine/dlls/wined3d/glsl_shader.c:6355:5: warning: implicit declaration of function ‘newlocale’ [-Wimplicit-function-declaration] ../../../wine/dlls/wined3d/glsl_shader.c:6355:36: error: ‘LC_ALL_MASK’ undeclared (first use in this function) ../../../wine/dlls/wined3d/glsl_shader.c:6410:9: warning: implicit declaration of function ‘freelocale’ [-Wimplicit-function-declaration] make: *** [glsl_shader.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] ole32: fixed 3 handle leaks (Coverity)
by Dmitry Timoshkov 10 Jun '13

10 Jun '13

Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1030106 Resource leak > 1030105 Resource leak > 1030104 Resource leak These cases are of the kind 'freeing resources at process exit is not useful'. -- Dmitry.

2 4

Re: [PATCH 2/2] d3dxof: Handle float in binary mode and remove code that becomes useless.
by Alexandre Julliard 07 Jun '13

07 Jun '13

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/parsing.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

1 0

joy.cpl icon
by Joel Holdsworth 07 Jun '13

07 Jun '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 For some reason, since I send in my icon for joy.cpl, it doesn't appear in the control panel - still only the wine glass fallback icon. Does anyone know why this is? I guess it will be a one line fix. Unfortunately I don't have time do this myself, but if someone has time, I think it would be worth resolving before the release. Best Regards Joel Holdsworth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRsFMgAAoJEIsWlGmq62Igf70H/jE97ibCOk2j2BMizaGkGzyW nAGQD0R9E3GXfdnGaUxzn21OPq3cu3/FapiTw1eN5Ns7Ec4b1cBLJ+ana1ElLIrO bz+yYGedqD0bYZq0D80MPE7t9S6jGy7939XGvkNLSMcZVOaBy8E2iroVnAILMNSB w1zbPhDXQGjHjRyBuYHZMhXTPhDz73s8+6JS7lZvCTaMmnF/dzZ6tW7DyTUIBdwx u3zUXn/j4nTNuNw3xGtK5wSYUZdNWxEx8RvQ1JrfuR9CWwLILTfFLB9d7OnSH/Rg 0sxBkjpSkOck25NN9gdQwdud0ERda1JurongrxUSHDXBBxghJ9BIk/gd+ZpP4cQ= =Hnk+ -----END PGP SIGNATURE-----

2 2

Re: wined3d: Add Mobility Radeon HD 4200
by Rico Schüller 06 Jun '13

06 Jun '13

On 30.05.2013 23:51, Kyle Luna wrote: > + {HW_VENDOR_AMD, CARD_AMD_RADEON_HD4200M, "ATI Mobility Radeon HD 4200", DRIVER_AMD_R600, 256 }, I think there are versions available which have only 128MB of graphics memory, see: http://de.wikipedia.org/wiki/ATI-Radeon-HD-4000-Serie (de) http://www.notebookcheck.com/ATI-Radeon-HD-4200.20492.0.html (de) I couldn't find this information on the English pages. I'm not sure how much we care about this. Cheers Rico

2 1

Re: user32: Fix icon extraction from non-native PE executables.
by Alexandre Julliard 06 Jun '13

06 Jun '13

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/user32/exticon.c | 202 ++++++++++++++++++++++++++++++++----------------- > 1 file changed, 133 insertions(+), 69 deletions(-) > > diff --git a/dlls/user32/exticon.c b/dlls/user32/exticon.c > index 5b9d681..e6e97d5 100644 > --- a/dlls/user32/exticon.c > +++ b/dlls/user32/exticon.c > @@ -251,6 +251,127 @@ static BYTE * ICO_GetIconDirectory( LPBYTE peimage, LPicoICONDIR* lplpiID, ULONG > return 0; > } > > +/* caller must make sure we have a PE image */ > +static BOOL get_nt_header( const BYTE *image, const IMAGE_NT_HEADERS32 **nt32, const IMAGE_NT_HEADERS64 **nt64 ) > +{ > + const IMAGE_DOS_HEADER *dos = (const IMAGE_DOS_HEADER *)image; > + const IMAGE_NT_HEADERS *nt = (const IMAGE_NT_HEADERS *)(image + dos->e_lfanew); > + > + if (nt->OptionalHeader.Magic == IMAGE_NT_OPTIONAL_HDR32_MAGIC) > + { > + *nt32 = (const IMAGE_NT_HEADERS32 *)nt; > + *nt64 = NULL; > + return TRUE; > + } > + else if (nt->OptionalHeader.Magic == IMAGE_NT_OPTIONAL_HDR64_MAGIC) > + { > + *nt64 = (const IMAGE_NT_HEADERS64 *)nt; > + *nt32 = NULL; > + return TRUE; > + } > + return FALSE; > +} > + > +static const IMAGE_SECTION_HEADER *get_next_section_header( const BYTE *image, WORD *index ) > +{ > + const IMAGE_NT_HEADERS32 *hdr32; > + const IMAGE_NT_HEADERS64 *hdr64; > + const IMAGE_SECTION_HEADER *section = NULL; > + > + if (!get_nt_header( image, &hdr32, &hdr64 )) return NULL; > + if (hdr32) > + { > + if (*index >= hdr32->FileHeader.NumberOfSections) return NULL; > + section = (const IMAGE_SECTION_HEADER *)((char *)hdr32 + sizeof(DWORD) + > + sizeof(IMAGE_FILE_HEADER) + hdr32->FileHeader.SizeOfOptionalHeader + > + *index * sizeof(IMAGE_SECTION_HEADER)); > + } > + else > + { > + if (*index >= hdr64->FileHeader.NumberOfSections) return NULL; > + section = (const IMAGE_SECTION_HEADER *)((char *)hdr64 + sizeof(DWORD) + > + sizeof(IMAGE_FILE_HEADER) + hdr64->FileHeader.SizeOfOptionalHeader + > + *index * sizeof(IMAGE_SECTION_HEADER)); > + } > + if (section) (*index)++; > + return section; > +} You probably want to use RtlImageDirectoryEntryToData and friends instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Disable Ctrl-C interrupt
by Jason Edmeades 06 Jun '13

06 Jun '13

Hi Hugh, Thanks for looking at this issue with wine's cmd I do not think this patch is enough - From memory (I once tried something similar) the problem with resolving it the way you have is you then lose the ability of breaking out of a batch program. I think the right solution needs an actual handler which resets back to the command prompt mode, optionally asking something like whether you want to end the program or not (with a no continuing from where it left off, with consideration around for loops etc!). I would suggest it's better to allow control c for now rather than get into situations you cannot terminate Jason

2 1

Re: oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types
by Nikolay Sivov 06 Jun '13

06 Jun '13

On Thu, Jun 6, 2013 at 9:55 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > Corrects a spelling mistake too and > > Changelog: > oledb32: Correct DBPROP_INIT_PROVIDERSTRING and DBPROP_INIT_HWND types > > > Best Regards > Alistair Leslie-Hughes > > > > - { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_REQUIRED, VT_BSTR }, + { extemdedW, DBPROP_INIT_PROVIDERSTRING, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, { gen_timeout, DBPROP_INIT_GENERALTIMEOUT, DBPROPOPTIONS_OPTIONAL, VT_I4 }, - { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_BSTR }, + { initcatW, DBPROP_CATALOGLOCATION, DBPROPOPTIONS_OPTIONAL, VT_I4 }, How it's an integer? Catalog location is a path basically. Regarding provider string, could you please add a test for this flag?

1 0

Re: [PATCH 2/3] oleaut32/tests: Add save/load tests for created typelibs
by Marvin 05 Jun '13

05 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25849 Your paranoid android. === WXPX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === WVISTAX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === W7PROX64 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8 === TEST64_W7SP1 (64 bit typelib) === typelib.c:2549: Test failed: cbSizeInstance = 8 typelib.c:2554: Test failed: cbSizeVft = 128 typelib.c:2556: Test failed: cbAlignment = 8 typelib.c:2631: Test failed: got 32 typelib.c:2657: Test failed: got 40 typelib.c:2682: Test failed: got 48 typelib.c:2743: Test failed: got 56 typelib.c:2791: Test failed: got 64 typelib.c:2830: Test failed: got 72 typelib.c:2869: Test failed: got 80 typelib.c:2911: Test failed: got 88 typelib.c:2947: Test failed: got 96 typelib.c:2977: Test failed: got 104 typelib.c:3011: Test failed: got 112 typelib.c:3044: Test failed: got 120 typelib.c:3080: Test failed: cbSizeInstance = 8 typelib.c:3085: Test failed: cbSizeVft = 21856 typelib.c:3086: Test failed: cbAlignment = 8 typelib.c:3105: Test failed: got 5550 typelib.c:3137: Test failed: got 5558 typelib.c:3169: Test failed: cbSizeInstance = 8 typelib.c:3175: Test failed: cbAlignment = 8 typelib.c:3196: Test failed: cbSizeInstance = 8 typelib.c:3202: Test failed: cbAlignment = 8 typelib.c:3242: Test failed: cbSizeInstance = 8 typelib.c:3247: Test failed: cbSizeVft = 56 typelib.c:3248: Test failed: cbAlignment = 8 typelib.c:3263: Test failed: cbSizeInstance = 8 typelib.c:3268: Test failed: cbSizeVft = 64 typelib.c:3269: Test failed: cbAlignment = 8

1 0

Re: ole32: Add a basic OLE client/server test suite. Take 2.
by Dmitry Timoshkov 05 Jun '13

05 Jun '13

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

2 7

Re: [PATCH 3/5] wined3d: Pass a wined3d_resource_desc structure to wined3d_texture_create_cube().
by Stefan Dösinger 05 Jun '13

05 Jun '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-06-05 11:06, schrieb Henri Verbeet: > + desc.width = edge_length; + desc.height = edge_length; + > desc.depth = 1; Wouldn't it make sense to either set desc.height = 1 or desc.depth = edge_length? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrwNtAAoJEN0/YqbEcdMwLkoP/jN3ooH3ur4ZLMgSc96VT+WR b+EcwCmK1yigPrY04UPiHmSVSS/g9bgR/BsVoQB9d6Fa2UfFeDEGGgOYdVOE6/9P guRWs6RAMTv4AfuDCjmRC3h2fO0nigg3sLkmvqG5qZF8hmGbItijB5zREWHys3Bk kedPMQaWXWuq9wwHa7ZM1B3wcMiZsxqfcyitFa1FsB7LvbLHIYuMzNQrViObGvT5 75J1Ux/WmFu9ZKTvWjIyFzhWg9oqeHPpB1lXgj4w3ONkOa0Rw27EUsxHRTlGiYm+ 4qGyvclsE1Ep2A2NK/kCUU1SuxeSP/bW38P9Lc8J/xNb8Si8zNu2VApTYjOIOk9q 3wHKgU0MuRRnw5ophMM9xNhIT/lt+0FilNZYosvEul+A0tAhncthCege0ZBRIeSf ZKlRGrInBMSy59BJwxVvPxaF702M0xHdkpKEMnML1NYCRg9+gbm862y/KRczvBxL kRWs6AIBr0247voTHvhRBJTtEanCeKP+qGLoatNVimPFaEDnSj9xxHIA+4XaThPW 2A+WjSPc7ni0Z8IKGQB9hOku0ZKvX2BJIAXiFm1KQW23psqUHF5CTR3w48yG7Dmh pm8SETIud6SwakKTW5ikp5ObjLYdM1Z8M8hNIkU64O8k7+aSX3hAqKW2shC6d/xm REcwzCU6NhmbDWgC5epH =tH28 -----END PGP SIGNATURE-----

2 1

Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.
by Rico Schüller 05 Jun '13

05 Jun '13

On 05.06.2013 08:48, Christian Costa wrote: > bone = &This->bones[bone_num]; > + /* Decrement refcounts of vertices previously influenced */ > + for (i = 0; i < bone->num_influences; i++) > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > bone->num_influences = num_influences; > HeapFree(GetProcessHeap(), 0, bone->vertices); > HeapFree(GetProcessHeap(), 0, bone->weights); > bone->vertices = new_vertices; > bone->weights = new_weights; > + /* Increment refcounts of vertices newly influenced */ > + for (i = 0; i < bone->num_influences; i++) > + { > + if (bone->vertices[i] < This->num_vertices) /* Ignore out of range value */ > + This->vertices_refcounts[bone->vertices[i]]--; > + } Please have a look at the code style (brackets {} at the for loops?). It should be a bit more consistent. Also I think an increment (as said in the comment) is something like "This->vertices_refcounts[bone->vertices[i]]++;". Maybe you could add a test to verify if the comment or the code is correct? Cheers Rico

2 1

Re: [PATCH 1/2] server: Don't create new handle when DUP_HANDLE_CLOSE_SOURCE is used if possible (try2)
by Alexandre Julliard 05 Jun '13

05 Jun '13

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -890,6 +890,7 @@ struct rawinput_device > obj_handle_t handle; /* duplicated handle in dst process */ > int self; /* is the source the current process? */ > int closed; /* whether the source handle has been closed */ > + int reused; /* whether the source handle has been reused */ I don't think you need an extra flag, there's nothing the client has to do differently in that case (the warning is mostly cosmetic anyway). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll
by Charles Davis 05 Jun '13

05 Jun '13

On Jun 4, 2013, at 12:15 PM, Austin English wrote: > diff --git a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > new file mode 100644 > index 0000000..cc15d4e > --- /dev/null > +++ b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > @@ -0,0 +1,40 @@ > +@ stub RegCloseKey Why don't you just forward them to their implementations in advapi32? Is there something oddly different about these functions that I don't know about? Chip

2 1

Re: bugzilla: Change no bugs found message
by Christian Costa 04 Jun '13

04 Jun '13

Hi, Minor but shouldn't it be "bug" instead "bugs"? Christian

2 2

Re: [PATCH 1/8] winemac: Don't unminimize a window on first activation during start-up.
by Dmitry Timoshkov 04 Jun '13

04 Jun '13

Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_app.h | 2 ++ > dlls/winemac.drv/cocoa_app.m | 3 ++- > 2 files changed, 4 insertions(+), 1 deletions(-) I wonder, do you actually run 'make test' in dlls/user32/tests with your changes? My guess is that you don't. -- Dmitry.

2 1

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker 04 Jun '13

04 Jun '13

On Tue, 2013-06-04 at 10:16 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > After suggestion by Hans, do it in the helper ... especially > as the other external callers do not initialize schemes either. I also said that you shouldn't touch the parameter on error :) The other callers pass a pointer to a user variable and the attached test confirms that native doesn't touch it.

1 0

testbot and NT4
by Ann and Jason Edmeades 04 Jun '13

04 Jun '13

Hiya, Its been a while since I did some cmd work and noticed there were some new bugs so am doing some fiddling. The real pain for me was always keeping the tests passing on nt4, so I noted with relief/surprise that the testbot doesnt have an NT4 VM anymore. Is it correct that there is no longer a requirement for tests to pass on NT4 for submission (if it's required, I really need a nt4 testbot!) If not, is there any objection to removing the numerous hacks in the test suite so they run on NT4? Thanks, Jason

6 6

Re: [PATCH] mscms: Use lcms2, when available [try 2]
by Hans Leidekker 04 Jun '13

04 Jun '13

On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: > try2: > import the unchanged icc34.h from the lcms (v1) dev. package. > (Do we need to add a Wine LGPL licence header for icc34.h?) > > The plan is to remove this include, when changing Wine > to use the new getter/setter functions of lcms2 > (After the release of Wine-1.6) My plan was to switch to lcms2 soon *after* the release of Wine 1.6. I studied the API some more and my conclusion is that while it doesn't have all we need (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want), we can avoid importing the icc34.h header. I'm not in favor of adding temporary workarounds. If distributions want to drop support for lcms1 in 1.6 I'd suggest that they backport the patches.

3 4

Re: Add tests for ntdll event functions
by Marvin 04 Jun '13

04 Jun '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25813 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Add tests for ntdll event functions
by Andrew Cook 04 Jun '13

04 Jun '13

While implemeting NtQueryEvent i stumbled across an odd permissions issue, which is really what this patch tests if ((event = create_event( root, &name, req->attributes, req->manual_reset, req->initial_state, sd ))) { if (get_error() == STATUS_OBJECT_NAME_EXISTS) reply->handle = alloc_handle( current->process, event, req->access, req->attributes ); else reply->handle = alloc_handle_no_access_check( current->process, event, req->access, req->attributes ); release_object( event ); } when creating an event, the handle is allocated with alloc_handle_no_access_check, which does not call event_map_access this causes event_op and event_query to fail, as the handle only has GENERIC_ALL, not the actual event permissions, which does not match windows behaviour (or at least windows 7 anyway), On 04/06/13 11:13, Andrew Cook wrote: > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/event.c | 69 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 70 insertions(+) > create mode 100644 dlls/ntdll/tests/event.c > > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..a44b880 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -7,6 +7,7 @@ C_SRCS = \ > directory.c \ > env.c \ > error.c \ > + event.c \ > exception.c \ > file.c \ > generated.c \ > diff --git a/dlls/ntdll/tests/event.c b/dlls/ntdll/tests/event.c > new file mode 100644 > index 0000000..f29abc3 > --- /dev/null > +++ b/dlls/ntdll/tests/event.c > @@ -0,0 +1,69 @@ > +/* > + * Unit test suite for event functions > + * > + * Copyright 2005 Robert Shearman > + * Copyright 2005 Vitaliy Margolen > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ > + > +#include "ntdll_test.h" > +#include "winternl.h" > +#include "winnt.h" > + > +static NTSTATUS (WINAPI *pNtCreateEvent) ( PHANDLE, ACCESS_MASK, const > POBJECT_ATTRIBUTES, BOOLEAN, BOOLEAN); > +static NTSTATUS (WINAPI *pNtPulseEvent) ( HANDLE, PULONG ); > +static NTSTATUS (WINAPI *pNtQueryEvent) ( HANDLE, > EVENT_INFORMATION_CLASS, PVOID, ULONG, PULONG ); > +static NTSTATUS (WINAPI *pNtClose) ( HANDLE ); > +static VOID (WINAPI *pRtlInitUnicodeString)( PUNICODE_STRING, > LPCWSTR ); > + > +START_TEST(event) > +{ > + HANDLE Event; > + NTSTATUS status; > + UNICODE_STRING str; > + OBJECT_ATTRIBUTES attr; > + EVENT_BASIC_INFORMATION info; > + HMODULE hntdll = GetModuleHandleA("ntdll.dll"); > + HMODULE hkernel32 = GetModuleHandleA("kernel32.dll"); > + static const WCHAR eventName[] = > {'\\','B','a','s','e','N','a','m','e','d','O','b','j','e','c','t','s','\\','t','e','s','t','E','v','e','n','t',0}; > + > + if (!hntdll) > + { > + skip("not running on NT, skipping test\n"); > + return; > + } > + > + pNtCreateEvent = (void *)GetProcAddress(hntdll, "NtCreateEvent"); > + pNtQueryEvent = (void *)GetProcAddress(hntdll, "NtQueryEvent"); > + pNtPulseEvent = (void *)GetProcAddress(hntdll, "NtPulseEvent"); > + pNtClose = (void *)GetProcAddress(hntdll, "NtClose"); > + pRtlInitUnicodeString = (void *)GetProcAddress(hntdll, > "RtlInitUnicodeString"); > + > + pRtlInitUnicodeString(&str, eventName); > + InitializeObjectAttributes(&attr, &str, 0, 0, NULL); > + > + status = pNtCreateEvent(&Event, GENERIC_ALL, &attr, 0, 0); > + ok( status == STATUS_SUCCESS, "NtCreateEvent failed %08x\n", status ); > + > + status = pNtPulseEvent(Event, 0); > + todo_wine ok( status == STATUS_SUCCESS, "NtPulseEvent failed > %08x\n", status ); > + > + status = pNtQueryEvent(Event, EventBasicInformation, &info, > sizeof(info), NULL); > + todo_wine ok( status == STATUS_SUCCESS, "NtQueryEvent failed > %08x\n", status ); > + > + status = pNtClose(Event); > + ok( status == STATUS_SUCCESS, "NtClose failed %08x\n", status ); > +}

1 0

Re: How to stop gecko and mono popups while git bisecting?
by Dan Kegel 03 Jun '13

03 Jun '13

Or run https://winezeug.googlecode.com/svn/trunk/install-addons.sh

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2013