On 3/19/2014 17:02, Jactry Zeng wrote:
> Update:
> - Add a todo_wine.
>
> + ITextDocument_Open(txtDoc, &testfile, tomReadOnly|tomRTF, CP_ACP);
It's a common practice to check a return value.
> + /* open a rtf without } in the end */
> + result = ITextDocument_Open(txtDoc, &testfile, tomReadOnly, CP_ACP);
> + /* 0x80070026 is HRESUILT_FROM_WIN32(ERROR_HANDLE_EOF) */
> + todo_wine ok(result == 0x80070026, "ITextDocument_Open: Should return an ERROR_HANDLE_EOF error.\n");
No need to put a magic number, use HRESULT_FROM_WIN32(), and don't
forget to use proper type for return value. Also a typo in a comment,
but that it go anyway.