wine-devel April 2014

wine-devel@winehq.org

61 participants
274 discussions

Re: [2/2] oleaut32: Fix loading of an empty picture from a non-statable stream.
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6260 Your paranoid android. === w2000pro (32 bit olepicture) === olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:435: Test failed: OleLoadPicture failed with error 0x8000ffff olepicture: unhandled exception c0000005 at 0040A7BD

1 0

Re: [1/2] oleaut32/tests: Add a test for loading an empty picture from a non-statable stream.
by Marvin 10 Apr '14

10 Apr '14

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 4)
by Stefan Dösinger 10 Apr '14

10 Apr '14

> + hr = IDirectPlay8Address_SetSP(localaddr, &GUID_NULL); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); That’s a step forward, but I also meant that you should call GetSP after setting GUID_NULL manually. > +DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); Why do you have to define this? (I really don’t know; It may be correct, or maybe you just need #define INITGUID, or something else.) > static HRESULT WINAPI IDirectPlay8AddressImpl_SetUserData(IDirectPlay8Address *iface, > @@ -313,6 +323,8 @@ HRESULT DPNET_CreateDirectPlay8Address(LPCLASSFACTORY iface, LPUNKNOWN punkOuter > return E_OUTOFMEMORY; > } > client->IDirectPlay8Address_iface.lpVtbl = &DirectPlay8Address_Vtbl; > + client->SP_guid = GUID_NULL; > + client->init = FALSE; > client->ref = 0; /* will be inited with QueryInterface */ > return IDirectPlay8AddressImpl_QueryInterface (&client->IDirectPlay8Address_iface, riid, ppobj); > } You shouldn’t have to set client->init = FALSE because you allocate client with HEAP_ZERO_MEMORY. If you prefer to set it for clarity that’s ok with me. The same applies to SP_guid, for two reasons: First, it’s already initialized to zeroes, and you’re not reading it unless client->init is set to TRUE, which only happens after a successful SetSP call. IMHO you can also correct the indentation in this function, but I’ll leave the decision up to you. Cheers, Stefan

2 2

Re: [PATCH] qedit/tests: Fix a file handle leak on error path (Coverity)
by Marvin 10 Apr '14

10 Apr '14

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 4)
by Marvin 10 Apr '14

10 Apr '14

1 0

Re: [5/5] taskschd: Forward IRegisteredTask::get_Enabled to SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

1 0

Re: [4/5] taskschd: Forward IRegisteredTask::get_State to SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

1 0

Re: [3/5] schedsvc: Add SchRpcGetTaskInfo stub implementation.
by Marvin 09 Apr '14

09 Apr '14

1 0

Re: [2/5] schedsvc: Add some tests for SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

1 0

Re: [1/5] schedsvc: Return correct error code when a being loaded xml doesn't exist.
by Marvin 09 Apr '14

09 Apr '14

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2014