wine-devel April 2014

wine-devel@winehq.org

61 participants
274 discussions

msvcp90/msvcp90.h: right-hand operand of comma expression has no effect
by Gerald Pfeifer 18 May '14

18 May '14

Building git head with GCC development sources (soon to be GCC 4.9.0) gives me the following warnings ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma expression has no effect [-Wunused-value] ../msvcp90/msvcp90.h:530:77: warning: right-hand operand of comma expression has no effect [-Wunused-value] several times. Digging into this in more detail I see ../msvcp90/ios.c: In function 'basic_streambuf_char__Xsgetn_s': ../msvcp90/msvcp90.h:529:75: warning: right-hand operand of comma expression has no effect [-Wunused-value] #define memcpy_s( dst, size, src, count ) (memcpy( (dst), (src), (count) ), 0) ^ ../msvcp90/ios.c:1218:13: note: in expansion of macro 'memcpy_s' memcpy_s(ptr+copied, size, *this->prpos, chunk); ^ Someone must have written that code intentionally, so I am wondering how to best address this. Gerald

2 2

Wine Test analysis, report
by Jeremy White 16 May '14

16 May '14

Just wanted to report that I do periodically do my analysis. It looks as though the test bot is beginning to be usable again, although the results are currently ugly: http://www.winehq.org/~jwhite/fba08e34c447.html I'm waiting for Francois to report that things are essentially operational again; until I get that word, I'm not planning to beat the drum. Francois, can we get an update? Cheers, Jeremy

7 8

Re: [PATCH] vbscript: Fixed CBool
by Piotr Caban 30 Apr '14

30 Apr '14

On 04/29/14 15:06, Shuai Meng wrote: > + if(!res) > + return S_OK; You can't return early if res is NULL. You still need to do the conversion and return error if it fails. > +Call ok(CBool(Empty) = False, "CBool(Empty) = " & CBool(Empty)) > +Call ok(getVT(CBool(Empty)) = "VT_BOOL", "getVT(CBool(Empty)) = " & getVT(CBool(Empty))) > +Call ok(CBool(1) = True, "CBool(1) = " & CBool(1)) > +Call ok(getVT(CBool(1)) = "VT_BOOL", "getVT(CBool(1)) = " & getVT(CBool(1))) > +Call ok(CBool(0) = False, "CBool(0) = " & CBool(0)) > +Call ok(getVT(CBool(0)) = "VT_BOOL", "getVT(CBool(0)) = " & getVT(CBool(0))) > +Call ok(CBool(-0.56) = True, "CBool(-0.56) = " & CBool(-0.56)) > +Call ok(getVT(CBool(-0.56)) = "VT_BOOL", "getVT(CBool(-0.56)) = " & getVT(CBool(-0.56))) > +Call ok(CBool("-1") = True, "CBool(""-1"") = " & CBool("-1")) > +Call ok(getVT(CBool("-1")) = "VT_BOOL", "getVT(CBool(""-1"")) = " & getVT(CBool("-1"))) It would be nice to add following tests (these are the tests Jacek was asking for): Call ok(CBool("True") = true, "CBool(""True"") = " & CBool("True")) Call ok(CBool("fAlSe") = false, "CBool(""fAlSe"") = " & CBool("fAlSe")) sub testCBoolError on error resume next call Err.clear() call CBool("#FALSE#") call ok(Err.number = 458, "Err.number = " & Err.number) end sub Call testCBoolError

3 7

Re: [PATCH 01/10] vbscript: Fixed CBool(try 3)
by Jacek Caban 30 Apr '14

30 Apr '14

Hi Shuai, On 04/21/14 03:45, Shuai Meng wrote: > - > - return return_bool(res, val); > + V_VT(res) = VT_EMPTY; > + return VariantChangeType(res, arg, VARIANT_LOCALBOOL, VT_BOOL); You can't assume that res is not NULL. If result of the function is not used, it will be NULL. A simple test case is like this: call CBool(0) Also, are you sure we want VARIANT_LOCALBOOL here? Did you test it (probably by running tests on localized Windows with translated string "False")? Looking at CBool tests: +Call ok(CBool(Empty) = False, "CBool(Empty) = " & CBool(Empty)) +Call ok(getVT(CBool(Empty)) = "VT_BOOL", "getVT(CBool(Empty)) = " & getVT(CBool(Empty))) +Call ok(CBool(1) = True, "CBool(1) = " & CBool(1)) +Call ok(getVT(CBool(1)) = "VT_BOOL", "getVT(CBool(1)) = " & getVT(CBool(1))) +Call ok(CBool(CLng(0)) = False, "CBool(CLng(0)) = " & CBool(CLng(0))) +Call ok(getVT(CBool(CLng(0))) = "VT_BOOL", "getVT(CBool(CLng(0))) = " & getVT(CBool(CLng(0)))) +Call ok(CBool(CSng(0.5)) = True, "CBool(CSng(0.5)) = " & CBool(CSng(0.5))) +Call ok(getVT(CBool(CSng(0.5))) = "VT_BOOL", "getVT(CBool(CSng(0.5))) = " & getVT(CBool(CSng(0.5)))) +Call ok(CBool(-0.56) = True, "CBool(-0.56) = " & CBool(-0.56)) +Call ok(getVT(CBool(-0.56)) = "VT_BOOL", "getVT(CBool(-0.56)) = " & getVT(CBool(-0.56))) +Call ok(CBool(CCur(8.55)) = True, "CBool(CCur(8.55)) = " & CBool(CCur(8.55))) +Call ok(getVT(CBool(CCur(8.55))) = "VT_BOOL", "getVT(CBool(CCur(8.55))) = " & getVT(CBool(CCur(8.55)))) +Call ok(CBool(CDate(0)) = False, "CBool(CDate(0)) = " & CBool(CDate(0))) +Call ok(getVT(CBool(CDate(0))) = "VT_BOOL", "getVT(CBool(CDate(0))) = " & getVT(CBool(CDate(0)))) +Call ok(CBool(CDate(3.33)) = True, "CBool(CDate(3.33)) = " & CBool(CDate(3.33))) +Call ok(getVT(CBool(CDate(3.33))) = "VT_BOOL", "getVT(CBool(CDate(3.33))) = " & getVT(CBool(CDate(3.33)))) +Call ok(CBool("6666.78") = True, "CBool(""6666.78"") = " & CBool("6666.78")) +Call ok(getVT(CBool("6666.78")) = "VT_BOOL", "getVT(CBool(""6666.78"")) = " & getVT(CBool("6666.78"))) +Call ok(CBool(CByte(-0.1)) = False, "CBool(CByte(-0.1)) = " & CBool(CByte(-0.1))) +Call ok(getVT(CBool(CByte(-0.1))) = "VT_BOOL", "getVT(CBool(CByte(-0.1))) = " & getVT(CBool(CByte(-0.1)))) Those look mostly good. However I'd like to see some more tests. Interesting case is for example empty string and a "false", "False" and "#FALSE#" string. Also I'd really like to see tests on object default values. See the attached patch for an example. Those comments apply also to other patches in the series. It may be easier to proceed if you resent just the first patch fixed and include tests that don't depending on other patches in the series in the patch itself. Cheers, Jacek

3 6

Re: dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h (try 2)
by Alexandre Julliard 30 Apr '14

30 Apr '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Change struct to interface, hopefully it will compile on the MAC this > time. Obviously this won't make any difference. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/1] ddraw/tests: Add some basic material tests.
by Marvin 30 Apr '14

30 Apr '14

1 0

Re: [PATCH 1/2] vbscript: Allow property getters to take arguments.
by Marvin 30 Apr '14

30 Apr '14

1 0

Re: msi/tests: Fix a couple of memory leaks (valgrind).
by Marvin 30 Apr '14

30 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6675 Your paranoid android. === w2000pro (32 bit package) === package.c:3956: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3962: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3968: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3980: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3986: Test failed: Expected "C:\\", got "C:\" package.c:3992: Test failed: Expected "C:\\", got "C:\" package.c:4008: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4019: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4478: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4570: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4581: Test failed: Expected "C:\\", got "C:\" package.c:4592: Test failed: Expected "C:\\", got "C:\" package.c:4642: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4653: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4668: Test failed: Expected "C:\\", got "C:\" package.c:4673: Test failed: Expected "", got "C:\" package.c:4689: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4698: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4948: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4959: Test failed: Expected "C:\\", got "C:\" package.c:4965: Test failed: Expected "C:\\", got "C:\" package.c:4986: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4997: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5237: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5243: Test failed: Expected "C:\\", got "C:\" package.c:5260: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5271: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5279: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5623: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6255: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6279: Test failed: Expected C:\\ or empty string, got C:\ package.c:6323: Test failed: Expected C:\\ or empty string, got C:\ package.c:6332: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6562: Test failed: Expected "C:\\", got "C:\" package.c:6563: Test failed: Expected 4, got 3 package.c:6570: Test failed: Expected "C:\\", got "C:\" package.c:6571: Test failed: Expected 4, got 3 package.c:6587: Test failed: Expected "C:\\", got "C:\" package.c:6588: Test failed: Expected 4, got 3 package.c:6594: Test failed: Expected "C:\\", got "C:\" package.c:6595: Test failed: Expected 4, got 3 package.c:6602: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6603: Test failed: Expected 14, got 13 package.c:6610: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6611: Test failed: Expected 19, got 18 package.c:6621: Test failed: Expected "C:\\", got "C:\" package.c:6622: Test failed: Expected 4, got 3 package.c:6629: Test failed: Expected "C:\\", got "C:\" package.c:6630: Test failed: Expected 4, got 3 package.c:6646: Test failed: Expected "C:\\", got "C:\" package.c:6647: Test failed: Expected 4, got 3 package.c:6653: Test failed: Expected "C:\\", got "C:\" package.c:6654: Test failed: Expected 4, got 3 package.c:6661: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6662: Test failed: Expected 14, got 13 package.c:6669: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6670: Test failed: Expected 19, got 18 package.c:6680: Test failed: Expected "C:\\", got "C:\" package.c:6681: Test failed: Expected 4, got 3 package.c:6688: Test failed: Expected "C:\\", got "C:\" package.c:6689: Test failed: Expected 4, got 3 package.c:6705: Test failed: Expected "C:\\", got "C:\" package.c:6706: Test failed: Expected 4, got 3 package.c:6712: Test failed: Expected "C:\\", got "C:\" package.c:6713: Test failed: Expected 4, got 3 package.c:6720: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6721: Test failed: Expected 14, got 13 package.c:6728: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6729: Test failed: Expected 19, got 18 package.c:6739: Test failed: Expected "C:\\", got "C:\" package.c:6740: Test failed: Expected 4, got 3 package.c:6747: Test failed: Expected "C:\\", got "C:\" package.c:6748: Test failed: Expected 4, got 3 package.c:6764: Test failed: Expected "C:\\", got "C:\" package.c:6765: Test failed: Expected 4, got 3 package.c:6771: Test failed: Expected "C:\\", got "C:\" package.c:6772: Test failed: Expected 4, got 3 package.c:6779: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6780: Test failed: Expected 14, got 13 package.c:6787: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6788: Test failed: Expected 19, got 18 package.c:6803: Test failed: Expected 4, got 3 package.c:6820: Test failed: Expected 4, got 3 package.c:6826: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6829: Test failed: Expected 4, got 3 package.c:6836: Test failed: Expected "C:\\", got "C:\" package.c:6837: Test failed: Expected 4, got 3 package.c:6848: Test failed: Expected "C:\\", got "C:\" package.c:6849: Test failed: Expected 4, got 3 package.c:6944: Test failed: Expected "C:\\", got "C:\" package.c:6945: Test failed: Expected 4, got 3 package.c:6952: Test failed: Expected "C:\\", got "C:\" package.c:6953: Test failed: Expected 4, got 3 package.c:6962: Test failed: Expected "C:\\", got "C:\" package.c:6963: Test failed: Expected 4, got 3 package.c:6971: Test failed: Expected "C:\\", got "C:\" package.c:6972: Test failed: Expected 4, got 3 package.c:6978: Test failed: Expected "C:\\", got "C:\" package.c:6979: Test failed: Expected 4, got 3 package.c:6986: Test failed: Expected "C:\\", got "C:\" package.c:6987: Test failed: Expected 4, got 3 package.c:6994: Test failed: Expected "C:\\", got "C:\" package.c:6995: Test failed: Expected 4, got 3 package.c:7005: Test failed: Expected "C:\\", got "C:\" package.c:7006: Test failed: Expected 4, got 3 package.c:7013: Test failed: Expected "C:\\", got "C:\" package.c:7014: Test failed: Expected 4, got 3 package.c:7023: Test failed: Expected "C:\\", got "C:\" package.c:7024: Test failed: Expected 4, got 3 package.c:7032: Test failed: Expected "C:\\", got "C:\" package.c:7033: Test failed: Expected 4, got 3 package.c:7039: Test failed: Expected "C:\\", got "C:\" package.c:7040: Test failed: Expected 4, got 3 package.c:7047: Test failed: Expected "C:\\", got "C:\" package.c:7048: Test failed: Expected 4, got 3 package.c:7055: Test failed: Expected "C:\\", got "C:\" package.c:7056: Test failed: Expected 4, got 3 package.c:7066: Test failed: Expected "C:\\", got "C:\" package.c:7067: Test failed: Expected 4, got 3 package.c:7074: Test failed: Expected "C:\\", got "C:\" package.c:7075: Test failed: Expected 4, got 3 package.c:7084: Test failed: Expected "C:\\", got "C:\" package.c:7085: Test failed: Expected 4, got 3 package.c:7093: Test failed: Expected "C:\\", got "C:\" package.c:7094: Test failed: Expected 4, got 3 package.c:7100: Test failed: Expected "C:\\", got "C:\" package.c:7101: Test failed: Expected 4, got 3 package.c:7108: Test failed: Expected "C:\\", got "C:\" package.c:7109: Test failed: Expected 4, got 3 package.c:7116: Test failed: Expected "C:\\", got "C:\" package.c:7117: Test failed: Expected 4, got 3 package.c:7127: Test failed: Expected "C:\\", got "C:\" package.c:7128: Test failed: Expected 4, got 3 package.c:7135: Test failed: Expected "C:\\", got "C:\" package.c:7136: Test failed: Expected 4, got 3 package.c:7145: Test failed: Expected "C:\\", got "C:\" package.c:7146: Test failed: Expected 4, got 3 package.c:7154: Test failed: Expected "C:\\", got "C:\" package.c:7155: Test failed: Expected 4, got 3 package.c:7161: Test failed: Expected "C:\\", got "C:\" package.c:7162: Test failed: Expected 4, got 3 package.c:7169: Test failed: Expected "C:\\", got "C:\" package.c:7170: Test failed: Expected 4, got 3 package.c:7177: Test failed: Expected "C:\\", got "C:\" package.c:7178: Test failed: Expected 4, got 3 package.c:7275: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7276: Test failed: Expected 9, got 8 package.c:7285: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7286: Test failed: Expected 9, got 8 package.c:7295: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7296: Test failed: Expected 9, got 8 package.c:7307: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7308: Test failed: Expected 8, got 7 package.c:7319: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7320: Test failed: Expected 9, got 8 package.c:7331: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7332: Test failed: Expected 8, got 7 package.c:7343: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7344: Test failed: Expected 10, got 9 package.c:7355: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7356: Test failed: Expected 8, got 7 package.c:7367: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7368: Test failed: Expected 11, got 10 package.c:7419: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7420: Test failed: Expected 10, got 9 package.c:7429: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7430: Test failed: Expected 10, got 9 package.c:7439: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7440: Test failed: Expected 10, got 9 package.c:7451: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7452: Test failed: Expected 8, got 7 package.c:7463: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7464: Test failed: Expected 10, got 9 package.c:7475: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7476: Test failed: Expected 9, got 8 package.c:7487: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7488: Test failed: Expected 10, got 9 package.c:7499: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7500: Test failed: Expected 9, got 8 package.c:7511: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7512: Test failed: Expected 11, got 10 package.c:7648: Test failed: Expected "C:\\", got "C:\" package.c:7649: Test failed: Expected 4, got 3 package.c:7660: Test failed: Expected "C:\\", got "C:\" package.c:7661: Test failed: Expected 4, got 3 package.c:7668: Test failed: Expected "C:\\", got "C:\" package.c:7669: Test failed: Expected 4, got 3 package.c:7766: Test failed: Expected "C:\\", got "C:\" package.c:7767: Test failed: Expected 4, got 3 package.c:7774: Test failed: Expected "C:\\", got "C:\" package.c:7775: Test failed: Expected 4, got 3 package.c:7782: Test failed: Expected "C:\\", got "C:\" package.c:7783: Test failed: Expected 4, got 3 package.c:7802: Test failed: Expected "C:\\", got "C:\" package.c:7803: Test failed: Expected 4, got 3 package.c:7810: Test failed: Expected "C:\\", got "C:\" package.c:7811: Test failed: Expected 4, got 3 package.c:7830: Test failed: Expected "C:\\", got "C:\" package.c:7831: Test failed: Expected 4, got 3 package.c:7838: Test failed: Expected "C:\\", got "C:\" package.c:7839: Test failed: Expected 4, got 3 package.c:7858: Test failed: Expected "C:\\", got "C:\" package.c:7859: Test failed: Expected 4, got 3 package.c:7866: Test failed: Expected "C:\\", got "C:\" package.c:7867: Test failed: Expected 4, got 3 === w7u (32 bit msi) === The test timed out === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === Failure running script in VM: timed out waiting for the child process === wxppro (32 bit action) === The test timed out === w2008s64 (32 bit action) === Failure running script in VM: timed out waiting for the child process === w7u (32 bit action) === Failure running script in VM: timed out waiting for the child process === w864 (32 bit action) === The test timed out

1 0

Re: wbemproxy: Fix invalid HRESULT assignment in class_object_Next.
by Hans Leidekker 30 Apr '14

30 Apr '14

On Tue, 2014-04-29 at 19:41 +0200, Victor Martinez wrote: > From 9cfa2abd78c6cd23c3bd5a48c6fb5f5259edd9e4 Mon Sep 17 00:00:00 2001 > From: Victor Martinez Calvo <vmartinez(a)reactos.org> > Date: Tue, 29 Apr 2014 17:36:27 +0200 > Subject: wbemproxy: Fix invalid HRESULT assignment in class_object_Next. Thanks. As it happens I have just rewritten this function and included the same fix: http://source.winehq.org/patches/data/104254

1 0

D3D11CreateDevice
by Dyweni - Wine-Devel 30 Apr '14

30 Apr '14

Hi All, I'm curious to know if anyone has an idea of when D3D11CreateDevice will be implemented to at least D3D_FEATURE_LEVEL_10_0? http://bugs.winehq.org/show_bug.cgi?id=34008 Thanks, Dyweni!

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2014