wine-devel May 2014

wine-devel@winehq.org

64 participants
176 discussions

Start a nNew thread

Re: [PATCH] vbscript: Fixed CBool(try 4)
by Marvin 03 May '14

03 May '14

1 0

Re: dpnet/tests: Add a trailing '\n' to an ok() call.
by Marvin 02 May '14

02 May '14

1 0

Building Wine conformance tests on Windows
by Albert Szilvasy 02 May '14

02 May '14

Hello there, It appears that it is not possible to build the Wine conformance tests on Windows as described here: http://www.winehq.org/site/docs/winedev-guide/testing-windows In particular, when I try to build against the latest Windows SDK I get all sorts of errors. Take for example, kernel32/tests/loader.c. It refers to IMAGE_FILE_MACHINE_ARM64. This symbol does not exist in winnt.h from Microsoft but does exist in the wine version. How do people build the conformance tests? Cross compile on Linux? Thanks, albert

6 7

Re: ole32/tests: Add a trailing '\n' to an ok() call.
by Marvin 02 May '14

02 May '14

1 0

Re: [PATCH] ddraw/tests: Add a test for getdc palette handling (try 3).
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6752 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 3/3] wined3d: Remove broken gdi palette code.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6747 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 1/3] ddraw/tests: Add a test for getdc palette handling (try 2).
by Henri Verbeet 02 May '14

02 May '14

On 2 May 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + * contains uninitialized garbage. See comments beflow for the P8 case. */ This is minor of course, but "below". > + /* See Win8 refcounting remarks in test_primary_palette. */ I think this is superfluous here as well. With those fixed, I think this set is ok.

1 0

Re: [PATCH 2/3] ddraw/tests: Test mipmap GetDC behavior.
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6746 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH 1/3] ddraw/tests: Add a test for getdc palette handling (try 2).
by Marvin 02 May '14

02 May '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6745 Your paranoid android. === wvistau64 (64 bit ddraw2) === ddraw2.c:5645: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw2.c:5645: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw1) === ddraw1.c:4569: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw1.c:4569: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw7) === ddraw7.c:6369: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw7.c:6369: Test failed: Test 6: Got unexpected pitch 252, expected 256. === wvistau64 (64 bit ddraw4) === ddraw4.c:6546: Test failed: Test 4: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 5: Got unexpected pitch 252, expected 256. ddraw4.c:6546: Test failed: Test 6: Got unexpected pitch 252, expected 256.

1 0

Re: [PATCH] user32: Don't destroy in-use menus
by Ken Thomases 02 May '14

02 May '14

On May 1, 2014, at 2:19 PM, Andrew Eikum wrote: > + /* two different kinds of "reference" counting. in_use is for internal > + * refcounting for e.g. submenus. user_destroyed indicates whether > + * DestroyMenu has been invoked on a handle returned by CreateMenu. */ > + BOOL in_use, user_destroyed; First, since in_use is a count, it probably shouldn't be a BOOL. Second, I haven't reviewed the menu code thoroughly, but I think that it would be better to conceptually separate the handle from the internal structure. Internal references to submenus and the like should be by pointers to the structure. The handle should only be used at the interface with external clients. Then, there should be only one reference count. It's the count of users of the structure. The handle represents one reference. Each place where a pointer to the structure is stored is another reference. DestroyMenu() should really destroy the handle (and thus decrement the reference count), not just mark it as "destroyed". -Ken

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel May 2014