August 2014 - wine-devel

Re: [PATCH 7/7] vbscript: Implemented Log(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8550 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] vbscript: Implemented Exp(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8549 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] vbscript: Implemented Atn(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8548 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/7] vbscript: Implemented Tan(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8547 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] vbscript: Implemented Sin(try 3 )
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8546 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] vbscript: Implemented Cos(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8545 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] vbscript: Implemented Sqr(try 3)
by Marvin 17 Aug '14

17 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8544 Your paranoid android. === build (build) === Patch failed to apply

1 0

imagehlp: Implement (parts of) BindImageEx
by Bernhard Reiter 16 Aug '14

16 Aug '14

Now that the test has been committed, I'd be grateful for any reviews of the implementation! Bernhard

4 9

Missing Bug links in AppDB - a try
by André Hentschel 15 Aug '14

15 Aug '14

Hi, I once wrote a script to search the Bugzilla backup file for application names from the AppDB backup file. There are still lots of false positives and it's not respected when the bug url is already linked to the AppDB entry... The script also ignores application names < 4 chars and closed bugs. So if you want to have a bug url adding run through the AppDB, be carefull and have a look at the output: http://dawncrow.de/wine/appdbbugzilla.html

1 1

Re: mshtml: Added IHTMLTableCell::align property implementation.
by Marvin 15 Aug '14

15 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8502 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wxppro (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wvistau64 (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === w7u (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === w8 (32 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000 === wvistau64 (64 bit dom) === dom.c:5936: Test failed: Expect E_INVALIDARG, got 00000000

1 0

Re: msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > +complex_float* __cdecl complex_float_pow_ci(complex_float *ret, const complex_float *l, int r) > +{ > + complex_float c = *l; > + complex_float temp = { 1.0, 0 }; > + complex_float_assign(ret, &temp); > + > + if(r < 0){ > + r = -r; > + complex_float_div(&c, &temp, l); > + } > + > + for(; r>0; r>>=1) > + { > + if( (r%2)&1 ) Please fix the if condition. You're also using tabs in the patch, please use spaces instead. Thanks, Piotr

3 3

Re: msvcp90: Add complex_float << implementation
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > --- > dlls/msvcp90/ios.c | 28 ++++++++++++++++++++++++++++ > dlls/msvcp90/msvcp90.spec | 4 ++-- > 2 files changed, 30 insertions(+), 2 deletions(-) > > This implementation is not behaving well in following case: complex<float> c = complex<float>(3.1, -0.5); cout.width(20); cout << c << endl; The width should affect whole complex value instead of first float. Cheers, Piotr

2 2

Re: [3/3] mshtml/tests: Add tests for modifying IHTMLTable.
by Jacek Caban 15 Aug '14

15 Aug '14

Hi Zhenbo, On 07/29/14 11:08, Zhenbo Li wrote: > To avoid affecting other tests, I squashed the tests for > insertRow / deleteRow. It would be interesting that the table not only contains given row, but also it is in the right place. For that I'd suggest to have test_table_rows_length, to test that the size changed, and another helper that would check if given row has expected id (or that a row with given id is in the right place). Cheers, Jacek

2 1

Re: [PATCH 7/7] vbscript: Implemented Atn(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Sqr(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8489 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Log(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Exp(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8487 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Tan(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8486 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Sin(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8485 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8484 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Jacek Caban 14 Aug '14

14 Aug '14

On 08/14/14 17:23, Shuai Meng wrote: > Change log: > Applied cleanly. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 19 +++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > Please add some tests for values other than trivial cases. You may want to add PI constant and a helper (like almostEqual) to deal with precision problems. Same applies to other patches from this series. Also, for functions (like atan) that have invalid arguments, I'd like to see tests of them. Jacek

1 0

Re: [PATCH 2/2] vbscript: Implemented Int(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8483 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Fix(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8482 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 7/7] vbscript: Implemented Atn
by Thomas Faber 14 Aug '14

14 Aug '14

> static HRESULT Global_Ant(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) Perhaps you want to use this opportunity to fix the typo in the function name too? ;)

2 1

Re: mshtml: Added IHTMLInputElement::readOnly property.
by Jacek Caban 14 Aug '14

14 Aug '14

Hi Zhenbo, On 08/14/14 16:08, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlinput.c > +++ b/dlls/mshtml/htmlinput.c > @@ -389,15 +389,33 @@ static HRESULT WINAPI HTMLInputElement_get_defaultValue(IHTMLInputElement *iface > static HRESULT WINAPI HTMLInputElement_put_readOnly(IHTMLInputElement *iface, VARIANT_BOOL v) > { > HTMLInputElement *This = impl_from_IHTMLInputElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLInputElement_SetReadOnly(This->nsinput, v != VARIANT_FALSE ? TRUE : FALSE); Remove "? TRUE : FALSE" part. Jacek

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2014