-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 2015-01-15 um 12:55 schrieb Alex Henrie:
> + DVCOMPRESSIONINFO data[32];
I can't really find any documentation about this. Is there a
documented maximum number of elements returned?
> + int i, j;
Afaics you can make those unsigned.
> + LPWSTR string_loc;
Is the use of the LPFOO type intentional?
> + if(GetCompressionTypes(iface, NULL, NULL, NULL, 0) == E_NOTIMPL)
> + {
> + skip("%s: GetCompressionTypes not implemented\n", name);
> + return;
> + }
I think todo_wine ok(0, "GetCompressionTypes not implemented") is
better here, but I don't particularly mind since you remove it in the
next patch anyway.
> + ok(data_size > sizeof(DVCOMPRESSIONINFO) && data_size < sizeof(data) - 1,
> + "%s: tests[%i]: expected data_size between %i and %i got data_size=%i\n",
> + name, i, sizeof(DVCOMPRESSIONINFO), sizeof(data) - 1, data_size);
data_size is unsigned, you should use %u instead of %i. Same for i and
j once you change them to unsigned.
> + string_loc = (LPWSTR)((char*)data + num_elements * sizeof(DVCOMPRESSIONINFO));
It's interesting that native places the string in the same data blob,
but it kinda makes sense. I think (WCHAR *)(data + num_elements) or
(WCHAR *)&data[num_elements] should work as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBAgAGBQJUt7l0AAoJEN0/YqbEcdMwf/sQAIGsh8jbGM7AsbdeHt5uEJUD
AGGg9OcqrDnW0PoCd5w36G70tNF/NFMRleNJ0tOL4r3HG8TD16BDXCkxW/U9hR7G
6c+DGAqnOFG0y6CjSAMGSvRh5VZVrD5OlI4XRTNFqYdL1QkVD0yQ/kXQl8YsvMUu
x/sWJ1kF4FCcojmmhIP5tSo6AmZJlso18tlOReCBBnHDkdq+0ej8ltR/pG0NmZUp
3eOdSfyHd0Swc9P8nLossRKbieORr88fE0ZUBP7oOtg2JbLfs3l/F4fudbPoMF8v
5JbJXD+KuHdNvGYBJ2ppHEZCUC2ArHEYgMW0m2ffRoWfoXmrJCUE8AnJsyHsjaYI
LFRiRGom7kRjoY8fhbTSJWdNTKLbW5swAiCzW7A+NkQvrXn5dcL2kZVpi2Z4x1gu
1JKYmb5G9G6SG+U4wblTWET4RWv5rAzoNeXvDZtznBW/KinnkNX2Ic7kug1/usqj
ATJ9q8ARt+3DMPYRonk7sXzFdyRRXhlCROlBvqHBkPitVz3tLxvziB/4C1SZ9ybu
wy28DMfEYfwbi/9iQnaHsn+811d7uf85QkKgiV6CBvS8XJ2xVzvHWnSWlbc0wNj1
/Gy5gCuKkluFWbJJjAliAf6+uHIypvBbFr85/Gn3gQy/tNUOH4FFSXPB18XrBXh3
CFH+vOFS/SN8fEA6WOtw
=EJNM
-----END PGP SIGNATURE-----