wine-devel February 2015

wine-devel@winehq.org

58 participants
166 discussions

Re: mshtml: Fix fire BeforeNavigate event for app: protocol
by Jacek Caban 10 Feb '15

10 Feb '15

On 02/09/15 07:08, Changhui Liu wrote: > - if(window->doc_obj && window->doc_obj->webbrowser && window == window->doc_obj->basedoc.window) { > + if(window->doc_obj && window->doc_obj->webbrowser && > + ((window == window->doc_obj->basedoc.window) || (window->parent == window->doc_obj->basedoc.window))) { > DWORD post_data_len = request_data ? request_data->post_data_len : 0; > void *post_data = post_data_len ? request_data->post_data : NULL; > const WCHAR *headers = request_data ? request_data->headers : NULL; The change on its own is wrong. There is nothing special about direct child of top HTML window. Ideally, we should call FireBeforeNavigate2 for all HTML windows, but use super_navigate only for the main one. This means that the if you change should not check which window we're in at all. However, for other windows, we need to pass proper frame name there. Let me know if you need more details. Cheers, Jacek

1 0

Re: [2/6] dxgi: Add interface for IDXGISurface1
by Stefan Dösinger 10 Feb '15

10 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Martell, There are a few things in Henri's list of fixes that are still missing here: Am 2015-02-09 um 10:28 schrieb Martell Malone: > Subject: [PATCH 2/6] dxgi: Add interface for IDXGISurface1 "include:" instead of "dxgi". > + uuid( 4ae63092-6327-4c1b-80ae-bfe12ea32b86), You have an extra space here. > + [out] HDC* hdc HDC *hdc, or even better HDC *dc. We avoid the Hungarian notification Microsoft once used, e.g. things like DWORD dwNumber. HDC hdc is the same kind of thing, although it's a bit of a special case. Patch 3: > +typedef struct DXGI_OUTDUPL_MOVE_RECT { > + POINT SourcePoint; > + RECT DestinationRect; > +} DXGI_OUTDUPL_MOVE_RECT; { placement . You also have FOO* bar; vs FOO *bar; issues in this patch. > + [in] IUnknown* pDevice, > + [in] IUnknown* pWindow, > + [in] const DXGI_SWAP_CHAIN_DESC1* pDesc, pStuff The same things also occur in patches 4, 5, and 6. Patch 4: > + [size_is(count_levels)] const D3D_FEATURE_LEVEL* levels, > + UINT count_levels, You are mixing count_* and *_count in patches 4, 5 and 6. For consistency's sake please make this *_count consistently. Patch 6: > +} > \ No newline at end of file Is this intentional? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU2eMXAAoJEN0/YqbEcdMwUmYP/A8I/1UBVqcynhIJ5qIvVTl4 sf3XQcWTmgI40JurL4D1mIaQMH+VeulQ7Jeroo9L9/WhIw1RRJ7R0jFULxZIu9tP VX5AyTVjd555jbt9DvlbmkaAicb0UuX7xSO5OelkkdwtdfuDCKnDq2+LxzXA2fXw y98vlT98meapIP5BzERMyAAyM0AkvpAMaxkBabE9w9Mj6IJUWteHQEwa2iavu0HR wBr/KotHXu/nqVD41PTYnAsyQoWeBNPBghg4RyqI42YKiOnDxuApOT9nAgewwHPA VghOW/hdlZahCZc+/Vst01pD7Sa7vS/Nuq4iDfJJVofSsXgwIdl5KT63eAOzR4Dl MefDKrEBmdTh44K/JeyCey1Rb4o6fNtPCQJV6lqXQkiHVeE/8IW8qPLectwuGPVd UtC7Fy38iR4UpDJBmPGypdZaFJzS2ZF1hO+mA/jJhOnefyL31vCeFWU+bf5ISuwo TDEGu7G/8yBpY+HKHr+++IwJlJKkEngf98ksjnyRC1PpIner05XHUDeu1PIll/FS T3aveyW5lWsyVGCyyovHLQIxfkaV6JPqR/AsuTuhDmhZu4ZQPoGLH5kpfrAhgVMA TeLGoR6RtTMOyFLob4sRI9nBR89H/UiEQ++fGbp/YXsOLnOZBJvn6y8AYh6zaeD5 6smvq4QiqsuQQS3tSC+f =CmBk -----END PGP SIGNATURE-----

2 3

Problem in compiling wine on 64 bit system
by Ali Aminian 10 Feb '15

10 Feb '15

Hello wine community I have some difficulty compiling wine on 64 bit ubuntu 14.04. I'm following the guide in http://wiki.winehq.org/Wine64 which i also replicate here: cd $HOME mkdir wine64 cd wine64 ../wine-git/configure --enable-win64 make > make.log 2>&1 cd .. mkdir wine32 cd wine32 ../wine-git/configure --with-wine64=../wine64 make > make.log 2>&1 #make install #cd ../wine64 #make install I can build the wine64 without any difficulty except that after configuration it prompts me that i don't have libhal, but i just ignored that. But when i get into win32 it gives me numerous warning that 32-bit development files not found, and some option will be disabled. for example: ************************************************************************************************** configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: pcap 32-bit development files not found, wpcap won't be supported. configure: libdbus 32-bit development files not found, no dynamic device support. configure: lib(n)curses 32-bit development files not found, curses won't be supported. configure: libsane 32-bit development files not found, scanners won't be supported. configure: liblcms2 32-bit development files not found, Color Management won't be supported. configure: libz 32-bit development files not found, data compression won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled configure: libcapi20 32-bit development files not found, ISDN won't be supported. configure: libcups 32-bit development files not found, CUPS won't be supported. configure: fontconfig 32-bit development files not found, fontconfig won't be supported. configure: libgsm 32-bit development files not found, gsm 06.10 codec won't be supported. configure: libtiff 32-bit development files not found, TIFF won't be supported. configure: libmpg123 32-bit development files not found (or too old), mp3 codec won't be supported. configure: libopenal 32-bit development files not found (or too old), OpenAL won't be supported. configure: libldap (OpenLDAP) 32-bit development files not found, LDAP won't be supported. ******************************************************************************************************** [important] and when i try to install 32 bit version of these libraries using aptitude (since using apt-get just says unmet dependencies and exits) it tries to remove my 64 bit version of the same library. for example: ***************************************************************************************************** ali@ali-Vostro-1520:~/other_drive/wine32$ sudo aptitude install libxi-dev:i386 The following NEW packages will be installed: libxi-dev:i386{b} 0 packages upgraded, 1 newly installed, 0 to remove and 1 not upgraded. Need to get 204 kB of archives. After unpacking 638 kB will be used. The following packages have unmet dependencies: libxi-dev : Conflicts: libxi-dev:i386 but 2:1.7.1.901-1ubuntu1 is to be installed. libxi-dev:i386 : Conflicts: libxi-dev but 2:1.7.1.901-1ubuntu1 is installed. The following actions will resolve these dependencies: Remove the following packages: 1) libatspi2.0-dev 2) libgtk2.0-dev 3) libxi-dev 4) libxtst-dev Accept this solution? [Y/n/q/?] y ******************************************************************************************************** [important] In one of these 32 bit installation aptitude removed my wine1.7 package and now i can't even install wine from official wine repository. so my questions are: 1_how you guys setup your environment for wine development? 2_how you deal with package managers when it acts weird?

2 1

Re: [PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)
by Alexandre Julliard 10 Feb '15

10 Feb '15

Matteo Bruni <mbruni(a)codeweavers.com> writes: > @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name ) > *func_ptr = driver_func; > } > > + if (!strcmp(name, "glGetStringi")) > + return (void *)glGetStringi; It seems to me you could handle this one through the extension table instead of special casing it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winecfg: Double click in dlls list to edit overides; fix indent. (try 2)
by Andrew Eikum 10 Feb '15

10 Feb '15

On Fri, Feb 06, 2015 at 10:23:15AM +0800, Hao Peng wrote: > Add a feature to winecfg. User can double click in dlls list to edit overides of selected item. > > the indent of code here mixed with tabs, 4 spaces and 8 space. I formated it to match the style of the rest code. > Usually we don't take patches that change nothing except formatting. I think your first patch was rejected because it adds even more inconsistent formatting. The indent is too small. The "case CBN_DBLCLK" line should be indented the same as the "case LBN_SELCHANGE" line. Instead it's indented 8 spaces when it should be indented 16 spaces. Andrew

1 0

Re: [2/6] dxgi: Add interface for IDXGISurface1
by Jacek Caban 10 Feb '15

10 Feb '15

Hi Martell, On 02/09/15 10:28, Martell Malone wrote: > + uuid( 4ae63092-6327-4c1b-80ae-bfe12ea32b86), > + local, > + pointer_default(unique) > +] > +interface IDXGISurface1 : IDXGISurface Once again, please make sure that your patches builds before sending patches. ../tools/widl/widl -o dxgi.h -m32 -I. -I../include -D__WINESRC__ dxgi.idl dxgi.idl:175: error: syntax error, unexpected aKNOWNTYPE, expecting tIMPORT Jacek

2 1

Re: rpcrt4: add a stub for I_RpcBindingInqLocalClientPID
by Dmitry Timoshkov 10 Feb '15

10 Feb '15

Austin English <austinenglish(a)gmail.com> wrote: > +RPC_STATUS WINAPI I_RpcBindingInqLocalClientPID(RPC_BINDING_HANDLE ClientBinding, unsigned long *ClientPID) > +{ > + FIXME("%p %p: stub\n", ClientBinding, ClientPID); > + return RPC_S_INVALID_BINDING; > +} This can't work under all platforms for obvious reasons. -- Dmitry.

2 1

Problem in compiling wine on 64 bit system
by Ali Aminian 10 Feb '15

10 Feb '15

1 0

(no subject)
by The Cheese 09 Feb '15

09 Feb '15

Hi, I'm a newbie. I would really like to help with the development of Wine in any capacity I can. The thing is, I looked over the bugzilla and various ways to get the stacktrace, etc. However, finding the cause simply by looking at address calls and returns eludes me. Is there something which might help me get there faster, for eg: reading up on instruction sets on x86 chipsets etc? I've already looked over the winedev-guide. Thanks for any help.

2 1

Re: [PATCH 1/4] wine-headers: add a winapifamily header
by Martell Malone 09 Feb '15

09 Feb '15

> > First, the 1/4 patch is really something you'll have to convince > Alexandre of it's the right thing to do. The easiest way is probably > to ask him about it on IRC. The amount of advice I can give on that > one is limited, but it would probably help if you could show why Wine > needs the winapifamily mechanism. The best way to do that may very > well just be to show that applications need e.g. the > WINAPI_FAMILY_DESKTOP_APP constant to compile against the Wine > headers. > I will ask him on IRC. Yes well it would be more correct to have the header in the case where a program uses that ifdef So this would match the official instructions from MS on using different api's I could also imagine that you'll be asked to partition the > other Wine headers as well if we're going to have this mechanism in > Wine. I.e., I don't think it makes a lot of sense to only do this for > a couple of dxgi headers, but not for anything else. The prefix for > the subject should be "include:". I'd move this patch to the end of > the series. > Initially I would have only done the dx stuff because mingw-w64 shares those headers. Essentially they Jacek Caban pulls in the d3d11 headers and idls from wine in to mingw-w64 to update. I could update the mingw-w64 project with the changes but I didn't want to leave wine out of the loop. I do understand that all headers would need to be partitioned to support this eventually. I was hoping the start would be with directx > The comment is pretty superfluous. > I can take it out. In patch 2/4, you have unrelated style changes for e.g. > IDXGIDevice2::OfferResources() > . I happen to like the new style better, > but please don't do that. First add the new stuff, then send a patch > to make the existing stuff consistent with dxgi.idl at the end of the > series. > Sure I can do that Some general style stuff: > - I think "{" on the same line for enum/struct/interface declarations is > ugly. > - Use "DXGI_OUTDUPL_DESC *desc" instead of "DXGI_OUTDUPL_DESC* desc", > etc. > - There are a couple of parameter naming issues. e.g. "pDevice", > "colorSpace", "pStats", "Data", etc. > - I prefer the order of things to be macros/constants, enums, > structs, interfaces, functions instead of having those interleaved > through the header. > - "FLOAT" -> "float", "LPCWSTR" -> "const WCHAR *" > - "num_*" -> "*_count" > > The prefix for the dxgi IDL patches should be "dxgi:", for the d3d11 > one it should be "d3d11:". > Seems easy enough to follow :) On Fri, Feb 6, 2015 at 1:05 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > I had a look at this series, and have a couple of comments. > > First, the 1/4 patch is really something you'll have to convince > Alexandre of it's the right thing to do. The easiest way is probably > to ask him about it on IRC. The amount of advice I can give on that > one is limited, but it would probably help if you could show why Wine > needs the winapifamily mechanism. The best way to do that may very > well just be to show that applications need e.g. the > WINAPI_FAMILY_DESKTOP_APP constant to compile against the Wine > headers. I could also imagine that you'll be asked to partition the > other Wine headers as well if we're going to have this mechanism in > Wine. I.e., I don't think it makes a lot of sense to only do this for > a couple of dxgi headers, but not for anything else. The prefix for > the subject should be "include:". I'd move this patch to the end of > the series. > > > +/* wine wants all the api's by default so we set to desktop + app */ > > +#ifndef WINAPI_FAMILY > > +#define WINAPI_FAMILY WINAPI_FAMILY_DESKTOP_APP > > +#endif > The comment is pretty superfluous. > > In patch 2/4, you have unrelated style changes for e.g. > IDXGIDevice2::OfferResources(). I happen to like the new style better, > but please don't do that. First add the new stuff, then send a patch > to make the existing stuff consistent with dxgi.idl at the end of the > series. > > Some general style stuff: > - I think "{" on the same line for enum/struct/interface declarations is > ugly. > - Use "DXGI_OUTDUPL_DESC *desc" instead of "DXGI_OUTDUPL_DESC* desc", > etc. > - There are a couple of parameter naming issues. e.g. "pDevice", > "colorSpace", "pStats", "Data", etc. > - I prefer the order of things to be macros/constants, enums, > structs, interfaces, functions instead of having those interleaved > through the header. > - "FLOAT" -> "float", "LPCWSTR" -> "const WCHAR *" > - "num_*" -> "*_count" > > The prefix for the dxgi IDL patches should be "dxgi:", for the d3d11 > one it should be "d3d11:". >

3 5

← Newer
1
...
10
11
12
13
14
15
16
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2015