Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13453
Your paranoid android.
=== build (build) ===
Patch failed to apply
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13452
Your paranoid android.
=== build (build) ===
Patch failed to apply
I have noticed that RtlCreateUserThread in dlls/ntdll.thread.c uses the
following call
pthread_attr_setstack( &attr, teb->DeallocationStack, (char
*)teb->Tib.StackBase - (char *)teb->DeallocationStack );
I have the source code from release 1.7.41.
I am working on a complex project that traces the execution of programs
running in Wine (won't go into detail here).
I have noticed problems in RtlCreateUserThread when services.exe is
launched in my environment.
Basically the …
[View More]call to pthread_create causes a SIGSEGV.
Let me make it clear that under ordinary conditions, Wine works fine.
Playing around with things, I note that if I change the call above to be
pthread_attr_setstacksize(&attr, 0x10000), then
I don't get the same problem.
My question is, why does the exact position of the stack need to be set in
this way?
[View Less]
+ WCHAR objectW[50]; /* should be enough*/
In the past I was told to always allocate memory in multiplies of 8
bytes,[1] and I personally have started to prefer powers of 2 in
particular. Alexandre seems to prefer allocating at least 64 characters
for short strings like this, judging from how he amended a proposed
patch of mine several years ago.[2]
+ if (!LoadStringW(OLEDLG_hInstance, IDS_VERBMENU_OBJECT, objectW, sizeof(objectW)/sizeof(WCHAR))) {
+ static const WCHAR enobjectW[]…
[View More] = {'&','O','b','j','e','c','t',0};
+ strcpyW(objectW, enobjectW);
+ }
Is this really necessary? How could LoadString fail? I recently
submitted a very similar patch [3] and didn't have to provide a special
fallback.
Just to be clear, I do really appreciate you taking the time to make
sure that Wine is properly localized :-) I just don't want to see the
codebase made unnecessarily complicated or inefficient.
-Alex
[1] https://www.winehq.org/pipermail/wine-devel/2011-December/093516.html
[2] https://source.winehq.org/git/wine.git/commitdiff/6e5bba1b60f97fce34415ea30…
[3] https://www.winehq.org/pipermail/wine-patches/2015-May/139132.html
[View Less]
On Thu, May 07, 2015 at 11:02:34PM +0300, Martin Storsjo wrote:
> +/***********************************************************************
> + * GetSystemTimePreciseAsFileTime (KERNEL32.@)
> + *
> + * Get the current time in utc format, with <1 us precision.
> + *
> + * RETURNS
> + * Nothing.
> + */
> +VOID WINAPI GetSystemTimePreciseAsFileTime(
> + LPFILETIME time) /* [out] Destination for the current utc time */
> +{
> + …
[View More]GetSystemTimeAsFileTime(time);
> +}
I don't know why this one's not getting in. I have a couple small
guesses.
Personally, I'm opposed to including a bunch of documentation in Wine.
I don't think Wine is the right place to document the Windows API. I
don't know if others feel this way, or if this is enough for
rejection.
You're also using VOID, LPJUNK, etc, which I think we're trying to
avoid these days.
Andrew
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13414
Your paranoid android.
=== wvistau64 (32 bit file) ===
file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820
=== wvistau64 (64 bit file) ===
file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13373
Your paranoid android.
=== build (build) ===
Patch failed to apply
In the attached picture, you can see, how the UI text differs for the simultaneously running WINE applications - notepad and winecfg. They both are running in the same WINEPREFIX and I expected to have the same appearance.
Why this happens and how I can make them to look the same?
Regards
--
http://fresh.flatassembler.nethttp://asm32.info
John Found <johnfound(a)asm32.info>
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13368
Your paranoid android.
=== wvistau64 (32 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue …
[View More]failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
=== w2008s64 (32 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
=== w7u (32 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
=== w8 (32 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
=== wvistau64 (64 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
=== w2008s64 (64 bit events) ===
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
events.c:1083: Test failed: get_returnValue failed: 80020008
events.c:1084: Test failed: unexpected returnValue
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=13361
Your paranoid android.
=== w8 (32 bit file) ===
file.c:407: Test failed: mismatched file size for L"WindowsUpdate.log"