wine-devel January 2016

wine-devel@winehq.org

71 participants
267 discussions

Re: [PATCH] winex11: Avoid inefficiency and overflow in remove_startup_notification.
by Alex Henrie 19 Jan '16

19 Jan '16

Could I get some feedback on this patch? I'd rather not have it drop off the list a second time, especially since Vincent already signed off on it: https://www.winehq.org/pipermail/wine-patches/2015-November/144119.html -Alex

2 1

Re: [PATCH 2/2] d3drm/tests: Add QueryInterface tests for IDirect3DRMTexture*.
by Henri Verbeet 19 Jan '16

19 Jan '16

On 18 January 2016 at 19:57, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + char *file = NULL; Why do you initialize this to NULL? > + BOOL check; > + > + > + hr = Direct3DRMCreate(&d3drm1); The extra empty line is weird. Is that intentional? > + file = create_bitmap(1, 1, TRUE); > + hr = IDirect3DRM_LoadTexture(d3drm1, file, &texture1); I think "file" is a bad name. I'd expect that to be a file handle or descriptor, not a string. > + ok(SUCCEEDED(hr), "Failed to load texture (hr = %x).\n", hr); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture interface (hr = %x)\n", hr); This looks like it was leftover from somewhere, but in either case it doesn't test what the message says it's testing. It's fairly harmless here, but %x is a bad format in most cases. E.g., is "1000" decimal 4096 or decimal 1000? Just use %#x. Ideally you'd also use the same message format as the other D3D tests. > + check = DeleteFileA(file); > + ok(check, "Cannot delete image stored in %s (error = %d).\n", file, GetLastError()); > +} You're leaking "file".

2 1

Re: [PATCH 1/2] d3drm: Fix QueryInterface for IDirect3DRMTexture*.
by Henri Verbeet 19 Jan '16

19 Jan '16

On 18 January 2016 at 19:57, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > - if (IsEqualGUID(riid, &IID_IDirect3DRMTexture2) > - || IsEqualGUID(riid, &IID_IDirect3DRMTexture) > + if (IsEqualGUID(riid, &IID_IDirect3DRMTexture) > + || IsEqualGUID(riid, &IID_IDirect3DRMVisual) > + || IsEqualGUID(riid, &IID_IDirect3DRMObject) > || IsEqualGUID(riid, &IID_IUnknown)) > { > + *out = &texture->IDirect3DRMTexture_iface; This isn't necessarily wrong, but it does seem weird. You return &texture->IDirect3DRMTexture_iface here for e.g. IUnknown, but the implementation then forwards to &texture->IDirect3DRMTexture3_iface. It seems more logical to return the IDirect3DRMTexture3 interface here directly. We also tend to check the "newest" IID first, in D3D code at least. I.e., IID_IDirect3DRMTexture3 before IID_IDirect3DRMTexture.

2 1

Re: winspool.drv: add EnumPrinterKeyA/W stubs
by Dmitry Timoshkov 19 Jan '16

19 Jan '16

Austin English <austinenglish(a)gmail.com> wrote: > +DWORD WINAPI EnumPrinterKeyW(HANDLE printer, const WCHAR *key, WCHAR *subkey, DWORD size, DWORD *ret); > +DWORD WINAPI EnumPrinterKeyW(HANDLE printer, const WCHAR *key, WCHAR *subkey, DWORD size, DWORD *ret); > +#define EnumPrinterKey WINELIB_NAME_AW(EnumPrinterKey) This doesn't look right. -- Dmitry.

2 1

Re: [PATCH 5/5] d3d8/tests: Block validation checks the surface size too.
by Marvin 18 Jan '16

18 Jan '16

1 0

Re: [PATCH 4/5] ddraw/tests: Port test_lockrect_invalid to other versions.
by Marvin 18 Jan '16

18 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19763 Your paranoid android. === wxppro (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === w2003std (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === wvistau64 (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === w2008s64 (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === w7u (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === w7pro64 (32 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 00461957 === w1064 (32 bit ddraw4) === ddraw4.c:2523: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === wvistau64 (64 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 0000000000457AC7 === w2008s64 (64 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 0000000000457AC7 === w7pro64 (64 bit ddraw4) === ddraw4.c:10352: Test failed: Failed to create surface, hr 0x88760233. ddraw4: unhandled exception c0000005 at 0000000000457AC7 === wxppro (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === w2003std (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === wvistau64 (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === w2008s64 (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === w7u (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === w7pro64 (32 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 0043A6FE === w1064 (32 bit ddraw2) === ddraw2.c:2338: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === wvistau64 (64 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00000000004356FB === w2008s64 (64 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00000000004356FB === w7pro64 (64 bit ddraw2) === ddraw2.c:9182: Test failed: Failed to create surface, hr 0x88760233. ddraw2: unhandled exception c0000005 at 00000000004356FB === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === wxppro (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === w2003std (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === wvistau64 (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === w2008s64 (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === w7u (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === w7pro64 (32 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 004147C8 === w1064 (32 bit ddraw1) === ddraw1.c:2187: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === wvistau64 (64 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0000000000413727 === w2008s64 (64 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0000000000413727 === w7pro64 (64 bit ddraw1) === ddraw1.c:8079: Test failed: Failed to create surface, hr 0x88760233. ddraw1: unhandled exception c0000005 at 0000000000413727 === wxppro (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === w2003std (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === wvistau64 (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === w2008s64 (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === w7u (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === w7pro64 (32 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 004985FD === w8 (32 bit ddraw7) === ddraw7.c:10650: Test failed: Lock returned 0 for rect [68, 60]->[60, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 68]->[68, 60], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-8, 60]->[0, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -8]->[68, 0], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-16, 60]->[-8, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -16]->[68, -8], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[136, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[68, 136], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [136, 60]->[144, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 136]->[68, 144], type managed texture. === w864 (32 bit ddraw7) === ddraw7.c:10650: Test failed: Lock returned 0 for rect [68, 60]->[60, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 68]->[68, 60], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-8, 60]->[0, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -8]->[68, 0], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-16, 60]->[-8, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -16]->[68, -8], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[136, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[68, 136], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [136, 60]->[144, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 136]->[68, 144], type managed texture. === w1064 (32 bit ddraw7) === ddraw7.c:2254: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:10650: Test failed: Lock returned 0 for rect [68, 60]->[60, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 68]->[68, 60], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-8, 60]->[0, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -8]->[68, 0], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-16, 60]->[-8, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -16]->[68, -8], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[136, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[68, 136], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [136, 60]->[144, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 136]->[68, 144], type managed texture. === wvistau64 (64 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 000000000048753F === w2008s64 (64 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 000000000048753F === w7pro64 (64 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x88760233. ddraw7: unhandled exception c0000005 at 000000000048753F === w864 (64 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10650: Test failed: Lock returned 0 for rect [68, 60]->[60, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 68]->[68, 60], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-8, 60]->[0, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -8]->[68, 0], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-16, 60]->[-8, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -16]->[68, -8], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[136, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[68, 136], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [136, 60]->[144, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 136]->[68, 144], type managed texture. === w1064 (64 bit ddraw7) === ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10616: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:10650: Test failed: Lock returned 0 for rect [68, 60]->[60, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 68]->[68, 60], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-8, 60]->[0, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -8]->[68, 0], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [-16, 60]->[-8, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, -16]->[68, -8], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[136, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 60]->[68, 136], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [136, 60]->[144, 68], type managed texture. ddraw7.c:10650: Test failed: Lock returned 0 for rect [60, 136]->[68, 144], type managed texture.

1 0

Re: [PATCH 6/7] wined3d: Recognize SM4 _sat instruction modifier.
by Henri Verbeet 18 Jan '16

18 Jan '16

On 18 January 2016 at 21:16, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -909,6 +919,7 @@ static void shader_sm4_read_instruction(void *data, const DWORD **ptr, struct wi > ins->handler_idx = WINED3DSIH_TABLE_SIZE; > return; > } > + priv->dst_param[i].modifiers |= instruction_dst_modifier; This is fine, although I wonder if you considered making saturation an instruction modifier on the wined3d_shader_instruction side instead?

2 1

steam web browsing on OS X
by Theodore Dubois 18 Jan '16

18 Jan '16

Wine Staging includes some patches to fix Steam web browsing, but they are deactivated on Mac because they apparently require special build flags. Does anyone know what this refers to? ~Theodore

5 15

Re: [PATCH] user32: Allow WM_CAPTURECHANGE indicating SetCapture() parameter.
by Alexandre Julliard 18 Jan '16

18 Jan '16

Christopher Thielen <cthielen(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=13683 > > A window may be notified with WM_CAPTURECHANGED about itself > gaining mouse capture if it calls SetCapture() twice. You'd need to review all places where we handle that message, I don't think we've taken that behavior into account. Because of this risk, I'm afraid it will have to wait until after code freeze. -- Alexandre Julliard julliard(a)winehq.org

4 7

Re: [PATCH v3] usp10: rewrite ScriptXtoCP
by Marvin 18 Jan '16

18 Jan '16

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2016