wine-devel December 2016

57 participants
120 discussions

Re: [PATCH 2/4] ddraw: Subtract framebuffer size from reported available video memory.
by Henri Verbeet 19 Dec '16

19 Dec '16

On 18 December 2016 at 00:22, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + INT64 total_vidmem, free_vidmem; ... > + free_vidmem = wined3d_device_get_available_texture_mem(ddraw->wined3d_device); > + *free = max(0, free_vidmem - framebuffer_size); This works, but it seems a little silly to use INT64 to avoid writing something along the lines of "*free = framebuffer_size > free_vidmem ? 0 : free_vidmem - framebuffer_size;".

1 0

Wined3d textureless rendering
by Bruno Jesus 18 Dec '16

18 Dec '16

Hello everyone. Following my email last year email asking if rendering in wireframe could speedup a game (answer was no in many different ways) I have a new idea after playing Totaly Accurate Battle Simulator with its red and blue army. What if I skip applying every texture to every object? Probably everything would be black so I would need to use different incremental solid color to distinguish stuff in the screen. Would that save memory and also make games faster? Remembering that my 3D knowledge didn't change much so, basically zero + wireframe knowledge from previous email ;-) Best wishes, Bruno

2 2

[OT] Machine learning for automatical GUI testing
by Qian Hong 18 Dec '16

18 Dec '16

Hi folks, I was falling into machine learning recently and I think I'd like to share some ideas. Here is one of them: quote: ``` Universe allows an AI agent to use a computer like a human does: by looking at screen pixels and operating a virtual keyboard and mouse. We must train AI systems on the full range of tasks we expect them to solve, and Universe lets us train a single agent on any task a human can complete with a computer. ``` Reference: https://openai.com/blog/universe/ Reinforcement Learning is the powerful algorithm used by AlphaGo which won the Go chess game this year against world class master. OpenAI Universe is a good environment to train Reinforcement Learning program's skill on software UI testing. We might want to follow the latest progress from OpenAI Universe community to see if there is anything useful for Wine development / testing. I know people tried GUI auto testing years ago but was not very happy with that, however this time with the revolution of machine learning, interesting thing could happen, finally. Any one want to discover more potential on using machine learning to improve Wine? This might not be practical in one month, but could be very powerful in long term, like 3 years or more. There could be multiple possible ways, not only GUI testing, but none is easy today. Other interesting reading: https://openai.com/blog/universe/ https://gym.openai.com/ Cheers! -- Regards, Qian Hong

1 0

Re: [Tools] testbot: Skip ntdll:exception on the Windows 10 VM.
by Francois Gouget 16 Dec '16

16 Dec '16

On Fri, 16 Dec 2016, Francois Gouget wrote: [...] > - $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\"\r\n" . > + my $Ignore = ($VM->Name eq "w1064" ? "-n ntdll:exception" : ""); > + $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\" $Ignore\r\n" . > "$FileName -q -s $RptFileName\r\n"; This should not be needed after all. The trick is not to upgrade QEMU, Windows 10, the host kernel, change the emulated CPU or switch to emulating USB 3. The trick is: echo 1 >/sys/module/kvm/parameters/ignore_msrs Once you've noticed the following lines in the host's kernel log and done a Google search: Dec 16 13:43:48 vm3 kernel: [ 191.624802] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0bf3 kvm_set_msr_common: MSR_IA32_DEBUGCTLMSR 0x1, nop Dec 16 13:43:48 vm3 kernel: [ 191.624835] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0c5c unhandled rdmsr: 0x1c9 https://www.reddit.com/r/VFIO/comments/42dj7n/some_games_crash_to_biosboot_… Now as to why another Windows 10 VM seemed to get magically fixed by the AEMU upgrade (from 2.1 to 2.7) and did not require this hack is another mystery. But one I can live with. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 3/7] d3d11/tests: Add workaround for bug in AMD Windows driver.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 59 +++++++++++++++++++++++++++--------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) > Unfortunately this makes it fail on Wine for me, probably because the initial texture data is undefined.

2 2

Re: [PATCH 7/7] wined3d: Make total video memory limit optional.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > It's enough to enable this workaround for ddraw. > So would it then also be enough to just fixup things in ddraw7_GetAvailableVidMem()? In fact, the documentation suggests that's actually the proper place, and that this shouldn't be specific to the Windows version. You could probably use wined3d_get_adapter_display_mode() together with wined3d_calculate_format_pitch() to calculate the primary surface size.

2 2

Re: [PATCH v2 14/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 15 Dec '16

15 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The test was slightly changed. If it still fails the failures should be more > clear now after "d3d11/tests: Print expected result in case of failures in > check_texture_sub_resource_*() functions." > Still fails: d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. So I investigated this a little, and the issue seems to be that as soon as D3D11_BIND_SHADER_RESOURCE is in the bind flags, reads from the depth texture return stale values. E.g., the failure at line 6563 is from the 0.6f written by the clear at line 6544. This can also be reproduced by calling check_texture_float() directly on the depth texture, and is not specific to typeless formats. I'd guess at a driver bug related to e.g. compressed depth or fast clear handling. Regardless, I'd expect that using separate resources for the clear and the shader reads would fix the failures, although it would perhaps weaken the test a little.

3 4

Re: [PATCH] d3dx9: Fix a typo in TRACE() message.
by Matteo Bruni 15 Dec '16

15 Dec '16

2016-12-12 11:21 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > @@ -750,7 +750,7 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX *pout, const D3DXVECTOR3 > D3DXQUATERNION prc; > D3DXVECTOR3 psc, pt; > > - TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcentr %p, protation %p, ptranslation %p\n", > + TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcenter %p, protation %p, ptranslation %p\n", > pout, pscalingcenter, pscalingrotation, pscaling, protationcenter, protation, ptranslation); > > if ( !pscalingcenter ) It would be nice to clean up the function while at it (add the missing period at the end of the trace, drop the useless 'p' prefix from all the parameters and most of the local variables, fix and split the function prototype over multiple lines, remove the spaces around the if condition, ...) IMO better if you send a v2 with the cleanups after Wine 2.0.

1 0

Re: [PATCH v2 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 15 Dec '16

15 Dec '16

Hi, On 12/14/16 18:18, Lauri Kenttä wrote: > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i] + 4, zeros[i], zeros[i] + 5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = U+%04X: got %d, expected 405\n", zeros[i], (int)res); > + tmp[1] = zeros[i] + 10; > + res = p_wcstoi64(tmp, NULL, 0); Please change the line to: res = p_wcstoi64(tmp, NULL, 16); Currently you don't test if zeros[i]+10 is recognized as valid digit. Except of that the patches are looking good for me. Are these patches fixing any bugs? Is any application working thanks to them (I'm asking because of the code freeze)? Thank you, Piotr

2 2

Re: [PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall
by Dmitry Timoshkov 15 Dec '16

15 Dec '16

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 > +IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi ... > +#include <shlwapi.h> ... > - info->regroot = root; > + info->regroot = SHRegDuplicateHKey(root); Adding a whole new import just because of a simple RegOpenKeyEx() wrapper is not really justified. -- Dmitry.

2 1

← Newer
1
2
3
4
5
6
7
...
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel December 2016