wine-devel April 2016

wine-devel@winehq.org

53 participants
293 discussions

Start a nNew thread

Re: [2/5] wininet/tests: Add tests for asynchronous InternetReadFileEx. (v2)
by Marvin 26 Apr '16

26 Apr '16

1 0

Re: [PATCH 2/5] qedit: Stub out AMTimelineObj.
by Nikolay Sivov 26 Apr '16

26 Apr '16

On 26.04.2016 6:09, Alex Henrie wrote: > Cc: Andrew Eikum <aeikum(a)codeweavers.com> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/qedit/Makefile.in | 3 +- > dlls/qedit/qedit_private.h | 2 + > dlls/qedit/tests/timeline.c | 3 - > dlls/qedit/timeline.c | 10 +- > dlls/qedit/timelineobj.c | 470 ++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 482 insertions(+), 6 deletions(-) > create mode 100644 dlls/qedit/timelineobj.c I think it's better to add this to timeline.c. > > diff --git a/dlls/qedit/timeline.c b/dlls/qedit/timeline.c > index 52123a7..0398f28 100644 > --- a/dlls/qedit/timeline.c > +++ b/dlls/qedit/timeline.c > @@ -129,8 +129,14 @@ static HRESULT WINAPI Timeline_IAMTimeline_CreateEmptyNode(IAMTimeline *iface, I > TIMELINE_MAJOR_TYPE type) > { > TimelineImpl *This = impl_from_IAMTimeline(iface); > - FIXME("(%p)->(%p,%04x): not implemented!\n", This, obj, type); > - return E_NOTIMPL; > + HRESULT hr; > + > + TRACE("(%p)->(%p,%04x)\n", This, obj, type); > + > + hr = AMTimelineObj_create(type, obj); > + if (FAILED(hr)) return hr; > + > + return S_OK; > } > You can simply 'return AMTimelineObj_create...;'. > + > +#include <assert.h> This one is not used. > +static ULONG WINAPI TimelineObj_inner_Release(IUnknown *iface) > +{ > + TimelineObjImpl *This = impl_from_IUnknown(iface); > + ULONG ref = InterlockedDecrement(&This->ref); > + > + TRACE("(%p) new ref = %u\n", This, ref); > + > + if (ref == 0) > + { > + CoTaskMemFree(This); > + return 0; > + } > + > + return ref; > +} Extra 'return 0;' does not add anything. > +HRESULT AMTimelineObj_create(TIMELINE_MAJOR_TYPE type, IAMTimelineObj **ppv) > +{ > + TimelineObjImpl* obj = NULL; No need to initialize it. > + > + TRACE("(%d,%p)\n", type, ppv); > + > + switch (type) > + { > + case TIMELINE_MAJOR_TYPE_COMPOSITE: > + case TIMELINE_MAJOR_TYPE_TRACK: > + case TIMELINE_MAJOR_TYPE_SOURCE: > + case TIMELINE_MAJOR_TYPE_TRANSITION: > + case TIMELINE_MAJOR_TYPE_EFFECT: > + case TIMELINE_MAJOR_TYPE_GROUP: > + break; > + default: > + return E_INVALIDARG; > + } What happens to returned pointer on type error? > + > + obj = CoTaskMemAlloc(sizeof(TimelineObjImpl)); > + if (NULL == obj) { > + *ppv = NULL; > + return E_OUTOFMEMORY; > + } > + ZeroMemory(obj, sizeof(TimelineObjImpl)); > + > + obj->ref = 1; > + obj->IUnknown_inner.lpVtbl = &timelineobj_vtbl; > + obj->IAMTimelineObj_iface.lpVtbl = &IAMTimelineObj_VTable; > + > + *ppv = &obj->IAMTimelineObj_iface; > + return S_OK; > +} > memset is not useful, you're setting all the fields anyway. Also, why do you need inner IUnknown for this object?

3 2

Re: kernel32/tests: Add initial tests for GetConsoleFontInfo (v3)
by Marvin 26 Apr '16

26 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22597 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 1511506268 console.c:1445: Test failed: [15] Expected output count to be 0, got 1511506268 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1511506268 console.c:1689: Test failed: [13] Expected output count to be 0, got 1511506268 console.c:1689: Test failed: [15] Expected output count to be 0, got 1511506268 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1511506268 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2670708688 console.c:1445: Test failed: [15] Expected output count to be 0, got 2670708688 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2670708688 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2670708688 console.c:1689: Test failed: [15] Expected output count to be 0, got 2670708688 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2670708688 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 795528606 console.c:1445: Test failed: [15] Expected output count to be 0, got 795528606 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 795528606 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 795528606 console.c:1689: Test failed: [15] Expected output count to be 0, got 795528606 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 795528606 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Windows 2000 VM timing out
by Hugh McMaster 26 Apr '16

26 Apr '16

The Windows 2000 VM is timing out with the following dialog message: kernel32_test.exe - Entry Point Not Found The procedure entry point InitializeSListHead could not be located in the dynamic link library kernel32.dll. For a screenshot, see https://testbot.winehq.org/JobDetails.pl?Key=22547&log_201=1&scrshot_201=1#… I'm not sure what the cause is. I sent a patch modifying a comment by one character and the same error occurs.

4 6

Re: [PATCH] winemac: Implement the WGL_WINE_query_renderer extension.
by Henri Verbeet 26 Apr '16

26 Apr '16

On 26 April 2016 at 10:29, Ken Thomases <ken(a)codeweavers.com> wrote: > + case WGL_RENDERER_UNIFIED_MEMORY_ARCHITECTURE_WINE: > + /* FIXME: not sure what this means */ Mostly whether the GPU has its own dedicated video memory that's not directly accessible by the CPU, or instead shares the memory between the CPU and GPU. > + case WGL_RENDERER_VERSION_WINE: > + /* FIXME: anything better we can return? */ If the driver doesn't have its own version number, the next best thing is probably the OS version number. This typically matches the final part of the GL_VERSION string.

4 4

Re: [PATCH v4 4/6] d3d11/tests: Add tests for 2D texture RTVs.
by Henri Verbeet 26 Apr '16

26 Apr '16

On 25 April 2016 at 12:25, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + hr = ID3D11Device_CreateBuffer(device, &buffer_desc, NULL, &context->ps_cb); > + ok_(__FILE__, line)(SUCCEEDED(hr), "Failed to create constant buffer, hr %#x.\n", hr); > + } > + > + ID3D11DeviceContext_PSSetShader(context->immediate_context, context->ps, NULL, 0); > + ID3D11DeviceContext_PSSetConstantBuffers(context->immediate_context, 0, 1, &context->ps_cb); > + > + ID3D11DeviceContext_UpdateSubresource(context->immediate_context, (ID3D11Resource *)context->ps_cb, 0, > + NULL, color, 0, 0); There isn't anything wrong with doing it like this, but note that you could also specify the initial contents when creating the buffer.

1 0

Re: [v3 PATCH 1/3] ucrtbase: Implement _initialize_onexit_table()
by Sebastian Lackner 26 Apr '16

26 Apr '16

On 26.04.2016 07:52, Nikolay Sivov wrote: > diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec > index a54a71a..96e0c3b 100644 > --- a/dlls/ucrtbase/ucrtbase.spec > +++ b/dlls/ucrtbase/ucrtbase.spec > @@ -419,7 +419,7 @@ > @ cdecl _i64tow(int64 ptr long) ntdll._i64tow > @ cdecl _i64tow_s(int64 ptr long long) MSVCRT__i64tow_s > @ cdecl _initialize_narrow_environment() > -@ stub _initialize_onexit_table > +@ cdecl _initialize_onexit_table() MSVCRT__initialize_onexit_table Did you accidentally send an old version?

1 0

Wine Smart Card handle
by Szili Péter 26 Apr '16

26 Apr '16

Hi I using Scard4Wine patch ( http://www.winehq.org/pipermail/wine-devel/2007-April/056432.html ) on Suse Leap 42.1 x64 and Ubuntu 16.04 desktop x86, and my Delphi 7 application, with wine. ( This is test sample program, which tests the smart card reader) http://www.topemail.hu/src/SCardSample.tar.gz Each of the two systems is the same problem: Delphi LoadLibrary() function can not load the winscard.dll. The patch replaces the under linux the /usr/lib/wine/winscard.dll.so With original winscard.dll.so can load the LoadLibrary(). Can someone idea of how the new winscard.dll.so could be used ? Best regards: Szili Péter szilipeter(a)topemail.hu ****************************

1 0

Re: [PATCH 2/2] inetcomm: Implement IMimeBody GetProp
by Marvin 26 Apr '16

26 Apr '16

1 0

Re: [PATCH 1/2] inetcomm: Implement IMimeBody SetProp
by Marvin 26 Apr '16

26 Apr '16

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel April 2016