wine-devel August 2016

wine-devel@winehq.org

55 participants
282 discussions

Re: [PATCH v8 1/3] shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.
by Sebastian Lackner 22 Aug '16

22 Aug '16

On 19.08.2016 11:43, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > v8 initializes V_ERROR(&var), item, item2, and i correctly. It also adds > checks that the test files were created and written successfully. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/tests/Makefile.in | 2 +- > dlls/shell32/tests/shelldispatch.c | 229 +++++++++++++++++++++++++++++++++++-- > 2 files changed, 219 insertions(+), 12 deletions(-) > I think this patch is unfortunately still a bit too noisy to be applied separately. If you want to keep the "bruteforce" tests I would suggest to move the implementation into the first patch, or alternatively change the FIXME to a TRACE. Besides that I am basically fine, although there are probably some ways how to improve the code style a bit further. Regards, Sebastian

2 2

Re: [PATCH v8 3/3] shell32: Implement FolderItems_get_Count.
by Sebastian Lackner 22 Aug '16

22 Aug '16

On 19.08.2016 11:43, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shelldispatch.c | 10 ++++++++-- > dlls/shell32/tests/shelldispatch.c | 6 ------ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c > index a456ad4..86b77d6 100644 > --- a/dlls/shell32/shelldispatch.c > +++ b/dlls/shell32/shelldispatch.c > @@ -1061,9 +1061,15 @@ static HRESULT WINAPI FolderItemsImpl_Invoke(FolderItems3 *iface, > > static HRESULT WINAPI FolderItemsImpl_get_Count(FolderItems3 *iface, LONG *count) > { > - FIXME("(%p,%p)\n", iface, count); > + FolderItemsImpl *This = impl_from_FolderItems(iface); > > - return E_NOTIMPL; > + TRACE("(%p,%p)\n", iface, count); > + > + if (!count) > + return E_INVALIDARG; The tests contain a comment which suggests that Windows does not do such checks. If this is true I would suggest to simplify it also here in your implementation. > + > + *count = This->item_count; > + return S_OK; > } > > static HRESULT WINAPI FolderItemsImpl_get_Application(FolderItems3 *iface, IDispatch **ppid) > diff --git a/dlls/shell32/tests/shelldispatch.c b/dlls/shell32/tests/shelldispatch.c > index dc4fda4..42cfbf7 100644 > --- a/dlls/shell32/tests/shelldispatch.c > +++ b/dlls/shell32/tests/shelldispatch.c > @@ -378,9 +378,7 @@ static void test_items(void) > r = FolderItems_get_Count(items, NULL); > > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(!lcount, "expected 0 files, got %d\n", lcount); > > V_VT(&var) = VT_I4; > @@ -435,9 +433,7 @@ todo_wine > > lcount = -1; > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(!lcount, "expected 0 files, got %d\n", lcount); > FolderItems_Release(items); > > @@ -455,9 +451,7 @@ todo_wine > > lcount = -1; > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(lcount == sizeof(file_defs)/sizeof(file_defs[0]), > "expected %d files, got %d\n", sizeof(file_defs)/sizeof(file_defs[0]), lcount); > >

2 1

Re: [PATCH 3/3] wpc: Register WindowsParentalControls class.
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 2/3] wpc: Added basic tests.
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 7/7] d3d9: Forbid display mode and back buffer mismatch in IDirect3DDevice9Ex_ResetEx().
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 6/7] d3d9: Allow passing "mode" to IDirect3DDevice9Ex_ResetEx() iff "Windowed" is FALSE.
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 5/7] d3d9/tests: Add test for IDirect3DDevice9Ex_ResetEx().
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 4/7] d3d9/tests: Restore display rotation in test_get_adapter_displaymode_ex().
by Marvin 22 Aug '16

22 Aug '16

1 0

Re: [PATCH 4/4 v2] d3d11: Add tests for WINED3DFMT_BC6H_UF16/SF16 formats.
by Marvin 22 Aug '16

22 Aug '16

2 1

Re: [PATCH resend 3/7] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25310 Your paranoid android. === w8 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480.

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel August 2016