January 2017 - wine-devel

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer 22 Nov '20

22 Nov '20

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong 28 Sep '18

28 Sep '18

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird 14 Jun '18

14 Jun '18

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

`setupapi` patch from staging
by Donat Enikeev 24 Apr '17

24 Apr '17

Hi Guys, Number of recent well-known games are based on Starling game engine (Adobe Air+Stage3D for gpu rendering), such as: The Banner Saga 2, Samorost 3, The Inner World, Angry Birds. They are are falling into Software rendering mode on plain Wine and thus barely playable (bug #41635) Thanks to Béla Gyebrószki finding @ bug #41653, Wine makes these games consider d3d9 rendering with the following single patch from wine-staging https://github.com/wine-compholio/wine-staging/blob/master/patches/setupapi… This patch implements support of the case when a full driver path is passed to SetupDiGetClassDevs (trace successfully reaching AddDeviceToSet for a game below [1]). I was unable to find @wine-devel discussion around this patch, I would be grateful if one could kindly remind why it was staged, probably it just requires refactoring around the change or additional tests? I am asking this, because Adobe stopped Linux support for the Air years ago and we could never see such games ported, and therefore plain Wine's support of gpu acceleration for such games looks important. Thanks in advance Best regards, Donnie [1] 0009:trace:setupapi:SetupDiGetClassDevsExW {4d36e968-e325-11ce-bfc1-08002be10318} L"PCI\\VEN_0000&DEV_0000" (nil) 0x0000000a (nil) (null) (nil) 0009:warn:setupapi:SetupDiGetClassDevsExW unsupported flags 0000000a 0009:trace:setupapi:SetupDiCreateDeviceInfoListExW {4d36e968-e325-11ce-bfc1-08002be10318} (nil) (null) (nil) 0009:trace:setupapi:SETUPDI_EnumerateDevices 0x464ac90, {4d36e968-e325-11ce-bfc1-08002be10318}, L"PCI\\VEN_0000&DEV_0000", 0000000a 0009:trace:setupapi:SETUPDI_EnumerateMatchingDeviceInstances L"PCI" L"VEN_0000&DEV_0000" 0009:trace:setupapi:SETUPDI_AddDeviceToSet 0x464ac90, {4d36e968-e325-11ce-bfc1-08002be10318}, 0, L"PCI\\VEN_0000&DEV_0000\\13&12345&0", 0

3 6

Re: include: Avoid overflow (warning) in RGBA_MAKE.
by Dmitry Timoshkov 26 Feb '17

26 Feb '17

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > --- a/include/d3dtypes.h > +++ b/include/d3dtypes.h > @@ -53,7 +53,7 @@ typedef LONG D3DFIXED; > #define RGBA_GETRED(rgb) (((rgb) >> 16) & 0xff) > #define RGBA_GETGREEN(rgb) (((rgb) >> 8) & 0xff) > #define RGBA_GETBLUE(rgb) ((rgb) & 0xff) > -#define RGBA_MAKE(r, g, b, a) ((D3DCOLOR) (((a) << 24) | ((r) << 16) | ((g) << 8) | (b))) > +#define RGBA_MAKE(r, g, b, a) ((D3DCOLOR) (((unsigned)(a) << 24) | ((r) << 16) | ((g) << 8) | (b))) This is a public header, probably you need to fix the callers of this macro instead. -- Dmitry.

3 4

Re: wine/test.h: Identify test result lines printed by child processes.
by Alexandre Julliard 18 Feb '17

18 Feb '17

Francois Gouget <fgouget(a)codeweavers.com> writes: > Currently the child process result lines are indistinguishable from the > main process one. This makes it impossible to automatically detect > when a process exits abruptly, i.e. without printing a result line, > if it has run a subprocess. By making the subprocess result lines > different analysis tools will detect that the main result line is > missing and automatically consider that the main process crashed, > thus marking the test as failed. > > Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> > --- > > This should fix bug 32354: > https://bugs.winehq.org/show_bug.cgi?id=32354 I don't think the test framework should be modifying the environment in all the tests. It already breaks some things: ../../../tools/runtest -q -P wine -T ../../.. -M msvcrt.dll -p msvcrt_test.exe.so environ && touch environ.ok environ.c:198: Test failed: Expected environment block pointer element to be non-NULL wine: Unhandled page fault on read access to 0x00000000 at address 0x7ed2a986 (thread 0074), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: kernel32: Avoid two potential buffer overflows of cStr in create_hardware_branch.
by Sebastian Lackner 12 Feb '17

12 Feb '17

On 08.10.2016 22:31, Gerald Pfeifer wrote: > + char cStr[sizeof(dent->d_name)+sizeof(procname_ide_media)], http://man7.org/linux/man-pages/man3/readdir.3.html says: """The standard also notes that the use of sizeof(d_name) is incorrect; use strlen(d_name) instead. (On some systems, this field is defined as char d_name[1]!)""" This means your solution will not work on all systems.

3 4

GSoC Ideas page
by André Hentschel 04 Feb '17

04 Feb '17

Hi, I just did the GSoC 2017 application for Wine, please update https://wiki.winehq.org/Summer_Of_Code with your Ideas and mention yourself as possible mentor where appropriate. Thanks!

3 2

Re: [PATCH] winealsa.drv: Fix handling of system real time MIDI messages
by Andrew Eikum 02 Feb '17

02 Feb '17

On Tue, Jan 31, 2017 at 04:16:17AM -0200, Bruno Jesus wrote: > MIDI spec at http://www.somascape.org/midi/tech/spec.html state that system real time messages "... are each single byte messages, with no following data bytes...", currently wine is prepending SYSEX header generating invalid messages. > Looking at this spec, should Tune Request be handled the same way as these system real time messages? I also noticed Reset is still handled as a SysEx after your patch. Should it be? Aside from that, I also noticed an old patch that unfortunately never got merged: https://www.winehq.org/pipermail/wine-patches/2013-January/121366.html If you understand this MIDI stuff a little bit, you might be a good person to review and re-submit that patch :) Thanks, Andrew

2 2

Re: xmllite: Add Unknown to map (Coverity)
by Nikolay Sivov 01 Feb '17

01 Feb '17

On 31.01.2017 1:11, André Hentschel wrote: > CID 1364307 > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/xmllite/reader.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c > index 1e3c7aa..f99ea66 100644 > --- a/dlls/xmllite/reader.c > +++ b/dlls/xmllite/reader.c > @@ -85,6 +85,7 @@ typedef enum > > static const WCHAR utf16W[] = {'U','T','F','-','1','6',0}; > static const WCHAR utf8W[] = {'U','T','F','-','8',0}; > +static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',0}; > > static const WCHAR dblquoteW[] = {'\"',0}; > static const WCHAR quoteW[] = {'\'',0}; > @@ -151,8 +152,9 @@ struct xml_encoding_data > }; > > static const struct xml_encoding_data xml_encoding_map[] = { > - { utf16W, XmlEncoding_UTF16, ~0 }, > - { utf8W, XmlEncoding_UTF8, CP_UTF8 } > + { utf16W, XmlEncoding_UTF16, ~0 }, > + { utf8W, XmlEncoding_UTF8, CP_UTF8 }, > + { unknownW, XmlEncoding_Unknown, ~0 }, > }; > > const WCHAR *get_encoding_name(xml_encoding encoding) > I don't think this fixes anything in a sense of making xmllite more compliant. We probably should just fail at CreateXmlWriterOutputWithEncodingName() and print encoding string that made it fail.

2 1

[v3 PATCH 00/10] x86: Enable User-Mode Instruction Prevention
by Ricardo Neri 01 Feb '17

01 Feb '17

This is v3 of this series. Again, it took me a while to complete the updates as support for virtual-8086 mode required extra rework. The two previous submissions can be found here [1] and here [2]. User-Mode Instruction Prevention (UMIP) is a security feature present in new Intel Processors. If enabled, it prevents the execution of certain instructions if the Current Privilege Level (CPL) is greater than 0. If these instructions were executed while in CPL > 0, user space applications could have access to system-wide settings such as the global and local descriptor tables, the segment selectors to the current task state and the local descriptor table. These are the instructions covered by UMIP: * SGDT - Store Global Descriptor Table * SIDT - Store Interrupt Descriptor Table * SLDT - Store Local Descriptor Table * SMSW - Store Machine Status Word * STR - Store Task Register If any of these instructions is executed with CPL > 0, a general protection exception is issued when UMIP is enabled. There is a caveat, however. Certain applications rely on some of these instructions to function. An example of this are applications that use WineHQ[3]. For instance, these applications rely on sidt returning a non- accesible memory location[4]. During the discussions, it was proposed that the fault could be relied to the user-space and perform the emulation in user-mode. However, this would break existing applications until, for instance, they update to a new WineHQ version. However, this approach would require UMIP to be disabled by default. The concensus in this forum is to always enable it. This patchset initially treated tasks running in virtual-8086 mode as a special case. However, I received clarification that DOSEMU[5] does not support applications that use these instructions. It relies on WineHQ for this[6]. Furthermore, the applications for which the concern was raised run in protected mode [4]. This version keeps UMIP enabled at all times and by default. If a general protection fault caused by the instructions protected by UMIP is detected, such fault will be fixed-up by returning dummy values as follows: * SGDT and SIDT return hard-coded dummy values as the base of the global descriptor and interrupt descriptor tables. These hard-coded values are located within a memory map hole in x86_64. For x86_32, the same values are used but truncated to 4 bytes. This is also the case for virtual- 8086 mode tasks, in which the base is truncated to 3 bytes. In all cases, the limit of the table is set to 0. * STR and SLDT return 0 as the segment selector. This looks appropriate since we are providing a dummy value as the base address of the global descriptor table. * SMSW returns the value with which the CR0 register is programmed in head_32/64.S at boot time. This is, the following bits are enabed: CR0.0 for Protection Enable, CR.1 for Monitor Coprocessor, CR.4 for Extension Type, which will always be 1 in recent processors with UMIP; CR.5 for Numeric Error, CR0.16 for Write Protect, CR0.18 for Alignment Mask. Additionally, in x86_64, CR0.31 for Paging is set. The proposed emulation code is handles faults that happens in both protected and virtual-8086 mode. I found very useful the code for Intel MPX (Memory Protection Extensions) used to parse opcodes and the memory locations contained in the general purpose registers when used as operands. I put some of this code in a separate library file that both MPX and UMIP can access and avoid code duplication. While here, I fixed two small bugs that I found in the MPX implementation. This new library was also extended to handle 16-bit address encodings as those found in virtual-8086 mode tasks. A set of representative selftests for virtual-8086 mode tasks are included as part of this series. The tested uses use displacements, registers to indicate memory addresses as well as the use as registers as operands. Extensive test cases were performed to test the page fault that is emulated when memory to write the instructions results is not accesible[7], to tests almost all combinations of operands (ModRM, SiB, REX prefix and displacements) in protected mode[8] and to test almost all the combinations of operands in virtual-8086 mode[9]. If there is interest, this could could also be submitted for the kernel selftests. [1]. https://lwn.net/Articles/705877/ [2]. https://lkml.org/lkml/2016/12/23/265 [3]. https://www.winehq.org/ [4]. https://www.winehq.org/pipermail/wine-devel/2016-November/115320.html [5]. http://www.dosemu.org/ [6]. http://marc.info/?l=linux-kernel&m=147876798717927&w=2 [7]. https://github.com/01org/luv-yocto/blob/rneri/umip/meta-luv/recipes-core/um… [8]. https://github.com/01org/luv-yocto/blob/rneri/umip/meta-luv/recipes-core/um… [9]. https://github.com/01org/luv-yocto/blob/rneri/umip/meta-luv/recipes-kernel/… Thanks and BR, Ricardo Changes since V2: * Added new utility functions to decode the memory addresses contained in registers when the 16-bit addressing encodings are used. This includes code to obtain and compute memory addresses using segment selectors for real-mode address translation. * Added support to emulate UMIP-protected instructions for virtual-8086 tasks. * Added selftests for virtual-8086 mode that contains representative use cases: address represented as a displacement, address in registers and registers as operands. * Instead of maintaining a static variable for the dummy base addresses of the IDT and GDT, a hard-coded value is used. * The emulated SMSW instructions now return the value with which the CR0 register is programmed in head_32/64.S This is: PE | MP | ET | NE | WP | AM. For x86_64, PG is also enabled. * The new file arch/x86/lib/insn-utils.c is now renamed as arch/x86/lib/ insn-kernel.c. It also has its own header. This helps keep in sync the the kernel and objtool instruction decoders. Also, the new insn-kernel.c contains utility functions that are only relevant in a kernel context. * Removed printed warnings for errors that occur when decoding instructions with invalid operands. * Added more comments on fixes in the instruction-decoding MPX functions. * Now user_64bit_mode(regs) is used instead of test_thread_flag(TIF_IA32) to determine if the task is 32-bit or 64-bit. * Found and fixed a bug in insn-decoder in which X86_MODRM_RM was incorrectly used to obtain the mod part of the ModRM byte. * Added more explanatory code in emulation and instruction decoding code. This includes a comment regarding that copy_from_user could fail if there exists a memory protection key in place. * Tested code with CONFIG_X86_DECODER_SELFTEST=y and everything passes now. * Prefixed get_reg_offset_rm with insn_ as this function is exposed via a header file. For clarity, this function was added in a separate patch. Changes since V1: * Virtual-8086 mode tasks are not treated in a special manner. All code for this purpose was removed. * Instead of attempting to disable UMIP during a context switch or when entering virtual-8086 mode, UMIP remains enabled all the time. General protection faults that occur are fixed-up by returning dummy values as detailed above. * Removed umip= kernel parameter in favor of using clearcpuid=514 to disable UMIP. * Removed selftests designed to detect the absence of SIGSEGV signals when running in virtual-8086 mode. * Reused code from MPX to decode instructions operands. For this purpose code was put in a common location. * Fixed two bugs in MPX code that decodes operands. Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Borislav Petkov <bp(a)suse.de> Cc: Brian Gerst <brgerst(a)gmail.com> Cc: Chen Yucong <slaoub(a)gmail.com> Cc: Chris Metcalf <cmetcalf(a)mellanox.com> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Fenghua Yu <fenghua.yu(a)intel.com> Cc: Huang Rui <ray.huang(a)amd.com> Cc: Jiri Slaby <jslaby(a)suse.cz> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Michael S. Tsirkin <mst(a)redhat.com> Cc: Paul Gortmaker <paul.gortmaker(a)windriver.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Ravi V. Shankar <ravi.v.shankar(a)intel.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Liang Z Li <liang.z.li(a)intel.com> Cc: x86(a)kernel.org Cc: linux-msdos(a)vger.kernel.org Ricardo Neri (10): x86/mpx: Do not use SIB index if index points to R/ESP x86/mpx: Fail decoding when SIB baseR/EBP is and no displacement is used x86/mpx, x86/insn: Relocate insn util functions to a new insn-kernel x86/insn-kernel: Add a function to obtain register offset in ModRM x86/insn-kernel: Add support to resolve 16-bit addressing encodings x86/cpufeature: Add User-Mode Instruction Prevention definitions x86: Add emulation code for UMIP instructions x86/traps: Fixup general protection faults caused by UMIP x86: Enable User-Mode Instruction Prevention selftests/x86: Add tests for User-Mode Instruction Prevention arch/x86/Kconfig | 10 + arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/insn-kernel.h | 17 ++ arch/x86/include/asm/umip.h | 15 ++ arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/common.c | 16 +- arch/x86/kernel/traps.c | 4 + arch/x86/kernel/umip.c | 251 +++++++++++++++++++ arch/x86/lib/Makefile | 2 +- arch/x86/lib/insn-kernel.c | 344 ++++++++++++++++++++++++++ arch/x86/mm/mpx.c | 120 +-------- tools/testing/selftests/x86/entry_from_vm86.c | 39 ++- 14 files changed, 708 insertions(+), 122 deletions(-) create mode 100644 arch/x86/include/asm/insn-kernel.h create mode 100644 arch/x86/include/asm/umip.h create mode 100644 arch/x86/kernel/umip.c create mode 100644 arch/x86/lib/insn-kernel.c -- 2.9.3

4 24

Re: wbemprox: Add a partial implementation of Win32_IP4RouteTable.
by Alexandre Julliard 31 Jan '17

31 Jan '17

Hans Leidekker <hans(a)codeweavers.com> writes: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/wbemprox/builtin.c | 75 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/wbemprox/tests/query.c | 63 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 138 insertions(+) This doesn't build on Mingw: i686-w64-mingw32-gcc -c -o builtin.o ../../../wine/dlls/wbemprox/builtin.c -I. -I../../../wine/dlls/wbemprox \ -I../../include -I../../../wine/include -D__WINESRC__ -DUSE_WS_PREFIX -D_REENTRANT -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer \ -g -O2 -fno-diagnostics-show-caret -D_WIN32 In file included from ../../../wine/dlls/wbemprox/builtin.c:38:0: ../../../wine/include/ws2tcpip.h:176:104: warning: ‘struct timeval’ declared inside parameter list will not be visible outside of this definition or declaration ../../../wine/include/ws2tcpip.h:178:107: warning: ‘struct timeval’ declared inside parameter list will not be visible outside of this definition or declaration ../../../wine/dlls/wbemprox/builtin.c: In function ‘fill_ip4routetable’: ../../../wine/dlls/wbemprox/builtin.c:2074:47: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] ../.././../obj-elf64/tools/winegcc/winegcc -o wbemprox.dll -B../.././../obj-elf64/tools/winebuild \ --sysroot=../.. -b i686-w64-mingw32 -fasynchronous-unwind-tables -shared ../../../wine/dlls/wbemprox/wbemprox.spec \ builtin.o class.o main.o process.o qualifier.o query.o reg.o security.o service.o services.o \ table.o wbemlocator.o wql.tab.o wbemprox_r.res ../../dlls/winspool.drv/libwinspool.a \ ../../dlls/version/libversion.a ../../dlls/iphlpapi/libiphlpapi.a ../../dlls/dxgi/libdxgi.a \ ../../dlls/oleaut32/liboleaut32.a ../../dlls/ole32/libole32.a ../../dlls/advapi32/libadvapi32.a \ ../../dlls/user32/libuser32.a ../../dlls/gdi32/libgdi32.a ../../dlls/ws2_32/libws2_32.a \ ../../dlls/rpcrt4/librpcrt4.a ../../libs/port/libwine_port.a -lwine builtin.o: In function `fill_ip4routetable': /home/julliard/wine/build/obj-pe32/dlls/wbemprox/../../../wine/dlls/wbemprox/builtin.c:2074: undefined reference to `ntohl' /home/julliard/wine/build/obj-pe32/dlls/wbemprox/../../../wine/dlls/wbemprox/builtin.c:2076: undefined reference to `ntohl' collect2: error: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed Makefile:638: recipe for target 'wbemprox.dll' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32:add SIZEALL_BIG cursor, reusing SIZEALL resource Fixes bug#42303
by Alexandre Julliard 31 Jan '17

31 Jan '17

Anton Romanov <theli.ua(a)gmail.com> writes: > @@ -2227,6 +2227,7 @@ typedef struct tagCBTACTIVATESTRUCT > #define IDC_HAND MAKEINTRESOURCE(32649) > #define IDC_APPSTARTING MAKEINTRESOURCE(32650) > #define IDC_HELP MAKEINTRESOURCE(32651) > +#define IDC_SIZEALL_BIG MAKEINTRESOURCE(32654) There's no such definition in Windows. > @@ -1011,6 +1011,7 @@ > #define OCR_NO 32648 > #define OCR_HAND 32649 > #define OCR_APPSTARTING 32650 > +#define OCR_SIZEALL_BIG 32654 This is already defined as OCR_RDR2DIM. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] wined3d: Implement buffer texture range.
by Guillaume Charifi 31 Jan '17

31 Jan '17

Thank you for your detailed answer :) Le 31/01/2017 à 00:19, Józef Kucia a écrit : > I'll explain in more details to encourage you ;-) > > On Sun, Jan 29, 2017 at 1:12 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: >> Please add a test. > Adding a test should be very easy. In test_buffer_srv() everything is > ready to add a test with an offset. You can use "rgba16_buffer" as > data, set size to {2.0f, 2.0f} or {1.0f, 1.0f}, and test with > different values of "srv_first_element" and "srv_element_count". Try > to come up with interesting test cases and test edge cases. Looks easier than I thought, indeed. I'll be doing this. > >> On Sun, Jan 29, 2017 at 12:25 AM, Guillaume Charifi >> <guillaume.charifi(a)sfr.fr> wrote: >>> + GL_EXTCALL(glTexBufferRange(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object, >>> + desc->u.buffer.start_idx, desc->u.buffer.count)); >> This is wrong. > glTexBufferRange() accepts offsets and sizes in bytes, but in D3D11 > offsets and sizes for typed buffers are expressed as the number of > elements. You have to multiply "start_idx" and "count" by > "view_format->byte_count". A test would also help you to find this > mistake. Oh, I see, I'm fixing it. > > Another advice: start small. It's better to send a few well tested > patches and get them accepted first. > > I'll hope to see some patches from you committed soon. > > Cheers, > Józef >

1 0

Re: [PATCH 2/2] winspool/tests: Test for LastError also on success of AddMonitor
by Huw Davies 31 Jan '17

31 Jan '17

On Mon, Jan 30, 2017 at 07:43:35PM +0100, Detlef Riekenberg wrote: > dlls/winspool.drv/tests/info.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c > index f6527c5..602e935 100644 > --- a/dlls/winspool.drv/tests/info.c > +++ b/dlls/winspool.drv/tests/info.c > @@ -435,6 +435,12 @@ static void test_AddMonitor(void) > SetLastError(MAGIC_DEAD); > res = AddMonitorA(NULL, 2, (LPBYTE) &mi2a); > ok(res, "returned %d with %d (expected '!= 0')\n", res, GetLastError()); > + if (res) > + { > + /* Some apps depend on the result of GetLastError() */ > + res = GetLastError(); > + ok(res == ERROR_SUCCESS, "got 0x%x/%u (expected ERROR_SUCCESS)\n", res, res); > + } There's no need to have this test conditional on res. Also, don't reassign res to the error, just use GetLastError() directly. And just print the error in decimal. Huw.

1 0

Re: [PATCH 1/2] localspl: Clear LastError on success in AddMonitor
by Huw Davies 31 Jan '17

31 Jan '17

On Mon, Jan 30, 2017 at 07:43:34PM +0100, Detlef Riekenberg wrote: > dlls/localspl/provider.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/localspl/provider.c b/dlls/localspl/provider.c > index f359b73..f370b9f 100644 > --- a/dlls/localspl/provider.c > +++ b/dlls/localspl/provider.c > @@ -1541,6 +1541,9 @@ static BOOL WINAPI fpAddMonitor(LPWSTR pName, DWORD Level, LPBYTE pMonitors) > RegCloseKey(hentry); > } > > + if (res) > + SetLastError(ERROR_SUCCESS); /* Monitor installer depend on this */ > + > RegCloseKey(hroot); > return (res); > } I think unconditionally resetting the error after monitor_unload() would be cleaner. Huw.

1 0

Re: comctl32: Fix some more spec file entries
by Huw Davies 31 Jan '17

31 Jan '17

On Sun, Jan 29, 2017 at 09:58:36PM +0100, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/comctl32/comctl32.spec | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/comctl32.spec b/dlls/comctl32/comctl32.spec > index c3e9167..dbfa123 100644 > --- a/dlls/comctl32/comctl32.spec > +++ b/dlls/comctl32/comctl32.spec > @@ -93,7 +93,7 @@ > 382 stdcall -noname SmoothScrollWindow(ptr) > 383 stub -noname DoReaderMode > 384 stdcall -noname SetPathWordBreakProc(ptr long) > -385 stdcall -ordinal DPA_EnumCallback(long long ptr) > +385 stdcall -ordinal DPA_EnumCallback(long ptr ptr) Should be: 385 stdcall -ordinal DPA_EnumCallback(ptr ptr ptr) Huw.

4 3

Re: [PATCH] winealsa.drv: Fix handling of system real time MIDI messages
by Austin English 31 Jan '17

31 Jan '17

On Tue, Jan 31, 2017 at 12:16 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > MIDI spec at http://www.somascape.org/midi/tech/spec.html state that system real time messages "... are each single byte messages, with no following data bytes...", currently wine is prepending SYSEX header generating invalid messages. > > A comparison before and after patch using gmidimonitor as ouput MIDI port: > http://alexa.pro.br/~bruno/wine/midi.png > > I believe the patch to be correct, I don't own any MIDI hardware to test but gmidimonitor seems good enough. Do wineoss / winepulse need similar fixes? -- -Austin GPG: 14FB D7EA A041 937B

2 1

Re: [PATCH] regedit: When processing 3.1 ignore any lines that don't begin with HKCR.
by Nikolay Sivov 31 Jan '17

31 Jan '17

On 31.01.2017 5:51, Zebediah Figura wrote: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > programs/regedit/regproc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c > index c055c10..b6de728 100644 > --- a/programs/regedit/regproc.c > +++ b/programs/regedit/regproc.c > @@ -616,8 +616,9 @@ static void processRegEntry31(WCHAR *line) > int res; > > static WCHAR empty[] = {0}; > + static WCHAR hkcr[] = {'H','K','E','Y','_','C','L','A','S','S','E','S','_','R','O','O','T',0}; > > - if (line[0] == '\0') return; > + if (memcmp(line, hkcr, sizeof(hkcr) - sizeof(WCHAR))) return; > > /* get key name */ > while (line[key_end] && !isspaceW(line[key_end])) key_end++; > Is it guaranteed 'line' is a least that large? Also you can remove terminating 0 from hkcr to avoid sizeof(WCHAR) subtraction.

2 1

Re: [PATCH 05/10] wined3d: Add compute shaders cb/samplers state updates.
by Guillaume Charifi 30 Jan '17

30 Jan '17

Thank you for your feedback. WineD3D/D3D11/OpenGL are complex APIs with lots of tricky details. I know my implementation is far from perfect, but it seems that you learn better by working, trying, so I do. I have a basic but (likely) working tessellation implementation and I'll submit it soon. But it's quite dirty, so I expect feedbacks to improve it (if you haven't done it locally yet). Btw, I think you should write down somewhere who is currently working on what at Crossover, to avoid useless duplicated work. <div>-------- Message d'origine --------</div><div>De : Józef Kucia <joseph.kucia(a)gmail.com> </div><div>Date :30/01/2017 14:13 (GMT+01:00) </div><div>À : wine-devel <wine-devel(a)winehq.org> </div><div>Cc : Guillaume Charifi <guillaume.charifi(a)sfr.fr> </div><div>Objet : Re: [PATCH 05/10] wined3d: Add compute shaders cb/samplers state updates. </div><div> </div>FWIW, I have a patch series adding basic support for compute shaders in my patch queue. I should start submitting the series when my SM5 shader instructions series from wine-patches is committed. I've skimmed over your patches though. I'll share some high-level comments. On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/context.c | 1 + > dlls/wined3d/state.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index ca73bcc..eaae0b8 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -3382,6 +3382,7 @@ static void context_bind_shader_resources(struct wined3d_context *context, const > { > {WINED3D_SHADER_TYPE_PIXEL, 0, MAX_FRAGMENT_SAMPLERS}, > {WINED3D_SHADER_TYPE_VERTEX, MAX_FRAGMENT_SAMPLERS, MAX_VERTEX_SAMPLERS}, > + {WINED3D_SHADER_TYPE_COMPUTE, 0, MAX_COMPUTE_SAMPLERS}, > }; I don't think that adding a proper support for binding compute shader resources is that simple.

2 1

Re: comctl32: Correctly set the colour table for ILC_COLOR4 and ILC_COLOR8 imagelists.
by Marvin 30 Jan '17

30 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28138 Your paranoid android. === wxppro (32 bit imagelist) === imagelist.c:2057: Test failed: 4: remove all, add 8: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 4: remove all, add 8: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 4: remove all, add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[0] 00 00 00 expect ff 00 ff imagelist.c:2057: Test failed: 4: add 4: got color[1] 80 00 00 expect ff ff 00 imagelist.c:2057: Test failed: 4: add 4: got color[2] 00 80 00 expect 00 ff ff imagelist.c:2057: Test failed: 4: add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 8: remove all, add 8: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[15] 1c 1c 1c expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[16] 22 22 22 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[17] 29 29 29 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[18] 55 55 55 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[19] 4d 4d 4d expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[20] 42 42 42 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[21] 39 39 39 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[22] ff 7c 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[23] ff 50 50 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[24] d6 00 93 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[25] cc ec ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[26] ef d6 c6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[27] e7 e7 d6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[28] ad a9 90 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[29] 33 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[30] 66 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[31] 99 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[32] cc 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[33] 00 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[34] 33 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[35] 66 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[36] 99 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[37] cc 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[38] ff 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[39] 00 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[40] 33 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[41] 66 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[42] 99 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[43] cc 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[44] ff 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[45] 00 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[46] 33 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[47] 66 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[48] 99 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[49] cc 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[50] ff 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[51] 00 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[52] 33 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[53] 66 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[54] 99 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[55] cc cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[56] ff cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[57] 66 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[58] 99 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[59] cc ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[60] 00 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[61] 33 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[62] 66 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[63] 99 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[64] cc 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[65] ff 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[66] 00 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[67] 33 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[68] 66 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[69] 99 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[70] cc 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[71] ff 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[72] 00 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[73] 33 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[74] 66 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[75] 99 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[76] cc 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[77] ff 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[78] 00 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[79] 33 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[80] 66 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[81] 99 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[82] cc 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[83] ff 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[84] 00 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[85] 33 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[86] 66 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[87] 99 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[88] cc cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[89] ff cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[90] 33 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[91] 66 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[92] 99 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[93] cc ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[94] ff ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[95] 00 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[96] 33 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[97] 66 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[98] 99 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[99] cc 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[100] ff 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[101] 00 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[102] 33 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[103] 66 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[104] 99 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[105] cc 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[106] ff 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[107] 00 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[108] 33 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[109] 66 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[110] 99 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[111] cc 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[112] 00 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[113] 33 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[114] 66 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[115] 99 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[116] cc 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[117] ff 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[118] 00 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[119] 33 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[120] 99 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[121] cc cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[122] ff cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[123] 00 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[124] 33 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[125] 99 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[126] cc ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[127] ff 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[128] cc 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[129] 00 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[130] 99 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[131] 99 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[132] cc 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[133] 00 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[134] 33 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[135] 66 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[136] cc 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[137] ff 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[138] 00 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[139] 33 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[140] 66 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[141] 99 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[142] cc 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[143] ff 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[144] 33 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[145] 66 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[146] 99 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[147] cc 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[148] ff 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[149] 00 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[150] 33 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[151] 66 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[152] 99 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[153] cc cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[154] ff cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[155] 00 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[156] 33 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[157] 66 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[158] 99 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[159] cc ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[160] ff ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[161] 00 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[162] 33 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[163] 66 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[164] 99 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[165] cc 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[166] 00 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[167] 33 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[168] 66 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[169] 99 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[170] cc 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[171] ff 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[172] 00 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[173] 33 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[174] 66 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[175] 99 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[176] cc 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[177] ff 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[178] 00 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[179] 33 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[180] 66 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[181] 99 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[182] cc 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[183] ff 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[184] 00 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[185] 33 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[186] 66 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[187] 99 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[188] cc cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[189] ff cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[190] 00 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[191] 33 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[192] 66 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[193] 99 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[194] cc ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[195] ff ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[196] 33 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[197] 66 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[198] 99 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[199] 00 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[200] 33 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[201] 66 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[202] 99 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[203] cc 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[204] ff 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[205] 00 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[206] 33 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[207] 66 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[208] 99 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[209] cc 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[210] ff 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[211] 00 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[212] 33 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[213] 66 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[214] 99 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[215] cc 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[216] ff 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[217] 00 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[218] 33 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[219] 66 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[220] 99 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[221] cc cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[222] ff cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[223] 33 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[224] 66 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[225] 99 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[226] cc ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[227] ff 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[228] 66 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[229] ff ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[230] 66 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[231] ff 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[232] 66 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[233] a5 00 21 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[234] 5f 5f 5f expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[235] 77 77 77 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[236] 86 86 86 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[237] 96 96 96 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[238] cb cb cb expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[239] b2 b2 b2 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[240] d7 d7 d7 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[241] dd dd dd expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[242] e3 e3 e3 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[243] ea ea ea expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[244] f1 f1 f1 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[245] f8 f8 f8 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[246] ff fb f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[247] a0 a0 a4 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[248] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[249] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[250] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[251] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[252] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[253] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[254] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[255] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 8: remove all, add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[15] 1c 1c 1c expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[16] 22 22 22 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[17] 29 29 29 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[18] 55 55 55 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[19] 4d 4d 4d expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[20] 42 42 42 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[21] 39 39 39 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[22] ff 7c 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[23] ff 50 50 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[24] d6 00 93 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[25] cc ec ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[26] ef d6 c6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[27] e7 e7 d6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[28] ad a9 90 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[29] 33 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[30] 66 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[31] 99 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[32] cc 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[33] 00 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[34] 33 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[35] 66 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[36] 99 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[37] cc 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[38] ff 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[39] 00 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[40] 33 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[41] 66 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[42] 99 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[43] cc 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[44] ff 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[45] 00 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[46] 33 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[47] 66 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[48] 99 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[49] cc 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[50] ff 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[51] 00 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[52] 33 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[53] 66 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[54] 99 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[55] cc cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[56] ff cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[57] 66 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[58] 99 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[59] cc ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[60] 00 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[61] 33 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[62] 66 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[63] 99 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[64] cc 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[65] ff 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[66] 00 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[67] 33 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[68] 66 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[69] 99 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[70] cc 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[71] ff 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[72] 00 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[73] 33 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[74] 66 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[75] 99 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[76] cc 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[77] ff 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[78] 00 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[79] 33 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[80] 66 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[81] 99 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[82] cc 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[83] ff 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[84] 00 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[85] 33 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[86] 66 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[87] 99 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[88] cc cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[89] ff cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[90] 33 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[91] 66 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[92] 99 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[93] cc ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[94] ff ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[95] 00 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[96] 33 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[97] 66 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[98] 99 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[99] cc 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[100] ff 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[101] 00 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[102] 33 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[103] 66 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[104] 99 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[105] cc 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[106] ff 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[107] 00 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[108] 33 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[109] 66 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[110] 99 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[111] cc 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[112] 00 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[113] 33 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[114] 66 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[115] 99 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[116] cc 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[117] ff 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[118] 00 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[119] 33 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[120] 99 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[121] cc cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[122] ff cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[123] 00 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[124] 33 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[125] 99 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[126] cc ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[127] ff 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[128] cc 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[129] 00 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[130] 99 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[131] 99 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[132] cc 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[133] 00 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[134] 33 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[135] 66 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[136] cc 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[137] ff 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[138] 00 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[139] 33 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[140] 66 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[141] 99 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[142] cc 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[143] ff 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[144] 33 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[145] 66 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[146] 99 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[147] cc 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[148] ff 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[149] 00 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[150] 33 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[151] 66 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[152] 99 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[153] cc cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[154] ff cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[155] 00 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[156] 33 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[157] 66 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[158] 99 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[159] cc ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[160] ff ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[161] 00 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[162] 33 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[163] 66 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[164] 99 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[165] cc 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[166] 00 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[167] 33 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[168] 66 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[169] 99 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[170] cc 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[171] ff 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[172] 00 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[173] 33 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[174] 66 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[175] 99 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[176] cc 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[177] ff 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[178] 00 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[179] 33 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[180] 66 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[181] 99 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[182] cc 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[183] ff 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[184] 00 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[185] 33 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[186] 66 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[187] 99 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[188] cc cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[189] ff cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[190] 00 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[191] 33 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[192] 66 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[193] 99 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[194] cc ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[195] ff ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[196] 33 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[197] 66 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[198] 99 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[199] 00 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[200] 33 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[201] 66 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[202] 99 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[203] cc 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[204] ff 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[205] 00 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[206] 33 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[207] 66 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[208] 99 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[209] cc 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[210] ff 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[211] 00 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[212] 33 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[213] 66 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[214] 99 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[215] cc 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[216] ff 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[217] 00 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[218] 33 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[219] 66 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[220] 99 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[221] cc cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[222] ff cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[223] 33 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[224] 66 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[225] 99 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[226] cc ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[227] ff 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[228] 66 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[229] ff ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[230] 66 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[231] ff 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[232] 66 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[233] a5 00 21 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[234] 5f 5f 5f expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[235] 77 77 77 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[236] 86 86 86 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[237] 96 96 96 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[238] cb cb cb expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[239] b2 b2 b2 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[240] d7 d7 d7 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[241] dd dd dd expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[242] e3 e3 e3 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[243] ea ea ea expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[244] f1 f1 f1 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[245] f8 f8 f8 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[246] ff fb f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[247] a0 a0 a4 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[248] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[249] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[250] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[251] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[252] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[253] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[254] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[255] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[0] 00 00 00 expect ff 00 ff imagelist.c:2057: Test failed: 8: add 4: got color[1] 80 00 00 expect ff ff 00 imagelist.c:2057: Test failed: 8: add 4: got color[2] 00 80 00 expect 00 ff ff imagelist.c:2057: Test failed: 8: add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[15] 1c 1c 1c expect 00 00 00 === w2003std (32 bit imagelist) === imagelist.c:2057: Test failed: 4: remove all, add 8: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 4: remove all, add 8: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 8: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 4: remove all, add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: remove all, add 4: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[0] 00 00 00 expect ff 00 ff imagelist.c:2057: Test failed: 4: add 4: got color[1] 80 00 00 expect ff ff 00 imagelist.c:2057: Test failed: 4: add 4: got color[2] 00 80 00 expect 00 ff ff imagelist.c:2057: Test failed: 4: add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[8] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[9] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[10] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[11] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[12] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[13] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[14] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 4: add 4: got color[15] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 8: remove all, add 8: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[15] 1c 1c 1c expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[16] 22 22 22 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[17] 29 29 29 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[18] 55 55 55 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[19] 4d 4d 4d expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[20] 42 42 42 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[21] 39 39 39 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[22] ff 7c 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[23] ff 50 50 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[24] d6 00 93 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[25] cc ec ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[26] ef d6 c6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[27] e7 e7 d6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[28] ad a9 90 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[29] 33 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[30] 66 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[31] 99 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[32] cc 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[33] 00 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[34] 33 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[35] 66 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[36] 99 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[37] cc 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[38] ff 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[39] 00 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[40] 33 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[41] 66 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[42] 99 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[43] cc 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[44] ff 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[45] 00 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[46] 33 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[47] 66 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[48] 99 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[49] cc 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[50] ff 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[51] 00 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[52] 33 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[53] 66 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[54] 99 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[55] cc cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[56] ff cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[57] 66 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[58] 99 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[59] cc ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[60] 00 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[61] 33 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[62] 66 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[63] 99 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[64] cc 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[65] ff 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[66] 00 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[67] 33 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[68] 66 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[69] 99 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[70] cc 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[71] ff 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[72] 00 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[73] 33 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[74] 66 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[75] 99 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[76] cc 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[77] ff 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[78] 00 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[79] 33 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[80] 66 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[81] 99 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[82] cc 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[83] ff 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[84] 00 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[85] 33 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[86] 66 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[87] 99 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[88] cc cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[89] ff cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[90] 33 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[91] 66 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[92] 99 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[93] cc ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[94] ff ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[95] 00 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[96] 33 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[97] 66 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[98] 99 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[99] cc 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[100] ff 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[101] 00 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[102] 33 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[103] 66 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[104] 99 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[105] cc 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[106] ff 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[107] 00 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[108] 33 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[109] 66 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[110] 99 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[111] cc 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[112] 00 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[113] 33 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[114] 66 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[115] 99 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[116] cc 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[117] ff 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[118] 00 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[119] 33 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[120] 99 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[121] cc cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[122] ff cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[123] 00 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[124] 33 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[125] 99 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[126] cc ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[127] ff 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[128] cc 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[129] 00 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[130] 99 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[131] 99 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[132] cc 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[133] 00 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[134] 33 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[135] 66 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[136] cc 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[137] ff 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[138] 00 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[139] 33 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[140] 66 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[141] 99 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[142] cc 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[143] ff 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[144] 33 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[145] 66 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[146] 99 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[147] cc 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[148] ff 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[149] 00 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[150] 33 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[151] 66 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[152] 99 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[153] cc cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[154] ff cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[155] 00 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[156] 33 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[157] 66 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[158] 99 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[159] cc ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[160] ff ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[161] 00 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[162] 33 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[163] 66 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[164] 99 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[165] cc 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[166] 00 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[167] 33 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[168] 66 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[169] 99 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[170] cc 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[171] ff 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[172] 00 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[173] 33 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[174] 66 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[175] 99 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[176] cc 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[177] ff 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[178] 00 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[179] 33 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[180] 66 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[181] 99 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[182] cc 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[183] ff 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[184] 00 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[185] 33 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[186] 66 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[187] 99 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[188] cc cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[189] ff cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[190] 00 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[191] 33 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[192] 66 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[193] 99 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[194] cc ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[195] ff ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[196] 33 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[197] 66 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[198] 99 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[199] 00 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[200] 33 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[201] 66 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[202] 99 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[203] cc 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[204] ff 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[205] 00 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[206] 33 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[207] 66 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[208] 99 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[209] cc 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[210] ff 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[211] 00 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[212] 33 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[213] 66 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[214] 99 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[215] cc 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[216] ff 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[217] 00 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[218] 33 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[219] 66 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[220] 99 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[221] cc cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[222] ff cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[223] 33 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[224] 66 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[225] 99 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[226] cc ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[227] ff 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[228] 66 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[229] ff ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[230] 66 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[231] ff 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[232] 66 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[233] a5 00 21 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[234] 5f 5f 5f expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[235] 77 77 77 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[236] 86 86 86 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[237] 96 96 96 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[238] cb cb cb expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[239] b2 b2 b2 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[240] d7 d7 d7 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[241] dd dd dd expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[242] e3 e3 e3 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[243] ea ea ea expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[244] f1 f1 f1 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[245] f8 f8 f8 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[246] ff fb f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[247] a0 a0 a4 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[248] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[249] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[250] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[251] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[252] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[253] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[254] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 8: got color[255] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[0] 00 00 00 expect ff 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[1] 80 00 00 expect 00 ff 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[2] 00 80 00 expect 00 00 ff imagelist.c:2057: Test failed: 8: remove all, add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[15] 1c 1c 1c expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[16] 22 22 22 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[17] 29 29 29 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[18] 55 55 55 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[19] 4d 4d 4d expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[20] 42 42 42 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[21] 39 39 39 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[22] ff 7c 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[23] ff 50 50 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[24] d6 00 93 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[25] cc ec ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[26] ef d6 c6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[27] e7 e7 d6 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[28] ad a9 90 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[29] 33 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[30] 66 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[31] 99 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[32] cc 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[33] 00 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[34] 33 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[35] 66 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[36] 99 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[37] cc 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[38] ff 33 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[39] 00 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[40] 33 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[41] 66 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[42] 99 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[43] cc 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[44] ff 66 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[45] 00 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[46] 33 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[47] 66 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[48] 99 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[49] cc 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[50] ff 99 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[51] 00 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[52] 33 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[53] 66 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[54] 99 cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[55] cc cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[56] ff cc 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[57] 66 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[58] 99 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[59] cc ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[60] 00 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[61] 33 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[62] 66 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[63] 99 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[64] cc 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[65] ff 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[66] 00 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[67] 33 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[68] 66 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[69] 99 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[70] cc 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[71] ff 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[72] 00 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[73] 33 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[74] 66 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[75] 99 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[76] cc 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[77] ff 66 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[78] 00 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[79] 33 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[80] 66 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[81] 99 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[82] cc 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[83] ff 99 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[84] 00 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[85] 33 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[86] 66 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[87] 99 cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[88] cc cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[89] ff cc 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[90] 33 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[91] 66 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[92] 99 ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[93] cc ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[94] ff ff 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[95] 00 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[96] 33 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[97] 66 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[98] 99 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[99] cc 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[100] ff 00 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[101] 00 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[102] 33 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[103] 66 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[104] 99 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[105] cc 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[106] ff 33 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[107] 00 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[108] 33 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[109] 66 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[110] 99 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[111] cc 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[112] 00 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[113] 33 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[114] 66 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[115] 99 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[116] cc 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[117] ff 99 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[118] 00 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[119] 33 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[120] 99 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[121] cc cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[122] ff cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[123] 00 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[124] 33 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[125] 99 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[126] cc ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[127] ff 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[128] cc 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[129] 00 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[130] 99 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[131] 99 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[132] cc 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[133] 00 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[134] 33 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[135] 66 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[136] cc 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[137] ff 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[138] 00 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[139] 33 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[140] 66 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[141] 99 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[142] cc 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[143] ff 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[144] 33 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[145] 66 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[146] 99 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[147] cc 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[148] ff 99 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[149] 00 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[150] 33 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[151] 66 cc 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[152] 99 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[153] cc cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[154] ff cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[155] 00 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[156] 33 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[157] 66 cc 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[158] 99 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[159] cc ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[160] ff ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[161] 00 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[162] 33 00 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[163] 66 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[164] 99 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[165] cc 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[166] 00 33 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[167] 33 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[168] 66 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[169] 99 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[170] cc 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[171] ff 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[172] 00 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[173] 33 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[174] 66 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[175] 99 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[176] cc 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[177] ff 66 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[178] 00 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[179] 33 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[180] 66 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[181] 99 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[182] cc 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[183] ff 99 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[184] 00 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[185] 33 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[186] 66 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[187] 99 cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[188] cc cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[189] ff cc cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[190] 00 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[191] 33 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[192] 66 ff 99 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[193] 99 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[194] cc ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[195] ff ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[196] 33 00 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[197] 66 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[198] 99 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[199] 00 33 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[200] 33 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[201] 66 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[202] 99 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[203] cc 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[204] ff 33 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[205] 00 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[206] 33 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[207] 66 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[208] 99 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[209] cc 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[210] ff 66 cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[211] 00 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[212] 33 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[213] 66 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[214] 99 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[215] cc 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[216] ff 99 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[217] 00 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[218] 33 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[219] 66 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[220] 99 cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[221] cc cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[222] ff cc ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[223] 33 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[224] 66 ff cc expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[225] 99 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[226] cc ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[227] ff 66 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[228] 66 ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[229] ff ff 66 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[230] 66 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[231] ff 66 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[232] 66 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[233] a5 00 21 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[234] 5f 5f 5f expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[235] 77 77 77 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[236] 86 86 86 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[237] 96 96 96 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[238] cb cb cb expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[239] b2 b2 b2 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[240] d7 d7 d7 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[241] dd dd dd expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[242] e3 e3 e3 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[243] ea ea ea expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[244] f1 f1 f1 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[245] f8 f8 f8 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[246] ff fb f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[247] a0 a0 a4 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[248] 80 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[249] ff 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[250] 00 ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[251] ff ff 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[252] 00 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[253] ff 00 ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[254] 00 ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: remove all, add 4: got color[255] ff ff ff expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[0] 00 00 00 expect ff 00 ff imagelist.c:2057: Test failed: 8: add 4: got color[1] 80 00 00 expect ff ff 00 imagelist.c:2057: Test failed: 8: add 4: got color[2] 00 80 00 expect 00 ff ff imagelist.c:2057: Test failed: 8: add 4: got color[3] 80 80 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[4] 00 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[5] 80 00 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[6] 00 80 80 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[7] c0 c0 c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[8] c0 dc c0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[9] a6 ca f0 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[10] 00 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[11] 33 00 00 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[12] 33 00 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[13] 00 33 33 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[14] 16 16 16 expect 00 00 00 imagelist.c:2057: Test failed: 8: add 4: got color[15] 1c 1c 1c expect 00 00 00

2 1

Re: [PATCH 05/10] wined3d: Add compute shaders cb/samplers state updates.
by Guillaume Charifi 30 Jan '17

30 Jan '17

I meant Codeweavers.

1 0

Re: [PATCH v2] user32: Also remove WM_CHAR from queue when a menu gets VK_ESCAPE and add tests
by Alexandre Julliard 30 Jan '17

30 Jan '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > @@ -3186,8 +3186,12 @@ static BOOL MENU_TrackMenu( HMENU hmenu, UINT wFlags, INT x, INT y, > break; > > case VK_ESCAPE: > + { > + MSG msg_dummy; > fEndMenu = MENU_KeyEscape(&mt, wFlags); > - break; > + PeekMessageW(&msg_dummy, 0, WM_CHAR, WM_CHAR, PM_REMOVE); > + break; > + } It would be cleaner to avoid TranslateMessage instead of removing the message (possibly getting the wrong one). -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH resend 1/2] user32: Fix WM_NCPAINT for windows crossing screen boarders and add tests
by Alexandre Julliard 30 Jan '17

30 Jan '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > @@ -662,7 +662,17 @@ static HRGN send_ncpaint( HWND hwnd, HWND *child, UINT *flags ) > if (type == SIMPLEREGION) > { > RECT window; > + LONG screenx = GetSystemMetrics(SM_CXSCREEN); > + LONG screeny = GetSystemMetrics(SM_CYSCREEN); > + > GetWindowRect( hwnd, &window ); > + > + /* Clamp the window region to screen bounds */ > + if(window.right > screenx) window.right = screenx; > + if(window.bottom > screeny) window.bottom = screeny; > + if(window.left < 0) window.left = 0; > + if(window.top < 0) window.top = 0; This won't be correct for multi-monitor setups. That sort of thing should probably be handled on the server side. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 06/10] wined3d: Add compute shaders initial support in GLSL backend.
by Józef Kucia 30 Jan '17

30 Jan '17

On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > - if (!(context->shader_update_mask & (1u << WINED3D_SHADER_TYPE_VERTEX)) && ctx_data->glsl_program) > + cshader = state->shader[WINED3D_SHADER_TYPE_COMPUTE]; > + if (!(context->shader_update_mask & (1u << WINED3D_SHADER_TYPE_COMPUTE)) > + && ctx_data->glsl_program->cs.id) > { > - vs_id = ctx_data->glsl_program->vs.id; > - vs_list = &ctx_data->glsl_program->vs.shader_entry; > + cs_id = ctx_data->glsl_program->cs.id; > + } > + else if (cshader) > + { > + struct cs_compile_args args; > > - if (use_vs(state)) > + find_cs_compile_args(state, cshader, &args); > + cs_id = find_glsl_compute_shader(context, priv, cshader, &args); > + } > + > + if(!cs_id) > + { > + if (!(context->shader_update_mask & (1u << WINED3D_SHADER_TYPE_VERTEX)) && ctx_data->glsl_program) > + { > + vs_id = ctx_data->glsl_program->vs.id; > + vs_list = &ctx_data->glsl_program->vs.shader_entry; > + > + if (use_vs(state)) > + vshader = state->shader[WINED3D_SHADER_TYPE_VERTEX]; > + } > + else if (use_vs(state)) > { > + struct vs_compile_args vs_compile_args; > + > vshader = state->shader[WINED3D_SHADER_TYPE_VERTEX]; > + > + find_vs_compile_args(state, vshader, context->stream_info.swizzle_map, &vs_compile_args, d3d_info); > + vs_id = find_glsl_vshader(context, priv, vshader, &vs_compile_args); > + vs_list = &vshader->linked_programs; > + } > + else if (priv->vertex_pipe == &glsl_vertex_pipe) > + { > + struct glsl_ffp_vertex_shader *ffp_shader; > + struct wined3d_ffp_vs_settings settings; > + > + wined3d_ffp_get_vs_settings(context, state, &settings); > + ffp_shader = shader_glsl_find_ffp_vertex_shader(priv, gl_info, &settings); > + vs_id = ffp_shader->id; > + vs_list = &ffp_shader->linked_programs; > + } > + > + if (use_vs(state)) > + { It doesn't seem reasonable to create a GL program for each combination of graphics pipeline and compute pipeline shaders. A single GL program for each compute shader is enough.

1 0

Re: [PATCH 07/10] wined3d: Add dispatch_compute() draw primitive.
by Józef Kucia 30 Jan '17

30 Jan '17

On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > + if (!context_apply_draw_state(context, device, state)) > + { > + context_release(context); > + WARN("Unable to apply draw state, skipping draw.\n"); > + return; > + } I don't think it makes sense to apply all states for compute pipeline. Note that graphics pipeline and compute pipeline have separate UAV bindings.

1 0

Re: [PATCH 08/10] wined3d: Dispatch compute through the command stream.
by Józef Kucia 30 Jan '17

30 Jan '17

On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > + for (i = 0; i < ARRAY_SIZE(state->streams); ++i) > + { > + if (state->streams[i].buffer) > + wined3d_resource_acquire(&state->streams[i].buffer->resource); > + } > + for (i = 0; i < ARRAY_SIZE(state->textures); ++i) > + { > + if (state->textures[i]) > + wined3d_resource_acquire(&state->textures[i]->resource); > + } Streams and textures are not supposed to be used by compute pipeline.

1 0

Re: [PATCH 05/10] wined3d: Add compute shaders cb/samplers state updates.
by Józef Kucia 30 Jan '17

30 Jan '17

FWIW, I have a patch series adding basic support for compute shaders in my patch queue. I should start submitting the series when my SM5 shader instructions series from wine-patches is committed. I've skimmed over your patches though. I'll share some high-level comments. On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/context.c | 1 + > dlls/wined3d/state.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index ca73bcc..eaae0b8 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -3382,6 +3382,7 @@ static void context_bind_shader_resources(struct wined3d_context *context, const > { > {WINED3D_SHADER_TYPE_PIXEL, 0, MAX_FRAGMENT_SAMPLERS}, > {WINED3D_SHADER_TYPE_VERTEX, MAX_FRAGMENT_SAMPLERS, MAX_VERTEX_SAMPLERS}, > + {WINED3D_SHADER_TYPE_COMPUTE, 0, MAX_COMPUTE_SAMPLERS}, > }; I don't think that adding a proper support for binding compute shader resources is that simple.

1 0

Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures.
by Henri Verbeet 30 Jan '17

30 Jan '17

On 29 January 2017 at 03:32, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > > --- > dlls/wined3d/context.c | 12 ++++++++++++ > dlls/wined3d/state.c | 5 +++++ > dlls/wined3d/view.c | 6 ------ > 3 files changed, 17 insertions(+), 6 deletions(-) > These patches are incredibly unappealing to review. There are multiple versions of multiple interleaved series, with html and other errors mixed in. (See e.g. https://source.winehq.org/patches/data/129296.) Please only send a reasonable number of patches at once, I'd suggest sticking with 5, and please use git send-email for sending patches.

1 0

Re: patches: Display multiple check marks for multiple signoffs.
by André Hentschel 30 Jan '17

30 Jan '17

Hi, > --- a/patches/update > +++ b/patches/update > @@ -229,7 +229,7 @@ foreach my $file (sort { $patches{$b}->{"order"} <=> $patches{$a}->{"order"} } k > } > if (defined($patch->{"signoff"})) > { > - printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">✓</td>"; > + printf INDEX "<td class=\"checkmark\" onclick=\"toggle_display('$file.signoff')\">%s</td>", "✓" x @{$patch->{"signoff"}}; > } The patch is definitly an improvement, but the problem with the patch is, that right now I can't see that my patch has been signed-off by Aric when looking at it in the patch list ... 129264 New Aric Stewart Re: usp10: Fix ScriptRecordDigitSubstitution spec file entry ✓ ... 129183 Assigned André Hentschel usp10: Fix ScriptRecordDigitSubstitution spec file entry Aric Stewart ✓ ... I think something like that was what Bruno is looking for

3 4

Re: [PATCH] winbase.h: Add UnlockResource prototype
by Dmitry Timoshkov 30 Jan '17

30 Jan '17

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > This function is obsolete and was only used in win16. However when trying > to compile a project with winelib found this function was called. Then you need to add it to an appropriate win16 header, or better remove it from your project since it won't compile with PSDK either. -- Dmitry.

2 1

Re: [PATCH 1/7] regedit: Use a helper for LoadString() and add debug information
by Dmitry Timoshkov 30 Jan '17

30 Jan '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -static INT vmessagebox(HWND hwnd, INT buttons, INT titleId, INT resId, va_list ap) > +static void load_string(unsigned int msg_id, WCHAR *buf, unsigned int count) > { > static const WCHAR errorW[] = {'E','r','r','o','r',0}; > - static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',' ','e','r','r','o','r',' ','s','t','r','i','n','g','!',0}; > > + if (!buf) return; > + > + if (!LoadStringW(hInst, msg_id, buf, count)) > + { > + WINE_FIXME("LoadString failed with %u\n", GetLastError()); > + lstrcpyW(buf, errorW); > + } > +} Probably using a flavour of lstrcpy that checks the target buffer length would be more appropriate. Although simply returning an empty buffer and an error indicator to the caller could be slightly better. Under which conditions LoadString may fail here? -- Dmitry.

2 2

Re: [PATCH] MAINTAINERS: Add myself for printing
by Bruno Jesus 29 Jan '17

29 Jan '17

On Sun, Jan 29, 2017 at 8:15 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > bye bye Detlef > > Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de> > --- > MAINTAINERS | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e5224ff..d53af50 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -206,10 +206,15 @@ F: dlls/vcomp*/ > > Printing > M: Huw Davies <huw(a)codeweavers.com> > +P: Detlef Riekenberg <wine.dev(a)web.de> > F: dlls/localspl/ > -F: dlls/wineps.drv/ > +F: dlls/spoolss/ > F: dlls/winspool.drv/ > > +Postscript Driver > +M: Huw Davies <huw(a)codeweavers.com> > +F: dlls/wineps.drv/ > + I believe we are trying to keep the areas in alphabetical order.

1 0

Re: [v2 PATCH 3/3] windowscodecs: Add support for palette image formats to PNG encoder.
by Vincent Povirk 29 Jan '17

29 Jan '17

> + else > + { > + png_palette[i].red = 0; > + png_palette[i].green = 0; > + png_palette[i].blue = 0; > + } Why is it necessary to pad the palette in this way? Couldn't you just pass the appropriate number of colors?

3 2

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.
by guillaume.charifi＠sfr.fr 29 Jan '17

29 Jan '17

Yes, you're right, I forgot to commit the declaration of raw_resource in wined3d_private.<br> And yes, it can be replaced by dst instead. <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;"> <div class="gl_quoted">On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi<br> wrote:<br> > Signed-off-by: Guillaume Charifi<br> > ---<br> > dlls/wined3d/arb_program_shader.c | 1 +<br> > dlls/wined3d/glsl_shader.c | 1 +<br> > dlls/wined3d/shader.c | 6 ++++++<br> > dlls/wined3d/shader_sm4.c | 10 ++++++++++<br> > dlls/wined3d/wined3d_private.h | 1 +<br> > 5 files changed, 19 insertions(+)<br> <br> This patch doesn't even compile. Please test your patches before<br> sending them to wine-patches.<br> <br> > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins,<br> > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count,<br> > + struct wined3d_sm4_data *priv)<br> > +{<br> > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg);<br> > +}<br> <br> You should just use "ins->declaration.dst".</div> </div>

1 0

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.
by Józef Kucia 29 Jan '17

29 Jan '17

On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/arb_program_shader.c | 1 + > dlls/wined3d/glsl_shader.c | 1 + > dlls/wined3d/shader.c | 6 ++++++ > dlls/wined3d/shader_sm4.c | 10 ++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 5 files changed, 19 insertions(+) This patch doesn't even compile. Please test your patches before sending them to wine-patches. > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins, > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count, > + struct wined3d_sm4_data *priv) > +{ > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg); > +} You should just use "ins->declaration.dst".

1 0

Re: [PATCH] wined3d: Implement buffer texture range.
by Józef Kucia 29 Jan '17

29 Jan '17

Please add a test. On Sun, Jan 29, 2017 at 12:25 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > + GL_EXTCALL(glTexBufferRange(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object, > + desc->u.buffer.start_idx, desc->u.buffer.count)); This is wrong.

1 0

RE : [PATCH] wined3d: Implement buffer texture range.
by Guillaume Charifi 29 Jan '17

29 Jan '17

Woops, I forgot the patch adding the required extension, I'll send it later.

1 0

RE : Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures.
by Guillaume Charifi 29 Jan '17

29 Jan '17

Right, thank you... -------- Message d'origine -------- De : Bruno Jesus <00cpxxx(a)gmail.com> Date :29/01/2017 03:13 (GMT+01:00) À : Guillaume Charifi Cc : Wine Develop Objet : Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures. On Sat, Jan 28, 2017 at 8:46 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > --- > dlls/wined3d/context.c | 12 ++++++++++++ > dlls/wined3d/state.c | 5 +++++ > dlls/wined3d/view.c | 6 ------ > 3 files changed, 17 insertions(+), 6 deletions(-) You missed the Signed-off-by, see the red marks at http://source.winehq.org/patches/

1 0

Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures.
by Bruno Jesus 29 Jan '17

29 Jan '17

On Sat, Jan 28, 2017 at 8:46 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > --- > dlls/wined3d/context.c | 12 ++++++++++++ > dlls/wined3d/state.c | 5 +++++ > dlls/wined3d/view.c | 6 ------ > 3 files changed, 17 insertions(+), 6 deletions(-) You missed the Signed-off-by, see the red marks at http://source.winehq.org/patches/

1 0

Re: [PATCH v3 1/4] ddraw: Don't crash if writing out a new ddraw1 surface segfaults.
by Marvin 28 Jan '17

28 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=28113 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:1662: Test failed: Got unexpected color 0x000000ff.

1 0

Re: [PATCH v3 1/4] ddraw: Don't crash if writing out a new ddraw1 surface segfaults.
by Sebastian Lackner 28 Jan '17

28 Jan '17

On 28.01.2017 22:59, Alex Henrie wrote: > + __TRY > { > - *surface = NULL; > - return hr; > + if (FAILED(hr)) > + { > + *surface = NULL; > + return hr; > + } Its not possible to use return in a __TRY block.

1 0

Re: [PATCH 1/5] wined3d: Fix sRGB clears with no support for ARB_framebuffer_sRGB.
by Henri Verbeet 27 Jan '17

27 Jan '17

On 27 January 2017 at 19:52, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - if (!gl_info->supported[ARB_FRAMEBUFFER_SRGB] && needs_srgb_write(context, state, fb)) > + if (!gl_info->supported[ARB_FRAMEBUFFER_SRGB] > + && ((!(context->d3d_info->wined3d_creation_flags & WINED3D_SRGB_READ_WRITE_CONTROL) > + && fb->render_targets[0] && fb->render_targets[0]->format_flags & WINED3DFMT_FLAG_SRGB_WRITE) > + || state->render_states[WINED3D_RS_SRGBWRITEENABLE])) I think this looks suspicious, why is this more correct? In particular, wouldn't this enable sRGB clears on formats without WINED3DFMT_FLAG_SRGB_WRITE? Patch 2/5 hints that that may be intentional, but in that case, shouldn't this be independent of ARB_framebuffer_sRGB support?

2 3

Re: [PATCH v2 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Alex Henrie 27 Jan '17

27 Jan '17

2017-01-27 5:43 GMT-07:00 Henri Verbeet <hverbeet(a)gmail.com>: > On 26 January 2017 at 06:20, Alex Henrie <alexhenrie24(a)gmail.com> wrote: >> + hr = IDirectDraw_CreateSurface(ddraw, &surface_desc, &surface, NULL); >> + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); >> + ok(surface == (IDirectDrawSurface *)0xdeadbeef || broken(!surface) /* 32-bit on Win8/10 */, >> + "Got unexpected surface %p.\n", surface); > Where does this pass without the broken()? It writes NULL to surface > for me on Windows 7, and appears to handle the exception when an > invalid pointer is passed in. http://testbot.winehq.org/JobDetails.pl?Key=28086 The following testbot VMs are the only ones that zero out the surface pointer: w8 (32 bit ddraw1) w864 (32 bit ddraw1) w1064 (32 bit ddraw1) Maybe the behavior of newer versions of Windows depends on the video card driver? -Alex ---------- Forwarded message ---------- From: Marvin <testbot(a)winehq.org> Date: 2017-01-27 10:00 GMT-07:00 Subject: TestBot job 28086 results: ddraw: Don't write out if a ddraw1 surface of size 0 is requested. To: Alex Henrie <alexhenrie24(a)gmail.com> VM Status Number of test failures build completed wxppro completed 0 w2003std completed 0 wvistau64 completed 0 w2008s64 completed 0 w7u completed 0 w7pro64 completed 0 w8 completed 1 w864 completed 1 w1064 completed 2 wvistau64 completed 0 w2008s64 completed 0 w7pro64 completed 0 w864 completed 0 w1064 completed 1 === build (build) === No build failures found === wxppro (32 bit ddraw1) === No test failures found === w2003std (32 bit ddraw1) === No test failures found === wvistau64 (32 bit ddraw1) === No test failures found === w2008s64 (32 bit ddraw1) === No test failures found === w7u (32 bit ddraw1) === No test failures found === w7pro64 (32 bit ddraw1) === No test failures found === w8 (32 bit ddraw1) === ddraw: ddraw1.c:1971: Test failed: Got unexpected surface 00000000. === w864 (32 bit ddraw1) === ddraw: ddraw1.c:1971: Test failed: Got unexpected surface 00000000. === w1064 (32 bit ddraw1) === ddraw: ddraw1.c:1971: Test failed: Got unexpected surface 00000000. ddraw1.c:2299: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === wvistau64 (64 bit ddraw1) === No test failures found === w2008s64 (64 bit ddraw1) === No test failures found === w7pro64 (64 bit ddraw1) === No test failures found === w864 (64 bit ddraw1) === No test failures found === w1064 (64 bit ddraw1) === ddraw: ddraw1.c:2299: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

2 1

Re: [PATCH] d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub. (resend)
by Matteo Bruni 27 Jan '17

27 Jan '17

2017-01-25 12:19 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/d3dx11_42/Makefile.in | 1 + > dlls/d3dx11_42/d3dx11_42.spec | 2 +- > dlls/d3dx11_43/Makefile.in | 1 + > dlls/d3dx11_43/d3dx11_43.spec | 2 +- > dlls/d3dx11_43/shader.c | 36 ++++++++++++++++++++++++++++++++++++ > 5 files changed, 40 insertions(+), 2 deletions(-) > create mode 100644 dlls/d3dx11_43/shader.c I had a better look at the patch and unfortunately I don't think this is okay as is. Sorry that I missed it the first time around. The D3DX11CreateShaderResourceViewFrom* functions are probably supposed to be very thin wrappers over the corresponding D3DX11CreateTextureFrom* functions. So e.g. for D3DX11CreateShaderResourceViewFromMemory() an implementation calling D3DX11CreateTextureFromMemory() and then ID3D11Device_CreateShaderResourceView(device, ...) on the returned resource is probably all there is to it. Except that, for the pump != NULL case, you want to do the work on the thread pump so e.g. create the the SRV in a ID3DX11DataProcessor. Anyway, it's still okay to me to go with just a stub or with an implementation only taking into account the !pump case. You need to add the function definition to d3dx11tex.h though. Also, given that this is really a texture function, it doesn't make sense to put it in a new shader.c file. Just adding it to texture.c seems fine.

1 0

Re: opengl32: add OpenGL 3.3/4.0 extensions
by Vito Paradiso 27 Jan '17

27 Jan '17

i quite didn’t understand > Il giorno 16 gen 2017, alle ore 22:49, Marvin <testbot(a)winehq.org> ha scritto: > > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "No patch". > > This means that no patch was found in your mail. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

1 0

Re: [PATCH] d3d8/tests: Fix copy&paste issue in compare_mode (cppcheck)
by Henri Verbeet 27 Jan '17

27 Jan '17

On 27 January 2017 at 05:58, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > - unsigned int h = mode_b->h - mode_b->h; > + unsigned int h = mode_a->h - mode_b->h; This is correct of course, but I'd hesitate to call copy/paste on it.

1 0

Re: [PATCH v2 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Henri Verbeet 27 Jan '17

27 Jan '17

On 26 January 2017 at 06:20, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > + hr = IDirectDraw_CreateSurface(ddraw, &surface_desc, &surface, NULL); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + ok(surface == (IDirectDrawSurface *)0xdeadbeef || broken(!surface) /* 32-bit on Win8/10 */, > + "Got unexpected surface %p.\n", surface); Where does this pass without the broken()? It writes NULL to surface for me on Windows 7, and appears to handle the exception when an invalid pointer is passed in.

1 0

Re: ntprint: Fix PSetupCreateMonitorInfo spec file entry
by Huw Davies 27 Jan '17

27 Jan '17

On Thu, Jan 26, 2017 at 11:46:57PM +0100, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/ntprint/ntprint.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/dlls/ntprint/ntprint.spec b/dlls/ntprint/ntprint.spec > index 8869776..3687979 100644 > --- a/dlls/ntprint/ntprint.spec > +++ b/dlls/ntprint/ntprint.spec > @@ -2,7 +2,7 @@ > @ stub PSetupAssociateICMProfiles > @ stub PSetupBuildDriversFromPath > @ stub PSetupCreateDrvSetupPage > -@ stdcall PSetupCreateMonitorInfo(long ptr ptr) > +@ stdcall PSetupCreateMonitorInfo(ptr ptr ptr) > @ stub PSetupCreatePrinterDeviceInfoList > @ stub PSetupDestroyDriverInfo3 > @ stdcall PSetupDestroyMonitorInfo(long) > I get exceptions running the tests on 32-bit Windows (with or without this patch) which go away when I call the function with just two arguments - I suspect we should lose the third argument. Huw.

1 0

Re: ntdll: add a stub for NtLoadKey2/ZwLoadKey2
by Dmitry Timoshkov 27 Jan '17

27 Jan '17

Austin English <austinenglish(a)gmail.com> wrote: > +NTSTATUS WINAPI NtLoadKey2(OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file, ULONG flags) > +{ > + NTSTATUS ret; > + > + FIXME("(%p,%p,0x%08x) semi-stub: ignoring flags\n", attr, file, flags); > + ret = NtLoadKey(attr, file); > + > + return ret; > +} There is no need for an intermediate variable. -- Dmitry.

1 0

Re: [PATCH 3/3] windowscodecs: Use source palette if it wasn't specified earlier for PNG frame
by Dmitry Timoshkov 27 Jan '17

27 Jan '17

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > @@ -1765,6 +1765,18 @@ static HRESULT WINAPI PngFrameEncode_WriteSource(IWICBitmapFrameEncode *iface, > > if (SUCCEEDED(hr)) > { > + if (This->colors == 0) > + { > + IWICPalette *palette; > + > + if (SUCCEEDED(PaletteImpl_Create(&palette))) > + { > + if (SUCCEEDED(IWICBitmapSource_CopyPalette(pIBitmapSource, palette))) > + IWICBitmapFrameEncode_SetPalette(iface, palette); > + IWICPalette_Release(palette); > + } > + } > + > hr = write_source(iface, pIBitmapSource, prc, > This->format->guid, This->format->bpp, This->width, This->height); > } What is this for? It looks like a workaround for a WIC converter bug. I'd like to see a test case for this behaviour. -- Dmitry.

1 0

Re: [PATCH 1/3] windowscodecs: Implement IWICBitmapFrameEncode::SetPalette in PNG encoder.
by Dmitry Timoshkov 27 Jan '17

27 Jan '17

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > From: Dmitry Timoshkov <dmitry(a)baikal.ru> ... > diff --git a/dlls/windowscodecs/tests/converter.c b/dlls/windowscodecs/tests/converter.c > index 2af985785c..9da82f1665 100644 > --- a/dlls/windowscodecs/tests/converter.c > +++ b/dlls/windowscodecs/tests/converter.c > @@ -25,6 +25,7 @@ > #include "windef.h" > #include "objbase.h" > #include "wincodec.h" > +#include "wincodecsdk.h" > #include "wine/test.h" > > typedef struct bitmap_data { > @@ -577,6 +578,50 @@ struct setting { > void *value; > }; > > +#define EXPECT_REF(obj,ref) _expect_ref((IUnknown*)obj, ref, __LINE__) > +static void _expect_ref(IUnknown* obj, ULONG ref, int line) I'd prefer to avoid getting a credit for the code I never had written. -- Dmitry.

1 0

Re: [v3 PATCH 05/10] x86/insn-kernel: Add support to resolve 16-bit addressing encodings (fwd)
by Julia Lawall 27 Jan '17

27 Jan '17

Check the type of seg on line 267. julia ---------- Forwarded message ---------- Date: Thu, 26 Jan 2017 05:24:40 +0800 From: kbuild test robot <fengguang.wu(a)intel.com> To: kbuild(a)01.org Cc: Julia Lawall <julia.lawall(a)lip6.fr> Subject: Re: [v3 PATCH 05/10] x86/insn-kernel: Add support to resolve 16-bit addressing encodings In-Reply-To: <20170125202353.101059-6-ricardo.neri-calderon(a)linux.intel.com> Hi Ricardo, [auto build test WARNING on tip/auto-latest] [also build test WARNING on v4.10-rc5 next-20170125] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ricardo-Neri/x86-Enable-User-Mode-… :::::: branch date: 51 minutes ago :::::: commit date: 51 minutes ago >> arch/x86/lib/insn-kernel.c:267:6-9: WARNING: Unsigned expression compared with zero: seg < 0 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 574de0de238ef30c816985006f02f7a1dbba92aa vim +267 arch/x86/lib/insn-kernel.c 574de0de Ricardo Neri 2017-01-25 251 addr = (seg << 4) + regs_get_register(regs, addr_offset1); 574de0de Ricardo Neri 2017-01-25 252 } else { 574de0de Ricardo Neri 2017-01-25 253 ret = get_reg_offset_16(insn, regs, &addr_offset1, 574de0de Ricardo Neri 2017-01-25 254 &addr_offset2); 574de0de Ricardo Neri 2017-01-25 255 if (ret < 0) 574de0de Ricardo Neri 2017-01-25 256 goto out_err; 574de0de Ricardo Neri 2017-01-25 257 /* 574de0de Ricardo Neri 2017-01-25 258 * Don't fail on invalid offset values. They might be invalid 574de0de Ricardo Neri 2017-01-25 259 * because they are not supported. Instead, use them in the 574de0de Ricardo Neri 2017-01-25 260 * calculation only if they contain a valid value. 574de0de Ricardo Neri 2017-01-25 261 */ 574de0de Ricardo Neri 2017-01-25 262 if (addr_offset1 >= 0) 574de0de Ricardo Neri 2017-01-25 263 addr1 = regs_get_register(regs, addr_offset1); 574de0de Ricardo Neri 2017-01-25 264 if (addr_offset2 >= 0) 574de0de Ricardo Neri 2017-01-25 265 addr2 = regs_get_register(regs, addr_offset2); 574de0de Ricardo Neri 2017-01-25 266 seg = __get_segment_selector_16(regs, insn, addr_offset1); 574de0de Ricardo Neri 2017-01-25 @267 if (seg < 0) 574de0de Ricardo Neri 2017-01-25 268 goto out_err; 574de0de Ricardo Neri 2017-01-25 269 addr = (seg << 4) + addr1 + addr2; 574de0de Ricardo Neri 2017-01-25 270 } 574de0de Ricardo Neri 2017-01-25 271 addr += insn->displacement.value; 574de0de Ricardo Neri 2017-01-25 272 574de0de Ricardo Neri 2017-01-25 273 return (void __user *)addr; 574de0de Ricardo Neri 2017-01-25 274 out_err: 574de0de Ricardo Neri 2017-01-25 275 return (void __user *)-1; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

2 1

Re: comctl32: Move prototype to header
by Sebastian Lackner 26 Jan '17

26 Jan '17

On 27.01.2017 00:26, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/comctl32/comctl32.h | 1 + > dlls/comctl32/syslink.c | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > Any specific reason that you don't use include/shlwapi.h ?

2 1

Re: msvideo.dll16: Implement DrawDibProfileDisplay
by Alexandre Julliard 26 Jan '17

26 Jan '17

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -35,7 +35,7 @@ > 111 stub DRAWDIBCHANGEPALETTE > 112 pascal -ret16 DrawDibRealize(word word word) DrawDibRealize16 > 113 stub DRAWDIBTIME > -114 stub DRAWDIBPROFILEDISPLAY > +114 pascal -ret16 DrawDibProfileDisplay(segptr) DrawDibProfileDisplay16 segptr is not correct if you pass the pointer to 32-bit code. -- Alexandre Julliard julliard(a)winehq.org

3 3

Performance Testing Wine-1.2-rc4 vs Wine-1.8
by Stefan Dösinger 26 Jan '17

26 Jan '17

Hi, After more than a year of break I ran my Wine benchmarking scripts again on one of my two test machines: The iMac5.1 box with a Radeon X1600 GPU. You can see the results and the comparison to the last regular run here: http://openbenchmarking.org/result/1701170-RI-UPDATETES12,1512236-GA-WINE18… The one game that jumps out is Trackmania Nations. It apparently regressed from approx. 32 fps to 24. I will run a bisect in the next days to pinpoint the patch that caused this. The game itself wasn't updated. Other than TMNations there is nothing too surprising. 3DMark2000 and 2001 are slightly slower, Half Life 2 (which surprisingly didn't seem to be changed by Valve since December 2015) is slightly faster. Unigine Heaven, UT2004 and World in Conflict are unchanged. As you can see in the results I updated the kernel, Mesa and Wine separately to see where changes come from (stable interfaces ftw!). The oldkernel_oldmesa_oldwine result differs from the 2015 one in the general update of the system (KDE Desktop, X server, DDX driver, etc). Unfortunately this old machine is the less interesting one of my two test boxes. I still don't have a monitor for my Radeon HD 5700 Desktop. I ordered one a while ago and it should arrive soon. If I have time I'll try to run the tests next week. Cheers, Stefan

2 4

Re: [PATCH] hidclass.sys: When processing reads fill all the buffers
by Sebastian Lackner 26 Jan '17

26 Jan '17

On 26.01.2017 13:57, Aric Stewart wrote: > This is a follow-up fix for continuing work on bug 42225 > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/hidclass.sys/buffer.c | 34 +++++++++++++++++++++++++++++++++- > dlls/hidclass.sys/device.c | 2 +- > dlls/hidclass.sys/hid.h | 3 ++- > 3 files changed, 36 insertions(+), 3 deletions(-) > > > > 0001-hidclass.sys-When-processing-reads-fill-all-the-buffer.txt > > > diff --git a/dlls/hidclass.sys/buffer.c b/dlls/hidclass.sys/buffer.c > index 0b29f97b69..41bbb8e241 100644 > --- a/dlls/hidclass.sys/buffer.c > +++ b/dlls/hidclass.sys/buffer.c > @@ -127,7 +127,7 @@ NTSTATUS RingBuffer_SetSize(struct ReportRingBuffer *ring, UINT size) > return STATUS_SUCCESS; > } > > -void RingBuffer_Read(struct ReportRingBuffer *ring, UINT index, void *output, UINT *size) > +void RingBuffer_ReadNew(struct ReportRingBuffer *ring, UINT index, void *output, UINT *size) > { > void *ret = NULL; > > @@ -155,6 +155,38 @@ void RingBuffer_Read(struct ReportRingBuffer *ring, UINT index, void *output, UI > } > } > > +void RingBuffer_Read(struct ReportRingBuffer *ring, UINT index, void *output, UINT *size) > +{ > + int pointer = ring->pointers[index]; > + void *ret = NULL; > + > + EnterCriticalSection(&ring->lock); > + if (index >= ring->pointer_alloc || ring->pointers[index] == POINTER_UNUSED > + || ring->end == ring->start) > + { > + LeaveCriticalSection(&ring->lock); > + *size = 0; > + return; > + } > + > + if (pointer == ring->end) > + pointer--; > + > + if (pointer < 0) > + pointer = ring->size - 1; > + > + ret = &ring->buffer[pointer * ring->buffer_size]; > + memcpy(output, ret, ring->buffer_size); > + if (pointer == ring->pointers[index]) > + { > + ring->pointers[index]++; > + if (ring->pointers[index] == ring->size) > + ring->pointers[index] = 0; > + } > + LeaveCriticalSection(&ring->lock); > + *size = ring->buffer_size; Have you been able to reproduce a similar behavior on Windows? The new code looks very suspicious and I'm not sure if this is the right approach to fix it. Also please note that this will effectively disable any asynchronous Read requests - HID_Device_read() will always use the first code path when there is at least one package in the ring buffer and never return STATUS_PENDING. > +} > + > UINT RingBuffer_AddPointer(struct ReportRingBuffer *ring) > { > UINT idx; > diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c > index b241016e72..d6a0a358e3 100644 > --- a/dlls/hidclass.sys/device.c > +++ b/dlls/hidclass.sys/device.c > @@ -662,7 +662,7 @@ NTSTATUS WINAPI HID_Device_read(DEVICE_OBJECT *device, IRP *irp) > ptr = PtrToUlong( irp->Tail.Overlay.OriginalFileObject->FsContext ); > > irp->IoStatus.Information = 0; > - RingBuffer_Read(ext->ring_buffer, ptr, packet, &buffer_size); > + RingBuffer_ReadNew(ext->ring_buffer, ptr, packet, &buffer_size); > > if (buffer_size) > { > diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h > index adc547cc43..1829319ccf 100644 > --- a/dlls/hidclass.sys/hid.h > +++ b/dlls/hidclass.sys/hid.h > @@ -62,7 +62,8 @@ typedef struct _BASE_DEVICE_EXTENSION { > void RingBuffer_Write(struct ReportRingBuffer *buffer, void *data) DECLSPEC_HIDDEN; > UINT RingBuffer_AddPointer(struct ReportRingBuffer *buffer) DECLSPEC_HIDDEN; > void RingBuffer_RemovePointer(struct ReportRingBuffer *ring, UINT index) DECLSPEC_HIDDEN; > -void RingBuffer_Read(struct ReportRingBuffer *buffer, UINT index, void *output, UINT *size) DECLSPEC_HIDDEN; > +void RingBuffer_Read(struct ReportRingBuffer *ring, UINT index, void *output, UINT *size) DECLSPEC_HIDDEN; > +void RingBuffer_ReadNew(struct ReportRingBuffer *buffer, UINT index, void *output, UINT *size) DECLSPEC_HIDDEN; > UINT RingBuffer_GetBufferSize(struct ReportRingBuffer *buffer) DECLSPEC_HIDDEN; > UINT RingBuffer_GetSize(struct ReportRingBuffer *buffer) DECLSPEC_HIDDEN; > void RingBuffer_Destroy(struct ReportRingBuffer *buffer) DECLSPEC_HIDDEN; > > >

2 1

DirectX 12 in Wine
by Gabríel Arthúr Pétursson 25 Jan '17

25 Jan '17

Hi, I am interested on working on getting DirectX 12 support into Wine. Is there anyone currently working towards that goal that I can get in contact with? With that said, what would an appropriate implementation in Wine look like? DirectX 12 on top of Vulkan seems like an obvious choice. The two APIs are very similar, whereas the DirectX 12 programming model deviates significantly from both OpenGL and DirectX 11. Another approach is to leverage wined3d (i.e. OpenGL + extensions). I don't know to what extent wined3d can be used or needs to be changed in order to support DirectX 12, or if it'd be useful at all. Can anyone shed some light on whether this would be a feasible approach? Thanks.

3 3

A couple unrelated issues
by Rafał Mużyło 25 Jan '17

25 Jan '17

Just as the title says, I've got a couple problems/questions that don't have much in common except for "happening in wine". 1. regedit and long REG_BINARY values: the edit control should either be made resizable or scrollable, cause long values just don't fit in the box; as a temporary solution, I've made a hackish patch, that changes the font the control uses (not sure if that's necesarry, but it's just feels more natural to use monospaced font here), makes sure all glyphs get the same space and once the value wraps, if it's a non-integer divide, the last line is correctly placed; 2. alsa/pulseaudio and stream recovery: as in the past, it's hard to tell if it's wine or the underlaying stuff that fails; the problem I'm hearing is that apps sometimes without any apparent reason (as CPU usage isn't all that different than the average) go into '(snd_pcm_recover) underrun occurred' mode and start playing the sounds on much higher rate and then just as randomly (as it's again seemingly not related to CPU usage) recover; it's the randomness that bothers me: both going into the state *and* not recovering for several minutes; would it be possible, if not outright fix that, then for example add a helper app, that the user could manually trigger to force recovery ? 3. err:ntdll:RtlpWaitForCriticalSection wait timed out in thread <nr>, blocked by <nr>, retrying (60 sec): this is an annoyance, sometimes a major one; namely, it happens that I terminate an app by pressing ^C; usually, that works just fine, but every now and then app goes into that unterminatable state and not for those 60 sec (which is horribly long anyway), but pretty much indefinitelly; it really shouldn't do that; this requires a taskmgr or wineboot intervention to close it 4. (somewhat related to the previous) taskmgr could use a little enhancement: when running several apps with the same executable name, it's very hard to tell (impossible ?) how a line from process tab relates to application tab; usually it's not much of a problem, but if point 3 strikes, there's no more entry in the app tab, but the process is still there and you need to guess, which will often be wrong; perhaps the entries in the process tab should print the app name or have an option in the context menu to retrieve it ?

4 6

Re: [PATCH 3/7] d3d11/tests: Add test for interleaved Draw() and Dispatch() calls.
by Henri Verbeet 25 Jan '17

25 Jan '17

On 25 January 2017 at 11:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 186 insertions(+) > This fails here: d3d11.c:1310: Feature level 0xb000. d3d11.c:6487: Tests skipped: Some AMD drivers have a bug affecting the test. d3d11.c:10104: Compute shader support via SM4 0x1. d3d11.c:11197: Optional format 0x59 - display supported, feature level 0xa100. d3d11.c:11197: Optional format 0x59 - display supported, feature level 0xa000. d3d11.c:12628: Test failed: Got 0x00000000, expected 0xffffffff at (0, 0), sub-resource 0. d3d11: 7402 tests executed (0 marked as todo, 1 failure), 1 skipped. It also takes a long time to run; it might be hanging the GPU.

2 1

Post-release
by Alexandre Julliard 25 Jan '17

25 Jan '17

Congrats to everybody for the 2.0 release! I'm particularly pleased with the progress we've made on fixing regressions, I didn't expect we'd get that many. Thanks all! The master branch is now open for development again. I'll go through the patches that are still in the queue, but please resend any patch that had been marked Deferred. I'll also resume the biweekly development release cycle, starting with release 2.1 on February 3rd. Despite fierce competition, Michael Stefaniuc once again took the coveted job of Stable Branch Maintainer. He'll be making regular 2.0.x releases. I've also implemented the patch reviewer assignment scheme that we discussed at WineConf. From now on, patches that stay in the queue unreviewed for a week will be assigned a reviewer automatically. The algorithm is prioritizing people who said they have some knowledge about the area (the P: entries in the MAINTAINERS file), before grabbing someone at random from the wildcard entry. If you feel that there are areas where you could help reviewing patches, but don't feel comfortable putting yourself up as maintainer, please consider adding an entry for yourself as a knowledgeable person. If you are asked to review a patch, and you think it looks good but don't feel that you know enough to sign off on it, please just send a reply saying "looks OK to me" or something like that. I may then ask someone else to have a further look, or do it myself. Any review helps, even without a full signoff. Looking forward to 3.0 :-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: rstrtmgr: add RmShutdown stub (resend)
by Sebastian Lackner 25 Jan '17

25 Jan '17

On 25.01.2017 06:28, Austin English wrote: > CC: Sebastian Lackner <sebastian(a)fds-team.de> > > Supersedes https://source.winehq.org/patches/data/128639 > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42093 > > Staged, https://github.com/wine-compholio/wine-staging/commit/b013afa66065427110c02… > > -- -Austin GPG: 14FB D7EA A041 937B > > > 0001-rstrtmgr-add-RmShutdown-stub-resend.patch > > > From fab99f2f9e398978461af053b38aa9b06b7bdc1d Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 28 Dec 2016 02:18:13 -0600 > Subject: [PATCH] rstrtmgr: add RmShutdown stub (resend) > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/rstrtmgr/main.c | 9 +++++++++ > dlls/rstrtmgr/rstrtmgr.spec | 2 +- > include/restartmanager.h | 3 +++ > 3 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/dlls/rstrtmgr/main.c b/dlls/rstrtmgr/main.c > index 2d45639..5c9a8dc 100644 > --- a/dlls/rstrtmgr/main.c > +++ b/dlls/rstrtmgr/main.c > @@ -100,3 +100,12 @@ DWORD WINAPI RmEndSession(DWORD handle) > FIXME("%u stub!\n", handle); > return ERROR_CALL_NOT_IMPLEMENTED; > } > + > +/*********************************************************************** > + * RmShutdown (rstrtmgr.@) > + */ > +DWORD WINAPI RmShutdown(DWORD handle, ULONG flags, RM_WRITE_STATUS_CALLBACK status) > +{ > + FIXME("%u, 0x%08x, %p stub!\n", handle, flags, status); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > diff --git a/dlls/rstrtmgr/rstrtmgr.spec b/dlls/rstrtmgr/rstrtmgr.spec > index 0e1ba79..6c6a9c9 100644 > --- a/dlls/rstrtmgr/rstrtmgr.spec > +++ b/dlls/rstrtmgr/rstrtmgr.spec > @@ -8,5 +8,5 @@ > @ stub RmRemoveFilter > @ stub RmReserveHeap > @ stdcall RmRestart(long long ptr) > -@ stub RmShutdown > +@ stdcall RmShutdown(long long ptr) > @ stdcall RmStartSession(ptr long ptr) > diff --git a/include/restartmanager.h b/include/restartmanager.h > index 27c1a92..51867a3 100644 > --- a/include/restartmanager.h > +++ b/include/restartmanager.h > @@ -64,6 +64,9 @@ typedef struct { > BOOL bRestartable; > } RM_PROCESS_INFO, *PRM_PROCESS_INFO; > > + > +typedef void *RM_WRITE_STATUS_CALLBACK(UINT); The calling convention is missing here, please see the staged version how it should look like. > + > #ifdef __cplusplus > } > #endif > -- 2.10.2 >

1 0

Re: [resend 2/3] ntdll: Implement FileIdInformation class support in NtQueryInformationFile.
by Sebastian Lackner 25 Jan '17

25 Jan '17

On 25.01.2017 04:57, Jonathan Doron wrote: > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->LowPart = (ULONG)volstats.f_fsid.__val[0]; > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->HighPart = (ULONG)volstats.f_fsid.__val[1]; Accessing members of f_fsid is not cross-platform compatible - you will either have to find a better way to get this information, or at least add corresponding checks to configure.ac. For more information see: https://linux.die.net/man/2/fstatfs """Nobody knows what f_fsid is supposed to contain (but see below).""" """Solaris, Irix and POSIX have a system call statvfs(2) that returns a struct statvfs (defined in <sys/statvfs.h>) containing an unsigned long f_fsid. Linux, SunOS, HP-UX, 4.4BSD have a system call statfs() that returns a struct statfs (defined in <sys/vfs.h>) containing a fsid_t f_fsid, where fsid_t is defined as struct { int val[2]; }."""

1 0

Re: [PATCH resend] user32: Also remove WM_CHAR from queue when a menu gets VK_ESCAPE and add tests
by Dmitry Timoshkov 25 Jan '17

25 Jan '17

Fabian Maurer <dark.shadow4(a)web.de> wrote: > +/* Test handling of VK_ESCAPE to close the menu */ > +static LRESULT WINAPI esc_test_wnd_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if(msg == WM_SHOWWINDOW) > + { > + PostMessageW(hwnd, WM_KEYDOWN, VK_ESCAPE, 0); > + HMENU hPopupMenu = CreatePopupMenu(); > + InsertMenuA(hPopupMenu, 0, MF_STRING, 10, "test"); > + TrackPopupMenu(hPopupMenu, 0, 0, 0, 0, hwnd, NULL); > + PostQuitMessage(0); > + } > + > + if(msg == WM_CHAR || msg == WM_KEYDOWN) > + ok(0, "Wrong VK_ESCAPE press detected.\n"); > + > + return DefWindowProcA(hwnd, msg, wparam, lparam); > +} Please add a test to msg.c instead. This should be a normal TrackPopupMenu test not wrapped inside of a parent's WM_SHOWWINDOW message handler. Once there is a message test, and the underlying behaviour is well understood a patch with a fix could be sent separately. -- Dmitry.

1 0

Re: [PATCH] gdi32: Add traces for painting functions
by Huw Davies 25 Jan '17

25 Jan '17

On Sat, Jan 21, 2017 at 06:45:31PM +0100, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/gdi32/painting.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 52 insertions(+), 4 deletions(-) I would suggest printing the point-like terms in the same way as wine_dbgstr_point() and the rect-like terms in the same way as wine_dbgstr_rect(). > @@ -237,6 +237,8 @@ BOOL WINAPI LineTo( HDC hdc, INT x, INT y ) > PHYSDEV physdev; > BOOL ret; > > + TRACE( "%p, %d, %d\n", hdc, x, y ); So this would be: TRACE( "%p, (%d,%d)\n", hdc, x, y ); > @@ -288,6 +292,8 @@ BOOL WINAPI Arc( HDC hdc, INT left, INT top, INT right, > BOOL ret; > DC * dc = get_dc_ptr( hdc ); > > + TRACE( "%p, %d, %d, %d, %d, %d, %d, %d, %d\n", hdc, left, top, right, bottom, xstart, ystart, xend, yend ); And this would be: TRACE( "%p, (%d,%d)-(%d,%d), (%d,%d), (%d,%d)\n", hdc, left, top, right, bottom, xstart, ystart, xend, yend ); > @@ -421,6 +437,8 @@ BOOL WINAPI RoundRect( HDC hdc, INT left, INT top, INT right, > BOOL ret; > DC *dc = get_dc_ptr( hdc ); > > + TRACE( "%p, %d, %d, %d, %d, %d, %d\n", hdc, left, top, right, bottom, ell_width, ell_height ); A size-like term could be: TRACE( "%p, (%d,%d)-(%d,%d), %dx%d\n", hdc, left, top, right, bottom, ell_width, ell_height ); > @@ -702,6 +738,8 @@ BOOL WINAPI ExtFloodFill( HDC hdc, INT x, INT y, COLORREF color, > BOOL ret; > DC * dc = get_dc_ptr( hdc ); > > + TRACE( "%p, %d, %d, %x, %x\n", hdc, x, y, color, fillType ); color should be %08x Huw.

2 1

Code freeze
by Fabian Maurer 25 Jan '17

25 Jan '17

Hello, Now that wine 2.0 is released, does this mark the end of code-freeze or should we still wait before sending in patches like normally? Regards, Fabian

2 1

Re: [PATCH] shell32: Implement knownfolder_GetRedirectionCapabilities somewhat
by Nikolay Sivov 24 Jan '17

24 Jan '17

On 23.01.2017 23:10, Enrico Horn wrote: > This is the one thing missing to get the config app for Temple+, a > Temple of Elemental Evil Mod, starting. > --- > dlls/shell32/shellpath.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c > index 92306239db7..3c44ecb393a 100644 > --- a/dlls/shell32/shellpath.c > +++ b/dlls/shell32/shellpath.c > @@ -5396,8 +5396,9 @@ static HRESULT WINAPI knownfolder_GetRedirectionCapabilities( > IKnownFolder *iface, > KF_REDIRECTION_CAPABILITIES *pCapabilities) > { > - FIXME("%p\n", pCapabilities); > - return E_NOTIMPL; > + FIXME("%p - always denied\n", pCapabilities); > + *pCapabilities = KF_REDIRECTION_CAPABILITIES_DENY_ALL; > + return S_OK; > } > > static HRESULT WINAPI knownfolder_GetFolderDefinition( > Do we have an open bug for that? If it's just a matter of returning static data, it's trivial to fix without any hacks.

2 1

RFC: Flushing the test reports
by Francois Gouget 24 Jan '17

24 Jan '17

When a test causes Windows to crash the test output is often lost, even if it was redirected to a file : said file is often either 0-byte long or is missing a huge chunk. This is particularly annoying when the crash happens as part of WineTest as then one has to manually run a bunch of tests to try and find which one caused the issue. And it's not always which test caused the crash as shown by the rasapi32:rasapi case (bug 42185). So I have tested a couple of approaches to better pinpoint which test is causing trouble, and possibly even which chunk of code in that test causes the crash. The first approach is simple: flush the WineTest report to disk between each test (in Unix terms sync). It has little impact on performance and in case of a crash the last 'dll:test start' line would clearly identify the test responsible. diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 50ebf4fd52a..df527734bb8 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -626,6 +626,11 @@ run_ex (char *cmd, HANDLE out_file, const char *tempdir, DWORD ms) PROCESS_INFORMATION pi; DWORD wait, status; + /* Flush to disk so we know which test caused Windows to crash if it does */ + if (out_file) + FlushFileBuffers(out_file); + FlushFileBuffers(GetStdHandle( STD_ERROR_HANDLE )); + GetStartupInfoA (&si); si.dwFlags = STARTF_USESTDHANDLES; si.hStdInput = GetStdHandle( STD_INPUT_HANDLE ); (the second flush is so WineTest's output too is flushed to disk in case stdout is redirected to a file though I did not really check that this part works) Another approach is to add these calls in wine/test.h. This narrows the location of the Windows crash down to an ok()/trace() interval, even more narrow if WINETEST_REPORT_SUCCESS is set. However this has quite an impact on performance: * WineTest normally takes about 19 minutes. * With the extra flushing this goes up to 29 minutes. * With no flushing but report success I get 45 minutes. * With both flushing and report success this shoots up to 315+ minutes. The report success cases can be ignored but even in the normal case the extra 10 minutes are probably not acceptable. So I set the flushing code behind a $WINETEST_FLUSH check. So once you've identified that, for instance, rasapi32:rasapi is causing trouble, you can run it on its own with report success and flushing to pinpoint where it goes wrong. Of course on the TestBot you still won't get the report (until the TestBot is changed appropriately), and you'll have to contend with the 2 minutes timeout but even with those options 88% of the tests completed within the time limit on my machine. That approach could be done with the patch below. commit ef211f6480fe84fd7660314c27bcaa5630dd0c16 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Sun Jan 22 02:57:23 2017 +0100 tests: Flush after each message if WINETEST_FLUSH is set. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> diff --git a/include/wine/test.h b/include/wine/test.h index aa89c55ca07..149b0a9ae14 100644 --- a/include/wine/test.h +++ b/include/wine/test.h @@ -52,6 +52,9 @@ extern int winetest_debug; /* running in interactive mode? */ extern int winetest_interactive; +/* flush after each trace */ +extern int winetest_flush; + /* current platform */ extern const char *winetest_platform; @@ -199,6 +202,9 @@ int winetest_debug = 1; /* interactive mode? */ int winetest_interactive = 0; +/* flush to disk after every message? */ +int winetest_flush = 0; + /* current platform */ const char *winetest_platform = "windows"; @@ -291,6 +297,11 @@ int broken( int condition ) { return (strcmp(winetest_platform, "windows") == 0) && condition; } +static void winetest_do_flush( void ) +{ + if (winetest_flush) + FlushFileBuffers(GetStdHandle( STD_ERROR_HANDLE )); +} /* * Checks condition. @@ -313,6 +324,7 @@ int winetest_vok( int condition, const char *msg, __winetest_va_list args ) printf( "%s:%d: Test succeeded inside todo block: ", data->current_file, data->current_line ); vprintf(msg, args); + winetest_do_flush(); InterlockedIncrement(&todo_failures); return 0; } @@ -323,6 +335,7 @@ int winetest_vok( int condition, const char *msg, __winetest_va_list args ) printf( "%s:%d: Test marked todo: ", data->current_file, data->current_line ); vprintf(msg, args); + winetest_do_flush(); } InterlockedIncrement(&todo_successes); return 1; @@ -335,14 +348,18 @@ int winetest_vok( int condition, const char *msg, __winetest_va_list args ) printf( "%s:%d: Test failed: ", data->current_file, data->current_line ); vprintf(msg, args); + winetest_do_flush(); InterlockedIncrement(&failures); return 0; } else { if (report_success) + { printf( "%s:%d: Test succeeded\n", data->current_file, data->current_line); + winetest_do_flush(); + } InterlockedIncrement(&successes); return 1; } @@ -369,6 +386,7 @@ void __winetest_cdecl winetest_trace( const char *msg, ... ) __winetest_va_start(valist, msg); vprintf(msg, valist); __winetest_va_end(valist); + winetest_do_flush(); } } @@ -378,6 +396,7 @@ void winetest_vskip( const char *msg, __winetest_va_list args ) printf( "%s:%d: Tests skipped: ", data->current_file, data->current_line ); vprintf(msg, args); + winetest_do_flush(); skipped++; } @@ -443,7 +462,10 @@ void winetest_wait_child_process( HANDLE process ) DWORD exit_code = 1; if (WaitForSingleObject( process, 30000 )) + { printf( "%s: child process wait failed\n", current_test->name ); + winetest_do_flush(); + } else GetExitCodeProcess( process, &exit_code ); @@ -452,12 +474,14 @@ void winetest_wait_child_process( HANDLE process ) if (exit_code > 255) { printf( "%s: exception 0x%08x in child process\n", current_test->name, exit_code ); + winetest_do_flush(); InterlockedIncrement( &failures ); } else { printf( "%s: %u failures in child process\n", current_test->name, exit_code ); + winetest_do_flush(); while (exit_code-- > 0) InterlockedIncrement(&failures); } @@ -599,6 +623,7 @@ static int run_test( const char *name ) todo_successes, failures + todo_failures, (failures + todo_failures != 1) ? "failures" : "failure", skipped ); + winetest_do_flush(); } status = (failures + todo_failures < 255) ? failures + todo_failures : 255; return status; @@ -624,6 +649,7 @@ static LONG CALLBACK exc_filter( EXCEPTION_POINTERS *ptrs ) printf( "%s: unhandled exception %08x at %p\n", current_test->name, ptrs->ExceptionRecord->ExceptionCode, ptrs->ExceptionRecord->ExceptionAddress ); fflush( stdout ); + winetest_do_flush(); return EXCEPTION_EXECUTE_HANDLER; } @@ -660,6 +686,7 @@ int main( int argc, char **argv ) if (GetEnvironmentVariableA( "WINETEST_IS_CHILD", p, sizeof(p) )) winetest_is_child = atoi(p); /* Identify any future process as a child of this one */ SetEnvironmentVariableA( "WINETEST_IS_CHILD", "1" ); + if (GetEnvironmentVariableA( "WINETEST_FLUSH", p, sizeof(p) )) winetest_flush = atoi(p); if (!strcmp( winetest_platform, "windows" )) SetUnhandledExceptionFilter( exc_filter ); if (!winetest_interactive) SetErrorMode( SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX ); Both approaches could be combined. Comments? Suggestions? -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH] winegstreamer: Avoid zero division in amt_from_gst_caps_video().
by Andrew Eikum 24 Jan '17

24 Jan '17

Hi Masanori, Thank you for working on this! We're late in code freeze right now, can you please re-submit this patch after Wine 2.0 is released? Also, it would be better to use the MulDiv function to avoid integer overflow: vih->AvgTimePerFrame = (nom == 0) ? 0 : MulDiv(10000000, denom, nom); Andrew On Mon, Jan 23, 2017 at 10:29:19PM +0900, Masanori Kakura wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42212 > > Signed-off-by: Masanori Kakura <kakurasan(a)gmail.com> > --- > dlls/winegstreamer/gstdemux.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c > index c33ed9e..14ee584 100644 > --- a/dlls/winegstreamer/gstdemux.c > +++ b/dlls/winegstreamer/gstdemux.c > @@ -233,9 +233,7 @@ static gboolean amt_from_gst_caps_video(GstCaps *caps, AM_MEDIA_TYPE *amt) > bih->biCompression = amt->subtype.Data1; > } > bih->biSizeImage = width * height * bih->biBitCount / 8; > - vih->AvgTimePerFrame = 10000000; > - vih->AvgTimePerFrame *= denom; > - vih->AvgTimePerFrame /= nom; > + vih->AvgTimePerFrame = (nom == 0) ? 0 : 10000000 * denom / nom; > vih->rcSource.left = 0; > vih->rcSource.right = width; > vih->rcSource.top = height; > -- > 2.9.3 > > >

1 0

Re: dinput: Silence some effects feedback in linuxinput
by Andrew Eikum 24 Jan '17

24 Jan '17

Instead of adding new cases, would you be opposed to just changing the FIXME into a TRACE or maybe a WARN? I think that would scale better, and users are likely only interested if they're doing dinput development anyway. Andrew

2 1

Re: [PATCH] Rename Mac OS X to macOS
by Nikolay Sivov 23 Jan '17

23 Jan '17

On 23.01.2017 22:19, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > en/winedev-multimedia.sgml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/en/winedev-multimedia.sgml b/en/winedev-multimedia.sgml > index fa04b04..4c95349 100644 > --- a/en/winedev-multimedia.sgml > +++ b/en/winedev-multimedia.sgml > @@ -330,7 +330,7 @@ Kernel space | Client applications > </listitem> > <listitem> > <para> > - Core Audio as introduced in Mac OS X 10.3. Source code resides in > + Core Audio as introduced in macOS 10.3. Source code resides in > <filename class="libraryfile">dlls/winecoreaudio.drv</filename>. > </para> > </listitem> > 10.3 was before macOS renaming, so original sounds better to me.

2 1

Re: [PATCH] programs/winhlp32: Use noyywrap for macro.lex.l
by Fabian Maurer 23 Jan '17

23 Jan '17

On Sunday, January 22, 2017 11:00:26 AM CET Mike Swanson wrote: > diff --git a/programs/winhlp32/macro.lex.l b/programs/winhlp32/macro.lex.l > index 8f6945ca98..ff8a4832d3 100644 > --- a/programs/winhlp32/macro.lex.l > +++ b/programs/winhlp32/macro.lex.l > @@ -20,7 +20,7 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA */ > %} > -%option noinput nounput never-interactive 8bit > +%option noinput nounput noyywrap never-interactive 8bit > %x quote > %{ > #include "config.h" > @@ -367,7 +367,3 @@ WINHELP_WINDOW* MACRO_CurrentWindow(void) > { > return lex_data ? lex_data->window : Globals.active_win; > } > - > -#ifndef yywrap > -int yywrap(void) { return 1; } > -#endif > -- > 2.11.0 Hello, I applied the patch and it compiles now, but I get a warning: > macro.lex.yy.c:398:0: warning: "yywrap" redefined > macro.lex.yy.c:74:0: note: this is the location of the previous definition You probably want to get rid of that, too. Regards, Fabian

4 5

Re: [PATCH] ws2_32/tests: Fix memcmp size in test_TransmitFile().
by Bruno Jesus 23 Jan '17

23 Jan '17

On Fri, Jan 20, 2017 at 5:54 PM, Zebediah Figura <z.figura12(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42221 > > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/ws2_32/tests/sock.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 5856718..3c3e443 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -8304,9 +8304,9 @@ static void test_TransmitFile(void) > iret = recv(dest, buf, sizeof(buf), 0); > ok(iret == sizeof(header_msg)+sizeof(footer_msg)+2, > "Returned an unexpected buffer from TransmitFile: %d\n", iret ); > - ok(memcmp(&buf[0], &header_msg[0], sizeof(header_msg)+1) == 0, > + ok(memcmp(&buf[0], &header_msg[0], sizeof(header_msg)) == 0, > "TransmitFile header buffer did not match!\n"); > - ok(memcmp(&buf[sizeof(header_msg)+1], &footer_msg[0], sizeof(footer_msg)+1) == 0, > + ok(memcmp(&buf[sizeof(header_msg)+1], &footer_msg[0], sizeof(footer_msg)) == 0, > "TransmitFile footer buffer did not match!\n"); Hi, you also have to change the sending lengths because it is also using +1. I believe this was a strlen/sizeof misfortune, right? Best wishes, Bruno

3 4

Re: server: Remove dead check in is_cpu_supported().
by Henri Verbeet 22 Jan '17

22 Jan '17

For what it's worth, On 21 January 2017 at 16:25, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I am wondering about the following piece of code in server/thread.c: > > int is_cpu_supported( enum cpu_type cpu ) > { > unsigned int prefix_cpu_mask = get_prefix_cpu_mask(); > > if (CPU_FLAG(cpu) && (supported_cpus & prefix_cpu_mask & CPU_FLAG(cpu))) return 1; > > that was added as part of > > commit 1e78c99388c61d353cf60787eac6415328f54560 > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Nov 22 12:32:48 2013 +0100 > > kernel32: Validate the architecture of newly created processes on the server side. > It's actually older than that, and seems to have been introduced by commit 279defe66e1265eeae3e2a72126c2b2f75e20c99 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Apr 3 14:59:12 2009 +0200 server: Verify that the client is using a supported CPU type. > That means CPU_FLAG(...) is always positive and different from zero > -- unless its parameter is 32 or higher on a 32-bit architecture > (and the 1 shifts out). > But the definition of CPU_FLAG doesn't really matter for this. If "CPU_FLAG(cpu)" evaluates to zero, "supported_cpus & prefix_cpu_mask & CPU_FLAG(cpu)" evaluates to zero as well.

2 1

Re: [PATCH] ws2_32/tests: Fix memcmp size in test_TransmitFile().
by Marvin 22 Jan '17

22 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27913 Your paranoid android. === w8 (32 bit sock) === sock.c:7995: Test failed: bytesReturned isn't supposed to be 1 sock.c:8019: Test failed: GetOverlappedResult failed, error 0

1 0

TestBot news
by Francois Gouget 21 Jan '17

21 Jan '17

I have upgraded Debian on vm1 from 7 to 8.6 and the filesystem from ext3 to ext4. This gets it a non-antique version of the kernel and QEMU which includes Huw's fix for the ntdll:exception test. So there should be one less unfixable failure for VMs being run on vm1. That said I'm not really happy with the state of things on vm1: for some reason its reverts are much slower than they should be. For instance with the wvista VM doing 3 reverts in a row on otherwise idle machines gives me: vm1 56.361s 46.803s 46.569s vm2 10.206s 9.783s 9.912s vm3 9.583s 8.137s 8.004s One could think that vm2 has much better hardware but that's just not the case: PassMark Disk Disk Host CPU MT ST Type Speed vm1 Xeon E3-1230v2 8855 1940 HD 130 MB/s vm2 Opteron 6128 6959 n/a HD Raid0 144 MB/s vm3 Xeon E3-1226v3 7462 2127 SSD 354 MB/s All hosts have 16 GB of RAM. So vm2 has what looks like a somewhat slower processor and a marginally faster disk thanks to Raid0. That should not be sufficient for it to be 4 times faster, particularly given that vm3 has a disk that's over twice as fast is only marginally faster than vm2. Indeed during the revert vm1 shows no read traffic (lots of RAM to cache that), but a steady 6 MB/s stream of writes ! In contrast on vm2 writes quickly ramp up to 80 MB/s, then stop after ~5 seconds and QEMU just uses CPU for the last ~4 seconds. vm3 also shows it's not an AMD vs Intel thing. There may be some missing CPU feature on vm1 but if that's the case I don't see what. So there is still a mystery there and if anyone has an insight into it it would be appreciated. Despite that I have put vm1 back to active duty. But I decided to keep the wvistau64 VM on the vm2 host. This means vm1 essentially only has one VM to take care of and since most of the time it's going to be idle already it should not slow jobs down. I also applied all Windows updates up to 2016/07/25 to the w7u VM. This caused some new failures that Hans started tackling / fixed. Any other new failure on the 3 VMs affected by the upgrade (wvista, wvistau64 and w7u) should be fixable. The configuration of the other two vms, wvista and wvistau64 should be essentially unchanged. Finally I also performed a minor upgrade on vm3: from Debian 8.2 to 8.6. The goal was to see if the minor QEMU upgrade would be sufficient to get Windows 10 to stop crashing when running WineTest. It looks like that's not the case. So the next step will be to grab QEMU 2.7 from the Debian BackPorts but there's a dumb command line incompatibility with libvirt 1.2.9 and there's no easily installable alternative :-( Fortunately I have a qemu wrapper script that should bridge the gap. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

authz.dll
by André Hentschel 21 Jan '17

21 Jan '17

Hi, while looking through the output of my wip script for detecting wrong spec file entries I came across authz.dll And here we have two suspicious functions: AuthzInitializeContextFromSid and AuthzInitializeContextFromToken Both have a parameter of type "LUID" (a struct, not a pointer) which is defined as: typedef struct _LUID { DWORD LowPart; LONG HighPart; } LUID, *PLUID; The spec-file says this is a long: @ stdcall AuthzInitializeContextFromSid(long ptr long ptr long ptr ptr) @ stdcall AuthzInitializeContextFromToken(long long long ptr long ptr ptr) I think a struct like this deserves two longs ("long long") in the spec file, right?

1 0

Wine and Valgrind / handling SIGILL
by Austin English 20 Jan '17

20 Jan '17

Howdy all, Several months ago, a patch from Sebastian: commit 44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu Feb 12 11:09:34 2015 +0100 winebuild: Do not access memory below ESP when restoring thread contexts. Based on a patch by John Reiser. for https://bugs.winehq.org/show_bug.cgi?id=14367 Caused problems for running Wine under Valgrind: https://bugs.kde.org/show_bug.cgi?id=344139 There are patches floating around for both Wine and Valgrind (see previous link), but from what I've seen so far, both projects aren't a fan of the current patches. Given that Wine developers like using Valgrind to check for problems, and I know Julian would like to use Wine with Valgrind, I feel like some solution to this problem can be found. Since my efforts at trying to run messages between the two projects hasn't solved it yet, I figured an email thread would work better ;). -- -Austin GPG: 14FB D7EA A041 937B

3 7

Wine-2.0-rc5 source code (Cppcheck 1.72)
by Игорь Чебаненко 20 Jan '17

20 Jan '17

Wine source code scanning with Cppcheck.

1 0

Re: [PATCH 5/5] wined3d: Recognize another Radeon HD 4650 PCI device id.
by Henri Verbeet 19 Jan '17

19 Jan '17

On 18 January 2017 at 21:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > For bug 34671, with thanks to winetaste(a)gmx.net for the relevant info. > This still doesn't make sense to me. In what cases does this make a difference? Which of those do we care about? > @@ -2018,8 +2019,8 @@ cards_amd_binary[] = > - {"HD 4670", CARD_AMD_RADEON_HD4600}, /* Radeon RV730 */ > - {"HD 4650", CARD_AMD_RADEON_HD4600}, /* Radeon RV730 */ > + {"HD 4670", CARD_AMD_RADEON_HD4650}, /* Radeon RV730 */ > + {"HD 4650", CARD_AMD_RADEON_HD4650}, /* Radeon RV730 */ This is arbitrary.

2 2

Re: [PATCH] setupapi: Stub CM_Open_DevNode_Key and CM_Get_Child
by Nikolay Sivov 19 Jan '17

19 Jan '17

On 18.01.2017 22:40, Christoph Brill wrote: > Both are necessary to start Lord of the Rings Online as of January 2017 > > Signed-off-by: Christoph Brill <egore911(a)gmail.com> > --- > dlls/setupapi/setupapi.spec | 4 ++-- > dlls/setupapi/stubs.c | 22 ++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec > index 0eb8359ee1..5c57c23431 100644 > --- a/dlls/setupapi/setupapi.spec > +++ b/dlls/setupapi/setupapi.spec > @@ -53,7 +53,7 @@ > @ stub CM_Free_Res_Des > @ stub CM_Free_Res_Des_Ex > @ stub CM_Free_Res_Des_Handle > -@ stub CM_Get_Child > +@ stdcall CM_Get_Child(ptr long long) > @ stub CM_Get_Child_Ex > @ stub CM_Get_Class_Key_NameA > @ stub CM_Get_Class_Key_NameW > @@ -144,7 +144,7 @@ > @ stub CM_Open_Class_KeyW > @ stub CM_Open_Class_Key_ExA > @ stub CM_Open_Class_Key_ExW > -@ stub CM_Open_DevNode_Key > +@ stdcall CM_Open_DevNode_Key(long long long long ptr long) > @ stub CM_Open_DevNode_Key_Ex > @ stub CM_Query_And_Remove_SubTreeA > @ stub CM_Query_And_Remove_SubTreeW > diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c > index 6ecf240c86..1f76b08a3d 100644 > --- a/dlls/setupapi/stubs.c > +++ b/dlls/setupapi/stubs.c > @@ -79,6 +79,28 @@ CONFIGRET WINAPI CM_Disconnect_Machine(HMACHINE handle) > } > > /*********************************************************************** > + * CM_Open_DevNode_Key (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Open_DevNode_Key( > + DEVINST dnDevInst, REGSAM access, ULONG ulHardwareProfile, ULONG /*REGDISPOSITION*/ disposition, > + PHKEY phkDevice, ULONG ulFlags) > +{ > + FIXME("0x%08x 0x%08x 0x%08x 0x%08x %p 0x%08x : stub\n", dnDevInst, access, ulHardwareProfile, > + disposition, phkDevice, ulFlags); > + return CR_SUCCESS; > +} > + > +/*********************************************************************** > + * CM_Get_Child (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Get_Child( > + PDEVINST pdnDevInst, DEVINST dnDevInst, ULONG ulFlags) > +{ > + FIXME("%p 0x%08x 0x%08x: stub\n", pdnDevInst, dnDevInst, ulFlags); > + return CR_SUCCESS; > +} > + Hi, Christoph. Please add prototypes to corresponding public header too. This will also fix REGDISPOSITION case - no reason not to have proper typedef for it. Also please run ./tools/make_specfiles to update dependent dlls.

1 0

Re: iphlpapi/tests: Add test for AllocateAndGetTcpExTableFromStack
by Sebastian Lackner 18 Jan '17

18 Jan '17

On 16.01.2017 17:55, André Hentschel wrote: > + ok( ret == ERROR_INVALID_PARAMETER || broken(ERROR_NOT_SUPPORTED) /* win2k */, "got %u\n", ret ); That is not how broken() works.

1 0

Re: regedit: Select a treeitem on right mouse click
by Nikolay Sivov 18 Jan '17

18 Jan '17

On 17.01.2017 12:47, Hugh McMaster wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=14606 > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/childwnd.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c > index 08eeec1..c9a35be 100644 > --- a/programs/regedit/childwnd.c > +++ b/programs/regedit/childwnd.c > @@ -411,8 +411,19 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa > g_pChildWnd->nFocusPanel = 0; > break; > case NM_RCLICK: { > - POINT pt; > + POINT pt, client_pt; > + TVHITTESTINFO ht; > + HTREEITEM treeitem; > + HWND hTree = ((NMHDR *)lParam)->hwndFrom; > + > GetCursorPos(&pt); > + client_pt = pt; > + ScreenToClient(hWnd, &client_pt); > + ht.pt = client_pt; > + treeitem = (HTREEITEM)SendMessageA(hTree, TVM_HITTEST, 0, (LPARAM)&ht); > + if (!treeitem) return 1; > + SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)treeitem); > + > TrackPopupMenu(GetSubMenu(hPopupMenus, PM_NEW), > TPM_RIGHTBUTTON, pt.x, pt.y, 0, hFrameWnd, NULL); > break; > This looks like a workaround, according to https://bugs.winehq.org/show_bug.cgi?id=14606 you should be able to TVM_GETNEXTITEM with TVGN_CARET, as selection should happen automatically.

2 1

Re: [PATCH v2] shlwapi: Fix the return value of SHAddDataBlock
by Marvin 17 Jan '17

17 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27838 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcrt: Implement nan
by Piotr Caban 17 Jan '17

17 Jan '17

On 01/14/17 00:11, Daniel Lehman wrote: > +double CDECL MSVCR120_nan(const char *tagp) > +{ > + /* Windows ignores input (MSDN) and Linux crashes on NULL */ > + const char *dummy = "NAN"; > +#ifdef HAVE_NAN > + return nan(dummy); > +#else > + return strtod(dummy, NULL); > +#endif > +} Why can't you just "return NAN;" here? Thanks, Piotr

2 1

Wine po issue page broken?
by Julian Rüger 17 Jan '17

17 Jan '17

Hi Francois and list, the po issue page http://fgouget.free.fr/wine-po/ has not updated for quite some time. It shows abb221fa81b60f53c14f6864bbfb9453455aeeeb as its latest commit id (that is the git commit id, right?), which is the release of 1.9.14, July 2016. First of all, did I miss something? I find that page quite useful, personally. What about the other translators? Seems there is not much interest...? http://source.winehq.org/transl/ is broken for me as well. It would be nice to hear from other translators, how much do you use these pages, would you like them to be fixed? If it's just me, please don't bother; otherwise it would be great if someone could look into it! All the best and a happy new year to everyone! Julian

6 9

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Marvin 17 Jan '17

17 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27756 Your paranoid android. === w8 (32 bit visual) === visual.c:7986: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

3 2

Re: [2/2] iphlpapi: Use the new version of the IP_ADAPTER_UNICAST_ADDRESS structure (try 2)
by Hans Leidekker 16 Jan '17

16 Jan '17

On Fri, 2017-01-13 at 13:27 +0100, André Hentschel wrote: > diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c > index 54f7a37..223d980 100644 > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -1065,6 +1065,13 @@ static ULONG adapterAddressesFromIndex(ULONG family, ULONG flags, IF_INDEX index > debugstr_ipv4(&sa->sin_addr.S_un.S_addr, addr_buf)); > fill_unicast_addr_data(aa, ua); > > + ua->OnLinkPrefixLength = 0; > + for (j = 0; j < sizeof(*v4masks) * 8; j++) > + { > + if (v4masks[i] & 1 << j) ua->OnLinkPrefixLength++; > + else break; > + } > + Please add a helper to compute prefix length instead of duplicating this code. This should probably wait until the code freeze is over.

3 6

Re: [PATCH] msvcrt: Trace clean_type_info_names_internal
by Piotr Caban 16 Jan '17

16 Jan '17

On 01/12/17 23:57, Jarkko Korpi wrote: > > Signed-off-by: Jarkko Korpi <jarkko_korpi(a)hotmail.com> > > There are only 2 fixmes in the file, all others are traces. And the other fixme is printed only once. This is printed quite often. There are only 2 FIXMEs in the file because other functions are implemented. I don't think this FIXME is very annoying taking into account that it's mainly printed when the application exits. Is it causing any issues for you? I prefer to have it printed unless it breaks application or makes logs unusable. Thanks, Piotr

1 0

Re: wined3d: Do not set DDCAPS_ALIGNBOUNDARYSRC caps for ddraw.
by Henri Verbeet 16 Jan '17

16 Jan '17

On 16 January 2017 at 15:07, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > The ALIGNBOUNDARYSRC flag suddenly appeared in c8901d6f6253f6c97610eb1068ac4ff89758ed0a, > although dwAlignBoundarySrc is not initialized. > It should be set to 0 by ddraw, although I could certainly see that causing issues.

1 0

Re: [PATCH v2 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Marvin 14 Jan '17

14 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27774 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:259: SPI_SETSCREENSAVETIMEOUT failed for reason: 329. Indicating test failure and skipping remainder of test sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Nikolay Sivov 14 Jan '17

14 Jan '17

On 14.01.2017 22:33, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/gdi32/gdi32.spec | 2 ++ > dlls/gdi32/gdiobj.c | 12 ++++++++++++ > dlls/user32/sysparams.c | 23 +++++++++++++++++------ > dlls/user32/tests/sysparams.c | 16 ++++++++++++++++ > include/wine/gdi_driver.h | 2 ++ > 5 files changed, 49 insertions(+), 6 deletions(-) > > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 7792731b9e..f9c3fb9293 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -518,6 +518,8 @@ > # GDI objects > @ cdecl __wine_make_gdi_object_system(long long) > @ cdecl __wine_set_visible_region(long long ptr ptr ptr) > +@ cdecl __wine_GDI_ReleaseObj(ptr) > +@ cdecl __wine_GDI_GetObjPtr(ptr long) > > # Graphics drivers > @ cdecl __wine_set_display_driver(long) > diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c > index 46b2241945..aa2ced1025 100644 > --- a/dlls/gdi32/gdiobj.c > +++ b/dlls/gdi32/gdiobj.c > @@ -880,6 +880,18 @@ void GDI_ReleaseObj( HGDIOBJ handle ) > LeaveCriticalSection( &gdi_section ); > } > > +/* Exports for user32, we need to be able to manipulate GDI objects where the official API doesn't allow us */ > + > +void* CDECL __wine_GDI_GetObjPtr( HGDIOBJ handle, WORD type ) > +{ > + return GDI_GetObjPtr( handle, type ); > +} > + > +void CDECL __wine_GDI_ReleaseObj( HGDIOBJ handle ) > +{ > + GDI_ReleaseObj( handle ); > +} > + > This is too much. If you only need to update object property while keeping same handle, you only need one additional call like __wine_set_gdi_object_color(), that should work for both brushes and pens, checking if it's a system object too, as an additional precaution. > +static void set_syscolors_gdi( INT index, COLORREF color ) > +{ > + HBRUSH brush = system_colors[index].brush; > + LOGBRUSH *brush_info; > + > + if(brush) > + { > + /* Since LOGBRUSH is the first member in BRUSHOBJ we just do a cast here */ > + brush_info = __wine_GDI_GetObjPtr( brush, OBJ_BRUSH ); > + if(brush_info->lbColor != color) > + brush_info->lbColor = color; > + __wine_GDI_ReleaseObj( brush ); > + } > +} > This looks very dirty.

2 1

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Marvin 14 Jan '17

14 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27773 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:259: SPI_SETSCREENSAVETIMEOUT failed for reason: 329. Indicating test failure and skipping remainder of test sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/3] winemac: Export HTML Format clipboard data to the public.html pasteboard type.
by Sebastian Lackner 13 Jan '17

13 Jan '17

On 13.01.2017 20:36, Ken Thomases wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > dlls/winemac.drv/clipboard.c | 68 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 67 insertions(+), 1 deletion(-) > > diff --git a/dlls/winemac.drv/clipboard.c b/dlls/winemac.drv/clipboard.c > index fdd1110..49a3ed3 100644 > --- a/dlls/winemac.drv/clipboard.c > +++ b/dlls/winemac.drv/clipboard.c > @@ -82,6 +82,7 @@ static CFDataRef export_bitmap_to_bmp(HANDLE data); > static CFDataRef export_dib_to_bmp(HANDLE data); > static CFDataRef export_enhmetafile(HANDLE data); > static CFDataRef export_hdrop_to_filenames(HANDLE data); > +static CFDataRef export_html(HANDLE data); > static CFDataRef export_metafilepict(HANDLE data); > static CFDataRef export_text_to_utf8(HANDLE data); > static CFDataRef export_unicodetext_to_utf8(HANDLE data); > @@ -186,7 +187,7 @@ static const struct > { wszJFIF, CFSTR("public.jpeg"), import_clipboard_data, export_clipboard_data }, > { wszPNG, CFSTR("public.png"), import_clipboard_data, export_clipboard_data }, > { wszHTMLFormat, NULL, import_clipboard_data, export_clipboard_data }, > - { wszHTMLFormat, CFSTR("public.html"), import_html, NULL, TRUE }, > + { wszHTMLFormat, CFSTR("public.html"), import_html, export_html, TRUE }, > { CFSTR_SHELLURLW, CFSTR("public.url"), import_utf8_to_text, export_text_to_utf8 }, > }; > > @@ -522,6 +523,28 @@ static HANDLE create_bitmap_from_dib(HANDLE dib) > > > /************************************************************************** > + * get_html_description_field > + * > + * Find the value of a field in an HTML Format description. > + */ > +static const char* get_html_description_field(const char* data, const char* keyword) > +{ > + const char* pos = data; > + > + while (pos && *pos && *pos != '<') > + { > + if (memcmp(pos, keyword, strlen(keyword)) == 0) Its not safe to use memcmp, it could read past the terminating \0 of data. > + return pos + strlen(keyword); > + > + pos = strchr(pos, '\n'); > + if (pos) pos++; > + } > + > + return NULL; > +} > + > + > +/************************************************************************** > * import_clipboard_data > * > * Generic import clipboard data routine. > @@ -1141,6 +1164,49 @@ done: > > > /************************************************************************** > + * export_html > + * > + * Export HTML Format to public.html data. > + * > + * FIXME: We should attempt to add an <a base> tag and convert windows paths. > + */ > +static CFDataRef export_html(HANDLE handle) > +{ > + CFDataRef ret; > + const char *data, *field_value; > + int fragmentstart, fragmentend; > + > + data = GlobalLock(handle); > + > + /* read the important fields */ > + field_value = get_html_description_field(data, "StartFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find StartFragment value\n"); > + goto failed; > + } > + fragmentstart = atoi(field_value); > + > + field_value = get_html_description_field(data, "EndFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find EndFragment value\n"); > + goto failed; > + } > + fragmentend = atoi(field_value); > + > + /* export only the fragment */ > + ret = CFDataCreate(NULL, (const UInt8*)&data[fragmentstart], fragmentend - fragmentstart); Some validation of those offsets wouldn't hurt. > + GlobalUnlock(handle); > + return ret; > + > +failed: > + GlobalUnlock(handle); > + return NULL; > +} > + > + > +/************************************************************************** > * export_metafilepict > * > * Export a metafile to data. >

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Henri Verbeet 13 Jan '17

13 Jan '17

On 13 January 2017 at 12:53, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 > Strictly speaking that's not a regression, but I'm willing to risk it.

1 0

Re: [PATCH] wined3d: Add Iris Haswell PCI ids and descriptions
by André Hentschel 13 Jan '17

13 Jan '17

Am 13.01.2017 um 06:42 schrieb Michael Cronenworth: > --- > dlls/wined3d/directx.c | 11 +++++++++++ > dlls/wined3d/wined3d_private.h | 9 +++++++++ > 2 files changed, 20 insertions(+) > Hi, you forgot to sign off your patch

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Bruno Jesus 13 Jan '17

13 Jan '17

On Fri, Jan 13, 2017 at 9:53 AM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 Most likely also fixes https://bugs.winehq.org/show_bug.cgi?id=28874

1 0

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Józef Kucia 13 Jan '17

13 Jan '17

On Fri, Jan 13, 2017 at 12:53 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d9/tests/visual.c | 81 ------------------------------------------------ > 1 file changed, 81 deletions(-) There is a typo in the subject prefix. It should read "d3d9/tests:".

1 0

Re: [tools] patches: Say "translation files" instead of "resource files".
by Henri Verbeet 13 Jan '17

13 Jan '17

On 13 January 2017 at 05:47, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > @@ -69,7 +69,7 @@ my @legend = > [ "formatting", "<ul><li>The patch author's full name, email address, or Signed-off-by headers are incorrect or missing.</li>" . > "<li>Whitespace got mangled in transit.</li>" . > "<li>Indentation is messed up (usually from editing with a non-standard tab size).</li>" . > - "<li>8-bit chars got mangled in transit (usually when sending patches to resource files).</li>" . > + "<li>8-bit chars got mangled in transit (usually when sending patches to translation files).</li>" . I guess this is fine, and not to make too much of a point of it, but this might as well read "usually when not using git send-email".

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Dmitry Timoshkov 13 Jan '17

13 Jan '17

Anton Romanov <theli.ua(a)gmail.com> wrote: > +todo_wine { > + enabled = 2; > + ret = getsockopt(v4, IPPROTO_IPV6, IPV6_V6ONLY, (char*)&enabled, &len); > + ok(!ret, "getsockopt(IPV6_ONLY) failed (LastError: %d)\n", WSAGetLastError()); > + ok(enabled == 1, "expected 1, got %d\n", enabled); > +} The 'todo_wine' statements should be added only around ok() call that will fail otherwise. This applies for other places in the patch as well. -- Dmitry.

2 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2017