January 2017 - wine-devel

Re: [PATCH v4] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin 12 Jan '17

12 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin 12 Jan '17

12 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27728 Your paranoid android. === build (build) === Patch failed to apply

1 0

TaskDialog implementation - Feedback needed
by Fabian Maurer 12 Jan '17

12 Jan '17

Hello, As already mentioned in "commctl32: TaskDialog", I'm currently working on a full implementation for TaskDialogIndirect. Now that I have a working foundation, I figured I ask for feedback instead of having to rewrite it later. Since TaskDialogs are very dynamic, the approach is to create a dialog template in memory, and then show it as dialog box. I attached 3 patches which create a small dialog. Though it doesn't do much (or anything) yet, it should be very easy to start from there and add all the missing functionality piece by piece. Criticism welcome. Fabian

1 0

Re: [PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Sebastian Lackner 12 Jan '17

12 Jan '17

On 12.01.2017 06:27, Anton Romanov wrote: > + > + bound = is_fd_bound(fd, &uaddr, &uaddrlen); > + release_sock_fd( s, fd ); > + if (uaddr.addr.sa_family == AF_INET && bound == 0) You might want to change the order here, uaddr is not initialized if is_fd_bound fails.

2 1

Re: [PATCH] wine.inf: Add Dynamic DST data for Asia/Tehran.
by Sebastian Lackner 12 Jan '17

12 Jan '17

On 12.01.2017 14:08, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > loader/wine.inf.in | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > Could you please also add day-of-week information, like its done in all the other Dynamic DST entries? Besides that, I'm also not sure if we really need registry entries for dates back until 1991. I have intentionally left out such information in the past. Best regards, Sebastian

2 1

Re: [v2] oleaut32: Make the heap allocation functions static.
by Alexandre Julliard 12 Jan '17

12 Jan '17

Francois Gouget <fgouget(a)free.fr> writes: > @@ -1600,26 +1600,26 @@ static void TLB_abort(void) > DebugBreak(); > } > > -void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > +static void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > { > void *ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > if (!ret) ERR("cannot allocate memory\n"); > return ret; > } There are standard functions that I expect we'd want to use in more places (right Michael?) -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: iphlpapi: Avoid sockaddr scope confusion
by Alexandre Julliard 11 Jan '17

11 Jan '17

André Hentschel <nerv(a)dawncrow.de> writes: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/iphlpapi/iphlpapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't look to me like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] Disabling IPV6_V6ONLY on AF_INET succeeds in Windows starting with Vista
by Bruno Jesus 11 Jan '17

11 Jan '17

On Tue, Jan 10, 2017 at 3:44 PM, Anton Romanov <theli.ua(a)gmail.com> wrote: > Fixes Magic The Gathering Online not able to login > --- > dlls/ws2_32/socket.c | 22 ++++++++++++++++++++++ > dlls/ws2_32/tests/sock.c | 24 +++++++++++++++++++++++- > 2 files changed, 45 insertions(+), 1 deletion(-) Hi, can you please open a bug report attaching a +winsock so we can discuss this further? Best wishes, Bruno

2 4

Re: Wine po issue page broken?
by Francois Gouget 11 Jan '17

11 Jan '17

Lauri Kenttä wrote: > With proper spell checking, I could take a look at the Swedish > translation, but the Swedish spell checking on wine-po has always been > broken (includes dots in words and so produces hundreds of false > positives). I'm not sure the periods are an issue. The command I run is: aspell -l sv --encoding utf-8 And it seems to return the same result whether there is a trailing period or not: arraygränser. # arraygränser. 0 arraygränser # arraygränser 0 cmd-fönstret. # cmd-fönstret. 0 cmd-fönstret # cmd-fönstret 0 drivrutinsnivå. ? drivrutinsnivå. 0 0: driv drivrutinsnivå ? drivrutinsnivå 0 0: driv konsoll. & konsoll. 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors konsoll & konsoll 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

Re: [v2 PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27687 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH 1/2] ddraw/tests: Try to avoid killing the Intel (kernel) driver.
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27682 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Alexandre Julliard 10 Jan '17

10 Jan '17

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/user32/tests/win.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) This doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:6758: Test failed: Unexpected text length, 7 win.c:6760: Test failed: Unexpected buffer contents, 0x20ac win.c:6769: Test failed: Unexpected text length, 18 win.c:6771: Test failed: Unexpected buffer contents make: *** [win.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/2] riched20: Only pass valid length to ME_InsertTextFromCursor
by Huw Davies 10 Jan '17

10 Jan '17

On Mon, Jan 09, 2017 at 06:08:12PM +0100, Fabian Maurer wrote: > This only affects ME_SetText and fnTextSrv_TxSetText, > should make it a bit more readable. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/caret.c | 2 -- > dlls/riched20/editor.c | 4 +++- > dlls/riched20/txtsrv.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c > index 26af743518..94794890b6 100644 > --- a/dlls/riched20/caret.c > +++ b/dlls/riched20/caret.c > @@ -526,8 +526,6 @@ void ME_InsertTextFromCursor(ME_TextEditor *editor, int nCursor, > assert(style); > > assert(nCursor>=0 && nCursor<editor->nCursors); > - if (len == -1) > - len = lstrlenW(str); > > /* grow the text limit to fit our text */ > if(editor->nTextLimit < oldLen +len) > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 1ce444e604..8873861aee 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3323,7 +3323,9 @@ static void ME_SetText(ME_TextEditor *editor, void *text, BOOL unicode) > int len = -1; > > /* uses default style! */ > - if (!(editor->styleFlags & ES_MULTILINE)) > + if (editor->styleFlags & ES_MULTILINE) > + len = lstrlenW(wszText); > + else > { > WCHAR *p = wszText; > > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 307b484352..a21ef5a02f 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -288,7 +288,7 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_SetCursorToStart(This->editor, &cursor); > ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > if(pszText) > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > + ME_InsertTextFromCursor(This->editor, 0, pszText, lstrlenW(pszText), This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); I'm not convinced this is an improvement. Huw.

2 1

Re: [PATCH] wined3d: Add FIXME for WINED3D_BLT_WAIT.
by Henri Verbeet 10 Jan '17

10 Jan '17

On 10 January 2017 at 15:02, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/wined3d/surface.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Why?

1 0

Re: imm32/tests: A spelling fix in an ok() message.
by Aric Stewart 10 Jan '17

10 Jan '17

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: usp10: A spelling fix in a comment
by Aric Stewart 10 Jan '17

10 Jan '17

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27674 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w1064 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test
by Huw Davies 09 Jan '17

09 Jan '17

On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote: > It already works with a null-pointer, but will crash if len is -1. > Since null-pointer means no text, we just return to avoid crashes. > > v2: Followed suggestion by Nikolay Sivov, moved check and extend test Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where it was in your first version. However, the extended test is much better. Huw.

2 1

Wine slides for Linux user group?
by Austin English 07 Jan '17

07 Jan '17

Howdy, Does anyone have some recentish slides I could build on for a local Linux user group presentation about Wine? Thanks

1 0

Re: ddraw/tests: A spelling fix in an ok() message.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27624 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ddraw/tests: Spelling fixes in a few comments.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27623 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: dxgi/tests: Some spelling fixes in ok() messages.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27612 Your paranoid android. === w7pro64 (32 bit device) === device.c:1445: Test failed: SetFullscreenState failed, hr 0x887a0004.

1 0

Re: [PATCH] d3dx11: Remove forward to d3dx11_43.
by Matteo Bruni 06 Jan '17

06 Jan '17

2016-12-29 16:59 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/d3dx11_42/d3dx11_42.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx11_42/d3dx11_42.spec b/dlls/d3dx11_42/d3dx11_42.spec > index f97ec24..0a6350c 100644 > --- a/dlls/d3dx11_42/d3dx11_42.spec > +++ b/dlls/d3dx11_42/d3dx11_42.spec > @@ -29,7 +29,7 @@ > @ stub D3DX11FilterTexture > @ stub D3DX11GetImageInfoFromFileA > @ stub D3DX11GetImageInfoFromFileW > -@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) d3dx11_43.D3DX11GetImageInfoFromMemory > +@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) > @ stub D3DX11GetImageInfoFromResourceA > @ stub D3DX11GetImageInfoFromResourceW > @ stub D3DX11LoadTextureFromTexture Does that compile?

1 0

Re: [PATCH] d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub.
by Matteo Bruni 06 Jan '17

06 Jan '17

2016-12-28 15:43 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: It's probably pretty safe but I'd prefer to defer this patch after 2.0.

1 0

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Henri Verbeet 06 Jan '17

06 Jan '17

On 6 January 2017 at 08:07, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42159 > This isn't a regression, right? > @@ -2975,10 +2975,7 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > hr = ddraw_surface_create(ddraw, &surface_desc2, &impl, outer_unknown, 1); > wined3d_mutex_unlock(); > if (FAILED(hr)) > - { > - *surface = NULL; > return hr; > - } This does a bit more than the commit message says it does, this doesn't write to *surface on any error from ddraw_surface_create(). That may very well be correct, but that's not what the test tests. The test only tests that CreateSurface() doesn't crash on error with an invalid "surface" pointer, but that could also be because of e.g. an exception handler. If you want to prove that it doesn't (try to) write to the "surface" pointer, you should pass a valid pointer to CreateSurface() and test that it isn't modified after the call.

2 2

Re: [PATCH] user.exe16: Add missing SELECTOROF in WM_DDE_EXECUTE.
by Alexandre Julliard 06 Jan '17

06 Jan '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/user.exe16/message.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/user.exe16/message.c b/dlls/user.exe16/message.c > index 7bcc8e2..383d746 100644 > --- a/dlls/user.exe16/message.c > +++ b/dlls/user.exe16/message.c > @@ -900,7 +900,7 @@ LRESULT WINPROC_CallProc16To32A( winproc_callback_t callback, HWND16 hwnd, UINT1 > } > break; /* FIXME don't know how to free allocated memory (handle) !! */ > case WM_DDE_EXECUTE: > - lParam = convert_handle_16_to_32( lParam, GMEM_DDESHARE ); > + lParam = convert_handle_16_to_32( SELECTOROF(lParam), GMEM_DDESHARE ); This won't work without fixing the opposite mapping. Do you have a reference for this? What application is this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Alex Henrie 06 Jan '17

06 Jan '17

2017-01-06 0:07 GMT-07:00 Alex Henrie <alexhenrie24(a)gmail.com>: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42159 > > With this patch, Sega Bug shows its intro logos, although it crashes > with "Unhandled privileged instruction" immediately after that. In case anyone is curious, I got rid of the "Unhandled privileged instruction" error by modifying my ioperm wrapper described at https://www.winehq.org/pipermail/wine-devel/2016-September/114873.html to open ports 3D0-3DF. With the patch and the ioperm wrapper, the game does not crash and the sound plays, but the game window is all black and the console repeats "fixme:d3d:surface_cpu_blt Filter WINED3D_TEXF_LINEAR not supported in software blit." -Alex

1 0

Re: [PATCH 4/4] ddraw: Don't write out if a ddraw7 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27599 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2276: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2276: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 3/4] ddraw: Don't write out if a ddraw4 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27598 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2550: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2550: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 2/4] ddraw: Don't write out if a ddraw2 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27597 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2395: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2395: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27596 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2244: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2244: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: reg/tests: Add tests for quotes and slashes in keys, values and data
by Marvin 05 Jan '17

05 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27579 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: regedit/tests: Add tests for quotes and slashes in keys, values and data
by Marvin 05 Jan '17

05 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27578 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/6] d3d9/tests: Add test for stale render target views regression.
by Henri Verbeet 05 Jan '17

05 Jan '17

On 5 January 2017 at 11:50, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +/* This test exercises a regression in Wine d3d9 implementation. */ The patch is fine, but note that once the bug is fixed it's no longer a regression.

1 0

commctl32: TaskDialog
by Fabian Maurer 04 Jan '17

04 Jan '17

Hello, just a question about the TaskDialog/TaskDialogIndirect functions. We already had a few patches in February 2015, but they weren't accepted for some reason. I'd start from scratch anyway, but something to look out for, mistakes that stopped the old series from being accepted? We're in code-freeze now, but I'd already start to give it a try. Another thing, since it's an internal UI class, how do you write test cases for those? I can probably test return value with simulated clicks, but after all, it's mostly visual whether control are properly aligned and shown. Fabian

2 1

Re: msxml3/tests: Mark Win10 behaviour as broken
by Nikolay Sivov 04 Jan '17

04 Jan '17

On 04.01.2017 18:49, André Hentschel wrote: > V_VT(&varbody_ref) = VT_VARIANT|VT_BYREF; > V_VARIANTREF(&varbody_ref) = &varbody; > hr = IXMLHttpRequest_send(xhr, varbody_ref); > - EXPECT_HR(hr, S_OK); > + ok(hr == S_OK || broken(hr == E_INVALIDARG) /* win10 */, "got 0x%08x, expected S_OK or E_INVALIDARG\n", hr); I don't think this has any value without understanding why it fails.

1 0

Re: [PATCH] qcap: Release IBaseFilter.
by Jactry Zeng 04 Jan '17

04 Jan '17

Hi Andrew, 2017-01-04 21:51 GMT+08:00 Andrew Eikum <aeikum(a)codeweavers.com>: > > This looks OK, but unless it fixes a bug, I'd rather wait until after > code freeze. No problem, I will resend it after code freeze. Thanks for review. -- Regards, Jactry Zeng

1 0

Re: [PATCH] quartz/tests: Skip test_render_run() if test file doesn't exist.
by Andrew Eikum 04 Jan '17

04 Jan '17

On Wed, Jan 04, 2017 at 10:52:28AM +0800, Jactry Zeng wrote: > + h = CreateFileW(file, 0, 0, NULL, OPEN_EXISTING, 0, NULL); > + if (h == INVALID_HANDLE_VALUE) { > + skip("Could not read test file \"%s\", skipping test\n", wine_dbgstr_w(file)); > + return; > + } > + CloseHandle(h); > + I like this, but please remove the quote characters: filtergraph.c:359: Tests skipped: Could not read test file "L"test.avi"", skipping test Andrew

1 0

[v2 0/7] x86: enable User-Mode Instruction Prevention
by Ricardo Neri 04 Jan '17

04 Jan '17

This is v2 of my first submission done a while ago[1]. I apologize for the delay. User-Mode Instruction Prevention (UMIP) is a security feature present in new Intel Processors. If enabled, it prevents the execution of certain instructions if the Current Privilege Level (CPL) is greater than 0. If these instructions were executed while in CPL > 0, user space applications could have access to system-wide settings such as the global and local descriptor tables, the segment selectors to the current task state and the local descriptor table. These are the instructions covered by UMIP: * SGDT - Store Global Descriptor Table * SIDT - Store Interrupt Descriptor Table * SLDT - Store Local Descriptor Table * SMSW - Store Machine Status Word * STR - Store Task Register If any of these instructions is executed with CPL > 0, a general protection exception is issued when UMIP is enabled. There is a caveat, however. Certain applications rely on some of these instructions to function. An example of this are applications that use WineHQ[2]. For instance, these applications rely on sidt returning a non- accesible memory location[3]. During the discussions, it was proposed that the fault could be relied to the user-space and perform the emulation in user-mode. However, this would break existing applications until, for instance, they update to a new WineHQ version. However, this approach would require UMIP to be disabled by default. The concensus in this forum is to always enable it. This patchset initially treated tasks running in virtual-8086 mode as a special case. However, I received clarification that DOSEMU[4] does not support applications that use these instructions. It relies on WineHQ for this[4]. Furthermore, the applications for which the concern was raised run in protected mode [3]. This version keeps UMIP enabled at all times and by default. If a general protection fault caused by the instructions protected by UMIP is detected, such fault will be fixed-up by returning dummy values as follows: * SGDT and SIDT return a base address to a dummy location in kernel memory and a limit of 0. * STR, SLDT returns 0 as the segment selector. This seems OK since we are providing a dummy value as the base address of the global descriptor table. * SMSW returns 0. Lastly, I found very useful the code for Intel MPX (Memory Protection Extensions) used to parse opcodes and the memory locations contained in the general purpose registers when used as operands. I put some of this code in a separate file that both MPX and UMIP can access and avoid code duplication. While here, I fixed two small bugs that I found in the MPX implementation. The code that I used to test the emulated instructions can be found in [6]. [1]. https://lwn.net/Articles/705877/ [2]. https://www.winehq.org/ [3]. https://www.winehq.org/pipermail/wine-devel/2016-November/115320.html [4]. http://www.dosemu.org/ [5]. http://marc.info/?l=linux-kernel&m=147876798717927&w=2 [6]. https://github.com/01org/luv-yocto/tree/rneri/umip/meta-luv/recipes-core/um… Thanks and BR, Ricardo Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Borislav Petkov <bp(a)suse.de> Cc: Brian Gerst <brgerst(a)gmail.com> Cc: Chen Yucong <slaoub(a)gmail.com> Cc: Chris Metcalf <cmetcalf(a)mellanox.com> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Fenghua Yu <fenghua.yu(a)intel.com> Cc: Huang Rui <ray.huang(a)amd.com> Cc: Jiri Slaby <jslaby(a)suse.cz> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Michael S. Tsirkin <mst(a)redhat.com> Cc: Paul Gortmaker <paul.gortmaker(a)windriver.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Ravi V. Shankar <ravi.v.shankar(a)intel.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Liang Z Li <liang.z.li(a)intel.com> Cc: x86(a)kernel.org Cc: linux-msdos(a)vger.kernel.org Changes since V1: * Virtual-8086 mode tasks are not treated in a special manner. All code for this purpose was removed. * Instead of attempting to disable UMIP during a context switch or when entering virtual-8086 mode, UMIP remains enabled all the time. General protection faults that occur are fixed-up by returning dummy values as detailed above. * Removed umip= kernel parameter in favor of using clearcpuid=514 to disable UMIP. * Removed selftests designed to detect the absence of SIGSEGV signals when running in virtual-8086 mode. * Reused code from MPX to decode instructions operands. For this purpose code was put in a common location. * Fixed two bugs in MPX code that decodes operands. Ricardo Neri (7): x86/mpx: Do not use SIB index if index points to R/ESP x86/mpx: Fail when implicit zero-displacement is used along with R/EBP x86/mpx, x86/insn: Relocate insn util functions to a new insn-utils x86/cpufeature: Add User-Mode Instruction Prevention definitions x86: Add emulation code for UMIP instructions x86/traps: Fixup general protection faults caused by UMIP x86: Enable User-Mode Instruction Prevention arch/x86/Kconfig | 10 ++ arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/insn.h | 6 + arch/x86/include/asm/umip.h | 16 +++ arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/common.c | 16 ++- arch/x86/kernel/traps.c | 4 + arch/x86/kernel/umip.c | 170 ++++++++++++++++++++++++++++ arch/x86/lib/Makefile | 2 +- arch/x86/lib/insn-utils.c | 148 ++++++++++++++++++++++++ arch/x86/mm/mpx.c | 119 +------------------ 13 files changed, 382 insertions(+), 121 deletions(-) create mode 100644 arch/x86/include/asm/umip.h create mode 100644 arch/x86/kernel/umip.c create mode 100644 arch/x86/lib/insn-utils.c -- 2.9.3

5 30

Re: [1/3] ntdll: Define more file information classes.
by Jonathan Doron 03 Jan '17

03 Jan '17

Hello I would like to understand how to proceed with this. I tried to keep the patchset to minimum amount of changes so it wont affect anything else. Thanks, -- Jon. On Mon, Jan 2, 2017 at 10:04 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Deferred". > > This means that the patch is deferred because of code freeze for an > upcoming release. You need to either resend after the release, make > the patch less intrusive, or make a convincing argument that it needs > to be included in the release. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. >

2 1

Re: [PATCH] riched20: Check for NULL in fnTextSrv_TxSetText and add test
by Nikolay Sivov 02 Jan '17

02 Jan '17

On 02.01.2017 23:19, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=12185 > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/tests/txtsrv.c | 3 +++ > dlls/riched20/txtsrv.c | 7 +++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/tests/txtsrv.c b/dlls/riched20/tests/txtsrv.c > index 1a6ca61052..6fd77d1b59 100644 > --- a/dlls/riched20/tests/txtsrv.c > +++ b/dlls/riched20/tests/txtsrv.c > @@ -681,6 +681,9 @@ static void test_TxSetText(void) > ok(memcmp(rettext,settext,SysStringByteLen(rettext)) == 0, > "String returned differs\n"); > > + /* Test if we crash when using NULL as text */ > + ITextServices_TxSetText(txtserv, NULL); > + > SysFreeString(rettext); > ITextServices_Release(txtserv); > ITextHost_Release(host); It's important to test if NULL text actually discards existing content or just does nothing. > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 3df779834b..307b484352 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -286,10 +286,9 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_Cursor cursor; > > ME_SetCursorToStart(This->editor, &cursor); > - ME_InternalDeleteText(This->editor, &cursor, > - ME_GetTextLength(This->editor), FALSE); > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, > - This->editor->pBuffer->pDefaultStyle); > + ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > + if(pszText) > + ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); Maybe it's better to add a check to ME_InsertTextFromCursor?

2 1

Starting wine virtual desktop minimized
by Austin English 02 Jan '17

02 Jan '17

Howdy, I'm looking for a way to start a virtual desktop and have it be minimized, similar to: wine start /min notepad But for the desktop itself. My goal is to be able to run winetest/winetricks-test/etc. with minimal graphical interface if I'm using the machine myself. Thanks and happy new year!

2 4

Re: [Patch] wined3d Add Turks HD6600 Binary driver
by Henri Verbeet 02 Jan '17

02 Jan '17

On 29 December 2016 at 12:07, Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > This is a regression fix. > What regression is that? If it's bug 38216, that was pretty much abandoned in early 2015. It was later reopened, but I don't see that bug report going anywhere without input from the original reporter. In fact, it's not all that clear whether the original issue still exists since commit 1df961bd3d1a5d4d4badfe364ca51e9f6cc88fd3.

1 0

Re: [PATCH] user32/tests: Added some tests for FindWindow()
by Marvin 02 Jan '17

02 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27514 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2017