wine-devel January 2017

wine-devel@winehq.org

54 participants
144 discussions

Re: [PATCH] winbase.h: Add UnlockResource prototype
by Dmitry Timoshkov 30 Jan '17

30 Jan '17

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > This function is obsolete and was only used in win16. However when trying > to compile a project with winelib found this function was called. Then you need to add it to an appropriate win16 header, or better remove it from your project since it won't compile with PSDK either. -- Dmitry.

2 1

Re: [PATCH 1/7] regedit: Use a helper for LoadString() and add debug information
by Dmitry Timoshkov 30 Jan '17

30 Jan '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -static INT vmessagebox(HWND hwnd, INT buttons, INT titleId, INT resId, va_list ap) > +static void load_string(unsigned int msg_id, WCHAR *buf, unsigned int count) > { > static const WCHAR errorW[] = {'E','r','r','o','r',0}; > - static const WCHAR unknownW[] = {'U','n','k','n','o','w','n',' ','e','r','r','o','r',' ','s','t','r','i','n','g','!',0}; > > + if (!buf) return; > + > + if (!LoadStringW(hInst, msg_id, buf, count)) > + { > + WINE_FIXME("LoadString failed with %u\n", GetLastError()); > + lstrcpyW(buf, errorW); > + } > +} Probably using a flavour of lstrcpy that checks the target buffer length would be more appropriate. Although simply returning an empty buffer and an error indicator to the caller could be slightly better. Under which conditions LoadString may fail here? -- Dmitry.

2 2

Re: [PATCH] MAINTAINERS: Add myself for printing
by Bruno Jesus 29 Jan '17

29 Jan '17

On Sun, Jan 29, 2017 at 8:15 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > bye bye Detlef > > Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de> > --- > MAINTAINERS | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e5224ff..d53af50 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -206,10 +206,15 @@ F: dlls/vcomp*/ > > Printing > M: Huw Davies <huw(a)codeweavers.com> > +P: Detlef Riekenberg <wine.dev(a)web.de> > F: dlls/localspl/ > -F: dlls/wineps.drv/ > +F: dlls/spoolss/ > F: dlls/winspool.drv/ > > +Postscript Driver > +M: Huw Davies <huw(a)codeweavers.com> > +F: dlls/wineps.drv/ > + I believe we are trying to keep the areas in alphabetical order.

1 0

Re: [v2 PATCH 3/3] windowscodecs: Add support for palette image formats to PNG encoder.
by Vincent Povirk 29 Jan '17

29 Jan '17

> + else > + { > + png_palette[i].red = 0; > + png_palette[i].green = 0; > + png_palette[i].blue = 0; > + } Why is it necessary to pad the palette in this way? Couldn't you just pass the appropriate number of colors?

3 2

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.
by guillaume.charifi＠sfr.fr 29 Jan '17

29 Jan '17

Yes, you're right, I forgot to commit the declaration of raw_resource in wined3d_private. And yes, it can be replaced by dst instead. <div class="gl_quote" style="margin-top: 20px; padding-top: 5px;"> <div class="gl_quoted">On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi wrote: > Signed-off-by: Guillaume Charifi > --- > dlls/wined3d/arb_program_shader.c | 1 + > dlls/wined3d/glsl_shader.c | 1 + > dlls/wined3d/shader.c | 6 ++++++ > dlls/wined3d/shader_sm4.c | 10 ++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 5 files changed, 19 insertions(+) This patch doesn't even compile. Please test your patches before sending them to wine-patches. > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins, > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count, > + struct wined3d_sm4_data *priv) > +{ > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg); > +} You should just use "ins->declaration.dst".</div> </div>

1 0

Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.
by Józef Kucia 29 Jan '17

29 Jan '17

On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > Signed-off-by: Guillaume Charifi <guillaume.charifi(a)sfr.fr> > --- > dlls/wined3d/arb_program_shader.c | 1 + > dlls/wined3d/glsl_shader.c | 1 + > dlls/wined3d/shader.c | 6 ++++++ > dlls/wined3d/shader_sm4.c | 10 ++++++++++ > dlls/wined3d/wined3d_private.h | 1 + > 5 files changed, 19 insertions(+) This patch doesn't even compile. Please test your patches before sending them to wine-patches. > +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction *ins, > + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int token_count, > + struct wined3d_sm4_data *priv) > +{ > + shader_sm4_read_dst_param(priv, &tokens, WINED3D_DATA_RESOURCE, &ins->declaration.raw_resource.reg); > +} You should just use "ins->declaration.dst".

1 0

Re: [PATCH] wined3d: Implement buffer texture range.
by Józef Kucia 29 Jan '17

29 Jan '17

Please add a test. On Sun, Jan 29, 2017 at 12:25 AM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > + GL_EXTCALL(glTexBufferRange(GL_TEXTURE_BUFFER, view_format->glInternal, buffer->buffer_object, > + desc->u.buffer.start_idx, desc->u.buffer.count)); This is wrong.

1 0

RE : [PATCH] wined3d: Implement buffer texture range.
by Guillaume Charifi 29 Jan '17

29 Jan '17

Woops, I forgot the patch adding the required extension, I'll send it later.

1 0

RE : Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures.
by Guillaume Charifi 29 Jan '17

29 Jan '17

Right, thank you... -------- Message d'origine -------- De : Bruno Jesus <00cpxxx(a)gmail.com> Date :29/01/2017 03:13 (GMT+01:00) À : Guillaume Charifi Cc : Wine Develop Objet : Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures. On Sat, Jan 28, 2017 at 8:46 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > --- > dlls/wined3d/context.c | 12 ++++++++++++ > dlls/wined3d/state.c | 5 +++++ > dlls/wined3d/view.c | 6 ------ > 3 files changed, 17 insertions(+), 6 deletions(-) You missed the Signed-off-by, see the red marks at http://source.winehq.org/patches/

1 0

Re: [PATCH 1/3] wined3d: Add some missing state updates for buffer textures.
by Bruno Jesus 29 Jan '17

29 Jan '17

On Sat, Jan 28, 2017 at 8:46 PM, Guillaume Charifi <guillaume.charifi(a)sfr.fr> wrote: > --- > dlls/wined3d/context.c | 12 ++++++++++++ > dlls/wined3d/state.c | 5 +++++ > dlls/wined3d/view.c | 6 ------ > 3 files changed, 17 insertions(+), 6 deletions(-) You missed the Signed-off-by, see the red marks at http://source.winehq.org/patches/

1 0

← Newer
1
2
3
4
5
6
7
...
15
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2017