wine-devel July 2017

wine-devel@winehq.org

49 participants
161 discussions

Re: [PATCH] ws2_32: Set return size when calling WSAIoctl with WS_SIO_GET_EXTENSION_FUNCTION_POINTER.
by Sebastian Lackner 13 Jul '17

13 Jul '17

On 13.07.2017 06:20, Alistair Leslie-Hughes wrote: > This is a backbort of the above change, borrowed from Codeweavers. :) > > Target: 2.0.* branch. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ws2_32/socket.c | 1 + > 1 file changed, 1 insertion(+) > It probably does not matter in practice (and I don't think we have any tests for it yet), but please note that this not equivalent to the code we have in the development branch. It also changes error handling in a completely unrelated situation (when a extension is not found). Why not just backport 914e401aa9d5401893c3807d51e3f19fc7a7ab38 plus the fix?

2 1

Re: [PATCH 4/5 v3] msvcr120: Add acosh.
by Alex Henrie 12 Jul '17

12 Jul '17

Alexandre, when you apply these patches, you don't have to keep the "From: Alex Henrie" line. The acosh and atanh implementations are now more Piotr's work than they are mine, although I'm happy to sign off on them. -Alex

1 0

Re: [PATCH 4/5 v2] msvcr120: Add acosh.
by Alex Henrie 12 Jul '17

12 Jul '17

/********************************************************************* + * acosh (MSVCR120.@) + */ +double CDECL MSVCR120_acosh(double x) +{ + if (x < 1) { + *MSVCRT__errno() = MSVCRT_EDOM; + return NAN; + } +#ifdef HAVE_ACOSH + return acosh(x); +#else + if (!isfinite(x*x)) return log(2) + log(x); + return log(x + sqrt(x*x-1)); +#endif +} + +/********************************************************************* + * acoshf (MSVCR120.@) + */ +float CDECL MSVCR120_acoshf(float x) +{ +#ifdef HAVE_ACOSHF + return acoshf(x); +#else + return MSVCR120_acosh(x); +#endif +} Thanks for the help. Are you sure that acosh and atanh require bounds checking, but acoshf and atanhf do not? Also, aren't they supposed to set an exception flag if x is less than 1? -Alex

2 1

wine-2.0.2-rc2 Available
by Michael Stefaniuc 12 Jul '17

12 Jul '17

Hello guys, I have pushed wine-2.0.2-rc2 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Changes rc1: - Added the commit "ddraw: Validate the "surface" pointer before creating the surface in CreateSurface()." Required by patches included in rc1 that were trading crashes for mem leaks (Thanks Sebastian and Henri). Please let me if you feel strongly about the inclusion of the outstanding Steam fix into wine-2.0.2. As it isn't in devel yet I would tend to defer it to 2.0.3 and I'm not opposed to do an earlier release for that in early to mid August. thanks bye michael

1 0

Re: [PATCH 8/9] msvcr120: Add expm1.
by Piotr Caban 12 Jul '17

12 Jul '17

On 07/10/17 06:55, Alex Henrie wrote: > +float CDECL MSVCR120_expm1f(float x) > +{ > +#ifdef HAVE_EXPM1F > + return expm1f(x); > +#else > + return exp(x) - 1; > +#endif > +} Please set errno on invalid arguments. Thanks, Piotr

1 0

Re: [PATCH 2/3] Add mfuuid.lib
by Alexandre Julliard 11 Jul '17

11 Jul '17

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +DEFINE_GUID(CLSID_MFReadWriteClassFactory, 0x48e2ed0f, 0x98c2, 0x4a37, 0xbe, 0xd5, 0x16, 0x63, 0x12, 0xdd, 0xd8, 0x3f); > +DEFINE_GUID(CLSID_MFSourceReader, 0x1777133c, 0x0881, 0x411b, 0xa5, 0x77, 0xad, 0x54, 0x5f, 0x07, 0x14, 0xc4); > +DEFINE_GUID(CLSID_MFSinkWriter, 0xa3bbfb17, 0x8273, 0x4e52, 0x9e, 0x0e, 0x97, 0x39, 0xdc, 0x88, 0x79, 0x90); > + > +DEFINE_GUID(MF_SINK_WRITER_ASYNC_CALLBACK, 0x48cb183e, 0x7b0b, 0x46f4, 0x82, 0x2e, 0x5e, 0x1d, 0x2d, 0xda, 0x43, 0x54); > +DEFINE_GUID(MF_SINK_WRITER_DISABLE_THROTTLING, 0x08b845d8, 0x2b74, 0x4afe, 0x9d, 0x53, 0xbe, 0x16, 0xd2, 0xd5, 0xae, 0x4f); > +DEFINE_GUID(MF_SINK_WRITER_D3D_MANAGER, 0xec822da2, 0xe1e9, 0x4b29, 0xa0, 0xd8, 0x56, 0x3c, 0x71, 0x9f, 0x52, 0x69); > +DEFINE_GUID(MF_SINK_WRITER_ENCODER_CONFIG, 0xad91cd04, 0xa7cc, 0x4ac7, 0x99, 0xb6, 0xa5, 0x7b, 0x9a, 0x4a, 0x7c, 0x70); > + > +DEFINE_GUID(MF_READWRITE_DISABLE_CONVERTERS, 0x98d5b065, 0x1374, 0x4847, 0x8d, 0x5d, 0x31, 0x52, 0x0f, 0xee, 0x71, 0x56); > +DEFINE_GUID(MF_READWRITE_ENABLE_HARDWARE_TRANSFORMS, 0xa634a91c, 0x822b, 0x41b9, 0xa4, 0x94, 0x4d, 0xe4, 0x64, 0x36, 0x12, 0xb0); > +DEFINE_GUID(MF_READWRITE_MMCSS_CLASS, 0x39384300, 0xd0eb, 0x40b1, 0x87, 0xa0, 0x33, 0x18, 0x87, 0x1b, 0x5a, 0x53); > +DEFINE_GUID(MF_READWRITE_MMCSS_PRIORITY, 0x43ad19ce, 0xf33f, 0x4ba9, 0xa5, 0x80, 0xe4, 0xcd, 0x12, 0xf2, 0xd1, 0x44); > +DEFINE_GUID(MF_READWRITE_MMCSS_CLASS_AUDIO, 0x430847da, 0x0890, 0x4b0e, 0x93, 0x8c, 0x05, 0x43, 0x32, 0xc5, 0x47, 0xe1); > +DEFINE_GUID(MF_READWRITE_MMCSS_PRIORITY_AUDIO, 0x273db885, 0x2de2, 0x4db2, 0xa6, 0xa7, 0xfd, 0xb6, 0x6f, 0xb4, 0x0b, 0x61); > +DEFINE_GUID(MF_READWRITE_D3D_OPTIONAL, 0x216479d9, 0x3071, 0x42ca, 0xbb, 0x6c, 0x4c, 0x22, 0x10, 0x2e, 0x1d, 0x18); I don't see any of these in the PSDK mfuuid library. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v2 2/2] user32: Activate another window upon minimizing.
by Marvin 11 Jul '17

11 Jul '17

1 0

Re: [PATCH v2 1/2] user32/tests: Add tests for activating windows.
by Marvin 11 Jul '17

11 Jul '17

1 0

Re: [PATCH 3/3] user32/tests: Use todo_wine for failing z-order tests.
by Marvin 11 Jul '17

11 Jul '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32243 Your paranoid android. === wxppro (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00020152 win.c:9961: Test failed: GetFocus() = 00020152 === w2003std (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 000400F6 win.c:9961: Test failed: GetFocus() = 000400F6 === wvistau64 (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00050120 win.c:9961: Test failed: GetFocus() = 00050120 === w2008s64 (32 bit win) === win.c:9961: Test failed: GetActiveWindow() = 00080124 win.c:9961: Test failed: GetFocus() = 00080124 === w7u (32 bit win) === win.c:3001: Test failed: 0011013C: expected next 00000000, got 000301B8 win.c:3003: Test failed: 00100192: expected prev 000301AC, got 000A01B6 win.c:3004: Test failed: 000301AC: expected next 00100192, got 00000000 win.c:3005: Test failed: 000901BA: expected prev 000A01B6, got 0011013C win.c:3006: Test failed: 000A01B6: expected next 000901BA, got 00100192 win.c:3015: Test failed: 0011013C: expected next 00000000, got 000301B8 win.c:3016: Test failed: 00100192: expected prev 000301AC, got 000A01B6 win.c:3017: Test failed: 000301AC: expected next 00100192, got 00000000 win.c:3018: Test failed: 000901BA: expected prev 000A01B6, got 0011013C win.c:3019: Test failed: 000A01B6: expected next 000901BA, got 00100192 win.c:3001: Test failed: 0012013C: expected next 00000000, got 000301B8 win.c:3003: Test failed: 000B01B6: expected prev 000301AC, got 009E015A win.c:3004: Test failed: 000301AC: expected next 000B01B6, got 00000000 win.c:3005: Test failed: 000901BA: expected prev 009E015A, got 0012013C win.c:3006: Test failed: 009E015A: expected next 000901BA, got 000B01B6 win.c:3015: Test failed: 0012013C: expected next 00000000, got 000301B8 win.c:3016: Test failed: 000B01B6: expected prev 000301AC, got 009E015A win.c:3017: Test failed: 000301AC: expected next 000B01B6, got 00000000 win.c:3018: Test failed: 000901BA: expected prev 009E015A, got 0012013C win.c:3019: Test failed: 009E015A: expected next 000901BA, got 000B01B6 === w7pro64 (32 bit win) === win.c:9968: Test failed: expected 000B015E, got 00050024 === w8 (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009012E fg 000400FA in hook HCBT_MINMAX === wvistau64 (64 bit win) === win.c:9961: Test failed: GetActiveWindow() = 0000000000050120 win.c:9961: Test failed: GetFocus() = 0000000000050120 === w2008s64 (64 bit win) === win.c:9961: Test failed: GetActiveWindow() = 0000000000080124 win.c:9961: Test failed: GetFocus() = 0000000000080124 === w7pro64 (64 bit win) === win.c:9968: Test failed: expected 00000000000B015E, got 000000000006011E === w864 (64 bit win) === win.c:9968: Test failed: expected 00000000000B015C, got 0000000000050028

1 0

Re: [PATCH 2/3] user32: Activate another window upon minimizing.
by Marvin 11 Jul '17

11 Jul '17

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2017