wine-devel July 2020

wine-devel@winehq.org

75 participants
841 discussions

[PATCH vkd3d 4/5] vkd3d-shader: Rename the vkd3d_root_signature_version enumeration to vkd3d_shader_root_signature_version.
by Henri Verbeet 21 Jul '20

21 Jul '20

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- include/vkd3d_shader.h | 14 ++++++------ libs/vkd3d-shader/dxbc.c | 41 ++++++++++++++++++----------------- libs/vkd3d-shader/vkd3d_shader_main.c | 4 ++-- libs/vkd3d/vkd3d_main.c | 15 +++++++------ tests/vkd3d_shader_api.c | 2 +- 5 files changed, 39 insertions(+), 37 deletions(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 6eed196..24e2f24 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -568,17 +568,17 @@ struct vkd3d_root_signature_desc1 enum vkd3d_shader_root_signature_flags flags; }; -enum vkd3d_root_signature_version +enum vkd3d_shader_root_signature_version { - VKD3D_ROOT_SIGNATURE_VERSION_1_0 = 0x1, - VKD3D_ROOT_SIGNATURE_VERSION_1_1 = 0x2, + VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0 = 0x1, + VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1 = 0x2, - VKD3D_FORCE_32_BIT_ENUM(VKD3D_ROOT_SIGNATURE_VERSION), + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_ROOT_SIGNATURE_VERSION), }; struct vkd3d_versioned_root_signature_desc { - enum vkd3d_root_signature_version version; + enum vkd3d_shader_root_signature_version version; union { struct vkd3d_root_signature_desc v_1_0; @@ -737,7 +737,7 @@ int vkd3d_shader_serialize_root_signature(const struct vkd3d_versioned_root_sign struct vkd3d_shader_code *dxbc); int vkd3d_shader_convert_root_signature(struct vkd3d_versioned_root_signature_desc *dst, - enum vkd3d_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src); + enum vkd3d_shader_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src); int vkd3d_shader_scan_dxbc(const struct vkd3d_shader_code *dxbc, struct vkd3d_shader_scan_info *scan_info); @@ -767,7 +767,7 @@ typedef int (*PFN_vkd3d_shader_serialize_root_signature)( const struct vkd3d_versioned_root_signature_desc *root_signature, struct vkd3d_shader_code *dxbc); typedef int (*PFN_vkd3d_shader_convert_root_signature)(struct vkd3d_versioned_root_signature_desc *dst, - enum vkd3d_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src); + enum vkd3d_shader_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src); typedef int (*PFN_vkd3d_shader_scan_dxbc)(const struct vkd3d_shader_code *dxbc, struct vkd3d_shader_scan_info *scan_info); diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index ca9e7b8..e871963 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -2580,7 +2580,7 @@ static int shader_parse_root_signature(const char *data, unsigned int data_size, read_dword(&ptr, &version); TRACE("Version %#x.\n", version); - if (version != VKD3D_ROOT_SIGNATURE_VERSION_1_0 && version != VKD3D_ROOT_SIGNATURE_VERSION_1_1) + if (version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0 && version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1) { FIXME("Unknown version %#x.\n", version); return VKD3D_ERROR_INVALID_ARGUMENT; @@ -2591,7 +2591,7 @@ static int shader_parse_root_signature(const char *data, unsigned int data_size, read_dword(&ptr, &offset); TRACE("Parameter count %u, offset %u.\n", count, offset); - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) { v_1_0->parameter_count = count; if (v_1_0->parameter_count) @@ -2608,7 +2608,7 @@ static int shader_parse_root_signature(const char *data, unsigned int data_size, { struct vkd3d_root_signature_desc1 *v_1_1 = &desc->u.v_1_1; - assert(version == VKD3D_ROOT_SIGNATURE_VERSION_1_1); + assert(version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1); v_1_1->parameter_count = count; if (v_1_1->parameter_count) @@ -2672,7 +2672,7 @@ int vkd3d_shader_parse_root_signature(const struct vkd3d_shader_code *dxbc, static unsigned int versioned_root_signature_get_parameter_count(const struct vkd3d_versioned_root_signature_desc *desc) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.parameter_count; else return desc->u.v_1_1.parameter_count; @@ -2681,7 +2681,7 @@ static unsigned int versioned_root_signature_get_parameter_count(const struct vk static enum vkd3d_shader_root_parameter_type versioned_root_signature_get_parameter_type( const struct vkd3d_versioned_root_signature_desc *desc, unsigned int i) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.parameters[i].parameter_type; else return desc->u.v_1_1.parameters[i].parameter_type; @@ -2690,7 +2690,7 @@ static enum vkd3d_shader_root_parameter_type versioned_root_signature_get_parame static enum vkd3d_shader_visibility versioned_root_signature_get_parameter_shader_visibility( const struct vkd3d_versioned_root_signature_desc *desc, unsigned int i) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.parameters[i].shader_visibility; else return desc->u.v_1_1.parameters[i].shader_visibility; @@ -2699,7 +2699,7 @@ static enum vkd3d_shader_visibility versioned_root_signature_get_parameter_shade static const struct vkd3d_shader_root_constants *versioned_root_signature_get_root_constants( const struct vkd3d_versioned_root_signature_desc *desc, unsigned int i) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return &desc->u.v_1_0.parameters[i].u.constants; else return &desc->u.v_1_1.parameters[i].u.constants; @@ -2707,7 +2707,7 @@ static const struct vkd3d_shader_root_constants *versioned_root_signature_get_ro static unsigned int versioned_root_signature_get_static_sampler_count(const struct vkd3d_versioned_root_signature_desc *desc) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.static_sampler_count; else return desc->u.v_1_1.static_sampler_count; @@ -2716,7 +2716,7 @@ static unsigned int versioned_root_signature_get_static_sampler_count(const stru static const struct vkd3d_shader_static_sampler_desc *versioned_root_signature_get_static_samplers( const struct vkd3d_versioned_root_signature_desc *desc) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.static_samplers; else return desc->u.v_1_1.static_samplers; @@ -2724,7 +2724,7 @@ static const struct vkd3d_shader_static_sampler_desc *versioned_root_signature_g static unsigned int versioned_root_signature_get_flags(const struct vkd3d_versioned_root_signature_desc *desc) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) return desc->u.v_1_0.flags; else return desc->u.v_1_1.flags; @@ -2939,7 +2939,7 @@ static int shader_write_root_parameters(struct root_signature_writer_context *co switch (versioned_root_signature_get_parameter_type(desc, i)) { case VKD3D_SHADER_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE: - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) ret = shader_write_descriptor_table(context, &desc->u.v_1_0.parameters[i].u.descriptor_table); else ret = shader_write_descriptor_table1(context, &desc->u.v_1_1.parameters[i].u.descriptor_table); @@ -2950,7 +2950,7 @@ static int shader_write_root_parameters(struct root_signature_writer_context *co case VKD3D_SHADER_ROOT_PARAMETER_TYPE_CBV: case VKD3D_SHADER_ROOT_PARAMETER_TYPE_SRV: case VKD3D_SHADER_ROOT_PARAMETER_TYPE_UAV: - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) ret = shader_write_root_descriptor(context, &desc->u.v_1_0.parameters[i].u.descriptor); else ret = shader_write_root_descriptor1(context, &desc->u.v_1_1.parameters[i].u.descriptor); @@ -3120,7 +3120,7 @@ static int validate_root_signature_desc(const struct vkd3d_versioned_root_signat type = versioned_root_signature_get_parameter_type(desc, i); if (type == VKD3D_SHADER_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) ret = validate_descriptor_table_v_1_0(&desc->u.v_1_0.parameters[i].u.descriptor_table); else ret = validate_descriptor_table_v_1_1(&desc->u.v_1_1.parameters[i].u.descriptor_table); @@ -3143,8 +3143,8 @@ int vkd3d_shader_serialize_root_signature(const struct vkd3d_versioned_root_sign TRACE("root_signature %p, dxbc %p.\n", root_signature, dxbc); - if (root_signature->version != VKD3D_ROOT_SIGNATURE_VERSION_1_0 - && root_signature->version != VKD3D_ROOT_SIGNATURE_VERSION_1_1) + if (root_signature->version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0 + && root_signature->version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1) { WARN("Root signature version %#x not supported.\n", root_signature->version); return VKD3D_ERROR_INVALID_ARGUMENT; @@ -3422,7 +3422,7 @@ fail: } int vkd3d_shader_convert_root_signature(struct vkd3d_versioned_root_signature_desc *dst, - enum vkd3d_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src) + enum vkd3d_shader_root_signature_version version, const struct vkd3d_versioned_root_signature_desc *src) { int ret; @@ -3434,13 +3434,14 @@ int vkd3d_shader_convert_root_signature(struct vkd3d_versioned_root_signature_de return VKD3D_ERROR_INVALID_ARGUMENT; } - if (version != VKD3D_ROOT_SIGNATURE_VERSION_1_0 && version != VKD3D_ROOT_SIGNATURE_VERSION_1_1) + if (version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0 && version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1) { WARN("Root signature version %#x not supported.\n", version); return VKD3D_ERROR_INVALID_ARGUMENT; } - if (src->version != VKD3D_ROOT_SIGNATURE_VERSION_1_0 && src->version != VKD3D_ROOT_SIGNATURE_VERSION_1_1) + if (src->version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0 + && src->version != VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1) { WARN("Root signature version %#x not supported.\n", src->version); return VKD3D_ERROR_INVALID_ARGUMENT; @@ -3449,13 +3450,13 @@ int vkd3d_shader_convert_root_signature(struct vkd3d_versioned_root_signature_de memset(dst, 0, sizeof(*dst)); dst->version = version; - if (version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) { ret = convert_root_signature_to_v1_0(dst, src); } else { - assert(version == VKD3D_ROOT_SIGNATURE_VERSION_1_1); + assert(version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1); ret = convert_root_signature_to_v1_1(dst, src); } diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index d4bd763..ff02eca 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -514,11 +514,11 @@ static void vkd3d_shader_free_root_signature_v_1_1(struct vkd3d_root_signature_d void vkd3d_shader_free_root_signature(struct vkd3d_versioned_root_signature_desc *desc) { - if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) { vkd3d_shader_free_root_signature_v_1_0(&desc->u.v_1_0); } - else if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_1) + else if (desc->version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1) { vkd3d_shader_free_root_signature_v_1_1(&desc->u.v_1_1); } diff --git a/libs/vkd3d/vkd3d_main.c b/libs/vkd3d/vkd3d_main.c index 7775077..964c6f5 100644 --- a/libs/vkd3d/vkd3d_main.c +++ b/libs/vkd3d/vkd3d_main.c @@ -180,15 +180,15 @@ int vkd3d_parse_root_signature_v_1_0(const struct vkd3d_shader_code *dxbc, return ret; } - if (desc.version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) + if (desc.version == VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0) { *out_desc = desc; } else { - enum vkd3d_root_signature_version version = desc.version; + enum vkd3d_shader_root_signature_version version = desc.version; - ret = vkd3d_shader_convert_root_signature(&converted_desc, VKD3D_ROOT_SIGNATURE_VERSION_1_0, &desc); + ret = vkd3d_shader_convert_root_signature(&converted_desc, VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0, &desc); vkd3d_shader_free_root_signature(&desc); if (ret < 0) { @@ -309,14 +309,15 @@ static ULONG STDMETHODCALLTYPE d3d12_versioned_root_signature_deserializer_Relea return refcount; } -static enum vkd3d_root_signature_version vkd3d_root_signature_version_from_d3d12(D3D_ROOT_SIGNATURE_VERSION version) +static enum vkd3d_shader_root_signature_version vkd3d_root_signature_version_from_d3d12( + D3D_ROOT_SIGNATURE_VERSION version) { switch (version) { case D3D_ROOT_SIGNATURE_VERSION_1_0: - return VKD3D_ROOT_SIGNATURE_VERSION_1_0; + return VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0; case D3D_ROOT_SIGNATURE_VERSION_1_1: - return VKD3D_ROOT_SIGNATURE_VERSION_1_1; + return VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_1; default: WARN("Unknown root signature version %#x.\n", version); return 0; @@ -562,7 +563,7 @@ HRESULT vkd3d_serialize_root_signature(const D3D12_ROOT_SIGNATURE_DESC *desc, if (error_blob) *error_blob = NULL; - vkd3d_desc.version = VKD3D_ROOT_SIGNATURE_VERSION_1_0; + vkd3d_desc.version = VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0; vkd3d_desc.u.v_1_0 = *(const struct vkd3d_root_signature_desc *)desc; if ((ret = vkd3d_shader_serialize_root_signature(&vkd3d_desc, &dxbc)) < 0) { diff --git a/tests/vkd3d_shader_api.c b/tests/vkd3d_shader_api.c index 6aef004..569b0e9 100644 --- a/tests/vkd3d_shader_api.c +++ b/tests/vkd3d_shader_api.c @@ -90,7 +90,7 @@ static void test_vkd3d_shader_pfns(void) static const struct vkd3d_versioned_root_signature_desc empty_rs_desc = { - .version = VKD3D_ROOT_SIGNATURE_VERSION_1_0, + .version = VKD3D_SHADER_ROOT_SIGNATURE_VERSION_1_0, }; static const DWORD vs_code[] = { -- 2.11.0

1 0

[PATCH vkd3d 3/5] vkd3d-shader: Rename the vkd3d_root_parameter1 structure to vkd3d_shader_root_parameter1.
by Henri Verbeet 21 Jul '20

21 Jul '20

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- include/vkd3d_shader.h | 4 ++-- libs/vkd3d-shader/dxbc.c | 18 +++++++++--------- libs/vkd3d-shader/vkd3d_shader_main.c | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 26ec469..6eed196 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -547,7 +547,7 @@ struct vkd3d_shader_root_descriptor1 enum vkd3d_shader_root_descriptor_flags flags; }; -struct vkd3d_root_parameter1 +struct vkd3d_shader_root_parameter1 { enum vkd3d_shader_root_parameter_type parameter_type; union @@ -562,7 +562,7 @@ struct vkd3d_root_parameter1 struct vkd3d_root_signature_desc1 { unsigned int parameter_count; - const struct vkd3d_root_parameter1 *parameters; + const struct vkd3d_shader_root_parameter1 *parameters; unsigned int static_sampler_count; const struct vkd3d_shader_static_sampler_desc *static_samplers; enum vkd3d_shader_root_signature_flags flags; diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 5ddfc20..ca9e7b8 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -2480,7 +2480,7 @@ static int shader_parse_root_parameters(struct root_signature_parser_context *co } static int shader_parse_root_parameters1(struct root_signature_parser_context *context, - DWORD offset, DWORD count, struct vkd3d_root_parameter1 *parameters) + DWORD offset, DWORD count, struct vkd3d_shader_root_parameter1 *parameters) { const char *ptr; unsigned int i; @@ -2613,7 +2613,7 @@ static int shader_parse_root_signature(const char *data, unsigned int data_size, v_1_1->parameter_count = count; if (v_1_1->parameter_count) { - struct vkd3d_root_parameter1 *parameters; + struct vkd3d_shader_root_parameter1 *parameters; if (!(parameters = vkd3d_calloc(v_1_1->parameter_count, sizeof(*parameters)))) return VKD3D_ERROR_OUT_OF_MEMORY; v_1_1->parameters = parameters; @@ -3198,7 +3198,7 @@ static void free_descriptor_ranges(const struct vkd3d_shader_root_parameter *par } static int convert_root_parameters_to_v_1_0(struct vkd3d_shader_root_parameter *dst, - const struct vkd3d_root_parameter1 *src, unsigned int count) + const struct vkd3d_shader_root_parameter1 *src, unsigned int count) { const struct vkd3d_shader_descriptor_range1 *ranges1; struct vkd3d_shader_descriptor_range *ranges; @@ -3207,7 +3207,7 @@ static int convert_root_parameters_to_v_1_0(struct vkd3d_shader_root_parameter * for (i = 0; i < count; ++i) { - const struct vkd3d_root_parameter1 *p1 = &src[i]; + const struct vkd3d_shader_root_parameter1 *p1 = &src[i]; struct vkd3d_shader_root_parameter *p = &dst[i]; p->parameter_type = p1->parameter_type; @@ -3300,7 +3300,7 @@ fail: return ret; } -static void free_descriptor_ranges1(const struct vkd3d_root_parameter1 *parameters, unsigned int count) +static void free_descriptor_ranges1(const struct vkd3d_shader_root_parameter1 *parameters, unsigned int count) { unsigned int i; @@ -3309,14 +3309,14 @@ static void free_descriptor_ranges1(const struct vkd3d_root_parameter1 *paramete for (i = 0; i < count; ++i) { - const struct vkd3d_root_parameter1 *p = &parameters[i]; + const struct vkd3d_shader_root_parameter1 *p = &parameters[i]; if (p->parameter_type == VKD3D_SHADER_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE) vkd3d_free((void *)p->u.descriptor_table.descriptor_ranges); } } -static int convert_root_parameters_to_v_1_1(struct vkd3d_root_parameter1 *dst, +static int convert_root_parameters_to_v_1_1(struct vkd3d_shader_root_parameter1 *dst, const struct vkd3d_shader_root_parameter *src, unsigned int count) { const struct vkd3d_shader_descriptor_range *ranges; @@ -3327,7 +3327,7 @@ static int convert_root_parameters_to_v_1_1(struct vkd3d_root_parameter1 *dst, for (i = 0; i < count; ++i) { const struct vkd3d_shader_root_parameter *p = &src[i]; - struct vkd3d_root_parameter1 *p1 = &dst[i]; + struct vkd3d_shader_root_parameter1 *p1 = &dst[i]; p1->parameter_type = p->parameter_type; switch (p1->parameter_type) @@ -3386,7 +3386,7 @@ static int convert_root_signature_to_v1_1(struct vkd3d_versioned_root_signature_ const struct vkd3d_root_signature_desc *src_desc = &src->u.v_1_0; struct vkd3d_root_signature_desc1 *dst_desc = &dst->u.v_1_1; struct vkd3d_shader_static_sampler_desc *samplers = NULL; - struct vkd3d_root_parameter1 *parameters = NULL; + struct vkd3d_shader_root_parameter1 *parameters = NULL; int ret; if ((dst_desc->parameter_count = src_desc->parameter_count)) diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 8dbd17e..d4bd763 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -501,7 +501,7 @@ static void vkd3d_shader_free_root_signature_v_1_1(struct vkd3d_root_signature_d for (i = 0; i < root_signature->parameter_count; ++i) { - const struct vkd3d_root_parameter1 *parameter = &root_signature->parameters[i]; + const struct vkd3d_shader_root_parameter1 *parameter = &root_signature->parameters[i]; if (parameter->parameter_type == VKD3D_SHADER_ROOT_PARAMETER_TYPE_DESCRIPTOR_TABLE) vkd3d_free((void *)parameter->u.descriptor_table.descriptor_ranges); -- 2.11.0

1 0

[PATCH vkd3d 2/5] vkd3d-shader: Rename the vkd3d_root_signature_flags enumeration to vkd3d_shader_root_signature_flags.
by Henri Verbeet 21 Jul '20

21 Jul '20

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- include/vkd3d_shader.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 1c01735..26ec469 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -479,18 +479,18 @@ struct vkd3d_shader_root_parameter enum vkd3d_shader_visibility shader_visibility; }; -enum vkd3d_root_signature_flags +enum vkd3d_shader_root_signature_flags { - VKD3D_ROOT_SIGNATURE_FLAG_NONE = 0x0, - VKD3D_ROOT_SIGNATURE_FLAG_ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT = 0x1, - VKD3D_ROOT_SIGNATURE_FLAG_DENY_VERTEX_SHADER_ROOT_ACCESS = 0x2, - VKD3D_ROOT_SIGNATURE_FLAG_DENY_HULL_SHADER_ROOT_ACCESS = 0x4, - VKD3D_ROOT_SIGNATURE_FLAG_DENY_DOMAIN_SHADER_ROOT_ACCESS = 0x8, - VKD3D_ROOT_SIGNATURE_FLAG_DENY_GEOMETRY_SHADER_ROOT_ACCESS = 0x10, - VKD3D_ROOT_SIGNATURE_FLAG_DENY_PIXEL_SHADER_ROOT_ACCESS = 0x20, - VKD3D_ROOT_SIGNATURE_FLAG_ALLOW_STREAM_OUTPUT = 0x40, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_NONE = 0x00, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT = 0x01, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_DENY_VERTEX_SHADER_ROOT_ACCESS = 0x02, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_DENY_HULL_SHADER_ROOT_ACCESS = 0x04, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_DENY_DOMAIN_SHADER_ROOT_ACCESS = 0x08, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_DENY_GEOMETRY_SHADER_ROOT_ACCESS = 0x10, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_DENY_PIXEL_SHADER_ROOT_ACCESS = 0x20, + VKD3D_SHADER_ROOT_SIGNATURE_FLAG_ALLOW_STREAM_OUTPUT = 0x40, - VKD3D_FORCE_32_BIT_ENUM(VKD3D_ROOT_SIGNATURE_FLAGS), + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_ROOT_SIGNATURE_FLAGS), }; struct vkd3d_root_signature_desc @@ -499,7 +499,7 @@ struct vkd3d_root_signature_desc const struct vkd3d_shader_root_parameter *parameters; unsigned int static_sampler_count; const struct vkd3d_shader_static_sampler_desc *static_samplers; - enum vkd3d_root_signature_flags flags; + enum vkd3d_shader_root_signature_flags flags; }; /* root signature 1.1 */ @@ -565,7 +565,7 @@ struct vkd3d_root_signature_desc1 const struct vkd3d_root_parameter1 *parameters; unsigned int static_sampler_count; const struct vkd3d_shader_static_sampler_desc *static_samplers; - enum vkd3d_root_signature_flags flags; + enum vkd3d_shader_root_signature_flags flags; }; enum vkd3d_root_signature_version -- 2.11.0

1 0

[PATCH vkd3d 1/5] vkd3d-shader: Rename the vkd3d_static_sampler_desc structure to vkd3d_shader_static_sampler_desc.
by Henri Verbeet 21 Jul '20

21 Jul '20

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> --- include/vkd3d_shader.h | 6 +++--- libs/vkd3d-shader/dxbc.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index 631cbf5..1c01735 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -401,7 +401,7 @@ enum vkd3d_shader_static_border_colour VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_STATIC_BORDER_COLOUR), }; -struct vkd3d_static_sampler_desc +struct vkd3d_shader_static_sampler_desc { enum vkd3d_shader_filter filter; enum vkd3d_shader_texture_address_mode address_u; @@ -498,7 +498,7 @@ struct vkd3d_root_signature_desc unsigned int parameter_count; const struct vkd3d_shader_root_parameter *parameters; unsigned int static_sampler_count; - const struct vkd3d_static_sampler_desc *static_samplers; + const struct vkd3d_shader_static_sampler_desc *static_samplers; enum vkd3d_root_signature_flags flags; }; @@ -564,7 +564,7 @@ struct vkd3d_root_signature_desc1 unsigned int parameter_count; const struct vkd3d_root_parameter1 *parameters; unsigned int static_sampler_count; - const struct vkd3d_static_sampler_desc *static_samplers; + const struct vkd3d_shader_static_sampler_desc *static_samplers; enum vkd3d_root_signature_flags flags; }; diff --git a/libs/vkd3d-shader/dxbc.c b/libs/vkd3d-shader/dxbc.c index 303bedd..5ddfc20 100644 --- a/libs/vkd3d-shader/dxbc.c +++ b/libs/vkd3d-shader/dxbc.c @@ -2528,7 +2528,7 @@ static int shader_parse_root_parameters1(struct root_signature_parser_context *c } static int shader_parse_static_samplers(struct root_signature_parser_context *context, - unsigned int offset, unsigned int count, struct vkd3d_static_sampler_desc *sampler_descs) + unsigned int offset, unsigned int count, struct vkd3d_shader_static_sampler_desc *sampler_descs) { const char *ptr; unsigned int i; @@ -2629,7 +2629,7 @@ static int shader_parse_root_signature(const char *data, unsigned int data_size, v_1_0->static_sampler_count = count; if (v_1_0->static_sampler_count) { - struct vkd3d_static_sampler_desc *samplers; + struct vkd3d_shader_static_sampler_desc *samplers; if (!(samplers = vkd3d_calloc(v_1_0->static_sampler_count, sizeof(*samplers)))) return VKD3D_ERROR_OUT_OF_MEMORY; v_1_0->static_samplers = samplers; @@ -2713,7 +2713,7 @@ static unsigned int versioned_root_signature_get_static_sampler_count(const stru return desc->u.v_1_1.static_sampler_count; } -static const struct vkd3d_static_sampler_desc *versioned_root_signature_get_static_samplers( +static const struct vkd3d_shader_static_sampler_desc *versioned_root_signature_get_static_samplers( const struct vkd3d_versioned_root_signature_desc *desc) { if (desc->version == VKD3D_ROOT_SIGNATURE_VERSION_1_0) @@ -2970,7 +2970,7 @@ static int shader_write_root_parameters(struct root_signature_writer_context *co static int shader_write_static_samplers(struct root_signature_writer_context *context, const struct vkd3d_versioned_root_signature_desc *desc) { - const struct vkd3d_static_sampler_desc *samplers = versioned_root_signature_get_static_samplers(desc); + const struct vkd3d_shader_static_sampler_desc *samplers = versioned_root_signature_get_static_samplers(desc); unsigned int i; for (i = 0; i < versioned_root_signature_get_static_sampler_count(desc); ++i) @@ -3264,8 +3264,8 @@ static int convert_root_signature_to_v1_0(struct vkd3d_versioned_root_signature_ { const struct vkd3d_root_signature_desc1 *src_desc = &src->u.v_1_1; struct vkd3d_root_signature_desc *dst_desc = &dst->u.v_1_0; + struct vkd3d_shader_static_sampler_desc *samplers = NULL; struct vkd3d_shader_root_parameter *parameters = NULL; - struct vkd3d_static_sampler_desc *samplers = NULL; int ret; if ((dst_desc->parameter_count = src_desc->parameter_count)) @@ -3385,7 +3385,7 @@ static int convert_root_signature_to_v1_1(struct vkd3d_versioned_root_signature_ { const struct vkd3d_root_signature_desc *src_desc = &src->u.v_1_0; struct vkd3d_root_signature_desc1 *dst_desc = &dst->u.v_1_1; - struct vkd3d_static_sampler_desc *samplers = NULL; + struct vkd3d_shader_static_sampler_desc *samplers = NULL; struct vkd3d_root_parameter1 *parameters = NULL; int ret; -- 2.11.0

1 0

[PATCH] usp10: Don't specify ETO_GLYPH_INDEX for bitmap fonts.
by Dmitry Timoshkov 21 Jul '20

21 Jul '20

This patch uses same check as ScriptShapeOpenType() does, and fixes painting of non-latin characters in Wordpad using MS Sans Serif font. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/usp10/usp10.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 322091c547..20025a6e93 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -3607,10 +3607,10 @@ HRESULT WINAPI ScriptTextOut(const HDC hdc, SCRIPT_CACHE *psc, int x, int y, UIN if (!hdc || !psc) return E_INVALIDARG; if (!piAdvance || !psa || !pwGlyphs) return E_INVALIDARG; - fuOptions &= ETO_CLIPPED + ETO_OPAQUE; + fuOptions &= ETO_CLIPPED | ETO_OPAQUE; fuOptions |= ETO_IGNORELANGUAGE; - if (!psa->fNoGlyphIndex) /* Have Glyphs? */ - fuOptions |= ETO_GLYPH_INDEX; /* Say don't do translation to glyph */ + if (!psa->fNoGlyphIndex && ((ScriptCache *)*psc)->sfnt) + fuOptions |= ETO_GLYPH_INDEX; /* We do actually have glyph indices */ if (!(lpDx = heap_calloc(cGlyphs, 2 * sizeof(*lpDx)))) return E_OUTOFMEMORY; -- 2.26.2

2 1

[PATCH 10/10 v2] msvcrt: Don't use wine/unicode.h header.
by Piotr Caban 21 Jul '20

21 Jul '20

1 0

[PATCH 09/10 v2] msvcrt: Copy wcsrchr implementation from ntdll.
by Piotr Caban 21 Jul '20

21 Jul '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/wcs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

1 0

[PATCH 08/10 v2] msvcrt: Copy wcschr implementation from ntdll.
by Piotr Caban 21 Jul '20

21 Jul '20

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/wcs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

1 0

[PATCH 07/10 v2] msvcrt: Copy wcscat implementation from ntdll.
by Piotr Caban 21 Jul '20

21 Jul '20

1 0

[PATCH 06/10 v2] msvcrt: Copy wcscpy implementation from ntdll.
by Piotr Caban 21 Jul '20

21 Jul '20

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2020