On Mon Jun 27 07:52:49 2022 +0000, Nikolay Sivov wrote:
> This is already done in video_renderer_initialize(). Maybe it's not
> triggered on shutdown?
I think the test failure may come from a missing the `video_renderer_release_presenter_services` call, though I haven't really investigated that aspect of the problem. If it's the case, perhaps it should be added to `video_renderer_initialize` too.
The issue with the testbot and 32bit apps is that the way `Initialize` is currently written it create a second video renderer before releasing the previously created one. This requires another d3d device initialization, which often fails from address space exhaustion, so releasing the previous renderer first was resolving the issue (and the reference leak also probably made it worse).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2750
The return length is unlikely to change between the two NtQuerySystemInformationEx calls, but it's possible, and it's more correct to parse the entries with the length from the call where the data was returned.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/316
The GetWorkItemCount implementation may look strange. It's done this way because of how WaitForAllItems is implemented. Alternative solution is to introduce separate counter for GetWorkItemCount.
--
v4: d3dx10/tests: Add D3DX10CreateThreadPump tests.
d3dx10: Add ID3DX10ThreadPump:PurgeAllItems implementation.
d3dx10: Add ID3DX10ThreadPump:GetQueueStatus implementation.
d3dx10: Add ID3DX10ThreadPump:WaitForAllItems implementation.
d3dx10: Add ID3DX10ThreadPump:ProcessDeviceWorkItems implementation.
d3dx10: Add ID3DX10ThreadPump:GetWorkItemCount implementation.
d3dx10: Add ID3DX10ThreadPump:AddWorkItem implementation.
d3dx10: Add D3DX10CreateThreadPump stub.
d3dx10/tests: Fix texture leak in check_resource_data.
https://gitlab.winehq.org/wine/wine/-/merge_requests/272