wine-devel July 2022

wine-devel@winehq.org

51 participants
452 discussions

Start a nNew thread

Re: [PATCH v2 01/11] winmm/tests: Add tests for visibility of video window.
by Marvin 31 Jul '22

31 Jul '22

1 0

Re: [PATCH v2 05/11] winmm/tests: Add tests for destination of video window.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120238 Your paranoid android. === debian11 (32 bit report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit German report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit French report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) === debian11 (32 bit WoW report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (64 bit WoW report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51)

1 0

Re: [PATCH v2 04/11] winmm/tests: Add tests for dimensions of video window.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120237 Your paranoid android. === debian11 (32 bit report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit German report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit French report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) === debian11 (32 bit WoW report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (64 bit WoW report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51)

1 0

Re: [PATCH v2 7/7] xactengine3_7: Return error on invalid notification value.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120222 Your paranoid android. === debian11 (32 bit report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Arabic:Morocco report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit German report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit French report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Hebrew:Israel report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Hindi:India report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Japanese:Japan report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Chinese:China report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit WoW report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (64 bit WoW report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received

1 0

[PATCH] fltlib: Add fixme stub for FilterSendMessage.
by Chao Long 31 Jul '22

31 Jul '22

Signed-off-by: Chao Long <longchao(a)uniontech.com> --- dlls/fltlib/fltlib.c | 11 +++++++++++ dlls/fltlib/fltlib.spec | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/fltlib/fltlib.c b/dlls/fltlib/fltlib.c index a6cf060b3d1..a322e7559de 100644 --- a/dlls/fltlib/fltlib.c +++ b/dlls/fltlib/fltlib.c @@ -80,3 +80,14 @@ HRESULT WINAPI FilterUnload(LPCWSTR filtername) return S_OK; } + +/********************************************************************** + * FilterSendMessage (FLTLIB.@) + */ +HRESULT WINAPI FilterSendMessage(HANDLE port, LPVOID in_buffer, DWORD in_size, LPVOID out_buffer, + DWORD out_size, LPDWORD returned) +{ + FIXME("(%p, %p, %d, %p, %d, %p) stub\n", port,in_buffer,in_size,out_buffer,out_size,returned); + + return S_OK; +} \ No newline at end of file diff --git a/dlls/fltlib/fltlib.spec b/dlls/fltlib/fltlib.spec index 226a61519d1..48caa505a28 100644 --- a/dlls/fltlib/fltlib.spec +++ b/dlls/fltlib/fltlib.spec @@ -18,7 +18,7 @@ @ stub FilterInstanceGetInformation @ stdcall FilterLoad(wstr) @ stub FilterReplyMessage -@ stub FilterSendMessage +@ stdcall FilterSendMessage(ptr ptr long ptr long ptr) @ stdcall FilterUnload(wstr) @ stub FilterVolumeClose @ stub FilterVolumeFindClose -- 2.20.1

2 1

Wine staging 7.14 release
by Alistair Leslie-Hughes 30 Jul '22

30 Jul '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.14 (537 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * xactengine3.7: Delay Notication for WAVEBANKPREPARED * ntdll: Check return parameter before use * ntdll: RtlFirstFreeAce only return FALSE on error * xactengine3_7: Remove Entry after FAudio Destroyed call Added: * None Updated: * xactengine3_7-Notification * xactengine3_7-callbacks Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: [PATCH v2 3/5] mshtml: Implement document.doctype.
by Marvin 29 Jul '22

29 Jul '22

1 0

Re: [PATCH 4/5] mshtml: Implement DocumentType node's name prop.
by Marvin 29 Jul '22

29 Jul '22

1 0

Re: [PATCH 3/5] mshtml: Implement document.doctype.
by Marvin 29 Jul '22

29 Jul '22

1 0

[PATCH vkd3d 2/3] vkd3d-shader: Introduce a compile option to use Unknown format for typed UAV reads.
by Conor McCarthy 29 Jul '22

29 Jul '22

Specifying R32ui for UAVs created with a vector format, e.g. R32G32B32A32_FLOAT, results in only the red being loaded/stored, potentially causing images to contain only the red component. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> --- include/vkd3d_shader.h | 18 ++++++++++++++++++ libs/vkd3d-shader/spirv.c | 16 +++++++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index ebddbba7..4175223f 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -99,6 +99,22 @@ enum vkd3d_shader_compile_option_buffer_uav VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_BUFFER_UAV), }; +/** + * Determines how typed UAVs are declared. + */ +enum vkd3d_shader_compile_option_typed_uav +{ + /** Use R32ui format for UAVs which are read from. This is the default value. */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI = 0x00000000, + /** + * Use Unknown format for UAVs which are read from. This should only be set if + * shaderStorageImageReadWithoutFormat is enabled in the target environment. + */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN = 0x00000001, + + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV), +}; + enum vkd3d_shader_compile_option_formatting_flags { VKD3D_SHADER_COMPILE_OPTION_FORMATTING_NONE = 0x00000000, @@ -127,6 +143,8 @@ enum vkd3d_shader_compile_option_name VKD3D_SHADER_COMPILE_OPTION_FORMATTING = 0x00000003, /** \a value is a member of enum vkd3d_shader_api_version. \since 1.3 */ VKD3D_SHADER_COMPILE_OPTION_API_VERSION = 0x00000004, + /** \a value is a member of enum vkd3d_shader_compile_option_typed_uav. \since 1.5 */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV = 0x00000005, VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_NAME), }; diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index 776533cb..6450f818 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -2228,6 +2228,7 @@ struct vkd3d_dxbc_compiler bool strip_debug; bool ssbo_uavs; + bool uav_read_without_format; struct rb_tree symbol_table; uint32_t temp_id; @@ -2379,6 +2380,15 @@ struct vkd3d_dxbc_compiler *vkd3d_dxbc_compiler_create(const struct vkd3d_shader case VKD3D_SHADER_COMPILE_OPTION_API_VERSION: break; + + case VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV: + if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI) + compiler->uav_read_without_format = false; + else if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN) + compiler->uav_read_without_format = true; + else + WARN("Ignoring unrecognised value %#x for option %#x.\n", option->value, option->name); + break; } } @@ -5856,14 +5866,18 @@ static uint32_t vkd3d_dxbc_compiler_get_image_type_id(struct vkd3d_dxbc_compiler const struct vkd3d_shader_descriptor_info *d; uint32_t sampled_type_id; SpvImageFormat format; + bool uav_read; format = SpvImageFormatUnknown; if (reg->type == VKD3DSPR_UAV) { d = vkd3d_dxbc_compiler_get_descriptor_info(compiler, VKD3D_SHADER_DESCRIPTOR_TYPE_UAV, range); - if (raw_structured || (d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ)) + uav_read = !!(d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ); + if (raw_structured || (uav_read && !compiler->uav_read_without_format)) format = image_format_for_image_read(data_type); + else if (uav_read) + vkd3d_spirv_enable_capability(builder, SpvCapabilityStorageImageReadWithoutFormat); } sampled_type_id = vkd3d_spirv_get_type_id(builder, data_type, 1); -- 2.36.1

3 10

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2022