- wine-devel - winehq.org

Re: [PATCH 1/2 v2] ntdll/tests: Check debug registers of a newly created thread
by Christian Inci 07 Apr '17

07 Apr '17

Forgot to send the response to wine-devel too. On 04/07/2017 10:01 PM, Christian Inci wrote: > Thank you very much for letting me know. > > Setting Dr7 with the "wrong" bits set will result into this error. > I'm going to change the testcase right now. > > On 04/07/2017 09:07 PM, Alexandre Julliard wrote: >> Christian Inci <chris.wine(a)broke-the-inter.net> writes: >> >>> +static void test_thread_debug_registers(void) >>> +{ >>> + HANDLE thread; >>> + CONTEXT ctx; >>> + NTSTATUS status; >>> + >>> + ctx.ContextFlags = CONTEXT_DEBUG_REGISTERS; >>> + ctx.Dr0 = 0xffffffff; >>> + ctx.Dr1 = 0xffffffff; >>> + ctx.Dr2 = 0xffffffff; >>> + ctx.Dr3 = 0xffffffff; >>> + ctx.Dr6 = 0xffffffff; >>> + ctx.Dr7 = 0xffffffff; >>> + status = pNtSetContextThread(GetCurrentThread(), &ctx); >>> + todo_wine ok(status == STATUS_SUCCESS, "NtSetContextThread failed with %x\n", status); >> >> It would be a more convincing test if setting the context succeeded. The >> failure is of course interesting too, but that could be a separate test. >>

1 0

Re: [PATCH v4 4/4] user32/tests: Fix an intermittent failure. (resend)
by Marvin 07 Apr '17

07 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=30041 Your paranoid android. === w7u (32 bit msg) === msg.c:12062: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:12064: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:12064: Test failed: wrong tme.hwndTrack 0018017E, expected 00000000 msg.c:12064: Test failed: wrong tme.dwHoverTime 400, expected 0 === w7pro64 (32 bit msg) === msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 7: the msg sequence is not complete: expected 0000 - actual 0005

1 0

Re: [PATCH] tools/winedump: Change duplicate flag.
by Austin English 07 Apr '17

07 Apr '17

On Apr 7, 2017 2:22 PM, "Zebediah Figura" <z.figura12(a)gmail.com> wrote: On 04/07/2017 02:09 PM, Alexandre Julliard wrote: > Zebediah Figura <z.figura12(a)gmail.com> writes: > >> diff --git a/tools/winedump/main.c b/tools/winedump/main.c >> index a4ebb43..5c683f6 100644 >> --- a/tools/winedump/main.c >> +++ b/tools/winedump/main.c >> @@ -226,7 +226,7 @@ static const struct my_option option_table[] = { >> {"-v", SPEC, 0, do_verbose, "-v Show lots of detail while working (verbose)."}, >> {"dump", DUMP, 0, do_dump, "dump <file> Dump the contents of 'file' (dll, exe, lib...)"}, >> {"-C", DUMP, 0, do_symdmngl, "-C Turn on symbol demangling"}, >> - {"-f", DUMP, 0, do_dumphead, "-f Dump file header information"}, >> + {"-F", DUMP, 0, do_dumphead, "-F Dump file header information"}, > > Not a big deal, but is there a reason for changing this? > The -f flag is assigned to two different options, yielding this one unreachable. Please also update the manpage. Thanks for catching this!

1 0

Re: [PATCH 1/2 v2] ntdll/tests: Check debug registers of a newly created thread
by Alexandre Julliard 07 Apr '17

07 Apr '17

Christian Inci <chris.wine(a)broke-the-inter.net> writes: > +static void test_thread_debug_registers(void) > +{ > + HANDLE thread; > + CONTEXT ctx; > + NTSTATUS status; > + > + ctx.ContextFlags = CONTEXT_DEBUG_REGISTERS; > + ctx.Dr0 = 0xffffffff; > + ctx.Dr1 = 0xffffffff; > + ctx.Dr2 = 0xffffffff; > + ctx.Dr3 = 0xffffffff; > + ctx.Dr6 = 0xffffffff; > + ctx.Dr7 = 0xffffffff; > + status = pNtSetContextThread(GetCurrentThread(), &ctx); > + todo_wine ok(status == STATUS_SUCCESS, "NtSetContextThread failed with %x\n", status); It would be a more convincing test if setting the context succeeded. The failure is of course interesting too, but that could be a separate test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] regedit: Correctly handle the importing of DWORD strings that are followed by a comment
by Alexandre Julliard 07 Apr '17

07 Apr '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/regproc.c | 29 ++++++++++++++++++++++++----- > programs/regedit/tests/regedit.c | 4 ++-- > 2 files changed, 26 insertions(+), 7 deletions(-) > > diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c > index e0049c6..c8149f5 100644 > --- a/programs/regedit/regproc.c > +++ b/programs/regedit/regproc.c > @@ -146,15 +146,34 @@ static char* GetMultiByteStringN(const WCHAR* strW, int chars, DWORD* len) > */ > static BOOL convertHexToDWord(WCHAR* str, DWORD *dw) > { > - char buf[9]; > + char *buf; > char dummy; > + BOOL ret = TRUE; > > - WideCharToMultiByte(CP_ACP, 0, str, -1, buf, 9, NULL, NULL); > - if (lstrlenW(str) > 8 || sscanf(buf, "%x%c", dw, &dummy) != 1) { > + buf = GetMultiByteString(str); > + if (!buf) return FALSE; > + > + if (strlen(buf) > 8) /* Look for any characters after the DWORD string */ > + { > + char *p = buf + 8; > + > + while (*p == ' ' || *p == '\t') p++; > + if (*p != ';') > + { > + HeapFree(GetProcessHeap(), 0, buf); > + return FALSE; > + } > + buf[8] = 0; > + } > + > + if (sscanf(buf, "%x%c", dw, &dummy) != 1) > + { > output_message(STRING_INVALID_HEX); > - return FALSE; > + ret = FALSE; > } It may be a good idea to write tests for dwords with different numbers of digits, it's not clear to me that this would be doing the right thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/8] server: Pass async_data_t as varargs in write request.
by Jacek Caban 07 Apr '17

07 Apr '17

On 06.04.2017 17:58, Jacek Caban wrote: > This is needed for later patch that adds APCs to async_data_t, causing > request to exceed allowed size. Having second thoughts about it, I think there is a solution that doesn't require changing async_data_t size. We could require that the first field of callback argument is a pointer to callback. This way we could have just one pointer for callback and its argument, saving space for APC in async_data_t. Please let me know if that would be preferred. Thanks, Jacek

2 1

Re: [PATCH] odbccp32: Implement SQLConfigDriver/W
by Huw Davies 07 Apr '17

07 Apr '17

On Fri, Apr 07, 2017 at 12:48:17AM +0000, Alistair Leslie-Hughes wrote: > v2 - Use worker function to load DLL > - Correctly set error when required. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 115 ++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 105 insertions(+), 10 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 773c5d2..041170a 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -62,6 +62,12 @@ static const WCHAR odbc_error_component_not_found[] = {'C','o','m','p','o','n',' > static const WCHAR odbc_error_out_of_mem[] = {'O','u','t',' ','o','f',' ','m','e','m','o','r','y',0}; > static const WCHAR odbc_error_invalid_param_sequence[] = {'I','n','v','a','l','i','d',' ','p','a','r','a','m','e','t','e','r',' ','s','e','q','u','e','n','c','e',0}; > static const WCHAR odbc_error_invalid_param_string[] = {'I','n','v','a','l','i','d',' ','p','a','r','a','m','e','t','e','r',' ','s','t','r','i','n','g',0}; > +static const WCHAR odbc_error_invalid_dsn[] = {'I','n','v','a','l','i','d',' ','D','S','N',0}; > +static const WCHAR odbc_error_load_lib_failed[] = {'L','o','a','d',' ','L','i','b','r','a','r','y',' ','F','a','i','l','e','d',0}; > +static const WCHAR odbc_error_request_failed[] = {'R','e','q','u','e','s','t',' ','F','a','i','l','e','d',0}; > + > +static BOOL (WINAPI *pConfigDriverW)(HWND hwnd, WORD request, const WCHAR *driver, const WCHAR *args, const WCHAR *msg, WORD msgmax, WORD *msgout); > +static BOOL (WINAPI *pConfigDriverA)(HWND hwnd, WORD request, const char *driver, const char *args, const char *msg, WORD msgmax, WORD *msgout); Is there a reason why pConfigDriverA/W are not local variables? Huw.

1 0

Re: [PATCH 2/2] wmvcore: Add WMReader stubs
by Nikolay Sivov 07 Apr '17

07 Apr '17

On 07.04.2017 6:51, Jefferson Carpenter wrote: > Adds interfaces used by IMesh in bug 42416, except for these: > > 5c938aeb-6378-479e-bfd5-eafba63dc6e9 > 7af7d5ed-4ef9-48da-a4b6-8ea7eb38f5cc > --- > dlls/wmvcore/wmvcore_main.c | 1301 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 1301 insertions(+) > Hi, this is too much for a single patch. Please split it up and add some tests that shows such interfaces are actually supported. To add tests create a 'tests' directory, Makefile.in in it, and wmvcore.c (file name could be different), where you place tests. You'll have to modify configure.ac to add WINE_CONFIG_TEST line in it. If you need to link to wmvcore.dll from your test, you'll need to modify WINE_CONFIG_DLL too, to include implib directive.

2 1

Re: shell32: Fix the 'OK' button is always gray when call SHBrowseForFolder with flags BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS (try 2)
by Xu Wenlong 07 Apr '17

07 Apr '17

------------------ Original ------------------ From: "Marvin"<testbot(a)winehq.org>; Date: Fri, Apr 7, 2017 04:05 AM To: "Xu Wenlong"<xuwenlong(a)deepin.com>; Subject: Re: shell32: Fix the 'OK' button is always gray when call SHBrowseForFolder with flags BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS (try 2) Thank you for your contribution to Wine! This is an automated notification to let you know that your patch has been reviewed and its status set to "No patch". This means that no patch was found in your mail. If you do not understand the reason for this status, disagree with our assessment, or are simply not sure how to proceed next, please ask for clarification by replying to this email.

1 0

Mailing List Issues
by Jeremy Newman 06 Apr '17

06 Apr '17

We have been having issues with bounces and people getting removed from the list subscriptions as of late. It seems to mostly affect Gmail users, but some others have been getting kicked as well. Gmail is getting particularly picky about valid mail headers. I'm looking into ways of preventing this from happening. I've done the following to prevent further issues: * Raise the bounce threshold in mailman to 10.0 * Add SPF record to DNS * Add DMARC policy to DNS * Add DKIM key signing to all outbound mail, and matching key in DNS We also have been hitting our bandwidth threshold at our co-lo. When this happens they start to drop packets on us as a form of throttling. This always happens when I do a full CDN flush. As this really chews up the bits when the mirrors re-sync. To prevent that, we now have a background process watching for changed files on our master, and only changes will be flushed. If you notice any further issues, or have suggestions, let me know. Thanks. -N

1 0

Re: [PATCH 2/2] odbccp32: Implement SQLRemoveTranslator/W
by Huw Davies 06 Apr '17

06 Apr '17

On Wed, Apr 05, 2017 at 09:51:15AM +0000, Alistair Leslie-Hughes wrote: > v3 - Fix trace message. > v4 - Fixed assignment of usage_count > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 69 +++++++++++++++++++++++++++++++++++++++++----- > dlls/odbccp32/tests/misc.c | 8 +++--- > 2 files changed, 66 insertions(+), 11 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 7b2f020bbe..161f2c2bd2 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1229,20 +1229,75 @@ BOOL WINAPI SQLRemoveDSNFromIni(LPCSTR lpszDSN) > return FALSE; > } > > -BOOL WINAPI SQLRemoveTranslatorW(LPCWSTR lpszTranslator, LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveTranslatorW(const WCHAR *translator, DWORD *usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %p\n", debugstr_w(lpszTranslator), lpdwUsageCount); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("%s %p\n", debugstr_w(translator), usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, translator, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + DWORD count; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + count = usagecount - 1; > + if (count) > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&count, sizeof(count)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + } > + > + RegCloseKey(hkeydriver); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + if(RegDeleteKeyW(hkey, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(translator)); > + > + if (RegOpenKeyW(hkey, odbctranslators, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(translator)); > + > + RegCloseKey(hkeydriver); > + } > + } > + > + RegCloseKey(hkey); > + } > + > + if (usage_count) > + *usage_count = usagecount; > + > + return TRUE; > } Sorry, I've just noticed that this returns TRUE even if the requested translator isn't installed, which is not correct. A test for that would be good too. Huw.

1 0

Re: gdi32: Change default interface font to Gothic typeface for CJK.
by Akihiro Sagawa 06 Apr '17

06 Apr '17

> On Tue, Apr 04, 2017 at 11:25:18PM +0800, Jactry Zeng wrote: > > This patch changes default interface typeface of CJK from Mincho font to > > Gothic font. > > Windows had made this change since Windows Vista. macOS and most of Linux > > distros are using Gothic typeface by default for CJK, too. > > This seems to be confirmed by the great oracle of truth that is Wikipedia. > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> I'm not sure about this. On my Japanese Windows 7, MS Shell Dlg points to MS UI Gothic, not Meiryo. If I remember correctly, it also points to legacy Mincho font in Chinese/Korean environment. I'm afraid that this change also affects dialog base units (e.g. GetDialogBaseUnits). A lot of application dialogs depend on default font's dialog units. Though Windows 7 introduces new type faces, we should use legacy font face in GDI for that reason. Instead of MS Shell Dlg, how about using "MS Shell Dlg 2" for system dialog windows? Regards, Akihiro Sagawa

3 3

Re: [PATCH 2/6] comctl32/tests: Test messages sent to the pager child.
by Nikolay Sivov 05 Apr '17

05 Apr '17

On 05.04.2017 10:15, Stefan Dösinger wrote: > --- > dlls/comctl32/tests/msg.h | 19 ++++++++++-- > dlls/comctl32/tests/pager.c | 70 ++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 83 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h > index b30b5d8..a3c789b 100644 > --- a/dlls/comctl32/tests/msg.h > +++ b/dlls/comctl32/tests/msg.h > @@ -39,7 +39,8 @@ typedef enum > hook = 0x100, > winevent_hook =0x200, > id = 0x400, > - custdraw = 0x800 > + custdraw = 0x800, > + child1 = 0x1000, > } msg_flags_t; > Maybe I don't see a full picture yet, but doesn't this duplicate 'id' flag? We use it for ListView/Header combined sequences for example. > struct message > @@ -182,6 +183,8 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > { > if (expected->message == actual->message) > { > + const char *expected_win = NULL; > + > if (expected->flags & wparam) > { > if (expected->wParam != actual->wParam && todo) > @@ -304,11 +307,23 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > context, expected->message, (expected->flags & posted) ? "posted" : "sent"); > if ((expected->flags & (sent|posted)) != (actual->flags & (sent|posted))) dump++; > > + if (expected->flags & parent) > + expected_win = "parent"; > + else if (expected->flags & child1) > + expected_win = "child 1"; > + else > + expected_win = "pager"; This has to be generic, something neutral like "control" instead of "pager" is better, if we'll end up using new flag.

2 2

Re: [PATCH 1/4] regedit: Concatenate the next line when a comment follows the backslash
by Alexandre Julliard 05 Apr '17

05 Apr '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -715,7 +715,7 @@ static char *get_lineA(FILE *fp) > > while (next) > { > - char *p = strpbrk(line, "\r\n"); > + char *p = strpbrk(line, "\r\n"), *s; > if (!p) > { > size_t len, count; > @@ -741,10 +741,11 @@ static char *get_lineA(FILE *fp) > next = p + 1; > if (*p == '\r' && *(p + 1) == '\n') next++; > *p = 0; > - if (p > buf && *(p - 1) == '\\') > + if ((s = strchr(line, ':')) && (*(s - 1) == 'x' || *(s - 1) == ')')) > { > - while (*next == ' ' || *next == '\t') next++; > - memmove(p - 1, next, strlen(next) + 1); > + s = strchr(s, '\\'); > + if (!s) return line; > + memmove(s, next, strlen(next) + 1); This looks wrong. I assume it's meant to check for hex() and the like, but this would have to be done in the parser, not in the line reading code. There could just as well be a "hex:" inside a value string for instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Store render target info instead of surfaces in "blit_targets".
by Henri Verbeet 05 Apr '17

05 Apr '17

On 5 April 2017 at 15:38, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -2678,17 +2713,17 @@ BOOL context_apply_clear_state(struct wined3d_context *context, const struct win > > if (!rt_count || wined3d_resource_is_offscreen(rts[0]->resource)) > { > + memset(context->blit_targets, 0, gl_info->limits.buffers * sizeof(context->blit_targets)); Is that sizeof missing a '*'?

1 0

Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.
by Nikolay Sivov 05 Apr '17

05 Apr '17

On 05.04.2017 10:15, Stefan Dösinger wrote: > --- > dlls/comctl32/tests/msg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h > index 3fa0fae..b30b5d8 100644 > --- a/dlls/comctl32/tests/msg.h > +++ b/dlls/comctl32/tests/msg.h > @@ -369,7 +369,7 @@ static void ok_sequence_(struct msg_sequence **seq, int sequence_index, > context, expected->message, actual->message); > } > > - if(todo && !failcount) /* succeeded yet marked todo */ > + if(todo && !failcount && !broken(TRUE)) /* succeeded yet marked todo */ > { > dump++; > todo_wine > This patch is marked is failed by testbot, but it looks like bot inability to deal with header file change in tests directory, as it still tries to run some tests. Anyway, could you make it look similar to user32/tests/msg.c? It's using: --- if( todo && !failcount) /* succeeded yet marked todo */ todo_wine { if (!strcmp(winetest_platform, "wine")) dump++; --- Platform is tested directly. It's not the only place where it's done like that, and it's more readable than broken(1), I think.

3 2

Re: [PATCH 2/4] ws2_32/tests: Added WSARecv tests using completion function.
by Marvin 05 Apr '17

05 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29976 Your paranoid android. === w2008s64 (64 bit sock) === sock.c:6817: Test failed: got 0

1 0

Re: [PATCH 6/6] comctl32/tests: Test WINDOWPOS structure contents.
by Marvin 05 Apr '17

05 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29956 Your paranoid android. === wvistau64 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w2008s64 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w7pro64 (64 bit pager) === pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} === w1064 (64 bit pager) === pager.c:292: Test failed: set child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:299: Test failed: switch to invisible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:307: Test failed: switch to visible child: in msg 0x0046 got incorrect WINDOWPOS contents {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0, expected {x=0, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:314: Test failed: set pos 10: in msg 0x0046 got incorrect WINDOWPOS contents {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-10, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0} pager.c:325: Test failed: set pos 9: in msg 0x0046 got incorrect WINDOWPOS contents {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}, expected {x=-9, y=0, cx=98 cy=98, hwndInsertAfter=0000000000000000, flags=0}

2 1

Re: [v3 PATCH 2/2] odbccp32: Implement SQLRemoveTranslator/W
by Huw Davies 05 Apr '17

05 Apr '17

On Wed, Apr 05, 2017 at 01:29:21AM +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 7b2f020bbe..4e00f2a29f 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1229,20 +1229,75 @@ BOOL WINAPI SQLRemoveDSNFromIni(LPCSTR lpszDSN) > return FALSE; > } > > -BOOL WINAPI SQLRemoveTranslatorW(LPCWSTR lpszTranslator, LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveTranslatorW(const WCHAR *translator, DWORD *usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %p\n", debugstr_w(lpszTranslator), lpdwUsageCount); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("%s %p\n", debugstr_w(translator), usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, translator, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + DWORD count; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + count = usagecount - 1; > + if (count) > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&count, sizeof(count)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + } > + > + RegCloseKey(hkeydriver); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + if(RegDeleteKeyW(hkey, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(translator)); > + > + if (RegOpenKeyW(hkey, odbctranslators, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, translator) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(translator)); > + > + RegCloseKey(hkeydriver); > + } > + } > + > + RegCloseKey(hkey); > + } > + > + if (usage_count) > + *usage_count = 0; Should this really always be zero? Huw.

1 0

Re: [PATCH] winhttp/tests: Added multi Authenticate header test
by Hans Leidekker 05 Apr '17

05 Apr '17

On Tue, 2017-04-04 at 23:39 +0000, Alistair Leslie-Hughes wrote: > +static void test_multi_authentication(int port) > +{ > + static const WCHAR multiauthW[] = {'/','m','u','l','t','i','a','u','t','h',0}; > + static const WCHAR getW[] = {'G','E','T',0}; > + HINTERNET ses, con, req; > + DWORD supported, first, target = 8; > + BOOL ret; > + > + ses = WinHttpOpen(test_useragent, WINHTTP_ACCESS_TYPE_NO_PROXY, NULL, NULL, 0); > + ok(ses != NULL, "failed to open session %u\n", GetLastError()); > + > + con = WinHttpConnect(ses, localhostW, port, 0); > + ok(con != NULL, "failed to open a connection %u\n", GetLastError()); > + > + req = WinHttpOpenRequest(con, getW, multiauthW, NULL, NULL, NULL, 0); > + ok(req != NULL, "failed to open a request %u\n", GetLastError()); > + > + ret = WinHttpSendRequest(req, WINHTTP_NO_ADDITIONAL_HEADERS, 0, > + WINHTTP_NO_REQUEST_DATA,0, 0, 0 ); > + ok(ret, "expected success\n"); > + > + ret = WinHttpReceiveResponse(req, NULL); > + ok(ret, "expected success\n"); > + > + ret = WinHttpQueryAuthSchemes(req, &supported, &first, &target); > + todo_wine ok(ret, "expected success\n"); > + todo_wine ok(supported == (WINHTTP_AUTH_SCHEME_BASIC | WINHTTP_AUTH_SCHEME_NTLM), "got %x\n", supported); > + todo_wine ok(target == WINHTTP_AUTH_TARGET_SERVER, "got %x\n", target); You need to initialize 'supported'. Maybe test 'first' too?

1 0

Re: [PATCH 1/6] comctl32/tests: Don't dump successful sequences on Windows.
by Marvin 05 Apr '17

05 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29951 Your paranoid android. === wxppro (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2003std (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === wvistau64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2008s64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7u (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7pro64 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w8 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w864 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w1064 (32 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === wvistau64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w2008s64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w7pro64 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w864 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?) === w1064 (64 bit) === comctl32: returned an error (1) despite having no failures comctl32: has no test summary line (early exit of the main process?)

1 0

Re: shell32: Solve the problem about 'OK' button is always disable when call SHBrowseForFolder with flags including both BIF
by Marvin 05 Apr '17

05 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29950 Your paranoid android. === build (build) === Patch failed to apply

1 0

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS
by 许文龙 05 Apr '17

05 Apr '17

shell32: Solve the problem about 'OK' button is always gray when call SHBrowseForFolder with flags including both BIF_BROWSEFORCOMPUTER and BIF_RETURNONLYFSDIRS

1 0

Replacing TestLauncher... or not?
by Francois Gouget 04 Apr '17

04 Apr '17

One of the hoped for TestBot improvements is to get rid of TestLauncher and replace it with WineTest on the theory that they perform the same role. Indeed both add lines to the test report to identify the start and end of each test, and they check that the dlls needed for the test are present (which is buggy in TestLauncher). However WineTest only deals with Wine's test executables and this leads to some hardcoded assumptions: 1) It expects to extract the test executables from its own resources. 2) It expects that the executables will be called something like <dllname>_test.exe and that it means it should check if <dllname> is usable. 3) It expects that when given the 'list' parameter the executable will spit out the list of test units to run. 4) Then it expects proceeds to run the test executables with the command line that it chose. However the TestBot also lets Wine developers upload any executable they like and lets them specify the command line they want. This breaks all the above assumptions. So, to replace TestLauncher, WineTest would need to be modified so it can run an arbitrary executable, not from its own resources, using an arbitrary command line. And it also means merging TestLauncher's code that dives into the executable's import table to figure out which dlls are needed, with WineTest's code that has support for activation contexts (the lack of which is what's causing the bug in TestLauncher if I understand correctly). Finally one would also want to be able to build WineTest without any builtin test executable to get something small enough since it would get uploaded for each task. And that would still leave all the GUI as dead weight. As far as I can tell a WineTest with no builtin test still takes around 87 KB whereas TestLauncher can get under 12 KB. Even in the patch case there are some issues though these have essentially been known from the start: * Currently it's only possible to build WineTest with all the tests, resulting in a huge executables. Fixing this requires either bypassing the build system to build WineTest, or tweaking the build system so one can specify which executables to embed. * Even if we embed only one test executable we usually only want to run one test unit. Fortunately that's already possible by specifying it on the command line. * However, even in the case of a patch the Wine developer can specify an arbitrary command line. This is probably not very command but do we want to drop it? * Finally WineTest systematically outputs platform information. That would make every report a bit larger and would force developers to skip over it most of the time. But it may also be useful sometimes. Given the above I feel like it would be simpler, cleaner and possibly more maintainable to keep the two separate after all. Of course sticking with TestLauncher would require some work too but that seems quite tractable: * First not checking it into Git! * Making sure it gets updated automatically. * Fixing the dll checks. * Bringing it in line with the latest changes w.r.t. pids, run tmie data, etc. -- Francois Gouget <fgouget(a)codeweavers.com>

3 5

test.winehq refactoring
by Francois Gouget 04 Apr '17

04 Apr '17

So I've been working on the test.winehq.org site lately. Here is an overall description of what I'm trying to achieve: 1) Improve parsing of the WineTest reports This is what started the ball rolling. Initially the issue was with detecting the test executable exiting abruptly after a subprocess had already printed a test summary line. Pids were introduced into the test reports and test.winehq turned out to not need modifications. But having it take advantage of the pids does. And then a lot of other parsing improvements turned up. 2) Make it possible to check out the source anywhere and use it unmodified no matter where your web server files are located. Currently winetest.conf, which is checked into Git, contains hardcoded paths to Wine's Git directory and the location of the web server files. I intend to move those to the web site configuration file and to the crontab entry. The path to that is to remove $datadir, $queuedir and $gitdir in favor of a single $workdir directory; and then pass that path to the scripts that need it. For the CGI scripts this would be done by setting $workdir in the web server configuration file. And for regular scripts by passing it on the command line, starting with the crontab entry. 3) Get rid of /data in the URLs The idea is that everything that's supposed to be accessible through the web server should be in the /data directory. That means moving the error files and the /builds directory. Once that's done the web server can be told to only serve files in $workdir/data, /data becomes redundant in the URL, and redirects can be put in place to not break the old URLs. That leaves /old-data which is currently accessible but need not be, and /queue which is partly accessible but probably should not be. After this change neither would be accessible anymore. There's also a number of scripts that have an unclear purpose and make very tempting targets for git rm: error.cgi, make-winetest, service.cgi, site 3) Security I don't know of any specific bug that needs fixing and I'm not an expert in that domain. So I'm just trying to stick to some principles that I hope will help keep things reasonably secure. - I'm trying to make it so the web server process has write access to as few files as possible. In particular it should not have write access to anything that's executable. Currently the raw reports remain owned by the web server so it can still modify them. That's not necessarily an issue since those are not being run but maybe it should be changed. - Same thing for the perl scripts which is why I documented a way of setting things up based on two accounts: one for the source and one where the scripts are run (and the web server is run in a third one of course). - Eventually I hope to enable perl's taint mode. This does not guarantee safety but can help identify places where incoming data should be checked and sanitized. 4) Miscellaneous issues that would be worth looking at one day. I don't have specific plans for these (hence why they have bug entries) but I'll list them here anyway in case someone volunteers. - Disk usage seems really very high for such a simple site. The static HTML pages the web site serves are pretty big: I estimate that for test.winehq they take up 21 GB of disk. And that's not because the reports themselves are big. On any given day we get about 60 reports which typically means: 50 MB of raw report files 180 MB of full report HTML files 285 MB of individual test unit HTML files 3 MB of index files So the raw reports represent under 10% of the disk usage. Everything else is duplicated data. But fixing this would require quite a change in the way the site works. See bug 42756 for more on this part: https://bugs.winehq.org/show_bug.cgi?id=42756 Then there is the archives which takes 132 GB! There are a number of things we could do to reduce that: . It looks like we keep the old reports forever. Maybe we could delete old data after a while. . Maybe archiving just the raw report would be sufficient. After all, all the data is there. We may not be able to parse the old reports in the future but we would still be able to read them. Or we could simply archive the raw report and the single-file full report. - Instead of bz2 we could use other compression algorithms. On a set of 3 builds I got the following results: all > bz2 -9 : 22 MB / build -> 41 GB (1) all > xz -9 : 5.5 MB / build -> 10 GB (1) raw + html > bz2 -9 : 14 MB / build -> 26 GB (2) raw + html > xz -9 : 3 MB / build -> 6 GB (2) raw report > bz2 -9 : 5.5 MB / build -> 10 GB (3) raw report > xz -9 : 1.1 MB / build -> 2 GB (3) (1) Archive every single file as we currently do. (2) Only archive (the raw) report and report.html (3) Only archive (the raw) report. . Passing the 64 bit builds through UPX (as we already do for the 32 bit ones) would compress them by a factor of around 2.9 (one build that took 82 MB got reduced to 28 MB). This would reduce the size of the /builds directory to around 43 GB. - Provide per machine results over time. The index files make it possible to see how the number of failures evolved over time for a fiven platform, such as Windows XP. But anyone running the tests regularly on a machine would appreciate being able to see how it fared over time. However that's currently impossible since you only get specific machine results on a per-build basis. A fix for that would be to add a 'flat all machines' top-level index, as well as 'flat all machines' indexes for each test unit. https://bugs.winehq.org/show_bug.cgi?id=39379 - Provide some data about the test unit run time. This would likely take the form of additional per-build index files showing the test units sorted by run time with some min, max and average data. This would help identify which test units take too much time or which machines are having trouble keeping up. https://bugs.winehq.org/show_bug.cgi?id=42757 - Provide some data about the size of individual test units output The Wine test reports are pretty close to the 1.5 MB limit so having an idea of which the biggest offenders are would be helpful. https://bugs.winehq.org/show_bug.cgi?id=42758 -- Francois Gouget <fgouget(a)codeweavers.com>

2 2

Re: [v2 PATCH 2/3] odbccp32: Implement SQLRemoveTranslator/W
by Huw Davies 04 Apr '17

04 Apr '17

On Wed, Mar 22, 2017 at 10:06:18PM +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 7b2f020..d95a110 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1229,20 +1229,75 @@ BOOL WINAPI SQLRemoveDSNFromIni(LPCSTR lpszDSN) > return FALSE; > } > > -BOOL WINAPI SQLRemoveTranslatorW(LPCWSTR lpszTranslator, LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveTranslatorW(const WCHAR *translator, DWORD *usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %p\n", debugstr_w(lpszTranslator), lpdwUsageCount); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + TRACE("%s %p\n", debugstr_w(translator), usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, translator, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + DWORD count; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", count); I think you mean usagecount here. It makes me wonder whether you actually need two variables to represent the same thing. Huw.

2 2

wine-2.0.1-rc1 Available
by Michael Stefaniuc 04 Apr '17

04 Apr '17

Hello guys, I have pushed wine-2.0.1-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Nothing particularly special in this release. Slow start into 2.0.x due to lack of time on my side as well as to give the more risky patches some more time to burn in. Same old, same old: one week for feedback followed by another rc if needed with the final release 3-4 days later. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes - Deprecated tools/wineinstall ---------------------------------------------------------------- Bugs fixed in 2.0.1 (total 47): 14897 DirectDraw games (Jojo's Fashion Show 2: Las Cruces demo, The Chosen: Well of Souls) try to lock surface with invalid dwSize 14939 Black & White: DXTC to ARGB converter not implemented 17495 Open dialog crashes if the desktop folder is at a Unicode path that cannot be represented in the current locale 18477 Need For Speed Most Wanted crashes after accepting video settings changes 19888 Venom Codename: Outbreak - initial menu screen is black (no menu items) 25700 MessageBox does not display last word if string contains '&' (ampersand) 26603 iMesh 10 crashes at startup (needs wmvcore.dll.WMCreateReaderPriv) 27580 Wine Notepad command line parser eats the first 2 letters when the path starts with / (it should only do this for valid command line options) 30308 Property sheet fails to display Page Title 35993 Graphical Glitches in Agarest Generations of War 38354 Multiple games and applications need msvcr120.dll._except1 (Audacity 2.1.0, Tera Online) 38485 New Marvel Heroes 2015 Launcher crashes on unimplemented function dhcpcsvc.dll.DhcpRequestParams 39048 MIDI Clock Messages are Corrupted Between Wine and ALSA 39920 Nanocad 5.: file open/import dialog does not open 40392 ComicRack 0.9.x (.NET 4.5 app) hangs/crashes on startup when executing WMI query 40938 UE4 games (Ether One Redux, Into the Stars) crash while loading with "BackBuffer->GetResource() has 3 refs, expected 1" error 40952 improper escaping of quotes in command line 41448 Civilization II Unhandled page fault on read access 41579 Rush for Berlin Gold crashes after the intro videos 41623 Odallus The Dark Call crashes while starting if a force feedback enabled controller is plugged in 41648 AmiBroker 6.00 fails, when run, with raise_exception Unhandled exception 41725 Unimplemented function api-ms-win-crt-math-l1-1-0.dll._except1 (Starcraft 2 main menu, Firefox) 41830 Updating group box text causes garbage 41926 Zafehouse demo crashes with Call from 0x7b43c14c to unimplemented function ddraw.dll.GetSurfaceFromDC, aborting 42001 SC2 unimplemented function ucrtbase.dll._except1 42022 The Magic School Bus Explores The Solar System needs msvideo.dll16.DRAWDIBPROFILEDISPLAY 42023 The Magic School Bus Explores The Solar System crashes on launch; appears to be missing some files 42078 Dungeons & Dragons: Chronicles of Mystara needs d3dx11_43.dll.D3DX11CreateShaderResourceViewFromMemory 42093 Git for Windows 2.7.0 needs unimplemented function rstrtmgr.dll.RmShutdown 42094 winamp needs unimplemented function ntoskrnl.exe.IoStopTimer 42096 Steam -> RPGMaker 2003 needs unimplemented function KERNEL32.dll.BaseFlushAppcompatCache 42159 Sega Bug crashes immediately 42212 WOLF RPG Editor: Division by zero when winegstreamer is enabled 42218 mshtml/tests/dom crashes in xul while running test_doc_elem 42244 QQ 2013 needs ntoskrnl.exe.IoCreateFile 42245 QQ 2013 needs ntoskrnl.exe.KeClearEvent 42257 Warpath 21st Century does not have sound 42303 Magic: The Gathering Online 4.0 crashes when entering the battle 42306 One Note Free Retail installer crashes in xmllite 42315 Piriform Speccy 1.3 needs setupapi.dll.CM_Get_Child_Ex 42361 DX Library: PlaySoundFile() doesn't play MP3 files with specific extra headers 42365 Unimplemented function msvcr120.dll.fesetenv 42367 KiriKiri Z based games: main screen doesn't update. 42469 GetOpenFileName should expand environment variables in lpstrInitialDir 42483 Build for Ubuntu Precise fails because MPG123_IGNORE_INFOFRAME is undeclared 42557 NVIDIA GeForce GT 525M detected as GeForce GTX 470 42567 Acid Pro Trial 7.0e fails to install ---------------------------------------------------------------- Changes since 2.0: Adam Bolte (1): wined3d: Add GPU information for AMD FIJI. Akihiro Sagawa (3): d3d9/tests: Add LockRect tests with dynamic textures. d3d8/tests: Add LockRect tests with dynamic textures. wined3d: Upload textures if NO_DIRTY_UPDATE flag is set when locking dynamic textures. Alex Henrie (3): ddraw: Don't crash if writing out a new ddraw1 surface segfaults. comdlg32: Don't crash if an IShellFolder could not be created. user32: Include space for ampersands when determining MessageBox size. Alexandre Julliard (1): make_announce: Update version number parsing for the new versioning scheme. Alistair Leslie-Hughes (1): include: Add dhcpcsdk.h. Andrew Wesie (1): ntdll: Read entry point in LdrInitializeThunk. Andrey Gusev (2): setupapi: Add CM_Get_Child_Ex stub. d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub. Anton Romanov (1): user32: Add OCR_RDR* cursors. Austin English (6): ntoskrnl.exe: Add IoCreateFile stub. ntoskrnl.exe: Add stub KeClearEvent. kernel32: Add BaseFlushAppcompatCache stub. rstrtmgr: Add RmShutdown stub. dhcpsvc: Add DhcpRequestParams stub. readme: Remove wineinstall. Bruno Jesus (8): winmm: Fix the ordinal number for function PlaySound. dinput: DISFFC_RESET will not release the effects. notepad: Only skip valid command options. winemp3.acm: Ignore XING headers when parsing MP3 files. winemp3.acm: Fixes compilation for older mpg123 library versions. winealsa.drv: Fix handling of system real time MIDI messages. wined3d: Recognize Geforce GT 525M. wined3d: Recognize GeForce 940M. Can Taşan (3): wine.desktop: Add Turkish translation. kernel32: Add Unicode character for Turkish lira. documentation: Update Turkish translation. Christoph Brill (1): setupapi: Stub CM_Open_DevNode_Key and CM_Get_Child. Daniel Lehman (1): msvcrt: Implement nan. Dmitry Timoshkov (4): avifil32: AVIFileGetStream should set stream to NULL in case of an error. user32: BUTTON_CalcLabelRect should use the button font. user32: Fix groupbox rectangle calculation in the button's WM_SETTEXT handler. kernel32: Replace Peb->BeingDebugged check by CheckRemoteDebuggerPresent(). Fabian Maurer (1): msvcr120: Add fesetenv stub. François Gouget (3): readme: Note that Wine may also use Mac APIs. readme: Adjust a couple of section separators. readme: Update and rewrap the French translation. Gerald Pfeifer (1): winedump: Increase buffer size and potential string length inoutput_spec_symbol. Hans Leidekker (1): wbemprox: Only include matching rows in the table row count. Henri Verbeet (5): ddraw/tests: Rewrite GetDCTest(). ddraw: Implement GetSurfaceFromDC(). ddraw: Kill stray tabs. wined3d: Allow decompression blits on system memory resources in arbfp_blit_supported(). wined3d: Disallow upload conversion from compressed formats in surface_convert_format(). Jacek Caban (1): mshtml: Initialize nsAString in IHTMLDocument3::get_dir. Jacob Lifshay (1): kernel32: Fix improper escaping of quotes in command line. Jarkko Korpi (1): ntoskrnl: Add IoStopTimer stub. Jefferson Carpenter (1): wmvcore: Implement WMCreateReaderPriv. Julian Rüger (2): readme: Update German translation. readme: Fix typo in German translation. Józef Kucia (6): d3d11/tests: Add tests showing that views do not keep resource reference. d3d11: Do not keep reference to resources. ddraw: Relax "dwSize" validation in ddraw_surface*_Lock(). ddraw: Implement D3DOP_TEXTURELOAD. ddraw/tests: Add basic test for D3DOP_TEXTURELOAD. d3d9: Do not decrease swapchain surface refcount when it is already 0. Lauri Kenttä (2): readme: Update Finnish translation. readme: Update Swedish translation. Louis Lenders (2): xmllite/reader: Handle NULL node type argument in Read(). wmvcore: Add version resource. Masanori Kakura (1): winegstreamer: Avoid zero division in amt_from_gst_caps_video(). Matteo Bruni (1): d3d9: Fix DrawIndexedPrimitiveUP with non-zero min_vertex_idx. Michael Müller (2): msvideo.dll16: Implement DrawDibProfileDisplay. msvideo.dll16: Check if any 16 bit thunks have been allocated before accessing pointer. Michael Stefaniuc (1): tools: Get the ANNOUNCE bug list from the stable-notes git notes. Nikolay Sivov (5): comdlg32: Always use original Open File dialog template. comctl32/propsheet: Force wizard header if any of pages has title/subtitle. comctl32/propsheet: Only use header bitmap when asked for it. comdlg32: Expand initial directory path for file open dialog. readme: Update Russian translation. Piotr Caban (2): msvcrt: Add fesetenv implementation. msvcr120: Add _except1 implementation. Zebediah Figura (7): storage.dll16: Fix bad type in IStorage16_fnOpenStorage. winebuild: Use unsigned int in spec file variable parameters. compobj: Implement several IIDs. ole2: Implement several IIDs. avifile: Implement several IIDs. ole2disp: Implement several IIDs. typelib: Implement several IIDs. -- Michael Stefaniuc mstefani(a)winehq.org

4 4

Re: [PATCH 1/4] d3dx9/tests: Add test implementation for ID3DXEffectStateManager interface.
by Marvin 04 Apr '17

04 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29921 Your paranoid android. === build (build) === Patch failed to apply

2 2

Re: [PATCH 4/4] d3dx9: Effect should preserve states regardless of state manager presence.
by Marvin 04 Apr '17

04 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29924 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3dx9: Support effect state manager.
by Marvin 04 Apr '17

04 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29923 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] d3dx9/tests: Add tests for effect state manager.
by Marvin 04 Apr '17

04 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29922 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [v2 PATCH 3/3] odbccp32: Implement SQLConfigDriver/W
by Huw Davies 04 Apr '17

04 Apr '17

On Wed, Mar 22, 2017 at 10:06:29PM +0000, Alistair Leslie-Hughes wrote: > v2 - No Changes > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 125 +++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 115 insertions(+), 10 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index d95a110..f327817 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -63,6 +63,9 @@ static const WCHAR odbc_error_out_of_mem[] = {'O','u','t',' ','o','f',' ','m','e > static const WCHAR odbc_error_invalid_param_sequence[] = {'I','n','v','a','l','i','d',' ','p','a','r','a','m','e','t','e','r',' ','s','e','q','u','e','n','c','e',0}; > static const WCHAR odbc_error_invalid_param_string[] = {'I','n','v','a','l','i','d',' ','p','a','r','a','m','e','t','e','r',' ','s','t','r','i','n','g',0}; > > +static BOOL (WINAPI *pConfigDriverW)(HWND hwnd, WORD request, const WCHAR *driver, const WCHAR *args, const WCHAR *msg, WORD msgmax, WORD *msgout); > +static BOOL (WINAPI *pConfigDriverA)(HWND hwnd, WORD request, const char *driver, const char *args, const char *msg, WORD msgmax, WORD *msgout); > + > /* Push an error onto the error stack, taking care of ranges etc. */ > static void push_error(int code, LPCWSTR msg) > { > @@ -248,22 +251,124 @@ BOOL WINAPI SQLConfigDataSource(HWND hwndParent, WORD fRequest, > return TRUE; > } > > -BOOL WINAPI SQLConfigDriverW(HWND hwndParent, WORD fRequest, LPCWSTR lpszDriver, > - LPCWSTR lpszArgs, LPWSTR lpszMsg, WORD cbMsgMax, WORD *pcbMsgOut) > +BOOL WINAPI SQLConfigDriverW(HWND hwnd, WORD request, LPCWSTR driver, > + LPCWSTR args, LPWSTR msg, WORD msgmax, WORD *msgout) > { > + static WCHAR reg_driver[] = {'d','r','i','v','e','r',0}; > + long ret; > + HMODULE hmod; > + HKEY hkey; > + WCHAR *filename = NULL; > + DWORD size = 0, type; > + BOOL funcret = FALSE; > + > clear_errors(); > - FIXME("(%p %d %s %s %p %d %p)\n", hwndParent, fRequest, debugstr_w(lpszDriver), > - debugstr_w(lpszArgs), lpszMsg, cbMsgMax, pcbMsgOut); > - return TRUE; > + TRACE("(%p %d %s %s %p %d %p)\n", hwnd, request, debugstr_w(driver), > + debugstr_w(args), msg, msgmax, msgout); > + > + if ((ret = RegOpenKeyW(HKEY_CURRENT_USER, odbcini, &hkey)) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if ((ret = RegOpenKeyW(hkey, driver, &hkeydriver)) == ERROR_SUCCESS) > + { > + ret = RegGetValueW(hkeydriver, NULL, reg_driver, RRF_RT_REG_SZ, &type, NULL, &size); > + if(ret == ERROR_MORE_DATA) > + { > + filename = HeapAlloc(GetProcessHeap(), 0, size); > + if(!filename) > + { > + RegCloseKey(hkeydriver); > + RegCloseKey(hkey); > + return ODBC_ERROR_OUT_OF_MEM; > + } > + ret = RegGetValueW(hkeydriver, NULL, driver, RRF_RT_REG_SZ, &type, filename, &size); > + } > + > + RegCloseKey(hkeydriver); > + } > + > + RegCloseKey(hkey); > + } > + > + if(ret != ERROR_SUCCESS) > + { > + HeapFree(GetProcessHeap(), 0, filename); > + return ODBC_ERROR_INVALID_DSN; > + } > + > + hmod = LoadLibraryW(filename); > + HeapFree(GetProcessHeap(), 0, filename); This function is supposed to return a BOOL, so either that's actually not the case, or these errors should be set using SetLastError(). I suggest you try writing a helper that could be used by both A and W versions. Something like: HMODULE load_driver(const WCHAR *driver) (or DWORD load_driver(const WCHAR *driver, HMODULE *mod) if you need to return the error code.) Feel free to pick a better function name. Huw.

1 0

Re: [v2 PATCH 1/3] odbccp32: Implement SQLInstallTranslator
by Huw Davies 04 Apr '17

04 Apr '17

On Wed, Mar 22, 2017 at 10:06:05PM +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/odbccp32/tests/misc.c b/dlls/odbccp32/tests/misc.c > index 4fdf584..e977e91 100644 > --- a/dlls/odbccp32/tests/misc.c > +++ b/dlls/odbccp32/tests/misc.c > @@ -473,6 +473,67 @@ void test_SQLInstallDriverEx(void) > ok(cnt == 0, "SQLRemoveDriver failed %d\n", cnt); > } > > +void test_SQLInstallTranslatorEx(void) > +{ > + char path[MAX_PATH]; > + char syspath[MAX_PATH]; > + WORD size = 0; > + BOOL ret, sql_ret; > + DWORD cnt, error_code = 0; > + HKEY hkey; > + LONG res; > + > + GetSystemDirectoryA(syspath, MAX_PATH); > + > + ret = SQLInstallTranslatorEx("WINE ODBC Translator\0Translator=sample.dll\0Setup=sample.dll\0\0", NULL, path, MAX_PATH, &size, ODBC_INSTALL_COMPLETE, NULL); The string will be terminated in three '\0's, I suspect you only need two. Also, 160 chars is a little long for a line - There are other cases in this series where line-length is excessive. > + sql_ret = SQLInstallerErrorW(1, &error_code, NULL, 0, NULL); > + if (sql_ret && error_code == ODBC_ERROR_WRITING_SYSINFO_FAILED) > + { > + win_skip("not enough privileges\n"); > + return; > + } > + ok(sql_ret && error_code == SQL_SUCCESS, "SQLInstallDriverEx failed %d, %u\n", sql_ret, error_code); > + ok(!strcmp(path, syspath), "invalid path %s\n", path); You should test size here. Does it include the '\0' or not, msdn is vague. Huw.

1 0

Re: [PATCH] d2d1: Support text clipping with D2D1_DRAW_TEXT_OPTIONS_CLIP
by Henri Verbeet 03 Apr '17

03 Apr '17

On 1 April 2017 at 21:01, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + clip_rect.left = origin.x + layout_metrics.left; > + clip_rect.top = origin.y + layout_metrics.top; > + clip_rect.right = clip_rect.left + layout_metrics.layoutWidth; > + clip_rect.bottom = clip_rect.top + layout_metrics.layoutHeight; > + ID2D1RenderTarget_PushAxisAlignedClip(iface, &clip_rect, D2D1_ANTIALIAS_MODE_ALIASED); Does this do the right thing wrt. rendertarget transforms?

2 1

APPDB Intro email
by Bijie Zhu 03 Apr '17

03 Apr '17

Hi,My name is Bijie Zhu and I am currently a computer science student studying at City University of New York - Queens College. This is my first time participate in an open source project, and I hope I can get some guidance and feedback for the outreach project application process. I want to apply for improving APPDB website project. And I want to improve the app voting system. I would like to design an evaluation metric system for the app voting. So when people votes, we know why they vote for the app. People now can not only search for the most voted app, but also search for the app with the most desired attributes. Thank you,Bijie Zhu

2 1

Re: [PATCH] ntoskrnl.exe: add KeBugCheck/KeBugCheckEx stubs
by Michael Müller 03 Apr '17

03 Apr '17

Am 03.04.2017 um 20:25 schrieb Austin English: > Mentioned in https://bugs.winehq.org/show_bug.cgi?id=42744 and > https://bugs.winehq.org/show_bug.cgi?id=42746. Does it really make sense to add such a stub? Windows is supposed to show a BSOD when you call the function and I guess it is not supposed to return back to the caller. I would either leave it as a stub or at least unload the driver / terminate the process with an error.

2 1

Re: [PATCH] d3dx9/tests: Add more tests for relative addressing in preshaders.
by Marvin 03 Apr '17

03 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29900 Your paranoid android. === w8 (32 bit effect) === effect.c:5159: Test failed: Test 0, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 0, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 1, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 1, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 1, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 2, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 2, component 1, expected 0x3f800000 (1), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 2, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 3, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 3, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 3, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 4, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 4, component 1, expected 0x448ae000 (1111), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 5, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 6, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5159: Test failed: Test 6, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 6, component 3, expected 0x453b9000 (3001), got 0x453bc000 (3004). effect.c:5159: Test failed: Test 8, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5159: Test failed: Test 9, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5159: Test failed: Test 10, component 2, expected 0x44fa2000 (2001), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 10, component 3, expected 0 (0), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 11, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 12, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 12, component 3, expected 0xc1400000 (-12), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 13, component 0, expected 0 (0), got 0x447b0000 (1004). effect.c:5159: Test failed: Test 13, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 13, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 14, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 14, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 14, component 3, expected 0x44fa6000 (2003), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 15, component 0, expected 0 (0), got 0x447a8000 (1002). effect.c:5159: Test failed: Test 16, component 0, expected 0 (0), got 0x447a4000 (1001). effect.c:5159: Test failed: Test 16, component 2, expected 0xc1200000 (-10), got 0 (0). effect.c:5159: Test failed: Test 17, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 18, component 2, expected 0x447a4000 (1001), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 18, component 3, expected 0 (0), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 19, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 20, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 20, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 20, component 3, expected 0x40000000 (2), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 21, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 21, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 22, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 22, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 22, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 23, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 23, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -100, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -100, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -99, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -98, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -95, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -94, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -94, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -93, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -93, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -92, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -91, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -90, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -87, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -87, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -86, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -86, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -85, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -85, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -84, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -83, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -82, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -79, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -78, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -78, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -77, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -77, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -76, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -75, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -74, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -71, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -71, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -70, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -70, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -69, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -69, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -68, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -67, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -66, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -63, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -62, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -62, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -61, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -61, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -60, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -59, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -58, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -55, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -55, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -54, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -54, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -53, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -53, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -52, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -51, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -50, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -47, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -46, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -46, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -45, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -45, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -44, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -43, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -42, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -39, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -39, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -38, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -38, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -37, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -37, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -36, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -35, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -34, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -31, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -30, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -30, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -29, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -29, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -28, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -27, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -26, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -23, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -22, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -22, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -21, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -21, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -20, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -19, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -18, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -15, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -14, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -14, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -13, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -13, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -12, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -11, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -10, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -7, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -7, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -6, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -6, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -5, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -5, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -4, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -3, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -2, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 0, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 1, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 2, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 2, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 3, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 3, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 4, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 6, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 9, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 9, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 10, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 10, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 11, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 12, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 13, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 14, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 17, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 18, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 18, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 19, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 19, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 20, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 21, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 22, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 25, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 25, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 26, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 26, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 27, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 27, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 28, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 29, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 30, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 33, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 34, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 34, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 35, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 35, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 36, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 37, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 38, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 41, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 41, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 42, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 42, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 43, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 43, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 44, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 45, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 46, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 49, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 50, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 50, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 51, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 51, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 52, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 53, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 54, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 57, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 57, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 58, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 58, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 59, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 59, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 60, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 61, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 62, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 65, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 66, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 66, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 67, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 67, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 68, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 69, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 70, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 73, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 73, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 74, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 74, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 75, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 75, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 76, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 77, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 78, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 81, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 82, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 82, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 83, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 83, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 84, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 85, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 86, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 89, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 89, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 90, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 90, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 91, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 91, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 92, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 93, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 94, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 97, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 98, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 98, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 99, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 99, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5215: Test failed: Test 0, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 0, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 0, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 1, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 1, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 2, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 2, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 3, component 0, expected 0x45843000 (4230), got 0 (0). effect.c:5215: Test failed: Test 3, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 0, expected 0x46a64000 (21280), got 0 (0). effect.c:5215: Test failed: Test 4, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 4, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 5, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 5, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 5, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 6, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 6, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 7, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 8, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 8, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 8, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 9, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 10, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 13, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 14, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 15, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 16, component 1, expected 0xc1900000 (-18), got 0 (0). effect.c:5215: Test failed: Test 18, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 19, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 20, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 21, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 23, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 24, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 25, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 26, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 29, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 30, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 31, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 32, component 1, expected 0xc0000000 (-2), got 0 (0). effect.c:5215: Test failed: Test 34, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 34, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 34, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 34, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 35, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 35, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 35, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 35, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 36, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 36, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 36, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 37, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 38, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 38, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 39, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 40, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 41, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 42, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 45, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 46, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 47, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 48, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 50, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 51, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 51, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 51, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 51, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 52, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 52, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 52, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 52, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 53, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 53, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 53, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 55, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 55, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 55, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 56, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 57, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 58, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 61, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 62, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 63, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 64, component 1, expected 0x41f00000 (30), got 0 (0). effect.c:5215: Test failed: Test 67, component 1, expected 0x40800000 (4), got 0 (0). === w864 (32 bit effect) === effect.c:5159: Test failed: Test 0, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 0, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 1, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 1, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 1, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 2, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 2, component 1, expected 0x3f800000 (1), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 2, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 3, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 3, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 3, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 4, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 4, component 1, expected 0x448ae000 (1111), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 5, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 6, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5159: Test failed: Test 6, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 6, component 3, expected 0x453b9000 (3001), got 0x453bc000 (3004). effect.c:5159: Test failed: Test 8, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5159: Test failed: Test 9, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5159: Test failed: Test 10, component 2, expected 0x44fa2000 (2001), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 10, component 3, expected 0 (0), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 11, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 12, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 12, component 3, expected 0xc1400000 (-12), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 13, component 0, expected 0 (0), got 0x447b0000 (1004). effect.c:5159: Test failed: Test 13, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 13, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 14, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 14, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 14, component 3, expected 0x44fa6000 (2003), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 15, component 0, expected 0 (0), got 0x447a8000 (1002). effect.c:5159: Test failed: Test 16, component 0, expected 0 (0), got 0x447a4000 (1001). effect.c:5159: Test failed: Test 16, component 2, expected 0xc1200000 (-10), got 0 (0). effect.c:5159: Test failed: Test 17, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 18, component 2, expected 0x447a4000 (1001), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 18, component 3, expected 0 (0), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 19, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 20, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 20, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 20, component 3, expected 0x40000000 (2), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 21, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 21, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 22, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 22, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 22, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 23, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 23, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -100, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -100, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -99, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -98, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -95, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -94, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -94, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -93, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -93, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -92, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -91, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -90, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -87, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -87, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -86, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -86, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -85, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -85, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -84, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -83, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -82, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -79, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -78, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -78, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -77, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -77, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -76, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -75, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -74, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -71, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -71, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -70, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -70, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -69, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -69, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -68, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -67, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -66, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -63, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -62, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -62, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -61, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -61, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -60, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -59, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -58, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -55, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -55, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -54, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -54, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -53, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -53, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -52, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -51, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -50, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -47, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -46, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -46, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -45, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -45, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -44, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -43, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -42, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -39, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -39, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -38, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -38, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -37, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -37, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -36, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -35, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -34, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -31, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -30, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -30, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -29, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -29, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -28, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -27, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -26, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -23, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -22, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -22, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -21, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -21, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -20, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -19, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -18, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -15, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -14, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -14, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -13, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -13, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -12, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -11, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -10, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -7, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -7, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -6, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -6, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -5, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -5, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -4, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -3, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -2, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 0, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 1, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 2, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 2, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 3, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 3, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 4, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 6, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 9, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 9, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 10, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 10, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 11, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 12, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 13, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 14, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 17, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 18, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 18, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 19, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 19, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 20, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 21, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 22, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 25, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 25, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 26, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 26, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 27, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 27, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 28, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 29, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 30, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 33, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 34, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 34, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 35, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 35, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 36, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 37, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 38, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 41, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 41, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 42, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 42, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 43, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 43, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 44, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 45, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 46, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 49, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 50, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 50, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 51, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 51, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 52, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 53, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 54, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 57, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 57, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 58, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 58, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 59, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 59, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 60, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 61, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 62, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 65, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 66, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 66, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 67, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 67, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 68, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 69, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 70, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 73, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 73, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 74, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 74, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 75, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 75, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 76, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 77, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 78, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 81, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 82, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 82, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 83, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 83, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 84, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 85, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 86, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 89, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 89, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 90, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 90, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 91, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 91, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 92, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 93, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 94, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 97, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 98, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 98, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 99, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 99, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5215: Test failed: Test 0, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 0, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 0, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 1, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 1, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 2, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 2, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 3, component 0, expected 0x45843000 (4230), got 0 (0). effect.c:5215: Test failed: Test 3, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 0, expected 0x46a64000 (21280), got 0 (0). effect.c:5215: Test failed: Test 4, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 4, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 5, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 5, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 5, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 6, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 6, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 7, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 8, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 8, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 8, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 9, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 10, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 13, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 14, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 15, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 16, component 1, expected 0xc1900000 (-18), got 0 (0). effect.c:5215: Test failed: Test 18, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 19, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 20, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 21, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 23, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 24, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 25, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 26, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 29, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 30, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 31, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 32, component 1, expected 0xc0000000 (-2), got 0 (0). effect.c:5215: Test failed: Test 34, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 34, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 34, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 34, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 35, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 35, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 35, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 35, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 36, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 36, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 36, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 37, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 38, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 38, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 39, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 40, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 41, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 42, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 45, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 46, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 47, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 48, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 50, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 51, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 51, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 51, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 51, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 52, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 52, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 52, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 52, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 53, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 53, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 53, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 55, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 55, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 55, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 56, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 57, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 58, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 61, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 62, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 63, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 64, component 1, expected 0x41f00000 (30), got 0 (0). effect.c:5215: Test failed: Test 67, component 1, expected 0x40800000 (4), got 0 (0). === w1064 (32 bit effect) === effect.c:5159: Test failed: Test 0, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 0, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 1, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 1, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 1, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 2, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 2, component 1, expected 0x3f800000 (1), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 2, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 3, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 3, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 3, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 4, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 4, component 1, expected 0x448ae000 (1111), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 5, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 6, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5159: Test failed: Test 6, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 6, component 3, expected 0x453b9000 (3001), got 0x453bc000 (3004). effect.c:5159: Test failed: Test 8, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5159: Test failed: Test 9, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5159: Test failed: Test 10, component 2, expected 0x44fa2000 (2001), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 10, component 3, expected 0 (0), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 11, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 12, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 12, component 3, expected 0xc1400000 (-12), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 13, component 0, expected 0 (0), got 0x447b0000 (1004). effect.c:5159: Test failed: Test 13, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 13, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 14, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 14, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 14, component 3, expected 0x44fa6000 (2003), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 15, component 0, expected 0 (0), got 0x447a8000 (1002). effect.c:5159: Test failed: Test 16, component 0, expected 0 (0), got 0x447a4000 (1001). effect.c:5159: Test failed: Test 16, component 2, expected 0xc1200000 (-10), got 0 (0). effect.c:5159: Test failed: Test 17, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 18, component 2, expected 0x447a4000 (1001), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 18, component 3, expected 0 (0), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 19, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 20, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 20, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 20, component 3, expected 0x40000000 (2), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 21, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 21, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 22, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 22, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 22, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 23, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 23, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -100, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -100, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -99, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -98, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -95, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -94, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -94, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -93, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -93, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -92, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -91, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -90, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -87, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -87, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -86, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -86, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -85, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -85, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -84, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -83, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -82, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -79, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -78, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -78, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -77, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -77, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -76, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -75, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -74, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -71, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -71, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -70, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -70, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -69, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -69, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -68, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -67, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -66, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -63, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -62, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -62, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -61, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -61, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -60, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -59, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -58, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -55, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -55, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -54, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -54, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -53, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -53, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -52, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -51, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -50, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -47, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -46, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -46, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -45, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -45, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -44, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -43, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -42, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -39, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -39, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -38, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -38, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -37, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -37, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -36, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -35, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -34, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -31, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -30, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -30, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -29, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -29, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -28, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -27, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -26, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -23, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -22, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -22, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -21, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -21, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -20, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -19, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -18, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -15, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -14, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -14, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -13, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -13, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -12, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -11, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -10, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -7, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -7, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -6, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -6, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -5, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -5, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -4, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -3, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -2, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 0, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 1, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 2, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 2, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 3, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 3, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 4, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 6, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 9, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 9, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 10, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 10, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 11, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 12, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 13, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 14, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 17, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 18, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 18, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 19, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 19, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 20, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 21, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 22, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 25, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 25, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 26, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 26, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 27, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 27, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 28, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 29, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 30, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 33, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 34, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 34, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 35, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 35, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 36, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 37, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 38, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 41, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 41, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 42, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 42, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 43, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 43, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 44, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 45, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 46, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 49, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 50, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 50, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 51, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 51, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 52, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 53, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 54, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 57, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 57, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 58, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 58, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 59, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 59, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 60, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 61, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 62, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 65, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 66, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 66, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 67, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 67, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 68, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 69, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 70, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 73, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 73, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 74, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 74, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 75, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 75, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 76, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 77, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 78, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 81, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 82, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 82, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 83, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 83, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 84, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 85, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 86, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 89, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 89, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 90, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 90, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 91, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 91, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 92, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 93, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 94, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 97, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 98, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 98, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 99, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 99, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5215: Test failed: Test 0, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 0, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 0, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 1, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 1, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 2, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 2, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 3, component 0, expected 0x45843000 (4230), got 0 (0). effect.c:5215: Test failed: Test 3, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 0, expected 0x46a64000 (21280), got 0 (0). effect.c:5215: Test failed: Test 4, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 4, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 5, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 5, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 5, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 6, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 6, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 7, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 8, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 8, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 8, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 9, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 10, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 13, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 14, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 15, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 16, component 1, expected 0xc1900000 (-18), got 0 (0). effect.c:5215: Test failed: Test 18, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 19, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 20, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 21, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 23, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 24, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 25, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 26, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 29, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 30, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 31, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 32, component 1, expected 0xc0000000 (-2), got 0 (0). effect.c:5215: Test failed: Test 34, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 34, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 34, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 34, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 35, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 35, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 35, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 35, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 36, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 36, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 36, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 37, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 38, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 38, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 39, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 40, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 41, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 42, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 45, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 46, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 47, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 48, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 50, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 51, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 51, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 51, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 51, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 52, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 52, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 52, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 52, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 53, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 53, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 53, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 55, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 55, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 55, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 56, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 57, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 58, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 61, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 62, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 63, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 64, component 1, expected 0x41f00000 (30), got 0 (0). effect.c:5215: Test failed: Test 67, component 1, expected 0x40800000 (4), got 0 (0). === w864 (64 bit effect) === effect.c:5159: Test failed: Test 0, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 0, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 1, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 1, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 1, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 2, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 2, component 1, expected 0x3f800000 (1), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 2, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 3, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 3, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 3, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 4, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 4, component 1, expected 0x448ae000 (1111), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 5, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 6, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5159: Test failed: Test 6, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 6, component 3, expected 0x453b9000 (3001), got 0x453bc000 (3004). effect.c:5159: Test failed: Test 8, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5159: Test failed: Test 9, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5159: Test failed: Test 10, component 2, expected 0x44fa2000 (2001), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 10, component 3, expected 0 (0), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 11, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 12, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 12, component 3, expected 0xc1400000 (-12), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 13, component 0, expected 0 (0), got 0x447b0000 (1004). effect.c:5159: Test failed: Test 13, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 13, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 14, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 14, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 14, component 3, expected 0x44fa6000 (2003), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 15, component 0, expected 0 (0), got 0x447a8000 (1002). effect.c:5159: Test failed: Test 16, component 0, expected 0 (0), got 0x447a4000 (1001). effect.c:5159: Test failed: Test 16, component 2, expected 0xc1200000 (-10), got 0 (0). effect.c:5159: Test failed: Test 17, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 18, component 2, expected 0x447a4000 (1001), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 18, component 3, expected 0 (0), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 19, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 20, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 20, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 20, component 3, expected 0x40000000 (2), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 21, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 21, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 22, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 22, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 22, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 23, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 23, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -100, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -100, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -99, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -98, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -95, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -94, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -94, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -93, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -93, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -92, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -91, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -90, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -87, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -87, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -86, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -86, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -85, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -85, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -84, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -83, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -82, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -79, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -78, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -78, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -77, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -77, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -76, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -75, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -74, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -71, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -71, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -70, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -70, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -69, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -69, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -68, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -67, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -66, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -63, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -62, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -62, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -61, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -61, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -60, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -59, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -58, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -55, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -55, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -54, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -54, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -53, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -53, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -52, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -51, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -50, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -47, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -46, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -46, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -45, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -45, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -44, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -43, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -42, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -39, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -39, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -38, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -38, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -37, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -37, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -36, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -35, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -34, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -31, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -30, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -30, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -29, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -29, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -28, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -27, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -26, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -23, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -22, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -22, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -21, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -21, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -20, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -19, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -18, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -15, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -14, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -14, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -13, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -13, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -12, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -11, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -10, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -7, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -7, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -6, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -6, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -5, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -5, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -4, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -3, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -2, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 0, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 1, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 2, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 2, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 3, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 3, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 4, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 6, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 9, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 9, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 10, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 10, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 11, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 12, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 13, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 14, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 17, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 18, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 18, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 19, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 19, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 20, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 21, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 22, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 25, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 25, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 26, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 26, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 27, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 27, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 28, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 29, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 30, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 33, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 34, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 34, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 35, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 35, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 36, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 37, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 38, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 41, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 41, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 42, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 42, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 43, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 43, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 44, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 45, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 46, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 49, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 50, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 50, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 51, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 51, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 52, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 53, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 54, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 57, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 57, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 58, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 58, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 59, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 59, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 60, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 61, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 62, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 65, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 66, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 66, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 67, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 67, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 68, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 69, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 70, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 73, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 73, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 74, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 74, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 75, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 75, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 76, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 77, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 78, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 81, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 82, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 82, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 83, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 83, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 84, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 85, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 86, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 89, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 89, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 90, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 90, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 91, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 91, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 92, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 93, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 94, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 97, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 98, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 98, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 99, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 99, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5215: Test failed: Test 0, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 0, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 0, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 1, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 1, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 2, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 2, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 3, component 0, expected 0x45843000 (4230), got 0 (0). effect.c:5215: Test failed: Test 3, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 0, expected 0x46a64000 (21280), got 0 (0). effect.c:5215: Test failed: Test 4, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 4, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 5, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 5, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 5, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 6, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 6, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 7, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 8, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 8, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 8, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 9, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 10, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 13, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 14, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 15, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 16, component 1, expected 0xc1900000 (-18), got 0 (0). effect.c:5215: Test failed: Test 18, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 19, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 20, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 21, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 23, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 24, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 25, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 26, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 29, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 30, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 31, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 32, component 1, expected 0xc0000000 (-2), got 0 (0). effect.c:5215: Test failed: Test 34, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 34, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 34, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 34, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 35, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 35, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 35, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 35, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 36, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 36, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 36, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 37, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 38, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 38, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 39, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 40, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 41, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 42, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 45, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 46, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 47, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 48, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 50, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 51, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 51, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 51, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 51, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 52, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 52, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 52, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 52, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 53, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 53, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 53, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 55, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 55, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 55, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 56, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 57, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 58, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 61, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 62, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 63, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 64, component 1, expected 0x41f00000 (30), got 0 (0). effect.c:5215: Test failed: Test 67, component 1, expected 0x40800000 (4), got 0 (0). === w1064 (64 bit effect) === effect.c:5159: Test failed: Test 0, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 0, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 1, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 1, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 1, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 2, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 2, component 1, expected 0x3f800000 (1), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 2, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 3, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 3, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 3, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 4, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 4, component 1, expected 0x448ae000 (1111), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 0, expected 0x447ac000 (1003), got 0 (0). effect.c:5159: Test failed: Test 5, component 1, expected 0x45505000 (3333), got 0x450ae000 (2222). effect.c:5159: Test failed: Test 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 6, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5159: Test failed: Test 6, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 6, component 3, expected 0x453b9000 (3001), got 0x453bc000 (3004). effect.c:5159: Test failed: Test 8, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5159: Test failed: Test 9, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5159: Test failed: Test 10, component 2, expected 0x44fa2000 (2001), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 10, component 3, expected 0 (0), got 0xc1000000 (-8). effect.c:5159: Test failed: Test 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 11, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 12, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 12, component 3, expected 0xc1400000 (-12), got 0x44fa6000 (2003). effect.c:5159: Test failed: Test 13, component 0, expected 0 (0), got 0x447b0000 (1004). effect.c:5159: Test failed: Test 13, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 13, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 14, component 0, expected 0 (0), got 0x447ac000 (1003). effect.c:5159: Test failed: Test 14, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 14, component 3, expected 0x44fa6000 (2003), got 0x457a3000 (4003). effect.c:5159: Test failed: Test 15, component 0, expected 0 (0), got 0x447a8000 (1002). effect.c:5159: Test failed: Test 16, component 0, expected 0 (0), got 0x447a4000 (1001). effect.c:5159: Test failed: Test 16, component 2, expected 0xc1200000 (-10), got 0 (0). effect.c:5159: Test failed: Test 17, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 18, component 2, expected 0x447a4000 (1001), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 18, component 3, expected 0 (0), got 0xc1c00000 (-24). effect.c:5159: Test failed: Test 19, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5159: Test failed: Test 20, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 20, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 20, component 3, expected 0x40000000 (2), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 21, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 21, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0x453bb000 (3003). effect.c:5159: Test failed: Test 22, component 1, expected 0xc5505000 (-3333), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 22, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5159: Test failed: Test 22, component 3, expected 0 (0), got 0x40400000 (3). effect.c:5159: Test failed: Test 23, component 1, expected 0xc48ae000 (-1111), got 0xc50ae000 (-2222). effect.c:5159: Test failed: Test 23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5159: Test failed: Test 23, component 3, expected 0x40400000 (3), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -100, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -100, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -99, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -98, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -95, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -94, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -94, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -93, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -93, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -92, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -91, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -90, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -87, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -87, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -86, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -86, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -85, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -85, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -84, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -83, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -82, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -79, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -78, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -78, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -77, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -77, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -76, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -75, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -74, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -71, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -71, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -70, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -70, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -69, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -69, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -68, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -67, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -66, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -63, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -62, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -62, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -61, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -61, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -60, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -59, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -58, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -55, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -55, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -54, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -54, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -53, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -53, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -52, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -51, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -50, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -47, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -46, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -46, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -45, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -45, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -44, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -43, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -42, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -39, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -39, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -38, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -38, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -37, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -37, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -36, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -35, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -34, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -31, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -30, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -30, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -29, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -29, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -28, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -27, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -26, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -23, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -23, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -22, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -22, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -21, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -21, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -20, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -19, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -18, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i -16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -15, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -14, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -14, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i -13, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i -13, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -12, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -11, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i -10, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i -8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i -8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i -7, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i -7, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i -6, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i -6, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i -5, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i -5, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i -4, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i -4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i -3, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i -2, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 0, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 1, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 2, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 2, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 3, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 3, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 4, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 4, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 5, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 6, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 8, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 8, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 9, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 9, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 10, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 10, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 11, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 11, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 12, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 12, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 13, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 14, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 16, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 17, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 18, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 18, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 19, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 19, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 20, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 20, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 21, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 22, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 24, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 24, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 25, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 25, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 26, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 26, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 27, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 27, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 28, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 28, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 29, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 30, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 32, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 33, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 34, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 34, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 35, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 35, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 36, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 36, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 37, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 38, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 40, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 40, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 41, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 41, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 42, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 42, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 43, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 43, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 44, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 44, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 45, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 46, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 48, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 49, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 50, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 50, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 51, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 51, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 52, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 52, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 53, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 54, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 56, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 56, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 57, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 57, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 58, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 58, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 59, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 59, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 60, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 60, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 61, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 62, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 64, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 65, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 66, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 66, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 67, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 67, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 68, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 68, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 69, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 70, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 72, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 72, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 73, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 73, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 74, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 74, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 75, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 75, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 76, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 76, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 77, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 78, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 80, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 81, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 82, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 82, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 83, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 83, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 84, component 2, expected 0x447a4000 (1001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 84, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 85, component 2, expected 0x3f800000 (1), got 0 (0). effect.c:5192: Test failed: i 86, component 2, expected 0xbf800000 (-1), got 0 (0). effect.c:5192: Test failed: i 88, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 88, component 3, expected 0x447a4000 (1001), got 0x44fa2000 (2001). effect.c:5192: Test failed: i 89, component 2, expected 0x44fa4000 (2002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 89, component 3, expected 0x3f800000 (1), got 0x453b9000 (3001). effect.c:5192: Test failed: i 90, component 2, expected 0x453ba000 (3002), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 90, component 3, expected 0xbf800000 (-1), got 0x447a4000 (1001). effect.c:5192: Test failed: i 91, component 2, expected 0x459c5000 (5002), got 0x40400000 (3). effect.c:5192: Test failed: i 91, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5192: Test failed: i 92, component 2, expected 0x44fa2000 (2001), got 0xc0000000 (-2). effect.c:5192: Test failed: i 92, component 3, expected 0 (0), got 0xbf800000 (-1). effect.c:5192: Test failed: i 93, component 2, expected 0x453b9000 (3001), got 0 (0). effect.c:5192: Test failed: i 94, component 2, expected 0x459c4800 (5001), got 0 (0). effect.c:5192: Test failed: i 96, component 2, expected 0 (0), got 0x457a3000 (4003). effect.c:5192: Test failed: i 97, component 2, expected 0x447a8000 (1002), got 0x45bb9800 (6003). effect.c:5192: Test failed: i 98, component 2, expected 0x40000000 (2), got 0x44fa6000 (2003). effect.c:5192: Test failed: i 98, component 3, expected 0x459c4800 (5001), got 0x447a4000 (1001). effect.c:5192: Test failed: i 99, component 2, expected 0xbf800000 (-1), got 0x40400000 (3). effect.c:5192: Test failed: i 99, component 3, expected 0 (0), got 0x3f800000 (1). effect.c:5215: Test failed: Test 0, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 0, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 0, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 1, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 1, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 2, component 0, expected 0x448d4000 (1130), got 0 (0). effect.c:5215: Test failed: Test 2, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 3, component 0, expected 0x45843000 (4230), got 0 (0). effect.c:5215: Test failed: Test 3, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 0, expected 0x46a64000 (21280), got 0 (0). effect.c:5215: Test failed: Test 4, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 4, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 4, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 5, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 5, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 5, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 6, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 6, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 7, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 8, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 8, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 8, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 9, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 10, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 13, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 14, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 15, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 16, component 1, expected 0xc1900000 (-18), got 0 (0). effect.c:5215: Test failed: Test 18, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 19, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 20, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 21, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 21, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 23, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 24, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 25, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 26, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 29, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 30, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 31, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 32, component 1, expected 0xc0000000 (-2), got 0 (0). effect.c:5215: Test failed: Test 34, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 34, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 34, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 34, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 35, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 35, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 35, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 35, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 36, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 36, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 36, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 37, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 38, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 38, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 39, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 40, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 41, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 42, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 45, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 46, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 47, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 48, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 50, component 1, expected 0x40800000 (4), got 0 (0). effect.c:5215: Test failed: Test 51, component 0, expected 0x45052000 (2130), got 0 (0). effect.c:5215: Test failed: Test 51, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 51, component 2, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 51, component 3, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 52, component 0, expected 0x467e6000 (16280), got 0 (0). effect.c:5215: Test failed: Test 52, component 1, expected 0x41400000 (12), got 0 (0). effect.c:5215: Test failed: Test 52, component 2, expected 0x447a8000 (1002), got 0 (0). effect.c:5215: Test failed: Test 52, component 3, expected 0x40000000 (2), got 0 (0). effect.c:5215: Test failed: Test 53, component 1, expected 0x447a4000 (1001), got 0 (0). effect.c:5215: Test failed: Test 53, component 2, expected 0x447ac000 (1003), got 0 (0). effect.c:5215: Test failed: Test 53, component 3, expected 0x40400000 (3), got 0 (0). effect.c:5215: Test failed: Test 55, component 1, expected 0x3f800000 (1), got 0 (0). effect.c:5215: Test failed: Test 55, component 2, expected 0x45bbd800 (6011), got 0 (0). effect.c:5215: Test failed: Test 55, component 3, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 56, component 1, expected 0x41100000 (9), got 0 (0). effect.c:5215: Test failed: Test 57, component 1, expected 0x41300000 (11), got 0 (0). effect.c:5215: Test failed: Test 58, component 1, expected 0x41600000 (14), got 0 (0). effect.c:5215: Test failed: Test 61, component 1, expected 0x40a00000 (5), got 0 (0). effect.c:5215: Test failed: Test 62, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 63, component 1, expected 0x41500000 (13), got 0 (0). effect.c:5215: Test failed: Test 64, component 1, expected 0x41f00000 (30), got 0 (0). effect.c:5215: Test failed: Test 67, component 1, expected 0x40800000 (4), got 0 (0).

2 1

Re: [8/10] wsdapi: Add stub implementation of IWSDiscoveryPublisher
by Alexandre Julliard 03 Apr '17

03 Apr '17

Owen Rudge <orudge(a)codeweavers.com> writes: > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index 913e99c..ac98522 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -89,6 +89,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "netcfgx.h" > #include "shimgdata.h" > #include "comsvcs.h" > +#include "wsdapi.h" I don't see any IWSD interfaces in the PSDK uuid library. > +static HRESULT WINAPI IWSDiscoveryPublisherImpl_Publish(IWSDiscoveryPublisher *This, LPCWSTR pszId, ULONGLONG ullMetadataVersion, ULONGLONG ullInstanceId, > + ULONGLONG ullMessageNumber, LPCWSTR pszSessionId, const WSD_NAME_LIST *pTypesList, > + const WSD_URI_LIST *pScopesList, const WSD_URI_LIST *pXAddrsList) > +{ > + FIXME("(%p, %s, %llu, %llu, %llu, %s, %p, %p, %p)\n", This, debugstr_w(pszId), ullMetadataVersion, ullInstanceId, ullMessageNumber, > + debugstr_w(pszSessionId), pTypesList, pScopesList, pXAddrsList); Please use wine_dbgstr_longlong instead of %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] wbemdisp: Add missing methods to the ISWbemObjectVtbl.
by Huw Davies 03 Apr '17

03 Apr '17

> On 3 Apr 2017, at 09:57, Huw Davies <huw(a)codeweavers.com> wrote: > > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/wbemdisp/locator.c | 285 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 284 insertions(+), 1 deletion(-) Please ignore this series. I sent it too early. Huw.

1 1

Re: maintainers: Take over the world of dmusic.
by Austin English 02 Apr '17

02 Apr '17

Signed-off-by: Austin English <austinenglish(a)gmail.com> -- -Austin GPG: 14FB D7EA A041 937B On Apr 1, 2017 4:02 PM, "André Hentschel" <nerv(a)dawncrow.de> wrote: >:) Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Am 01.04.2017 um 16:05 schrieb Michael Stefaniuc: > Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> > --- > André, this is how you properly do an Aprils Fools Day joke! > > > MAINTAINERS | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 878e210..732b898 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -91,6 +91,10 @@ DirectInput > P: Andrew Eikum <aeikum(a)codeweavers.com> > F: dlls/dinput/ > > +DirectMusic > +M: Michael Stefaniuc <mstefani(a)winehq.org> > +F: dlls/dm*/ > + > DirectPlay > M: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > F: dlls/dplayx/ >

1 0

Re: [PATCH 2/5] ddraw: Implement depth/colour fills on top of wined3d_device_clear_rendertarget_view().
by Stefan Dösinger 01 Apr '17

01 Apr '17

> Am 29.03.2017 um 22:17 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > > + struct wined3d_color colour; Out of curiosity, why is this patch introducing the British spelling of colo[u]r? The code was consistently using the American spelling before, except for a few comments / trace messages.

1 0

Re: [PATCH] usp10: Handle invalid arguments in ScriptIsComplex()
by Marvin 01 Apr '17

01 Apr '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29873 Your paranoid android. === wxppro (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 09e8:usp10: unhandled exception c0000005 at 74DA37CD === w2003std (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 05f0:usp10: unhandled exception c0000005 at 754A73F9 === wvistau64 (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 00c4:usp10: unhandled exception c0000005 at 76089892 === w2008s64 (32 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 0b54:usp10: unhandled exception c0000005 at 76729892 === wvistau64 (64 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 00c4:usp10: unhandled exception c0000005 at 000007FEFEE0119A === w2008s64 (64 bit usp10) === usp10.c:3938: Test failed: got 0x00000001 07ec:usp10: unhandled exception c0000005 at 000007FEFD9F119A

1 0

Re: [PATCH] wmvcore: Add WMReader stubs.
by Alistair Leslie-Hughes 31 Mar '17

31 Mar '17

Hi Jefferson, On 30/03/17 10:18, Jefferson Carpenter wrote: > > I have not written unit tests for this code. I would like to add some > wmvcore tests, but am not very familiar with Wine's build system > autotools, and have not been able to get tests to compile and run. > I have a basic patch for adding tests in the works, but I was waiting for my IDL changes to be accepted first. So, If someone wants to review the IDL changes, Since Sebastian has been busy with other stuff. https://source.winehq.org/patches/data/131403 > > Signed-off-by: Jefferson Carpenter > --- > dlls/wmvcore/wmvcore_main.c | 1234 +++++++++++++++++++++++++++++++++++++++++++ > +static HRESULT WINAPI WMHeaderInfo_GetScriptCount(IWMHeaderInfo3 *iface, WORD *pcScripts) > +{ > + WMReader *This = impl_from_IWMHeaderInfo3(iface); > + FIXME("(%p)->(WMHeaderInfo_GetScriptCount)\n", This); This is incorrect. The FIXME will insert the function name into the logs. You need to specify each parameter in the FIXME, there are plenty of examples of how to do this. Best Regards Alistair Leslie-Hughes

3 3

Re: [PATCH 2/2] regedit: Handle comment lines with leading spaces and tabs
by Alexandre Julliard 31 Mar '17

31 Mar '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/regproc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c > index 131149f..bce551b 100644 > --- a/programs/regedit/regproc.c > +++ b/programs/regedit/regproc.c > @@ -749,6 +749,7 @@ static char *get_lineA(FILE *fp) > next = line; > continue; > } > + while (*line == ' ' || *line == '\t') line++; > if (*line == ';' || *line == '#') > { > line = next; This is going to affect non-comment lines too, is that what you want? If so, the commit message is a bit misleading. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 04/13] msvcrt: Add CurrentScheduler class stub
by Gijs Vermeulen 31 Mar '17

31 Mar '17

Hi, I'm sorry if this is a stupid question. But shouldn't this also change: ?_Get@_CurrentScheduler@details@Concurrency@@SA?AV_Scheduler@23@XZ ?_GetNumberOfVirtualProcessors@_CurrentScheduler@details@Concurrency@@SAIXZ ?_Id@_CurrentScheduler@details@Concurrency@@SAIXZ -arch=win32 ?_ScheduleTask@_CurrentScheduler@details@Concurrency@ @SAXP6AXPAX@Z0@Z -arch=win64 ?_ScheduleTask@_CurrentScheduler@details@Concurrency@ @SAXP6AXPEAX@Z0@Z Or do these not do the same? Sorry if I'm wasting your time. Sincerely, Gijs 2017-03-30 22:47 GMT+02:00 Piotr Caban <piotr(a)codeweavers.com>: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/concrt140/concrt140.spec | 40 ++++++++--------- > dlls/msvcr100/msvcr100.spec | 28 ++++++------ > dlls/msvcr110/msvcr110.spec | 40 ++++++++--------- > dlls/msvcr120/msvcr120.spec | 40 ++++++++--------- > dlls/msvcr120_app/msvcr120_app.spec | 40 ++++++++--------- > dlls/msvcrt/scheduler.c | 88 ++++++++++++++++++++++++++++++ > +++++++ > 6 files changed, 182 insertions(+), 94 deletions(-) > > > > > >

2 1

Re: d3d10: sync spec file to Windows 10
by Henri Verbeet 30 Mar '17

30 Mar '17

On 29 March 2017 at 23:51, Austin English <austinenglish(a)gmail.com> wrote: > -- We may not necessarily care, but RevertToOldImplementation() is the first export instead of the last on my Windows 10.

3 3

Re: [2/3] windowscodecs: Test for png codec seeking too far
by Vincent Povirk 30 Mar '17

30 Mar '17

Is there a reason to switch to SHCreateMemStream to do this test in particular? If not, it would probably make more sense as a separate cleanup project. On Mon, Mar 27, 2017 at 3:09 PM, Viktor Semykin <thesame.ml(a)gmail.com> wrote: > Signed-off-by: Viktor Semykin <thesame.ml(a)gmail.com> > --- > dlls/windowscodecs/tests/Makefile.in | 2 +- > dlls/windowscodecs/tests/pngformat.c | 19 ++++++++++--------- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/tests/Makefile.in b/dlls/windowscodecs/tests/Makefile.in > index e11d184..e006e3d 100644 > --- a/dlls/windowscodecs/tests/Makefile.in > +++ b/dlls/windowscodecs/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = windowscodecs.dll > -IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 > +IMPORTS = windowscodecs oleaut32 ole32 user32 gdi32 shlwapi > > C_SRCS = \ > bitmap.c \ > diff --git a/dlls/windowscodecs/tests/pngformat.c b/dlls/windowscodecs/tests/pngformat.c > index 34cb533..20b6e93 100644 > --- a/dlls/windowscodecs/tests/pngformat.c > +++ b/dlls/windowscodecs/tests/pngformat.c > @@ -25,6 +25,7 @@ > #include "windef.h" > #include "wincodec.h" > #include "wine/test.h" > +#include "shlwapi.h" > > /* 1x1 pixel PNG image */ > static const char png_no_color_profile[] = { > @@ -277,21 +278,16 @@ static IWICImagingFactory *factory; > > static IWICBitmapDecoder *create_decoder(const void *image_data, UINT image_size) > { > - HGLOBAL hmem; > - BYTE *data; > HRESULT hr; > IWICBitmapDecoder *decoder = NULL; > IStream *stream; > GUID format; > LONG refcount; > + ULARGE_INTEGER pos; > + LARGE_INTEGER zero; > > - hmem = GlobalAlloc(0, image_size); > - data = GlobalLock(hmem); > - memcpy(data, image_data, image_size); > - GlobalUnlock(hmem); > - > - hr = CreateStreamOnHGlobal(hmem, TRUE, &stream); > - ok(hr == S_OK, "CreateStreamOnHGlobal error %#x\n", hr); > + stream = SHCreateMemStream (image_data, image_size); > + ok(stream != NULL, "SHCreateMemStream error\n"); > > hr = IWICImagingFactory_CreateDecoderFromStream(factory, stream, NULL, 0, &decoder); > ok(hr == S_OK, "CreateDecoderFromStream error %#x\n", hr); > @@ -302,6 +298,11 @@ static IWICBitmapDecoder *create_decoder(const void *image_data, UINT image_size > ok(IsEqualGUID(&format, &GUID_ContainerFormatPng), > "wrong container format %s\n", wine_dbgstr_guid(&format)); > > + zero.QuadPart = 0; > + IStream_Seek (stream, zero, STREAM_SEEK_CUR, &pos); > + todo_wine ok(pos.QuadPart < image_size, "seek beyond the end of stream: %lu >= %u\n", > + pos.QuadPart, image_size); > + > refcount = IStream_Release(stream); > ok(refcount > 0, "expected stream refcount > 0\n"); > > -- > 2.12.1 > > >

2 3

Re: [PATCH 3/3] shlwapi/tests: A test to query ISequentialStream from memory stream
by Marvin 30 Mar '17

30 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29831 Your paranoid android. === wxppro (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 09f0:istream: unhandled exception c0000005 at 00405AEC === w2003std (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 05f0:istream: unhandled exception c0000005 at 00405AEC

1 0

Re: [PATCH 2/3] shlwapi: Fix QueryInterface for file-based streams
by Marvin 30 Mar '17

30 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29830 Your paranoid android. === wxppro (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 09ec:istream: unhandled exception c0000005 at 00405AEC === w2003std (32 bit istream) === istream.c:44: Test failed: got 0x80004002 istream.c:45: Test failed: unexpected interface pointer 05f0:istream: unhandled exception c0000005 at 00405AEC

1 0

Re: [PATCH] wmvcore: Add WMReader stubs.
by Alistair Leslie-Hughes 30 Mar '17

30 Mar '17

Hi Jefferson, On 30/03/17 10:18, Jefferson Carpenter wrote: > > I have not written unit tests for this code. I would like to add some > wmvcore tests, but am not very familiar with Wine's build system > autotools, and have not been able to get tests to compile and run. > I have a basic patch for adding tests in the works, but I was waiting for my IDL changes to be accepted first. So, If someone wants to review the IDL changes, Since Sebastian has been busy with other stuff. https://source.winehq.org/patches/data/131403 > > Signed-off-by: Jefferson Carpenter > --- > dlls/wmvcore/wmvcore_main.c | 1234 +++++++++++++++++++++++++++++++++++++++++++ > +static HRESULT WINAPI WMHeaderInfo_GetScriptCount(IWMHeaderInfo3 *iface, WORD *pcScripts) > +{ > + WMReader *This = impl_from_IWMHeaderInfo3(iface); > + FIXME("(%p)->(WMHeaderInfo_GetScriptCount)\n", This); This is incorrect. The FIXME will insert the function name into the logs. You need to specify each parameter in the FIXME, there are plenty of examples of how to do this. Best Regards Alistair Leslie-Hughes

1 0

Re: dpnaddr: sync spec file to Windows 10
by Alistair Leslie-Hughes 30 Mar '17

30 Mar '17

On 30/03/17 08:51, Austin English wrote: > > > You appear to be comparing the stub version of this DLL. (It would be about 8k in size, the real version is larger). Same goes for dpnlobby. Best Regards Alistair Leslie-Hughes

1 0

Darren Stevens II -- Outreachy Internship
by Darren M. Stevens II 30 Mar '17

30 Mar '17

Hello, my name is Darren and I'm a computer science major at the University of Maryland Baltimore County. I've never worked in open source software before, but the idea of letting windows apps run for linux sounds appealing, especially for games. Though it's my first time in open source, I have some experience in C. Looking at the project list, the graphical user interface seems to be the most interesting, but I'm also interested in the resource and dialog editor since I'd like to get some UI experience. I've also worked in html, php, and mysql before, so improving the AppDB website also interests me. If pressed, I'd prefer to work with the gui and learn about what goes into making one. I look forward to potentially working with you all more during the summer. Thank you for your time, -- --------------------------------------------- Darren Stevens II Meyerhoff Scholar [M25] Computer Science (Game Design Track) Major University of Maryland Baltimore County (UMBC)

2 1

Packaging related changes
by Michael Müller 29 Mar '17

29 Mar '17

Hi everyone, I would like to announce some very important build server / packaging related changes that will take effect with the next release. As most of you should know, Sebastian and I took care of the Wine Development and Staging builds for more than a year now. So far we were using a collection of scripts which were run on a dedicated machine to build and upload the packages. This solution did not scale very well, so we decided to rework the whole build system. The new system can not only be controlled using a command line utility but also provides an easy to use website which gives us the possibility to provide some great new features. Interested Wine developers will be able to request access to the system so that they can start their own builds. This can for example be used to provide a patched Wine version for testing in a bug report or to verify that a patch is compatible with all platforms and compilers. Nevertheless, in this mail I would like to concentrate on the user related changes. The developer related features need some further polishing and will be announced in a separate mail. Starting with the next release, we will use our new build server to compile the packages, leading to the following differences: ====================================================================== Launchpad is no longer used for the Ubuntu builds ------------------------------------------------- In order to provide the possibility for Wine developers to create their own builds through our system, we had to move away from Launchpad. This will also have the advantage that we can provide older builds (see below). The disadvantage of this change is that our users will have to manually switch from the PPA to the new repository, since there is no way to push prebuilt Debian/Ubuntu packages into a PPA on Launchpad (not even with a commercial subscription). We already added the new Ubuntu repository to the CDN, so that users can start switching by now and don't have to wait till the next release. The repository can be added using the following commands: wget https://dl.winehq.org/wine-builds/Release.key sudo apt-key add Release.key sudo apt-add-repository 'https://dl.winehq.org/wine-builds/ubuntu/' To make sure that all users will be informed about this change, I will push at least one additional update (Wine 2.5) to the PPA that displays a warning during the package upgrade containing the necessary instructions (I hope this also works on Ubuntu, I have only tested it on Debian so far). This means users will have at least two weeks to switch from the PPA to the new repository - maybe a bit more if we push additional builds. Old packages for Ubuntu / Debian -------------------------------- On the last build server we used reprepo to generate the Debian repositories. One disadvantage of the tool is that it does not support multiple versions of a package. We tried several other tools, but they did not fit our needs, so I ended up writing my own tool that does not have this limitation. This will make it easy to download and test old versions of Wine when using the new repository. There are some small packaging changes left, but in the future you will be able to tell apt-get which version you would like to install using: sudo apt-get install winehq-devel=2.4.0-1~stretch You can get a list of all available versions with: apt-cache policy winehq-devel Notes: * The "-1~stretch" part is used for the packaging. * The additional ".0" version component is added for technical reasons, to ensure package managers can determine which version is the latest one. Wine Stable is now available as package --------------------------------------- We will start providing builds for Wine Stable, which will be called "winehq-stable". This is actually a change we have planned for quite some time now, but all the manual steps involved in the old build system and the limited resources blocked us from doing this change earlier. Added / removed distros ----------------------- The following distros have been removed as they are no longer supported or reach their EOL within the next month: * Ubuntu Precise * Fedora 23 * Mageia 4 One new distro has been added: * Fedora 25 We had to temporarily disable the building of packages for Mageia 5. The problem is that the tool used for generating the repository files is not very compatible with other distros and I did not find a working combination of genhdlist2, URPM and librpm that works on Debian without any warnings or errors. We therefore decided to pause the builds until we made sure that we can provide a fully working repository. repos.wine-staging.com changes ------------------------------ This only affects users who are still getting their packages from repos.wine-staging.com. So far we were providing two repositories, the original one at repos.wine-staging.com and the new one at dl.winehq.org. We wanted to get rid of the original one for quite some time now, since both repositories basically contain the same packages. We decided that it is now the perfect time to make this step. In order to receive further updates, those users will have to switch to the dl.winehq.org repository by following the normal installation instructions. We will also post an announcement on the wine-staging.com website to make all users aware of this change. ====================================================================== As you can see there are plenty of changes, and there are even more developer related changes ahead. Although we would like to avoid any inconvenience, there is some manual work involved for some of our users. Ubuntu users will have to switch to the WineHQ repository, and repos.wine-staging.com users will have to update repository paths for all distributions. Nevertheless, we believe that these changes are very useful and will make things much easier in the long term. Regards, Michael

5 5

Re: [PATCH 10/10] xmllite/tests: Added tests for returned string pointers.
by Marvin 29 Mar '17

29 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29805 Your paranoid android. === wxppro (32 bit reader) === reader.c:2517: Test failed: ns != value reader.c:2549: Test failed: xmlns_name != prefix reader.c:2555: Test failed: xmlns_name != prefix reader.c:2560: Test failed: p != prefix reader.c:2561: Test failed: empty != namespace reader.c:2566: Test failed: q != prefix reader.c:2567: Test failed: nsq != namespace reader.c:2570: Test failed: q == qname reader.c:2597: Test failed: ns+1 != p === w2003std (32 bit reader) === reader.c:2517: Test failed: ns != value reader.c:2549: Test failed: xmlns_name != prefix reader.c:2555: Test failed: xmlns_name != prefix reader.c:2560: Test failed: p != prefix reader.c:2561: Test failed: empty != namespace reader.c:2566: Test failed: q != prefix reader.c:2567: Test failed: nsq != namespace reader.c:2570: Test failed: q == qname reader.c:2597: Test failed: ns+1 != p

1 0

Re: [PATCH 3/9] xmllite: Merge reader_lookup_ns and reader_lookup_nsdef implementations.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/xmllite/reader.c | 53 > +++++++++++++++++++++------------------------------ > 1 file changed, 22 insertions(+), 31 deletions(-) This fails here: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok wine: Unhandled page fault on read access to 0x00000014 at address 0x7e05d1a7 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000014 in 32-bit code (0x7e05d1a7). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7e05d1a7 ESP:0033f4e0 EBP:0033f518 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:00000005 ECX:0013dbf8 EDX:0013dc08 ESI:0013dba8 EDI:0033f4f8 Stack dump: 0x0033f4e0: 0013dba8 00000000 0033f4f8 0033f5ac 0x0033f4f0: 7e09dfe8 7e06d000 0033f518 00000005 0x0033f500: 0013d8b8 7e05d136 0033f530 7e0a7000 0x0033f510: 0013dba8 00008454 0033f5c8 7e08f52d 0x0033f520: 0013d8b8 00000001 7e085061 7e08f52d 0x0033f530: 0013dba8 0033f5ac 00000000 00000000 Backtrace: =>0 0x7e05d1a7 xmlreader_GetValue+0x87(iface=<couldn't compute location>, value=<couldn't compute location>, len=<couldn't compute location>) [/home/julliard/wine/wine/dlls/xmllite/reader.c:3301] in xmllite (0x0033f518) 1 0x7e08f52d TaskDefinition_put_XmlText+0x4fc(iface=<couldn't compute location>, xml=<couldn't compute location>) [/home/julliard/wine/wine/dlls/taskschd/../../include/xmllite.h:366] in taskschd (0x0033f5c8) 2 0x7e08655d TaskFolder_RegisterTask+0xdc(iface=<couldn't compute location>, name=<couldn't compute location>, xml=<couldn't compute location>, flags=<couldn't compute location>, user={n1={n2={vt=0x1, wReserved1=0x11, wReserved2=0xd7e6, wReserved3=0x7bc3, n3={cVal=-16, uiVal=0xf7f0, ulVal=0x33f7f0, intVal=0x33f7f0, uintVal=0x33f7f0, bVal=-16, iVal=0xfffff7f0, lVal=0x33f7f0, fltVal=0.000000, dblVal=1511150729130819689735093992150912839369984728108261507947203237810152168316886087549523621236115883856409333081269449041715263251744478647635819958016247928527492445059748209219694759120105362131911873167308517643014354124272586209814321930163516051621612695826549010655565890397283549184.000000, boolVal=0xfffff7f0, scode=0x33f7f0, date=1511150729130819689735093992150912839369984728108261507947203237810152168316886087549523621236115883856409333081269449041715263251744478647635819958016247928527492445059748209219694759120105362131911873167308517643014354124272586209814321930163516051621612695826549010655565890397283549184.000000, bstrVal="`?????`??3≥?", cyVal={={Lo=0x33f7f0, Hi=0x7bc3d926}, int64=0x7bc3d9260033f7f0}, punkVal=0x33f7f0, pdispVal=0x33f7f0, parray=0x33f7f0, llVal=0x7bc3d9260033f7f0, ullVal=0x7bc3d9260033f7f0, pcVal="`", puiVal="`?????`??3≥?", pulVal=0x33f7f0, pintVal=0x33f7f0, puintVal=0x33f7f0, pbVal="`", piVal=0x33f7f0, plVal=0x33f7f0, pfltVal=0x33f7f0, pdblVal=0x33f7f0, pboolVal=0x33f7f0, pscode=0x33f7f0, pdate=0x33f7f0, pbstrVal=0x33f7f0, pvarVal=0x33f7f0, byref=0x33f7f0, pcyVal=0x33f7f0, pdecVal=0x33f7f0, ppunkVal=0x33f7f0, ppdispVal=0x33f7f0, pparray=0x33f7f0, pllVal=0x33f7f0, pullVal=0x33f7f0, brecVal={pvRecord=0x33f7f0, pRecInfo=0x7bc3d926}}}, decVal={wReserved=0x1, ={={scale=17, sign=0}, signscale=0x11}, Hi32=0x7bc3d7e6, ={={Lo32=0x33f7f0, Mid32=0x7bc3d926}, Lo64=0x7bc3d9260033f7f0}}}}, password={n1={n2={vt=0x1, wReserved1=0x33, wReserved2=0xd7e6, wReserved3=0x7bc3, n3={cVal=0, uiVal=0xf800, ulVal=0x33f800, intVal=0x33f800, uintVal=0x33f800, bVal=0, iVal=0xfffff800, lVal=0x33f800, fltVal=0.000000, dblVal=1511150729130824017523893055520610957737502764212302110344498125717661440571014434062133365926164698282569564768952682214359048014142616051827027404016169084942804013460762242723410078969754872380504678452713624017530338190327992990462096150957280615769007395389364412955620604666965917696.000000, boolVal=0xfffff800, scode=0x33f800, date=1511150729130824017523893055520610957737502764212302110344498125717661440571014434062133365926164698282569564768952682214359048014142616051827027404016169084942804013460762242723410078969754872380504678452713624017530338190327992990462096150957280615769007395389364412955620604666965917696.000000, bstrVal="`??3≥?", cyVal={={Lo=0x33f800, Hi=0x7bc3d926}, int64=0x7bc3d9260033f800}, punkVal=0x33f800, pdispVal=0x33f800, parray=0x33f800, llVal=0x7bc3d9260033f800, ullVal=0x7bc3d9260033f800, pcVal="`", puiVal="`??3≥?", pulVal=0x33f800, pintVal=0x33f800, puintVal=0x33f800, pbVal="`", piVal=0x33f800, plVal=0x33f800, pfltVal=0x33f800, pdblVal=0x33f800, pboolVal=0x33f800, pscode=0x33f800, pdate=0x33f800, pbstrVal=0x33f800, pvarVal=0x33f800, byref=0x33f800, pcyVal=0x33f800, pdecVal=0x33f800, ppunkVal=0x33f800, ppdispVal=0x33f800, pparray=0x33f800, pllVal=0x33f800, pullVal=0x33f800, brecVal={pvRecord=0x33f800, pRecInfo=0x7bc3d926}}}, decVal={wReserved=0x1, ={={scale='3', sign=0}, signscale=0x33}, Hi32=0x7bc3d7e6, ={={Lo32=0x33f800, Mid32=0x7bc3d926}, Lo64=0x7bc3d9260033f800}}}}, logon=<couldn't compute location>, sddl={n1={n2={vt=0x1, wReserved1=0x33, wReserved2=0x9000, wReserved3=0x7bcd, n3={cVal='X', uiVal=0xf858, ulVal=0x33f858, intVal=0x33f858, uintVal=0x33f858, bVal='X', iVal=0xfffff858, lVal=0x33f858, fltVal=0.000000, dblVal=1599434225947997951839798187977314197247957319428824144722608502103490780437150503599313505255422560087677850314482444820949235532773538977575659441663949722412271782696123659963005719660434825558687050651416890927056302450102863675852450005771357260534626948999518468080309345769339486208.000000, boolVal=0xfffff858, scode=0x33f858, date=1599434225947997951839798187977314197247957319428824144722608502103490780437150503599313505255422560087677850314482444820949235532773538977575659441663949722412271782696123659963005719660434825558687050651416890927056302450102863675852450005771357260534626948999518468080309345769339486208.000000, bstrVal="?3????????", cyVal={={Lo=0x33f858, Hi=0x7bc501ff}, int64=0x7bc501ff0033f858}, punkVal=0x33f858, pdispVal=0x33f858, parray=0x33f858, llVal=0x7bc501ff0033f858, ullVal=0x7bc501ff0033f858, pcVal="ê°3", puiVal="?3????????", pulVal=0x33f858, pintVal=0x33f858, puintVal=0x33f858, pbVal="ê°3", piVal=0x33f858, plVal=0x33f858, pfltVal=0x33f858, pdblVal=0x33f858, pboolVal=0x33f858, pscode=0x33f858, pdate=0x33f858, pbstrVal=0x33f858, pvarVal=0x33f858, byref=0x33f858, pcyVal=0x33f858, pdecVal=0x33f858, ppunkVal=0x33f858, ppdispVal=0x33f858, pparray=0x33f858, pllVal=0x33f858, pullVal=0x33f858, brecVal={pvRecord=0x33f858, pRecInfo=0x7bc501ff}}}, decVal={wReserved=0x1, ={={scale='3', sign=0}, signscale=0x33}, Hi32=0x7bcd9000, ={={Lo32=0x33f858, Mid32=0x7bc501ff}, Lo64=0x7bc501ff0033f858}}}}, task=<couldn't compute location>) [/home/julliard/wine/wine/dlls/taskschd/../../include/taskschd.h:2719] in taskschd (0x0033f668) 3 0x7ed666c6 test_GetTask+0x385() [/home/julliard/wine/wine/dlls/taskschd/tests/../../../include/taskschd.h:2140] in taskschd_test (0x0033fd18) 4 0x7ed6bd20 func_scheduler+0x2f() [/home/julliard/wine/wine/dlls/taskschd/tests/scheduler.c:1488] in taskschd_test (0x0033fd28) 5 0x7ed6bf56 run_test+0x115(name=<is not available>) [/home/julliard/wine/wine/dlls/taskschd/tests/../../../include/wine/test.h:589] in taskschd_test (0x0033fd58) 6 0x7ed63c5b main+0x14a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/taskschd/tests/../../../include/wine/test.h:673] in taskschd_test (0x0033fe08) 7 0x7ed6c95b __wine_spec_exe_entry+0x4a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in taskschd_test (0x0033fe48) 8 0x7b45e5cc call_process_entry+0xb() in kernel32 (0x0033fe68) 9 0x7b45f509 start_process+0x68(entry=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1116] in kernel32 (0x0033fea8) 10 0x7bc80aac call_thread_func_wrapper+0xb() in ntdll (0x0033fec8) 11 0x7bc83869 call_thread_func+0xa8(entry=0x7b45f4a0, arg=0x7ed6c910, frame=0x33ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2759] in ntdll (0x0033ffa8) 12 0x7bc80a8a call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 13 0x7bc540f3 start_process+0x12(arg=0xffb0e178) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3054] in ntdll (0x0033ffe8) 14 0xf755a8dd __x86.get_pc_thunk.di+0x2a() in libwine.so.1 (0x00000000) 15 0xf755aa40 wine_switch_to_stack+0x1f(func=0x7bc540e0, arg=0xffb0e178, stack=0x340000) [/home/julliard/wine/wine/libs/wine/port.c:77] in libwine.so.1 (0xffb0e148) 16 0x7bc59ca6 LdrInitializeThunk+0x235(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:3115] in ntdll (0xffb0e198) 17 0x7b46540f __wine_kernel_init+0xa4e() [/home/julliard/wine/wine/dlls/kernel32/process.c:1310] in kernel32 (0xffb0f088) 18 0x7bc5ab03 __wine_process_init+0x152() [/home/julliard/wine/wine/dlls/ntdll/loader.c:3324] in ntdll (0xffb0f0f8) 19 0xf7558b43 wine_init+0x2a2(argc=0x3, argv=0xffb0f644, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:956] in libwine.so.1 (0xffb0f148) 20 0x7c000b58 main+0x97(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:254] in <wine-loader> (0xffb0f598) 21 0xf7362276 __libc_start_main+0xf5() in libc.so.6 (0x00000000) 0x7e05d1a7 xmlreader_GetValue+0x87 [/home/julliard/wine/wine/dlls/xmllite/reader.c:3301] in xmllite: movl 0x14(%eax),%edx -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] user32: Store the item rects as relative to the items_rect.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Huw Davies <huw(a)codeweavers.com> writes: > Signed-off-by: Huw Davies <huw(a)codeweavers.com> > --- > dlls/user32/menu.c | 68 ++++++++++++++++++++++++++---------------------------- > 1 file changed, 33 insertions(+), 35 deletions(-) This fails here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:1104: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203) win.c:1111: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300) win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150) ... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [v2 2/2] d3dx9/tests: Add more tests for preshader relative addressing.
by Matteo Bruni 28 Mar '17

28 Mar '17

2017-03-24 23:12 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Again, I'd separate the update of the test effect blob and the existing test from the addition of a new test. Aside from that, I just had a quick glance. expected_light_specular_2[] doesn't seem like a good name, you can call that "test_light_specular_2" or similar and rename its "result" field "expected" (i.e. always calling the table driving the test "test_something" is nice and consistent, as is calling the array with expected results "expected").

1 0

Re: [PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_ns.
by Nikolay Sivov 28 Mar '17

28 Mar '17

On 28.03.2017 17:44, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------ > 1 file changed, 27 insertions(+), 6 deletions(-) > > > +static struct ns default_ns = { > + { emptyW }, > + { emptyW } > }; > I think this could use a better name. Default namespace is something defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match empty strings naming. Also everything static in this patch should be also const, no?

2 1

Re: [v2 PATCH] ole32: Add CoRegisterSurrogate/Ex stubs
by Huw Davies 28 Mar '17

28 Mar '17

On Mon, Mar 27, 2017 at 10:12:11PM +0000, Alistair Leslie-Hughes wrote: > v2 - Removed CoRegisterSurrogateEx from header > - Minor formatting changes > - Return E_NOTIMPL > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ole32/compobj.c | 20 ++++++++++++++++++++ > dlls/ole32/ole32.spec | 4 ++-- > 2 files changed, 22 insertions(+), 2 deletions(-) Looks good. I've sent in a new version having run make_specfiles. Huw.

1 0

Re: [3/3] windowscodecs: Fixed loading png from streams
by Marvin 28 Mar '17

28 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29747 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] windowscodecs: Test for png codec seeking too far
by Marvin 28 Mar '17

28 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29746 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v4 6/7] user32/tests: Workaround an intermittent failure.
by Marvin 27 Mar '17

27 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29730 Your paranoid android. === w7pro64 (64 bit msg) === msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:12609: Test failed: 54: ShowWindow(SW_MINIMIZE): 7: the msg sequence is not complete: expected 0000 - actual 0005

1 0

[1/3] shlwapi: SHCreateMemStream added to shlwapi.h
by Viktor Semykin 27 Mar '17

27 Mar '17

Where it belongs according to its documentation. Signed-off-by: Viktor Semykin <thesame.ml(a)gmail.com> --- include/shlwapi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/shlwapi.h b/include/shlwapi.h index 2c68b7f..c19ca31 100644 --- a/include/shlwapi.h +++ b/include/shlwapi.h @@ -978,6 +978,7 @@ HRESULT WINAPI SHCreateStreamOnFileA(LPCSTR,DWORD,struct IStream**); HRESULT WINAPI SHCreateStreamOnFileW(LPCWSTR,DWORD,struct IStream**); #define SHCreateStreamOnFile WINELIB_NAME_AW(SHCreateStreamOnFile) +struct IStream * WINAPI SHCreateMemStream(const BYTE *lpbData, UINT dwDataLen); HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR,DWORD,DWORD,BOOL,struct IStream*,struct IStream**); HRESULT WINAPI SHCreateStreamWrapper(LPBYTE,DWORD,DWORD,struct IStream**); -- 2.12.1

1 2

Re: [PATCH v4 4/7] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin 27 Mar '17

27 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29728 Your paranoid android. === w7u (32 bit msg) === msg.c:5084: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088

1 0

Re: [2/3] windowscodecs: Test for png codec seeking too far
by Vincent Povirk 27 Mar '17

27 Mar '17

Does this test fail on Wine without patch 3? If it fails, you should add a todo_wine to the failing test, and remove it when the test is fixed.

2 1

Re: [PATCH 2/2 v2] devenum: Implement IMoniker::IsEqual().
by Andrew Eikum 27 Mar '17

27 Mar '17

Thanks, just a couple more tweaks. On Mon, Mar 27, 2017 at 10:57:36PM +0800, Jactry Zeng wrote: > diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c > index e3c0f47256..b6275be8d2 100644 > --- a/dlls/devenum/tests/devenum.c > +++ b/dlls/devenum/tests/devenum.c > @@ -135,6 +135,94 @@ static void test_devenum(IBindCtx *bind_ctx) > if(sizeof(void*) == 4) > ok(have_mrle, "mrle codec not found\n"); > } > +static void test_moniker_isequal(void) > +{ > + HRESULT res; > + ICreateDevEnum *create_devenum = NULL; > + IEnumMoniker *enum_moniker0 = NULL, *enum_moniker1 = NULL; > + IMoniker *moniker0 = NULL, *moniker1 = NULL; > + > + res = CoCreateInstance(&CLSID_SystemDeviceEnum, NULL, CLSCTX_INPROC, > + &IID_ICreateDevEnum, (LPVOID*)&create_devenum); > + if (res) Please use FAILED() here. > + if (SUCCEEDED(IEnumMoniker_Next(enum_moniker0, 1, &moniker0, NULL)) && > + SUCCEEDED(IEnumMoniker_Next(enum_moniker1, 1, &moniker1, NULL))) > + { > + res = IMoniker_IsEqual(moniker0, moniker1); > + ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res); > + > + res = IMoniker_IsEqual(moniker1, moniker0); > + ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res); These should be compared against S_OK, otherwise S_FALSE will also pass the test. Andrew

2 1

Re: [PATCH 2/2] devenum: Implement IMoniker::IsEqual().
by Andrew Eikum 27 Mar '17

27 Mar '17

On Sun, Mar 26, 2017 at 04:31:55PM +0800, Jactry Zeng wrote: > + res = ICreateDevEnum_CreateClassEnumerator(create_devenum, &CLSID_LegacyAmFilterCategory, &enum_moniker0, 0); > + ok(SUCCEEDED(res), "Cannot create enum moniker (res = %x)\n", res); > + res = ICreateDevEnum_CreateClassEnumerator(create_devenum, &CLSID_LegacyAmFilterCategory, &enum_moniker1, 0); > + ok(SUCCEEDED(res), "Cannot create enum moniker (res = %x)\n", res); > + if (!res) > + { > + if (!IEnumMoniker_Next(enum_moniker0, 1, &moniker0, NULL) && !IEnumMoniker_Next(enum_moniker1, 1, &moniker1, NULL)) > + { > + res = IMoniker_IsEqual(moniker0, moniker1); > + ok(!res, "IMoniker_IsEqual should failed (res = %x)\n", res); > + > + res = IMoniker_IsEqual(moniker1, moniker0); > + ok(!res, "IMoniker_IsEqual should failed (res = %x)\n", res); > + > + IMoniker_Release(moniker0); > + IMoniker_Release(moniker1); > + } These patches look fine to me except the ok() message is wrong on these two. Also, I think it's easier to read code that explicitly compares against S_OK or uses SUCCEEDED() instead of using !. Andrew

2 1

Re: iphlpapi: Implement GetUnicastIpAddressTable (try 2)
by Hans Leidekker 27 Mar '17

27 Mar '17

> +DWORD WINAPI GetUnicastIpAddressTable(ADDRESS_FAMILY family, MIB_UNICASTIPADDRESS_TABLE **table) > +{ > + IP_ADAPTER_ADDRESSES *aa, *ptr; > + MIB_UNICASTIPADDRESS_TABLE *data; > + DWORD ret, count = 0; > + ULONG size; > + > + TRACE("%u, %p\n", family, table); > + > + if (!table || (family != WS_AF_INET && family != WS_AF_INET6 && family != WS_AF_UNSPEC)) > + return ERROR_INVALID_PARAMETER; > + > + ret = GetAdaptersAddresses(family, 0, NULL, NULL, &size); You should pass GAA_FLAG_SKIP_* flags here to exclude any data that will not be used.

2 1

Wine | Bug Query
by Akarsha Sehwag 27 Mar '17

27 Mar '17

Hi I started with the bug( https://bugs.winehq.org/show_bug.cgi?id=39640 ). As of what I understood, I am writing it below. Kindly correct me wherever I go wrong. To implement ProcessPage_OnEndProcessTree() correctly we need to kill all its children and grandchildren also. So for that purpose, we need to iterate through all the active processes and check if their parent process is same as the process we wish to terminate. If yes, we kill them, if no, we continue our iteration. Now, for implementing this, can we use 'ps' or 'top' command. An example code: char string[30] = "ps -o pid --ppid "; char ppid[7]; sprintf(ppid , "%d" , getpid() ) ; strcat ( string , ppid ) ; system ( string ) ; ps -o pid --ppid <parent_Id> will give us the pid of all the child_processes whose parent has a PID. And now, get the parentProcess's PID by getpid(). Next, convert the integer into string and concatenate the result with string to get the final command which is then executed by system(string). Kindly tell me if I am anywhere near the right solution and also guide me how to proceed. Thanks :) Regards -- Akarsha Sehwag

3 2

Re: [PATCH v3 1/6] user32: Move internal message from EnableWindow() to WIN_SetStyle().
by Alexandre Julliard 27 Mar '17

27 Mar '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > The capture is already killed by handling WM_CANCELMODE, as in Windows. This should be a separate change, with its own tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: Add CoRegisterSurrogate/Ex stubs
by Huw Davies 27 Mar '17

27 Mar '17

On Mon, Mar 27, 2017 at 04:29:24AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > diff --git a/include/objbase.h b/include/objbase.h > index 875f0e1..8f89389 100644 > --- a/include/objbase.h > +++ b/include/objbase.h > @@ -331,6 +331,7 @@ HRESULT WINAPI CoRevokeClassObject(DWORD dwRegister); > HRESULT WINAPI CoGetPSClsid(REFIID riid,CLSID *pclsid); > HRESULT WINAPI CoRegisterPSClsid(REFIID riid, REFCLSID rclsid); > HRESULT WINAPI CoRegisterSurrogate(LPSURROGATE pSurrogate); > +HRESULT WINAPI CoRegisterSurrogateEx(REFGUID guid, void *reserved); I don't see this in my Windows 10 SDK. Where does it come from? Huw.

2 2

Re: [v2 PATCH] oledb32/tests: Add convert to DBTYPE_NUMERIC tests
by Huw Davies 27 Mar '17

27 Mar '17

On Sun, Mar 26, 2017 at 10:14:00PM +0000, Alistair Leslie-Hughes wrote: > v2 > - Added VT_NULL test > - Use result variables for each test. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> convert.c:3349: Test succeeded inside todo block: got 00000000 convert.c:3350: Test succeeded inside todo block: got 00000003 I've fixed these, removed the unnecessary src array, and resent. Huw.

1 0

Re: [PATCH v3 3/6] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin 26 Mar '17

26 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29708 Your paranoid android. === w7u (32 bit msg) === msg.c:12062: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:12064: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:12064: Test failed: wrong tme.hwndTrack 0012017C, expected 00000000 msg.c:12064: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [PATCH 4/7] wined3d: Save pixel and vertex shader resource views in stateblocks.
by Henri Verbeet 26 Mar '17

26 Mar '17

On 24 March 2017 at 17:14, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -3132,6 +3132,8 @@ struct wined3d_saved_states > WORD vertexShaderConstantsB; /* WINED3D_MAX_CONSTS_B, 16 */ > WORD vertexShaderConstantsI; /* WINED3D_MAX_CONSTS_I, 16 */ > BOOL vs_consts_f[WINED3D_MAX_VS_CONSTS_F]; > + DWORD pixel_shader_resource_views : 16; /* MAX_FRAGMENT_SAMPLERS, 16 */ > + DWORD vertex_shader_resource_views : 16; /* MAX_VERTEX_SAMPLERS, 4 */ So why is it 16 bits wide?

2 1

Re: [PATCH 2/7] wined3d: Allow creating shader resource views with NULL description.
by Henri Verbeet 26 Mar '17

26 Mar '17

On 24 March 2017 at 17:14, Józef Kucia <jkucia(a)codeweavers.com> wrote: > For ddraw, d3d8 and d3d9. > I think we'd rather just create a wined3d_view_desc in those DLLs.

1 0

Re: cmd: Adjust CMD_LIST to a tree-like structure and implement command chains
by Flávio J. Saraiva 26 Mar '17

26 Mar '17

Hi, Some time ago I was told that every patch in a patch set all patches should produce a state that passes all the tests. Given how much the current code is interconnected, i don't think i can split this while keeping the tests functional. How should I proceed in this case, can I split the code into logical bits knowing that the intermediate states will not pass the tests? Flávio J. Saraiva 2017-03-21 21:06 GMT+00:00 Marvin <testbot(a)winehq.org>: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Needs splitting". > > This means that the patch needs to be split, either because it > contains unrelated changes that should be their own separate patch, or > because it's too large for review. You need to find a way to resend > the changes in smaller chunks. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

5 8

Re: [PATCH v2 1/5] user32: Fix handling of internal messages.
by Alexandre Julliard 25 Mar '17

25 Mar '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > This patch adds a new flag and a server reply, allowing GetQueueStatus > to ignore internal messages, and MsgWaitForMultipleObjects to process > internal messages until a real sent message is found. There's a lot of code duplication in there, and adding private flags to public headers is discouraged. There has to be a better way of doing this, or else it would need a stronger justification than a couple of EnableWindow tests. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] oleaut32: Implement GetAltMonthNames()
by Jacek Caban 25 Mar '17

25 Mar '17

Hi Nikolay, On 3/24/17 7:32 PM, Nikolay Sivov wrote: > diff --git a/dlls/oleaut32/oleaut.c b/dlls/oleaut32/oleaut.c > index f9734e6d78..816b18ce35 100644 > --- a/dlls/oleaut32/oleaut.c > +++ b/dlls/oleaut32/oleaut.c > @@ -935,3 +935,109 @@ HCURSOR WINAPI OleIconToCursor( HINSTANCE hinstExe, HICON hIcon) > /* FIXME: make an extended conversation from HICON to HCURSOR */ > return CopyCursor(hIcon); > } > + > +BOOL WINAPI GetAltMonthNames(LCID lcid, LPOLESTR **str) Shouldn't it return HRESULT? Thanks, Jacek

2 1

Re: [PATCH 2/3] d3dx9: Support relative addressing in preshader.
by Matteo Bruni 24 Mar '17

24 Mar '17

2017-03-23 16:06 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/preshader.c | 103 ++++++++++++++++++++++++++++++++++++------- > dlls/d3dx9_36/tests/effect.c | 38 ++++++++-------- > 2 files changed, 106 insertions(+), 35 deletions(-) > > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index 9aedc99..2974ffd 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -191,6 +191,8 @@ struct d3dx_pres_operand > /* offset is component index, not register index, e. g. > offset for component c3.y is 13 (3 * 4 + 1) */ > unsigned int offset; > + enum pres_reg_tables base_reg_table; > + unsigned int base_reg_offset; > }; It would be nicer to create a struct for storing together table and offset and to pass it around to the various functions taking both arguments, like parse_pres_reg(). It should probably be a separate patch before this one. > + ptr = parse_pres_reg(ptr + 1, &opr->base_reg_table, &opr->base_reg_offset); > + } > + else > + { > + opr->base_reg_table = PRES_REGTAB_COUNT; > + ++ptr; > } > - opr->table = reg_table[*ptr++]; > - opr->offset = *ptr++; > + > + ptr = parse_pres_reg(ptr, &opr->table, &opr->offset); This would crash if the previous parse_pres_reg() call returned NULL. > + size = rs->table_sizes[table] * table_info[table].reg_component_count; > + if (offset >= size) > + { > + if ((offset & 255) < size) > + offset &= 255; > + else > + offset = offset % size; > + } Is this just to try and avoid the modulo operation in some cases or is there a deeper reason? If the former, you could extend that to all the power-of-two sizes by first checking if that's the case (!(size & size - 1)) and, if so, and-ing offset with the mask (size - 1). That's assuming the compiler doesn't do the same optimization already. Let me know if there is some other reason instead. > static double exec_get_arg(struct d3dx_regstore *rs, const struct d3dx_pres_operand *opr, unsigned int comp) > { > - if (!regstore_is_val_set_reg(rs, opr->table, (opr->offset + comp) / table_info[opr->table].reg_component_count)) > - WARN("Using uninitialized input, table %u, offset %u.\n", opr->table, opr->offset + comp); > + unsigned int base_offset, index; > + > + if (opr->base_reg_table == PRES_REGTAB_COUNT) > + index = 0; > + else > + index = (int)exec_get_reg_value(rs, opr->base_reg_table, opr->base_reg_offset); I think it's better with lrint() in place of the cast. > + if (index >= rs->table_sizes[opr->table] && opr->table == PRES_REGTAB_CONST) > + { > + unsigned int size_pow2; > + > + for (size_pow2 = 1; size_pow2 < rs->table_sizes[opr->table]; size_pow2 <<= 1) > + ; > + index &= (size_pow2 - 1); > + if (index >= rs->table_sizes[opr->table]) > + return 0.0; > + } I don't think we necessarily have to follow native's madness on buffer overflows to the letter. Since you did, that's certainly fine though.

2 6

Re: [PATCH v2] winex11: Use GLX_OML_sync_control to synchronise buffer swaps with X11DRV_FLUSH_GL_DRAWABLE requests.
by Jacek Caban 24 Mar '17

24 Mar '17

Hi Henri, On 23.03.2017 23:58, Henri Verbeet wrote: > diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c > index af2fd92..7efd603 100644 > --- a/dlls/winex11.drv/init.c > +++ b/dlls/winex11.drv/init.c > @@ -375,9 +375,6 @@ static INT X11DRV_ExtEscape( PHYSDEV dev, INT escape, INT in_count, LPCVOID in_d > RECT rect = physDev->dc_rect; > > OffsetRect( &rect, -physDev->dc_rect.left, -physDev->dc_rect.top ); > - /* The GL drawable may be lagged behind if we don't flush first, so > - * flush the display make sure we copy up-to-date data */ > - XFlush( gdi_display ); Shouldn't this be called if GLX_OML_sync_control is not available? It seems to me that it should either depend on extension availability or be a separated patch. Thanks, Jacek

2 1

Re: [PATCH] oledb32/tests: Add convert to DBTYPE_NUMERIC tests
by Huw Davies 24 Mar '17

24 Mar '17

On Fri, Mar 24, 2017 at 01:11:17AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/oledb32/tests/convert.c | 147 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 147 insertions(+) > > diff --git a/dlls/oledb32/tests/convert.c b/dlls/oledb32/tests/convert.c > index b8b3c6f..4e49058 100644 > --- a/dlls/oledb32/tests/convert.c > +++ b/dlls/oledb32/tests/convert.c > @@ -3264,6 +3264,152 @@ static void test_converttoiunknown(void) > ok(dst_len == 44, "got %ld\n", dst_len); > } > > +#define test_numberic_val(dst, array) _test_numberic_val(__LINE__, dst, array); > +static inline void _test_numberic_val(unsigned line, DB_NUMERIC *dst, BYTE *array) > +{ > + int same = !memcmp(dst->val, array, sizeof(dst->val)); > + ok_(__FILE__,line) (same, "Invalid byte array\n"); > + if(!same) > + { > + int i; > + for(i=0; i < sizeof(dst->val); i++) > + ok_(__FILE__,line) (dst->val[i] == array[i], " byte %d got 0x%02x\n", i, dst->val[i]); > + } > +} > + > +static inline void set_numberic_array(BYTE *dst, > + BYTE x0, BYTE x1, BYTE x2, BYTE x3, BYTE x4, BYTE x5, BYTE x6, > + BYTE x7, BYTE x8, BYTE x9, BYTE x10, BYTE x11, BYTE x12, BYTE x13, > + BYTE x14, BYTE x15) > +{ > + dst[0] = x0; dst[1] = x1; dst[2] = x2; dst[3] = x3; > + dst[4] = x4; dst[5] = x5; dst[6] = x6; dst[7] = x7; > + dst[8] = x8; dst[9] = x9; dst[10] = x10; dst[11] = x11; > + dst[12] = x12; dst[13] = x13; dst[14] = x14; dst[15] = x15; > +} > + > +static void test_converttonumeric(void) > +{ > + HRESULT hr; > + DBSTATUS dst_status; > + DBLENGTH dst_len; > + DB_NUMERIC dst; > + BYTE src[20]; > + static WCHAR strW[] = {'1','2','3','.','4','5',0}; > + static WCHAR largeW[] = {'1','2','3','4','5','6','7','8','9','0',0}; > + BSTR bstr; > + FLOAT fvalue = 543.21f; > + VARIANT_BOOL boolean = VARIANT_TRUE; > + LARGE_INTEGER i8; > + BYTE array[16]; > + > + *(INT *)src = 4098; > + dst_len = 0x1234; > + dst.scale = 30; > + memset(dst.val, 0xfe, sizeof(dst.val)); > + hr = IDataConvert_DataConvert(convert, DBTYPE_I4, DBTYPE_NUMERIC, 0, &dst_len, src, &dst, sizeof(dst), 0, &dst_status, 10, 0, 0); > + todo_wine ok(hr == S_OK, "got %08x\n", hr); > + todo_wine ok(dst_status == DBSTATUS_S_OK, "got %08x\n", dst_status); > + todo_wine ok(dst_len == sizeof(dst), "got %ld\n", dst_len); > + todo_wine ok(dst.precision == 10, "returned %d\n", dst.precision); > + todo_wine ok(dst.scale == 0, "returned %d\n", dst.scale); > + todo_wine ok(dst.sign == 1, "returned %d\n", dst.sign); > + set_numberic_array(array, 0x02, 0x10, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ); > + todo_wine test_numberic_val(&dst, array); All this seems overly complicated. How about something like: DB_NUMERIC val1 = {10, 0, 1, {0x02, 0x10, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }}; /* 4098 */ .... hr = IDataConvert_DataConvert(convert, DBTYPE_I4, DBTYPE_NUMERIC, 0, &dst_len, src, &dst, sizeof(dst), 0, &dst_status, 10, 0, 0); todo_wine ok(hr == S_OK, "got %08x\n", hr); todo_wine ok(dst_status == DBSTATUS_S_OK, "got %08x\n", dst_status); todo_wine ok(dst_len == sizeof(dst), "got %ld\n", dst_len); todo_wine ok(!memcmp(&dst, &val1, sizeof(dst), "mismatch\n"); It doesn't print out the retrieved value on failure, and you could add this if you want. However, once the conversion is actually implemented, you won't need that anyway. You should probably add a test for converting a variant of type VT_NULL too. Huw.

1 0

Star Trek Online changed their routine for d3dcompiler_47.dll
by cyfer3＠googlemail.com 23 Mar '17

23 Mar '17

Hi dev's! I'd like to report something that might have been working in wine-staging 2.3 but doesn't work in wine-staging current (2.4) but that's not necessarily a wine (mis)understanding as it looks, but I'd rather like to point out, the workaround that has been posted here <https://www.codeweavers.com/compatibility/crossover/forum/star-trek-online?…> doesn't seem to work anymore and with wine-devel 2.4 it is at least possible to see any characters on the login screen, but it crashes right after picking any. This issue might be connected with Cryptic has abandoned dx9 support entirely and I'm very grateful that it worked until today and hopefully will work again in future. Thank you for your work and heart to the project! I hope you will reply to this mail but it's ok if you don't. Regards.

3 3

Re: [v2 3/3] d3dx9/tests: Add more tests for preshader relative addressing.
by Matteo Bruni 23 Mar '17

23 Mar '17

2017-03-23 16:25 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > +static void test_effect_preshader_relative_addressing(IDirect3DDevice9 *device) > +{ > + static const struct > + { > + D3DXVECTOR4 opvect2; > + D3DXVECTOR4 g_ivect; > + unsigned int result[4]; > + } > + test_out_of_bounds_index[] = Better as out_of_bounds_index_tests[] or similar. > + static const struct > + { > + unsigned int zw[2]; > + } > + test_index_range[] = This one would be clearer as expected_light_specular[] or something like that. > + fvect.x = 1001.f; fvect.y = 1002.f; fvect.z = 1003.f; fvect.w = 1004.f; For consistency, please write out the 0 after the decimal separator. > + for (j = 0; j < 4; ++j) > + { > + ok(compare_float(v[j], ((const float *)test_out_of_bounds_index[i].result)[j], 0), > + "Test %u, component %u, expected %#x (%g), got %#x (%g).\n", > + i, j, test_out_of_bounds_index[i].result[j], > + ((const float *)test_out_of_bounds_index[i].result)[j], > + ((const unsigned int *)v)[j], v[j]); You could factor out a variable for the const float * (expected_float?) and use it twice here. > + for (j = 0; j < 2; ++j) > + { > + ok(compare_float(v[j + 2], ((const float *)test_index_range[(unsigned int)i & 7].zw)[j], 0), > + "Test %u, component %u, expected %#x (%g), got %#x (%g).\n", > + i, j, test_index_range[(unsigned int)i & 7].zw[j], > + ((const float *)test_index_range[(unsigned int)i & 7].zw)[j], > + ((const unsigned int *)v)[j + 2], v[j + 2]); Same here. In addition you could set v to &light.Specular.b before this part of the test and avoid those "+ 2".

1 0

Re: [PATCH 1/5] winex11: Use GLX_OML_sync_control to synchronise buffer swaps with X11DRV_FLUSH_GL_DRAWABLE requests.
by Ken Thomases 23 Mar '17

23 Mar '17

On Mar 23, 2017, at 4:49 PM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > > @@ -3330,17 +3343,26 @@ static BOOL glxdrv_wglSwapBuffers( HDC hdc ) > gl->rect.right - gl->rect.left, gl->rect.bottom - gl->rect.top ); > break; > } > - pglXSwapBuffers(gdi_display, gl->drawable); > + if (pglXSwapBuffersMscOML) > + target_sbc = pglXSwapBuffersMscOML( gdi_display, gl->drawable, 0, 0, 0 ); > + else > + pglXSwapBuffers( gdi_display, gl->drawable ); > break; > case DC_GL_CHILD_WIN: > if (ctx) sync_context( ctx ); > escape.gl_drawable = gl->window; > /* fall through */ > default: > - pglXSwapBuffers(gdi_display, gl->drawable); > + if (pglXSwapBuffersMscOML) > + target_sbc = pglXSwapBuffersMscOML( gdi_display, gl->drawable, 0, 0, 0 ); > + else > + pglXSwapBuffers( gdi_display, gl->drawable ); > break; > } > > + if (escape.gl_drawable && pglXWaitForSbcOML) > + pglXWaitForSbcOML( gdi_display, gl->drawable, target_sbc, &ust, &msc, &sbc ); > + > release_gl_drawable( gl ); > > if (escape.gl_drawable) ExtEscape( ctx->hdc, X11DRV_ESCAPE, sizeof(escape), (LPSTR)&escape, 0, NULL ); According to the spec <https://www.khronos.org/registry/OpenGL/extensions/OML/GLX_OML_sync_control…>, glXSwapBuffersMscOML() does not perform an implicit glFlush() as glXSwapBuffers() does. Also, there's no indication that glXWaitForSbcOML() performs one either, although it sort of seems like it should. Is that a problem? -Ken

2 1

Re: [PATCH 4/5] include: Add comments to blocks of render states added with each D3D version.
by Henri Verbeet 23 Mar '17

23 Mar '17

On 22 March 2017 at 23:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > include/wine/wined3d.h | 5 +++++ > 1 file changed, 5 insertions(+) > Are you using these? I'm not necessarily opposed, but in principle wined3d has no concept of Direct3D versions. There's also the consideration that in principle render states will eventually go away in favour of DIrect3D 10 style state object.

2 1

Re: [PATCH v5 1/2] d3d10core/tests: Add a geometry shader test.
by Henri Verbeet 23 Mar '17

23 Mar '17

On 22 March 2017 at 23:53, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > v2: Update for the changed get_texture_readback() and the new > create_buffer() helpers. > v3: Strip debug info from the GS. > v4: Drop some unnecessary state setup. > v5: Get rid of an unused variable. > > This now passes on r600g. It looks like it was indirectly fixed by Mesa > commit 0d383a79a8f13bb00ed5e5d84f41071b43c7e92d "glsl/lower_output_reads: > fix geometry shader output handling with conditional emit" which is in > Mesa 17.0+. > And 13.0.2+, for what it's worth.

1 0

Re: [PATCH 4/7] msvcrt: Add Context::Id tests
by Marvin 23 Mar '17

23 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29651 Your paranoid android. === wxppro (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 8 === w2003std (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 15 === wvistau64 (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 2 === w2008s64 (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 21 === w8 (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 2 === w864 (32 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 7 === wvistau64 (64 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 12 === w2008s64 (64 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 11 === w864 (64 bit msvcr100) === msvcr100.c:874: Test failed: Context::Id() = 0 msvcr100.c:863: Test failed: Context::Id() = 12

1 0

Re: [PATCH] mshtml/tests: Free ready state BSTR (Valgrind)
by Nikolay Sivov 23 Mar '17

23 Mar '17

On 23.03.2017 6:07, Daniel Lehman wrote: > 1 loop of xmlview tests: > ==2633== 32 bytes in 1 blocks are definitely lost in loss record 624 of 2,647 > ==2633== at 0x7BC516E5: RtlAllocateHeap (heap.c:254) > ==2633== by 0x5123CAA: IMalloc_fnAlloc (ifs.c:187) > ==2633== by 0x512416C: IMalloc_Alloc (objidl.h:1508) > ==2633== by 0x512416C: CoTaskMemAlloc (???:0) > ==2633== by 0x4DC843E: alloc_bstr (oleaut.c:177) > ==2633== by 0x4DC89C8: SysAllocStringLen (oleaut.c:355) > ==2633== by 0x4DC8AC6: SysAllocString (oleaut.c:247) > ==2633== by 0x77B4DE8: get_readystate_string (htmlelem.c:248) > ==2633== by 0x779A522: HTMLDocument_get_readyState (htmldoc.c:641) > ==2633== by 0x4C6B064: HTMLEvents_Invoke (mshtml.h:56005) > ==2633== by 0x77BC74A: call_event_handlers (oaidl.h:887) > ==2633== by 0x77BCC70: fire_event_obj.isra.6 (htmlevent.c:1134) > ==2633== by 0x783CE76: notif_readystate (persist.c:451) > ==2633== by 0x7823B30: handle_load (nsevents.c:253) > ==2633== by 0x6B18A8A8: ??? > > 3 loops of xmlview tests: > ==23851== 96 bytes in 3 blocks are definitely lost in loss record 1,767 of 2,701 > ==23851== at 0x7BC516D5: RtlAllocateHeap (heap.c:254) > ==23851== by 0x5123CAA: IMalloc_fnAlloc (ifs.c:187) > ==23851== by 0x512416C: IMalloc_Alloc (objidl.h:1508) > ==23851== by 0x512416C: CoTaskMemAlloc (???:0) > ==23851== by 0x4DC843E: alloc_bstr (oleaut.c:177) > ==23851== by 0x4DC89C8: SysAllocStringLen (oleaut.c:355) > ==23851== by 0x4DC8AC6: SysAllocString (oleaut.c:247) > ==23851== by 0x7683DE8: get_readystate_string (htmlelem.c:248) > ==23851== by 0x7669522: HTMLDocument_get_readyState (htmldoc.c:641) > ==23851== by 0x4C6B314: HTMLEvents_Invoke (mshtml.h:56005) > ==23851== by 0x768B74A: call_event_handlers (oaidl.h:887) > ==23851== by 0x768BC70: fire_event_obj.isra.6 (htmlevent.c:1134) > ==23851== by 0x770BE76: notif_readystate (persist.c:451) > ==23851== by 0x76F2B30: handle_load (nsevents.c:253) > ==23851== by 0x6B18A8A8: ??? > > Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> > --- > dlls/msxml3/tests/xmlview.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dlls/msxml3/tests/xmlview.c b/dlls/msxml3/tests/xmlview.c > index 3c1d8d9..dc8ab7d 100644 > --- a/dlls/msxml3/tests/xmlview.c > +++ b/dlls/msxml3/tests/xmlview.c > @@ -130,6 +130,7 @@ static HRESULT WINAPI HTMLEvents_Invoke(IDispatch *iface, DISPID dispIdMember, R > ok(hr == S_OK, "got 0x%08x\n", hr); > if(!memcmp(state, completeW, sizeof(completeW))) > loaded = TRUE; > + SysFreeString(state); > } > > return S_OK; > This obviously looks correct, please resend with subject changed to msxml3/tests.

1 0

Re: Nikolay Sivov : comctl32/taskdialog: Initial implementation of a minimal task dialog.
by Fabian Maurer 23 Mar '17

23 Mar '17

> Author: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Tue Mar 21 17:31:20 2017 +0300 > > comctl32/taskdialog: Initial implementation of a minimal task dialog. > > Based on patches by Fabian Maurer. Thanks for taking the time to rework it, really appreciate it! However, there's a few questions I'd like to ask. > static const WCHAR nulW; Shouldn't this be set 0? > if (radio_button) *radio_button = taskconfig->nDefaultButton; This probably should have been changed, it was already wrong in the old implementation. > /* write control entries */ > LIST_FOR_EACH_ENTRY_SAFE(control, control2, &desc.controls, struct taskdialog_control, entry) > { > ALIGN_POINTER(ptr, 3); > > template_write_data(&ptr, control->template, control->template_size); > > /* list item won't be needed later */ > list_remove(&control->entry); > Free(control->template); > Free(control); > } Wouldn't it be shorter to also use "taskdialog_clear_controls" here? Just curious on why you chose to write it again. Also, wouldn't it make sense to keep the template generating code separated from the taskdialog specific bits? I intentionally split it, so we could use those function in another place, if needed. In my opinion, that also makes the code easier readable. Finally, are you adding the rest from my latest patch-set too, or should I adapt the missing parts? Regards, Fabian Maurer

2 1

Re: [PATCH 2/5] usp10: Avoid LPPOINT.
by Aric Stewart 22 Mar '17

22 Mar '17

Hi, I think I would personally almost prefer if all 4 of these where one patch. A few of them are only 1-2 changes and this one does both avoid LPPOINT and avoid LPCVOID, some of them rename variables as well. All changes I am happy to sign-off on. -aric On 3/21/17 4:59 PM, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/usp10/opentype.c | 41 +++++++++++++++++++++++------------------ > 1 file changed, 23 insertions(+), 18 deletions(-) > > diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c > index 701e1a0..0579aed 100644 > --- a/dlls/usp10/opentype.c > +++ b/dlls/usp10/opentype.c > @@ -1529,7 +1529,7 @@ static INT GPOS_get_device_table_value(const OT_DeviceTable *DeviceTable, WORD p > return 0; > } > > -static VOID GPOS_get_anchor_values(LPCVOID table, LPPOINT pt, WORD ppem) > +static void GPOS_get_anchor_values(const void *table, POINT *pt, WORD ppem) > { > const GPOS_AnchorFormat1* anchor1 = (const GPOS_AnchorFormat1*)table; > > @@ -1607,7 +1607,8 @@ static INT GPOS_get_value_record(WORD ValueFormat, const WORD data[], GPOS_Value > return offset; > } > > -static VOID GPOS_get_value_record_offsets(const BYTE* head, GPOS_ValueRecord *ValueRecord, WORD ValueFormat, INT ppem, LPPOINT ptPlacement, LPPOINT ptAdvance) > +static void GPOS_get_value_record_offsets(const BYTE *head, GPOS_ValueRecord *ValueRecord, > + WORD ValueFormat, unsigned int ppem, POINT *ptPlacement, POINT *ptAdvance) > { > if (ValueFormat & 0x0001) ptPlacement->x += (short)ValueRecord->XPlacement; > if (ValueFormat & 0x0002) ptPlacement->y += (short)ValueRecord->YPlacement; > @@ -1639,8 +1640,9 @@ static const BYTE *GPOS_get_subtable(const OT_LookupTable *look, int index) > return (const BYTE *)look + offset; > } > > -static VOID GPOS_apply_SingleAdjustment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, const WORD *glyphs, INT glyph_index, > - INT glyph_count, INT ppem, LPPOINT ptAdjust, LPPOINT ptAdvance) > +static void GPOS_apply_SingleAdjustment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, > + const WORD *glyphs, unsigned int glyph_index, unsigned int glyph_count, unsigned int ppem, > + POINT *adjust, POINT *advance) > { > int j; > > @@ -1658,7 +1660,7 @@ static VOID GPOS_apply_SingleAdjustment(const OT_LookupTable *look, const SCRIPT > GPOS_ValueRecord ValueRecord = {0,0,0,0,0,0,0,0}; > WORD ValueFormat = GET_BE_WORD(spf1->ValueFormat); > GPOS_get_value_record(ValueFormat, spf1->Value, &ValueRecord); > - GPOS_get_value_record_offsets((const BYTE*)spf1, &ValueRecord, ValueFormat, ppem, ptAdjust, ptAdvance); > + GPOS_get_value_record_offsets((const BYTE *)spf1, &ValueRecord, ValueFormat, ppem, adjust, advance); > TRACE("Glyph Adjusted by %i,%i\n",ValueRecord.XPlacement,ValueRecord.YPlacement); > } > } > @@ -1680,7 +1682,7 @@ static VOID GPOS_apply_SingleAdjustment(const OT_LookupTable *look, const SCRIPT > offset = size * index; > GPOS_get_value_record(ValueFormat, &spf2->Value[offset], &ValueRecord); > } > - GPOS_get_value_record_offsets((const BYTE*)spf2, &ValueRecord, ValueFormat, ppem, ptAdjust, ptAdvance); > + GPOS_get_value_record_offsets((const BYTE *)spf2, &ValueRecord, ValueFormat, ppem, adjust, advance); > TRACE("Glyph Adjusted by %i,%i\n",ValueRecord.XPlacement,ValueRecord.YPlacement); > } > } > @@ -1713,13 +1715,14 @@ static void apply_pair_value( const void *pos_table, WORD val_fmt1, WORD val_fmt > } > } > > -static INT GPOS_apply_PairAdjustment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, const WORD *glyphs, INT glyph_index, > - INT glyph_count, INT ppem, LPPOINT ptAdjust, LPPOINT ptAdvance) > +static int GPOS_apply_PairAdjustment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, > + const WORD *glyphs, unsigned int glyph_index, unsigned int glyph_count, unsigned int ppem, > + POINT *adjust, POINT *advance) > { > int j; > int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; > > - if (glyph_index + write_dir < 0 || glyph_index + write_dir >= glyph_count) > + if (glyph_index + write_dir >= glyph_count) > return 1; > > TRACE("Pair Adjustment Positioning Subtable\n"); > @@ -1754,7 +1757,8 @@ static INT GPOS_apply_PairAdjustment(const OT_LookupTable *look, const SCRIPT_AN > { > int next = 1; > TRACE("Format 1: Found Pair %x,%x\n",glyphs[glyph_index],glyphs[glyph_index+write_dir]); > - apply_pair_value( ppf1, ValueFormat1, ValueFormat2, pair_val_rec->Value1, ppem, ptAdjust, ptAdvance ); > + apply_pair_value(ppf1, ValueFormat1, ValueFormat2, > + pair_val_rec->Value1, ppem, adjust, advance); > if (ValueFormat2) next++; > return next; > } > @@ -1787,7 +1791,7 @@ static INT GPOS_apply_PairAdjustment(const OT_LookupTable *look, const SCRIPT_AN > > TRACE( "Format 2: Found Pair %x,%x\n", glyphs[glyph_index], glyphs[glyph_index + write_dir] ); > > - apply_pair_value( ppf2, ValueFormat1, ValueFormat2, pair_val, ppem, ptAdjust, ptAdvance ); > + apply_pair_value(ppf2, ValueFormat1, ValueFormat2, pair_val, ppem, adjust, advance); > if (ValueFormat2) next++; > return next; > } > @@ -1799,13 +1803,14 @@ static INT GPOS_apply_PairAdjustment(const OT_LookupTable *look, const SCRIPT_AN > return 1; > } > > -static VOID GPOS_apply_CursiveAttachment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, const WORD *glyphs, INT glyph_index, > - INT glyph_count, INT ppem, LPPOINT pt) > +static void GPOS_apply_CursiveAttachment(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, > + const WORD *glyphs, unsigned int glyph_index, unsigned int glyph_count, unsigned int ppem, POINT *pt) > { > int j; > int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; > > - if (glyph_index + write_dir < 0 || glyph_index + write_dir >= glyph_count) return; > + if (glyph_index + write_dir >= glyph_count) > + return; > > TRACE("Cursive Attachment Positioning Subtable\n"); > > @@ -1925,8 +1930,8 @@ static int GPOS_apply_MarkToBase(const ScriptCache *script_cache, const OT_Looku > return rc; > } > > -static VOID GPOS_apply_MarkToLigature(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, const WORD *glyphs, INT glyph_index, > - INT glyph_count, INT ppem, LPPOINT pt) > +static void GPOS_apply_MarkToLigature(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, > + const WORD *glyphs, unsigned int glyph_index, unsigned int glyph_count, unsigned int ppem, POINT *pt) > { > int j; > int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; > @@ -2015,8 +2020,8 @@ static VOID GPOS_apply_MarkToLigature(const OT_LookupTable *look, const SCRIPT_A > } > } > > -static BOOL GPOS_apply_MarkToMark(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, const WORD *glyphs, INT glyph_index, > - INT glyph_count, INT ppem, LPPOINT pt) > +static BOOL GPOS_apply_MarkToMark(const OT_LookupTable *look, const SCRIPT_ANALYSIS *analysis, > + const WORD *glyphs, unsigned int glyph_index, unsigned int glyph_count, unsigned int ppem, POINT *pt) > { > int j; > BOOL rc = FALSE; >

2 2

Re: [PATCH 1/5] d3d11: Downgrade unknown DWORD FIXMEs() to TRACE() messages.
by Henri Verbeet 22 Mar '17

22 Mar '17

On 22 March 2017 at 09:40, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -727,11 +727,11 @@ void skip_dword_unknown(const char **ptr, unsigned int count) > unsigned int i; > DWORD d; > > - FIXME("Skipping %u unknown DWORDs:\n", count); > + TRACE("Skipping %u unknown DWORDs:\n", count); > for (i = 0; i < count; ++i) > { > read_dword(ptr, &d); > - FIXME("\t0x%08x\n", d); > + TRACE("\t0x%08x\n", d); > } > } > I think WARN would be appropriate.

1 0

Re: [PATCH 1/3] odbccp32: Implement SQLInstallTranslator
by Hans Leidekker 22 Mar '17

22 Mar '17

On Wed, 2017-03-22 at 00:14 +0000, Alistair Leslie-Hughes wrote: > + reg_ret = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "Software\\ODBC\\ODBCINST.INI\\WINE ODBC Translator", 0, KEY_READ, &hkey); > + ok(reg_ret == ERROR_SUCCESS, "RegOpenKeyExW failed\n"); > + if (reg_ret == ERROR_SUCCESS) > + { > + DWORD type, size = MAX_PATH; > + char driverpath[MAX_PATH]; > + > + strcpy(driverpath, syspath); > + strcat(driverpath, "\\sample.dll"); > + > + reg_ret = RegGetValueA(hkey, NULL, "Translator", RRF_RT_REG_SZ, &type, &path, &size); > + ok(reg_ret == ERROR_SUCCESS, "RegGetValueA failed\n"); > + ok(!strcmp(path, driverpath), "invalid path %s\n", path); RegGetValueA is not available on XP. A warning dialog is shown but it's never closed, which can cause failures in tests that follow: https://testbot.winehq.org/JobDetails.pl?Key=29622&scrshot_101=1#k101 I've submitted a patch that avoids RegGetValueA. Please do something similar in these patches.

1 0

Re: [PATCH v2] msvcp100: Add stub for Concurrency::is_current_task_group_canceling
by Piotr Caban 22 Mar '17

22 Mar '17

Hi, Is any application working thanks to this patch (not crashing on next unimplemented function)? Thanks, Piotr

2 3

Outreachy Internships
by Iwona Kotlarska 21 Mar '17

21 Mar '17

Hi everyone, I'm new to contributing to Wine and I would like to apply to Outreachy Internship. I'm generally comfortable with C, but I don't understand Wine's code yet. I tried to download and build Wine on my computer, I followed this: https://wiki.winehq.org/Developer_FAQ#How_do_I_download_and_build_the_very_… and make fails (linking actually) with undefined reference to yywrap in function yylex in file programs/winhlp32/macro.lex.yy.c line 1032. I'm using gcc 5.4.0. Could anyone help me solve this compilation issue? And suggest some small bugs to work on after succesfully compiling wine? Thanks in advance for help! Iwona Kotlarska

4 3

Re: cmd: Adjust CMD_LIST to a tree-like structure and implement command chains
by Marvin 21 Mar '17

21 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29617 Your paranoid android. === wxppro (32 bit) === Found no trace of a test summary line or of a crash === w2003std (32 bit) === Found no trace of a test summary line or of a crash === wvistau64 (32 bit) === Found no trace of a test summary line or of a crash === w2008s64 (32 bit) === Found no trace of a test summary line or of a crash === w7u (32 bit) === Found no trace of a test summary line or of a crash === w7pro64 (32 bit) === Found no trace of a test summary line or of a crash === w8 (32 bit) === Found no trace of a test summary line or of a crash === w864 (32 bit) === Found no trace of a test summary line or of a crash === w1064 (32 bit) === Found no trace of a test summary line or of a crash === wvistau64 (64 bit) === Found no trace of a test summary line or of a crash === w2008s64 (64 bit) === Found no trace of a test summary line or of a crash === w7pro64 (64 bit) === Found no trace of a test summary line or of a crash === w864 (64 bit) === Found no trace of a test summary line or of a crash === w1064 (64 bit) === Found no trace of a test summary line or of a crash

1 0

Re: [PATCH 3/4] xmllite: Set empty value for end element nodes.
by Nikolay Sivov 21 Mar '17

21 Mar '17

On 21.03.2017 18:19, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/xmllite/reader.c | 1 + > 1 file changed, 1 insertion(+) > Could you make this another node type case in GetValue? Like for XmlNodeType_XmlDeclaration. The goal is to make sure empty static string is returned unconditionally for certain node types, as opposed to heap-allocated empty string.

2 1

Re: [PATCH v2 resend] user32: Don't call IsChild with NULL window in EnableWindow
by Marvin 21 Mar '17

21 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29610 Your paranoid android. === w7u (32 bit win) === win.c:999: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A90148 fg 000F0138 in hook HCBT_MINMAX

1 0

Re: [6/7] [resend] version: Add support for FILE_VER_GET_LOCALISED flag.
by Alexandre Julliard 21 Mar '17

21 Mar '17

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -356,7 +356,10 @@ static BOOL find_pe_resource( HFILE lzfd, DWORD *resLen, DWORD *resOff ) > TRACE("No resid entry found\n" ); > goto done; > } > - resPtr = find_entry_language( resPtr, resDir ); > + if ( flags & FILE_VER_GET_LOCALISED ) > + resPtr = find_entry_language( resPtr, resDir ); > + else > + resPtr = find_entry_default( resPtr, resDir ); This won't do what you want, it will return the first available resource which may not be English. > @@ -642,12 +645,12 @@ DWORD WINAPI GetFileVersionInfoSizeExW( DWORD flags, LPCWSTR filename, LPDWORD h > SetLastError(ERROR_BAD_PATHNAME); > return 0; > } > - if (flags) > - FIXME("flags 0x%x ignored\n", flags); > + if (flags & ~FILE_VER_GET_LOCALISED) > + FIXME("flags 0x%x ignored\n", flags & ~FILE_VER_GET_LOCALISED); > > if ((lzfd = LZOpenFileW( (LPWSTR)filename, &ofs, OF_READ )) != HFILE_ERROR) > { > - magic = find_version_resource( lzfd, &len, &offset ); > + magic = find_version_resource( lzfd, &len, &offset, flags ); > LZClose( lzfd ); > } You'd also need to change the FindResourceW call a few lines below. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: A grammar fix in a comment.
by Henri Verbeet 21 Mar '17

21 Mar '17

On 12 March 2017 at 20:47, Francois Gouget <fgouget(a)free.fr> wrote: > @@ -3645,8 +3645,8 @@ static void wined3d_adapter_init_limits(struct wined3d_gl_info *gl_info) > gl_info->gl_ops.gl.p_glGetIntegerv(GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS, &gl_max); > gl_info->limits.compute_samplers = gl_max; > TRACE("Max compute samplers: %u.\n", gl_info->limits.compute_samplers); > - /* A majority of OpenGL implementations allow to statically partition > - * the set of texture bindings into six separate sets. */ > + /* A majority of OpenGL implementations allow applications to statically > + * partition the set of texture bindings into six separate sets. */ I think that changes the meaning somewhat.

2 2

32-bit dlls in 64-bit process
by Viktor Semykin 21 Mar '17

21 Mar '17

Hello. I'm trying to run Adobe Photoshop Lightroom using Wine. One of the showstoppers was the fact that 64-bit process of Lightroom is loading 32-bit DLLs containing various resources. While Windows allows it [1 <https://support.microsoft.com/en-us/help/282423/list-of-limitations-in-64-b…>] wine does not. I made this simple change to Wine code just to make it work for my local usecase: > --- a/server/mapping.c > +++ b/server/mapping.c > @@ -414,8 +414,6 @@ static unsigned int get_image_params( struct > mapping *mapping, file_pos_t file_s > if (nt.opt.hdr32.Magic != IMAGE_NT_OPTIONAL_HDR32_MAGIC) > return STATUS_INVALID_IMAGE_FORMAT; > break; > case CPU_x86_64: > - if (nt.FileHeader.Machine != IMAGE_FILE_MACHINE_AMD64) return > STATUS_INVALID_IMAGE_FORMAT; > - if (nt.opt.hdr64.Magic != IMAGE_NT_OPTIONAL_HDR64_MAGIC) > return STATUS_INVALID_IMAGE_FORMAT; > break; > case CPU_POWERPC: > if (nt.FileHeader.Machine != IMAGE_FILE_MACHINE_POWERPC) > return STATUS_INVALID_IMAGE_FORMAT; From what I can tell this change looks neigher neat nor correct. My question is, what is /the/ correct way to allow loading 32-bit dll into 64-bit process just for loading its resources. Thank you. [1] https://support.microsoft.com/en-us/help/282423/list-of-limitations-in-64-b… -- best, Viktor.

1 0

Re: Fabian Maurer : comctl32/taskdialog: Move TaskDialogIndirect and its tests into own source files.
by Fabian Maurer 20 Mar '17

20 Mar '17

Is there a reason you changed that copyright notice from "Copyright 2017 Fabian Maurer for the Wine project" to "Copyright 2017 Fabian Maurer" only in one place? If you wanted that "for the Wine project" part removed, I don't mind that, but I figured you'd do it at both places then. Regards, Fabian Maurer

3 4

Re: [PATCH 1/3] uiautomationcore: Add UiaLookupId stub.
by Jacek Caban 20 Mar '17

20 Mar '17

Hi Andrey, On 19.03.2017 00:13, Andrey Gusev wrote: > Fixes bug 42665 > > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/uiautomationcore/uia_main.c | 10 ++++++++++ > dlls/uiautomationcore/uiautomationcore.spec | 2 +- > include/uiautomationcoreapi.h | 10 ++++++++++ > 3 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/dlls/uiautomationcore/uia_main.c b/dlls/uiautomationcore/uia_main.c > index 994d8e6..a16d3d1 100644 > --- a/dlls/uiautomationcore/uia_main.c > +++ b/dlls/uiautomationcore/uia_main.c > @@ -17,6 +17,7 @@ > */ > > #include "uiautomationcore.h" > +#include "uiautomationcoreapi.h" Please just use uiautomation.h instead of both includes. Thanks, Jacek

1 0

Re: [PATCH 2/3] uiautomationcore: Add UiaGetReservedMixedAttributeValue stub.
by Alistair Leslie-Hughes 20 Mar '17

20 Mar '17

Hi Andrey, > +HRESULT WINAPI UiaGetReservedMixedAttributeValue(IUnknown **value) > +{ > + FIXME("(%p) stub!\n", value); > + return S_OK; > +} Your returning success but not assigning anything to the out parameter "value". If you have to return S_OK, maybe *value = NULL might be good enough. Same goes for patch 3. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] ntdll: Implement ProcessVmCounters for Linux.
by Alex Henrie 20 Mar '17

20 Mar '17

So, I think Alexandre has been ignoring this patch because it only reports correct information for the current process, even though the Mac implementation has the same problem. I can think of a few ways to fix that: 1. Do nothing if the handle passed to NtQueryInformationProcess is the handle of another process. 2. Add a wineserver call such as get_process_unix_pid to get the process's Unix PID from its handle. Modify the Mac code to use task_for_pid and the Linux code to use /proc/%u/status. 3. Add a wineserver call such as get_process_vm_counters to get all the information that ProcessVmCounters needs without exposing the Unix PID. Move the Mac code into the wineserver and add the Linux code there too. Of those options, I think #3 makes the most sense. Ken, do you think it will cause any problems on Mac? -Alex

2 2

Re: [PATCH v4] msvcrt: Add stub for Concurrency::Alloc
by Gijs Vermeulen 18 Mar '17

18 Mar '17

Hi, What is the difference between this version and my v3? Thank you in advance. Sincerely, Gijs Op 18 mrt. 2017 12:27 p.m. schreef "Piotr Caban" <piotr(a)codeweavers.com>: > From: Gijs Vermeulen <gijsvrm(a)gmail.com> > > Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/concrt140/concrt140.spec | 4 ++-- > dlls/msvcr100/msvcr100.spec | 4 ++-- > dlls/msvcr110/msvcr110.spec | 4 ++-- > dlls/msvcr120/msvcr120.spec | 4 ++-- > dlls/msvcr120_app/msvcr120_app.spec | 4 ++-- > dlls/msvcrt/heap.c | 9 +++++++++ > 6 files changed, 19 insertions(+), 10 deletions(-) > > > > > >

2 2

Wine | Outreachy Applicant
by Akarsha Sehwag 18 Mar '17

18 Mar '17

Hi everyone I am a second yr Btech student at IIIT Delhi, India. I am a newcomer so I'll need some help to start off. I am really willing to be a part of Wine as an Outreachy intern and upgrade to becoming a regular contributor. Also, I know I am starting very late but I am confident that I'll complete the tasks given by the mentor soon. The projects which attract me the most : 1. Winetest GUI 2. Implement resource editor and/or dialog editor I am well-versed with knowledge of C. Though User interface implementation I have only done in Java as of now. 3. Winetest Scripting Interface. I know C and I have also written many scripts in Python. Apart from scripting and UI, I am also very interested in computer graphics but have no experience with that. I am looking forward to some help regarding the projects and the tasks expected to be done before the application deadline. Also, I would appreciate some suggestions regarding the project choice (since I am starting late and the mentors must have already chosen certain favourites by now) Regards -- Akarsha Sehwag 2015010 CSE Undergrad, IIIT Delhi

2 1

Re: [v2 2/2] msvcrt: Add stub for Concurrency::Free
by Piotr Caban 18 Mar '17

18 Mar '17

Hi, Please also move this code to heap.c and rename the function and argument (e.g. to mem). On 03/16/17 23:12, Gijs Vermeulen wrote: > +/* ?Free@Concurrency@@YAXPAX@Z */ > +/* ?Free@Concurrency@@YAXPEAX@Z */ > +void __cdecl Free(void * _PAllocation) > +{ > + FIXME("(%p) stub\n", _PAllocation); Even so it's a semi-stub it's better to free the memory here. Applications have no guarantee that memory block will be cached anyway. Thanks, Piotr

2 1

Re: [PATCH v2 4/5] user32: Always send WM_CANCELMODE when disabling a window.
by Marvin 17 Mar '17

17 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29573 Your paranoid android. === w2003std (32 bit msg) === msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 1: in msg 0x0046 expecting wParam 0x8170 got 0x8160 msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 4: the msg 0x0047 was expected, but got msg 0x0022 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:5724: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: 11: the msg sequence is not complete: expected 0000 - actual 0005

1 0

Re: [PATCH v2 3/5] user32/tests: Add tests for EnableWindow().
by Marvin 17 Mar '17

17 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29572 Your paranoid android. === w7u (32 bit win) === win.c:3891: Test failed: hwnd 000301BC/000301BC message 0200 win.c:3895: Test failed: hwnd 000301BC/000301BC message 0201 win.c:3904: Test failed: hwnd 0011015A/0011015A message 0202 win.c:3907: Test failed: hwnd 0011015A/0011015A message 0201

1 0

Re: [v2 1/2] msvcrt: Add stub for Concurrency::Alloc
by Piotr Caban 17 Mar '17

17 Mar '17

Hi, On 03/16/17 23:12, Gijs Vermeulen wrote: > dlls/msvcrt/lock.c | 9 +++++++++ I think it would be better to implement the function in heap.c file. Could you please move the implementation there. > +void * __cdecl Alloc(MSVCRT_size_t _NumBytes) Please rename the function to Concurrency_Alloc and argument name to size. > + void *p = MSVCRT_malloc(_NumBytes); > + FIXME("(%ld, %p) stub\n", _NumBytes, p); How about changing the FIXME message to something like: FIXME("(%ld) returning %p\n", size, p); (this matches the trace of operator new). Thanks, Piotr

1 0

Re: [PATCH 1/6] wined3d: Introduce "copy sub-resource" command stream operation.
by Henri Verbeet 17 Mar '17

17 Mar '17

On 17 March 2017 at 12:57, Józef Kucia <jkucia(a)codeweavers.com> wrote: > The idea behind the patch series is to split blit and memcpy-like copy > operations. That wasn't the direction I was going with this though. > A few arguments in favor of this idea: > * memcpy-like is simpler operation (doesn't support conversion or > stretching), Sure, but we do already check for that in wined3d_surface_blt(). > * we shouldn't need to extend blitter to handle other resource types > (it's fine to support just 2D textures), Sure, but extending that interface is trivial, and arguably it should be using texture/sub-resource index anyway. > * blit and copy operations should produce different results between > different formats (blitter performs conversions), That's somewhat of an issue, but we do already have blitter flags for alpha test, color keying, flipping, mirroring, etc. > * copy operation should be allowed between various formats of the same > size (including compressed and non-compressed formats), > * it should be possible to implement wined3d_device_update_texture() > on top of wined3d_cs_emit_copy_sub_resource(). I don't think those are incompatible with the current blitter interface.

1 0

Re: shell32/tests: Return early if the shell folder creation fails in order to avoid a compiler warning.
by Marvin 17 Mar '17

17 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29562 Your paranoid android. === wvistau64 (32 bit shlfolder) === shlfolder.c:457: Test failed: 0: got 7480017f expected 7080017f shlfolder.c:457: Test failed: 1: got f480017f expected 7080017f shlfolder.c:457: Test failed: 2: got 44400177 expected 40400177 shlfolder.c:457: Test failed: 3: got 44400177 expected 40400177 shlfolder.c:457: Test failed: 4: got 44400177 expected 40400177 === wvistau64 (64 bit shlfolder) === shlfolder.c:457: Test failed: 0: got 7480017f expected 7080017f shlfolder.c:457: Test failed: 1: got f480017f expected 7080017f shlfolder.c:457: Test failed: 2: got 44400177 expected 40400177 shlfolder.c:457: Test failed: 3: got 44400177 expected 40400177 shlfolder.c:457: Test failed: 4: got 44400177 expected 40400177

2 1

Re: [v4 PATCH] odbccp32: Implement SQLRemoveDriver/SQLRemoveDriverW
by Huw Davies 17 Mar '17

17 Mar '17

On Fri, Mar 17, 2017 at 04:22:20AM +0000, Alistair Leslie-Hughes wrote: > v2 - Support Usage Count. > v3 - Write key when not zero. > v4 - Only Close key when it was successfully opened. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 69 +++++++++++++++++++++++++++++++++++++++++----- > dlls/odbccp32/tests/misc.c | 4 +-- > 2 files changed, 64 insertions(+), 9 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 037a2a9..5e70a9d 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1132,22 +1132,77 @@ BOOL WINAPI SQLRemoveDefaultDataSource(void) > return FALSE; > } > > -BOOL WINAPI SQLRemoveDriverW(LPCWSTR lpszDriver, BOOL fRemoveDSN, > - LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveDriverW(LPCWSTR drivername, BOOL remove_dsn, LPDWORD usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %d %p\n", debugstr_w(lpszDriver), fRemoveDSN, lpdwUsageCount); > - if (lpdwUsageCount) *lpdwUsageCount = 1; > + TRACE("%s %d %p\n", debugstr_w(drivername), remove_dsn, usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, drivername, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + RegCloseKey(hkeydriver); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + if (RegDeleteKeyW(hkey, drivername) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(drivername)); > + > + if (RegOpenKeyW(hkey, odbcdrivers, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, drivername) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(drivername)); > + RegCloseKey(hkeydriver); > + } > + } > + else > + { > + if (RegOpenKeyW(hkey, drivername, &hkeydriver) == ERROR_SUCCESS) > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&usagecount, sizeof(usagecount)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + RegCloseKey(hkeydriver); > + } > + } > + > + RegCloseKey(hkey); > + } > + It should be possible to do this without needing to open the drivername key twice. Huw.

1 0

Re: [PATCH v2] user32: Always send WM_NCACTIVATE when changing the foreground window.
by Alexandre Julliard 17 Mar '17

17 Mar '17

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=7198 > > v2: Use the wineserver to determine if the new foreground window is > already active in its thread. It still looks suspicious to do it here, particularly since we already have code for this in set_active_window. It would need more tests to determine where it fits with the other messages of the sequence. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: ddraw/tests: Fix Android build by replacing log2f(x) with logf(x)/logf(2)
by Alexandre Julliard 16 Mar '17

16 Mar '17

André Hentschel <nerv(a)dawncrow.de> writes: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/ddraw/tests/ddraw1.c | 2 +- > dlls/ddraw/tests/ddraw2.c | 2 +- > dlls/ddraw/tests/ddraw4.c | 2 +- > dlls/ddraw/tests/ddraw7.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) It builds fine here, are you using an old API version? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [v2 2/6] d3dx9: Apply changed states only in CommitChanges.
by Matteo Bruni 16 Mar '17

16 Mar '17

2017-03-14 13:46 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> The current subject might be slightly confusing, something like "d3dx9: Don't apply unmodified states in CommitChanges." would be probably better. The patch looks generally good. Comments follow. > --- > v2: > - stored current_light and current_material in effect structure instead of pass; > - renamed clear_dirty_all() -> clear_dirty_params(). > --- > +static BOOL param_clear_dirty_func(void *dummy, struct d3dx_parameter *param) > +{ > + *param->dirty_flag_ptr &= ~PARAMETER_FLAG_DIRTY; > + return FALSE; > +} > + > +static void clear_dirty_params(struct d3dx9_base_effect *base) > +{ > + unsigned int i; > + > + for (i = 0; i < base->parameter_count; ++i) > + walk_parameter_tree(&base->parameters[i], param_clear_dirty_func, NULL); > +} The walk seems unnecessary since we know that all the children parameters share their dirty flag with their parents. > - param = param->referenced_param; > - TRACE("Array index %u.\n", array_idx); > - if (array_idx >= param->element_count) > + if (array_idx >= ref_param->element_count) > { > - ERR("Computed array index %u is out of bound %u.\n", array_idx, param->element_count); > + ERR("Computed array index %u is out of bound %u.\n", array_idx, ref_param->element_count); > return D3DERR_INVALIDCALL; > } > - param = &param->members[array_idx]; > + param = &ref_param->members[array_idx]; > + *param_dirty = state->index != array_idx || is_param_dirty(param); This looked a bit weird to me at first because of reusing "param". Maybe use a separate "selected_param" variable (or something to that effect)? > - if (FAILED(hr = d3dx9_get_param_value_ptr(effect, pass, state, &param_value, &param))) > + if (FAILED(hr = d3dx9_get_param_value_ptr(effect, pass, state, &param_value, &param, > + update_all, &param_dirty))) > /* Native d3dx returns D3D_OK from BeginPass or Commit involving out of bounds array > - * access and does not touch affected state. */ > + * access and does not touch affected state, except for BeginPass fails with E_FAIL if > + * out of bounds array index depends on dirty parameter(s) in BeginPass. The latter case > + * is TODO. */ Nitpicking on the comment, it sounds better to me with something like "...except for BeginPass when the out of bounds array index depends on dirty parameters. The latter case is supposed to return E_FAIL but is currently TODO". BTW, the ERR in d3dx9_get_param_value_ptr() should probably be a WARN since it can be triggered by the application. > + TRACE("d3dx9_get_param_value_ptr error %#x.\n", hr); This one shouldn't be necessary, I think there should have been a more specific error / warning printed out by d3dx9_get_param_value_ptr() or one of its callees. Otherwise you could repurpose this to say that you're returning D3D_OK notwithstanding the failure. > + return D3D_OK; > + } Actually, it's probably better to change the d3dx9_get_param_value_ptr() return on out of bounds to E_FAIL and only override the return value to D3D_OK in that specific case. > +BOOL is_param_eval_input_dirty(struct d3dx_param_eval *peval) > +{ > + return is_const_tab_input_dirty(&peval->pres.inputs) > + || is_const_tab_input_dirty(&peval->shader_inputs); > +} If I'm not mistaken this only needs to check pres.inputs, given that it's only reasonably going to be called on FXLC and ARRAY_SELECTOR preshaders (not on actual shaders' preshaders). It doesn't matter much though. > - set_constants(rs, &pres->inputs); > - if (FAILED(hr = execute_preshader(pres))) > - return hr; > + if (update_all || is_const_tab_input_dirty(&pres->inputs)) > + { > + set_constants(rs, &pres->inputs, TRUE); > + if (FAILED(hr = execute_preshader(pres))) > + return hr; > + regstore_reset_table(rs, PRES_REGTAB_CONST); > + } This is technically a separate bugfix which would be better as a separate patch, before this one.

2 6

Re: [PATCH 2/2] rpcrt4/tests: Added more server listening tests.
by Marvin 16 Mar '17

16 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29547 Your paranoid android. === w8 (32 bit server) === server.c:1769: Test failed: RpcServerUseProtseqEp(ncacn_np) failed with status 1740 server.c:1776: Test failed: RpcServerListen failed with status 1714 server.c:1777: Test failed: RpcMgmtIsServerListening returned 1715, expected 0 server.c:1780: Test failed: RpcServerListen failed with status 1714 server.c:1783: Test failed: RpcMgmtStopServerListening server.c:1787: Test failed: RpcMgmtWaitServerListening failed with status 1715 === w864 (32 bit server) === server.c:1769: Test failed: RpcServerUseProtseqEp(ncacn_np) failed with status 1740 server.c:1776: Test failed: RpcServerListen failed with status 1714 server.c:1777: Test failed: RpcMgmtIsServerListening returned 1715, expected 0 server.c:1780: Test failed: RpcServerListen failed with status 1714 server.c:1783: Test failed: RpcMgmtStopServerListening server.c:1787: Test failed: RpcMgmtWaitServerListening failed with status 1715 === w1064 (32 bit server) === server.c:1769: Test failed: RpcServerUseProtseqEp(ncacn_np) failed with status 1740 server.c:1776: Test failed: RpcServerListen failed with status 1714 server.c:1777: Test failed: RpcMgmtIsServerListening returned 1715, expected 0 server.c:1780: Test failed: RpcServerListen failed with status 1714 server.c:1783: Test failed: RpcMgmtStopServerListening server.c:1787: Test failed: RpcMgmtWaitServerListening failed with status 1715 === w864 (64 bit server) === server.c:1769: Test failed: RpcServerUseProtseqEp(ncacn_np) failed with status 1740 server.c:1776: Test failed: RpcServerListen failed with status 1714 server.c:1777: Test failed: RpcMgmtIsServerListening returned 1715, expected 0 server.c:1780: Test failed: RpcServerListen failed with status 1714 server.c:1783: Test failed: RpcMgmtStopServerListening server.c:1787: Test failed: RpcMgmtWaitServerListening failed with status 1715 === w1064 (64 bit server) === server.c:1769: Test failed: RpcServerUseProtseqEp(ncacn_np) failed with status 1740 server.c:1776: Test failed: RpcServerListen failed with status 1714 server.c:1777: Test failed: RpcMgmtIsServerListening returned 1715, expected 0 server.c:1780: Test failed: RpcServerListen failed with status 1714 server.c:1783: Test failed: RpcMgmtStopServerListening server.c:1787: Test failed: RpcMgmtWaitServerListening failed with status 1715

1 0

Re: [PATCH] wined3d: Zero-initialize count.
by Henri Verbeet 16 Mar '17

16 Mar '17

On 15 March 2017 at 17:50, Huw Davies <huw(a)codeweavers.com> wrote: > This prevents the loop below accessing beyond multisample_types > if the GL_NUM_SAMPLE_COUNTS call fails. > I think making this a little more robust is fine, but that call should never fail.

1 0

Re: [PATCH 4/8] wined3d: Allow using more than MAX_COMBINED_SAMPLERS texture image units.
by Matteo Bruni 16 Mar '17

16 Mar '17

2017-03-14 13:15 GMT+01:00 Józef Kucia <jkucia(a)codeweavers.com>: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index b1cda46..6fe96e4 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -5994,40 +5994,28 @@ void wined3d_gl_limits_get_uniform_block_range(const struct wined3d_gl_limits *g > void wined3d_gl_limits_get_texture_unit_range(const struct wined3d_gl_limits *gl_limits, > enum wined3d_shader_type shader_type, unsigned int *base, unsigned int *count) > { > - static const struct > + if (shader_type == WINED3D_SHADER_TYPE_COMPUTE) > { > - enum wined3d_shader_type type; > - unsigned int base_idx; > - unsigned int count; > + if (gl_limits->combined_samplers == gl_limits->graphics_samplers) > + *base = 0; > + else > + *base = gl_limits->graphics_samplers - 1; > + *count = gl_limits->compute_samplers; > + return; > } Late to the party and not really important but shouldn't *base in the else case be set to gl_limits->graphics_samplers (i.e. without the "- 1")?

2 1

Re: [v3 PATCH] odbccp32: Implement SQLRemoveDriver/SQLRemoveDriverW
by Huw Davies 16 Mar '17

16 Mar '17

On Thu, Mar 16, 2017 at 04:54:08AM +0000, Alistair Leslie-Hughes wrote: > v2 - Support Usage Count. > v3 - Write key when not zero. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/odbccp32/odbccp32.c | 66 +++++++++++++++++++++++++++++++++++++++++----- > dlls/odbccp32/tests/misc.c | 4 +-- > 2 files changed, 61 insertions(+), 9 deletions(-) > > diff --git a/dlls/odbccp32/odbccp32.c b/dlls/odbccp32/odbccp32.c > index 037a2a9..ace801f 100644 > --- a/dlls/odbccp32/odbccp32.c > +++ b/dlls/odbccp32/odbccp32.c > @@ -1132,22 +1132,74 @@ BOOL WINAPI SQLRemoveDefaultDataSource(void) > return FALSE; > } > > -BOOL WINAPI SQLRemoveDriverW(LPCWSTR lpszDriver, BOOL fRemoveDSN, > - LPDWORD lpdwUsageCount) > +BOOL WINAPI SQLRemoveDriverW(LPCWSTR drivername, BOOL remove_dsn, LPDWORD usage_count) > { > + HKEY hkey; > + DWORD usagecount = 1; > + > clear_errors(); > - FIXME("%s %d %p\n", debugstr_w(lpszDriver), fRemoveDSN, lpdwUsageCount); > - if (lpdwUsageCount) *lpdwUsageCount = 1; > + TRACE("%s %d %p\n", debugstr_w(drivername), remove_dsn, usage_count); > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, odbcini, &hkey) == ERROR_SUCCESS) > + { > + HKEY hkeydriver; > + > + if (RegOpenKeyW(hkey, drivername, &hkeydriver) == ERROR_SUCCESS) > + { > + DWORD size, type; > + > + size = sizeof(usagecount); > + RegGetValueA(hkeydriver, NULL, "UsageCount", RRF_RT_DWORD, &type, &usagecount, &size); > + TRACE("Usage count %d\n", usagecount); > + } > + > + if (usagecount) > + usagecount--; > + > + if (!usagecount) > + { > + RegCloseKey(hkeydriver); > + > + if (RegDeleteKeyW(hkey, drivername) != ERROR_SUCCESS) > + ERR("Failed to delete registry key: %s\n", debugstr_w(drivername)); > + > + if (RegOpenKeyW(hkey, odbcdrivers, &hkeydriver) == ERROR_SUCCESS) > + { > + if(RegDeleteValueW(hkeydriver, drivername) != ERROR_SUCCESS) > + ERR("Failed to delete registry value: %s\n", debugstr_w(drivername)); > + } > + } > + else > + { > + if (RegSetValueExA(hkeydriver, "UsageCount", 0, REG_DWORD, (BYTE*)&usagecount, sizeof(usagecount)) != ERROR_SUCCESS) > + ERR("Failed to write registry UsageCount key\n"); > + } > + RegCloseKey(hkeydriver); > + > + RegCloseKey(hkey); > + } > + > + if (usage_count) > + *usage_count = usagecount; > + > return TRUE; > } This isn't correct if RegOpenKeyW(hkey, drivername, &hkeydriver) fails. The clue that something is wrong (at least for this style of handling errors) is the two RegCloseKey()s in the same block. Huw.

1 0

Re: [v2 6/6] d3dx9/tests: Add test for CommitChanges in effect.
by Matteo Bruni 15 Mar '17

15 Mar '17

2017-03-14 13:47 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> I haven't looked in detail to this patch, just a couple bits I noticed. > + for (i = 0; i < sizeof(check_op_parameters) / sizeof(*check_op_parameters); ++i) You can use ARRAY_SIZE() here too. > + { > + unsigned int j; > + > + for (j = 0; j < 8; ++j) > + { > + hr = IDirect3DDevice9_SetLight(device, j, &test_effect_preshader_light_empty); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); Please add the values of i and j to the message.

1 0

Re: [v2 5/6] d3dx9/tests: Factor out vertex shader constants check helper function from test_effect_preshader().
by Matteo Bruni 15 Mar '17

15 Mar '17

2017-03-14 13:47 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Looks pretty good, I only have a few nitpicks here. > -static void test_effect_preshader(IDirect3DDevice9 *device) > +static const D3DXVECTOR4 fvect_empty = {-9999.0f, -9999.0f, -9999.0f, -9999.0f}; I don't like the "empty" suffix much. Not sure about a better name though... Maybe fvect_filler? > +#define TEST_EFFECT_PRES_NFLOATV ARRAY_SIZE(test_effect_preshader_fconstsv) Same as the previous patch, if you want to keep this define please call it *_COUNT. The naming in general isn't very consistent, probably better to stick to _FVECT_ and similar here and below. > + if (const_updated_mask[i / TEST_EFFECT_FLOATV_BITMASK_BLOCK_SIZE] > + & (1 << (i % TEST_EFFECT_FLOATV_BITMASK_BLOCK_SIZE))) Please use 1u here. > + } > + > +} Spurious empty line.

1 0

Re: [v4 5/5] comctl32: TaskDialog - Implement buttons
by Fabian Maurer 15 Mar '17

15 Mar '17

> They are properly placed but aren't working yet. Sorry, forgot to remove that line, please ignore it. Regards, Fabian Maurer

1 0

Re: [v2 PATCH 2/2] odbccp32: Implement SQLRemoveDriver/SQLRemoveDriverW
by Vincent Povirk 15 Mar '17

15 Mar '17

I think you forgot to write the new usage count to the registry in the case where the driver is not removed.

1 0

Oureachy Applicant Introduction
by chhavi gupta 15 Mar '17

15 Mar '17

Hello! I am Chhavi Gupta, a final year Computer Science Student with an interest in applying for the next round of Outreachy with Wine as some of the ideas have really caught my attention. I am familiar with C and have taken a course in Computer Graphics during my third year in college. Github Profile: https://github.com/chhavip I am interested in the following projects: - Winetest Graphical User Interface - Winecfg / winemenubuilder - enhance MIME type handling - WineCE: Implement the CommandBar I am quite new to Windows programming hence any guidance on how to get started will be extremely helpful! Thank You Chhavi Gupta

2 1

Re: [4/4] kernel32: Add localized version resource.
by Alexandre Julliard 15 Mar '17

15 Mar '17

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > diff --git a/dlls/kernel32/version.rc b/dlls/kernel32/version.rc > index 411bd6e..dbaee67 100644 > --- a/dlls/kernel32/version.rc > +++ b/dlls/kernel32/version.rc > @@ -16,6 +16,13 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#include "winresrc.h" > + > +#pragma makedep po > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + > +#define WINE_FILEDESCRIPTION_STR "#msgctxt#kernel32#Wine Core DLL" > #define WINE_FILENAME_STR "kernel32.dll" Is there a reason that this needs to be kernel32 specific? Why couldn't other dlls use the translation too? -- Alexandre Julliard julliard(a)winehq.org

2 2

[PATCH] user32: Fix handling of internal messages.
by Zebediah Figura 15 Mar '17

15 Mar '17

I'm submitting this to wine-devel because the code is probably messy and I'm not sure if this is the right approach to solving the problem. This patch adds a new flag and a server reply, allowing GetQueueStatus to ignore internal messages, and MsgWaitForMultipleObjects to process internal messages until a real sent message is found. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/user32/message.c | 129 +++++++++++++++++++++++++++++++++++++++-- dlls/user32/tests/msg.c | 8 +-- include/wine/server_protocol.h | 4 +- include/winuser.h | 3 + server/protocol.def | 1 + server/queue.c | 14 ++++- server/request.h | 3 +- server/trace.c | 1 + 8 files changed, 150 insertions(+), 13 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index 9bfb453..92caf64 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -2964,6 +2964,98 @@ static BOOL peek_message( MSG *msg, HWND hwnd, UINT first, UINT last, UINT flags /*********************************************************************** + * receive_internal_message + * + * Retrieves and processes a single sent internal message. + */ +static DWORD receive_internal_message(size_t buffer_size) +{ + LRESULT result; + struct user_thread_info *thread_info = get_user_thread_info(); + struct received_message_info info, *old_info; + void *buffer; + size_t size = 0; + + buffer = HeapAlloc(GetProcessHeap(), 0, buffer_size); + + SERVER_START_REQ( get_message ) + { + NTSTATUS res; + + req->flags = PM_REMOVE | PM_QS_SENDMESSAGE; + req->get_win = 0; + req->get_first = 0; + req->get_last = 0; + req->hw_id = 0; + req->wake_mask = 0; + req->changed_mask = 0; + wine_server_set_reply( req, buffer, buffer_size ); + + if ((res = wine_server_call( req )) != STATUS_SUCCESS) + { + HeapFree(GetProcessHeap(), 0, buffer); + if (res == STATUS_BUFFER_OVERFLOW) + return receive_internal_message(reply->total); + + return RtlNtStatusToDosError(res); + } + + size = wine_server_reply_size( reply ); + info.type = reply->type; + info.msg.hwnd = wine_server_ptr_handle( reply->win ); + info.msg.message = reply->msg; + info.msg.wParam = reply->wparam; + info.msg.lParam = reply->lparam; + info.msg.time = reply->time; + info.msg.pt.x = reply->x; + info.msg.pt.y = reply->y; + thread_info->active_hooks = reply->active_hooks; + } + SERVER_END_REQ; + + switch(info.type) + { + case MSG_ASCII: + case MSG_UNICODE: + info.flags = ISMEX_SEND; + break; + case MSG_NOTIFY: + info.flags = ISMEX_NOTIFY; + break; + case MSG_CALLBACK: + info.flags = ISMEX_CALLBACK; + break; + case MSG_HOOK_LL: + info.flags = ISMEX_SEND; + reply_message(&info, 0, TRUE); + return STATUS_SUCCESS; + case MSG_OTHER_PROCESS: + info.flags = ISMEX_SEND; + if (!unpack_message(info.msg.hwnd, info.msg.message, &info.msg.wParam, + &info.msg.lParam, &buffer, size)) + { + /* ignore it */ + reply_message(&info, 0, TRUE); + return ERROR_SUCCESS; + } + break; + default: + ERR("unexpected type %d for internal message %08x\n", info.type, info.msg.message); + } + + old_info = thread_info->receive_info; + thread_info->receive_info = &info; + result = handle_internal_message(info.msg.hwnd, info.msg.message, + info.msg.wParam, info.msg.lParam); + reply_message( &info, result, TRUE ); + thread_info->receive_info = old_info; + + HeapFree(GetProcessHeap(), 0, buffer); + return ERROR_SUCCESS; +} + + +/*********************************************************************** * process_sent_messages * * Process all pending sent messages. @@ -3811,7 +3903,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH PeekMessageA( MSG *msg, HWND hwnd, UINT first, UIN BOOL WINAPI DECLSPEC_HOTPATCH GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT last ) { HANDLE server_queue = get_server_queue_handle(); - unsigned int mask = QS_POSTMESSAGE | QS_SENDMESSAGE; /* Always selected */ + unsigned int mask = QS_POSTMESSAGE | QS_SENDMESSAGE | QS_WINE_SENDMESSAGE; /* Always selected */ USER_CheckNotLock(); check_for_driver_events( 0 ); @@ -3825,7 +3917,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT if ((first <= WM_SYSTIMER) && (last >= WM_SYSTIMER)) mask |= QS_TIMER; if ((first <= WM_PAINT) && (last >= WM_PAINT)) mask |= QS_PAINT; } - else mask = QS_ALLINPUT; + else mask |= QS_ALLINPUT; while (!peek_message( msg, hwnd, first, last, PM_REMOVE | (mask << 16), mask )) { @@ -4142,7 +4234,7 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *pHandles, DWORD timeout, DWORD mask, DWORD flags ) { HANDLE handles[MAXIMUM_WAIT_OBJECTS]; - DWORD i; + DWORD i, res; if (count > MAXIMUM_WAIT_OBJECTS-1) { @@ -4154,8 +4246,37 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *pHandles, for (i = 0; i < count; i++) handles[i] = pHandles[i]; handles[count] = get_server_queue_handle(); - return wait_objects( count+1, handles, timeout, + mask |= QS_WINE_SENDMESSAGE; + + for (;;) + { + res = wait_objects( count+1, handles, timeout, (flags & MWMO_INPUTAVAILABLE) ? mask : 0, mask, flags ); + if (res == WAIT_OBJECT_0+count) + { + NTSTATUS server_res; + UINT msg; + SERVER_START_REQ( get_queue_status ) + { + req->clear_bits = 0; + if ((server_res = wine_server_call( req )) != STATUS_SUCCESS) + { + SetLastError(RtlNtStatusToDosError(server_res)); + return WAIT_FAILED; + } + msg = reply->first_sent_msg; + } + SERVER_END_REQ; + + if (msg & 0x80000000) + { + /* If it's a WINE internal message, process it and keep waiting */ + receive_internal_message(256); + continue; + } + } + return res; + } } diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 19a1f31..a682b70 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -16332,7 +16332,7 @@ static void test_SendMessage_other_thread(int thread_n) GetMessageA(&msg, 0, 0, 0); ok(msg.message == WM_USER, "expected WM_USER, got %04x\n", msg.message); DispatchMessageA(&msg); - ok_sequence(send_message_1, "SendMessage from other thread 1", thread_n == 2); + ok_sequence(send_message_1, "SendMessage from other thread 1", FALSE); /* intentionally yield */ MsgWaitForMultipleObjects(0, NULL, FALSE, 100, qs_all_input); @@ -16347,7 +16347,7 @@ static void test_SendMessage_other_thread(int thread_n) trace("main: call PeekMessage\n"); ok(PeekMessageA(&msg, 0, 0, 0, PM_NOREMOVE), "PeekMessage should not fail\n"); ok(msg.message == WM_USER+1, "expected WM_USER+1, got %04x\n", msg.message); - ok_sequence(send_message_3, "SendMessage from other thread 3", thread_n == 2); + ok_sequence(send_message_3, "SendMessage from other thread 3", FALSE); trace("main: call PeekMessage\n"); ok(PeekMessageA(&msg, 0, 0, 0, PM_REMOVE), "PeekMessage should not fail\n"); @@ -16359,13 +16359,11 @@ static void test_SendMessage_other_thread(int thread_n) MsgWaitForMultipleObjects(0, NULL, FALSE, 100, qs_all_input); ret = GetQueueStatus(QS_SENDMESSAGE|QS_POSTMESSAGE); - /* FIXME: remove once Wine is fixed */ -todo_wine_if (thread_n == 2) ok(ret == 0, "wrong status %08x\n", ret); trace("main: call PeekMessage\n"); ok(!PeekMessageA(&msg, 0, 0, 0, PM_REMOVE), "PeekMessage should fail\n"); - ok_sequence(WmEmptySeq, "SendMessage from other thread 5", thread_n == 2); + ok_sequence(WmEmptySeq, "SendMessage from other thread 5", FALSE); ret = GetQueueStatus(QS_SENDMESSAGE|QS_POSTMESSAGE); ok(ret == 0, "wrong status %08x\n", ret); diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index ee9fdd1..4417cb6 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -2941,6 +2941,8 @@ struct get_queue_status_reply struct reply_header __header; unsigned int wake_bits; unsigned int changed_bits; + unsigned int first_sent_msg; + char __pad_20[4]; }; @@ -6412,6 +6414,6 @@ union generic_reply struct terminate_job_reply terminate_job_reply; }; -#define SERVER_PROTOCOL_VERSION 524 +#define SERVER_PROTOCOL_VERSION 525 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/include/winuser.h b/include/winuser.h index 2b8331c..d10caba 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -2898,6 +2898,9 @@ typedef struct tagTRACKMOUSEEVENT { /* Extra (undocumented) queue wake bits - see "Undoc. Windows" */ #define QS_SMRESULT 0x8000 +/* Internal WINE message */ +#define QS_WINE_SENDMESSAGE 0x80000000 + /* InSendMessageEx flags */ #define ISMEX_NOSEND 0x00000000 #define ISMEX_SEND 0x00000001 diff --git a/server/protocol.def b/server/protocol.def index 60865a6..7b797af 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2162,6 +2162,7 @@ enum char_info_mode @REPLY unsigned int wake_bits; /* wake bits */ unsigned int changed_bits; /* changed bits since last time */ + unsigned int first_sent_msg; /* first message in the sent message queue */ @END diff --git a/server/queue.c b/server/queue.c index c479b38..ea6d5e6 100644 --- a/server/queue.c +++ b/server/queue.c @@ -744,7 +744,8 @@ static void receive_message( struct msg_queue *queue, struct message *msg, queue->recv_result = result; } free( msg ); - if (list_empty( &queue->msg_list[SEND_MESSAGE] )) clear_queue_bits( queue, QS_SENDMESSAGE ); + if (list_empty( &queue->msg_list[SEND_MESSAGE] )) + clear_queue_bits( queue, QS_SENDMESSAGE | QS_WINE_SENDMESSAGE ); } /* set the result of the current received message */ @@ -2272,11 +2273,17 @@ DECL_HANDLER(set_queue_mask) DECL_HANDLER(get_queue_status) { struct msg_queue *queue = current->queue; + struct list *ptr; if (queue) { reply->wake_bits = queue->wake_bits; reply->changed_bits = queue->changed_bits; queue->changed_bits &= ~req->clear_bits; + + if ((ptr = list_head( &queue->msg_list[SEND_MESSAGE] ))) + reply->first_sent_msg = LIST_ENTRY( ptr, struct message, entry )->msg; + else + reply->first_sent_msg = 0; } else reply->wake_bits = reply->changed_bits = 0; } @@ -2339,7 +2346,10 @@ DECL_HANDLER(send_message) /* fall through */ case MSG_NOTIFY: list_add_tail( &recv_queue->msg_list[SEND_MESSAGE], &msg->entry ); - set_queue_bits( recv_queue, QS_SENDMESSAGE ); + if (msg->msg & 0x80000000) /* Wine internal message */ + set_queue_bits( recv_queue, QS_WINE_SENDMESSAGE ); + else + set_queue_bits( recv_queue, QS_SENDMESSAGE ); break; case MSG_POSTED: list_add_tail( &recv_queue->msg_list[POST_MESSAGE], &msg->entry ); diff --git a/server/request.h b/server/request.h index cd396ee..374150d 100644 --- a/server/request.h +++ b/server/request.h @@ -1480,7 +1480,8 @@ C_ASSERT( FIELD_OFFSET(struct get_queue_status_request, clear_bits) == 12 ); C_ASSERT( sizeof(struct get_queue_status_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, wake_bits) == 8 ); C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, changed_bits) == 12 ); -C_ASSERT( sizeof(struct get_queue_status_reply) == 16 ); +C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, first_sent_msg) == 16 ); +C_ASSERT( sizeof(struct get_queue_status_reply) == 24 ); C_ASSERT( FIELD_OFFSET(struct get_process_idle_event_request, handle) == 12 ); C_ASSERT( sizeof(struct get_process_idle_event_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_process_idle_event_reply, event) == 8 ); diff --git a/server/trace.c b/server/trace.c index e0ce45a..5ba65da 100644 --- a/server/trace.c +++ b/server/trace.c @@ -2698,6 +2698,7 @@ static void dump_get_queue_status_reply( const struct get_queue_status_reply *re { fprintf( stderr, " wake_bits=%08x", req->wake_bits ); fprintf( stderr, ", changed_bits=%08x", req->changed_bits ); + fprintf( stderr, ", first_sent_msg=%08x", req->first_sent_msg ); } static void dump_get_process_idle_event_request( const struct get_process_idle_event_request *req ) -- 2.7.4

2 1

Re: [PATCH v2 2/3] msvcrt: Implement Concurrency::event
by Piotr Caban 15 Mar '17

15 Mar '17

Hi Daniel, I think it would be better to also avoid the static critical section. Here are some hints how it can be achieved: typedef struct { struct list *waiters; INT_PTR signaled; critical_section cs; } event; struct thread_wait; typedef struct { struct thread_wait *wait; struct list entry; } thread_wait_entry; typedef struct thread_wait { event *signaled; int pending_waits; thread_wait_entry entries[1]; } thread_wait; (thread_wait structure will need to be accessed in a thread safe way) With such structures event_set may be implemented in following way (this describes the idea, it's not a fully correct code): void __thiscall event_set(event *this) { critical_section_lock(&this->cs); if (this->signaled) unlock and return; this->signaled = TRUE; LIST_FOR_EACH_ENTRY(cur, this->waiters) { if (!InterlockedDecrement(&cur->wait->pending_waits)) { if (!InterlockedCompareExchangePtr(&cur->wait->signaled, this, 0)) NtReleaseKeyedEvent(keyed_event, cur->wait, 0, NULL); } } critical_section_unlock(&this->cs); } void __thiscall event_reset(event *this) { critical_section_lock(&this->cs); if (!this->signaled) unlock and return; this->signaled = FALSE; LIST_FOR_EACH_ENTRY(cur, this->waiters) InterlockedIncrement(&cur->wait->pending_waits); critical_section_unlock(&this->cs); } int __cdecl wait_for_multiple(event **events, MSVCRT_size_t count, MSVCRT_bool wait_all, unsigned int timeout) { wait = allocate thread_wait struct; initialize wait struct; (wait->pending_waits = wait_all ? count : 1) for(int i=0; i<count; i++) { critical_section_lock(events[i]); add wait to waiters queue (decrease wait->pending_waits if necessary) critical_section_unlock(events[i]); } status = NtWaitForKeyedEvent(keyed_event, wait, ...); if(!status || InterlockedCompareExchangePtr(wait->signaled, 1, 0)) get ret from wait->signaled else ret = COOPERATIVE_WAIT_TIMEOUT; for(int i=0; i<count; i++) { critical_section_lock(events[i]); remove wait from waiters queue critical_section_unlock(events[i]); } } Also I think it would be nice to avoid allocation in case of waiting for only one handle (or just in event_wait function). What do you think about it? Thank you, Piotr

2 1

Re: [PATCH] msxml3: Don't QI for IPersistStream in internal_parse
by Nikolay Sivov 15 Mar '17

15 Mar '17

Hi, Daniel. I think it would be better to add a ok(0, ...) call at istream_QueryInterface() instead of adding new stub for interface we are not supposed to support. This function is actually incomplete, because it does not respond to ISequentialStream. If you want to test order of QI calls, just add another QueryInterface test implementation that does that, and reuse the rest of vtable. Did you test with all versions, 3, 4, and 6?

2 1

Re: [PATCH 4/5] server: Added server side mamed pipe read and write implementation and use it for message mode pipes.
by Sebastian Lackner 15 Mar '17

15 Mar '17

On 22.02.2017 14:51, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/kernel32/tests/pipe.c | 28 ++- > dlls/ntdll/file.c | 7 +- > dlls/ntdll/tests/file.c | 2 +- > server/async.c | 9 + > server/file.h | 1 + > server/named_pipe.c | 446 > ++++++++++++++++++++++++++++++++++++++++++--- > 6 files changed, 447 insertions(+), 46 deletions(-) As I see this updated patchset allows to return the result immediately, but still uses a USR1 signal to transfer back the IO completion info. Wouldn't it be useful to get rid of that aswell? Also please note that we need to distinguish "immediate returns" and "async returns" to properly implement FileIoCompletionNotificationInformation. This especially means that waiting internally is not an option. > + iosb = async_get_iosb( async ); > + if ((blocking || iosb->status != STATUS_PENDING) > + && !(handle = alloc_handle( current->process, async, SYNCHRONIZE, 0 ))) > + async_terminate( async, get_error() ); I don't think this will work as expected. async_terminate might queue an APC, but the caller will immediately deallocate the async struct in server_write_file because status != STATUS_PENDING.

3 14

Outreachy applicant
by Prerna Garg 14 Mar '17

14 Mar '17

Hi, I would like to participate in the current round of Outreachy. I am new to the world of open source. I am interested to contribute in the project Winetest Graphical User Interface. Can somebody please guide me as to how I should go about it. Regards, Prerna Garg B. Tech. Computer Science NIT Hamirpur India

2 1

Re: appwiz.cpl: Use sha256 checksums to validate Mono/Gecko downloads.
by Alexandre Julliard 14 Mar '17

14 Mar '17

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This patch also replaces the memory mapping logic with ReadFile. That's noticeably slower, any particular reason for doing this? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] include: Introduce a with_context macro and use it to simplify vcomp tests. [RFC]
by Bruno Jesus 14 Mar '17

14 Mar '17

On Tue, Mar 7, 2017 at 2:29 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Based on ideas by Mark Jansen. > ... > > The with_context macro allows to specify a format string which is printed in > case of test failures and for trace messages. Currently, to track down the > origin of a test failure, it is necessary to write down all relevant variables > in each ok message. With the new macro it is much easier: > ... Hi, Sebastian. I like this idea, it would be specially useful for table struct tests (eg ws2_32) and functions that are called more than once for different tests (eg rsaenh). Each maintainer/helper could slowly update the tests as they think it fits and new tests could start benefiting from it. I hope more people join this conversation as it clearly took a long time to produce the patch and letting it drop from the list without talk would not be nice ;-)

3 3

Re: [PATCH 8/8] d3d9/tests: Add test for vertex textures.
by Marvin 14 Mar '17

14 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29507 Your paranoid android. === w8 (32 bit visual) === visual.c:8099: Test failed: Got unexpected color 0x00ff00ff for no color attribute test. === w864 (64 bit visual) === visual.c:8099: Test failed: Got unexpected color 0x00ff00ff for no color attribute test.

1 0

Re: [PATCH 3/3] msvcrt100/tests: Add tests for concurrency::event
by Piotr Caban 14 Mar '17

14 Mar '17

Hi, On 03/13/17 21:53, Daniel Lehman wrote: > +static void test_event(void) > +{ > + int i; > + int ret; > + int left; > + int wait; > + event evt; > + event *evts[70]; > + HANDLE thread; > + HANDLE threads[NUMELMS(evts)]; > + > + call_func1(p_event_ctor, &evt); > + > + ret = call_func2(p_event_wait, &evt, 100); > + ok(ret == -1, "expected -1, got %d\n", ret); > + > + call_func1(p_event_set, &evt); > + ret = call_func2(p_event_wait, &evt, 100); > + ok(!ret, "expected 0, got %d\n", ret); Could you please add following test here (to show that event is not reset after wait): ret = call_func2(p_event_wait, &evt, 100); ok(!ret, "expected 0, got %d\n", ret); > + i = 0; > + left = NUMELMS(evts); > + while (left) { > + wait = min(left, MAXIMUM_WAIT_OBJECTS); > + WaitForMultipleObjects(wait, &threads[i], TRUE, 5000); > + left -= wait; > + i += wait; > + } > + > + for (i = 0; i < NUMELMS(evts); i++) > + CloseHandle(threads[i]); I think it's cleaner if you change the while and for loop to something like: for (i = 0; i < NUMELMS(threads); i++) { WaitForSingleObject(threads[i], INFINITE); CloseHandle(threads[i]); } > + /* reset and test wait for multiple with any */ > + for (i = 0; i < NUMELMS(evts); i++) > + call_func1(p_event_reset, evts[i]); > + > + for (i = 0; i < NUMELMS(evts); i++) > + threads[i] = CreateThread(NULL, 0, test_event_thread, (void*)evts[i], 0, NULL); > + > + ret = p_event_wait_for_multiple(evts, NUMELMS(evts), FALSE, 5000); > + ok(ret != -1, "didn't expect -1\n"); Could you please start only one thread in this case and check exact return value from p_event_wait_for_multiple. Could you please also add following test: static DWORD WINAPI multiple_events_thread(void *arg) { event **events = arg; Sleep(50); call_func1(p_event_set, events[0]); call_func1(p_event_reset, events[0]); call_func1(p_event_set, events[1]); call_func1(p_event_reset, events[1]); return 0; } call_func1(p_event_reset, evts[0]); call_func1(p_event_reset, evts[1]); thread = CreateThread(NULL, 0, multiple_events_thread, (void*)evts, 0, NULL); ret = p_event_wait_for_multiple(evts, 2, TRUE, 500); ok(ret == -1, "expect -1, got %d\n", ret); WaitForSingleObject(thread, INFINITE); CloseHandle(thread); Thanks, Piotr

1 0

1.8.7 maintenance release?
by version2013＠openmailbox.org 14 Mar '17

14 Mar '17

I still have much to learn. Why have a 1.8.7 maintenance release after a 2.0 stable release? In advance, thank you for sharing your knowledge as to why.

4 4

Re: [PATCH 1/3] msvcrt: Add Concurrency::event stubs
by Piotr Caban 14 Mar '17

14 Mar '17

Hi Daniel, On 03/13/17 21:53, Daniel Lehman wrote: > include/concrt.h | 25 ++++++++++++++++ The c-runtimes related headers are defined in include/msvcrt/*. In this case I think that it will be better to define needed constants in dlls/msvcrt/msvcrt.h because the concrt.h header is not useful. Thanks, Piotr

1 0

Re: [PATCH] user32: Removed 16-bit windows position and size constraints
by Alexandre Julliard 14 Mar '17

14 Mar '17

Kees Beets <kbeets68(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38231 > > Removed 16-bit windows position and size constraints > introduced in 2006. Only kept truncation to 16-bit > in windows messaging to keep same behaviour as windows. I'd find it surprising that the messages wouldn't match the actual window sizes. This would need more test cases. In fact we already had some window size tests, but they were commented out. I've re-enabled them now, so if you try your patch against latest git you'll see new failures, indicating that fixing up the messages is not correct. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] msvcrt: Implement Concurrency::event
by Sebastian Lackner 14 Mar '17

14 Mar '17

On 13.03.2017 21:53, Daniel Lehman wrote: > > From 44d603b75fe10d51377c20e4c3c2a1bf031c4fcf Mon Sep 17 00:00:00 2001 > From: Daniel Lehman <dlehman(a)esri.com> > Date: Mon, 12 Dec 2016 16:44:44 -0800 > Subject: [PATCH 2/3] msvcrt: Implement Concurrency::event > > wait_for_multiple can handle more than WaitForMultipleObjects' limit of 64 > a separate thread is used to handle threads that wait on multiple handles > and is loosely modeled after wineserver's select request handler > a very simple command structure is used to communicate with it over a single shared pipe > > Signed-off-by: Daniel Lehman <dlehman(a)esri.com> > --- > dlls/msvcrt/lock.c | 387 +++++++++++++++++++++++++++++++++++++++++++++++++-- > dlls/msvcrt/main.c | 3 + > dlls/msvcrt/msvcrt.h | 18 +++ > 3 files changed, 397 insertions(+), 11 deletions(-) Not sure if its suitable here, but please note that Wines threadpool implementation also supports waiting on more than 64 objects (using similar tricks). If possible, it would be better to avoid the second implementation.

2 3

Re: [PATCH 3/3] d3dx9: Apply changed states only in CommitChanges.
by Matteo Bruni 14 Mar '17

14 Mar '17

2017-03-09 23:15 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/d3dx9_private.h | 8 ++- > dlls/d3dx9_36/effect.c | 146 ++++++++++++++++++++++++++++-------------- > dlls/d3dx9_36/preshader.c | 40 ++++++++++-- > dlls/d3dx9_36/tests/effect.c | 13 ---- > 4 files changed, 137 insertions(+), 70 deletions(-) > > diff --git a/dlls/d3dx9_36/d3dx9_private.h b/dlls/d3dx9_36/d3dx9_private.h > index 27b91a7..53cf99f 100644 > --- a/dlls/d3dx9_36/d3dx9_private.h > +++ b/dlls/d3dx9_36/d3dx9_private.h > @@ -222,6 +222,11 @@ struct d3dx_parameter > DWORD *dirty_flag_ptr; > }; > > +static inline BOOL is_param_dirty(struct d3dx_parameter *param) > +{ > + return (*param->dirty_flag_ptr & PARAMETER_FLAG_DIRTY); > +} > + > struct d3dx9_base_effect; > > struct d3dx_parameter *get_parameter_by_name(struct d3dx9_base_effect *base, > @@ -233,6 +238,7 @@ void d3dx_free_param_eval(struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > HRESULT d3dx_evaluate_parameter(struct d3dx_param_eval *peval, > const struct d3dx_parameter *param, void *param_value) DECLSPEC_HIDDEN; > HRESULT d3dx_param_eval_set_shader_constants(struct IDirect3DDevice9 *device, > - struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > + struct d3dx_param_eval *peval, BOOL update_all) DECLSPEC_HIDDEN; > +BOOL is_param_eval_input_dirty(struct d3dx_param_eval *peval) DECLSPEC_HIDDEN; > > #endif /* __WINE_D3DX9_PRIVATE_H */ > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index ada78f9..b18465c 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -123,6 +123,9 @@ struct d3dx_pass > > struct d3dx_state *states; > struct d3dx_parameter *annotations; > + > + D3DLIGHT9 current_light[8]; > + D3DMATERIAL9 current_material; > }; I think these might be stored in the effect struct instead. > +static void clear_dirty_all(struct d3dx9_base_effect *base) clear_dirty_params() or something like that would be a clearer name. > @@ -1570,8 +1587,12 @@ static HRESULT d3dx9_base_effect_set_int(struct d3dx9_base_effect *base, D3DXHAN > { > if (param->rows == 1 && param->columns == 1) > { > - set_number(param->data, param->type, &n, D3DXPT_INT); > - set_dirty(param); > + DWORD value; > + > + set_number(&value, param->type, &n, D3DXPT_INT); > + if (value != *(DWORD *)param->data) > + set_dirty(param); > + *(DWORD *)param->data = value; Shouldn't this go in the previous patch?

2 1

Re: [PATCH 2/3] d3dx9: Set dirty flag on parameter change.
by Matteo Bruni 14 Mar '17

14 Mar '17

2017-03-09 23:15 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -2021,9 +2055,11 @@ static HRESULT d3dx9_base_effect_set_matrix_array(struct d3dx9_base_effect *base > switch (param->class) > { > case D3DXPC_MATRIX_ROWS: > + set_dirty(param); > for (i = 0; i < count; ++i) > { > set_matrix(&param->members[i], &matrix[i]); > + set_dirty(&param->members[i]); > } > return D3D_OK; > Here and below it should be possible to avoid marking dirty each array element individually. IIRC I had some test showing that arrays are always considered completely dirty or clean on native i.e. CommitChanges updates the whole array even if you only change a subset of the elements.

2 1

Re: [PATCH 1/3] d3dx9/tests: Add test for CommitChanges in effect.
by Matteo Bruni 14 Mar '17

14 Mar '17

2017-03-09 23:15 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/tests/effect.c | 1267 +++++++++++++++++++++++++++++++----------- > 1 file changed, 930 insertions(+), 337 deletions(-) First of all, please split up this patch, this is way too large and does multiple things at once (I see that it extends the test effect and checks the new states, factors out two helper functions from test_effect_preshader() and it also adds the CommitChanges test in the subject). Those are all good changes but when they are squeezed in one patch it becomes hard to review. I haven't looked in too much detail but anyway there are a few additional comments below. > +#define TEST_EFFECT_PRES_NOPTESTS ARRAY_SIZE(test_effect_preshader_op_results) I know this isn't new but I don't think this define is very useful. If you really want to keep it, please name it xxx_TEST_COUNT. > + else if (!state_updated[i]) > + { > + todo_wine_if(memcmp(v, empty_v, sizeof(float) * 4)) > + ok_(__FILE__, line)(!memcmp(v, empty_v, sizeof(float) * 4), > + "Parameter %s, test %d, operation %s, state updated unexpectedly.\n", > + updated_param, i, test_effect_preshader_op_results[i].comment); Eh, this isn't really all that nice. I don't see an obvious way to make this any better though so it probably makes sense to move this part (or even all the tests) to the end of the patch series and avoid the problem altogether. BTW, if you define empty_v as an array you can use sizeof(empty_v) here. > + } > + } > +} > + > +static const D3DXVECTOR4 fvect_empty = {-9999.0f, -9999.0f, -9999.0f, -9999.0f}; > + > +static void test_effect_preshader_clear_vconsts(IDirect3DDevice9 *device) > +{ > + int i; unsigned int i; > + static const struct > + { > + const char *param_name; > + BOOL const_updated[TEST_EFFECT_PRES_NFLOATV]; > + } > + check_vconsts_parameters[] = > + { > + {"g_Selector", > + {FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, > + FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, > + FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, > + FALSE, FALSE, FALSE, TRUE}}, It would be nicer to represent these as 32-bit hexadecimal bitmasks. > + for (i = 0; i < sizeof(check_op_parameters) / sizeof(*check_op_parameters); ++i) > + { > + int j; unsigned int j; Also please leave a blank line between declarations and code. > + for (j = 0; j < 8; j++) Consistency, please stick to the '++j' form.

2 1

Re: [PATCH 3/7] d3d9/tests: Fix test_updatetexture() on GPUs not supporting WINED3DFMT_R32_FLOAT.
by Marvin 13 Mar '17

13 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29498 Your paranoid android. === w1064 (32 bit visual) === visual.c:7995: Test failed: Got unexpected color 0x00008080 for quad 2 (different colors). visual.c:7995: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH 1/7] d3d9/tests: Ignore test_vshader_input() "no color attribute" test result on WARP.
by Marvin 13 Mar '17

13 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29497 Your paranoid android. === w1064 (32 bit visual) === visual.c:7995: Test failed: Got unexpected color 0x00008080 for quad 2 (different colors). === w1064 (64 bit visual) === visual.c:7995: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH] ddraw/tests: Rewrite SrcColorKey32BlitTest (v2).
by Henri Verbeet 13 Mar '17

13 Mar '17

On 8 March 2017 at 20:29, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > *) Accept the Nvidia XRGB color key results with X != 0. I am open to > removing this test entirely as we're accepting a lot of different > outcomes now. Yeah, probably. It does seem consistent with the idea that the "X" channel is undefined, and I don't think that particular test was motivated by application behaviour.

2 1

[PATCH] user32: Fix handling of internal messages.
by Zebediah Figura 13 Mar '17

13 Mar '17

I'm submitting this to wine-devel because the code is probably messy and I'm not sure if this is the right approach to solving the problem. This patch adds a new flag and a server reply, allowing GetQueueStatus to ignore internal messages, and MsgWaitForMultipleObjects to process internal messages until a real sent message is found. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/user32/message.c | 129 +++++++++++++++++++++++++++++++++++++++-- dlls/user32/tests/msg.c | 8 +-- include/wine/server_protocol.h | 4 +- include/winuser.h | 3 + server/protocol.def | 1 + server/queue.c | 14 ++++- server/request.h | 3 +- server/trace.c | 1 + 8 files changed, 150 insertions(+), 13 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index 9bfb453..92caf64 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -2964,6 +2964,98 @@ static BOOL peek_message( MSG *msg, HWND hwnd, UINT first, UINT last, UINT flags /*********************************************************************** + * receive_internal_message + * + * Retrieves and processes a single sent internal message. + */ +static DWORD receive_internal_message(size_t buffer_size) +{ + LRESULT result; + struct user_thread_info *thread_info = get_user_thread_info(); + struct received_message_info info, *old_info; + void *buffer; + size_t size = 0; + + buffer = HeapAlloc(GetProcessHeap(), 0, buffer_size); + + SERVER_START_REQ( get_message ) + { + NTSTATUS res; + + req->flags = PM_REMOVE | PM_QS_SENDMESSAGE; + req->get_win = 0; + req->get_first = 0; + req->get_last = 0; + req->hw_id = 0; + req->wake_mask = 0; + req->changed_mask = 0; + wine_server_set_reply( req, buffer, buffer_size ); + + if ((res = wine_server_call( req )) != STATUS_SUCCESS) + { + HeapFree(GetProcessHeap(), 0, buffer); + if (res == STATUS_BUFFER_OVERFLOW) + return receive_internal_message(reply->total); + + return RtlNtStatusToDosError(res); + } + + size = wine_server_reply_size( reply ); + info.type = reply->type; + info.msg.hwnd = wine_server_ptr_handle( reply->win ); + info.msg.message = reply->msg; + info.msg.wParam = reply->wparam; + info.msg.lParam = reply->lparam; + info.msg.time = reply->time; + info.msg.pt.x = reply->x; + info.msg.pt.y = reply->y; + thread_info->active_hooks = reply->active_hooks; + } + SERVER_END_REQ; + + switch(info.type) + { + case MSG_ASCII: + case MSG_UNICODE: + info.flags = ISMEX_SEND; + break; + case MSG_NOTIFY: + info.flags = ISMEX_NOTIFY; + break; + case MSG_CALLBACK: + info.flags = ISMEX_CALLBACK; + break; + case MSG_HOOK_LL: + info.flags = ISMEX_SEND; + reply_message(&info, 0, TRUE); + return STATUS_SUCCESS; + case MSG_OTHER_PROCESS: + info.flags = ISMEX_SEND; + if (!unpack_message(info.msg.hwnd, info.msg.message, &info.msg.wParam, + &info.msg.lParam, &buffer, size)) + { + /* ignore it */ + reply_message(&info, 0, TRUE); + return ERROR_SUCCESS; + } + break; + default: + ERR("unexpected type %d for internal message %08x\n", info.type, info.msg.message); + } + + old_info = thread_info->receive_info; + thread_info->receive_info = &info; + result = handle_internal_message(info.msg.hwnd, info.msg.message, + info.msg.wParam, info.msg.lParam); + reply_message( &info, result, TRUE ); + thread_info->receive_info = old_info; + + HeapFree(GetProcessHeap(), 0, buffer); + return ERROR_SUCCESS; +} + + +/*********************************************************************** * process_sent_messages * * Process all pending sent messages. @@ -3811,7 +3903,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH PeekMessageA( MSG *msg, HWND hwnd, UINT first, UIN BOOL WINAPI DECLSPEC_HOTPATCH GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT last ) { HANDLE server_queue = get_server_queue_handle(); - unsigned int mask = QS_POSTMESSAGE | QS_SENDMESSAGE; /* Always selected */ + unsigned int mask = QS_POSTMESSAGE | QS_SENDMESSAGE | QS_WINE_SENDMESSAGE; /* Always selected */ USER_CheckNotLock(); check_for_driver_events( 0 ); @@ -3825,7 +3917,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT if ((first <= WM_SYSTIMER) && (last >= WM_SYSTIMER)) mask |= QS_TIMER; if ((first <= WM_PAINT) && (last >= WM_PAINT)) mask |= QS_PAINT; } - else mask = QS_ALLINPUT; + else mask |= QS_ALLINPUT; while (!peek_message( msg, hwnd, first, last, PM_REMOVE | (mask << 16), mask )) { @@ -4142,7 +4234,7 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *pHandles, DWORD timeout, DWORD mask, DWORD flags ) { HANDLE handles[MAXIMUM_WAIT_OBJECTS]; - DWORD i; + DWORD i, res; if (count > MAXIMUM_WAIT_OBJECTS-1) { @@ -4154,8 +4246,37 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, const HANDLE *pHandles, for (i = 0; i < count; i++) handles[i] = pHandles[i]; handles[count] = get_server_queue_handle(); - return wait_objects( count+1, handles, timeout, + mask |= QS_WINE_SENDMESSAGE; + + for (;;) + { + res = wait_objects( count+1, handles, timeout, (flags & MWMO_INPUTAVAILABLE) ? mask : 0, mask, flags ); + if (res == WAIT_OBJECT_0+count) + { + NTSTATUS server_res; + UINT msg; + SERVER_START_REQ( get_queue_status ) + { + req->clear_bits = 0; + if ((server_res = wine_server_call( req )) != STATUS_SUCCESS) + { + SetLastError(RtlNtStatusToDosError(server_res)); + return WAIT_FAILED; + } + msg = reply->first_sent_msg; + } + SERVER_END_REQ; + + if (msg & 0x80000000) + { + /* If it's a WINE internal message, process it and keep waiting */ + receive_internal_message(256); + continue; + } + } + return res; + } } diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 19a1f31..a682b70 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -16332,7 +16332,7 @@ static void test_SendMessage_other_thread(int thread_n) GetMessageA(&msg, 0, 0, 0); ok(msg.message == WM_USER, "expected WM_USER, got %04x\n", msg.message); DispatchMessageA(&msg); - ok_sequence(send_message_1, "SendMessage from other thread 1", thread_n == 2); + ok_sequence(send_message_1, "SendMessage from other thread 1", FALSE); /* intentionally yield */ MsgWaitForMultipleObjects(0, NULL, FALSE, 100, qs_all_input); @@ -16347,7 +16347,7 @@ static void test_SendMessage_other_thread(int thread_n) trace("main: call PeekMessage\n"); ok(PeekMessageA(&msg, 0, 0, 0, PM_NOREMOVE), "PeekMessage should not fail\n"); ok(msg.message == WM_USER+1, "expected WM_USER+1, got %04x\n", msg.message); - ok_sequence(send_message_3, "SendMessage from other thread 3", thread_n == 2); + ok_sequence(send_message_3, "SendMessage from other thread 3", FALSE); trace("main: call PeekMessage\n"); ok(PeekMessageA(&msg, 0, 0, 0, PM_REMOVE), "PeekMessage should not fail\n"); @@ -16359,13 +16359,11 @@ static void test_SendMessage_other_thread(int thread_n) MsgWaitForMultipleObjects(0, NULL, FALSE, 100, qs_all_input); ret = GetQueueStatus(QS_SENDMESSAGE|QS_POSTMESSAGE); - /* FIXME: remove once Wine is fixed */ -todo_wine_if (thread_n == 2) ok(ret == 0, "wrong status %08x\n", ret); trace("main: call PeekMessage\n"); ok(!PeekMessageA(&msg, 0, 0, 0, PM_REMOVE), "PeekMessage should fail\n"); - ok_sequence(WmEmptySeq, "SendMessage from other thread 5", thread_n == 2); + ok_sequence(WmEmptySeq, "SendMessage from other thread 5", FALSE); ret = GetQueueStatus(QS_SENDMESSAGE|QS_POSTMESSAGE); ok(ret == 0, "wrong status %08x\n", ret); diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index ee9fdd1..4417cb6 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -2941,6 +2941,8 @@ struct get_queue_status_reply struct reply_header __header; unsigned int wake_bits; unsigned int changed_bits; + unsigned int first_sent_msg; + char __pad_20[4]; }; @@ -6412,6 +6414,6 @@ union generic_reply struct terminate_job_reply terminate_job_reply; }; -#define SERVER_PROTOCOL_VERSION 524 +#define SERVER_PROTOCOL_VERSION 525 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/include/winuser.h b/include/winuser.h index 2b8331c..d10caba 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -2898,6 +2898,9 @@ typedef struct tagTRACKMOUSEEVENT { /* Extra (undocumented) queue wake bits - see "Undoc. Windows" */ #define QS_SMRESULT 0x8000 +/* Internal WINE message */ +#define QS_WINE_SENDMESSAGE 0x80000000 + /* InSendMessageEx flags */ #define ISMEX_NOSEND 0x00000000 #define ISMEX_SEND 0x00000001 diff --git a/server/protocol.def b/server/protocol.def index 60865a6..7b797af 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2162,6 +2162,7 @@ enum char_info_mode @REPLY unsigned int wake_bits; /* wake bits */ unsigned int changed_bits; /* changed bits since last time */ + unsigned int first_sent_msg; /* first message in the sent message queue */ @END diff --git a/server/queue.c b/server/queue.c index c479b38..ea6d5e6 100644 --- a/server/queue.c +++ b/server/queue.c @@ -744,7 +744,8 @@ static void receive_message( struct msg_queue *queue, struct message *msg, queue->recv_result = result; } free( msg ); - if (list_empty( &queue->msg_list[SEND_MESSAGE] )) clear_queue_bits( queue, QS_SENDMESSAGE ); + if (list_empty( &queue->msg_list[SEND_MESSAGE] )) + clear_queue_bits( queue, QS_SENDMESSAGE | QS_WINE_SENDMESSAGE ); } /* set the result of the current received message */ @@ -2272,11 +2273,17 @@ DECL_HANDLER(set_queue_mask) DECL_HANDLER(get_queue_status) { struct msg_queue *queue = current->queue; + struct list *ptr; if (queue) { reply->wake_bits = queue->wake_bits; reply->changed_bits = queue->changed_bits; queue->changed_bits &= ~req->clear_bits; + + if ((ptr = list_head( &queue->msg_list[SEND_MESSAGE] ))) + reply->first_sent_msg = LIST_ENTRY( ptr, struct message, entry )->msg; + else + reply->first_sent_msg = 0; } else reply->wake_bits = reply->changed_bits = 0; } @@ -2339,7 +2346,10 @@ DECL_HANDLER(send_message) /* fall through */ case MSG_NOTIFY: list_add_tail( &recv_queue->msg_list[SEND_MESSAGE], &msg->entry ); - set_queue_bits( recv_queue, QS_SENDMESSAGE ); + if (msg->msg & 0x80000000) /* Wine internal message */ + set_queue_bits( recv_queue, QS_WINE_SENDMESSAGE ); + else + set_queue_bits( recv_queue, QS_SENDMESSAGE ); break; case MSG_POSTED: list_add_tail( &recv_queue->msg_list[POST_MESSAGE], &msg->entry ); diff --git a/server/request.h b/server/request.h index cd396ee..374150d 100644 --- a/server/request.h +++ b/server/request.h @@ -1480,7 +1480,8 @@ C_ASSERT( FIELD_OFFSET(struct get_queue_status_request, clear_bits) == 12 ); C_ASSERT( sizeof(struct get_queue_status_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, wake_bits) == 8 ); C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, changed_bits) == 12 ); -C_ASSERT( sizeof(struct get_queue_status_reply) == 16 ); +C_ASSERT( FIELD_OFFSET(struct get_queue_status_reply, first_sent_msg) == 16 ); +C_ASSERT( sizeof(struct get_queue_status_reply) == 24 ); C_ASSERT( FIELD_OFFSET(struct get_process_idle_event_request, handle) == 12 ); C_ASSERT( sizeof(struct get_process_idle_event_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_process_idle_event_reply, event) == 8 ); diff --git a/server/trace.c b/server/trace.c index e0ce45a..5ba65da 100644 --- a/server/trace.c +++ b/server/trace.c @@ -2698,6 +2698,7 @@ static void dump_get_queue_status_reply( const struct get_queue_status_reply *re { fprintf( stderr, " wake_bits=%08x", req->wake_bits ); fprintf( stderr, ", changed_bits=%08x", req->changed_bits ); + fprintf( stderr, ", first_sent_msg=%08x", req->first_sent_msg ); } static void dump_get_process_idle_event_request( const struct get_process_idle_event_request *req ) -- 2.7.4

1 0

Re: [PATCH 1/5] wined3d: Get rid of "texture_stages" variable in draw_primitive_immediate_mode().
by Henri Verbeet 13 Mar '17

13 Mar '17

On 13 March 2017 at 11:57, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -281,8 +281,7 @@ static void draw_primitive_immediate_mode(struct wined3d_context *context, const > GL_EXTCALL(glSecondaryColor3fEXT)(0.0f, 0.0f, 0.0f); > } > > - texture_stages = d3d_info->limits.ffp_blend_stages; > - for (texture_idx = 0; texture_idx < texture_stages; ++texture_idx) > + for (texture_idx = 0; texture_idx < d3d_info->limits.ffp_blend_stages; ++texture_idx) It doesn't matter that much, but I'm not sure that's an improvement.

1 0

Re: [PATCH] ole32/tests: Stop crash on XP
by Jacek Caban 13 Mar '17

13 Mar '17

Hi Alistair, On 12.03.2017 22:11, Alistair Leslie-Hughes wrote: > Fixes crash > http://test.winehq.org/data/4b1445940d47870895b7fa87b7d69d12abe701ef/xp_fg-… > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/ole32/tests/compobj.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c > index 8f6ff7107c..db68fd05c6 100644 > --- a/dlls/ole32/tests/compobj.c > +++ b/dlls/ole32/tests/compobj.c > @@ -3569,7 +3569,12 @@ static void test_GlobalOptions(void) > > hres = CoCreateInstance(&CLSID_GlobalOptions, NULL, CLSCTX_INPROC_SERVER, > &IID_IGlobalOptions, (void**)&global_options); > - ok(hres == S_OK, "CoCreateInstance(CLSID_GlobalOptions) failed: %08x\n", hres); Instead of removing ok(), please change it with '|| broken(hres == E_NOINTERFACE)'. > + if(FAILED(hres)) > + { > + win_skip("CLSID_GlobalOptions not available\n"); > + CoUninitialize(); > + return; > + } > > IGlobalOptions_Release(global_options); Jacek

1 0

Re: [v3 04/12] comctl32: Extend TaskDialog, add simple callback and tests
by Nikolay Sivov 13 Mar '17

13 Mar '17

On 10.03.2017 21:21, Fabian Maurer wrote: > v3: Rewrite to implement Nikolay Sivov's suggestions > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/comctl32/taskdialog.c | 29 +++++++++++++++++++++++-- > dlls/comctl32/tests/taskdialog.c | 46 +++++++++++++++++++++++++++++++++------- > 2 files changed, 65 insertions(+), 10 deletions(-) > > diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c > index 2166ce1898..c5f410716e 100644 > --- a/dlls/comctl32/taskdialog.c > +++ b/dlls/comctl32/taskdialog.c > @@ -147,17 +147,41 @@ static void controls_add(struct list *controls, WORD id, const WCHAR *class, con > list_add_tail(controls, &data->entry); > } > > +/* FIXME: Make thread safe */ > +static const TASKDIALOGCONFIG *task_config = 0; > +static HRESULT callback(HWND hwnd, UINT uNotification, WPARAM wParam, LPARAM lParam) > +{ > + if(task_config->pfCallback) > + return task_config->pfCallback(hwnd, uNotification, wParam, lParam, task_config->lpCallbackData); > + return S_OK; > +} > + There's no reason to introduce global variable for that, just to remove it two patches after. > static INT_PTR CALLBACK DialogProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) > { > + HRESULT ret_callback; > + > switch (uMsg) > { > + case WM_INITDIALOG: > + callback(hwndDlg, TDN_DIALOG_CONSTRUCTED, 0, 0); > + callback(hwndDlg, TDN_CREATED, 0, 0); > + return TRUE; > case WM_COMMAND: > - if(HIWORD(wParam) == BN_CLICKED && LOWORD(wParam) == IDOK) > + if(HIWORD(wParam) == BN_CLICKED) > { > - EndDialog(hwndDlg, 0); > + WORD command_id = LOWORD(wParam); > + > + ret_callback = callback(hwndDlg, TDN_BUTTON_CLICKED, command_id, 0); > + if(ret_callback == S_OK) /* FIXME */ > + { > + EndDialog(hwndDlg, command_id); > + } > return TRUE; > } > break; > + case WM_DESTROY: > + callback(hwndDlg, TDN_DESTROYED, 0, 0); > + break; > } > return FALSE; For minimal working replacement of MessageBox callback support is not needed, right?

2 4

Re: [v2] user32: Removed 16-bit windows position and size constraints
by Alex Henrie 12 Mar '17

12 Mar '17

2017-03-12 4:23 GMT-06:00 Kees Beets <kbeets68(a)gmail.com>: > Thanks. Changed and submitted again. > > > I'm new to wine. From the instructions here > https://wiki.winehq.org/Submitting_Patches it sounds like there is a > possibility to submit corrections to patches without creating new entries in > the patch list. Somehow I've not been able to get that working. Hope I don't > get on people's nerves :). Alexandre manually removes old patches from the list after a couple of days. If you suspect that there is something wrong with a patch, don't send it to wine-patches, but don't feel bad about sending a new patch to fix an honest mistake. -Alex

1 0

Re: wine/test.h: Identify the process responsible for test summary lines.
by Sebastian Lackner 12 Mar '17

12 Mar '17

On 22.02.2017 15:33, Francois Gouget wrote: > Currently the child process summary lines are indistinguishable from the > main process one. This makes it impossible to automatically detect > when a process exits abruptly, i.e. without printing a summary line, > if it has run a subprocess. > This patch will let analysis tools identify which summary lines > correspond to processes they started and thus when some are missing. > Note also that in case of a crash the 'unhandled exception' play the > same role as the test summary lines. Thus it is important to also tag > them with the pid of the source process. > > Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> > --- > include/wine/test.h | 8 +++++--- > programs/winetest/main.c | 14 +++++++++----- > 2 files changed, 14 insertions(+), 8 deletions(-) Ugh... actually it looks like we have a summary line hardcoded in schedsvc tests: --- snip --- if (winetest_debug) { fprintf(stdout, "rpcapi: 0 tests executed (0 marked as todo, 0 failures), 1 skipped.\n"); fflush(stdout); } ExitProcess(0); --- snip --- Is it still recognized by the testbot?

2 1

Re: [v3 03/12] comctl32: Added basic implementation for task dialogs and add tests
by Nikolay Sivov 12 Mar '17

12 Mar '17

On 10.03.2017 21:21, Fabian Maurer wrote: > + UINT text_size; /* Length in bytes including null-terminator */ > + UINT class_size; /* Length in bytes including null-terminator */ > + struct list entry; > +}control_info; > + > +typedef struct > +{ > + DLGTEMPLATE template; > + WORD menu; > + WORD class; > + const WCHAR *title; > + > + /* Not part of actual template */ > + UINT titleSize; /* Length in bytes including null-terminator */ > +}dialog_header; About formatting issues, for consistency please add space after bracket, same goes for 'if' and other places. "titleSize" -> "title_size". > +#define MEMCPY_MOVEPTR(target, source, size) memcpy(target, source, size); target += size; I think this one will be better as a function, also this macro assumes that target point is char*, which is impossible to guess. > +static void* align_pointer(void *ptr, unsigned int boundary) > +{ > + boundary--; > + return (void *)(((UINT_PTR)ptr + boundary) & ~boundary); > +} This is usually done with macros in Wine I think, like ((x) + size - 1) & ~(size - 1). > +LPDLGTEMPLATEW dialog_template_create(dialog_header header, struct list *controls) Why is 'header' passed by value? > + void *template_data_start; I think it's better to declare this with a type you're going to return. > + data_size += sizeof(WORD)*2 + header.titleSize; Same formatting issue - please add spaces around operator. > + /* Align on WORD boundary for the strings */ > + template_data = align_pointer(template_data, 2); I don't see how it could be not aligned to WORD, could you explain?

2 3

Interested to contribute to WINE via Outreachy
by Himadri Pandya 12 Mar '17

12 Mar '17

Hello Everyone, I'm Himadri, an undergraduate student from India pursuing my bachelors in computer engineering. I'm a newbie to the FOSS community and keen to be a part by contributing to some interesting project. And I guess starting the journey with Outreachy would be the best ! Gsoc project : "Tools - Winetest Graphical User Interface" seems quite interesting to me. I would love to be a part of it. It would be really appreciable if I can get some replies about how can I contribute to it. Regards Himadri Pandya Linked In : https://www.linkedin.com/in/himadri2117

3 3

Re: [PATCH] oledb32: Ignore IRunnableObject in IDataSourceLocator_QueryInterface.
by Sebastian Lackner 12 Mar '17

12 Mar '17

On 12.03.2017 05:34, Alistair Leslie-Hughes wrote: > + else if (IsEqualIID(riid, &IID_IDataInitialize)) > + { > + TRACE("IID_IRunnableObject returning NULL\n"); > + } You are checking for the wrong IID. Also, the TRACE does not really prevent that the FIXME message shows up.

1 0

Re: [v2] user32: Removed 16-bit windows position and size constraints
by Alex Henrie 11 Mar '17

11 Mar '17

+ // truncate x,y to 16-bit in WM_WINDOWPOSCHANGING message (only) + // truncate x,y to 16-bit in WM_WINDOWPOSCHANGED message (only) C++-style comments are not permitted in Wine patches. See https://wiki.winehq.org/Developer_Hints#Using_only_C89-compliant_code -Alex

1 0

GSoC 2017 : CMD - implement more robust parser
by Kevin Jojo 11 Mar '17

11 Mar '17

I am Prateek Bilung , a first year undergraduate student of Mathematics & Computing at BIT Mesra ,Ranchi , India. I am interested in contributing for project "CMD - implement more robust parser" . Please guide me . Thank you !

1 0

Re: [PATCH] user32: Removed 16-bit windows position and size constraints
by Alexandre Julliard 11 Mar '17

11 Mar '17

Kees Beets <kbeets68(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38231 > > Removed code introduced in 2006 to correctly reflect Win9x 16-bit winpos > behaviour. Newer versions of Windows do not have the 16-bit constraint > and this code is now actually causing a bug in Adobe Lightroom on Wine. > I've not used iswin9x to ensure compatibility with Win9x as: > - Applications that can run on Win9x should take care of this > - Adding such code will over time make wine more complex > > Tested on Ubuntu 16.04, HP Elitebook with AMD A10. > 13 failures before change, 10 failures after change. Test code uses > iswin9x, so to have 0 failures means changes to the test suite or > further introduction of 'if isinw9x' logic. > > Signed-off-by: Kees Beets <kbeets68(a)gmail.com> > --- > dlls/user32/winpos.c | 16 ---------------- > 1 file changed, 16 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:776: Test failed: bad winpos->x -32769 win.c:777: Test failed: bad winpos->y -40000 win.c:795: Test failed: bad winpos->x -32769 win.c:796: Test failed: bad winpos->y -40000 win.c:776: Test failed: bad winpos->x 32768 win.c:777: Test failed: bad winpos->y 40000 win.c:795: Test failed: bad winpos->x 32768 win.c:796: Test failed: bad winpos->y 40000 Makefile:649: recipe for target 'win.ok' failed -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [v3 01/12] comctl32: Move TaskDialogIndirect and tests into own source files
by Nikolay Sivov 11 Mar '17

11 Mar '17

On 10.03.2017 21:21, Fabian Maurer wrote: > diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c > new file mode 100644 > index 0000000000..c26d53bac9 > --- /dev/null > +++ b/dlls/comctl32/taskdialog.c > @@ -0,0 +1,72 @@ > +/* > + * Task dialog control > + * > + * Copyright 2017 Fabian Maurer for the Wine project > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + * > + */ > + > +#include <stdarg.h> > +#include <string.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "winuser.h" > +#include "commctrl.h" > +#include "winerror.h" > +#include "comctl32.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(commctrl); > + Since it's move to its own file, let's call new debug channel "taskdlg" for instance.

2 2

Re: [v3 02/12] comctl32: Add notification codes and messages for TaskDialog to header
by Nikolay Sivov 11 Mar '17

11 Mar '17

On 10.03.2017 21:21, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > include/commctrl.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/include/commctrl.h b/include/commctrl.h > index d176b4fd0e..1bf9c279c5 100644 > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -5228,6 +5228,38 @@ typedef struct _TASKDIALOG_BUTTON > PCWSTR pszButtonText; > } TASKDIALOG_BUTTON; > > +enum _TASKDIALOG_NOTIFICATIONS > +{ > + TDN_CREATED = 0, > + TDN_NAVIGATED = 1, > + TDN_BUTTON_CLICKED = 2, > + TDN_HYPERLINK_CLICKED = 3, > + TDN_TIMER = 4, > + TDN_DESTROYED = 5, > + TDN_RADIO_BUTTON_CLICKED = 6, > + TDN_DIALOG_CONSTRUCTED = 7, > + TDN_VERIFICATION_CLICKED = 8, > + TDN_HELP = 9, > + TDN_EXPANDO_BUTTON_CLICKED = 10 > +}; This is not how it's defined in SDK (v10). > + > +/* Taskdialog messages */ > +#define TDM_NAVIGATE_PAGE (WM_USER + 101) > +#define TDM_CLICK_BUTTON (WM_USER + 102) > +#define TDM_SET_MARQUEE_PROGRESS_BAR (WM_USER + 103) > +#define TDM_SET_PROGRESS_BAR_STATE (WM_USER + 104) > +#define TDM_SET_PROGRESS_BAR_RANGE (WM_USER + 105) > +#define TDM_SET_PROGRESS_BAR_POS (WM_USER + 106) > +#define TDM_SET_PROGRESS_BAR_MARQUEE (WM_USER + 107) > +#define TDM_SET_ELEMENT_TEXT (WM_USER + 108) > +#define TDM_CLICK_RADIO_BUTTON (WM_USER + 110) > +#define TDM_ENABLE_BUTTON (WM_USER + 111) > +#define TDM_ENABLE_RADIO_BUTTON (WM_USER + 112) > +#define TDM_CLICK_VERIFICATION (WM_USER + 113) > +#define TDM_UPDATE_ELEMENT_TEXT (WM_USER + 114) > +#define TDM_SET_BUTTON_ELEVATION_REQUIRED_STATE (WM_USER + 115) > +#define TDM_UPDATE_ICON (WM_USER + 116) > + Same here, message numbers are defined as enum members. > typedef HRESULT (CALLBACK *PFTASKDIALOGCALLBACK)(HWND, UINT, WPARAM, LPARAM, LONG_PTR); > > typedef struct _TASKDIALOGCONFIG >

2 2

Re: [PATCH 3/5] usp10: Use heap_alloc_zero() instead of HeapAlloc() with HEAP_ZERO_MEMORY.
by Sebastian Lackner 11 Mar '17

11 Mar '17

On 09.03.2017 10:37, Henri Verbeet wrote: > -static inline BOOL heap_free(void *mem) > -{ > - return HeapFree(GetProcessHeap(), 0, mem); > -} [...] > +static inline void heap_free(void *mem) > +{ > + HeapFree(GetProcessHeap(), 0, mem); > +} I'm not sure if Francois is happy with this change. In other dlls, he has made the exact opposite change in his effort to standardize those functions.

4 3

Re: [v3 03/12] comctl32: Added basic implementation for task dialogs and add tests
by Sebastian Lackner 10 Mar '17

10 Mar '17

On 10.03.2017 19:21, Fabian Maurer wrote: > + /* Skip this test on wine, because it doesn't really fail, > + * it would displays a dialog that doesn't automatically close */ > + if (strcmp(winetest_platform, "wine")) > + { > + ret = pTaskDialogIndirect(&info, NULL, NULL, NULL); > + ok(ret == S_OK, "Expected S_OK, got %x\n", ret); > + } We usually use winetest_interactive for that. There might be more comments, so please wait a bit before resending. ;) Also, please try to send your changes in reasonable sized chunks (max 5-7) in the future. Sending more patches at once only makes sense if they do not depend on each other. Best regards, Sebastian

3 6

Re: [v3 06/12] comctl32: TaskDialog - make thread-safe
by Nikolay Sivov 10 Mar '17

10 Mar '17

On 10.03.2017 21:21, Fabian Maurer wrote: > + > +typedef struct > +{ > + const TASKDIALOGCONFIG *task_config; > + HWND hwnd; > +}taskdialog_info; It doesn't look very safe to keep original pointer here. If you only need callback pointer and user callback data, store them directly.

2 1

Re: [PATCH] dbghelp: Make SymGetLineFromAddr64 call SymGetLineFromAddrW64
by Sebastian Lackner 10 Mar '17

10 Mar '17

On 10.03.2017 04:24, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/dbghelp/dbghelp_private.h | 3 ++ > dlls/dbghelp/symbol.c | 96 ++++++++++++++++++++++++++++++------------ > 2 files changed, 73 insertions(+), 26 deletions(-) > Could you give some explanation for the purpose of this patch? It looks a bit odd that we need two almost identical symt_fill_func_line_info implementations. > + if (found) > + { > + char *filename = (char*)source_get(module, dli->u.source_file); > + int len = lstrlenA(filename)+1; > + > + line->FileName = fetch_buffer(module->process, len * sizeof(WCHAR)); > + > + MultiByteToWideChar(CP_ACP, 0, filename, -1, line->FileName, len); [...] > - len = MultiByteToWideChar(CP_ACP, 0, l64->FileName, -1, NULL, 0); > - if ((l64w->FileName = fetch_buffer(pcs, len * sizeof(WCHAR)))) > - MultiByteToWideChar(CP_ACP, 0, l64->FileName, -1, l64w->FileName, len); > - l64w->Address = l64->Address; Actually, the old way of converting the strings looked more reasonable. Computing the correct length and checking for errors is preferred in such cases. Best regards, Sebastian

2 1

Re: [v3 09/12] comctl32: TaskDialog - Changed tests to allow sending messages
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29422 Your paranoid android. === wvistau64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w2008s64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w7pro64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w864 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w1064 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?)

2 1

Re: [v3 12/12] comctl32: TaskDialog - Add ability to cancel dialog
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29425 Your paranoid android. === wvistau64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w2008s64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w7pro64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w864 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w1064 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?)

1 0

Re: [v3 11/12] comctl32: TaskDialog - Set default button and add tests
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29424 Your paranoid android. === wvistau64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w2008s64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w7pro64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w864 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w1064 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?)

1 0

Re: [PATCH 2/2] odbccp32: Implement SQLRemoveDriver/SQLRemoveDriverW
by Vincent Povirk 10 Mar '17

10 Mar '17

> + if (usage_count) > + *usage_count = 0; If we're not going to do refcounting properly, it'd make more sense to hard-code this to 1 and never actually remove the drivers. Better to leave things around than delete them while they're still needed.

1 0

Re: [v3 10/12] comctl32: TaskDialog - Add button return value and tests
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29423 Your paranoid android. === wvistau64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w2008s64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w7pro64 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w864 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?) === w1064 (64 bit taskdialog) === comctl32:taskdialog returned an error (3221226356) despite having no failures comctl32:taskdialog has no test summary line (early exit of the main process?)

1 0

Re: [PATCH 1/2] odbccp32: Implement SQLInstallDriverEx correctly
by Vincent Povirk 10 Mar '17

10 Mar '17

> + if(RegSetValueExW(hkeydriver, driver, 0, REG_SZ, (BYTE*)installed, > + (sizeof(installed)+1)*sizeof(WCHAR)) != ERROR_SUCCESS) sizeof(installed) is already in bytes and includes the null terminator. > + /* Driver and Setup entries use the system path unless a path is specified. */ > + if(lstrcmpiW(driverW, entry) == 0 || lstrcmpiW(setupW, entry) == 0) > + { > + lstrcpyW(value, path); > + lstrcatW(value, slash); > + lstrcatW(value, divider); > + } > + else > + lstrcpyW(value, divider); Some sort of overflow check might be good here. > + ret = SQLInstallDriverEx("WINE ODBC Driver\0Driver=sample.dll\0Setup=sample.dll\0\0", NULL, path, MAX_PATH, &size, ODBC_INSTALL_COMPLETE, NULL); > + sql_ret = SQLInstallerErrorW(1, &error_code, NULL, 0, NULL); > + if (sql_ret && error_code == ODBC_ERROR_WRITING_SYSINFO_FAILED) > + { > + win_skip("not enough privileges\n"); > + return; > + } > + ok(sql_ret && error_code == SQL_SUCCESS, "SQLInstallDriverEx failed %d, %u\n", sql_ret, error_code); > + ok(!strcmp(path, syspath), "invalid path %s\n", path); This doesn't use the value of ret.

1 0

Re: [PATCH 4/5] usp10: Use heap_alloc() instead of HeapAlloc().
by Henri Verbeet 10 Mar '17

10 Mar '17

On 10 March 2017 at 16:23, Aric Stewart <aric(a)codeweavers.com> wrote: > Feels a little like there are 2 unrelated changes here the heap_alloc work and then using the loaded_feature temporary variable to clean up the code. I am fine with both changes so I will sign off but i wonder if it makes the commit message a bit less clear. > Yeah, somewhat. It came up during the heap_alloc() work, but ended up touching a fair number of lines. In that regard it could have been split out, although I figured it wasn't too bad.

1 0

Re: [PATCH 2/2 resend] devenum: Return S_OK in IMoniker::IsEqual() stub.
by Andrew Eikum 10 Mar '17

10 Mar '17

I'm not sure how application use these monikers, but lying about moniker equality makes me a little nervous. This doesn't look that hard to implement correctly. Andrew On Fri, Mar 10, 2017 at 06:26:55PM +0800, Jactry Zeng wrote: > Superseded patch 131295. > > Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> > --- > dlls/devenum/mediacatenum.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > > diff --git a/dlls/devenum/mediacatenum.c b/dlls/devenum/mediacatenum.c > index 66343342c9..3543182cf4 100644 > --- a/dlls/devenum/mediacatenum.c > +++ b/dlls/devenum/mediacatenum.c > @@ -530,7 +530,10 @@ static HRESULT WINAPI DEVENUM_IMediaCatMoniker_IsEqual(IMoniker *iface, IMoniker > { > FIXME("(%p)->(%p): stub\n", iface, pmkOtherMoniker); > > - return E_NOTIMPL; > + if (!pmkOtherMoniker) > + return E_INVALIDARG; > + > + return S_OK; > } > > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_Hash(IMoniker *iface, DWORD *pdwHash) > >

1 0

Re: [1/2] services/tests: Add test for database locking.
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29411 Your paranoid android. === w7u (32 bit service) === service.c:407: Test failed: LockServiceDatabase failed: 1055 service.c:413: Test failed: UnlockServiceDatabase failed: 1071

2 1

Re: [PATCH 1/2] devenum: Implement IMoniker::GetClassID().
by Nikolay Sivov 10 Mar '17

10 Mar '17

On 10.03.2017 12:32, Jactry Zeng wrote: > Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> > --- > dlls/devenum/mediacatenum.c | 8 +++++--- > dlls/devenum/tests/devenum.c | 9 +++++++++ > 2 files changed, 14 insertions(+), 3 deletions(-) > > - FIXME("(%p)->(%p): stub\n", This, pClassID); > + TRACE("(%p)->(%p): stub\n", This, pClassID); You can remove 'stub' now.

2 1

Re: [PATCH] oledb32: Downgrade IDataSourceLocator_QueryInterface FIXME to WARN
by Huw Davies 10 Mar '17

10 Mar '17

On Fri, Mar 10, 2017 at 04:31:02AM +0000, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/oledb32/dslocator.c | 2 +- > dlls/oledb32/tests/database.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/oledb32/dslocator.c b/dlls/oledb32/dslocator.c > index 11ed3e9..055357e 100644 > --- a/dlls/oledb32/dslocator.c > +++ b/dlls/oledb32/dslocator.c > @@ -80,7 +80,7 @@ static HRESULT WINAPI dslocator_QueryInterface(IDataSourceLocator *iface, REFIID > return S_OK; > } > > - FIXME("interface %s not implemented\n", debugstr_guid(riid)); > + WARN("interface %s not implemented\n", debugstr_guid(riid)); > return E_NOINTERFACE; > } I think leaving the FIXME, but skipping it if the iid is IID_IRunnableObject would be better. Huw.

1 0

Re: [PATCH 1/2] comctl32/propsheet: Diverse UI fixes
by Nikolay Sivov 10 Mar '17

10 Mar '17

On 09.03.2017 23:19, Hermès BÉLUSCA-MAÏTO wrote: > [PATCH 1/2] comctl32/propsheet: Diverse UI fixes: > > - Draw static text elements with a transparent background, so that they > acquire the correct background color of the wizard window. > > - Modify the check for the header bitmap, as the header's hbmHeader is > initialized also if the flag PSH_HEADER but not PSH_USEHBMHEADER is set > (see function PROPSHEET_LoadWizardBitmaps). > > - Add a check for header's hbmWatermark so that the watermark is drawn > only when a valid bitmap handle is present. - Fix a copy-pasta error > when drawing the header's subtitle. > > > > Hi, Hermès. Thanks for the patches, some comments follow. > case WM_CTLCOLORSTATIC: > - SetBkColor((HDC)wParam, GetSysColor(COLOR_WINDOW)); > - return (INT_PTR)GetSysColorBrush(COLOR_WINDOW); > + SetBkMode((HDC)wParam, TRANSPARENT); > + return (INT_PTR)GetStockObject(HOLLOW_BRUSH); > } Do you have a simple test program to confirm this? This should be a separate patch. > @@ -3373,7 +3373,7 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC hdcParam) > if (ppshpage->dwFlags & PSP_USEHEADERSUBTITLE) { > SelectObject(hdc, psInfo->hFont); > SetRect(&r, 40, 25, rzone.right - 69, rzone.bottom); > - if (!IS_INTRESOURCE(ppshpage->pszHeaderTitle)) > + if (!IS_INTRESOURCE(ppshpage->pszHeaderSubTitle)) > DrawTextW(hdc, ppshpage->pszHeaderSubTitle, -1, &r, DT_LEFT | DT_WORDBREAK); > else > { Looks good, please make it a separate patch too. > @@ -3298,7 +3298,7 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC hdcParam) > > hOldFont = SelectObject(hdc, psInfo->hFontBold); > > - if (psInfo->ppshheader.dwFlags & PSH_USEHBMHEADER) > + if (psInfo->ppshheader.u5.hbmHeader) > { > hbmp = SelectObject(hdcSrc, psInfo->ppshheader.u5.hbmHeader); > I'll need a visual test to confirm this, looks a bit strange that flags are ignored. > @@ -3395,7 +3395,8 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC hdcParam) > > if ( (ppshpage && (ppshpage->dwFlags & PSP_HIDEHEADER)) && > (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_OLD | PSH_WIZARD97_NEW)) && > - (psInfo->ppshheader.dwFlags & PSH_WATERMARK) ) > + (psInfo->ppshheader.dwFlags & PSH_WATERMARK) && > + (psInfo->ppshheader.u4.hbmWatermark) ) > { > HWND hwndLine = GetDlgItem(hwnd, IDC_SUNKEN_LINE); This looks reasonable, also deserved a separate patch.

1 1

Re: [PATCH 5/7] xmllite/reader: Fix position methods return values in closed reader state
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29381 Your paranoid android. === wxppro (32 bit reader) === reader.c:2536: Test failed: Expected (XmlReadState_Initial), got (XmlReadState_Closed) === w2003std (32 bit reader) === reader.c:2536: Test failed: Expected (XmlReadState_Initial), got (XmlReadState_Closed)

1 0

Wine Mono vagrant build environment
by Vincent Povirk 10 Mar '17

10 Mar '17

I'm not sure if anyone will care about this, but I figured I should mention it somewhere. With the release of Wine Mono 4.7.0 today, the source tree now ships with a Vagrantfile, which can be used with Vagrant to create a virtual machine that can build the project. This was the environment used to create the msi package, and I plan to continue using it this way for future releases. Previously, the official build environment was my work PC, which means there was always the possibility that upgrading or changing it would have some effect on the official packages. I don't know if this is useful for anyone else, but I figure that an easy way to create a build environment, along with the complete documentation of that environment which we get as a side-effect, can only be a good thing. This is not a replacement for building on real hardware. I only plan to use it to make official builds, not for development, and I still want to hear about any issues people encounter while trying to do the build on their own systems.

2 1

Re: [PATCH 4/5] d3d9/tests: Skip UpdateTexture tests if texture filtering isn't supported.
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29375 Your paranoid android. === w1064 (32 bit visual) === visual.c:7947: Test failed: Input test: Quad 3(2crd-wrongidx) returned color 0x00ff00ff, expected 0x00ff0080 visual.c:7995: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors). visual.c:8099: Test failed: Got unexpected color 0x00ff0000 for no color attribute test.

1 0

Re: [PATCH v2 2/5] ddraw/tests: Add a ddraw7 vertex buffer refcount test.
by Marvin 10 Mar '17

10 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29374 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:3763: Test failed: Lit quad with light has color 0x00000000. ddraw7.c:3763: Test failed: Lit quad with singular world matrix has color 0x00000000. ddraw7.c:3763: Test failed: Lit quad with transformation matrix has color 0x00000000.

1 0

RE: ***SPAM*** Re: [PATCH 1/2] comctl32/propsheet: Diverse UI fixes
by Hermès BÉLUSCA-MAÏTO 09 Mar '17

09 Mar '17

Hello Nikolay, I'll resend tomorrow the fixes in separate patches, and add a simple test app (with source) for you to have a look. Thank you for your reviewing, Hermès -----Message d'origine----- De : wine-patches [mailto:wine-patches-bounces@winehq.org] De la part de Nikolay Sivov Envoyé : jeudi 9 mars 2017 23:17 À : wine-patches(a)winehq.org Objet : ***SPAM*** Re: [PATCH 1/2] comctl32/propsheet: Diverse UI fixes On 09.03.2017 23:19, Hermès BÉLUSCA-MAÏTO wrote: > [PATCH 1/2] comctl32/propsheet: Diverse UI fixes: > > - Draw static text elements with a transparent background, so that > they acquire the correct background color of the wizard window. > > - Modify the check for the header bitmap, as the header's hbmHeader is > initialized also if the flag PSH_HEADER but not PSH_USEHBMHEADER is > set (see function PROPSHEET_LoadWizardBitmaps). > > - Add a check for header's hbmWatermark so that the watermark is drawn > only when a valid bitmap handle is present. - Fix a copy-pasta error > when drawing the header's subtitle. > > > > Hi, Hermès. Thanks for the patches, some comments follow. > case WM_CTLCOLORSTATIC: > - SetBkColor((HDC)wParam, GetSysColor(COLOR_WINDOW)); > - return (INT_PTR)GetSysColorBrush(COLOR_WINDOW); > + SetBkMode((HDC)wParam, TRANSPARENT); > + return (INT_PTR)GetStockObject(HOLLOW_BRUSH); > } Do you have a simple test program to confirm this? This should be a separate patch. > @@ -3373,7 +3373,7 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC hdcParam) > if (ppshpage->dwFlags & PSP_USEHEADERSUBTITLE) { > SelectObject(hdc, psInfo->hFont); > SetRect(&r, 40, 25, rzone.right - 69, rzone.bottom); > - if (!IS_INTRESOURCE(ppshpage->pszHeaderTitle)) > + if (!IS_INTRESOURCE(ppshpage->pszHeaderSubTitle)) > DrawTextW(hdc, ppshpage->pszHeaderSubTitle, -1, &r, DT_LEFT | DT_WORDBREAK); > else > { Looks good, please make it a separate patch too. > @@ -3298,7 +3298,7 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC > hdcParam) > > hOldFont = SelectObject(hdc, psInfo->hFontBold); > > - if (psInfo->ppshheader.dwFlags & PSH_USEHBMHEADER) > + if (psInfo->ppshheader.u5.hbmHeader) > { > hbmp = SelectObject(hdcSrc, > psInfo->ppshheader.u5.hbmHeader); > I'll need a visual test to confirm this, looks a bit strange that flags are ignored. > @@ -3395,7 +3395,8 @@ static LRESULT PROPSHEET_Paint(HWND hwnd, HDC > hdcParam) > > if ( (ppshpage && (ppshpage->dwFlags & PSP_HIDEHEADER)) && > (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_OLD | PSH_WIZARD97_NEW)) && > - (psInfo->ppshheader.dwFlags & PSH_WATERMARK) ) > + (psInfo->ppshheader.dwFlags & PSH_WATERMARK) && > + (psInfo->ppshheader.u4.hbmWatermark) ) > { > HWND hwndLine = GetDlgItem(hwnd, IDC_SUNKEN_LINE); This looks reasonable, also deserved a separate patch.

1 0

Re: [PATCH 2/2] comctl32/propsheet: Make the PROPSHEET_RemovePage function similar to PROPSHEET_CleanUp
by Nikolay Sivov 09 Mar '17

09 Mar '17

On 09.03.2017 23:20, Hermès BÉLUSCA-MAÏTO wrote: > [PATCH 2/2] comctl32/propsheet: Make the PROPSHEET_RemovePage function > similar to PROPSHEET_CleanUp: > > - Use an auxiliary psp pointer to hold the psInfo->proppage[index].hpage; > > - Check psInfo->proppage[index].hwndPage before destroying the > associated window. > > /* Destroy page dialog window */ > - DestroyWindow(psInfo->proppage[index].hwndPage); > + if(psInfo->proppage[index].hwndPage) > + DestroyWindow(psInfo->proppage[index].hwndPage); Why is this important?

1 0

Re: [1/4] webservices: Unlock critical section before returning.
by Alexandre Julliard 09 Mar '17

09 Mar '17

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > Do I have to send feedback to the patches list to make sure it is not missed? ;) Sorry about that. Having replies go to the patches list would make things easier for me, but I expect others prefer to keep wine-patches only for patches. OTOH we already have signoffs in there... -- Alexandre Julliard julliard(a)winehq.org

5 5

Re: [PATCH] user32: Always send WM_NCACTIVATE when changing the foreground window.
by Alexandre Julliard 09 Mar '17

09 Mar '17

Alex Henrie <alexhenrie24(a)gmail.com> writes: > + if (send_msg_old) /* old window belongs to other thread */ > + SendNotifyMessageW( previous, WM_WINE_SETACTIVEWINDOW, 0, 0 ); > + else if (send_msg_new) /* old window belongs to us but new one to other thread */ > + ret = set_active_window( 0, NULL, mouse, TRUE ); > + > + if (GetActiveWindow() == hwnd) > { The active window is per-thread but SetForegroundWindow works across threads, so this can't do the right thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 10/10] wininet/tests: Added more HTTP read tests.
by Marvin 09 Mar '17

09 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29364 Your paranoid android. === wxppro (32 bit http) === http.c:5050: Test failed: http.c:314: Test failed: InternetReadFileExW failed: 997 http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:4634: Test failed: expected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) 1 times, received 2 times === wvistau64 (32 bit http) === http.c:5050: Test failed: InternetReadFileExW failed: 997 http.c:5056: Test failed: InternetQueryDataAvailable returned: 1(997) http.c:5056: Test failed: size = 10 http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:5060: Test failed: dwBufferLength = 10 http.c:5061: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 1 times, received 0 times http.c:5062: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 0 times http.c:314: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:314: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:5104: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 1 times, received 2 times http.c:5105: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 2 times === w2008s64 (32 bit http) === http.c:5050: Test failed: InternetReadFileExW failed: 997 http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:5061: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 1 times, received 0 times http.c:5062: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 0 times http.c:314: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:4634: Test failed: expected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) 1 times, received 2 times http.c:5105: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 2 times === wvistau64 (64 bit http) === http.c:5050: Test failed: InternetReadFileExW failed: 997 http.c:314: Test failed: http.c:382: 0364:Callback 0000000000CC0014 0xdeadbeef INTERNET_STATUS_CLOSING_CONNECTION 0000000000000000 0 http.c:4731: Test failed: expected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) 1 times, received 2 times === w2008s64 (64 bit http) === http.c:5050: Test failed: http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:5062: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 1 times, received 0 times http.c:314: Test failed: unexpected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) http.c:4634: Test failed: expected status 100 (INTERNET_STATUS_REQUEST_COMPLETE) 1 times, received 2 times

2 1

Re: [PATCH 05/10] wininet: Rewrite InternetReadFileEx for http protocol to make use of non-blocking reads.
by Marvin 09 Mar '17

09 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29362 Your paranoid android. === w2008s64 (64 bit http) === http.c:628: Test failed: req_error = 12029 http.c:652: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:653: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:654: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:655: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:664: Test failed: flags = 8, expected 0 0b30:http: unhandled exception c0000005 at 00000000004162E8

1 0

Re: [PATCH 1/5] winebus.sys: Handle linux input event device via udev
by Sebastian Lackner 09 Mar '17

09 Mar '17

On 27.02.2017 16:09, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/winebus.sys/bus.h | 3 + > dlls/winebus.sys/bus_udev.c | 150 ++++++++++++++++++++++++++++++++++++++++++-- > dlls/winebus.sys/main.c | 26 ++++++++ > 3 files changed, 173 insertions(+), 6 deletions(-) > I assume this is meant as a fallback, if we don't have access to hidraw, right? If you plan to use this as a replacement for dinput, it would be better to implement it without fixed dependency on udev. > > > 0001-winebus.sys-Handle-linux-input-event-device-via-udev.txt > > > diff --git a/dlls/winebus.sys/bus.h b/dlls/winebus.sys/bus.h > index effbd4afd0..fed35e8c1e 100644 > --- a/dlls/winebus.sys/bus.h > +++ b/dlls/winebus.sys/bus.h > @@ -43,3 +43,6 @@ DEVICE_OBJECT *bus_find_hid_device(const platform_vtbl *vtbl, void *platform_dev > void bus_remove_hid_device(DEVICE_OBJECT *device) DECLSPEC_HIDDEN; > NTSTATUS WINAPI hid_internal_dispatch(DEVICE_OBJECT *device, IRP *irp) DECLSPEC_HIDDEN; > void process_hid_report(DEVICE_OBJECT *device, BYTE *report, DWORD length) DECLSPEC_HIDDEN; > + > +/* General Bus Functions */ > +DWORD check_bus_option(UNICODE_STRING *registry_path, const UNICODE_STRING *option) DECLSPEC_HIDDEN; > diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c > index 415bd3db08..2dcc7fb442 100644 > --- a/dlls/winebus.sys/bus_udev.c > +++ b/dlls/winebus.sys/bus_udev.c > @@ -42,6 +42,14 @@ > # include <sys/ioctl.h> > #endif > > +#ifdef HAVE_LINUX_INPUT_H > +# include <linux/input.h> > +# undef SW_MAX > +# if defined(EVIOCGBIT) && defined(EV_ABS) && defined(BTN_PINKIE) > +# define HAS_PROPER_INPUT_HEADER > +# endif > +#endif > + > #define NONAMELESSUNION > > #include "ntstatus.h" > @@ -65,11 +73,15 @@ WINE_DECLARE_DEBUG_CHANNEL(hid_report); > > static struct udev *udev_context = NULL; > static DRIVER_OBJECT *udev_driver_obj = NULL; > +static DWORD disable_hidraw = 0; > +static DWORD disable_input = 0; > > static const WCHAR hidraw_busidW[] = {'H','I','D','R','A','W',0}; > +static const WCHAR lnxev_busidW[] = {'L','N','X','E','V',0}; > > #include "initguid.h" > DEFINE_GUID(GUID_DEVCLASS_HIDRAW, 0x3def44ad,0x242e,0x46e5,0x82,0x6d,0x70,0x72,0x13,0xf3,0xaa,0x81); > +DEFINE_GUID(GUID_DEVCLASS_LINUXEVENT, 0x1b932c0d,0xfea7,0x42cd,0x8e,0xaa,0x0e,0x48,0x79,0xb6,0x9e,0xaa); > > struct platform_private > { > @@ -392,6 +404,52 @@ static const platform_vtbl hidraw_vtbl = > hidraw_set_feature_report, > }; > > +#ifdef HAS_PROPER_INPUT_HEADER > + > +static NTSTATUS lnxev_get_reportdescriptor(DEVICE_OBJECT *device, BYTE *buffer, DWORD length, DWORD *out_length) > +{ > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static NTSTATUS lnxev_get_string(DEVICE_OBJECT *device, DWORD index, WCHAR *buffer, DWORD length) > +{ > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static NTSTATUS lnxev_begin_report_processing(DEVICE_OBJECT *device) > +{ > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static NTSTATUS lnxev_set_output_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *written) > +{ > + *written = 0; > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static NTSTATUS lnxev_get_feature_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *read) > +{ > + *read = 0; > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static NTSTATUS lnxev_set_feature_report(DEVICE_OBJECT *device, UCHAR id, BYTE *report, DWORD length, ULONG_PTR *written) > +{ > + *written = 0; > + return STATUS_NOT_IMPLEMENTED; > +} > + > +static const platform_vtbl lnxev_vtbl = { > + compare_platform_device, > + lnxev_get_reportdescriptor, > + lnxev_get_string, > + lnxev_begin_report_processing, > + lnxev_set_output_report, > + lnxev_get_feature_report, > + lnxev_set_feature_report, > +}; > +#endif > + > static void try_add_device(struct udev_device *dev) > { > DWORD vid = 0, pid = 0, version = 0; > @@ -400,6 +458,7 @@ static void try_add_device(struct udev_device *dev) > const char *subsystem; > const char *devnode; > WCHAR *serial = NULL; > + const char* gamepad = NULL; > int fd; > > if (!(devnode = udev_device_get_devnode(dev))) > @@ -419,6 +478,26 @@ static void try_add_device(struct udev_device *dev) > version = get_sysattr_dword(usbdev, "version", 10); > serial = get_sysattr_string(usbdev, "serial"); > } > +#ifdef HAS_PROPER_INPUT_HEADER > + else > + { > + struct input_id device_id = {0}; > + char device_uid[255] = {0}; > + > + if (ioctl(fd, EVIOCGID, &device_id) == -1) > + WARN("ioctl(EVIOCGID) failed: %d %s\n", errno, strerror(errno)); > + if (ioctl(fd, EVIOCGUNIQ(254), device_uid) && device_uid[0]) > + MultiByteToWideChar(CP_UNIXCP, 0, device_uid, -1, serial, 255); I don't think this will work as expected. serial is a NULL pointer, and the check if ioctl() was successful is also done wrong. On error a value < 0 is returned. > + > + gamepad = udev_device_get_property_value(dev, "ID_INPUT_JOYSTICK"); > + vid = device_id.vendor; > + pid = device_id.product; > + version = device_id.version; > + } > +#else > + else > + WARN("Could not get device to query VID, PID, Version and Serial\n"); > +#endif > > TRACE("Found udev device %s (vid %04x, pid %04x, version %u, serial %s)\n", > debugstr_a(devnode), vid, pid, version, debugstr_w(serial)); > @@ -429,6 +508,12 @@ static void try_add_device(struct udev_device *dev) > device = bus_create_hid_device(udev_driver_obj, hidraw_busidW, vid, pid, version, 0, serial, FALSE, > &GUID_DEVCLASS_HIDRAW, &hidraw_vtbl, sizeof(struct platform_private)); > } > +#ifdef HAS_PROPER_INPUT_HEADER > + else if (strcmp(subsystem, "input") == 0) > + { > + device = bus_create_hid_device(udev_driver_obj, lnxev_busidW, vid, pid, version, 0, serial, (gamepad != NULL), &GUID_DEVCLASS_LINUXEVENT, &lnxev_vtbl, sizeof(struct platform_private)); Some linebreaks wouldn't hurt. > + } > +#endif > > if (device) > { > @@ -448,8 +533,17 @@ static void try_add_device(struct udev_device *dev) > > static void try_remove_device(struct udev_device *dev) > { > - DEVICE_OBJECT *device = bus_find_hid_device(&hidraw_vtbl, dev); > - struct platform_private *private; > + DEVICE_OBJECT *device = NULL; > + const char* subsystem; > + struct platform_private* private; > + > + subsystem = udev_device_get_subsystem(dev); > + if (strcmp(subsystem, "hidraw") == 0) > + device = bus_find_hid_device(&hidraw_vtbl, dev); > +#ifdef HAS_PROPER_INPUT_HEADER > + else if (strcmp(subsystem, "input") == 0) > + device = bus_find_hid_device(&lnxev_vtbl, dev); > +#endif It might be easier to just check both after each other, like: device = bus_find_hid_device(...); if (!device) device = bus_find_hid_device(...); > if (!device) return; > > IoInvalidateDeviceRelations(device, RemovalRelations); > @@ -483,8 +577,18 @@ static void build_initial_deviceset(void) > return; > } > > - if (udev_enumerate_add_match_subsystem(enumerate, "hidraw") < 0) > - WARN("Failed to add subsystem 'hidraw' to enumeration\n"); > + if (!disable_hidraw) > + if (udev_enumerate_add_match_subsystem(enumerate, "hidraw") < 0) > + WARN("Failed to add subsystem 'hidraw' to enumeration\n"); > +#ifdef HAS_PROPER_INPUT_HEADER > + if (!disable_input) > + { > + if (udev_enumerate_add_match_subsystem(enumerate, "event") < 0) > + WARN("Failed to add subsystem 'event' to enumeration\n"); Why do you add this match when results are not processed anywhere? > + if (udev_enumerate_add_match_subsystem(enumerate, "input") < 0) > + WARN("Failed to add subsystem 'input' to enumeration\n"); > + } > +#endif > > if (udev_enumerate_scan_devices(enumerate) < 0) > WARN("Enumeration scan failed\n"); > @@ -509,6 +613,7 @@ static void build_initial_deviceset(void) > static struct udev_monitor *create_monitor(struct pollfd *pfd) > { > struct udev_monitor *monitor; > + int systems = 0; > > monitor = udev_monitor_new_from_netlink(udev_context, "udev"); > if (!monitor) > @@ -517,8 +622,27 @@ static struct udev_monitor *create_monitor(struct pollfd *pfd) > return NULL; > } > > - if (udev_monitor_filter_add_match_subsystem_devtype(monitor, "hidraw", NULL) < 0) > - WARN("Failed to add subsystem 'hidraw' to monitor\n"); > + if (!disable_hidraw) > + { > + if (udev_monitor_filter_add_match_subsystem_devtype(monitor, "hidraw", NULL) < 0) > + WARN("Failed to add 'hidraw' subsystem to monitor\n"); > + else > + systems++; > + } > +#ifdef HAS_PROPER_INPUT_HEADER > + if (!disable_input) > + { > + if (udev_monitor_filter_add_match_subsystem_devtype(monitor, "input", NULL) < 0) > + WARN("Failed to add 'input' subsystem to monitor\n"); > + else > + systems++; > + } > +#endif > + if (systems == 0) > + { > + WARN("No subsystems added to monitor\n"); > + goto error; > + } > > if (udev_monitor_enable_receiving(monitor) < 0) > goto error; > @@ -589,6 +713,10 @@ NTSTATUS WINAPI udev_driver_init(DRIVER_OBJECT *driver, UNICODE_STRING *registry > { > HANDLE events[2]; > DWORD result; > + static const WCHAR hidraw_disabledW[] = {'D','i','s','a','b','l','e',' ','h','i','d','r','a','w',0}; > + static const UNICODE_STRING hidraw_disabled = {sizeof(hidraw_disabledW) - sizeof(WCHAR), sizeof(hidraw_disabledW), (WCHAR*)hidraw_disabledW}; > + static const WCHAR input_disabledW[] = {'D','i','s','a','b','l','e',' ','i','n','p','u','t',0}; > + static const UNICODE_STRING input_disabled = {sizeof(input_disabledW) - sizeof(WCHAR), sizeof(input_disabledW), (WCHAR*)input_disabledW}; > > TRACE("(%p, %s)\n", driver, debugstr_w(registry_path->Buffer)); > > @@ -602,6 +730,16 @@ NTSTATUS WINAPI udev_driver_init(DRIVER_OBJECT *driver, UNICODE_STRING *registry > driver->MajorFunction[IRP_MJ_PNP] = common_pnp_dispatch; > driver->MajorFunction[IRP_MJ_INTERNAL_DEVICE_CONTROL] = hid_internal_dispatch; > > + disable_hidraw = check_bus_option(registry_path, &hidraw_disabled); > + if (disable_hidraw) > + TRACE("UDEV hidraw devices disabled in registry\n"); > + > +#ifdef HAS_PROPER_INPUT_HEADER > + disable_input = check_bus_option(registry_path, &input_disabled); > + if (disable_input) > + TRACE("UDEV input devices disabled in registry\n"); > +#endif Does it hurt when both hidraw and input event devices are found? If yes, it would be better to filter duplicates somewhere else, instead of using registry keys. > + > if (!(events[0] = CreateEventW(NULL, TRUE, FALSE, NULL))) > goto error; > if (!(events[1] = CreateThread(NULL, 0, deviceloop_thread, events[0], 0, NULL))) > diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c > index 978540bb17..0388f0263c 100644 > --- a/dlls/winebus.sys/main.c > +++ b/dlls/winebus.sys/main.c > @@ -625,6 +625,32 @@ void process_hid_report(DEVICE_OBJECT *device, BYTE *report, DWORD length) > LeaveCriticalSection(&ext->report_cs); > } > > +DWORD check_bus_option(UNICODE_STRING *registry_path, const UNICODE_STRING *option) > +{ > + OBJECT_ATTRIBUTES attr; > + HANDLE key; > + DWORD output = 0; > + > + InitializeObjectAttributes(&attr, registry_path, OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, NULL, NULL); > + if (NtOpenKey(&key, KEY_ALL_ACCESS, &attr) == STATUS_SUCCESS) > + { > + DWORD size; > + char buffer[FIELD_OFFSET(KEY_VALUE_PARTIAL_INFORMATION, Data[sizeof(DWORD)])]; > + > + KEY_VALUE_PARTIAL_INFORMATION *info = (KEY_VALUE_PARTIAL_INFORMATION*)buffer; > + > + if (NtQueryValueKey(key, option, KeyValuePartialInformation, info, sizeof(buffer), &size) == STATUS_SUCCESS) > + { > + if (info->Type == REG_DWORD) > + output = *(DWORD*)info->Data; > + } > + > + NtClose(key); > + } > + > + return output; > +} > + > NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path ) > { > static const WCHAR udevW[] = {'\\','D','r','i','v','e','r','\\','U','D','E','V',0}; > > >

3 5

Re: [PATCH 2/8] wined3d: Unbind textures in context_bind_shader_resources().
by Henri Verbeet 09 Mar '17

09 Mar '17

On 9 March 2017 at 10:03, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The WINED3D_LEGACY_TEXTURE_BINDING flag should prevent from generating > the "No resource view bound at index" warnings in D3D9-, allows to > safely unbind resources in context_bind_shader_resources(), and make it > easier easier to add support for more samplers in D3D10+. > The issue is texture bindings set through wined3d_device_set_texture(), right? Could we get rid of wined3d_device_set_texture() and create shader resource views for those textures instead, similar to how we create rendertarget views in d3d9, etc.? IIRC one of the issues was interactions with sampler and texture stage states. Tangentially, how does this work with "Aon9" shaders?

2 3

Re: [PATCH] crypt32/tests: Fix a memory leak in testFindCRL.
by Erich E. Hoover 08 Mar '17

08 Mar '17

On Sun, Feb 26, 2017 at 11:52 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > ... > + store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, 0, > + CERT_STORE_CREATE_NEW_FLAG, NULL); > + if (!store) return; > + > ... Would you mind adding an error when this happens? Otherwise we may not know that these tests did not run. Best, Erich

2 2

Re: [PATCH 5/5] d3d9/tests: Fix pixel shader version check in test_pointsize().
by Marvin 08 Mar '17

08 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29312 Your paranoid android. === w8 (32 bit visual) === visual.c:7931: Test failed: Input test: Quad 3(2crd-wrongidx) returned color 0x00ff00ff, expected 0x00ff0080 visual.c:8099: Test failed: Got unexpected color 0x00ff0000 for no color attribute test. === w864 (64 bit visual) === visual.c:7947: Test failed: Input test: Quad 3(2crd-wrongidx) returned color 0x00ff00ff, expected 0x00ff0080 visual.c:7995: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors). visual.c:8099: Test failed: Got unexpected color 0x00ff0000 for no color attribute test.

1 0

Re: [PATCH 4/5] d3d9/tests: Skip test_vshader_input() if PS 3.0 isn't supported.
by Marvin 08 Mar '17

08 Mar '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=29311 Your paranoid android. === w864 (32 bit visual) === visual.c:8099: Test failed: Got unexpected color 0x00ff00ff for no color attribute test.

1 0

Re: [2/8] webservices: Protect messages with a critical section.
by Sebastian Lackner 08 Mar '17

08 Mar '17

On 08.03.2017 11:25, Hans Leidekker wrote: > + } > } > > msg->is_addressed = TRUE; Not sure if it matters, but previously this was skipped in case of a failure. Also please note that depending on how many objects are used by an application, a separate CS for each might significantly increase memory usage. > - return S_OK; > + > + LeaveCriticalSection( &msg->cs ); > + return hr; [...] > - msg->init = init; > - msg->state = WS_MESSAGE_STATE_INITIALIZED; > - return write_envelope( msg ); > + if ((hr = write_envelope( msg )) == S_OK) > + { > + msg->init = init; > + msg->state = WS_MESSAGE_STATE_INITIALIZED; > + } Here, the new code also does something else than the old one. Previously the msg fields were changed unconditionally.

2 1

Re: [5/8] webservices: Protect writers with a critical section.
by Sebastian Lackner 08 Mar '17

08 Mar '17

On 08.03.2017 11:25, Hans Leidekker wrote: > + if ((hr = write_set_element_namespace( writer )) != S_OK) goto done; > + if ((hr = write_startelement( writer )) != S_OK) goto done; > + if ((hr = write_endstartelement( writer )) != S_OK) goto done; > writer->state = WRITER_STATE_ENDSTARTELEMENT; > + > +done: > + LeaveCriticalSection( &writer->cs ); > return S_OK; You should return hr here. > for (i = offset; i < count; i++) > { > const char *ptr = (const char *)array + (offset + i) * type_size; > - if ((hr = write_element_node( writer, NULL, localname, ns )) != S_OK) return hr; > + if ((hr = write_element_node( writer, NULL, localname, ns )) != S_OK) goto done; > if ((hr = write_type( writer, WS_ELEMENT_TYPE_MAPPING, type, NULL, WS_WRITE_REQUIRED_POINTER, > - &ptr, sizeof(ptr) )) != S_OK) return hr; > - if ((hr = write_endelement_node( writer )) != S_OK) return hr; > + &ptr, sizeof(ptr) )) != S_OK) goto done; > + if ((hr = write_endelement_node( writer )) != S_OK) goto done; > } > > - return S_OK; > +done: > + LeaveCriticalSection( &writer->cs ); > + return hr; It looks like hr will be undefined here if count == 0 > } > > /************************************************************************** > @@ -2392,9 +2662,20 @@ HRESULT WINAPI WsWriteXmlBuffer( WS_XML_WRITER *handle, WS_XML_BUFFER *buffer, W > > if (!writer || !xmlbuf) return E_INVALIDARG; > > - if ((hr = write_flush( writer )) != S_OK) return hr; > - if ((hr = write_grow_buffer( writer, xmlbuf->size )) != S_OK) return hr; > + EnterCriticalSection( &writer->cs ); > + > + if (writer->magic != WRITER_MAGIC) > + { > + LeaveCriticalSection( &writer->cs ); > + return E_INVALIDARG; > + } > + > + if ((hr = write_flush( writer )) != S_OK) goto done; > + if ((hr = write_grow_buffer( writer, xmlbuf->size )) != S_OK) goto done; > write_bytes( writer, xmlbuf->ptr, xmlbuf->size ); > + > +done: > + LeaveCriticalSection( &writer->cs ); > return S_OK; Here you should also use hr.

1 0

Re: [PATCH] kernel32/tests: Add 64bit number tests for FormatMessage[A|W] (try 2)
by Sebastian Lackner 08 Mar '17

08 Mar '17

On 08.03.2017 15:42, Bruno Jesus wrote: > + { -1, "-1", 2}, > + { ULL(0xFFFFFFFF,0xFFFFFFFF), "-1", 2}, You can remove the second test. 0xffffffffffffffff and -1 are just different representations for the same number. Best regards, Sebastian

2 1

Re: bcrypt: Add a builtin sha384/sha512 implementation. (v2)
by Sebastian Lackner 08 Mar '17

08 Mar '17

On 08.03.2017 12:17, Jacek Caban wrote: > On 08.03.2017 12:03, Sebastian Lackner wrote: >> +void sha512_init(SHA512_CTX *ctx) >> +{ >> + ctx->len = 0; >> + ctx->h[0] = 0x6a09e667f3bcc908; >> + ctx->h[1] = 0xbb67ae8584caa73b; >> + ctx->h[2] = 0x3c6ef372fe94f82b; >> + ctx->h[3] = 0xa54ff53a5f1d36f1; >> + ctx->h[4] = 0x510e527fade682d1; >> + ctx->h[5] = 0x9b05688c2b3e6c1f; >> + ctx->h[6] = 0x1f83d9abfb41bd6b; >> + ctx->h[7] = 0x5be0cd19137e2179; > > > I think those are still not portable, because those constants are too > large. You may use something like ((ULONG64)0x6a09e667<<32)|0xf3bcc908. > > > Jacek I was wondering about that too, but it looks like we have already various places where 64-bit consts are used without any ugly tricks. Examples are in tests, include files, and also implementation code. Is it really necessary? Or is it only the suffix which causes trouble? Best regards, Sebastian

2 1

Re: [4/5] bcrypt: Add a builtin sha384/sha512 implementation.
by Hans Leidekker 08 Mar '17

08 Mar '17

On Tue, 2017-03-07 at 23:16 +0100, Sebastian Lackner wrote: > +void sha384_init(SHA512_CTX *ctx) > +{ > + ctx->len = 0; > + ctx->h[0] = 0xcbbb9d5dc1059ed8ULL; > + ctx->h[1] = 0x629a292a367cd507ULL; > + ctx->h[2] = 0x9159015a3070dd17ULL; > + ctx->h[3] = 0x152fecd8f70e5939ULL; > + ctx->h[4] = 0x67332667ffc00b31ULL; > + ctx->h[5] = 0x8eb44a8768581511ULL; > + ctx->h[6] = 0xdb0c2e0d64f98fa7ULL; > + ctx->h[7] = 0x47b5481dbefa4fa4ULL; We try to avoid the (U)LL suffix. The patch set looks good otherwise.

2 1

Re: [PATCH] d3dx9/tests: Add test for out of bound array selector in effect.
by Matteo Bruni 07 Mar '17

07 Mar '17

2017-03-07 18:47 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Hi Paul! Patch looks mostly good to me BUT I have a couple comments anyway... > --- > dlls/d3dx9_36/tests/effect.c | 159 ++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 141 insertions(+), 18 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c > index b3845c5..fe84173 100644 > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -3813,6 +3813,33 @@ static const DWORD test_effect_preshader_effect_blob[] = > #define TEST_EFFECT_PRESHADER_VSHADER_POS 2458 > #define TEST_EFFECT_PRESHADER_VSHADER_LEN 13 > > +static BOOL test_effect_preshader_compare_shader(IDirect3DDevice9 *device, int expected_shader_index) > +{ > + IDirect3DVertexShader9 *vshader; > + void *byte_code; > + unsigned int byte_code_size; > + HRESULT hr; > + BOOL ret; > + > + if (FAILED(hr = IDirect3DDevice9_GetVertexShader(device, &vshader)) || !vshader) > + return FALSE; It seems preferable to keep the detailed ok() calls from the old test instead of a generic ok() message on the return value of test_effect_preshader_compare_shader(). I guess you want to avoid to have ambiguous ok() calls in this helper. Until we get something like the with_context() thing from https://source.winehq.org/patches/data/131137 just passing a string with the test name to the helper function and using that in the ok() messages should do the trick. > + hr = effect->lpVtbl->BeginPass(effect, 1); > + todo_wine ok(hr == E_FAIL, "Got result %#x.\n", hr); > + if (SUCCEEDED(hr)) > + effect->lpVtbl->EndPass(effect); > + > + hr = effect->lpVtbl->BeginPass(effect, 1); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); That reminds me, do we have tests for two BeginPass() calls without an EndPass() in between? Might be interesting to see what happens both with the same or different pass index. Other somewhat interesting cases might be BeginPass() outside of Begin() / End() and multiple Begin() / End() / EndPass() calls in a row. It should probably be in a separate patch though. BTW, I think it's somewhat idiomatic to call it "out of bounds" even when technically there is a single bound involved.

2 3

Interested in Wine Outreachy Application
by Sreya Mittal 07 Mar '17

07 Mar '17

Hi, I am Sreya Mittal pursuing my Btech in Computer Science at International Institute of Information Technology, Hyderabad. I am interested in getting started with open-source contributions and looking forward to becoming a part of Wine and Outreachy community. I am proficient in C. This would help in the work. I would be grateful if I could get a few pointers regarding how to get started. Thank you, Sreya

4 5

Re: kernel32: add stub for GetCurrentPackageFullName
by Sebastian Lackner 07 Mar '17

07 Mar '17

On 04.03.2017 11:05, Louis Lenders wrote: > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -629,6 +629,7 @@ > @ stdcall GetCurrentDirectoryA(long ptr) > @ stdcall GetCurrentDirectoryW(long ptr) > @ stdcall GetCurrentPackageId(ptr ptr) > +@ stdcall GetCurrentPackageFullName(ptr ptr) > @ stdcall -norelay GetCurrentProcess() > @ stdcall -norelay GetCurrentProcessId() > @ stdcall GetCurrentProcessorNumber() ntdll.NtGetCurrentProcessorNumber In this case its too late, but please make sure to keep the specfile ordered alphabetically in the future.

2 1

Re: [PATCH v2 2/5] winebus.sys: Build device reports for linux event devices
by Roderick Colenbrander 07 Mar '17

07 Mar '17

Hi Aric, I have had a quick look over this patch and have some initial feedback, maybe more later if time permits. For the absolute and relative axes don't hard code the minimum and maximum values for the report descriptors. These are not correct for many devices e.g. Xbox controllers use 16-bit absolute axes, while DS3/DS4 for example use 8-bit. In addition xbox controllers use signed data, while DS3/DS4 use unsigned (0-255)Also many devices use signed data. You should rely on the absinfo data returned by EVIOCGABS and base your input ranges on that. Thanks, Roderick On Mon, Feb 27, 2017 at 9:32 AM, Aric Stewart <aric(a)codeweavers.com> wrote: > > v2: Updates from Sebastian Lackner > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/winebus.sys/bus_udev.c | 438 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 436 insertions(+), 2 deletions(-) > > > > >

2 2

Re: qcap: Fix compile error when O_CLOEXEC is not defined.
by Alexandre Julliard 07 Mar '17

07 Mar '17

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > Defining to 0 ensures that it doesn't do any harm. If we don't > care about ancient systems, we can probably also remove the fcntl call. > On modern systems, setting CLOEXEC twice (via open and fcntl) shouldn't > hurt. I'm too lazy to check, but I'm wondering if passing O_CLOEXEC would cause the open to fail on an ancient system, and whether we should be checking for EINVAL and retrying... -- Alexandre Julliard julliard(a)winehq.org

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel