- wine-devel - winehq.org

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Nikolay Sivov 14 Jan '17

14 Jan '17

On 14.01.2017 22:33, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/gdi32/gdi32.spec | 2 ++ > dlls/gdi32/gdiobj.c | 12 ++++++++++++ > dlls/user32/sysparams.c | 23 +++++++++++++++++------ > dlls/user32/tests/sysparams.c | 16 ++++++++++++++++ > include/wine/gdi_driver.h | 2 ++ > 5 files changed, 49 insertions(+), 6 deletions(-) > > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 7792731b9e..f9c3fb9293 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -518,6 +518,8 @@ > # GDI objects > @ cdecl __wine_make_gdi_object_system(long long) > @ cdecl __wine_set_visible_region(long long ptr ptr ptr) > +@ cdecl __wine_GDI_ReleaseObj(ptr) > +@ cdecl __wine_GDI_GetObjPtr(ptr long) > > # Graphics drivers > @ cdecl __wine_set_display_driver(long) > diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c > index 46b2241945..aa2ced1025 100644 > --- a/dlls/gdi32/gdiobj.c > +++ b/dlls/gdi32/gdiobj.c > @@ -880,6 +880,18 @@ void GDI_ReleaseObj( HGDIOBJ handle ) > LeaveCriticalSection( &gdi_section ); > } > > +/* Exports for user32, we need to be able to manipulate GDI objects where the official API doesn't allow us */ > + > +void* CDECL __wine_GDI_GetObjPtr( HGDIOBJ handle, WORD type ) > +{ > + return GDI_GetObjPtr( handle, type ); > +} > + > +void CDECL __wine_GDI_ReleaseObj( HGDIOBJ handle ) > +{ > + GDI_ReleaseObj( handle ); > +} > + > This is too much. If you only need to update object property while keeping same handle, you only need one additional call like __wine_set_gdi_object_color(), that should work for both brushes and pens, checking if it's a system object too, as an additional precaution. > +static void set_syscolors_gdi( INT index, COLORREF color ) > +{ > + HBRUSH brush = system_colors[index].brush; > + LOGBRUSH *brush_info; > + > + if(brush) > + { > + /* Since LOGBRUSH is the first member in BRUSHOBJ we just do a cast here */ > + brush_info = __wine_GDI_GetObjPtr( brush, OBJ_BRUSH ); > + if(brush_info->lbColor != color) > + brush_info->lbColor = color; > + __wine_GDI_ReleaseObj( brush ); > + } > +} > This looks very dirty.

2 1

Re: [PATCH 1/2] user32: SetSysColors updates brushes from GetSysColorBrush and add test
by Marvin 14 Jan '17

14 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27773 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:259: SPI_SETSCREENSAVETIMEOUT failed for reason: 329. Indicating test failure and skipping remainder of test sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:260: Test failed: SystemParametersInfoA: rc=0 err=329 sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/3] winemac: Export HTML Format clipboard data to the public.html pasteboard type.
by Sebastian Lackner 13 Jan '17

13 Jan '17

On 13.01.2017 20:36, Ken Thomases wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > dlls/winemac.drv/clipboard.c | 68 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 67 insertions(+), 1 deletion(-) > > diff --git a/dlls/winemac.drv/clipboard.c b/dlls/winemac.drv/clipboard.c > index fdd1110..49a3ed3 100644 > --- a/dlls/winemac.drv/clipboard.c > +++ b/dlls/winemac.drv/clipboard.c > @@ -82,6 +82,7 @@ static CFDataRef export_bitmap_to_bmp(HANDLE data); > static CFDataRef export_dib_to_bmp(HANDLE data); > static CFDataRef export_enhmetafile(HANDLE data); > static CFDataRef export_hdrop_to_filenames(HANDLE data); > +static CFDataRef export_html(HANDLE data); > static CFDataRef export_metafilepict(HANDLE data); > static CFDataRef export_text_to_utf8(HANDLE data); > static CFDataRef export_unicodetext_to_utf8(HANDLE data); > @@ -186,7 +187,7 @@ static const struct > { wszJFIF, CFSTR("public.jpeg"), import_clipboard_data, export_clipboard_data }, > { wszPNG, CFSTR("public.png"), import_clipboard_data, export_clipboard_data }, > { wszHTMLFormat, NULL, import_clipboard_data, export_clipboard_data }, > - { wszHTMLFormat, CFSTR("public.html"), import_html, NULL, TRUE }, > + { wszHTMLFormat, CFSTR("public.html"), import_html, export_html, TRUE }, > { CFSTR_SHELLURLW, CFSTR("public.url"), import_utf8_to_text, export_text_to_utf8 }, > }; > > @@ -522,6 +523,28 @@ static HANDLE create_bitmap_from_dib(HANDLE dib) > > > /************************************************************************** > + * get_html_description_field > + * > + * Find the value of a field in an HTML Format description. > + */ > +static const char* get_html_description_field(const char* data, const char* keyword) > +{ > + const char* pos = data; > + > + while (pos && *pos && *pos != '<') > + { > + if (memcmp(pos, keyword, strlen(keyword)) == 0) Its not safe to use memcmp, it could read past the terminating \0 of data. > + return pos + strlen(keyword); > + > + pos = strchr(pos, '\n'); > + if (pos) pos++; > + } > + > + return NULL; > +} > + > + > +/************************************************************************** > * import_clipboard_data > * > * Generic import clipboard data routine. > @@ -1141,6 +1164,49 @@ done: > > > /************************************************************************** > + * export_html > + * > + * Export HTML Format to public.html data. > + * > + * FIXME: We should attempt to add an <a base> tag and convert windows paths. > + */ > +static CFDataRef export_html(HANDLE handle) > +{ > + CFDataRef ret; > + const char *data, *field_value; > + int fragmentstart, fragmentend; > + > + data = GlobalLock(handle); > + > + /* read the important fields */ > + field_value = get_html_description_field(data, "StartFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find StartFragment value\n"); > + goto failed; > + } > + fragmentstart = atoi(field_value); > + > + field_value = get_html_description_field(data, "EndFragment:"); > + if (!field_value) > + { > + ERR("Couldn't find EndFragment value\n"); > + goto failed; > + } > + fragmentend = atoi(field_value); > + > + /* export only the fragment */ > + ret = CFDataCreate(NULL, (const UInt8*)&data[fragmentstart], fragmentend - fragmentstart); Some validation of those offsets wouldn't hurt. > + GlobalUnlock(handle); > + return ret; > + > +failed: > + GlobalUnlock(handle); > + return NULL; > +} > + > + > +/************************************************************************** > * export_metafilepict > * > * Export a metafile to data. >

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Henri Verbeet 13 Jan '17

13 Jan '17

On 13 January 2017 at 12:53, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 > Strictly speaking that's not a regression, but I'm willing to risk it.

1 0

Re: [PATCH] wined3d: Add Iris Haswell PCI ids and descriptions
by André Hentschel 13 Jan '17

13 Jan '17

Am 13.01.2017 um 06:42 schrieb Michael Cronenworth: > --- > dlls/wined3d/directx.c | 11 +++++++++++ > dlls/wined3d/wined3d_private.h | 9 +++++++++ > 2 files changed, 20 insertions(+) > Hi, you forgot to sign off your patch

2 1

Re: [PATCH 03/12] d3d8: Return D3D_OK from UnlockRect() for not locked textures.
by Bruno Jesus 13 Jan '17

13 Jan '17

On Fri, Jan 13, 2017 at 9:53 AM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > Fixes bug 19862 > https://bugs.winehq.org/show_bug.cgi?id=19862 Most likely also fixes https://bugs.winehq.org/show_bug.cgi?id=28874

1 0

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Józef Kucia 13 Jan '17

13 Jan '17

On Fri, Jan 13, 2017 at 12:53 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d9/tests/visual.c | 81 ------------------------------------------------ > 1 file changed, 81 deletions(-) There is a typo in the subject prefix. It should read "d3d9/tests:".

1 0

Re: [tools] patches: Say "translation files" instead of "resource files".
by Henri Verbeet 13 Jan '17

13 Jan '17

On 13 January 2017 at 05:47, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > @@ -69,7 +69,7 @@ my @legend = > [ "formatting", "<ul><li>The patch author's full name, email address, or Signed-off-by headers are incorrect or missing.</li>" . > "<li>Whitespace got mangled in transit.</li>" . > "<li>Indentation is messed up (usually from editing with a non-standard tab size).</li>" . > - "<li>8-bit chars got mangled in transit (usually when sending patches to resource files).</li>" . > + "<li>8-bit chars got mangled in transit (usually when sending patches to translation files).</li>" . I guess this is fine, and not to make too much of a point of it, but this might as well read "usually when not using git send-email".

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Dmitry Timoshkov 13 Jan '17

13 Jan '17

Anton Romanov <theli.ua(a)gmail.com> wrote: > +todo_wine { > + enabled = 2; > + ret = getsockopt(v4, IPPROTO_IPV6, IPV6_V6ONLY, (char*)&enabled, &len); > + ok(!ret, "getsockopt(IPV6_ONLY) failed (LastError: %d)\n", WSAGetLastError()); > + ok(enabled == 1, "expected 1, got %d\n", enabled); > +} The 'todo_wine' statements should be added only around ok() call that will fail otherwise. This applies for other places in the patch as well. -- Dmitry.

2 4

Re: [PATCH v4] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin 12 Jan '17

12 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27729 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH v3] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Marvin 12 Jan '17

12 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27728 Your paranoid android. === build (build) === Patch failed to apply

1 0

TaskDialog implementation - Feedback needed
by Fabian Maurer 12 Jan '17

12 Jan '17

Hello, As already mentioned in "commctl32: TaskDialog", I'm currently working on a full implementation for TaskDialogIndirect. Now that I have a working foundation, I figured I ask for feedback instead of having to rewrite it later. Since TaskDialogs are very dynamic, the approach is to create a dialog template in memory, and then show it as dialog box. I attached 3 patches which create a small dialog. Though it doesn't do much (or anything) yet, it should be very easy to start from there and add all the missing functionality piece by piece. Criticism welcome. Fabian

1 0

Re: [PATCH v2] ws2_32:Succeed IPV6_V6ONLY setsockopt for AF_INET sockets ignoring it
by Sebastian Lackner 12 Jan '17

12 Jan '17

On 12.01.2017 06:27, Anton Romanov wrote: > + > + bound = is_fd_bound(fd, &uaddr, &uaddrlen); > + release_sock_fd( s, fd ); > + if (uaddr.addr.sa_family == AF_INET && bound == 0) You might want to change the order here, uaddr is not initialized if is_fd_bound fails.

2 1

Re: [PATCH] wine.inf: Add Dynamic DST data for Asia/Tehran.
by Sebastian Lackner 12 Jan '17

12 Jan '17

On 12.01.2017 14:08, Henri Verbeet wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > loader/wine.inf.in | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > Could you please also add day-of-week information, like its done in all the other Dynamic DST entries? Besides that, I'm also not sure if we really need registry entries for dates back until 1991. I have intentionally left out such information in the past. Best regards, Sebastian

2 1

Re: [v2] oleaut32: Make the heap allocation functions static.
by Alexandre Julliard 12 Jan '17

12 Jan '17

Francois Gouget <fgouget(a)free.fr> writes: > @@ -1600,26 +1600,26 @@ static void TLB_abort(void) > DebugBreak(); > } > > -void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > +static void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(unsigned size) > { > void *ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > if (!ret) ERR("cannot allocate memory\n"); > return ret; > } There are standard functions that I expect we'd want to use in more places (right Michael?) -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: iphlpapi: Avoid sockaddr scope confusion
by Alexandre Julliard 11 Jan '17

11 Jan '17

André Hentschel <nerv(a)dawncrow.de> writes: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/iphlpapi/iphlpapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't look to me like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] Disabling IPV6_V6ONLY on AF_INET succeeds in Windows starting with Vista
by Bruno Jesus 11 Jan '17

11 Jan '17

On Tue, Jan 10, 2017 at 3:44 PM, Anton Romanov <theli.ua(a)gmail.com> wrote: > Fixes Magic The Gathering Online not able to login > --- > dlls/ws2_32/socket.c | 22 ++++++++++++++++++++++ > dlls/ws2_32/tests/sock.c | 24 +++++++++++++++++++++++- > 2 files changed, 45 insertions(+), 1 deletion(-) Hi, can you please open a bug report attaching a +winsock so we can discuss this further? Best wishes, Bruno

2 4

Re: Wine po issue page broken?
by Francois Gouget 11 Jan '17

11 Jan '17

Lauri Kenttä wrote: > With proper spell checking, I could take a look at the Swedish > translation, but the Swedish spell checking on wine-po has always been > broken (includes dots in words and so produces hundreds of false > positives). I'm not sure the periods are an issue. The command I run is: aspell -l sv --encoding utf-8 And it seems to return the same result whether there is a trailing period or not: arraygränser. # arraygränser. 0 arraygränser # arraygränser 0 cmd-fönstret. # cmd-fönstret. 0 cmd-fönstret # cmd-fönstret 0 drivrutinsnivå. ? drivrutinsnivå. 0 0: driv drivrutinsnivå ? drivrutinsnivå 0 0: driv konsoll. & konsoll. 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors konsoll & konsoll 23 0: konsul, gondol, kontroll, konselj, konsuln, konsuls, konsult, knöl, kons, känslo, köns, kondom, konst, konto, gondols, kossor, konton, kontor, kontot, konvoj, känsel, sonson, kossors -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

Re: [v2 PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27687 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH 1/2] ddraw/tests: Try to avoid killing the Intel (kernel) driver.
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27682 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2445: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2294: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2314: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2588: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Alexandre Julliard 10 Jan '17

10 Jan '17

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/user32/tests/win.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) This doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:6758: Test failed: Unexpected text length, 7 win.c:6760: Test failed: Unexpected buffer contents, 0x20ac win.c:6769: Test failed: Unexpected text length, 18 win.c:6771: Test failed: Unexpected buffer contents make: *** [win.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/2] riched20: Only pass valid length to ME_InsertTextFromCursor
by Huw Davies 10 Jan '17

10 Jan '17

On Mon, Jan 09, 2017 at 06:08:12PM +0100, Fabian Maurer wrote: > This only affects ME_SetText and fnTextSrv_TxSetText, > should make it a bit more readable. > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/caret.c | 2 -- > dlls/riched20/editor.c | 4 +++- > dlls/riched20/txtsrv.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c > index 26af743518..94794890b6 100644 > --- a/dlls/riched20/caret.c > +++ b/dlls/riched20/caret.c > @@ -526,8 +526,6 @@ void ME_InsertTextFromCursor(ME_TextEditor *editor, int nCursor, > assert(style); > > assert(nCursor>=0 && nCursor<editor->nCursors); > - if (len == -1) > - len = lstrlenW(str); > > /* grow the text limit to fit our text */ > if(editor->nTextLimit < oldLen +len) > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 1ce444e604..8873861aee 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -3323,7 +3323,9 @@ static void ME_SetText(ME_TextEditor *editor, void *text, BOOL unicode) > int len = -1; > > /* uses default style! */ > - if (!(editor->styleFlags & ES_MULTILINE)) > + if (editor->styleFlags & ES_MULTILINE) > + len = lstrlenW(wszText); > + else > { > WCHAR *p = wszText; > > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 307b484352..a21ef5a02f 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -288,7 +288,7 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_SetCursorToStart(This->editor, &cursor); > ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > if(pszText) > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > + ME_InsertTextFromCursor(This->editor, 0, pszText, lstrlenW(pszText), This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); I'm not convinced this is an improvement. Huw.

2 1

Re: [PATCH] wined3d: Add FIXME for WINED3D_BLT_WAIT.
by Henri Verbeet 10 Jan '17

10 Jan '17

On 10 January 2017 at 15:02, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/wined3d/surface.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Why?

1 0

Re: imm32/tests: A spelling fix in an ok() message.
by Aric Stewart 10 Jan '17

10 Jan '17

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: usp10: A spelling fix in a comment
by Aric Stewart 10 Jan '17

10 Jan '17

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: [PATCH] user32/tests: Some tests for GetWindowText() when non terminated string is returned
by Marvin 10 Jan '17

10 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27674 Your paranoid android. === w864 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w1064 (32 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100 === w864 (64 bit win) === win.c:2327: Test failed: expected !100 win.c:2327: Test failed: expected !100

1 0

Re: [PATCH v2] riched20: Check for NULL in ME_InsertTextFromCursor and add test
by Huw Davies 09 Jan '17

09 Jan '17

On Thu, Jan 05, 2017 at 05:06:42PM +0100, Fabian Maurer wrote: > It already works with a null-pointer, but will crash if len is -1. > Since null-pointer means no text, we just return to avoid crashes. > > v2: Followed suggestion by Nikolay Sivov, moved check and extend test Actually, I'd prefer the NULL ptr check in fnTextSrv_TxSetText(), where it was in your first version. However, the extended test is much better. Huw.

2 1

Wine slides for Linux user group?
by Austin English 07 Jan '17

07 Jan '17

Howdy, Does anyone have some recentish slides I could build on for a local Linux user group presentation about Wine? Thanks

1 0

Re: ddraw/tests: A spelling fix in an ok() message.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27624 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ddraw/tests: Spelling fixes in a few comments.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27623 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2391: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2240: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2546: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: dxgi/tests: Some spelling fixes in ok() messages.
by Marvin 07 Jan '17

07 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27612 Your paranoid android. === w7pro64 (32 bit device) === device.c:1445: Test failed: SetFullscreenState failed, hr 0x887a0004.

1 0

Re: [PATCH] d3dx11: Remove forward to d3dx11_43.
by Matteo Bruni 06 Jan '17

06 Jan '17

2016-12-29 16:59 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/d3dx11_42/d3dx11_42.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx11_42/d3dx11_42.spec b/dlls/d3dx11_42/d3dx11_42.spec > index f97ec24..0a6350c 100644 > --- a/dlls/d3dx11_42/d3dx11_42.spec > +++ b/dlls/d3dx11_42/d3dx11_42.spec > @@ -29,7 +29,7 @@ > @ stub D3DX11FilterTexture > @ stub D3DX11GetImageInfoFromFileA > @ stub D3DX11GetImageInfoFromFileW > -@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) d3dx11_43.D3DX11GetImageInfoFromMemory > +@ stdcall D3DX11GetImageInfoFromMemory(ptr long ptr ptr ptr) > @ stub D3DX11GetImageInfoFromResourceA > @ stub D3DX11GetImageInfoFromResourceW > @ stub D3DX11LoadTextureFromTexture Does that compile?

1 0

Re: [PATCH] d3dx11: Add D3DX11CreateShaderResourceViewFromMemory stub.
by Matteo Bruni 06 Jan '17

06 Jan '17

2016-12-28 15:43 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: It's probably pretty safe but I'd prefer to defer this patch after 2.0.

1 0

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Henri Verbeet 06 Jan '17

06 Jan '17

On 6 January 2017 at 08:07, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42159 > This isn't a regression, right? > @@ -2975,10 +2975,7 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, > hr = ddraw_surface_create(ddraw, &surface_desc2, &impl, outer_unknown, 1); > wined3d_mutex_unlock(); > if (FAILED(hr)) > - { > - *surface = NULL; > return hr; > - } This does a bit more than the commit message says it does, this doesn't write to *surface on any error from ddraw_surface_create(). That may very well be correct, but that's not what the test tests. The test only tests that CreateSurface() doesn't crash on error with an invalid "surface" pointer, but that could also be because of e.g. an exception handler. If you want to prove that it doesn't (try to) write to the "surface" pointer, you should pass a valid pointer to CreateSurface() and test that it isn't modified after the call.

2 2

Re: [PATCH] user.exe16: Add missing SELECTOROF in WM_DDE_EXECUTE.
by Alexandre Julliard 06 Jan '17

06 Jan '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/user.exe16/message.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/user.exe16/message.c b/dlls/user.exe16/message.c > index 7bcc8e2..383d746 100644 > --- a/dlls/user.exe16/message.c > +++ b/dlls/user.exe16/message.c > @@ -900,7 +900,7 @@ LRESULT WINPROC_CallProc16To32A( winproc_callback_t callback, HWND16 hwnd, UINT1 > } > break; /* FIXME don't know how to free allocated memory (handle) !! */ > case WM_DDE_EXECUTE: > - lParam = convert_handle_16_to_32( lParam, GMEM_DDESHARE ); > + lParam = convert_handle_16_to_32( SELECTOROF(lParam), GMEM_DDESHARE ); This won't work without fixing the opposite mapping. Do you have a reference for this? What application is this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Alex Henrie 06 Jan '17

06 Jan '17

2017-01-06 0:07 GMT-07:00 Alex Henrie <alexhenrie24(a)gmail.com>: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42159 > > With this patch, Sega Bug shows its intro logos, although it crashes > with "Unhandled privileged instruction" immediately after that. In case anyone is curious, I got rid of the "Unhandled privileged instruction" error by modifying my ioperm wrapper described at https://www.winehq.org/pipermail/wine-devel/2016-September/114873.html to open ports 3D0-3DF. With the patch and the ioperm wrapper, the game does not crash and the sound plays, but the game window is all black and the console repeats "fixme:d3d:surface_cpu_blt Filter WINED3D_TEXF_LINEAR not supported in software blit." -Alex

1 0

Re: [PATCH 4/4] ddraw: Don't write out if a ddraw7 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27599 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2276: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2276: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 3/4] ddraw: Don't write out if a ddraw4 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27598 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2550: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2550: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 2/4] ddraw: Don't write out if a ddraw2 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27597 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2395: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2395: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.
by Marvin 06 Jan '17

06 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27596 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2244: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2244: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: reg/tests: Add tests for quotes and slashes in keys, values and data
by Marvin 05 Jan '17

05 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27579 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: regedit/tests: Add tests for quotes and slashes in keys, values and data
by Marvin 05 Jan '17

05 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27578 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/6] d3d9/tests: Add test for stale render target views regression.
by Henri Verbeet 05 Jan '17

05 Jan '17

On 5 January 2017 at 11:50, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +/* This test exercises a regression in Wine d3d9 implementation. */ The patch is fine, but note that once the bug is fixed it's no longer a regression.

1 0

commctl32: TaskDialog
by Fabian Maurer 04 Jan '17

04 Jan '17

Hello, just a question about the TaskDialog/TaskDialogIndirect functions. We already had a few patches in February 2015, but they weren't accepted for some reason. I'd start from scratch anyway, but something to look out for, mistakes that stopped the old series from being accepted? We're in code-freeze now, but I'd already start to give it a try. Another thing, since it's an internal UI class, how do you write test cases for those? I can probably test return value with simulated clicks, but after all, it's mostly visual whether control are properly aligned and shown. Fabian

2 1

Re: msxml3/tests: Mark Win10 behaviour as broken
by Nikolay Sivov 04 Jan '17

04 Jan '17

On 04.01.2017 18:49, André Hentschel wrote: > V_VT(&varbody_ref) = VT_VARIANT|VT_BYREF; > V_VARIANTREF(&varbody_ref) = &varbody; > hr = IXMLHttpRequest_send(xhr, varbody_ref); > - EXPECT_HR(hr, S_OK); > + ok(hr == S_OK || broken(hr == E_INVALIDARG) /* win10 */, "got 0x%08x, expected S_OK or E_INVALIDARG\n", hr); I don't think this has any value without understanding why it fails.

1 0

Re: [PATCH] qcap: Release IBaseFilter.
by Jactry Zeng 04 Jan '17

04 Jan '17

Hi Andrew, 2017-01-04 21:51 GMT+08:00 Andrew Eikum <aeikum(a)codeweavers.com>: > > This looks OK, but unless it fixes a bug, I'd rather wait until after > code freeze. No problem, I will resend it after code freeze. Thanks for review. -- Regards, Jactry Zeng

1 0

Re: [PATCH] quartz/tests: Skip test_render_run() if test file doesn't exist.
by Andrew Eikum 04 Jan '17

04 Jan '17

On Wed, Jan 04, 2017 at 10:52:28AM +0800, Jactry Zeng wrote: > + h = CreateFileW(file, 0, 0, NULL, OPEN_EXISTING, 0, NULL); > + if (h == INVALID_HANDLE_VALUE) { > + skip("Could not read test file \"%s\", skipping test\n", wine_dbgstr_w(file)); > + return; > + } > + CloseHandle(h); > + I like this, but please remove the quote characters: filtergraph.c:359: Tests skipped: Could not read test file "L"test.avi"", skipping test Andrew

1 0

[v2 0/7] x86: enable User-Mode Instruction Prevention
by Ricardo Neri 04 Jan '17

04 Jan '17

This is v2 of my first submission done a while ago[1]. I apologize for the delay. User-Mode Instruction Prevention (UMIP) is a security feature present in new Intel Processors. If enabled, it prevents the execution of certain instructions if the Current Privilege Level (CPL) is greater than 0. If these instructions were executed while in CPL > 0, user space applications could have access to system-wide settings such as the global and local descriptor tables, the segment selectors to the current task state and the local descriptor table. These are the instructions covered by UMIP: * SGDT - Store Global Descriptor Table * SIDT - Store Interrupt Descriptor Table * SLDT - Store Local Descriptor Table * SMSW - Store Machine Status Word * STR - Store Task Register If any of these instructions is executed with CPL > 0, a general protection exception is issued when UMIP is enabled. There is a caveat, however. Certain applications rely on some of these instructions to function. An example of this are applications that use WineHQ[2]. For instance, these applications rely on sidt returning a non- accesible memory location[3]. During the discussions, it was proposed that the fault could be relied to the user-space and perform the emulation in user-mode. However, this would break existing applications until, for instance, they update to a new WineHQ version. However, this approach would require UMIP to be disabled by default. The concensus in this forum is to always enable it. This patchset initially treated tasks running in virtual-8086 mode as a special case. However, I received clarification that DOSEMU[4] does not support applications that use these instructions. It relies on WineHQ for this[4]. Furthermore, the applications for which the concern was raised run in protected mode [3]. This version keeps UMIP enabled at all times and by default. If a general protection fault caused by the instructions protected by UMIP is detected, such fault will be fixed-up by returning dummy values as follows: * SGDT and SIDT return a base address to a dummy location in kernel memory and a limit of 0. * STR, SLDT returns 0 as the segment selector. This seems OK since we are providing a dummy value as the base address of the global descriptor table. * SMSW returns 0. Lastly, I found very useful the code for Intel MPX (Memory Protection Extensions) used to parse opcodes and the memory locations contained in the general purpose registers when used as operands. I put some of this code in a separate file that both MPX and UMIP can access and avoid code duplication. While here, I fixed two small bugs that I found in the MPX implementation. The code that I used to test the emulated instructions can be found in [6]. [1]. https://lwn.net/Articles/705877/ [2]. https://www.winehq.org/ [3]. https://www.winehq.org/pipermail/wine-devel/2016-November/115320.html [4]. http://www.dosemu.org/ [5]. http://marc.info/?l=linux-kernel&m=147876798717927&w=2 [6]. https://github.com/01org/luv-yocto/tree/rneri/umip/meta-luv/recipes-core/um… Thanks and BR, Ricardo Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Borislav Petkov <bp(a)suse.de> Cc: Brian Gerst <brgerst(a)gmail.com> Cc: Chen Yucong <slaoub(a)gmail.com> Cc: Chris Metcalf <cmetcalf(a)mellanox.com> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Fenghua Yu <fenghua.yu(a)intel.com> Cc: Huang Rui <ray.huang(a)amd.com> Cc: Jiri Slaby <jslaby(a)suse.cz> Cc: Jonathan Corbet <corbet(a)lwn.net> Cc: Michael S. Tsirkin <mst(a)redhat.com> Cc: Paul Gortmaker <paul.gortmaker(a)windriver.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Ravi V. Shankar <ravi.v.shankar(a)intel.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Liang Z Li <liang.z.li(a)intel.com> Cc: x86(a)kernel.org Cc: linux-msdos(a)vger.kernel.org Changes since V1: * Virtual-8086 mode tasks are not treated in a special manner. All code for this purpose was removed. * Instead of attempting to disable UMIP during a context switch or when entering virtual-8086 mode, UMIP remains enabled all the time. General protection faults that occur are fixed-up by returning dummy values as detailed above. * Removed umip= kernel parameter in favor of using clearcpuid=514 to disable UMIP. * Removed selftests designed to detect the absence of SIGSEGV signals when running in virtual-8086 mode. * Reused code from MPX to decode instructions operands. For this purpose code was put in a common location. * Fixed two bugs in MPX code that decodes operands. Ricardo Neri (7): x86/mpx: Do not use SIB index if index points to R/ESP x86/mpx: Fail when implicit zero-displacement is used along with R/EBP x86/mpx, x86/insn: Relocate insn util functions to a new insn-utils x86/cpufeature: Add User-Mode Instruction Prevention definitions x86: Add emulation code for UMIP instructions x86/traps: Fixup general protection faults caused by UMIP x86: Enable User-Mode Instruction Prevention arch/x86/Kconfig | 10 ++ arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/insn.h | 6 + arch/x86/include/asm/umip.h | 16 +++ arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/common.c | 16 ++- arch/x86/kernel/traps.c | 4 + arch/x86/kernel/umip.c | 170 ++++++++++++++++++++++++++++ arch/x86/lib/Makefile | 2 +- arch/x86/lib/insn-utils.c | 148 ++++++++++++++++++++++++ arch/x86/mm/mpx.c | 119 +------------------ 13 files changed, 382 insertions(+), 121 deletions(-) create mode 100644 arch/x86/include/asm/umip.h create mode 100644 arch/x86/kernel/umip.c create mode 100644 arch/x86/lib/insn-utils.c -- 2.9.3

5 30

Re: [1/3] ntdll: Define more file information classes.
by Jonathan Doron 03 Jan '17

03 Jan '17

Hello I would like to understand how to proceed with this. I tried to keep the patchset to minimum amount of changes so it wont affect anything else. Thanks, -- Jon. On Mon, Jan 2, 2017 at 10:04 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Deferred". > > This means that the patch is deferred because of code freeze for an > upcoming release. You need to either resend after the release, make > the patch less intrusive, or make a convincing argument that it needs > to be included in the release. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. >

2 1

Re: [PATCH] riched20: Check for NULL in fnTextSrv_TxSetText and add test
by Nikolay Sivov 02 Jan '17

02 Jan '17

On 02.01.2017 23:19, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=12185 > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/riched20/tests/txtsrv.c | 3 +++ > dlls/riched20/txtsrv.c | 7 +++---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/dlls/riched20/tests/txtsrv.c b/dlls/riched20/tests/txtsrv.c > index 1a6ca61052..6fd77d1b59 100644 > --- a/dlls/riched20/tests/txtsrv.c > +++ b/dlls/riched20/tests/txtsrv.c > @@ -681,6 +681,9 @@ static void test_TxSetText(void) > ok(memcmp(rettext,settext,SysStringByteLen(rettext)) == 0, > "String returned differs\n"); > > + /* Test if we crash when using NULL as text */ > + ITextServices_TxSetText(txtserv, NULL); > + > SysFreeString(rettext); > ITextServices_Release(txtserv); > ITextHost_Release(host); It's important to test if NULL text actually discards existing content or just does nothing. > diff --git a/dlls/riched20/txtsrv.c b/dlls/riched20/txtsrv.c > index 3df779834b..307b484352 100644 > --- a/dlls/riched20/txtsrv.c > +++ b/dlls/riched20/txtsrv.c > @@ -286,10 +286,9 @@ DECLSPEC_HIDDEN HRESULT WINAPI fnTextSrv_TxSetText(ITextServices *iface, LPCWSTR > ME_Cursor cursor; > > ME_SetCursorToStart(This->editor, &cursor); > - ME_InternalDeleteText(This->editor, &cursor, > - ME_GetTextLength(This->editor), FALSE); > - ME_InsertTextFromCursor(This->editor, 0, pszText, -1, > - This->editor->pBuffer->pDefaultStyle); > + ME_InternalDeleteText(This->editor, &cursor, ME_GetTextLength(This->editor), FALSE); > + if(pszText) > + ME_InsertTextFromCursor(This->editor, 0, pszText, -1, This->editor->pBuffer->pDefaultStyle); > ME_SetSelection(This->editor, 0, 0); > This->editor->nModifyStep = 0; > OleFlushClipboard(); Maybe it's better to add a check to ME_InsertTextFromCursor?

2 1

Starting wine virtual desktop minimized
by Austin English 02 Jan '17

02 Jan '17

Howdy, I'm looking for a way to start a virtual desktop and have it be minimized, similar to: wine start /min notepad But for the desktop itself. My goal is to be able to run winetest/winetricks-test/etc. with minimal graphical interface if I'm using the machine myself. Thanks and happy new year!

2 4

Re: [Patch] wined3d Add Turks HD6600 Binary driver
by Henri Verbeet 02 Jan '17

02 Jan '17

On 29 December 2016 at 12:07, Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > This is a regression fix. > What regression is that? If it's bug 38216, that was pretty much abandoned in early 2015. It was later reopened, but I don't see that bug report going anywhere without input from the original reporter. In fact, it's not all that clear whether the original issue still exists since commit 1df961bd3d1a5d4d4badfe364ca51e9f6cc88fd3.

1 0

Re: [PATCH] user32/tests: Added some tests for FindWindow()
by Marvin 02 Jan '17

02 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27514 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

1 0

Emitting aligned SSE movs in gcc with force_align_arg_pointer
by Daniel Santos 31 Dec '16

31 Dec '16

I'm working on a few improvements in GCC targeting 64-bit Wine. I've got a patch set that gives us back aligned SSE movs for 64-bit ms_abi functions that call System V functions. However, it looks like I'll have to wait until GCC 8's stage 1 comes around (https://gcc.gnu.org/ml/gcc-patches/2016-12/msg01924.html), but I thought I should post this here to prevent any duplication of effort. (Come to think of it, I should probably open a gcc bug report for this.) Following this patch set I have the out-of-lining patch set for the msabi/sysv prologues & epilogues as well that I'm still refining and cleaning up a bit. Happy New Year all! Daniel

1 0

Re: [2/3] ntdll: Implement FileIdInformation class support in NtQueryInformationFile.
by Nikolay Sivov 31 Dec '16

31 Dec '16

On 31.12.2016 16:50, Jonathan Doron wrote: > Signed-off-by: Jonathan Doron <jond(a)wizery.com> > --- > dlls/ntdll/file.c | 19 ++++++++++++++++++- > include/winternl.h | 9 +++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 6eddd19..fbadfbd 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2379,7 +2379,7 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, > 0, /* FileRenameInformationBypassAccessCheck */ > 0, /* FileLinkInformationBypassAccessCheck */ > 0, /* FileVolumeNameInformation */ > - 0, /* FileIdInformation */ > + sizeof(FILE_ID_INFORMATION), /* FileIdInformation */ > 0, /* FileIdExtdDirectoryInformation */ > 0, /* FileReplaceCompletionInformation */ > 0, /* FileHardLinkFullIdInformation */ > @@ -2621,6 +2621,23 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, > } > } > break; > + case FileIdInformation: > + { > + struct statfs volstats; > + FILE_ID_INFORMATION *info = ptr; > + if ((fstat(fd, &st) == -1) || (fstatfs(fd, &volstats) == -1)) > + { > + io->u.Status = FILE_GetNtStatus(); > + } > + else > + { > + memset(info, 0, sizeof(*info)); > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->LowPart = (ULONG)volstats.f_fsid.__val[0]; > + ((PLARGE_INTEGER)&info->VolumeSerialNumber)->HighPart = (ULONG)volstats.f_fsid.__val[1]; > + ((PLARGE_INTEGER)&info->FileId)->QuadPart = st.st_ino; > + } > + } > + break; > default: > FIXME("Unsupported class (%d)\n", class); > io->u.Status = STATUS_NOT_IMPLEMENTED; > diff --git a/include/winternl.h b/include/winternl.h > index 891b6a7..2f2ea86 100644 > --- a/include/winternl.h > +++ b/include/winternl.h > @@ -571,6 +571,15 @@ typedef struct _FILE_INTERNAL_INFORMATION { > LARGE_INTEGER IndexNumber; > } FILE_INTERNAL_INFORMATION, *PFILE_INTERNAL_INFORMATION; > > +typedef struct _FILE_ID_128 { > + UCHAR Identifier[16]; > +} FILE_ID_128, *PFILE_ID_128; Windows SDK has it in winnt.h, using BYTE instead of UCHAR. > + > +typedef struct _FILE_ID_INFORMATION { > + ULONGLONG VolumeSerialNumber; > + FILE_ID_128 FileId; > +} FILE_ID_INFORMATION, *PFILE_ID_INFORMATION; > + This one should go to winbase.h, as FILE_ID_INFO. > typedef struct _FILE_EA_INFORMATION { > ULONG EaSize; > } FILE_EA_INFORMATION, *PFILE_EA_INFORMATION;

2 1

Release plans
by Alexandre Julliard 30 Dec '16

30 Dec '16

Folks, Since there was (understandably) very little activity this week, I'm going to skip today's release. I'll release rc4 next Friday; after that, there will probably be a couple more release candidates, since I'm hoping that we can make some more progress on bug fixing once people are back from the holidays. That will put the final 2.0 probably in the second half of January. Happy New Year to everyone! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: add stub for GetAutoRotationState
by Alistair Leslie-Hughes 30 Dec '16

30 Dec '16

Hi Fabian, On 30/12/16 12:31, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=42106 > > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/user32/misc.c | 14 ++++++++++++++ > dlls/user32/user32.spec | 1 + > include/winuser.h | 13 +++++++++++++ > 3 files changed, 28 insertions(+) > > diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c > index fa0502e25e..15f5c877fa 100644 > --- a/dlls/user32/misc.c > +++ b/dlls/user32/misc.c > @@ -836,6 +836,20 @@ LONG WINAPI GetDisplayConfigBufferSizes(UINT32 flags, UINT32 *num_path_info, UIN > return ERROR_NOT_SUPPORTED; > } > > +/********************************************************************** > + * GetAutoRotationState [USER32.@] > + */ > +BOOL WINAPI GetAutoRotationState(PAR_STATE pState) > +{ > + FIXME("(0x%x): stub\n", pState); Since PAR_STATE is a pointer, %p would be more appropriate. Best Regards Alistair

2 1

Re: [PATCH 2/2] regedit: Only allow value renaming via the Edit or Popup menus
by Ken Thomases 29 Dec '16

29 Dec '16

Hi, I personally dislike this proposed change. I use click-to-rename values all the time and can't think of why that would be a problem. -Ken

3 2

Re: [PATCH 2/2] regedit: Only allow value renaming via the Edit or Popup menus
by Nikolay Sivov 29 Dec '16

29 Dec '16

On 28.12.2016 14:47, Hugh McMaster wrote: > @@ -485,7 +494,7 @@ HWND CreateListView(HWND hwndParent, UINT id) > /* Get the dimensions of the parent window's client area, and create the list view control. */ > GetClientRect(hwndParent, &rcClient); > hwndLV = CreateWindowExW(WS_EX_CLIENTEDGE, WC_LISTVIEWW, ListView, > - WS_VISIBLE | WS_CHILD | WS_TABSTOP | LVS_REPORT | LVS_EDITLABELS, > + WS_VISIBLE | WS_CHILD | WS_TABSTOP | LVS_REPORT, > 0, 0, rcClient.right, rcClient.bottom, > hwndParent, ULongToHandle(id), hInst, NULL); > if (!hwndLV) return NULL; Clean way to do that is to block edit operation using LVN_BEGINLABELEDIT notification. So basically you should always return TRUE from it, except for the case when edit is triggered with UI command, in this case you can temporarily enable edit, and block it back when done. But I'm curious, why do you want to do that in a first place, what's wrong with the ability to click-rename items?

2 2

Re: [PATCH] winmm: RegQueryValueExW wants the size in bytes, not the size in characters.
by Andrew Eikum 28 Dec '16

28 Dec '16

Thanks. These look good but we're in code freeze. I'll be happy to sign-off on them after the freeze is over. Andrew On Mon, Dec 26, 2016 at 04:25:22PM +0100, Carlo Bramini wrote: > There is a bug into dlls/winmm/playsound.c > Function RegQueryValueExW accepts the size in bytes as parameter, not the size > in characters. > > See: > https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911(v=vs.85). > aspx > > Sincerely. > > Signed-off-by: Carlo Bramini <carlo_bramini(a)users.sourceforge.net> > > diff --git a/dlls/winmm/playsound.c b/dlls/winmm/playsound.c > index 5d9aed0..6525db5 100644 > --- a/dlls/winmm/playsound.c > +++ b/dlls/winmm/playsound.c > @@ -140,7 +140,7 @@ static HMMIO get_mmioFromProfile(UINT uFlags, LPCWSTR lpszName) > if (err != 0) > goto none; > } > - count = sizeof(str)/sizeof(str[0]); > + count = sizeof(str); > err = RegQueryValueExW(hSnd, NULL, 0, &type, (LPBYTE)str, &count); > RegCloseKey(hSnd); > if (err != 0 || !*str) goto none; >

1 0

wined3d Add Amd rx 480 binary driver
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options and complains not enough memory. With the attached patch here the options are not limited anymore.

2 1

(no subject)
by Jarkko Korpi 26 Dec '16

26 Dec '16

http://source.winehq.org/git/wine.git/commit/c63e3261f37e8116e59c70b9bed20a… Since that commit Rx 480 supposed to be recognized, but I am using closed source drivers, because the audio patches arent in upstream yet. I found a real problem from SC2 appdatabase and I could confirm it myself. When you start SC2 and go to options it limits your GPU graphics options. With the attached patch here the options are not limited anymore.

1 0

RE: msvcirt: Avoid "array subscript above array bounds" warnings in test_ostrstream and test_strstreambuf.
by Filip Frackiewicz 24 Dec '16

24 Dec '16

Hi Gerald, In wine-1.9.22-129-g906e770 I see the array subscript warnings in the following location: ../../../../wine/dlls/msvcirt/tests/msvcirt.c: In function ‘test_strstream’: ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6861:34: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.ebuf == buffer + 0x7fffffff || pssb->base.ebuf == (char*) -1, ~~~~~~~^~~~~~~~~~~~ ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6868:35: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.epptr == buffer + 0x7fffffff || pssb->base.epptr == (char*) -1, Thought I'd let you know as I just encountered this while compiling the 64-bit version of Wine. Cheers, Filip

2 1

Re: [PATCH] mscoree: Free argument buffer on error (Coverity)
by Vincent Povirk 22 Dec '16

22 Dec '16

I'm out visiting family and don't have access to a machine that can build or run Wine. I'll be able to do reviews again next year. FWIW, by purely visual inspection this looks fine to me.

1 0

Re: [PATCH] msvcrt: Pass WCHAR strings to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:38:19 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > Cc: Nikolay Sivov <bunglehead(a)gmail.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > v2: Switch to WCHAR type. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c > index 9ba0891806..ad5a78d54d 100644 > --- a/dlls/msvcrt/exit.c > +++ b/dlls/msvcrt/exit.c > @@ -41,8 +41,6 @@ typedef struct MSVCRT__onexit_table_t > MSVCRT__onexit_t *_end; > } MSVCRT__onexit_table_t; > > -static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > - > extern int MSVCRT_app_type; > extern MSVCRT_wchar_t *MSVCRT__wpgmptr; > > @@ -112,10 +110,12 @@ void CDECL MSVCRT__exit(int exitcode) > /* Print out an error message with an option to debug */ > static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *message) > { > - static const MSVCRT_wchar_t message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > + static const WCHAR message_format[] = {'%','s','\n','\n','P','r','o','g','r','a','m',':',' ','%','s','\n', > '%','s','\n','\n','P','r','e','s','s',' ','O','K',' ','t','o',' ','e','x','i','t',' ','t','h','e',' ', > 'p','r','o','g','r','a','m',',',' ','o','r',' ','C','a','n','c','e','l',' ','t','o',' ','s','t','a','r','t',' ', > 't','h','e',' ','W','i','n','e',' ','d','e','b','b','u','g','e','r','.','\n',0}; > + static const WCHAR title[] = > + {'W','i','n','e',' ','C','+','+',' ','R','u','n','t','i','m','e',' ','L','i','b','r','a','r','y',0}; 'message_format' is used with MSVCRT__snwprintf, so it should be wchar_t strictly speaking. > > MSGBOXPARAMSW msgbox; > MSVCRT_wchar_t text[2048]; Another existing bug is wrong buffer length here: --- MSVCRT__snwprintf(text,sizeof(text),message_format, lead, MSVCRT__wpgmptr, message); --- Could be a separate patch I guess. > @@ -126,8 +126,8 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > msgbox.cbSize = sizeof(msgbox); > msgbox.hwndOwner = GetActiveWindow(); > msgbox.hInstance = 0; > - msgbox.lpszText = (LPCWSTR)text; > - msgbox.lpszCaption = (LPCWSTR)szMsgBoxTitle; > + msgbox.lpszText = text; > + msgbox.lpszCaption = title; What I meant is that you can remove 'text' cast without changing its type. > msgbox.dwStyle = MB_OKCANCEL|MB_ICONERROR; > msgbox.lpszIcon = NULL; > msgbox.dwContextHelpId = 0;

1 0

Re: [PATCH] msvcrt: Pass wide char caption string to MessageBoxIndirectW.
by Nikolay Sivov 22 Dec '16

22 Dec '16

On Thu, 22 Dec 2016 14:20:26 -0700 Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Cc: Piotr Caban <piotr(a)codeweavers.com> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=42057 > > I figured this would be a good time to get rid of the misleading > Hungarian notation and move the string into the single function that > uses it. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/msvcrt/exit.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c > index 9ba0891806..3bfcd15967 100644 > --- a/dlls/msvcrt/exit.c > +++ b/dlls/msvcrt/exit.c > @@ -41,8 +41,6 @@ typedef struct MSVCRT__onexit_table_t > MSVCRT__onexit_t *_end; > } MSVCRT__onexit_table_t; > > -static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > - > extern int MSVCRT_app_type; > extern MSVCRT_wchar_t *MSVCRT__wpgmptr; > > @@ -116,6 +114,8 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > '%','s','\n','\n','P','r','e','s','s',' ','O','K',' ','t','o',' ','e','x','i','t',' ','t','h','e',' ', > 'p','r','o','g','r','a','m',',',' ','o','r',' ','C','a','n','c','e','l',' ','t','o',' ','s','t','a','r','t',' ', > 't','h','e',' ','W','i','n','e',' ','d','e','b','b','u','g','e','r','.','\n',0}; > + static const MSVCRT_wchar_t title[] = > + {'W','i','n','e',' ','C','+','+',' ','R','u','n','t','i','m','e',' ','L','i','b','r','a','r','y',0}; I think this should be WCHAR, because it will be used with regular API. > > MSGBOXPARAMSW msgbox; > MSVCRT_wchar_t text[2048]; > @@ -127,7 +127,7 @@ static void DoMessageBoxW(const MSVCRT_wchar_t *lead, const MSVCRT_wchar_t *mess > msgbox.hwndOwner = GetActiveWindow(); > msgbox.hInstance = 0; > msgbox.lpszText = (LPCWSTR)text; > - msgbox.lpszCaption = (LPCWSTR)szMsgBoxTitle; > + msgbox.lpszCaption = (LPCWSTR)title; Looks like these two casts could be removed. > msgbox.dwStyle = MB_OKCANCEL|MB_ICONERROR; > msgbox.lpszIcon = NULL; > msgbox.dwContextHelpId = 0;

1 0

Re: [PATCH 2/2] user32: Send WM_NCPAINT and WM_ERASEBKGND when window is shown and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27468 Your paranoid android. === w7u (32 bit msg) === msg.c:9126: Test failed: did not get zero count as expected (1). msg.c:9129: Test failed: did not get one count as expected (2). msg.c:9133: Test failed: killing replaced timer did not work (2). msg.c:9146: Test failed: did not get expected count for minimum timeout (12 != ~100). === w7pro64 (64 bit msg) === msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 5: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 6: the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 7: the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:12258: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): 13: the msg sequence is not complete: expected 0000 - actual 0003

2 1

Re: [PATCH 1/2] user32: Fix WM_NCPAINT for windows crossing screen boarders and add tests
by Marvin 22 Dec '16

22 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27467 Your paranoid android. === w7pro64 (64 bit msg) === msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 4: in msg 0x0047 expecting wParam 0x8170 got 0x1803 msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 5: the msg 0x0003 was expected, but got msg 0x0047 instead msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 6: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:12156: Test failed: 54: ShowWindow(SW_MINIMIZE): 7: the msg sequence is not complete: expected 0000 - actual 0005

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Austin English 21 Dec '16

21 Dec '16

On Wed, Dec 14, 2016 at 4:45 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of weeks, please resend the patch. This shows in the tracker as assigned to Hans, but Hans signed off a week ago. -- -Austin GPG: 14FB D7EA A041 937B

3 3

Can't build crosstests
by Fabian Maurer 20 Dec '16

20 Dec '16

Hello, I'm trying to build the tests for windows, but I can't get it working anymore. I have mingw installed and it does work for cross-compiling with code-blocks, but wine says it's broken. The configure script fails with >checking for i686-w64-mingw32-gcc... i686-w64-mingw32-gcc >checking whether i686-w64-mingw32-gcc works... no An idea how to find out what's going wrong?

3 4

Re: user32/tests: Disable automatic shell restart during SetShellWindow tests.
by Marvin 20 Dec '16

20 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27438 Your paranoid android. === w864 (32 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100 === w864 (64 bit win) === win.c:2305: Test failed: expected !100 win.c:2305: Test failed: expected !100

2 1

Re: [PATCH] gdiplus/tests: Test for initial properties of adjustable arrow caps
by Vincent Povirk 19 Dec '16

19 Dec '16

On Fri, Dec 16, 2016 at 6:21 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + stat = GdipGetCustomLineCapBaseInset((GpCustomLineCap*)cap, &inset); > + ok(stat == Ok, "Unexpected return code, %d\n", stat); > + It isn't enough to reject the patch, but I'm curious why you don't test this value.

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Nikolay Sivov 19 Dec '16

19 Dec '16

On 19.12.2016 13:38, Hans Leidekker wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/shell32/tests/shlfileop.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 0e502fc..776da98 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -819,7 +819,7 @@ static void test_rename(void) > retval == DE_DIFFDIR || /* Vista */ > broken(retval == DE_OPCANCELLED) || /* Win9x */ > broken(retval == 65652), /* NT4 */ > - "Expected ERROR_CANCELLED or DE_DIFFDIR\n"); > + "Expected ERROR_CANCELLED or DE_DIFFDIR, got %u\n", retval); > ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); > > /* pFrom is empty */ > @@ -2516,6 +2516,11 @@ static void test_unicode(void) > skip("Unicode tests skipped on non-unicode system\n"); > return; > } > + if (GetLastError()==ERROR_ACCESS_DENIED) > + { > + skip("test needs admin rights\n"); > + return; > + } > CloseHandle(file); > > /* Try to delete a file with unicode filename */ > @@ -2574,6 +2579,7 @@ static void test_unicode(void) > ok(GetLastError() == ERROR_SUCCESS || > broken(GetLastError() == ERROR_INVALID_HANDLE), /* WinXp, win2k3 */ > "Expected ERROR_SUCCESS, got %d\n", GetLastError()); > + DeleteFileW(UNICODE_PATH_TO); > > /* Check last error after a failed file operation. */ > DeleteFileW(UNICODE_PATH); Will it work if user temp directory was used instead of current directory or C: root?

2 1

Re: shell32/tests: Skip SHFileOperationW tests if the user doesn't have admin rights.
by Marvin 19 Dec '16

19 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27406 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128 === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR, got 128

2 1

Re: [PATCH] webservices: free the potentially allocated pointer (Coverity)
by Hans Leidekker 19 Dec '16

19 Dec '16

On Sat, 2016-12-17 at 12:48 +0100, Marcus Meissner wrote: > 1374356 Resource leak > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/webservices/reader.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > index d67c47a701..219683b2af 100644 > --- a/dlls/webservices/reader.c > +++ b/dlls/webservices/reader.c > @@ -4701,15 +4701,33 @@ static ULONG get_field_size( const WS_FIELD_DESCRIPTION *desc ) > > static HRESULT read_param( struct reader *reader, const WS_FIELD_DESCRIPTION *desc, WS_HEAP *heap, void *ret ) > { > - if (!ret && !(ret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > - return read_type_struct_field( reader, desc, heap, ret, 0 ); > + HRESULT hr; > + VOID *xret = NULL; > + > + if (!ret) > + { > + if (!(xret = ws_alloc_zero( heap, get_field_size(desc) ))) return WS_E_QUOTA_EXCEEDED; > + ret = xret; > + } > + hr = read_type_struct_field( reader, desc, heap, ret, 0 ); > + ws_free( heap, xret); > + return hr; > } It's not a leak. The memory is allocated on the heap passed to this function and it will be released when the heap is destroyed. I guess Coverity doesn't see that.

2 1

Re: [PATCH 2/4] ddraw: Subtract framebuffer size from reported available video memory.
by Henri Verbeet 19 Dec '16

19 Dec '16

On 18 December 2016 at 00:22, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + INT64 total_vidmem, free_vidmem; ... > + free_vidmem = wined3d_device_get_available_texture_mem(ddraw->wined3d_device); > + *free = max(0, free_vidmem - framebuffer_size); This works, but it seems a little silly to use INT64 to avoid writing something along the lines of "*free = framebuffer_size > free_vidmem ? 0 : free_vidmem - framebuffer_size;".

1 0

Wined3d textureless rendering
by Bruno Jesus 18 Dec '16

18 Dec '16

Hello everyone. Following my email last year email asking if rendering in wireframe could speedup a game (answer was no in many different ways) I have a new idea after playing Totaly Accurate Battle Simulator with its red and blue army. What if I skip applying every texture to every object? Probably everything would be black so I would need to use different incremental solid color to distinguish stuff in the screen. Would that save memory and also make games faster? Remembering that my 3D knowledge didn't change much so, basically zero + wireframe knowledge from previous email ;-) Best wishes, Bruno

2 2

[OT] Machine learning for automatical GUI testing
by Qian Hong 18 Dec '16

18 Dec '16

Hi folks, I was falling into machine learning recently and I think I'd like to share some ideas. Here is one of them: quote: ``` Universe allows an AI agent to use a computer like a human does: by looking at screen pixels and operating a virtual keyboard and mouse. We must train AI systems on the full range of tasks we expect them to solve, and Universe lets us train a single agent on any task a human can complete with a computer. ``` Reference: https://openai.com/blog/universe/ Reinforcement Learning is the powerful algorithm used by AlphaGo which won the Go chess game this year against world class master. OpenAI Universe is a good environment to train Reinforcement Learning program's skill on software UI testing. We might want to follow the latest progress from OpenAI Universe community to see if there is anything useful for Wine development / testing. I know people tried GUI auto testing years ago but was not very happy with that, however this time with the revolution of machine learning, interesting thing could happen, finally. Any one want to discover more potential on using machine learning to improve Wine? This might not be practical in one month, but could be very powerful in long term, like 3 years or more. There could be multiple possible ways, not only GUI testing, but none is easy today. Other interesting reading: https://openai.com/blog/universe/ https://gym.openai.com/ Cheers! -- Regards, Qian Hong

1 0

Re: [Tools] testbot: Skip ntdll:exception on the Windows 10 VM.
by Francois Gouget 16 Dec '16

16 Dec '16

On Fri, 16 Dec 2016, Francois Gouget wrote: [...] > - $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\"\r\n" . > + my $Ignore = ($VM->Name eq "w1064" ? "-n ntdll:exception" : ""); > + $Script .= "-q -o $RptFileName -t $Tag -m \"$EMail\" -i \"$Info\" $Ignore\r\n" . > "$FileName -q -s $RptFileName\r\n"; This should not be needed after all. The trick is not to upgrade QEMU, Windows 10, the host kernel, change the emulated CPU or switch to emulating USB 3. The trick is: echo 1 >/sys/module/kvm/parameters/ignore_msrs Once you've noticed the following lines in the host's kernel log and done a Google search: Dec 16 13:43:48 vm3 kernel: [ 191.624802] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0bf3 kvm_set_msr_common: MSR_IA32_DEBUGCTLMSR 0x1, nop Dec 16 13:43:48 vm3 kernel: [ 191.624835] kvm [2064]: vcpu0, guest rIP: 0xfffff803cb3c0c5c unhandled rdmsr: 0x1c9 https://www.reddit.com/r/VFIO/comments/42dj7n/some_games_crash_to_biosboot_… Now as to why another Windows 10 VM seemed to get magically fixed by the AEMU upgrade (from 2.1 to 2.7) and did not require this hack is another mystery. But one I can live with. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 3/7] d3d11/tests: Add workaround for bug in AMD Windows driver.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 59 +++++++++++++++++++++++++++--------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) > Unfortunately this makes it fail on Wine for me, probably because the initial texture data is undefined.

2 2

Re: [PATCH 7/7] wined3d: Make total video memory limit optional.
by Henri Verbeet 16 Dec '16

16 Dec '16

On 15 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > It's enough to enable this workaround for ddraw. > So would it then also be enough to just fixup things in ddraw7_GetAvailableVidMem()? In fact, the documentation suggests that's actually the proper place, and that this shouldn't be specific to the Windows version. You could probably use wined3d_get_adapter_display_mode() together with wined3d_calculate_format_pitch() to calculate the primary surface size.

2 2

Re: [PATCH v2 14/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 15 Dec '16

15 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The test was slightly changed. If it still fails the failures should be more > clear now after "d3d11/tests: Print expected result in case of failures in > check_texture_sub_resource_*() functions." > Still fails: d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got 0.00000000e+000, expected 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6599: Test failed: Got 1.00000000e+002, expected 2.55000000e+002 at (0, 0), sub-resource 0. d3d11.c:6608: Test failed: Got 2.55199997e+002, expected 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6613: Test failed: Got 3.29999995e+000, expected 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6618: Test failed: Got 4.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6537: Test failed: Got 0.00000000e+000, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6542: Test failed: Got 1.00000000e+000, expected 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6563: Test failed: Got 6.00000024e-001, expected 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6568: Test failed: Got 1.00000000e+000, expected 2.00000003e-001 at (0, 0), sub-resource 0. So I investigated this a little, and the issue seems to be that as soon as D3D11_BIND_SHADER_RESOURCE is in the bind flags, reads from the depth texture return stale values. E.g., the failure at line 6563 is from the 0.6f written by the clear at line 6544. This can also be reproduced by calling check_texture_float() directly on the depth texture, and is not specific to typeless formats. I'd guess at a driver bug related to e.g. compressed depth or fast clear handling. Regardless, I'd expect that using separate resources for the clear and the shader reads would fix the failures, although it would perhaps weaken the test a little.

3 4

Re: [PATCH] d3dx9: Fix a typo in TRACE() message.
by Matteo Bruni 15 Dec '16

15 Dec '16

2016-12-12 11:21 GMT+01:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > @@ -750,7 +750,7 @@ D3DXMATRIX* WINAPI D3DXMatrixTransformation(D3DXMATRIX *pout, const D3DXVECTOR3 > D3DXQUATERNION prc; > D3DXVECTOR3 psc, pt; > > - TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcentr %p, protation %p, ptranslation %p\n", > + TRACE("pout %p, pscalingcenter %p, pscalingrotation %p, pscaling %p, protationcenter %p, protation %p, ptranslation %p\n", > pout, pscalingcenter, pscalingrotation, pscaling, protationcenter, protation, ptranslation); > > if ( !pscalingcenter ) It would be nice to clean up the function while at it (add the missing period at the end of the trace, drop the useless 'p' prefix from all the parameters and most of the local variables, fix and split the function prototype over multiple lines, remove the spaces around the if condition, ...) IMO better if you send a v2 with the cleanups after Wine 2.0.

1 0

Re: [PATCH v2 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 15 Dec '16

15 Dec '16

Hi, On 12/14/16 18:18, Lauri Kenttä wrote: > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i] + 4, zeros[i], zeros[i] + 5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = U+%04X: got %d, expected 405\n", zeros[i], (int)res); > + tmp[1] = zeros[i] + 10; > + res = p_wcstoi64(tmp, NULL, 0); Please change the line to: res = p_wcstoi64(tmp, NULL, 16); Currently you don't test if zeros[i]+10 is recognized as valid digit. Except of that the patches are looking good for me. Are these patches fixing any bugs? Is any application working thanks to them (I'm asking because of the code freeze)? Thank you, Piotr

2 2

Re: [PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall
by Dmitry Timoshkov 15 Dec '16

15 Dec '16

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > -IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 > +IMPORTS = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi ... > +#include <shlwapi.h> ... > - info->regroot = root; > + info->regroot = SHRegDuplicateHKey(root); Adding a whole new import just because of a simple RegOpenKeyEx() wrapper is not really justified. -- Dmitry.

2 1

Re: [v3] winex11: Use XIAllDevices to select for XI_RawMotion
by Carlos Garnacho 15 Dec '16

15 Dec '16

Hi all, Got this message from Marvin about "formatting", but I'm not sure what could have triggered this. Getting picky I see the parens at the update_relative_valuators function aren't alright given surrounding code style, but I see nothing specifically against https://wiki.winehq.org/Submitting_Patches#Code_guidelines or https://source.winehq.org/patches/#legend Is there anything actually wrong? I'll be happy to send an updated patch. Cheers, Carlos On Mon, Dec 12, 2016 at 11:15 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Formatting". > > This means that there are some formatting issues with your > patch. Either the author's full name, email address, or Signed-off-by > headers are missing, indentation is messed up (usually from editing > with a non-standard tab size), or there are gratuitous formatting > changes to the code. You need to resend a fixed patch. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

2 2

wine-staging status
by Michael Cronenworth 14 Dec '16

14 Dec '16

Hi, Is Wine Staging on hiatus? MIA? DIA? It has been one month since the last release with no signs of any new commits. I sent an e-mail to Sebastian but no response yet. Thanks, Michael

3 2

Re: [PATCH 3/3] msvcrt: Make wcstoi64 support various Unicode digits.
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 19:48, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: > @@ -2027,6 +2027,19 @@ static int wctoint(WCHAR c, int base) > v = c - 'A' + 10; > else if ('a' <= c && c <= 'z') > v = c - 'a' + 10; > + else { > + /* Unicode points that contain digits 0-9; keep this sorted! */ > + static const WCHAR zeros[] = { > + 0x660, 0x6f0, 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, > + 0xd66, 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0xff10 > + }; > + int i; > + for (i = 0; i < sizeof(zeros)/sizeof(zeros[0]) && c >= zeros[i]; ++i) { > + if (zeros[i] <= c && c < zeros[i] + base) { Using "base" here seems questionable. That would imply that e.g. with base 16, "\x6f2\x6fa"/"۲ۺ" would return "42". Is that really the case? For what it's worth, note also that Wine has wine_fold_string(), which should be consistent with FoldString().

4 8

Re: [PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban 14 Dec '16

14 Dec '16

Hi Lauri, On 12/13/16 19:48, Lauri Kenttä wrote: > + static const WCHAR zeros[] = { > + 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10, > + 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66 > + }; Please also add a test for Tibetan digits range: https://unicode-table.com/en/0F20/ > + /* Test various unicode digits */ > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i]+4, zeros[i], zeros[i]+5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = %#x: got %d, expected 405\n", zeros[i], (int)res); Could you please also add following test: tmp[1] = zeros[i]+10; res = p_wcstoi64(tmp, NULL, 16); ok(res == 4, ...); Thank you, Piotr

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Henri Verbeet 14 Dec '16

14 Dec '16

On 13 December 2016 at 20:17, Austin English <austinenglish(a)gmail.com> wrote: > + /* buf was originally [24], increased to 48 to prevent a stack smashing error when running tests under Valgrind */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308". */ The more interesting comment would perhaps be what actually happens and why this helps. One thing I do notice is that while 24 chars would be enough to hold "-1.1111111111111111E-308", that doesn't leave any room for the \0 terminator, while the other cases above this one do seem to include space for that.

2 5

Re: [PATCH] shlwapi: Changed UrlEscapeW error paths and add tests
by Jacek Caban 14 Dec '16

14 Dec '16

Hi Fabian, On 13.12.2016 22:53, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=41956 > > Also changed wininet:HTTP_HandleRedirect to not break it. > On windows output buffer must not be NULL, > and size must not be NULL or zero, > or it won't return the number of needed characters. Please send wininet changes as separated patch. They don't depend on shlwapi, so may be applied separately, before shlwapi patch. Other than that and one small comment bellow, the patch looks good. Thanks. > + /* Check error paths */ > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); You set and test size although the actual call doesn't use it. Please remove lines with size. Same in a few more cases. > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_POINTER, "got %x, expected %x\n", ret, E_POINTER); > + ok(size == 6, "got %d, expected %d\n", size, 6); Thanks, Jacek

3 2

Wine Swag and Promotion
by Aric Stewart 13 Dec '16

13 Dec '16

Hello all, So at this last wineconf we had a great discussion around promotion of the wine project and how we get more interaction with the broader open source developer and user community. As part of that we really wanted people to step up and volunteer to attend conferences, Linux user groups, shows and wherever they can to talk about wine. Jeremy reminded everyone that there is money in the wine project budget to compensate people for expenses around this. The job I volunteered to take on was that of swag master. It was agreed that we should have some things to give away at these events. Many projects have stickers and other goodies that they distribute, sell or otherwise get out into the community to increase visible footprint. The expense of these will come out of the wine project funds and we need to discuss the best way to manage it. Right now, I still have a number of leftover badge flags from FOSDEM, probably about 100 of them. If you are attending a conference with badges and you want some to distribute contact me and I can get that sent out. My first thought was that we should have a sticker stockpile. Stickers seem like a good first step. Here I have brought in Jana from CodeWeavers Marketing to help. She has agreed to design some stickers for us when she has free time (probably prototypes in early Jan) and talk to her production contacts on quotes for production of the stickers. We are thinking 2" x 4" oval or die-cut stickers. The price per sticker drops so dramatically with volume that doing smaller on demand printings seems counter productive. This would mean that there would be a mailing expense to ship the stickers from St. Paul, MN to each event. But with enough time, less expensive shipping can be selected and it just seems like the shipping expense would be out-weighted by production savings. The question I am posing out to you, the broader community, is if this sounds like a good first step plan? Also, what else do you think we should have a swag? Should I reorder badge flags when we run out? I know t-shirts are always popular but they tend to be enough more expensive that they are not really give-away items. Thoughts? I will send more info when Jana produces the sticker prototypes. Finally, I do have the flags, so right now, if you are off to an event and want to start with that as swag feel free to contact me! Thanks! -aric

2 1

Re: winhttp: Handle EINTR from connect and poll.
by Bruno Jesus 13 Dec '16

13 Dec '16

On Tue, Dec 13, 2016 at 7:33 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/winhttp/net.c | 47 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 33 insertions(+), 14 deletions(-) Hi, Isn't it better to make winhttp use ws2_32 just like wininet change [1]? Then we would have a single point for all networking code and EINTR is already covered in ws2_32. [1] http://source.winehq.org/git/wine.git/commitdiff/5436fef80722fe7896aed5e659… Best Regards, Bruno

2 3

Re: [PATCH 3/3] wined3d: Filter messages for fullscreen mode changes.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27335 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 2/3] d3d9/tests: Add test showing WM_SIZE is not sent during fullscreen mode change.
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27334 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind)
by Hans Leidekker 13 Dec '16

13 Dec '16

On Mon, 2016-12-12 at 16:20 -0600, Austin English wrote: > This avoids a stack smashing error when running > dlls/webservices/tests/writer.c under Valgrind. > > diff --git a/dlls/webservices/writer.c b/dlls/webservices/writer.c > index c1f1b0c..07b32d8 100644 > --- a/dlls/webservices/writer.c > +++ b/dlls/webservices/writer.c > @@ -1369,7 +1369,7 @@ static HRESULT text_to_utf8text( const WS_XML_TEXT *text, WS_XML_UTF8_TEXT **ret > case WS_XML_TEXT_TYPE_DOUBLE: > { > const WS_XML_DOUBLE_TEXT *double_text = (const WS_XML_DOUBLE_TEXT *)text; > - unsigned char buf[24]; /* "-1.1111111111111111E-308" */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308" */ > unsigned short fpword; > ULONG len; Please add a comment with motivation for the increased buffer size.

1 0

Re: [PATCH] advapi32: Add tests for StartTrace().
by Marvin 13 Dec '16

13 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27322 Your paranoid android. === wxppro (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1216: Test failed: Expected success, got 161 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 161 === w2003std (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 32

1 0

Re: [PATCH] mmdevapi: Fix pointer type cast
by Andrew Eikum 12 Dec '16

12 Dec '16

On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote: > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c > index 221fb39..b189e8e 100644 > --- a/dlls/mmdevapi/devenum.c > +++ b/dlls/mmdevapi/devenum.c > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls > if (SUCCEEDED(hr)) > { > IPersistPropertyBag *ppb; > - hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb); > + hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb); > if (SUCCEEDED(hr)) > { > /* ::Load cannot assume the interface stays alive after the function returns, Seems like this (and other similar cleanup patches) should be deferred until after freeze, right? Andrew

3 2

Re: [2/2 v2] winex11: Use XIAllDevices to select for XI_RawMotion
by Henri Verbeet 12 Dec '16

12 Dec '16

On 18 November 2016 at 12:43, Carlos Garnacho <carlosg(a)gnome.org> wrote: > Change the strategy used to get raw motion from slave devices. Instead > of selecting for XI2 events for every slave device individually, do it > for XIAllDevices, and store the current device's relative X/Y valuators > so they can be quickly looked up in the XI_RawMotion events received. > I think this makes sense, and in my (limited) testing this correctly handles the case of attaching a new input device. I do have a few minor comments though: > +static void update_relative_valuators(XIAnyClassInfo **valuators, > + int n_valuators) This should probably just be "static void update_relative_valuators( XIAnyClassInfo **valuators, int n_valuators )" > + free( thread_data->x_rel_valuator ); > + free( thread_data->y_rel_valuator ); ... > + thread_data->x_rel_valuator = malloc( sizeof(XIValuatorClassInfo) ); > + memcpy ( thread_data->x_rel_valuator, class, sizeof(XIValuatorClassInfo) ); We generally avoid malloc()/free() in Wine code and use HeapAlloc()/HeapFree() instead. The main consideration has to do with the way address space is allocated for Win32 applications, effectively making malloc() space a bit more scarce than HeapAlloc() space. We'd probably prefer the sizeof as "sizeof(*thread_data->x_rel_valuator)", or perhaps "sizeof(*class)". I'm not sure how much we should worry about this in practice, but when multiple slaves are attached to the master, and they're not completely idle, update_relative_valuators() can end up getting called quite a bit. It doesn't seem hard to at least do the allocation only once, and only update the data in update_relative_valuators(). Perhaps it's also fine the way it is though. > - XISetMask( mask_bits, XI_ButtonPress ); This was added intentionally (see also https://bugs.winehq.org/show_bug.cgi?id=27522#c18). Perhaps it's no longer needed, but that would need to be a separate patch. > + pointer_info = pXIQueryDevice( data->display, data->xi2_core_pointer, &count ); > + update_relative_valuators( pointer_info->classes, pointer_info->num_classes ); > + pXIFreeDeviceInfo( pointer_info ); ... > + pXISelectEvents( data->display, DefaultRootWindow( data->display ), &mask, 1 ); I'm not too concerned about it, but can this race? I.e. switching slaves between when update_relative_valuators() is called above and when XISelectEvents() takes effect. Applies to querying the devices list as well. > + if (thread_data->xi2_current_slave == 0) We'd typically write that "if (!thread_data->xi2_current_slave)", although I don't think anyone would be overly concerned about it. > + for (i = 0; i <= max ( x_rel->number, y_rel->number ); i++) > + { > +»······if (!XIMaskIsSet( event->valuators.mask, i )) continue; > +»······val = *values++; > +»······if (i == x_rel->number) > +»······{ > + input.u.mi.dx = dx = val; > +»······ if (x_rel->min < x_rel->max) > + input.u.mi.dx = val * (virtual_rect.right - virtual_rect.left) > + / (x_rel->max - x_rel->min); > +»······} > +»······if (i == y_rel->number) > +»······{ > +»······ input.u.mi.dy = dy = val; > +»······ if (y_rel->min < y_rel->max) You're using tabs for indentation here.

2 1

Re: [PATCH] shlwapi: Avoid 'else if' for IStream_fnQueryInterface.
by Nikolay Sivov 12 Dec '16

12 Dec '16

On Mon, 12 Dec 2016 13:24:38 +0200 Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/shlwapi/regstream.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/dlls/shlwapi/regstream.c b/dlls/shlwapi/regstream.c > index 1b0ca4e..d886c0c 100644 > --- a/dlls/shlwapi/regstream.c > +++ b/dlls/shlwapi/regstream.c > @@ -67,9 +67,7 @@ static HRESULT WINAPI IStream_fnQueryInterface(IStream *iface, REFIID riid, LPVO > > *ppvObj = NULL; > > - if(IsEqualIID(riid, &IID_IUnknown)) /*IUnknown*/ > - *ppvObj = This; > - else if(IsEqualIID(riid, &IID_IStream)) /*IStream*/ > + if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IStream)) > *ppvObj = This; > > if(*ppvObj) Please return interface pointer, to IStream_iface. Also TRACE() for this method needs simplification, but it could be a separate change.

1 0

Re: [PATCH resend 13/18] wined3d: Use depth/stencil formats for typeless resources only when WINED3DUSAGE_DEPTHSTENCIL is set.
by Henri Verbeet 12 Dec '16

12 Dec '16

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > const struct wined3d_format *wined3d_get_format(const struct wined3d_gl_info *gl_info, > - enum wined3d_format_id format_id) > + enum wined3d_format_id format_id, unsigned int resource_usage) > { > + const struct wined3d_format *format; > int idx = get_format_idx(format_id); > + unsigned int i; > > if (idx == -1) > { > - FIXME("Can't find format %s (%#x) in the format lookup table\n", > + FIXME("Can't find format %s (%#x) in the format lookup table.\n", > + debug_d3dformat(format_id), format_id); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > + } > + > + format = &gl_info->formats[idx]; > + > + if (resource_usage & WINED3DUSAGE_DEPTHSTENCIL && wined3d_format_is_typeless(format)) > + { > + for (i = 0; i < ARRAY_SIZE(typeless_depth_stencil_formats); ++i) > + { > + if (typeless_depth_stencil_formats[i].typeless_id == format_id) > + return &gl_info->formats[WINED3D_FORMAT_COUNT + i]; > + } > + > + FIXME("Cannot find depth/stencil typeless format %s (%#x).\n", > debug_d3dformat(format_id), format_id); > - /* Get the caller a valid pointer */ > - idx = get_format_idx(WINED3DFMT_UNKNOWN); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > } > > - return &gl_info->formats[idx]; > + return format; > } > I do have some concerns about whether returning different wined3d_format structures for different usages/bind flags is better than having different GL internal formats for different usages/bind flags within the same wined3d_format structure, but lets give it a try.

1 0

Re: [v2] preloader: Allow a debugger to find ld.so's rendezvous-struct
by Alexandre Julliard 12 Dec '16

12 Dec '16

Keno Fischer <keno(a)juliacomputing.com> writes: > @@ -123,6 +123,18 @@ static struct wine_preload_info preload_info[] = > { 0, 0 } /* end of list */ > }; > > +/* A fake .dynamic section through which we can inform the debugger of the > + address of the chain-loaded dynamic linker's rendezvous struct */ > +__asm__( > +".section .dynamic,\"aw\"\n" > +".global _DYNAMIC\n" > +"_DYNAMIC: .quad 21\n" // DT_DEBUG > +".quad 0\n" > +".quad 0\n" > +".quad 0\n" > +".previous\n" > +); This is causing a warning here: gcc -m32 -c -o preloader.o preloader.c -I. -I../include -D__WINESRC__ -fno-builtin -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Werror -g -O2 -fno-diagnostics-show-caret {standard input}: Assembler messages: {standard input}:5: Warning: setting incorrect section attributes for .dynamic -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH] po: Update Simplified Chinese translation.
by Jactry Zeng 11 Dec '16

11 Dec '16

This looks good to me. Thank you, Mingcong! 2016-12-11 0:12 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 588 ++++++++++++++++++++++++++++++ > +++--------------------------- > 1 file changed, 324 insertions(+), 264 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Source.winehq.org down?
by Filip Frackiewicz 10 Dec '16

10 Dec '16

Sorry for the bother but is source.winehq.org down for anyone? Filip

3 2

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Stefan Dösinger 10 Dec '16

10 Dec '16

Am 2016-12-07 um 06:27 schrieb Bruno Jesus: > @@ -2433,6 +2438,12 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > union generic_unix_sockaddr unix_addr; > int n, ret; > > + if (network_disabled) > + { > + errno = EHOSTUNREACH; > + return -1; > + } > + Shouldn't it be possible to achieve a similar effect with a LD_PRELOAD library?

2 2

WineTest reference Linux machines
by Francois Gouget 09 Dec '16

09 Dec '16

CodeWeavers has two machines that I have been running WineTest on, in Linux, Windows 8.1 and Windows 10, in 32 and 64 bit. They are identical except for the graphics cards: AMD HD6800 for cw1 and Nvidia GTX560 for cw2. During WineConf we decided that these should be able to run WineTest on Linux without any errors and thus become reference WineTest machines. We are not quite there yet so here is the current status starting with the 32 bit tests. * crypt32:chain Some of the certificates used by this test are present on Windows but missing on Linux, thus causing the error. Hans is looking into it and either the test will be modified to use other certificates present on both platforms, or the certificates will be added to these boxes. In the latter case this will be documented on the Wiki: https://wiki.winehq.org/Conformance_Tests#Running_WineTest_in_Wine * d2d1:d2d1, d3d10core:device These tests only fails on the GTX560. The reason is unknown. We need someone to look into it. * d3d8:device, d3d9:d3d9ex, d3d9:device, d3d9:visual Matteo fixed the radeon driver configuration and is looking into these failures, at least for the HD6800 case. It is possible some of these failures are caused by the window manager (currently xfwm from Xfce). Replacing the windows manager is no issue, we just need to know which one to pick. fvwm2? * kernel32:console, kernel32:process These failures happen because the tests are being run from cron, with their output redirected to a log file and thus they have no real terminal to work with. Interestingly the 64 bit tests are not failing. Vincent is investigating whether the tests should be modified or whether the test should be run from an xterm, screen session or some equivalent. * user32:winstation winstation.c:959: Test succeeded inside todo block: unexpected foreground window (nil) The cause for this failure has not been identified. Another window manager issue? * ws2_32:sock sock.c:2811: Test succeeded inside todo block: Test[2]: expected 0, got 0 We need someone to investigate this failure. It looks like it's random and relatively rare. Some tests just cannot be made to work reliably on Linux due to the asynchronous nature of X11 messaging. So another decision that was made that tests should be run up to 3 times until they succeed. It's not entirely clear if that applies to all tests or just to specific tests that are known to be flaky. The practical upshot is that people running 'make test' can re-run it a couple of times if it fails at first, and if it succeeds after 3 tries then you can consider that it's all good. These machines run WineTest so the results can be uploaded to test.winehq.org (with the relevant header describing the machine, the dlls, etc). So WineTest may need to be updated to deal with flaky tests according to policy. Here is more detail about these machines: * i7-2600K (4 cores+hyperthreading at 3.4GHz) * 16 GB of RAM * 768 GB of spinning disk * Debian 8.2 64 bit * cw1: AMD HD6800 running the open-source radeon driver. * cw2: Nvidia GTX560 running the proprietary driver. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

Code freeze
by Alexandre Julliard 09 Dec '16

09 Dec '16

Folks, The release of 2.0-rc1 marks the beginning of code freeze towards 2.0. Most of you probably know the drill already, but from now on, only targeted bug fixes and other "safe" changes, like test fixes, translation updates, etc. will be accepted. I know that many people will soon be out for the holidays, but I hope we can still make significant progress with the open bugs, particularly with the bugs from the regression list. Now would also be a good time to retest your favorite applications to make sure that there are no regressions that we have missed. As usual, I'll be making release candidates every week, until we run out of bugs... Thank you all for helping make Wine 2.0 as good as we can! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/7] server: Added support for message mode named pipes.
by Alexandre Julliard 09 Dec '16

09 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/kernel32/tests/pipe.c | 74 ++----- > dlls/ntdll/file.c | 7 +- > dlls/ntdll/tests/file.c | 2 +- > server/async.c | 15 ++ > server/file.h | 2 + > server/named_pipe.c | 499 > ++++++++++++++++++++++++++++++++++++++++++--- > 6 files changed, 510 insertions(+), 89 deletions(-) This is causing various random failures during make test. I don't have a good reproducible case, but it seems to randomly break communication with services. For instance I see mountmgr-related errors, or hangs in the msi tests. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: dsound: Avoid casts from COM object to interface.
by Andrew Eikum 09 Dec '16

09 Dec '16

On Thu, Dec 08, 2016 at 11:29:42AM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 43b252d..d11c864 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -452,8 +452,8 @@ static HRESULT DirectSoundDevice_CreateSoundBuffer( > > if (device->primary) { > WARN("Primary Buffer already created\n"); > - IDirectSoundBuffer_AddRef((LPDIRECTSOUNDBUFFER8)(device->primary)); > - *ppdsb = (LPDIRECTSOUNDBUFFER)(device->primary); > + *ppdsb = (IDirectSoundBuffer *)&device->primary->IDirectSoundBuffer8_iface; > + IDirectSoundBuffer_AddRef(*ppdsb); > } else { Changing the order of these statements makes me nervous. Some applications use the returned pointers before the function returns, see 6a7c2f66e0569d2419eb9619e78716a9a5f94966. Andrew

1 0

[PATCH][RFC] msctf: Remove incorrect dereference of double pointer.
by Brock York 09 Dec '16

09 Dec '16

This is my attempt at a fix for Helldivers crashing on startup. This is my first Wine patch and I don't know the msctf system. I'm removing a dereference because it *seems* like the right thing to do. It seems to pass the msctf tests on my Arch box. If someone with more knowledge of msctf can give this a review and see if it's sane that would be appreciated. --------Patch below-------- Fixes https://bugs.winehq.org/show_bug.cgi?id=41252 ThreadMgr_QueryInterface is expecting ppvOut to be a pointer to a pointer. When UIElementMgr_QueryInterface calls the ThreadMgr_QueryInterface function it derefences the void **ppvOut making it a void *ppvOut when passing it in. When ThreadMgr_QueryInterface attempts to dereference this pointer to assign a pointer to it, it is instead accessing the value ppvOut is suppose to be pointing at. When the pointer ppvOut points to is NULL this causes a null pointer dereference Tested on Arch Linux Signed-off-by: Brock York <twunknown(a)gmail.com> --- dlls/msctf/threadmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index e1f56f1..62ddfd2 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -1187,7 +1187,7 @@ static HRESULT WINAPI UIElementMgr_QueryInterface(ITfUIElementMgr *iface, REFIID { ThreadMgr *This = impl_from_ITfUIElementMgr(iface); - return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, *ppvOut); + return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, ppvOut); } static ULONG WINAPI UIElementMgr_AddRef(ITfUIElementMgr *iface) -- 2.10.2

2 1

Re: [website] German translation for release 1.9.24
by Henri Verbeet 09 Dec '16

09 Dec '16

On 8 December 2016 at 16:06, Julian Rüger <jr98(a)gmx.net> wrote: > Dear D3D guys (esp. Stefan), do you have any suggestions or better translations for "unordered access views"? > Thanks! > My German isn't great, but "ungeordneten View-Zugriffen" sounds like "unordered view access" to me, which would be something else. (An UAV is a resource view that allows unordered/random read/write access to a resource from a shader, as opposed to e.g. shader resource views that only allow read access, or e.g. render target views that allow write access but only to a specific location.) You should probably check if Microsoft has an official translation for this, but lacking that I'd expect something along the lines of "ungeordnete Zugriffsview". Or whatever the appropriate translation of "view" would be in this context.

3 2

Re: [PATCH] ws2_32: Fix build failure on Mac
by Bruno Jesus 09 Dec '16

09 Dec '16

On Fri, Dec 9, 2016 at 3:11 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 3cdeade..6bf3c9d 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -1230,7 +1230,7 @@ static BOOL get_dont_fragment(SOCKET s, int level, BOOL *out) > static int once; > if (!once++) > FIXME("IP_DONTFRAGMENT for IPv6 not supported in this platform\n"); > - return TRUE /* fake success */ > + return TRUE; /* fake success */ > #endif Sorry for that, I tested the defines before cloning the block and for some reason I messed the last block.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Alexandre Julliard 08 Dec '16

08 Dec '16

Lauri Kenttä <lauri.kentta(a)gmail.com> writes: > v2: Win8 and Win10 give different results (sometimes even > different different results), so mark some cases as broken. > Also simplify the patch overall. I don't think that painting on the desktop window is a very useful test, and it can fail for various reasons. If the goal is to test LockWindowUpdate, you should do that with top-level windows instead. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [PATCH 09/11] wined3d: Recognize dynamic linking shader instructions.
by Henri Verbeet 08 Dec '16

08 Dec '16

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This patch was written while testing the ret instruction in subroutines. Sets > of function bodies/tables are not parsed yet. If preferred, it can be split > into 5 patches (one for each instruction). > Not enough to make you redo it, but yes, split would have been preferred.

1 0

Re: [PATCH 08/11] d3d11/tests: Add test for primitive restart.
by Henri Verbeet 08 Dec '16

08 Dec '16

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + get_texture_readback(test_context.backbuffer, 0, &rb); > + for (y = 0; y < 480; ++y) > + { > + for (x = 0; x < 640; ++x) > + { > + DWORD color = get_readback_color(&rb, x, y); > + DWORD expected_color; > + if (x < 240) > + expected_color = 0xffffff00; > + else if (x >= 640 - 240) > + expected_color = 0xff0000ff; > + else > + expected_color = 0x00000000; > + ok(compare_color(color, expected_color, 1), > + "Test %u: Got 0x%08x, expected 0x%08x at (%u, %u).\n", > + i, color, expected_color, x, y); > + } > + } > + release_resource_readback(&rb); For what it's worth, if we'll have more tests like this in the future, adding an optional rectangle argument to check_texture_color() may be useful.

1 0

Re: [PATCH] wincodecs: Remove some of error handling duplication in InitializePredefined()
by Dmitry Timoshkov 08 Dec '16

08 Dec '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > case WICBitmapPaletteTypeFixedHalftone125: > colors = generate_halftone125_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone216: > colors = generate_halftone216_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone252: > colors = generate_halftone252_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone256: > colors = generate_halftone256_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > default: > @@ -406,6 +417,9 @@ static HRESULT WINAPI PaletteImpl_InitializePredefined(IWICPalette *iface, > return E_INVALIDARG; > } > > + if (!colors) > + return E_OUTOFMEMORY; That's hardly an improvement, at best this is a personal preference. When I wrote this code I was considering other versions as well, and current variant I like better. Please leave this code as it is. -- Dmitry.

1 0

Re: [PATCH] uxtheme: Return E_POINTER if RECT pointer is NULL.
by Nikolay Sivov 08 Dec '16

08 Dec '16

On Tue, 6 Dec 2016 08:37:32 +0100 Hadrien Boizard <h.boizard(a)gmail.com> wrote: > DrawTextW(hdc, pszText, iCharCount, &rt, dwTextFlags|DT_CALCRECT); > + if(!pExtentRect) > + return E_POINTER; > *pExtentRect = rt; This needs a test.

1 0

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by Bruno Jesus 08 Dec '16

08 Dec '16

On Tue, Nov 22, 2016 at 5:46 PM, Jeremy White <jwhite(a)codeweavers.com> wrote: > Signed-off-by: Jeremy White <jwhite(a)codeweavers.com> > --- > This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with xdg-email. Hi, for unknown reasons I did not receive the v4 email so I'm replying here. Is there any way to test this without Microsoft Office? Best wishes, Bruno

2 1

Re: [PATCH] msacm32: Support conversion from 24-bit PCM
by Lauri Kenttä 07 Dec '16

07 Dec '16

On 2016-12-05 19:28, Andrew Eikum wrote: > +static inline short C2416(int s) > +{ > + return HIWORD(s); > +} > + Just wondering: Is it true that msacm32 doesn't do any dithering? -- Lauri Kenttä

2 1

Re: [PATCH] kernel32/tests: Mask out FILE_ATTRIBUTE_COMPRESSED to prevent failures.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27243 Your paranoid android. === wxppro (32 bit file) === file.c:2389: Test failed: open failed for modes 40/2/40010000/2 file.c:2393: Test failed: wrong error code 32

1 0

Re: [TEST v2] user32/tests: Add tests for LockWindowUpdate.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27238 Your paranoid android. === wvistau64 (32 bit win) === win.c:8981: Test failed: GetActiveWindow() = 000200E0 win.c:8981: Test failed: GetFocus() = 000200E0 === w8 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200 === w864 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200

1 0

Re: [TEST] user32/tests: Add tests for LockWindowUpdate.
by Marvin 07 Dec '16

07 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27237 Your paranoid android. === w8 (32 bit win) === win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (64 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff

1 0

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Jens Reyer 07 Dec '16

07 Dec '16

On 07.12.2016 07:27, Bruno Jesus wrote: > I have used this in some situations to check how network enabled applications react to not having network access. IMO it is useful but if nobody cares I don't mind it being rejected. I like it. Can you document it in a manpage? Greets jre

2 2

Re: [PATCH] d2d1/tests: Change rotation angle in test_bitmap_brush().
by Henri Verbeet 07 Dec '16

07 Dec '16

On 7 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Fixes the test failure with Nvidia binary driver. > Well yes, but that's a much less interesting rotation.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Marvin 06 Dec '16

06 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27177 Your paranoid android. === w8 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (64 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (64 bit win) === win.c:9388: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff

1 0

WineHQ packages for 1.9.24
by Rosanne DiMesio 06 Dec '16

06 Dec '16

WineHQ packages for 1.9.24 still haven't been built for any of the distros, and users are asking about them. What's going on? -- Rosanne DiMesio dimesio(a)earthlink.net

3 2

Serial port sniffing problem
by Bill Lionheart 06 Dec '16

06 Dec '16

Using Wine version 1.8 on Ubuntu 14.04.5 I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a serial interface. The device is supplied with a Prolific USB serial converter which comes up as /dev/ttyUSB0 which I have sym linked to COM1 The bundled GPRS tracker config software installs and runs OK under Wine. But my attempts to sniff the serial port traffic fails using all the standard Linux methods I know. I also tried using the Windows program Serial Port Monitor under Wine http://www.eltima.com/products/serial-port-monitor/ . This program says it cannot detect any serial ports. Under Windows 7 the config program and Serial Port Monitor both work well and I can intercept all the serial traffic Any ideas please folks? Bill

3 4

Calling msvcp90 (C++) functions from Wine code
by Lauri Kenttä 06 Dec '16

06 Dec '16

Hey, In a patch [1] I ended up recreating a function that practically exists already in msvcp90 as tr2_sys__Equivalent_wchar. However, I'm guessing it's not okay to call tr2_sys__Equivalent_wchar directly, since it's really a C++ function. Is there some valid and portable way to use this tr2_sys__Equivalent_wchar within another part of Wine (in this case, cmd.exe), to avoid duplicate code? [1] http://source.winehq.org/patches/data/128310 -- Lauri Kenttä

3 3

Re: [PATCH] user32: Handle WM_SYSKEYDOWN in MENU_SuspendPopup.
by Alexandre Julliard 06 Dec '16

06 Dec '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Technically, all the stuff about WM_SYSKEYDOWN is unnecessary. All we > really need to do is fix the error handling, or remove this questionable > optimization altogether. I'm not sure what you mean by that. Also you are essentially reverting d75b0cdc986f464f3067767cd53aca6b85feb366, I'd like to hear some justification for that. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH v3] cmd: Fix copying when the dest is one of the sources.
by Marvin 05 Dec '16

05 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27154 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2] cmd: Fix copying when the dest is one of the sources.
by Marvin 05 Dec '16

05 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27152 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: kernel32: Implement Process thread attribute lists.
by Dmitry Timoshkov 05 Dec '16

05 Dec '16

Huw Davies <huw(a)codeweavers.com> wrote: > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 3c25286..224e6ae 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec ... > +@ stdcall DeleteProcThreadAttributeList(ptr) ... > +@ stdcall InitializeProcThreadAttributeList(ptr long long ptr) ... > +@ stdcall UpdateProcThreadAttribute(ptr long long ptr long ptr ptr) UMS (User Mode Scheduler) stuff should be implemented in ntdll and kernel32 APIs should be either forwards or thin wrappers around the ntdll exports. So, to avoid duplicate efforts this all from the start needs to be implemeted in ntdll. -- Dmitry.

2 5

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Hans Leidekker 05 Dec '16

05 Dec '16

On Sat, 2016-12-03 at 00:15 -0200, Bruno Jesus wrote: > @@ -2446,8 +2476,32 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > return -1; > } > > + if (wsa->addr->sa_family == WS_AF_INET) > + { > + /* When the target IPv4 address ends in 255 we are going to check if > + * it matches the broadcast address. Trying to send the packet without > + * setting SO_BROADCAST results in EACCES, to avoid that we will enable > + * the flag and send the packet, after that we will restore the flag > + * This is the most common estimate to reduce the number of UDP packets > + * that we need to check. */ > + struct sockaddr_in *addr = (struct sockaddr_in*) hdr.msg_name; > + in_addr_t address = addr->sin_addr.s_addr; > + > + if (address != INADDR_BROADCAST && (address & 0xFF000000) == 0xFF000000) This doesn't work for a /25 network, for example. You really need to use the network mask here to calculate the broadcast address. > +/* required for broadcast tests */ > +static void disable_firewall(void) > +{ > + system("netsh firewall set opmode disable"); /* XP */ > + system("netsh Advfirewall set allprofiles state off"); /* >= Vista*/ > +} > + > +static void enable_firewall(void) > +{ > + system("netsh firewall set opmode enable"); /* XP */ > + system("netsh Advfirewall set allprofiles state on"); /* >= Vista*/ > +} This will not work if the test is run as an unprivileged user. It would be better to use an API like INetFwMgr and skip the affected tests when you can't modify the firewall. I'm working on a fix for a similar problem in the rpcrt4 test. I can share a patch if you're interested.

3 6

Re: [PATCH v2] wined3d: Implement SM5 atomic_umax/min instructions.
by Józef Kucia 05 Dec '16

05 Dec '16

On Sun, Dec 4, 2016 at 6:49 PM, Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > @@ -897,6 +899,8 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = > {WINED3D_SM5_OP_LD_STRUCTURED, WINED3DSIH_LD_STRUCTURED, "u", "iiR"}, > {WINED3D_SM5_OP_STORE_STRUCTURED, WINED3DSIH_STORE_STRUCTURED, "U", "iiu"}, > {WINED3D_SM5_OP_ATOMIC_IADD, WINED3DSIH_ATOMIC_IADD, "U", "ii"}, >+ {WINED3D_SM5_OP_ATOMIC_UMAX, WINED3DSIH_ATOMIC_UMAX, "U", "uu"}, >+ {WINED3D_SM5_OP_ATOMIC_UMIN, WINED3DSIH_ATOMIC_UMIN, "U", "uu"}, This is wrong. The generated GLSL code will produce compiler errors. FWIW, I should have patches for various atomics with some tests soon.

2 1

Re: [PATCH 03/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet 05 Dec '16

05 Dec '16

On 5 December 2016 at 12:04, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 335 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 335 insertions(+) > This fails here on Windows: d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0.

1 0

Re: [PATCH 02/18] wined3d: Set default sampler minification filter to GL_NEAREST.
by Józef Kucia 05 Dec '16

05 Dec '16

On Mon, Dec 5, 2016 at 12:04 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This seems to be required for reading stencil values. The GL spec says > "When sampling the stencil index only NEAREST filtering is supported.". > The GL spec is inconsistent about this, but Mesa refuses to sample > stencil index values with the GL_NEAREST_MIPMAP_NEAREST filter. The NEAREST_MIPMAP_NEAREST is going to be allowed in Mesa (there is a patch for this [1]). However, the ARB_stencil_texturing spec was never updated, and an implementation of OpenGL which does not expose GL 4.5 doesn't have to allow using NEAREST_MIPMAP_NEAREST for stencil texturing. [1] - https://lists.freedesktop.org/archives/mesa-dev/2016-December/137309.html

1 0

Re: [PATCH] user32: Fix handling of invert_y in DrawTextExW.
by Dmitry Timoshkov 05 Dec '16

05 Dec '16

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > From: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> 1. this needs some tests 2. are you planning to fix any regressions caused by this patch without relying on Sebastian's help? -- Dmitry.

2 2

Windows 2008 does not support MP3 correctly in msacm32.dll?
by Bruno Jesus 05 Dec '16

05 Dec '16

Hi, in an attempt to add MP3 tests from Michael Müller it looks like the only machine that has trouble is Windows 2008 [1]. Around half of the tests are rejected while in all other versions it worked fine. Could there be a simple explanation to this? [1] https://testbot.winehq.org/JobDetails.pl?Key=27009 Best wishes, Bruno

2 2

Re: [PATCH] Updated Readme with Github Markdown
by Alex Henrie 04 Dec '16

04 Dec '16

Hello Varunram, and thanks for your interest in contributing to Wine. The patch you submitted is very unlikely to be accepted because we, like the Linux kernel and many other projects, optimize our READMEs for terminal text editors rather than for GitHub. Also, if you submit any more patches in the future, please be sure to use your real name and include a Signed-off-by line. -Alex

1 0

WineHQ Forums: Slackware multi-lib Wine build issues
by Bob Wya 04 Dec '16

04 Dec '16

Hiya, I've gotten really stuck trying to help out a Slackware user (yes they still exist!) on the WineHQ forums... Been bashing away at this problem for over a month now. He's trying to build a Shared WoW64 Wine. The build logs look clean. But the 32-bit half of Wine is segfaulting immediately. The 64-bit half appears to function as normal. I feel like I've hit a brick wall now... Anyone able to help? See: https://forum.winehq.org/viewtopic.php?f=8&t=27879 -- All the best, Robert

1 0

Re: [v2 1/2] wined3d: Implement primitive restart index.
by Józef Kucia 04 Dec '16

04 Dec '16

On Fri, Nov 18, 2016 at 4:44 AM, Andrew Wesie <awesie(a)gmail.com> wrote: > @@ -8602,6 +8602,16 @@ static void shader_glsl_init_context_state(struct wined3d_context *context) > > gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE); > checkGLcall("GL_PROGRAM_POINT_SIZE"); > + if (gl_info->supported[ARB_ES3_COMPATIBILITY]) > + { > + /* We prefer this method because it correctly handles 16-bit and 32-bit indices. */ > + gl_info->gl_ops.gl.p_glEnable(GL_PRIMITIVE_RESTART_FIXED_INDEX); > + checkGLcall("GL_PRIMITIVE_RESTART_FIXED_INDEX"); > + } Is it really safe to enable the primitive restart for all D3D versions? Shouldn't we enable it just for D3D10+? See, e.g., e47a735f762ebe1545bb366c7e9e2b90db7c7f80, if it's decided that this should be enabled just for D3D10+. > + else > + { > + WARN("Missing support for primitive restart index.\n"); > + } This is not important, but ideally this would be a FIXME() for D3D10+ feature level >= 10_0 and nothing otherwise. > } > > static void shader_glsl_get_caps(const struct wined3d_gl_info *gl_info, struct shader_caps *caps) > diff --git a/dlls/wined3d/wined3d_gl.h b/dlls/wined3d/wined3d_gl.h > index b71190d..7bd2d6a 100644 > --- a/dlls/wined3d/wined3d_gl.h > +++ b/dlls/wined3d/wined3d_gl.h > @@ -55,6 +55,7 @@ enum wined3d_gl_extension > ARB_DRAW_ELEMENTS_BASE_VERTEX, > ARB_DRAW_INSTANCED, > ARB_ES2_COMPATIBILITY, > + ARB_ES3_COMPATIBILITY, > ARB_EXPLICIT_ATTRIB_LOCATION, > ARB_FRAGMENT_COORD_CONVENTIONS, > ARB_FRAGMENT_PROGRAM, The extension has to be also added to the "core_extensions" table.

2 2

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Lauri Kenttä 03 Dec '16

03 Dec '16

On 2016-12-03 22:27, Lauri Kenttä wrote: > Inspired by bug 7961. > > v2: Apparently Windows has much more strict limits for file names on > native file systems (compared to VirtualBox shared folders), so this > version of the patch leaves out some of the more problematic ones. > Tested on Windows 2003 Server with NTFS. The remaining TestBot failures are not my fault, again. Also, the "much more strict limits" part was a bit exaggerated. There were simply two file names ending with dots, even though I knew they wouldn't work on FAT32 or NTFS. I thought I had removed them already. Anyway, that's fixed in this v2. -- Lauri Kenttä

1 0

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27101 Your paranoid android. === wxppro (32 bit file) === file.c:2388: Test failed: open failed for modes 0/2/c0000000/2 file.c:2392: Test failed: wrong error code 32 === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27099 Your paranoid android. === wxppro (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2003std (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7u (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w8 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none

1 0

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Marvin 03 Dec '16

03 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27089 Your paranoid android. === w2003std (32 bit sock) === An error occurred while retrieving the test report: network read got a premature EOF (getfile:ListSize:0/4) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH 7/7] bcrypt: Mostly implement AES decryption
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27082 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] bcrypt: Implement AES encryption
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27081 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] bcrypt: Beginnings of the AES provider
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27080 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] bcrypt: Implement BCryptGenerateSymmetricKey function
by Bruno Jesus 02 Dec '16

02 Dec '16

OOps, sorry for that. I pasted the wrong command in the terminal. This is the real deal but was only supposed to be sent if the previous 5 test patches were commited. On Fri, Dec 2, 2016 at 8:28 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > From: Hans Leidekker <hans(a)codeweavers.com> > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/bcrypt/bcrypt_main.c | 79 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > > diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c > index 6023c94..50c05c0 100644 > --- a/dlls/bcrypt/bcrypt_main.c > +++ b/dlls/bcrypt/bcrypt_main.c > @@ -138,6 +138,8 @@ NTSTATUS WINAPI BCryptEnumAlgorithms(ULONG dwAlgOperations, ULONG *pAlgCount, > > #define MAGIC_ALG (('A' << 24) | ('L' << 16) | ('G' << 8) | '0') > #define MAGIC_HASH (('H' << 24) | ('A' << 16) | ('S' << 8) | 'H') > +#define MAGIC_KEY (('K' << 24) | ('E' << 16) | ('Y' << 8) | '0') > + > struct object > { > ULONG magic; > @@ -172,6 +174,8 @@ struct algorithm > BOOL hmac; > }; > > +static ULONG get_block_size( enum alg_id alg ); > + > NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE handle, UCHAR *buffer, ULONG count, ULONG flags) > { > const DWORD supported_flags = BCRYPT_USE_SYSTEM_PREFERRED_RNG; > @@ -541,6 +545,37 @@ static NTSTATUS hmac_finish( struct hash *hash, UCHAR *output, ULONG size ) > pgnutls_hmac_deinit( hash->u.hmac_handle, output ); > return STATUS_SUCCESS; > } > + > +struct key > +{ > + struct object hdr; > + enum alg_id alg_id; > + ULONG block_size; > + gnutls_cipher_hd_t handle; > + UCHAR *secret; > + ULONG secret_len; > +}; > + > +static NTSTATUS key_init( struct key *key, enum alg_id id, UCHAR *secret, ULONG secret_len ) > +{ > + if (!libgnutls_handle) return STATUS_INTERNAL_ERROR; > + > + switch (id) > + { > + default: > + FIXME( "algorithm %u not supported\n", id ); > + return STATUS_NOT_SUPPORTED; > + } > + > + if (!(key->block_size = get_block_size( id ))) return STATUS_INVALID_PARAMETER; > + > + key->alg_id = id; > + key->handle = 0; /* initialized on first use */ > + key->secret = secret; > + key->secret_len = secret_len; > + > + return STATUS_SUCCESS; > +} > #else > struct hash > { > @@ -584,6 +619,17 @@ static NTSTATUS hmac_finish( struct hash *hash, UCHAR *output, ULONG size ) > ERR( "support for hashes not available at build time\n" ); > return STATUS_NOT_IMPLEMENTED; > } > + > +struct key > +{ > + struct object hdr; > +}; > + > +static NTSTATUS key_init( struct key *key, enum alg_id id, const UCHAR *secret, ULONG secret_len ) > +{ > + ERR( "support for keys not available at build time\n" ); > + return STATUS_NOT_IMPLEMENTED; > +} > #endif > > #define OBJECT_LENGTH_MD5 274 > @@ -694,6 +740,13 @@ static NTSTATUS get_alg_property( enum alg_id id, const WCHAR *prop, UCHAR *buf, > return STATUS_SUCCESS; > } > > +static ULONG get_block_size( enum alg_id alg ) > +{ > + ULONG ret = 0, size = sizeof(ret); > + get_alg_property( alg, BCRYPT_BLOCK_LENGTH, (UCHAR *)&ret, sizeof(ret), &size ); > + return ret; > +} > + > static NTSTATUS get_hash_property( enum alg_id id, const WCHAR *prop, UCHAR *buf, ULONG size, ULONG *ret_size ) > { > NTSTATUS status; > @@ -854,6 +907,32 @@ NTSTATUS WINAPI BCryptHash( BCRYPT_ALG_HANDLE algorithm, UCHAR *secret, ULONG se > return BCryptDestroyHash( handle ); > } > > +NTSTATUS WINAPI BCryptGenerateSymmetricKey( BCRYPT_ALG_HANDLE algorithm, BCRYPT_KEY_HANDLE *handle, > + UCHAR *object, ULONG object_len, UCHAR *secret, ULONG secret_len, > + ULONG flags ) > +{ > + struct algorithm *alg = algorithm; > + struct key *key; > + NTSTATUS status; > + > + TRACE( "%p, %p, %p, %u, %p, %u, %08x\n", alg, handle, object, object_len, secret, secret_len, flags ); > + > + if (!alg || alg->hdr.magic != MAGIC_ALG) return STATUS_INVALID_HANDLE; > + if (object) FIXME( "ignoring object buffer\n" ); > + > + if (!(key = HeapAlloc( GetProcessHeap(), 0, sizeof(*key) ))) return STATUS_NO_MEMORY; > + key->hdr.magic = MAGIC_KEY; > + > + if ((status = key_init( key, alg->id, secret, secret_len ))) > + { > + HeapFree( GetProcessHeap(), 0, key ); > + return status; > + } > + > + *handle = key; > + return STATUS_SUCCESS; > +} > + > BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > { > switch (reason) > -- > 2.9.3 >

1 0

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by André Hentschel 02 Dec '16

02 Dec '16

Hi, comments inline Am 22.11.2016 um 20:46 schrieb Jeremy White: > -ULONG WINAPI MAPISendMail(LHANDLE session, ULONG_PTR uiparam, > +static ULONG BrowserSendMail(LHANDLE session, ULONG_PTR uiparam, > lpMapiMessage message, FLAGS flags, ULONG reserved) > { > ULONG ret = MAPI_E_FAILURE; > @@ -291,6 +370,129 @@ exit: > return ret; > } Do you need all those parameters? > +/************************************************************************** > + * XDGSendMail > + * > + * Send a message using xdg-email mail client. > + * > + */ > +ULONG XDGSendMail(LHANDLE session, ULONG_PTR uiparam, > + lpMapiMessage message, FLAGS flags, ULONG reserved) Same here Also should be a static function > + > + TRACE("(0x%08lx 0x%08lx %p 0x%08x 0x%08x)\n", session, uiparam, message, flags, reserved); I'd keep the TRACE in the WINAPI function > + > + if (!message) > + return MAPI_E_FAILURE; maybe this check, too > + max_args = 1 + (2 + message->nRecipCount + message->nFileCount) * 2; > + argv = HeapAlloc(GetProcessHeap(), 0, (max_args + 1) * sizeof(*argv)); > + if (!argv) > + return MAPI_E_INSUFFICIENT_MEMORY; > + > + ret = add_argument(argv, &argc, "xdg-email", NULL); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + > + if (message->lpOriginator) > + TRACE("From: %s (unused)\n", debugstr_a(message->lpOriginator->lpszAddress)); Why is the TRACE message different from the original function? > + > + for (i = 0; i < message->nRecipCount; i++) > + { > + if (!message->lpRecips) > + { > + WARN("Recipient %d missing\n", i); > + ret = MAPI_E_FAILURE; > + goto exit; > + } > + > + if (message->lpRecips[i].lpszAddress) > + { > + ret = add_target(argv, &argc, message->lpRecips[i].ulRecipClass, add_target is only used in one place, no need for a helper function IMO > + message->lpRecips[i].lpszAddress); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + } > + else > + FIXME("Name resolution and entry identifiers not supported\n"); > + } > + > + for (i = 0; i < message->nFileCount; i++) > + { > + TRACE("File Path: %s, name %s\n", debugstr_a(message->lpFiles[i].lpszPathName), > + debugstr_a(message->lpFiles[i].lpszFileName)); > + ret = add_file(argv, &argc, message->lpFiles[i].lpszPathName, message->lpFiles[i].lpszFileName); Same for add_file Hope that helps

2 1

Re: [PATCH 5/5] bcrypt/tests: Add BCryptEncrypt/Decrypt tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27070 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 622 bcrypt.c:848: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654

2 2

Re: [PATCH 4/5] bcrypt/tests: Add BCryptGenerateSymmetricKey tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27069 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 598 bcrypt.c:848: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 622 bcrypt.c:848: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:792: Test failed: got 654 bcrypt.c:848: Test failed: got 654

1 0

Re: [PATCH 3/5] bcrypt/tests: Add AES provider tests
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27068 Your paranoid android. === wvistau64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 598 === w2008s64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 598 === w7pro64 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 622 === w864 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 654 === w1064 (64 bit bcrypt) === bcrypt.c:783: Test failed: got 654

1 0

Re: [PATCH 1/3] server: Introduced iosb struct for server-side IO_STATUS_BLOCK representation and use it in irp_call.
by Alexandre Julliard 02 Dec '16

02 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > +/* release iosb reference */ > +void release_iosb( struct iosb *iosb ) > +{ > + if (--iosb->refcount) return; > + > + free( iosb->in_data ); > + free( iosb->out_data ); > + free( iosb ); > +} I think you should use a proper server object instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Signal pipe server fd in create_pipe_server.
by Marvin 02 Dec '16

02 Dec '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27047 Your paranoid android. === w2008s64 (32 bit pipe) === Unable to set the VM system time: the "nc -q0 '10.42.42.136' '4242'" command returned 1 (settime/connect). Maybe the TestAgentd process is missing the required privileges. The test VM is powered off! Did the test shut it down?

1 0

Re: [PATCH] dxgi: Silence a noisy fixme
by Henri Verbeet 02 Dec '16

02 Dec '16

On 2 December 2016 at 10:26, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > static HRESULT STDMETHODCALLTYPE dxgi_output_WaitForVBlank(IDXGIOutput *iface) > { > - FIXME("iface %p stub!\n", iface); > + BOOL once = FALSE; > + > + if (!once++) > + FIXME("iface %p stub!\n", iface); > > return E_NOTIMPL; > } Did you test that this does what you think it does? Leaving that issue aside for the moment, while printing the FIXME only once is probably fine, not tracing anything on subsequent calls isn't.

1 0

Re: [PATCH] dxgi: Silence a noisy fixme
by Hans Leidekker 02 Dec '16

02 Dec '16

On Fri, 2016-12-02 at 09:26 +0000, Alistair Leslie-Hughes wrote: > diff --git a/dlls/dxgi/output.c b/dlls/dxgi/output.c > index 0cf8084..61a7043 100644 > --- a/dlls/dxgi/output.c > +++ b/dlls/dxgi/output.c > @@ -268,7 +268,10 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_FindClosestMatchingMode(IDXGIOutput > > static HRESULT STDMETHODCALLTYPE dxgi_output_WaitForVBlank(IDXGIOutput *iface) > { > - FIXME("iface %p stub!\n", iface); > + BOOL once = FALSE; > + > + if (!once++) > + FIXME("iface %p stub!\n", iface); > > return E_NOTIMPL; > } static BOOL once;

1 0

Call for tests - GNU/Linux & specially OSX - iphlpapi
by Bruno Jesus 02 Dec '16

02 Dec '16

Hello all, in order to exercise an IP ordering problem from bug 40247 (OSX) [1] I would like to request help for testing the crosstest at [2]. Valid testers must have at least 1 network interface with a valid IP and a the loopback interface up. A good test should result in 1 error, if not send me the results anyway, only the traces from lines 262 and 266 are needed (first in the log, 10 lines should be enough). If you find the lines I'm expecting just paste them, if you don't have patience just attach the whole results, pĺease. Sample output: bruno@Note:~/programs/wine32/dlls/iphlpapi/tests$ wine iphlpapi_crosstest.exe iphlpapi.c:262: Entry[0]: addr 127.0.0.1, dwIndex 1, wType 0x1 iphlpapi.c:266: Test failed: Loopback interface wrongly at position 0/3 iphlpapi.c:262: Entry[1]: addr 192.168.1.34, dwIndex 3, wType 0x1 iphlpapi.c:262: Entry[2]: addr 192.168.112.1, dwIndex 4, wType 0x1 iphlpapi.c:262: Entry[3]: addr 192.168.27.1, dwIndex 5, wType 0x1 [1] https://bugs.winehq.org/show_bug.cgi?id=40247 [2] https://testbot.winehq.org/JobDetails.pl?Key=27012 Thanks in advance, Bruno

2 2

Testing Direct3D
by Fabian Maurer 01 Dec '16

01 Dec '16

Hello Wine-Devel, It might be a stupid question, but how do you test the Direct3D implementation? I don't mean the conformance tests, these too need to get the data somewhere. So you probably have a windows running somewhere. I currently I don't have a windows machine to test on though. Only a Virtualbox VM, and this doesn't offer (reliable) 3D acceleration for DX > 9. Do you have your own windows machine dedicated to this, or how do you do it?

3 5

Re: [PATCH 2/2] winmm: Use a thread to send driver messages on Win9x (try 2)
by Andrew Eikum 01 Dec '16

01 Dec '16

This seems like something you should be able to write a test for. I'm also curious how this manages to work on Windows >= XP You need to be more careful about thread shutdown. See WINMM_StartDevicesThread and WINMM_DevicesThreadProc. I think you could use the same logic, including WINMM_DevicesThreadDone, to determine when to quit your new thread. Andrew On Thu, Dec 01, 2016 at 11:32:35AM -0200, Bruno Jesus wrote: > try 2: > Use a better way to detect Win9x (thanks Dmitry) > Use a single point of config/teardown and a pointer to callback (thanks Nikolay) > > More detailed explanation in the patch comments. Basically the games use a DLL that calls SuspendThread from inside the WinMM callback, this makes the program hang as we use the "main thread" to dispatch callbacks. > > Games tested in Win95 config: > Heroes of Might & Magic (well known affected) > Deadlock (well known affected) > Worms 2 (just to ensure things still work) > Age of Empires (just to ensure things still work) > Shivers (just to ensure things still work) > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=3930 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/winmm/waveform.c | 117 ++++++++++++++++++++++++++++++++++++++++++-------- > dlls/winmm/winemm.h | 1 + > dlls/winmm/winmm.c | 2 +- > 3 files changed, 101 insertions(+), 19 deletions(-) > > diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c > index 7308519..4387c44 100644 > --- a/dlls/winmm/waveform.c > +++ b/dlls/winmm/waveform.c > @@ -134,6 +134,13 @@ struct _WINMM_MMDevice { > WINMM_Device *devices[MAX_DEVICES]; > }; > > +static struct { > + HANDLE thread, event_main, event_thread; > + WINMM_CBInfo *info; > + WORD msg; > + DWORD_PTR param1, param2; > +} win9x; > + > static WINMM_MMDevice *g_out_mmdevices; > static WINMM_MMDevice **g_out_map; > static UINT g_outmmdevices_count; > @@ -192,6 +199,77 @@ static LRESULT WID_Open(WINMM_OpenInfo *info); > static LRESULT WID_Close(HWAVEIN hwave); > static MMRESULT WINMM_BeginPlaying(WINMM_Device *device); > > +static void (*pWINMM_NotifyClient)(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2); > + > + > +static DWORD WINAPI win9x_callback_thread(LPVOID param) > +{ > + while(WaitForSingleObject(win9x.event_thread, INFINITE) == WAIT_OBJECT_0) > + { > + if (!win9x.info->hwave) break; > + DriverCallback(win9x.info->callback, win9x.info->flags, (HDRVR)win9x.info->hwave, > + win9x.msg, win9x.info->user, win9x.param1, win9x.param2); > + SetEvent(win9x.event_main); > + } > + return 0; > +} > + > +/* Note: NotifyClient should never be called while holding the device lock > + * since the client may call wave* functions from within the callback. */ > +static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2) > +{ > + DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > + msg, info->user, param1, param2); > +} > + > +static inline void WINMM_NotifyClient9x(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > + DWORD_PTR param2) > +{ > + /* Prepare callback data for the thread, dispatch and wait response */ > + win9x.info = info; > + win9x.msg = msg; > + win9x.param1 = param1; > + win9x.param2 = param2; > + SetEvent(win9x.event_thread); > + WaitForSingleObject(win9x.event_main, INFINITE); > +} > + > +void WINMM_SetupCallback(void) > +{ > + pWINMM_NotifyClient = WINMM_NotifyClient; > + if (!(GetVersion() & 0x80000000)) > + return; > + > + /* WAIL32.DLL from Rad Game Tools is an audio helper DLL that simplifies the > + * use of sound effects in an application. It seems to be released in 1996 and > + * is used at least by Heroes of Might and Magic and Deadlock. Unfortunately > + * during a callback to the DLL it calls SuspendThread on the main thread and > + * keeps doing some stuff from inside the callback until it does a ResumeThread > + * and returns from the callback. This works in Windows 95/98 because they use > + * a separate thread to send callback messages. XP changed this by going back > + * to a single thread but the games still works due to shim. > + */ > + TRACE("Using old behavior of WinMM callbacks\n"); > + win9x.event_thread = CreateEventA(NULL, FALSE, FALSE, NULL); > + win9x.event_main = CreateEventA(NULL, FALSE, FALSE, NULL); > + win9x.thread = CreateThread(NULL, 0, win9x_callback_thread, NULL, 0, NULL); > + if (win9x.event_thread && win9x.event_main && win9x.thread) > + pWINMM_NotifyClient = WINMM_NotifyClient9x; > + else > + { > + ERR("Failed to create resources for callback, expect problems!\n"); > + TerminateThread(win9x.thread, 0); > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + return; > + } > +} > + > +/* tear down function for DLL process detach */ > void WINMM_DeleteWaveform(void) > { > UINT i, j; > @@ -241,6 +319,18 @@ void WINMM_DeleteWaveform(void) > HeapFree(GetProcessHeap(), 0, g_device_handles); > HeapFree(GetProcessHeap(), 0, g_handle_devices); > > + if (win9x.thread) > + { > + /* warn the thread so it can die gracefully */ > + win9x.info->hwave = 0; > + SetEvent(win9x.event_thread); > + > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + } > + > DeleteCriticalSection(&g_devthread_lock); > } > > @@ -370,15 +460,6 @@ static WINMM_Device *WINMM_GetDeviceFromHWAVE(HWAVE hwave) > return device; > } > > -/* Note: NotifyClient should never be called while holding the device lock > - * since the client may call wave* functions from within the callback. */ > -static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > - DWORD_PTR param2) > -{ > - DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > - msg, info->user, param1, param2); > -} > - > static MMRESULT hr2mmr(HRESULT hr) > { > switch(hr){ > @@ -1753,7 +1834,7 @@ exit: > WAVEHDR *next = first->lpNext; > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > first = next; > } > } > @@ -1929,7 +2010,7 @@ exit: > WAVEHDR *next = first->lpNext; > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > first = next; > } > } > @@ -2022,9 +2103,9 @@ static LRESULT WINMM_Reset(HWAVE hwave) > first->dwFlags &= ~WHDR_INQUEUE; > first->dwFlags |= WHDR_DONE; > if(is_out) > - WINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WOM_DONE, (DWORD_PTR)first, 0); > else > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)first, 0); > first = next; > } > > @@ -2774,7 +2855,7 @@ MMRESULT WINAPI waveOutOpen(LPHWAVEOUT lphWaveOut, UINT uDeviceID, > cb_info.user = dwInstance; > cb_info.hwave = info.handle; > > - WINMM_NotifyClient(&cb_info, WOM_OPEN, 0, 0); > + pWINMM_NotifyClient(&cb_info, WOM_OPEN, 0, 0); > > return res; > } > @@ -2802,7 +2883,7 @@ UINT WINAPI waveOutClose(HWAVEOUT hWaveOut) > res = SendMessageW(g_devices_hwnd, WODM_CLOSE, (WPARAM)hWaveOut, 0); > > if(res == MMSYSERR_NOERROR) > - WINMM_NotifyClient(&cb_info, WOM_CLOSE, 0, 0); > + pWINMM_NotifyClient(&cb_info, WOM_CLOSE, 0, 0); > > return res; > } > @@ -3410,7 +3491,7 @@ MMRESULT WINAPI waveInOpen(HWAVEIN* lphWaveIn, UINT uDeviceID, > cb_info.user = dwInstance; > cb_info.hwave = info.handle; > > - WINMM_NotifyClient(&cb_info, WIM_OPEN, 0, 0); > + pWINMM_NotifyClient(&cb_info, WIM_OPEN, 0, 0); > > return res; > } > @@ -3438,7 +3519,7 @@ UINT WINAPI waveInClose(HWAVEIN hWaveIn) > res = SendMessageW(g_devices_hwnd, WIDM_CLOSE, (WPARAM)hWaveIn, 0); > > if(res == MMSYSERR_NOERROR) > - WINMM_NotifyClient(&cb_info, WIM_CLOSE, 0, 0); > + pWINMM_NotifyClient(&cb_info, WIM_CLOSE, 0, 0); > > return res; > } > @@ -3586,7 +3667,7 @@ UINT WINAPI waveInStop(HWAVEIN hWaveIn) > if(buf){ > buf->dwFlags &= ~WHDR_INQUEUE; > buf->dwFlags |= WHDR_DONE; > - WINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)buf, 0); > + pWINMM_NotifyClient(&cb_info, WIM_DATA, (DWORD_PTR)buf, 0); > } > > return MMSYSERR_NOERROR; > diff --git a/dlls/winmm/winemm.h b/dlls/winmm/winemm.h > index d7bab0f..10cd0f4 100644 > --- a/dlls/winmm/winemm.h > +++ b/dlls/winmm/winemm.h > @@ -151,6 +151,7 @@ void TIME_MMTimeStop(void) DECLSPEC_HIDDEN; > > MMRESULT WINMM_CheckCallback(DWORD_PTR dwCallback, DWORD fdwOpen, BOOL mixer) DECLSPEC_HIDDEN; > > +void WINMM_SetupCallback(void) DECLSPEC_HIDDEN; > void WINMM_DeleteWaveform(void) DECLSPEC_HIDDEN; > > /* Global variables */ > diff --git a/dlls/winmm/winmm.c b/dlls/winmm/winmm.c > index 0f3cd5d..358f139 100644 > --- a/dlls/winmm/winmm.c > +++ b/dlls/winmm/winmm.c > @@ -139,7 +139,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID fImpLoad) > > if (!WINMM_CreateIData(hInstDLL)) > return FALSE; > - > + WINMM_SetupCallback(); > break; > case DLL_PROCESS_DETACH: > if(fImpLoad) > -- > 2.9.3 > > >

2 8

Re: [PATCH 1/2] server: Store async list in process object and use that to find async in cansel_async request.
by Alexandre Julliard 01 Dec '16

01 Dec '16

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -614,6 +615,7 @@ static void process_destroy( struct object *obj ) > > /* we can't have a thread remaining */ > assert( list_empty( &process->thread_list )); > + assert( list_empty( &process->asyncs )); I don't think that this is guaranteed, I believe that there can still be asyncs in the queues of shared files. We'd probably need to clear them explicitly at process exit. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] iphlpapi: Ensure GetIpAddrTable returns loopback addresses in the end
by Alexandre Julliard 01 Dec '16

01 Dec '16

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Manually tested by other people in GNU/Linux and OSX, in every case > loopback was returned first while in all testbot Windows machines and > my Windows machines the loopback comes after everything. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=40247 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/iphlpapi/iphlpapi_main.c | 27 +++++++++++++++++++++------ > dlls/iphlpapi/tests/iphlpapi.c | 4 ++++ > 2 files changed, 25 insertions(+), 6 deletions(-) This breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok sock.c:2489: Tests skipped: SOCK_RAW is not supported sock.c:6947: Test failed: got 11002 expected WSAHOST_NOT_FOUND sock.c:6948: Test failed: expected 11001, got 11002 sock.c:7197: Test failed: got 11002 expected WSAHOST_NOT_FOUND sock.c:7198: Test failed: expected 11001, got 11002 sock.c:8648: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled Makefile:208: recipe for target 'sock.ok' failed make: *** [sock.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winspool.drv: Clear last error when creating mutex
by Alexandre Julliard 01 Dec '16

01 Dec '16

"A. Wilcox" <AWilcox(a)Wilcox-Tech.com> writes: > A stale error may reside in thread-local storage that causes > WINSPOOL_LoadSystemPrinters to believe initialisation has already > occurred. CreateMutex always sets last error, so this can't make any difference. There must be something else going on. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winmm: Use a thread to send driver messages on Win9x
by Nikolay Sivov 01 Dec '16

01 Dec '16

On Thu, 1 Dec 2016 04:40:22 -0200 Bruno Jesus <00cpxxx(a)gmail.com> wrote: > More detailed explanation in the patch comments. Basically the games use a DLL that calls SuspendThread from inside the WinMM callback, this makes the program hang as we use the "main thread" to dispatch callbacks. > > Games tested in Win95 config: > Heroes of Might & Magic (well known affected) > Deadlock (well known affected) > Worms 2 (just to ensure things still work) > Age of Empires (just to ensure things still work) > Shivers (just to ensure things still work) > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=3930 > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/winmm/waveform.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 76 insertions(+), 2 deletions(-) > > diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c > index 7308519..24d7e30 100644 > --- a/dlls/winmm/waveform.c > +++ b/dlls/winmm/waveform.c > @@ -134,6 +134,14 @@ struct _WINMM_MMDevice { > WINMM_Device *devices[MAX_DEVICES]; > }; > > +static struct { > + BOOL is, checked; > + HANDLE thread, event_main, event_thread; > + WINMM_CBInfo *info; > + WORD msg; > + DWORD_PTR param1, param2; > +} win9x; > + > static WINMM_MMDevice *g_out_mmdevices; > static WINMM_MMDevice **g_out_map; > static UINT g_outmmdevices_count; > @@ -286,6 +294,13 @@ static WINMM_Device *WINMM_FindUnusedDevice(WINMM_Device **devices, > { > UINT i; > > + if (!win9x.checked) > + { > + win9x.checked = TRUE; > + if ((GetVersion() & 0xFF) < 5) > + win9x.is = TRUE; > + } > + This only needs to happen during dll initialization. I think cleaner way for a change you're proposing will be two separate vtable structures, one for win9x and another one for the rest. This way you can select appropriate vtable once on dll initialization, and keep this selection forever as a global pointer for example. > /* Note: NotifyClient should never be called while holding the device lock > * since the client may call wave* functions from within the callback. */ > static inline void WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, > DWORD_PTR param2) > { > - DriverCallback(info->callback, info->flags, (HDRVR)info->hwave, > - msg, info->user, param1, param2); > + if (win9x.is) > + { > > HeapFree(GetProcessHeap(), 0, device->orig_fmt); > + if (win9x.thread) > + { > + /* warn the thread so it can die gracefully */ > + win9x.info->hwave = 0; > + SetEvent(win9x.event_thread); > + > + CloseHandle(win9x.event_main); > + CloseHandle(win9x.event_thread); > + CloseHandle(win9x.thread); > + win9x.event_main = win9x.event_thread = win9x.thread = NULL; > + } > > return S_OK; > } This will also let you to get rid of conditional implementation like above.

1 0

Re: [PATCH] winmm: Use a thread to send driver messages on Win9x
by Dmitry Timoshkov 01 Dec '16

01 Dec '16

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > + if ((GetVersion() & 0xFF) < 5) > + win9x.is = TRUE; A more correct check for win9x would be if ((GetVersion() & 0x80000000) win9x.is = TRUE; -- Dmitry.

1 0

wine-1.8.6-rc1 Available
by Michael Stefaniuc 30 Nov '16

30 Nov '16

Hello guys, I have pushed wine-1.8.6-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ After introducing a regression into 1.8.5 I got a little bit risk averse so just 51 cherry-picks this time. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. But that might change as I'm travelling at the moment. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Fix a regression introduced in 1.8.5 (#41627) - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.6 (total 35): 27671 ComboFix fails to install 29661 wineboot unable to create win32 prefix if the directory already exists 29916 ElsterFormular cannot make use of default PDF viewer (e. g. Okular) 30368 AMD Radeon 6480g detected as ATI Radeon 3200 30673 Smart Cutter 1.9.4 crashes when the button OPEN is pressed 32694 NVIDIA GTX 690 not in the list of recognized cards. 33636 wine cmd: invalid behaviour of '&' operator 35025 Max Payne 2 Demo: checkboxes in options dialog have missing window styles 35658 Anthem Room Correction 2 v1.0.1 reports 'Unknown COM error 0x80004001' (needs IAudioEndpointVolume::GetVolumeRange method implementation) 36101 Wow Hangs at login screen when coming from battle.net launcher (only with gxapi Opengl) 39447 Unimplemented function hid.dll.HidP_TranslateUsagesToI8042ScanCodes 39734 ProtectDisc Driver 11: acedrv11.sys crashes 40448 Final Fantasy XI: Missing character models, potential black screen and crashes 40540 ReadIntervalTimeout is ignored if there is data in the buffer when ReadFile is called and no data arrives after that 40746 Microsoft Expression Web 4 crashes when opening site, needs rpcrt4.dll.NdrAsyncServerCall 40861 Kingsoft Office 2012 needs ntoskrnl.exe.IoAttachDevice 40999 Epic Games Launcher needs ws2_32.InetNtopW 41021 Zombie Army trilogy needs msvcr100.dll._fpieee_flt 41050 Age of Mythology: Extended Edition needs api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vswscanf 41090 Multiple games (Starcraft 2, UE4 games) require vcruntime140.dll.__intrinsic_setjmp 41142 gcc6: server build warnings 41224 WineD3D8 crashes on Windows with GTAVC and i915-class video 41284 dbghelp_dwarf: parse_cie_details unknown CIE version 4 (clang/mesa/valgrind) 41308 iconfig.exe needs msvcr120.??0_Condition_variable@details@Concurrency@@QAE@XZ 41343 Ellisys Visual USB needs unimplemented function newdev.dll.DiInstallDriverA 41389 ComboFix fails to install: complains about missing HKLM\System\CurrentControlSet\Control\hivelist 41405 Hornbill Supportworks Client 7.6.0: crashes with ExtFloodFill when open 'Incident Details' pane 41428 The Forest: Terminal gets spammed with errors if Steam is running 41570 Xenia emulator needs unimplemented function api-ms-win-core-rtlsupport-l1-1.RtlLookupFunctionEntry called in 64-bit code 41602 Videos do not play in Age of Empires 41627 MS Word 2010 crash when exiting on Wine stable 1.8.5. 41640 add rx 480 into directx.c 41642 S3CC921 programmer app needs ntoskrnl.exe.KeSetTimerEx 41651 WScript object name on wine is case sensitive which should not be the case (vbscript) 41705 Build fails in dpnet: redefinition of typedef 'SOCKADDR' ---------------------------------------------------------------- Changes since 1.8.5: Alex Henrie (1): ntdll: Skip synchronous read if a serial read interval timeout is set. Alexandre Julliard (2): server: Avoid some compiler warnings when EWOULDBLOCK == EAGAIN. ntdll: Add a helper function for registering a file read async I/O. Alistair Leslie-Hughes (2): comdlg32/tests: Test when a directory is passed to OpenFileName Dialog. dpnet: Header files cleanup. Andrew Eikum (1): mmdevapi: Implement IAudioEndpointVolume::GetVolumeRange. Andrew Kanaber (1): wined3d: Add id for Broadwell Xeon E3 GPU. Andrey Gusev (1): user32: Add support for WS_EX_RIGHT style. André Hentschel (1): loader/wine.inf: Open pdf files using winebrowser. Aric Stewart (1): hid: Stub HidP_TranslateUsagesToI8042ScanCodes. Austin English (5): wine.inf: Add HKLM\System\CurrentControlSet\Control\hivelist key. newdev: Add DiInstallDriverA/W stubs. api-ms-win-core-rtlsupport-l1-1-0: Add missing forwards. ntoskrnl.exe: Add IoAttachDevice stub. ntoskrnl.exe: Add KeSetTimerEx stub. Bernhard Übelacker (1): ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. Bruno Jesus (3): xinput1_3: Prefer builtin DLL. comdlg32: Avoid crash when a path is passed into Open File Dialog. msvfw32/tests: Add tests for ICInfo(). Carlos Rafael Ramirez (1): cmd: When 'if' condition is not met, ignore the next commands in the list. Daniel Lehman (2): ucrtbase: Add __stdio_common_vfwprintf. ucrtbase: Add __stdio_common_vfwscanf. Filip Frąckiewicz (5): wined3d: Add NVIDIA GTX 690 (GK104) to the GPU list. wined3d: Add AMD Radeon HD 6480G IGP. wined3d: Add NVIDIA GTX 980 Ti. wined3d: Add NVIDIA GTX 675MX to the GPU list. wined3d: Add NVIDIA GTX 760 Ti to the GPU list. Grazvydas Ignotas (1): wined3d: Add Polaris GPUs and their driver. Huw D. M. Davies (3): ucrtbase: Add __stdio_common_vswscanf(). gdi32: Check that ExtFloodFill()'s initial co-ordinates lie within the dib. fonts: Fix typo in glyph name. Jacek Caban (4): msctf: Don't call ITextStoreACP::UnadviseSink in context destructor. msctf: Added Push/Pop context tests. vbscript: Call GetItemInfo() with original item name. secur32: Use %LATEST_RECORD_VERSION gnutls priority. Józef Kucia (1): wined3d: Improve advertized driver version for Windows 10. Matteo Bruni (2): wined3d: Recognize a couple of Haswell / Broadwell GPUs on macOS. wined3d: Add a bunch of Broadwell and Skylake PCI ids and descriptions. Michael Müller (2): ntdll: Open current working directory with FILE_TRAVERSE access. msvfw32: Use case insensitive compare in ICInfo for fourcc codes. Nikolay Sivov (3): dbghelp: Support CIE version 4 in parse_cie_details(). rpcrt4: Added NdrAsyncServerCall stub. ucrtbase: Fix some spec file entries. Philipp Hoppermann (1): ws2_32: Implement InetNtopW. Piotr Caban (5): ucrtbase: Add __intrinsic_setjmp implementation. msvcrt: Add _fpieee_flt stub. msvcrt: Support fdiv m64fp in i386 _fpieee_flt. msvcr110: Add Concurrency::details::_Condition_variable class stub. msvcr120: Add _Condition_variable implementation. Ruslan Kabatsayev (1): wined3d: Initialise p_wglGetPixelFormat when USE_WIN32_OPENGL is defined. Sebastian Lackner (1): server: Allow to create win32 prefix when directory already exists. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Re: [PATCH 8/9] d3d10core/tests: Add test for two sided stencil.
by Henri Verbeet 30 Nov '16

30 Nov '16

On 30 November 2016 at 12:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + ds_desc.FrontFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilFunc = D3D10_COMPARISON_NEVER; > + ds_desc.BackFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilFunc = D3D10_COMPARISON_ALWAYS; It's fine for a start, but note that this test doesn't do much for front/back stencil ops. Also, fwiw, in d3d9:visual there's stencil_cull_test() that's similar.

1 0

Re: [PATCH 03/10] server: Use async object to transfer IRP result to client.
by Alexandre Julliard 30 Nov '16

30 Nov '16

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/server/file.h b/server/file.h > index c0a53a2..75a2e03 100644 > --- a/server/file.h > +++ b/server/file.h > @@ -53,6 +53,8 @@ struct fd_ops > void (*reselect_async)( struct fd *, struct async_queue *queue ); > /* cancel an async operation */ > int (*cancel_async)(struct fd *, struct process *process, struct thread *thread, client_ptr_t iosb); > + /* find an async operation in queues */ > + struct async *(*find_async)( struct fd *fd, struct process *process, client_ptr_t client_async ); > }; I think a per-process list of async/iosb would make more sense. There should be nothing file type specific about finding an async. It could probably be used to get rid of cancel_async() too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Github mirror seems to be out-of-sync
by Akihiro Sagawa 30 Nov '16

30 Nov '16

Source code admin, Official Github mirror, https://github.com/wine-mirror/wine, seems to be not updated for a few days. Could you take a look? Thanks in advance. Akihiro Sagawa

2 2

Re: [resend] fusion: Avoid buffer overflow in enum_gac_assemblies.
by Alexandre Julliard 29 Nov '16

29 Nov '16

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ Marvin indicated testing went fine, and I did not see any feedback > for two weeks. Only the description below has changed a little. ] > > In enum_gac_assemblies we have the following > > sprintf(buf, ", Version=%s, Culture=%s, PublicKeyToken=%s", > ffd.cFileName, culture, ptr); > > culture is declared as char[MAX_PATH], and WIN32_FIND_DATAA.cFileName > is CHAR[260], so a mere size of MAX_PATH for the output buffer buf is > not sufficient. > > (We need to double sizeof(ffd.cFileName) since ptr also points > into it.) They all point into the same path, so the total size is not going to exceed MAX_PATH (modulo the additionally printed chars). And it doesn't make sense to fix this buffer but not the other ones, you are just moving the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Serial port sniffing problem
by Christopher Harrington 29 Nov '16

29 Nov '16

(copying list again, below edited for brevity) On Tue, Nov 29, 2016 at 12:39 PM Bill Lionheart <billlionheart(a)gmail.com> wrote: > $ ls -Fl > lrwxrwxrwx 1 bill bill 10 May 11 2014 c: -> ../drive_c/ > lrwxrwxrwx 1 bill bill 12 Jan 6 2016 com1 -> /dev/ttyUSB0 > > $ id -a > uid=1001(bill) gid=1001(bill) > groups=1001(bill),20(dialout) > $ ls -l /dev/ttyUSB0 > crw-rw---- 1 root dialout 188, 0 Nov 29 18:27 /dev/ttyUSB0 > > > All of this definitely looks correct. Here are a couple more suggestions: 1. Try creating a brand new wine prefix. Yours certainly has a beard on it and there may be artifacts of older copies of Wine that could be impacting your testing. Anyway, this essentially would look like moving ~/.wine to somewhere else, installing your test application again, and re-creating your com1 file in dosdevices/. You can always move your .wine directory back if it has important stuff in it. 2. See if using a more current version of Wine improves anything. You say you're on Wine 1.8; if you could be more specific (try running wine --version) that might give someone a lightbulb. 3. Crossover from Codeweavers is appallingly affordable if you haven't looked into that yet, and it comes with professional support. Anyway, wine-devel is more for discussion of development of Wine itself, not a support forum. What you're probably looking for is wine-users. I'm not subscribed to wine-users, so I can't copy your email there, but you can subscribe here: https://www.winehq.org/mailman/listinfo/wine-users Good luck. > > On 29 November 2016 at 17:57, Christopher Harrington > <ironiridis+winehq(a)gmail.com> wrote: > > On Tue, Nov 29, 2016 at 1:22 AM Bill Lionheart <billlionheart(a)gmail.com> > > wrote: > >> > >> Using Wine version 1.8 on Ubuntu 14.04.5 > >> I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a > >> serial interface. The device is supplied with a Prolific USB serial > >> converter which comes up as /dev/ttyUSB0 which > >> I have sym linked to COM1 > > > > > > Can you please cd into your dosdevices folder and run this command? > > > > ls -Fl > > > > (that's an uppercase F and a lowercase L) > > > > Then we will also need to see permissions of the serial device, so run > this: > > > > ls -l /dev/ttyUSB0 > > > > That's a lowercase L again... and run this too: > > > > id -a > > > > With all this info we can rule out a couple problems, chief among them: > > 1. Is the symlink named correctly and actually pointing to something that > > exists > > 2. Do you actually have permissions to access the serial port > > > > If you provide the output of all three of these commands, we should be > able > > to help. > > > > -Chris > > > >> > >> > > > > > > -- > Professor of Applied Mathematics > University of Manchester > http://www.maths.manchester.ac.uk/bl >

1 0

Re: [PATCH v2] ws2_32/tests: Add IDN resolution tests for GetAddrInfoW
by Marvin 29 Nov '16

29 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26981 Your paranoid android. === w7u (32 bit sock) === sock.c:8270: Test failed: Overlapped TransmitFile failed. sock.c:8272: Test failed: Overlapped TransmitFile sent an unexpected number of bytes (219 != 209).

1 0

Re: [PATCH 9/9] d3d11/tests: Add test for typed UAV loads.
by Henri Verbeet 29 Nov '16

29 Nov '16

On 29 November 2016 at 12:06, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 326 insertions(+) > This fails for me on Windows: d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 5: Got 0x00000010, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 3).

2 1

Re: [PATCH 4/5] d3d11/tests: Add test for shader input register limits.
by Henri Verbeet 29 Nov '16

29 Nov '16

On 25 November 2016 at 12:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The "ps_many_resources_code" shader bytecode is very big because texture > resources cannot be indexed and the loop is unrolled. > > --- > dlls/d3d11/tests/d3d11.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 221 insertions(+) > This doesn't work here. In particular: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #5: fixme:d3d_shader:print_glsl_info_log error: Too many fragment shader texture samplers ... fixme:d3d:context_bind_shader_resources Shader 0x18bb10 needs 21 samplers, but only 16 are supported.

2 3

Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW
by Alexandre Julliard 29 Nov '16

29 Nov '16

Bruno Jesus <00cpxxx(a)gmail.com> writes: > I'm using €.linux.it because I could not find any standard domain name > for validation. Maybe winehq.org could have a IDN sub-domain name to > test. I created テスト.winehq.org for this purpose. > Also instead of broken'ing every test to catch Windows <= 7 I'm > skipping before, so real failures are not lost due to broken covering > them in Win >= 8. I still think it's better to avoid version checks. You can do broken() on the first test and skip the others if you detect the Win 7 behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Add some uuids present on Windows 10.
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 16:43, Huw Davies wrote: > +DEFINE_GUID(IID_UnknownInterface22, 0x42f85136, 0xdb7e, 0x439c, 0x85,0xf1, 0xe4,0x07,0x5d,0x13,0x5f,0xc8); This one is IID_IFileDialog.

2 1

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > Since put_ProcessImageFileName appears to validate the image name that is > supplied, the normal put/get/compare was excluded because it returned > E_INVALIDARG even for a fully qualified filename. An investigation for another > day. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/tests/Makefile.in | 2 +- > dlls/hnetcfg/tests/policy.c | 32 +++++++++++++++++++++++++++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/tests/Makefile.in b/dlls/hnetcfg/tests/Makefile.in > index aa4062a..5e1ce91 100644 > --- a/dlls/hnetcfg/tests/Makefile.in > +++ b/dlls/hnetcfg/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = hnetcfg.dll > -IMPORTS = ole32 uuid > +IMPORTS = ole32 uuid oleaut32 > > C_SRCS = \ > policy.c > diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c > index a3ed4b2..a05b02e 100644 > --- a/dlls/hnetcfg/tests/policy.c > +++ b/dlls/hnetcfg/tests/policy.c > @@ -65,6 +65,36 @@ static void test_interfaces(void) > INetFwMgr_Release(manager); > } > > +static void test_NetFwAuthorizedApplication(void) > +{ > + INetFwAuthorizedApplication *app; > + HRESULT hr; > + > + hr = CoCreateInstance(&CLSID_NetFwAuthorizedApplication, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > + &IID_INetFwAuthorizedApplication, (void**)&app); > + ok(hr == S_OK, "got: %08x\n", hr); > + if(hr == S_OK) > + { It's not really necessary to protect it like that. If creation consistently fails test or all tests should be skipped. > + static WCHAR empty[] = {0}; > + BSTR bstr; > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, NULL); > + ok(hr == E_POINTER, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, &bstr); > + ok(hr == S_OK, "got: %08x\n", hr); > + ok(!bstr, "got: %s\n", wine_dbgstr_w(bstr)); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, NULL); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, empty); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); Please use actual BSTR here. > + > + INetFwAuthorizedApplication_Release(app); > + } > +} > + > START_TEST(policy) > { > INetFwMgr *manager; > @@ -84,7 +114,7 @@ START_TEST(policy) > INetFwMgr_Release(manager); > > test_interfaces(); > - > + test_NetFwAuthorizedApplication(); > > CoUninitialize(); > } >

1 0

Re: [v2 PATCH 1/2] hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Nikolay Sivov 29 Nov '16

29 Nov '16

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > From: Michael Müller <michael(a)fds-team.de> > > v2: > Corrected error return values. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/apps.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/apps.c b/dlls/hnetcfg/apps.c > index 2b8d78c..a89e6a7 100644 > --- a/dlls/hnetcfg/apps.c > +++ b/dlls/hnetcfg/apps.c > @@ -38,6 +38,7 @@ typedef struct fw_app > { > INetFwAuthorizedApplication INetFwAuthorizedApplication_iface; > LONG refs; > + BSTR filename; > } fw_app; > > static inline fw_app *impl_from_INetFwAuthorizedApplication( INetFwAuthorizedApplication *iface ) > @@ -60,6 +61,7 @@ static ULONG WINAPI fw_app_Release( > if (!refs) > { > TRACE("destroying %p\n", fw_app); > + if (fw_app->filename) SysFreeString( fw_app->filename ); There's no need for this check. > HeapFree( GetProcessHeap(), 0, fw_app ); > } > return refs; > @@ -252,7 +254,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_POINTER; > + > + if (!This->filename) > + { > + *imageFileName = NULL; > + return S_OK; > + } > + > + *imageFileName = SysAllocString( This->filename ); > + return *imageFileName ? S_OK : E_OUTOFMEMORY; > } You can reduce this to --- *imageFileName = SysAllocString( This->filename ); return *imageFileName || !This->filename ? S_OK : E_OUTOFMEMORY; --- > > static HRESULT WINAPI fw_app_put_ProcessImageFileName( > @@ -262,7 +275,12 @@ static HRESULT WINAPI fw_app_put_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %s\n", This, debugstr_w(imageFileName)); > - return S_OK; > + > + if (!imageFileName || !imageFileName[0]) > + return E_INVALIDARG; > + > + This->filename = SysAllocString( imageFileName ); > + return This->filename ? S_OK : E_OUTOFMEMORY; > } What happens if you call put_ProcessImageFileName() repeatedly?

1 0

Re: hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Alistair Leslie-Hughes 29 Nov '16

29 Nov '16

On 24/11/16 07:22, Bruno Jesus wrote: > From: Michael Müller <michael(a)fds-team.de> > > Manually tested using vbscript. > > @@ -250,7 +252,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_INVALIDARG; The return value here is incorrect. I've sent an updated patch+tests to wine-patches Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Marvin 29 Nov '16

29 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26959 Your paranoid android. === wxppro (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === w2003std (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === wvistau64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w2008s64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7u (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7pro64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w8 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w864 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w1064 (32 bit policy) === policy.c:92: Test failed: got: 80070003

1 0

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()
by Dmitry Timoshkov 28 Nov '16

28 Nov '16

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Does this even fix a real application? What exactly this patch is supposed to fix? -- Dmitry.

1 0

Re: [v3] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26946 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Undocumented function prototype
by Marco Savelli 28 Nov '16

28 Nov '16

Hi everybody! I'm new to this list. I found this page (in deutsch) which seems to document an otherwise undocumented function, namely GetPermLayers from aphelp.dll. I don't know where they got it, but seems a realistic definition. Hope it helps. And thanks for your development effort, go on this way! :D P.S. It' in delphi, there's a "var" keyword, which should means (from google, I'm not a delphist) an optional argument. IDA PRO gives error when given the last two args. Hope you can figure out where's the problem

3 4

Re: [PATCH 3/3] wintrust/tests: Remove a test that crashes on Windows 8 amd 10.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26944 Your paranoid android. === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001

1 0

Re: [PATCH 2/3] wintrust/tests: Initialize the pSigState member to prevent Windows 8 and 10 from crashing.
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26943 Your paranoid android. === w8 (32 bit softpub) === softpub: unhandled exception c0000005 at 7511A63B === w864 (32 bit softpub) === softpub: unhandled exception c0000005 at 7772A63B === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 768B0B90 === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF9B8F === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FFC77A7F593

1 0

Re: [2/5] strmbase: Add validation checks when updating source rectangle.
by Andrew Eikum 28 Nov '16

28 Nov '16

On Sun, Nov 20, 2016 at 03:33:22PM +0900, Akihiro Sagawa wrote: > @@ -53,6 +53,26 @@ HRESULT WINAPI BaseControlVideo_Destroy(BaseControlVideo *pControlVideo) > return BaseDispatch_Destroy(&pControlVideo->baseDispatch); > } > > +static HRESULT BaseControlVideoImpl_CheckSourceRect(BaseControlVideo *This, RECT *pSourceRect) > +{ > + LONG VideoWidth, VideoHeight; > + HRESULT hr; > + > + if (pSourceRect->top < 0 || pSourceRect->left < 0 || > + pSourceRect->top >= pSourceRect->bottom || > + pSourceRect->left >= pSourceRect->right) > + return E_INVALIDARG; I'm not opposed to spelling it out, but you could use IsRectEmpty() here instead. > + > + hr = BaseControlVideoImpl_GetVideoSize((IBasicVideo *)This, &VideoWidth, &VideoHeight); > + if (FAILED(hr)) > + return hr; > + > + if (pSourceRect->bottom > VideoHeight || pSourceRect->right > VideoWidth) > + return E_INVALIDARG; > + Shouldn't these use (bottom - top) and (right - left)? Andrew

2 2

Do we delete spammers accounts from bugzilla?
by Bruno Jesus 28 Nov '16

28 Nov '16

Today we had one more piece of spam, the bot registered the account a few moments before creating a bug. In this case should we use bugzilla's admin features to delete the user? Best wishes, Bruno

3 3

Re: [v2] cmd/tests: chaining rules of pipe and else
by Marvin 28 Nov '16

28 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26937 Your paranoid android. === wxppro (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w2003std (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7u (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7pro64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w8 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w864 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w1064 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w7pro64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w864 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]') === w1064 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken@h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken@i4:[i3:[i2:,i3],i4]@or_broken@i4:[i3:,i4]')

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Lauri Kenttä 26 Nov '16

26 Nov '16

Testbot reports a failure on Vista, but that is not related to my patch. -- Lauri Kenttä

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Marvin 26 Nov '16

26 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26929 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2 2/5] d3d9/tests: Add test for occlusion query with result bigger than UINT32_MAX.
by Marvin 25 Nov '16

25 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26917 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: ntdll/tests: The fpu exception offset is broken on 32-bit Windows 8 too.
by Marvin 25 Nov '16

25 Nov '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26914 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x2e0000/0x2e0001 exception: unhandled exception 80000004 at 002E0000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x2e0001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x300000/0x300001 exception: unhandled exception 80000004 at 00300000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x300001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH] winspool: Use all Fields from DRIVER_INFO_8A when we add a Printer Driver.
by Huw Davies 25 Nov '16

25 Nov '16

On Fri, Nov 25, 2016 at 12:49:40AM +0100, Detlef Riekenberg wrote: > + if ((Level > 7) && diA->pszzColorProfiles) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, NULL, 0); > + diW.pszzColorProfiles = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, diW.pszzColorProfiles, len); > + } This is a 'multi-sz' string, so you need the same handling as 'pDependentFiles' here. > + if ((Level > 7) && diA->pszInfPath) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, NULL, 0); > + diW.pszInfPath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, diW.pszInfPath, len); > + } > + > + if ((Level > 7) && diA->pszzCoreDriverDependencies) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, NULL, 0); > + diW.pszzCoreDriverDependencies = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, diW.pszzCoreDriverDependencies, len); > + } The same goes for pszzCoreDriverDependencies. > if (Level > 7) { > - FIXME("level %u is incomplete\n", Level); > + diW.dwPrinterDriverAttributes = diA->dwPrinterDriverAttributes; > + diW.ftMinInboxDriverVerDate = diA->ftMinInboxDriverVerDate; > + diW.dwlMinInboxDriverVerVersion = diA->dwlMinInboxDriverVerVersion; > } > > res = AddPrinterDriverExW(nameW, Level, (LPBYTE) &diW, dwFileCopyFlags); > @@ -7018,6 +7061,11 @@ BOOL WINAPI AddPrinterDriverExA(LPSTR pName, DWORD Level, LPBYTE pDriverInfo, DW You're leaking pHelpFile. > HeapFree(GetProcessHeap(), 0, diW.pszOEMUrl); > HeapFree(GetProcessHeap(), 0, diW.pszHardwareID); > HeapFree(GetProcessHeap(), 0, diW.pszProvider); > + HeapFree(GetProcessHeap(), 0, diW.pszPrintProcessor); > + HeapFree(GetProcessHeap(), 0, diW.pszVendorSetup); > + HeapFree(GetProcessHeap(), 0, diW.pszzColorProfiles); > + HeapFree(GetProcessHeap(), 0, diW.pszInfPath); > + HeapFree(GetProcessHeap(), 0, diW.pszzCoreDriverDependencies); > > TRACE("=> %u with %u\n", res, GetLastError()); > return res;

1 0

Re: 2 of 13 [PATCH] po: Update Simplified Chinese translation (v3).
by Jactry Zeng 24 Nov '16

24 Nov '16

This looks good to me. Thanks for your contribution! 2016-11-23 0:09 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 1202 ++++++++++++++++++++++++++++++ > ++++------------------------- > 1 file changed, 687 insertions(+), 515 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 1/2] shlwapi: Remove dot segments for URLs starting with /
by Jacek Caban 24 Nov '16

24 Nov '16

Hi Daniel, On 24.11.2016 00:44, Daniel Lehman wrote: > diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c > index 879a734..5de9076 100644 > --- a/dlls/shlwapi/url.c > +++ b/dlls/shlwapi/url.c > @@ -372,6 +372,9 @@ HRESULT WINAPI UrlCanonicalizeW(LPCWSTR pszUrl, LPWSTR pszCanonicalized, > dwFlags |= URL_ESCAPE_UNSAFE; > state = 5; > is_file_url = TRUE; > + } else if(url[0] == '/') { > + state = 2; Wouldn't state 5 be more appropriate? > + is_file_url = TRUE; It would be interesting to have tests using URL_WININET_COMPATIBILITY and URL_FILE_USE_PATHURL flags. is_file_url usually affects slashes conversion in such cases, but you set it too late to take such effect. It may be right, but tests would be nice. Thanks, Jacek

1 0

Re: [PATCH 04/11] wined3d: Introduce wined3d_device_set_unordered_access_view().
by Henri Verbeet 24 Nov '16

24 Nov '16

On 23 November 2016 at 14:36, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + FIXME("Unordered access view unsupported yet (layers %u-%u).\n", > + desc->u.texture.layer_idx, desc->u.texture.layer_count); I don't think you can do that in English. You'd either have "UAV unsupported" or "UAV not supported yet". In the specific case here, I'd probably use something like "Unsupported layer selection %u+%u.\n" or something along those lines though.

1 0

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles
by Henri Verbeet 24 Nov '16

24 Nov '16

On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) > +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) > { > - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); > + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); > + > + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); > + > + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); > + if (dash_count > style->dash_count) > + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); That doesn't look right.

2 2

Re: [PATCH v2] msvcrt: Add _lfind_s
by Piotr Caban 24 Nov '16

24 Nov '16

Hi Daniel, it fails to compile: ../../tools/winegcc/winegcc -o api-ms-win-crt-utility-l1-1-0.dll.so -B../../tools/winebuild -m32 -fasynchronous-unwind-tables -shared ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec \ ../../libs/port/libwine_port.a ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec:6: function '_lfind_s' not defined winegcc: ../../tools/winebuild/winebuild failed Makefile:166: recipe for target 'api-ms-win-crt-utility-l1-1-0.dll.so' failed make[1]: *** [api-ms-win-crt-utility-l1-1-0.dll.so] Error 2 Thank you, Piotr

1 0

Wineconf wrap up
by Jeremy White 24 Nov '16

24 Nov '16

Hi Folks, I thought I would take a minute to write a summary of the events of the weekend, and that start a thread where others could chime in. It was a great event; a traditional wineconf with cheer and conversations, and even sometimes productive meetings. Here were our working notes for the weekend: https://www.winehq.org/~jwhite/wineconf_2016.pdf The plan for next year is to have the Wine conference in Poland next fall. We are going to try to broaden our reach; inviting users and others to come to the conference as well. Aric is going to try to help coordinate that structural growth. Mechanically, we did decide that the Google hangout was not intrusive, so we will likely try to repeat that next year. (We would like it to not require us to manually accept each person, if possible). Many others volunteered to help in a variety of ways; I did not take rigorous notes of this during the conference, so hopefully others will step forward with that information (or we'll all shame them into remembering <evil grin>). It was a joy to see you all! Cheers, Jeremy p.s. For my part, one key part is that we are going to attempt to make one or two of the Debian Jessie systems hosted here at CodeWeavers run make test to successful completion. We are going to accept the fact that we have several timing dependent tests; so 'success' is going to be something like the following: make test -o make test -o make test -o make test In a similar vein, we are going to try to establish a 'diffing' logic for the winetest bot. So if there are n failures that happen routinely, and a new patch arrives, so long as only those same failures remain, the patch will be considered suitable. The advantage to that approach is that we can also apply it to platforms such as the Mac, where we are no where close to running green. Michael will help Francois with this once he is done with his travels. I agreed to lock Francois and the d3d guys in the server room until we saw progress on the make test front; I think that was the sum total of what I volunteered to do.

4 5

Re: Donat Enikeev : crypt32/tests: Fix chain tests failure with cs.standford.edu certificates.
by Huw Davies 24 Nov '16

24 Nov '16

> On 21 Nov 2016, at 21:28, Alexandre Julliard <julliard(a)winehq.org> wrote: > > Module: wine > Branch: master > Commit: 8a4508cecc4a6e46da200c85aa7d62515041f6e2 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4508cecc4a6e46da200c85a… > > Author: Donat Enikeev <donat(a)enikeev.net> > Date: Sat Nov 19 21:12:30 2016 +0300 > > crypt32/tests: Fix chain tests failure with cs.standford.edu certificates. > > Signed-off-by: Donat Enikeev <donat(a)enikeev.net> > Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> > > --- > > dlls/crypt32/tests/chain.c | 658 ++++++++++++++++++++++++--------------------- > 1 file changed, 352 insertions(+), 306 deletions(-) > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8a4508cecc4a6e46da200… Hi Donat, This has caused failures on some of Francois’ XP VMs. For example: http://test.winehq.org/data/8a4508cecc4a6e46da200c85aa7d62515041f6e2/xp_fg-… Could you take a look? Thanks, Huw.

6 12

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel