- wine-devel - winehq.org

Re: [PATCH 3/4] ntoskrnl.exe: Send PnP and Power IRPs to plug and play devices
by Sebastian Lackner 31 Aug '16

31 Aug '16

On 29.08.2016 20:49, Aric Stewart wrote: > The drivers AddDevice function will be well behaved and call > IoAttachDeviceToDeviceStack. The Plug and Play manager will look at > the bus device after AddDevice and if there is an AttachedDevice then > will proceed to call IRP_MN_START_DEVICE on the attached device. Then > a IRP_MJ_POWER/IRP_MN_SET_POWER to PowerDeviceD0. > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/pnp_manager.c | 64 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > > > 0003-ntoskrnl.exe-Send-PnP-and-Power-IRPs-to-plug-and-play-.txt > > > diff --git a/dlls/ntoskrnl.exe/pnp_manager.c b/dlls/ntoskrnl.exe/pnp_manager.c > index f1f3109..912f5fd 100644 > --- a/dlls/ntoskrnl.exe/pnp_manager.c > +++ b/dlls/ntoskrnl.exe/pnp_manager.c > @@ -148,6 +148,60 @@ static NTSTATUS get_device_id(DEVICE_OBJECT *device, BUS_QUERY_ID_TYPE type, WCH > return status; > } > > +static NTSTATUS send_deviceIRP(DEVICE_OBJECT* device, IRP *irp) > +{ > + NTSTATUS status; > + IO_STACK_LOCATION *irpsp; > + HANDLE event = CreateEventA(NULL, FALSE, FALSE, NULL); > + > + irp->UserEvent = event; > + irpsp = IoGetNextIrpStackLocation(irp); > + irpsp->CompletionRoutine = internalComplete; > + irpsp->Control = SL_INVOKE_ON_SUCCESS | SL_INVOKE_ON_ERROR; > + > + IoCallDriver(device, irp); > + > + if (irp->IoStatus.u.Status == STATUS_PENDING) > + WaitForSingleObject(event, INFINITE); > + > + status = irp->IoStatus.u.Status; > + IoCompleteRequest(irp, IO_NO_INCREMENT ); > + CloseHandle(event); > + return status; > +} Such a helper function could also be used to simplify get_device_id. > + > +static NTSTATUS send_pnpIRP(DEVICE_OBJECT *device, UCHAR minor) > +{ > + IO_STACK_LOCATION *irpsp; > + IO_STATUS_BLOCK irp_status; > + > + IRP *irp = IoBuildSynchronousFsdRequest(IRP_MJ_PNP, device, NULL, 0, NULL, NULL, &irp_status); It would be better to handle failure of IoBuildSynchronousFsdRequest like in get_device_id. The same also applies to send_powerIRP() below. > + > + irpsp = IoGetNextIrpStackLocation(irp); > + irpsp->MinorFunction = minor; > + > + irpsp->Parameters.StartDevice.AllocatedResources = NULL; > + irpsp->Parameters.StartDevice.AllocatedResourcesTranslated = NULL; > + > + return send_deviceIRP(device, irp); > +} > + > +static NTSTATUS send_powerIRP(DEVICE_OBJECT *device, DEVICE_POWER_STATE power) Please check if its possible to (partially) move this to PoRequestPowerIrp(). If there is not enough information we can keep it like that for now, but according to the description it sounds very similar. > +{ > + IO_STATUS_BLOCK irp_status; > + IO_STACK_LOCATION *irpsp; > + > + IRP *irp = IoBuildSynchronousFsdRequest(IRP_MJ_POWER, device, NULL, 0, NULL, NULL, &irp_status); > + > + irpsp = IoGetNextIrpStackLocation(irp); > + irpsp->MinorFunction = IRP_MN_SET_POWER; > + > + irpsp->Parameters.Power.Type = DevicePowerState; > + irpsp->Parameters.Power.State.DeviceState = power; > + > + return send_deviceIRP(device, irp); > +} > + > static void handle_bus_relations(DEVICE_OBJECT *device) > { > static const WCHAR szDriverW[] = {'\\','D','r','i','v','e','r','\\',0}; > @@ -244,6 +298,16 @@ static void handle_bus_relations(DEVICE_OBJECT *device) > ERR("AddDevice failed\n"); > return; > } > + > + if (device->AttachedDevice) > + { > + send_pnpIRP(device->AttachedDevice, IRP_MN_START_DEVICE); > + send_powerIRP(device->AttachedDevice, PowerDeviceD0); > + } > + else > + { > + ERR("No attached device\n"); > + } > } > > static void initialize_driver_store(void) > > >

1 0

Re: [PATCH 2/4] ntoskrnl.exe: Implement loading plug and play devices
by Sebastian Lackner 31 Aug '16

31 Aug '16

On 29.08.2016 20:49, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/pnp_manager.c | 150 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 150 insertions(+) > > > > 0002-ntoskrnl.exe-Implement-loading-plug-and-play-devices.txt > > > diff --git a/dlls/ntoskrnl.exe/pnp_manager.c b/dlls/ntoskrnl.exe/pnp_manager.c > index 5b42a0a..f1f3109 100644 > --- a/dlls/ntoskrnl.exe/pnp_manager.c > +++ b/dlls/ntoskrnl.exe/pnp_manager.c > @@ -17,6 +17,7 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#define NONAMELESSUNION > #include <stdarg.h> > #include "ntstatus.h" > #define WIN32_NO_STATUS > @@ -27,6 +28,7 @@ > #include "cfgmgr32.h" > #include "winsvc.h" > #include "winreg.h" > +#include "wine/unicode.h" > #include "wine/debug.h" > #include "wine/list.h" > > @@ -34,6 +36,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(plugplay); > > #define MAX_SERVICE_NAME 260 > > +typedef NTSTATUS WINAPI (*pAddDevice)(DRIVER_OBJECT *DriverObject, DEVICE_OBJECT *PhysicalDeviceObject); My Win10 header files contain DRIVER_EXTENSION with the appropriate definition, which would make the casts unnecessary. > + > typedef struct _device_driver { > struct list entry; > > @@ -105,6 +109,143 @@ static device_driver* register_device_driver(const WCHAR *drivername, const WCHA > return ptr; > } > > +static NTSTATUS WINAPI internalComplete(DEVICE_OBJECT *deviceObject, IRP *irp, > + void *context ) > +{ > + SetEvent(irp->UserEvent); > + return STATUS_MORE_PROCESSING_REQUIRED; > +} > + > +static NTSTATUS get_device_id(DEVICE_OBJECT *device, BUS_QUERY_ID_TYPE type, WCHAR **id) > +{ > + NTSTATUS status; > + IO_STACK_LOCATION *irpsp; > + IO_STATUS_BLOCK irp_status; > + IRP *irp; > + HANDLE event = CreateEventA(NULL, FALSE, FALSE, NULL); > + > + irp = IoBuildSynchronousFsdRequest(IRP_MJ_PNP, device, NULL, 0, NULL, NULL, &irp_status); > + if (irp == NULL) > + return STATUS_NO_MEMORY; The return path here will leak the event handle. The same issue was recently fixed in hidclass.sys. Also I'm wondering a bit, do we need to keep this identical code at both places? > + > + irp->UserEvent = event; > + irpsp = IoGetNextIrpStackLocation(irp); > + irpsp->MinorFunction = IRP_MN_QUERY_ID; > + irpsp->Parameters.QueryId.IdType = type; > + irpsp->CompletionRoutine = internalComplete; > + irpsp->Control = SL_INVOKE_ON_SUCCESS | SL_INVOKE_ON_ERROR; > + > + IoCallDriver(device, irp); > + > + if (irp->IoStatus.u.Status == STATUS_PENDING) > + WaitForSingleObject(event, INFINITE); > + > + *id = (WCHAR*)irp->IoStatus.Information; > + status = irp->IoStatus.u.Status; > + IoCompleteRequest(irp, IO_NO_INCREMENT ); > + CloseHandle(event); > + > + return status; > +} > + > +static void handle_bus_relations(DEVICE_OBJECT *device) > +{ > + static const WCHAR szDriverW[] = {'\\','D','r','i','v','e','r','\\',0}; > + > + NTSTATUS status; > + WCHAR *id, *idptr; > + device_driver *driver = NULL; > + WCHAR fullname[MAX_PATH]; > + DRIVER_OBJECT *driver_obj; > + UNICODE_STRING driverName; > + > + TRACE("Device %p\n", device); > + > + /* We could(should?) do a full IRP_MN_QUERY_DEVICE_RELATIONS query, > + * but we dont have to, We have the DEVICE_OBJECT of the new device > + * so we can simply handle the process here */ > + > + status = get_device_id(device, BusQueryCompatibleIDs, &id); > + if (status != ERROR_SUCCESS || !id) > + { > + ERR("Failed to get device IDs\n"); > + return; > + } > + > + idptr = id; > + do { > + device_driver *ptr; > + > + TRACE("Checking for id %s\n",debugstr_w(idptr)); > + > + /* Check loaded drivers */ > + LIST_FOR_EACH_ENTRY(ptr, &device_drivers, device_driver, entry) > + { > + int i; > + for (i = 0; i < ptr->id_count; i++) > + { > + if (lstrcmpW(idptr, ptr->matching_ids[i]) == 0) > + { > + driver = ptr; > + break; Is it intentional that this does not abort the outer loop? > + } > + } > + } > + idptr += (lstrlenW(idptr) + 1); > + } while (!driver && *idptr != 0); > + > + HeapFree(GetProcessHeap(), 0, id); > + > + if (!driver) > + { > + ERR("No matching driver found for device\n"); > + return; > + } > + > + strcpyW(fullname, szDriverW); > + strcatW(fullname, driver->driver_name); > + RtlInitUnicodeString(&driverName, fullname); > + > + if (!driver->loaded) > + { > + static const WCHAR servicesW[] = {'\\','R','e','g','i','s','t','r','y', > + '\\','M','a','c','h','i','n','e', > + '\\','S','y','s','t','e','m', > + '\\','C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t', > + '\\','S','e','r','v','i','c','e','s', > + '\\',0}; > + WCHAR driverKey[MAX_PATH]; > + UNICODE_STRING driverPath; > + > + strcpyW(driverKey, servicesW); > + strcatW(driverKey, driver->driver_name); > + RtlInitUnicodeString(&driverPath, driverKey); > + if (ZwLoadDriver(&driverPath) != STATUS_SUCCESS) > + { > + ERR("Failed to load driver %s\n",debugstr_w(driver->driver_name)); > + return; > + } > + driver->loaded = TRUE; > + } > + > + if (ObReferenceObjectByName(&driverName, OBJ_CASE_INSENSITIVE, NULL, > + 0, NULL, KernelMode, NULL, (void**)&driver_obj) != STATUS_SUCCESS) > + { > + ERR("Failed to locate loaded driver\n"); > + return; > + } > + > + status = ((pAddDevice)driver_obj->DriverExtension->AddDevice)(driver_obj, device); It would be better to handle the lack of a AddDevice routine. > + > + ObDereferenceObject(driver_obj); > + > + if (status != STATUS_SUCCESS) > + { > + ERR("AddDevice failed\n"); > + return; > + } > +} > + > static void initialize_driver_store(void) > { > static const WCHAR criticalW[] = > @@ -181,5 +322,14 @@ VOID WINAPI IoInvalidateDeviceRelations(DEVICE_OBJECT *DeviceObject, DEVICE_RELA > initialized = TRUE; > initialize_driver_store(); > } > + > + switch (Type) > + { > + case BusRelations: > + handle_bus_relations(DeviceObject); > + break; > + default: > + FIXME("Unhandled Relation %i\n", Type); > + } > LeaveCriticalSection(&pnp_cs); > } > > >

1 0

Re: [PATCH 1/4] ntoskrnl.exe: Implement IoInvalidateDeviceRelations to initialize device driver store
by Sebastian Lackner 31 Aug '16

31 Aug '16

On 29.08.2016 20:49, Aric Stewart wrote: > We are not handling installing drivers just yet, so we just make use of the > critical device store. These are drivers that, on Windows, are automatically > loaded on boot every time. This database is maintained in > [CurrentControlSet/Control/CriticalDeviceDatabase] The keys in this registry key > represent a HardwareID that match a device. We query the IDs from the bus > device’s BusQueryHardwareIDs and if we find a match (from most specific to most > general) we look at that registry key. The CriticalDeviceDatabase entry > specify a [Service] value representing the driver. > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/ntoskrnl.exe/Makefile.in | 3 +- > dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- > dlls/ntoskrnl.exe/pnp_manager.c | 185 ++++++++++++++++++++++++++++++++++++ > include/ddk/wdm.h | 1 + > 4 files changed, 189 insertions(+), 2 deletions(-) > create mode 100644 dlls/ntoskrnl.exe/pnp_manager.c > At some places the patch does not really use a consistent style yet (for example VOID <-> void, placement of "*" inbetween of type and variable name, "sz" prefix for variables, ...), however I will focus mainly on the technical aspects in this review. > > > 0001-ntoskrnl.exe-Implement-IoInvalidateDeviceRelations-to-.txt > > > diff --git a/dlls/ntoskrnl.exe/Makefile.in b/dlls/ntoskrnl.exe/Makefile.in > index b459c54..2fa768b 100644 > --- a/dlls/ntoskrnl.exe/Makefile.in > +++ b/dlls/ntoskrnl.exe/Makefile.in > @@ -4,6 +4,7 @@ IMPORTS = advapi32 > > C_SRCS = \ > instr.c \ > - ntoskrnl.c > + ntoskrnl.c \ > + pnp_manager.c > > RC_SRCS = ntoskrnl.rc > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > index 119d406..c94b902 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > @@ -400,7 +400,7 @@ > @ stdcall IoInitializeIrp(ptr long long) > @ stdcall IoInitializeRemoveLockEx(ptr long long long long) > @ stdcall IoInitializeTimer(ptr ptr ptr) > -@ stub IoInvalidateDeviceRelations > +@ stdcall IoInvalidateDeviceRelations(ptr long) > @ stub IoInvalidateDeviceState > @ stub IoIsFileOriginRemote > @ stub IoIsOperationSynchronous > diff --git a/dlls/ntoskrnl.exe/pnp_manager.c b/dlls/ntoskrnl.exe/pnp_manager.c > new file mode 100644 > index 0000000..5b42a0a > --- /dev/null > +++ b/dlls/ntoskrnl.exe/pnp_manager.c > @@ -0,0 +1,185 @@ > +/* HID plug and play Manager like functionality > + * > + * Copyright 2016 CodeWeavers, Aric Stewart > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > +#include "ntstatus.h" > +#define WIN32_NO_STATUS > +#include "windef.h" > +#include "winbase.h" > +#include "winternl.h" > +#include "ddk/wdm.h" > +#include "cfgmgr32.h" > +#include "winsvc.h" I don't think this include is required anymore. > +#include "winreg.h" > +#include "wine/debug.h" > +#include "wine/list.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(plugplay); > + > +#define MAX_SERVICE_NAME 260 > + > +typedef struct _device_driver { > + struct list entry; > + > + BOOL loaded; > + > + WCHAR **matching_ids; > + INT id_count; > + > + WCHAR *driver_name; > +} device_driver; > + > +struct list device_drivers = LIST_INIT(device_drivers); > +static BOOL initialized = FALSE; > + > +static CRITICAL_SECTION pnp_cs; > +static CRITICAL_SECTION_DEBUG critsect_debug = > +{ > + 0, 0, &pnp_cs, > + { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": pnp_cs") } > +}; > +static CRITICAL_SECTION pnp_cs = { &critsect_debug, -1, 0, 0, 0, 0 }; > + > +static inline LPWSTR strdupW(LPCWSTR src) > +{ > + LPWSTR dest; > + > + if (!src) > + return NULL; > + > + dest = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(src) + 1) * sizeof(WCHAR)); > + if (dest) > + lstrcpyW(dest, src); For new code it would be better to follow the current Wine style guidelines, which means no LP* types and strlenW/strcpyW without l prefix. > + > + return dest; > +} > + > +static device_driver* register_device_driver(const WCHAR *drivername, const WCHAR* match) > +{ > + device_driver *ptr; > + > + LIST_FOR_EACH_ENTRY(ptr, &device_drivers, device_driver, entry) > + { > + if (lstrcmpW(drivername, ptr->driver_name) == 0) > + { > + int i; > + /* Check matching ids */ > + for (i = 0; i < ptr->id_count; i++) > + if (lstrcmpW(match, ptr->matching_ids[i]) == 0) > + return ptr; > + /* Add a new matching id, this should be reletivly rare, > + no exponental growth needed */ > + ptr->matching_ids = HeapReAlloc(GetProcessHeap(), 0, ptr->matching_ids, sizeof(WCHAR*) * (ptr->id_count+1)); > + ptr->matching_ids[ptr->id_count] = strdupW(match); > + ptr->id_count++; If it is very rare, wouldn't it be better to add them as separate driver entries then? This would simplify the code and avoid nested loops at some places. The current way of organizing the driver db also has the disadvantage that the same "matching id" could be added for multiple drivers. > + > + return ptr; > + } > + } > + > + ptr = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ptr)); > + ptr->driver_name = strdupW(drivername); > + ptr->loaded = FALSE; > + ptr->matching_ids = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR*)); > + ptr->matching_ids[0] = strdupW(match); > + ptr->id_count = 1; > + list_add_tail(&device_drivers, &ptr->entry); > + > + return ptr; > +} > + > +static void initialize_driver_store(void) > +{ > + static const WCHAR criticalW[] = > + { 'S','y','s','t','e','m','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l', '\\', > + 'C','r','i','t','i','c','a','l','D','e','v','i','c','e','D','a','t','a','b','a','s','e', 0}; > + static const WCHAR serviceW[] = {'S','e','r','v','i','c','e',0}; > + HKEY hkey_root; > + WCHAR szMatch[MAX_DEVICE_ID_LEN]; > + int i; > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, criticalW, &hkey_root)) > + { > + TRACE("No drivers found\n"); > + return; > + } > + > + for (i = 0; TRUE; i++) > + { > + HKEY hkey_service; > + DWORD rc; > + device_driver *driver; > + DWORD len = 0; > + WCHAR szService[MAX_SERVICE_NAME]; > + > + rc = RegEnumKeyW(hkey_root, i, szMatch, MAX_DEVICE_ID_LEN); > + if (rc == ERROR_NO_MORE_ITEMS) > + break; > + > + if (rc != 0) > + { > + ERR("Error %d reading key %d - skipping\n", rc, i); > + continue; > + } > + > + if (RegOpenKeyW(hkey_root, szMatch, &hkey_service)) > + { > + ERR("Error opening key %s - skipping\n",debugstr_w(szMatch)); > + continue; > + } > + > + len = sizeof(szService); > + rc = RegQueryValueExW(hkey_service, serviceW, NULL, NULL, (BYTE*)szService, &len); It might be useful to check the type of the registry key here. > + if (rc != ERROR_SUCCESS) > + { > + ERR("Error querying service from key %s - skipping\n",debugstr_w(szMatch)); > + RegCloseKey(hkey_service); > + continue; > + } > + RegCloseKey(hkey_service); > + > + TRACE("Registering service '%s' to match '%s'\n", debugstr_w(szService), debugstr_w(szMatch)); > + > + driver = register_device_driver(szService, szMatch); > + if (!driver) > + ERR("failed to load driver %s\n", debugstr_w(szService)); The message is actually a bit misleading. It will only occur for duplicate entries, which should not happen anyway. > + > + } > + > + RegCloseKey(hkey_root); > +} > + > +/*********************************************************************** > + * IoInvalidateDeviceRelations(NTOSKRNL.EXE.@) > + */ > +VOID WINAPI IoInvalidateDeviceRelations(DEVICE_OBJECT *DeviceObject, DEVICE_RELATION_TYPE Type) > +{ > + TRACE("(%p %i)\n", DeviceObject, Type); > + > + EnterCriticalSection(&pnp_cs); > + if (!initialized) > + { > + initialized = TRUE; > + initialize_driver_store(); > + } > + LeaveCriticalSection(&pnp_cs); > +} > diff --git a/include/ddk/wdm.h b/include/ddk/wdm.h > index 68694af..bd3b323 100644 > --- a/include/ddk/wdm.h > +++ b/include/ddk/wdm.h > @@ -1233,6 +1233,7 @@ NTSTATUS WINAPI IoGetDeviceProperty(PDEVICE_OBJECT,DEVICE_REGISTRY_PROPERTY,ULO > PVOID WINAPI IoGetDriverObjectExtension(PDRIVER_OBJECT,PVOID); > PDEVICE_OBJECT WINAPI IoGetRelatedDeviceObject(PFILE_OBJECT); > void WINAPI IoInitializeIrp(IRP*,USHORT,CCHAR); > +void WINAPI IoInvalidateDeviceRelations(PDEVICE_OBJECT,DEVICE_RELATION_TYPE); > VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK,ULONG,ULONG,ULONG,ULONG); > NTSTATUS WINAPI IoWMIRegistrationControl(PDEVICE_OBJECT,ULONG); > > > >

1 0

Re: [PATCH 1/5] ddraw/tests: Move IDirect3DViewport::TransformVertices tests to ddraw1.c.
by Henri Verbeet 30 Aug '16

30 Aug '16

On 29 August 2016 at 23:01, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + * is transformed, and this vertex is offscreen.· Trailing whitespace. As an aside, those float comparisons are probably safe enough, but perhaps those should use compare_vec4()?

1 0

Re: kernel32: Stub CAL_RETURN_GENITIVE_NAMES flag.
by Nikolay Sivov 30 Aug '16

30 Aug '16

On 29.08.2016 22:24, David Keijser wrote: > This stops GetCalendarInfoW from reporting unknown caltype when it's > really a case of unsupported flags. > > Signed-off-by: David Keijser <keijser(a)gmail.com> > --- > dlls/kernel32/time.c | 4 +++- > include/winnls.h | 7 ++++--- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/dlls/kernel32/time.c b/dlls/kernel32/time.c > index b7a7918..e1fd107 100644 > --- a/dlls/kernel32/time.c > +++ b/dlls/kernel32/time.c > @@ -860,6 +860,8 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID Calendar, CALTYPE CalType, > FIXME("flag CAL_NOUSEROVERRIDE used, not fully implemented\n"); > if (CalType & CAL_USE_CP_ACP) > FIXME("flag CAL_USE_CP_ACP used, not fully implemented\n"); > + if (CalType & CAL_RETURN_GENITIVE_NAMES) > + FIXME("flag CAL_RETURN_GENITIVE_NAMES used, not fully implemented\n"); Hi, David. LOCALE_RETURN_GENITIVE_NAMES itself is implemented, you should pass it to GetLocaleInfo instead of stripping it from caltype. P.S. anyone working on translations please take another look at SMONTHNAME* constants for your language, to make sure genitive forms are there, if applicable. > > if (CalType & CAL_RETURN_NUMBER) { > if (!lpValue) > @@ -878,7 +880,7 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID Calendar, CALTYPE CalType, > > /* FIXME: No verification is made yet wrt Locale > * for the CALTYPES not requiring GetLocaleInfoA */ > - switch (CalType & ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP)) { > + switch (CalType & ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP|CAL_RETURN_GENITIVE_NAMES)) { > case CAL_ICALINTVALUE: > if (CalType & CAL_RETURN_NUMBER) > return GetLocaleInfoW(Locale, LOCALE_RETURN_NUMBER | LOCALE_ICALENDARTYPE, > diff --git a/include/winnls.h b/include/winnls.h > index 1a7baaf..3d950f6 100644 > --- a/include/winnls.h > +++ b/include/winnls.h > @@ -471,9 +471,10 @@ static const WCHAR LOCALE_NAME_SYSTEM_DEFAULT[] = {'!','s','y','s','-','d','e',' > #define MAX_DEFAULTCHAR 2 > > /* Defines for calendar handling */ > -#define CAL_NOUSEROVERRIDE LOCALE_NOUSEROVERRIDE > -#define CAL_USE_CP_ACP LOCALE_USE_CP_ACP > -#define CAL_RETURN_NUMBER LOCALE_RETURN_NUMBER > +#define CAL_NOUSEROVERRIDE LOCALE_NOUSEROVERRIDE > +#define CAL_USE_CP_ACP LOCALE_USE_CP_ACP > +#define CAL_RETURN_NUMBER LOCALE_RETURN_NUMBER > +#define CAL_RETURN_GENITIVE_NAMES LOCALE_RETURN_GENITIVE_NAMES > > #define CAL_ICALINTVALUE 0x01 > #define CAL_SCALNAME 0x02 >

2 1

Re: [PATCH 5/5] ddraw/tests: Extend TransformVertices invalid data tests.
by Marvin 29 Aug '16

29 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25440 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 3/5] ddraw: Fix offscreen flag handling in TransformVertices.
by Marvin 29 Aug '16

29 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25439 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 2/5] ddraw: Copy extra vertex data in viewport::TransformVertices.
by Marvin 29 Aug '16

29 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25438 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 1/5] ddraw/tests: Move IDirect3DViewport::TransformVertices tests to ddraw1.c.
by Marvin 29 Aug '16

29 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25437 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2215: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit d3d) === d3d.c:2051: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2051: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2235: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2382: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2382: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [v2 2/2] winejoystick.drv: Disable joysticks via wine registry on Mac
by Ken Thomases 29 Aug '16

29 Aug '16

Hi, On Aug 29, 2016, at 6:03 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > > +static void char_device_name_length(IOHIDDeviceRef device, char *name, int max_length) > +{ > + CFStringRef str = copy_device_name(device); > + CFIndex len = CFStringGetLength(str); > + > + if (name) > + name[0] = 0; > + > + if (max_length >= len) > + { > + CFStringGetCString(str,name,max_length,kCFStringEncodingASCII); > + CFRelease(str); > + } > + else > + { > + CFStringRef substr = CFStringCreateWithSubstring(kCFAllocatorDefault, str, CFRangeMake(0, max_length)); > + CFRelease(str); > + CFStringGetCString(substr,name,max_length,kCFStringEncodingASCII); > + CFRelease(substr); > + } > +} I realize you based this function on code from DInput. Unfortunately, that code is pretty badly broken. CFStringGetLength() returns the length of the string in UTF-16 code units, which is basically the same as WCHARs. It's not meaningful to compare that to a buffer size that's in ASCII chars. Using ASCII is wrong, too. If the name has any non-ASCII characters in it, the conversion will just fail. Second, it's potentially unnecessarily restrictive. Your device_disabled_registry() function, by virtue of using the "A" variant RegQueryValueEx(), uses the ANSI code page, not ASCII. The ANSI code page could maybe handle more names than ASCII would. You could get a wide string and then use WideCharToMultiByte() to convert it to CP_ACP, but since you control all of the relevant code, it's just better to work with wide strings throughout. Change your device_disabled_registry() and get_config_key() functions to accept a wide string. Then, you can safely use CFStringGetLength() and CFStringGetCharacters() to acquire the WCHAR-based wide string from the CFString. You can just cast a WCHAR* to a UniChar*. -Ken

1 0

Re: [v2 1/2] winejoystick.drv: Add functionality to disable joystick via registry
by Ken Thomases 29 Aug '16

29 Aug '16

On Aug 29, 2016, at 6:03 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > > + get_app_key(&hkey, &appkey); > + > + /* Joystick settings are in the 'joysticks' subkey */ > + if (appkey) > + { > + if (RegOpenKeyA(appkey, joystick_key, &temp)) temp = 0; > + RegCloseKey(appkey); > + appkey = temp; > + } > + if (hkey) > + { > + if (RegOpenKeyA(hkey, joystick_key, &temp)) temp = 0; > + RegCloseKey(hkey); > + hkey = temp; > + } It seems the appending of the Joysticks subkey should be done in get_app_key(). -Ken

1 0

Re: rpcrt4/tests: Don't load GetUserNameEx dynamically.
by Marvin 29 Aug '16

29 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25430 Your paranoid android. === w864 (32 bit rpc) === rpc.c:815: Test failed: GUID does not appear to contain a MAC address: {9d7329b2-6dfd-11e6-be78-e71666c2e04a} === w864 (64 bit rpc) === rpc.c:815: Test failed: GUID does not appear to contain a MAC address: {cfff88a2-6dfd-11e6-be78-e71666c2e04a} === w8 (32 bit server) === server.c:1010: Test failed: get_ranged_enum() returned 2000814083 instead of RE3 === w864 (32 bit server) === server.c:1010: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1010: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1010: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 === w864 (64 bit server) === server.c:1010: Test failed: get_ranged_enum() returned 4390915 instead of RE3 server.c:1010: Test failed: get_ranged_enum() returned 117440515 instead of RE3 server.c:1010: Test failed: get_ranged_enum() returned 4390915 instead of RE3 === w1064 (64 bit server) === server.c:1010: Test failed: get_ranged_enum() returned 6356995 instead of RE3 server.c:1010: Test failed: get_ranged_enum() returned 6029315 instead of RE3

1 0

Re: d3drm/tests: Fix crash when surface can't be created
by Henri Verbeet 29 Aug '16

29 Aug '16

On 28 August 2016 at 16:49, André Hentschel <nerv(a)dawncrow.de> wrote: > Should fix crashes like: > https://test.winehq.org/data/a83d5d3b83042d2305de0595c0d03e4e7bf1e29e/xp_wx… > Does this happen on any setups that aren't using "VirtualBox Graphics Adapter" as display driver? I don't think failing the test or skipping is ultimately much more useful than crashing here, but if it's just about skipping cleanly I'd rather just blacklist the driver in a way similar to ddraw_is_warp() in the ddraw tests.

1 0

Re: [v1 1/5] winejoystick.drv: Add functionality to disable joystick via registry
by Bruno Jesus 29 Aug '16

29 Aug '16

On Sun, Aug 28, 2016 at 3:18 AM, David Lawrie <david.dljunk(a)gmail.com> wrote: > Adds device_disabled_registry, helper functions to shared joystick code Hi, thanks for working on this. The problem with this series is that you are introducing dead code in patches 1, 2 and 3. As the code is not used anywhere until patch 5. Patch 4 also adds dead code that is only used in patch 5. IMO you should merge patches 1,2,3 into a single patch and also 4 and 5 into second patch. This will make the dead code will last a single commit. Best wishes, Bruno

2 1

Re: [PATCH 1/2] rbtree.h: Store parent in each entry and use that to manipulate the tree without a stack.
by Henri Verbeet 29 Aug '16

29 Aug '16

On 10 August 2016 at 16:01, Jacek Caban <jacek(a)codeweavers.com> wrote: > include/wine/rbtree.h | 376 > +++++++++++++++++++++++++++----------------------- > 1 file changed, 200 insertions(+), 176 deletions(-) > Since this patch was assigned to me... I think this patch has quite a number of unrelated changes, to the point that the patch touches over half of the lines in the file and I think deletion for example ends up just being a different algorithm. And while the aforementioned means I didn't look at everything in quite the amount of detail that would otherwise be appropriate, I do think some of those changes make things overly complicated. For example, a straightforward modification to wine_rb_put() would turn it into something like the following: static inline int wine_rb_put(struct wine_rb_tree *tree, const void *key, struct wine_rb_entry *entry) { struct wine_rb_entry **node = &tree->root; struct wine_rb_entry *parent = *node; while (*node) { int c; if (!(c = tree->functions->compare(key, *node))) return -1; parent = *node; if (c < 0) node = &(*node)->left; else node = &(*node)->right; } entry->flags = WINE_RB_FLAG_RED; entry->parent = parent; entry->left = NULL; entry->right = NULL; *node = entry; wine_rb_fixup(&tree->root, entry); tree->root->flags &= ~WINE_RB_FLAG_RED; return 0; } I think that's much clearer than what this patch does with wine_rb_put().

3 10

Re: dxdiagn: Do fill DMI information on Linux
by Chris Robinson 28 Aug '16

28 Aug '16

On 08/28/2016 02:50 AM, Ruslan Kabatsayev wrote: > This patch makes previously empty fields szSystemManufacturerEnglish, > szSystemManufacturerEnglish and szBIOSEnglish in DxDiag filled with the > DMI information. This is the same information I get on my test Windows > system. > Currently this is only implemented for Linux, on other platforms > the fields remain empty. Are there functions to get this info in the Windows API? If so, it may be worth using/implementing those API calls, instead of reading it directly from the host like this.

2 1

Issues if GLX_SWAP_METHOD_OML is not fully supported
by Fabian Maurer 28 Aug '16

28 Aug '16

Hello, I have an OpenGL program that tries to use WGL_SWAP_METHOD, but while my graphics card supports GLX_OML_swap_method, no pixelformat supports its value GLX_SWAP_EXCHANGE_OML. Is this a graphics driver issue? I'm using the most recent open source mesa drivers. Attached a patch proposal to deal with the issue in wine, but I'm not sure if this is the right course of action to take. Fabian Maurer

2 2

How to link winreg.h to winejoystick.drv during compilation
by DavidL 28 Aug '16

28 Aug '16

I'm trying to add the ability to read registry keys to winejoystick.drv using functions like RegQueryValueExA, RegOpenKeyA, and RegCloseKey. However, I am getting linker errors where they are showing up as undefined symbols. The changed files are attached. The functions get_app_key, get_config_key, and device_disabled_registry are copied from various files in dinput and I assumed I needed to import advapi32 in the makefile.in since that's what type the aforementioned registry functions are, but I'm obviously misunderstanding how this works. Any help appreciated! Thanks, David

3 4

Re: Add a GUI for dxdiag program
by Aaryaman Vasishta 27 Aug '16

27 Aug '16

Hi, Thanks for your patch! I see there are still many style inconsistencies here, like "foo=bar;" and "foo = bar;" mixed together. Same for passing arguments, like "foo(bar,baz)" and "foo(bar, baz)" mixed together. Please try sticking to a single convention, it helps in code readability. There also might be an issue with the consistency of indendation on longer lines which do not fit. As long as you keep the indentation levels consistent across the file you should be fine. On Sat, Aug 27, 2016 at 1:56 PM, Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > +INT_PTR CALLBACK system_tab_proc(HWND hsystab, UINT msg, WPARAM wparam, > LPARAM lparam) > +{ > + switch(msg) > + { > + case WM_COMMAND: > + switch(HIWORD(wparam)) > + { > + case BN_CLICKED: > + switch(wparam) > + { > + case IDC_WHQL_CHECKBOX: > + { > + update_dxdiag_info(); > + return TRUE; > + } > + } > + break; > There's an indentation issue here. You should still wait for others to review this before re-sending this patch though. Cheers, Aaryaman

2 2

Yet another xinput implementation for the xbox360 controller
by Bruno Jesus 27 Aug '16

27 Aug '16

Hi to everybody. In order to exercise dinput (which is overly complex) I have implemented xinput using dinput. Xinput is as easy as winmm joystick support, I guess MS wanted to go back to the basics. I know that this is not really useful specially when HID kicks in but as I said it was an exercise and now I can play Broforce properly with the Xbox controller and force feedback. If you know a game that is xinput only and it does not work with this patch tests are appreciated (+xinput,+dinput). Most of the code can still be reused for HID IMO, just change the dinput functions. If you want force feedback remember to disable the (js) joystick in the control panel. Also if you have other controller brands it must have at least 6 axis, 11 buttons and 1 POV to work, but the mapping has to be redone. If it has less buttons you can relax the checks in dinput_is_good. Last but not least I know I should have used dinput to map the axes values for me but I was tired of reading dinput docs and it was easy enough to convert manually. Best wishes, Bruno

1 1

Re: [PATCH 1/2] user32: Wait before getting/setting the cursor position in send_hardware_message
by Alexandre Julliard 27 Aug '16

27 Aug '16

Max Qian <public(a)maxqia.com> writes: > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > dlls/user32/message.c | 20 +++++++++++++------- > include/wine/server_protocol.h | 8 ++------ > server/protocol.def | 4 ---- > server/queue.c | 5 ----- > server/request.h | 6 +----- > server/trace.c | 4 ---- > 6 files changed, 16 insertions(+), 31 deletions(-) There's a lot of complexity in the mouse input code, but it was all added for a reason. There are many games that do strange things with mouse input. If you want to remove things, you'll need to explain why you think they are no longer necessary. They were definitely necessary when I added them. That doesn't mean that it's perfect, but I think you should be looking into ways of tweaking the existing code instead of taking an axe to it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bugs in gcc 5.3.0, 5.4.0 with force_align_arg_pointer
by Daniel Santos 27 Aug '16

27 Aug '16

Just to let you guys know, there's a bug in gcc 5.3 & 5.4 that causes wine's 64 bit code to be generated as if the incoming stack boundary was 8 bytes. This makes the pro/epilogues all bloaty with unaligned movups for SSE saves/restores. This can be avoided by actually *not* using force_align_arg_pointer or -mstackrealign. Note however that when using either of those, we should supply -mincoming-stack-boundary=4 so that gcc knows what alignment to force the arg pointer to... except that that is also expertly broken. I'm not aware of this actually causing any crashes or UB, just producing slower, bloaty code. There was also PR69140 that caused build breakage when the stack pointer wasn't properly aligned, but I guess this is a flaw that got exposed once force_align_arg_pointer started breaking alignment on x64 abi. Daniel

1 0

Re: kernel32: Fixed handling LOCALE_NAME_USER_DEFAULT in GetLocaleInfoEx.
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25413 Your paranoid android. === w1064 (32 bit locale) === locale.c:2554: Test failed: LCMapStringEx should fail with bad locale name locale.c:2555: Test failed: unexpected error code -559038737 locale.c:2646: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4382: Test failed: IsValidLocaleName should have failed locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4767: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4769: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2554: Test failed: LCMapStringEx should fail with bad locale name locale.c:2555: Test failed: unexpected error code -559038737 locale.c:2646: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4382: Test failed: IsValidLocaleName should have failed locale.c:4384: Test failed: IsValidLocaleName should have failed locale.c:4767: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4769: Test failed: For id 7, Expected IVC, got ''

1 0

Re: user32: Fix DefWindowProc behavior on WM_NCRBUTTONDOWN message
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25405 Your paranoid android. === w7u (32 bit msg) === msg.c:4771: Test failed: ShowWindow(SW_RESTORE):overlapped: 18: the msg sequence is not complete: expected 0000 - actual 0088 === w8 (32 bit msg) === msg.c:13932: Test failed: WM_NCRBUTTONDOWN on caption: 3: the msg sequence is not complete: expected 007b - actual 0000 === w864 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6715: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6717: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:13932: Test failed: WM_NCRBUTTONDOWN on caption: 3: the msg sequence is not complete: expected 007b - actual 0000 === w1064 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6715: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6717: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:13932: Test failed: WM_NCRBUTTONDOWN on caption: 3: the msg sequence is not complete: expected 007b - actual 0000 === w864 (64 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6715: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6717: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:13932: Test failed: WM_NCRBUTTONDOWN on caption: 3: the msg sequence is not complete: expected 007b - actual 0000 === w1064 (64 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6715: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6717: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:7078: Test failed: SetWindowPos:FrameChanged_clip: 10: the msg sequence is not complete: expected 0000 - actual 001a msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:13932: Test failed: WM_NCRBUTTONDOWN on caption: 3: the msg sequence is not complete: expected 007b - actual 0000

1 0

Re: [2/3] winex11: Returning more reliable value from X11DRV_MsgWaitForMultipleObjects.
by Ken Thomases 26 Aug '16

26 Aug '16

Hi, On Aug 23, 2016, at 8:13 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > > This patch fixes ole32 test failure with my IME window patch. > > After processing several X events, X11DRV_MsgWaitForMultipleObjects always > tells us that a new message is available. This is not true for some cases. > > For instance, when we call DestroyWindow, the X queues DestroyEvent. Then, > X11DRV_MsgWaitForMultipleObjects handles the event only; none is posted or > sent as hwnd for destroyed window is unavailable. However, the function > states "new message is available" by returning count - 1 value. > > This is an issue for CoWaitForMultipleHandles because it expects a new > message in the queue and consumes the message. I'm looking at this with an eye toward whether the Mac driver needs a similar change. First, there's no change in the ole32 tests with or without your IME window patch when using the Mac driver. There's a clipboard failure but everything else succeeds. Second, the Mac driver doesn't have a notion of the window being destroyed behind our backs. I.e. there's nothing like a DestroyNotify event for a window whose HWND is still valid. But, just because that particular case doesn't come up doesn't mean the change is not still relevant to the Mac driver for other cases. However, I'm having a hard time seeing the logic of your change. In process_events(), you use a variable named "queued" to hold the result of calls to event handlers. That implies that event handlers should only return true if they have posted or sent a Windows message or hardware input. But that doesn't seem to be what you've actually done in the event handlers. For example, in the first "if" statement in X11DRV_MapNotify(), you return true without queuing anything. Instead, you seem to be returning true for some notion of "success" in handling events, but I'm not sure how that plays into the rationale for this patch. Am I misunderstanding something? I also don't get why you changed the TRACE at the end of process_events(). The events really were processed. They aren't "ignored" just because they didn't result in messages or input being queued. Also, shouldn't the return type of process_events() be changed to BOOL? Thanks, Ken

2 1

What flavor of C does Wine source target?
by Ruslan Kabatsayev 26 Aug '16

26 Aug '16

Hello all, While developing some code for Wine I wanted to ensure that I don't use some C99 features like C++-style comments or declaration of variables after statement. But the only way I found to do this with gcc was to use '-std=c89 -pedantic'. This appears to break lots of other things in winelib, particularly 'inline' functions, so it can't really be used for Wine/Winelib sources. The default for GCC is gnu89, which does allow the things Wine doesn't want. So, I wonder now, what flavor of C does Wine actually target? What tools can I use to automatically restrict language features? Regards, Ruslan

3 2

Re: [PATCH 3/6] wined3d: Handle WINED3DFMT_FLAG_BROKEN_PITCH in wined3d_format_calculate_size().
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25402 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 3/6] wined3d: Handle WINED3DFMT_FLAG_BROKEN_PITCH in wined3d_format_calculate_size().
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25401 Your paranoid android. === w8 (32 bit device) === device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2784: Test failed: The focus window is active. device.c:2792: Test failed: Got unexpected hr 0x88760869. device.c:2796: Test failed: Got unexpect screen size 800x600. device.c:2811: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2820: Test failed: Got unexpect screen size 800x600. device.c:2833: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2841: Test failed: Got unexpect width 640. device.c:2842: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2784: Test failed: The focus window is active. device.c:2792: Test failed: Got unexpected hr 0x88760869. device.c:2796: Test failed: Got unexpect screen size 800x600. device.c:2811: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2820: Test failed: Got unexpect screen size 800x600. device.c:2833: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2841: Test failed: Got unexpect width 640. device.c:2842: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2784: Test failed: The focus window is active. device.c:2792: Test failed: Got unexpected hr 0x88760869. device.c:2796: Test failed: Got unexpect screen size 800x600. device.c:2811: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2820: Test failed: Got unexpect screen size 800x600. device.c:2833: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2841: Test failed: Got unexpect width 640. device.c:2842: Test failed: Got unexpect height 480.

1 0

Re: ntdll: Add missing stdint.h include for kfreebsd architectures.
by Jens Reyer 26 Aug '16

26 Aug '16

On 24.08.2016 19:05, Marvin wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Pending". > > This means that the patch is not necessarily wrong, but its > correctness is not obvious. You should either write a test case > demonstrating that it is correct, try to fix the problem in a more > straightforward way, or better explain why you are doing things this > way. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. It's not clear to me why this was set to pending, so I'll try to cover most bases in this mail: I assume the patch itself is fine!? We deploy it on every arch (Linux: amd64 arm64 armel armhf i386 powerpc, hurd-i386, kfreebsd-i386) Authorship: The original author Mike (CCed in patch submission) is quite short on time, so I decided to bring this patch (and others that we have in Debian) here. The whole Debian packaging is LGPL-2.1+ licensed (except if we use 3rd party stuff, which isn't the case for this patch). See [1]. History of this patch: 1.7.45-1 add, Michael Gilbert [2] 1.7.54-1 temporarily disable, Michael Gilbert [3] 1.7.54-2 refresh and readd, Michael Gilbert [4] 1.7.55-1 rename, Michael Gilbert [5] 1.9.9-1 refresh, Jens Reyer [6] Is this patch needed? Related (fixed) build failures: The last successful build on kfreebsd-i386 without this patch was 1.7.41-1. There's no data for 1.7.42/1.7.43. 1.7.44 failed to build. With the patch 1.7.45 and following versions built. When the patch was removed temporarily 1.7.54-1 failed to build. Later versions with patch built again. A list of all build logs is available at [7]. I didn't run a regression test, nor can name the relevant commit that caused the failure (I assume it was a change in Wine). If required I might verify if the patch is still needed today, but I'd have to apply for access to a kfreebsd machine first. I hope this clarifies everything Greets jre [1] https://anonscm.debian.org/git/pkg-wine/wine.git/tree/debian/copyright [2] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=4d7a55e [3] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=94643f4 [4] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=0fa1339 [5] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=8deb56f [6] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=3d3f870 [7] https://buildd.debian.org/status/logs.php?pkg=wine-development&arch=kfreebs…

1 1

Re: [PATCH 4/4] oleaut32: Implement ITypeComp::Bind() proxy/stub
by Huw Davies 26 Aug '16

26 Aug '16

On Thu, Aug 25, 2016 at 08:57:18PM +0300, Nikolay Sivov wrote: > + if (hr == S_OK) > + { > + switch (*desckind) > + { > + case DESCKIND_FUNCDESC: > + bindptr->lpfuncdesc = funcdesc; > + break; > + case DESCKIND_VARDESC: > + bindptr->lpvardesc = vardesc; > + break; > + case DESCKIND_TYPECOMP: > + bindptr->lptcomp = typecomp; > + break; > + default: > + ; > + } You're missing DESCKIND_IMPLICITAPPOBJ which should be handled like DESCKIND_VARDESC. Huw.

1 0

Re: kernel32/tests: Add a missing linebreak to an ok() message.
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25390 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext (try3)
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25379 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x2c0000/0x2c0001 exception: unhandled exception 80000004 at 002C0000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x2c0001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x3c0000/0x3c0001 exception: unhandled exception 80000004 at 003C0000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x3c0001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: What flavor of C does Wine source target?
by achbarrr＠gmail.com 26 Aug '16

26 Aug '16

hello Ruslan wine is looking like emulator its works same like bluestacks app player. if its true wine is not emulator its must work like other. Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: >Hello all, > >While developing some code for Wine I wanted to ensure that I don't >use some C99 features like C++-style comments or declaration of >variables after statement. But the only way I found to do this with >gcc was to use '-std=c89 -pedantic'. This appears to break lots of >other things in winelib, particularly 'inline' functions, so it can't >really be used for Wine/Winelib sources. The default for GCC is gnu89, >which does allow the things Wine doesn't want. > >So, I wonder now, what flavor of C does Wine actually target? What >tools can I use to automatically restrict language features? > >Regards, >Ruslan > >

1 0

Re: [PATCH] wined3d: Fix ATI1 buffer size, try 3
by Marvin 26 Aug '16

26 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25380 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH] ntdll: Use boot time to calculate tick count
by Ken Thomases 25 Aug '16

25 Aug '16

On Aug 25, 2016, at 2:55 PM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > > Two catches with the macOS behavior: First, this implementation is much > more expensive than one system call in a very frequently called > function. mach_absolute_time() isn't even a system call. It's implemented in user space. It reads the TSC from the CPU and applies adjustments read from the commpage. There's a potential for it to loop if the commpage is adjusted while it's running. > It's an open question whether fixing behavior on sleep is > worth the cost. Second, the boot time has precision only to the nearest > second. This could cause skew if the current time is updated in <~1 > second intervals. Actually, it will cause skew whenever the current time is updated by a delta that's not whole seconds. Another issue is the race between sysctl() and gettimeofday(). If a time adjustment occurs between them, you'll get an incorrect result. This could be detected by checking the boot time again after gettimeofday() and repeating if it changed. Unfortunately, that adds even more overhead. (Actually, if we track the last known boot time in a static, we could only check it after and loop if it changed. That requires interlocked updating of the static, though, to make it thread safe.) Unfortunately, I don't know a good solution. I think that it may be a bug that mach_absolute_time() doesn't count time spent sleeping, but that's of no comfort. -Ken

1 0

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext (try2)
by Piotr Caban 25 Aug '16

25 Aug '16

Hi Daniel, On 08/18/16 18:29, Daniel Lehman wrote: > + pass = 0; > + pRtlCaptureContext(&ctx); > + if (InterlockedIncrement(&pass) == 1) /* interlocked to prevent compiler from moving */ The patch looks good for me except one thing that I don't understand. Why there's no risk that compiler will move the pass=0 assignment after pRtlCaptureContext call? Maybe something like this will be more correct: pass = 0; InterlockedIncrement(&pass); pRtlCaptureContext(&ctx); if (InterlockedIncrement(&pass) == 2) ? Thanks, Piotr

2 1

Re: [PATCH] user32: Only use the driver for getting the position
by Alexandre Julliard 25 Aug '16

25 Aug '16

Max Qian <public(a)maxqia.com> writes: > This fixes bug 24951 and reverts GetCursorPos related > changes from commits 39c4e6d, f1a3480, and 6576703. This is going to break things that use low-level hooks, in particular dinput, since the cursor won't be in sync with the hardware events. We also have tests for that: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so input && touch input.ok input.c:1299: Test failed: Wrong new pos: (103,103) input.c:1302: Test failed: Wrong new pos: (106,106) input.c:1305: Test failed: Wrong new pos: (109,109) input.c:1308: Test failed: Wrong new pos: (112,112) make: *** [input.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v2] d3d8/tests: Prefer higher resolutions in test_reset().
by Marvin 25 Aug '16

25 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25373 Your paranoid android. === w8 (32 bit device) === device.c:2794: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2799: Test failed: The focus window is active. device.c:2807: Test failed: Got unexpected hr 0x88760869. device.c:2811: Test failed: Got unexpect screen size 800x600. device.c:2826: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2835: Test failed: Got unexpect screen size 800x600. device.c:2848: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2856: Test failed: Got unexpect width 640. device.c:2857: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2794: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2799: Test failed: The focus window is active. device.c:2807: Test failed: Got unexpected hr 0x88760869. device.c:2811: Test failed: Got unexpect screen size 800x600. device.c:2826: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2835: Test failed: Got unexpect screen size 800x600. device.c:2848: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2856: Test failed: Got unexpect width 640. device.c:2857: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2794: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2799: Test failed: The focus window is active. device.c:2807: Test failed: Got unexpected hr 0x88760869. device.c:2811: Test failed: Got unexpect screen size 800x600. device.c:2826: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2835: Test failed: Got unexpect screen size 800x600. device.c:2848: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2856: Test failed: Got unexpect width 640. device.c:2857: Test failed: Got unexpect height 480.

1 0

Re: [PATCH v9 2/3] shell32: Implement FolderItems_Item.
by Sebastian Lackner 25 Aug '16

25 Aug '16

On 23.08.2016 06:02, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shelldispatch.c | 136 +++++++++++++++++++++++++++++++++++-- > dlls/shell32/tests/shelldispatch.c | 13 ---- > 2 files changed, 130 insertions(+), 19 deletions(-) > Thanks for the updated version, this already looks much better. Nevertheless, I have two more small requests: * You decided to use StrDupW(), but there shouldn't be any need to use this shlwapi function. The only other place where it was used in shell32 was wrong and has been fixed with: http://source.winehq.org/git/wine.git/commit/a11fb74ffb15b60768c6fa49b07251… I would suggest to move the strdupW() function which is used in other parts of shell32 to the public header file and then use that instead. * You decided to use exponential growth for the filenames buffer which is better than allocating only one element at once. Nevertheless, it might still waste a lot of memory. I would suggest to use either linear growth or attempt to shrink the buffer size to release unnecessary space. Patch 1 should technically be fine, but the code still looks unnecessary complex to me. I will think about some ways to simplify it a bit more. Regards, Sebastian

2 1

Re: [PATCH v8 2/3] shell32: Implement FolderItems_Item.
by Sebastian Lackner 25 Aug '16

25 Aug '16

On 19.08.2016 11:43, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shelldispatch.c | 133 +++++++++++++++++++++++++++++++++++-- > dlls/shell32/tests/shelldispatch.c | 12 ---- > 2 files changed, 127 insertions(+), 18 deletions(-) > > diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c > index ac79302..a456ad4 100644 > --- a/dlls/shell32/shelldispatch.c > +++ b/dlls/shell32/shelldispatch.c > @@ -68,6 +68,9 @@ typedef struct { > typedef struct { > FolderItems3 FolderItems3_iface; > LONG ref; > + VARIANT dir; > + BSTR *item_paths; > + LONG item_count; > } FolderItemsImpl; > > typedef struct { > @@ -989,11 +992,18 @@ static ULONG WINAPI FolderItemsImpl_Release(FolderItems3 *iface) > { > FolderItemsImpl *This = impl_from_FolderItems(iface); > ULONG ref = InterlockedDecrement(&This->ref); > + int i; > > TRACE("(%p), new refcount=%i\n", iface, ref); > > if (!ref) > + { > + VariantClear(&This->dir); > + for (i = 0; i < This->item_count; i++) > + SysFreeString(This->item_paths[i]); > + HeapFree(GetProcessHeap(), 0, This->item_paths); > HeapFree(GetProcessHeap(), 0, This); > + } > return ref; > } > > @@ -1079,10 +1089,47 @@ static HRESULT WINAPI FolderItemsImpl_get_Parent(FolderItems3 *iface, IDispatch > > static HRESULT WINAPI FolderItemsImpl_Item(FolderItems3 *iface, VARIANT index, FolderItem **ppid) > { > - FIXME("(%p,%s,%p)\n", iface, debugstr_variant(&index), ppid); > + FolderItemsImpl *This = impl_from_FolderItems(iface); > + VARIANT path; > + int i; > + > + TRACE("(%p,%s,%p)\n", iface, debugstr_variant(&index), ppid); > > *ppid = NULL; > - return E_NOTIMPL; > + > + switch (V_VT(&index)) > + { > + case VT_I2: > + VariantChangeType(&index, &index, 0, VT_I4); > + /* fall through */ > + case VT_I4: > + if (V_I4(&index) < 0 || V_I4(&index) >= This->item_count) > + return S_FALSE; > + > + V_VT(&path) = VT_BSTR; > + V_BSTR(&path) = This->item_paths[V_I4(&index)]; > + return FolderItem_Constructor(&path, ppid); > + > + case VT_BSTR: > + for (i = 0; i < This->item_count; i++) > + { > + if (!lstrcmpW(V_BSTR(&index), PathFindFileNameW(This->item_paths[i]))) Usually strcmpW is preferred in Wine code. Its better to do NULL pointer checks explicitly. > + { > + V_VT(&path) = VT_BSTR; > + V_BSTR(&path) = This->item_paths[i]; > + return FolderItem_Constructor(&path, ppid); > + } > + } > + return S_FALSE; > + > + case VT_ERROR: > + V_VT(&path) = VT_BSTR; > + V_BSTR(&path) = V_BSTR(&This->dir); > + return FolderItem_Constructor(&path, ppid); You can also pass &This->dir directly to the constructor. > + > + default: > + return E_NOTIMPL; > + } > } > > static HRESULT WINAPI FolderItemsImpl__NewEnum(FolderItems3 *iface, IUnknown **ppunk) > @@ -1139,21 +1186,93 @@ static const FolderItems3Vtbl FolderItemsImpl_Vtbl = { > FolderItemsImpl_get_Verbs > }; > > -static HRESULT FolderItems_Constructor(FolderItems **ppfi) > +static HRESULT FolderItems_Constructor(VARIANT *dir, FolderItems **ppfi) > { > + static const WCHAR backslash_star[] = {'\\','*',0}; > + static const WCHAR dot[] = {'.',0}; > + static const WCHAR dot_dot[] = {'.','.',0}; > FolderItemsImpl *This; > + WCHAR path[MAX_PATH + 2]; > + HANDLE first_file; > + WIN32_FIND_DATAW file_info; > + BSTR *paths; > + HRESULT ret; > > TRACE("\n"); Not really an issue, but you could add a trace for the function arguments here. > > *ppfi = NULL; > > + if (V_VT(dir) == VT_I4) > + { > + FIXME("special folder constants are not supported\n"); > + return E_NOTIMPL; > + } > + > This = HeapAlloc(GetProcessHeap(), 0, sizeof(FolderItemsImpl)); > if (!This) return E_OUTOFMEMORY; > This->FolderItems3_iface.lpVtbl = &FolderItemsImpl_Vtbl; > This->ref = 1; > > + VariantInit(&This->dir); > + ret = VariantCopy(&This->dir, dir); > + if (FAILED(ret)) > + { > + HeapFree(GetProcessHeap(), 0, This); > + return E_OUTOFMEMORY; > + } > + > + This->item_paths = HeapAlloc(GetProcessHeap(), 0, sizeof(BSTR)); > + if (!This->item_paths) > + { > + VariantClear(&This->dir); > + HeapFree(GetProcessHeap(), 0, This); > + return E_OUTOFMEMORY; > + } > + This->item_count = 0; > + > + lstrcpyW(path, V_BSTR(dir)); > + lstrcatW(path, backslash_star); > + first_file = FindFirstFileW(path, &file_info); > + if (first_file != INVALID_HANDLE_VALUE) > + { > + do > + { > + if (!lstrcmpW(file_info.cFileName, dot) || !lstrcmpW(file_info.cFileName, dot_dot)) > + continue; Similar to above, strcmpW is usually preferred. > + > + if (!PathCombineW(path, V_BSTR(dir), file_info.cFileName)) > + { > + ret = E_OUTOFMEMORY; > + goto fail; > + } I think it makes more sense to store the relative paths, there is no need to prepend the directory name in advance. FolderItemsImpl_Item also expects a relative path for example. > + > + paths = HeapReAlloc(GetProcessHeap(), 0, This->item_paths, (This->item_count + 1) * sizeof(BSTR)); It seems more reasonable to increase the buffer size in bigger chunks. Its better to have a few entries overhead than to do frequent reallocs. > + if (!paths) > + { > + ret = E_OUTOFMEMORY; > + goto fail; > + } > + This->item_paths = paths; > + > + This->item_paths[This->item_count] = SysAllocString(path); > + if (!This->item_paths[This->item_count]) > + { > + ret = E_OUTOFMEMORY; > + goto fail; > + } > + This->item_count++; > + } > + while (FindNextFileW(first_file, &file_info)); > + > + FindClose(first_file); > + } > + > *ppfi = (FolderItems*)&This->FolderItems3_iface; > - return S_OK; > + return ret; It is better to return S_OK explicitly because !FAILED(ret) could still be any other value >= 0, like S_FALSE for example. > + > +fail: You are leaking the FindFirstFile handle here. > + FolderItems3_Release(&This->FolderItems3_iface); > + return ret; > } > > static HRESULT WINAPI FolderImpl_QueryInterface(Folder3 *iface, REFIID riid, > @@ -1308,9 +1427,11 @@ static HRESULT WINAPI FolderImpl_get_ParentFolder(Folder3 *iface, Folder **ppsf) > > static HRESULT WINAPI FolderImpl_Items(Folder3 *iface, FolderItems **ppid) > { > - FIXME("(%p,%p)\n", iface, ppid); > + FolderImpl *This = impl_from_Folder(iface); > + > + TRACE("(%p,%p)\n", iface, ppid); > > - return FolderItems_Constructor(ppid); > + return FolderItems_Constructor(&This->dir, ppid); > } > > static HRESULT WINAPI FolderImpl_ParseName(Folder3 *iface, BSTR name, FolderItem **item) > diff --git a/dlls/shell32/tests/shelldispatch.c b/dlls/shell32/tests/shelldispatch.c > index 6715794..dc4fda4 100644 > --- a/dlls/shell32/tests/shelldispatch.c > +++ b/dlls/shell32/tests/shelldispatch.c > @@ -390,7 +390,6 @@ todo_wine > r = FolderItems_Item(items, var, NULL); > > r = FolderItems_Item(items, var, &item); > -todo_wine > ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > ok(!item, "item is not null\n"); > > @@ -470,14 +469,11 @@ todo_wine > r = FolderItems_Item(items, var, &item); > if (i == VT_I2 || i == VT_I4 || i == VT_ERROR) > { > -todo_wine > ok(r == S_OK, "type %d: expected S_OK, got %08x\n", i, r); > -todo_wine > ok(!!item, "item is null\n"); > } > else if (i == VT_BSTR) > { > -todo_wine > ok(r == S_FALSE, "type %d: expected S_FALSE, got %08x\n", i, r); > ok(!item, "item is not null\n"); > } > @@ -495,11 +491,8 @@ todo_wine > V_VT(&var) = VT_ERROR; > V_ERROR(&var) = i; > r = FolderItems_Item(items, var, &item); > -todo_wine > ok(r == S_OK, "expected S_OK, got %08x\n", r); > -todo_wine > ok(!!item, "item is null\n"); > - if (!item) continue; > > bstr = NULL; > r = FolderItem_get_Path(item, &bstr); > @@ -518,7 +511,6 @@ todo_wine > V_I4(&var) = -1; > item = (FolderItem*)0xdeadbeef; > r = FolderItems_Item(items, var, &item); > -todo_wine > ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > ok(!item, "item is not null\n"); > > @@ -541,11 +533,8 @@ todo_wine > > item = NULL; > r = FolderItems_Item(items, var, &item); > -todo_wine > ok(r == S_OK, "file_defs[%d], %d: FolderItems::Item failed: %08x\n", i, j, r); > -todo_wine > ok(!!item, "file_defs[%d], %d: item is null\n", i, j); > - if (!item) continue; > > item2 = NULL; > r = FolderItems_Item(items, var, &item2); > @@ -572,7 +561,6 @@ todo_wine > V_I4(&var) = sizeof(file_defs)/sizeof(file_defs[0]); > item = (FolderItem*)0xdeadbeef; > r = FolderItems_Item(items, var, &item); > -todo_wine > ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > ok(!item, "item is not null\n"); > >

2 3

Re: [PATCH] kernel32: Improve tests for pUnregisterWait(0)
by Marvin 25 Aug '16

25 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25353 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: [PATCH] dinput: Add the 16-bit DLL version on acmGetVersion
by Bruno Jesus 24 Aug '16

24 Aug '16

Sorry, wrong subject. Sent a new one. On Wed, Aug 24, 2016 at 8:09 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Remove the annoying message when Wine is configured as 3.11. The DLL version 2.1 number was tested on Windows 3.11. > > Source for test: > http://alexa.pro.br/~bruno/wine/acm.c > > Compiled 16-bit EXE: > http://alexa.pro.br/~bruno/wine/acm.exe > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > --- > dlls/msacm32/msacm32_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/msacm32/msacm32_main.c b/dlls/msacm32/msacm32_main.c > index a47611c..efe58af 100644 > --- a/dlls/msacm32/msacm32_main.c > +++ b/dlls/msacm32/msacm32_main.c > @@ -84,6 +84,8 @@ DWORD WINAPI acmGetVersion(void) > switch (version.dwPlatformId) { > case VER_PLATFORM_WIN32_NT: > return 0x04000565; /* 4.0.1381 */ > + case VER_PLATFORM_WIN32s: > + return 0x02010000; /* 2.1 */ > default: > FIXME("%x not supported\n", version.dwPlatformId); > /* fall through */ > -- > 2.9.3 >

1 0

Re: [PATCH 4/4] msvcr90: Add _fpieee_flt tests
by Marvin 24 Aug '16

24 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25343 Your paranoid android. === wxppro (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w2003std (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === wvistau64 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w2008s64 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w7u (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w7pro64 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w8 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w864 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b === w1064 (32 bit msvcr90) === msvcr90.c:1784: Test failed: 1) Operand1.Format = b msvcr90.c:1784: Test failed: 3) Operand1.Format = b msvcr90.c:1784: Test failed: 4) Operand1.Format = b

1 0

Re: [PATCH] wined3d: Fix ATI1 buffer size, try 2
by Henri Verbeet 24 Aug '16

24 Aug '16

On 22 August 2016 at 18:53, Patrick Rudolph <siro(a)das-labor.org> wrote: > Apitrace crashes on WINE when trying to playback a trace containing ATI1 textures. > > Add a tests to show that "unknown" formats like ATI1 are backed by a buffer > of size pitch * height. Without the attaced fix the tests will crash. > > Calculate correct buffer size in wined3d_format_calculate_pitch for formats that > have WINED3DFMT_FLAG_BROKEN_PITCH flag set. > Remove no longer needed check in texture_resource_sub_resource_map. > > Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> > --- > dlls/d3d9/tests/device.c | 8 ++++++++ > dlls/wined3d/texture.c | 10 +--------- > dlls/wined3d/utils.c | 9 ++++++++- > 3 files changed, 17 insertions(+), 10 deletions(-) > This breaks the tests. For example: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:9512: Tests skipped: Card has unconditional NP2 support, skipping conditional NP2 tests visual.c:13651: Tests skipped: No NVDB (depth bounds test) support, skipping tests. visual.c:17111: Tests skipped: DXT5 volume textures are not supported, skipping test. visual.c:17966: Test failed: Got unexpected color 0x008080ff, case 2. visual.c:17966: Test failed: Got unexpected color 0x008080ff, case 3. visual.c:19801: Tests skipped: Volume ATI2N textures are not supported, skipping some tests. Makefile:276: recipe for target 'visual.ok' failed make: *** [visual.ok] Error 2

1 0

Re: [PATCH 2/7] d3d8/tests: Prefer higher resolutions in test_reset().
by Henri Verbeet 24 Aug '16

24 Aug '16

On 22 August 2016 at 14:53, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -21,6 +21,8 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#include <stdlib.h> > + > #define WINVER 0x0602 /* for CURSOR_SUPPRESSED */ This causes warnings from make crosstest for me: device.c:26:0: warning: "WINVER" redefined #define WINVER 0x0602 /* for CURSOR_SUPPRESSED */ ^ In file included from /usr/share/mingw-w64/include/crtdefs.h:10:0, from /usr/share/mingw-w64/include/stdlib.h:9, from device.c:24: /usr/share/mingw-w64/include/_mingw.h:225:0: note: this is the location of the previous definition #define WINVER 0x0502 ^

1 0

Re: ntoskrnl.exe: Implement ZwLoadDriver and ZwUnloadDriver based on services API.
by Sebastian Lackner 23 Aug '16

23 Aug '16

On 22.08.2016 16:12, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > This hides the complicated services API behind some easy to use functions :) > The timeout are a bit arbitrary and can be adjusted if they do not work well > enough in practice. Based on Arics feedback this solution is confirmed to work > for his purpose. > > dlls/ntoskrnl.exe/Makefile.in | 1 > dlls/ntoskrnl.exe/ntoskrnl.c | 164 ++++++++++++++++++++++++++++++++++++ > dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 4 > 3 files changed, 167 insertions(+), 2 deletions(-) Aric already signed off, but please ignore this patch. I am planning to send a new version shortly. The functions should also strip off the registry prefix.

1 0

Re: Adding binfmt configuration to official Wine packages
by Alex Henrie 23 Aug '16

23 Aug '16

2016-08-23 4:45 GMT-06:00 Rosanne DiMesio <dimesio(a)earthlink.net>: > On Mon, 22 Aug 2016 20:26:51 -0600 > Alex Henrie <alexhenrie24(a)gmail.com> wrote: > >> In fact, it's easy to >> forget that you have to explicitly give execution permissions to a >> downloaded file before Linux will let you execute it. If the file is >> on a USB drive, unless the drive has a Linux filesystem, the binary >> must be moved off of the drive before it can receive execution >> permissions. >> > > I have portable Firefox on a FAT32 formatted flash drive and Wine is able to run it. Wine will run any EXE as long as you start it (or your desktop environment starts it) with `wine foobar.exe`. If you start it with `./foobar.exe` instead, the file must be executable and binfmt must be set up correctly. Interestingly, it looks like Arch Linux and Ubuntu have both started to mount FAT32 filesystems with the "showexec" option. This makes EXE files on USB drives executable automatically. (It doesn't look very smart, it just turns on executability if the filename ends in ".exe".) So I stand corrected; you're right that it's no longer necessary to change the mount options or copy the EXE to another filesystem. Still, no desktop environment is going to execute files off of a USB drive without asking. -Alex

1 0

Adding binfmt configuration to official Wine packages
by Bruno Jesus 23 Aug '16

23 Aug '16

Hi, I would like to please call for attention on bug https://bugs.winehq.org/show_bug.cgi?id=39884 As far as I understand there are only benefits to users if we allow .exe files to run through binfmt, would it pose any kind of problem to add this configuration to our packages? Best wishes, Bruno

6 19

Re: [PATCH] Get the position from the driver on every GetCursorPos run
by Alexandre Julliard 23 Aug '16

23 Aug '16

Max Qian <public(a)maxqia.com> writes: > This reverts the GetCursorPos changes in commits 6576703 and f1a3480 to fix bug 24951. This is going to reintroduce the performance issues that the changes were supposed to fix. Doing a server round-trip on every GetCursorPos gives bad results in many apps. You'll need to find a fix that doesn't require this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [resend PATCH] ntdll: Tolerate null handle in DeregisterWait
by Bruno Jesus 23 Aug '16

23 Aug '16

On Fri, Aug 19, 2016 at 6:24 PM, Keno Fischer <keno(a)juliacomputing.com> wrote: Hi, is the subject supposed to be Tolerate NULL handle in UnregisterWait? > diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c > index a9a04df..44c6278 100644 > --- a/dlls/kernel32/tests/thread.c > +++ b/dlls/kernel32/tests/thread.c > @@ -1245,6 +1245,11 @@ static void test_RegisterWaitForSingleObject(void) > > ret = pUnregisterWait(wait_handle); > ok(ret, "UnregisterWait failed with error %d\n", GetLastError()); > + > + /* Test UnregisterWait null argument case */ > + ret = pUnregisterWait(0); > + ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, > + "UnregisterWait failed with unexpected error %d\n", GetLastError()); > } Please test ret and GetLastError separately as the rest of the code does most times. If you see other tests that test GetLastError you will notice that they call SetLastError before calling the tested function to ensure the error is not from a previous test. So add a SetLastError(0xdeadbeef) before the call to pUnregisterWait to ensure the ERROR_INVALID_HANDLE returned is from UnregisterWait. Also for consistency why not pUnregisterWait(NULL) instead of (0)?

3 2

Re: [PATCH] dinput: 0 is a valid fd (Coverity)
by Bruno Jesus 23 Aug '16

23 Aug '16

On Mon, Aug 22, 2016 at 6:19 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1371727 Resource leak > (will not happen in Wine, but it is valid) > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> This patch is superseeded by http://source.winehq.org/patches/data/125859

1 0

Re: dinput: Check the return of open() properly (Coverity)
by Bruno Jesus 22 Aug '16

22 Aug '16

On Mon, Aug 22, 2016 at 6:07 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> This patch is superseeded by http://source.winehq.org/patches/data/125859

1 0

Re: [PATCH] wined3d: Fix ATI1 buffer size, try 2
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25322 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH v8 1/3] shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.
by Sebastian Lackner 22 Aug '16

22 Aug '16

On 19.08.2016 11:43, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > v8 initializes V_ERROR(&var), item, item2, and i correctly. It also adds > checks that the test files were created and written successfully. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/tests/Makefile.in | 2 +- > dlls/shell32/tests/shelldispatch.c | 229 +++++++++++++++++++++++++++++++++++-- > 2 files changed, 219 insertions(+), 12 deletions(-) > I think this patch is unfortunately still a bit too noisy to be applied separately. If you want to keep the "bruteforce" tests I would suggest to move the implementation into the first patch, or alternatively change the FIXME to a TRACE. Besides that I am basically fine, although there are probably some ways how to improve the code style a bit further. Regards, Sebastian

2 2

Re: [PATCH v8 3/3] shell32: Implement FolderItems_get_Count.
by Sebastian Lackner 22 Aug '16

22 Aug '16

On 19.08.2016 11:43, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shelldispatch.c | 10 ++++++++-- > dlls/shell32/tests/shelldispatch.c | 6 ------ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c > index a456ad4..86b77d6 100644 > --- a/dlls/shell32/shelldispatch.c > +++ b/dlls/shell32/shelldispatch.c > @@ -1061,9 +1061,15 @@ static HRESULT WINAPI FolderItemsImpl_Invoke(FolderItems3 *iface, > > static HRESULT WINAPI FolderItemsImpl_get_Count(FolderItems3 *iface, LONG *count) > { > - FIXME("(%p,%p)\n", iface, count); > + FolderItemsImpl *This = impl_from_FolderItems(iface); > > - return E_NOTIMPL; > + TRACE("(%p,%p)\n", iface, count); > + > + if (!count) > + return E_INVALIDARG; The tests contain a comment which suggests that Windows does not do such checks. If this is true I would suggest to simplify it also here in your implementation. > + > + *count = This->item_count; > + return S_OK; > } > > static HRESULT WINAPI FolderItemsImpl_get_Application(FolderItems3 *iface, IDispatch **ppid) > diff --git a/dlls/shell32/tests/shelldispatch.c b/dlls/shell32/tests/shelldispatch.c > index dc4fda4..42cfbf7 100644 > --- a/dlls/shell32/tests/shelldispatch.c > +++ b/dlls/shell32/tests/shelldispatch.c > @@ -378,9 +378,7 @@ static void test_items(void) > r = FolderItems_get_Count(items, NULL); > > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(!lcount, "expected 0 files, got %d\n", lcount); > > V_VT(&var) = VT_I4; > @@ -435,9 +433,7 @@ todo_wine > > lcount = -1; > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(!lcount, "expected 0 files, got %d\n", lcount); > FolderItems_Release(items); > > @@ -455,9 +451,7 @@ todo_wine > > lcount = -1; > r = FolderItems_get_Count(items, &lcount); > -todo_wine > ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > -todo_wine > ok(lcount == sizeof(file_defs)/sizeof(file_defs[0]), > "expected %d files, got %d\n", sizeof(file_defs)/sizeof(file_defs[0]), lcount); > >

2 1

Re: [PATCH 3/3] wpc: Register WindowsParentalControls class.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25317 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [PATCH 2/3] wpc: Added basic tests.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25316 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [PATCH 7/7] d3d9: Forbid display mode and back buffer mismatch in IDirect3DDevice9Ex_ResetEx().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25314 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2828: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2830: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2828: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2830: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2828: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2830: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2828: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2830: Test failed: Got unexpected hr 0, i=1.

1 0

Re: [PATCH 6/7] d3d9: Allow passing "mode" to IDirect3DDevice9Ex_ResetEx() iff "Windowed" is FALSE.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25313 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=1.

1 0

Re: [PATCH 5/7] d3d9/tests: Add test for IDirect3DDevice9Ex_ResetEx().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25312 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2817: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2819: Test failed: Got unexpected hr 0, i=1.

1 0

Re: [PATCH 4/7] d3d9/tests: Restore display rotation in test_get_adapter_displaymode_ex().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25311 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2414: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2416: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2414: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2416: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2414: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2416: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2414: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2416: Test failed: Got unexpected hr 0, i=1.

1 0

Re: [PATCH 4/4 v2] d3d11: Add tests for WINED3DFMT_BC6H_UF16/SF16 formats.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25307 Your paranoid android. === wvistau64 (64 bit d3d11) === The test timed out

2 1

Re: [PATCH resend 3/7] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25310 Your paranoid android. === w8 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2795: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2800: Test failed: The focus window is active. device.c:2808: Test failed: Got unexpected hr 0x88760869. device.c:2812: Test failed: Got unexpect screen size 800x600. device.c:2827: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2836: Test failed: Got unexpect screen size 800x600. device.c:2849: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2857: Test failed: Got unexpect width 640. device.c:2858: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 2/7] d3d8/tests: Prefer higher resolutions in test_reset().
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25309 Your paranoid android. === w8 (32 bit device) === device.c:2747: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2752: Test failed: The focus window is active. device.c:2760: Test failed: Got unexpected hr 0x88760869. device.c:2764: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2788: Test failed: Got unexpect screen size 800x600. device.c:2801: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2809: Test failed: Got unexpect width 640. device.c:2810: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2747: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2752: Test failed: The focus window is active. device.c:2760: Test failed: Got unexpected hr 0x88760869. device.c:2764: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2788: Test failed: Got unexpect screen size 800x600. device.c:2801: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2809: Test failed: Got unexpect width 640. device.c:2810: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2747: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2752: Test failed: The focus window is active. device.c:2760: Test failed: Got unexpected hr 0x88760869. device.c:2764: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2788: Test failed: Got unexpect screen size 800x600. device.c:2801: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2809: Test failed: Got unexpect width 640. device.c:2810: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/7] d3d8/tests: Skip test_reset() when device is initially lost.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25308 Your paranoid android. === w8 (32 bit device) === device.c:2731: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2736: Test failed: The focus window is active. device.c:2744: Test failed: Got unexpected hr 0x88760869. device.c:2748: Test failed: Got unexpect screen size 800x600. device.c:2763: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2772: Test failed: Got unexpect screen size 800x600. device.c:2785: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2793: Test failed: Got unexpect width 640. device.c:2794: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:2731: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2736: Test failed: The focus window is active. device.c:2744: Test failed: Got unexpected hr 0x88760869. device.c:2748: Test failed: Got unexpect screen size 800x600. device.c:2763: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2772: Test failed: Got unexpect screen size 800x600. device.c:2785: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2793: Test failed: Got unexpect width 640. device.c:2794: Test failed: Got unexpect height 480.

1 0

Re: [PATCH] d3dx10/tests: Basic tests for async loaders
by Matteo Bruni 22 Aug '16

22 Aug '16

2016-08-18 19:45 GMT+02:00 Nikolay Sivov <nsivov(a)codeweavers.com>: > diff --git a/include/d3d10.idl b/include/d3d10.idl > index 0ab6ab3..24fd2bf 100644 > --- a/include/d3d10.idl > +++ b/include/d3d10.idl > @@ -242,7 +242,7 @@ const unsigned int D3D_SPEC_DATE_YEAR > cpp_quote("#endif") > > const unsigned int D3D10_APPEND_ALIGNED_ELEMENT = 0xffffffff; > -const unsigned int _FACD3D10 = 0x87; > +const unsigned int _FACD3D10 = 0x879; > const unsigned int _FACD3D10DEBUG = _FACD3D10 + 1; > const unsigned int D3D10_FILTER_TYPE_MASK = 0x3; > const unsigned int D3D10_SDK_VERSION = 29; Can you please send this chunk separately? I'll send a fixed up version of the rest later on.

2 1

Re: [PATCH 1/4] wined3d: Add support for WINED3DFMT_BC7_UNORM format.
by Henri Verbeet 22 Aug '16

22 Aug '16

On 21 August 2016 at 11:18, Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > For bug 40997. > For what it's worth, these seem fine once the corresponding tests are fixed.

1 0

Re: [PATCH] wined3d: Fix ATI1 buffer size
by Henri Verbeet 22 Aug '16

22 Aug '16

On 19 August 2016 at 14:51, Patrick Rudolph <siro(a)das-labor.org> wrote: > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index fbafa14..a163ed9 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -7141,6 +7141,12 @@ static void test_lockrect_offset(void) > ok(locked_rect.Pitch == expected_pitch, "Got unexpected pitch %d for format %s, expected %d.\n", > locked_rect.Pitch, dxt_formats[i].name, expected_pitch); > > + /* Make sure that for "unknown" formats like ATIx the buffer has a > + * size of pitch * height bytes */ > + if ((dxt_formats[i].format == MAKEFOURCC('A','T','I','1')) || > + (dxt_formats[i].format == MAKEFOURCC('A','T','I','2'))) > + memset(base, 0, expected_pitch * 128); > + > hr = IDirect3DSurface9_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > Well, this passes here on its own, albeit with minor memory corruption, so doesn't make for a very convincing test. Would adding these to test_miptree_layout() work? > + /* For "unknown" formats like ATIx the pitch equals width. */ > + if (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_BROKEN_PITCH) > + { > + *row_pitch = width; > + *slice_pitch = *row_pitch * height; > + } The comment needs some work. If the test ends up working out, and this turns out to be the right place to do this, there are a couple of other places that explicitly handle WINED3DFMT_FLAG_BROKEN_PITCH now that may no longer need to if we handle it here.

1 0

Re: [PATCH] d3dx9/test: Add TextureShader GetConstantBuffer tests
by Matteo Bruni 22 Aug '16

22 Aug '16

2016-08-17 8:53 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > + hr = D3DXCreateTextureShader(texture_noise, &shader); > + ok(hr == S_OK, "got %08x\n", hr); > + if(hr == S_OK) > + { > + ID3DXBuffer *buffer = NULL; > + > + hr = shader->lpVtbl->GetConstantBuffer(shader, &buffer); > + todo_wine ok(hr == S_OK, "got %08x\n", hr); > + if(hr == S_OK) > + { > + int size = ID3DXBuffer_GetBufferSize(buffer); > + ok(size == 16, "GetBufferSize failed, got %u\n", size); Do you know what the returned buffer is supposed to be? Dumping the contents seems to suggest arbitrary (but not random) stack data.

2 1

Re: [PATCH 4/4] user32: Scale the button size with screen resolution.
by Dmitry Timoshkov 22 Aug '16

22 Aug '16

Huw Davies <huw(a)codeweavers.com> wrote: > + checkBoxWidth = 12 * GetDeviceCaps( hDC, LOGPIXELSX ) / 96 + 1; > + checkBoxHeight = 12 * GetDeviceCaps( hDC, LOGPIXELSY ) / 96 + 1; Are you sure that user32 is really supposed to scale the buttons? Could that be that it's only new comctl32 implementation should do this kind of thing? Scaling the buttons has the potential of completely distorting the dialog layout, and I really would like to see some tests for this behaviour (even a standalone application would be acceptable). -- Dmitry.

2 2

Re: [PATCH 3/4] d3d11: Add tests for WINED3DFMT_BC7_UNORM format.
by Marvin 22 Aug '16

22 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25292 Your paranoid android. === wvistau64 (32 bit d3d11) === d3d11.c:5917: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 27: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 27: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 28: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 28: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 3). === w2008s64 (32 bit d3d11) === d3d11.c:5917: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 27: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 27: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 28: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 28: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 3). === w7u (32 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w7pro64 (32 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w8 (32 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w864 (32 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w1064 (32 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === wvistau64 (64 bit d3d11) === d3d11.c:5917: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 27: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 27: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 28: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 28: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 3). === w2008s64 (64 bit d3d11) === d3d11.c:5917: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 27: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 27: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 27: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5917: Test failed: Test 28: Failed to create 2d texture, hr 0x80070057. d3d11.c:5920: Test failed: Test 28: Failed to create shader resource view, hr 0x80070057. d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0x00000000 at (3, 3). === w7pro64 (64 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w864 (64 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3). === w1064 (64 bit d3d11) === d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 17: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5963: Test failed: Test 28: Got unexpected color 0xfffa0000 at (1, 3).

3 2

Re: [PATCH] ntdll: improve heap allocation performance
by Alex Henrie 22 Aug '16

22 Aug '16

Would it be possible to split this patch up into a series of smaller patches, each offering a small benefit on its own? -Alex

1 0

Wine dinput changes
by Bruno Jesus 21 Aug '16

21 Aug '16

Hi all. In order to reduce parallel work/waste of time I'm just passing to say that I'm working on dinput. I found some problems related to force feedback and also found Elias Vanderstuyft very interesting email [1]. I'm also working on reduce A/W function code duplication and better tracing. In the end I'm thinking about borrowing a mac to sync the changes in osx. I also thought about rewriting the winejoystick.drv using dinput and finally adding support to FreeBSD but I'm waiting for the longer moves about the HID and minidriver stuff. [1] https://www.winehq.org/pipermail/wine-devel/2014-March/103280.html Best regards, Bruno

1 0

Re: [PATCH 4/4 resend] d3d11: Add tests for WINED3DFMT_BC6H_UF16/SF16 formats.
by Marvin 21 Aug '16

21 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25293 Your paranoid android. === wvistau64 (32 bit d3d11) === d3d11.c:5937: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 18: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 18: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 19: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 19: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 29: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 29: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 30: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 30: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 31: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 31: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 32: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 32: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 3). === w2008s64 (32 bit d3d11) === d3d11.c:5937: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 18: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 18: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 19: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 19: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 29: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 29: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 30: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 30: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 31: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 31: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 32: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 32: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 3). === w7u (32 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w7pro64 (32 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w8 (32 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w864 (32 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w1064 (32 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === wvistau64 (64 bit d3d11) === d3d11.c:5937: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 18: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 18: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 19: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 19: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 29: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 29: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 30: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 30: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 31: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 31: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 32: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 32: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 3). === w2008s64 (64 bit d3d11) === d3d11.c:5937: Test failed: Test 16: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 16: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 16: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 17: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 17: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 17: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 18: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 18: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 19: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 19: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 29: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 29: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 29: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 30: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 30: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 30: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 31: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 31: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 31: Got unexpected color 0x00000000 at (3, 3). d3d11.c:5937: Test failed: Test 32: Failed to create 2d texture, hr 0x80070057. d3d11.c:5940: Test failed: Test 32: Failed to create shader resource view, hr 0x80070057. d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (2, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0x00000000 at (3, 3). === w7pro64 (64 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w864 (64 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3). === w1064 (64 bit d3d11) === d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 19: Got unexpected color 0xfffa0000 at (1, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 0). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (0, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff0000fa at (1, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (2, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xff00fa00 at (3, 1). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 2). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (0, 3). d3d11.c:5983: Test failed: Test 32: Got unexpected color 0xfffa0000 at (1, 3).

1 0

amazing new stuff
by Susan Cragin 21 Aug '16

21 Aug '16

Dear friend! I've found that store with a lot of amazing new stuff, just take a look, you'll love it <http://phethachyru.lapointeonline.com/lnhcax> Sent from a prehistoric stone tablet, Susan Cragin

1 0

Re: [PATCH 05/13] wineplugplay.sys: Common function to check if a bus is enabled
by Sebastian Lackner 21 Aug '16

21 Aug '16

On 17.08.2016 15:36, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/wineplugplay.sys/Makefile.in | 1 + > dlls/wineplugplay.sys/bus_hid_common.c | 65 ++++++++++++++++++++++++++++++++++ > 2 files changed, 66 insertions(+) > create mode 100644 dlls/wineplugplay.sys/bus_hid_common.c > Is it intentional that this patch does not contain any include file changes? Not sure if Alexandre agrees, but I personally think it might be useful to merge patches 5-7. When added separately they are basically dead code, and its difficult to review them without a usage example. Regards, Sebastian

3 2

Re: [PATCH 04/13] Configuration changes for linux udev
by Sebastian Lackner 21 Aug '16

21 Aug '16

On 17.08.2016 15:36, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > configure | 110 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 13 +++++++ > include/config.h.in | 6 +++ > 3 files changed, 129 insertions(+) > You will also have to add a AC_ARG_WITH() line at the beginning to define the supported command line argument. I would also suggest to merge this into the later patch where it is actually used. If you want to keep it separate, the subject should probably be changed to "configure: Add detection for linux udev." or similar. Regards, Sebastian

1 0

Re: ntdll: Do not call group cancel callback for finished simple callbacks. (v2)
by Marvin 20 Aug '16

20 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25289 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/7] ntdll/tests: Use longer waits to reduce risk of random failures on the testbot.
by Marvin 20 Aug '16

20 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25284 Your paranoid android. === w7u (32 bit threadpool) === threadpool.c:367: Test failed: WaitForSingleObject returned 258 threadpool.c:379: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:390: Test failed: expected info.userdata = 0x10000, got 0 threadpool.c:409: Test failed: expected info.userdata = 1, got 0 threadpool.c:422: Test failed: expected info.userdata = 1, got 0 threadpool.c:424: Test failed: expected STATUS_PENDING, got 0 threadpool.c:427: Test failed: WaitForSingleObject returned 258 === w864 (64 bit threadpool) === threadpool.c:1618: Test failed: WaitForSingleObject returned 258 threadpool.c:1619: Test failed: expected result 2, got 0 threadpool.c:1619: Test failed: expected result 4, got 2 threadpool.c:1619: Test failed: expected result 6, got 4 threadpool.c:1619: Test failed: expected result 8, got 6 threadpool.c:1619: Test failed: expected result 10, got 8 threadpool.c:1619: Test failed: expected result 12, got 10 threadpool.c:1619: Test failed: expected result 14, got 12 threadpool.c:1619: Test failed: expected result 16, got 14 threadpool.c:1619: Test failed: expected result 18, got 16 threadpool.c:1619: Test failed: expected result 20, got 18 threadpool.c:1619: Test failed: expected result 22, got 20 threadpool.c:1619: Test failed: expected result 24, got 22 threadpool.c:1619: Test failed: expected result 26, got 24 threadpool.c:1619: Test failed: expected result 28, got 26 threadpool.c:1619: Test failed: expected result 30, got 28 threadpool.c:1619: Test failed: expected result 32, got 30 threadpool.c:1619: Test failed: expected result 34, got 32 threadpool.c:1619: Test failed: expected result 36, got 34 threadpool.c:1619: Test failed: expected result 38, got 36 threadpool.c:1619: Test failed: expected result 40, got 38 threadpool.c:1619: Test failed: expected result 42, got 40 threadpool.c:1619: Test failed: expected result 44, got 42 threadpool.c:1619: Test failed: expected result 46, got 44 threadpool.c:1619: Test failed: expected result 48, got 46 threadpool.c:1619: Test failed: expected result 50, got 48 threadpool.c:1619: Test failed: expected result 52, got 50 threadpool.c:1619: Test failed: expected result 54, got 52 threadpool.c:1619: Test failed: expected result 56, got 54 threadpool.c:1619: Test failed: expected result 58, got 56 threadpool.c:1619: Test failed: expected result 60, got 58 threadpool.c:1619: Test failed: expected result 62, got 60 threadpool.c:1619: Test failed: expected result 64, got 62 threadpool.c:1619: Test failed: expected result 66, got 64 threadpool.c:1619: Test failed: expected result 68, got 66 threadpool.c:1619: Test failed: expected result 70, got 68 threadpool.c:1619: Test failed: expected result 72, got 70 threadpool.c:1619: Test failed: expected result 74, got 72 threadpool.c:1619: Test failed: expected result 76, got 74 threadpool.c:1619: Test failed: expected result 78, got 76 threadpool.c:1619: Test failed: expected result 80, got 78 threadpool.c:1619: Test failed: expected result 82, got 80 threadpool.c:1619: Test failed: expected result 84, got 82 threadpool.c:1619: Test failed: expected result 86, got 84 threadpool.c:1619: Test failed: expected result 88, got 86 threadpool.c:1619: Test failed: expected result 90, got 88 threadpool.c:1619: Test failed: expected result 92, got 90 threadpool.c:1619: Test failed: expected result 94, got 92 threadpool.c:1619: Test failed: expected result 96, got 94 threadpool.c:1619: Test failed: expected result 98, got 96 threadpool.c:1619: Test failed: expected result 100, got 98 threadpool.c:1619: Test failed: expected result 102, got 100 threadpool.c:1619: Test failed: expected result 104, got 102 threadpool.c:1619: Test failed: expected result 106, got 104 threadpool.c:1619: Test failed: expected result 108, got 106 threadpool.c:1619: Test failed: expected result 110, got 108 threadpool.c:1619: Test failed: expected result 112, got 110 threadpool.c:1619: Test failed: expected result 114, got 112 threadpool.c:1619: Test failed: expected result 116, got 114 threadpool.c:1619: Test failed: expected result 118, got 116 threadpool.c:1619: Test failed: expected result 120, got 118 threadpool.c:1619: Test failed: expected result 122, got 120 threadpool.c:1619: Test failed: expected result 124, got 122 threadpool.c:1619: Test failed: expected result 126, got 124 threadpool.c:1619: Test failed: expected result 128, got 126 threadpool.c:1619: Test failed: expected result 130, got 128 threadpool.c:1619: Test failed: expected result 132, got 130 threadpool.c:1619: Test failed: expected result 134, got 132 threadpool.c:1619: Test failed: expected result 136, got 134 threadpool.c:1619: Test failed: expected result 138, got 136 threadpool.c:1619: Test failed: expected result 140, got 138 threadpool.c:1619: Test failed: expected result 142, got 140 threadpool.c:1619: Test failed: expected result 144, got 142 threadpool.c:1619: Test failed: expected result 146, got 144 threadpool.c:1619: Test failed: expected result 148, got 146 threadpool.c:1619: Test failed: expected result 150, got 148 threadpool.c:1619: Test failed: expected result 152, got 150 threadpool.c:1619: Test failed: expected result 154, got 152 threadpool.c:1619: Test failed: expected result 156, got 154 threadpool.c:1619: Test failed: expected result 158, got 156 threadpool.c:1619: Test failed: expected result 160, got 158 threadpool.c:1619: Test failed: expected result 162, got 160 threadpool.c:1619: Test failed: expected result 164, got 162 threadpool.c:1619: Test failed: expected result 166, got 164 threadpool.c:1619: Test failed: expected result 168, got 166 threadpool.c:1619: Test failed: expected result 170, got 168 threadpool.c:1619: Test failed: expected result 172, got 170 threadpool.c:1619: Test failed: expected result 174, got 172 threadpool.c:1619: Test failed: expected result 176, got 174 threadpool.c:1619: Test failed: expected result 178, got 176 threadpool.c:1619: Test failed: expected result 180, got 178 threadpool.c:1619: Test failed: expected result 182, got 180 threadpool.c:1619: Test failed: expected result 184, got 182 threadpool.c:1619: Test failed: expected result 186, got 184 threadpool.c:1619: Test failed: expected result 188, got 186 threadpool.c:1619: Test failed: expected result 190, got 188 threadpool.c:1619: Test failed: expected result 192, got 190 threadpool.c:1619: Test failed: expected result 194, got 192 threadpool.c:1619: Test failed: expected result 196, got 194 threadpool.c:1619: Test failed: expected result 198, got 196 threadpool.c:1619: Test failed: expected result 200, got 198 threadpool.c:1619: Test failed: expected result 202, got 200 threadpool.c:1619: Test failed: expected result 204, got 202 threadpool.c:1619: Test failed: expected result 206, got 204 threadpool.c:1619: Test failed: expected result 208, got 206 threadpool.c:1619: Test failed: expected result 210, got 208 threadpool.c:1619: Test failed: expected result 212, got 210 threadpool.c:1619: Test failed: expected result 214, got 212 threadpool.c:1619: Test failed: expected result 216, got 214 threadpool.c:1619: Test failed: expected result 218, got 216 threadpool.c:1619: Test failed: expected result 220, got 218 threadpool.c:1619: Test failed: expected result 222, got 220 threadpool.c:1619: Test failed: expected result 224, got 222 threadpool.c:1619: Test failed: expected result 226, got 224 threadpool.c:1619: Test failed: expected result 228, got 226 threadpool.c:1619: Test failed: expected result 230, got 228 threadpool.c:1619: Test failed: expected result 232, got 230 threadpool.c:1619: Test failed: expected result 234, got 232 threadpool.c:1619: Test failed: expected result 236, got 234 threadpool.c:1619: Test failed: expected result 238, got 236 threadpool.c:1619: Test failed: expected result 240, got 238 threadpool.c:1619: Test failed: expected result 242, got 240 threadpool.c:1619: Test failed: expected result 244, got 242 threadpool.c:1619: Test failed: expected result 246, got 244 threadpool.c:1619: Test failed: expected result 248, got 246 threadpool.c:1619: Test failed: expected result 250, got 248 threadpool.c:1619: Test failed: expected result 252, got 250 threadpool.c:1619: Test failed: expected result 254, got 252 threadpool.c:1619: Test failed: expected result 256, got 254 threadpool.c:1619: Test failed: expected result 258, got 256 threadpool.c:1619: Test failed: expected result 260, got 258 threadpool.c:1619: Test failed: expected result 262, got 260 threadpool.c:1619: Test failed: expected result 264, got 262 threadpool.c:1619: Test failed: expected result 266, got 264 threadpool.c:1619: Test failed: expected result 268, got 266 threadpool.c:1619: Test failed: expected result 270, got 268 threadpool.c:1619: Test failed: expected result 272, got 270 threadpool.c:1619: Test failed: expected result 274, got 272 threadpool.c:1619: Test failed: expected result 276, got 274 threadpool.c:1619: Test failed: expected result 278, got 276 threadpool.c:1619: Test failed: expected result 280, got 278 threadpool.c:1619: Test failed: expected result 282, got 280 threadpool.c:1619: Test failed: expected result 284, got 282 threadpool.c:1619: Test failed: expected result 286, got 284 threadpool.c:1619: Test failed: expected result 288, got 286 threadpool.c:1619: Test failed: expected result 290, got 288 threadpool.c:1619: Test failed: expected result 292, got 290 threadpool.c:1619: Test failed: expected result 294, got 292 threadpool.c:1619: Test failed: expected result 296, got 294 threadpool.c:1619: Test failed: expected result 298, got 296 threadpool.c:1619: Test failed: expected result 300, got 298 threadpool.c:1619: Test failed: expected result 302, got 300 threadpool.c:1619: Test failed: expected result 304, got 302 threadpool.c:1619: Test failed: expected result 306, got 304 threadpool.c:1619: Test failed: expected result 308, got 306 threadpool.c:1619: Test failed: expected result 310, got 308 threadpool.c:1619: Test failed: expected result 312, got 310 threadpool.c:1619: Test failed: expected result 314, got 312 threadpool.c:1619: Test failed: expected result 316, got 314 threadpool.c:1619: Test failed: expected result 318, got 316 threadpool.c:1619: Test failed: expected result 320, got 318 threadpool.c:1619: Test failed: expected result 322, got 320 threadpool.c:1619: Test failed: expected result 324, got 322 threadpool.c:1619: Test failed: expected result 326, got 324 threadpool.c:1619: Test failed: expected result 328, got 326 threadpool.c:1619: Test failed: expected result 330, got 328 threadpool.c:1619: Test failed: expected result 332, got 330 threadpool.c:1619: Test failed: expected result 334, got 332 threadpool.c:1619: Test failed: expected result 336, got 334 threadpool.c:1619: Test failed: expected result 338, got 336 threadpool.c:1619: Test failed: expected result 340, got 338 threadpool.c:1619: Test failed: expected result 342, got 340 threadpool.c:1619: Test failed: expected result 344, got 342 threadpool.c:1619: Test failed: expected result 346, got 344 threadpool.c:1619: Test failed: expected result 348, got 346 threadpool.c:1619: Test failed: expected result 350, got 348 threadpool.c:1619: Test failed: expected result 352, got 350 threadpool.c:1619: Test failed: expected result 354, got 352 threadpool.c:1619: Test failed: expected result 356, got 354 threadpool.c:1619: Test failed: expected result 358, got 356 threadpool.c:1619: Test failed: expected result 360, got 358 threadpool.c:1619: Test failed: expected result 362, got 360 threadpool.c:1619: Test failed: expected result 364, got 362 threadpool.c:1619: Test failed: expected result 366, got 364 threadpool.c:1619: Test failed: expected result 368, got 366 threadpool.c:1619: Test failed: expected result 370, got 368 threadpool.c:1619: Test failed: expected result 372, got 370 threadpool.c:1619: Test failed: expected result 374, got 372 threadpool.c:1619: Test failed: expected result 376, got 374 threadpool.c:1619: Test failed: expected result 378, got 376 threadpool.c:1619: Test failed: expected result 380, got 378 threadpool.c:1619: Test failed: expected result 382, got 380 threadpool.c:1619: Test failed: expected result 384, got 382 threadpool.c:1619: Test failed: expected result 386, got 384 threadpool.c:1619: Test failed: expected result 388, got 386 threadpool.c:1619: Test failed: expected result 390, got 388 threadpool.c:1619: Test failed: expected result 392, got 390 threadpool.c:1619: Test failed: expected result 394, got 392 threadpool.c:1619: Test failed: expected result 396, got 394 threadpool.c:1619: Test failed: expected result 398, got 396 threadpool.c:1619: Test failed: expected result 400, got 398 threadpool.c:1619: Test failed: expected result 402, got 400 threadpool.c:1619: Test failed: expected result 404, got 402 threadpool.c:1619: Test failed: expected result 406, got 404 threadpool.c:1619: Test failed: expected result 408, got 406 threadpool.c:1619: Test failed: expected result 410, got 408 threadpool.c:1619: Test failed: expected result 412, got 410 threadpool.c:1619: Test failed: expected result 414, got 412 threadpool.c:1619: Test failed: expected result 416, got 414 threadpool.c:1619: Test failed: expected result 418, got 416 threadpool.c:1619: Test failed: expected result 420, got 418 threadpool.c:1619: Test failed: expected result 422, got 420 threadpool.c:1619: Test failed: expected result 424, got 422 threadpool.c:1619: Test failed: expected result 426, got 424 threadpool.c:1619: Test failed: expected result 428, got 426 threadpool.c:1619: Test failed: expected result 430, got 428 threadpool.c:1619: Test failed: expected result 432, got 430 threadpool.c:1619: Test failed: expected result 434, got 432 threadpool.c:1619: Test failed: expected result 436, got 434 threadpool.c:1619: Test failed: expected result 438, got 436 threadpool.c:1619: Test failed: expected result 440, got 438 threadpool.c:1619: Test failed: expected result 442, got 440 threadpool.c:1619: Test failed: expected result 444, got 442 threadpool.c:1619: Test failed: expected result 446, got 444 threadpool.c:1619: Test failed: expected result 448, got 446 threadpool.c:1619: Test failed: expected result 450, got 448 threadpool.c:1619: Test failed: expected result 452, got 450 threadpool.c:1619: Test failed: expected result 454, got 452 threadpool.c:1619: Test failed: expected result 456, got 454 threadpool.c:1619: Test failed: expected result 458, got 456 threadpool.c:1619: Test failed: expected result 460, got 458 threadpool.c:1619: Test failed: expected result 462, got 460 threadpool.c:1619: Test failed: expected result 464, got 462 threadpool.c:1619: Test failed: expected result 466, got 464 threadpool.c:1619: Test failed: expected result 468, got 466 threadpool.c:1619: Test failed: expected result 470, got 468 threadpool.c:1619: Test failed: expected result 472, got 470 threadpool.c:1619: Test failed: expected result 474, got 472 threadpool.c:1619: Test failed: expected result 476, got 474 threadpool.c:1619: Test failed: expected result 478, got 476 threadpool.c:1619: Test failed: expected result 480, got 478 threadpool.c:1619: Test failed: expected result 482, got 480 threadpool.c:1619: Test failed: expected result 483, got 482

2 1

Re: [PATCH renamed] Add a bunch of api-ms dlls that I was too lazy to commit earlier
by Sebastian Lackner 20 Aug '16

20 Aug '16

On 20.08.2016 07:16, Max Qian wrote: > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > configure | 16 ++++++++++++++++ > configure.ac | 8 ++++++++ > dlls/api-ms-win-core-job-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-job-l1-1-0.spec | 1 + > dlls/api-ms-win-core-job-l2-1-0/Makefile.in | 1 + > .../api-ms-win-core-job-l2-1-0.spec | 6 ++++++ > dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-namespace-l1-1-0.spec | 6 ++++++ > dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-normalization-l1-1-0.spec | 5 +++++ > dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-string-obsolete-l1-1-0.spec | 10 ++++++++++ > dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-toolhelp-l1-1-0.spec | 7 +++++++ > dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in | 1 + > .../api-ms-win-eventlog-legacy-l1-1-0.spec | 6 ++++++ > dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in | 1 + > .../api-ms-win-shell-shellfolders-l1-1-0.spec | 14 ++++++++++++++ > tools/make_specfiles | 6 ++++++ > 19 files changed, 93 insertions(+) > create mode 100644 dlls/api-ms-win-core-job-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-job-l2-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec > create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec > create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec > create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec You will have to split this patch and give each part a meaningful title like: "api-ms-win-core-job-l1-1-0: Add dll." Also, there is no need to explain why you didn't send it earlier, especially not in the subject which will be used as commit message. While reworking the patch, please also remove the hand written comments in the spec files. When you know that api-ms-win-core-namespace-l1-1-0 forwards to kernel32 for example, it is better to add that to ./tools/make_specfiles instead of hoping someone will find the comments later and update it manually. The same also applies to api-ms-win-core-normalization-l1-1-0. Regards, Sebastian

1 0

Re: [resend PATCH] ntdll: Tolerate null handle in DeregisterWait
by Marvin 20 Aug '16

20 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25273 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE) === w1064 (64 bit thread) === The test timed out

1 0

Re: [PATCH 1/3] kernel32/tests: Add test for library load order
by Dmitry Timoshkov 20 Aug '16

20 Aug '16

Daniel Lehman <dlehman(a)esri.com> wrote: > creates several temp directories with dynamically created main.dll and dep.dll dependency > dlls are loaded and the resulting loaded path and dependency path are checked > the search path is altered using several methods to see how behavior changes Please consider merging the tests into existing loader.c test suite where creation of PE images already implemented and automated. This should considerably simplify new tests, and reduce the patch size. -- Dmitry.

1 0

Re: Add a simple 3D APIs demo
by Aaryaman Vasishta 19 Aug '16

19 Aug '16

Hi, On Sat, Aug 20, 2016 at 1:11 AM, Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > > create mode 100644 programs/3d-demo/winehq_logo_glass.png > FWIW, It's probably not a good idea to include images in a commit unless it's absolutely necessary. I will let the reviewers comment on this, though. Cheers, Aaryaman

1 0

Re: [PATCH] Add a bunch of dlls that I was too lazy to commit earlier
by Austin English 19 Aug '16

19 Aug '16

On Aug 19, 2016 7:03 AM, "Max Qian" <public(a)maxqia.com> wrote: > > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > configure | 16 ++++++++++++++++ > configure.ac | 8 ++++++++ > dlls/api-ms-win-core-job-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-job-l1-1-0.spec | 1 + > dlls/api-ms-win-core-job-l2-1-0/Makefile.in | 1 + > .../api-ms-win-core-job-l2-1-0.spec | 6 ++++++ > dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-namespace-l1-1-0.spec | 6 ++++++ > dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-normalization-l1-1-0.spec | 5 +++++ > dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-string-obsolete-l1-1-0.spec | 10 ++++++++++ > dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in | 1 + > .../api-ms-win-core-toolhelp-l1-1-0.spec | 7 +++++++ > dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in | 1 + > .../api-ms-win-eventlog-legacy-l1-1-0.spec | 6 ++++++ > dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in | 1 + > .../api-ms-win-shell-shellfolders-l1-1-0.spec | 14 ++++++++++++++ > tools/make_specfiles | 6 ++++++ > 19 files changed, 93 insertions(+) > create mode 100644 dlls/api-ms-win-core-job-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-job-l2-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec > create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec > create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec > create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec > create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in > create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec > > diff --git a/configure b/configure > index dccacb4..2dbf835 100755 > --- a/configure > +++ b/configure > @@ -896,6 +896,8 @@ enable_api_ms_win_core_heap_obsolete_l1_1_0 > enable_api_ms_win_core_interlocked_l1_1_0 > enable_api_ms_win_core_interlocked_l1_2_0 > enable_api_ms_win_core_io_l1_1_1 > +enable_api_ms_win_core_job_l1_1_0 > +enable_api_ms_win_core_job_l2_1_0 > enable_api_ms_win_core_kernel32_legacy_l1_1_0 > enable_api_ms_win_core_kernel32_legacy_l1_1_1 > enable_api_ms_win_core_libraryloader_l1_1_0 > @@ -912,6 +914,8 @@ enable_api_ms_win_core_memory_l1_1_2 > enable_api_ms_win_core_misc_l1_1_0 > enable_api_ms_win_core_namedpipe_l1_1_0 > enable_api_ms_win_core_namedpipe_l1_2_0 > +enable_api_ms_win_core_namespace_l1_1_0 > +enable_api_ms_win_core_normalization_l1_1_0 > enable_api_ms_win_core_path_l1_1_0 > enable_api_ms_win_core_processenvironment_l1_1_0 > enable_api_ms_win_core_processenvironment_l1_2_0 > @@ -926,6 +930,7 @@ enable_api_ms_win_core_rtlsupport_l1_2_0 > enable_api_ms_win_core_shlwapi_legacy_l1_1_0 > enable_api_ms_win_core_string_l1_1_0 > enable_api_ms_win_core_string_l2_1_0 > +enable_api_ms_win_core_string_obsolete_l1_1_0 > enable_api_ms_win_core_synch_l1_1_0 > enable_api_ms_win_core_synch_l1_2_0 > enable_api_ms_win_core_sysinfo_l1_1_0 > @@ -934,6 +939,7 @@ enable_api_ms_win_core_sysinfo_l1_2_1 > enable_api_ms_win_core_threadpool_l1_2_0 > enable_api_ms_win_core_threadpool_legacy_l1_1_0 > enable_api_ms_win_core_timezone_l1_1_0 > +enable_api_ms_win_core_toolhelp_l1_1_0 > enable_api_ms_win_core_url_l1_1_0 > enable_api_ms_win_core_util_l1_1_0 > enable_api_ms_win_core_version_l1_1_0 > @@ -970,6 +976,7 @@ enable_api_ms_win_downlevel_user32_l1_1_0 > enable_api_ms_win_downlevel_version_l1_1_0 > enable_api_ms_win_eventing_classicprovider_l1_1_0 > enable_api_ms_win_eventing_provider_l1_1_0 > +enable_api_ms_win_eventlog_legacy_l1_1_0 > enable_api_ms_win_ntuser_dc_access_l1_1_0 > enable_api_ms_win_security_base_l1_1_0 > enable_api_ms_win_security_base_l1_2_0 > @@ -979,6 +986,7 @@ enable_api_ms_win_security_sddl_l1_1_0 > enable_api_ms_win_service_core_l1_1_1 > enable_api_ms_win_service_management_l1_1_0 > enable_api_ms_win_service_winsvc_l1_2_0 > +enable_api_ms_win_shell_shellfolders_l1_1_0 > enable_apphelp > enable_appwiz_cpl > enable_atl > @@ -17430,6 +17438,8 @@ wine_fn_config_dll api-ms-win-core-heap-obsolete-l1-1-0 enable_api_ms_win_core_h > wine_fn_config_dll api-ms-win-core-interlocked-l1-1-0 enable_api_ms_win_core_interlocked_l1_1_0 > wine_fn_config_dll api-ms-win-core-interlocked-l1-2-0 enable_api_ms_win_core_interlocked_l1_2_0 > wine_fn_config_dll api-ms-win-core-io-l1-1-1 enable_api_ms_win_core_io_l1_1_1 > +wine_fn_config_dll api-ms-win-core-job-l1-1-0 enable_api_ms_win_core_job_l1_1_0 > +wine_fn_config_dll api-ms-win-core-job-l2-1-0 enable_api_ms_win_core_job_l2_1_0 > wine_fn_config_dll api-ms-win-core-kernel32-legacy-l1-1-0 enable_api_ms_win_core_kernel32_legacy_l1_1_0 > wine_fn_config_dll api-ms-win-core-kernel32-legacy-l1-1-1 enable_api_ms_win_core_kernel32_legacy_l1_1_1 > wine_fn_config_dll api-ms-win-core-libraryloader-l1-1-0 enable_api_ms_win_core_libraryloader_l1_1_0 > @@ -17446,6 +17456,8 @@ wine_fn_config_dll api-ms-win-core-memory-l1-1-2 enable_api_ms_win_core_memory_l > wine_fn_config_dll api-ms-win-core-misc-l1-1-0 enable_api_ms_win_core_misc_l1_1_0 > wine_fn_config_dll api-ms-win-core-namedpipe-l1-1-0 enable_api_ms_win_core_namedpipe_l1_1_0 > wine_fn_config_dll api-ms-win-core-namedpipe-l1-2-0 enable_api_ms_win_core_namedpipe_l1_2_0 > +wine_fn_config_dll api-ms-win-core-namespace-l1-1-0 enable_api_ms_win_core_namespace_l1_1_0 > +wine_fn_config_dll api-ms-win-core-normalization-l1-1-0 enable_api_ms_win_core_normalization_l1_1_0 > wine_fn_config_dll api-ms-win-core-path-l1-1-0 enable_api_ms_win_core_path_l1_1_0 > wine_fn_config_dll api-ms-win-core-processenvironment-l1-1-0 enable_api_ms_win_core_processenvironment_l1_1_0 > wine_fn_config_dll api-ms-win-core-processenvironment-l1-2-0 enable_api_ms_win_core_processenvironment_l1_2_0 > @@ -17460,6 +17472,7 @@ wine_fn_config_dll api-ms-win-core-rtlsupport-l1-2-0 enable_api_ms_win_core_rtls > wine_fn_config_dll api-ms-win-core-shlwapi-legacy-l1-1-0 enable_api_ms_win_core_shlwapi_legacy_l1_1_0 > wine_fn_config_dll api-ms-win-core-string-l1-1-0 enable_api_ms_win_core_string_l1_1_0 > wine_fn_config_dll api-ms-win-core-string-l2-1-0 enable_api_ms_win_core_string_l2_1_0 > +wine_fn_config_dll api-ms-win-core-string-obsolete-l1-1-0 enable_api_ms_win_core_string_obsolete_l1_1_0 > wine_fn_config_dll api-ms-win-core-synch-l1-1-0 enable_api_ms_win_core_synch_l1_1_0 > wine_fn_config_dll api-ms-win-core-synch-l1-2-0 enable_api_ms_win_core_synch_l1_2_0 > wine_fn_config_dll api-ms-win-core-sysinfo-l1-1-0 enable_api_ms_win_core_sysinfo_l1_1_0 > @@ -17468,6 +17481,7 @@ wine_fn_config_dll api-ms-win-core-sysinfo-l1-2-1 enable_api_ms_win_core_sysinfo > wine_fn_config_dll api-ms-win-core-threadpool-l1-2-0 enable_api_ms_win_core_threadpool_l1_2_0 > wine_fn_config_dll api-ms-win-core-threadpool-legacy-l1-1-0 enable_api_ms_win_core_threadpool_legacy_l1_1_0 > wine_fn_config_dll api-ms-win-core-timezone-l1-1-0 enable_api_ms_win_core_timezone_l1_1_0 > +wine_fn_config_dll api-ms-win-core-toolhelp-l1-1-0 enable_api_ms_win_core_toolhelp_l1_1_0 > wine_fn_config_dll api-ms-win-core-url-l1-1-0 enable_api_ms_win_core_url_l1_1_0 > wine_fn_config_dll api-ms-win-core-util-l1-1-0 enable_api_ms_win_core_util_l1_1_0 > wine_fn_config_dll api-ms-win-core-version-l1-1-0 enable_api_ms_win_core_version_l1_1_0 > @@ -17504,6 +17518,7 @@ wine_fn_config_dll api-ms-win-downlevel-user32-l1-1-0 enable_api_ms_win_downleve > wine_fn_config_dll api-ms-win-downlevel-version-l1-1-0 enable_api_ms_win_downlevel_version_l1_1_0 > wine_fn_config_dll api-ms-win-eventing-classicprovider-l1-1-0 enable_api_ms_win_eventing_classicprovider_l1_1_0 > wine_fn_config_dll api-ms-win-eventing-provider-l1-1-0 enable_api_ms_win_eventing_provider_l1_1_0 > +wine_fn_config_dll api-ms-win-eventlog-legacy-l1-1-0 enable_api_ms_win_eventlog_legacy_l1_1_0 > wine_fn_config_dll api-ms-win-ntuser-dc-access-l1-1-0 enable_api_ms_win_ntuser_dc_access_l1_1_0 > wine_fn_config_dll api-ms-win-security-base-l1-1-0 enable_api_ms_win_security_base_l1_1_0 > wine_fn_config_dll api-ms-win-security-base-l1-2-0 enable_api_ms_win_security_base_l1_2_0 > @@ -17513,6 +17528,7 @@ wine_fn_config_dll api-ms-win-security-sddl-l1-1-0 enable_api_ms_win_security_sd > wine_fn_config_dll api-ms-win-service-core-l1-1-1 enable_api_ms_win_service_core_l1_1_1 > wine_fn_config_dll api-ms-win-service-management-l1-1-0 enable_api_ms_win_service_management_l1_1_0 > wine_fn_config_dll api-ms-win-service-winsvc-l1-2-0 enable_api_ms_win_service_winsvc_l1_2_0 > +wine_fn_config_dll api-ms-win-shell-shellfolders-l1-1-0 enable_api_ms_win_shell_shellfolders_l1_1_0 > wine_fn_config_dll apphelp enable_apphelp > wine_fn_config_test dlls/apphelp/tests apphelp_test > wine_fn_config_dll appwiz.cpl enable_appwiz_cpl clean > diff --git a/configure.ac b/configure.ac > index 3a24aab..43d2734 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2661,6 +2661,8 @@ WINE_CONFIG_DLL(api-ms-win-core-heap-obsolete-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-interlocked-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-interlocked-l1-2-0) > WINE_CONFIG_DLL(api-ms-win-core-io-l1-1-1) > +WINE_CONFIG_DLL(api-ms-win-core-job-l1-1-0) > +WINE_CONFIG_DLL(api-ms-win-core-job-l2-1-0) > WINE_CONFIG_DLL(api-ms-win-core-kernel32-legacy-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-kernel32-legacy-l1-1-1) > WINE_CONFIG_DLL(api-ms-win-core-libraryloader-l1-1-0) > @@ -2677,6 +2679,8 @@ WINE_CONFIG_DLL(api-ms-win-core-memory-l1-1-2) > WINE_CONFIG_DLL(api-ms-win-core-misc-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-namedpipe-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-namedpipe-l1-2-0) > +WINE_CONFIG_DLL(api-ms-win-core-namespace-l1-1-0) > +WINE_CONFIG_DLL(api-ms-win-core-normalization-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-path-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-processenvironment-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-processenvironment-l1-2-0) > @@ -2691,6 +2695,7 @@ WINE_CONFIG_DLL(api-ms-win-core-rtlsupport-l1-2-0) > WINE_CONFIG_DLL(api-ms-win-core-shlwapi-legacy-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-string-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-string-l2-1-0) > +WINE_CONFIG_DLL(api-ms-win-core-string-obsolete-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-synch-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-synch-l1-2-0) > WINE_CONFIG_DLL(api-ms-win-core-sysinfo-l1-1-0) > @@ -2699,6 +2704,7 @@ WINE_CONFIG_DLL(api-ms-win-core-sysinfo-l1-2-1) > WINE_CONFIG_DLL(api-ms-win-core-threadpool-l1-2-0) > WINE_CONFIG_DLL(api-ms-win-core-threadpool-legacy-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-timezone-l1-1-0) > +WINE_CONFIG_DLL(api-ms-win-core-toolhelp-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-url-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-util-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-core-version-l1-1-0) > @@ -2735,6 +2741,7 @@ WINE_CONFIG_DLL(api-ms-win-downlevel-user32-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-downlevel-version-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-eventing-classicprovider-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-eventing-provider-l1-1-0) > +WINE_CONFIG_DLL(api-ms-win-eventlog-legacy-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-ntuser-dc-access-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-security-base-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-security-base-l1-2-0) > @@ -2744,6 +2751,7 @@ WINE_CONFIG_DLL(api-ms-win-security-sddl-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-service-core-l1-1-1) > WINE_CONFIG_DLL(api-ms-win-service-management-l1-1-0) > WINE_CONFIG_DLL(api-ms-win-service-winsvc-l1-2-0) > +WINE_CONFIG_DLL(api-ms-win-shell-shellfolders-l1-1-0) > WINE_CONFIG_DLL(apphelp) > WINE_CONFIG_TEST(dlls/apphelp/tests) > WINE_CONFIG_DLL(appwiz.cpl,,[clean]) > diff --git a/dlls/api-ms-win-core-job-l1-1-0/Makefile.in b/dlls/api-ms-win-core-job-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..412c521 > --- /dev/null > +++ b/dlls/api-ms-win-core-job-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-job-l1-1-0.dll > diff --git a/dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec b/dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec > new file mode 100644 > index 0000000..720fecb > --- /dev/null > +++ b/dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec > @@ -0,0 +1 @@ > +@ stdcall IsProcessInJob(long long ptr) kernel32.IsProcessInJob > diff --git a/dlls/api-ms-win-core-job-l2-1-0/Makefile.in b/dlls/api-ms-win-core-job-l2-1-0/Makefile.in > new file mode 100644 > index 0000000..9f3e130 > --- /dev/null > +++ b/dlls/api-ms-win-core-job-l2-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-job-l2-1-0.dll > diff --git a/dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec b/dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec > new file mode 100644 > index 0000000..94871ad > --- /dev/null > +++ b/dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec > @@ -0,0 +1,6 @@ > +@ stdcall AssignProcessToJobObject(ptr ptr) kernel32.AssignProcessToJobObject > +@ stdcall CreateJobObjectW(ptr wstr) kernel32.CreateJobObjectW > +@ stdcall OpenJobObjectW(long long wstr) kernel32.OpenJobObjectW > +@ stdcall QueryInformationJobObject(long long ptr long ptr) kernel32.QueryInformationJobObject > +@ stdcall SetInformationJobObject(long long ptr long) kernel32.SetInformationJobObject > +@ stdcall TerminateJobObject(long long) kernel32.TerminateJobObject > diff --git a/dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in b/dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..ff22a3a > --- /dev/null > +++ b/dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-namespace-l1-1-0.dll > diff --git a/dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec b/dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec > new file mode 100644 > index 0000000..e7b059d > --- /dev/null > +++ b/dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec > @@ -0,0 +1,6 @@ > +@ stub AddSIDToBoundaryDescriptor #kernel32.AddSIDToBoundaryDescriptor > +@ stub ClosePrivateNamespace #kernel32.ClosePrivateNamespace > +@ stub CreateBoundaryDescriptorW #kernel32.CreateBoundaryDescriptorW > +@ stub CreatePrivateNamespaceW #kernel32.CreatePrivateNamespaceW > +@ stub DeleteBoundaryDescriptor #kernel32.DeleteBoundaryDescriptor > +@ stub OpenPrivateNamespaceW #kernel32.OpenPrivateNamespaceW > diff --git a/dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in b/dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..c968955 > --- /dev/null > +++ b/dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-normalization-l1-1-0.dll > diff --git a/dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec b/dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec > new file mode 100644 > index 0000000..65601c1 > --- /dev/null > +++ b/dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec > @@ -0,0 +1,5 @@ > +@ stub GetStringScripts #kernel32.GetStringScripts > +@ stdcall IdnToNameprepUnicode(long wstr long ptr long) kernel32.IdnToNameprepUnicode > +@ stdcall IsNormalizedString(long wstr long) kernel32.IsNormalizedString > +@ stdcall NormalizeString(long wstr long ptr long) kernel32.NormalizeString > +@ stub VerifyScripts #kernel32.VerifyScripts > diff --git a/dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in b/dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..f02787a > --- /dev/null > +++ b/dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-string-obsolete-l1-1-0.dll > diff --git a/dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec b/dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec > new file mode 100644 > index 0000000..0747444 > --- /dev/null > +++ b/dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec > @@ -0,0 +1,10 @@ > +@ stdcall lstrcatW(wstr wstr) kernel32.lstrcatW > +@ stdcall lstrcmpA(str str) kernel32.lstrcmpA > +@ stdcall lstrcmpW(wstr wstr) kernel32.lstrcmpW > +@ stdcall lstrcmpiA(str str) kernel32.lstrcmpiA > +@ stdcall lstrcmpiW(wstr wstr) kernel32.lstrcmpiW > +@ stdcall lstrcpyW(str wstr) kernel32.lstrcpyW > +@ stdcall lstrcpynA(ptr str long) kernel32.lstrcpynA > +@ stdcall lstrcpynW(ptr wstr long) kernel32.lstrcpynW > +@ stdcall lstrlenA(str) kernel32.lstrlenA > +@ stdcall lstrlenW(wstr) kernel32.lstrlenW > diff --git a/dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in b/dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..50368cb > --- /dev/null > +++ b/dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-core-toolhelp-l1-1-0.dll > diff --git a/dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec b/dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec > new file mode 100644 > index 0000000..6275601 > --- /dev/null > +++ b/dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec > @@ -0,0 +1,7 @@ > +@ stdcall CreateToolhelp32Snapshot(long long) kernel32.CreateToolhelp32Snapshot > +@ stdcall Module32FirstW(long ptr) kernel32.Module32FirstW > +@ stdcall Module32NextW(long ptr) kernel32.Module32NextW > +@ stdcall Process32FirstW(ptr ptr) kernel32.Process32FirstW > +@ stdcall Process32NextW(ptr ptr) kernel32.Process32NextW > +@ stdcall Thread32First(long ptr) kernel32.Thread32First > +@ stdcall Thread32Next(long ptr) kernel32.Thread32Next > diff --git a/dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in b/dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..11590ca > --- /dev/null > +++ b/dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-eventlog-legacy-l1-1-0.dll > diff --git a/dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec b/dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec > new file mode 100644 > index 0000000..6a12a60 > --- /dev/null > +++ b/dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec > @@ -0,0 +1,6 @@ > +@ stdcall DeregisterEventSource(long) advapi32.DeregisterEventSource > +@ stdcall GetEventLogInformation(long long ptr long ptr) advapi32.GetEventLogInformation > +@ stdcall RegisterEventSourceA(ptr ptr) advapi32.RegisterEventSourceA > +@ stdcall RegisterEventSourceW(ptr ptr) advapi32.RegisterEventSourceW > +@ stdcall ReportEventA(long long long long ptr long long ptr ptr) advapi32.ReportEventA > +@ stdcall ReportEventW(long long long long ptr long long ptr ptr) advapi32.ReportEventW > diff --git a/dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in b/dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in > new file mode 100644 > index 0000000..5f1d020 > --- /dev/null > +++ b/dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in > @@ -0,0 +1 @@ > +MODULE = api-ms-win-shell-shellfolders-l1-1-0.dll > diff --git a/dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec b/dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec > new file mode 100644 > index 0000000..d81785d > --- /dev/null > +++ b/dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec > @@ -0,0 +1,14 @@ > +@ stdcall PathCleanupSpec(ptr ptr) shell32.PathCleanupSpec > +@ stdcall PathIsExe(ptr) shell32.PathIsExe > +@ stdcall SHCreateDirectoryExW(long wstr ptr) shell32.SHCreateDirectoryExW > +@ stdcall SHGetDesktopFolder(ptr) shell32.SHGetDesktopFolder > +@ stdcall SHGetFileInfoW(ptr long ptr long long) shell32.SHGetFileInfoW > +@ stdcall SHGetFolderLocation(long long long long ptr) shell32.SHGetFolderLocation > +@ stdcall SHGetFolderPathA(long long long long ptr) shell32.SHGetFolderPathA > +@ stdcall SHGetFolderPathAndSubDirW(long long long long wstr ptr) shell32.SHGetFolderPathAndSubDirW > +@ stdcall SHGetFolderPathW(long long long long ptr) shell32.SHGetFolderPathW > +@ stdcall SHGetInstanceExplorer(long) shell32.SHGetInstanceExplorer > +@ stdcall SHGetKnownFolderPath(ptr long ptr ptr) shell32.SHGetKnownFolderPath > +@ stdcall SHGetSpecialFolderPathA(long ptr long long) shell32.SHGetSpecialFolderPathA > +@ stdcall SHGetSpecialFolderPathW(long ptr long long) shell32.SHGetSpecialFolderPathW > +@ stub SHSetKnownFolderPath #shell32.SHSetKnownFolderPath > diff --git a/tools/make_specfiles b/tools/make_specfiles > index a965210..3f2e590 100755 > --- a/tools/make_specfiles > +++ b/tools/make_specfiles > @@ -115,6 +115,7 @@ my @dll_groups = > "api-ms-win-core-registry-l1-1-0", > "api-ms-win-eventing-classicprovider-l1-1-0", > "api-ms-win-eventing-provider-l1-1-0", > + "api-ms-win-eventlog-legacy-l1-1-0", > "api-ms-win-security-base-l1-2-0", > "api-ms-win-security-lsalookup-l1-1-0", > "api-ms-win-security-sddl-l1-1-0", > @@ -136,6 +137,7 @@ my @dll_groups = > "api-ms-win-core-misc-l1-1-0", > "api-ms-win-core-profile-l1-1-0", > "api-ms-win-core-string-l1-1-0", > + "api-ms-win-core-string-obsolete-l1-1-0", > "api-ms-win-core-sysinfo-l1-1-0", > "api-ms-win-core-sysinfo-l1-2-0", > "api-ms-win-core-util-l1-1-0", > @@ -152,6 +154,8 @@ my @dll_groups = > "api-ms-win-core-heap-l1-2-0", > "api-ms-win-core-heap-obsolete-l1-1-0", > "api-ms-win-core-io-l1-1-1", > + "api-ms-win-core-job-l1-1-0", > + "api-ms-win-core-job-l2-1-0", > "api-ms-win-core-kernel32-legacy-l1-1-0", > "api-ms-win-core-kernel32-legacy-l1-1-1", > "api-ms-win-core-localization-l1-1-0", > @@ -166,6 +170,7 @@ my @dll_groups = > "api-ms-win-core-threadpool-l1-2-0", > "api-ms-win-core-threadpool-legacy-l1-1-0", > "api-ms-win-core-timezone-l1-1-0", > + "api-ms-win-core-toolhelp-l1-1-0", > "api-ms-win-core-sysinfo-l1-2-1", > "api-ms-win-core-processthreads-l1-1-2", > "api-ms-win-core-fibers-l1-1-0", > @@ -207,6 +212,7 @@ my @dll_groups = > [ > "shell32", > "api-ms-win-downlevel-shell32-l1-1-0", > + "api-ms-win-shell-shellfolders-l1-1-0", > ], > [ > "shlwapi", > -- > 2.9.3 A better commit message would be appreciated, e.g. something like, "add some more api-ms DLLs"

1 0

Re: [PATCH] wined3d: Fix ATI1 buffer size
by Marvin 19 Aug '16

19 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25231 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Compilation with winegcc and linking with msvcrt
by Ruslan Kabatsayev 19 Aug '16

19 Aug '16

Hello all, I'm trying to compile a simple application like follows with winegcc, linking to msvcrt (which this test doesn't require, but it's a reduced test case): #include <stdio.h> int main() { printf("Hello"); fflush(stdout); printf(", world!\n"); return 0; } I compile it with this command: winegcc test.c -o test -lmsvcrt Looks pretty harmless, but when I run it, it only prints "Hello" and hangs on fflush. If I don't link it to msvcrt, then it doesn't hang. Why is it so? Is it a bug in Wine? Regards, Ruslan

2 3

Re: [PATCH 2/2] rpcrt4: Add a test for RpcBindingServerFromClient (todo_wine).
by Marvin 19 Aug '16

19 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25221 Your paranoid android. === w8 (32 bit server) === server.c:1033: Test failed: get_ranged_enum() returned 2000814083 instead of RE3 === w864 (32 bit server) === server.c:1033: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1033: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1033: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 === w864 (64 bit server) === server.c:1033: Test failed: get_ranged_enum() returned 4390915 instead of RE3 server.c:1033: Test failed: get_ranged_enum() returned 184549379 instead of RE3 server.c:1033: Test failed: get_ranged_enum() returned 4390915 instead of RE3 === w1064 (64 bit server) === server.c:1033: Test failed: get_ranged_enum() returned 6815747 instead of RE3 server.c:1033: Test failed: get_ranged_enum() returned 3145731 instead of RE3

1 0

Re: [PATCH 2/2] rpcrt4: Add a test for RpcBindingServerFromClient (todo_wine).
by Marvin 19 Aug '16

19 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25216 Your paranoid android. === w8 (32 bit server) === server.c:1025: Test failed: get_ranged_enum() returned 2000814083 instead of RE3 === w864 (32 bit server) === server.c:1025: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1025: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:1025: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 === w864 (64 bit server) === server.c:1025: Test failed: get_ranged_enum() returned 4390915 instead of RE3 server.c:1025: Test failed: get_ranged_enum() returned 184549379 instead of RE3 server.c:1025: Test failed: get_ranged_enum() returned 4390915 instead of RE3 === w1064 (64 bit server) === server.c:1025: Test failed: get_ranged_enum() returned 7143427 instead of RE3 server.c:1025: Test failed: get_ranged_enum() returned 6029315 instead of RE3

1 0

Re: [rebased PATCH] ntdll: Tolerate null handle in DeregisterWait
by Sebastian Lackner 18 Aug '16

18 Aug '16

On 18.08.2016 23:00, Keno Fischer wrote: > @@ -637,6 +637,9 @@ NTSTATUS WINAPI RtlDeregisterWaitEx(HANDLE > WaitHandle, HANDLE CompletionEvent) This rebased version seems to have the same issue. Actually it looks like your mail client is corrupting the patch here.

2 2

Re: [rebased PATCH] ntdll: Tolerate null handle in DeregisterWait
by Marvin 18 Aug '16

18 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25207 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] ntdll: Tolerate null handle in DeregisterWait
by Marvin 18 Aug '16

18 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25206 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: gdiplus: Reimplement metafile loading using gdi32 instead of IPicture. (v2)
by Vincent Povirk 18 Aug '16

18 Aug '16

> @@ -2220,10 +2157,8 @@ GpStatus WINGDIPAPI GdipGetImageBounds(GpImage *image, GpRectF *srcRect, > *srcUnit = UnitPixel; > } > else{ > - srcRect->X = srcRect->Y = 0.0; > - srcRect->Width = ipicture_pixel_width(image->picture); > - srcRect->Height = ipicture_pixel_height(image->picture); > - *srcUnit = UnitPixel; > + WARN("GpImage with no image data (metafile in wrong state?)\n"); > + return InvalidParameter; > } > > TRACE("returning (%f, %f) (%f, %f) unit type %d\n", srcRect->X, srcRect->Y, The "metafile in wrong state?" part is wrong, because that would still have ImageTypeMetafile, and we'd have bounds to return. If this case ever occurs, it's more likely a use-after-free (we set the type to ~0 when we free images), or a random pointer that doesn't point to a GpImage.

1 0

Re: [PATCH 2/2] rpcrt4: Add a test for RpcBindingServerFromClient (todo_wine).
by Marvin 18 Aug '16

18 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25203 Your paranoid android. === wxppro (32 bit server) === server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 7C812FD3 === w2003std (32 bit server) === server: unhandled exception c0000005 at 00421E02 === wvistau64 (32 bit server) === server: unhandled exception c0000005 at 00421E02 === w2008s64 (32 bit server) === server: unhandled exception c0000005 at 00421E02 === w7u (32 bit server) === server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 75D8812F === w7pro64 (32 bit server) === server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 76C7C41F === w8 (32 bit server) === server.c:1018: Test failed: get_ranged_enum() returned 2000814083 instead of RE3 server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 7515FD78 === w864 (32 bit server) === server.c:1018: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 77261D4D === w1064 (32 bit server) === server: unhandled exception c0000005 at 00421E02 server: unhandled exception 000006be at 747E3E28 === wvistau64 (64 bit server) === server: unhandled exception c0000005 at 00000000004148A5 server: unhandled exception 000006be at 000000007765674D === w2008s64 (64 bit server) === server: unhandled exception c0000005 at 00000000004148A5 === w7pro64 (64 bit server) === server: unhandled exception c0000005 at 00000000004148A5 server: unhandled exception 000006be at 000007FEFCF4940D === w864 (64 bit server) === server.c:1018: Test failed: get_ranged_enum() returned 4390915 instead of RE3 server: unhandled exception c0000005 at 00000000004148A5 server: unhandled exception 000006be at 00007FFB7AC05BF8 === w1064 (64 bit server) === server.c:1018: Test failed: get_ranged_enum() returned 5963779 instead of RE3 server: unhandled exception c0000005 at 00000000004148A5 server: unhandled exception 000006be at 00007FFC77CCA1C8

1 0

RE: TestBot job 25201 results: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext (try2)
by Daniel Lehman 18 Aug '16

18 Aug '16

=== wvistau64 (32 bit exception) === ntdll: exception.c:551: Test failed: 42: Unexpected eip 0x350000/0x350001 exception: unhandled exception 80000004 at 00350000 exception.c:548: Test failed: 42: Wrong exception code c0000027/80000004 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x350001 === w7u (32 bit exception) === ntdll: exception.c:551: Test failed: 42: Unexpected eip 0x3f0000/0x3f0001 exception: unhandled exception 80000004 at 003F0000 exception.c:548: Test failed: 42: Wrong exception code c0000027/80000004 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x3f0001 === w8 (32 bit exception) === ntdll: exception.c:1261: Test failed: Got exception offset 0x1b, expected 0x19 exception.c:1270: Test failed: Got exception offset 0x19, expected 0x17 these are existing failures

1 0

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext (try2)
by Marvin 18 Aug '16

18 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25201 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x350000/0x350001 exception: unhandled exception 80000004 at 00350000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x350001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x3f0000/0x3f0001 exception: unhandled exception 80000004 at 003F0000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x3f0001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH v7 1/3] shell32/tests: Add tests for FolderItems_Item and FolderItems_get_Count.
by Sebastian Lackner 18 Aug '16

18 Aug '16

On 18.08.2016 06:37, Alex Henrie wrote: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > v7 fixes the use-after-free of V_BSTR(&var). > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/tests/Makefile.in | 2 +- > dlls/shell32/tests/shelldispatch.c | 220 +++++++++++++++++++++++++++++++++++-- > 2 files changed, 210 insertions(+), 12 deletions(-) > > diff --git a/dlls/shell32/tests/Makefile.in b/dlls/shell32/tests/Makefile.in > index cfe0c50..ef95b52 100644 > --- a/dlls/shell32/tests/Makefile.in > +++ b/dlls/shell32/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = shell32.dll > -IMPORTS = shell32 ole32 oleaut32 user32 advapi32 > +IMPORTS = shell32 ole32 oleaut32 user32 advapi32 shlwapi > > C_SRCS = \ > appbar.c \ > diff --git a/dlls/shell32/tests/shelldispatch.c b/dlls/shell32/tests/shelldispatch.c > index 9a47c67..02be8fd 100644 > --- a/dlls/shell32/tests/shelldispatch.c > +++ b/dlls/shell32/tests/shelldispatch.c > @@ -25,13 +25,14 @@ > #include "shldisp.h" > #include "shlobj.h" > #include "shlwapi.h" > +#include "shellapi.h" > #include "winsvc.h" > #include "wine/test.h" > > #define EXPECT_HR(hr,hr_exp) \ > ok(hr == hr_exp, "got 0x%08x, expected 0x%08x\n", hr, hr_exp) > > -static const WCHAR winetestW[] = {'w','i','n','e','t','e','s','t',0}; > +static const WCHAR winetestW[] = {'w','i','n','e','t','e','s','t',0,0}; > > static HRESULT (WINAPI *pSHGetFolderPathW)(HWND, int, HANDLE, DWORD, LPWSTR); > static HRESULT (WINAPI *pSHGetNameFromIDList)(PCIDLIST_ABSOLUTE,SIGDN,PWSTR*); > @@ -310,19 +311,46 @@ static void test_namespace(void) > > static void test_items(void) > { > - WCHAR wstr[MAX_PATH], orig_dir[MAX_PATH]; > + static const struct > + { > + char name[32]; > + enum > + { > + DIRECTORY, > + SHORTCUT, > + EMPTY, > + RANDOM, > + } > + type; > + } > + file_defs[] = > + { > + { "00-Myfolder", DIRECTORY }, > + { "01-empty.lnk", EMPTY }, Not really an issue, but is it intentional that the empty file has a .lnk extension? > + { "02-shortcut.lnk", SHORTCUT }, > + { "03-empty.bin", EMPTY }, > + { "04-random.bin", RANDOM }, > + }; > + WCHAR wstr[MAX_PATH], wstr2[MAX_PATH], orig_dir[MAX_PATH]; > HRESULT r; > IShellDispatch *sd = NULL; > Folder *folder = NULL; > FolderItems *items = NULL; > FolderItems2 *items2 = NULL; > FolderItems3 *items3 = NULL; > - FolderItem *item = (FolderItem*)0xdeadbeef; > + FolderItem *item = (FolderItem*)0xdeadbeef, *item2 = (FolderItem*)0xdeadbeef; > IDispatch *disp = NULL; > IUnknown *unk = NULL; > FolderItemVerbs *verbs = (FolderItemVerbs*)0xdeadbeef; > VARIANT var; > LONG lcount = -1; > + HANDLE file; > + DWORD dwcount; > + IPersistFile *shortcut = NULL; > + BSTR bstr; > + SHFILEOPSTRUCTW del; > + char buf[512]; > + int i, j; > > r = CoCreateInstance(&CLSID_Shell, NULL, CLSCTX_INPROC_SERVER, &IID_IShellDispatch, (void**)&sd); > ok(SUCCEEDED(r), "CoCreateInstance failed: %08x\n", r); > @@ -345,13 +373,6 @@ static void test_items(void) > r = Folder_Items(folder, &items); > ok(r == S_OK, "Folder::Items failed: %08x\n", r); > ok(!!items, "items is null\n"); > - r = FolderItems_QueryInterface(items, &IID_FolderItems2, (void**)&items2); > - ok(r == S_OK || broken(E_NOINTERFACE) /* xp and later */, "FolderItems::QueryInterface failed: %08x\n", r); > - ok(!!items2 || broken(!items2) /* xp and later */, "items2 is null\n"); > - r = FolderItems_QueryInterface(items, &IID_FolderItems3, (void**)&items3); > - ok(r == S_OK, "FolderItems::QueryInterface failed: %08x\n", r); > - ok(!!items3, "items3 is null\n"); > - Folder_Release(folder); > > if (0) /* crashes on all versions of Windows */ > r = FolderItems_get_Count(items, NULL); > @@ -373,6 +394,179 @@ todo_wine > ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > ok(!item, "item is not null\n"); > > + for (i = 0; i < sizeof(file_defs)/sizeof(file_defs[0]); i++) > + { > + switch (file_defs[i].type) > + { > + case DIRECTORY: > + CreateDirectoryA(file_defs[i].name, NULL); > + PathCombineA(buf, file_defs[i].name, "foo.txt"); > + CloseHandle(CreateFileA(buf, 0, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL)); > + break; > + > + case SHORTCUT: > + CoCreateInstance(&CLSID_ShellLink, NULL, CLSCTX_INPROC_SERVER, &IID_IPersistFile, (void**)&shortcut); > + MultiByteToWideChar(CP_ACP, 0, file_defs[i].name, -1, wstr, sizeof(wstr)/sizeof(WCHAR)); > + IPersistFile_Save(shortcut, wstr, FALSE); > + IPersistFile_Release(shortcut); > + break; > + > + case EMPTY: > + CloseHandle(CreateFileA(file_defs[i].name, 0, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL)); > + break; > + > + case RANDOM: > + file = CreateFileA(file_defs[i].name, GENERIC_WRITE, 0, NULL, > + CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + for (j = 0; j < sizeof(buf); j++) > + buf[j] = rand() % 256; > + WriteFile(file, buf, sizeof(buf), &dwcount, NULL); > + CloseHandle(file); > + break; I think a few checks would not hurt in the code above. > + } > + } > + > + lcount = -1; > + r = FolderItems_get_Count(items, &lcount); > +todo_wine > + ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > +todo_wine > + ok(!lcount, "expected 0 files, got %d\n", lcount); > + FolderItems_Release(items); > + > + items = NULL; > + r = Folder_Items(folder, &items); > + ok(r == S_OK, "Folder::Items failed: %08x\n", r); > + ok(!!items, "items is null\n"); > + r = FolderItems_QueryInterface(items, &IID_FolderItems2, (void**)&items2); > + ok(r == S_OK || broken(E_NOINTERFACE) /* xp and later */, "FolderItems::QueryInterface failed: %08x\n", r); > + if (r == S_OK) ok(!!items2, "items2 is null\n"); > + r = FolderItems_QueryInterface(items, &IID_FolderItems3, (void**)&items3); > + ok(r == S_OK, "FolderItems::QueryInterface failed: %08x\n", r); > + ok(!!items3, "items3 is null\n"); Isn't it necessary to release those items{2,3} interfaces? > + Folder_Release(folder); > + > + lcount = -1; > + r = FolderItems_get_Count(items, &lcount); > +todo_wine > + ok(r == S_OK, "FolderItems::get_Count failed: %08x\n", r); > +todo_wine > + ok(lcount == sizeof(file_defs)/sizeof(file_defs[0]), > + "expected %d files, got %d\n", sizeof(file_defs)/sizeof(file_defs[0]), lcount); > + > + VariantInit(&var); > + for (i = -10; i < 0x10000; i++) > + { > + item = NULL; > + V_VT(&var) = i; Is such a bruteforce approach also used in other places of Wine? I personally don't think it makes much sense. It causes a huge amount of FIXMEs although there are just a few supported types. For debugging purposes something like this is probably fine, but it might be preferred to test only "reasonable" stuff. Please also note that that VARTYPE is unsigned short, so negative numbers do not make sense. Very high numbers correspond to vector/array/... which also don't make sense, especially when they are not properly initialized. > + r = FolderItems_Item(items, var, &item); > + if (i == VT_I2 || i == VT_I4 || i == VT_ERROR) > + { > +todo_wine > + ok(r == S_OK, "type %d: expected S_OK, got %08x\n", i, r); > +todo_wine > + ok(!!item, "item is null\n"); > + } > + else if (i == VT_BSTR) > + { > +todo_wine > + ok(r == S_FALSE, "type %d: expected S_FALSE, got %08x\n", i, r); > + ok(!item, "item is not null\n"); > + } > + else > + { > + ok(r == E_NOTIMPL, "type %d: expected E_NOTIMPL, got %08x\n", i, r); > + ok(!item, "item is not null\n"); > + } > + if (item) FolderItem_Release(item); > + } > + > + for (i = -10; i < 10; i++) > + { Could you explain why this test is repeated 20 times? It does not look like you actually use the counter variable anywhere. > + item = NULL; > + V_VT(&var) = VT_ERROR; > + V_ERROR(&var) = 0; > + r = FolderItems_Item(items, var, &item); > +todo_wine > + ok(r == S_OK, "expected S_OK, got %08x\n", r); > +todo_wine > + ok(!!item, "item is null\n"); > + if (!item) continue; > + > + bstr = NULL; > + r = FolderItem_get_Path(item, &bstr); > + ok(r == S_OK, "FolderItem::get_Path failed: %08x\n", r); > + ok(!!bstr, "bstr is null\n"); > + GetCurrentDirectoryW(MAX_PATH, wstr); > + GetLongPathNameW(wstr, wstr2, MAX_PATH); > + ok(!lstrcmpW(bstr, wstr2), > + "expected %s, got %s\n", wine_dbgstr_w(wstr2), wine_dbgstr_w(bstr)); > + > + SysFreeString(bstr); > + FolderItem_Release(item); > + } > + > + item = NULL; > + V_VT(&var) = VT_I4; > + V_I4(&var) = -1; > + r = FolderItems_Item(items, var, &item); > +todo_wine > + ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > + ok(!item, "item is not null\n"); Not sure if its critical, but the test isn't really convincing when you already initialize item to the correct value. It might be better to set it to something else. The same also applies to similar code below. > + > + for (i = 0; i < sizeof(file_defs)/sizeof(file_defs[0]); i++) > + { > + for (j = 0; j < 2; j++) > + { > + item = NULL; It might be better to do the initialization directly in front of the call. > + MultiByteToWideChar(CP_ACP, 0, file_defs[i].name, -1, wstr, MAX_PATH); > + > + if (j == 0) > + { > + V_VT(&var) = VT_I4; > + V_I4(&var) = i; > + } > + else > + { > + V_VT(&var) = VT_BSTR; > + V_BSTR(&var) = SysAllocString(wstr); > + } > + > + r = FolderItems_Item(items, var, &item); > +todo_wine > + ok(r == S_OK, "file_defs[%d], %d: FolderItems::Item failed: %08x\n", i, j, r); > +todo_wine > + ok(!!item, "file_defs[%d], %d: item is null\n", i, j); > + if (!item) continue; > + You probably should also initialize item2 here. > + r = FolderItems_Item(items, var, &item2); > + ok(r == S_OK, "file_defs[%d], %d: FolderItems::Item failed: %08x\n", i, j, r); > + ok(item2 != item, "file_defs[%d], %d: item and item2 are the same\n", i, j); > + FolderItem_Release(item2); > + if (V_VT(&var) == VT_BSTR) SysFreeString(V_BSTR(&var)); > + > + bstr = NULL; > + r = FolderItem_get_Path(item, &bstr); > + ok(r == S_OK, "file_defs[%d], %d: FolderItem::get_Path failed: %08x\n", i, j, r); > + ok(!!bstr, "file_defs[%d], %d: bstr is null\n", i, j); > + GetFullPathNameW(wstr, MAX_PATH, wstr2, NULL); > + GetLongPathNameW(wstr2, wstr, MAX_PATH); > + ok(!lstrcmpW(bstr, wstr), > + "file_defs[%d], %d: expected %s, got %s\n", i, j, wine_dbgstr_w(wstr), wine_dbgstr_w(bstr)); > + SysFreeString(bstr); > + > + FolderItem_Release(item); > + } > + } > + > + V_VT(&var) = VT_I4; > + V_I4(&var) = sizeof(file_defs)/sizeof(file_defs[0]); > + item = NULL; > + r = FolderItems_Item(items, var, &item); > +todo_wine > + ok(r == S_FALSE, "expected S_FALSE, got %08x\n", r); > + ok(!item, "item is not null\n"); > + > if (0) /* crashes on xp */ > { > r = FolderItems_get_Application(items, NULL); > @@ -430,7 +624,11 @@ todo_wine > > GetTempPathW(MAX_PATH, wstr); > SetCurrentDirectoryW(wstr); > - RemoveDirectoryW(winetestW); > + memset(&del, 0, sizeof(del)); > + del.wFunc = FO_DELETE; > + del.pFrom = winetestW; > + del.fFlags = FOF_NO_UI; > + SHFileOperationW(&del); > SetCurrentDirectoryW(orig_dir); > > FolderItems_Release(items); >

2 1

Re: [PATCH 02/13] wineplugplay.sys: Initialize device driver store
by Sebastian Lackner 18 Aug '16

18 Aug '16

On 17.08.2016 15:36, Aric Stewart wrote: > We are not handling installing drivers just yet, so we just make use of the > critical device store. These are drivers that, on Windows, are automatically > loaded on boot every time. This database is maintained in > [CurrentControlSet/Control/CriticalDeviceDatabase] The keys in this registry key > represent a HardwareID that match a device. We query the IDs from the bus > device’s BusQueryHardwareIDs and if we find a match (from most specific to most > general) we look at that registry key. The CriticalDeviceDatabase entry > specify a [Service] value representing the driver. > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/wineplugplay.sys/Makefile.in | 5 +- > dlls/wineplugplay.sys/main.c | 14 ++++ > dlls/wineplugplay.sys/pnp.h | 20 +++++ > dlls/wineplugplay.sys/pnp_manager.c | 162 ++++++++++++++++++++++++++++++++++++ > 4 files changed, 199 insertions(+), 2 deletions(-) > create mode 100644 dlls/wineplugplay.sys/pnp.h > create mode 100644 dlls/wineplugplay.sys/pnp_manager.c > > > > 0002-wineplugplay.sys-Initialize-device-driver-store.txt > > > diff --git a/dlls/wineplugplay.sys/Makefile.in b/dlls/wineplugplay.sys/Makefile.in > index 4039a8d..618dac7 100644 > --- a/dlls/wineplugplay.sys/Makefile.in > +++ b/dlls/wineplugplay.sys/Makefile.in > @@ -1,6 +1,7 @@ > MODULE = wineplugplay.sys > -IMPORTS = ntoskrnl > +IMPORTS = ntoskrnl advapi32 > EXTRADLLFLAGS = -Wb,--subsystem,native > > C_SRCS = \ > - main.c > + main.c \ > + pnp_manager.c > diff --git a/dlls/wineplugplay.sys/main.c b/dlls/wineplugplay.sys/main.c > index 51b5d97..4ce641b 100644 > --- a/dlls/wineplugplay.sys/main.c > +++ b/dlls/wineplugplay.sys/main.c > @@ -30,11 +30,25 @@ > #include "wine/unicode.h" > #include "wine/debug.h" > > +#include "pnp.h" > + > WINE_DEFAULT_DEBUG_CHANNEL(plugplay); > > +static DWORD CALLBACK Initialize_thread(void *args) > +{ > + Initialize_DriverStore(); > + return 0; > +} > + > /* main entry point for the driver */ > NTSTATUS WINAPI DriverEntry( DRIVER_OBJECT *driver, UNICODE_STRING *path ) > { > TRACE("\n"); > + /* We are doing this in a new thread because we want this DriverEntry > + to return as immediently as possible. The loader lock will prevent > + the thread from starting immediently so this service can finish > + loading before the Initialization start trying to load more > + services */ > + CreateThread(NULL, 0, Initialize_thread, NULL, 0, NULL); > return STATUS_SUCCESS; > } > diff --git a/dlls/wineplugplay.sys/pnp.h b/dlls/wineplugplay.sys/pnp.h > new file mode 100644 > index 0000000..db18202 > --- /dev/null > +++ b/dlls/wineplugplay.sys/pnp.h > @@ -0,0 +1,20 @@ > +/* > + * Copyright 2016 Aric Stewart > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +/* Plug and Play Manager */ > +void Initialize_DriverStore(void) DECLSPEC_HIDDEN; > diff --git a/dlls/wineplugplay.sys/pnp_manager.c b/dlls/wineplugplay.sys/pnp_manager.c > new file mode 100644 > index 0000000..0e10240 > --- /dev/null > +++ b/dlls/wineplugplay.sys/pnp_manager.c > @@ -0,0 +1,162 @@ > +/* HID plug and play Manager like functionality > + * > + * Copyright 2016 CodeWeavers, Aric Stewart > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > +#include "ntstatus.h" > +#define WIN32_NO_STATUS > +#include "windef.h" > +#include "winbase.h" > +#include "winternl.h" > +#include "ddk/wdm.h" > +#include "cfgmgr32.h" > +#include "winsvc.h" > +#include "winreg.h" > +#include "wine/debug.h" > +#include "wine/list.h" > + > +#include "pnp.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(plugplay); > + > +#define MAX_SERVICE_NAME 260 > + > +typedef struct _device_driver { > + struct list entry; > + > + WCHAR **matching_ids; > + INT id_count; > + > + WCHAR *driver_name; > +} device_driver; > + > +struct list device_drivers = LIST_INIT(device_drivers); > + > +static device_driver* load_device_driver(const WCHAR *drivername, const WCHAR* match) > +{ > + device_driver *ptr; > + > + LIST_FOR_EACH_ENTRY(ptr, &device_drivers, device_driver, entry) > + { > + if (lstrcmpW(drivername, ptr->driver_name) == 0) > + { > + int i; > + /* Check matching ids */ > + for (i = 0; i < ptr->id_count; i++) > + if (lstrcmpW(match, ptr->matching_ids[i]) == 0) > + return ptr; > + /* Add a new matching id, this should be reletivly rare, > + no exponental growth needed */ > + ptr->matching_ids = HeapReAlloc(GetProcessHeap(), 0, ptr->matching_ids, sizeof(WCHAR*) * (ptr->id_count+1)); > + ptr->matching_ids[ptr->id_count] = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(match)+1)); > + lstrcpyW(ptr->matching_ids[ptr->id_count], match); Such code would be easier to read with a strdupW() helper function, like in many other places of Wine. The same also applies to some places below. > + ptr->id_count++; > + > + return ptr; > + } > + } > + > + ptr = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ptr)); > + ptr->driver_name = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(drivername)+1)); > + lstrcpyW(ptr->driver_name, drivername); > + ptr->matching_ids = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR*)); > + ptr->matching_ids[0] = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(match)+1)); > + lstrcpyW(ptr->matching_ids[0], match); > + ptr->id_count = 1; > + list_add_tail(&device_drivers, &ptr->entry); > + > + return ptr; > +} > + > +void Initialize_DriverStore(void) > +{ > + static const WCHAR criticalW[] = > + { 'S','y','s','t','e','m','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l', '\\', > + 'C','r','i','t','i','c','a','l','D','e','v','i','c','e','D','a','t','a','b','a','s','e', 0}; > + static const WCHAR serviceW[] = {'S','e','r','v','i','c','e',0}; > + HKEY hkey_root; > + WCHAR szMatch[MAX_DEVICE_ID_LEN]; > + SC_HANDLE service_manager; > + > + int i; > + > + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, criticalW, &hkey_root)) > + { > + TRACE("No drivers found\n"); > + return; > + } > + > + service_manager = OpenSCManagerW(NULL, NULL, GENERIC_READ|GENERIC_EXECUTE); > + > + for (i = 0; TRUE; i++) > + { > + HKEY hkey_service; > + DWORD rc; > + device_driver *driver; > + DWORD len = 0; > + WCHAR szService[MAX_SERVICE_NAME]; > + SC_HANDLE service; > + > + rc = RegEnumKeyW(hkey_root, i, szMatch, MAX_DEVICE_ID_LEN); > + if (rc == ERROR_NO_MORE_ITEMS) > + break; > + > + if (rc != 0) > + { > + ERR("Error %d reading key %d - skipping\n", rc, i); > + continue; > + } > + > + if (RegOpenKeyW(hkey_root, szMatch, &hkey_service)) > + { > + ERR("Error opening key %s - skipping\n",debugstr_w(szMatch)); > + continue; > + } > + > + len = sizeof(szService); > + rc = RegQueryValueExW(hkey_service, serviceW, NULL, NULL, (BYTE*)szService, &len); > + if (rc != ERROR_SUCCESS) > + { > + ERR("Error querying service from key %s - skipping\n",debugstr_w(szMatch)); > + RegCloseKey(hkey_service); > + continue; > + } > + RegCloseKey(hkey_service); > + > + service = OpenServiceW(service_manager, szService, GENERIC_READ|GENERIC_EXECUTE); > + if (!service) > + { > + ERR("Unable to open service %s - skipping\n",debugstr_w(szService)); > + continue; > + } > + > + TRACE("Loading service '%s' to match '%s'\n", debugstr_w(szService), debugstr_w(szMatch)); Why are there so many spaces in the middle of the line? > + > + driver = load_device_driver(szService, szMatch); > + if (!driver) > + ERR("failed to load driver %s\n", debugstr_w(szService)); > + > + StartServiceW(service, 0, NULL); > + CloseServiceHandle(service); The registry parsing code is probably fine, but wouldn't it be easier to handle this similar to other autostart services in services.exe? Then there would also be no need to spawn a separate thread for initialization. > + } > + > + CloseServiceHandle(service_manager); > + RegCloseKey(hkey_root); > +} > > >

2 2

Re: [PATCH] api-ms-win-core-console-l2-1-0: Add stub dll.
by Hugh McMaster 18 Aug '16

18 Aug '16

On Wednesday, 17 August 2016 8:39 PM, Hadrien Boizard wrote: > +@ stub AttachConsole > +@ stub CreateConsoleScreenBuffer > +@ stub FillConsoleOutputAttribute > +@ stub FillConsoleOutputCharacterA > +@ stub FillConsoleOutputCharacterW > +@ stub FlushConsoleInputBuffer > +@ stub FreeConsole > +@ stub GenerateConsoleCtrlEvent > +@ stub GetConsoleCursorInfo > +@ stub GetConsoleScreenBufferInfo > +@ stub GetConsoleScreenBufferInfoEx > +@ stub GetConsoleTitleW > +@ stub GetLargestConsoleWindowSize > +@ stub PeekConsoleInputW > +@ stub ReadConsoleOutputA > +@ stub ReadConsoleOutputAttribute > +@ stub ReadConsoleOutputCharacterA > +@ stub ReadConsoleOutputCharacterW > +@ stub ReadConsoleOutputW > +@ stub ScrollConsoleScreenBufferA > +@ stub ScrollConsoleScreenBufferW > +@ stub SetConsoleActiveScreenBuffer > +@ stub SetConsoleCP > +@ stub SetConsoleCursorInfo > +@ stub SetConsoleCursorPosition > +@ stub SetConsoleOutputCP > +@ stub SetConsoleScreenBufferInfoEx > +@ stub SetConsoleScreenBufferSize > +@ stub SetConsoleTextAttribute > +@ stub SetConsoleTitleW > +@ stub SetConsoleWindowInfo > +@ stub WriteConsoleInputA > +@ stub WriteConsoleInputW > +@ stub WriteConsoleOutputA > +@ stub WriteConsoleOutputAttribute > +@ stub WriteConsoleOutputCharacterA > +@ stub WriteConsoleOutputCharacterW > +@ stub WriteConsoleOutputW Hi Hadrien, Most, if not all, of these functions are implemented in dlls/kernel32. You should forward these calls to kernel32, making sure to change 'stub' to 'stdcall' as necessary. -- Hugh McMaster

2 1

Re: msvcrt: Fix strtok_s and _mbstok_s for empty strings. (v2)
by Piotr Caban 18 Aug '16

18 Aug '16

Hi, On 08/18/16 11:06, Bernhard Übelacker wrote: > + if(!p_strtok_s) { > + win_skip("strtok_s not found.\n"); > + return; > + } There's one more thing that I missed earlier - strtok_s/mbstok_s is always available in msvcr90. There's no point in checking it. Sorry for not spotting it earlier. Thanks you, Piotr

1 0

Re: msvcrt: Fix strtok_s for an empty string.
by Piotr Caban 18 Aug '16

18 Aug '16

Hi Bernhard, On 08/18/16 03:48, Bernhard Übelacker wrote: > + old_handler = p_set_invalid_parameter_handler(test_strtok_s_handler); I'm not sure if it makes sense to set invalid parameter handler taking in account it's never called. If you don't set it and it's called the tests will crash. > + context = (char*)0xdeadbeef; > + strret = p__mbstok_s( test, "/", &context); This will cause compilation warnings (signedness mismatch). Thanks, Piotr

2 1

Re: ntdll/tests: Dump the handle table on failure.
by Huw Davies 18 Aug '16

18 Aug '16

> On 17 Aug 2016, at 14:54, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > > On 17.08.2016 14:45, Huw Davies wrote: >> Signed-off-by: Huw Davies <huw(a)codeweavers.com> >> --- >> dlls/ntdll/tests/info.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> > > I assume this is for bug 40106, right? I also investigated it back then, > and it looked like a kernel bug to me. If I remember correctly it was > somehow triggered by a large number of allocated handles. Yes, I was wondering whether it was a simple as needing to compare the LOWORD of the handle. Huw.

2 3

Re: [v4 PATCH] kernel32: Fix RegisterWaitForSingleObject for console handles
by Marvin 18 Aug '16

18 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25182 Your paranoid android. === w8 (32 bit console) === console.c:1497: Test failed: [13] Expected output count to be 0, got 1354796060 console.c:1497: Test failed: [15] Expected output count to be 0, got 1354796060 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 1354796060 console.c:1741: Test failed: [13] Expected output count to be 0, got 1354796060 console.c:1741: Test failed: [15] Expected output count to be 0, got 1354796060 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 1354796060 === w864 (32 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 1429009712 console.c:1497: Test failed: [15] Expected output count to be 0, got 1429009712 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 1429009712 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 1429009712 console.c:1741: Test failed: [15] Expected output count to be 0, got 1429009712 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 1429009712 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 4210212470 console.c:1497: Test failed: [15] Expected output count to be 0, got 4210212470 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 4210212470 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 4210212470 console.c:1741: Test failed: [15] Expected output count to be 0, got 4210212470 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 4210212470 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1

1 0

wine-1.8.4-rc2 Available
by Michael Stefaniuc 17 Aug '16

17 Aug '16

Hello guys, wine-1.8.4-rc2 is now available, including the tag: https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Three more fixes added on Nikolay's request: - t2embed: Fix TTIsEmbeddingEnabled() to properly use otmpFaceName metrics field. - dwrite: Sanitize specified stretch value, valid range is [1, 9]. - dwrite: Fix font stretch name conversion table. As the release commit changed this will be a forced update. bye michael

1 1

Re: [v3 PATCH] kernel32: Fix RegisterWaitForSingleObject for console handles
by Sebastian Lackner 17 Aug '16

17 Aug '16

On 17.08.2016 21:02, Keno Fischer wrote: > Minimal change from v2, just an extra Sleep(100) before UnregisterWait > to hopefully fix the failure identified by the testbot. > > > 0001-kernel32-Fix-RegisterWaitForSingleObject-for-console.patch > > > From 50347e64eedb1c07f1c9aedf253ec78eac4d3476 Mon Sep 17 00:00:00 2001 > From: Keno Fischer <keno(a)juliacomputing.com> > Date: Tue, 16 Aug 2016 14:35:27 -0400 > Subject: [PATCH] kernel32: Fix RegisterWaitForSingleObject for console handles > > WaitForSingleObject contains a special case to wait on the correct > handle if the passed in handle is a console object. However, > RegisterWaitForSingleObject was missing this special case. This > functionality was used e.g., by the libuv I/O library, causing > any users thereof to not receive input under wine, > e.g. fixes https://github.com/JuliaLang/julia/issues/18006. > > Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> > --- > dlls/kernel32/sync.c | 37 +++++++++++++++-------------- > dlls/kernel32/tests/console.c | 54 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 74 insertions(+), 17 deletions(-) > Thanks for all your effort to get this bug fixed. :) Unfortunately you'll have to send another iteration, C++ - style comments ("//") are not allowed in Wine source code, only C-style comments ("/* ... */"). If you don't mind, I also have some other suggestions how to improve the code a bit. > diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c > index c10fd01..2d6625b 100644 > --- a/dlls/kernel32/sync.c > +++ b/dlls/kernel32/sync.c > @@ -148,6 +148,23 @@ DWORD WINAPI WaitForMultipleObjects( DWORD count, const HANDLE *handles, > return WaitForMultipleObjectsEx( count, handles, wait_all, timeout, FALSE ); > } > > +static HANDLE NormalizeHandleIfConsole(HANDLE handle) Usually lowercase names (with underscores) are preferred for Wine internal functions, otherwise it looks like a WINAPI function. ;) > +{ > + if ((handle == (HANDLE)STD_INPUT_HANDLE) || > + (handle == (HANDLE)STD_OUTPUT_HANDLE) || > + (handle == (HANDLE)STD_ERROR_HANDLE)) > + handle = GetStdHandle( HandleToULong(handle) ); > + > + /* yes, even screen buffer console handles are waitable, and are > + * handled as a handle to the console itself !! > + */ > + if (is_console_handle(handle)) > + { > + if (VerifyConsoleIoHandle(handle)) > + handle = GetConsoleInputWaitHandle(); > + } > + return handle; > +} > > /*********************************************************************** > * WaitForMultipleObjectsEx (KERNEL32.@) > @@ -167,23 +184,7 @@ DWORD WINAPI WaitForMultipleObjectsEx( DWORD count, const HANDLE *handles, > return WAIT_FAILED; > } > for (i = 0; i < count; i++) > - { > - if ((handles[i] == (HANDLE)STD_INPUT_HANDLE) || > - (handles[i] == (HANDLE)STD_OUTPUT_HANDLE) || > - (handles[i] == (HANDLE)STD_ERROR_HANDLE)) > - hloc[i] = GetStdHandle( HandleToULong(handles[i]) ); > - else > - hloc[i] = handles[i]; > - > - /* yes, even screen buffer console handles are waitable, and are > - * handled as a handle to the console itself !! > - */ > - if (is_console_handle(hloc[i])) > - { > - if (VerifyConsoleIoHandle(hloc[i])) > - hloc[i] = GetConsoleInputWaitHandle(); > - } > - } > + hloc[i] = NormalizeHandleIfConsole(handles[i]); > > status = NtWaitForMultipleObjects( count, hloc, !wait_all, alertable, > get_nt_timeout( &time, timeout ) ); > @@ -209,6 +210,7 @@ BOOL WINAPI RegisterWaitForSingleObject(PHANDLE phNewWaitObject, HANDLE hObject, > TRACE("%p %p %p %p %d %d\n", > phNewWaitObject,hObject,Callback,Context,dwMilliseconds,dwFlags); > > + hObject = NormalizeHandleIfConsole(hObject); > status = RtlRegisterWait( phNewWaitObject, hObject, Callback, Context, dwMilliseconds, dwFlags ); > if (status != STATUS_SUCCESS) > { > @@ -231,6 +233,7 @@ HANDLE WINAPI RegisterWaitForSingleObjectEx( HANDLE hObject, > TRACE("%p %p %p %d %d\n", > hObject,Callback,Context,dwMilliseconds,dwFlags); > > + hObject = NormalizeHandleIfConsole(hObject); > status = RtlRegisterWait( &hNewWaitObject, hObject, Callback, Context, dwMilliseconds, dwFlags ); > if (status != STATUS_SUCCESS) > { > diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c > index 5b66d9f..88ef2b8 100644 > --- a/dlls/kernel32/tests/console.c > +++ b/dlls/kernel32/tests/console.c > @@ -908,6 +908,58 @@ static void testScreenBuffer(HANDLE hConOut) > SetConsoleOutputCP(oldcp); > } > > +static void CALLBACK signaled_function(void *p, BOOLEAN timeout) > +{ > + HANDLE event = p; > + SetEvent(event); > + ok(!timeout, "wait shouldn't have timed out\n"); > +} > + > +static void testWaitForConsoleInput(HANDLE input_handle) > +{ > + HANDLE wait_handle; > + HANDLE complete_event; > + INPUT_RECORD record; > + DWORD events_written; > + DWORD wait_ret; > + BOOL ret; > + > + complete_event = CreateEventW(NULL, FALSE, FALSE, NULL); > + > + // Test success case > + ret = RegisterWaitForSingleObject(&wait_handle, input_handle, signaled_function, complete_event, INFINITE, WT_EXECUTEONLYONCE); > + ok(ret == TRUE, "Expected RegisterWaitForSingleObject to return TRUE, got %d\n", ret); > + /* give worker thread a chance to start up */ > + Sleep(100); > + record.EventType = KEY_EVENT; > + record.Event.KeyEvent.bKeyDown = 1; > + record.Event.KeyEvent.wRepeatCount = 1; > + record.Event.KeyEvent.wVirtualKeyCode = VK_RETURN; > + record.Event.KeyEvent.wVirtualScanCode = VK_RETURN; > + record.Event.KeyEvent.uChar.UnicodeChar = L'\r'; The L prefix should be omitted here. Wine can't use the Compilers wchar_t features because they might have a different size than WCHAR on Windows. > + record.Event.KeyEvent.dwControlKeyState = 0; > + ret = WriteConsoleInputW(input_handle, &record, 1, &events_written); > + ok(ret == TRUE, "Expected WriteConsoleInputW to return TRUE, got %d\n", ret); > + wait_ret = WaitForSingleObject(complete_event, INFINITE); > + ok(wait_ret == WAIT_OBJECT_0, "Expected the handle to be signaled\n"); > + /* give worker thread chance to complete */ > + Sleep(100); > + ret = UnregisterWait(wait_handle); > + ok(ret, "UnregisterWait failed with error %d\n", GetLastError()); According to MSDN "If any callback functions associated with the timer have not completed when UnregisterWait is called, UnregisterWait unregisters the wait on the callback functions and fails with the ERROR_IO_PENDING error code. The error code does not indicate that the function has failed, and the function does not need to be called again." Since tests should always run as quickly as possible I would suggest to omit the Sleep and remove the return value check here (or if you prefer, explicitly treat ERROR_IO_PENDING as success). > + > + // Test timeout case > + FlushConsoleInputBuffer(input_handle); > + ret = RegisterWaitForSingleObject(&wait_handle, input_handle, signaled_function, complete_event, INFINITE, WT_EXECUTEONLYONCE); > + wait_ret = WaitForSingleObject(complete_event, 100); > + ok(wait_ret == WAIT_TIMEOUT, "Expected the wait to time out\n"); > + ret = UnregisterWait(wait_handle); > + ok(ret, "UnregisterWait failed with error %d\n", GetLastError()); > + > + // Clean up > + ret = CloseHandle(complete_event); > + ok(!!ret, "Failed to close event handle, last error %#x.\n", GetLastError()); CloseHandle returns a BOOL, so there should be no need to use "!!". Also I would suggest to use a consistent way of tracing GetLastError() within the patch, above you used "%d". > +} > + > static void test_GetSetConsoleInputExeName(void) > { > BOOL ret; > @@ -3044,6 +3096,8 @@ START_TEST(console) > testScroll(hConOut, sbi.dwSize); > /* will test sb creation / modification / codepage handling */ > testScreenBuffer(hConOut); > + /* Test waiting for a console handle */ > + testWaitForConsoleInput(hConIn); > > /* clear duplicated console font table */ > CloseHandle(hConIn); > -- 2.7.4 > > >

1 0

Re: gdiplus: Reimplement metafile loading using gdi32 instead of IPicture.
by Vincent Povirk 17 Aug '16

17 Aug '16

I'd probably be OK with this as-is, but since you asked for feedback: > @@ -2219,12 +2155,6 @@ GpStatus WINGDIPAPI GdipGetImageBounds(GpImage *image, GpRectF *srcRect, > srcRect->Height = (REAL) ((GpBitmap*)image)->height; > *srcUnit = UnitPixel; > } > - else{ > - srcRect->X = srcRect->Y = 0.0; > - srcRect->Width = ipicture_pixel_width(image->picture); > - srcRect->Height = ipicture_pixel_height(image->picture); > - *srcUnit = UnitPixel; > - } > > TRACE("returning (%f, %f) (%f, %f) unit type %d\n", srcRect->X, srcRect->Y, > srcRect->Width, srcRect->Height, *srcUnit); Even for ipicture metafiles, this case wasn't really used before, except when given an invalid image object (type isn't bitmap or metafile) where it would likely crash. We should probably return InvalidParameter here. Same with the other GdipGetImage* functions where we're removing else clauses. I am OK with the simplified error handling from IStream_Read. > + hr = IStream_Read(stream, buf, emh.nBytes, &size); > + if (hr == S_OK && size == emh.nBytes) > + { > + hemf = SetEnhMetaFileBits(emh.nBytes, buf); > + if (hemf) > + { > + status = GdipCreateMetafileFromEmf(hemf, TRUE, metafile); > + if (status != Ok) > + DeleteEnhMetaFile(hemf); > + } > } > > + heap_free(buf); > + return status; > +} I guess this works, but it's kind of confusing how status gets set here when IStream_Read or SetEnhMetaFileBits fails. I'd rather it be set closer to the failure.

2 1

Re: [v3 PATCH] kernel32: Fix RegisterWaitForSingleObject for console handles
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25178 Your paranoid android. === w8 (32 bit console) === console.c:1497: Test failed: [13] Expected output count to be 0, got 2297442973 console.c:1497: Test failed: [15] Expected output count to be 0, got 2297442973 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 2297442973 console.c:1741: Test failed: [13] Expected output count to be 0, got 2297442973 console.c:1741: Test failed: [15] Expected output count to be 0, got 2297442973 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 2297442973 === w864 (32 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 2437813945 console.c:1497: Test failed: [15] Expected output count to be 0, got 2437813945 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 2437813945 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 2437813945 console.c:1741: Test failed: [15] Expected output count to be 0, got 2437813945 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 2437813945 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [13] Expected output count to be 0, got 4156894918 console.c:1497: Test failed: [15] Expected output count to be 0, got 4156894918 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 4156894918 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [13] Expected output count to be 0, got 4156894918 console.c:1741: Test failed: [15] Expected output count to be 0, got 4156894918 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 4156894918 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2619: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2625: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2632: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2639: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1322: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1497: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1497: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1741: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2200: Test failed: [7] Expected count to be 0, got 1 console.c:2266: Test failed: [7] Expected count to be 0, got 1 console.c:2332: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [v2 PATCH] kernel32: Fix RegisterWaitForSingleObject for console handles
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25177 Your paranoid android. === w8 (32 bit console) === console.c:946: Test failed: UnregisterWait failed with error 997 console.c:1495: Test failed: [13] Expected output count to be 0, got 1795086881 console.c:1495: Test failed: [15] Expected output count to be 0, got 1795086881 console.c:1495: Test failed: [18] Expected output count to be 3735928559, got 1795086881 console.c:1739: Test failed: [13] Expected output count to be 0, got 1795086881 console.c:1739: Test failed: [15] Expected output count to be 0, got 1795086881 console.c:1739: Test failed: [18] Expected output count to be 3735928559, got 1795086881 === w864 (32 bit console) === console.c:2617: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2623: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2630: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2637: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:946: Test failed: UnregisterWait failed with error 997 console.c:1320: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1495: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [13] Expected output count to be 0, got 3132035615 console.c:1495: Test failed: [15] Expected output count to be 0, got 3132035615 console.c:1495: Test failed: [18] Expected output count to be 3735928559, got 3132035615 console.c:1739: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [13] Expected output count to be 0, got 3132035615 console.c:1739: Test failed: [15] Expected output count to be 0, got 3132035615 console.c:1739: Test failed: [18] Expected output count to be 3735928559, got 3132035615 console.c:2198: Test failed: [7] Expected count to be 0, got 1 console.c:2264: Test failed: [7] Expected count to be 0, got 1 console.c:2330: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2617: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2623: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2630: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2637: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:946: Test failed: UnregisterWait failed with error 997 console.c:1320: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1495: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [13] Expected output count to be 0, got 2323415655 console.c:1495: Test failed: [15] Expected output count to be 0, got 2323415655 console.c:1495: Test failed: [18] Expected output count to be 3735928559, got 2323415655 console.c:1739: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [13] Expected output count to be 0, got 2323415655 console.c:1739: Test failed: [15] Expected output count to be 0, got 2323415655 console.c:1739: Test failed: [18] Expected output count to be 3735928559, got 2323415655 console.c:2198: Test failed: [7] Expected count to be 0, got 1 console.c:2264: Test failed: [7] Expected count to be 0, got 1 console.c:2330: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2617: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2623: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2630: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2637: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:946: Test failed: UnregisterWait failed with error 997 console.c:1320: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1495: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2198: Test failed: [7] Expected count to be 0, got 1 console.c:2264: Test failed: [7] Expected count to be 0, got 1 console.c:2330: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2617: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2623: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2630: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2637: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:946: Test failed: UnregisterWait failed with error 997 console.c:1320: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1495: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1495: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1739: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2198: Test failed: [7] Expected count to be 0, got 1 console.c:2264: Test failed: [7] Expected count to be 0, got 1 console.c:2330: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH] kernel32: Add GetNumberFormatEx
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25170 Your paranoid android. === w1064 (32 bit locale) === locale.c:2554: Test failed: LCMapStringEx should fail with bad locale name locale.c:2555: Test failed: unexpected error code -559038737 locale.c:2646: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4376: Test failed: IsValidLocaleName should have failed locale.c:4378: Test failed: IsValidLocaleName should have failed locale.c:4761: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4763: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2554: Test failed: LCMapStringEx should fail with bad locale name locale.c:2555: Test failed: unexpected error code -559038737 locale.c:2646: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4376: Test failed: IsValidLocaleName should have failed locale.c:4378: Test failed: IsValidLocaleName should have failed locale.c:4761: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4763: Test failed: For id 7, Expected IVC, got ''

2 1

Compilation with winegcc vs compilation in Wine source
by Ruslan Kabatsayev 17 Aug '16

17 Aug '16

Hello all, I'm trying to integrate my program into Wine source and having some difficulties with doing OpenGL calls. Namely, when I compile the program with mingw and with winegcc, it works flawlessly. But when I integrate it into Wine source tree (taking regedit as an example), stack appears smashed after OpenGL calls. Here's what my command line looks like with winegcc (written by me manually): # compilation winegcc -c wgl.c -o wgl.o -g -m32 -municode -DUNICODE -D_UNICODE -g # linking winegcc main.o wgl.o d3d8.o d3d9.o texture.o common.o demo-res.o -lopengl32 -ld3d8 -ld3d9 -ld3dx9 -lgdi32 -lgdiplus -lglu32 -lole32 -lshell32 -lmsvcrt -o 3d-demo.exe -g -m32 -municode And the function where the crash happens looks like: 00012839 <initLightAndMaterial>: 12839: 55 push ebp 1283a: 89 e5 mov ebp,esp 1283c: 53 push ebx 1283d: 83 ec 24 sub esp,0x24 12840: e8 02 f1 ff ff call 11947 <__i686.get_pc_thunk.bx> 12845: 81 c3 17 5f 00 00 add ebx,0x5f17 1284b: b8 00 00 00 00 mov eax,0x0 12850: 89 45 e8 mov DWORD PTR [ebp-0x18],eax 12853: b8 00 00 00 00 mov eax,0x0 12858: 89 45 ec mov DWORD PTR [ebp-0x14],eax 1285b: b8 00 00 00 00 mov eax,0x0 12860: 89 45 f0 mov DWORD PTR [ebp-0x10],eax 12863: b8 00 00 80 3f mov eax,0x3f800000 12868: 89 45 f4 mov DWORD PTR [ebp-0xc],eax 1286b: 8d 45 e8 lea eax,[ebp-0x18] 1286e: 89 44 24 04 mov DWORD PTR [esp+0x4],eax 12872: c7 04 24 53 0b 00 00 mov DWORD PTR [esp],0xb53 12879: e8 92 f1 ff ff call 11a10 <glLightModelfv> 1287e: 83 ec 08 sub esp,0x8 12881: 8b 5d fc mov ebx,DWORD PTR [ebp-0x4] 12884: c9 leave 12885: c3 ret And here's the command from Wine tree (generated by its build system): # compilation /usr/lib/ccache/gcc-4.5 -c -o wgl.o wgl.c -I. -I../../include -I../../include/msvcrt -D__WINESRC__ -D_REENTRANT -fPIC \ -fno-builtin -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g # linking ../../tools/winegcc/winegcc -o 3d-demo.exe.so -B../../tools/winebuild -fasynchronous-unwind-tables -mwindows \ -municode -mno-cygwin d3d8.o d3d9.o wgl.o main.o common.o texture.o demo.res -luser32 -lgdi32 \ -lgdiplus -lopengl32 -lglu32 -ld3d8 -ld3d9 -ld3dx9 -lole32 -lshell32 -lmsvcrt \ ../../libs/port/libwine_port.a And the resulting function looks like 00014f8e <initLightAndMaterial>: 14f8e: 55 push ebp 14f8f: 89 e5 mov ebp,esp 14f91: 53 push ebx 14f92: 83 ec 24 sub esp,0x24 14f95: e8 8d c9 ff ff call 11927 <__i686.get_pc_thunk.bx> 14f9a: 81 c3 be 42 00 00 add ebx,0x42be 14fa0: b8 00 00 00 00 mov eax,0x0 14fa5: 89 45 e8 mov DWORD PTR [ebp-0x18],eax 14fa8: b8 00 00 00 00 mov eax,0x0 14fad: 89 45 ec mov DWORD PTR [ebp-0x14],eax 14fb0: b8 00 00 00 00 mov eax,0x0 14fb5: 89 45 f0 mov DWORD PTR [ebp-0x10],eax 14fb8: b8 00 00 80 3f mov eax,0x3f800000 14fbd: 89 45 f4 mov DWORD PTR [ebp-0xc],eax 14fc0: 8d 45 e8 lea eax,[ebp-0x18] 14fc3: 89 44 24 04 mov DWORD PTR [esp+0x4],eax 14fc7: c7 04 24 53 0b 00 00 mov DWORD PTR [esp],0xb53 14fce: e8 9d cb ff ff call 11b70 <glLightModelfv> 14fd3: 83 c4 24 add esp,0x24 14fd6: 5b pop ebx 14fd7: 5d pop ebp 14fd8: c3 ret The C code for the function looked like static void initLightAndMaterial(void) { const GLfloat globalAmbient[4]={0,0,0,1}; glLightModelfv(GL_LIGHT_MODEL_AMBIENT,globalAmbient); } And this is my Makefile.in (the function is defined in wgl.c): #--------------------------------------------- MODULE = 3d-demo.exe APPMODE = -mwindows -municode -mno-cygwin IMPORTS = user32 gdi32 gdiplus opengl32 glu32 d3d8 d3d9 d3dx9 ole32 shell32 msvcrt C_SRCS = \ d3d8.c \ d3d9.c \ wgl.c \ main.c \ common.c \ texture.c RC_SRCS = demo.rc INSTALL_LIB = 3d-demo.exe 3d-demo #--------------------------------------- Apparently in-tree compilation assumes another calling convention for glLightModelfv here... What could be the reason for this? How should I set up my Makefile.in so that it generated a result compatible with opengl32 calling convention? Thanks, Ruslan

2 7

Re: gdiplus: Reimplement metafile loading using gdi32 instead of IPicture.
by Nikolay Sivov 17 Aug '16

17 Aug '16

On 17.08.2016 11:26, Sebastian Lackner wrote: > +static GpStatus load_wmf(IStream *stream, GpMetafile **metafile) > +{ > + WmfPlaceableFileHeader pfh; > + GpStatus status = GenericError; > + BOOL is_placeable = FALSE; > + LARGE_INTEGER seek; > + METAHEADER mh; > + HMETAFILE hmf; > + HRESULT hr; > + UINT size; > + void *buf; > + > + hr = IStream_Read(stream, &mh, sizeof(mh), &size); > + if (hr != S_OK || size != sizeof(mh)) > + return GenericError; > + > + if (mh.mtType == 0xcdd7 && mh.mtHeaderSize == 0x9ac6) It'd be more readable to test this as UINT32 it's supposed to be, and having this constant defined to GDIP_WMF_PLACEABLEKEY (locally in gdiplus, it's only mentioned in comment in SDK) will help looking it up. > + { > + is_placeable = TRUE; > + > + seek.QuadPart = 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + hr = IStream_Read(stream, &pfh, sizeof(pfh), &size); > + if (hr != S_OK || size != sizeof(pfh)) > + return GenericError; > + > + hr = IStream_Read(stream, &mh, sizeof(mh), &size); > + if (hr != S_OK || size != sizeof(mh)) > + return GenericError; > + } > + > + seek.QuadPart = is_placeable ? sizeof(pfh) : 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + buf = heap_alloc(mh.mtSize * 2); > + if (!buf) return OutOfMemory; > + > + hr = IStream_Read(stream, buf, mh.mtSize * 2, &size); > + if (hr == S_OK && size == mh.mtSize * 2) > + { > + hmf = SetMetaFileBitsEx(mh.mtSize * 2, buf); > + if (hmf) > + { > + status = GdipCreateMetafileFromWmf(hmf, TRUE, is_placeable ? &pfh : NULL, metafile); > + if (status != Ok) > + DeleteMetaFile(hmf); > + } > + } > + > + heap_free(buf); > + return status; > +} > + > +static GpStatus decode_image_wmf(IStream *stream, GpImage **image) > { > - IPicture *pic; > + GpMetafile *metafile; > + GpStatus status; > > TRACE("%p %p\n", stream, image); > > - if(!stream || !image) > + if (!stream || !image) > return InvalidParameter; > > - if(OleLoadPicture(stream, 0, FALSE, &IID_IPicture, > - (LPVOID*) &pic) != S_OK){ > - TRACE("Could not load picture\n"); > + status = load_wmf(stream, &metafile); > + if (status != Ok) > + { > + TRACE("Could not load metafile\n"); > + return status; > + } > + > + *image = (GpImage *)metafile; > + TRACE("<-- %p\n", *image); > + > + return Ok; > +} > + > +static GpStatus load_emf(IStream *stream, GpMetafile **metafile) > +{ > + GpStatus status = GenericError; > + LARGE_INTEGER seek; > + ENHMETAHEADER emh; > + HENHMETAFILE hemf; > + HRESULT hr; > + UINT size; > + void *buf; > + > + hr = IStream_Read(stream, &emh, sizeof(emh), &size); > + if (hr != S_OK || size != sizeof(emh) || emh.dSignature != ENHMETA_SIGNATURE) > return GenericError; > + > + seek.QuadPart = 0; > + hr = IStream_Seek(stream, seek, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) return hresult_to_status(hr); > + > + buf = heap_alloc(emh.nBytes); > + if (!buf) return OutOfMemory; > + > + hr = IStream_Read(stream, buf, emh.nBytes, &size); > + if (hr == S_OK && size == emh.nBytes) > + { > + hemf = SetEnhMetaFileBits(emh.nBytes, buf); > + if (hemf) > + { > + status = GdipCreateMetafileFromEmf(hemf, TRUE, metafile); > + if (status != Ok) > + DeleteEnhMetaFile(hemf); > + } > } > > - /* FIXME: missing initialization code */ > - *image = heap_alloc_zero(sizeof(GpMetafile)); > - if(!*image) return OutOfMemory; > - (*image)->type = ImageTypeMetafile; > - (*image)->decoder = NULL; > - (*image)->picture = pic; > - (*image)->flags = ImageFlagsNone; > - (*image)->frame_count = 1; > - (*image)->current_frame = 0; > - (*image)->palette = NULL; > - list_init(&(*(GpMetafile**)image)->containers); > + heap_free(buf); > + return status; > +} > + > +static GpStatus decode_image_emf(IStream *stream, GpImage **image) > +{ > + GpMetafile *metafile; > + GpStatus status; > + > + TRACE("%p %p\n", stream, image); > + > + if (!stream || !image) > + return InvalidParameter; > + > + status = load_emf(stream, &metafile); > + if (status != Ok) > + { > + TRACE("Could not load metafile\n"); > + return status; > + } > > + *image = (GpImage *)metafile; > TRACE("<-- %p\n", *image); > > return Ok; > @@ -4721,7 +4750,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ emf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_emf, > NULL > }, > { > @@ -4741,7 +4770,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ wmf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_wmf, > NULL > }, > { > diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c > index a854e55..8b93e81 100644 > --- a/dlls/gdiplus/metafile.c > +++ b/dlls/gdiplus/metafile.c > @@ -317,7 +317,6 @@ GpStatus WINGDIPAPI GdipRecordMetafile(HDC hdc, EmfType type, GDIPCONST GpRectF > } > > (*metafile)->image.type = ImageTypeMetafile; > - (*metafile)->image.picture = NULL; > (*metafile)->image.flags = ImageFlagsNone; > (*metafile)->image.palette = NULL; > (*metafile)->image.xres = dpix; > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index ad84feb..cabd2fce 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -1446,19 +1446,19 @@ static void test_loadwmf(void) > > stat = GdipGetImageBounds(img, &bounds, &unit); > expect(Ok, stat); > - todo_wine expect(UnitPixel, unit); > + expect(UnitPixel, unit); > expectf(0.0, bounds.X); > expectf(0.0, bounds.Y); > - todo_wine expectf(320.0, bounds.Width); > - todo_wine expectf(320.0, bounds.Height); > + expectf(320.0, bounds.Width); > + expectf(320.0, bounds.Height); > > stat = GdipGetImageHorizontalResolution(img, &res); > expect(Ok, stat); > - todo_wine expectf(1440.0, res); > + expectf(1440.0, res); > > stat = GdipGetImageVerticalResolution(img, &res); > expect(Ok, stat); > - todo_wine expectf(1440.0, res); > + expectf(1440.0, res); > > memset(&header, 0, sizeof(header)); > stat = GdipGetMetafileHeaderFromMetafile((GpMetafile*)img, &header); >

2 1

Re: [PATCH 1/2] user32/tests: Add more tests for setting window styles.
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25155 Your paranoid android. === w7u (32 bit win) === win.c:8644: Test failed: assigned and retrieved update regions are different win.c:8645: Test failed: has invalid area after ValidateRgn(NULL) win.c:8662: Test failed: wrong update region win.c:8667: Test failed: wrong update region win.c:8674: Test failed: wrong update region

2 1

Re: [PATCH] d3d11: Support D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS in ID3D11Device CheckFeatureSupport
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === build (build) === Make failed

3 2

Re: [PATCH] d3d11: Support D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS in ID3D11Device CheckFeatureSupport
by Józef Kucia 17 Aug '16

17 Aug '16

This patch is probably fine because I don't expect that we will expose compute shaders in SM4 (at least initially). On Wed, Aug 17, 2016 at 8:52 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d11/device.c | 12 ++++++++++++ > dlls/d3d11/tests/d3d11.c | 18 ++++++++++++++++++ > include/d3d11.idl | 5 +++++ > 3 files changed, 35 insertions(+) > > diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c > index df5a4ac..6142ac0 100644 > --- a/dlls/d3d11/device.c > +++ b/dlls/d3d11/device.c > @@ -3463,6 +3463,18 @@ static HRESULT STDMETHODCALLTYPE d3d11_device_CheckFeatureSupport(ID3D11Device * > threading_data->DriverCommandLists = FALSE; > return S_OK; > } > + case D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS: > + { > + D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS *options = feature_support_data; > + if (feature_support_data_size != sizeof(*options)) > + { > + WARN("Invalid data size.\n"); > + return E_INVALIDARG; > + } > + > + options->ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x = FALSE; > + return S_OK; > + } > > default: > FIXME("Unhandled feature %#x.\n", feature); > diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c > index 330a960..962682d 100644 > --- a/dlls/d3d11/tests/d3d11.c > +++ b/dlls/d3d11/tests/d3d11.c > @@ -9188,6 +9188,7 @@ static void test_null_sampler(void) > static void test_check_feature_support(void) > { > D3D11_FEATURE_DATA_THREADING threading[2]; > + D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS hwopts; This is not important but I would name it d3d10_hw_opts or d3d10_opts. > ID3D11Device *device; > ULONG refcount; > HRESULT hr; > @@ -9229,6 +9230,23 @@ static void test_check_feature_support(void) > ok(threading->DriverCommandLists == TRUE || threading->DriverCommandLists == FALSE, > "Got unexpected command lists %#x.\n", threading->DriverCommandLists); > > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, NULL, 0); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, 0); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) - 1); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) / 2); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) + 1); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts) * 2); > + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); > + > + hr = ID3D11Device_CheckFeatureSupport(device, D3D11_FEATURE_D3D10_X_HARDWARE_OPTIONS, &hwopts, sizeof(hwopts)); > + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); > + trace("Shader support %#x.\n", hwopts.ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4); It should be "ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x". Besides, the trace() message could more clear, e.g. "Compute shader support via SM4". > + > refcount = ID3D11Device_Release(device); > ok(!refcount, "Device has %u references left.\n", refcount); > } > diff --git a/include/d3d11.idl b/include/d3d11.idl > index cd177c2..767321b 100644 > --- a/include/d3d11.idl > +++ b/include/d3d11.idl > @@ -445,6 +445,11 @@ typedef struct D3D11_FEATURE_DATA_THREADING > BOOL DriverCommandLists; > } D3D11_FEATURE_DATA_THREADING; > > +typedef struct D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS > +{ > + BOOL ComputeShaders_Plus_RawAndStructuredBuffers_Via_Shader_4_x; > +} D3D11_FEATURE_DATA_D3D10_X_HARDWARE_OPTIONS; > + > typedef struct D3D11_FEATURE_DATA_D3D11_OPTIONS > { > BOOL OutputMergerLogicOp; > -- > 2.8.1 > > >

1 0

Re: [3/4] msvcirt: Add predefined streams.
by Piotr Caban 17 Aug '16

17 Aug '16

Hi, On 08/17/16 12:57, Iván Matellanes wrote: > + if ((fb = MSVCRT_operator_new(sizeof(filebuf)))) { > + filebuf_fd_ctor(fb, 0); > + istream_sb_ctor(&cin.is, &fb->base, TRUE); > + } else > + istream_sb_ctor(&cin.is, NULL, TRUE); > + Iostream_init_ios_ctor(NULL, &cin.vbase, 0); You should use istream_withassign_sb_ctor here. Thanks, Piotr

1 0

Re: [PATCH 4/6] ntdll: Add support for exceptions inside termination handlers in __C_specific_handler
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25148 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:516: Test failed: 42: Unexpected eip 0x340000/0x340001 exception: unhandled exception 80000004 at 00340000 exception.c:516: Test failed: 42: Unexpected eip 0x77baed97/0x340001 === w7u (32 bit exception) === exception.c:516: Test failed: 42: Unexpected eip 0x3d0000/0x3d0001 exception: unhandled exception 80000004 at 003D0000 exception.c:516: Test failed: 42: Unexpected eip 0x77cde34f/0x3d0001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

2 1

Re: [1/4] gdiplus: Implement playback/recording for SetClipRect.
by Sebastian Lackner 17 Aug '16

17 Aug '16

On 16.08.2016 23:00, Vincent Povirk wrote: > diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c > index a854e55..643d3c4 100644 > --- a/dlls/gdiplus/metafile.c > +++ b/dlls/gdiplus/metafile.c > @@ -70,6 +70,12 @@ typedef struct EmfPlusFillRects > DWORD Count; > } EmfPlusFillRects; > > +typedef struct EmfPlusSetClipRect > +{ > + EmfPlusRecordHeader Header; > + GpRectF ClipRect; There is a small whitespace error in the line above. > +} EmfPlusSetClipRect; > + > typedef struct EmfPlusSetPageTransform > { > EmfPlusRecordHeader Header;

1 0

Re: [PATCH] server/console: Allow waiting on console_input
by Alexandre Julliard 17 Aug '16

17 Aug '16

Keno Fischer <keno(a)juliacomputing.com> writes: > Please see attached. This fixes console input under wine for julia and > probably other programs using libuv. I am not particularly familiar > with wine internals, so please review closely. The right way is probably to fix RegisterWaitForSingleObject to handle console handles the same way WaitForSingleObject does. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/4] gdiplus: Load EMF images directly instead of through olepicture.
by Dmitry Timoshkov 17 Aug '16

17 Aug '16

Vincent Povirk <madewokherd(a)gmail.com> wrote: > @@ -4721,7 +4767,7 @@ static const struct image_codec codecs[NUM_CODECS] = { > /* SigMask */ emf_sig_mask, > }, > NULL, > - decode_image_olepicture_metafile, > + decode_image_emf, > NULL > }, This patch is very incomplete, and probably won't pass the 'make test'. wine-staging contains a pretty full and well tested patch that reimplements metafile loading in gdiplus using gdi32 APis: https://github.com/wine-compholio/wine-staging/blob/master/patches/oleaut32… it should be possible to either use it directly or as a base for your work. There are some other related patches in staging that touch the metafile loading in gdiplus. -- Dmitry.

3 2

Re: [PATCH 2/2] kernel32: Implement GetConsoleScreenBufferInfoEx
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25126 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3964615102 console.c:1445: Test failed: [15] Expected output count to be 0, got 3964615102 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3964615102 console.c:1689: Test failed: [13] Expected output count to be 0, got 3964615102 console.c:1689: Test failed: [15] Expected output count to be 0, got 3964615102 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3964615102 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 4007961408 console.c:1445: Test failed: [15] Expected output count to be 0, got 4007961408 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4007961408 console.c:1689: Test failed: [13] Expected output count to be 0, got 4007961408 console.c:1689: Test failed: [15] Expected output count to be 0, got 4007961408 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4007961408 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 564791309 console.c:1445: Test failed: [15] Expected output count to be 0, got 564791309 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 564791309 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 564791309 console.c:1689: Test failed: [15] Expected output count to be 0, got 564791309 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 564791309 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH 1/2] kernel32/tests: Add tests for GetConsoleScreenBufferInfoEx
by Marvin 17 Aug '16

17 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25125 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2191869370 console.c:1445: Test failed: [15] Expected output count to be 0, got 2191869370 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2191869370 console.c:1689: Test failed: [13] Expected output count to be 0, got 2191869370 console.c:1689: Test failed: [15] Expected output count to be 0, got 2191869370 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2191869370 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3647870754 console.c:1445: Test failed: [15] Expected output count to be 0, got 3647870754 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3647870754 console.c:1689: Test failed: [13] Expected output count to be 0, got 3647870754 console.c:1689: Test failed: [15] Expected output count to be 0, got 3647870754 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3647870754 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3382944356 console.c:1445: Test failed: [15] Expected output count to be 0, got 3382944356 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3382944356 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3382944356 console.c:1689: Test failed: [15] Expected output count to be 0, got 3382944356 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3382944356 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [PATCH] server/console: Allow waiting on console_input
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25120 Your paranoid android. === w8 (32 bit console) === console.c:1480: Test failed: [13] Expected output count to be 0, got 1510596369 console.c:1480: Test failed: [15] Expected output count to be 0, got 1510596369 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 1510596369 console.c:1724: Test failed: [13] Expected output count to be 0, got 1510596369 console.c:1724: Test failed: [15] Expected output count to be 0, got 1510596369 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 1510596369 === w864 (32 bit console) === console.c:1480: Test failed: [13] Expected output count to be 0, got 1764633039 console.c:1480: Test failed: [15] Expected output count to be 0, got 1764633039 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 1764633039 console.c:1724: Test failed: [13] Expected output count to be 0, got 1764633039 console.c:1724: Test failed: [15] Expected output count to be 0, got 1764633039 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 1764633039 === w1064 (32 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [13] Expected output count to be 0, got 2775085592 console.c:1480: Test failed: [15] Expected output count to be 0, got 2775085592 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 2775085592 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [13] Expected output count to be 0, got 2775085592 console.c:1724: Test failed: [15] Expected output count to be 0, got 2775085592 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 2775085592 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2602: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2608: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2615: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2622: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1305: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1480: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1480: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1724: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2183: Test failed: [7] Expected count to be 0, got 1 console.c:2249: Test failed: [7] Expected count to be 0, got 1 console.c:2315: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH] server/console: Allow waiting on console_input
by Sebastian Lackner 16 Aug '16

16 Aug '16

On 16.08.2016 20:47, Keno Fischer wrote: > Please see attached. This fixes console input under wine for julia and > probably other programs using libuv. I am not particularly familiar > with wine internals, so please review closely. > > Thanks, > Keno > > > 0001-server-console-Allow-waiting-on-console_input.patch > > > From 5fe78027f0034b83145c879adb17531e9487c6f7 Mon Sep 17 00:00:00 2001 > From: Keno Fischer <keno(a)juliacomputing.com> > Date: Tue, 16 Aug 2016 14:35:27 -0400 > Subject: [PATCH] server/console: Allow waiting on console_input > > It appears that Windows allows this for notification of new input > events in the console. This functionality was used e.g., by the libuv > I/O library, causing any users thereof to not receive input under wine, > e.g. fixes https://github.com/JuliaLang/julia/issues/18006. Thanks for working on this. I think the implementation is fine, however there are some small things which could be improved a bit. > > Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> > --- > dlls/kernel32/tests/console.c | 37 +++++++++++++++++++++++++++++++++++++ > server/console.c | 16 +++++++++++++--- > 2 files changed, 50 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c > index 5b66d9f..f97b415 100644 > --- a/dlls/kernel32/tests/console.c > +++ b/dlls/kernel32/tests/console.c > @@ -908,6 +908,41 @@ static void testScreenBuffer(HANDLE hConOut) > SetConsoleOutputCP(oldcp); > } > > +static void CALLBACK signaled_function(PVOID p, BOOLEAN TimerOrWaitFired) > +{ Usually wine prefers "void *" instead of PVOID and also lowercase variable names, so for example just "timeout" instead of "TimerOrWaitFired" as on MSDN. > + HANDLE event = p; > + SetEvent(event); > + ok(!TimerOrWaitFired, "wait shouldn't have timed out\n"); > +} > + > +static void testWaitForConsoleInput(HANDLE input_handle) > +{ > + HANDLE wait_handle; > + HANDLE complete_event; > + INPUT_RECORD record; > + DWORD events_written; > + DWORD wait_ret; > + BOOL ret; > + > + complete_event = CreateEventW(NULL, FALSE, FALSE, NULL); > + > + ret = RegisterWaitForSingleObject(&wait_handle, input_handle, signaled_function, complete_event, INFINITE, WT_EXECUTEONLYONCE); > + ok(ret == TRUE, "Expected RegisterWaitForSingleObject to return TRUE, got %d\n", ret); To keep the testcase similar to the original code thats probably fine, however I would like to point out that you do not really need an asynchronous wait here. You could basically test the same with WaitForSingleObject(input_handle, INFINITE). > + /* give worker thread a chance to start up */ > + Sleep(100); > + record.EventType = KEY_EVENT; > + record.Event.KeyEvent.bKeyDown = 1; > + record.Event.KeyEvent.wRepeatCount = 1; > + record.Event.KeyEvent.wVirtualKeyCode = VK_RETURN; > + record.Event.KeyEvent.wVirtualScanCode = VK_RETURN; > + record.Event.KeyEvent.uChar.AsciiChar = '\r'; If I don't miss anything this does not initialize the upper byte of the union. > + record.Event.KeyEvent.dwControlKeyState = 0; > + ret = WriteConsoleInputW(input_handle, &record, 1, &events_written); > + ok(ret == TRUE, "Expected WriteConsoleInputW to return TRUE, got %d\n", ret); > + wait_ret = WaitForSingleObject(complete_event, INFINITE); > + ok(wait_ret == WAIT_OBJECT_0, "Expected the handle to be signaled"); There is a linebreak missing in the line above. For completeness, it also wouldn't hurt to add another test after calling FlushConsoleInputBuffer() to make sure it times out as expected. If you want to keep the asynchronous wait, please also add cleanup of the complete_event and the wait_handle. > +} > + > static void test_GetSetConsoleInputExeName(void) > { > BOOL ret; > @@ -3044,6 +3079,8 @@ START_TEST(console) > testScroll(hConOut, sbi.dwSize); > /* will test sb creation / modification / codepage handling */ > testScreenBuffer(hConOut); > + /* Test waiting for a console handle */ > + testWaitForConsoleInput(hConIn); > > /* clear duplicated console font table */ > CloseHandle(hConIn); > diff --git a/server/console.c b/server/console.c > index 93f785a..376395d 100644 > --- a/server/console.c > +++ b/server/console.c > @@ -67,6 +67,7 @@ struct console_input > > static void console_input_dump( struct object *obj, int verbose ); > static void console_input_destroy( struct object *obj ); > +static int console_input_signaled( struct object *obj, struct wait_queue_entry *entry ); > static struct fd *console_input_get_fd( struct object *obj ); > > static const struct object_ops console_input_ops = > @@ -74,9 +75,9 @@ static const struct object_ops console_input_ops = > sizeof(struct console_input), /* size */ > console_input_dump, /* dump */ > no_get_type, /* get_type */ > - no_add_queue, /* add_queue */ > - NULL, /* remove_queue */ > - NULL, /* signaled */ > + add_queue, /* add_queue */ > + remove_queue, /* remove_queue */ > + console_input_signaled, /* signaled */ > no_satisfied, /* satisfied */ > no_signal, /* signal */ > console_input_get_fd, /* get_fd */ > @@ -543,6 +544,14 @@ static struct console_input* console_input_get( obj_handle_t handle, unsigned ac > return console; > } > > +/* the console input is signaled when it's not empty */ > +static int console_input_signaled( struct object *obj, struct wait_queue_entry *entry ) > +{ > + struct console_input *console = (struct console_input *)obj; > + assert( obj->ops == &console_input_ops ); > + return (console->recnum != 0); > +} > + > struct console_signal_info > { > struct console_input *console; > @@ -677,6 +686,7 @@ static int write_console_input( struct console_input* console, int count, > } > if (!console->recnum && count) set_event( console->event ); > console->recnum += count; > + wake_up( &console->obj, 0 ); > return count; > } > > -- 2.7.4 > > >

2 1

Re: kernel32/tests: Fill in the delay IAT to succeed on Win10
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25081 Your paranoid android. === wvistau64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:722: Test failed: 2: unexpected error 193 loader.c:722: Test failed: 3: unexpected error 193 loader.c:722: Test failed: 4: unexpected error 193 loader.c:722: Test failed: 6: unexpected error 193 loader.c:722: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784

1 0

Re: [PATCH 3/9] d3d9/tests: Add test for regression in IDirect3DDevice9_Reset().
by Marvin 16 Aug '16

16 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25061 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (32 bit d3d9ex) === d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2411: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2413: Test failed: Got unexpected hr 0, i=1.

1 0

Re: d3dx9: Add D3DXFrameFind stub.
by Nikolay Sivov 16 Aug '16

16 Aug '16

On 12.08.2016 13:00, Andrey Gusev wrote: > +D3DXFRAME * WINAPI D3DXFrameFind(const D3DXFRAME *frame_root, const char *name) > +{ > + FIXME("frame_root %p, name %s stub!\n", frame_root, debugstr_a(name)); > + > + return NULL; > +} This looks trivial enough to implement. It's probably just going from pFrameFirstChild -> pFrameSibling. The question is does it check grandchildren, but it's easy to test.

2 1

Re: [PATCH 2/2] d3drm: Implement IDirect3DRMViewport*::Clear. (v3 resend)
by Henri Verbeet 16 Aug '16

16 Aug '16

On 15 August 2016 at 21:50, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID)); Why not "driver = IID_IDirect3DRGBDevice;"? It probably also makes sense to introduce a helper function to create d3drm devices at some point. > + hr = IDirect3DMaterial_SetMaterial(viewport->material, &mat); > + > + return hr; "return IDirect3DMaterial_SetMaterial(viewport->material, &mat);" > + if (FAILED(hr = IDirect3DViewport_Clear(viewport->d3d_viewport, 1, &clear_rect, clear_flags))) > + return hr; Formatting.

1 0

Re: [PATCH] po: Update Simplified Chinese translation.
by Jactry Zeng 16 Aug '16

16 Aug '16

It looks good to me. Thanks! 2016-08-16 14:28 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 342 ++++++++++++++++++++++++++++++ > ------------------------------ > 1 file changed, 171 insertions(+), 171 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 2/9] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Henri Verbeet 16 Aug '16

16 Aug '16

On 16 August 2016 at 12:51, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > Or well, maybe I should hold off on that for a bit. It works here though.

2 1

Re: [PATCH] msvcrt: Add _wcreate_locale (try2)
by Piotr Caban 16 Aug '16

16 Aug '16

On 08/15/16 22:02, Daniel Lehman wrote: > + lcl = p_wcreate_locale(LC_ALL, german); You should probably skip this test on systems that doesn't support German locale. Thanks, Piotr

1 0

[v2 PATCH] inetcomm: Add MimeOleObjectFromMoniker stub
by Andrey Gusev 15 Aug '16

15 Aug '16

> FIXME("(0x%08x, %p, %p, %s, %p %p) stub\n", bindf, moniker, binding, debugstr_guid(riid), out, moniker_new); You missed a comma.

1 0

Re: [v4] riched20: allow setting background text color
by Huw Davies 15 Aug '16

15 Aug '16

On Sun, Aug 14, 2016 at 03:07:25PM -0600, Kenneth Haley wrote: > fixes https://bugs.winehq.org/show_bug.cgi?id=36625 Actually I missed that you hadn't added a Signed-off-by: line, git format-patch -s will do this for you. Please resend with one. Thanks, Huw.

1 0

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Sebastian Lackner 15 Aug '16

15 Aug '16

On 11.08.2016 19:27, Daniel Lehman wrote: > Some tests will fail but are unrelated to this patch: > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > https://urldefense.proofpoint.com/v2/url?u=http-3A__test.winehq.org_data_88… > > > 0001-ntdll-Set-Rip-in-for-longjmp-in-RtlRestoreContext.txt > > > From eaab70ee4ddc866526df0341853ccdb599cf7674 Mon Sep 17 00:00:00 2001 > From: Daniel Lehman <dlehman(a)esri.com> > Date: Mon, 1 Aug 2016 14:52:32 -0700 > Subject: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext > > Signed-off-by: Daniel Lehman <dlehman(a)esri.com> > --- > dlls/ntdll/signal_x86_64.c | 1 + > dlls/ntdll/tests/exception.c | 202 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 203 insertions(+) > > diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c > index 4c88536..598e08a 100644 > --- a/dlls/ntdll/signal_x86_64.c > +++ b/dlls/ntdll/signal_x86_64.c > @@ -3513,6 +3513,7 @@ void WINAPI RtlRestoreContext( CONTEXT *context, EXCEPTION_RECORD *rec ) > context->R13 = jmp->R13; > context->R14 = jmp->R14; > context->R15 = jmp->R15; > + context->Rip = jmp->Rip; > context->u.s.Xmm6 = jmp->Xmm6; > context->u.s.Xmm7 = jmp->Xmm7; > context->u.s.Xmm8 = jmp->Xmm8; Please note that this also modifies the behavior of RtlUnwindEx (which gets the target_ip passed directly as a function argument). With your change it will be ignored, which might need additional (at least manual) tests to make sure this is correct. > diff --git a/dlls/ntdll/tests/exception.c b/dlls/ntdll/tests/exception.c > index a086436..4846769 100644 > --- a/dlls/ntdll/tests/exception.c > +++ b/dlls/ntdll/tests/exception.c > @@ -53,10 +53,44 @@ static NTSTATUS (WINAPI *pNtSetInformationProcess)(HANDLE, PROCESSINFOCLASS, PV > static BOOL (WINAPI *pIsWow64Process)(HANDLE, PBOOL); > > #if defined(__x86_64__) > +typedef struct _SETJMP_FLOAT128 > +{ > + unsigned __int64 DECLSPEC_ALIGN(16) Part[2]; > +} SETJMP_FLOAT128; > + > +typedef struct _JUMP_BUFFER > +{ > + unsigned __int64 Frame; > + unsigned __int64 Rbx; > + unsigned __int64 Rsp; > + unsigned __int64 Rbp; > + unsigned __int64 Rsi; > + unsigned __int64 Rdi; > + unsigned __int64 R12; > + unsigned __int64 R13; > + unsigned __int64 R14; > + unsigned __int64 R15; > + unsigned __int64 Rip; > + unsigned __int64 Spare; > + SETJMP_FLOAT128 Xmm6; > + SETJMP_FLOAT128 Xmm7; > + SETJMP_FLOAT128 Xmm8; > + SETJMP_FLOAT128 Xmm9; > + SETJMP_FLOAT128 Xmm10; > + SETJMP_FLOAT128 Xmm11; > + SETJMP_FLOAT128 Xmm12; > + SETJMP_FLOAT128 Xmm13; > + SETJMP_FLOAT128 Xmm14; > + SETJMP_FLOAT128 Xmm15; > +} _JUMP_BUFFER; > + > static BOOLEAN (CDECL *pRtlAddFunctionTable)(RUNTIME_FUNCTION*, DWORD, DWORD64); > static BOOLEAN (CDECL *pRtlDeleteFunctionTable)(RUNTIME_FUNCTION*); > static BOOLEAN (CDECL *pRtlInstallFunctionTableCallback)(DWORD64, DWORD64, DWORD, PGET_RUNTIME_FUNCTION_CALLBACK, PVOID, PCWSTR); > static PRUNTIME_FUNCTION (WINAPI *pRtlLookupFunctionEntry)(ULONG64, ULONG64*, UNWIND_HISTORY_TABLE*); > +static VOID (WINAPI *pRtlCaptureContext)(CONTEXT*); > +static VOID (CDECL *pRtlRestoreContext)(CONTEXT*, EXCEPTION_RECORD*); > +static int (CDECL *p_setjmp)(_JUMP_BUFFER*); > #endif > > #ifdef __i386__ > @@ -1631,6 +1665,164 @@ static void test_virtual_unwind(void) > call_virtual_unwind( i, &tests[i] ); > } > > +static int consolidate_dummy_called; > +static PVOID CALLBACK test_consolidate_dummy(EXCEPTION_RECORD *rec) > +{ > + CONTEXT *ctx = (CONTEXT *)rec->ExceptionInformation[1]; > + consolidate_dummy_called = 1; > + ok(ctx->Rip == 0xdeadbeef, "test_consolidate_dummy failed for Rip, expected: 0xdeadbeef, got: %lx\n", ctx->Rip); > + return (PVOID)rec->ExceptionInformation[2]; > +} > + > +static void test_restore_context(void) > +{ > + XMM_SAVE_AREA32 *fltsave; > + EXCEPTION_RECORD rec; > + volatile int done; /* gcc 4.5.2 rearranges 'done' and RtlCaptureContext */ > + volatile int pass; A better way to make sure the compiler does not rearrange the code would be to use Interlocked*() functions. > + _JUMP_BUFFER buf; > + CONTEXT ctx; > + > + if (!pRtlRestoreContext || !pRtlCaptureContext || !p_setjmp) > + { > + skip("RtlCaptureContext/RtlRestoreContext/_setjmp not found\n"); > + return; > + } > + > + /* RtlRestoreContext(NULL, NULL); crashes on Windows */ > + > + /* test simple case of capture and restore context */ > + pass = 0; > + done = 0; > + pRtlCaptureContext(&ctx); > + switch (pass) > + { > + case 0: > + ok(!done, "done on first pass\n"); > + break; > + case 1: > + ok(done, "not done on second pass\n"); > + break; > + default: > + ok(0, "bad pass = %i done = %i\n", pass, done); > + break; > + } > + ++pass; > + if (done) goto test_longjmp; > + done = 1; I don't think the second variable adds much value here. A simplified version like below would test the same things: pass = 0; pRtlCaptureContext(&ctx); ok(pass < 2, "unexpected pass = %d\n", pass); if (!pass++) pRtlRestoreContext(&ctx, NULL); > + > + pRtlRestoreContext(&ctx, NULL); > + > +test_longjmp: I do not see any need to use goto here, regular if () checks would also do the job. > + fltsave = (XMM_SAVE_AREA32 *)((char*)&ctx + 0x100); It is better to avoid such hardcoded constants. Why not access the field directly? > + done = 0; > + pRtlCaptureContext(&ctx); What is the purpose of the RtlCaptureContext call here? The result does not seem to be used. After RtlRestoreContext() the ctx struct has been filled with the jump buffer values. > + p_setjmp(&buf); > + if (done) > + { > + ok(buf.Rbx == ctx.Rbx, "RtlRestoreContext:longjump failed for Rbx, expected: %lx, got: %lx\n", buf.Rbx, ctx.Rbx); > + ok(buf.Rsp == ctx.Rsp, "RtlRestoreContext:longjump failed for Rsp, expected: %lx, got: %lx\n", buf.Rsp, ctx.Rsp); > + ok(buf.Rbp == ctx.Rbp, "RtlRestoreContext:longjump failed for Rbp, expected: %lx, got: %lx\n", buf.Rbp, ctx.Rbp); > + ok(buf.Rsi == ctx.Rsi, "RtlRestoreContext:longjump failed for Rsi, expected: %lx, got: %lx\n", buf.Rsi, ctx.Rsi); > + ok(buf.Rdi == ctx.Rdi, "RtlRestoreContext:longjump failed for Rdi, expected: %lx, got: %lx\n", buf.Rdi, ctx.Rdi); > + ok(buf.R12 == ctx.R12, "RtlRestoreContext:longjump failed for R12, expected: %lx, got: %lx\n", buf.R12, ctx.R12); > + ok(buf.R13 == ctx.R13, "RtlRestoreContext:longjump failed for R13, expected: %lx, got: %lx\n", buf.R13, ctx.R13); > + ok(buf.R14 == ctx.R14, "RtlRestoreContext:longjump failed for R14, expected: %lx, got: %lx\n", buf.R14, ctx.R14); > + ok(buf.R15 == ctx.R15, "RtlRestoreContext:longjump failed for R15, expected: %lx, got: %lx\n", buf.R15, ctx.R15); > + > + ok(buf.Xmm6.Part[1] == fltsave->XmmRegisters[6].High && buf.Xmm6.Part[0] == fltsave->XmmRegisters[6].Low, > + "RtlRestoreContext:longjump failed for Xmm6, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm6.Part[1], buf.Xmm6.Part[0], fltsave->XmmRegisters[6].High, fltsave->XmmRegisters[6].Low); > + ok(buf.Xmm7.Part[1] == fltsave->XmmRegisters[7].High && buf.Xmm7.Part[0] == fltsave->XmmRegisters[7].Low, > + "RtlRestoreContext:longjump failed for Xmm7, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm7.Part[1], buf.Xmm7.Part[0], fltsave->XmmRegisters[7].High, fltsave->XmmRegisters[7].Low); > + ok(buf.Xmm8.Part[1] == fltsave->XmmRegisters[8].High && buf.Xmm8.Part[0] == fltsave->XmmRegisters[8].Low, > + "RtlRestoreContext:longjump failed for Xmm8, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm8.Part[1], buf.Xmm8.Part[0], fltsave->XmmRegisters[8].High, fltsave->XmmRegisters[8].Low); > + ok(buf.Xmm9.Part[1] == fltsave->XmmRegisters[9].High && buf.Xmm9.Part[0] == fltsave->XmmRegisters[9].Low, > + "RtlRestoreContext:longjump failed for Xmm9, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm9.Part[1], buf.Xmm9.Part[0], fltsave->XmmRegisters[9].High, fltsave->XmmRegisters[9].Low); > + ok(buf.Xmm10.Part[1] == fltsave->XmmRegisters[10].High && buf.Xmm10.Part[0] == fltsave->XmmRegisters[10].Low, > + "RtlRestoreContext:longjump failed for Xmm10, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm10.Part[1], buf.Xmm10.Part[0], fltsave->XmmRegisters[10].High, fltsave->XmmRegisters[10].Low); > + ok(buf.Xmm11.Part[1] == fltsave->XmmRegisters[11].High && buf.Xmm11.Part[0] == fltsave->XmmRegisters[11].Low, > + "RtlRestoreContext:longjump failed for Xmm11, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm11.Part[1], buf.Xmm11.Part[0], fltsave->XmmRegisters[11].High, fltsave->XmmRegisters[11].Low); > + ok(buf.Xmm12.Part[1] == fltsave->XmmRegisters[12].High && buf.Xmm12.Part[0] == fltsave->XmmRegisters[12].Low, > + "RtlRestoreContext:longjump failed for Xmm12, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm12.Part[1], buf.Xmm12.Part[0], fltsave->XmmRegisters[12].High, fltsave->XmmRegisters[12].Low); > + ok(buf.Xmm13.Part[1] == fltsave->XmmRegisters[13].High && buf.Xmm13.Part[0] == fltsave->XmmRegisters[13].Low, > + "RtlRestoreContext:longjump failed for Xmm13, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm13.Part[1], buf.Xmm13.Part[0], fltsave->XmmRegisters[13].High, fltsave->XmmRegisters[13].Low); > + ok(buf.Xmm14.Part[1] == fltsave->XmmRegisters[14].High && buf.Xmm14.Part[0] == fltsave->XmmRegisters[14].Low, > + "RtlRestoreContext:longjump failed for Xmm14, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm14.Part[1], buf.Xmm14.Part[0], fltsave->XmmRegisters[14].High, fltsave->XmmRegisters[14].Low); > + ok(buf.Xmm15.Part[1] == fltsave->XmmRegisters[15].High && buf.Xmm15.Part[0] == fltsave->XmmRegisters[15].Low, > + "RtlRestoreContext:longjump failed for Xmm15, expected: %lx%08lx, got: %lx%08lx\n", > + buf.Xmm15.Part[1], buf.Xmm15.Part[0], fltsave->XmmRegisters[15].High, fltsave->XmmRegisters[15].Low); > + > + goto test_consolidate; Similar to above, it would be better to avoid goto. All the code below could just be moved to an else branch. > + } > + done = 1; > + > + rec.ExceptionCode = STATUS_LONGJUMP; > + rec.NumberParameters = 1; > + rec.ExceptionInformation[0] = (DWORD64)&buf; > + > + ctx.Rbx = 0xdeadbeef; > + ctx.Rsp = 0xdeadbeef; > + ctx.Rbp = 0xdeadbeef; > + ctx.Rsi = 0xdeadbeef; > + ctx.Rdi = 0xdeadbeef; > + ctx.R12 = 0xdeadbeef; > + ctx.R13 = 0xdeadbeef; > + ctx.R14 = 0xdeadbeef; > + ctx.R15 = 0xdeadbeef; > + > + fltsave->XmmRegisters[6].High = 0xbaadf00d; > + fltsave->XmmRegisters[6].Low = 0xdeadbeef; > + fltsave->XmmRegisters[7].High = 0xbaadf00d; > + fltsave->XmmRegisters[7].Low = 0xdeadbeef; > + fltsave->XmmRegisters[8].High = 0xbaadf00d; > + fltsave->XmmRegisters[8].Low = 0xdeadbeef; > + fltsave->XmmRegisters[9].High = 0xbaadf00d; > + fltsave->XmmRegisters[9].Low = 0xdeadbeef; > + fltsave->XmmRegisters[10].High = 0xbaadf00d; > + fltsave->XmmRegisters[10].Low = 0xdeadbeef; > + fltsave->XmmRegisters[11].High = 0xbaadf00d; > + fltsave->XmmRegisters[11].Low = 0xdeadbeef; > + fltsave->XmmRegisters[12].High = 0xbaadf00d; > + fltsave->XmmRegisters[12].Low = 0xdeadbeef; > + fltsave->XmmRegisters[13].High = 0xbaadf00d; > + fltsave->XmmRegisters[13].Low = 0xdeadbeef; > + fltsave->XmmRegisters[14].High = 0xbaadf00d; > + fltsave->XmmRegisters[14].Low = 0xdeadbeef; > + fltsave->XmmRegisters[15].High = 0xbaadf00d; > + fltsave->XmmRegisters[15].Low = 0xdeadbeef; It would look better if you would use a loop or just a memset() for something like that. > + > + pRtlRestoreContext(&ctx, &rec); > + > +test_consolidate: > + done = 0; > + > + pRtlCaptureContext(&ctx); > + if (done) > + { > + ok(consolidate_dummy_called, "test_consolidate_dummy not called\n"); > + return; > + } > + done = 1; > + > + rec.ExceptionCode = STATUS_UNWIND_CONSOLIDATE; > + rec.NumberParameters = 3; > + rec.ExceptionInformation[0] = (DWORD64)test_consolidate_dummy; > + rec.ExceptionInformation[1] = (DWORD64)&ctx; > + rec.ExceptionInformation[2] = ctx.Rip; > + ctx.Rip = 0xdeadbeef; > + > + pRtlRestoreContext(&ctx, &rec); > +} > + > static RUNTIME_FUNCTION* CALLBACK dynamic_unwind_callback( DWORD64 pc, PVOID context ) > { > static const int code_offset = 1024; > @@ -2155,6 +2347,9 @@ static void test_vectored_continue_handler(void) > START_TEST(exception) > { > HMODULE hntdll = GetModuleHandleA("ntdll.dll"); > +#if defined(__x86_64__) > + HMODULE hmsvcrt = LoadLibraryA("msvcrt.dll"); > +#endif > > code_mem = VirtualAlloc(NULL, 65536, MEM_RESERVE | MEM_COMMIT, PAGE_EXECUTE_READWRITE); > if(!code_mem) { > @@ -2267,6 +2462,12 @@ START_TEST(exception) > "RtlInstallFunctionTableCallback" ); > pRtlLookupFunctionEntry = (void *)GetProcAddress( hntdll, > "RtlLookupFunctionEntry" ); > + pRtlCaptureContext = (void *)GetProcAddress( hntdll, > + "RtlCaptureContext" ); > + pRtlRestoreContext = (void *)GetProcAddress( hntdll, > + "RtlRestoreContext" ); > + p_setjmp = (void *)GetProcAddress( hmsvcrt, > + "_setjmp" ); > > test_debug_registers(); > test_outputdebugstring(1, FALSE); > @@ -2275,6 +2476,7 @@ START_TEST(exception) > test_breakpoint(1); > test_vectored_continue_handler(); > test_virtual_unwind(); > + test_restore_context(); > > if (pRtlAddFunctionTable && pRtlDeleteFunctionTable && pRtlInstallFunctionTableCallback && pRtlLookupFunctionEntry) > test_dynamic_unwind(); > -- 1.9.5 > > >

1 0

RE: TestBot job 25000 results: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Daniel Lehman 15 Aug '16

15 Aug '16

> ntdll: > exception.c:523: Test failed: 42: Unexpected eip 0x2d0000/0x2d0001 > exception: unhandled exception 80000004 at 002D0000 > exception.c:520: Test failed: 42: Wrong exception code > c0000027/80000004 > exception.c:523: Test failed: 42: Unexpected eip 0x77baed97/0x2d0001 ... > > ntdll: > exception.c:1233: Test failed: Got exception offset 0x1b, expected 0x19 > exception.c:1242: Test failed: Got exception offset 0x19, expected 0x17 these are existing failures

1 0

Re: [PATCH 2/9] d3d8/tests: Add test for regression in IDirect3DDevice8_Reset().
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25060 Your paranoid android. === w864 (32 bit device) === device.c:1374: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1416: Test failed: Reset failed, hr 0x88760868. device.c:1418: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1422: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1427: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1428: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1429: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1430: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1431: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1432: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1436: Test failed: Screen width is 640, expected 800. device.c:1437: Test failed: Screen height is 480, expected 600. device.c:1443: Test failed: Back buffer width is 640, expected 800. device.c:1445: Test failed: Back buffer height is 480, expected 600. device.c:1472: Test failed: Screen width is 640, expected 1024. device.c:1473: Test failed: Screen height is 480, expected 768. device.c:1501: Test failed: Reset failed, hr 0x80070057. device.c:1503: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1515: Test failed: D3DVIEWPORT->Width = 400. device.c:1516: Test failed: D3DVIEWPORT->Height = 300. device: unhandled exception c0000005 at 75095D5B

2 1

Re: [PATCH] [preloader] Add proper CFI instructions to _start functions
by Alexandre Julliard 15 Aug '16

15 Aug '16

Keno Fischer <keno(a)juliacomputing.com> writes: > diff --git a/loader/preloader.c b/loader/preloader.c > index db0e998..8a86311 100644 > --- a/loader/preloader.c > +++ b/loader/preloader.c > @@ -212,6 +212,7 @@ struct > void _start(void); > extern char _end[]; > __ASM_GLOBAL_FUNC(_start, > + "\t.cfi_undefined %eip\n" > "\tmovl $243,%eax\n" /* SYS_set_thread_area */ > "\tmovl $thread_ldt,%ebx\n" > "\tint $0x80\n" /* allocate gs segment */ Looks OK, but it would need to be wrapped with the __ASM_CFI macro. Also could you please make sure to include your signoff? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v6)
by Henri Verbeet 15 Aug '16

15 Aug '16

On 12 August 2016 at 01:09, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface); Actually, sorry, you probably shouldn't do that in d3drm. The d3drm headers are written by hand, so IDirect3DRMFrame3_AddRef() is a macro instead of an inline function. That means that when this expands the assignment happens twice.

2 3

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Alex Henrie 15 Aug '16

15 Aug '16

2016-08-14 22:20 GMT-06:00 Alex Henrie <alexhenrie24(a)gmail.com>: > v4 does not include any tests that are not necessary to demonstrate the > correctness of the FolderItems_Item implementation. This makes the > patches much smaller, and hopefully more likely to be accepted. I have > also simplified the test for FolderItems_Item with VT_ERROR, and I've > added a small test to show that FolderItems_Item doesn't accept VT_BSTR > file names. Crud, I just realized that FolderItems_Item does accept VT_BSTR file names after all. I thought I'd tested this, sorry. Please do not ignore this patchset for another 3 weeks because of this mistake. -Alex

1 0

Re: [PATCH v4 3/3] shell32: Implement FolderItems_get_Count.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25033 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:524: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[0]: item is not null shelldispatch.c:524: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[1]: item is not null shelldispatch.c:524: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[2]: item is not null shelldispatch.c:524: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[3]: item is not null shelldispatch.c:524: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:525: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 2/3] shell32: Implement FolderItems_Item.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25032 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:530: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[0]: item is not null shelldispatch.c:530: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[1]: item is not null shelldispatch.c:530: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[2]: item is not null shelldispatch.c:530: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[3]: item is not null shelldispatch.c:530: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:531: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH v4 1/3] shell32/tests: Add more tests for FolderItems.
by Marvin 15 Aug '16

15 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25031 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2003std (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7u (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w8 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (32 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === wvistau64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w2008s64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w7pro64 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w864 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null === w1064 (64 bit shelldispatch) === shelldispatch.c:540: Test failed: file_defs[0]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[0]: item is not null shelldispatch.c:540: Test failed: file_defs[1]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[1]: item is not null shelldispatch.c:540: Test failed: file_defs[2]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[2]: item is not null shelldispatch.c:540: Test failed: file_defs[3]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[3]: item is not null shelldispatch.c:540: Test failed: file_defs[4]: expected S_FALSE, got 00000000 shelldispatch.c:541: Test failed: file_defs[4]: item is not null

1 0

Re: [PATCH] po: Update Simplified Chinese translation (v2).
by Jactry Zeng 14 Aug '16

14 Aug '16

Hi, It looks good to me. Thanks for your contribution! :) 2016-08-14 21:52 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Reverted a translated string to the existing upstream translation, and > unmarked two extra fuzzies. > > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 927 ++++++++++++++++++++++++++++++ > +----------------------------- > 1 file changed, 477 insertions(+), 450 deletions(-) > > > > > -- Regards, Jactry Zeng

1 0

Where is winegstreamer used?
by Bruno Jesus 14 Aug '16

14 Aug '16

After looking for gstreamer related source code in Wine I could not find a place that calls winegstreamer to actually do something like video/audio decode/output. I think it should be somewhere amstream/quartz related but I'm not sure. My question is basically what I need to do (preferably with source example or documentation) to get a mpg movie to play and that ends up using winegstreamer, for example. For example with AVI files I can simply do some avifil32/msvfw32 calls and get the video output to a window. Thanks in advance, Bruno

3 5

Re: [PATCH 1/2] dwrite: Sanitize specified stretch value, valid range is [1, 9]
by Ken Thomases 13 Aug '16

13 Aug '16

On Aug 13, 2016, at 4:47 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/dwrite/opentype.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c > index b35f1df..ff23f51 100644 > --- a/dlls/dwrite/opentype.c > +++ b/dlls/dwrite/opentype.c > @@ -1291,8 +1291,9 @@ void opentype_get_font_properties(struct file_stream_desc *stream_desc, struct d > USHORT version = GET_BE_WORD(tt_os2->version); > USHORT fsSelection = GET_BE_WORD(tt_os2->fsSelection); > USHORT usWeightClass = GET_BE_WORD(tt_os2->usWeightClass); > + USHORT usWidthClass = GET_BE_WORD(tt_os2->usWidthClass); > > - if (GET_BE_WORD(tt_os2->usWidthClass) <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > + if (usWidthClass > DWRITE_FONT_STRETCH_UNDEFINED && usWidthClass <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > props->stretch = GET_BE_WORD(tt_os2->usWidthClass); Shouldn't you use the new usWidthClass variable in the assignment here, too? -Ken

1 0

Re: [PATCH] gdi32: Support special 'ttcf' tag in GetFontData(), fix individual collection item offset
by Huw Davies 12 Aug '16

12 Aug '16

On Fri, Aug 12, 2016 at 01:47:39AM +0300, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/gdi32/freetype.c | 53 ++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 44 insertions(+), 9 deletions(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 5ddfc6a..f4aab0b 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -394,6 +396,8 @@ struct tagGdiFont { > int codepage; > BOOL fake_italic; > BOOL fake_bold; > + BOOL is_ttc_item; > + ULONG ttc_item_offset; Since ttc_item_offset can never be zero in a ttc, you don't need the boolean. > BYTE underline; > BYTE strikeout; > INT orientation; > @@ -2189,7 +2193,7 @@ static FT_Face new_ft_face( const char *file, void *font_data_ptr, DWORD font_da > !pFT_Get_Sfnt_Table( ft_face, ft_sfnt_hhea ) || > !pFT_Get_Sfnt_Table( ft_face, ft_sfnt_head )) > { > - TRACE("Font %s/%p lacks either an OS2, HHEA or HEAD table.\n" > + TRACE("Font %s/%p lacks either an OS/2, hhea or head table.\n" > "Skipping this font.\n", debugstr_a(file), font_data_ptr); > goto fail; > } Unrelated. > @@ -4535,6 +4539,9 @@ static FT_Face OpenFontFace(GdiFont *font, Face *face, LONG width, LONG height) > font->ft_face = ft_face; > > if(FT_IS_SCALABLE(ft_face)) { > + FT_ULong len; > + DWORD header; > + > /* load the VDMX table if we have one */ > font->ppem = load_VDMX(font, height); > if(font->ppem == 0) > @@ -4543,6 +4550,22 @@ static FT_Face OpenFontFace(GdiFont *font, Face *face, LONG width, LONG height) > > if((err = pFT_Set_Pixel_Sizes(ft_face, 0, font->ppem)) != 0) > WARN("FT_Set_Pixel_Sizes %d, %d rets %x\n", 0, font->ppem, err); > + > + /* see if it's a TTC */ > + len = sizeof(header); > + if (!pFT_Load_Sfnt_Table(ft_face, 0, 0, (void*)&header, &len)) { > + const DWORD ttcf = 0x66637474; Please define and use the 'ttcf' tag. > @@ -4638,12 +4661,18 @@ static void free_font(GdiFont *font) > HeapFree(GetProcessHeap(), 0, font); > } > > +#define MS_MAKE_TAG( _x1, _x2, _x3, _x4 ) \ > + ( ( (FT_ULong)_x4 << 24 ) | \ > + ( (FT_ULong)_x3 << 16 ) | \ > + ( (FT_ULong)_x2 << 8 ) | \ > + (FT_ULong)_x1 ) We already have this define later on, we should probably move it to the top of the file (under the GET_BE_(D)WORD defines looks like a good place) and move all the various tag definitions up there too. This should be done as a separate, preliminary patch. > static DWORD get_font_data( GdiFont *font, DWORD table, DWORD offset, LPVOID buf, DWORD cbData) > { > FT_Face ft_face = font->ft_face; > FT_ULong len; > FT_Error err; > + DWORD tag; > > if (!FT_IS_SFNT(ft_face)) return GDI_ERROR; > > @@ -4652,7 +4681,17 @@ static DWORD get_font_data( GdiFont *font, DWORD table, DWORD offset, LPVOID buf > else > len = cbData; > > - table = RtlUlongByteSwap( table ); /* MS tags differ in endianness from FT ones */ > + table = RtlUlongByteSwap( tag = table ); /* MS tags differ in endianness from FT ones */ > + > + /* if font is a member of TTC, 'ttcf' tag allows reading from beginning of TTC file, > + 0 tag means to read from start of collection member data. */ > + if (font->is_ttc_item) > + { > + if (tag == MS_MAKE_TAG('t','t','c','f')) > + table = 0; > + else if (tag == 0) > + offset += font->ttc_item_offset; > + } I find the introduction of tag here confusiong. You should be able to do this without the second variable. > return GDI_ERROR; > } > return len; > @@ -8246,9 +8282,8 @@ static DWORD freetype_GetFontData( PHYSDEV dev, DWORD table, DWORD offset, LPVOI > return dev->funcs->pGetFontData( dev, table, offset, buf, cbData ); > } > > - TRACE("font=%p, table=%c%c%c%c, offset=0x%x, buf=%p, cbData=0x%x\n", > - physdev->font, LOBYTE(LOWORD(table)), HIBYTE(LOWORD(table)), > - LOBYTE(HIWORD(table)), HIBYTE(HIWORD(table)), offset, buf, cbData); > + TRACE("font=%p, table=%s, offset=0x%x, buf=%p, cbData=0x%x\n", > + physdev->font, debugstr_an((char*)&table, 4), offset, buf, cbData); Doesn't this print the tag backwards? Huw.

1 0

Re: [PATCH] ucrtbase: Add __stdio_common_vfwscanf
by Piotr Caban 12 Aug '16

12 Aug '16

On 08/11/16 19:27, Daniel Lehman wrote: > + if (options & ~UCRTBASE_SCANF_MASK) > + FIXME("options %s not handled\n", wine_dbgstr_longlong(options)); > + if (options & UCRTBASE_SCANF_SECURECRT) It would be better to compare options with UCRTBASE_SCANF_SECURECRT when printing FIXME message. Your implementation doesn't support any other options. Thanks, Piotr

1 0

Re: [PATCH] msvcrt: Add _wcreate_locale
by Piotr Caban 12 Aug '16

12 Aug '16

On 08/11/16 19:27, Daniel Lehman wrote: > + len = MSVCRT_wcstombs(NULL, locale, 0); > + if (!(str = MSVCRT_malloc(len))) return NULL; Please handle string conversion error. The allocated buffer is not big enough. Something like this should work: len = MSVCRT_wcstombs(NULL, locale, 0); if(len == -1) { ... } if(!(str = MSVCRT_malloc(len+1)) ... It may be even better to call wcstombs_s so invalid parameter handler is called (I didn't test if it should be called). Thanks, Piotr

1 0

Re: [v3] riched20: allow setting background text color
by Huw Davies 12 Aug '16

12 Aug '16

On Thu, Aug 11, 2016 at 12:22:21PM -0600, Kenneth Haley wrote: > fixes https://bugs.winehq.org/show_bug.cgi?id=36625 > > Tested on Arch Linux. Now the background is correctly painted, but there's still the issue of the background disappearing when selecting a range within a run of text that has a background. It's easy to test this using Wine's wordpad. Huw.

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v5)
by Józef Kucia 11 Aug '16

11 Aug '16

On Fri, Aug 12, 2016 at 12:48 AM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v4: Shorter implementation. > v3: Directly traverse through parent frames instead of using GetParent. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/frame.c | 43 +++++++++++++++++++++++++++++++++++++------ > dlls/d3drm/tests/d3drm.c | 24 ++++++++++++++++++++++++ > 2 files changed, 61 insertions(+), 6 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 2ff0241..4d7ab42 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -1339,23 +1339,54 @@ static HRESULT WINAPI d3drm_frame1_GetRotation(IDirect3DRMFrame *iface, > > static HRESULT WINAPI d3drm_frame3_GetScene(IDirect3DRMFrame3 *iface, IDirect3DRMFrame3 **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame3(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + if (!scene) > + return D3DRMERR_BADVALUE; > + > + *scene = &frame->IDirect3DRMFrame3_iface; Do you really need this assignment? > + > + while (frame->parent) > + frame = frame->parent; > + > + IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface); > + > + return D3DRM_OK; > }

2 1

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v4)
by Henri Verbeet 11 Aug '16

11 Aug '16

On 10 August 2016 at 17:41, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + *scene = &frame->IDirect3DRMFrame3_iface; > + > + while ((frame = frame->parent)) > + *scene = &frame->IDirect3DRMFrame3_iface; > + > + IDirect3DRMFrame3_AddRef(*scene); How about: while (frame->parent) frame = frame->parent; IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);

2 1

Re: [PATCH] ntdll: Set Rip in for longjmp in RtlRestoreContext
by Marvin 11 Aug '16

11 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=25000 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:523: Test failed: 42: Unexpected eip 0x2d0000/0x2d0001 exception: unhandled exception 80000004 at 002D0000 exception.c:523: Test failed: 42: Unexpected eip 0x77baed97/0x2d0001 === w7u (32 bit exception) === exception.c:523: Test failed: 42: Unexpected eip 0x280000/0x280001 exception: unhandled exception 80000004 at 00280000 exception.c:523: Test failed: 42: Unexpected eip 0x77cde34f/0x280001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH 2/2] include: cpp_quote D3D10CreateDeviceAndSwapChain1.
by Henri Verbeet 11 Aug '16

11 Aug '16

On 7 August 2016 at 21:22, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > D3D10_DRIVER_TYPE is defined in d3d10misc.h, so MIDL complains that it > doesn't know about it. Would introducing d3d10misc.idl help?

2 3

xaudio2: More than 256 audio sources
by Fabian Maurer 11 Aug '16

11 Aug '16

Some applications run out of sources when using xaudio2 so I'm working on a patch that allows more than the 256 sources provided by OpenAL. I've tried a few different methods, and the current should be the easiest and most compatible. Still, I'm not perfectly familiar with the implementation of xaudio2, and I ran into lots of hard to resolve issues, so I figured I'd ask for feedback before submitting the patch. Any feedback or mistakes regarding my implementation?

2 1

Re: [PATCH 3/5] programs/services: Break services into Loader groups
by Sebastian Lackner 11 Aug '16

11 Aug '16

On 09.08.2016 18:40, Aric Stewart wrote: > > Sort the groups by the service's tag to start in order > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/services/services.c | 101 ++++++++++++++++++++++++++++++++----------- > 1 file changed, 75 insertions(+), 26 deletions(-) > I believe this can be solved a bit easier. Why not just a sort function callback which sorts for both group and tag?

2 3

Re: [PATCH 2/5] programs/winedevice.exe: allow loading multiple devices on the command line
by Sebastian Lackner 11 Aug '16

11 Aug '16

On 09.08.2016 18:40, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/winedevice/device.c | 92 ++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 75 insertions(+), 17 deletions(-) > I am not sure if I'm missing something, but where is this functionality used? Is it only for manual testing, or where are the corresponding changes to programs/services to pass multiple drivers in the commandline?

2 1

Re: [PATCH 4/6] d3d10core/tests: Add test for swapchain views.
by Marvin 11 Aug '16

11 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24991 Your paranoid android. === wvistau64 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w2008s64 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w8 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w864 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === w1064 (32 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 0040F80E === wvistau64 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w2008s64 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w864 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4 === w1064 (64 bit device) === device.c:7284: Test failed: Failed to create render target view, hr 0x80070057. device.c:7288: Test failed: Got unexpected color 0xff804c33 at (0, 0), sub-resource 0. device: unhandled exception c0000005 at 000000000040DED4

1 0

Re: [PATCH 4/6] d3d10core/tests: Add test for swapchain views.
by Józef Kucia 11 Aug '16

11 Aug '16

On Thu, Aug 11, 2016 at 12:57 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d10core/tests/device.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) Please ignore this patch. It seems that this is a D3D11-only feature. I'll send other test for d3d10core in the next patch series.

1 0

Re: user32: Avoid -Wmisleading-indentation warnings and fix comments in comments in test_AppendMenu.
by Dmitry Timoshkov 11 Aug '16

11 Aug '16

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c > index 33d8eb8..ea965cd 100644 > --- a/dlls/user32/tests/menu.c > +++ b/dlls/user32/tests/menu.c > @@ -3992,13 +3992,15 @@ static void test_AppendMenu(void) > mii.wID = 206; > ret = InsertMenuItemA(hmenu, 0, TRUE, &mii); > ok(ret, "InsertMenuItem failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 206, MF_SEPARATOR, MFS_GRAYED); > +} > mii.wID = 207; > ret = SetMenuItemInfoA(hmenu, 0, TRUE, &mii); > ok(ret, "SetMenuItemInfo failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 207, MF_SEPARATOR, MFS_GRAYED); > +} > DestroyMenu(hmenu); > > hbmp = CreateBitmap(1, 1, 1, 1, NULL); Please don't make the code look uglier than it already is. I'd personally argue that checking and forcing indentation rules by a C compiler is pretty disappointing and actually misleading. That warning should be turned off by default IMHO. -- Dmitry.

3 2

Re: [PATCH] msvcr120: Add lgamma
by Piotr Caban 11 Aug '16

11 Aug '16

Hi, On 08/10/16 18:54, Daniel Lehman wrote: > +/********************************************************************* > + * lgamma (MSVCR120.@) > + */ > +double CDECL MSVCR120_lgamma(double x) > +{ > + return lgamma(x); > +} lgamma function is not a C89 function. It probably shouldn't be used without appropriate configure checks. On the other hand there are some other non C89 functions calls in this file. I don't know why/if it's OK in other cases (like e.g. y0). Thanks, Piotr

1 0

Re: [PATCH] winex11.drv: LoadKeyboardLayout - return default locale in stub instead of 0
by Matteo Bruni 10 Aug '16

10 Aug '16

2016-08-06 1:09 GMT+02:00 Nils Kuhnhenn <kuhnhenn.nils(a)gmail.com>: > This matches the behavior of the original more closely, which returns > the default locale in case of any error. > > See the section "Return value" here: > https://msdn.microsoft.com/en-us/library/windows/desktop/ms646305(v=vs.85).… > > Guild Wars 2 will repeat the call to "LoadKeyboardLayout" every frame > if 0 is returned, followed by a call to "MapVirtualKeyEx" with the returned > (unsupported) layout. > --- > dlls/winex11.drv/keyboard.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c > index 47a9872..6f6eda8 100644 > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -1947,9 +1947,9 @@ HKL CDECL X11DRV_GetKeyboardLayout(DWORD dwThreadid) > */ > HKL CDECL X11DRV_LoadKeyboardLayout(LPCWSTR name, UINT flags) > { > - FIXME("%s, %04x: stub!\n", debugstr_w(name), flags); > + FIXME("%s, %04x: stub! Returning default language.\n", debugstr_w(name), flags); > SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return 0; > + return get_locale_kbd_layout(); > } I'm not exactly an expert in the area but I think your patch makes sense. It's missing your sign-off though, please resend the patch with it. BTW, you can follow the status of your patch on http://source.winehq.org/patches/.

2 1

Re: [v2] kernel32: properly deal with double path delimiters in GetShortPathName.
by Matteo Bruni 10 Aug '16

10 Aug '16

2016-08-10 15:27 GMT+02:00 Peter Beutner <p.beutner(a)gmx.net>: > v2: ignore previous attempt, this is a better fix i think > > Remove the extra if clause that deals with paths starting with ".\\". The > code a few lines below that handles "." or ".." as part of the path > already handles that case. > That way the code handling path delimiters will properly work for > paths starting with ".\\\\". > > Fixes https://bugs.winehq.org/show_bug.cgi?id=41002 > > Signed-off-by: Peter Beutner <p.beutner(a)gmx.net> > --- > dlls/kernel32/path.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c > index 620401d..3eff35e 100644 > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -510,12 +510,6 @@ DWORD WINAPI GetShortPathNameW( LPCWSTR longpath, LPWSTR shortpath, DWORD shortl > } > > p = longpath + lp; > - if (lp == 0 && p[0] == '.' && (p[1] == '/' || p[1] == '\\')) > - { > - tmpshortpath[sp++] = *p++; > - tmpshortpath[sp++] = *p++; > - lp += 2; > - } > for (; *p && *p != '/' && *p != '\\'; p++); > tmplen = p - (longpath + lp); > lstrcpynW(tmpshortpath + sp, longpath + lp, tmplen + 1); > -- > 2.7.3 In case you haven't noticed, you patch was not accepted because it needs tests, as Bruno mentioned in the bug report. You can check the status of your patches on http://source.winehq.org/patches/. BTW, thank you for your work!

1 0

Re: [PATCH 1/5] mpr: Implement local name automatic redirection for disks. (try 6)
by Pierre Schweitzer 10 Aug '16

10 Aug '16

Le 10/08/2016 à 17:31, Bruno Jesus a écrit : > On Mon, Aug 8, 2016 at 7:09 AM, Pierre Schweitzer <pierre(a)reactos.org> wrote: >> This is a purely cosmetic change, as I had the opportunity to resend. I >> use uppercase letters instead of lowercase. >> -- >> Pierre Schweitzer <pierre at reactos.org> >> System & Network Administrator >> Senior Kernel Developer >> ReactOS Deutschland e.V. > > > Hiho, can you tell me how do we test this patches? Maybe with real > testing we can convince Alexandre to have the patches commited. Hi, Unfortunately, there's no easy way to test them, especially in Wine, as it comes without network provider. At the moment, the tests I'm doing are the following: - I developped a "net use" application against Windows 2003 (ie, it works in Windows 2003 as the native app - minus a few features I don't need yet): https://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network… - This "net use" application obviously relies on MPR functions I'm working with. - I install an instance of ReactOS in VirtualBox/VMware and I try the various functions of net use, such as: * net use z: \\UNC path (it must mount the remote UNC path and try to assign the z: drive letter. As net use command has no idea about network providers or whatever, it requires the second patch in row which allows selecting the good network provider (in MPR) to perform the connection). * net use * \\UNC path (it must mount the remote UNC path and automatically assign a local drive letter). Typically, that's the patch you're replying to. It will attempt all the drive letters till one works. That one is also important because my net use implementation mimics the MS implementation: when connection is done with automatic drive letter selection, net use must write connection that was established (remote UNC to local letter), so it allows testing the return of the WNetUseConnection function: which is the local drive used). This is also covered by the 5th patch. net use z: /delete (it must cancel the connection). This covers the patches 3 and 4 of the serie. Note that I also have patches to implement connected resources enumeration (which is working nicely :-)), but I didn't submit them yet to Wine, waiting for these 5 patches to make it. This is for the "net use" and "net use z:" command. For the network provider "proper" implementation, I rely on open source software, known to work in Windows, such as VirtualBox guest additions (https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Additions/WINNT/Shar…) and Winfsp (https://github.com/billziss-gh/winfsp/blob/master/src/dll/np.c). Screenshots here can give you an overview of what can Wine MPR achieve now: https://twitter.com/HeisSpiter/media ;-). I'll do a resend tonight to address a few style comments I received on #winehackers today (thanks!). Thanks for your help on this! > > Best wishes, > Bruno > -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V.

1 0

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v3)
by Aaryaman Vasishta 10 Aug '16

10 Aug '16

Hi, Please ignore this and go for v4 of this patch instead. Cheers, Aaryaman On Wed, Aug 10, 2016 at 9:07 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > v3: Directly traverse through parent frames instead of using GetParent. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/frame.c | 46 ++++++++++++++++++++++++++++++ > ++++++++++------ > dlls/d3drm/tests/d3drm.c | 24 ++++++++++++++++++++++++ > 2 files changed, 64 insertions(+), 6 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 2ff0241..312007b 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -1339,23 +1339,57 @@ static HRESULT WINAPI d3drm_frame1_GetRotation(IDirect3DRMFrame > *iface, > > static HRESULT WINAPI d3drm_frame3_GetScene(IDirect3DRMFrame3 *iface, > IDirect3DRMFrame3 **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame3(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + if (!scene) > + return D3DRMERR_BADVALUE; > + > + *scene = &frame->IDirect3DRMFrame3_iface; > + > + while (frame->parent) > + { > + frame = frame->parent; > + *scene = &frame->IDirect3DRMFrame3_iface; > + } > + > + IDirect3DRMFrame3_AddRef(*scene); > + > + return D3DRM_OK; > } > > static HRESULT WINAPI d3drm_frame2_GetScene(IDirect3DRMFrame2 *iface, > IDirect3DRMFrame **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame2(iface); > + IDirect3DRMFrame3 *frame3; > + HRESULT hr; > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + if (!scene) > + return D3DRMERR_BADVALUE; > + > + hr = IDirect3DRMFrame3_GetScene(&frame->IDirect3DRMFrame3_iface, > &frame3); > + if (FAILED(hr) || !frame3) > + { > + *scene = NULL; > + return hr; > + } > + > + hr = IDirect3DRMFrame3_QueryInterface(frame3, &IID_IDirect3DRMFrame, > (void **)scene); > + IDirect3DRMFrame3_Release(frame3); > + > + return hr; > } > > static HRESULT WINAPI d3drm_frame1_GetScene(IDirect3DRMFrame *iface, > IDirect3DRMFrame **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface); > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + return d3drm_frame2_GetScene(&frame->IDirect3DRMFrame2_iface, scene); > } > > static D3DRMSORTMODE WINAPI d3drm_frame3_GetSortMode(IDirect3DRMFrame3 > *iface) > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abaed5..d86477d 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -885,6 +885,7 @@ static void test_Frame(void) > IDirect3DRMFrame *pFrameP1; > IDirect3DRMFrame *pFrameP2; > IDirect3DRMFrame *pFrameTmp; > + IDirect3DRMFrame *scene_frame; > IDirect3DRMFrameArray *frame_array; > IDirect3DRMMeshBuilder *mesh_builder; > IDirect3DRMVisual *visual1; > @@ -967,6 +968,19 @@ static void test_Frame(void) > CHECK_REFCOUNT(pFrameP1, 1); > CHECK_REFCOUNT(pFrameC, 2); > > + hr = IDirect3DRMFrame_GetScene(pFrameC, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %#x.\n", hr); > + hr = IDirect3DRMFrame_GetScene(pFrameC, &scene_frame); > + ok(SUCCEEDED(hr), "Cannot get scene (hr == %#x).\n", hr); > + ok(scene_frame == pFrameP1, "Expected scene frame == %p, got %p.\n", > pFrameP1, scene_frame); > + CHECK_REFCOUNT(pFrameP1, 2); > + IDirect3DRMFrame_Release(scene_frame); > + hr = IDirect3DRMFrame_GetScene(pFrameP1, &scene_frame); > + ok(SUCCEEDED(hr), "Cannot get scene (hr == %#x).\n", hr); > + ok(scene_frame == pFrameP1, "Expected scene frame == %p, got %p.\n", > pFrameP1, scene_frame); > + CHECK_REFCOUNT(pFrameP1, 2); > + IDirect3DRMFrame_Release(scene_frame); > + > frame_array = NULL; > hr = IDirect3DRMFrame_GetChildren(pFrameP1, &frame_array); > ok(hr == D3DRM_OK, "Cannot get children (hr = %x)\n", hr); > @@ -1032,6 +1046,16 @@ static void test_Frame(void) > ok(pFrameTmp == NULL, "pFrameTmp = %p\n", pFrameTmp); > IDirect3DRMFrameArray_Release(frame_array); > } > + hr = IDirect3DRMFrame_GetScene(pFrameC, &scene_frame); > + ok(SUCCEEDED(hr), "Cannot get scene (hr == %#x).\n", hr); > + ok(scene_frame == pFrameP2, "Expected scene frame == %p, got %p.\n", > pFrameP2, scene_frame); > + CHECK_REFCOUNT(pFrameP2, 2); > + IDirect3DRMFrame_Release(scene_frame); > + hr = IDirect3DRMFrame_GetScene(pFrameP2, &scene_frame); > + ok(SUCCEEDED(hr), "Cannot get scene (hr == %#x).\n", hr); > + ok(scene_frame == pFrameP2, "Expected scene frame == %p, got %p.\n", > pFrameP2, scene_frame); > + CHECK_REFCOUNT(pFrameP2, 2); > + IDirect3DRMFrame_Release(scene_frame); > > pFrameTmp = (void*)0xdeadbeef; > hr = IDirect3DRMFrame_GetParent(pFrameC, &pFrameTmp); > -- > 2.3.2 (Apple Git-55) > >

1 0

Building Wine programs for Windows
by Ruslan Kabatsayev 10 Aug '16

10 Aug '16

Hello all. Is there any supported way to build programs supplied with Wine, e.g. `dxdiag` or `regedit`, for native Windows? There seems to be a `crosstest` target, but it appears to only build tests, not all the programs and libraries. Regards, Ruslan

2 4

Re: [PATCH] winhttp/tests: Fix indentation warning on GCC 6
by Marvin 10 Aug '16

10 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24961 Your paranoid android. === w864 (32 bit winhttp) === winhttp.c:1030: Test failed: failed to send request 2148074273 winhttp.c:1034: Test failed: failed to retrieve certificate context 12019 winhttp.c:1039: Test failed: failed to retrieve key bitness 4317 winhttp.c:1043: Test failed: failed to retrieve certificate info 12019 winhttp.c:1056: Test failed: failed to receive response 12019 winhttp.c:1060: Test failed: failed to query available data 12019 winhttp.c:1061: Test failed: available_size = 0 winhttp.c:1066: Test failed: failed unexpectedly 12019 winhttp.c:1067: Test failed: request failed unexpectedly 3735928559 winhttp.c:1078: Test failed: WinHttpReadData failed: 12019.

1 0

Re: [PATCH resend 2/2] wined3d: Do not enable blending for edge/line antialiasing.
by Marvin 10 Aug '16

10 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24955 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH resend 2/2] wined3d: Do not enable blending for edge/line antialiasing.
by Marvin 10 Aug '16

10 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24951 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH v2 1/2] ddraw/tests: Add tests for edge antialiasing blending.
by Marvin 10 Aug '16

10 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24948 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 5/7] ddraw/tests: Add test for edge antialiasing blending.
by Henri Verbeet 10 Aug '16

10 Aug '16

On 8 August 2016 at 16:52, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static D3DCOLOR get_surface_color_rb(IDirectDraw7 *ddraw, IDirectDrawSurface7 *surface, > + unsigned int x, unsigned int y) > +{ > + IDirectDrawSurface7 *readback_surface; > + DDSURFACEDESC2 surface_desc; > + D3DCOLOR color; > + HRESULT hr; > + > + memset(&surface_desc, 0, sizeof(surface_desc)); > + surface_desc.dwSize = sizeof(surface_desc); > + hr = IDirectDrawSurface7_GetSurfaceDesc(surface, &surface_desc); > + ok(SUCCEEDED(hr), "Failed to get surface desc, hr %#x.\n", hr); > + surface_desc.ddsCaps.dwCaps = DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY; > + hr = IDirectDraw7_CreateSurface(ddraw, &surface_desc, &readback_surface, NULL); > + ok(SUCCEEDED(hr), "IDirectDraw7_CreateSurface failed, hr %#x.\n", hr); > + hr = IDirectDrawSurface_BltFast(readback_surface, 0, 0, surface, NULL, 0); > + ok(SUCCEEDED(hr), "IDirectDrawSurface7_BltFast failed, hr %#x.\n", hr); > + > + color = get_surface_color(readback_surface, x, y); > + > + IDirectDrawSurface7_Release(readback_surface); > + > + return color; > +} What is this for? Note that ddraw too has a D3DPRASTERCAPS_ANTIALIASEDGES cap. What about other versions? I think at least IDirect3DDevice3 also had D3DRENDERSTATE_EDGEANTIALIAS.

2 1

Re: [PATCH] msvcp140: Forward __ExceptionPtr* to msvcr120
by Piotr Caban 10 Aug '16

10 Aug '16

Hi Daniel, On 08/09/16 18:31, Daniel Lehman wrote: > -@ stub -arch=win32 ?__ExceptionPtrCopy@@YAXPAXPBX@Z > -@ stub -arch=win64 ?__ExceptionPtrCopy@@YAXPEAXPEBX@Z > +@ cdecl -arch=win32 ?__ExceptionPtrCopy@@YAXPAXPBX@Z(ptr ptr) __ExceptionPtrCopy > +@ cdecl -arch=win64 ?__ExceptionPtrCopy@@YAXPEAXPEBX@Z(ptr ptr) __ExceptionPtrCopy Why can't you just add forwards to msvcr120.dll in spec file? Thanks, Piotr

2 2

Re: [v2] riched20: allow setting background text color
by Huw Davies 10 Aug '16

10 Aug '16

On Tue, Aug 09, 2016 at 03:17:36PM -0600, Kenneth Haley wrote: > --- a/dlls/riched20/paint.c > +++ b/dlls/riched20/paint.c > @@ -318,10 +318,23 @@ static void get_selection_rect( ME_Context *c, ME_Run *run, int from, int to, in > static void draw_text( ME_Context *c, ME_Run *run, int x, int y, BOOL selected, RECT *sel_rect ) > { > COLORREF text_color = get_text_color( c, run->style, selected ); > - COLORREF back_color = selected ? ITextHost_TxGetSysColor( c->editor->texthost, COLOR_HIGHLIGHT ) : 0; > + COLORREF back_color = 0; > COLORREF old_text, old_back = 0; > const WCHAR *text = get_text( run, 0 ); > ME_String *masked = NULL; > + BOOL paint_bg = FALSE; > + > + if (selected) > + { > + back_color = ITextHost_TxGetSysColor(c->editor->texthost, COLOR_HIGHLIGHT); > + paint_bg = TRUE; > + } > + else if (run->style->fmt.dwMask & CFM_BACKCOLOR && > + !(CFE_AUTOBACKCOLOR & run->style->fmt.dwEffects)) > + { > + back_color = run->style->fmt.crBackColor; > + paint_bg = TRUE; > + } This doesn't work for me. You need to use the new paint_bg boolean to trigger the ETO_OPAQUE flags below. Also there's some odd behaviour if you select text in a run with background colour - the selection is correctly highlighted, but the rest of the run loses its background colour. Huw.

1 0

Re: mmdevapi: Another use case for todo_wine_if().
by Marvin 09 Aug '16

09 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24917 Your paranoid android. === w8 (32 bit capture) === capture.c:181: Test failed: Position 119 expected 0 capture.c:231: Test failed: Position 2167 expected 567 capture.c:261: Test failed: Position 2167 expected 567 capture.c:318: Test failed: Position 3191 gap 2176 capture.c:321: Test failed: GCP 13440 vs. BufferSize 21996 === w864 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:261: Test failed: Position 2167 expected 1527 capture.c:318: Test failed: Position 3191 gap 1216 capture.c:321: Test failed: GCP 14336 vs. BufferSize 21996 capture.c:341: Test failed: Position 4279 expected 3639 capture.c:342: Test failed: flags 1 capture.c:366: Test failed: Position 5303 expected 4087 capture.c:367: Test failed: flags 1 === w1064 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:261: Test failed: Position 2167 expected 1527 capture.c:318: Test failed: Position 3255 gap 1280 capture.c:321: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:341: Test failed: Position 4343 expected 3703 capture.c:342: Test failed: flags 1 capture.c:366: Test failed: Position 4791 expected 4151 === w864 (64 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:261: Test failed: Position 2167 expected 1527 capture.c:318: Test failed: Position 3127 gap 1152 capture.c:321: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:341: Test failed: Position 4215 expected 3575 capture.c:342: Test failed: flags 1 capture.c:366: Test failed: Position 5303 expected 4023 capture.c:367: Test failed: flags 1 === w1064 (64 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:261: Test failed: Position 2167 expected 1527 capture.c:318: Test failed: Position 3255 gap 1280 capture.c:321: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:341: Test failed: Position 4343 expected 3703 capture.c:342: Test failed: flags 1 capture.c:366: Test failed: Position 4791 expected 4151

1 0

Re: [PATCH] wshom.ocx/tests: Fix indentation warning on GCC 6
by Bruno Jesus 09 Aug '16

09 Aug '16

On Tue, Aug 9, 2016 at 2:07 PM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Are you going to also change lines starting with todo_wine? Like http://source.winehq.org/source/dlls/ws2_32/tests/sock.c#1468 Because it is made like this to make it more evident and to reduce diff files when the problem is fixed. Best wishes, Bruno

2 1

Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v2)
by Henri Verbeet 09 Aug '16

09 Aug '16

On 9 August 2016 at 03:16, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > static HRESULT WINAPI d3drm_frame3_GetScene(IDirect3DRMFrame3 *iface, IDirect3DRMFrame3 **scene) > { > - FIXME("iface %p, scene %p stub!\n", iface, scene); > + HRESULT hr; > + IDirect3DRMFrame3 *frame = iface, *parent_frame = NULL; > > - return E_NOTIMPL; > + TRACE("iface %p, scene %p.\n", iface, scene); > + > + if (!scene) > + return D3DRMERR_BADVALUE; > + > + for (;;) > + { > + if (FAILED(hr = IDirect3DRMFrame3_GetParent(frame, &parent_frame))) > + return hr; > + if (parent_frame) > + { > + frame = parent_frame; > + IDirect3DRMFrame3_Release(parent_frame); > + } > + else > + break; > + } You could just do if (!parent_frame) break; More importantly though, as Stefan already mentioned, the reference counting is weird. I think the code would be much nicer if you just used impl_from_IDirect3DRMFrame3() and then followed the frame->parent pointers.

2 1

Re: [PATCH 3/3] d3drm: Implement IDirect3DRMViewport*::Clear. (v3)
by Henri Verbeet 09 Aug '16

09 Aug '16

On 9 August 2016 at 03:20, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v2: Remove some redundancies and add more tests. Handling of Clear without depth surface is still a bit weird as wined3d_device_clear seems to return an error on a device with no depth surface since the start vs device whose depth surface was deleted after it was created, in which case it (oddly) returns successfully, even having access to and successfully clearing the depth surface. > What does "deleted" and "surface" mean in the above? If it's just releasing the references to the depth/stencil texture and view, note that the device state keeps a reference to view that wouldn't be released until you set a different view or NULL.

2 1

Re: [PATCH 1/3] d3drm: Store reference to render target in IDirect3DRM*::CreateDeviceFromD3D.
by Henri Verbeet 09 Aug '16

09 Aug '16

On 9 August 2016 at 03:16, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abaed5..2c82ecb 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -4572,7 +4572,7 @@ static void test_create_device_from_d3d1(void) > ref3 = get_refcount((IUnknown *)d3drm1); > ok(ref3 > ref2, "expected ref3 > ref1, got ref1 = %u , ref3 = %u.\n", ref1, ref3); > ref3 = get_refcount((IUnknown *)temp_d3ddevice1); > - ok(ref3 == device_ref2, "Expected ref3 == device_ref2, got ref3 = %u, device_ref2 = %u.\n", ref3, device_ref2); > + todo_wine ok(ref3 == device_ref2, "Expected ref3 == device_ref2, got ref3 = %u, device_ref2 = %u.\n", ref3, device_ref2); So what does this patch fix?

2 1

Re: imm32, user32: Create and destroy the default IME window implicitly. (try 9)
by Alexandre Julliard 09 Aug '16

09 Aug '16

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 9: > - Withdraw try 8 changes as we have ImmDisableIME now. > - Rebased and resolve conflicts against ImmDisableIME patch. This is still breaking some tests: ../../../tools/runtest -q -P wine -T ../../.. -M ole32.dll -p ole32_test.exe.so compobj && touch compobj.ok compobj.c:2618: Test failed: CoWaitForMultipleHandles unexpectedly pumped messages make: *** [compobj.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] usp10: Better implementation for ScriptGetLogicalWidths()
by Marvin 09 Aug '16

09 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24886 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

[RFC PATCH 2/2] programs/services: Load device drivers of the same group into the same winedevice process
by Aric Stewart 09 Aug '16

09 Aug '16

--- programs/services/services.c | 112 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 112 insertions(+)

1 0

[RFC PATCH 1/2] programs/services: Break services into Loader groups
by Aric Stewart 09 Aug '16

09 Aug '16

Sort the groups by the service's tag to start in order --- programs/services/services.c | 101 ++++++++++++++++++++++++++++++++----------- 1 file changed, 75 insertions(+), 26 deletions(-)

1 0

[RFC PATCH 2/2] programs/winedevice: Dynamically load devices into group device
by Aric Stewart 09 Aug '16

09 Aug '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- programs/winedevice/device.c | 55 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 54 insertions(+), 1 deletion(-)

1 0

[RFC PATCH 1/2] programs/winedevice.exe: allow loading multiple devices on the command line
by Aric Stewart 09 Aug '16

09 Aug '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> --- programs/winedevice/device.c | 92 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 75 insertions(+), 17 deletions(-)

1 0

Re: [PATCH] advapi32: Allow for sending extended control events to services
by Sebastian Lackner 09 Aug '16

09 Aug '16

On 08.08.2016 17:41, Aric Stewart wrote: > > This allows dwEventType and lpEventData parameters to be sent > > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > dlls/advapi32/service.c | 36 ++++++++++++++++++++++++++++-------- > include/wine/svcctl.idl | 11 ++++++++++- > 2 files changed, 38 insertions(+), 9 deletions(-) > It might be useful to validate the parameters received from the control pipe before assuming its safe to access the data. The existing code is also not really perfect yet, however it wouldn't hurt to add some checks. Nevertheless, even more important, it would also be good to combine this in a series with the corresponding programs/services part, so that it can be tested and we are sure this is the right way to solve it. Best regards, Sebastian

2 1

Re: [PATCH] msvcp140/tests: Initial tests for thread functions
by Piotr Caban 09 Aug '16

09 Aug '16

Hi Nikolay, On 08/08/16 23:26, Nikolay Sivov wrote: > + ret = p__Thrd_create(&ta, thrd_thread, NULL); > + ok(!ret, "failed to create thread, got %d\n", ret); > + ret = p__Thrd_detach(ta); > + ok(!ret, "_Thrd_detach failed, got %d\n", ret); Could you please duplicate the thread handle and wait for the thread to finish before exiting the tests? It would be nice to also change the msvcp120 tests this way. Thanks, Piotr

1 0

Re: [PATCH] vcomp140: Add vcomp140 stub
by Sebastian Lackner 09 Aug '16

09 Aug '16

On 09.08.2016 05:31, Daniel Lehman wrote: > > 0001-vcomp140-Add-vcomp140-stub.txt > > > From 4a1bccc08c4fce6c37921cc7d94d4e738433c92b Mon Sep 17 00:00:00 2001 > From: Daniel Lehman <dlehman(a)esri.com> > Date: Mon, 8 Aug 2016 19:56:29 -0700 > Subject: [PATCH] vcomp140: Add vcomp140 stub > > Signed-off-by: Daniel Lehman <dlehman(a)esri.com> > --- > configure.ac | 1 + > dlls/vcomp140/Makefile.in | 1 + > dlls/vcomp140/vcomp140.spec | 113 ++++++++++++++++++++++++++++++++++++++++++++ > tools/make_specfiles | 1 + > 4 files changed, 116 insertions(+) > create mode 100644 dlls/vcomp140/Makefile.in > create mode 100644 dlls/vcomp140/vcomp140.spec Thanks for working on this. Is there any specific reason why you omitted the DllMain method? It might be better to return FALSE from DLL_WINE_PREATTACH to ensure the native dll is preferred if available (like done in all other vcomp* dlls). I would also be fine to switch vcomp to "prefer builtin" at some point, however I am not sure if it is sufficiently tested yet. There are still various unimplemented functions, so apps could stop working if they were using native vcomp140 before. Other opinions are also welcome of course. ;) Regards, Sebastian

2 3

Re: [PATCH] ntdll: Call __finally blocks in __C_specific_handler (try3)
by Piotr Caban 09 Aug '16

09 Aug '16

Hi, On 08/09/16 00:33, Daniel Lehman wrote: > Try2: don't use exception handler signature for termination handler You've sent old patch, with wrong termination handler signature. Thanks, Piotr

1 0

Re: [PATCH 3/5] server: Get and set the console ColorTable
by Alexandre Julliard 09 Aug '16

09 Aug '16

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > @@ -1568,6 +1568,22 @@ struct console_renderer_event > short int font_height; > @END > > + > +/* Fill the console ColorTable */ > +@REQ(set_console_colortable) > + obj_handle_t handle; /* handle to the console */ > + VARARG(color,unsigned_int); /* ColorTable */ > +@END > + > + > +/* Fetch the console ColorTable */ > +@REQ(get_console_colortable) > + obj_handle_t handle; /* handle to the console */ > +@REPLY > + VARARG(color,unsigned_int); /* ColorTable */ > +@END It would probably be better to add this to the existing get/set_console_output_info requests. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 7/7] wined3d: Do not enable blending for edge/line antialiasing.
by Marvin 08 Aug '16

08 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24847 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 7/7] wined3d: Do not enable blending for edge/line antialiasing.
by Marvin 08 Aug '16

08 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24846 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: [PATCH 5/7] ddraw/tests: Add test for edge antialiasing blending.
by Marvin 08 Aug '16

08 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24841 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2295: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

Re: server: Fix loading of IMAGE_OPTIONAL_HEADER
by Marvin 08 Aug '16

08 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24836 Your paranoid android. === w1064 (32 bit loader) === loader.c:2867: Test failed: Test 0: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 0: expected 74374550, got 00000000 loader.c:2867: Test failed: Test 1: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 1: expected 72BC2CF0, got 00000000 loader.c:2867: Test failed: Test 2: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 2: expected 74372DC0, got 00000000 loader.c:2875: Test failed: Test 3: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2876: Test failed: Test 3: Wrong callback count: 0 loader.c:2875: Test failed: Test 4: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2876: Test failed: Test 4: Wrong callback count: 0 === wvistau64 (64 bit loader) === loader.c:720: Test failed: 2: unexpected error 193 loader.c:720: Test failed: 3: unexpected error 193 loader.c:720: Test failed: 4: unexpected error 193 loader.c:720: Test failed: 6: unexpected error 193 loader.c:720: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:720: Test failed: 2: unexpected error 193 loader.c:720: Test failed: 3: unexpected error 193 loader.c:720: Test failed: 4: unexpected error 193 loader.c:720: Test failed: 6: unexpected error 193 loader.c:720: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:720: Test failed: 2: unexpected error 193 loader.c:720: Test failed: 3: unexpected error 193 loader.c:720: Test failed: 4: unexpected error 193 loader.c:720: Test failed: 6: unexpected error 193 loader.c:720: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:720: Test failed: 2: unexpected error 193 loader.c:720: Test failed: 3: unexpected error 193 loader.c:720: Test failed: 4: unexpected error 193 loader.c:720: Test failed: 6: unexpected error 193 loader.c:720: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:720: Test failed: 2: unexpected error 193 loader.c:720: Test failed: 3: unexpected error 193 loader.c:720: Test failed: 4: unexpected error 193 loader.c:720: Test failed: 6: unexpected error 193 loader.c:720: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784

2 1

Re: [PATCH 1/1] riched20: allow setting background text color
by Huw Davies 08 Aug '16

08 Aug '16

Hi Kenneth, Thanks for your contribution to Wine. Please see below for some comments. On Sat, Aug 06, 2016 at 02:17:34PM -0600, Kenneth Haley wrote: > diff --git a/dlls/riched20/paint.c b/dlls/riched20/paint.c > index 42434b9..df7af79 100644 > --- a/dlls/riched20/paint.c > +++ b/dlls/riched20/paint.c > @@ -318,11 +318,20 @@ static void get_selection_rect( ME_Context *c, ME_Run *run, int from, int to, in > static void draw_text( ME_Context *c, ME_Run *run, int x, int y, BOOL selected, RECT *sel_rect ) > { > COLORREF text_color = get_text_color( c, run->style, selected ); > - COLORREF back_color = selected ? ITextHost_TxGetSysColor( c->editor->texthost, COLOR_HIGHLIGHT ) : 0; > + COLORREF back_color = 0; > COLORREF old_text, old_back = 0; > const WCHAR *text = get_text( run, 0 ); > ME_String *masked = NULL; > > + if (selected) > + back_color = ITextHost_TxGetSysColor( c->editor->texthost, COLOR_HIGHLIGHT ); > + else if(run->style->fmt.dwMask & CFM_BACKCOLOR) > + if (!(CFE_AUTOBACKCOLOR & run->style->fmt.dwEffects)) > + { > + back_color = run->style->fmt.crBackColor; > + selected = TRUE; > + } > + You don't need two 'if's in the 'else' clause, just combine them with an &&. I think we should introduce a new boolean 'paint_bkgnd' (or something) rather than hijacking 'selected' here. It would be set to TRUE if 'selected' or we have a background colour. The code that follows this would then use that rather than 'selected'. Also, please use 4-space indents in this function and be consistant about spaces after an 'if'. > @@ -385,6 +394,18 @@ static void ME_DrawTextWithStyle(ME_Context *c, ME_Run *run, int x, int y, > } > } > } > + else if(run->style->fmt.dwMask & CFM_BACKCOLOR) Again, space after 'if'. > + { > + get_selection_rect( c, run, 0, run->len, cy, &sel_rect ); > + OffsetRect( &sel_rect, x, ymin ); > + sel_rgn = CreateRectRgnIndirect( &sel_rect ); > + clip = CreateRectRgn( 0, 0, 0, 0 ); > + if (GetClipRgn( hDC, clip ) != 1) > + { > + DeleteObject( clip ); > + clip = NULL; > + } > + } This block is essentially a copy of the selected block. It should be possible to rewrite the if condition in that block so you don't need to duplicate this code. Huw.

1 0

Re: [PATCH] winedevice: Remove static driver_obj variable
by Sebastian Lackner 08 Aug '16

08 Aug '16

On 05.08.2016 14:26, Aric Stewart wrote: > Signed-off-by: Aric Stewart <aric(a)codeweavers.com> > --- > programs/winedevice/device.c | 36 ++++++++++++++++++++++++++++++------ > 1 file changed, 30 insertions(+), 6 deletions(-) > > > > 0001-winedevice-Remove-static-driver_obj-variable.txt > > > diff --git a/programs/winedevice/device.c b/programs/winedevice/device.c > index e31318c..2744b9d5 100644 > --- a/programs/winedevice/device.c > +++ b/programs/winedevice/device.c > @@ -42,7 +42,16 @@ extern NTSTATUS CDECL wine_ntoskrnl_main_loop( HANDLE stop_event ); > > static SERVICE_STATUS_HANDLE service_handle; > static HANDLE stop_event; > -static DRIVER_OBJECT *driver_obj; > + > +static const WCHAR driverW[] = {'\\','D','r','i','v','e','r','\\',0}; > +extern NTSTATUS WINAPI ObReferenceObjectByName( UNICODE_STRING *ObjectName, > + ULONG Attributes, > + ACCESS_STATE *AccessState, > + ACCESS_MASK DesiredAccess, > + POBJECT_TYPE ObjectType, > + KPROCESSOR_MODE AccessMode, > + void *ParseContext, > + void **Object); It might be better to add this to a public header file. On Windows its in a different header file, but Wine already has a couple of ObReference* functions in include/ddk/wdm.h. You could add it there, too. > > /* find the LDR_MODULE corresponding to the driver module */ > static LDR_MODULE *find_ldr_module( HMODULE module ) > @@ -225,7 +234,6 @@ static NTSTATUS WINAPI init_driver( DRIVER_OBJECT *driver_object, UNICODE_STRING > if (!module) > return STATUS_DLL_INIT_FAILED; > > - driver_obj = driver_object; > driver_object->DriverSection = find_ldr_module( module ); > > nt = RtlImageNtHeader( module ); > @@ -253,9 +261,26 @@ static NTSTATUS WINAPI init_driver( DRIVER_OBJECT *driver_object, UNICODE_STRING > } > > /* call the driver unload function */ > -static void unload_driver( DRIVER_OBJECT *driver_obj ) > +static void unload_driver( const WCHAR *driver_name ) > { > - LDR_MODULE *ldr = driver_obj->DriverSection; > + DRIVER_OBJECT *driver_obj; > + LDR_MODULE *ldr; > + UNICODE_STRING drv_name; > + WCHAR *str; > + > + str = HeapAlloc( GetProcessHeap(), 0, sizeof(driverW) + strlenW(driver_name)*sizeof(WCHAR) ); > + lstrcpyW( str, driverW); > + lstrcatW( str, driver_name ); > + RtlInitUnicodeString( &drv_name, str ); > + > + if (ObReferenceObjectByName( &drv_name, OBJ_CASE_INSENSITIVE, NULL, > + 0, NULL, KernelMode, NULL, (void**)&driver_obj ) != STATUS_SUCCESS) To avoid putting together the string twice, you could already call this function immediately after loading. Also, in theory you would have to release the reference obtained by "ObReferenceObjectByName" using ObDereferenceObject. Since there is no refcounting yet its fine to skip it, but it might be important at some later point. > + { > + ERR("Failed to locate loaded driver (%s)\n", wine_dbgstr_w(driver_name)); > + return; You are leaking the drv_name variable here and at the end of the function. > + } > + > + ldr = driver_obj->DriverSection; > > if (driver_obj->DriverUnload) > { > @@ -276,7 +301,6 @@ static void unload_driver( DRIVER_OBJECT *driver_obj ) > > static NTSTATUS create_driver(const WCHAR *driver_name) > { > - static const WCHAR driverW[] = {'\\','D','r','i','v','e','r','\\',0}; > UNICODE_STRING drv_name; > NTSTATUS status; > WCHAR *str; > @@ -351,7 +375,7 @@ static void WINAPI ServiceMain( DWORD argc, LPWSTR *argv ) > SetServiceStatus( service_handle, &status ); > > wine_ntoskrnl_main_loop( stop_event ); > - unload_driver( driver_obj ); > + unload_driver( driver_name ); > } > else WINE_ERR( "driver %s failed to load\n", wine_dbgstr_w(driver_name) ); > > > >

2 3

Re: [3/3] kernel32/tests: Remove superfluous filler definitions
by Marvin 07 Aug '16

07 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24824 Your paranoid android. === w7u (32 bit loader) === loader.c:2439: Test failed: WaitForSingleObject failed: 102 === w1064 (32 bit loader) === loader.c:2855: Test failed: Test 0: ResolveDelayLoadedAPI failed loader.c:2856: Test failed: Test 0: expected 74374550, got 00000000 loader.c:2855: Test failed: Test 1: ResolveDelayLoadedAPI failed loader.c:2856: Test failed: Test 1: expected 72BC2CF0, got 00000000 loader.c:2855: Test failed: Test 2: ResolveDelayLoadedAPI failed loader.c:2856: Test failed: Test 2: expected 74372DC0, got 00000000 loader.c:2863: Test failed: Test 3: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2864: Test failed: Test 3: Wrong callback count: 0 loader.c:2863: Test failed: Test 4: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2864: Test failed: Test 4: Wrong callback count: 0 === wvistau64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784

1 0

Re: [2/3] kernel32/tests: Use SetFilePointer instead of GetFileSize with WriteFile
by Marvin 07 Aug '16

07 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24823 Your paranoid android. === w7u (32 bit loader) === loader.c:2440: Test failed: WaitForSingleObject failed: 102 loader.c:2442: Test failed: expected exit code 199, got 259 loader.c:2461: Test failed: expected 198, got 199 === w1064 (32 bit loader) === loader.c:2857: Test failed: Test 0: ResolveDelayLoadedAPI failed loader.c:2858: Test failed: Test 0: expected 74374550, got 00000000 loader.c:2857: Test failed: Test 1: ResolveDelayLoadedAPI failed loader.c:2858: Test failed: Test 1: expected 72BC2CF0, got 00000000 loader.c:2857: Test failed: Test 2: ResolveDelayLoadedAPI failed loader.c:2858: Test failed: Test 2: expected 74372DC0, got 00000000 loader.c:2865: Test failed: Test 3: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2866: Test failed: Test 3: Wrong callback count: 0 loader.c:2865: Test failed: Test 4: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2866: Test failed: Test 4: Wrong callback count: 0 === wvistau64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 The test timed out

1 0

Re: [1/3] kernel32/tests: Explicitly set SizeOfRawData
by Marvin 07 Aug '16

07 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24822 Your paranoid android. === w1064 (32 bit loader) === loader.c:2867: Test failed: Test 0: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 0: expected 74374550, got 00000000 loader.c:2867: Test failed: Test 1: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 1: expected 72BC2CF0, got 00000000 loader.c:2867: Test failed: Test 2: ResolveDelayLoadedAPI failed loader.c:2868: Test failed: Test 2: expected 74372DC0, got 00000000 loader.c:2875: Test failed: Test 3: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2876: Test failed: Test 3: Wrong callback count: 0 loader.c:2875: Test failed: Test 4: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2876: Test failed: Test 4: Wrong callback count: 0 === wvistau64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w2008s64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w7pro64 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w864 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784 === w1064 (64 bit loader) === loader.c:718: Test failed: 2: unexpected error 193 loader.c:718: Test failed: 3: unexpected error 193 loader.c:718: Test failed: 4: unexpected error 193 loader.c:718: Test failed: 6: unexpected error 193 loader.c:718: Test failed: 7: unexpected error 193 loader.c:173: Test failed: WriteFile error 1784

1 0

Re: [PATCH 1/2] ddraw/tests: Skip overlay tests if DWM is on.
by Marvin 07 Aug '16

07 Aug '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=24816 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw2) === ddraw2.c:2357: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw7) === ddraw7.c:2272: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw1) === ddraw1.c:2206: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw1) === ddraw1.c:2206: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (32 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). === w1064 (64 bit ddraw4) === ddraw4.c:2542: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).

1 0

WineHQ upgrade breaking dinput8:dinput?
by Francois Gouget 07 Aug '16

07 Aug '16

This is a truly weird one. dinput8:dinput start failing on the 17th, the day after WineHQ was upgraded: https://test.winehq.org/data/tests/dinput8:dinput.html What makes this weird is that: * There has been no change to these tests between bd332f53f2d7 and 966a07149a02. In fact the last patch goes back to 2013. So it's not a bad patch. * The failures happen on every 32 bit test environment, from XP to Windows 10, VM or not, TestBot or not. Only 64 bit is spared. * I compiled a dinput8_crosstest.exe binary bd332f53f2d7 which was not failing according to the test.winehq.org results. But all I got is failures: - 887b445bb878, 8th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21611 - bd332f53f2d7, 16th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21610 - 329dfee70c35, 22nd, 13 test.winehq.org failures, 13 here https://testbot.winehq.org/JobDetails.pl?Key=21609 My MinGW compiler is more recent than the one WineHQ was using before the upgrade however. So I think this points to a compiler-related issue. The official WineTest binaries are build on WineHQ so I suspect the MinGW upgrade is somehow responsible for the new failures. However I don't know if the old compiler was masking them, of if the new one is causing them. Any ideas? For reference: * Debian Testing (my environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 5.3.1 20160205 * Debian 7 (close to former WineHQ environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 4.9.1 -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

5 15

Re: [PATCH 2/2] d3drm: Implement IDirect3DRMViewport*::Clear.
by Stefan Dösinger 07 Aug '16

07 Aug '16

On 2016-08-06 16:29, Aaryaman Vasishta wrote: > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/tests/d3drm.c | 640 +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/d3drm/viewport.c | 71 +++++- > 2 files changed, 704 insertions(+), 7 deletions(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index c4020e4..b9a83a0 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -5852,6 +5852,644 @@ static void test_viewport_qi(void) > IDirect3DRM_Release(d3drm1); > } > > +static D3DCOLOR get_surface_color(IDirectDrawSurface *surface, UINT x, UINT y) > +{ > + RECT rect = { x, y, x + 1, y + 1 }; > + DDSURFACEDESC surface_desc; > + D3DCOLOR color; > + HRESULT hr; > + > + memset(&surface_desc, 0, sizeof(surface_desc)); > + surface_desc.dwSize = sizeof(surface_desc); > + > + hr = IDirectDrawSurface_Lock(surface, &rect, &surface_desc, DDLOCK_READONLY | DDLOCK_WAIT, NULL); > + ok(SUCCEEDED(hr), "Failed to lock surface, hr %#x.\n", hr); > + if (FAILED(hr)) > + return 0xdeadbeef; > + > + color = *((DWORD *)surface_desc.lpSurface) & 0x00ffffff; > + > + hr = IDirectDrawSurface_Unlock(surface, NULL); > + ok(SUCCEEDED(hr), "Failed to unlock surface, hr %#x.\n", hr); > + > + return color; > +} > + > +static BOOL compare_color(D3DCOLOR c1, D3DCOLOR c2, BYTE max_diff) > +{ > + if ((c1 & 0xff) - (c2 & 0xff) > max_diff) return FALSE; > + c1 >>= 8; c2 >>= 8; > + if ((c1 & 0xff) - (c2 & 0xff) > max_diff) return FALSE; > + c1 >>= 8; c2 >>= 8; > + if ((c1 & 0xff) - (c2 & 0xff) > max_diff) return FALSE; > + c1 >>= 8; c2 >>= 8; > + if ((c1 & 0xff) - (c2 & 0xff) > max_diff) return FALSE; > + return TRUE; > +} > + > +static void clear_depth_surface(IDirectDrawSurface *surface, DWORD value) > +{ > + HRESULT hr; > + DDBLTFX fx; > + > + memset(&fx, 0, sizeof(fx)); > + fx.dwSize = sizeof(fx); > + U5(fx).dwFillDepth = value; > + > + hr = IDirectDrawSurface_Blt(surface, NULL, NULL, NULL, DDBLT_DEPTHFILL | DDBLT_WAIT, &fx); > + ok(SUCCEEDED(hr), "Got unexpected hr %#x.\n", hr); > +} > + > +static void set_execute_data(IDirect3DExecuteBuffer *execute_buffer, UINT vertex_count, UINT offset, UINT len) > +{ > + D3DEXECUTEDATA exec_data; > + HRESULT hr; > + > + memset(&exec_data, 0, sizeof(exec_data)); > + exec_data.dwSize = sizeof(exec_data); > + exec_data.dwVertexCount = vertex_count; > + exec_data.dwInstructionOffset = offset; > + exec_data.dwInstructionLength = len; > + hr = IDirect3DExecuteBuffer_SetExecuteData(execute_buffer, &exec_data); > + ok(SUCCEEDED(hr), "Failed to set execute data, hr %#x.\n", hr); > +} > + > +static void emit_set_ts(void **ptr, D3DTRANSFORMSTATETYPE state, DWORD value) > +{ > + D3DINSTRUCTION *inst = *ptr; > + D3DSTATE *ts = (D3DSTATE *)(inst + 1); > + > + inst->bOpcode = D3DOP_STATETRANSFORM; > + inst->bSize = sizeof(*ts); > + inst->wCount = 1; > + > + U1(*ts).dtstTransformStateType = state; > + U2(*ts).dwArg[0] = value; > + > + *ptr = ts + 1; > +} > + > +static void emit_set_rs(void **ptr, D3DRENDERSTATETYPE state, DWORD value) > +{ > + D3DINSTRUCTION *inst = *ptr; > + D3DSTATE *rs = (D3DSTATE *)(inst + 1); > + > + inst->bOpcode = D3DOP_STATERENDER; > + inst->bSize = sizeof(*rs); > + inst->wCount = 1; > + > + U1(*rs).drstRenderStateType = state; > + U2(*rs).dwArg[0] = value; > + > + *ptr = rs + 1; > +} > + > +static void emit_process_vertices(void **ptr, DWORD flags, WORD base_idx, DWORD vertex_count) > +{ > + D3DINSTRUCTION *inst = *ptr; > + D3DPROCESSVERTICES *pv = (D3DPROCESSVERTICES *)(inst + 1); > + > + inst->bOpcode = D3DOP_PROCESSVERTICES; > + inst->bSize = sizeof(*pv); > + inst->wCount = 1; > + > + pv->dwFlags = flags; > + pv->wStart = base_idx; > + pv->wDest = 0; > + pv->dwCount = vertex_count; > + pv->dwReserved = 0; > + > + *ptr = pv + 1; > +} > + > +static void emit_tquad(void **ptr, WORD base_idx) > +{ > + D3DINSTRUCTION *inst = *ptr; > + D3DTRIANGLE *tri = (D3DTRIANGLE *)(inst + 1); > + > + inst->bOpcode = D3DOP_TRIANGLE; > + inst->bSize = sizeof(*tri); > + inst->wCount = 2; > + > + U1(*tri).v1 = base_idx; > + U2(*tri).v2 = base_idx + 1; > + U3(*tri).v3 = base_idx + 2; > + tri->wFlags = D3DTRIFLAG_START; > + ++tri; > + > + U1(*tri).v1 = base_idx + 2; > + U2(*tri).v2 = base_idx + 1; > + U3(*tri).v3 = base_idx + 3; > + tri->wFlags = D3DTRIFLAG_ODD; > + ++tri; > + > + *ptr = tri; > +} > + > +static void emit_end(void **ptr) > +{ > + D3DINSTRUCTION *inst = *ptr; > + > + inst->bOpcode = D3DOP_EXIT; > + inst->bSize = 0; > + inst->wCount = 0; > + > + *ptr = inst + 1; > +} > + > +static void d3d_draw_quad1(IDirect3DDevice *device, IDirect3DViewport *viewport) > +{ > + IDirect3DExecuteBuffer *execute_buffer; > + D3DEXECUTEBUFFERDESC exec_desc; > + HRESULT hr; > + void *ptr; > + UINT inst_length; > + D3DMATRIXHANDLE world_handle, view_handle, proj_handle; > + static D3DMATRIX mat = > + { > + 1.0f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.0f, 0.0f, 0.0f, > + 0.0f, 0.0f, 1.0f, 0.0f, > + 0.0f, 0.0f, 0.0f, 1.0f, > + }; > + static const D3DLVERTEX quad_strip[] = > + { > + {{-1.0f}, {-1.0f}, {0.80f}, 0, {0xffbada55}}, > + {{-1.0f}, { 1.0f}, {0.80f}, 0, {0xffbada55}}, > + {{ 1.0f}, {-1.0f}, {0.80f}, 0, {0xffbada55}}, > + {{ 1.0f}, { 1.0f}, {0.80f}, 0, {0xffbada55}}, > + }; You could make this {{-1.0f}, {-1.0f}, {0.0f}, 0, {0xffbada55}}, {{-1.0f}, { 1.0f}, {0.0f}, 0, {0xffbada55}}, {{ 1.0f}, {-1.0f}, {1.0f}, 0, {0xffbada55}}, {{ 1.0f}, { 1.0f}, {1.0f}, 0, {0xffbada55}}, Then your currently discarded draws will draw to ca x = 250. That way you can make sure the draw is really discarded by the depth test and not some other reason. > + /* Check what happens if we release the depth surface that d3drm created, and clear the viewport */ > ... > + hr = IDirect3DRMViewport_Clear(viewport1); > + ok(SUCCEEDED(hr), "Cannot clear viewport (hr = %#x).\n", hr); It's worth checking the color surface here to see if the clear was completely ignored or if it realized that there's no depth surface and it only cleared color. Also clear with a different color than what's left behind by the previous test. > ... > + d3d_draw_quad1(d3d_device1, d3d_viewport); > + > + ret_color = get_surface_color(surface, 100, 200); > + todo_wine ok(compare_color(ret_color, 0x000000ff, 1), "Got unexpected color 0x%08x.\n", ret_color); My reading of this is that the depth surface wasn't cleared (everything else would be very surprising). If the color surface was indeed cleared this shows that native at some place expects your ugly deed of removing the depth surface. If the color is not cleared it and the clear call is completely ignored I'd say something is broken somewhere and we shouldn't care too much about this corner case. > + hr = IDirect3DRM_CreateViewport(d3drm1, device1, dummy_frame1, 0, 0, rc.right, > + rc.bottom, &viewport1); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMViewport interface (hr = %#x)\n", hr); > + > + > + /* Clear uses the scene/root frame's background color. */ Two newlines. Is that intentional? > + hr = IDirect3DRMFrame_SetSceneBackgroundRGB(frame1, 1.0f, 1.0f, 1.0f); > + ok(SUCCEEDED(hr), "Cannot set scene background RGB (hr = %#x)\n", hr); > + ret_color = IDirect3DRMFrame_GetSceneBackground(frame1); > + ok(ret_color == 0xffffffff, "Expected scene color returned == 0xffffffff, got %#x.\n", ret_color); > + hr = IDirect3DRMFrame_SetSceneBackgroundRGB(dummy_frame1, 0.0f, 1.0f, 0.0f); > + ok(SUCCEEDED(hr), "Cannot set scene background RGB (hr = %#x)\n", hr); > + ret_color = IDirect3DRMFrame_GetSceneBackground(dummy_frame1); > + ok(ret_color == 0xff00ff00, "Expected scene color returned == 0xff00ff00, got %#x.\n", ret_color); > + hr = IDirect3DRMFrame_SetSceneBackgroundRGB(dummy_frame1, 0.0f, 0.0f, 1.0f); > + ok(SUCCEEDED(hr), "Cannot set scene background RGB (hr = %#x)\n", hr); > + ret_color = IDirect3DRMFrame_GetSceneBackground(dummy_frame1); > + ok(ret_color == 0xff0000ff, "Expected scene color returned == 0xff0000ff, got %#x.\n", ret_color); Can't the "where does the color come from" test be merged into the clear test at the start? > +static void draw_quad2(IDirect3DDevice2 *device, IDirect3DViewport *viewport) > +{ Do you need to draw with IDirect3DDevice2 directly here? What about QI'ing IDirect3DDevice and calling d3d_draw_quad1? > diff --git a/dlls/d3drm/viewport.c b/dlls/d3drm/viewport.c > index cb57fe0..371aae3 100644 > --- a/dlls/d3drm/viewport.c > +++ b/dlls/d3drm/viewport.c > @@ -39,6 +39,42 @@ static inline struct d3drm_viewport *impl_from_IDirect3DRMViewport2(IDirect3DRMV > return CONTAINING_RECORD(iface, struct d3drm_viewport, IDirect3DRMViewport2_iface); > } > > +static inline void d3drm_normalize_d3d_color(D3DCOLORVALUE *color_value, D3DCOLOR color) > +{ > + color_value->r = RGBA_GETRED(color) / 255.0f; > + color_value->g = RGBA_GETGREEN(color) / 255.0f; > + color_value->b = RGBA_GETBLUE(color) / 255.0f; > + color_value->a = RGBA_GETALPHA(color) / 255.0f; > +} > + > +static HRESULT d3drm_update_background_material(struct d3drm_viewport *viewport) > +{ > + IDirect3DRMFrame *root_frame; > + D3DCOLOR color; > + D3DMATERIAL mat; > + D3DMATERIALHANDLE hmat; > + HRESULT hr; > + > + if (FAILED(hr = IDirect3DRMFrame_GetScene(viewport->camera, &root_frame))) > + return hr; > + color = IDirect3DRMFrame_GetSceneBackground(root_frame); You are leaking root_frame here. > + if (FAILED(hr = IDirect3DMaterial_GetHandle(viewport->material, viewport->device->device, &hmat))) > + return hr; > + > + if (FAILED(hr = IDirect3DViewport_SetBackground(viewport->d3d_viewport, hmat))) > + return hr; You can do these two calls during viewport creation, you don't have to repeat them every time. > @@ -344,10 +380,7 @@ static HRESULT WINAPI d3drm_viewport2_Init(IDirect3DRMViewport2 *iface, IDirect3 > > memset(&mat, 0, sizeof(mat)); > mat.dwSize = sizeof(mat); > - mat.diffuse.r = RGBA_GETRED(color) / 255.0f; > - mat.diffuse.g = RGBA_GETGREEN(color) / 255.0f; > - mat.diffuse.b = RGBA_GETBLUE(color) / 255.0f; > - mat.diffuse.a = RGBA_GETALPHA(color) / 255.0f; > + d3drm_normalize_d3d_color(&mat.diffuse, color); > > if (FAILED(hr = IDirect3DMaterial_SetMaterial(material, &mat))) > goto cleanup; You can remove the IDirect3DMaterial::SetMaterial call from Init because you have to do it every time clear is called anyway. Keep the GetHandle / SetBackground call in Init though to link the material with the viewport. > static HRESULT WINAPI d3drm_viewport2_Clear(IDirect3DRMViewport2 *iface, DWORD flags) > ... > + if (flags & D3DRMCLEAR_ZBUFFER) > + clear_flags |= D3DCLEAR_ZBUFFER; I guess somewhere here or in the IDirect3DViewport::Clear implementation in ddraw you'll have to handle your missing depth buffer case.

2 4

Re: [PATCH 1/2] d3drm: Implement IDirect3DRMFrame*::GetScene.
by Stefan Dösinger 06 Aug '16

06 Aug '16

On 2016-08-06 16:29, Aaryaman Vasishta wrote: > + while (!done) > + { > + if (FAILED(hr = IDirect3DRMFrame3_GetParent(frame, &parent_frame))) > + return hr; > + if (parent_frame) > + { > + frame = parent_frame; > + IDirect3DRMFrame3_Release(parent_frame); > + } > + else > + done = TRUE; > + } What happens if GetScene is called on the root frame? Does it return itself or NULL or an error? You can eliminate the done variable from this loop by replacing it with a break: for (;;) { if (FAILED(hr = IDirect3DRMFrame3_GetParent(frame, &parent_frame))) return hr; if (parent_frame) { frame = parent_frame; IDirect3DRMFrame3_Release(parent_frame); } else break; } I originally thought about a do {} while(parent_frame); kind of construct but that doesn't gain you much because you need the if check anyway to release parent_frame. It's not nice to call GetParent in the next iteration after you release the frame, but so far I haven't come up with an implementation that avoids that and isn't terribly ugly. I'll keep thinking.

2 1

Re: winealsa.drv: Use debugstr_guid() to trace a guid.
by Andrew Eikum 06 Aug '16

06 Aug '16

On Fri, Aug 05, 2016 at 03:55:55PM +0200, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/winealsa.drv/mmdevdrv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 14eac39..8577e75 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -3390,7 +3390,7 @@ static HRESULT WINAPI SimpleAudioVolume_SetMute(ISimpleAudioVolume *iface, > AudioSessionWrapper *This = impl_from_ISimpleAudioVolume(iface); > AudioSession *session = This->session; > > - TRACE("(%p)->(%u, %p)\n", session, mute, context); > + TRACE("(%p)->(%u, %p)\n", session, mute, debugstr_guid(context)); > The format on these should be changed to %s, right? Andrew

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel