- wine-devel - winehq.org

Re: [2/3] user32/tests: Add tests for button WM_CTLCOLOR* messages.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22345 Your paranoid android. === w864 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6482: Test failed: Update region shouldn't be empty msg.c:6716: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6718: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:6488: Test failed: Regions are different msg.c:7438: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a

1 0

Re: [PATCH 1/5] dwrite/tests: Added GetFontSignature() test
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22328 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: user32: Do not block sending/posting WM_NOTIFY messages. (v2)
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22327 Your paranoid android. === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

2 1

Re: [PATCH 5/5] dwrite: Initial implementation of IDWriteFontFaceReference
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] dwrite: Accept local loader in CreateCustomFontFileReference()
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22331 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] dwrite: Handle NULL path in CreateFontFileReference()
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22330 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] dwrite/tests: Some basic tests for fontface references
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22329 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Ignore invalid exit_frame when exiting thread.
by Alexandre Julliard 19 Apr '16

19 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > When applications switch to a custom stack, exit_frame is not necessarily > valid anymore. How does it become invalid? Does the app unmap the previous stack? -- Alexandre Julliard julliard(a)winehq.org

2 6

[PATCH] Added Nvidia GT 9700M
by Kim Malmo 19 Apr '16

19 Apr '16

Thanks for your feedback Henri. By looking at similar cards in the code I found the GT/GTS description were often omitted from mobile (M) cards. I wanted to keep the same text formatting. This is indeed the GT version and I can add that to the patch. I will sign off the next patch, still getting to grips with git. -- Date: Mon, 18 Apr 2016 19:00:33 +0200 From: Henri Verbeet<hverbeet(a)gmail.com> To: wine-devel<wine-devel(a)winehq.org> Cc: Kim Malmo<kimmalmo(a)protonmail.ch> Subject: Re: [PATCH] Added Nvidia GT 9700M Message-ID: <CAOsNvwyqyR1swwYaPUhiOpu7+TtBRuC9yg33Zi4+KYE1J0EyEw(a)mail.gmail.com> Content-Type: text/plain; charset=UTF-8 On 18 April 2016 at 18:39, Kim Malmo<berencamlost(a)msn.com> wrote: > From: Kim Malmo<kimmalmo(a)protonmail.ch> > > --- > dlls/wined3d/directx.c | 2 ++ > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 3 insertions(+) > You're missing the Signed-off-by line. Passing -s to format-patch will add it. > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 }, Is that the correct description string for the card? I'm only finding references to the 9700M GT and 9700M GTS.

2 2

Re: [PATCH 04/10] wined3d: Add support for rendering to 2D array textures.
by Henri Verbeet 19 Apr '16

19 Apr '16

On 19 April 2016 at 00:01, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Layered rendering is not supported yet. > > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/wined3d/context.c | 84 +++++++++++++++++++++++++----------------- > dlls/wined3d/directx.c | 6 +++ > dlls/wined3d/wined3d_private.h | 5 ++- > 3 files changed, 60 insertions(+), 35 deletions(-) > This one conflicts with 121430.

1 0

Re: [PATCH 2/2] include/wincon.h: add some undocumented prototypes
by Hugh McMaster 19 Apr '16

19 Apr '16

On Tuesday, 19 April 2016 11:25 AM UTC+10, Austin English wrote: > +/* Undocumented */ > +WINBASEAPI DWORD WINAPI GetNumberOfConsoleFonts(void); [...] > +/* Undocumented */ > +WINBASEAPI BOOL WINAPI SetConsoleFont(HANDLE, DWORD); [...] > +/* Undocumented */ > +WINBASEAPI BOOL WINAPI SetConsoleIcon(HICON); > +WINBASEAPI BOOL WINAPI SetConsoleMode(HANDLE,DWORD); As with your previous patch, these functions can only be called via GetModuleHandle and GetProcAddress on Windows, so they shouldn't be included in wincon.h. -- Hugh McMaster

1 1

RE: [PATCH 1/2] kernel32: add GetConsoleFontInfo stub
by Hugh McMaster 19 Apr '16

19 Apr '16

On Tuesday, 19 April 2016 11:25 AM, Austin English wrote: >+BOOL WINAPI GetConsoleFontInfo(HANDLE hOutput, BOOL bMaximize, DWORD numFonts, CONSOLE_FONT *info) >+{ >+ FIXME("(%p %d %u %p): stub!\n", hOutput, bMaximize, numFonts, info); >+ SetLastError(ERROR_CALL_NOT_IMPLEMENTED); >+ return FALSE; >+} Please add this function after the GetConsoleFontSize function. We should keep the "Ex" functions in their own group at the bottom of console.c. Also, avoid Hungarian notation for bMaximize. That's okay for the HANLDE, although it should be hConsole. to match the surrounding code. >+/* Undocumented */ >+WINBASEAPI BOOL WINAPI GetConsoleFontInfo(HANDLE, BOOL, DWORD, CONSOLE_FONT *); I can't check right now, but I'm fairly certain GetConsoleFontInfo should not be included in wincon.h. IIRC, this function cannot be called directly from a console program, only via GetModuleHandle and GetProcAddress. -- Hugh McMaster

1 0

Re: [PATCH 4/4] inetcomm/tests: Add IMimeMessage SetOption tests
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22311 Your paranoid android. === wvistau64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w864 (64 bit mimeole) === Found no trace of the test summary line or of a crash === w1064 (64 bit mimeole) === Found no trace of the test summary line or of a crash

1 0

Re: ddraw/tests: A spelling fix for a d3d ok() message.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22306 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: advapi32/tests: Some spelling fixes for the security ok() messages.
by Marvin 19 Apr '16

19 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22304 Your paranoid android. === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [Tools] testbot/TestAgent: Better indicate the file transfer position/range in case of errors.
by Francois Gouget 19 Apr '16

19 Apr '16

Should I resend or change this patch? On Mon, 11 Apr 2016, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > testbot/lib/WineTestBot/TestAgent.pm | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm > index 74e7395..82ca97f 100644 > --- a/testbot/lib/WineTestBot/TestAgent.pm > +++ b/testbot/lib/WineTestBot/TestAgent.pm > @@ -486,7 +486,7 @@ sub _RecvFile($$$$) > if (!defined $r) > { > alarm(0); > - $self->_SetError($FATAL, "got a network error while receiving '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($FATAL, "got a network error while receiving '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > return; # out of eval > } > if ($r == 0) > @@ -501,7 +501,7 @@ sub _RecvFile($$$$) > if (!defined $w or $w != $r) > { > alarm(0); > - $self->_SetError($ERROR, "an error occurred while writing to '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($ERROR, "an error occurred while writing to '$Filename' ($self->{rpc}:$Name:$Pos+$r/$Size): $!"); > $self->_SkipRawData($Name, $Remaining); > return; # out of eval > } > @@ -806,7 +806,7 @@ sub _SendFile($$$$) > if (!defined $r) > { > alarm(0); > - $self->_SetError($FATAL, "an error occurred while reading from '$Filename' ($self->{rpc}:$Name:$Pos/$Size): $!"); > + $self->_SetError($FATAL, "an error occurred while reading from '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > return; # out of eval > } > if ($r == 0) > @@ -821,7 +821,8 @@ sub _SendFile($$$$) > if (!defined $w or $w != $r) > { > alarm(0); > - $self->_SetError($FATAL, "got a network error while sending '$Filename' ($self->{rpc}:$Name:$Pos+$s/$Size): $!"); > + # Overwrite _Write()'s error message with a more appropriate one > + $self->_SetError($FATAL, "got a network error while sending '$Filename' ($self->{rpc}:$Name:$Pos+$r/$Size): $!"); > return; # out of eval > } > } > -- > 2.8.0.rc3 > > > -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

wined3d: Add Nvidia GT 9700M
by Kim Malmo 18 Apr '16

18 Apr '16

Thanks Caron, that's exactly the kind of feedback I wanted. I now feel really stupid. The spacing and line breaks comes from copy/pasting the patch into an email, as I couldn't get git-send-email to work. Apparently, it has it's own package in Ubuntu. That's causing the linebreaks. The spacing I cannot explain, but ofcourse both come out clean when using git-send-email. Thanks for that. That's still no excuse for sending a patch with bad formatting though. Now I just have to figure out how to properly use git-send-email so I can add the comments I want. I'm new to git. Do I need to sign off my own patches? Just curious how it works, I had imagined one of the proper developers had to sign it off. -- Actually, you sent it to the right place. There are some things you should have a look at that my eyes are drawn to. First, when reviewed here, the patch has odd line breaks and spacing: https://source.winehq.org/patches/data/121371 It's also missing your signed-off-by line. You can read about how to add that here: https://wiki.winehq.org/Submitting_Patches Your patch should come through clean and match the surrounding style. I had a patch accepted adding the same number of lines in the same general places, pay close attention to how the two differ in appearance: https://source.winehq.org/patches/data/121336 I'm looking at those patches simply by going to this page to make sure everything "looks" okay: https://source.winehq.org/patches/ Note the red "X" indicating the missing sign-off next to your patch. You would do yourself many favors by using git send-email to send patches or in the very least, take a moment to create a patch and check it over once, twice, three times, before sending. I commit to my local tree and then I do: git format-patch origin and compare what's going on and then I make sure Wine still builds after my changes. I catch a lot of mistakes that way (like missing a comma...). Thank you for sending a patch and following up on it. Others might have more feedback for you. -Caron

2 1

Re: [PATCH] Added Nvidia GT 9700M
by Henri Verbeet 18 Apr '16

18 Apr '16

On 18 April 2016 at 18:39, Kim Malmo <berencamlost(a)msn.com> wrote: > From: Kim Malmo <kimmalmo(a)protonmail.ch> > > --- > dlls/wined3d/directx.c | 2 ++ > dlls/wined3d/wined3d_private.h | 1 + > 2 files changed, 3 insertions(+) > You're missing the Signed-off-by line. Passing -s to format-patch will add it. > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 }, Is that the correct description string for the card? I'm only finding references to the 9700M GT and 9700M GTS.

1 0

Re: [PATCH 1/2] d3drm: Implement IDirect3DRM*::CreateObject.
by Henri Verbeet 18 Apr '16

18 Apr '16

On 17 April 2016 at 22:57, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > @@ -1054,10 +1058,50 @@ static ULONG WINAPI d3drm3_Release(IDirect3DRM3 *iface) > static HRESULT WINAPI d3drm3_CreateObject(IDirect3DRM3 *iface, > REFCLSID clsid, IUnknown *outer, REFIID iid, void **out) > { > - FIXME("iface %p, clsid %s, outer %p, iid %s, out %p stub!\n", > + void *object_struct; ... > + if (IsEqualGUID(clsid, &CLSID_CDirect3DRMTexture)) > + { > + if (FAILED(hr = d3drm_texture_create((struct d3drm_texture **)&object_struct))) > + { > + *out = NULL; > + return hr; > + } > + object = (IUnknown *)&((struct d3drm_texture *)object_struct)->IDirect3DRMTexture3_iface; > + } Why do you need "object_struct"?

2 8

Re: ddraw [v3]: Move ComputeSphereVisibility tests to ddraw7
by Henri Verbeet 18 Apr '16

18 Apr '16

On 18 April 2016 at 09:02, David Adam <david.adam.cnrs(a)gmail.com> wrote: > Thos one with my valid email address. > Please try to match the structure and style of the other tests in ddraw7.c, and please use git send-email for submitting patches.

1 0

Re: [PATCH] d3dx9: Don't complain when overwriting effect object id 0.
by Matteo Bruni 18 Apr '16

18 Apr '16

2016-04-18 15:26 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Matteo, > > I must be missing something, but don't you forget to free the > object->data when it is reallocated at least for object id 0 when it is > not FIXME anymore? I suppose you don't but I looked through several > times and do not see how it can be freed when it was allocated previously. > > Regards, > Paul. No, you're right, I forgot the free altogether. Let's drop this patch, unless it's too late. I'll send a fix either way.

1 2

wined3d: Add Nvidia GT 9700M
by Kim Malmo 18 Apr '16

18 Apr '16

I posted this one to wine-patches, I realize I may have sent it to the wrong mailing list. I would probably want some feedback on this one, as it's basically a dirty hack I put together. Critisism welcome. Posted here: https://www.winehq.org/pipermail/wine-patches/2016-April/149298.html wined3d: Add Nvidia GT 9700M Bug: https://bugs.winehq.org/show_bug.cgi?id=36031 --- dlls/wined3d/directx.c | 2 ++ dlls/wined3d/wined3d_private.h | 1 + 2 files changed, 3 insertions(+) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 8358930..6b115d3 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1230,6 +1230,7 @@ static const struct gpu_description gpu_description_table[] = {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9400GT, "NVIDIA GeForce 9400 GT", DRIVER_NVIDIA_GEFORCE8, 256 }, {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9500GT, "NVIDIA GeForce 9500 GT", DRIVER_NVIDIA_GEFORCE8, 256 }, {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9600GT, "NVIDIA GeForce 9600 GT", DRIVER_NVIDIA_GEFORCE8, 384 }, + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9700M, "NVIDIA GeForce 9700M", DRIVER_NVIDIA_GEFORCE8, 512 }, {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_9800GT, "NVIDIA GeForce 9800 GT", DRIVER_NVIDIA_GEFORCE8, 512 }, {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_210, "NVIDIA GeForce 210", DRIVER_NVIDIA_GEFORCE8, 512 }, {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GT220, "NVIDIA GeForce GT 220", DRIVER_NVIDIA_GEFORCE8, 512 }, @@ -1819,6 +1820,7 @@ cards_nvidia_binary[] = {"GTS 150", CARD_NVIDIA_GEFORCE_9800GT}, /* Geforce 9 - highend / Geforce 200 - midend */ {"9800", CARD_NVIDIA_GEFORCE_9800GT}, /* Geforce 9 - highend / Geforce 200 - midend */ {"GT 140", CARD_NVIDIA_GEFORCE_9600GT}, /* Geforce 9 - midend */ + {"9700M", CARD_NVIDIA_GEFORCE_9700M}, /* Geforce 9 - midend */ {"9600", CARD_NVIDIA_GEFORCE_9600GT}, /* Geforce 9 - midend */ {"GT 130", CARD_NVIDIA_GEFORCE_9500GT}, /* Geforce 9 - midend low / Geforce 200 - low */ {"GT 120", CARD_NVIDIA_GEFORCE_9500GT}, /* Geforce 9 - midend low / Geforce 200 - low */ diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 24515da..95dd88b 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1739,6 +1739,7 @@ enum wined3d_pci_device CARD_NVIDIA_GEFORCE_9400GT = 0x042c, CARD_NVIDIA_GEFORCE_9500GT = 0x0640, CARD_NVIDIA_GEFORCE_9600GT = 0x0622, + CARD_NVIDIA_GEFORCE_9700M = 0x064a, CARD_NVIDIA_GEFORCE_9800GT = 0x0614, CARD_NVIDIA_GEFORCE_210 = 0x0a23, CARD_NVIDIA_GEFORCE_GT220 = 0x0a20, -- 1.9.1

2 1

Re: riched20: Use SetRect instead of open coding it.
by Huw Davies 18 Apr '16

18 Apr '16

On 18 Apr 2016, at 09:11, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > --- a/dlls/riched20/paint.c > +++ b/dlls/riched20/paint.c > @@ -617,10 +617,8 @@ static void ME_DrawParaDecoration(ME_Context* c, ME_Paragraph* para, int y, RECT > MoveToEx(c->hDC, c->pt.x, y + bounds->top, NULL); > LineTo(c->hDC, c->pt.x, y + para->nHeight - bounds->bottom); > if (border_details[idx].dble) { > - rc.left = c->pt.x + 1; > - rc.right = rc.left + border_width; > - rc.top = y + bounds->top; > - rc.bottom = y + para->nHeight - bounds->bottom; > + SetRect(&rc, c->pt.x + 1, y + bounds->top, rc.left + border_width, > + y + para->nHeight - bounds->bottom); This is using rc.left uninitialised. Huw.

2 2

Re: user32/tests: Use SetRect instead of open coding it.
by Marvin 18 Apr '16

18 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22284 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === w864 (32 bit sysparams) === sysparams.c:2485: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2496: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

2 1

Re: wbemprox/tests: Add initial tests for ASSOCIATORS query.
by Hans Leidekker 18 Apr '16

18 Apr '16

On Sun, 2016-04-17 at 21:03 +0200, Sebastian Lackner wrote: > +static void test_associators( IWbemServices *services ) > +{ > + static const WCHAR query1[] = > + {'A','S','S','O','C','I','A','T','O','R','S',' ','O','F',' ','{','W','i','n','3','2','_', > + 'v','L','o','g','i','c','a','l','D','i','s','k','.', 'D','e','v','i','c','e','I','D','=','"','C',':','"','}',0}; Should that be 'Win32_LogicalDisk'?

2 1

Re: ddraw [v3]: Move ComputeSphereVisibility tests to ddraw7
by Marvin 18 Apr '16

18 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22283 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ddraw [V2]: Move ComputeSphereVisibilty to ddraw7
by Marvin 18 Apr '16

18 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22282 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: ddraw: Move ComputeSphereVisibilty to ddraw7
by Marvin 18 Apr '16

18 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22281 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: d3dxof & d3dx9_36: Unknown spelling fixes.
by Matteo Bruni 17 Apr '16

17 Apr '16

2016-04-15 14:29 GMT+02:00 Francois Gouget <fgouget(a)free.fr>: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > dlls/d3dx9_36/tests/shader.c | 2 +- > dlls/d3dxof/tests/d3dxof.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) The changes look fine but could you please split the patch in two?

1 0

Re: [PATCH 6/6] d3dx9: Add test for D3DXSHMultiply3 arguments aliasing.
by Matteo Bruni 17 Apr '16

17 Apr '16

2016-04-14 14:10 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: A few nitpicks: > + const FLOAT expected_aliased[20] = > + { 454.092499f,2.126404f, 5.570401f, 15.330379f, 22.796087f, 43.604126f, > + 4.273841f, 175.772034f, 237.672729f, 1.09f, 1.1f, 1.11f, 1.12f, 1.13f, > + 1.14f, 1.15f, 1.16f, 1.17f, 1.18f, 1.19f }; You can use just 'float' and the indentation style we use in "modern" code. You can fixup the previous array declaration too if you want but it's also fine if you don't. > + for (i = 0; i < 20; i++) > + c[i] = a[i]; > + D3DXSHMultiply3(c, c, b); > + for (i = 0; i < 20; i++) > + ok(relative_error(c[i], expected_aliased[i]) < admitted_error, "Expected[%d] = %f, received = %f\n", i, expected[i], c[i]); This line is too long.

1 0

Re: [PATCH 3/6] d3dx9: D3DXQuaternionSquadSetup should support arguments aliasing.
by Matteo Bruni 17 Apr '16

17 Apr '16

2016-04-14 14:10 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: Neither of those are your faults, but since you're at it... > - if ( D3DXQuaternionDot(pq0, pq1) < 0.0f ) > + if (D3DXQuaternionDot(pq0, pq1) < 0.0f) > temp2 = add_diff(&zero, pq0, -1.0f); > else > temp2 = *pq0; also remove the double space. > @@ -1634,7 +1635,9 @@ void WINAPI D3DXQuaternionSquadSetup(D3DXQUATERNION *paout, D3DXQUATERNION *pbou > temp1.z *= -0.25f; > temp1.w *= -0.25f; > D3DXQuaternionExp(&temp1, &temp1); > - D3DXQuaternionMultiply(pbout, pcout, &temp1); > + D3DXQuaternionMultiply(pbout, &cout, &temp1); > + *paout = aout; > + *pcout = cout; > > return; > } Please also remove the unnecessary return.

1 0

Re: [v12 4/4] d3dx9: Implement setting named shader constants in effect.
by Matteo Bruni 17 Apr '16

17 Apr '16

2016-04-14 12:30 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: A bunch of nitpicks: > + for (i = 0; i < parameters_count; i++) ++i > + TRACE("sampler %s, register index %u, state count %u.\n", params[i]->name, > + cdesc[i].RegisterIndex, sampler->state_count); You probably want to use debugstr_a(). > +static HRESULT set_shader_constants_device(struct IDirect3DDevice9 *device, struct d3dx_regstore *rs, > + D3DXPARAMETER_TYPE type, enum pres_reg_tables table) > +{ > + unsigned int start, n; Better to call it "count" for consistency IMO. > + if (!n) > + continue; That works but a break seems clearer.

1 0

Re: d3d9/tests: Spelling fixes for a couple of ok() calls.
by Marvin 16 Apr '16

16 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22235 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [2/2] kernel32/tests: Port stack commit tests to x86_64.
by Alexandre Julliard 15 Apr '16

15 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > START_TEST(virtual) > { > +#ifdef __x86_64__ > + static const char code_current_teb[] = { > + 0x65, 0x48, 0x8b, 0x04, 0x25, 0x30, 0x00, 0x00, 0x00, 0xc3 }; > +#endif It would be cleaner to use the existing inline function from winnt.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] wined3d: Implement texture DC creation on top of D3DKMTCreateDCFromMemory().
by Marvin 14 Apr '16

14 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22198 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 2/6] wined3d: Implement texture DC creation on top of D3DKMTCreateDCFromMemory().
by Marvin 14 Apr '16

14 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22197 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: compobj.dll16: Fix implementation of StringFromGUID2.
by Nikolay Sivov 14 Apr '16

14 Apr '16

On 14.04.2016 19:44, Sebastian Lackner wrote: > -INT WINAPI StringFromGUID216(REFGUID id, LPOLESTR str, INT cmax) > +INT WINAPI StringFromGUID216(REFGUID id, LPOLESTR16 str, INT cmax) It also should use INT16, with spec file fixed accordingly.

1 0

Fullscreen upscaling
by David Guillen Fandos 14 Apr '16

14 Apr '16

Hey there! I was looking into doing some automatic upscale for HiDPI screens (mine is 3200*1800). It would be some knob that allows the user to choose a x2 scaling for fullscreen apps and similar stuff. After reading winex11.drv I saw that it wouldn't be that hard to report 1/2 of the actual monitor resolution and then just upscale whatever gets rendered to the gdi_display (so we would have an unscaled surface and then blit that with a 2x scaling to the gdi_display). I guess that some other modifications would be needed though. Any comments on this? I think it could be useful for some people, nowadays that screens just got lots of pixels. Thanks! David G.F.

3 3

Re: [v2 PATCH] dwrite/tests: A test for glyphBox* metrics
by Marvin 14 Apr '16

14 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22191 Your paranoid android. === w864 (32 bit font) === The test timed out

2 1

Re: [v2 PATCH 2/2] d3d10core: Support NULL RenderTargetView pointer in ClearRenderTargetView
by Marvin 14 Apr '16

14 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22171 Your paranoid android. === w7u (32 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w7pro64 (32 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w8 (32 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w864 (32 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w1064 (32 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w7pro64 (64 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w864 (64 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w1064 (64 bit device) === device.c:6244: Test failed: Got unexpected value 2.35098856e-038 at (0, 0).

1 0

Re: [v2 PATCH 1/2] d3d10core: Support NULL DepthStecilView pointer in ClearDepthStencilView
by Marvin 14 Apr '16

14 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22170 Your paranoid android. === w7u (32 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w7pro64 (32 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w8 (32 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w864 (32 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w1064 (32 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w7pro64 (64 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w864 (64 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0). === w1064 (64 bit device) === device.c:6235: Test failed: Got unexpected value 2.35098856e-038 at (0, 0).

1 0

Re: [PATCH] dwrite/tests: A test for glyphBox* metrics
by Sebastian Lackner 14 Apr '16

14 Apr '16

On 14.04.2016 06:13, Nikolay Sivov wrote: > + ok(m1->glyphBoxBottom == expected->glyphBoxBottom, "font %s: glyphBoxLeft %d, expected %d\n", wine_dbgstr_w(nameW), > + m1->glyphBoxBottom, expected->glyphBoxBottom); There is a copy&paste in the ok() message error here.

1 0

Re: [v11 1/4] d3dx9: Implement fxlc constants (expressions) in effect.
by Matteo Bruni 13 Apr '16

13 Apr '16

2016-04-12 11:34 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -369,12 +410,17 @@ static HRESULT get_constants_desc(unsigned int *byte_code, struct d3dx_const_tab > goto err_out; > } > count = 1; > - hr = ID3DXConstantTable_GetConstantDesc(ctab, hc, &cdesc[i], &count); > - if (FAILED(hr)) > + if (FAILED(hr = ID3DXConstantTable_GetConstantDesc(ctab, hc, &cdesc[i], &count))) > { > FIXME("Could not get constant desc, hr %#x.\n", hr); > goto err_out; > } > + if (count != 1) > + { > + FIXME("Unexpected constant descriptors count %u.\n", count); > + hr = D3DERR_INVALIDCALL; > + goto err_out; > + } Notice that, since you set count to 1 before calling GetConstantDesc(), the only possible results are 0 or 1 and the 0 case should be already handled by the "if (FAILED())" branch. You might use a temporary array of 3 elements and pass 3 as count, then only copy the first element to the destination so the rest of the code is unchanged while still giving a chance for the FIXME to trigger. Not sure it's worth it though, maybe just adding support for multiple descriptors (even only in struct d3dx_const_tab and the immediately related code) might be a better plan. > +static HRESULT set_constants_param(struct d3dx_regstore *rs, struct d3dx_const_tab *const_tab, > + D3DXHANDLE hc, struct d3dx_parameter *param) > +{ > + ID3DXConstantTable *ctab = const_tab->ctab; > + D3DXCONSTANT_DESC desc; > + unsigned int const_count, param_count, i, j, n, table, start_offset; > + unsigned int minor, major, major_stride, param_offset; > + BOOL transpose, get_element; > + unsigned int desc_count; > + > + desc_count = 1; > + ID3DXConstantTable_GetConstantDesc(ctab, hc, &desc, &desc_count); > + if (desc_count != 1) > + { > + FIXME("Unexpected constant descriptors count %u.\n", desc_count); > + return D3DERR_INVALIDCALL; > + } Same here, in this case the descriptors are only used locally so both options above should be easier to do. > + if (const_count != param_count) > + { > + FIXME("Number of elements or struct members differs between parameter and constant.\n"); > + return D3DERR_INVALIDCALL; > + } You could print the two counts here. Not a big deal though. Looks good otherwise.

2 2

Re: [v10 1/4] d3dx9: Implement fxlc constants (expressions) in effect.
by Matteo Bruni 13 Apr '16

13 Apr '16

2016-04-07 17:41 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > switch (state->type) > { > case ST_CONSTANT: > + *param_value = param->data; > + *out_param = param; > + return D3D_OK; > case ST_PARAMETER: > + param = param->referenced_param; > *param_value = param->data; > *out_param = param; > return D3D_OK; It doesn't matter (this is perfectly fine) but you could have kept the fallthrough by switching these two cases around. > +static HRESULT set_constants_param(struct d3dx_regstore *rs, struct d3dx_const_tab *const_tab, > + D3DXHANDLE hc, struct d3dx_parameter *param) > +{ > + ID3DXConstantTable *ctab = const_tab->ctab; > + D3DXCONSTANT_DESC desc; > + unsigned int const_count, param_count, i, j, n, table, start_offset; > + unsigned int minor, major, major_stride, param_offset; > + BOOL transpose, get_element; > + > + ID3DXConstantTable_GetConstantDesc(ctab, hc, &desc, &const_count); This isn't correct, although it currently works. const_count is supposed to be an inout parameter for GetConstantDesc() (you could potentially have multiple instances of the same constant in different register sets). The current implementation of GetConstantDesc() doesn't check the parameter and blindly returns only the first descriptor, also setting const_count to 1 (actually the following descriptors aren't even parsed currently by the constant table code IIRC) so this ends up working, although that's a bug and at some point it might get fixed which would in turn break this. Also it's a bit of an "overload" to use the same variable here and as the count of constant elements / members in the following lines, it's probably nicer to use two separate variables. BTW you're using GetConstantDesc() correctly in get_constants_desc(). > + table = const_tab->regset2table[desc.RegisterSet]; > + if (table >= PRES_REGTAB_COUNT) > + { > + FIXME("Unexpected register set %u.\n", desc.RegisterSet); > + return D3DERR_INVALIDCALL; > + } Since regset2table is defined by us ERR() is maybe more appropriate here. It might make sense to also check desc.RegisterSet before accessing the array. > + hc = ID3DXConstantTable_GetConstant(const_tab->ctab, NULL, i); > + if (!hc) > + { > + FIXME("Could not get constant.\n"); > + hr = D3DERR_INVALIDCALL; You could probably also print the value of 'i' in the FIXME. Up to you, but you could switch the then and else branches and drop the '!' in the if condition. > + if (oi->func_all_comps) > + { > + if (oi->input_count * ins->component_count > ARGS_ARRAY_SIZE) > + { > + FIXME("Too many arguments (%u) for one instruction.\n", oi->input_count * ins->component_count); > + return E_FAIL; > + } I think this check should be outside of the if (oi->func_all_comps) block. > + hr = set_constants(&peval->pres.regs, &peval->pres.inputs); > + if (FAILED(hr)) > + return hr; > + > + hr = execute_preshader(&peval->pres); > + if (FAILED(hr)) > + return hr; Not a big deal but since you're there... You could merge the function calls with the respective if, like you're doing in some other patches of the series.

2 6

Re: [v11 4/4] d3dx9: Implement setting named shader constants in effect.
by Matteo Bruni 13 Apr '16

13 Apr '16

2016-04-12 11:34 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > static HRESULT d3dx9_apply_state(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, > - struct d3dx_state *state, int parent_index) > + struct d3dx_state *state, unsigned int parent_index); > + > +HRESULT d3dx_set_shader_const_fxlc(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, > + struct d3dx_parameter *param, BOOL vs) Nitpick, the _fxlc suffix doesn't seem correct at this point I think. Just call it d3dx_effect_set_shader_constants() or something similar? The function can probably be static too. > +static HRESULT set_shader_constants_device(struct IDirect3DDevice9 *device, struct d3dx_regstore *rs, > + D3DXPARAMETER_TYPE type, enum pres_reg_tables table) > +{ > + unsigned int start, n; Maybe call it "count" instead of "n"? It's up to you though.

1 0

Re: [v11 2/4] d3dx9: Add basic opcodes to preshader.
by Matteo Bruni 13 Apr '16

13 Apr '16

2016-04-12 11:34 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -3834,11 +3831,16 @@ static void test_effect_preshader(IDirect3DDevice9 *device) > v = i < 8 ? (unsigned int *)&light.Diffuse : (unsigned int *)&light.Ambient; > ok(hr == D3D_OK, "Got result %#x.\n", hr); > for (j = 0; j < 4; ++j) > + { > + unsigned int mask; > + > + mask = ~0u << test_effect_preshader_op_results[i].tolerance_bit_count; > todo_wine_if(test_effect_preshader_op_results[i].todo[j]) > - ok(v[j] == test_effect_preshader_op_results[i].result[j], > + ok((v[j] & mask) == (test_effect_preshader_op_results[i].result[j] & mask), That doesn't seem right. You can just use compare_float() to do a correct float comparison.

1 0

Re: [PATCH v2 4/5] d3d9/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22150 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH v2 3/5] ddraw/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22149 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [5/9] webservices: Add support for reading enum values.
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22153 Your paranoid android. === build (build) === Make failed

1 0

Re: hidclass.sys: Fix spelling of a private struct's name.
by Aric Stewart 13 Apr '16

13 Apr '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> On 4/13/16 4:28 AM, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > dlls/hidclass.sys/hid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h > index 2820c9d..34c2a09 100644 > --- a/dlls/hidclass.sys/hid.h > +++ b/dlls/hidclass.sys/hid.h > @@ -39,7 +39,7 @@ typedef NTSTATUS (WINAPI *pAddDevice)(DRIVER_OBJECT *DriverObject, DEVICE_OBJECT > /* Ring buffer functions */ > struct ReportRingBuffer; > > -typedef struct _BASE_DEVICE_EXTENSTION { > +typedef struct _BASE_DEVICE_EXTENSION { > HID_DEVICE_EXTENSION deviceExtension; > > HID_COLLECTION_INFORMATION information; >

1 0

Re: [PATCH v2 2/5] wined3d: Be more strict with wined3d_texture_get_dc() calls from d3d9.
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22148 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH v2 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22147 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH v2 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22146 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 07/11] dxgi: Do not store IDXGIOutputs in IDXGIAdapter.
by Henri Verbeet 13 Apr '16

13 Apr '16

On 12 April 2016 at 12:29, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +HRESULT dxgi_output_create(struct dxgi_adapter *adapter, struct dxgi_output **output) > +{ > + if (!(*output = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(**output)))) > + { > + *output = NULL; > + return E_OUTOFMEMORY; > + } Explicitly setting output variables to NULL on failure can be ok (although I don't think it's needed for dxgi_output_create()), but note that *output is already NULL when HeapAlloc() fails.

1 0

Re: ole32/tests: Fix spelling of a few variable names.
by Marvin 13 Apr '16

13 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22145 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w1064 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w1064 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A

1 0

Re: ucrtbase: Add __std_exception_destroy/copy
by Piotr Caban 13 Apr '16

13 Apr '16

Hi Daniel, please add following tests (and fix implementation): + src.what = NULL; + src.dofree = 0; + p___std_exception_copy(&src, &dst); + ok(!dst.what, "dst.what != NULL\n"); + ok(!dst.dofree, "dst.dofree != FALSE\n"); + + src.what = NULL; + src.dofree = 1; + p___std_exception_copy(&src, &dst); + ok(!dst.what, "dst.what != NULL\n"); + ok(!dst.dofree, "dst.dofree != FALSE\n"); Thanks, Piotr

1 0

Re: [PATCH 5/5] gdi32: Implement DC creation from pre-existing memory.
by Huw Davies 13 Apr '16

13 Apr '16

On Tue, Apr 12, 2016 at 06:09:32PM +0200, Henri Verbeet wrote: > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index e19c552..1b818b3 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -5642,14 +5648,262 @@ static void test_SetDIBitsToDevice_RLE8(void) ... > + ok(size == sizeof(dib), "%s: Got unexpected size %d, expected %u.\n", > + test_data[i].name, size, sizeof(dib)); You have a couple of sizeof()s in ok()s. Other than that it looks good to me. Huw.

1 0

Re: [PATCH v2] ole32: Fix memory leak in CompositeMonikerImpl_Construct.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: F> Coverity #713613, "Variable This going out of scope leaks the storage it > points to." > > If we need to loop through This->tabMoniker and call IMoniker_Release on > each of its items, we should do the same in the other three similar > error paths in this function. Please let me know if this is what you > want. Yes, even if Coverity doesn't warn about the reference leaks, it should be fixed completely, otherwise once the warning is gone we'll forget about it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntoskrnl.exe: Fix SIB_INDEX() to use REX_X, not REX_R.
by Sebastian Lackner 12 Apr '16

12 Apr '16

On 12.04.2016 08:19, Ken Thomases wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > See <http://source.winehq.org/source/programs/winedbg/db_disasm64.c#0992> or > <http://wiki.osdev.org/X86-64_Instruction_Encoding#Encoding>, for confirmation. > > dlls/ntoskrnl.exe/instr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Good catch, thanks.

1 0

Re: [PATCH 4/5] d3d9/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22131 Your paranoid android. === w1064 (32 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2355: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2357: Test failed: Got unexpected hr 0, i=1. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 3/5] ddraw/tests: Add some tests for the properties of the DC returned by surface GetDC().
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22130 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22126 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/5] wined3d: Be more strict with wined3d_texture_get_dc() calls from d3d9.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22128 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 1/5] wined3d: Be more lenient with wined3d_texture_get_dc() calls from ddraw.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22127 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: shell32/tests: Use SetRect instead of open coding it.
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22120 Your paranoid android. === w1064 (32 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} === w1064 (64 bit ebrowser) === ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {2e228ba3-ea25-4378-97b6-d574faeba356}, riid: {2e228ba3-ea25-4378-97b6-d574faeba356} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d}, riid: {c13b3d3a-10d6-43f5-98db-b7ddd987b33d} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {42f85136-db7e-439c-85f1-e4075d135fc8} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} ebrowser.c:524: Test failed: unknown service, serviceID: {d56a2092-7dbf-4144-a110-c2963a709832}, riid: {d56a2092-7dbf-4144-a110-c2963a709832} === wxppro (32 bit shlview) === shlview.c:684: Test failed: hwnd 00020126 still valid shlview.c:699: Test failed: expected 18 > 18

2 1

Re: [PATCH] d3dx9: D3DXVec3Transform should support input and output parameter overlap.
by Henri Verbeet 12 Apr '16

12 Apr '16

On 12 April 2016 at 12:09, Paul Gofman <gofmanp(a)gmail.com> wrote: > Fixes #40456. > > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/math.c | 11 +++++++---- > dlls/d3dx9_36/tests/math.c | 8 ++++++-- > 2 files changed, 13 insertions(+), 6 deletions(-) > For what it's worth, the technical term is "aliasing". And yeah, I'd expect this to be an issue in more places, so if you have the time it would be good the check the entire DLL, particularly for things working on vectors, quaternions, matrices, etc.

2 2

Re: [PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateObject (v2).
by Henri Verbeet 12 Apr '16

12 Apr '16

On 11 April 2016 at 20:04, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + hr = IDirect3DRM_CreateObject(d3drm1, NULL, NULL, tests[i].iid, (void **)&unknown); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Test %u: expected hr == D3DRMERR_BADVALUE, got %#x.\n", i, hr); Note that mentioning the expected value is mostly redundant here. It's obvious as soon as you look at the test source, and test output isn't generally useful without that. > + hr = IDirect3DRM_CreateObject(d3drm1, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + todo_wine ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + if (SUCCEEDED(hr)) > + { I'll point out that if you had done a "continue" on failure instead, you wouldn't need to change the indentation when you remove the todo_wine.

2 1

Re: [PATCH 05/11] dxgi: Partially implement dxgi_swapchain_GetContainingOutput().
by Henri Verbeet 12 Apr '16

12 Apr '16

On 12 April 2016 at 12:29, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > This implementation works properly for adapters that have got 1 output. > --- I could probably live with this, considering winex11 and wined3d don't properly report multiple outputs anyway, but at the same time I think it shouldn't be hard to implement this properly.

1 0

Re: [PATCH 2/4] d3d10core: Support NULL DepthStecilView pointer in ClearDepthStencilView
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22096 Your paranoid android. === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 740CCE1D === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 7397CE1D === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000074AB253F === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 0000000073DB253F

2 1

Re: [PATCH 4/4] d3d10core: Support NULL RenderTargetView pointer in ClearRenderTargetView
by Marvin 12 Apr '16

12 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22098 Your paranoid android. === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 73F9CBBD === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 7384CBBD === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000074AB22BF === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 00000000739B22BF

1 0

Re: [PATCH 3/4] d3d11: Support NULL RenderTargetView pointer in ClearRenderTargetView
by Józef Kucia 12 Apr '16

12 Apr '16

On Tue, Apr 12, 2016 at 9:52 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > @@ -4897,6 +4898,9 @@ static void test_update_subresource(void) > ID3D11DeviceContext_ClearRenderTargetView(context, test_context.backbuffer_rtv, red); > check_texture_color(test_context.backbuffer, 0x7f0000ff, 1); > > + ID3D11DeviceContext_ClearRenderTargetView(context, NULL, green); > + check_texture_color(test_context.backbuffer, 0x7f0000ff, 1); > + > draw_quad(&test_context); > check_texture_color(test_context.backbuffer, 0x00000000, 0); The "test_clear_render_target_view" function would be much better place for this test.

1 0

Re: user32/tests: Add some tests for dialog owner disabled state. (v3)
by Jacek Caban 12 Apr '16

12 Apr '16

Hi Dmitry, On 04/06/16 13:15, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/user32/tests/win.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 96 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 957e8a1d..528669e 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -4258,6 +4258,78 @@ static INT_PTR WINAPI empty_dlg_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM > return 0; > } > > +static INT_PTR WINAPI empty_dlg_proc3(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if (msg == WM_INITDIALOG) > + EndDialog(hwnd, 0); > + > + return 0; > +} > + > +struct dialog_param > +{ > + HWND parent, grand_parent; > + DLGTEMPLATE *dlg_data; > +}; > + > +static INT_PTR WINAPI empty_dlg_proc2(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if (msg == WM_INITDIALOG) > + { > + DWORD style = GetWindowLongA(hwnd, GWL_STYLE); > + struct dialog_param *param = (struct dialog_param *)lparam; > + BOOL parent_is_child; > + HWND disabled_hwnd; > + > + parent_is_child = (GetWindowLongA(param->parent, GWL_STYLE) & (WS_POPUP | WS_CHILD)) == WS_CHILD; > + > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + if (parent_is_child) > + { > + ok(IsWindowEnabled(param->parent), "wrong state for %08x\n", style); > + disabled_hwnd = param->grand_parent; > + } > + else > + { > + ok(!IsWindowEnabled(param->parent), "wrong state for %08x\n", style); > + disabled_hwnd = param->parent; > + } > + > + if (param->grand_parent) > + { > + if (parent_is_child) > + ok(!IsWindowEnabled(param->grand_parent), "wrong state for %08x\n", style); > + else > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %08x\n", style); > + } > + > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, disabled_hwnd, empty_dlg_proc3, 0); > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(disabled_hwnd), "wrong state for %08x\n", style); If you ensured that disabled_hwnd is enabled here, then testing it later, after dialog is done, has very little value. Maybe you'd disable it by EnableWindow() call here? > + > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + ok(IsWindowEnabled(param->parent), "wrong state for %p\n", param->parent); > + if (param->grand_parent) > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %p (%08x)\n", param->grand_parent, style); > + > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, hwnd, empty_dlg_proc3, 0); > + ok(IsWindowEnabled(hwnd), "wrong state for %p\n", hwnd); > + ok(IsWindowEnabled(param->parent), "wrong state for %p\n", param->parent); > + if (param->grand_parent) > + todo_wine_if ((style & (WS_CHILD|WS_POPUP)) == WS_CHILD) > + ok(IsWindowEnabled(param->grand_parent), "wrong state for %p (%08x)\n", param->grand_parent, style); Why do you put those tests inside WM_INITDIALOG? Wouldn't separated tests be cleaner? > + param->dlg_data->style |= WS_CHILD; > + DialogBoxIndirectParamA(GetModuleHandleA(NULL), param->dlg_data, hwnd, empty_dlg_proc3, 0); > + todo_wine_if (!(style & (WS_CHILD|WS_POPUP))) > + ok(IsWindowEnabled(hwnd), "wrong state for %p (%08x)\n", hwnd, style); > + > + EndDialog(hwnd, 0); Testing that EndDialog enables window would be nice (given that it's disabled as I said above). > + } > + return 0; > +} > + > static void check_dialog_style(DWORD style_in, DWORD ex_style_in, DWORD style_out, DWORD ex_style_out) > { > struct > @@ -4269,11 +4341,19 @@ static void check_dialog_style(DWORD style_in, DWORD ex_style_in, DWORD style_ou > WCHAR caption[1]; > } dlg_data; > DWORD style, ex_style; > - HWND hwnd, parent = 0; > + HWND hwnd, grand_parent = 0, parent = 0; > + struct dialog_param param; > > if (style_in & WS_CHILD) > - parent = CreateWindowExA(0, "static", NULL, WS_OVERLAPPEDWINDOW, > + { > + grand_parent = CreateWindowExA(0, "static", NULL, WS_OVERLAPPEDWINDOW, > 0, 0, 0, 0, NULL, NULL, NULL, NULL); > + ok(grand_parent != 0, "grand_parent creation failed\n"); > + } > + > + parent = CreateWindowExA(0, "static", NULL, style_in, > + 0, 0, 0, 0, grand_parent, NULL, NULL, NULL); > + ok(parent != 0, "parent creation failed, style %#x\n", style_in); Always creating window here changes existing tests. It's not a big deal, I wouldn't expect it to change much, but still, the case that's currently tested will no longer be tested. Jacek

3 6

Re: [PATCH 2/3] ole32: Fix memory leak in CompositeMonikerImpl_Construct.
by Alexandre Julliard 12 Apr '16

12 Apr '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -1848,8 +1848,10 @@ CompositeMonikerImpl_Construct(IMoniker **ppMoniker, IMoniker *pmkFirst, IMonike > IMoniker_Release(This->tabMoniker[This->tabLastIndex-1]); > > This->tabMoniker[This->tabLastIndex-1]=tempMk; > - } else > + } else{ > + HeapFree(GetProcessHeap(), 0, This); > return res; > + } You'd need to free the contents too, at least This->tabMoniker and its references. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-1.8.2-rc3 Available
by Michael Stefaniuc 11 Apr '16

11 Apr '16

Hello Alexandre, I have just pushed commit 74dbed07afbeda2e707424f1def138ec857da2b8 Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Thu Apr 7 14:25:40 2016 +0200 Release 1.8.2. as wine-1.8.2-rc3. It needs the configure change and your rubber stamp to call it 1.8.2. The only additions on top of 1.8.2-rc2 are your make_announce patch and the release commit. thanks bye michael

1 2

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22089 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22087 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22082 Your paranoid android. === w1064 (64 bit chain) === The test timed out

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22080 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22074 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22072 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: [PATCH 7/7] d3d8/tests: Add a system memory miptree layout test.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22069 Your paranoid android. === w8 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w1064 (32 bit device) === device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 6/7] d3d9/tests: Add a system memory miptree layout test.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22068 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

EVE using Wine on Mac
by Snorri Sturluson 11 Apr '16

11 Apr '16

About a month ago CCP announced support for running EVE Online on Mac using Wine (https://forums.eveonline.com/default.aspx?g=posts&m=6380823#post6380823) I am the primary developer on this project, and wanted to express my gratitude to the Wine community for making this possible. This experiment is going well - there have been some issues with getting Wine to run on all the different OS X versions and different hardware configurations out there, but that has largely been resolved (I think) with proper configuration of the build machine producing the Wine build. My plan is to proactively hunt down and fix any issues our Mac players run into, whether the fix entails digging into Wine source or our own codebase. Ideally everything we do in EVE should just work under Wine, but sometimes a workaround in our code may be easier than hunting down why Wine behaves different from Windows, but being able to debug both sides makes finding workarounds easier. Any fixes I come up with I will contribute to Wine, of course - it remains to be seen if they end up being very EVE specific, as EVE will of course be my main focus. My plan is also to document my experience along the way at http://ccpsnorlax.blogspot.is/ - if you find this interesting, please leave comments there. I hope that my initiative with this project meets with your approval, and look forward to working with the Wine codebase and you, the Wine developers in the future. Snorri Sturluson, Software Architect, CCP Games @CCP_Snorlax - http://ccpsnorlax.blogspot.is/

2 1

Re: [PATCH 1/2] ieframe: Simplify IPersist_Load, make error handling more straightforward (Coverity)
by Jacek Caban 11 Apr '16

11 Apr '16

Hi Nikolay, On 04/08/16 21:56, Nikolay Sivov wrote: > + /* Now we're going to read in the iconfile and iconindex. > + If we don't find them, that's not a failure case -- it's possible > + that they just aren't in there. */ > + hr = IPropertySetStorage_Open(This->property_set_storage, &FMTID_Intshcut, > + STGM_READWRITE | STGM_SHARE_EXCLUSIVE, &pPropStg); It's an already existing bug, but we should handle Open failure here. Thanks, Jacek

2 2

Re: [PATCH 2/2] ieframe: Convert to integer without additional string buffer allocation
by Jacek Caban 11 Apr '16

11 Apr '16

On 04/08/16 21:56, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ieframe/intshcut.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/ieframe/intshcut.c b/dlls/ieframe/intshcut.c > index 385b059..79458ac 100644 > --- a/dlls/ieframe/intshcut.c > +++ b/dlls/ieframe/intshcut.c > @@ -511,12 +511,11 @@ static HRESULT WINAPI PersistFile_Load(IPersistFile *pFile, LPCOLESTR pszFileNam > > if (get_profile_string(str_header, str_iconindex, pszFileName, &iconindexstring) == S_OK) > { > + WCHAR *end; > int iconindex; > PROPSPEC ps; > PROPVARIANT pv; > - char *iconindexastring = co_strdupWtoA(iconindexstring); > - sscanf(iconindexastring, "%d", &iconindex); > - CoTaskMemFree(iconindexastring); > + iconindex = strtolW(iconindexstring, &end, 10); If you don't need end value, you could pass NULL instead. Thanks, Jacek

2 1

Re: [PATCH 3/5] user32: Don't enable owner in DIALOG_DoDialogBox.
by Dmitry Timoshkov 11 Apr '16

11 Apr '16

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/user32/controls.h > +++ b/dlls/user32/controls.h > @@ -241,7 +241,6 @@ typedef struct tagDIALOGINFO > } DIALOGINFO; > > #define DF_END 0x0001 > -#define DF_OWNERENABLED 0x0002 As I already mentioned during our conversation in wine-devel my (not yet submitted) tests show that completely removing DF_OWNERENABLED handling is wrong. And once again I'd like to see the tests submitted first with todo_wine statements in appropriate places, and the patches sent only after that with separate fixes for every failure found by the tests. Sending a bunch of tests as the final patch doesn't show what didn't actually work before, and what exactly has been fixed by the patch series. -- Dmitry.

2 8

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22037 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22051 Your paranoid android. === wvistau64 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22050 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22042 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22036 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

2 1

Re: Assorted comment, trace and ok() message spelling fixes.
by Marvin 11 Apr '16

11 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22052 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

2 1

Experimental 64 bit OS X packages ready for testing
by Michael Müller 10 Apr '16

10 Apr '16

Hi all, recently there were multiple requests to provide experimental OS X 64 bit packages. I decided to give it a try and updated our build system and cross compiling toolchain during the last days. Luckily the whole idea turned out to be less difficult than I thought, and I can now present you the first 64-bit Wine packages for testing. It would be great to have some testers to find out if I made a mistake during the packaging and to evaluate how good the OS X 64 bit support already works, despite the GS segment / TEB problem. You can find the test packages at https://repos.wine-staging.com/macosx/beta/. I didn't use the WineHQ url because those packages are really in a very early stage, so I would like to have some more testers first before we push it to the users. The pkg installer will now provide you with an option to enable 64 bit support. The files of the 32-bit and 64-bit build are merged during the installation depending on your choice. Please test both options to ensure that a pure 32-bit build also still works as expected. The wine devel package is a pure 1.9.7 build without any additional patches applied, while the staging package contains a small hack to work around at least some of the GS segment issues (it fixed 64 bit VLC and TS3 for me). If you stumble upon any differences between both packages (besides the staged bugs), feel free to tell them to me. This way I can find out how much the hack breaks ;-). Anyway, I am looking forward to your feedback. The checksums are: 272d0fc6ccc390c99b8457c8a433953555f517e0ebbdfe68d7070de377c9fcb4 winehq-devel-1.9.7.pkg eb381ff8aec9e3c82576f941b9918f36185c17f921f0c6c93d6d97033cc0b303 winehq-staging-1.9.7.pkg BTW: Are there any news regarding the developer certificate, so we can sign the packages? I have not heard anything since about four months ago when there was the idea to ask the SFC. Regards, Michael

4 6

Re: [PATCH 5/6] d3d9/tests: Add some more surface GetDC() tests to test_getdc().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22024 Your paranoid android. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 4/6] ddraw/tests: Add some more surface GetDC() tests to test_getdc().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22023 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === The test timed out === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w864 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 3/6] ddraw/tests: Rewrite GetDCFormatTest().
by Marvin 10 Apr '16

10 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22022 Your paranoid android. === w864 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] d3d11: Support NULL DepthStecilView pointer in ClearDepthStencilView
by Henri Verbeet 10 Apr '16

10 Apr '16

On 10 April 2016 at 12:15, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- > dlls/d3d11/device.c | 3 +++ > dlls/d3d11/tests/d3d11.c | 3 +++ > 2 files changed, 6 insertions(+) > Before you resend this with the proper sign-off, could you please check d3d10 and the other clears (uav, rtv) as well?

1 0

Re: [PATCH 2/2] d3drm/tests: Add tests for IDirect3DRMObject::Add/DeleteDestroyCallback (v2).
by Stefan Dösinger 09 Apr '16

09 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, A few questions / suggestions: *) What happens if you register the same callback with different context pointers? *) The test already does some testing of the call order. I think you could extend it a bit if you store arrays of expected callback functions and context pointers in the structure and compare them when the callbacks are invoked. *) Does DeleteDestroyCallback return an error when no matching callback is found? *) The last one is mostly curiosity / a bad feeling: Is there a difference between callbacks added with IDirect3DRMObject (and its derived interfaces) and IDirect3DRMObject2? I am asking because Object2 is a separate interface and might be implemented in a separate object and then aggregated. If Microsoft screwed up (they never do that, right? ;-) ) then it'll have its own list of added callbacks... Stefan Am 2016-04-03 um 20:42 schrieb Aaryaman Vasishta: > v2: Fixed commit message. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/tests/d3drm.c | 203 ++++++++++++++++++----------------------------- > 1 file changed, 79 insertions(+), 124 deletions(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 1abfed3..1f197b8 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1219,6 +1219,7 @@ static void test_Frame(void) > struct destroy_context > { > IDirect3DRMObject *obj; > + unsigned int test_idx; > int called; > }; > > @@ -1238,6 +1239,81 @@ static void CDECL destroy_callback1(IDirect3DRMObject *obj, void *arg) > ctxt->called++; > } > > +static void test_destroy_callback(unsigned int test_idx, REFCLSID clsid, REFIID iid) > +{ > + struct destroy_context context; > + IDirect3DRMObject *obj; > + IUnknown *unknown; > + IDirect3DRM *d3drm; > + HRESULT hr; > + > + hr = Direct3DRMCreate(&d3drm); > + ok(SUCCEEDED(hr), "Test %u: Cannot get IDirect3DRM interface (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + context.called = 0; > + context.test_idx = test_idx; > + context.obj = obj; > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, NULL, &context); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRMERR_BADVALUE (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* same callback added twice */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, NULL); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + /* add one more */ > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, NULL, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Test %u: expected D3DRM_BADVALUE (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + IDirect3DRMObject_Release(obj); > + ok(context.called == 3, "Test %u: got %d, expected 3.\n", test_idx, context.called); > + > + /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > + hr = IDirect3DRM_CreateObject(d3drm, clsid, NULL, iid, (void **)&unknown); > + ok(hr == D3DRM_OK, "Test %u: Cannot get IDirect3DRMObject interface (hr = %x).\n", test_idx, hr); > + hr = IUnknown_QueryInterface(unknown, &IID_IDirect3DRMObject, (void**)&obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IUnknown_Release(unknown); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback1, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_AddDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + hr = IDirect3DRMObject_DeleteDestroyCallback(obj, destroy_callback, &context); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + > + context.called = 0; > + hr = IDirect3DRMObject_QueryInterface(obj, &IID_IDirect3DRMObject, (void**)&context.obj); > + ok(hr == D3DRM_OK, "Test %u: expected D3DRM_OK (hr = %x).\n", test_idx, hr); > + IDirect3DRMObject_Release(context.obj); > + IUnknown_Release(unknown); > + ok(context.called == 2, "Test %u: got %d, expected 2.\n", test_idx, context.called); > +} > + > static void test_object(void) > { > static const struct > @@ -1292,6 +1368,9 @@ static void test_object(void) > ref2 = get_refcount((IUnknown *)d3drm1); > ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > > + /* test Add/Destroy callbacks */ > + test_destroy_callback(i, tests[i].clsid, tests[i].iid); > + > hr = IDirect3DRM2_CreateObject(d3drm2, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > ref2 = get_refcount((IUnknown *)d3drm1); > @@ -1325,7 +1404,6 @@ static void test_object(void) > > static void test_Viewport(void) > { > - struct destroy_context context; > IDirectDrawClipper *pClipper; > HRESULT hr; > IDirect3DRM *d3drm; > @@ -1411,129 +1489,6 @@ static void test_Viewport(void) > ok(data == 1, "got %x\n", data); > IDirect3DRMViewport2_Release(viewport2); > > - /* destroy callback */ > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_AddDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_DeleteDestroyCallback(viewport, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport_Release(viewport); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > - /* destroy from Viewport2 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, NULL, &context); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRMERR_BADVALUE (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* same callback added twice */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, NULL); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - /* add one more */ > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, NULL, NULL); > - ok(hr == D3DRMERR_BADVALUE, "expected D3DRM_BADVALUE (hr = %x)\n", hr); > - > - context.called = 0; > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 3, "got %d, expected 3\n", context.called); > - > - /* test this pattern - add cb1, add cb2, add cb1, delete cb1 */ > - hr = IDirect3DRM_CreateViewport(d3drm, device, frame, rc.left, rc.top, rc.right, rc.bottom, &viewport); > - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMViewport interface (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport_QueryInterface(viewport, &IID_IDirect3DRMViewport2, (void**)&viewport2); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMViewport_Release(viewport); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback1, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_AddDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - hr = IDirect3DRMViewport2_DeleteDestroyCallback(viewport2, destroy_callback, &context); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - > - context.called = 0; > - hr = IDirect3DRMViewport2_QueryInterface(viewport2, &IID_IDirect3DRMObject, (void**)&context.obj); > - ok(hr == D3DRM_OK, "expected D3DRM_OK (hr = %x)\n", hr); > - IDirect3DRMObject_Release(context.obj); > - IDirect3DRMViewport2_Release(viewport2); > - ok(context.called == 2, "got %d, expected 2\n", context.called); > - > IDirect3DRMFrame_Release(frame); > IDirect3DRMDevice_Release(device); > IDirectDrawClipper_Release(pClipper); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXAXjPAAoJEN0/YqbEcdMwaCAP/R0jPTn4638NJY+4kpdtREkT pmpe3+RAx7XQXqJd7baFP1Ge5A8+UyH0GC5jraqneelZ4tjIePY9weFtTI0dPlbO W5Ptty2lIqI5e79S9BC9RYn6HOVVcLqWZTbArBwfRLWCDmHFDKIvLzzg1CmgVoZQ rL8pPiqzE0qanj7UnAZXt8/N5Dz8Uy3aY2tXimnn/ao/ET4Tpi2rp6CRuFGXo71I n7ydIj+spggC6GSk1HmOiAsHLOoKwmmxd83XOrQE+awlYJVxe/jrKZu6Du/29eYa /J+xfD9iHvm2oXAvQKNy8Tca3KaynCTB0aLPzZzZ1E/UXZsI3CPYWeEzXNxkyvQv yrSVRWyUjhAegPB3DUB4JWZq8sDiEjZw6y8hRwibN3NCGTZYtjsK2AuFAK5zUmlH H4k6BFtYRyVNvOUARA5UHO+bJ9wzr0nak14DZbiWoDYISLFKm77nieWR4EU03TNh cZWOpQde/CngNRXIr1mth/WAabPm8WN1IXRcayDAh5GfTC3bVLiRvrjT/vlpm8AH G+9qVEUTmH7HRpSXJpQ4vjAnZJkpJa/ixJazz9cxcNYucPD1LMg/ZbvTGLjKRFhF 1yR9UWOFKBAZyKolehBwRuDFFzw0cXpsUJW9gW/CFyoxtoL6qV+BmmZLN2Gy6Yoe XQJAPbjrbZ4oxHyyGsGp =BxYw -----END PGP SIGNATURE-----

2 2

Re: How to change Wine DLL search path for "built-in" DLLs?
by Vladimir Panteleev 09 Apr '16

09 Apr '16

Thanks Theodore. As I have mentioned, I have already tried DLL overrides, which did not provide the desired effect. Also, as I have mentioned, I'm looking for a programmatic solution, without involving user intervention. On Fri, Apr 8, 2016 at 11:21 PM, Vladimir Panteleev <vladimir(a)thecybershadow.net> wrote: > Thanks Theodore. As I have mentioned, I have already tried DLL > overrides, which did not provide the desired effect. Also, as I have > mentioned, I'm looking for a programmatic solution, without involving > user intervention. > > On Fri, Apr 8, 2016 at 11:19 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> Use DLL overrides. Open winecfg, go to the Libraries tab, type msvcr120, click add, click edit, click native, click ok. >> >> ~Theodore >> >>> On Apr 8, 2016, at 2:52 PM, Vladimir Panteleev <vladimir(a)thecybershadow.net> wrote: >>> >>> (reposting from wine-users, which seems to be dead) >>> >>> I'm trying to get the VS2012 C++ compiler (cl.exe) running under Wine >>> - stand-alone, as a component for a different larger project. The >>> project works fine on Windows without affecting any global system >>> settings or files (i.e. it unpacks DLLs etc. to private subdirs >>> instead of installing them system-wide). I'd like it to "just work" >>> under Wine as well, without user intervention or persistent >>> modifications to bottle settings or system files. >>> >>> Wine has a msvcr120.dll, however it is incomplete, at least as far as >>> cl.exe is concerned: >>> >>> wine: Call from 0x7b44ee37 to unimplemented function >>> msvcr120.dll.??0reader_writer_lock@Concurrency@@QEAA@XZ, aborting >>> Internal Compiler Error in >>> Z:\home\vladimir\work\Digger\work-wine\dl\vs2013-community\Program >>> Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64\cl.exe. You >>> will be prompted to send an error report to Microsoft later. >>> >>> The problem is that it attempts to load its builtin DLL even if I >>> place the native Microsoft's DLL in PATH before system32/syswow64. >>> WINEDLLPATH seems to have no effect, and adding a DLL override has no >>> effect other than changing whether it loads Wine's DLL on fails to >>> load a DLL at all (even though it's in PATH!). Yes, the model >>> (bitness) is correct. >>> >>> I remember reading somewhere that Wine uses the value of PATH from the >>> registry. I guess I could also just delete or overwrite Wine's DLL in >>> system32/syswow64. But is it possible to change the DLL search path >>> for one Wine invocation, without any permanent modifications to the >>> bottle? >>> >>> Partially related, but I noticed that Wine does not skip over DLLs of >>> wrong bitness as Windows does. Instead, the program fails to >>> initialize. This means you can't add 32-bit and 64-bit DLL directories >>> to PATH and let the programs' bitness sort out which to use. That's >>> definitely a bug I guess. >>> >>> >>

2 2

Fwd: How to change Wine DLL search path for "built-in" DLLs?
by Vladimir Panteleev 08 Apr '16

08 Apr '16

(reposting from wine-users, which seems to be dead) I'm trying to get the VS2012 C++ compiler (cl.exe) running under Wine - stand-alone, as a component for a different larger project. The project works fine on Windows without affecting any global system settings or files (i.e. it unpacks DLLs etc. to private subdirs instead of installing them system-wide). I'd like it to "just work" under Wine as well, without user intervention or persistent modifications to bottle settings or system files. Wine has a msvcr120.dll, however it is incomplete, at least as far as cl.exe is concerned: wine: Call from 0x7b44ee37 to unimplemented function msvcr120.dll.??0reader_writer_lock@Concurrency@@QEAA@XZ, aborting Internal Compiler Error in Z:\home\vladimir\work\Digger\work-wine\dl\vs2013-community\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin\amd64\cl.exe. You will be prompted to send an error report to Microsoft later. The problem is that it attempts to load its builtin DLL even if I place the native Microsoft's DLL in PATH before system32/syswow64. WINEDLLPATH seems to have no effect, and adding a DLL override has no effect other than changing whether it loads Wine's DLL on fails to load a DLL at all (even though it's in PATH!). Yes, the model (bitness) is correct. I remember reading somewhere that Wine uses the value of PATH from the registry. I guess I could also just delete or overwrite Wine's DLL in system32/syswow64. But is it possible to change the DLL search path for one Wine invocation, without any permanent modifications to the bottle? Partially related, but I noticed that Wine does not skip over DLLs of wrong bitness as Windows does. Instead, the program fails to initialize. This means you can't add 32-bit and 64-bit DLL directories to PATH and let the programs' bitness sort out which to use. That's definitely a bug I guess.

2 2

Re: [PATCH 1/4] dsound: Rework ugly mixer logic
by Henri Verbeet 08 Apr '16

08 Apr '16

On 8 April 2016 at 20:37, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > From: Maarten Lankhorst <maarten.lankhorst(a)canonical.com> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/dsound/dsound.c | 1 - > dlls/dsound/dsound_main.c | 6 -- > dlls/dsound/dsound_private.h | 6 +- > dlls/dsound/mixer.c | 252 +++++++++++-------------------------------- > dlls/dsound/primary.c | 107 ++++++++---------- > 5 files changed, 108 insertions(+), 264 deletions(-) > You're the one that has to maintain this, so I don't care all too much, but this looks like it's doing a bunch of different things under a pretty vague commit message.

2 1

Winegstreamer entry on Wine FAQ Wiki Page
by NP-Hardass 08 Apr '16

08 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, About a month ago, I created a Wine Wiki account and requested that it be activated, explicitly so that I could add an entry to the FAQ page [1]. After going to reference this new entry to someone today, I noticed that my changes were reverted soon after my submission and the page was subsequently locked [2]. This submission was made after consulting wine developer, Sebastian Lackner. I think this information would be very useful to users starting to adopt Winegstreamer, now that Andrew Eikum has updated it to gstreamer 1.0 and it is functioning again. I'd like to inquire why the change was reverted, if my content is deemed unnecessary, and if not, why it was not moved elsewhere. - -- NP-Hardass Gentoo Wine maintainer [1] https://wiki.winehq.org/index.php?title=FAQ [2] https://wiki.winehq.org/index.php?title=FAQ&action=history -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXBgQkAAoJEBzZQR2yrxj7Q6gP/27bv0ZQSiRYVgaoWu4SUOsu TXeZyPLTbKs+KbYuScyMmE1fv8d6FetSNdubUw0ZYKyryu7qUqm/19hhhrs3T6Oo j7hXa7QPmsejtRkM3kCWNItPS6M5olEEqBJq2Ics84DrfFiEaUxPdeJwFgiJLwvX erNgf5600OJHzhDxSCa0UfMdEBWBs7DsdVFncgAWyv3s4dnp4L7aaYGgv2vlpkXI QrhbUCzqWy5grjf9HOsmix4Zz9SSwk6xvEMBjRi9RHiAAOTx2f9Gussiwq2N1Dbe VYoZpxtGaEFt+UKtNJds5vZXaSQlWFg+IT8aeh/VglJJp7avM8Hi6gGFQ22CvwUr M31oU3t/adH3EzyKC0eVBrNjiicnRyzFbrTrkWwokKV+LjV/C8/SfexzHqzn40Vi T4yQrMBoHZcjT6YhLXFjVIE4RSIXbmT5TrCA6oAqKgbueGcfiEvLaz8ti/XUnsyO fgiCNrdSV1hPvAi+5yI2l+BE9xxxhrS2DOXyJlxYMflxXctbRnQ0KFjBzs24x4Qj CXXrXavrP8MhMoemzMuBZMEt7hui0+z4WUGZdjc+oT0Cso8VLrdnE93wJdBJOlbD G/K3cQb6hNr387pKcUXTEq1KDTyrH5LCzxOAjS4TOuhFti8jMbSdKRea9flfR2bp pVoJARXzVNeQla7n7+ox =3Bex -----END PGP SIGNATURE-----

4 7

Re: [PATCH 2/2] cmd: Add support for || and &&.
by Sebastian Lackner 07 Apr '16

07 Apr '16

On 07.04.2016 22:12, Qian Hong wrote: > Slightly improved based on Mikhail Bystryantsev's patch, add support for those built-in commands which does not change %ERRORLEVEL%. > > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > programs/cmd/builtins.c | 14 +++++++++++--- > programs/cmd/tests/test_builtins.cmd | 13 +++++++++++++ > programs/cmd/tests/test_builtins.cmd.exp | 13 ++++++++++++- > programs/cmd/tests/test_cmdline.cmd | 20 ++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 22 ++++++++++++++++++++++ > programs/cmd/wcmd.h | 1 + > programs/cmd/wcmdmain.c | 26 ++++++++++++++++++++++++-- > 7 files changed, 103 insertions(+), 6 deletions(-) > Has it really something to do with builtin-commands which do not change %ERRORLEVEL%? I think the tests only cover one of those commands, a couple of additional tests would probably not hurt. The lack of tests is also the reason why I haven't merged this into Staging yet. If this turns out to be right way to solve it, I would suggest to define a function check_errorlevel() which checks 'errorlevel' and 'changed' at once.

1 0

Re: [PATCH 2/2] cmd: Add support for || and &&.
by Qian Hong 07 Apr '16

07 Apr '16

I should add "From Mikhail Bystryantsev." in commit message, but something was wrong with my mail client. (Could you please use git send-email to send patches in the future? --- from Henri. :D) On Fri, Apr 8, 2016 at 4:12 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Slightly improved based on Mikhail Bystryantsev's patch, add support for > those built-in commands which does not change %ERRORLEVEL%. > > Signed-off-by: Qian Hong <qhong(a)codeweavers.com> > --- > programs/cmd/builtins.c | 14 +++++++++++--- > programs/cmd/tests/test_builtins.cmd | 13 +++++++++++++ > programs/cmd/tests/test_builtins.cmd.exp | 13 ++++++++++++- > programs/cmd/tests/test_cmdline.cmd | 20 ++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 22 ++++++++++++++++++++++ > programs/cmd/wcmd.h | 1 + > programs/cmd/wcmdmain.c | 26 ++++++++++++++++++++++++-- > 7 files changed, 103 insertions(+), 6 deletions(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 1/2] user32/tests: Message filtering tests for broadcast messages
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21970 Your paranoid android. === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

2 1

Re: [PATCH 2/2] user32: Limit broadcast messages to system and registered ones
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21971 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:11018: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11030: Test failed: msg.message = 275 instead of WM_USER msg.c:11032: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11041: Test failed: msg.message = 1024 instead of WM_TIMER msg.c:11043: Test failed: expected PeekMessage to return FALSE, got 1 === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

1 0

Re: [PATCH 3/3] mshtml: Added more IHTMLXMLHttpRequst::send tests.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21965 Your paranoid android. === w1064 (64 bit xmlhttprequest) === The test timed out

1 0

Re: [v9 4/6] d3dx9: Add basic opcodes to preshader.
by Matteo Bruni 07 Apr '16

07 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static double pres_rsq(double *args, int ncomp) > +{ > +double v; Indentation. You could also probably rename ncomp to just n. Also I get this on 32 bit: effect.c:3838: Test succeeded inside todo block: Operation rsq, component 2, expected 0x3f2c985c, got 0x3f2c985c (0.6742). effect.c:3838: Test succeeded inside todo block: Operation rsq, component 3, expected 0x1f800001, got 0x1f800001 (5.42101e-20).

2 2

Re: [v9 3/6] d3dx9: Implement fxlc constants (expressions) in effect.
by Matteo Bruni 07 Apr '16

07 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static double regstore_get_double(struct d3dx_regstore *rs, unsigned int table, unsigned int offset) > +{ > + BYTE *p; > + > + p = (BYTE *)rs->tables[table] + table_info[table].component_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : return *(float *)p; > + case PRES_VT_DOUBLE: return *(double *)p; > + case PRES_VT_INT : return *(int *)p; > + case PRES_VT_BOOL : return *(BOOL *)p ? 1.0f : 0.0f; The 'f' suffix is now wrong since you're returning double. Something like "return !!*(BOOL *)p;" would be probably preferable, although I don't think you're ever supposed to read from PRES_VT_INT or PRES_VT_BOOL tables so maybe replacing the last two cases with a FIXME or similar is even better. > +static void regstore_set_double(struct d3dx_regstore *rs, unsigned int table, unsigned int offset, double v) > +{ > + BYTE *p; > + unsigned int reg_idx; > + > + p = (BYTE *)rs->tables[table] + table_info[table].component_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : *(float *)p = v; break; > + case PRES_VT_DOUBLE: *(double *)p = v; break; > + case PRES_VT_INT : *(int *)p = roundf(v); break; Same here. Also it's not clear that rounding away from 0 is correct, this would need tests (although IIRC preshaders generated by the MS compiler explicitly compute integral values for integer constants, that would make this hard to test and mostly irrelevant in practice). So please try to test for rounding behavior with 0.5 / -0.5 / 1.5, if nothing else to confirm that my memory serves me right. BTW unless testing proves otherwise lrint() is probably the best option here since it generates much nicer code (at least when building with gcc for 32 bits). > + case PRES_VT_BOOL : *(BOOL *)p = !!v; break; The !! here might also be unnecessary strictly speaking but this isn't quite as significant and it's okay to me either way. > + transpose = (desc.Class == D3DXPC_MATRIX_COLUMNS && param->class == D3DXPC_MATRIX_ROWS) || > + (param->class == D3DXPC_MATRIX_COLUMNS && desc.Class == D3DXPC_MATRIX_ROWS); It looks like you forgot to move the operator at the start of the next line here (while you did that e.g. in patch 6/6).

2 2

[GSoC] Further work on the Visual C++ iostream library
by Piotr Caban 07 Apr '16

07 Apr '16

Hi Iván, could you please provide us with timeline for your project? It doesn't have to be very specific. Thanks, Piotr

2 1

Re: [PATCH] msvcp90: Add codecvt<wchar_t>::do_encoding that returns 0
by Piotr Caban 07 Apr '16

07 Apr '16

On 04/06/16 18:51, Daniel Lehman wrote: > seems to be only msvcp90 that returns 1 > > all others return 0 (which seems more correct anyway) Msvcp100 behaves the same as msvcp90. Please also update codecvt_short virtual functions table. Thanks, Piotr

1 0

Wine is "Community Choice" SourceForge Project of the Month
by Marcus Meissner 07 Apr '16

07 Apr '16

Hi, We are the "Community Choice" Project of the Month April 2016 at SourceForge. https://sourceforge.net/blog/april-2016-community-choice-project-of-the-mon… Ciao, Marcus

2 2

Re: ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call. (v2)
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21960 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call. (v2)
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21959 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call.
by Alexandre Julliard 07 Apr '16

07 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The change only affects FSCTL_PIPE_LISTEN because we probably want > more tests before changing the rest. Indeed we do, so you should probably move this out of the default case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21958 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

1 0

Re: [2/4] ntdll/tests: Add tests for iosb.Status value after pending FSCTL_PIPE_LISTEN call.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21955 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

2 1

Re: [1/4] ntdll/tests: Fix some test failures on Win 8+.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21954 Your paranoid android. === w864 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (32 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w864 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231 === w1064 (64 bit pipe) === pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 1, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 2, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 0, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 80000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: 40000000, GetLastError: 231 pipe.c:240: Test failed: CreateFile failed for sharing 3, access: c0000000, GetLastError: 231

1 0

Re: [PATCH 1/2] d3drm/tests: Add tests for IDirect3DRM*::CreateObject.
by Stefan Dösinger 06 Apr '16

06 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Some curiosities: Am 2016-04-03 um 20:04 schrieb Aaryaman Vasishta: > + for (i = 0; i < sizeof(tests) / sizeof(*tests); ++i) > + { > + hr = IDirect3DRM_CreateObject(d3drm1, tests[i].clsid, NULL, NULL, NULL); > + todo_wine ok(hr == D3DRMERR_BADVALUE, "Test %u: expected hr == D3DRMERR_BADVALUE, got %#x.\n", i, hr); What does clsid != NULL, refiid == NULL, output object != NULL do? I guess that clsid is the object you create, and iid is the interface to that object that is returned. So I guess in theory you can pass clsid = IDirect3DRMTexture3, iid = IDirect3DRMTexture and you'd get the same result as creating a d3drmtexture3 object and then calling QI(IDirect3DRMTexture). It might be worth adding explicit tests for this in future patches. (And if you use aggregation you'll want to pass iid == IUnknown, otherwise there's no way you get the inner IUnknown and will never be able to release the object) > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + IUnknown_Release(unknown); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); So what will increment the refcount? InitFrom*? > + hr = IDirect3DRM2_CreateObject(d3drm2, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + ref3 = get_refcount((IUnknown *)d3drm2); > + ok(ref3 == ref1, "Test %u: expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", i, ref1, ref3); > ... > + > + hr = IDirect3DRM3_CreateObject(d3drm3, tests[i].clsid, NULL, tests[i].iid, (void **)&unknown); > + ok(SUCCEEDED(hr), "Test %u: expected hr == D3DRM_OK, got %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 == ref1, "Test %u: expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + ref3 = get_refcount((IUnknown *)d3drm3); > + ok(ref3 == ref1, "Test %u: expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", i, ref1, ref3); Since you're testing the refcounts of 1,2 and 1,3 you might as well test the refcounts of all interfaces in all 3 versions. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXAXWIAAoJEN0/YqbEcdMwbkIQAI9ItseZE8bef+z24Cisul9g UYxXhve3Ll9Pz5vVB+jG0H0F5iPk4vdmoHIwsJgd018xBnwXc1C0+QkTknsTHcfI LOb1l4PbjherhDNDn+4t95Hy3fdHKrutFkMhYp73m1+0V5GwY7MANCmIxu4b/z+b nW545EvcpPGluZXPcPyWiwGi9qB33VkGRvDkUpii8qQtwC+vsrDuerWcT2V7fbXj 2R0O9QSuvlbd83p16i3nVx2R8ZQRweYQoSKKdLBca07cIt3/xW6lBJOz34yUmupE 5PdKK0wOPWMKXVCuAplWuDGrvgCOtyMcIB1FmsUfxPfLjonfX3UeXoWfTwMmrMBo XkzgZj8S6JTPK2qOegzg8nGz8FZXvsvWkUZWzCtypuuAQ3rGn5p940JwIu3pW+Cq 4Z3K+r7Ka9lYxSJfiliNyhqPIlrGytHbrpN0aTmWJGn79Jqs7Ffd01+ujOQ2NlOf POWffmglWRHoYDZjSOS2JaL597hhna7ktM0xlhTWHT7HFgRB4oCV2DJAHmSeZUME egudzSfSbRgB9u8bQQpfrYr/kV6MJ0OE2d3VoTn8RRJ3RJL5UFp08N7m+YXkQW9T LAzfiyaAjNILLTCj4tpqjEikH2ftGE/hBH+tInXTKlwnf1NyB6iz5/1+dAm+7JYk MKdVO/nQCpGffRqmYNtG =H6sj -----END PGP SIGNATURE-----

2 1

Re: [PATCH] wined3d: Add Nvidia GeForce 820M
by Henri Verbeet 06 Apr '16

06 Apr '16

On 6 April 2016 at 16:06, Caron Wills <caron(a)codeweavers.com> wrote: > for bug 40348 > This ends up looking like this on the patches site: https://source.winehq.org/patches/data/121067. That's actually a valid patch, but it's not exactly ideal. Could you please use git send-email to send patches in the future?

1 0

Re: [PATCH] msvcr120: Add remainder (try3)
by Piotr Caban 06 Apr '16

06 Apr '16

Hi Daniel, On 04/06/16 01:00, Daniel Lehman wrote: > Try2: handle y==0 > Try3: add tests and error handling for both x and y, but I have a question: > > Based on the tests, remainder on 32-bit Windows differs from 64-bit Windows in errno handling. Other math functions, like acosf, behave the same - if tests for it were added, the current Wine implementation would differ from 32-bit Windows > > The #ifdef is admittedly ugly but makes it match both Windows 32-bit and 64-bit > > is it preferable to match Windows exactly? or could I drop the #ifdef and use the 64-bit errno handling, like acosf? could I skip the tests that differ on 32-bit? It depends on the function. In this case I don't think anything bad will happen if errno is set on invalid input even so it's not on Windows. I think it's OK to ignore the difference in this case and run some tests only in 32-bit or 64-bit environment. If you decide to be not fully compatible with native - please leave a comment in code. Currently the tests are not working on wine (both i386 and x86_64). Thanks, Piotr

2 2

Re: [PATCH 5/5] wined3d: Alpha test emulation for core profile contexts.
by Henri Verbeet 06 Apr '16

06 Apr '16

On 31 March 2016 at 19:51, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + shader_addline(buffer, "if (alpha_test)\n"); > + if (alpha_func != WINED3D_CMP_NEVER) > + shader_addline(buffer, " if (!(%s[0].a %s alpha_ref))\n", > + get_fragment_output(gl_info), comparison_operator[alpha_func - WINED3D_CMP_NEVER]); > + shader_addline(buffer, " discard;\n"); Is there really an advantage to having the "alpha_test" uniform instead of just mapping disabled alpha test to WINED3D_CMP_ALWAYS? > @@ -973,6 +981,7 @@ struct ps_compile_args { > WORD texcoords_initialized; /* MAX_TEXTURES, 8 */ > BOOL pointsprite; > BOOL flatshading; > + enum wined3d_cmp_func alpha_func; > }; > > enum fog_src_type { > @@ -2022,6 +2031,7 @@ struct ffp_frag_settings > unsigned char pointsprite : 1; > unsigned char flatshading : 1; > unsigned char padding : 5; > + enum wined3d_cmp_func alpha_func; "alpha_func" only needs 4 bits (3 if you just mask the 4th bit), so would still fit in the padding. That applies somewhat to struct ps_compile_args as well, although we may care less there.

2 3

Re: [v9 6/6] d3dx9: Implement setting named shader constants in effect.
by Matteo Bruni 06 Apr '16

06 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: A few nitpicks: > +HRESULT d3dx_set_shader_const_fxlc(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, > + struct d3dx_parameter *param, BOOL vs) > +{ > + IDirect3DDevice9 *device = effect->device; > + HRESULT hr, ret; > + struct d3dx_parameter **params; > + D3DXCONSTANT_DESC *cdesc; > + unsigned int parameters_count; > + unsigned int i, j; > + > + if (!param->param_eval) > + { > + FIXME("Preshader structure is null.\n"); > + return D3DERR_INVALIDCALL; > + } The name of the function and the FIXME above seem somewhat mixed up WRT the naming change we had earlier. > + if (FAILED(hr = d3dx_param_eval_set_shader_constants(device, param->param_eval))) > + return hr; > + params = param->param_eval->shader_inputs.inputs_param; > + cdesc = param->param_eval->shader_inputs.inputs; > + parameters_count = param->param_eval->shader_inputs.input_count; > + ret = D3D_OK; > + for (i = 0; i < parameters_count; i++) > + { > + if (params[i] && params[i]->class == D3DXPC_OBJECT && (params[i]->type == D3DXPT_SAMPLER > + || params[i]->type == D3DXPT_SAMPLER1D || params[i]->type == D3DXPT_SAMPLER2D > + || params[i]->type == D3DXPT_SAMPLER3D || params[i]->type == D3DXPT_SAMPLERCUBE)) Line continuations should have 8 spaces indentation. You can also replace i++ with ++i like in the other patches. > + TRACE("setting %u consts at %u.\n", n, start); Capitalize "setting", spell out "constants".

1 0

Re: [v9 5/6] d3dx9: Implement array selectors in effect.
by Matteo Bruni 06 Apr '16

06 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > case ST_ARRAY_SELECTOR: > - FIXME("Array selector.\n"); > - break; > + { > + struct d3dx_parameter array_idx_par; I'd call that array_idx_param, for consistency. Also you can probably declare it static const and initialize it just once. > + if (FAILED(hr = d3dx9_get_param_value_ptr(effect, pass, state, &param_value, &param))) > + /* Native d3dx returns OK from BeginPass or Commit involving out of bound array > + access, and does not touch affected state. */ Nitpicks: please spell D3D_OK in full, boundS, drop the comma. Usually we put a '*' at the start of following comment lines for multiline comments, aligned with the '*' from the first line.

1 0

Re: [v9 1/6] d3dx9: Implement preshader parsing.
by Matteo Bruni 06 Apr '16

06 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Looks good! Just a few tiny comments: > +static void dump_bytecode(void *data, unsigned int size) > +{ > + unsigned int *bytecode = (unsigned int *)data; The cast is unnecessary. > +static unsigned int *find_bytecode_comment(unsigned int *ptr, unsigned int count, > + unsigned int fourcc, unsigned int *size) > +{ > + /* Provide at least one value in comment section on non-NULL return. */ > + while (count > 2 && (*ptr & 0xffff) == 0xfffe) > + { > + unsigned int section_size; > + > + section_size = (*ptr >> 16); > + if (!section_size || section_size + 1 > count) > + break; I guess a WARN() would be nice there. Also probably an "explicit" return NULL is a bit nicer. > +static HRESULT parse_preshader(struct d3dx_preshader *pres, unsigned int *ptr, unsigned int count, struct d3dx9_base_effect *base) Try to stay below 120 characters per line (targeting ~100). > + p = find_bytecode_comment(ptr + 1, count - 1, FOURCC_CLIT, &section_size); > + if (p) > + { > + const_count = *p++; > + if (const_count > (section_size - 1) / (sizeof(double) / sizeof(unsigned int))) > + { > + WARN("Byte code buffer ends unexpectedly.\n"); > + return D3DXERR_INVALIDDATA; > + } > + dconst = (double *)p; > + } > + else > + { > + const_count = 0; > + dconst = NULL; > + } > + TRACE("%u double constants.\n", const_count); > + > + p = find_bytecode_comment(ptr + 1, count - 1, FOURCC_FXLC, &section_size); You could decrement "count" by the amount of section_size before looking for the next comment. It probably makes sense to set *size to 0 at the beginning of find_bytecode_comment() so that you can unconditionally decrement here. > + count = byte_code_size / sizeof(unsigned int); > + if (!byte_code || !count) > + { > + *peval_out = NULL; > + return; > + } It just occurred to me, you could also check for byte_code_size % sizeof(unsigned int) while you're at it.

1 0

Re: [tools] winemono.php: Set default version to 4.6.2.
by Alexandre Julliard 06 Apr '16

06 Apr '16

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -4,7 +4,7 @@ > */ > > // Default version if none given > -$sVersion = '4.6.0'; > +$sVersion = '4.6.2'; Do we need this? Is there anything that actually uses the default version? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [4/4] webservices: Always skip comment and empty text nodes in WsReadType.
by Sebastian Lackner 06 Apr '16

06 Apr '16

On 06.04.2016 14:09, Hans Leidekker wrote: > + if ((hr = read_node( reader ) != S_OK)) return hr; Only moved by your patch, but this looks like a typo.

1 0

Re: [3/4] webservices: Reset the read position if an opening bracket is not followed by a valid name character.
by Sebastian Lackner 06 Apr '16

06 Apr '16

On 06.04.2016 14:09, Hans Leidekker wrote: > +static inline void read_rewind( struct reader *reader, unsigned int count ) > +{ > + while (reader->read_pos && count) > + { > + reader->read_pos--; > + count--; > + } > +} I know its also done similar in the function above, but it still looks weird to me. Is it really necessary to unroll simple math functions like addition and subtraction?

1 0

Re: user32: Use top level window as dialog parent for modal dialogs.
by Dmitry Timoshkov 06 Apr '16

06 Apr '16

Hi Jacek, Jacek Caban <jacek(a)codeweavers.com> wrote: > This is part of the fix for bug 40282. Could you please add actual tests that show the handling of disabled window state? Neither current tests nor the new ones actually check that at all, having such tests would prevent new regressions in this area. Feel free to use my tests from the staging repository as a base if desired, or write your own ones that use the same approach. -- Dmitry.

4 23

Re: krnl386.exe16: Do not reassign default handles after they got closed.
by Alexandre Julliard 06 Apr '16

06 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -363,7 +363,7 @@ HFILE16 WINAPI _lclose16( HFILE16 hFile ) > } > TRACE("%d (handle32=%p)\n", hFile, dos_handles[hFile] ); > CloseHandle( dos_handles[hFile] ); > - dos_handles[hFile] = 0; > + dos_handles[hFile] = (hFile < 5) ? INVALID_HANDLE_VALUE : 0; This will cause functions that take default handles to not return the correct errors. Is that really how it's supposed to work? What bug is this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: user32: Use top level window as dialog parent for modal dialogs.
by Marvin 05 Apr '16

05 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21903 Your paranoid android. === w864 (64 bit win) === win.c:8544: Test failed: msg.message = 320

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLWindow6::postMessage semi-stub implementation.
by Marvin 05 Apr '16

05 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21874 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

FW: [PATCH 1/2] ucrtbase: Add _get_initial_wide_environment
by Daniel Lehman 05 Apr '16

05 Apr '16

ignore - didn't sign. Will resend later

1 0

Wine Download Server
by Nathan 04 Apr '16

04 Apr '16

I am having difficulty downloading the three files: https://dl.winehq.org/wine/wine-appdb-*.tar.gz https://dl.winehq.org/wine/wine-bugzilla-*.tar.gz https://dl.winehq.org/wine/wine-wiki-*.xml.gz * not part of the actual file names.

6 10

Re: [PATCH 1/2] ntoskrnl.exe: add PsRemoveLoadImageNotifyRoutine stub
by Sebastian Lackner 04 Apr '16

04 Apr '16

On 04.04.2016 02:59, Austin English wrote: > /*********************************************************************** > + * PsRemoveLoadImageNotifyRoutine (NTOSKRNL.EXE.@) > + */ > + NTSTATUS WINAPI PsRemoveLoadImageNotifyRoutine(PLOAD_IMAGE_NOTIFY_ROUTINE NotifyRoutine) > + { > + FIXME( "stub: %p\n", NotifyRoutine ); > + return STATUS_SUCCESS; > + } Its too late to fix it now, but please check the formatting a bit more careful the next time. Some lines contain an unnecessary space at the beginning.

1 0

Re: kernel32: add GetVolumeInformationByHandleW stub
by Nikolay Sivov 04 Apr '16

04 Apr '16

> +@ stdcall GetVolumeInformationByHandleW(ptr wstr long ptr ptr ptr wstr long) All string buffers are out parameters. > + FIXME("%p %s %d %p %p %p %s %d\n", handle, debugstr_w(volnamebuf), volnamesize, volserial, maxlength, flags, debugstr_w(fsnamebuf), fsnamesize); Should be fixed too.

1 0

Re: [PATCH] msvcr120: Add remainder (try 2)
by Piotr Caban 04 Apr '16

04 Apr '16

On 04/04/16 17:05, Daniel Lehman wrote: > Try2: handle y == 0 You should probably also check if x and y is finite (I haven't tested it myself). Thanks, Piotr

1 0

Re: [PATCH] ucrtbase: Add some wide functions called on startup
by Piotr Caban 04 Apr '16

04 Apr '16

The functions looks like stubs. Is this is a correct implementation? If not please change TRACE to FIXME. Thanks, Piotr

2 1

Re: [PATCH 2/2] msvcr120: Add remainder
by Piotr Caban 04 Apr '16

04 Apr '16

On 04/02/16 02:09, Daniel Lehman wrote: > +/********************************************************************* > + * remainder (MSVCR120.@) > + */ > +double CDECL MSVCR120_remainder(double x, double y) > +{ > +#ifdef HAVE_REMAINDER > + return remainder(x, y); > +#else > + FIXME( "not implemented\n" ); > + return 0.0; > +#endif Please handle y==0 case. Thanks, Piotr

1 0

Re: [PATCH] wininet: Dont fail on invalid Certificates when masking errors.
by Jacek Caban 04 Apr '16

04 Apr '16

Hi Alistair, On 04/04/16 11:48, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/wininet/netconnection.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index 7305860..723705a 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c > @@ -200,7 +200,10 @@ static DWORD netconn_verify_cert(netconn_t *conn, PCCERT_CONTEXT cert, HCERTSTOR > conn->server->cert_chain = NULL; > } > if(conn->mask_errors) > + { > conn->server->security_flags |= conn->security_flags & _SECURITY_ERROR_FLAGS_MASK; > + err = ERROR_SUCCESS; > + } I don't think we should do that. mask_errors means that we should combine errors, not ignore them. I don't know what you're trying to fix, but I'd suggest to concentrate on error source (maybe there shouldn't be an error in the first place or it should be ignored due to security_flags). If you think that the error is right, maybe we don't handle failure correctly. Cheers, Jacek

2 1

Re: [PATCH] comctrl32/tooltips: AddTool doesn't fails on empty TTTOOLINFO structure
by Marvin 04 Apr '16

04 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21855 Your paranoid android. === wxppro (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2003std (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7u (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w8 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (32 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === wvistau64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w2008s64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w7pro64 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w864 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed === w1064 (64 bit tooltips) === tooltips.c:382: Test failed: Adding the tool to the tooltip failed

1 0

Re: sfc_os: add SRSetRestorePointA/W stubs
by Alistair Leslie-Hughes 04 Apr '16

04 Apr '16

Hi Austin, On 04/04/16 10:24, Austin English wrote: > For https://bugs.winehq.org/show_bug.cgi?id=40397 / > https://bugs.winehq.org/show_bug.cgi?id=40410 > > > +BOOL WINAPI SRSetRestorePointA(RESTOREPOINTINFOA *restorepoint, STATEMGRSTATUS *status) >... > + return 0; > +} > It would be better to return TRUE or FALSE for the BOOL type. Best Regards Alistair

1 0

wine-1.8.2-rc2 Available
by Michael Stefaniuc 03 Apr '16

03 Apr '16

Hello, I have pushed now wine-1.8.2-rc2 (Warning: forced update). Many thanks to Sebastian for reviewing 1.8.2-rc1. As I've missed 3 dependency patches for the fix for bug #13683 I have rebased the stable branch and added a fix for a fix and two test patches. The 1.8.2-rc1 tag is still available. Missed dependencies: 85faafc user32: Ensure that button responds only to changes in WM_CAPTURECHANGED handler. 0bea2f7 comctl32: Ensure that trackbar respond only to changes in WM_CAPTURECHANGED handler. ff063d9 comctl32: Ensure that toolbar respond only to changes in WM_CAPTURECHANGED handler. Fix: 97c70c8 wined3d: Fix driver version check. Tests 1bebee9 kernel32/tests: Add test to show that CompareStringW aborts on first non-matching character. 32f7298 kernel32/tests: Add tests for RtlInterlockedPushListSList[Ex]. The changes excluding tests are: comctl32/toolbar.c | 1 + comctl32/trackbar.c | 1 + user32/button.c | 1 + wined3d/directx.c | 3 +-- 4 files changed, 4 insertions(+), 2 deletions(-) bye michael

1 0

Re: [PATCH] loader: Fix wld_prctl prototype.
by Qian Hong 03 Apr '16

03 Apr '16

On Mon, Apr 4, 2016 at 1:42 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > reserve debugging Typo, should be "Reverse Debugging". One can debug with "backward step in" and "backward next". Maybe useful for Wine developers. -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 1/2] t2embed: Implement TTIsEmbeddingEnabledForFacename()
by Dmitry Timoshkov 02 Apr '16

02 Apr '16

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + if (!strcasecmp(name, facename)) strcasecmp() is not suitable for strings in windows encodings. -- Dmitry.

1 0

VRAM size autodetection on OS X
by Theodore Dubois 02 Apr '16

02 Apr '16

Sometimes, when I'm playing games on Wine, the game crashes, and then I look in the log and see "Out of adapter memory". Then I run `winetricks videomemorysize=1024`, and it runs fine. My graphics card has 1536 MB of total VRAM. It seems to me that Wine isn't correctly autodetecting the amount of VRAM I have. (DISCLAIMER: The following analysis is not based on any log output. It's based on my reading of the code, which may well be incorrect. If so, please correct me.) I just had a look at the code. In dlls/wined3d/directx.c, query_gpu_description uses wglQueryCurrentRendererIntegerWINE to obtain the GPU vendor, device, and available VRAM. wglQueryCurrentRendererIntegerWINE is part of the WGL_WINE_QUERY_RENDERER extension, which...is not implemented in winemac.drv. It's only implemented in winex11.drv. I don't use X11 if I can help it. So, with absolutely no information about what the graphics card is, Wine defaults to an Nvidia Riva 128 with WINE_DEFAULT_VIDMEM (64MB) of VRAM. This is not close. I would like to write a patch to fix this problem. I'm thinking of adding an implementation of WGL_WINE_QUERY_RENDERER to winemac.drv. There are 12 different things that can be queried about the renderer, but only WGL_RENDERER_VENDOR_ID_WINE, WGL_RENDERER_DEVICE_ID_WINE, and WGL_RENDERER_VIDEO_MEMORY_WINE are used to my knowledge, so I’d only implement those. Does this sound correct? ~Theodore

3 2

Re: ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. (try 2)
by Sebastian Lackner 02 Apr '16

02 Apr '16

On 29.03.2016 22:13, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39734 > > This patch should avoid crash in acedrv11.sys. > IoAllocateIrp is called with a stack_size of -128. > Therefore ExAllocatePool gets a negative size value. > > Tested against Windows XP. > (See the test based on wine-staging "driver testing framework" attached to the bug.) > ( https://newtestbot.winehq.org/JobDetails.pl?Key=21722 testrun by Sebastian Lackner.) > > Try 1: https://www.winehq.org/pipermail/wine-patches/2016-March/148587.html > Review 1: https://www.winehq.org/pipermail/wine-devel/2016-March/112476.html > > Changes since try 1: > - Fix usage of wrong variable. > - Use a better name for variable. > - Simplify if statement. > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks for the updated version. Could you maybe also add a couple of additional tests with charge_quota = TRUE? Since you are changing both versions, I'm fearing a bit that your changes could break other situations. If there are no unexpected test failures it looks good to me.

2 1

Re: [PATCH] user32: Add stub for IsProcessDPIAware
by Alexandre Julliard 01 Apr '16

01 Apr '16

Louis Lenders <xerox.xerox2000x(a)gmail.com> writes: > Signed off: Louis Lenders <xerox.xerox2000x(a)gmail.com> This is still not a valid Signed-off-by header. Could you please use git to generate it, so that it matches the standard format? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v8 1/6] d3dx9: Implement preshader parsing.
by Matteo Bruni 31 Mar '16

31 Mar '16

2016-03-29 17:22 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > +enum pres_reg_tables > +{ > + PRES_REGTAB_IMMED, /* immediate double constants from CLIT */ I don't quite recall, I might be contradicting my own earlier comments here but at this point this comment doesn't seem to add much. General (and late) note, we usually tend to be more verbose with variable or type names and avoid too cryptic abbreviations. I don't think it's worth changing everything now though. > +struct d3dx_preshader > +{ > + struct d3dx_regstore regs; > + > + unsigned int ins_count; > + struct d3dx_pres_ins *ins; > + > + struct d3dx_const_tab inputs; > +}; > + > + > +struct d3dx_param_eval That double empty line seems unnecessary. > -HRESULT d3dx_create_param_eval(struct d3dx9_base_effect *base_effect, void *byte_code, unsigned int byte_code_size, > +enum pres_ops > +{ > + PRESHADER_OP_NOP, > + PRESHADER_OP_MOV, > + PRESHADER_OP_MAX_ENUM > +}; Maybe rename _MAX_ENUM to _UNKNOWN? At least for this patch series you don't really need that enum value though (see below). > +static HRESULT regstore_alloc_table(struct d3dx_regstore *rs, unsigned int table) > +{ > + unsigned int size; > + > + size = rs->table_sizes[table] * table_info[table].reg_component_count * table_info[table].component_size; > + if (size) > + { > + rs->tables[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > + rs->table_value_set[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + sizeof(*rs->table_value_set[table]) * > + ((rs->table_sizes[table] + PRES_BITMASK_BLOCK_SIZE - 1) / PRES_BITMASK_BLOCK_SIZE)); Indentation. > +static void regstore_set_values(struct d3dx_regstore *rs, unsigned int table, void *data, > + unsigned int start_offset, unsigned int count) > +{ > + unsigned int block_idx, start, end, start_block, end_block; > + > + if (!count) > + return; > + > + memcpy((BYTE *)rs->tables[table] + start_offset * table_info[table].component_size, > + data, count * table_info[table].component_size); Indentation. > + for (i = 0; i < PRESHADER_OP_MAX_ENUM; ++i) > + if (ins_code == pres_op_info[i].opcode) > + break; > + if (i == PRESHADER_OP_MAX_ENUM) > + { > + FIXME("Unknown opcode %#x, raw %#x.\n", ins_code, ins_raw); > + return NULL; > + } I'd use ARRAY_SIZE(pres_op_info) instead of PRESHADER_OP_MAX_ENUM. > + cdesc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*cdesc) * desc.Constants); > + inputs_param = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*inputs_param) * desc.Constants); AFAICS neither really needs HEAP_ZERO_MEMORY. You should also check those allocations and bail out if either one fails. > +static void update_table_sizes_consts(unsigned int *table_sizes, struct d3dx_const_tab *ctab) > +{ > + unsigned int i, table, max_register; > + > + for (i = 0; i < ctab->input_count; ++i) > + { > + max_register = ctab->inputs[i].RegisterIndex + ctab->inputs[i].RegisterCount; > + table = ctab->regset2table[ctab->inputs[i].RegisterSet]; > + if (table < PRES_REGTAB_COUNT) > + table_sizes[table] = max(table_sizes[table], max_register); > + } > +} > + > +static void update_table_size(unsigned int *table_sizes, unsigned int table, unsigned int offset) > +{ > + table_sizes[table] = max(table_sizes[table], get_reg_offset(table, offset) + 1); > +} Why not use it also in update_table_sizes_consts()? The "table < PRES_REGTAB_COUNT" check should then go into the update_table_size() helper. > + if (const_count > UINT_MAX / sizeof(double)) > + { > + WARN("Invalid immediate constants count %u.\n", const_count); > + return NULL; > + } > + if (p - ptr + const_count * (sizeof(double) / sizeof(unsigned int)) >= count) > + { > + WARN("Byte code buffer ends unexpectedly.\n"); > + return NULL; > + } The first check seems unnecessary, if the idea was to avoid integer overflows in the second check you can rewrite that one instead (e.g. by dividing by sizeof(unsigned int) both sides of the inequality). That second check can probably be improved by verifying that the constants fit into the CLIT comment instead (see below). BTW, the function return type is HRESULT, those returns generate warnings for me. > + pres->ins = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*pres->ins) * pres->ins_count); You should probably check this allocation too. > + for (i = 0; i < pres->ins_count; ++i) > + { > + unsigned int *ptr_next; > + > + ptr_next = parse_pres_ins(p, count, &pres->ins[i]); > + if (!ptr_next) > + return D3DXERR_INVALIDDATA; > + count -= ptr_next - p; > + p = ptr_next; > + } > + > + if (!count) > + { > + WARN("Byte code buffer ends unexpectedly.\n"); > + return D3DXERR_INVALIDDATA; > + } These kinds of size checks probably work but they are somewhat hard to follow. You could instead check the size of each comment section (making sure that it doesn't overflow the whole bytecode buffer) and then check that you don't go outside of each comment while parsing it. find_bytecode_comment() could do the first check before returning and, for example, also return the comment size so that the caller can use it to validate the relevant accesses. Hopefully what I mean is clear enough, otherwise as usual feel free to ask. > +err_out: > + FIXME("Error creating parameter evaluator.\n"); > + d3dx_free_param_eval(peval); > *peval_out = NULL; > - return E_NOTIMPL; > + return; > +} That return is now unnecessary.

1 0

Re: [PATCH 2/2] d3dx10: Add D3DX10UnsetAllDeviceObjects stub
by Matteo Bruni 31 Mar '16

31 Mar '16

2016-03-29 9:07 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Reference: https://bugs.winehq.org/show_bug.cgi?id=27035 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Applying: d3dx10: Add D3DX10UnsetAllDeviceObjects stub .git/rebase-apply/patch:35: new blank line at EOF. + .git/rebase-apply/patch:52: new blank line at EOF. + warning: 2 lines add whitespace errors. Looks okay otherwise.

1 0

Re: [PATCH v2 1/5] ddraw/tests: Add a test for color varyings clamping.
by Marvin 31 Mar '16

31 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21816 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

wine-1.8.2-rc1 Available
by Michael Stefaniuc 31 Mar '16

31 Mar '16

Hello guys, sorry for the delay in preparing the next Stable release. Too much stuff going on and I couldn't focus on Wine. I have pushed today an informal wine-1.8.2-rc1 to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ 1.8.2-rc1 is fairly complete(*) from my point of view. The plan is to give the interested developers about a week time to look at the proposed 1.8.2. On Wednesday next week I plan to hand over the "final" to Alexandre, with a probable release on Friday next week. Depending on the feedback / outcry I might do another release candidate before Wednesday. (*) I wanted to include: Bug 39092 - Regression introduced with xaudio2_8 too. It is a beast to cherry-pick due to the dependencies and dependencies of dependencies... 1.8.2-rc1 is already big enough: - I have included this time interesting commits I have found interesting, mostly based on the additional information in the patch submission. - 32 bugs fixed (of which 6 are regressions). - 86 patches (of which 7 are tests only). - With test file changes filtered out: 95 files changed, 1873 insertions(+), 770 deletions(-) - The biggest "offender" for those changes is Bug 25086 - Multiple games and applications need kernel32.GetLogicalProcessorInformationEx implementation - I have attached the filtered diffstat While I have added a (lightweight) tag to it, I didn't bother with the rest of the release stuff. I have included that info in this email though. ---------------------------------------------------------------- Bugs fixed in 1.8.2-rc1 (total 32) [12652] Tom Clancy's Rainbow Six: Vegas 2 fails to launch (number of quality levels for D3DMULTISAMPLE_NONMASKABLE multiple-sample type must not exceed 8) [13683] Ultima IX: Mouse pointer missing when reading books, under inventory [14617] Multiple Visual Basic 5/6 applications using ActiveX components depend on Standard OLE Types Typelib which is missing from 'olepro32.dll' [15473] Adobe After Effects 4 crashes on startup [25086] Multiple games and applications need kernel32.GetLogicalProcessorInformationEx implementation (CPU-Z 1.72, Splinter Cell: Blacklist, Adobe CC 2015, Kontakt 5) [30687] Powerpoint 2003/2007: embedded video play/pause on click no longer works [32827] Legrand XlPro 3 (MFC app) crashes on startup (failure to load registry-free COM servers via app hook, 'OleCreate' must ignore HRESULT of 'IOleObject::GetMiscStatus') [33787] IE8 crashes on new tab [33988] Star Wars: The Force Unleashed II - Crashes with a page fault [34174] MinGW installer 0.5-beta-20120426-1 fails to process log files (sharing violation on temp file used for piped output) [34318] Multiple games and applications need ntdll.dll.EtwRegisterTraceGuidsW (Process Hacker 2.x, Far Cry 4) [35187] Jade Empire Special Edition configuration tool always resetting video settings [36013] bleem! 1.4 (PlayStation emulator) fails on startup, complaining with 'Not enough memory to load program!' [37115] Calling ReadFile from WINBASEAPI (WinBase.h) with zero read length causes hang [37288] Not implemented feature System.Drawing.Pen.ResetTransform() [37536] Native MSVCP120.dll override requires implementation of msvcr120.dll._W_Gettnames (Desura client) [37556] CompareStringW should abort on the first nonmatching character to avoid invalid memory access. [38314] Mouse Wheel doesn't work for Jagged Alliance 2 version 1.13 (it uses MOUSEHOOKSTRUCTEX) [39591] Crimzon Clover: Page fault on launch [39838] Wreckfest Server: Crashes at startup, unimplemented function KERNEL32.dll.GetConsoleScreenBufferInfoEx & SetConsoleScreenBufferInfoEx [39866] XIIZeal (steam) immediately exits on start [39875] Starcraft can't see Direct Cable Connection games hosted on another computer [39878] Diablo II does not start on 64bit system with more than 2GB VRAM cards [39908] SuperTux 0.3.5a crashes on startup, needs msvcr120.dll.strtof [40021] IDEA v1.7 fails to start [40053] Romance of the Three Kingdoms 13 (三國志13) fails to start [40083] Heroes of the Storm Freezes/Crashes after its recent updates [40129] MSI Reading and Writing Behaves differently than Windows [40147] Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:827 on starting Skype 7.18.0.112 [40201] EccoPro only works on Wine 1.6.2 [40204] Steam client fails to start with UmePlus font installed, when running in dwrite mode [40222] IMalloc(Spy)::Free nullptr ---------------------------------------------------------------- Changes since 1.8.1: Alex Henrie (1): ntdll: Finish serial reads of size 0 immediately. Alexandre Julliard (3): make_unicode: Fix typo in Indic syllable table generation. server: Implement serial port read interval timeouts. advapi32: Fix null termination in RegQueryInfoKeyA. Alistair Leslie-Hughes (7): user32: Don't crash in DrawTextEx when tab length is zero. olepro32: Add typelib resource. include: Add GdipGetPenTransform, GdipSetPenTransform declarations. gdiplus/tests: Add Pen Transform tests. gdiplus: Implement GdipGetPenTransform. gdiplus: Implement GdipSetPenTransform. gdiplus: Implement GdipResetPenTransform. Andrew Eikum (5): oleaut32: Don't clear BSTR size. mciqtz: Implement MCI_RESUME. xaudio2: Handle openal source allocation failure. winepulse.drv: Check that the server connection actually succeeded. ntdll: Implement SystemLogicalProcessorInformationEx. André Hentschel (2): winemaker: Markup fixes in German translation. ntdll: Set TPIDRURW also on ARMv8-A. Anton Baskanov (1): quartz: Set the result to 1.0 in FilterGraph::GetRate. Aric Stewart (1): winejoystick.drv: Initialize unhandled dwPOV to JOY_POVCENTERED. Austin English (1): kernel32: Add GetConsoleScreenBufferInfoEx/SetConsoleScreenBufferInfoEx stubs. Bernhard Übelacker (2): include: Implement todo_wine_if for usage in wine tests. msvcr120: Implement strtof and _strtof_l. Charles Davis (3): winex11.drv: Actually query the swap method attribute. dwrite: Fix typos, and fix definition of Mac LangCodes for Welsh and up. configure: Check for __builtin_ms_va_list on all x86_64 platforms. Christopher Thielen (1): user32: A window may be notified with WM_CAPTURECHANGED about itself if SetCapture() is called twice. Dmitry Timoshkov (1): kernel32: CompareStringW should abort on the first nonmatching character to avoid an invalid memory access. Frédéric Delanoy (1): winemaker: Markup fixes in French translation. Hans Leidekker (2): msiexec: Fix manpage markup for repair and logging modifiers. msi: Fix the CHAR column type. Henri Verbeet (1): ntdll: Add special handling for int $0x2d exceptions. Hugh McMaster (1): reg: Remove stub output from the 'add' and 'delete' functions. Huw D. M. Davies (1): ole32: The type of the size of IMalloc'ed blocks is SIZE_T. Jacek Caban (4): ntdll: Pass SYNCHRONIZE flag in NtOpenFile and NtCreateFile calls. ntdll: Don't call NtOpenKeyEx directly from NtOpenKey. kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping. ntdll: Moved RegisterTraceGuids[AW] implementation to ntdll. Jens Reyer (2): loader: Fix macro-not-defined error from man. winemaker: Fix macro-not-defined errors from man. Józef Kucia (3): wined3d: Validate render state in wined3d_device_set_render_state(). wined3d: Limit amount of video memory for older Windows versions. wined3d: Allow to query if surface format supports gamma correction. Kira Backes (1): user32: Add MOUSEHOOKSTRUCTEX for mouse wheel support. Marcus Meissner (1): manpages: Markup fixes. Matteo Bruni (2): wined3d: Limit the number of WINED3D_MULTISAMPLE_NON_MASKABLE quality levels reported. wined3d: Add WINED3DFMT_FLAG_RENDERTARGET to WINED3DFMT_B5G5R5X1_UNORM. Michael Müller (6): msvideo.dll16: Translate 16 bit address in lparam for MCIWNDM_SETTIMEFORMATA message. include: Add definitions for Win8 pseudo handles. server: Add support for Win8 pseudo handles. advapi32/tests: Add tests for Win8 pseudo handles. kernel32: Allow to pass NULL as old protection in VirtualProtect for Win9x compatibility. user32: Preserve beginning of extra data for MDI windows. Miklós Máté (2): winex11: Add 1280x960 resolution. wined3d: Warn only once about unsupported wrap state. Nikolay Sivov (12): ole2disp: Implement SafeArrayGetDim(). ole2disp: Implement SafeArrayGetElemsize(). ole2disp: Implement SafeArrayLock()/SafeArrayUnlock(). ole2disp: Implement SafeArrayAccessData()/SafeArrayUnaccessData(). include: Fix IsBad* prototypes. ctl3d32: Claim success in Ctl3dRegister(). ole32: Ignore GetMiscStatus() returned value in OleCreate(). dwrite: Handle font data initialization failure when building collections. ntdll/tests: Some tests for NtQuerySystemInformationEx(). ntdll: Add NtQuerySystemInformationEx() stub. kernel32: Forward GetLogicalProcessorInformationEx() to ntdll. ole32: Don't call spy on IMalloc::Free(NULL). Paul Gofman (1): d3dx9: Fix D3DXIntersectTri function. Piotr Caban (5): msxml3: Update xmlNode reference count when nodes are merged in node_insert_before. msxml3: Store information about ignorrable whitespace nodes in xmlNode._private variable. msxml3: Reimplement node_get_text helper so it uses information about ignorred white space nodes. msxml3: Add support for CDATA nodes in node_get_text. msvcr110: Add _W_Gettnames implementation. Sebastian Lackner (13): vcomp/tests: Reenable architecture dependent tests. vcomp: Implement 64-bit atomic instructions. ntdll: Implement RtlInterlockedPushListSListEx and fix calling convention of RtlInterlockedPushListSList. kernel32/tests: Clean up interlocked SList tests. kernel32: Forward InterlockedPushListSList[Ex] to ntdll. cmd: Fix sharing permissions of piped output files. vmm.vxd: Fix protection flags passed to VirtualAlloc. ntdll: Mimic Windows behaviour when calling debug service. ntdll: Implement handling of int $0x2d for x86_64. ntdll/tests: Add more tests for calling int $0x2d on x86 and x86_64. ntdll/tests: Add additional tests for instruction pointer in debug service tests. ntdll/tests: Add separate tests for exception handling of int $0x3. ntdll: Fix up instruction pointer in context for EXCEPTION_BREAKPOINT on x86_64. bye michael

1 0

Re: [PATCH 1/2] d3dx10: Add D3D10CreateEffectPoolFromMemory stub
by Józef Kucia 31 Mar '16

31 Mar '16

On Tue, Mar 29, 2016 at 9:07 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > dlls/d3d10/d3d10.spec | 2 +- > dlls/d3d10/d3d10_main.c | 9 +++++++++ > dlls/d3d10_1/d3d10_1.spec | 2 +- > include/d3d10effect.h | 2 ++ The subject prefix should be "d3d10:". > +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags, > + ID3D10Device *device, ID3D10EffectPool **effectpool) > +{ Please use "effect_pool" instead of "effectpool", mainly for consistency (snake_case). > + FIXME("data %p, data_size %lu, fx_flags %#x, device %p, effectpool %p.\n", > + data, data_size, fx_flags, device, effectpool); The FIXME() message should end with "stub!" or "stub.". > + return E_NOTIMPL; > +} > + I think you can remove this additional empty line. > diff --git a/include/d3d10effect.h b/include/d3d10effect.h > index 1494894..5dafdae 100644 > --- a/include/d3d10effect.h > +++ b/include/d3d10effect.h > @@ -832,6 +832,8 @@ HRESULT WINAPI D3D10CompileEffectFromMemory(void *data, SIZE_T data_size, const > ID3D10Blob **effect, ID3D10Blob **errors); > HRESULT WINAPI D3D10CreateEffectFromMemory(void *data, SIZE_T data_size, UINT flags, > ID3D10Device *device, ID3D10EffectPool *effect_pool, ID3D10Effect **effect); > +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags, > + ID3D10Device *device, ID3D10EffectPool **effectpool); It should be "effect_pool" instead of "effectpool".

1 0

Re: [PATCH (try2)] setupapi: Fix spec entries for handle parameters
by Sebastian Lackner 31 Mar '16

31 Mar '16

On 30.03.2016 17:00, Andrew Eikum wrote: > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > > try2: Turns out there's a whole bunch more of these. I think I got > most/all of them. > > dlls/setupapi/setupapi.spec | 118 ++++++++++++++++++++++---------------------- > 1 file changed, 59 insertions(+), 59 deletions(-) Is there any specific reason why you want to change that? Using "long" for handles is usually perfectly fine and it depends on the exact implementation details if its a pointer or just an index into a handle table.

3 2

Re: [PATCH] msvcr120: Add scalbn
by Piotr Caban 31 Mar '16

31 Mar '16

On 03/31/16 08:45, Daniel Lehman wrote: @ cdecl scalbn(double long) MSVCRT__scalb It will not compile in case of i386 wine. MSVCRT__scalb is defined inside ifdef. Thanks, Piotr

1 0

Need some advice on shell32
by Mathy Vanvoorden 31 Mar '16

31 Mar '16

Hello, In an effort to get myself acquainted with the code I searched for some bugs I might be able to solve in Bugzilla. I found this one: https://bugs.winehq.org/show_bug.cgi?id=32079 Basically it says that an open file dialog in for example notepad or notepad++ doesn't show hidden files when the "Show hidden files" option is set in winecfg. I have traced this back to the fact that the ShowDotFiles option is only checked in the NT functions in ntdll, but notepad (and notepad++) use the comdlg32 open dialog which does not use those NT functions but the shell32 ones. It seems to me that the comdlg32 open dialog should check if ShowDotFiles is active and if so, to pass the SHCONTF_INCLUDEHIDDEN flag to the shell32 objects. But I might (probably?) be wrong. Can someone verify that this is the way to go before I start writing a patch? -- Met vriendelijke groeten, Best regards, Mathy Vanvoorden

3 7

Re: [PATCH 4/4] mshtml: Added IHTMLElement::outerText tests.
by Marvin 30 Mar '16

30 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21790 Your paranoid android. === wxppro (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === wvistau64 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7u (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7pro64 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w8 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w864 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w1064 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === wvistau64 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7pro64 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w864 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w1064 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1

2 1

Re: [PATCH] t2embed: Implement TTGetEmbeddingType()
by Marvin 30 Mar '16

30 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21774 Your paranoid android. === build (build) === Make failed

2 1

Re: ntoskrnl.exe: Make IoAllocateIrp not crash on negative values.
by Sebastian Lackner 29 Mar '16

29 Mar '16

On 27.03.2016 20:27, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39734 > > Changes should avoid crash in acedrv11.sys. > IoAllocateIrp is called with a stack_size of -128. > > Tested against Windows XP. > (See the test based on wine-staging "driver testing framework".) For reference, here a testbot run which confirms that the change is correct (for XP/2003): https://newtestbot.winehq.org/JobDetails.pl?Key=21722 > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c > index 36488a7..f2ccc61 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -592,15 +592,20 @@ PIRP WINAPI IoAllocateIrp( CCHAR stack_size, BOOLEAN charge_quota ) > { > SIZE_T size; > PIRP irp; > + CCHAR _stack_size = stack_size; > > TRACE( "%d, %d\n", stack_size, charge_quota ); > > - size = sizeof(IRP) + stack_size * sizeof(IO_STACK_LOCATION); > + if (_stack_size <= 0 || (_stack_size > 1 && stack_size < 8)) > + _stack_size = 8; I would suggest to use a different variable, its very easy to mix up "stack_size" and "_stack_size". You even mixed it up yourself in the if() condition above. ;) If you want, you can also simplify the condition to (stack_size < 8 && stack_size != 1). > + > + size = sizeof(IRP) + _stack_size * sizeof(IO_STACK_LOCATION); > irp = ExAllocatePool( NonPagedPool, size ); > if (irp == NULL) > return NULL; > IoInitializeIrp( irp, size, stack_size ); > - irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > + if (stack_size >= 1 && stack_size <= 8) > + irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > if (charge_quota) > irp->AllocationFlags |= IRP_LOOKASIDE_ALLOCATION; > return irp; >

2 1

Re: [PATCH] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v3).
by Henri Verbeet 29 Mar '16

29 Mar '16

On 28 March 2016 at 20:02, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v3: Add bitmap verification, use InitFromFile and other minor improvements. > Implementing InitFromFile() should be a separate patch from implementing LoadTexture(). > if (FAILED(hr = d3drm_texture_create(&object))) > return hr; > > + if (FAILED(hr = IDirect3DRMTexture_InitFromFile(&object->IDirect3DRMTexture_iface, filename))) > + { > + d3drm_texture_destroy(object); > + return hr; > + } > + > + object->d3drm = iface; > + IDirect3DRM_AddRef(iface); It would be good to back this up with tests. It would seem more natural to pass the IDirect3DRM interface to d3drm_texture_create(). If that's how it's supposed to work, you can make that change in a separate patch. > @@ -39,6 +40,9 @@ struct d3drm_texture > IDirect3DRMTexture IDirect3DRMTexture_iface; > IDirect3DRMTexture2 IDirect3DRMTexture2_iface; > IDirect3DRMTexture3 IDirect3DRMTexture3_iface; > + IDirect3DRM *d3drm; > + D3DRMIMAGE *image; > + BOOL internal_image_created; You don't really need internal_image_created, you can probably just add a destroy callback. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, > + BOOL load_upside_down) DECLSPEC_HIDDEN; > + > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) DECLSPEC_HIDDEN; These are internal helper functions now. > @@ -4109,36 +4111,94 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "Test %u: expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + > + hr = IDirect3DRMTexture_InitFromFile(texture1, filename); > + ok(hr == D3DRMERR_BADOBJECT, "Test %u: Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", i, hr); > + /* It's odd, but InitFromFile seems to AddRef IDirect3DRM even if it fails. */ So a test for the refcounts would be appropriate here. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ This is an internal helper function now and should be static. You never use "d3drm". > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors; > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; There's not reason to use signed types for any of these. > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + if (bpl * h > UINT_MAX) > + { > + return NULL; > + } This doesn't work. If "bpl * h" would be larger than UINT_MAX it would overflow before the comparison. In fact, strictly speaking things become implementation defined above INT_MAX already, since you're using signed types for "bpl" and "h". What you'd typically do is something like "if (h > UINT_MAX / bpl)". Note that the calculation of "bpl" itself can overflow as well. So you'd need something like "if (align(w, 4) > UINT_MAX / (bpp / 8))" there as well. > + if (!(colors = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*colors)))) > + { > + WARN("Not enough memory to allocate palette, returning NULL.\n"); > + return NULL; > + } > + > + > + if (!(image = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)))) > + { > + WARN("Not enough memory to allocate image struct, returning NULL.\n"); > + return NULL; > + } You probably don't need HEAP_ZERO_MEMORY for either of these. You certainly don't for "colors", and you should probably just initialise the few fields in "image" that you don't already. You also leak "colors" if the allocation for "image" fails. The indentation for the WARN is wrong. > + if (!(image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, bpl * h))) > + { > + WARN("Not enough memory to allocate image buffer, returning NULL.\n"); > + return NULL; > + } You don't need HEAP_ZERO_MEMORY here if you're going to memset() it again below. You leak "colors" and "image" on failure. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); I think 0xff is clearer than 255. The "sizeof(unsigned char)" doesn't add much. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, num_colors * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Like above, you use HEAP_ZERO_MEMORY here, but immediately memcpy() over it. You leak on error. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Leak on error. > static HRESULT WINAPI d3drm_texture1_InitFromFile(IDirect3DRMTexture *iface, const char *filename) > { > - FIXME("iface %p, filename %s stub!\n", iface, debugstr_a(filename)); > + struct d3drm_texture *object = impl_from_IDirect3DRMTexture(iface); I'd suggest "texture" instead of "object". > + if (object->d3drm) > + { > + /* InitFromFile seems to AddRef IDirect3DRM even if it fails. */ > + IDirect3DRM_AddRef(object->d3drm); > + } This is very suspicious, since you always assign "object->d3drm" after calling InitFromFile(). It's not backed up by tests either.

2 4

Re: [v7 2/7] d3dx9: Implement preshader parsing.
by Matteo Bruni 29 Mar '16

29 Mar '16

2016-03-28 9:20 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > Changes > - Changed opcode function to take double arguments and return double Good catch. > +static struct op_info pres_op_info[] = > +{ > + {0x000, "nop", 0, 0, NULL }, /* PRESHADER_OP_NOP */ > + {0x100, "mov", 1, 0, pres_mov}, /* PRESHADER_OP_MOV */ > +}; I think this can be const. > +struct d3dx_pres_ins > +{ > + enum pres_ops op; > + /* first input argument is scalar, > + scalar component is propagated */ > + BOOL scalar_op; > + unsigned int component_count; > + struct d3dx_pres_operand inputs[3]; The maximum number of input operands could use a #define. Not a huge deal though. > +static void regstore_free_tables(struct d3dx_regstore *rs) > +{ > + unsigned int i; > + > + for (i = PRES_REGTAB_FIRST; i <= PRES_REGTAB_LAST; ++i) > + { > + if (rs->tables[i]) > + HeapFree(GetProcessHeap(), 0, rs->tables[i]); > + if (rs->table_value_set[i]) > + HeapFree(GetProcessHeap(), 0, rs->table_value_set[i]); > + } > +} You don't need to check for non-NULL, HeapFree() handles NULL arguments just fine. > +static unsigned int *find_bytecode_comment(unsigned int *ptr, unsigned int fourcc) > +{ > + while ((*ptr & 0xffff) == 0xfffe) > + { > + if (*(ptr + 1) == fourcc) > + return ptr + 2; > + ptr += 1 + (*ptr >> 16); > + } > + return NULL; > +} This is probably paranoid but in theory a broken or malicious effect could send you rummaging outside of the bytecode buffer so all the offsets should be checked. I don't think it's critical in practice i.e. I'll probably sleep just fine if you decide to ignore this issue... > +static unsigned int *parse_pres_arg(unsigned int *ptr, struct d3dx_pres_operand *opr) > +{ > + static const enum pres_reg_tables reg_table[8] = > + { > + PRES_REGTAB_COUNT, PRES_REGTAB_IMMED, PRES_REGTAB_CONST, PRES_REGTAB_COUNT, > + PRES_REGTAB_OCONST, PRES_REGTAB_OBCONST, PRES_REGTAB_OICONST, PRES_REGTAB_REG Matter of taste, so feel free to ignore this, but PRES_REGTAB_REG sounds a bit vague to me. I'd go with something like PRES_REGTAB_TEMP. > + if (input_count != pres_op_info[i].input_count) > + { > + FIXME("Actual input args %u, expected %u, instruction %s.\n", input_count, > + pres_op_info[i].input_count, pres_op_info[i].mnem); > + return NULL; > + } > + for (i = 0; i < input_count; ++i) > + { > + ptr = parse_pres_arg(ptr, &ins->inputs[i]); > + if (!ptr) > + return NULL; > + } Another pretty paranoid potential check, here you could verify that input_count is < ARRAY_SIZE(ins->inputs). Of course that could only fail if we encounter some instruction with more than 3 components AND we update pres_op_info BUT we forget to update struct d3dx_pres_ins, but I don't think it would hurt to be safe... > + for (i = 0; i < pres->ins_count; ++i) > + { > + unsigned int table; > + > + for (j = 0; j < pres_op_info[pres->ins[i].op].input_count; ++j) > + { > + table = pres->ins[i].inputs[j].table; > + max_offset = get_reg_offset(table, pres->ins[i].inputs[j].offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + table = pres->ins[i].output.table; > + max_offset = get_reg_offset(table, pres->ins[i].output.offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + update_table_sizes_consts(pres->regs.table_sizes, &pres->inputs); It probably makes sense to add a small update_table_size() helper (or similar), the "same" 3 lines are repeated in the loop for the input operands, for the output operand and in update_table_sizes_consts(). > + for (i = PRES_REGTAB_IMMED + 1; i <= PRES_REGTAB_LAST; ++i) It depends on what is coming up next but maybe it would make sense to add an enum for "PRES_REGTAB_IMMED + 1" (incidentally, PRES_REGTAB_FIRST is never used in this patch series). > + { > + TRACE("table_sizes[%u] %u.\n", i, peval->pres.regs.table_sizes[i]); That trace looks a bit like a debugging leftover. > + if (FAILED(regstore_alloc_table(&peval->pres.regs, i))) > + { > + hr = E_OUTOFMEMORY; > + goto err_out; > + } > + } > + > + if (TRACE_ON(d3dx)) > + dump_bytecode(byte_code, byte_code_size); > + > + *peval_out = peval; > + TRACE("retval %u, *peval_out %p.\n", D3D_OK, *peval_out); Same with this. This one in particular doesn't seem worth keeping. > + return D3D_OK; > + > +err_out: > + FIXME("Error creating parameter evaluator.\n"); > + d3dx_free_param_eval(peval); > *peval_out = NULL; > - return E_NOTIMPL; > + TRACE("retval %u, *peval_out %p.\n", hr, *peval_out); > + return hr; > +} You could print the HRESULT in the FIXME (e.g. FIXME("Error creating parameter evaluator, returning %#x.\n", hr)). Tracing the value of *peval_out doesn't seem particularly worthwhile. > +static void d3dx_free_const_tab(struct d3dx_const_tab *ctab) > +{ > + if (ctab->inputs) > + HeapFree(GetProcessHeap(), 0, ctab->inputs); > + if (ctab->inputs_param) > + HeapFree(GetProcessHeap(), 0, ctab->inputs_param); > + if (ctab->ctab) > + ID3DXConstantTable_Release(ctab->ctab); > +} > + > +static void d3dx_free_preshader(struct d3dx_preshader *pres) > +{ > + if (pres->ins) > + HeapFree(GetProcessHeap(), 0, pres->ins); > + > + regstore_free_tables(&pres->regs); > + d3dx_free_const_tab(&pres->inputs); > } You can drop all those ifs (I think there are a few more of them in the middle of the patch I haven't specifically mentioned).

2 5

Re: [v2 PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet 29 Mar '16

29 Mar '16

On 29 March 2016 at 01:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + static D2D1_PIXEL_FORMAT invalid_formats[] = > + { > + { DXGI_FORMAT_UNKNOWN, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + { DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_UNKNOWN }, > + { DXGI_FORMAT_R8G8B8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + }; I should have noticed before, but this should be const.

2 1

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Henri Verbeet 29 Mar '16

29 Mar '16

On 28 March 2016 at 23:03, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + hr = IDirect3DDevice7_GetDirect3D(device, &d3d); > + ok(SUCCEEDED(hr), "Failed to get d3d interface, hr %#x.\n", hr); I suppose this is borrowed from test_shademode() where it's used to create the vertex buffers, but you're not using "d3d" anywhere here.

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.
by Piotr Caban 29 Mar '16

29 Mar '16

Hi YongHao, On 03/18/16 17:24, YongHao Hu wrote: > dlls/msvcr120/tests/msvcr120.c | 300 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 300 insertions(+) I don't think this is a good approach for adding tests of critical_section class. Executing tons of enter/leave calls is not really testing much. Your test_critical_section_lock tests will probably pass if you comment all critical section related calls out (it passed on my computer in 10 consecutive runs, never failed, probably it's because the code was optimized during compilation). Testing 5s/6s timeouts is also not a good idea. Because of it the tests are running much longer. It would be much better if you test following things: - just check some basic functionality of enter/leave: enter cs in main thread, start new thread that tries to enter it as well, wait for 100ms and check that it was not able to enter the cs, then leave cs in main thread and wait for thread to enter cs and finish - check some basic functionality of try_lock: use it to lock the cs, check if it fails on locked cs Also the tests failed on testbot, I was not checking why. Thanks, Piotr

3 3

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21748 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet 28 Mar '16

28 Mar '16

On 28 March 2016 at 22:18, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + hr = ID2D1Factory_CreateDCRenderTarget(factory, &desc, &rt); > + todo_wine > + ok(hr == D2DERR_UNSUPPORTED_PIXEL_FORMAT, "Failed to create target, hr %#x.\n", hr); ... > + hr = ID2D1DCRenderTarget_EndDraw(rt, NULL, NULL); > + ok(hr == D2DERR_WRONG_STATE, "EndDraw() failed, hr %#x.\n", hr); Those messages are a bit misleading. (For what it's worth, we usually use "Got unexpected hr %#x.\n" for those.)

1 0

Re: [PATCH] d2d1: Added a stub implementation for ID2D1DCRenderTarget
by Nikolay Sivov 28 Mar '16

28 Mar '16

Please ignore this one for now.

1 0

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v2).
by Henri Verbeet 28 Mar '16

28 Mar '16

On 20 March 2016 at 19:24, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p\n", iface, debugstr_a(filename), texture); Missing period. > @@ -853,15 +859,19 @@ static HRESULT WINAPI d3drm2_CreateUserVisual(IDirect3DRM2 *iface, > static HRESULT WINAPI d3drm2_LoadTexture(IDirect3DRM2 *iface, > const char *filename, IDirect3DRMTexture2 **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p.\n", iface, debugstr_a(filename), texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = IDirect3DRM3_LoadTexture(&d3drm->IDirect3DRM3_iface, filename, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture2_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, &IID_IDirect3DRMTexture2, (void**)texture); > + IDirect3DRMTexture3_Release(texture3); > + if (FAILED(hr)) > + return hr; > > return D3DRM_OK; > } This is probably ok, but you may want to consider just introducing a helper function instead. I.e.: if (FAILED(hr = d3drm_load_texture(d3drm, filename, TRUE, &object))) return hr; IDirect3DRMTexture2_AddRef(*texture = &object->IDirect3DRMTexture2_iface); return D3DRM_OK; What happens when d3drm_texture_load() is called multiple times on the same texture? Should that be possible? > +void d3drm_texture_destroy(struct d3drm_texture *texture); Missing DECLSPEC_HIDDEN. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) DECLSPEC_HIDDEN; This line is a bit long. Try to stick to 120 columns as a maximum, preferably a bit less. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down); Missing DECLSPEC_HIDDEN. > @@ -4103,24 +4105,34 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", ref1, ref2); The message should mention which test (i.e., "i") failed. > d3drm_img = IDirect3DRMTexture_GetImage(texture1); > - todo_wine ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > + ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > if (d3drm_img) > test_bitmap_data(i * 4, d3drm_img, FALSE, tests[i].w, tests[i].h, tests[i].palettized); Now that IDirect3DRMTexture_GetImage() succeeds, you can remove the "if (d3drm_img)". > +void d3drm_texture_destroy(struct d3drm_texture *texture) > +{ > + if (texture->image) > + { > + TRACE("Releasing attached members.\n"); > + HeapFree(GetProcessHeap(), 0, texture->image->buffer1); > + if(texture->image->palette) Missing space between "if" and "(". > + HeapFree(GetProcessHeap(), 0, texture->image->palette); > + HeapFree(GetProcessHeap(), 0, texture->image); This seems a bit suspicious. Supposedly the "image" argument to d3drm3_CreateTexture() can be used to create a texture on an existing image. The documentation isn't very explicit about it, but suggests that the image data isn't copied in that case. So I'm not sure the texture is supposed to be responsible for destroying the image. In general I think it's not entirely clear how things like CreateTexture(), LoadTexture() and InitFromFile() etc. are supposed to interact. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ > + BITMAPINFO *info; > + BITMAPFILEHEADER *bmp_header; > + unsigned char *buffer; > + DWORD size; > + HANDLE hfile, hmapping; > + > + hfile = CreateFileA(path, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if (hfile == INVALID_HANDLE_VALUE) > + return D3DRMERR_BADFILE; > + > + size = GetFileSize(hfile, NULL); > + if (size == INVALID_FILE_SIZE) > + { > + DeleteObject(hfile); > + return D3DRMERR_BADVALUE; > + } You never use "size" after this, but you probably should. I also think you meant CloseHandle() instead of DeleteObject(). > + buffer = MapViewOfFile(hmapping, FILE_MAP_READ, 0, 0, 0); > + if (buffer == NULL) "if (!buffer)", or even "if (!(buffer = MapViewOfFile(...)))" > + bmp_header = (BITMAPFILEHEADER *)buffer; > + info = (BITMAPINFO *) (buffer + sizeof(*bmp_header)); Or just "info = (BITMAPINFO *)bmp_header + 1;". You should validate that this is actually a BMP file. You should also check which version of the BITMAPINFOHEADER structure the file has. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors = (D3DRMPALETTEENTRY *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 257 * sizeof(*colors)); Is "257" there intentional? The cast is unnecessary. HeapAlloc() can fail. Do you need HEAP_ZERO_MEMORY here? > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + image = (D3DRMIMAGE *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)); > + image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(unsigned char) * bpl * h); This is unsafe. Consider e.g. what happens when the header gives you 0x10000 for width and height. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); You just initialised the memory with HEAP_ZERO_MEMORY, and now you're overwriting it again. At least one of these two initialisations is unnecessary, and quite possibly both of them.

3 21

Re: [PATCH 10/10] jscript: Find Function.arguments on the stack instead of storing it in FunctionInstance object.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21743 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

RE: regedit: Display REG_DWORD_BIG_ENDIAN values
by Hugh McMaster 28 Mar '16

28 Mar '16

On Monday, March 28 2016, 21:05 UTC+11, Nikolay Sivov wrote: >On 28.03.2016 12:52, Hugh McMaster wrote: >> Signed-off-by: Hugh McMaster >> --- >> programs/regedit/listview.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c >> index c0119ff..5b1bd80 100644 >> --- a/programs/regedit/listview.c >> +++ b/programs/regedit/listview.c >> @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, >> ListView_SetItemTextW(hwndLV, index, 2, buf); >> } >> break; >> + case REG_DWORD_BIG_ENDIAN: { >> + DWORD i, value = 0; >> + BYTE *data = ValBuf; >> + WCHAR buf[64]; >> + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; >> + for (i = 0; i < dwCount; i++) { >> + value <<= 8; >> + value |= data[i]; >> + } >> + sprintfW(buf, fmt, value, value); >> + ListView_SetItemTextW(hwndLV, index, 2, buf); >> + } >> + break; >> case REG_BINARY: { >> unsigned int i; >> LPBYTE pData = ValBuf; >> >dwCount is always 1 in this case, dwCount is 4 for REG_DWORD and REG_DWORD_BIG_ENDIAN. >so it could be simplified to the point of swapping 'value' and >falling through to REG_DWORD case. I didn't check tests, but >you sure you need to modify what RegQueryValueExW() returns? On Windows, regedit displays the REG_DWORD type in little endian order and the REG_DWORD_BIG_ENDIAN type in big endian order. But both "reg query" and RegQueryValueEx() return any type of DWORD in little endian order. While it is true that there is common code in REG_DWORD and the BIG_ENDIAN case, I'm not sure there is a clean way to handle the endianness without checking for and handling the value type a second time.

1 0

[GSoC] Mailinglist discussions
by André Hentschel 28 Mar '16

28 Mar '16

Hi, This year it's not possible to communicate with the GSoC Students over the GSoC-Project site. I guess the reason is to force communication with the community. Thus I suggest to move the discussions to wine-devel and prefix them with [GSoC] Thx

3 2

Re: msvcirt: Avoid superfluous comparison in some compilers
by Henri Verbeet 28 Mar '16

28 Mar '16

On 27 March 2016 at 13:57, Iván Matellanes <matellanesivan(a)gmail.com> wrote: > - if (dir < SEEKDIR_beg || dir > SEEKDIR_end || !(mode & (OPENMODE_in|OPENMODE_out))) > + if ((dir != SEEKDIR_beg && dir != SEEKDIR_cur && dir != SEEKDIR_end) || !(mode & (OPENMODE_in|OPENMODE_out))) I'm not sure you're really making it better by adding another comparison. One alternative you may want to consider is just "(unsigned int)dir > SEEKDIR_end".

2 1

Re: regedit: Display REG_DWORD_BIG_ENDIAN values
by Nikolay Sivov 28 Mar '16

28 Mar '16

On 28.03.2016 12:52, Hugh McMaster wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/listview.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c > index c0119ff..5b1bd80 100644 > --- a/programs/regedit/listview.c > +++ b/programs/regedit/listview.c > @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, > ListView_SetItemTextW(hwndLV, index, 2, buf); > } > break; > + case REG_DWORD_BIG_ENDIAN: { > + DWORD i, value = 0; > + BYTE *data = ValBuf; > + WCHAR buf[64]; > + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; > + for (i = 0; i < dwCount; i++) { > + value <<= 8; > + value |= data[i]; > + } > + sprintfW(buf, fmt, value, value); > + ListView_SetItemTextW(hwndLV, index, 2, buf); > + } > + break; > case REG_BINARY: { > unsigned int i; > LPBYTE pData = ValBuf; > dwCount is always 1 in this case, so it could be simplified to the point of swapping 'value' and falling through to REG_DWORD case. I didn't check tests, but you sure you need to modify what RegQueryValueExW() returns?

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21718 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21717 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21714 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w1064 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w1064 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21712 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21705 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21704 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: Assorted spelling fixes.
by Marvin 28 Mar '16

28 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21702 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

[GSoC] Support of pluggable theming engines
by André Hentschel 28 Mar '16

28 Mar '16

Hi Ivan, all, You say in your proposal that you want to start with rewriting 30% of comctl32. Why so much? Is it currently needed for the gtk3 code in wine-staging?

4 11

Re: [v6 1/7] d3dx9: Introduce preshaders in effect.
by Matteo Bruni 27 Mar '16

27 Mar '16

2016-03-23 18:02 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: Sorry, I thought about this only now: > @@ -5569,7 +5579,15 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > param->referenced_param = get_parameter_by_name(base, NULL, object->data); > if (param->referenced_param) > { > - TRACE("Mapping to parameter %p.\n", param->referenced_param); > + struct d3dx_parameter *refpar = param->referenced_param; > + > + TRACE("Mapping to parameter %p, having object id %u.\n", refpar, refpar->object_id); > + if (refpar->type == D3DXPT_VERTEXSHADER || refpar->type == D3DXPT_PIXELSHADER) > + { > + struct d3dx_object *refobj = &base->objects[refpar->object_id]; > + > + d3dx_create_param_eval(base, refobj->data, refobj->size, refpar->type, &refpar->param_eval); > + } If a parameter is referenced multiple times in an effect this probably allocates the param_eval structure more than once, leaking all but the last copy (well, it depends on the implementation of d3dx_create_param_eval(), but it should be the case here). I haven't tested that directly but I have tested that two references to the vs_arr array seem to lead to a similar issue WRT the array elements (i.e. the vertex shaders).

2 3

Re: d3d8: Unlock already unlocked surface does not fail
by Stefan Dösinger 27 Mar '16

27 Mar '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-03-27 um 13:05 schrieb David Adam: > Signed-off-by: David Adam <david.adam.cnrs(a)gmail.com> > --- > dlls/d3d8/surface.c | 9 ++++----- > dlls/d3d8/tests/visual.c | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3d8/surface.c b/dlls/d3d8/surface.c > index 565f642..376bc6f 100644 > --- a/dlls/d3d8/surface.c > +++ b/dlls/d3d8/surface.c > @@ -271,11 +271,10 @@ static HRESULT WINAPI d3d8_surface_UnlockRect(IDirect3DSurface8 *iface) > hr = wined3d_resource_unmap(wined3d_texture_get_resource(surface->wined3d_texture), surface->sub_resource_idx); > wined3d_mutex_unlock(); > > - switch(hr) > - { > - case WINEDDERR_NOTLOCKED: return D3DERR_INVALIDCALL; > - default: return hr; > - } > + if (hr == WINEDDERR_NOTLOCKED) > + return D3D_OK; I suspect that similarly to lock validation the behavior of double unlocks depends on the resource type (surface vs texture). > @@ -178,6 +178,8 @@ static D3DCOLOR get_surface_color(IDirect3DSurface8 *surface, UINT x, UINT y) > > hr = IDirect3DSurface8_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr=%#x.\n", hr); > + hr = IDirect3DSurface8_UnlockRect(surface); > + ok(SUCCEEDED(hr), "Failed to double unlock surface, hr=%#x.\n", hr); We have test_surface_double_unlock() in device.c and test_lockrect_invalid(). The test fits there better than sprinkled all around visual.c. (I have a preference for merging test_surface_double_unlock into test_lockrect_invalid, but I haven't looked closely how well that'll work) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW+AcxAAoJEN0/YqbEcdMwSYMP/ifDlI7N/z6QcEL6lRo9WsDr C+WfvTA6R4SRY+Wc/rWihX821b1mApv+kk9CSnZDSV96tpXKikjQdsMM5pB91oDW PDXxNkuoGpo1AR6gS5rve3fWc3vgRXSy7XzPLXAOlL6PF/lxbDcD/jixj8PjI6NZ Oel1ukbYuAr8dINKS8oB4tTZg59Pq/devXepJNlxxzfg11lgnoiF2kBYAlKZp+qC e59bWeZMixzB7ChzSUpAxlpjd+yipdtnVLKrq2codNYZn2Z+tV959MAZO+YYB35I BtHoSFNF16omLJ6qu9ZDZISOesep4YAlHyicERkZKR6kikaGI1/ezkxZtzD9zREn EDK5L+Trhar+XW/WgEYwJtIk9PAkJgLU53W5hgoq9TeDguMEtszvFj2GTStGEVnd M+dNN/4DQNg1aqCj1yRoom7N7WCVExWxdw9PlgqOFW68EjlNxZM2uO8S5pTNKx95 cBfxLYCI+agYj/aw3xOL3/yzNe4tI/pp+thsDlTqQZaXXTb3/S+ilChGEED9pQOz rHRQCP8yTsV9YtjWa2F+a/uSYP/LkZ9qFMkVzV9/nRw9GxpD0s2F7RdZVqhdW+VY eXW/YSDN+Mm8YF7MkWCKCeodDHL/VVqlDiEx8e+XQ96uELoiV2WP/GiVCwtjVMmb 9fib0jMQDGufm0Txe57H =pNWk -----END PGP SIGNATURE-----

1 0

Re: [1/3] user32/tests: Test loading monochrome icons.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21687 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0.

2 1

Re: [3/3] user32: Correctly determine bit count for BITMAPCOREINFO in is_dib_monochrome.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21689 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: [2/3] user32: Handle BITMAPCOREINFO when loading icons.
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21688 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: d3d8: Unlock already unlocked surface does not fail
by Marvin 27 Mar '16

27 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21685 Your paranoid android. === w8 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w864 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w1064 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c.

1 0

Re: [PATCH] winex11: Don't put a default icon on modal dialogs.
by Alexandre Julliard 26 Mar '16

26 Mar '16

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -611,7 +612,7 @@ static void fetch_icon_data( HWND hwnd, HICON icon_big, HICON icon_small ) > if (!icon_small) icon_small = (HICON)GetClassLongPtrW( hwnd, GCLP_HICONSM ); > } > > - if (!GetIconInfo(icon_big, &ii)) return; > + if (!GetIconInfo(icon_small, &ii) && !GetIconInfo(icon_big, &ii)) return; This doesn't make sense. What are you trying to do? -- Alexandre Julliard julliard(a)winehq.org

2 5

[GSOC] Implement rendering for Direct3D Retained Mode
by Aaryaman Vasishta 26 Mar '16

26 Mar '16

Hi, I have applied to GSoC this year, and I'm intending to continue my work on d3drm over this summer. Please review the proposal and provide feedback/comments, it would be very appreciated :) Cheers, Aaryaman

1 1

Re: [PATCH 1/3] msvcrt: Call C structured exception translator in x86_64 __CxxFrameHandler
by Piotr Caban 26 Mar '16

26 Mar '16

Please ignore this patches for now, they are too buggy. It was working quite well in my tests but crashes with most real applications. Looks like local unwinding is implemented incorrectly. Thanks, Piotr

1 0

Re: [PATCH 5/5] d3d9/tests: Add a test for color varyings clamping.
by Marvin 25 Mar '16

25 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21679 Your paranoid android. === w8 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1.

1 0

Re: Need some advice on shell32
by Mathy Vanvoorden 25 Mar '16

25 Mar '16

2016-03-25 16:15 GMT+01:00 Vincent Povirk <madewokherd(a)gmail.com>: > You didn't copy the list. Was that intentional? > Sorry, it was not, I recently switched to gmail and didn't notice the mailinglist fell off the CC list. > Related: While doing the research I came across some people trying to find > > out if the user is showing hidden files and there are some references to > > checking > Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\Hidden, > > would it not make sense to store the setting there in the same way > instead > > of the wine config? I'm not sure what the policy on this is. > > I'd consider "Are dotfiles hidden files?" and "Should shell views > display hidden files?" two distinct questions that should have > distinct settings. > I agree, they are.

1 0

Question about wine XWindow to HWND mapping
by Brandon Adkins 25 Mar '16

25 Mar '16

Hi guys. I am working on porting a Windows application over to Linux, and my hope is to use Wine to make that go as quickly as possible. In my research, I have found one possible hangup, and hopefully you guys can answer it in a few minutes, vs the week or so of work for me to test it out myself. Long story short, I have an application which creates child HWNDs. The application also launches separate processes. When WM_PAINT messages come in for those child HWNDs, it passes the HWND to one of the other processes, and that other process is the one that actually draws on it. This works great on Windows. But I have found out that Wine only makes XWindows for top level HWNDs. So my question is: Can an application in wine perform operations (like drawing, BitBlting) onto a child HWND owned by another process? Any tips or guidance you can give will be greatly appreciated. Best regards!

2 2

Re: [PATCH] riched20: Implement ITextRange::ScrollIntoView.
by Huw Davies 24 Mar '16

24 Mar '16

On Fri, Mar 18, 2016 at 11:59:52AM -0700, Adam Buchbinder wrote: > diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c > index 7c6c5d5..de3c7a0 100644 > --- a/dlls/riched20/tests/richole.c > +++ b/dlls/riched20/tests/richole.c > @@ -53,6 +53,7 @@ static HWND new_window(LPCSTR lpClassName, DWORD dwStyle, HWND parent) > HWND hwnd = CreateWindowA(lpClassName, NULL, > dwStyle | WS_POPUP | WS_HSCROLL | WS_VSCROLL | WS_VISIBLE, > 0, 0, 200, 60, parent, NULL, hmoduleRichEdit, NULL); > + ok(hwnd != NULL, "class: %s, error: %d\n", lpClassName, (int) GetLastError()); > return hwnd; > } > > @@ -761,6 +762,66 @@ static void test_ITextRange_GetChar(void) > ITextRange_Release(txtRge); > } > > +/* Helper function for testing ITextRange_ScrollIntoView */ > +static void check_range(HWND w, ITextDocument* doc, int first, int lim, > + LONG bStart, int expected_nonzero) { Please put the opening brace on a new line. More importantly, I get a test failure: richole.c:785: Test failed: Moved scrollbar is at 60, should be 0. (Range 0-160.) Huw.

2 3

Re: [PATCH] wined3d: Support D3DFMT_L8 format as render target when supported by GPU.
by Henri Verbeet 24 Mar '16

24 Mar '16

On 23 March 2016 at 09:56, Paul Gofman <gofmanp(a)gmail.com> wrote: > Tested on Intel HD 4000 (L8 rt is not supported) and NVIDIA GeForce 650M > (L8 rt supported). Changes in query_internal_format are for avoiding > ERR in output when format is not supported as render target (RENDERTARGET > flag is cleared in check_fbo_compat which is called later). Is this needed by an application? Luminance formats aren't supposed to be color-renderable according to the OpenGL spec, and that's why you're getting GL_INVALID_ENUM in query_internal_format(). Does NVIDIA have some extension that allows this? > @@ -11279,6 +11279,7 @@ static void pixelshader_blending_test(void) > {"D3DFMT_R32F", D3DFMT_R32F, 0x0018ffff, 0x0020ffff}, > {"D3DFMT_G32R32F", D3DFMT_G32R32F, 0x001818ff, 0x002010ff}, > {"D3DFMT_A32B32G32R32F", D3DFMT_A32B32G32R32F, 0x00181800, 0x00201000}, > + {"D3DFMT_L8", D3DFMT_L8, 0x00181818, 0x002010ff}, The 0x002010ff there doesn't look right. It's also not exactly ideal that the red and green channels end up with the same values after blending, although that's and existing issue with the test.

3 7

Re: jscript: Added a few more arguments tests.
by Sebastian Lackner 24 Mar '16

24 Mar '16

On 24.03.2016 16:39, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/jscript/tests/lang.js | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Was it intentional that the newly added function is never called?

2 1

Re: jscript: Added a few more arguments tests.
by Marvin 24 Mar '16

24 Mar '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21665 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [v3] bcrypt: Added BCryptHash function.
by Patrick Armstrong 24 Mar '16

24 Mar '16

Thanks for all the help with the reviews! > On Mar 24, 2016, at 2:53 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > > > >

1 0

Possible security bug with unmount
by Cédric Picard 24 Mar '16

24 Mar '16

Hi, I find that DIR_unmount_device in wine/dlls/ntdll/directory.c (latest git) is looking like an unsafe use of system(). If a device was mounted to a point such as ";ls" I think it would be passed to system and cause a command injection. I didn't open a bug because I wasn't able to really test it due to my lack of knowledge of wine and because I can't think of a real world attack based on this as it needs to mount a device first but I think it's worth at least a thorough check. Cédric Picard

5 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel