- wine-devel - winehq.org

Re: winmm: Clear adwInfo when the struct MMIOINFO is initialized by MMIO_Open
by Andrew Eikum 25 Oct '15

25 Oct '15

This looks OK to me. What do you think about zeroing the whole structure instead of just some of the fields, just to prevent this problem happening again in the future? In either case, Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> On Fri, Oct 23, 2015 at 06:24:02PM +0800, Bruno Jesus wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > > The program from bug 35872 registers an IO handler that test adwInfo > and crashes because when MMIO_Open is called these values have > garbage. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=35872 > diff --git a/dlls/winmm/mmio.c b/dlls/winmm/mmio.c > index ad73564..03cadd5 100644 > --- a/dlls/winmm/mmio.c > +++ b/dlls/winmm/mmio.c > @@ -596,6 +596,7 @@ static HMMIO MMIO_Open(LPSTR szFileName, MMIOINFO* refmminfo, DWORD dwOpenFlags, > mmioinfo.pIOProc = NULL; > mmioinfo.pchBuffer = NULL; > mmioinfo.cchBuffer = 0; > + memset(mmioinfo.adwInfo, 0, sizeof(mmioinfo.adwInfo)); > is_unicode = FALSE; > } > > diff --git a/dlls/winmm/tests/mmio.c b/dlls/winmm/tests/mmio.c > index fd5433c..48367ee 100644 > --- a/dlls/winmm/tests/mmio.c > +++ b/dlls/winmm/tests/mmio.c > @@ -599,12 +599,15 @@ static void test_mmioSetBuffer(char *fname) > static LRESULT CALLBACK mmio_test_IOProc(LPSTR lpMMIOInfo, UINT uMessage, LPARAM lParam1, LPARAM lParam2) > { > LPMMIOINFO lpInfo = (LPMMIOINFO) lpMMIOInfo; > + int i; > > switch (uMessage) > { > case MMIOM_OPEN: > if (lpInfo->fccIOProc == FOURCC_DOS) > lpInfo->fccIOProc = mmioFOURCC('F', 'A', 'I', 'L'); > + for (i = 0; i < sizeof(lpInfo->adwInfo) / sizeof(*lpInfo->adwInfo); i++) > + ok(lpInfo->adwInfo[i] == 0, "[%d] Expected 0, got %u\n", i, lpInfo->adwInfo[i]); > return MMSYSERR_NOERROR; > case MMIOM_CLOSE: > return MMSYSERR_NOERROR; > @@ -642,6 +645,18 @@ static void test_mmioOpen_fourcc(void) > mmio.lDiskOffset); > mmioClose(hmmio, 0); > > + /* Same test with NULL info */ > + memset(&mmio, 0, sizeof(mmio)); > + hmmio = mmioOpenA(fname, NULL, MMIO_READ); > + mmioGetInfo(hmmio, &mmio, 0); > + ok(hmmio && mmio.fccIOProc == FOURCC_XYZ, "mmioOpenA error %u, got %4.4s\n", > + mmio.wErrorRet, (LPCSTR)&mmio.fccIOProc); > + ok(mmio.adwInfo[1] == 0, "mmioOpenA sent MMIOM_SEEK, got %d\n", > + mmio.adwInfo[1]); > + ok(mmio.lDiskOffset == 0, "mmioOpenA updated lDiskOffset, got %d\n", > + mmio.lDiskOffset); > + mmioClose(hmmio, 0); > + > mmioInstallIOProcA(FOURCC_XYZ, NULL, MMIO_REMOVEPROC); > > memset(&mmio, 0, sizeof(mmio)); >

2 1

Videos or Slides from WineConf
by Joel Holdsworth 25 Oct '15

25 Oct '15

Hi, are there any plans to publish videos or slides from wineconf? Joel

11 15

Re: [PATCH v2] user32: Added a GetDisplayConfigBufferSizes stub
by Marvin 24 Oct '15

24 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17611 Your paranoid android. === w1064 (32 bit monitor) === monitor.c:248: Test failed: Unexpected ChangeDisplaySettingsEx() return code for resolution[0]: -2 monitor.c:248: Test failed: Unexpected ChangeDisplaySettingsEx() return code for resolution[1]: -2 monitor.c:248: Test failed: Unexpected ChangeDisplaySettingsEx() return code for resolution[2]: -2 monitor.c:248: Test failed: Unexpected ChangeDisplaySettingsEx() return code for resolution[3]: -2

2 1

Re: d3d11: Make impl_from_ID3D11ShaderResourceView() static.
by Józef Kucia 24 Oct '15

24 Oct '15

Hi Francois, On Sat, Oct 24, 2015 at 4:05 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/d3d11/view.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3d11/view.c b/dlls/d3d11/view.c > index 91f9265..a62c2de 100644 > --- a/dlls/d3d11/view.c > +++ b/dlls/d3d11/view.c > @@ -1189,7 +1189,7 @@ struct d3d_rendertarget_view *unsafe_impl_from_ID3D10RenderTargetView(ID3D10Rend > > /* ID3D11ShaderResourceView methods */ > > -struct d3d_shader_resource_view *impl_from_ID3D11ShaderResourceView(ID3D11ShaderResourceView *iface) > +static struct d3d_shader_resource_view *impl_from_ID3D11ShaderResourceView(ID3D11ShaderResourceView *iface) It should actually be "static inline". Thanks!

1 0

Wine-git no longer compiles
by Bruno Jesus 23 Oct '15

23 Oct '15

Hi all, I just pulled today's git and wine no longer compiles: bruno@Note:~/programs/wine32$ make make: *** No rule to make target '../wine/Make.vars.in', needed by 'Makefile'. I can see some Makefile changes from Alexandre so probably related, am I the only affected? I'm compiling out of tree and I didn't try make clean yet because rebuilding the whole wine takes a lot of time (over 2 hours). Best wishes, Bruno

3 4

Wine Staging patch submission
by Michael Müller 23 Oct '15

23 Oct '15

Dear Wine developers, a lot of changes regarding the integration of Wine Staging have already been realized, but there are also some tasks left. In this email I would like to talk about the ways on how to submit patches that should be integrated into the staging tree. So far most patch submissions were done through our Wine Staging bug tracker, but now we would like to move the patch submission to WineHQ. We had the choice between using a mailing list or using the upstream bug tracker. For the usual development progress a mailing list is perfectly fine, however patches submitted to Wine Staging are usually either complex, or need more work. Often multiple revisions are required, and we think that its much easier to keep track of the progress of a patchset, when all information is collected in one place. Also, it is much easier to use the existing bug tracker than writing tools for a separate staging patch overview page. ;-) * How does it work? We want to add a new component "patches" into the Staging product in the WineHQ bug tracker. If you want so submit a patch, you can then create a new bug report and add your patch as attachment. In case of a patch series, you can either put them into a tar archive, or add several attachments. You can sign-off your patch if you want to indicate that it would be ready for integration into the development branch, and just needs some more testing. Other developers are of course invited to give feedback on those patches, too. If the patch gets accepted, the status changes to FIXED. If the patch fixes a bug and there is no open bug report for this problem yet, we might also change the status to STAGED and move it to the appropriate upstream category. * Which patches should be sent to Staging? Normal patches should be sent to wine-patches. If Alexandre or a reviewer decides that the patch is dangerous or not good enough, they would tell you to try to get it into Staging first. Someone of the Wine Staging team will then be assigned as reviewer, and provide additional feedback / instructions how to proceed. If the patch just needs some additional testing, we will directly add it to Wine Staging. Otherwise we will ask you to create a bug report, where the patch can be improved iteratively. If you already know that your patch is very experimental, you can skip the first step and directly create a bug report as described above. * What happens after my patch got into Staging? This depends a bit on the reason why your patch was added, but usually one or more of the following things will happen: * you continue working on the patch and send us an updated version * someone else improves the patch (list all authors, for example by signing off the modified patch) * we remove / replace your patch if it turns out to be wrong or if we find a better solution * we (or you) send the patch to wine-patches if we think it is ready Although there are quite a few people testing git versions of Wine Staging, it sometimes makes sense to wait till the patch was included for one release to ensure that it does not introduce any regressions. I hope this answers all your questions regarding the patch submission to Wine Staging :-) Regards, Michael

6 6

Re: [PATCH] user32: Added GetDisplayConfigBufferSizes() stub
by Dmitry Timoshkov 23 Oct '15

23 Oct '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +LONG WINAPI GetDisplayConfigBufferSizes(UINT32 flags, UINT32 *num_path_info, UINT32 *num_mode_info) > +{ > + FIXME("(0x%x %p %p): stub\n", flags, num_path_info, num_mode_info); > + if (num_path_info) *num_path_info = 0; > + if (num_mode_info) *num_mode_info = 0; > + return ERROR_NOT_SUPPORTED; > +} According to MSDN 2nd and 3rd parameters of this API can't be NULL. Also you should probably add a prototype to winuser.h. -- Dmitry.

2 2

Re: [2/2] ntdll: Do not check if object was signaled after user APC in server_select. (resend)
by Marvin 23 Oct '15

23 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17602 Your paranoid android. === w1064 (64 bit sync) === sync.c:1694: Test failed: SleepConditionVariableCS should still return TRUE on crit unlock delay

1 0

Re: [PATCH 2/2] ws2_32: Add support for TF_REUSE_SOCKET to TransmitFile.
by Marvin 23 Oct '15

23 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17597 Your paranoid android. === w2008s64 (32 bit sock) === sock.c:7350: Test failed: bytesReturned isn't supposed to be 1 sock.c:7374: Test failed: GetOverlappedResult failed, error 997

1 0

Re: [PATCH 1/2] ws2_32: Add support for TF_DISCONNECT to TransmitFile.
by Sebastian Lackner 23 Oct '15

23 Oct '15

On 23.10.2015 02:03, Erich E. Hoover wrote: > Now that we have TransmitFile support, there are a couple important > flags that are frequently used by applications utilizing this feature > (particularly in async mode). This patch adds support for the > TF_DISCONNECT flag, which closes out the socket handle once the > TransmitFile operation is complete. I would prefer a solution without NtClose from an APC callback. I have tests in the Staging tree, which show that NtClose will throw an exception for invalid handles, when a debugger is attached.

1 0

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Henri Verbeet 22 Oct '15

22 Oct '15

On 22 October 2015 at 09:00, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +static void test_create_device_swap_chain(void) You should probably just port d3d11/tests' test_create_device().

1 0

Re: quartz: Add stub IAMStreamSelect to MPEG-1 Stream Splitter. (try 2, resend)
by Nikolay Sivov 22 Oct '15

22 Oct '15

On 22.10.2015 17:35, Anton Baskanov wrote: > + if ( IsEqualIID(riid, &IID_IUnknown) > + || IsEqualIID(riid, &IID_IPersist) > + || IsEqualIID(riid, &IID_IMediaFilter) > + || IsEqualIID(riid, &IID_IBaseFilter) ) > + *ppv = iface; > + > + if ( IsEqualIID(riid, &IID_IAMStreamSelect) ) > + *ppv = &This->IAMStreamSelect_iface; This is usually done with 'else if'. > +static HRESULT WINAPI StreamSelect_QueryInterface(IAMStreamSelect *iface, REFIID riid, LPVOID *ppv) > +{ > + MPEGSplitterImpl *This = impl_from_IAMStreamSelect(iface); > + > + return IBaseFilter_QueryInterface(&This->Parser.filter.IBaseFilter_iface, riid, ppv); > +} Unfortunately we don't have a written rule for that (I think), so I guess I'm just sharing my habits: I personally try to use exact interface names for implementation functions, with leading 'I' stripped, so AMStreamSelect_* in this case. This makes it clear what's this is about, and you don't need to invent another name that doesn't exist anywhere. > +static const IAMStreamSelectVtbl StreamSelect_Vtbl = > +{ Same here, AMStreamSelectVtbl is easier imho. (quartz is not a best example in that regard) Also please, no LPVOID. > + HRESULT Count( > + [out] DWORD * pcStreams); > + > + HRESULT Info( > + [in] long lIndex, > + [out] AM_MEDIA_TYPE ** ppmt, > + [out] DWORD * pdwFlags, > + [out] LCID * plcid, > + [out] DWORD * pdwGroup, > + [out] WCHAR ** ppszName, > + [out] IUnknown ** ppObject, > + [out] IUnknown ** ppUnk); > + > + HRESULT Enable( > + [in] long lIndex, > + [in] DWORD dwFlags); You are using exact naming PSDK has, please do it in your own words, with better, cleaner names, like 'streams' or 'index', spacing in pointer notation could be fixed as well.

1 0

Re: ieframe: Capitalize some menu items‏
by Jacek Caban 22 Oct '15

22 Oct '15

Hi Jared, The patch still has NEW status, but I don't think I can sign it of myself. I'm not native speaker and I recall discussions about similar case on wine-devel in the past. I hope someone else can comment. Thanks, Jacek On 10/19/15 23:30, Jared Smudde wrote: > Signed-off-by: Jared Smudde <computerwhiz02(a)hotmail.com> > > Some of the second words on menu items are not capitalized. This looks weird as some of the other menu items are all capitalized. > > > dlls/ieframe/ieframe.rc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/dlls/ieframe/ieframe.rc b/dlls/ieframe/ieframe.rc > index aed8483..d4ccf3c 100644 > --- a/dlls/ieframe/ieframe.rc > +++ b/dlls/ieframe/ieframe.rc > @@ -32,11 +32,11 @@ IDR_BROWSE_MAIN_MENU MENU > } > MENUITEM "&Open...", ID_BROWSE_OPEN > MENUITEM "&Save", ID_BROWSE_SAVE > - MENUITEM "Save &as...", ID_BROWSE_SAVE_AS > + MENUITEM "Save &As...", ID_BROWSE_SAVE_AS > MENUITEM SEPARATOR > - MENUITEM "Print &format...", ID_BROWSE_PRINT_FORMAT > + MENUITEM "Print &Format...", ID_BROWSE_PRINT_FORMAT > MENUITEM "Pr&int...", ID_BROWSE_PRINT > - MENUITEM "Print previe&w", ID_BROWSE_PRINT_PREVIEW > + MENUITEM "Print Previe&w", ID_BROWSE_PRINT_PREVIEW > MENUITEM SEPARATOR > MENUITEM "&Properties", ID_BROWSE_PROPERTIES > MENUITEM "&Close", ID_BROWSE_QUIT > @@ -45,8 +45,8 @@ IDR_BROWSE_MAIN_MENU MENU > { > POPUP "&Toolbars" > { > - MENUITEM "&Standard bar", ID_BROWSE_BAR_STD > - MENUITEM "&Address bar", ID_BROWSE_BAR_ADDR > + MENUITEM "&Standard Bar", ID_BROWSE_BAR_STD > + MENUITEM "&Address Bar", ID_BROWSE_BAR_ADDR > } > } > POPUP "&Favorites"

3 2

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Józef Kucia 22 Oct '15

22 Oct '15

On Thu, Oct 22, 2015 at 9:00 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39278 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3d10_1/d3d10_1.spec | 2 +- > dlls/d3d10_1/d3d10_1_main.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/d3d10_1/tests/Makefile.in | 2 +- > dlls/d3d10_1/tests/d3d10_1.c | 63 +++++++++++++++++++++++++++++++++++++ > include/d3d10_1.idl | 3 ++ > 5 files changed, 139 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3d10_1/d3d10_1.spec b/dlls/d3d10_1/d3d10_1.spec > index b3d2da7..5582558 100644 > --- a/dlls/d3d10_1/d3d10_1.spec > +++ b/dlls/d3d10_1/d3d10_1.spec > @@ -3,7 +3,7 @@ > @ stub D3D10CompileShader > @ stub D3D10CreateBlob > @ stdcall D3D10CreateDevice1(ptr long ptr long long long ptr) > -@ stub D3D10CreateDeviceAndSwapChain1 > +@ stdcall D3D10CreateDeviceAndSwapChain1(ptr long ptr long long long ptr ptr ptr) > @ stdcall D3D10CreateEffectFromMemory(ptr long long ptr ptr ptr) d3d10.D3D10CreateEffectFromMemory > @ stub D3D10CreateEffectPoolFromMemory > @ stdcall D3D10CreateStateBlock(ptr ptr ptr) d3d10.D3D10CreateStateBlock > diff --git a/dlls/d3d10_1/d3d10_1_main.c b/dlls/d3d10_1/d3d10_1_main.c > index a619004..e51019c 100644 > --- a/dlls/d3d10_1/d3d10_1_main.c > +++ b/dlls/d3d10_1/d3d10_1_main.c > @@ -168,3 +168,74 @@ HRESULT WINAPI D3D10CreateDevice1(IDXGIAdapter *adapter, D3D10_DRIVER_TYPE drive > > return hr; > } > + > +HRESULT WINAPI D3D10CreateDeviceAndSwapChain1(IDXGIAdapter *adapter, D3D10_DRIVER_TYPE driver_type, > + HMODULE swrast, UINT flags, D3D10_FEATURE_LEVEL1 hw_level, UINT sdk_version, > + DXGI_SWAP_CHAIN_DESC *swapchain_desc, IDXGISwapChain **swapchain, ID3D10Device1 **device) > +{ > + IDXGIDevice *dxgi_device; > + IDXGIFactory *factory; > + HRESULT hr; > + > + TRACE("adapter %p, driver_type %s, swrast %p, flags %#x, hw_level %s, sdk_version %d, " > + "swapchain_desc %p, swapchain %p, device %p\n", > + adapter, debug_d3d10_driver_type(driver_type), swrast, flags, > + debug_d3d10_feature_level(hw_level), sdk_version, swapchain_desc, swapchain, device); > + It's generally preferred to end messages with dot in new D3D code. It also applies to WARN(), ERR(), FIXME() and ok() messages in tests. > + if(!device) > + return E_INVALIDARG; There should be a space after 'if': if (!device) Please fix this in tests as well. > + > + hr = D3D10CreateDevice1(adapter, driver_type, swrast, flags, hw_level, sdk_version, device); > + if (FAILED(hr)) > + { > + WARN("Failed to create a device, returning %#x\n", hr); > + *device = NULL; > + return hr; > + } It's generally preferred to check if function failed in a single line in new code, i.e. if (FAILED(hr = D3D10CreateDevice1(adapter, driver_type, swrast, flags, hw_level, sdk_version, device)) > + > + TRACE("Created ID3D10Device1 %p\n", *device); > + > + hr = ID3D10Device1_QueryInterface(*device, &IID_IDXGIDevice, (void **)&dxgi_device); > + if (FAILED(hr)) > + { > + ERR("Failed to get a dxgi device from the d3d10 device, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIDevice_GetAdapter(dxgi_device, &adapter); > + IDXGIDevice_Release(dxgi_device); > + if (FAILED(hr)) > + { > + ERR("Failed to get the device adapter, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIAdapter_GetParent(adapter, &IID_IDXGIFactory, (void **)&factory); > + IDXGIAdapter_Release(adapter); > + if (FAILED(hr)) > + { > + ERR("Failed to get the adapter factory, returning %#x\n", hr); > + ID3D10Device1_Release(*device); > + *device = NULL; > + return hr; > + } > + > + hr = IDXGIFactory_CreateSwapChain(factory, (IUnknown *)*device, swapchain_desc, swapchain); > + IDXGIFactory_Release(factory); > + if (FAILED(hr)) > + { > + ID3D10Device1_Release(*device); > + *device = NULL; > + > + WARN("Failed to create a swapchain, returning %#x\n", hr); > + return hr; > + } > + > + TRACE("Created IDXGISwapChain %p\n", *swapchain); > + > + return S_OK; > +} > diff --git a/dlls/d3d10_1/tests/Makefile.in b/dlls/d3d10_1/tests/Makefile.in > index f6f17bd..256bb40 100644 > --- a/dlls/d3d10_1/tests/Makefile.in > +++ b/dlls/d3d10_1/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = d3d10_1.dll > -IMPORTS = d3d10_1 > +IMPORTS = d3d10_1 user32 > > C_SRCS = \ > d3d10_1.c > diff --git a/dlls/d3d10_1/tests/d3d10_1.c b/dlls/d3d10_1/tests/d3d10_1.c > index 534689c..c760b0d 100644 > --- a/dlls/d3d10_1/tests/d3d10_1.c > +++ b/dlls/d3d10_1/tests/d3d10_1.c > @@ -377,8 +377,71 @@ static void test_create_blend_state(void) > ok(!refcount, "Device has %u references left.\n", refcount); > } > > +static void test_create_device_swap_chain(void) > +{ > + HRESULT hr; > + ID3D10Device1 *device; > + IDXGISwapChain *swapchain; > + DXGI_SWAP_CHAIN_DESC swapchain_desc; > + HWND window; > + > + window = CreateWindowA("d3d10_test_wc", "d3d10_test_swap", WS_OVERLAPPEDWINDOW, > + 0, 0, 640, 480, NULL, NULL, NULL, NULL); > + ok(!!window, "Failed to create a window.\n"); > + > + memset(&swapchain_desc, 0, sizeof(swapchain_desc)); > + swapchain_desc.BufferCount = 1; > + swapchain_desc.BufferDesc.Width = 640; > + swapchain_desc.BufferDesc.Height = 480; > + swapchain_desc.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; > + swapchain_desc.BufferDesc.RefreshRate.Numerator = 60; > + swapchain_desc.BufferDesc.RefreshRate.Denominator = 1; > + swapchain_desc.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT; > + swapchain_desc.SampleDesc.Count = 1; > + swapchain_desc.SampleDesc.Quality = 0; > + swapchain_desc.Windowed = TRUE; > + > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, NULL); > + ok(hr == E_INVALIDARG, "got %#x.\n", hr); > + > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, NULL, &device); > + todo_wine ok(hr == S_OK, "got %#x.\n", hr); > + if(hr == S_OK) > + ID3D10Device1_Release(device); > + > + /* swapchain_desc.OutputWindow = NULL */ > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, &device); > + todo_wine ok(hr == DXGI_ERROR_INVALID_CALL, "got %#x.\n", hr); > + > + swapchain_desc.OutputWindow = window; > + hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, D3D10_FEATURE_LEVEL_10_1, > + D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, &device); > + if(FAILED(hr)) > + { > + skip("Failed to create device.\n"); > + return; > + } You are leaking HWND. Also I am not sure why you use skip() here. > + > + IDXGISwapChain_Release(swapchain); > + ID3D10Device1_Release(device); > + > + DestroyWindow(window); > +} > + > START_TEST(d3d10_1) > { > + WNDCLASSA wc = {0}; > + > + wc.lpfnWndProc = DefWindowProcA; > + wc.lpszClassName = "d3d10_test_wc"; > + RegisterClassA(&wc); > + > test_create_shader_resource_view(); > test_create_blend_state(); > + test_create_device_swap_chain(); > + > + UnregisterClassA("d3d10_test_wc", GetModuleHandleA(NULL)); > } You don't need a new window class. Please use "static". > diff --git a/include/d3d10_1.idl b/include/d3d10_1.idl > index 4ee49c6..05d22b5 100644 > --- a/include/d3d10_1.idl > +++ b/include/d3d10_1.idl > @@ -151,3 +151,6 @@ const UINT D3D10_1_SDK_VERSION = 0x20; > > cpp_quote("HRESULT WINAPI D3D10CreateDevice1(IDXGIAdapter*,D3D10_DRIVER_TYPE,") > cpp_quote(" HMODULE,UINT,D3D10_FEATURE_LEVEL1,UINT,ID3D10Device1**);") > +cpp_quote("HRESULT WINAPI D3D10CreateDeviceAndSwapChain1(IDXGIAdapter *,") > +cpp_quote(" D3D10_DRIVER_TYPE, HMODULE, UINT, D3D10_FEATURE_LEVEL1,") > +cpp_quote(" UINT, DXGI_SWAP_CHAIN_DESC *, IDXGISwapChain **, ID3D10Device1 **);") Please avoid cpp_quote and include parameter names. See D3D11CreateDeviceAndSwapChain() in d3d11.idl. > -- > 1.9.1 > > >

1 0

Re: [PATCH 2/6] d3d11: Use CreateDXGIFactory1 to create factory in D3D11CreateDevice.
by Stefan Dösinger 22 Oct '15

22 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-22 um 01:52 schrieb Józef Kucia: > - hr = CreateDXGIFactory(&IID_IDXGIFactory, (void **)&factory); > + hr = CreateDXGIFactory1(&IID_IDXGIFactory, (void **)&factory); Shouldn't you request an IDXGIFactory1 interface now? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWKLJpAAoJEN0/YqbEcdMwEowQAI86raf6TRlQgfOeUiKzQTMr 2cUKnGqoaCVNwTWgFwX8WBusGAuOtak409h2VvQ3CHcvXBqAzS0XO6eXvXqZuKtn dihGyCGtLGTOzldCsI0k50xhQj2/9+UbkCs4YAL0muFzrlpA/i1CSi+XWb9arySc KJNjMx7wa77cbCDlWqJTrtAWK1ftHA0hWpddogxy5y16TpYq5fvBS5Nf0VkMZ28K +EFpINsnT3ed7xJbbWgDOKxb/8K8JgkB5N2PwYn3eyDAugawIeZTU6/WG1r1nFuq KbZnN/RZv1rB4Hqixl7Ic1sNWIB2zNQ0r0NsrHCVMLXe9Qq7cVnv2iMhYuXAs5Cj HdBZE5nJ2V2Tncd12m7qo8vAX+Fl+caUWYIPUlHz27IYVYZ1NFmvnZKVIuqXhJu/ 5xI1G5+ycYZ6+giWQY5WGm5YmPvc7ni/lcYu+KGOCk0xMFkz+9VmnZQ0N/LEHu9Y H/ufWYUexXmFMNyZKvZbTtXttynhVY6JxuiAuW3BACIoeaygYVNumk3n6ckfh3rF XBjoz8FbynUIf/3RUjEQukMKmwhYBJjMQvloqZMUYsptpMBYOtBww57uLZdRv8bD jFds+0vHI99uYFYhAn9ujtiBIbn2bsb0hLJvAgKNg+qRAAj1kuwhf/4mEQKvWUJT KKoUf43d/WBfnDH1/Sdz =OkwT -----END PGP SIGNATURE-----

2 1

Re: [8/8] webservices: Implement WsSetInputToBuffer.
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17568 Your paranoid android. === w7u (32 bit reader) === reader.c:1390: Test failed: wrong data L"valueest" === w864 (32 bit reader) === reader.c:1390: Test failed: wrong data L"valueP\5868P" === w1064 (32 bit reader) === reader.c:1390: Test failed: wrong data L"valuez\c5d8z\2980z\2980z\2980z\26b8z\2980z\2980z\2980z\2980z\2980z\26b8z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\2980z\26b8z\70d3\6a13\e609" === w7pro64 (64 bit reader) === reader.c:1390: Test failed: wrong data L"value]" === w864 (64 bit reader) === reader.c:1390: Test failed: wrong data L"valueU" === w1064 (64 bit reader) === reader.c:1390: Test failed: wrong data L"value0"

1 0

Re: [PATCH 08/10] wined3d: make wined3d_device_update_surface operate with wined3d_texture and sub_resource_idx
by Henri Verbeet 22 Oct '15

22 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -3774,12 +3764,25 @@ float CDECL wined3d_device_get_npatch_mode(const struct wined3d_device *device) > /* FIXME: Callers should probably use wined3d_device_update_sub_resource() > * instead. */ > HRESULT CDECL wined3d_device_update_surface(struct wined3d_device *device, > - struct wined3d_surface *src_surface, const RECT *src_rect, > - struct wined3d_surface *dst_surface, const POINT *dst_point) > + struct wined3d_texture *src_texture, unsigned int src_idx, const RECT *src_rect, > + struct wined3d_texture *dst_texture, unsigned int dst_idx, const POINT *dst_point) You should probably use wined3d_device_update_sub_resource() instead.

3 11

Re: [PATCH 06/10] d3d9: use wined3d_rendertarget_view_create instead of wined3d_rendertarget_view_create_from_surface in d3d9_surface_get_rendertarget_view
by Henri Verbeet 22 Oct '15

22 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + desc.format_id = resource_desc.format; > + desc.u.texture.level_idx = surface->sub_resource_idx; > + desc.u.texture.layer_idx = 0; This is wrong for cube texture surfaces.

2 8

Re: [3/8] webservices: Add a stub implementation of WsGetXmlAttribute.
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17566 Your paranoid android. === w7u (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueest" === w864 (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueD\5868D" === w1064 (32 bit reader) === reader.c:1329: Test failed: wrong data L"valueo\c5d8o\2980o\2980o\2980o\26b8o\2980o\2980o\2980o\2980o\2980o\26b8o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\2980o\26b8o\5ee6\5456\8e4e" === w7pro64 (64 bit reader) === reader.c:1329: Test failed: wrong data L"valueb" === w864 (64 bit reader) === reader.c:1329: Test failed: wrong data L"valueT" === w1064 (64 bit reader) === reader.c:1329: Test failed: wrong data L"value'"

1 0

Re: [PATCH 5/5] wined3d: Use the core version of the debug messages functions.
by Henri Verbeet 22 Oct '15

22 Oct '15

On 22 October 2015 at 00:21, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Fixes bug 39478. > > Do we want to introduce some additional tag for this kind of info? > In general, no. The way you search for bugs fixed by a particular commit is to search for the commit ID in bugzilla. Bug ID's aren't necessarily stable over the lifetime of the git repository, and for Wine in particular it isn't necessarily clear beforehand what bugs a patch is going to fix. I also would have preferred a (short) description of the issue in the commit message over having to look it up in bugzilla.

1 0

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Sebastian Lackner 22 Oct '15

22 Oct '15

On 21.10.2015 02:43, Hugh McMaster wrote: > + if (osvi.dwMajorVersion >= 6) /* Windows Vista or higher */ > + { > + COORD c; > + c = GetConsoleFontSize(std_output, cfi.nFont); > + todo_wine ok(cfi.dwFontSize.X == c.X, "got %d, expected %d\n", cfi.dwFontSize.X, c.X); > + todo_wine ok(cfi.dwFontSize.Y == c.Y, "got %d, expected %d\n", cfi.dwFontSize.Y, c.Y); > + } > + else > + { > + CONSOLE_SCREEN_BUFFER_INFO csbi; > + short int width, height; > + GetConsoleScreenBufferInfo(std_output, &csbi); > + width = csbi.srWindow.Right - csbi.srWindow.Left + 1; > + height = csbi.srWindow.Bottom - csbi.srWindow.Top + 1; > + ok(cfi.dwFontSize.X == width, "got %d, expected %d\n", cfi.dwFontSize.X, width); > + ok(cfi.dwFontSize.Y == height, "got %d, expected %d\n", cfi.dwFontSize.Y, height); > + } I haven't reviewed the whole patch, but wanted to point that we usually do not test or implement Windows version specific behavior, unless an application depends on it. Often only one of both is implemented, and the other version is marked as broken. If you decide to implement the pre-Vista behavior (which would make sense, because Wine still uses WinXP as default version), it seems like no wineserver changes are required at all (at least as long as font.index is always 0).

3 2

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17563 Your paranoid android. === wvistau64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7u (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w7pro64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w8 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === wvistau64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7pro64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002.

1 0

Re: [PATCH] vbscript/tests Add array out of bounds test
by Jacek Caban 22 Oct '15

22 Oct '15

Hi Alistair, On 10/20/15 10:05, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/vbscript/tests/lang.vbs | 5 +++++ > dlls/vbscript/tests/run.c | 17 ++++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) This seems more complicated than it has to be. Is there any reason you don't use parse_script_ar helper? Thanks, Jacek

2 1

Re: [PATCH 6/6] dxgi/tests: Remove test_device_interfaces().
by Marvin 22 Oct '15

22 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17561 Your paranoid android. === w1064 (32 bit device) === device.c:1141: Test failed: Got unexpected hr 0, test 16. device.c:1141: Test failed: Got unexpected hr 0x87a0001, test 39. === w1064 (64 bit device) === device.c:1195: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1195: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1141: Test failed: Got unexpected hr 0, test 39. device.c:1195: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1195: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: [PATCH] quartz: show fixme for Parser_OutputPin_QueryInterface only once
by Nikolay Sivov 21 Oct '15

21 Oct '15

On 20.10.2015 21:56, Jonas Maebe wrote: > This prevents the game Majesty Gold HD from flooding the console with > "No interface for {56a868a5-0ad4-11ce-b03a-0020af0ba770}" messages. > > Signed-off-by: Jonas Maebe <jonas.maebe(a)elis.ugent.be> > --- > dlls/quartz/parser.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c > index cd8d93d..a9384a5 100644 > --- a/dlls/quartz/parser.c > +++ b/dlls/quartz/parser.c > @@ -634,6 +634,7 @@ static HRESULT WINAPI Parser_OutputPin_BreakConnect(BaseOutputPin *This) > > static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, LPVOID * ppv) > { > + static int once = 0; > Parser_OutputPin *This = unsafe_impl_Parser_OutputPin_from_IPin(iface); > > TRACE("(%s, %p)\n", qzdebugstr_guid(riid), ppv); > @@ -654,7 +655,11 @@ static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, > return S_OK; > } > > - FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + if (!once) > + { > + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + once = 1; > + } > > return E_NOINTERFACE; > } > This is too much, because it will disable every failed QI fixme after first one. Base output pin already supports IQualityControl case, by forwarding it. So proper fix is to try to write some tests for this pin implementation to see if it's supposed to be supported, and then act from there.

2 3

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Alexandre Julliard 21 Oct '15

21 Oct '15

Michael Cronenworth <mike(a)cchtml.com> writes: > @@ -1167,8 +1173,9 @@ static void build(struct options* opts) > spawn(opts->prefix, link_args, 0); > strarray_free (link_args); > > - /* set the base address */ > - if (opts->image_base && !opts->target) > + /* set the base address with prelink if linker support is not present */ > + if (opts->image_base && !opts->target && > + try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base))) It looks OK now, but please avoid calling try_link() twice for the same check. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1
by Henri Verbeet 21 Oct '15

21 Oct '15

On 21 October 2015 at 05:25, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- > dlls/d3d10_1/d3d10_1.spec | 2 +- > dlls/d3d10_1/d3d10_1_main.c | 68 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 1 deletion(-) > Tests, please.

1 0

Re: [PATCH 1/2] kernel32/tests: Add tests for GetCurrentConsoleFont (v2)
by Marvin 21 Oct '15

21 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17535 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: fltmgr.sys: add FltInitializePushLock stub (try 4)
by Dmitry Timoshkov 21 Oct '15

21 Oct '15

Austin English <austinenglish(a)gmail.com> wrote: > +void WINAPI FltInitializePushLock( PEX_PUSH_LOCK *lock ) According to MSDN this is wrong. -- Dmitry.

1 0

ws2_32: Implement a basic synchronous TransmitFile.
by Hugh McMaster 21 Oct '15

21 Oct '15

Hi Erich, When checking another Wine component, I noticed build warnings for dlls/ws2_32/socket.c. The relevant commit is 4d081f36efefd3ccf702cacea4d20c5616cfbae1, which was your patch, so I thought I'd let you know. socket.c: In function ‘WS2_TransmitFile’: socket.c:2826:46: warning: ‘iosb.Information’ may be used uninitialized in this function [-Wmaybe-uninitialized] wsa->write.iovec[0].iov_len = iosb.Information; ^ socket.c:2808:25: note: ‘iosb.Information’ was declared here IO_STATUS_BLOCK iosb; ^ Adding iosb.Information = 0 before status = WS2_ReadFile( wsa->file, &iosb, wsa->buffer, bytes_per_send ); fixes the warning, but I have no idea if that is correct for for ws2_32. -- Hugh McMaster

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin 21 Oct '15

21 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17531 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH 1/4 v2] server: Add console font table information
by Sebastian Lackner 21 Oct '15

21 Oct '15

On 21.10.2015 02:43, Hugh McMaster wrote: > Changes since version 1: > * Removed an unintentional newline > * Simplified a few comments > > We must use the server because kernel32 does not export a function for this purpose. > The struct font_info can also be expanded to support all elements from CONSOLE_FONT_INFOEX. > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > server/console.c | 19 +++++++++++++++++++ > server/protocol.def | 7 ++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > font.index is unused, it would make more sense to add it later, when it is actually required. Also see my previous mail, where I point out that you could implement the XP-version of those functions without any wineserver changes at all.

1 0

Re: kernel32/tests: Remove unnecessary busy loop (PVS-Studio).
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17527 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: [PATCH] shell32: Implement IShellDispatch2::ShellExecute
by Huw Davies 20 Oct '15

20 Oct '15

On 20 Oct 2015, at 19:25, Andrew Eikum wrote: > -static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, BSTR file, VARIANT args, VARIANT dir, > - VARIANT op, VARIANT show) > +static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, > + BSTR file, VARIANT v_args, VARIANT v_dir, VARIANT v_op, VARIANT v_show) > { > - FIXME("(%s): stub\n", debugstr_w(file)); > - return E_NOTIMPL; > + VARIANT args_str, dir_str, op_str, show_str; > + WCHAR *args = NULL, *dir = NULL, *op = NULL; > + INT show = 0; > + HINSTANCE ret; > + > + TRACE("(%s, %s, %s, %s, %s)\n", debugstr_w(file), debugstr_variant(&v_args), > + debugstr_variant(&v_dir), debugstr_variant(&v_op), debugstr_variant(&v_show)); > + > + VariantInit(&v_args); Did you mean to args_str here? > + VariantChangeType(&args_str, &v_args, 0, VT_BSTR); > + if (V_VT(&v_args) == VT_BSTR) > + args = V_BSTR(&v_args); and also args_str here? (and similar occurrences below). Huw.

2 1

Marvin says... (was: [v2] d3d8: Adjust D3DCOLOR_ARGB to avoid shift overflow.)
by Gerald Pfeifer 20 Oct '15

20 Oct '15

On Tue, 20 Oct 2015, Marvin wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Committed". > > This means that your patch has been approved, and committed to the > main git tree. Congratulations! Sooo, this is officially cool. For casual contributors like me, this is especially nice and helpful, and it saves me time to check (git and/or mailing list archives) manually. Thank you! Gerald

1 0

Re: [PATCH 03/10] d3d9: move GetDC check to actual d3d9_surface_GetDC call
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -360,7 +379,6 @@ static const struct wined3d_parent_ops d3d9_surface_wined3d_parent_ops = > void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, > struct wined3d_surface *wined3d_surface, const struct wined3d_parent_ops **parent_ops) > { > - struct wined3d_resource_desc desc; > IDirect3DBaseTexture9 *texture; > > surface->IDirect3DSurface9_iface.lpVtbl = &d3d9_surface_vtbl; > @@ -379,23 +397,6 @@ void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_ > IDirect3DBaseTexture9_Release(texture); > } > > - wined3d_resource_get_desc(wined3d_surface_get_resource(wined3d_surface), &desc); > - switch (d3dformat_from_wined3dformat(desc.format)) > - { > - case D3DFMT_A8R8G8B8: > - case D3DFMT_X8R8G8B8: > - case D3DFMT_R5G6B5: > - case D3DFMT_X1R5G5B5: > - case D3DFMT_A1R5G5B5: > - case D3DFMT_R8G8B8: > - surface->getdc_supported = TRUE; > - break; > - > - default: > - surface->getdc_supported = FALSE; > - break; > - } > - > *parent_ops = &d3d9_surface_wined3d_parent_ops; > } I guess you're moving this to avoid wined3d_texture_get_sub_resource() in surface_init(), but you don't really need that. You can get the format from the texture, since it's the same for all sub-resources.

2 2

Re: [PATCH 02/10] d3d9: avoid using a wined3d_surface in get_desc calls inside d3d9_device_StretchRect
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + if (!(sub_resource = wined3d_texture_get_sub_resource(dst->wined3d_texture, dst->sub_resource_idx))) > + goto done; This should never fail.

2 2

Re: d3d9/tests: Test the return of CreateDepthStencilSurface()
by Henri Verbeet 20 Oct '15

20 Oct '15

On 20 October 2015 at 09:48, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > hr = IDirect3DDevice9_CreateDepthStencilSurface(device, 640, 480, D3DFMT_D24S8, > D3DMULTISAMPLE_NONE, 0, TRUE, &ds, NULL); > + ok(SUCCEEDED(hr), "Failed to create depth stencil surface, hr = %08x.\n", hr); Please use the same style as the other messages in the test. (I.e., "hr %#x.\n".)

1 0

Re: [PATCH] wintrust/tests: Use proper return types when calling provider funcs (PVS-Studio)
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17516 Your paranoid android. === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 757DC81B === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF266C === w1064 (64 bit softpub) === softpub.c:255: Test failed: Expected S_OK, got 00000001 softpub.c:258: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FF85A339A5D

1 0

Re: [PATCH] usp10/tests: Use BOOL variable for BOOL retval (PVS-Studio)
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17515 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1244: Test failed: 0: uJustification incorrect (0) usp10.c:1244: Test failed: 1: uJustification incorrect (0) usp10.c:1244: Test failed: 2: uJustification incorrect (0) usp10.c:1244: Test failed: 3: uJustification incorrect (0) usp10.c:1244: Test failed: 4: uJustification incorrect (0) usp10.c:1244: Test failed: 5: uJustification incorrect (0) usp10.c:1244: Test failed: 6: uJustification incorrect (0) usp10.c:1244: Test failed: 7: uJustification incorrect (0) usp10.c:1244: Test failed: 8: uJustification incorrect (0) usp10.c:1244: Test failed: 9: uJustification incorrect (0) usp10.c:1260: Test failed: 3: uJustification incorrect (0) usp10.c:1260: Test failed: 5: fDiacritic incorrect (1) usp10.c:1260: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1260: Test failed: 15: fDiacritic incorrect (1) usp10.c:1260: Test failed: 15: fZeroWidth incorrect (1)

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17510 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [RFC PATCH 1/2] msvcrt: Split simple string/memory routines to a separate file
by Alexandre Julliard 20 Oct '15

20 Oct '15

Martin Storsjo <martin(a)martin.st> writes: > These are simple functions that don't touch the global CRT state > (not touching errno etc). These are functions that are part of > vcruntime140.dll in the new ucrtbase/vcruntime split. > > Signed-off-by: Martin Storsjo <martin(a)martin.st> > --- > I'm not sure if "memory" is the best filename here, other suggestions > are welcome. I don't think you need a separate file for this. Simply duplicate the handful of functions that you need inside vcruntime140. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ddraw/tests: Test the return of DrawPrimitive()
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17507 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

2 1

Re: gdi32: Return default palette entries from GetSystemPaletteEntries for non-palette-based devices. (try 5)
by Huw Davies 20 Oct '15

20 Oct '15

On 17 Oct 2015, at 16:35, Anton Baskanov wrote: > +static void test_system_palette_entries() You're missing a 'void' inside the parenthesis. Otherwise, this looks good. Huw.

1 0

Re: [PATCH] dpnet: Add Server tests
by Stefan Dösinger 19 Oct '15

19 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, My apologies for the late review. I've been sick the past days and also had to put a lot of attention towards other stuff. Am 2015-10-13 um 11:05 schrieb Alistair Leslie-Hughes: > +static const WCHAR localhost[] = {'1','2','7','.','0','.','0','.','1',0}; Minor nitpick: Is there a reason why you use "127.0.0.1" instead of "localhost"? > +static int destroy_dnt = 0; What does "dnt" stand for? > +static HRESULT WINAPI DirectPlayMessageHandler(void *pvUserContext, DWORD dwMessageId, void *pMsgBuffer) You got rid of CamelCase in the global variables. Please do it here as well and call the function direct_play_message_handler or similar. Also avoid things like dwThisIsADword and pDidIMentionThisIsaPointer. > + case DPN_MSGID_INDICATE_CONNECT: > + trace("DPN_MSGID_CREATE_PLAYER\n"); Copy-paste mistake. > +static HRESULT WINAPI DirectPlayClientMsHandler(void *context, DWORD dwMessageId, void *buffer) "MsHandler"? > +{ > + HRESULT hr; > + > + switch(dwMessageId) > + { > + case DPN_MSGID_ENUM_HOSTS_RESPONSE: > + { > + DPNMSG_ENUM_HOSTS_RESPONSE *host_msg; > + host_msg = (PDPNMSG_ENUM_HOSTS_RESPONSE)buffer; PDPNMSG_ENUM_HOSTS_RESPONSE -> DPNMSG_ENUM_HOSTS_RESPONSE * please. > + memset(&hostdesc, 0, sizeof(DPN_APPLICATION_DESC)); You can use sizeof(hostdesc) instead of sizeof(DPN_APPLICATION_DESC) here. > + memcpy(&hostdesc, host_msg->pApplicationDescription, sizeof(DPN_APPLICATION_DESC) ); Same. > + hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > + ok(hr == S_OK, "CoCreateInstance failed with 0x%x\n", hr); > + if(hr != S_OK) > + return; You don't need the if() check here. If CoCreateInstance fails the test already failed and you can just let it crash. > + memset( &appdesc, 0, sizeof(DPN_APPLICATION_DESC) ); > + appdesc.dwSize = sizeof( DPN_APPLICATION_DESC ); > + appdesc.guidApplication = appguid; > + > + connect = CreateEventA( NULL, TRUE, FALSE, NULL); > + hostenum = CreateEventA( NULL, TRUE, FALSE, NULL); Inconsistent parenthesis placement. It seems the code was copypasted together from other places. > + hr = IDirectPlay8Client_Initialize(client, NULL, DirectPlayClientMsHandler, 0); > + ok(hr == S_OK, "IDirectPlay8Client_Initialize failed with %x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&host); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(host, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&device); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); You're using LPCRAP here again. I think you're not making any productive use of the address object you create here and you're leaking it. Later on you're creating a separate address and overwrite this one. > + hr = IDirectPlay8Address_AddComponent(host, DPNA_KEY_HOSTNAME, localhost, sizeof(localhost), > + DPNA_DATATYPE_STRING); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); This is obviously something for a different patch / test, but do you know how the various components play together with the service provider? I'd assume that a Serial or Modem service provider requires different components than the TCPIP service provider. > @@ -109,5 +269,9 @@ START_TEST(server) > > create_server(); > > + create_client(); > + > + cleanup(); It is difficult to see what is going on by just reading the main function of the test. create_foo() and cleanup() suggest that they create / destroy helper objects, but all of them do a serious amount of testing. You cannot disable the tests separately without breaking the entire test. I'd suggest to have helper functions that create server and client and one enumeration test, a test for connecting to a server, ..., and call the creation functions in each individual test, similar to how e.g. create_device() is working in various d3d tests. This makes this patch more complicated, but it will be very helpful in the long run when more tests are added that need fresh objects. Sooner or later you'll also want to be able to disable individual tests for debugging and / or faster execution times if you work on a new test. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWJSi7AAoJEN0/YqbEcdMwz3sP/ArVZHXjUMVD45/bGbqJ7ZIX oKYP/GTHEBVJtA3EICapjIhN/92intcsQxtjYy0sK5ol4U2Yeg3HDon/PTSihEgC oK0cr1Jf8Z1lN7+kuIgDc4agMrW7UxAhBuJ4CqMFsOkLFbuem30VXnFj+/1VhCRC zYqhirihyFyH+8ac4g6kQLJBnPP5gtJ3YKbDYoE+LM0wF1eIUTfvcEuMfxp8tF4s gO4k7fpjvOzrf7J/z1MK/J+1OUQxvyGPp+HikZ8ZUXD16A6Dqwc7nATL3f+wMV85 JICLuXiyqV7slnkb0A2rIbMIM2Y5cF7pHAjz08thGYSWno+wJFXAcGtH12JPT1uD 61XQfh/lPZKXgeJRKwpwq3meztVVxzb1V4mfQsNWvi81nzEnu2VRvs8PZqAyR09E vU7yFNXq/cDikRN9NrtX/tTv7ZaHwM1HwZVqGzA+mB4vlQ8pApzycYLQh1sOVQRm g39eSq2qNx/7pk53G7Chxm/8sQ3Xa7s5D0F7PqvDTxlXA0xo8Q1r3+zH/NQDGvS8 UsKz0br6rRFdArpyzv9VUxF2Ynn+xig25JPk0ofbJx90H677kAJJ2QMyik4DOWGb sojlCQ0n9W5zR1kY3mbNWxa6mFiBsnexvoJ+eSiqnybkc+b+SDz1vJrSsOcKp1ys XUIIuCpcMtvVp85zcZG3 =/XJU -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/5] winepulse: Add format and period probing
by Alexandre Julliard 19 Oct '15

19 Oct '15

Andrew Eikum <aeikum(a)codeweavers.com> writes: > From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/winepulse.drv/mmdevdrv.c | 128 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 128 insertions(+) It breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M devenum.dll -p devenum_test.exe.so devenum && touch devenum.ok wine: Unhandled page fault on execute access to 0x7dd57d70 at address 0x7dd57d70 (thread 0026), starting debugger... Unhandled exception: page fault on execute access to 0x7dd57d70 in 32-bit code (0x7dd57d70). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7dd57d70 ESP:0053e900 EBP:0053e928 EFLAGS:00010206( R- -- I - -P- ) EAX:00000000 EBX:7dd64260 ECX:00000087 EDX:7dd64830 ESI:7d6004b8 EDI:7dd64830 Stack dump: 0x0053e900: 7dd64830 0053e942 0000000a 7dce2a74 0x0053e910: 7d6004f8 7d6007f0 7dd57d5b 7dd1a000 0x0053e920: 7d6004b8 00000000 7dd57d50 7dce26d2 0x0053e930: 7d604e40 00000003 ffffffff 00000000 0x0053e940: 575704b8 57575757 0000009c 25aac200 0x0053e950: 0053e9e8 00000801 7dce2629 7dd1a000 Backtrace: =>0 0x7dd57d70 (0x0053e928) 1 0x7dce26d2 pa_mainloop_poll+0xb1() in libpulse.so.0 (0x7dd57d50) 2 0x7dce2def pa_mainloop_iterate+0x3e() in libpulse.so.0 (0x0053e9e8) 3 0x7dce2eac pa_mainloop_run+0x2b() in libpulse.so.0 (0x0053e9e8) 4 0x7dd57d18 (0x0053e9e8) 5 0x7bc7ea60 call_thread_func_wrapper+0xb() in ntdll (0x0053ea08) 6 0x7bc817cf call_thread_func+0xde(entry=0x7dd57cb0, arg=0x0(nil), frame=0x53eb08) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0053eae8) 7 0x7bc7ea3e call_thread_entry_point+0x11() in ntdll (0x0053eb08) 8 0x7bc89483 start_thread+0xa2(info=0x7ffd4fb8) [/home/julliard/wine/wine/dlls/ntdll/thread.c:449] in ntdll (0x0053f358) 9 0xf755defb start_thread+0xca() in libpthread.so.0 (0x0053f428) 0x7dd57d70: -- no code accessible -- Modules: Module Address Debug info Name (108 modules) ELF 7b800000-7ba60000 Deferred kernel32<elf> \-PE 7b810000-7ba60000 \ kernel32 ELF 7bc00000-7bcec000 Dwarf ntdll<elf> \-PE 7bc10000-7bcec000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7d4f4000-7d600000 Deferred libasound.so.2 ELF 7d764000-7d794000 Deferred winealsa<elf> \-PE 7d770000-7d794000 \ winealsa ELF 7d794000-7d7c1000 Deferred libvorbis.so.0 ELF 7d7c1000-7d7ca000 Deferred libogg.so.0 ELF 7d7ca000-7d7df000 Deferred libgpg-error.so.0 ELF 7d7df000-7d852000 Deferred libpcre.so.3 ELF 7d852000-7d8de000 Deferred libvorbisenc.so.2 ELF 7d8de000-7d93f000 Deferred libflac.so.8 ELF 7d93f000-7d95c000 Deferred libgcc_s.so.1 ELF 7d95c000-7da0d000 Deferred libgcrypt.so.20 ELF 7da0d000-7da36000 Deferred liblzma.so.5 ELF 7da36000-7da4d000 Deferred libresolv.so.2 ELF 7da4d000-7da75000 Deferred libselinux.so.1 ELF 7da75000-7da7b000 Deferred libuuid.so.1 ELF 7da7b000-7da81000 Deferred libattr.so.1 ELF 7da81000-7da88000 Deferred libasyncns.so.0 ELF 7da88000-7db01000 Deferred libsndfile.so.1 ELF 7db01000-7db0b000 Deferred libwrap.so.0 ELF 7db0b000-7db97000 Deferred libsystemd.so.0 ELF 7db97000-7db9f000 Deferred libxtst.so.6 ELF 7db9f000-7dba9000 Deferred libsm.so.6 ELF 7dba9000-7dbc6000 Deferred libice.so.6 ELF 7dbc6000-7dbcf000 Deferred librt.so.1 ELF 7dbcf000-7dc2b000 Deferred libdbus-1.so.3 ELF 7dc2b000-7dcb5000 Deferred libpulsecommon-7.0.so ELF 7dcb5000-7dcc1000 Deferred libjson-c.so.2 ELF 7dcc1000-7dd1b000 Dwarf libpulse.so.0 ELF 7dd65000-7dd87000 Deferred mmdevapi<elf> \-PE 7dd70000-7dd87000 \ mmdevapi ELF 7dd87000-7ddbd000 Deferred uxtheme<elf> \-PE 7dd90000-7ddbd000 \ uxtheme ELF 7ddbd000-7de32000 Deferred shlwapi<elf> \-PE 7ddd0000-7de32000 \ shlwapi ELF 7de32000-7df2a000 Deferred comctl32<elf> \-PE 7de40000-7df2a000 \ comctl32 ELF 7df2a000-7df74000 Deferred dsound<elf> \-PE 7df30000-7df74000 \ dsound ELF 7df74000-7e061000 Deferred quartz<elf> \-PE 7df90000-7e061000 \ quartz ELF 7e061000-7e117000 Deferred winmm<elf> \-PE 7e070000-7e117000 \ winmm ELF 7e172000-7e175000 Deferred libx11-xcb.so.1 ELF 7e175000-7e19e000 Deferred msvfw32<elf> \-PE 7e180000-7e19e000 \ msvfw32 ELF 7e19e000-7e1c7000 Deferred msacm32<elf> \-PE 7e1a0000-7e1c7000 \ msacm32 ELF 7e1c7000-7e1db000 Deferred avicap32<elf> \-PE 7e1d0000-7e1db000 \ avicap32 ELF 7e1db000-7e202000 Deferred devenum<elf> \-PE 7e1e0000-7e202000 \ devenum ELF 7e224000-7e22b000 Deferred libxfixes.so.3 ELF 7e22b000-7e237000 Deferred libxcursor.so.1 ELF 7e237000-7e24a000 Deferred libxi.so.6 ELF 7e24a000-7e24e000 Deferred libxcomposite.so.1 ELF 7e24e000-7e25b000 Deferred libxrandr.so.2 ELF 7e25b000-7e267000 Deferred libxrender.so.1 ELF 7e267000-7e26e000 Deferred libxxf86vm.so.1 ELF 7e26e000-7e272000 Deferred libxinerama.so.1 ELF 7e272000-7e279000 Deferred libxdmcp.so.6 ELF 7e279000-7e27d000 Deferred libxau.so.6 ELF 7e27d000-7e2a3000 Deferred libxcb.so.1 ELF 7e2a3000-7e3f5000 Deferred libx11.so.6 ELF 7e3f5000-7e40a000 Deferred libxext.so.6 ELF 7e40a000-7e410000 Deferred libcap.so.2 ELF 7e434000-7e4c0000 Deferred winex11<elf> \-PE 7e440000-7e4c0000 \ winex11 ELF 7e4c0000-7e4e3000 Deferred imm32<elf> \-PE 7e4d0000-7e4e3000 \ imm32 ELF 7e5c3000-7e5ed000 Deferred libexpat.so.1 ELF 7e5ed000-7e62f000 Deferred libfontconfig.so.1 ELF 7e62f000-7e65c000 Deferred libpng12.so.0 ELF 7e65c000-7e679000 Deferred libz.so.1 ELF 7e679000-7e728000 Deferred libfreetype.so.6 ELF 7e728000-7e74c000 Deferred libtinfo.so.5 ELF 7e74c000-7e772000 Deferred libncurses.so.5 ELF 7e79c000-7e81a000 Deferred rpcrt4<elf> \-PE 7e7b0000-7e81a000 \ rpcrt4 ELF 7e81a000-7e833000 Deferred version<elf> \-PE 7e820000-7e833000 \ version ELF 7e833000-7e94a000 Deferred gdi32<elf> \-PE 7e840000-7e94a000 \ gdi32 ELF 7e94a000-7ea97000 Deferred user32<elf> \-PE 7e960000-7ea97000 \ user32 ELF 7ea97000-7eb0a000 Deferred advapi32<elf> \-PE 7eaa0000-7eb0a000 \ advapi32 ELF 7eb0a000-7ec3c000 Deferred ole32<elf> \-PE 7eb20000-7ec3c000 \ ole32 ELF 7ec3c000-7ed69000 Deferred oleaut32<elf> \-PE 7ec50000-7ed69000 \ oleaut32 ELF 7ef69000-7ef76000 Deferred libnss_files.so.2 ELF 7ef76000-7ef90000 Deferred libnsl.so.1 ELF 7ef90000-7efd6000 Deferred libm.so.6 ELF 7efe8000-7f000000 Deferred devenum_test<elf> \-PE 7eff0000-7f000000 \ devenum_test ELF f73a6000-f73ab000 Deferred libdl.so.2 ELF f73ab000-f7556000 Dwarf libc.so.6 ELF f7557000-f7573000 Dwarf libpthread.so.0 ELF f7574000-f7580000 Deferred libnss_nis.so.2 ELF f7594000-f759d000 Deferred libnss_compat.so.2 ELF f759d000-f7753000 Dwarf libwine.so.1 ELF f7755000-f7777000 Deferred ld-linux.so.2 ELF f7777000-f7778000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\julliard\wine\wine\dlls\devenum\tests\devenum_test.exe 00000028 0 00000027 0 00000026 0 <== 00000009 0 0000000e services.exe 0000001e 0 0000001d 0 00000017 0 00000016 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 0000001c 0 00000019 0 00000018 0 00000013 0 0000001a plugplay.exe 00000020 0 0000001f 0 0000001b 0 00000021 explorer.exe 00000025 0 00000024 0 00000023 0 00000022 0 System information: Wine build: wine-1.7.53-39-g51c5fea1f275 Platform: i386 Host system: Linux Host version: 3.16.0-4-amd64 Makefile:161: recipe for target 'devenum.ok' failed make: *** [devenum.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] hidclass.sys: fixed size passed IOCTL_HID_GET_INPUT_REPORT (Coverity)
by Sebastian Lackner 19 Oct '15

19 Oct '15

On 17.10.2015 14:52, Marcus Meissner wrote: > 1327477 Wrong sizeof argument > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c > index e7e7e11..dcc7d3c 100644 > --- a/dlls/hidclass.sys/device.c > +++ b/dlls/hidclass.sys/device.c > @@ -277,7 +277,7 @@ static DWORD CALLBACK hid_device_thread(void *args) > packet->reportId = 0; > > irp = IoBuildDeviceIoControlRequest(IOCTL_HID_GET_INPUT_REPORT, > - device, NULL, 0, packet, sizeof(packet), TRUE, events[0], > + device, NULL, 0, packet, sizeof(*packet)+ext->preparseData->caps.InputReportByteLength, TRUE, events[0], > &irp_status); > > irpsp = IoGetNextIrpStackLocation(irp); > This looks wrong, you have to allocate a separate buffer, and then copy it (like in the code below). I don't know why some of these buffers are HEAP_ZERO_MEMORY though, and others not? Adding Aric, he might want to review this part again, especially since Coverity detected more issues in this code (unnecessary assignment of "rc" for example).

4 8

Re: [PATCH v4] Remove whitespaces and tabs
by Frédéric Delanoy 19 Oct '15

19 Oct '15

On Sun, Oct 18, 2015 at 11:44 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Supersedes 115416 As a general rule, pure whitespace patches are not accepted. No point sending them over and over. Frédéric Delanoy

5 4

Re: wined3d: Recognize Radeon HD 3850 AGP
by Henri Verbeet 19 Oct '15

19 Oct '15

Did you test this? You don't add anything that matches CARD_AMD_RADEON_HD3850.

1 0

Re: [PATCH 2/5] d3d11: Implement d3d10_device_CreateShaderResourceView1().
by Henri Verbeet 19 Oct '15

19 Oct '15

On 19 October 2015 at 01:41, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static HRESULT STDMETHODCALLTYPE d3d10_device_CreateShaderResourceView1(ID3D10Device1 *iface, > + ID3D10Resource *resource, const D3D10_SHADER_RESOURCE_VIEW_DESC1 *desc, ID3D10ShaderResourceView1 **view); Things like this are always a bit awkward because on the one hand you'd like to preserve the vtbl order, while on the other you'd like to avoid forward declarations. I think it's better to just move the implementation of d3d10_device_CreateShaderResourceView1() to be above d3d10_device_CreateShaderResourceView().

1 0

Re: [RFC PATCH 2/2] vcruntime140: Add the new MSVC 2015 compiler specific DLL.
by Nikolay Sivov 19 Oct '15

19 Oct '15

On 18.10.2015 22:20, Martin Storsjo wrote: > +EXTRADEFS = -D_MT -D_MSVCR_VER=140 -DVCRUNTIME Is it not enough to have MSVCR_VER only? E.g. is it possible to have MSVCR_VER defined to 140 and undefined VCRUNTIME at the same time? > + case DLL_PROCESS_ATTACH: > +// msvcrt_init_exception(hinstDLL); > + if(!msvcrt_init_tls()) { Debug leftovers? > diff --git a/dlls/msvcrt/main-vcruntime.c b/dlls/msvcrt/main-vcruntime.c > new file mode 100644 > index 0000000..ccbe6a9 > --- /dev/null > +++ b/dlls/msvcrt/main-vcruntime.c This looks like a workaround to me. Will it work to duplicate this in vcruntime140 or consolidate it in some way making it usable from msvcrt and vcruntime*?

2 3

Re: patches: Make Author and Reviewer titles centered
by Nikolay Sivov 19 Oct '15

19 Oct '15

I'm not sure if it's better when centered to be honest. I personally find it easier to read when names are left aligned, same as with subject field. Other fields have limited number of possible values (or fixed char length for a long period of time), so it's not that jumpy when centered. In any case looks like Reviewer fields uses same 'author' class, so only that need changes to do what you want.

2 1

Re: [PATCH 4/5] ddraw: Accept all 3 versions of D3DFINDDEVICERESULT
by Stefan Dösinger 18 Oct '15

18 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-04 um 19:52 schrieb Andrew D'Addesio: > + /* Write ddHwDesc */ > + desc_ptr = (BYTE*)&fdr->ddHwDesc; > + memcpy(desc_ptr, &desc1, desc_size); > + ((D3DDEVICEDESC*)desc_ptr)->dwSize = desc_size; > + > + /* Write ddSwDesc */ > + desc_ptr += desc_size; > + memcpy(desc_ptr, &desc1, desc_size); > + ((D3DDEVICEDESC*)desc_ptr)->dwSize = desc_size; Is there a nicer way? I can't think of one to be honest, but this code feels somewhat unsatisfying. Also I guess we're lucky that all versions of D3DDEVICEDESC have a DWORD-aligned size, so we don't have to worry about padding between them. Native ddraw doesn't support d3d in 64 bit. Ours does though, mostly out of laziness. Did you run the test in a 64 bit build? It might fail due to different struct alignment. > + /* Invalid D3DDEVICEDESC sizes should fail */ > + search.dwSize = sizeof(search); > + search.dwFlags = 0; > + clear_device_result(&result, (D3D1_DESC_SIZE-4), (D3D1_DESC_SIZE-4)); > hr = IDirect3D_FindDevice(Direct3D1, &search, &result); > - ok(hr == D3D_OK, > - "Expected IDirect3D1::FindDevice to return D3D_OK, got 0x%08x\n", hr); > + ok(hr == DDERR_INVALIDPARAMS, > + "Expected IDirect3D1::FindDevice to return DDERR_INVALIDPARAMS, got 0x%08x\n", hr); What happens when you use something between D3D1_DESC_SIZE and D3D2_DESC_SIZE, or e.g. the largest size + 4? I recommend to put the valid and invalid tests in a table together with an expect HRESULT. That way you don't have to duplicate the structure assignment code + FindDevice call and can just iterate over the table. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWEiUOAAoJEN0/YqbEcdMwTCgP/AqlzZ9yyJktv2U+OTgxVGTU 9tj/ZbsKIVk7S0FQFDvyUaKCmP7CcYH+ARoJapn7it6peMdNKHB7zbAgsR7koWph hKECmx+xJ4w4Fjvkj159XYL28DokEHqDmZeaeghwldPbCcXTMO5BulJrooO5F1MI Q2/lwhr+pOO3EDOlLvvLntrOszuYJdy0CbWB34ORlV0PQfk/7Wwm+9rkDzVTDS4r xnpNAzEPaFHNrlhmXlaoFa6arsKTILcwhpmt6wzXTMhcyGs8NRcHA1F5lgIbnH3X m6q84FI5Law/epfKwJSyXTI1eDdWB0PKGqw+xEUv4T79q8oRVRe+W/Sjvq9bluEa fDYshHOP2uVRQ0kcObqSTx9iOWW9RtCdTdHxhloHDOOPIAJyxyoENOkYV/5V+QBT P3pKUG9qjNFODFxQvHb6rvbUisVUXGPihC1fbdAkoNYD4Mf2V5rZ+K88RgXQmofS +zbxziLAr6ItmeCw4/nAvt3/8HoQAtWkF7Bb6ZxhtViOzRraNkLvjqPtJ1HAmz8F TueLADA2bRXpGmkW+9bjLbQ0Z6aK2fqQHYy4Rmkt1LJwGSqrMz5ctq63XChZgA+G +c2OXfvcC+zJsVfLxFHmPjPv1eQ0CQ3gyssjRVGPXq9JAQNHqJxm4ldK5e/dJcTS VBxzcIjMMFVLld6a+dS5 =TBrC -----END PGP SIGNATURE-----

3 5

Re: msrle32/tests: Add uncompressed video tests using MRLE as codec (try 2)
by Nikolay Sivov 18 Oct '15

18 Oct '15

On 18.10.2015 19:47, Bruno Jesus wrote: > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> > > try 2: > Create the required video file on runtime, I squeezed the avi file as > much as I could to make it still functional. I don't think blob in sources is better. Clean way is to have a separate avi file, compile it as resource, and create temporary file from resource. That's how it's already done in qedit/tests, and in gdi32/dwrite for font files. And of course ideally it should be as small as possible, that has improved significantly from try1 (~450 bytes vs 20K). > > original: > While studying bug https://bugs.winehq.org/show_bug.cgi?id=33022 I > noticed that the game mouse cursors are stored in an uncompressed AVI > file, wine currently is not able to process such videos as ICLocate > will fail without finding a valid codec. > > Windows always returns the MRLE codec in such cases so this test opens > an uncompressed video and use explicitly MRLE to check if it is able > to decompress the video and it does. > > > >

1 0

Re: msrle32/tests: Add uncompressed video tests using MRLE as codec (try 2)
by Marvin 18 Oct '15

18 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17431 Your paranoid android. === w8 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w864 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w1064 (32 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w864 (64 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data === w1064 (64 bit msrle) === msrle.c:174: Test failed: Expected non-NULL frame data msrle.c:176: Test failed: Expected non-NULL frame data

1 0

Undocumented Toolbar common control message is now documented by Microsoft
by Alan Feldman 18 Oct '15

18 Oct '15

Hello Wine developers, I don't know if you guys are interested in this or not, but I figured I'd let you know that Microsoft has now documented one of the undocumented toolbar messages. include/commctrl.h (Wine) #define TB_UNKWN45D (WM_USER + 93) include\um\commctrl.h (Windows) #define TB_SETBOUNDINGSIZE (WM_USER + 93) TB_SETBOUNDINGSIZE message https://msdn.microsoft.com/en-us/library/ee663584(v=vs.85).aspx << Sets the bounding size for a multi-column toolbar control. >> That would mean you could also make the corresponding changes to this code as well: dlls/comctl32/toolbar.c case TB_UNKWN45D: return TOOLBAR_Unkwn45D(hwnd, wParam, lParam); /* UNDOCUMENTED MESSAGE: This appears to set some kind of size. Perhaps it * is the maximum size of the toolbar? */ static LRESULT TOOLBAR_Unkwn45D(HWND hwnd, WPARAM wParam, LPARAM lParam) Anyway, just figured I'd share that with you guys. Cheers, Alan Feldman

2 1

Re: fltmgr.sys: add FltInitializePushLock stub (try 3)
by Dmitry Timoshkov 17 Oct '15

17 Oct '15

Austin English <austinenglish(a)gmail.com> wrote: > +void WINAPI FltInitializePushLock(EX_PUSH_LOCK *lock) > +{ > + FIXME("(%p): stub\n", lock); > +} > diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h > index a8d90a1..8d22d41 100644 > --- a/include/ddk/ntifs.h > +++ b/include/ddk/ntifs.h > @@ -19,6 +19,9 @@ > #ifndef __NTIFS_H__ > #define __NTIFS_H__ > > +#define EX_PUSH_LOCK ULONG_PTR > +#define PEX_PUSH_LOCK PULONG_PTR I'd guess that's not what Alexandre meant with an opaque pointer (anyway 'ULONG_PTR *' and 'ULONG_PTR' are two different things, not sure what you tried to achieve with any of them), you may try with 'void *' instead. -- Dmitry.

1 0

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Marcus Meissner 17 Oct '15

17 Oct '15

On Fri, Oct 16, 2015 at 10:21:50AM -0500, Michael Cronenworth wrote: > Prelink was used to rewrite binares and set their text segment, but > modern linkers support setting the value at link time. Prelink is > being retired by upstream. > > Signed-off-by: Michael Cronenworth <mike(a)cchtml.com> Can confirm it works on SUSE too. Signed-Off-By: Marcus Meissner <marcus(a)jet.franken.de> > --- > configure.ac | 11 ++++++++--- > tools/winegcc/winegcc.c | 11 +++++++++-- > 2 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index de8cde5..f283802 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -988,10 +988,15 @@ wine-installed: main.o > *) LDEXECFLAGS="$LDEXECFLAGS -Wl,--section-start,.interp=0x7bf00400" ;; > esac > ]) > - AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) > - if test "x$PRELINK" = xfalse > + WINE_TRY_CFLAGS([-Wl,-Ttext-segment=0x7bc00000], > + [HAVE_TTEXT_SEGMENT="yes"]) > + if test "x$HAVE_TTEXT_SEGMENT" != "xyes" > then > - WINE_WARNING([prelink not found, base address of core dlls won't be set correctly.]) > + AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) > + if test "x$PRELINK" = xfalse > + then > + WINE_WARNING([prelink not found and linker does not support relocation, base address of core dlls won't be set correctly.]) > + fi > fi > ;; > esac > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index 3b2794e..4acd12d 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -1134,6 +1134,12 @@ static void build(struct options* opts) > } > break; > default: > + /* Try option first, modern linkers support this */ > + if (opts->image_base && > + !try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base))) > + { > + strarray_add(link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base)); > + } > break; > } > > @@ -1167,8 +1173,9 @@ static void build(struct options* opts) > spawn(opts->prefix, link_args, 0); > strarray_free (link_args); > > - /* set the base address */ > - if (opts->image_base && !opts->target) > + /* set the base address with prelink if linker support is not present */ > + if (opts->image_base && !opts->target && > + try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base))) > { > const char *prelink = PRELINK; > if (prelink[0] && strcmp(prelink,"false")) > -- > 2.4.3 > > > >

1 0

Re: [1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec (resend)
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17422 Your paranoid android. === build (build) === Make failed

4 4

Re: [2/2] msrle32: Add support to uncompressed frames video (resend)
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17423 Your paranoid android. === build (build) === Make failed

1 0

Re: [2/2] msrle32: Add support to uncompressed frames video
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17420 Your paranoid android. === build (build) === Make failed

1 0

Re: [1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17419 Your paranoid android. === build (build) === Make failed

1 0

Re: fltmgr.sys: add FltInitializePushLock stub (try 2)
by Alexandre Julliard 17 Oct '15

17 Oct '15

Austin English <austinenglish(a)gmail.com> writes: > +++ b/include/ddk/ntifs.h > @@ -19,6 +19,18 @@ > #ifndef __NTIFS_H__ > #define __NTIFS_H__ > > +typedef struct _EX_PUSH_LOCK { > + union { > + struct { > + ULONG waiting : 1; > + ULONG exclusive : 1; > + ULONG shared : 30; > + } DUMMYSTRUCTNAME; > + ULONG value; > + VOID *ptr; > + } DUMMYUNIONNAME; > +} EX_PUSH_LOCK, *PEX_PUSH_LOCK; Where does this come from? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3d8: Adjust D3DCOLOR_ARGB to avoid shift overflow.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-09-13 um 22:56 schrieb Gerald Pfeifer: > -#define D3DCOLOR_ARGB(a,r,g,b) ((D3DCOLOR)((((a)&0xff)<<24)|(((r)&0xff)<<16)|(((g)&0xff)<<8)|((b)&0xff))) > +#define D3DCOLOR_ARGB(a,r,g,b) ((D3DCOLOR)((((a)&0xffu)<<24)|(((r)&0xff)<<16)|(((g)&0xff)<<8)|((b)&0xff))) Wouldn't it make sense to make the masks for the other channels unsigned too? Are there any possible side effects when compiling code with winelib? The native header uses a signed 0xff. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJV9o1AAAoJEN0/YqbEcdMwVwUP/3G2g6LM41sKgJt3/mxlhkQ4 BdxJ+Oj2Sz1FdefWNzohcRGI5V8AaRSfoCyCQCvSvFRUm72VY9aMKvK3Nhg7gku0 OmP9z81GEDIb13eLNGrcGNmU97wsqk69MtahHFZ3tj8gYLEWVW3sZPwU64VOa89g 7eLLrx5xXGAhoyzN/q85rV7oGj6xmCzv8YKzasv7BAQIdARVwoSVzmyH2kqbuJFf ENVHyoPSJpphYBc4vxSOLVelgVCGEeAdAECnaGpGG+UfT8Sha3GTFu5q6Nn8P9Gx 3irwIPv7nfgqgdBFDRZUOuck/P5mirM9K3YQLB5309usVh7czusvR6LRWR7g5/gD aCf3fub02sfVe0+Sl2NBMfjF361qaOcMpv63e6+QGToKRIXSE9Ht/v4oUeblNi+h H6K/ljyv/kXr9mDUQBRbRUFlcKtp9Cm49xHAK7cT2xDrIj9z18mExKeARz+V1hiF Fs9W/sJao6F+LN9p1XpdZ+Ha10zvFUrsF3OPj09nyv/C+lXdIt5WgFIiI6gzsD/Z +vKFEoiYWnea9xBO9hUprnr4HTNlCMCZroQrvgeJm3xVxhcZZ9d7XQk7Q+oS1UlU S1g4FJL/Ea8EPNW5bq35F9x50azgZVKmdgIDe1ZtogDF+tgGwuuHN5DiqHAhU2cM deINoftjzz/ztYWqm2Yh =kZgE -----END PGP SIGNATURE-----

2 1

Re: d3drm/tests: Release two retrieved interfaces to allow proper cleanup.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker: > + hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameC); > + ok(hr == D3DRM_OK, "Cannot remove child frame (hr = %x)\n", hr); > + CHECK_REFCOUNT(pFrameC, 1); > + > + CHECK_REFCOUNT(pFrameP1, 2); > + hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameP1); > + ok(hr == D3DRM_OK, "Cannot remove child frame (hr = %x)\n", hr); > + CHECK_REFCOUNT(pFrameP1, 1); Are these necessary? I'd expect the frame children to be detached when their parent is destroyed, similarly to how it works in ddraw. I'm not opposed to explicitly removing them, so I'll send my signed-off-by to wine-patches. But it's something someone (Jamm? ;-) ) could write an explicit test for. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWINjmAAoJEN0/YqbEcdMwQFAQAIcW8C+DxXKqNfUX2gxN3HtP FHrr2i+Ufy694aoL/O+hcWgL0mxS/Hv9F9RnXth+m5x1FKBkKJx1DA3wXZl+N6Ea w961wIDiPZCzCr2Hb1HGeQEEKBoPXnY3oxtGmOipv8bYEpjSXLngYKXVmM9U0Ojl BjAKCPraAukui5sLaMr3Bypf6jrOylrceWnyXo70Q7E1Gg5Lq5auTawYDvDsYxKF WISMIn5eBXsNDr4irRneuW/2JDwbB/FePzkqxhVfKzkw9K0A72enuzHMWkfeXAHS zQvZr+uSC+KanwWJq41VdFhWzFNhudUklHT/Ne5vl/nPeFibtCmB6CxoGtVJPaqT Htzb2MoPV4cV/efp+2+oZPPZxOeAgXhdFmWqGUYZ02/rHpthH8saRJ1mGZoWY7DU R82s3k0vXBmwzhK1CHvs2zZgi6mt25qZqeJwM7Ehci/VLwjaREjts8yetGL8NoKP 9ZFx+Hg4LD4w8mBOc5utkerODw6fwIZ3KKCfdX2S9FAIbqWsZ0/cN4rmJkIjRMGq FiYyOZ9GU2H93CyRTtQfv3mVcXGh2LXxvxsgviR5gzBxo4XbVqiYe/cFcCfTtJQu NrTYURDXQxFFkjq5rZXYP4bUItGAbuoC5/Kh4C/ATONahQq9yqEo7qDQRsP9IRS6 AX+rnn4Sagutm0q/OJc8 =R0Nv -----END PGP SIGNATURE-----

3 3

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 5).
by Marvin 16 Oct '15

16 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17393 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7350: Test failed: bytesReturned isn't supposed to be 1 sock.c:7374: Test failed: GetOverlappedResult failed, error 0

3 2

Re: [PATCH] shell32: Implement IShellDispatch2::ShellExecute
by Dmitry Timoshkov 16 Oct '15

16 Oct '15

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > + TRACE("(%s, %s, %s, %s, %s): stub\n", debugstr_w(file), debugstr_variant(&v_args), > + debugstr_variant(&v_dir), debugstr_variant(&v_op), debugstr_variant(&v_show)); Probably ": stub" part should be removed. > + if (V_VT(&v_op) == VT_BSTR) > + op = V_BSTR(&v_op); > + > + if (V_VT(&v_args) == VT_BSTR) > + args = V_BSTR(&v_args); > + > + if (V_VT(&v_dir) == VT_BSTR) > + dir = V_BSTR(&v_dir); > + > + if (V_VT(&v_show) == VT_INT) > + show = V_INT(&v_show); > + > + ShellExecuteW(NULL, op, file, args, dir, show); > + > + return S_OK; Shouldn't return value somehow reflect what ShellExecute returns? Also as usually it would be nice to see some tests for this, especially with not handled variant types. -- Dmitry.

2 1

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Alexandre Julliard 16 Oct '15

16 Oct '15

Michael Cronenworth <mike(a)cchtml.com> writes: > @@ -988,10 +988,17 @@ wine-installed: main.o > *) LDEXECFLAGS="$LDEXECFLAGS -Wl,--section-start,.interp=0x7bf00400" ;; > esac > ]) > - AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) > - if test "x$PRELINK" = xfalse > + WINE_TRY_CFLAGS([-Wl,-Ttext-segment=0x7bc00000], > + [AC_DEFINE([HAVE_TTEXT_SEGMENT],[1],[Define if > +linker supports -Ttext-segment.])], > + [HAVE_TTEXT_SEGMENT="no"]) > + if test "x$HAVE_TTEXT_SEGMENT" = "xno" The check should be done at run-time. Check how winegcc does it for other linker flags. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3drm/tests: Skip following tests when device creation fails.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker: > hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm, pClipper, &driver, rc.right, rc.bottom, &device); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRMDevice interface (hr = %x)\n", hr); > + if (FAILED(hr)) > + { > + skip("Cannot get IDirect3DRMDevice interface (hr = %x), skipping tests\n", hr); > + IDirectDrawClipper_Release(pClipper); > + IDirect3DRM_Release(d3drm); > + DestroyWindow(window); > + return; > + } The test will fail regardless, so you don't gain too much. It would be nicer if the test skips without a failing ok() statement in this case. Do you have a Windows VM to test how native d3drm responds if d3d is not available? I.e., which error code is returned? It might be a bit tricky to test because we request a software device that Wine doesn't implement but should be available everywhere on Windows. If you need help finding that out I can play a bit with my Windows XP box. (Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWINx5AAoJEN0/YqbEcdMwcDYP/1mLNoDkllStJ4gySEeUgfxK QUuTt7vIFiWGVl8/x9QUsO9dWakZ+2fPZJSl3cO8cUxuk/GbpwmKNYFG3IEcQUIo 1nTn5aM6kTxv4b+uVT2BnX/CwJLouQnjuFnsTxTORJad1WsPk/qTVcPAmknnTPlX uHs30ed8QBm7ZWwi+549rQfFeGjp41xf05BVqjtSILtIhPiRYfnfsXAV/zFmUPMB hCG3QtaSL4Ea4zS3aEr0II0aV6TcSSY1t+V0+SvCuZEgZDKbYF5qbEeKRiXubdga mQEtEWcun0NUwtRD7ftNA6Ad5WumHUv3hj3fwb0q4hA0AtjvsW1L4zuYQs/DVb2v T/vpyZLowUpUn4peTOwuNU5rBeUY9BRqeoqcE1ccyVUFQ2nt6Iq3XJGvzjRWf3RT e5j1F9OyM31j8eDTVRO3Vr5SXqH3yDiwzSoLPJzTrE9AV4r1hj30Vb7MWjlqmOlq 03P83KwPDyNg5JBtr7R6a9TxQn7zhfZNzHctuJWI2ZSvXhbPTHgh0GZd1ka9ITkT 273sIi/VKU8e1HoBz5zTnGHYgE3utdqBk6RHVzSk/L+fhsVxD8LccyytRs7de+ai 7ut0IFuLsM3jd22g9FF3PTmpgZx3nEDUn0WN628hQO4w+Lf7w+MUmGslHMSrqx1r yiscxon1fyODz+BewWKG =NOTo -----END PGP SIGNATURE-----

3 4

Re: [PATCH 3/5] wined3d: make wined3d_swapchain_get_front_buffer_data work with wined3d_texture and sub_resource_idx
by Henri Verbeet 16 Oct '15

16 Oct '15

On 15 October 2015 at 15:41, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + if (!(sub_resource = wined3d_texture_get_sub_resource(dst_texture, sub_resource_idx)) || > + sub_resource->type != WINED3D_RTYPE_SURFACE) Not a big issue, but if you're resending the series anyway, we usually put the "||" on the next line. (Here and in patch 4/5.)

2 1

Re: [PATCH 5/5] wined3d: introduce a new wined3d_texture_blt function
by Henri Verbeet 16 Oct '15

16 Oct '15

On 15 October 2015 at 15:41, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > +HRESULT CDECL wined3d_texture_blt(struct wined3d_texture *dst_texture, unsigned int dst_sub_resource_idx, const RECT *dst_rect_in, > + struct wined3d_texture *src_texture, unsigned int src_sub_resource_idx, const RECT *src_rect_in, DWORD flags, > + const WINEDDBLTFX *fx, enum wined3d_texture_filter_type filter) > +{ > + struct wined3d_resource *dst_resource, *src_resource; > + > + TRACE("dst_texture %p, dst_sub_resource_idx %u, src_texture %p, src_sub_resource_idx %u.\n", > + dst_texture, dst_sub_resource_idx, src_texture, src_sub_resource_idx); > + > + dst_resource = wined3d_texture_get_sub_resource(dst_texture, dst_sub_resource_idx); > + src_resource = wined3d_texture_get_sub_resource(src_texture, src_sub_resource_idx); > + > + if (!dst_resource || !src_resource) > + return WINED3DERR_INVALIDCALL; > + > + return wined3d_surface_blt(surface_from_resource(dst_resource), dst_rect_in, > + surface_from_resource(src_resource), src_rect_in, flags, fx, filter); > +} You can't assume src_resource and dst_resource are surfaces.

2 1

Re: [PATCH 1/5] d3d8: call wined3d_swapchain_get_front_buffer_data instead of wined3d_device_get_front_buffer_data in d3d8_device_GetFrontBuffer
by Henri Verbeet 16 Oct '15

16 Oct '15

On 15 October 2015 at 15:41, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > - hr = wined3d_device_get_front_buffer_data(device->wined3d_device, 0, dst_impl->wined3d_surface); > + if (!(swapchain = wined3d_device_get_swapchain(device->wined3d_device, 0))) > + hr = D3DERR_INVALIDCALL; > + else > + hr = wined3d_swapchain_get_front_buffer_data(swapchain, dst_impl->wined3d_surface); The timing is perhaps unfortunate, but since commit 20d5be042c577b8dfcca431fa4688cad192196df you can just use "device->implicit_swapchain->wined3d_swapchain" instead of calling wined3d_device_get_swapchain(). Something similar applies to patch 2/5.

1 0

Re: [PATCH 6/6] wined3d: Use non-deprecated texture sample builtins also in the fragment pipeline replacement shaders.
by Henri Verbeet 16 Oct '15

16 Oct '15

On 15 October 2015 at 22:01, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -6259,7 +6259,7 @@ static GLuint shader_glsl_generate_ffp_fragment_shader(struct shader_glsl_priv * > { > struct wined3d_string_buffer *buffer = &priv->shader_buffer; > BYTE lum_map = 0, bump_map = 0, tex_map = 0, tss_const_map = 0; > - BOOL tempreg_used = FALSE, tfactor_used = FALSE; > + BOOL tempreg_used = FALSE, tfactor_used = FALSE, legacy_syntax = needs_legacy_glsl_syntax(gl_info); > const char *final_combiner_src = "ret"; > UINT lowest_disabled_stage; > GLuint shader_id; > @@ -6480,52 +6480,52 @@ static GLuint shader_glsl_generate_ffp_fragment_shader(struct shader_glsl_priv * > case WINED3D_GL_RES_TYPE_TEX_1D: > if (proj) > { > - texture_function = "texture1DProj"; > + texture_function = legacy_syntax ? "texture1DProj" : "textureProj"; > coord_mask = "xw"; > } > else > { > - texture_function = "texture1D"; > + texture_function = legacy_syntax ? "texture1D" : "texture"; > coord_mask = "x"; > } > break; > case WINED3D_GL_RES_TYPE_TEX_2D: > if (proj) > { > - texture_function = "texture2DProj"; > + texture_function = legacy_syntax ? "texture2DProj" : "textureProj"; > coord_mask = "xyw"; > } > else > { > - texture_function = "texture2D"; > + texture_function = legacy_syntax ? "texture2D" : "texture"; > coord_mask = "xy"; > } > break; > case WINED3D_GL_RES_TYPE_TEX_3D: > if (proj) > { > - texture_function = "texture3DProj"; > + texture_function = legacy_syntax ? "texture3DProj" : "textureProj"; > coord_mask = "xyzw"; > } > else > { > - texture_function = "texture3D"; > + texture_function = legacy_syntax ? "texture3D" : "texture"; > coord_mask = "xyz"; > } > break; > case WINED3D_GL_RES_TYPE_TEX_CUBE: > - texture_function = "textureCube"; > + texture_function = legacy_syntax ? "textureCube" : "texture"; > coord_mask = "xyz"; > break; > case WINED3D_GL_RES_TYPE_TEX_RECT: > if (proj) > { > - texture_function = "texture2DRectProj"; > + texture_function = legacy_syntax ? "texture2DRectProj" : "textureProj"; > coord_mask = "xyw"; > } > else > { > - texture_function = "texture2DRect"; > + texture_function = legacy_syntax ? "texture2DRect" : "texture"; > coord_mask = "xy"; > } > break; It seems like it would be at least as readable to adjust "proj" for cube textures and then just do if (!needs_legacy_glsl_syntax(gl_info)) texture_function = proj ? "textureProj" : "texture";

1 0

xrdp wine drv
by Jay Sorg 15 Oct '15

15 Oct '15

I'm hacking on wine fork from github.com. My goal is to create a new driver for wine for xrdp. Similar to winemac.drv and winex11.drv but not to draw into a Mac or X11 window but an xrdp session. I don't want to have any X11 in the picture, strait from wine gdi into xrdp. Is anyone interested in this effort? Is there an example dummy driver for learning? Jay

2 2

Re: [1/3] scrrun: Implement filesys_DriveExists.
by Nikolay Sivov 15 Oct '15

15 Oct '15

On 15.10.2015 13:56, Joachim Priesner wrote: > + if (!pfExists) return E_POINTER; > + *pfExists = VARIANT_FALSE; > + len = SysStringLen(DriveSpec); > + if (len >= 1 && DriveSpec[0] >= 'A' && DriveSpec[0] <= 'Z' > + && (len < 2 || DriveSpec[1] == ':') > + && (len < 3 || DriveSpec[2] == '\\')) { > + WCHAR root[] = {toupperW(DriveSpec[0]), ':', '\\', 0}; > + *pfExists = GetDriveTypeW(root) != DRIVE_NO_ROOT_DIR ? VARIANT_TRUE : VARIANT_FALSE; > + } Not necessary wrong, but it'd be better if all that validation was GetDriveTypeW responsibility. I don't see many tests for it in kernel32/tests, could you please add some, so we can get rid of this extra logic? I haven't looked much at its implementation but it feels like DRIVE_UNKNOWN would also qualify as non-existent drive.

2 2

Re: [3/3] scrrun: Implement filesys_GetDrive for local drives.
by Nikolay Sivov 15 Oct '15

15 Oct '15

On 15.10.2015 13:56, Joachim Priesner wrote: > + DriveSpec[0] = toupperW(DriveSpec[0]); > + if (DriveSpec[0] < 'A' || DriveSpec[0] > 'Z' > + || (len >= 2 && DriveSpec[1] != ':') > + || (len == 3 && DriveSpec[2] != '\\')) > + return E_INVALIDARG; > + hr = filesys_DriveExists(iface, DriveSpec, &drive_exists); I'm not sure about that sanity check, the reason is that DriveExists doesn't fail on invalid drivespec? Also please use method wrappers internally, instead of calling implementation functions, I'm talking about filesys_DriveExists.

1 0

Reviewer assignments in the patch tracker
by Alexandre Julliard 15 Oct '15

15 Oct '15

Folks, I've now added support in the patch tracker to enable assigning a reviewer to a patch. If you get assigned a patch, you are expected to either reply with a sign-off, or send a comment to wine-devel (and please CC the patch author). Initially I'm only going to assign patches to people who have listed themselves as maintainers for the area that the patch modifies. A further step will be to gather a list of volunteers who are willing to be assigned patches for areas that don't have an active maintainer. I don't know what's the best mechanism for that, I was thinking we could have volunteer entries in MAINTAINERS, from which I would pick someone. I'd like to hear suggestions for other approaches. Also, currently you don't get a mail telling you that you have been assigned a patch, so you have to watch the patch tracker. I can add that feature if people think it would be useful and not too obnoxious. Please let me know. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH] dpnet: Add Server tests
by Stefan Dösinger 15 Oct '15

15 Oct '15

Just fyi, I want to take a closer look at this patch but didn't get around to it yet :-( . Stefan > Am 13.10.2015 um 11:05 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/dpnet/tests/server.c | 194 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 179 insertions(+), 15 deletions(-) > > diff --git a/dlls/dpnet/tests/server.c b/dlls/dpnet/tests/server.c > index 8279666..9ed3ef3 100644 > --- a/dlls/dpnet/tests/server.c > +++ b/dlls/dpnet/tests/server.c > @@ -25,22 +25,84 @@ > /* {CD0C3D4B-E15E-4CF2-9EA8-6E1D6548C5A5} */ > static const GUID appguid = { 0xcd0c3d4b, 0xe15e, 0x4cf2, { 0x9e, 0xa8, 0x6e, 0x1d, 0x65, 0x48, 0xc5, 0xa5 } }; > static WCHAR sessionname[] = {'w','i','n','e','g','a','m','e','s','s','e','r','v','e','r',0}; > +static const WCHAR localhost[] = {'1','2','7','.','0','.','0','.','1',0}; > > -static BOOL nCreatePlayer; > -static BOOL nDestroyPlayer; > +static int create_cnt = 0; > +static int destroy_dnt = 0; > +static int indicate_cnt = 0; > +static IDirectPlay8Server *server = NULL; > +static IDirectPlay8Client* client = NULL; > +static HANDLE connect = NULL; > +static HANDLE hostenum = NULL; > +static HANDLE clientfinished = NULL; > +static DPN_APPLICATION_DESC hostdesc; > > -static HRESULT WINAPI DirectPlayMessageHandler(PVOID pvUserContext, DWORD dwMessageId, PVOID pMsgBuffer) > -{ > - trace("msgid: 0x%08x\n", dwMessageId); > +static IDirectPlay8Address *hostAddr = NULL; > +static IDirectPlay8Address *deviceAddr = NULL; > +static WCHAR session[255]; > > +static HRESULT WINAPI DirectPlayMessageHandler(void *pvUserContext, DWORD dwMessageId, void *pMsgBuffer) > +{ > switch(dwMessageId) > { > + case DPN_MSGID_INDICATE_CONNECT: > + trace("DPN_MSGID_CREATE_PLAYER\n"); > + indicate_cnt++; > + break; > case DPN_MSGID_CREATE_PLAYER: > - nCreatePlayer = TRUE; > + trace("DPN_MSGID_CREATE_PLAYER\n"); > + create_cnt++; > break; > case DPN_MSGID_DESTROY_PLAYER: > - nDestroyPlayer = TRUE; > + trace("DPN_MSGID_DESTROY_PLAYER\n"); > + destroy_dnt++; > break; > + default: > + trace("msgid: 0x%08x\n", dwMessageId); > + } > + > + return S_OK; > +} > + > +static HRESULT WINAPI DirectPlayClientMsHandler(void *context, DWORD dwMessageId, void *buffer) > +{ > + HRESULT hr; > + > + switch(dwMessageId) > + { > + case DPN_MSGID_ENUM_HOSTS_RESPONSE: > + { > + DPNMSG_ENUM_HOSTS_RESPONSE *host_msg; > + host_msg = (PDPNMSG_ENUM_HOSTS_RESPONSE)buffer; > + > + trace("DPN_MSGID_ENUM_HOSTS_RESPONSE\n"); > + > + hr = IDirectPlay8Address_Duplicate(host_msg->pAddressSender, &hostAddr); > + ok(hr == S_OK, "Failed to Duplicate Host Address\n"); > + > + hr = IDirectPlay8Address_Duplicate(host_msg->pAddressDevice, &deviceAddr); > + ok(hr == S_OK, "Failed to Duplicate Device Address\n"); > + > + memset(&hostdesc, 0, sizeof(DPN_APPLICATION_DESC)); > + memcpy(&hostdesc, host_msg->pApplicationDescription, sizeof(DPN_APPLICATION_DESC) ); > + > + lstrcpyW(session, host_msg->pApplicationDescription->pwszSessionName); > + > + trace("SessionName: %s\n", wine_dbgstr_w(session)); > + ok(!lstrcmpW(session, sessionname), "incorrect name %s\n", wine_dbgstr_w(session)); > + > + SetEvent(hostenum); > + break; > + } > + case DPN_MSGID_ASYNC_OP_COMPLETE: > + trace("DPN_MSGID_ASYNC_OP_COMPLETE\n"); > + break; > + case DPN_MSGID_CONNECT_COMPLETE: > + trace("DPN_MSGID_CONNECT_COMPLETE\n"); > + SetEvent(connect); > + break; > + default: > + trace("DirectPlayClientMsHandler: 0x%08x\n", dwMessageId); > } > > return S_OK; > @@ -49,7 +111,6 @@ static HRESULT WINAPI DirectPlayMessageHandler(PVOID pvUserContext, DWORD dwMess > static void create_server(void) > { > HRESULT hr; > - IDirectPlay8Server *server = NULL; > > hr = CoCreateInstance( &CLSID_DirectPlay8Server, NULL, CLSCTX_ALL, &IID_IDirectPlay8Server, (LPVOID*)&server); > ok(hr == S_OK, "Failed to create IDirectPlay8Server object\n"); > @@ -74,6 +135,10 @@ static void create_server(void) > hr = IDirectPlay8Address_SetSP(localaddr, &CLSID_DP8SP_TCPIP); > ok(hr == S_OK, "got 0x%08x\n", hr); > > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, localhost, sizeof(localhost), > + DPNA_DATATYPE_STRING); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > memset( &appdesc, 0, sizeof(DPN_APPLICATION_DESC) ); > appdesc.dwSize = sizeof( DPN_APPLICATION_DESC ); > appdesc.dwFlags = DPNSESSION_CLIENT_SERVER; > @@ -83,16 +148,111 @@ static void create_server(void) > hr = IDirectPlay8Server_Host(server, &appdesc, &localaddr, 1, NULL, NULL, NULL, 0); > todo_wine ok(hr == S_OK, "got 0x%08x\n", hr); > > - todo_wine ok(nCreatePlayer, "No DPN_MSGID_CREATE_PLAYER Message\n"); > - ok(!nDestroyPlayer, "Received DPN_MSGID_DESTROY_PLAYER Message\n"); > - > - hr = IDirectPlay8Server_Close(server, 0); > - todo_wine ok(hr == S_OK, "got 0x%08x\n", hr); > - > - todo_wine ok(nDestroyPlayer, "No DPN_MSGID_DESTROY_PLAYER Message\n"); > + todo_wine ok(create_cnt == 1, "No DPN_MSGID_CREATE_PLAYER Message\n"); > + ok(indicate_cnt == 0, "wrong indicate count (%d)\n", indicate_cnt); > > IDirectPlay8Address_Release(localaddr); > } > + } > +} > + > +static void create_client(void) > +{ > + HRESULT hr; > + IDirectPlay8Address *host = NULL; > + IDirectPlay8Address *device = NULL; > + DPN_APPLICATION_DESC appdesc; > + DWORD ret; > + DPNHANDLE async = 0; > + > + hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > + ok(hr == S_OK, "CoCreateInstance failed with 0x%x\n", hr); > + if(hr != S_OK) > + return; > + > + memset( &appdesc, 0, sizeof(DPN_APPLICATION_DESC) ); > + appdesc.dwSize = sizeof( DPN_APPLICATION_DESC ); > + appdesc.guidApplication = appguid; > + > + connect = CreateEventA( NULL, TRUE, FALSE, NULL); > + hostenum = CreateEventA( NULL, TRUE, FALSE, NULL); > + > + hr = IDirectPlay8Client_Initialize(client, NULL, DirectPlayClientMsHandler, 0); > + ok(hr == S_OK, "IDirectPlay8Client_Initialize failed with %x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&host); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(host, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&device); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(device, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_AddComponent(host, DPNA_KEY_HOSTNAME, localhost, sizeof(localhost), > + DPNA_DATATYPE_STRING); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&device); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(device, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Client_EnumHosts(client, &appdesc, host, device, NULL, 0, INFINITE, 0, INFINITE, NULL, &async, 0); > + todo_wine ok(hr == DPNSUCCESS_PENDING, "IDirectPlay8Client_EnumServiceProviders failed with 0x%08x\n", hr); > + todo_wine ok(async, "No Handle returned\n"); > + > + ret = WaitForSingleObject(hostenum, 2000); > + todo_wine ok(ret == WAIT_OBJECT_0, "Failed to get find host\n"); > + if(ret == WAIT_OBJECT_0) > + { > + DPNHANDLE handle = 0; > + > + hr = IDirectPlay8Client_Connect(client, &hostdesc, hostAddr, deviceAddr, NULL, NULL, NULL, 0, NULL, &handle, 0 ); > + todo_wine ok(hr == DPNSUCCESS_PENDING, "IDirectPlay8Client_EnumServiceProviders failed with 0x%08x\n", hr); > + > + ret = WaitForSingleObject(connect, 2000); > + todo_wine ok(ret == WAIT_OBJECT_0, "Connect failed.\n"); > + > + todo_wine ok(create_cnt == 1, "Wrong create player count (%d)\n", create_cnt); > + todo_wine ok(destroy_dnt == 0, "Wrong Destroy player count (%d)\n", destroy_dnt); > + todo_wine ok(indicate_cnt == 1, "wrong indicate count (%d)\n", indicate_cnt); > + } > + > + CloseHandle(connect); > + CloseHandle(hostenum); > + > + SetEvent(clientfinished); > + > + IDirectPlay8Address_Release(host); > + IDirectPlay8Address_Release(device); > +} > + > +static void cleanup(void) > +{ > + HRESULT hr; > + > + if(client) > + { > + IDirectPlay8Client_Close(client, 0); > + IDirectPlay8Client_Release(client); > + } > + > + if(hostAddr) > + IDirectPlay8Address_Release(hostAddr); > + if(deviceAddr) > + IDirectPlay8Address_Release(deviceAddr); > + > + if(server) > + { > + hr = IDirectPlay8Server_Close(server, 0); > + todo_wine ok(hr == S_OK, "got 0x%08x\n", hr); > + > + todo_wine ok(destroy_dnt == 2 || broken(destroy_dnt == 1), "Wrong Destroy player count (%d)\n", destroy_dnt); > > IDirectPlay8Server_Release(server); > } > @@ -109,5 +269,9 @@ START_TEST(server) > > create_server(); > > + create_client(); > + > + cleanup(); > + > CoUninitialize(); > } > -- > 2.6.1 > > >

1 0

Re: include/wine: make LegalCopyright match CompanyName (resend)
by Michael Stefaniuc 15 Oct '15

15 Oct '15

On 10/15/2015 01:02 PM, Austin English wrote: > Previous patch was dropped without comment. > > For https://bugs.winehq.org/show_bug.cgi?id=35659 > 0001-include-wine-make-LegalCopyright-match-CompanyName-r.txt > > > From 3430c0e8fceb605b42fc4424be03f1d8a745c365 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Thu, 15 Oct 2015 05:59:58 -0500 > Subject: [PATCH] include/wine: make LegalCopyright match CompanyName (resend) > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > include/wine/wine_common_ver.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/wine/wine_common_ver.rc b/include/wine/wine_common_ver.rc > index 5938582..52024aa 100644 > --- a/include/wine/wine_common_ver.rc > +++ b/include/wine/wine_common_ver.rc > @@ -106,7 +106,7 @@ FILESUBTYPE WINE_FILESUBTYPE > VALUE "FileDescription", WINE_FILEDESCRIPTION_STR > VALUE "FileVersion", WINE_FILEVERSION_STR > VALUE "InternalName", WINE_FILENAME > - VALUE "LegalCopyright", "Copyright (c) 1993-2015 the Wine project authors (see the file AUTHORS for a complete list)" > + VALUE "LegalCopyright", "Microsoft Corporation" /* CATIA needs this in both CompanyName _and_ LegalCopyright */ CATIA needs that only to verify that the host has a certified OpenGL driver. So for compatibility reasons that needs to go only to opengl32.dll, we don't have to spread that around. And that's actually what focht proposed. bye michael

2 1

Re: [v2 2/4] wined3d: make wined3d_device_get_front_buffer_data work with wined3d_texture and sub_resource_index
by Henri Verbeet 15 Oct '15

15 Oct '15

On 13 October 2015 at 18:45, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > HRESULT CDECL wined3d_device_get_front_buffer_data(const struct wined3d_device *device, > - UINT swapchain_idx, struct wined3d_surface *dst_surface) > + UINT swapchain_idx, struct wined3d_texture *texture, unsigned int sub_resource_idx) > { > + struct wined3d_resource *sub_resource; > struct wined3d_swapchain *swapchain; > > - TRACE("device %p, swapchain_idx %u, dst_surface %p.\n", device, swapchain_idx, dst_surface); > + TRACE("device %p, swapchain_idx %u, texture %p, sub_resource_idx %u.\n", device, swapchain_idx, texture, sub_resource_idx); > > - if (!(swapchain = wined3d_device_get_swapchain(device, swapchain_idx))) > + sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx); > + > + if (!sub_resource || !(swapchain = wined3d_device_get_swapchain(device, swapchain_idx))) > return WINED3DERR_INVALIDCALL; > > - return wined3d_swapchain_get_front_buffer_data(swapchain, dst_surface); > + return wined3d_swapchain_get_front_buffer_data(swapchain, surface_from_resource(sub_resource)); > } It's a little harder than that, I'm afraid. In particular, you can't assume the sub-resource is a surface here. (I.e., "texture" could be a volume texture.) In general, the rule is that anywhere you use surface_from_resource() you should make sure the resource is actually the surface in some way. In this specific case, the answer is probably that wined3d_device_get_front_buffer_data() should just go away, and callers should use wined3d_swapchain_get_front_buffer_data() directly instead. Of course that only slightly moves the problem, so wined3d_swapchain_get_front_buffer_data() should then verify that it gets an appropriate texture when you make the equivalent change there.

2 2

Re: [v2 3/4] wined3d: make wined3d_device_set_cursor_properties work with wined3d_texture and sub_resource_index
by Henri Verbeet 15 Oct '15

15 Oct '15

On 13 October 2015 at 18:45, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > HRESULT CDECL wined3d_device_set_cursor_properties(struct wined3d_device *device, > - UINT x_hotspot, UINT y_hotspot, struct wined3d_surface *cursor_image) > + UINT x_hotspot, UINT y_hotspot, struct wined3d_texture *texture, unsigned int sub_resource_idx) > { > - TRACE("device %p, x_hotspot %u, y_hotspot %u, cursor_image %p.\n", > - device, x_hotspot, y_hotspot, cursor_image); > + struct wined3d_resource *sub_resource; > + struct wined3d_surface *cursor_image; > + > + TRACE("device %p, x_hotspot %u, y_hotspot %u, texture %p, sub_resource_idx %u.\n", > + device, x_hotspot, y_hotspot, texture, sub_resource_idx); > + > + sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx); > + > + if (!sub_resource) > + return WINED3DERR_INVALIDCALL; You can merge these lines: if (!(sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx))) return WINED3DERR_INVALIDCALL; Other than that, this has the same issue as patch 2/4 that "sub_resource" isn't necessarily a surface.

1 0

Re: [PATCH 1/6] d3d11: Implement d3d11_immediate_context_IASetPrimitiveTopology().
by Józef Kucia 15 Oct '15

15 Oct '15

On Wed, Oct 14, 2015 at 2:08 AM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/device.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c > index 8a7a794..a06f3e6 100644 > --- a/dlls/d3d11/device.c > +++ b/dlls/d3d11/device.c > @@ -39,6 +39,12 @@ static inline struct d3d11_immediate_context *impl_from_ID3D11DeviceContext(ID3D > return CONTAINING_RECORD(iface, struct d3d11_immediate_context, ID3D11DeviceContext_iface); > } > > +static inline struct d3d_device *device_from_immediate_ID3D11DeviceContext(ID3D11DeviceContext *iface) > +{ > + struct d3d11_immediate_context *context = impl_from_ID3D11DeviceContext(iface); > + return CONTAINING_RECORD(context, struct d3d_device, immediate_context); > +} > + > static HRESULT STDMETHODCALLTYPE d3d11_immediate_context_QueryInterface(ID3D11DeviceContext *iface, > REFIID riid, void **out) > { > @@ -249,7 +255,13 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_GSSetShader(ID3D11DeviceCo > static void STDMETHODCALLTYPE d3d11_immediate_context_IASetPrimitiveTopology(ID3D11DeviceContext *iface, > D3D11_PRIMITIVE_TOPOLOGY topology) > { > - FIXME("iface %p, topology %u stub!\n", iface, topology); > + struct d3d_device *device = device_from_immediate_ID3D11DeviceContext(iface); We could alternatively keep a pointer to d3d_device in d3d_immediate_context instead of a pointer to ID3D11Device.

2 4

Implementing the console font table
by Hugh McMaster 15 Oct '15

15 Oct '15

I'm implementing a version of the console font table, as it is needed by GetCurrentConsoleFont and friends. The Windows VMs on the testbot have the console font tables listed in [1]. As you can see, most of the font tables are the same (although the table itself depends on the host configuration). If the user changes the console font size, the new size is added to the table (if it is not already listed) and the active font index (nFont) re-assigned. 1. How much of the Windows table should be implemented in Wine? (Windows programs call GetCurrentConsoleFont, then pass the active font index to GetConsoleFontSize to retrieve the actual cell width/height). Keep in mind that Wine generally uses fonts not available on Windows, meaning the testbot data is somewhat irrelevant. It seems to me that we could simply use the registry font size as index 0 and add any new font sizes selected by the user to the array later. 2. Where to implement this functionality? In kernel32? Any comments/opinions welcome. [1] https://www.dropbox.com/s/bsvgxlwoamybu0y/font-table.pdf?dl=0 -- Hugh McMaster

2 2

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 4).
by Alexandre Julliard 14 Oct '15

14 Oct '15

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > This patch adds support for the basic file-transfer operation of > TransmitFile. It reads the file in as "bytes_per_send" chunks, which > it then sends to the destination using WS2_send. This process is > repeated synchronously (until patch 5 adds async support) until the > entire file is sent. It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p ws2_32_test.exe.so sock && touch sock.ok sock.c:2399: Tests skipped: SOCK_RAW is not supported sock.c:7545: Test failed: TransmitFile failed unexpectedly. sock.c:7734: Tests skipped: Cannot test SIO_ADDRESS_LIST_CHANGE, interactive tests must be enabled make: *** [sock.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

wine Presentation at ubucon Berlin - Powered by Codeweavers and Software Freedom Conservancy Project
by Maik Wagner 14 Oct '15

14 Oct '15

Hello everyone, thanks to Jeremy White and Sebastian (who made me aware of this) I have received funding to hold a presentation on wine in Berlin. The conference is called ubucon and is focussed on Ubuntu Linux which takes place from 23-25 October in Berlin at the premises of a privately owned higher education institution in Friedrichstraße. There is a quite well-known forum at ubuntuusers.de where I give regular support concerning wine. It's mostly helping people getting their games to run and Microsoft Office issues also come up frequently. I post a link to my presentation which will take about one hour. The time slot afterwards is still free and I am willing to take this longer if the room is still free and people are interested http://ubucon.de/2015/programm#wine I have attached the slides which I have developed so far and I can certainly change the master slides to match a more wine-centric "corporate identity" if there is any. I will be leaving for Berlin next Friday and will be available during the whole conference if people are interested in talking to me. You can also ask me about "Crossover" as I am regularly submitting Beta-reports and made it to "Mythical" ranking. I am also maintaining some applications in AppDB (Fifa 2005 Demo, Crazy Taxi Demo, Nerf Arena Blast and Fotostation Pro) I will be bringing my Slackware 14.1 laptop as wine always compiles fine on this machine. It is a fairly old laptop though and still on 32-bits and a fairly broken graphics stack but I think it should be alright to show people that there is a development version around. I will also test and present some demos and show people how to file reports in AppDB. I will be reporting back on how the presentation went on this mailing-list as this is part of the sponsorship deal. Again, thanks to everyone who supported this. Please feel free to write to me and share some ideas, comments etc. Best regards, Maik Wagner

2 3

Re: [PATCH 3/3] ws2_32: Add asynchronous support for TransmitFile.
by Alexandre Julliard 14 Oct '15

14 Oct '15

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > + LARGE_INTEGER offset; > + int status; > + > + /* set the file offset to the desired point */ > + offset.u.LowPart = overlapped->u.s.Offset; > + offset.u.HighPart = overlapped->u.s.OffsetHigh; > + SetFilePointerEx( wsa->file, offset, NULL, FILE_BEGIN ); You need to handle overlapped files differently, using pread() instead of setting the file pointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd/tests: Simplify boolean expressions (PVS-Studio)
by Marvin 14 Oct '15

14 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17349 Your paranoid android. === wxppro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1383 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1384 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1385 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1386 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1387 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1388 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1389 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1390 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1392 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1395 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1396 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1397 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1398 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1399 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1400 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1401 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w2003std (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 716 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 726 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 735 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 739 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 745 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 746 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 748 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 761 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 783 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 784 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 786 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 787 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 788 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 789 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 790 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 791 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 792 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 793 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 794 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 795 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 796 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 797 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 798 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 799 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1383 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1384 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1385 (got 'C:\Documents and Settings\Administrator\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1386 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1387 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1388 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1389 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1390 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1392 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1395 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1396 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1397 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1398 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1399 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1400 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1401 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w1064 (32 bit batch) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 334 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === w1064 (64 bit batch) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 334 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

2 1

Re: [PATCH 2/5] wined3d: Remove wined3d_device_present (v2).
by Henri Verbeet 14 Oct '15

14 Oct '15

On 8 October 2015 at 20:09, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > index c995afb..1355a95 100644 > --- a/dlls/d3d9/swapchain.c > +++ b/dlls/d3d9/swapchain.c > @@ -118,10 +118,6 @@ static HRESULT WINAPI DECLSPEC_HOTPATCH d3d9_swapchain_Present(IDirect3DSwapChai > struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(swapchain->parent_device); > HRESULT hr; > > - TRACE("iface %p, src_rect %s, dst_rect %s, dst_window_override %p, dirty_region %p, flags %#x.\n", > - iface, wine_dbgstr_rect(src_rect), wine_dbgstr_rect(dst_rect), > - dst_window_override, dirty_region, flags); > Why would you want to do that?

2 1

Re: [PATCH] d3d8, 9/tests: Use BOOL variable for ShowCursor return value (PVS-Studio)
by Marvin 14 Oct '15

14 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17345 Your paranoid android. === w1064 (64 bit device) === device.c:4213: Test failed: cw is 0xf60, expected 0x7f. device.c:4222: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH] d3d8, 9/tests: Use BOOL variable for ShowCursor return value (PVS-Studio)
by Marvin 14 Oct '15

14 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17344 Your paranoid android. === w1064 (32 bit device) === device.c:2612: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2617: Test failed: The focus window is active. device.c:2625: Test failed: Got unexpected hr 0x88760869. device.c:2631: Test failed: Got unexpect screen size 1152x870. device.c:2646: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=2. device.c:2655: Test failed: Got unexpect screen size 1152x870. device.c:2668: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2676: Test failed: Got unexpect width 1152. device.c:2677: Test failed: Got unexpect height 864.

1 0

Re: [PATCH] gdi32: Return default palette entries from GetSystemPaletteEntries for non-palette-based devices. (try 4, resend)
by Huw Davies 14 Oct '15

14 Oct '15

On 14 Oct 2015, at 07:13, Anton Baskanov wrote: > diff --git a/dlls/gdi32/palette.c b/dlls/gdi32/palette.c > index d850d0f..70a75d8 100644 > --- a/dlls/gdi32/palette.c > +++ b/dlls/gdi32/palette.c > @@ -418,8 +418,39 @@ UINT WINAPI GetSystemPaletteEntries( > + { > + if (entries && start < 256) > + { > + UINT i; > + const RGBQUAD *default_entries; > + > + if (start + count > 256) count = 256 - start; > + > + default_entries = get_default_color_table( 8 ); > + for (i = 0; i < count; ++i) > + { > + if (start + i < 10 || start + i >= 246) > + { > + entries[i].peRed = default_entries[start + i].rgbRed; > + entries[i].peGreen = default_entries[start + i].rgbGreen; > + entries[i].peBlue = default_entries[start + i].rgbBlue; > + } > + else > + { > + entries[i].peRed = 0; > + entries[i].peGreen = 0; > + entries[i].peBlue = 0; > + } > + entries[i].peFlags = 0; > + } > + } > + } I think this should be moved to nulldrv_GetSystemPaletteEntries(). Then X11DRV_GetSystemPaletteEntries() should forward to this (using GET_NEXT_PHYSDEV) in the case that 'palette_size' is zero. This avoids the ugly GetDeviceCaps call at the beginning. Huw.

1 0

Re: [v2 1/6] d3d8: make use of wined3d_texture_map in d3d8_surface_LockRect
by Henri Verbeet 13 Oct '15

13 Oct '15

On 11 October 2015 at 13:29, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c > index 20027a7..8f66112 100644 > --- a/dlls/d3d11/device.c > +++ b/dlls/d3d11/device.c > @@ -3007,11 +3007,11 @@ static void CDECL device_parent_activate(struct wined3d_device_parent *device_pa > } > > static HRESULT CDECL device_parent_surface_created(struct wined3d_device_parent *device_parent, > - void *container_parent, struct wined3d_surface *surface, void **parent, > + struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, struct wined3d_surface *surface, void **parent, > const struct wined3d_parent_ops **parent_ops) > { > - TRACE("device_parent %p, container_parent %p, surface %p, parent %p, parent_ops %p.\n", > - device_parent, container_parent, surface, parent, parent_ops); > + TRACE("device_parent %p, wined3d_texture %p, sub_resource_idx %u, surface %p, parent %p, parent_ops %p.\n", > + device_parent, wined3d_texture, sub_resource_idx, surface, parent, parent_ops); > > *parent = NULL; > *parent_ops = &d3d10_null_wined3d_parent_ops; This series looks fine, but there's a (trivial) merge conflict due to commit a865b14aedb01def345c09732717c3c5f2eb6dab.

3 2

ddraw cleanup
by Riccardo Bortolato 13 Oct '15

13 Oct '15

Hi, While sending the other cleanup patches I worked towards wined3d_surface freedom in ddraw and reached a critical point (aka it's the last thing I need to do and it's something that needs a strong decision): in order to get rid of wined3d_surface_get_resource() I need to accomodate the wined3d_resource_get_desc() call inside ddraw_surface_init() (ddraw/surface.c). Since the callback is executed when the wined3d_texture->sub_resources list isn't ready yet, I cannot use wined3d_texture_get_sub_resource(). So here are the ideas so far: - keep wined3d surface in the callback only (really ugly) - move the wined3d_resource_get_desc() calls in a loop after wined3d_texture_create() (kind of ugly) - do magic in wined3d (really unlikely?) Any ideas? Ciao, Riccardo

2 1

Re: [PATCH 4/7] wined3d: make wined3d_device_set_cursor_properties work with wined3d_texture and sub_resource_index
by Henri Verbeet 13 Oct '15

13 Oct '15

On 12 October 2015 at 17:23, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > HRESULT CDECL wined3d_device_set_cursor_properties(struct wined3d_device *device, > - UINT x_hotspot, UINT y_hotspot, struct wined3d_surface *cursor_image) > + UINT x_hotspot, UINT y_hotspot, struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx) "wined3d_texture" is redundant inside wined3d, just "texture" is fine. > { > + struct wined3d_resource *sub_resource = wined3d_texture_get_sub_resource(wined3d_texture, sub_resource_idx); > + struct wined3d_surface *cursor_image; > + > + if (!sub_resource) > + return WINED3DERR_INVALIDCALL; > + > + cursor_image = surface_from_resource(sub_resource); > + > TRACE("device %p, x_hotspot %u, y_hotspot %u, cursor_image %p.\n", > device, x_hotspot, y_hotspot, cursor_image); Like in 3/7, please move most of the new lines after the TRACE, and then update the trace to match the parameters.

1 0

Re: [PATCH 3/7] wined3d: make wined3d_device_get_front_buffer_data work with wined3d_texture and sub_resource_index
by Henri Verbeet 13 Oct '15

13 Oct '15

On 12 October 2015 at 17:23, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > HRESULT CDECL wined3d_device_get_front_buffer_data(const struct wined3d_device *device, > - UINT swapchain_idx, struct wined3d_surface *dst_surface) > + UINT swapchain_idx, struct wined3d_texture *texture, unsigned int sub_resource_idx) > { > + struct wined3d_resource *sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx); I'd rather have the wined3d_texture_get_sub_resource() call after the TRACE. It's not too much of an issue, but it does affect the order of the traces in the debug output. > - TRACE("device %p, swapchain_idx %u, dst_surface %p.\n", device, swapchain_idx, dst_surface); > + TRACE("device %p, swapchain_idx %u, texture %p, sub_index %u.\n", device, swapchain_idx, texture, sub_resource_idx); And please just match the parameter name here.

1 0

Re: [PATCH 1/7] d3d8: use wined3d_rendertarget_view_create instead of wined3d_rendertarget_view_create_from_surface in d3d8_surface_get_rendertarget_view
by Henri Verbeet 13 Oct '15

13 Oct '15

On 12 October 2015 at 17:23, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + resource = wined3d_texture_get_resource(surface->wined3d_texture); > + if (!resource) > + { > + ERR("No resource found.\n"); > + return NULL; > + } wined3d_texture_get_resource() can't fail.

1 0

Re: [PATCH 1/4] ole32: Hold a reference to the stub manager throughout an incoming call.
by Jacek Caban 13 Oct '15

13 Oct '15

Hi Huw, On 10/13/15 15:49, Huw Davies wrote: > -HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, IRpcStubBuffer **stub, IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN; > +HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, struct stub_manager **manager, IRpcStubBuffer **stub, > + IRpcChannelBuffer **chan, IID *iid, IUnknown **iface) DECLSPEC_HIDDEN; How about returning stub manager instead of APARTMENT? It already contains APARTMENT reference. Thanks, Jacek

2 1

Re: [PATCH 3/4] ole32/tests: Test calling CoDisconnectObject from within a COM call to the object.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17337 Your paranoid android. === w8 (32 bit marshal) === marshal.c:3473: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3490: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3528: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3546: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3510: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3473: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3490: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3528: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3546: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3510: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3473: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3490: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3528: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3546: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x694 instead of 0xff0 marshal.c:3510: Test failed: info->cbSize was -86228343 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x694 instead of 0xff0 === w864 (32 bit marshal) === marshal.c:3473: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3490: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3528: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3546: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3510: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3473: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3490: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3528: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3546: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3510: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3473: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3490: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3528: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3546: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 marshal.c:3510: Test failed: info->cbSize was 48454452 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0xcc instead of 0x7e8 === w1064 (32 bit marshal) === marshal.c:3473: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3490: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3528: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3513: Test failed: info->pObject shouldn't be NULL marshal.c:3473: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3490: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3528: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3513: Test failed: info->pObject shouldn't be NULL marshal.c:3473: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3474: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3490: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3491: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3528: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3529: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3547: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1482345884 instead of 48 marshal.c:3511: Test failed: info->dwServerPid was 0x139c instead of 0xc6c marshal.c:3513: Test failed: info->pObject shouldn't be NULL === w864 (64 bit marshal) === marshal.c:3473: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3490: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3528: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3546: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3510: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3473: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3490: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3528: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3546: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3510: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3473: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3490: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3528: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3546: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x960 instead of 0xa14 marshal.c:3510: Test failed: info->cbSize was -418054392 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x960 instead of 0xa14 === w1064 (64 bit marshal) === marshal.c:3473: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3490: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3528: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3513: Test failed: info->pObject shouldn't be NULL marshal.c:3473: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3490: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3528: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3513: Test failed: info->pObject shouldn't be NULL marshal.c:3473: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3474: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3490: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3491: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3528: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3529: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3530: Test failed: info->pObject shouldn't be NULL marshal.c:3546: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3547: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3548: Test failed: info->pObject shouldn't be NULL marshal.c:3510: Test failed: info->cbSize was -1670162658 instead of 56 marshal.c:3511: Test failed: info->dwServerPid was 0x370 instead of 0xafc marshal.c:3513: Test failed: info->pObject shouldn't be NULL

2 1

Re: [PATCH v3] d3d8/tests: Uninitialized varyings tests.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17335 Your paranoid android. === build (build) === Make failed

1 0

Re: mshtml: Fixed some tests on win10.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17332 Your paranoid android. === w1064 (32 bit htmldoc) === htmldoc.c:3559: Test failed: unexpected call IsErrorUrl htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc} htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc} htmldoc.c:2877: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2877: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc} === w1064 (64 bit htmldoc) === htmldoc.c:3559: Test failed: unexpected call IsErrorUrl htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc} htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc} htmldoc.c:2877: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2877: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:875: Test failed: unexpected call {ede9319b-a823-403d-bd14-14c8adfe67dc}

1 0

Re: [PATCH 2/5] wined3d: Pass a context to read_from_framebuffer.
by Matteo Bruni 13 Oct '15

13 Oct '15

2015-10-12 22:34 GMT+02:00 Stefan Dösinger <stefan(a)codeweavers.com>: > Sometimes the context won't be reusable because we need a specific > context to access the WGL drawable. Afterwards we need to switch back to > the caller's context. Bug 34574 is related to this. This is only > relevant for backbuffer offscreen rendering, and in practise it is rare. > It'll only matter if the application is blitting from an onscreen > surface to a currently active offscreen one. For everything else the > offscreen surface is copied into the texture when it is deactivated. > > Note that in most cases the wined3d_context * structure is the same for > both surfaces involved in the blit, but context->render_offscreen > differs for source and destination. That's why context_restore needs a > surface and not the old context. > > I'm open to placing the extra context_acquire / context_release calls > into the callers. We need them in 4 places: read_from_framebuffer, > surface_blt_to_drawable, surface_blt_fbo and surface_load_fb_texture. Yes, IMHO that would be better, although I haven't actually tried that so it might turn out to be bad in practice. Obviously ignore this suggestion altogether if Henri thinks otherwise :P

2 2

Re: [PATCH 4/5] wined3d: Pass a context to surface_load_drawable.
by Matteo Bruni 13 Oct '15

13 Oct '15

2015-10-12 22:34 GMT+02:00 Stefan Dösinger <stefan(a)codeweavers.com>: > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > --- > dlls/wined3d/surface.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index f5ee7e1..c70b709 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -3850,11 +3850,11 @@ static void surface_load_sysmem(struct wined3d_surface *surface, > surface, wined3d_debug_location(surface->locations)); > } > > +/* Context activation is done by the caller. */ > static HRESULT surface_load_drawable(struct wined3d_surface *surface, > - const struct wined3d_gl_info *gl_info) > + struct wined3d_context *context) > { > RECT r; > - struct wined3d_context *context; > > if (wined3d_settings.offscreen_rendering_mode == ORM_FBO > && wined3d_resource_is_offscreen(&surface->container->resource)) > @@ -3863,12 +3863,10 @@ static HRESULT surface_load_drawable(struct wined3d_surface *surface, > return WINED3DERR_INVALIDCALL; > } > > - context = context_acquire(surface->resource.device, surface); > surface_get_rect(surface, NULL, &r); > surface_load_location(surface, WINED3D_LOCATION_TEXTURE_RGB); > surface_blt_to_drawable(surface->resource.device, context, > WINED3D_TEXF_POINT, FALSE, surface, &r, surface, &r); > - context_release(context); > > return WINED3D_OK; > } > @@ -4125,7 +4123,10 @@ HRESULT surface_load_location(struct wined3d_surface *surface, DWORD location) > break; > > case WINED3D_LOCATION_DRAWABLE: > - if (FAILED(hr = surface_load_drawable(surface, gl_info))) > + context = context_acquire(device, NULL); > + hr = surface_load_drawable(surface, context); Doesn't this context_acquire() need to take the surface of the drawable into account (i.e. something like the context_acquire you're removing from surface_load_drawable())? Maybe the context is already guaranteed to be correct? If that's the case though perhaps a comment would help since it's not immediately obvious.

2 2

Re: [PATCH] advapi32/tests: Simplify conditional expression (PVS-Studio)
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17328 Your paranoid android. === w1064 (32 bit security) === security.c:3738: Test failed: MACHINE\Software owner SID != Administrators SID. security.c:3778: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:3782: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3791: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:3778: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:3782: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3791: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [PATCH v2 5/5] d3d8/tests: Uninitialized varyings tests.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17302 Your paranoid android. === w1064 (32 bit visual) === visual.c:8250: Test failed: Got unexpected color 0xffffffff, case 3. visual.c:8250: Test failed: Got unexpected color 0x00800000, case 5. visual.c:8250: Test failed: Got unexpected color 0x00800000, case 6.

2 1

Re: [PATCH 5/7] wined3d: introduce a new wined3d_texture_blt function
by Stefan Dösinger 13 Oct '15

13 Oct '15

> Am 12.10.2015 um 17:23 schrieb Riccardo Bortolato <rikyz619(a)gmail.com>: > > +HRESULT CDECL wined3d_texture_blt(struct wined3d_texture *dst_texture, unsigned int dst_idx, const RECT *dst_rect_in, > + struct wined3d_texture *src_texture, unsigned int src_idx, const RECT *src_rect_in, DWORD flags, > + const WINEDDBLTFX *fx, enum wined3d_texture_filter_type filter) I am not convinced that this is how we want blits to work. I was looking into some blit cleanups myself a few months ago, but got stuck in swapchain related sidequests, mostly to get rid of wined3d_swapchain_blit. My thinking re blitting is that we want to separate things into d3d9-style StretchRect (does color conversion, multisample resolve, stretching, color keying, ...) and CopySubresourceRegion (does sysmem<->vidmem transfers). Mapping d3d8+ methods on top of these calls is pretty simple. ddraw is trickier though and I cannot promise yet that it will work. Many things can be solved with staging resources, e.g. to split a color keyed sysmem -> vidmem blit into a copy_sub_resource_region upload and StretchRect color key blit. (StretchRect will need to be a bit more powerful than what d3d9 / d3d10 allow. At least we want sysmem<->sysmem blits supported by it). Henri was arguing for a more powerful blitter in wined3d if I understood him right, that would also be capable of handling the upload of converted surfaces (wined3d_format_texture_info.convert in utils.c). My concern is that this kind of blitter will turn into a god object that's more powerful than what we need (e.g. we don't need signed RGB -> unsigned RGB conversion while transfering from a sysmem vertex buffer to a vidmem volume texture), but I didn't get very far in proving that my alternative approach works.

2 1

Re: [PATCH 5/7] wined3d: introduce a new wined3d_texture_blt function
by Józef Kucia 13 Oct '15

13 Oct '15

Just some nitpicks. On Mon, Oct 12, 2015 at 5:23 PM, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > initial usage in d3d8 > > Signed-off-by: Riccardo Bortolato <rikyz619(a)gmail.com> > --- > dlls/d3d8/device.c | 12 ++++++------ > dlls/wined3d/texture.c | 14 ++++++++++++++ > dlls/wined3d/wined3d.spec | 1 + > include/wine/wined3d.h | 3 +++ > 4 files changed, 24 insertions(+), 6 deletions(-) > > diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c > index 2b11923..95684c7 100644 > --- a/dlls/d3d8/device.c > +++ b/dlls/d3d8/device.c > @@ -1093,8 +1093,8 @@ static HRESULT WINAPI d3d8_device_CopyRects(IDirect3DDevice8 *iface, > if (!rect_count && !src_rects && !dst_points) > { > RECT rect = {0, 0, src_w, src_h}; > - wined3d_surface_blt(dst->wined3d_surface, &rect, > - src->wined3d_surface, &rect, 0, NULL, WINED3D_TEXF_POINT); > + wined3d_texture_blt(dst->wined3d_texture, dst->sub_resource_idx, &rect, > + src->wined3d_texture, src->sub_resource_idx, &rect, 0, NULL, WINED3D_TEXF_POINT); > } > else > { > @@ -1109,8 +1109,8 @@ static HRESULT WINAPI d3d8_device_CopyRects(IDirect3DDevice8 *iface, > RECT dst_rect = {dst_points[i].x, dst_points[i].y, > dst_points[i].x + w, dst_points[i].y + h}; > > - wined3d_surface_blt(dst->wined3d_surface, &dst_rect, > - src->wined3d_surface, &src_rects[i], 0, NULL, WINED3D_TEXF_POINT); > + wined3d_texture_blt(dst->wined3d_texture, dst->sub_resource_idx, &dst_rect, > + src->wined3d_texture, src->sub_resource_idx, &src_rects[i], 0, NULL, WINED3D_TEXF_POINT); > } > } > else > @@ -1121,8 +1121,8 @@ static HRESULT WINAPI d3d8_device_CopyRects(IDirect3DDevice8 *iface, > UINT h = src_rects[i].bottom - src_rects[i].top; > RECT dst_rect = {0, 0, w, h}; > > - wined3d_surface_blt(dst->wined3d_surface, &dst_rect, > - src->wined3d_surface, &src_rects[i], 0, NULL, WINED3D_TEXF_POINT); > + wined3d_texture_blt(dst->wined3d_texture, dst->sub_resource_idx, &dst_rect, > + src->wined3d_texture, src->sub_resource_idx, &src_rects[i], 0, NULL, WINED3D_TEXF_POINT); > } > } > } > diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c > index d5f9591..d93c241 100644 > --- a/dlls/wined3d/texture.c > +++ b/dlls/wined3d/texture.c > @@ -1431,6 +1431,20 @@ static HRESULT volumetexture_init(struct wined3d_texture *texture, const struct > return WINED3D_OK; > } > > +HRESULT CDECL wined3d_texture_blt(struct wined3d_texture *dst_texture, unsigned int dst_idx, const RECT *dst_rect_in, > + struct wined3d_texture *src_texture, unsigned int src_idx, const RECT *src_rect_in, DWORD flags, > + const WINEDDBLTFX *fx, enum wined3d_texture_filter_type filter) > +{ > + struct wined3d_resource *dst_resource = wined3d_texture_get_sub_resource(dst_texture, dst_idx); > + struct wined3d_resource *src_resource = wined3d_texture_get_sub_resource(src_texture, src_idx); > + > + if (!dst_resource || !src_resource) > + return WINED3DERR_INVALIDCALL; > + > + return wined3d_surface_blt(surface_from_resource(dst_resource), dst_rect_in, > + surface_from_resource(src_resource), src_rect_in, flags, fx, filter); > +} > + > HRESULT CDECL wined3d_texture_create(struct wined3d_device *device, const struct wined3d_resource_desc *desc, > UINT level_count, DWORD surface_flags, const struct wined3d_sub_resource_data *data, void *parent, > const struct wined3d_parent_ops *parent_ops, struct wined3d_texture **texture) > diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec > index 1569e24..22c6d23 100644 > --- a/dlls/wined3d/wined3d.spec > +++ b/dlls/wined3d/wined3d.spec > @@ -259,6 +259,7 @@ > @ cdecl wined3d_swapchain_set_window(ptr ptr) > > @ cdecl wined3d_texture_add_dirty_region(ptr long ptr) > +@ cdecl wined3d_texture_blt(ptr long ptr ptr long ptr long ptr long) > @ cdecl wined3d_texture_create(ptr ptr long long ptr ptr ptr ptr) > @ cdecl wined3d_texture_decref(ptr) > @ cdecl wined3d_texture_generate_mipmaps(ptr) > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index 1735b95..b5f705c 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -2531,6 +2531,9 @@ void __cdecl wined3d_swapchain_set_window(struct wined3d_swapchain *swapchain, H > > HRESULT __cdecl wined3d_texture_add_dirty_region(struct wined3d_texture *texture, > UINT layer, const struct wined3d_box *dirty_region); > +HRESULT __cdecl wined3d_texture_blt(struct wined3d_texture *dst_texture, unsigned int dst_idx, const RECT *dst_rect_in, > + struct wined3d_texture *src_texture, unsigned int src_idx, const RECT *src_rect_in, DWORD flags, > + const WINEDDBLTFX *fx, enum wined3d_texture_filter_type filter); I think it would be preferred to use dst_sub_resource_idx and src_sub_resource_idx. Mostly for consistency. Also, the patch 6 and 7 should be probably merged. It doesn't make sense to leave unused fields just to remove them in the next patch.

2 1

Re: kernel32: add a stub for CancelSynchronousIo
by Dmitry Timoshkov 13 Oct '15

13 Oct '15

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI CancelSynchronousIo(HANDLE thread) > +{ > + FIXME("(%p): stub\n", thread); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return FALSE; > +} ... > +@ stdcall CancelSynchronousIo(ptr) Please have a look at other .spec file entries how a thread handle (or HANDLE in general) is supposed to be represented. -- Dmitry.

3 2

Re: [PATCH 2/2] dxgi/tests: Add test for IDXGIAdapter::CheckInterfaceSupport().
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17326 Your paranoid android. === w1064 (32 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1188: Test failed: Got unexpected hr 0x87a0001, test 39. === w1064 (64 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1242: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1242: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1188: Test failed: Got unexpected hr 0, test 39. device.c:1242: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1242: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: mshtml: Add IHTMLEditServices stub implementation. Take 4.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17322 Your paranoid android. === w1064 (32 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 === w1064 (64 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132

1 0

Re: mshtml: Add IHTMLEditServices stub implementation. Take 3.
by Marvin 13 Oct '15

13 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17315 Your paranoid android. === wxppro (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2003std (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === wvistau64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2008s64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w7u (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w7pro64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w8 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w864 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w1064 (32 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 === wvistau64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2008s64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w7pro64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w864 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w1064 (64 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132

3 3

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 3).
by Alexandre Julliard 13 Oct '15

13 Oct '15

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > + /* set reasonable defaults when requested */ > + if (!bytes_per_send) > + bytes_per_send = 1024; Is that the Windows default? It doesn't seem very reasonable to me, it won't even fill a network packet. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 4).
by Marvin 12 Oct '15

12 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17307 Your paranoid android. === w2008s64 (64 bit sock) === sock.c:5766: Test failed: Expected event sequence [FD_WRITE(0)], got [] sock.c:5787: Test failed: Expected event sequence [FD_READ(0) FD_CLOSE(0)], got [FD_READ(0) FD_WRITE(0) FD_CLOSE(0)]

1 0

Re: [PATCH 1/2] dxgi: Partially implement dxgi_adapter_CheckInterfaceSupport().
by Henri Verbeet 12 Oct '15

12 Oct '15

On 12 October 2015 at 03:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -200,9 +200,39 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_GetDesc(IDXGIAdapter1 *iface, DXGI > static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IDXGIAdapter1 *iface, > REFGUID guid, LARGE_INTEGER *umd_version) > { > - FIXME("iface %p, guid %s, umd_version %p stub!\n", iface, debugstr_guid(guid), umd_version); > + struct dxgi_adapter *adapter = impl_from_IDXGIAdapter1(iface); > + struct wined3d_adapter_identifier adapter_id; > + HRESULT hr; > + > + TRACE("iface %p, guid %s, umd_version %p.\n", iface, debugstr_guid(guid), umd_version); > + > + /* This method works only for D3D10 interfaces. */ > + if (!(IsEqualGUID(guid, &IID_ID3D10Device) > + || IsEqualGUID(guid, &IID_ID3D10Device1))) > + { > + WARN("Returning DXGI_ERROR_UNSUPPORTED for %s.\n", debugstr_guid(guid)); > + return DXGI_ERROR_UNSUPPORTED; > + } > + > + FIXME("Determine actual capabilities of adapter.\n"); Do you know what this does for hardware that doesn't support Direct3D10? Getting the capabilities isn't that hard, we already do that in dxgi_device_init(). (The wined3d_get_device_caps() call in particular.) > #include "dxgi.h" > +#include "d3d10_1.h" If you include d3d10_1.h you should be able to drop dxgi.h.

2 2

Re: [PATCH v2 4/5] d3d9/tests: Uninitialized varyings tests.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Matteo Bruni <mbruni(a)codeweavers.com> writes: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > v2: Update to the new helpers interface, fix WARP failures. > > dlls/d3d9/tests/visual.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 302 insertions(+) It fails here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:20243: Test failed: Got unexpected color 0xff7fffff, case 19. make: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] mshtml: Add IHTMLEditServices stub implementation. Take 2.
by Jacek Caban 12 Oct '15

12 Oct '15

Hi Dmitry, On 10/12/15 05:21, Dmitry Timoshkov wrote: > Thanks Jacek for the comments. > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/mshtml/htmldoc.c | 2 + > dlls/mshtml/main.c | 1 + > dlls/mshtml/mshtml_private.h | 1 + > dlls/mshtml/service.c | 137 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 141 insertions(+) The patch looks good to me now, but I still hope to see a test. It should be trivial, we even already have test_QueryService for that. Thanks, Jacek

2 1

Patch tracker emails
by Alexandre Julliard 12 Oct '15

12 Oct '15

Folks, As we discussed at WineConf, I have now modified the patch tracker to send a mail whenever a patch status is updated. I'm sure everybody will love that ;-) I tried to make the messages nice and encouraging, but I'm sure there's room for improvement. Feedback is welcome... -- Alexandre Julliard julliard(a)winehq.org

3 4

RFC - d3d9: Return success for UnlockRect attempts on already unlocked surfaces
by Bruno Jesus 12 Oct '15

12 Oct '15

Hi all, this is an attempt to fix bug 28874 [1]. The tests [2] run fine up to Windows 8, which unfortunately introduced a change in the behavior so I'm not sure how to handle this (broken?). Maybe a similar test is required in other d3d versions and a deeper change (wined3d_surface_unmap?) required to proper fix this. [1] - https://bugs.winehq.org/show_bug.cgi?id=28874 [2] - https://testbot.winehq.org/JobDetails.pl?Key=17252 Best wishes, Bruno

3 2

Re: [PATCH 2/3] user32: Send WM_COMMAND to parent window, not parent control.
by Marvin 12 Oct '15

12 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17285 Your paranoid android. === w1064 (32 bit msg) === msg.c:6100: Test failed: Update region shouldn't be empty msg.c:6334: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6336: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6100: Test failed: Update region shouldn't be empty msg.c:6334: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6336: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different

1 0

Re: [PATCH 1/3] user32: Test button parent messages.
by Marvin 12 Oct '15

12 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17284 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10622: Test failed: expected PeekMessage to return FALSE, got 1 === w1064 (32 bit msg) === msg.c:6103: Test failed: Update region shouldn't be empty msg.c:6337: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6339: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6103: Test failed: Update region shouldn't be empty msg.c:6337: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6339: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different

1 0

Re: [PATCH 2/2] dxgi/tests: Add test for IDXGIAdapter::CheckInterfaceSupport().
by Marvin 12 Oct '15

12 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17277 Your paranoid android. === w1064 (32 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1242: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1242: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1188: Test failed: Got unexpected hr 0, test 39. device.c:1242: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1242: Test failed: Got usage 160, expected 60, test 42, buffer 15. === w1064 (64 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1188: Test failed: Got unexpected hr 0x87a0001, test 39.

1 0

Re: [PATCH 3/3] ws2_32: Add asynchronous support for TransmitFile (resend).
by Marvin 12 Oct '15

12 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17267 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7346: Test failed: bytesReturned isn't supposed to be 1 sock.c:7370: Test failed: GetOverlappedResult failed, error 0

1 0

Speed of gdi vs opengl DirectDrawRenderer
by Jonas Maebe 11 Oct '15

11 Oct '15

Hi, I had a problem with Majesty Gold HD running at glacial speed on my machine (quad Core i5 2.9GHz, NVidia GeForce GT 750M 1GB, OS X 10.9.5). I'm using wine 1.7.35, but I've had similar problems with older wine versions. It's a DirectDraw7 game that has been partially remastered to run on modern systems, but still uses DirectDraw7. This is a common problem on Windows too, but generally can be resolved by telling the game to use the DirectDraw blitter (instead of blitting itself). That didn't help on Wine though. I profiled wine (Instruments time profile) and noticed that most time was spent in wined3d's convert_r5g6b5_x8r8g8b8. Replacing that routine with an optimized sse2 version from pixman did not make much of a difference. Then I discovered that if I told the game to render to a 16 bit instead of to a 32 bit surface, wine would let OpenGL handle the colour conversion. Unfortunately, while this significantly reduced wine's cpu usage, it by no means made the game any faster. Looking at the OpenGL Driver Monitor stats, it seems the cpu was simply waiting all the time on the GPU, probably while it was blitting all of those 1920x1080 images to the screen. Reducing the resolution to the lowest supported by the game (800x600) made it slightly faster, but not much. Next, I added the DirectDrawRenderer registry key and set it to gdi. Now, while it's still slow at 1920x1080, the game runs much faster at 800x600 and even still at 1024x768. Profiling the gdi renderer shows that it has way higher cpu usage than the OpenGL renderer (virtually all in convert_to_8888), but it seems that for some reason it has causes much less traffic to the GPU. The wiki's wording suggests the gdi renderer is deprecated though. Does that mean this qualifies as a bug in the OpenGL renderer (maybe it tries to update the screen more often than necessary, saturating the bus that way?), and are there any things I can try to narrow down why the gdi renderer is so much faster? I didn't immediately see where it blits things actually to the screen. Thanks, Jonas

4 10

Total bugs in WWN Issue 400
by Mathew Hodson 11 Oct '15

11 Oct '15

How is it that in WWN Issue 400, https://www.winehq.org/wwn/400, the total number of bugs has decreased? Was that an error or have some bugs been deleted? -- Sincerely, Mathew Hodson

4 4

wiki.winehq.org is down
by Austin English 11 Oct '15

11 Oct '15

Thought it may be my connection while travelling, but isup.me confirms it's down: http://isup.me/wiki.winehq.org could you please have a look? Thanks, -Austin

3 2

Re: [PATCH 1/6] d3d8: make use of wined3d_texture_map in d3d8_surface_LockRect
by Stefan Dösinger 11 Oct '15

11 Oct '15

2 1

stack realignment
by Marcus Meissner 11 Oct '15

11 Oct '15

Hi, (as small heads up) As we have this problem with the Win64 code calling us with non-16 byte aligned stacks, the gcc folks have now commited code to trunk gcc that allows -mincoming-stack-boundary=3 on October 7th. Uros also plans a backport for gcc 5. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66697 $ cat xx.c #include <stdio.h> int f(int a,int b) { printf("a=%d, b=%d\n", a, b); } -O2 build: 0000000000000000 <f>: 0: 89 f2 mov %esi,%edx 2: 31 c0 xor %eax,%eax 4: 89 fe mov %edi,%esi 6: bf 00 00 00 00 mov $0x0,%edi b: e9 00 00 00 00 jmpq 10 <f+0x10> -O2 -mincoming-stack-boundary=3 0000000000000000 <f>: 0: 4c 8d 54 24 08 lea 0x8(%rsp),%r10 5: 48 83 e4 f0 and $0xfffffffffffffff0,%rsp 9: 89 f2 mov %esi,%edx b: 31 c0 xor %eax,%eax d: 89 fe mov %edi,%esi f: bf 00 00 00 00 mov $0x0,%edi 14: 41 ff 72 f8 pushq -0x8(%r10) 18: 55 push %rbp 19: 48 89 e5 mov %rsp,%rbp 1c: 41 52 push %r10 1e: 48 83 ec 08 sub $0x8,%rsp 22: e8 00 00 00 00 callq 27 <f+0x27> 27: 48 83 c4 08 add $0x8,%rsp 2b: 41 5a pop %r10 2d: 5d pop %rbp 2e: 49 8d 62 f8 lea -0x8(%r10),%rsp 32: c3 retq It is more code emitted, but we can at least fix it without generating our own thunks. Ciao, Marcus

2 2

WineConf 2015 decisions
by Alexandre Julliard 10 Oct '15

10 Oct '15

Over the last few months there have been a lot of discussions about how to improve our development process. I've been gathering feedback, and last week at WineConf I summarized the suggestions in my keynote presentation; the slides can be viewed at http://wiki.winehq.org/WineConf2015?action=AttachFile&do=get&target=winecon… We've then had a lot of constructive discussions about the various points. The major decisions we've agreed on are: - Wine-staging is now considered an integral part of the Wine development process, and will be used as a mechanism to enable more patches to meet the requirements for inclusion in the main tree. We will all be working together as a team. - Bugs reported against wine-staging will be accepted in the WineHQ bug tracker; there will be a way to distinguish bugs specific to Staging, and bugs that are fixed in Staging but not yet in main Wine. The Staging bug tracker will be retired. Austin English is in charge of implementing the necessary changes in Bugzilla. - We will switch to a time-based stable release, on a yearly schedule. The code freeze will start every year in the fall. Michael Stefaniuc will be maintaining the stable branch starting with 1.8. - We will start enforcing a Signed-Off-By header on patches, to make it possible to better distribute reviewing responsibility, and to allow multiple authors to cooperate on a patch. - We will keep a list of maintainer contact information for the various submodules; developers will be encouraged to go through the respective maintainer before submitting to wine-patches. - There will be a group of people who volunteer to be assigned patches to review, to make sure that no patch goes unreviewed. Going through Staging first will also be encouraged for unfinished or risky patches. - The patch tracker will send automated emails when a patch status changes; this will also serve to encourage discussion rather than despair when a patch is not approved. - We will start building and distributing binary packages for all distros that don't have readily available packages. The packaging scripts and control files will be maintained in git, so that people can review them and submit improvements. These changes will be implemented over the next few weeks. I'm hoping that this will make the development process more pleasant for everybody, and enable us to better respond to users' needs. Once these changes are in place, I'll also encourage everybody who had given up in disgust to give us another chance; and if things are still not satisfactory, please send us feedback. This is a work in progress, and we will continue to listen and work on making things better. -- Alexandre Julliard julliard(a)winehq.org

9 17

Re: kernel32: add a stub for GetCurrentProcessorNumberEx (try 2)
by Sebastian Lackner 09 Oct '15

09 Oct '15

On 09.10.2015 12:15, Austin English wrote: > Try 2: > move implementation to ntdll.RtlGetCurrentProcessorNumberEx with a > forward from kernel32. > Initialize Group/Processor to 0. > > For https://bugs.winehq.org/show_bug.cgi?id=39376 > > +/********************************************************************** > + * RtlGetCurrentProcessorNumberEx [NTDLL.@] > + */ > +VOID WINAPI RtlGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER processor) I think its preferred to use PROCESSOR_NUMBER * here. > +{ > + processor->Group = 0; > + processor->Number = 0; The ->Number member could be initialized to the result to NtGetCurrentProcessorNumber(). Initializing ->Group to 0 is correct because Wine supports max 64 processors. According to MSDN, the struct also has a ->Reserved member, which probably should be set to zero. > + > + FIXME(":%p stub\n", processor); It might be better to print the FIXME before accessing the pointer, this allows to see if applications pass garbage pointers before the crash happens. ;) > +}

2 1

Re: [PATCH 5/5] maintainers: Update Direct3D-related sections.
by Stefan Dösinger 09 Oct '15

09 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-09 um 15:55 schrieb Matteo Bruni: > Stefan, I'm putting d3drm under the general Direct3D section at > the moment. Feel free to change that as you see fit. Fine with me :-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWF8a0AAoJEN0/YqbEcdMw96oP/j1MyVZNxrVNRFg7v6K1b6Zn mTbnDc17oZbrJOnUYTNs+FJhaCvffj5wFRh8dB1piX6ayMpvItzoTOFnYzhYowIS iElwL/V7iYr8x4fojbrn8OestiaI7j41Rv4jlTNLfcnMtbbBYonM3oxDkFxJhQPp lsKw5/qOPfDpw2RFry5d3FTbhpKcy6vdQHPcCa4fb0E/pHvvCtwCH00pje5TIO7b fV2FUl8YEbMHpP1W1zY9m2jWDuPk3ke14g/KsGBXcB3PVZUtqPw4Tb4hCjBsXEzr WMyv3LqLw3vvWwtGpN49pLSAE0jHiSMCbH1fq4kNsZkT7TdB3he7vce1ckzRQWKh cvL1DmrL4TfVv1nH3bENX9I80I5SDRlg8EFWI/BYQZgNGun4fXweslHZISBz4CqZ VpZO/PpDOtM6DJhDXn0WDgYqNKC7GsLsx8TPsNpLPt+f/aSM+0ozZUmwDWtZW1HX m0lwn2sXoJzVwZ858ukmLRh8KtXJhl3Nupp0Eppa3IbYCwZOWERcwyhSDV6CB5gD lLmff2NPBirX7/yAC3D5NXEcvIxEk7nJPi01EY+b8iofIlrIUHzfrNeKkEpDAv89 oM9DwD7ZwzO5ga8EDYMdDGV/UhmZlFRAWyYC9oz4M8QGyiHwmtuA6VGgGiYtCYjy /jvROBtdjkiTTUpb24i4 =mAJR -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/6] hidclass.sys: Add a processing thread for HID devices
by Nikolay Sivov 09 Oct '15

09 Oct '15

On 08.10.2015 22:34, Aric Stewart wrote: > + buffer_size = RingBuffer_GetBufferSize(ext->ring_buffer); > + RingBuffer_Read(ext->ring_buffer, ptr, packet, &buffer_size); No idea what's going on there, but first call seems to be redundant. Also maybe it makes sense to make RingBuffer_Read return size since it's out-only argument right now?

2 1

Re: [PATCH 1/2] dbghelp: Parse DW_TAG_pointer_type inside dwarf2_parse_subprogram_block.
by Qian Hong 09 Oct '15

09 Oct '15

Sorry, typo in commit message, will resend soon, thanks Michael Müller.

1 0

Re: ntdll: Implement RtlValidRelativeSecurityDescriptor.
by Marcus Meissner 09 Oct '15

09 Oct '15

On Fri, Oct 09, 2015 at 06:20:50PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sec.c | 9 +++++++++ > include/winternl.h | 1 + > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index ca3561d..1e68ef3 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -936,7 +936,7 @@ > @ stub RtlUsageHeap > @ cdecl -i386 -norelay RtlUshortByteSwap() NTDLL_RtlUshortByteSwap > @ stdcall RtlValidAcl(ptr) > -# @ stub RtlValidRelativeSecurityDescriptor > +@ stdcall RtlValidRelativeSecurityDescriptor(ptr long long) > @ stdcall RtlValidSecurityDescriptor(ptr) > @ stdcall RtlValidSid(ptr) > @ stdcall RtlValidateHeap(long long ptr) > diff --git a/dlls/ntdll/sec.c b/dlls/ntdll/sec.c > index 360a579..bc5d5a3 100644 > --- a/dlls/ntdll/sec.c > +++ b/dlls/ntdll/sec.c > @@ -558,6 +558,15 @@ NTSTATUS WINAPI RtlValidSecurityDescriptor( > } > > /************************************************************************** > + * RtlValidRelativeSecurityDescriptor [NTDLL.@] > + */ > +BOOLEAN WINAPI RtlValidRelativeSecurityDescriptor(PSECURITY_DESCRIPTOR descriptor, > + ULONG length, SECURITY_INFORMATION info) > +{ > + return RtlValidSecurityDescriptor(descriptor) == STATUS_SUCCESS; > +} Perhaps add a semi-stub FIXME message, in case some app needs the behaviour triggered by the other arguments? Ciao, Marcus

1 0

Re: mshtml: Add IHTMLEditServices stub implementation.
by Jacek Caban 09 Oct '15

09 Oct '15

Hi Dmitry, Please add a test. A very simple one that just calls QueryService and checks its return will be enough. I can see that you used undo mgr as an example, but it has its problems that I'd rather avoid in new code, so it would be nice to improve the patch. On 10/09/15 05:53, Dmitry Timoshkov wrote: > +static HRESULT WINAPI editsvcs_QueryInterface(IHTMLEditServices *iface, REFIID riid, void **ppv) > +{ > + editsvcs *This = impl_from_IHTMLEditServices(iface); > + > + if(IsEqualGUID(riid, &IID_IUnknown)) { > + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); > + *ppv = &This->IHTMLEditServices_iface; > + } else if(IsEqualGUID(riid, &IID_IHTMLEditServices)) { > + TRACE("(%p)->(IID_IHTMLEditServices %p)\n", This, ppv); > + *ppv = &This->IHTMLEditServices_iface; > + } else { > + *ppv = NULL; > + FIXME("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > + } Please use debugstr_mshtml_guid and add IHTMLEditServices there. > + > +static IHTMLEditServices *create_editsvcs(void) > +{ > + editsvcs *ret = heap_alloc(sizeof(*ret)); Please handle heap_alloc failure here. > + > + ret->IHTMLEditServices_iface.lpVtbl = &editsvcsVtbl; > + ret->ref = 1; > + > + return &ret->IHTMLEditServices_iface; > +} > + > /********************************************************** > * IServiceProvider implementation > */ > @@ -259,6 +381,15 @@ static HRESULT WINAPI ServiceProvider_QueryService(IServiceProvider *iface, REFG > return IWindowForBindingUI_QueryInterface(&This->doc_obj->IWindowForBindingUI_iface, riid, ppv); > } > > + if(IsEqualGUID(&SID_SHTMLEditServices, guidService)) { > + FIXME("SID_SHTMLEditServices\n"); I think it should be TRACE. Thanks, Jacek

1 0

Re: [PATCH 3/4] ole32: Add a stub for OleCreateFromFileEx.
by Dmitry Timoshkov 09 Oct '15

09 Oct '15

Huw Davies <huw(a)codeweavers.com> wrote: > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -189,7 +189,7 @@ > @ stdcall OleCreateFromData(ptr ptr long ptr ptr ptr ptr) > @ stdcall OleCreateFromDataEx(ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr) > @ stdcall OleCreateFromFile(ptr ptr ptr long ptr ptr ptr ptr) > -@ stub OleCreateFromFileEx > +@ stdcall OleCreateFromFileEx(ptr ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr) The 2nd parameter should be str, but that's not your fault, probably you've just copied and extended the OleCreateFromFile entry :) -- Dmitry.

2 2

Re: kernel32: add a stub for GetCurrentProcessorNumberEx
by Nikolay Sivov 09 Oct '15

09 Oct '15

Looks like it should forward to RtlGetCurrentProcessorNumberEx, and that one should init fields to zeroes or whatever lowest limits for group/processor number are.

2 1

Re: [PATCH] oledb32: Support VT_NULL on all conversions (try 2)
by Marvin 09 Oct '15

09 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17215 Your paranoid android. === wvistau64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w2008s64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w7pro64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w864 (64 bit convert) === convert.c:2995: Test failed: got 24 === w1064 (64 bit convert) === convert.c:2995: Test failed: got 24

1 0

Re: [PATCH] oledb32: Support VT_NULL on all conversions
by Marvin 09 Oct '15

09 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17213 Your paranoid android. === wvistau64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w2008s64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w7pro64 (64 bit convert) === convert.c:2995: Test failed: got 24 === w864 (64 bit convert) === convert.c:2995: Test failed: got 24 === w1064 (64 bit convert) === convert.c:2995: Test failed: got 24

1 0

Re: [PATCH] riched20: Implement set all caps(Ctrl+Shift+A) shortcut key. (try 2)
by Jactry Zeng 09 Oct '15

09 Oct '15

Please ignore this patch. It's wrong. I'll have another try later. 2015-09-14 22:26 GMT+08:00 Jactry Zeng <jzeng(a)codeweavers.com>: > Suppereded patch 114471. > > ChangeLog: > - Use struprW/strlwrW instead of toupperW/tolowerW; > - Remove isalphaW(). > > Thanks Nikolay! > --- > dlls/riched20/editor.c | 30 +++++++++++++++++++++++++++++- > dlls/riched20/editstr.h | 1 + > 2 files changed, 30 insertions(+), 1 deletion(-) > > > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 2).
by Sebastian Lackner 09 Oct '15

09 Oct '15

On 08.10.2015 03:11, Erich E. Hoover wrote: > This patch adds support for the basic file-transfer operation of > TransmitFile. It reads the file in as "bytes_per_send" chunks, which > it then sends to the destination using WS2_send. This process is > repeated synchronously (until patch 5 adds async support) until the > entire file is sent. > > This version has been updated to use a simple APC-safe NtReadFile-like > routine instead of using NtReadFile. > > > + else if (errno != EAGAIN) > + status = wsaErrno(); wsaErrno() doesn't return a status. Nevertheless, the more critical issue / question I see is, if we want to duplicate ReadFile code into ws2_32. The ntdll version is already very complicated, and your minimal version might not always be sufficient. * Missing handling for server_read_file(). * FILE_GetNtStatus() doesn't match sock_get_ntstatus() exactly. * FD type dependent code is probably simplied a bit too much. The original code behaves different depending on the exact FD_TYPE_* at some places. * NtReadFile will very likely get even more complicated over time, for example when a proper solution for message mode pipes is implemented.

3 2

Re: [2/2] ntdll: wait_thread_proc should not terminate on user APC.
by Marvin 09 Oct '15

09 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17207 Your paranoid android. === w7u (32 bit threadpool) === threadpool.c:1097: Test failed: WaitForSingleObject returned 258

2 1

Re: [2/2] wininet/tests: Add test for using NULL as proxy server. (v2)
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17183 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [PATCH 1/5] d3d8: Call IDirect3DSwapChain8::Present in IDirect3DDevice8::Present.
by Stefan Dösinger 08 Oct '15

08 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-08 um 20:09 schrieb Stefan Dösinger: > I'll send a mail to wine-devel with the patches that implement the > actual flipping in wined3d. Please have a look at them, as the > client lib pointer update is fairly useless without them. > > Changes from the previous flip version: *) I'm keeping track of > views in their resource, that way we can update their resource > pointer and take action for GL_ARB_texture_view. *) Put some > thoughts into how this will work with CSMT. *) Implement resource > pointer updates in dxgi. Here's the rest of the patches. DXGI is tricky because of the way it interacts with d3d11 (patch 8). Some async vs sync accesses aren't easy to place so far without the command stream. If in doubt I used async. For transition purposes the main thread can always wait for the worker to finish. The other way doesn't work. Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWFrJsAAoJEN0/YqbEcdMwTP4P/R6xDgSYiHfPVdyFGR0L4lu5 KwlSWw6q2nzURsNZPb4itWxADMMjRjYiHyHg6a7QCsWkkPq5FJutDTjRHZzpCx1H /oWKhJ6G5T9wEmewRyr5YuzmTh4Qt2dTfjR1pekI4p0oObBaY+O3Pzht6sElLWwW ILvJT7HwlHV0k5eyYI7q26VBLBb91E4QKzVugjnB6xrWYKAkkUBtJuxvFPqWlvJE mKW+hof0U5zRC5jcWRgHpEZwihsPamBEPmfnf+EmW6LYD3V1M+fNa80vOo1VJtR8 P5amAKQV9RZP19tgil8NBznbc60JEMa/hv3wpUN6Ddf3X5Ess1ORlKRSgrbhNMhg oqZCCD7/bgnIa6U/tEQpf/yua3MaA+SoXavMup+U6IiX5YGXTHlSEI7C1mXwSTBl e9adECuCKX9vD6PWQY6TiiMw5ZioHALW27dH68bvWcg13+qhCEJJHhLJEMovY4UX zNFZDo5YEvYBAkebn5KzQQwMKnYTwSWRijaWZshwnA4tgKT9gzqLsuZ7a3h5GNOf y1cwRCrppjmfaM9wYERjUo5giHhQq2jol1Y1NaVe8roOvhToNIKnTwI7VK+VVxHZ TbLvU+aHCVN4sJAuTQ6Y/Hgo55oi9Ts6RC26AqtNH0A6zGEBmIEN5xeJbVGEq5iO kX55vB1808MtThZBIRc1 =BJLE -----END PGP SIGNATURE-----

1 0

RE: [PATCH 2/2] reg: merge key open code
by Michel Zou 08 Oct '15

08 Oct '15

Hi, I saw the 1/2 patch has been commited, this is the second half that corresponds to the commit 1 of 4 by jnvsor in a preliminary work to add reg query functionality: https://github.com/jnvsor/wine/commits/reg.exe I split this commit in two after the review from Stefan Dösinger. I did not want to submit all at once because it seems pretty hard to get patches accepted. M. > Subject: Re: [PATCH 2/2] reg: merge key open code > To: wine-patches(a)winehq.org > From: stefandoesinger(a)gmail.com > Date: Mon, 5 Oct 2015 11:43:52 +0200 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2015-10-04 um 21:14 schrieb Michel Zou: > > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > > > Signed-off-by: Michel Zou <xantares09(a)hotmail.com> > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWEkZYAAoJEN0/YqbEcdMwHoIP/RbWUWDNwqoDGiEY/b+IX+Ik > JuOwKGS/VJ36CrAUE03qgJ4XOBzIvfKMO+5UmjztQLPh60bvzKozzTVFJlYlCExQ > jzuOyz24P+7QBx195Ov9YV56p7isk2g2ShL9zg/XVub4b/47snRzncmjC7kAM2my > Zxfhcg5wxqHE3+905LXf4VcL9a1vbZG5+sIjMCfB5q6/b0EtyDBomIuH3YRgGuHu > iH57nTjUu+bMD+lH5PvmD0mAhMFEwSjbdXCsSqQhyDUg7WQaYo/XE17XtA2N4gb1 > tHl66PPdazaKxJGrTBdJtHhtgA8LO2ahfa7Ses5x3z6+/oGlO1OsdPPNRJusUC4V > 93tcacPj7IpWSLknZDFPHfcaHhv0IBMkI64lqiB9uEjQmylFd9+N1hYbnuB9ddpB > 21W4JE+Yfk7XDK0N4LDfKOGOblS7id58FoOJVIOGbYwklD9LXRGwiRkQe5yPGu6u > oAG0eWGySkU1egL6eXQ1fTzmF2RDzx3nFUUDB86kjeHa6mbeYzCtZEDzDaGOJkdI > 3J61hbUhY6VMMoSFsyokYwK++DJMvxhjk6Dy8cnU/qXM5MsDQWJUHePA9FZYOaOy > BBTcNUt1x2zNZjrsoCpdwHWGCpnht199cH+GElTIXp/CIaolxvEgl8TmyW6v5M42 > KfJ1DoYOZjEcs/gVwPDA > =Go1E > -----END PGP SIGNATURE----- > >

3 2

Re: [PATCH] vcomp120: add vcomp120 stub dll
by Nikolay Sivov 08 Oct '15

08 Oct '15

On 08.10.2015 19:02, Daniel Lehman wrote: > > diff --git a/dlls/vcomp120/main.c b/dlls/vcomp120/main.c > new file mode 100644 > index 0000000..a534bc7 > --- /dev/null > +++ b/dlls/vcomp120/main.c > @@ -0,0 +1,46 @@ > +/* > + * > + * vcomp120 implementation > + * > + * Copyright 2012 AndrÃ© Hentschel It's a new file, so I think it's better to add yourself too, you can of course keep Andre as original author you copied from. > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) Please rename them to 'instance', 'reason' and 'reserved'.

1 0

Re: [PATCH] vcomp120: add vcomp120 stub dll
by Sebastian Lackner 08 Oct '15

08 Oct '15

On 08.10.2015 18:02, Daniel Lehman wrote: > > > > There is one export missing compared to the vcomp120 version I have here (C2VectParallel). Also, variable names like lpvReserved should be avoided nowadays. It might be better to use the names from vcomp110/main.c. Regards, Sebastian

1 0

Re: [1/2] wininet/tests: Add test for using NULL as proxy server.
by Jacek Caban 08 Oct '15

08 Oct '15

Hi Sebastian, On 10/08/15 07:15, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > Testbot is broken again, so here a link to a run with precompiled test: > https://newtestbot.winehq.org/JobDetails.pl?Key=17153 > > dlls/wininet/tests/internet.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) It fails here: fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub fixme:wininet:get_proxy_autoconfig_url no support on this platform fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub fixme:wininet:get_proxy_autoconfig_url no support on this platform fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub internet.c:1387: Test failed: InternetSetOption should've succeeded Cheers, Jacek

2 1

Re: [2/2] wininet: Disabling proxy should return success when no proxy was enabled.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17155 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [1/2] wininet/tests: Add test for using NULL as proxy server.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17154 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [PATCH 1/6] d3d9/tests: Fix color_match().
by Henri Verbeet 08 Oct '15

08 Oct '15

On 8 October 2015 at 01:26, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Clang on OS X complains about calling abs() on an unsigned value and > I think it has a point since technically the unsigned to signed > conversion is implementation-dependent when the value can't be > represented in the signed integer type (i.e. for the "negative" numbers). > ...and I don't suppose you accidentally compiled with -Wpedantic. The warning isn't wrong, but it's not terribly useful either. On two's complement systems (i.e., anything relevant) the reasonable thing to do is also the correct thing. This function exists in other places as well, of course.

2 1

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 2).
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17148 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7346: Test failed: bytesReturned isn't supposed to be 1 sock.c:7370: Test failed: GetOverlappedResult failed, error 0 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF312045

1 0

Re: [PATCH 3/6] d3d9/tests: Add helpers to avoid multiple readbacks of the render target surface.
by Henri Verbeet 08 Oct '15

08 Oct '15

On 8 October 2015 at 01:26, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > My feeling is that we could improve the readback performance further in > wined3d, regardless of this patch. Possibly, but note that GetRenderTargetData() isn't terribly fast on Windows either. I like the concept, but the implementation probably needs some work. I'd like to have an interface that can work for d3d10/11 as well, so the device parameter probably needs to go. (See also how get_texture_color() is used in d3d10core.) Maybe return a structure that wraps both the readback surface and locked rect to avoid declaring those as separate parameters. E.g.: struct surface_readback rb; get_surface_readback(backbuffer, &rb) color = get_readback_color(&rb, x, y); release_surface_readback(&rb); (Not sure on the naming.) I also think getPixelColor() should then be implemented on top of this. I think masking out the alpha/X channel was the wrong decision, and we should fix that at some point, but for the time being you can of course still mask the result of get_readback_color().

1 0

Re: [PATCH 6/6] d3d8/tests: Uninitialized varyings tests.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17143 Your paranoid android. === w8 (32 bit visual) === visual.c:8280: Test failed: Got unexpected color 0xffffffff, case 3. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 5. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 6. === w864 (32 bit visual) === visual.c:8280: Test failed: Got unexpected color 0xffffffff, case 3. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 5. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 6. === w1064 (32 bit visual) === visual.c:8280: Test failed: Got unexpected color 0xffffffff, case 3. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 5. visual.c:8280: Test failed: Got unexpected color 0x00800000, case 6.

1 0

Re: [PATCH 4/6] d3d9/tests: Uninitialized varyings tests.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17141 Your paranoid android. === w8 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 4. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 7. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 10. visual.c:20260: Test failed: Got unexpected color 0xff000000, case 11. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 12. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 13. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 16. === w864 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 4. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 7. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 10. visual.c:20260: Test failed: Got unexpected color 0xff000000, case 11. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 12. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 13. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 16. === w1064 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 4. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 7. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 10. visual.c:20260: Test failed: Got unexpected color 0xff000000, case 11. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 12. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 13. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 16. === w864 (64 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 4. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 7. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 10. visual.c:20260: Test failed: Got unexpected color 0xff000000, case 11. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 12. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 13. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 16. === w1064 (64 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 4. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 7. visual.c:20260: Test failed: Got unexpected color 0xffffffff, case 10. visual.c:20260: Test failed: Got unexpected color 0xff000000, case 11. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 12. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 13. visual.c:20260: Test failed: Got unexpected color 0x00800000, case 16.

1 0

Re: [PATCH 3/6] d3d9/tests: Add helpers to avoid multiple readbacks of the render target surface.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17140 Your paranoid android. === w8 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w864 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w1064 (32 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w864 (64 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w1064 (64 bit visual) === visual.c:7274: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000.

1 0

Re: mshtml: Treat "data:" as Gecko special URI scheme
by Alex Henrie 08 Oct '15

08 Oct '15

I tried your patch and it worked for loading embedded resources within a page, but I still could not type data:text/plain,Hello%20world! into the address bar and get anything back. Do you have plans to make the address bar work too? -Alex

4 5

Re: [PATCH 2/6] d3d9/tests: Test uninitialized texture varyings with transformed vertices.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17139 Your paranoid android. === w8 (32 bit visual) === visual.c:7209: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w864 (32 bit visual) === visual.c:7209: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w1064 (32 bit visual) === visual.c:7209: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w864 (64 bit visual) === visual.c:7209: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000. === w1064 (64 bit visual) === visual.c:7209: Test failed: Test texcoord1 alpha returned color 0x00ffffff, expected 0x00000000.

1 0

Re: [PATCH 1/2] oledb32: Support VARIANT(VT_NULL)->DBTYPE_WSTR in GetConversionSize
by Michael Stefaniuc 08 Oct '15

08 Oct '15

Alistair, On 10/08/2015 11:06 AM, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/oledb32/convert.c | 2 ++ > dlls/oledb32/tests/convert.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c > index a92369f..21938aa 100644 > --- a/dlls/oledb32/convert.c > +++ b/dlls/oledb32/convert.c > @@ -1416,6 +1416,8 @@ static HRESULT WINAPI convert_GetConversionSize(IDataConvert* iface, > case DBTYPE_VARIANT: > if(V_VT((VARIANT*)src) == VT_BSTR) > *dst_len = (SysStringLen(V_BSTR((VARIANT*)src))+1) * sizeof(WCHAR); > + else if(V_VT((VARIANT*)src) == VT_NULL) > + *dst_len = 110; what is the magic number 110? I looked at the surrounding code but I don't see any other magic numbers assigned to dst_len. bye michael

2 1

Re: [v3 09/10] wined3d: don't pass a wined3d_volume to device_volume_created callback anymore
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index a354308..f1ead48 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -2034,7 +2034,7 @@ struct wined3d_device_parent_ops > struct wined3d_surface *surface, void **parent, const struct wined3d_parent_ops **parent_ops); > HRESULT (__cdecl *volume_created)(struct wined3d_device_parent *device_parent, > struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, > - struct wined3d_volume *volume, void **parent, const struct wined3d_parent_ops **parent_ops); > + void **parent, const struct wined3d_parent_ops **parent_ops); I think you should be able to remove the forward declaration of struct wined3d_volume as well now.

2 1

Re: [v3 06/10] d3d9: make use of wined3d_texture_map in d3d9_volume_LockBox
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index eb4a0fc..e5111ab 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2335,6 +2335,8 @@ void wined3d_volume_get_pitch(const struct wined3d_volume *volume, UINT *row_pit > void wined3d_volume_load(struct wined3d_volume *volume, struct wined3d_context *context, > BOOL srgb_mode) DECLSPEC_HIDDEN; > void wined3d_volume_invalidate_location(struct wined3d_volume *volume, DWORD location) DECLSPEC_HIDDEN; > +HRESULT wined3d_volume_map(struct wined3d_volume *volume, > + struct wined3d_map_desc *map_desc, const struct wined3d_box *box, DWORD flags); This needs DECLSPEC_HIDDEN. Applies to patch 7/10 as well.

1 0

RE: [PATCH 1/2] reg: simplify root key search
by Michel Zou 07 Oct '15

07 Oct '15

Hi, These two patches correspond to the 1/4 commit by jnvsor in a preliminary work to add reg query functionality: https://github.com/jnvsor/wine/commits/reg.exe I split this commit in two after the review from Stefan Dösinger. I did not want to submit all at once because it seems pretty hard to get patches accepted. M. > Subject: Re: [PATCH 1/2] reg: simplify root key search > To: wine-patches(a)winehq.org > From: stefandoesinger(a)gmail.com > Date: Mon, 5 Oct 2015 11:42:15 +0200 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2015-10-04 um 21:14 schrieb Michel Zou: > > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > > > Signed-off-by: Michel Zou <xantares09(a)hotmail.com> > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWEkX3AAoJEN0/YqbEcdMwOx8P/RgHK3cBvTiTegMwxWil8zin > BkTP/Lq7hQjXBP5fOKhpysT6KgtXCqvif9h9gEIJkePszPQurcQrAR6DDwzS+dqT > pHWqwIBwktePQP3bo7Xb0zwWRAePe/KAf80EUF4Vj1sFmQpOExS2SzCPbLylSyle > UlIZfV4LzOMf2rqn70h0p7i+eFymUcRs8Ocejwf6llM9B/M6ETT3+PJ600rOcpYJ > a+/+oJasmBQZTyhOr2xtJe9ZctmmldCIufjH9OYpkkTiSf+fNekbBh6T7Sd1VM0q > 7KxuanloX1RJ33IZUbnaeMi4XPjYGkXwN07Y0Qoz/KbIAqsLqjs6ZX4a7zRttH/R > TiBvk8G5KgOLSA3CGk764krIAT4BhLae1sIV2BdjGnz8LXarRLY442+srLPOW5ko > F5y34SGaSjV90+K27yiAfg/HLMYa6DvT+dqU7K/+jokkir3hl87Hz2mRpWRA2Gge > 5oH4UHnrOXqOzxnmZMvhmMtteEZ7XyCtF97r+Hv1l9XDFY4eVKQMEZN0pMDIwvSx > lIvKRmQyce9RV4XAo1zsYwUFmWBjbiEDouhylgjYMp1yean7+wP6pZDxnmJ6SIxF > w6WXd2+V16rts61joPqXoXndpmPXH1SJINu69v+3YKaTFCeQF1gbGlpf/G9nM85P > 3JmJVKAKRId0MJAKIJZq > =Lqx3 > -----END PGP SIGNATURE----- > >

1 0

Re: [PATCH 3/5] ws2_32: Implement a basic synchronous TransmitFile.
by Alexandre Julliard 07 Oct '15

07 Oct '15

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > This patch adds support for the basic file-transfer operation of > TransmitFile. It uses NtReadFile to obtain "bytes_per_send" chunks of > the file, which it then sends to the destination using WS2_send. NtReadFile potentially allocates memory, you can't use it in an async I/O callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v3 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
by Henri Verbeet 07 Oct '15

07 Oct '15

On 6 October 2015 at 10:36, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > Store wined3d_texture and sub_resource in d3d8_volume. > Updated the d3d8_volume_LockBox to make use of wined3d_texture_map. > Also updated d3d9, d3d11, ddraw callbacks accordingly > --- This is mostly fine, although "d3d8: Use wined3d_texture_map() in d3d8_volume_LockBox()." would perhaps have been more appropriate as a subject, since the callback change is just a side-effect. The d3d9 volume_init() change could have been deferred until patch 6/10 and would perhaps been more appropriate there, but it doesn't matter too much.

2 3

Signed-off-by support
by Alexandre Julliard 07 Oct '15

07 Oct '15

Folks, As a first step of the implementation of the WineConf decisions, the patch tracker now supports Signed-off-by. You can see the list of people who have signed off on a patch by hovering over the signed-off checkmark in the tracker. In general, people who are listed in the MAINTAINERS file should sign off on other people's patches that touch their area. I'll be working next on implementing a more formal mechanism for assigning reviewing responsibility. To add your sign-off to a patch that you have approved, you need to send a reply to wine-patches with your Signed-off-by header. If you find this inconvenient, I'm open to adding other mechanisms; suggestions are welcome. Finally, starting next week I'm going to require patch authors to include a proper Signed-off-by header on all patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3 v3 resend] user32: Implement semi-stub for FlashWindowEx.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17092 Your paranoid android. === w8 (32 bit win) === win.c:3418: Test failed: hwnd 00030114 message 0118 === w864 (32 bit win) === win.c:3418: Test failed: hwnd 00030192 message 0118 === w1064 (32 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w864 (64 bit win) === win.c:3418: Test failed: hwnd 0000000000040144 message 0118 === w1064 (64 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

2 1

Re: [1/3 resend] user32/tests: Add tests for FlashWindow.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17091 Your paranoid android. === w8 (32 bit win) === win.c:3418: Test failed: hwnd 000601B0 message 0118 === w864 (32 bit win) === win.c:3418: Test failed: hwnd 00060192 message 0118 === w1064 (32 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w1064 (64 bit win) === win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6659: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6659: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6681: Test failed: 0x80/0x1410000: window rect 0,0-1024,768

2 1

Re: [2/2] wbemprox: Add bios name column in Win32_BIOS.
by Hans Leidekker 07 Oct '15

07 Oct '15

On Wed, 2015-10-07 at 03:51 +0200, Sebastian Lackner wrote: > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 1c960eb..8f51453 100644 > --- a/dlls/wbemprox/builtin.c > +++ b/dlls/wbemprox/builtin.c > @@ -377,7 +377,8 @@ static const struct column col_bios[] = > { prop_releasedateW, CIM_DATETIME }, > { prop_serialnumberW, CIM_STRING }, > { prop_smbiosbiosversionW, CIM_STRING }, > - { prop_versionW, CIM_STRING|COL_FLAG_KEY } > + { prop_versionW, CIM_STRING|COL_FLAG_KEY }, > + { prop_nameW, CIM_STRING } Please keep them sorted.

1 0

Re: [2/3 v3] user32: Implement semi-stub for FlashWindowEx.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17089 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] user32/tests: Add tests for FlashWindow.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17088 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] ntdll/tests: Add tests for RtlRegisterWait.
by Marvin 07 Oct '15

07 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17078 Your paranoid android. === w7u (32 bit threadpool) === threadpool.c:1364: Test failed: WaitForSingleObject returned 258 threadpool.c:1375: Test failed: WaitForSingleObject returned 0 === w864 (64 bit threadpool) === threadpool.c:613: Test failed: expected userdata >> 16 != 0, got 0

2 1

Re: [1/3] msi/tests: Add a test for MsiInstallProduct with command line containing double quotes inside of the property.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17052 Your paranoid android. === wvistau64 (32 bit install) === The test timed out

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data. Take 2.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17051 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

1 0

Re: [v2 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
by Stefan Dösinger 06 Oct '15

06 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 This patch causes a crash in the d3d8 tests here: Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7ec1adda). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ec1adda ESP:0033f450 EBP:0033f488 EFLAGS:00010246( R- -- I Z- -P- ) EAX:7ec887f5 EBX:7ec72000 ECX:0033f4a0 EDX:7eca7e80 ESI:0015c920 EDI:00000000 Stack dump: 0x0033f450: 00000000 7bc3cc86 0033f480 7ec72000 0x0033f460: 0015c920 00000000 0033f498 7ec1c369 0x0033f470: 00000010 7ec1adc6 0033f4a0 7eca8000 0x0033f480: 0015c920 00000000 0033f4c8 7ec9941c 0x0033f490: 0033f4b0 7eca8000 7ec887f5 7ec9941c 0x0033f4a0: 00000000 00000000 7ec8859d 7ec99411 Backtrace: =>0 0x7ec1adda wined3d_volume_unmap+0x2a(volume=<couldn't compute location>) [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d (0x0033f488) 1 0x7ec9941c d3d8_volume_UnlockBox+0x5b(iface=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/volume.c:170] in d3d8 (0x0033f4c8) 2 0x7ec952e6 d3d8_texture_3d_UnlockBox+0x55(iface=<couldn't compute location>, level=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/texture.c:1068] in d3d8 (0x0033f508) 3 0x7ecea1d1 test_volume_locking+0x160() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:5761] in d3d8_test (0x0033f668) 4 0x7ecff26a func_device+0x4e39() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:7533] in d3d8_test (0x0033fd38) 5 0x7ece2536 main+0x385(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/include/wine/test.h:584] in d3d8_test (0x0033fdf8) 6 0x7ed1ff0f __wine_spec_exe_entry+0x6e(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/winecrt0/../../../../src/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033fe48) 7 0x7b85d97c call_process_entry+0xb() in kernel32 (0x0033fe68) 8 0x7b85e9ba start_process+0x59(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1104] in kernel32 (0x0033fe98) 9 0x7bc7e5e0 call_thread_func_wrapper+0xb() in ntdll (0x0033feb8) 10 0x7bc8151f call_thread_func+0xce(entry=0x7b85e960, arg=0x7ffdf000, frame=0x33ffc8) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0033ffa8) 11 0x7bc7e5be call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 12 0x7bc53de7 start_process+0x16(kernel_start=0x7b85e960) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3040] in ntdll (0x0033ffe8) 13 0xf759138d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 14 0xf7591500 wine_switch_to_stack+0x1f(func=0x7bc53dd0, arg=0x7b85e960, stack=0x340000) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/port.c:59] in libwine.so.1 (0xffccfbd8) 15 0x7bc59b31 LdrInitializeThunk+0x1f0(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3094] in ntdll (0xffccfc18) 16 0x7b864812 __wine_kernel_init+0x871() [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1276] in kernel32 (0xffcd0d88) 17 0x7bc5a973 __wine_process_init+0x162() [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3303] in ntdll (0xffcd0e08) 18 0xf758f003 wine_init+0x2d2(argc=0x3, argv=0xffcd1364, error="", error_size=0x400) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/loader.c:958] in libwine.so.1 (0xffcd0e68) 19 0x7bf00d52 main+0x81(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/loader/../../../src/wine/loader/main.c:247] in <wine-loader> (0xffcd12b8) 20 0xf739b973 __libc_start_main+0xf2() in libc.so.6 (0x00000000) 0x7ec1adda wined3d_volume_unmap+0x2a [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d: movl 0x8(%edi),%eax 683 if (!volume->resource.map_count) Modules: Module Address Debug info Name (60 modules) ELF 7a800000-7a92f000 Deferred opengl32<elf> \-PE 7a820000-7a92f000 \ opengl32 ELF 7b800000-7ba62000 Dwarf kernel32<elf> \-PE 7b810000-7ba62000 \ kernel32 ELF 7bc00000-7bced000 Dwarf ntdll<elf> \-PE 7bc10000-7bced000 \ ntdll ELF 7bf00000-7bf04000 Dwarf <wine-loader> ELF 7e321000-7e327000 Deferred libxfixes.so.3 ELF 7e327000-7e332000 Deferred libxcursor.so.1 ELF 7e332000-7e341000 Deferred libxi.so.6 ELF 7e341000-7e345000 Deferred libxcomposite.so.1 ELF 7e345000-7e34f000 Deferred libxrandr.so.2 ELF 7e34f000-7e359000 Deferred libxrender.so.1 ELF 7e359000-7e35f000 Deferred libxxf86vm.so.1 ELF 7e35f000-7e363000 Deferred libxinerama.so.1 ELF 7e363000-7e36a000 Deferred libxdmcp.so.6 ELF 7e36a000-7e36e000 Deferred libxau.so.6 ELF 7e36e000-7e38f000 Deferred libxcb.so.1 ELF 7e38f000-7e4a8000 Deferred libx11.so.6 ELF 7e4a8000-7e4b9000 Deferred libxext.so.6 ELF 7e50b000-7e59a000 Deferred winex11<elf> \-PE 7e520000-7e59a000 \ winex11 ELF 7e59a000-7e5be000 Deferred imm32<elf> \-PE 7e5a0000-7e5be000 \ imm32 ELF 7e683000-7e6a2000 Deferred libexpat.so.1 ELF 7e6a2000-7e6d7000 Deferred libfontconfig.so.1 ELF 7e6d7000-7e706000 Deferred libpng16.so.16 ELF 7e706000-7e71a000 Deferred libz.so.1 ELF 7e71a000-7e7a8000 Deferred libfreetype.so.6 ELF 7e7a8000-7e7e5000 Deferred libncurses.so.5 ELF 7e837000-7e851000 Deferred version<elf> \-PE 7e840000-7e851000 \ version ELF 7e851000-7e9a2000 Deferred user32<elf> \-PE 7e860000-7e9a2000 \ user32 ELF 7e9a2000-7ea19000 Deferred advapi32<elf> \-PE 7e9b0000-7ea19000 \ advapi32 ELF 7ea19000-7eb34000 Deferred gdi32<elf> \-PE 7ea30000-7eb34000 \ gdi32 ELF 7eb34000-7ec76000 Dwarf wined3d<elf> \-PE 7eb40000-7ec76000 \ wined3d ELF 7ec76000-7ecaa000 Dwarf d3d8<elf> \-PE 7ec80000-7ecaa000 \ d3d8 ELF 7ecd0000-7ed37000 Dwarf d3d8_test<elf> \-PE 7ece0000-7ed37000 \ d3d8_test ELF 7ef37000-7ef44000 Deferred libnss_files.so.2 ELF 7ef44000-7ef50000 Deferred libnss_nis.so.2 ELF 7ef50000-7ef69000 Deferred libnsl.so.1 ELF 7ef69000-7efae000 Deferred libm.so.6 ELF 7efb2000-7efbf000 Deferred libbz2.so.1 ELF f4f8f000-f4fab000 Deferred libgcc_s.so.1 ELF f5147000-f721b000 Deferred libnvidia-glcore.so.355.11 ELF f726d000-f7370000 Deferred libgl.so.1 ELF f737c000-f7381000 Deferred libdl.so.2 ELF f7382000-f751c000 Dwarf libc.so.6 ELF f751c000-f7536000 Deferred libpthread.so.0 ELF f7537000-f7540000 Deferred libnss_compat.so.2 ELF f757b000-f7580000 Deferred libnvidia-tls.so.355.11 ELF f7588000-f7740000 Dwarf libwine.so.1 ELF f7741000-f7763000 Deferred ld-linux.so.2 ELF f7765000-f7766000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 0000000e services.exe 0000002f 0 0000002e 0 00000028 0 00000022 0 0000001c 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 00000019 0 00000018 0 00000013 0 0000001a winedevice.exe 0000001f 0 0000001e 0 0000001b 0 00000020 winedevice.exe 00000025 0 00000024 0 00000021 0 00000026 plugplay.exe 0000002b 0 0000002a 0 00000027 0 0000002c winedevice.exe 00000031 0 00000030 0 0000002d 0 00000032 explorer.exe 00000037 0 00000036 0 00000035 0 00000034 0 00000033 0 0000003b (D) Z:\home\stefan\build\wine\dlls\d3d8\tests\d3d8_test.exe 00000040 0 <== System information: Wine build: wine-1.7.52-49-gc171ca1 Platform: i386 (WOW64) Host system: Linux Host version: 4.0.5-aufs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWE38aAAoJEN0/YqbEcdMw/XQP/jP/uppjezHsceuRmebdi44J F/RPugTszK6FVR3/c7+x/q4zVq5tdJXYD2W5Sa07k7F63P/t8lneWk0ADaASSdI6 XETTWQ9dEdP3mndOdlw2oftGwmDomgZXc7jAeGE6N7yvwRfUKUat8IRslIGmpmu2 VdeV3aYk6VL/KDxWIBVdid26hiEWVkgqQWEK2m4rZHiu5ZehE7HEf5sA+NQ3d+GX VThFQcaNRUZ1988W0iDfIEB5r621V9eedVWdPktwGh+trdJMlObTtDoihEiF9IUi Q0r5LYa47HcI6KpHhJYF+dSXFUy8c8dm+CX7xA+EhO7X4W0HL/EBE4C2sF3mZ8mO 0tAg/lrCb0o9PJJ21I/fckQ3qhAJWyA1I/BQxrBfE16W9Ywh65SA5CLDKg5hXX45 jervpWtfi6jjkgCy9A/lmmJ0pUKL7RsES8Ot8eI/aUMpmwaGf4rYuk+ZjrQiEJ9v 2xT439SXYuQw6RK3EJUeaLiMr8PiYDEluWSPbD5uYtxjUwI4L/PXRGMuqxUz+TSz 7O2jC8FHHRYuGLAskgZetd3RYi8Ip3ApPySntkZJ0B4HwNSg4AzSUaiL6UYVnNZH 8PB+dJKSx94Zb+gRA/IgonsXM0AuD9roOeVXYMCiE92ubzHHboO8YQ6dsaYM9Ial vlyz2JJWEYqBCTBD5P/c =PHTE -----END PGP SIGNATURE-----

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Andrew Eikum 06 Oct '15

06 Oct '15

On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote: > +{ > + "a", > + "{00000000-0000-0000-0000-000000000000}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, ... > +{ > + "c", > + "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, These two tests fail on my Win7 VM: typelib.c:4378: Interface a typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _a typelib.c:4378: Interface aa typelib.c:4378: Interface _b typelib.c:4378: Interface bb typelib.c:4378: Interface c typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _c I get the same failures when running the tests on Wine. Unlike the testbot, everything else passes on my VM. Andrew

2 3

Re: [1/2] user32/tests: Add a test for sending WM_SIZE message to edit control.
by Nikolay Sivov 05 Oct '15

05 Oct '15

On 06.10.2015 0:42, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The test failure "edit.c:1521: Test failed: got 1, 1" on Win7 is unrelated to this patch. > > dlls/user32/tests/edit.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c > index e8b41c2..88bb364 100644 > --- a/dlls/user32/tests/edit.c > +++ b/dlls/user32/tests/edit.c > @@ -1481,6 +1481,15 @@ static void test_margins(void) > ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > > + /* The lParam argument of the WM_SIZE message should be ignored. */ > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&old_rect); > + SendMessageA(hwEdit, WM_SIZE, 0, 0); > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&new_rect); > + ok(new_rect.left == old_rect.left, "The left border of the rectangle has changed\n"); > + todo_wine ok(new_rect.right == old_rect.right, "The right border of the rectangle has changed\n"); > + todo_wine ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > + todo_wine ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > + Maybe use EqualRect()? Could you add more tests for that? For example non-zero lParam, different combinations of wParam modes (with SIZE_RESTORED instead of 0). > DestroyWindow (hwEdit); > > memset(&lf, 0, sizeof(lf)); >

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Stefan Dösinger 05 Oct '15

05 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Your mails ended up in my spam folder for some reason. Google says it has large similarities to other known spam mail, which seems unlikely to me. Am 2015-10-04 um 19:52 schrieb Andrew D'Addesio: > To avoid confusion, CreateDirect3D/ReleaseDirect3D is also renamed to > CreateDirect3D7/ReleaseDirect3D7. > --- > dlls/ddraw/tests/d3d.c | 167 +++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 154 insertions(+), 13 deletions(-) New tests should be added to ddraw*.c, ideally in all ddraw versions that offer the tested feature. The long term goal for d3d.c, dsurface.c, etc is to be migrated to those files. If you want to modify an existing test in d3d.c please move the existing code to ddraw*.c, then add your new test features to it. These files have some exising helper functions like create_device, so you don't have to take stuff like d3d3_create_objects along. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWEh67AAoJEN0/YqbEcdMwGUEQAIskKamXUC/+Kik99/eqbcpp 3SohARAHPivs+bf2GM68dBBeON9SbzlllfH/cIog9Z9oAUr2fGWDUMLQnyb96ANH +g39WlGO/HFEvqBI9B+mLrZO1VQaePwNH6Sv6p4d09OLWlyRa0PfGrImdqxBNwS2 /Z9j9PmHMQ2oV2KAM3vyqAGAX7VrLH+kr/fQqQofLhHGidHhXUZgkpOT67Drwp4/ 98B3QzFgFyo58Z1AWJ2hAJt4PZQ/uLIn3zQdnYzgsC2H3a9maLC2iB0l3CvXeMgi N8Sb+Nazvjtlu7ut6sNc7cOaharjnYLzKjTpqC0IV0TjFysa0BcwXAm1dj660KzK 2RAy6HeTbE4OpgbT+jU482GNTzhKtRX0EmyCIWD1YZV6li5SO4/mkqPp54D14pHK jgnMV689ZCayn+TpdbO2Q30USJD1tI3HwvXFWyweTFeB59ERmtruLJNDUQ3TtWct Wvcg9AMY8PaSFha/fhGis8/HUFmwWnRWt/E4rhVGmA5wLUD9NO7k0sGOxdRja6mE mNs/dE9ibLn3WB9K9NNLylI2W/4ATbUZoypdEb5H4hyejzfvsbj4LK+772qvLEkS +CEqcT5JwXVF2/XaGrXEkIWt1hz8CnGPHDFrylDoXdXBO5LYKkgKuXmBfFV7DU7Y HM8/Zo1J7TZ9r3yZjmm+ =cNFg -----END PGP SIGNATURE-----

2 2

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17010 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

2 1

Re: [PATCH 4/7] wined3d: Initialize unwritten texcoord varyings in the VS.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -4998,7 +4996,22 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, > output->register_idx, reg_mask[1]); > } > } > - shader_addline(buffer, "}\n"); > + > + for (i = 0; i < MAX_TEXTURES; ++i) > + { > + if (ps && !(ps->reg_maps.texcoord & (1u << i))) > + continue; > + > + if (texcoords_written_mask[i] != WINED3DSP_WRITEMASK_ALL) > + { > + if (gl_info->limits.glsl_varyings < wined3d_max_compat_varyings(gl_info) > + && !texcoords_written_mask[i]) > + continue; > + > + shader_glsl_write_mask_to_str(~texcoords_written_mask[i] & WINED3DSP_WRITEMASK_ALL, reg_mask); > + shader_addline(buffer, "gl_TexCoord[%u]%s = vec4(0.0)%s;\n", i, reg_mask, reg_mask); > + } > + } > } > else > { Doesn't this end up writing 0.0 to .w instead of 1.0? IIRC unwritten texture coordinates are assumed to be (0, 0, 0, 1) in D3D. May apply to the previous patch in the series as well.

3 4

Re: [3/6] oleaut32/tests: Update the typelib test generator to match existing data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17007 Your paranoid android. === wvistau64 (32 bit typelib) === The test timed out

1 0

Re: [PATCH] hidclass.sys: fixed copy/paste error (Coverity)
by Ken Thomases 05 Oct '15

05 Oct '15

On Oct 3, 2015, at 2:52 AM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > > 1325460 Identical code for different branches > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/descriptor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/descriptor.c b/dlls/hidclass.sys/descriptor.c > index 6f8e45e..35057f1 100644 > --- a/dlls/hidclass.sys/descriptor.c > +++ b/dlls/hidclass.sys/descriptor.c > @@ -414,7 +414,7 @@ void parse_io_feature(unsigned int bSize, int itemVal, int bTag, unsigned int *f > if ((itemVal & INPUT_ARRAY) == 0) > feature->isArray= TRUE; > else > - feature->isArray= TRUE; /* Var */ > + feature->isArray= FALSE; /* Var */ Hmm. First, doesn't that logic seem backward? You're now setting isArray to true only if itemVal does NOT contain INPUT_ARRAY. And wouldn't it be better to just replace that whole if statement by: feature->isArray = (itemVal & INPUT_ARRAY) != 0; ? (For what it's worth, I started to suggest the style refactoring first and that's what made it so obvious that the logic was wrong. The power of good style to improve comprehension!) > if ((itemVal & INPUT_ABS) == 0) > feature->IsAbsolute = TRUE; > else The rest of this function looks like it's riddled with similar backward logic. :( -Ken

2 3

Ignored WineTest report
by Francois Gouget 05 Oct '15

05 Oct '15

My FreeBSD 7.0 VM sent the following report: http://fgouget.free.fr/tmp/winebot-fg-freebsd70-vm.report However that report was ignored and I have no idea why. The report is under 1.5MB and has only 44 failures. So why is it being ignored? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

2 5

Re: [PATCH 6/7] wined3d: Avoid reading uninitialized texcoord varyings in FFP replacement fragment shaders.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - unsigned char padding; > + unsigned char pointsprite : 1; > + unsigned char padding : 7; > + unsigned int inited_texcoords; > }; Did you perhaps mean something like "initialized_texcoords" or "texcoords_initialized"?

2 2

Re: [PATCH 1/7] wined3d: Avoid the deprecated syntax for SM3 varyings on core profile.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +static void PRINTF_ATTR(4, 5) declare_in_varying(const struct wined3d_gl_info *gl_info, > + struct wined3d_string_buffer *buffer, BOOL flat, const char *format, ...) It's not a huge issue, but generally speaking things are more readable on the caller side when you use a flag or enum instead of a BOOL. I.e., "declare_in_varying(..., TRUE, ...);" vs. e.g. "declare_in_varying(..., WINED3D_GLSL_INTERPOLATE_FLAT, ...);".

1 0

Re: [PATCH 5/9] d3d11: Implement {d3d10, d3d11}_geometry_shader_GetDevice().
by Henri Verbeet 05 Oct '15

05 Oct '15

For what it's worth, the original reason geometry shaders and input layouts don't have a GetDevice() implementation was that it was a bit harder to add test coverage for them than for the rest of the interfaces. It's probably easy enough now, so please add some geometry shader coverage to test_create_shader(). You can probably use the shader from test_clear_state().

1 0

Re: crypt32/tests: Delete WineTest registry key when tests are complete
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17004 Your paranoid android. === w864 (64 bit store) === store.c:2603: Test failed: CertAddCertificateContextToStore failed store.c:2604: Test failed: Unexpected cert3 store: unhandled exception c0000005 at 000000000044DAD6

2 1

Re: [PATCH 1/5] ddraw/tests: Don't skip d3d1-2 tests if DirectDrawCreateEx isn't present
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17003 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2334: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2518: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2665: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [2/2] widl: Fix generation of a typelib for winhttp.
by Huw Davies 05 Oct '15

05 Oct '15

On 2 Oct 2015, at 03:25, Dmitry Timoshkov wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 26600e4..7973113 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -974,8 +974,7 @@ static int encode_type( > { > int typeinfo_offset; > > - /* typedef'd types without public attribute aren't included in the typelib */ > - while (type->typelib_idx < 0 && type_is_alias(type) && !is_attr(type->attrs, ATTR_PUBLIC)) > + while (type->typelib_idx < 0 && type_is_alias(type)) > type = type_alias_get_aliasee(type); > > chat("encode_type: VT_USERDEFINED - type %p name = %s real type %d idx %d\n", type, > @@ -1836,7 +1835,7 @@ static msft_typeinfo_t *create_msft_typeinfo(msft_typelib_t *typelib, enum type_ > MSFT_TypeInfoBase *typeinfo; > MSFT_GuidEntry guidentry; > > - chat("create_msft_typeinfo: name %s kind %d\n", name, kind); > + chat("create_msft_typeinfo: name %s kind %d, index %d\n", name, kind, typelib->typelib_header.nrtypeinfos); > > msft_typeinfo = xmalloc(sizeof(*msft_typeinfo)); > memset( msft_typeinfo, 0, sizeof(*msft_typeinfo) ); > @@ -2307,9 +2306,7 @@ static void add_entry(msft_typelib_t *typelib, const statement_t *stmt) > { > const type_list_t *type_entry = stmt->u.type_list; > for (; type_entry; type_entry = type_entry->next) { > - /* if the type is public then add the typedef, otherwise attempt > - * to add the aliased type */ > - if (is_attr(type_entry->type->attrs, ATTR_PUBLIC)) > + if (type_get_type(type_entry->type) == TYPE_BASIC) > add_typedef_typeinfo(typelib, type_entry->type); > else > add_type_typeinfo(typelib, type_alias_get_aliasee(type_entry->type)); Doesn't this essentially make [public] a nop? That seems wrong. The WinHttpRequestOption enum has a [uuid] attribute, so that probably has something to do with it. Huw.

3 8

Re: [PATCH 5/5] ddraw: Enumerate the correct Direct3D devices in the correct order
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16988 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2428: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2428: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2612: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2759: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2759: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 4/5] ddraw: Accept all 3 versions of D3DFINDDEVICERESULT
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16987 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2367: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2367: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2551: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2698: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2698: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16986 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16985 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16984 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2353: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2537: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2684: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: ntdll: Work around a conflict between Wine and Solaris list.h.
by André Hentschel 04 Oct '15

04 Oct '15

Am 04.10.2015 um 16:32 schrieb Francois Gouget: > + * This need to be workaround it here. Hi Francois, I'm not a native speaker, but this sounds strange. Same for the original commit from 2008

2 1

Re: [PATCH 3/5] ddraw/tests: Restore strings modified by D3D7EnumLifetimeTest
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16983 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2360: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2360: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2544: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2691: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2691: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16982 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2353: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2353: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2537: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2684: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2684: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [PATCH 1/5] ddraw/tests: Don't skip d3d1-2 tests if DirectDrawCreateEx isn't present
by Marvin 04 Oct '15

04 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16981 Your paranoid android. === w1064 (32 bit d3d) === d3d.c:2334: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2334: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2518: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2665: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2665: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

Re: [2/2 v4 resend] winex11.drv: Implement FlashWindowEx.
by André Hentschel 04 Oct '15

04 Oct '15

Am 03.10.2015 um 05:39 schrieb Jactry Zeng: > Superseded patch 114739. > > ChangeLog: > v4: > - Rename driver entry to FlashWindowEx; > - Put FlashWindowEx/pFlashWindowEx in right place; > - Add CDECL for X11DRV_FlashWindowEx. > v3: > - Use x11drv_atom instead of XInternAtom; > - Only do XSendEvent() when data->mapped is true. > v2: > - Use _NET_WM_STATE_DEMANDS_ATTENTION instead of Urgency. > Hi, I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function. In this patch you do Ex->non-Ex->Ex which looks strange.

2 1

Re: [PATCH 4/5] ws2_32: Add support for TransmitFile headers and footers.
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16975 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7324: Test failed: bytesReturned isn't supposed to be 1 sock.c:7370: Test failed: Waiting for timeout failed with 0 + errno 997

2 1

Re: [3/4] psapi/tests: Adjust margin for win10
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16971 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3

1 0

Re: [2/4] psapi/tests: Remove bad test
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16970 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:627: Test failed: wrong length 3 psapi_main.c:643: Test failed: wrong length 3

1 0

Re: [1/4] psapi/tests: Disable tests which crash on win10
by Marvin 03 Oct '15

03 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16969 Your paranoid android. === w1064 (32 bit psapi_main) === psapi_main.c:157: Test failed: cbNeeded=136 psapi_main.c:644: Test failed: wrong length 3 psapi_main.c:660: Test failed: wrong length 3 === w1064 (64 bit psapi_main) === psapi_main.c:644: Test failed: wrong length 3 psapi_main.c:660: Test failed: wrong length 3

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel