- wine-devel - winehq.org

Re: [PATCH 1/4] ntdll: Implement retrieving DOS attributes in NtQueryInformationFile (try 2).
by Alexandre Julliard 19 Dec '14

19 Dec '14

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > Currently only Linux extended attributes are supported, when they are > not available at compile time the ports implementation will fall back > to a "not-supported" return and any such attributes will be ignored. > It is necessary to place this feature in ports so that Mac and FreeBSD > can be supported separately, as the semantics of these APIs are quite > different on such systems (patches to come after this initial > implementation). That doesn't mean they should go into ports, especially not as such non-standard functions. Unless you really have to use them all over the place, they should remain in ntdll. -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [3/3] advapi32: Fix HKLM\Software handling when opening with KEY_WOW64_32KEY.
by Nikolay Sivov 19 Dec '14

19 Dec '14

On 12/18/2014 06:21 PM, Akihiro Sagawa wrote: > --- > dlls/advapi32/registry.c | 99 ++++++++++++++++++++++++++++++++++++------ > dlls/advapi32/tests/registry.c | 6 +-- > 2 files changed, 88 insertions(+), 17 deletions(-) > Just curious, why HKLM\Software needs special handling in this case? In other words is there a solution that covers all paths?

2 1

Patch 108275 superseded incorrectly?
by Dmitry Kozliuk 19 Dec '14

19 Dec '14

Hello, Patch status page shows patch http://source.winehq.org/patches/data/108275 as "Superseded", and patch http://source.winehq.org/patches/data/108285 as "New". However, the former is supposed to supersede the latter: it has "(try 2)" mark an was submitted later with an explanation. Please consider patch status correction. -- Dmitry Kozliuk

1 0

Re: [PATCH 3/4] ntdll: Implement storing DOS attributes in NtSetInformationFile (try 2).
by Marvin 19 Dec '14

19 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10823 Your paranoid android. === w8 (32 bit file) === file.c:397: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

Re: [PATCH 3/4] ntdll: Implement storing DOS attributes in NtSetInformationFile.
by cdavis5x＠gmail.com 18 Dec '14

18 Dec '14

> On Dec 18, 2014, at 10:16 AM, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > This patch implements storing DOS attributes in the Samba format > "user.DOSATTRIB" extended attribute using fsetxattr and fremovexattr. > FILE_ATTRIBUTE_NORMAL is masked out since that attribute is > unnecessary, and leaving it out avoids having to store an attribute > for every file on the system. Only NORMAL? There are quite a few DOS attributes. Here’s a list from <winnt.h>: #define FILE_ATTRIBUTE_READONLY 0x00000001 #define FILE_ATTRIBUTE_HIDDEN 0x00000002 #define FILE_ATTRIBUTE_SYSTEM 0x00000004 #define FILE_ATTRIBUTE_DIRECTORY 0x00000010 #define FILE_ATTRIBUTE_ARCHIVE 0x00000020 #define FILE_ATTRIBUTE_DEVICE 0x00000040 #define FILE_ATTRIBUTE_NORMAL 0x00000080 #define FILE_ATTRIBUTE_TEMPORARY 0x00000100 #define FILE_ATTRIBUTE_SPARSE_FILE 0x00000200 #define FILE_ATTRIBUTE_REPARSE_POINT 0x00000400 #define FILE_ATTRIBUTE_COMPRESSED 0x00000800 #define FILE_ATTRIBUTE_OFFLINE 0x00001000 #define FILE_ATTRIBUTE_NOT_CONTENT_INDEXED 0x00002000 #define FILE_ATTRIBUTE_ENCRYPTED 0x00004000 (Yes, all of those are in Microsoft’s public headers. I checked.) Of those, these are the ones that Samba lets clients set: FILE_ATTRIBUTE_READONLY FILE_ATTRIBUTE_HIDDEN FILE_ATTRIBUTE_SYSTEM FILE_ATTRIBUTE_ARCHIVE FILE_ATTRIBUTE_OFFLINE and these are the ones that Samba returns: FILE_ATTRIBUTE_READONLY FILE_ATTRIBUTE_HIDDEN FILE_ATTRIBUTE_SYSTEM FILE_ATTRIBUTE_DIRECTORY FILE_ATTRIBUTE_ARCHIVE FILE_ATTRIBUTE_SPARSE_FILE (Weird. They let people set OFFLINE, but never return it…) These are the ones that MSDN says Windows lets programs set with SetFileAttributes() (but I can’t vouch for MSDN’s accuracy, so this really needs to be demonstrated with a test): FILE_ATTRIBUTE_READONLY FILE_ATTRIBUTE_HIDDEN FILE_ATTRIBUTE_SYSTEM FILE_ATTRIBUTE_NORMAL FILE_ATTRIBUTE_ARCHIVE FILE_ATTRIBUTE_TEMPORARY FILE_ATTRIBUTE_OFFLINE FILE_ATTRIBUTE_NOT_CONTENT_INDEXED and these are the ones that CreateFile() is supposed to let programs set: FILE_ATTRIBUTE_READONLY FILE_ATTRIBUTE_HIDDEN FILE_ATTRIBUTE_SYSTEM FILE_ATTRIBUTE_NORMAL FILE_ATTRIBUTE_ARCHIVE FILE_ATTRIBUTE_TEMPORARY FILE_ATTRIBUTE_OFFLINE FILE_ATTRIBUTE_ENCRYPTED I definitely think we shouldn’t be letting people set the DEVICE attribute (this is, I suspect, the attribute you get from a device handle), or the REPARSE_POINT attribute (this is what Windows returns for e.g. symlinks and junctions); MSDN says that the SET_REPARSE_POINT FSCTL is supposed to be able to set this attribute, though. Samba also forcibly sets the DIRECTORY attribute according to whether the file is or is not actually a directory; we should do this, too. MSDN also says the COMPRESSED attribute is supposed to be set by the SET_COMPRESSION FSCTL, the ENCRYPTED attribute is supposed to be set by advapi32.EncryptFile() (which I suspect just makes a SET_ENCRYPTION FSCTL) or when the file is created, and the SPARSE_FILE attribute is supposed to be set by the SET_SPARSE FSCTL, so we should mask all those out too. (Or error out, depending on what native does; as always, the tests are your friends here.) Also, NORMAL is only supposed to be valid by itself, so if any attributes are set along with NORMAL, we may need to error out. We REALLY need tests for all this. ;) (We have some tests for setting file attributes, but not enough IMO.) Chip

2 1

Re: [PATCH 4/4] ntdll: Implement storing DOS attributes in NtCreateFile.
by Marvin 18 Dec '14

18 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10817 Your paranoid android. === build (build) === Make in include dir failed

1 0

Re: [PATCH 3/4] ntdll: Implement storing DOS attributes in NtSetInformationFile.
by Marvin 18 Dec '14

18 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10816 Your paranoid android. === build (build) === Make in include dir failed

1 0

Re: winex11.drv: don't drop raw input events after mouse warp
by Patrick Rudolph 18 Dec '14

18 Dec '14

Am 2014-12-17 20:56, schrieb Alexandre Julliard: > Patrick Rudolph <siro(a)das-labor.org> writes: > >> This patch fixes bug https://bugs.winehq.org/show_bug.cgi?id=32913 >> After each mouse move the cursor is warped back to the center of the >> screen. This is OK for XInput, but not for XInput2 as XInput2 reports >> raw events that doesn't care about absolute screen coordinates and >> doesn't need to be dropped. There're frequent cursor warps resulting >> in lot's of dropped raw motion events (up to all). These dropped >> motion events cause mouse jitter, which is notable in FPS games, but >> not while using any GUI that only needs pixel coordinates. > > The problem is that warping the mouse also generates events, and you > have to ignore those. I've attached a log file, here: https://bugs.winehq.org/attachment.cgi?id=50258 As you can see XWarpCursor inserts MotionNotify events, that are correctly ignored using the serial, but there're no inserted RawMotion events. So there's no need to drop them, correct me if I'm wrong. Sadly I couldn't find any documentation for XWarpCursor and RawMotion events. Kind Regards, Patrick

2 1

Re: winex11.drv: don't drop raw input events after mouse warp
by Alexandre Julliard 17 Dec '14

17 Dec '14

Patrick Rudolph <siro(a)das-labor.org> writes: > This patch fixes bug https://bugs.winehq.org/show_bug.cgi?id=32913 > After each mouse move the cursor is warped back to the center of the > screen. This is OK for XInput, but not for XInput2 as XInput2 reports > raw events that doesn't care about absolute screen coordinates and > doesn't need to be dropped. There're frequent cursor warps resulting > in lot's of dropped raw motion events (up to all). These dropped > motion events cause mouse jitter, which is notable in FPS games, but > not while using any GUI that only needs pixel coordinates. The problem is that warping the mouse also generates events, and you have to ignore those. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] mmdevapi: More accurately track device position
by Marvin 17 Dec '14

17 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10797 Your paranoid android. === w7u (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.501088 render.c:2005: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.671337 render.c:2005: Test failed: Got wrong volume: 0.671337

1 0

RE: [PATCH] libs/wine/string.c: Always return (int)written
by Hugh McMaster 17 Dec '14

17 Dec '14

On Wednesday, Dec 17 05:54:42 CST 2014, Jonathan Vollebregt wrote: >No: http://msdn.microsoft.com/en-us/library/1kt27hek.aspx#returnValueToggle >> vsnprintf ,_vsnprintf, and _vsnwprintf return the number of characters written if the number of characters to write is less than or equal to count; if the number of characters to write is greater than count, these functions return -1 indicating that output has been truncated. The return value does not include the terminating null, if one is written. >> >> If buffer or format is NULL, or if count is less than or equal to zero, these functions invoke the invalid parameter handler, as described in Parameter Validation. If execution is allowed to continue, these functions return -1 and set errno to EINVAL. I disagree. vsnprintfW is not a Windows function. We should be following the Linux form here, which returns the number of chars that would be written.

2 1

Re: [PATCH] libs/wine/string.c: Always return (int)written
by Jonathan Vollebregt 17 Dec '14

17 Dec '14

No: http://msdn.microsoft.com/en-us/library/1kt27hek.aspx#returnValueToggle > vsnprintf ,_vsnprintf, and _vsnwprintf return the number of characters written if the number of characters to write is less than or equal to count; if the number of characters to write is greater than count, these functions return -1 indicating that output has been truncated. The return value does not include the terminating null, if one is written. > > If buffer or format is NULL, or if count is less than or equal to zero, these functions invoke the invalid parameter handler, as described in Parameter Validation. If execution is allowed to continue, these functions return -1 and set errno to EINVAL. On 12/17/2014 12:47 PM, Hugh McMaster wrote: > Both GCC and Windows versions of vsnprintf return the number of chars that would be written to a given buffer when vsnprintf(NULL, 0, fmt, va_args) is called. > > Wine currently returns -1, which is incorrect. > > Also, if there is a short buffer, that is, buffer <= len, not only is any output truncated, but the return value is the number of chars that would be written if the buffer had sufficient space. > > Here, Wine returns -1, which is, again, incorrect. > > In all cases, the return value should be the number of chars written or the number of chars that would be written if the buffer has sufficient space.

1 0

RE: (resend) regedit: Improve error message when recasing a key.
by Hugh McMaster 17 Dec '14

17 Dec '14

On Wednesday, 17 Dec 2014 01:31:53 +0300, Dmitry Kozliuk wrote: >+ IDS_ERROR_RENAMING_VALUE "Error Renaming Value" >+ IDS_KEY_ALREADY_EXISTS "The Registry Editor cannot rename %s. > The specified key name already exists. Type another name and try again." You cannot use those strings. The first is a verbatim copy from native regedit.exe. The second is almost verbatim, with the exception of "key name". Native regedit.exe uses "value name". Please craft different text with the same meaning.

1 0

Re: shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault (try 4)
by Nikolay Sivov 17 Dec '14

17 Dec '14

On 12/17/2014 08:11 AM, Alistair Leslie-Hughes wrote: > - test_IApplicationAssociationRegistration_QueryInterface(); > + /* this works since Vista */ > + hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER, > + &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg); > + if (hr == S_OK) > + { > + test_IApplicationAssociationRegistration_QueryInterface(appreg); > + test_IApplicationAssociationRegistration_QueryCurrentDefault(appreg); > + > + IApplicationAssociationRegistration_Release(appreg); > + } > + else > + skip("IApplicationAssociationRegistration not supported: 0x%x\n", hr); This should be win_skip().

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByName (try 3)
by Marvin 17 Dec '14

17 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10793 Your paranoid android. === w8 (32 bit address) === The test timed out

2 1

Re: [1/2] server: Never attempt to wake up the current thread.
by Sebastian Lackner 16 Dec '14

16 Dec '14

On 16.12.2014 06:23, Sebastian Lackner wrote: > Alternative approach for patch #107840 "server: Avoid sending unexpected wakeup with uninitialized cookie value." (which should also still be fine, but this solution is probably a bit easier). > > We never want to send any wakeup cookies to our currently active thread, so just fake success in this case. > To demonstrate what happens without this patch (and to avoid any regressions) I've also added a test in patch 2/2. > > The unexpected cookies itself are not visible without debug messages of course, but because of the buffer size limitation the whole wineserver freezes. > When forcefully killing the test, the wineserver also crashes with: > > ==14785== Invalid read of size 4 > ==14785== at 0x807CE1B: select_on (thread.c:830) > ==14785== by 0x807E604: req_select (thread.c:1462) > ==14785== by 0x8076003: call_req_handler (request.c:247) > ==14785== by 0x807620A: read_request (request.c:302) > ==14785== by 0x807B8C1: thread_poll_event (thread.c:267) > ==14785== by 0x805679F: fd_poll_event (fd.c:446) > ==14785== by 0x8056A43: main_loop_epoll (fd.c:541) > ==14785== by 0x8056E2F: main_loop (fd.c:886) > ==14785== by 0x805F4B6: main (main.c:148) > ==14785== Address 0x50 is not stack'd, malloc'd or (recently) free'd > ==14785== > ==14785== Process terminating with default action of signal 11 (SIGSEGV): dumping core > > Reason for the crash is that the wakeup write() syscall fails -> the thread is terminated with kill_thread() -> this sets current = NULL - the code later assumes that 'current' is still a valid pointer. By not sending wakeup cookies we avoid this whole code path, and the test runs well. > > --- > server/thread.c | 4 ++++ > 1 file changed, 4 insertions(+) > Please ignore this patch for now, there are some situations (not covered by existing tests) where this idea would not work correctly.

1 0

Re: include/ddk: add csq.h
by Austin English 16 Dec '14

16 Dec '14

On Thu, Nov 13, 2014 at 3:30 PM, Austin English <austinenglish(a)gmail.com> wrote: > > > -- > -Austin > Patch dropped off the tracker without comment, could I get some feedback please? -- -Austin

1 0

Re: zh_CN Translation Submittion
by Nikolay Sivov 15 Dec '14

15 Dec '14

On 15.12.2014 17:39, Jeff Bai wrote: > Umm... I think POEdit is the one who made these changes... Not sure if it's my settings or what. Yes, it's mostly likely it. But you don't have to use it, your favorite text editor will work just fine. > > >> 在 2014年12月15日，上午12:01，Nikolay Sivov <bunglehead(a)gmail.com> 写道： >> >>> On 15.12.2014 7:53, Jeff Bai wrote: >>> Hello, fellow developers. >>> >>> I've got several hundred strings translated to zh_CN, and according to >>> you guys' wiki I am supposed to submit a patch of what I've changed. >>> >>> So here it is (too long, used PasteBin) >>> >>> https://pastebin.anthonos.org/view/bb82ca07 >>> >>> Also, I am not sure if I would be fast enough to get them all done by >>> 1.7.34 (nearly two weeks apart?), so is it Okay for me to submit them >>> bit by bit, like this time, several hundred? There's still about 950 >>> left as I can see on POEdit - and I think I can push this to 100% after >>> my high school final four days later. >>> >>> Thanks everyone, Wine is AWESOME. >>> >>> Regards, >>> >>> Jeff Bai (白铭骢) >> >> Hi, Jeff. >> >> I think it's okay to submit full diff at once. But please avoid changing original messages like you do here (or maybe not you directly but poedit): >> >>> #: oleview.rc:121 >>> -msgid "" >>> -"Toggle the display of component categories that are not meant to be visible" >>> +msgid "Toggle the display of component categories that are not meant to be visible" >>> msgstr "切换隐藏组件类显示" >> >> So keep msgid part as it is and touch only msgstr part, this will also help reducing resulting diff. >> >> And once you fixed that you should send a patch to wine-patches(a)winehq.org as it says here http://wiki.winehq.org/SubmittingPatches.

1 0

setting break point in 16 bit Windows app
by Marius Cirsta 15 Dec '14

15 Dec '14

I'd like to use winedbg to set a break point in a 16 bit Windows app, to stop execution on some function call. From what I've read this is broken as of 2005 ( https://www.winehq.org/pipermail/wine-devel/2006-June/048343.html ). Has anything happened since ? I'm interested in getting this to work but it all depends on the effort involved. Can anyone provide an estimate as to how much work is needed ? Thanks.

1 0

Re: d3d9: Don't assert when apps pass in the wrong shader iface.
by Sebastian Lackner 15 Dec '14

15 Dec '14

On 15.12.2014 15:29, Michael Stefaniuc wrote: > Fixes a regression reported in > https://bugs.winehq.org/show_bug.cgi?id=37723 > --- > dlls/d3d9/shader.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3d9/shader.c b/dlls/d3d9/shader.c > index 0c2c881..9541028 100644 > --- a/dlls/d3d9/shader.c > +++ b/dlls/d3d9/shader.c > @@ -165,9 +165,8 @@ HRESULT vertexshader_init(struct d3d9_vertexshader *shader, struct d3d9_device * > > struct d3d9_vertexshader *unsafe_impl_from_IDirect3DVertexShader9(IDirect3DVertexShader9 *iface) > { > - if (!iface) > + if (!iface && iface->lpVtbl != &d3d9_vertexshader_vtbl) ^^^^ Shouldn't it be !iface || iface->lpVtbl != &d3d9_vertexshader_vtbl ? > return NULL; > - assert(iface->lpVtbl == &d3d9_vertexshader_vtbl); > > return impl_from_IDirect3DVertexShader9(iface); > } > @@ -315,9 +314,8 @@ HRESULT pixelshader_init(struct d3d9_pixelshader *shader, struct d3d9_device *de > > struct d3d9_pixelshader *unsafe_impl_from_IDirect3DPixelShader9(IDirect3DPixelShader9 *iface) > { > - if (!iface) > + if (!iface && iface->lpVtbl != &d3d9_pixelshader_vtbl) > return NULL; > - assert(iface->lpVtbl == &d3d9_pixelshader_vtbl); > > return impl_from_IDirect3DPixelShader9(iface); > } >

1 0

Re: zh_CN Translation Submittion
by Nikolay Sivov 15 Dec '14

15 Dec '14

On 15.12.2014 7:53, Jeff Bai wrote: > Hello, fellow developers. > > I've got several hundred strings translated to zh_CN, and according to > you guys' wiki I am supposed to submit a patch of what I've changed. > > So here it is (too long, used PasteBin) > > https://pastebin.anthonos.org/view/bb82ca07 > > Also, I am not sure if I would be fast enough to get them all done by > 1.7.34 (nearly two weeks apart?), so is it Okay for me to submit them > bit by bit, like this time, several hundred? There's still about 950 > left as I can see on POEdit - and I think I can push this to 100% after > my high school final four days later. > > Thanks everyone, Wine is AWESOME. > > Regards, > > Jeff Bai (白铭骢) > > > Hi, Jeff. I think it's okay to submit full diff at once. But please avoid changing original messages like you do here (or maybe not you directly but poedit): > #: oleview.rc:121 > -msgid "" > -"Toggle the display of component categories that are not meant to be visible" > +msgid "Toggle the display of component categories that are not meant to be visible" > msgstr "切换隐藏组件类显示" So keep msgid part as it is and touch only msgstr part, this will also help reducing resulting diff. And once you fixed that you should send a patch to wine-patches(a)winehq.org as it says here http://wiki.winehq.org/SubmittingPatches.

1 0

Re: ole32:fix CoWaitForMultipleHandles cause RPC hang
by Changhui Liu 15 Dec '14

15 Dec '14

Hi, I got it. The CoWaitForMultipleHandles of Microsoft implement is this: The message loop continue although has received WM_QUIT, but just dispatch message who sent to the OleMainThreadWndClass Window. I attached a latest patch and a verify function. Run the test_CoWaitForMultipleHandlesDispatchMsg, We will only get the message who send to cowait_test_class window . It also pass your PeekMessage test at: https://github.com/wine-compholio/wine-staging/blob/master/patches/ole32-Co… Please help me review it again when you are free. Thank you. ------------------ Regards. ------------------ Original ------------------ From: "Sebastian Lackner"<sebastian(a)fds-team.de>; Date: Sat, Dec 13, 2014 11:32 PM To: "Changhui Liu"<liuchanghui(a)linuxdeepin.com>; Cc: "wine-devel"<wine-devel(a)winehq.org>; Subject: Re: ole32:fix CoWaitForMultipleHandles cause RPC hang Hi, On 13.12.2014 16:15, Changhui Liu wrote: > Hi Sebastian, > > > I tested your current work-in-progress patch: > https://github.com/wine-compholio/wine-staging/blob/master/patches/ole32-Co… > > I have two puzzles about these code: >> index = 0xdeadbeef; >> PostMessageA(hWnd, WM_DDE_FIRST, 0, 0); >> PostQuitMessage(44); >> thread = CreateThread(NULL, 0, post_message_thread, hWnd, 0, &tid); >> ok(thread != NULL, "CreateThread failed, error %u\n", GetLastError()); >> hr = CoWaitForMultipleHandles(0, 100, 2, handles, &index); >> ok(hr == RPC_S_CALLPENDING, "expected RPC_S_CALLPENDING, got 0x%08x\n", hr); >> ok(index == 0 || broken(index == 0xdeadbeef) /* Win 8 */, "expected index 0, got %u\n", index); >> success = PeekMessageA(&msg, hWnd, WM_DDE_FIRST, WM_DDE_FIRST, PM_REMOVE); >> ok(success, "PeekMessageA failed, error %u\n", GetLastError()); > > > The first, why use the PeekMessage to check if received a WM_DDE_FIRST message? > Is there an real application do like that way? Of course there are multiple ways to test for window messages in the message queue, I just picked PeekMessageA because it doesn't require setting up a Wndproc. > > > In fact CoWaitForMultipleHandles has a message loop, the WM_DDE_FIRST message has been > dispatched to the window's WNDPROC. So the PeekMessageA certainly failed. No, it doesn't. Feel free to run the tests yourself on a Windows machine, I have tested them with the Wine testbot and all tests pass on 2000/XP/Vista/8/2008/... - which means that Windows does not process all WM_DDE_FIRST messages. This is also why I am unsure about how to fix it. When changing the behaviour in order to fix one of the tests which fails in Wine (marked with todo_wine), it breaks other tests which were working well before. > > > I think the correct test should be this: > 1, Define a custom WNDPROC function named cowait_test_wnd_proc . > 2, Define a global int variable named g_count_of_wm_dde_first. > 3, Set the value of g_count_of_wm_dde_first to zero before call CoWaitForMultipleHandles. > 4, Increase the value of g_count_of_wm_dde_first by one, once received a WM_DDE_FIRST message in cowait_test_wnd_proc. > 5, Check if the value of g_count_of_wm_dde_first is equal to 2 after CoWaitForMultipleHandles returned. > This testing method would also be fine, but you would get 1 instead of 2. My patch doesn't show any test failures on Windows, which means that one of the WM_DDE_FIRST messages is still in the queue. > > The second is why use todo_wine ? > todo_wine > ok(!success, "PeekMessageA succeeded\n"); > why not just write? > ok(!success, "PeekMessageA succeeded\n"); > The Wine coding guideline does not allow to add new test failures, instead all tests which do not pass yet have to be marked with "todo_wine". This makes easily visible which tests need further work just by looking at the source code, moreover it avoids introducing regressions (breaking tests which were working well before). Take a look at some of the other Wine tests, this is not the only place where its used. > > > > Thank you. Regards, Sebastian

1 1

Re: [1/2] jscript: Support PROPERTYGET in Date Value
by Jacek Caban 14 Dec '14

14 Dec '14

On 12/14/14 00:18, Alistair Leslie-Hughes wrote: > case INVOKE_PROPERTYGET: > + { > + DateInstance *date; > + > + if(!(date = date_this(jsthis))) > + return throw_type_error(ctx, JS_E_DATE_EXPECTED, NULL); It's guaranteed that jsthis is of DataInstance type in case of *_value functions, so there is no need to check that in runtime. You may simply cast it here. Jacek

1 0

Re: ole32:fix CoWaitForMultipleHandles cause RPC hang
by Sebastian Lackner 13 Dec '14

13 Dec '14

On 11.12.2014 15:07, Changhui Liu wrote: > Because there's a RPC request need to be handled by OLE apartment window proc apartment_wndproc. > So, after received a WM_QUIT, > if the GUI thread in calling CoWaitForMultipleHandles don't handle message loop any more , > the RPC will never be handled, the RPC dispatch thread will be hang. > > > > There are several issues with this patch. You wrote in your last mail: > so this patch can't pass test on testbot.winehq.org, it only pass test on wine. > The test result is here, https://testbot.winehq.org/JobDetails.pl?Key=10727. It is not clear what you mean. The test should of course also pass on testbot.winehq.org, if it doesn't, this means that Wine doesn't properly reproduce the expected behaviour. You need to create a test so that it passes on both wine and the testbot, otherwise nothing is tested at all. Other issues in your patch: * It seems very unlikely that this is how quit messages are processed. Immediately calling PostQuitMessage(...) but continuing to process messages means that effectively WM_QUIT is lost. * Always add a "\n" at the end of ok(...) messages. * Try to avoid huge sleeps like Sleep(5000). This will probably cause the tests time out. Unfortunately I didn't have much time to look into this issue myself so far, but I guess I'll have more time at the weekend. Regards, Sebastian

2 4

Re: [PATCH v3 03/10] reg: Add system error printing function
by Indrek Altpere 13 Dec '14

13 Dec '14

Seems that the patches have reached the magical "1 month" limit where they disappear from the list silently. Last I saw, your patchset contained about 8 or 10 patches? Not sure if the best suggestion by official rules/guidelines, but perhaps it would be possible to add the new stuff in multiple, smaller patchsets, instead of one mega-patchset? It would mean that reviewers don't have to dig around in hundreds of lines of code changes that change a lot of functionality, makes it hard to keep track of all of it and review it thoroughly. Many big patchsets have gotten stalled like that: reviewer notices a few things, notifies developer, developer makes the changes, sends the changed full patchset again, reviewer checks full patchset again, finds more stuff in next files (or even the same files), notifies developer and so on and so on. Sometimes multiple reviewers also cause havoc, because due to many coding rules not being written down (http://wiki.winehq.org/SubmittingPatches contains general and vague guidelines, but essentially 0 hard examples) and each reviewer having a bit different viewpoint about what styling issues are could-be or should-be, so sending a huge set will end up with responses "here's about ~10 things wrong with your code" and like that after each submit. As I understand, someone correct me if I'm wrong, there is currently also no active reg component maintainer, who would be able to review things quickly, so smaller patchset would probably help things move along much faster? About https://source.winehq.org/patches/data/107580 getting stalled, I have no clue/opinion, does not seem to be overly complex? Regards, Indrek Altpere

3 2

Re: jscript: Added test of Date object default value.
by Marvin 12 Dec '14

12 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10746 Your paranoid android. === w2000pro (32 bit run) === run.c:1962: Test failed: Invoke failed: 8000ffff run.c:1963: Test failed: V_VT(v) = 0

1 0

Re: [PATCH v4 2/4] combase: Implement creation and deletion of HSTRING objects.
by Martin Storsjö 12 Dec '14

12 Dec '14

On Wed, 10 Dec 2014, Martin Storsjo wrote: > --- > configure.ac | 1 + > .../api-ms-win-core-winrt-string-l1-1-0.spec | 8 +- > dlls/combase/Makefile.in | 3 +- > dlls/combase/combase.spec | 8 +- > dlls/combase/string.c | 143 +++++++++++++++++++++ > dlls/combase/tests/Makefile.in | 4 + > dlls/combase/tests/string.c | 128 ++++++++++++++++++ > tools/make_specfiles | 1 + > 8 files changed, 287 insertions(+), 9 deletions(-) > create mode 100644 dlls/combase/string.c > create mode 100644 dlls/combase/tests/Makefile.in > create mode 100644 dlls/combase/tests/string.c Any further comments on these ones (2-4), or should I resubmit them for a new look? // Martin

1 0

Drawbridge -- WinAPI/NT API sandbox in Windows
by Saulius Krasuckas 11 Dec '14

11 Dec '14

Hello, I just have heard about MS project called Drawbridge. [*] They use NT kernel (ntoskrnl + win32k) implementation in user-mode (NTUM) to load native DLLs and services from different versions of Windows, IIUC. Set of downcalls from NTUM (to native kernel) is reduced to 45 items. This way a process-based isolation is achieved. Some sort of sandbox/container. It sounds like Wine on Windows. Just FYI. S. [*] http://research.microsoft.com/en-us/projects/drawbridge/

1 0

Re: ole32:fix CoWaitForMultipleHandles cause RPC hang
by Marvin 11 Dec '14

11 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10727 Your paranoid android. === w2000pro (32 bit compobj) === compobj.c:2325: compobj.c:2299: Test failed: sleep 5 second === wxppro (32 bit compobj) === compobj.c:2325: compobj.c:2299: Test failed: sleep 5 second === wvistau64 (32 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK! === w2008s64 (32 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK! === w7u (32 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK! === w8 (32 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK! === wvistau64 (64 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK! === w2008s64 (64 bit compobj) === compobj.c:2299: Test failed: Expected OLE apartment window is valid!compobj.c:2334: The RPC request is processed OK!

1 0

Re: ole32:fix CoWaitForMultipleHandles cause RPC hang
by Marvin 11 Dec '14

11 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10726 Your paranoid android. === w2000pro (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === wxppro (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === wvistau64 (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === w2008s64 (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === w7u (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === w8 (32 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === wvistau64 (64 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second === w2008s64 (64 bit compobj) === compobj.c:2296: Test failed: Expected OLE apartment window is valid!compobj.c:2325: sleep 1 second

1 0

Re: d3dx9: ID3DXFont PreloadCharacters return S_OK
by Bruno Jesus 11 Dec '14

11 Dec '14

On Thu, Dec 11, 2014 at 1:27 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > If any program uses the SharpDX library, it throws an exception when > PreloadCharacters > returns E_NOTIMPL. > > Changelog: > d3dx9: ID3DXFont PreloadCharacters return S_OK Missing patch. > > Best Regards > Alistair Leslie-Hughes Regards, Bruno

1 0

Re: dwrite: Block creation of unsupported face types
by Marvin 10 Dec '14

10 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10716 Your paranoid android. === wvistau64 (32 bit font) === font.c:1056: Test failed: got 0x80070057 === w2008s64 (32 bit font) === font.c:1056: Test failed: got 0x80070057 === wvistau64 (64 bit font) === font.c:1056: Test failed: got 0x80070057 === w2008s64 (64 bit font) === font.c:1056: Test failed: got 0x80070057

1 0

Re: [8/9] winhttp: Don't try to read data when the server response is HTTP_STATUS_NO_CONTENT or HTTP_STATUS_NOT_MODIFIED.
by Bruno Jesus 10 Dec '14

10 Dec '14

On Tue, Dec 9, 2014 at 9:50 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Tests based on a patch by Bruno Jesus. > --- > dlls/winhttp/request.c | 15 ++++++----- > dlls/winhttp/tests/winhttp.c | 62 +++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 69 insertions(+), 8 deletions(-) > Hans, I can no longer find the bug that this was about. Can you please give the bug URL? Do you think your current patch set fixed it? Best regards, Bruno

2 1

Re: [PATCH v3 4/7] include: Add hstring.h and winstring.h.
by Alexandre Julliard 10 Dec '14

10 Dec '14

Martin Storsjo <martin(a)martin.st> writes: > --- > No changes since v2. > --- > include/Makefile.in | 2 ++ > include/hstring.h | 39 +++++++++++++++++++++++++++++++++++++++ > include/winstring.h | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+) > create mode 100644 include/hstring.h > create mode 100644 include/winstring.h hstring.h should be generated from idl. -- Alexandre Julliard julliard(a)winehq.org

2 1

RE: [PATCH v3 03/10] reg: Add system error printing function
by Hugh McMaster 09 Dec '14

09 Dec '14

On Saturday, 8 Nov 2014 11:26:44 +0100, Jonathan Vollebregt wrote: +static void reg_print_error(LSTATUS error_code) +{ + switch (error_code) + { + case ERROR_SUCCESS: + return; + case ERROR_BAD_COMMAND: + reg_message(STRING_INVALID_CMDLINE); + return; + default: + { + static const WCHAR error_string[] = {'%','0','5','d',':',' ','%','s',0}; + WCHAR *message = NULL; + FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER, NULL, + error_code, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (WCHAR *)&message, 0, NULL); + + reg_message(STRING_ERROR); + reg_printfW(error_string, error_code, message); + LocalFree(message); + return; + } + } +}This seems like a step backwards to me. It would be much better to add the required functionality -- e.g. FormatMessage() -- and fix reg.exe printf-style functions in one go. See http://source.winehq.org/patches/data/107578 for what I mean. Also, mixing reg_message() and reg_printfW() just seems wrong. A clear resource string incorporating your formatting above would suffice, I expect. -- Hugh McMaster

2 3

Re: [8/9] winhttp: Don't try to read data when the server response is HTTP_STATUS_NO_CONTENT or HTTP_STATUS_NOT_MODIFIED.
by Marvin 09 Dec '14

09 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10702 Your paranoid android. === w7u (32 bit winhttp) === winhttp.c:2035: Test failed: failed to receive response 12030 winhttp.c:2039: Test failed: failed to query status code 12019 winhttp.c:2040: Test failed: request failed unexpectedly 589826 winhttp.c:2044: Test failed: failed to query authentication schemes 4317 winhttp.c:2045: Test failed: got deadbeef winhttp.c:2046: Test failed: got deadbeef winhttp.c:2047: Test failed: got deadbeef === w8 (32 bit winhttp) === winhttp.c:2035: Test failed: failed to receive response 12030 winhttp.c:2039: Test failed: failed to query status code 12019 winhttp.c:2040: Test failed: request failed unexpectedly 589826 winhttp.c:2044: Test failed: failed to query authentication schemes 4317 winhttp.c:2045: Test failed: got deadbeef winhttp.c:2046: Test failed: got deadbeef winhttp.c:2047: Test failed: got deadbeef

2 1

Re: [9/9] winhttp/tests: Close the connection immediately after authentication.
by Marvin 09 Dec '14

09 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10703 Your paranoid android. === w2008s64 (32 bit winhttp) === winhttp.c:2250: Test failed: WinHttpReceiveResponse failed: 12152 winhttp.c:2255: Test failed: WinHttpQueryHeaders failed: 12019 winhttp.c:2256: Test failed: got 0 winhttp.c:2260: Test failed: WinHttpQueryDataAvailable failed: 12019 === w7u (32 bit winhttp) === winhttp.c:2041: Test failed: failed to receive response 12030 winhttp.c:2045: Test failed: failed to query status code 12019 winhttp.c:2046: Test failed: request failed unexpectedly 589826 winhttp.c:2050: Test failed: failed to query authentication schemes 4317 winhttp.c:2051: Test failed: got deadbeef winhttp.c:2052: Test failed: got deadbeef winhttp.c:2053: Test failed: got deadbeef === w8 (32 bit winhttp) === winhttp.c:2041: Test failed: failed to receive response 12030 winhttp.c:2045: Test failed: failed to query status code 12019 winhttp.c:2046: Test failed: request failed unexpectedly 589826 winhttp.c:2050: Test failed: failed to query authentication schemes 4317 winhttp.c:2051: Test failed: got deadbeef winhttp.c:2052: Test failed: got deadbeef winhttp.c:2053: Test failed: got deadbeef

1 0

Re: gdiplus: fix GdipFillRectangleI no effect on memory DC whose windoworigin point has changed
by Marvin 09 Dec '14

09 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10699 Your paranoid android. === w7u (32 bit graphics) === graphics.c:5575: Test failed: Expected the color of memory bitmap is blue!graphics: 4644 tests executed (0 marked as todo, 1 failure), 0 skipped.

1 0

Re: [PATCH v2 08/10] combase: Implement creation and deletion of HSTRING objects.
by Sebastian Lackner 09 Dec '14

09 Dec '14

On 08.12.2014 10:26, Martin Storsjo wrote: > + return E_INVALIDARG; > + if (str == NULL) > + { > + *out = NULL; <--- > + return S_OK; <--- > + } > + if (priv->reference) > + return WindowsCreateString(priv->buffer, priv->length, out); Wrong indentation. Moreover I noticed a mistake in patch 10. I had the guess that preallocating an empty string should also return a NULL string-buffer. + /* Test creation of an empty buffer */ + ok(pWindowsPreallocateStringBuffer(0, &ptr, &buf) == S_OK, "Failed to preallocate string buffer\n"); + ok(buf != NULL, "Empty string buffer is a null string\n"); + ok(ptr != NULL, "Empty string didn't return a buffer pointer\n"); + ok(pWindowsDeleteStringBuffer(buf) == S_OK, "Failed to delete string buffer\n"); + The testbot seems to confirm that: https://newtestbot.winehq.org/JobDetails.pl?Key=10687 ( I would suggest to wait with resending till after the daily commits, everything from patch 1-7 should be fine, and it probably doesn't make sense to resend the whole series several times. ;) ) Regards, Sebastian

2 2

Re: gdiplus: fix GdipFillRectangleI no effect on memory DC whose window origin point has changed
by Marvin 09 Dec '14

09 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10695 Your paranoid android. === w7u (32 bit graphics) === graphics.c:5575: Test failed: Expected the color of memory bitmap is blue!graphics: 4645 tests executed (0 marked as todo, 1 failure), 0 skipped.

1 0

Puzzle about ExtSelectClipRgn?
by Changhui Liu 08 Dec '14

08 Dec '14

Dear all, I test this code : void test (HDC hdc, HRGN hregion) { RECT srcbox; RECT dstbox; GetClipBox(hdc, &dstbox); GetRgnBox(hregion, &srcbox); TRACE("Before ExtSelectClipRgn:%s,%s\n", wine_dbgstr_rect(&srcbox), wine_dbgstr_rect(&dstbox) ); ExtSelectClipRgn(hdc, hregion, RGN_AND ); GetClipBox(graphics->hdc,&dstbox); TRACE("After ExtSelectClipRgn:%s,%s\n", wine_dbgstr_rect(&dstbox) ); } It output in wine is : Before ExtSelectClipRgn:(693,5)-(763,28),(693,5)-(763,28) After ExtSelectClipRgn:(693,5)-(693,5) But I think it should be output: Before ExtSelectClipRgn:(693,5)-(763,28),(693,5)-(763,28) After ExtSelectClipRgn:(693,5)-(763,28) Where is my understanding mistake, or is it a bug in ExtSelectClipRgn? Thank you!

3 3

Re: [PATCH 4/4] dwrite: Implement GetDesignGlyphAdvances()
by Marvin 08 Dec '14

08 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10681 Your paranoid android. === wvistau64 (32 bit font) === font: unhandled exception c0000005 at 00409EDC === w2008s64 (32 bit font) === font: unhandled exception c0000005 at 00409EDC === wvistau64 (64 bit font) === font: unhandled exception c0000005 at 0000000000409275 === w2008s64 (64 bit font) === font: unhandled exception c0000005 at 0000000000409275

1 0

Re: [PATCH 3/4] dwrite: Implement IsMonospacedFont()
by Marvin 08 Dec '14

08 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10680 Your paranoid android. === wvistau64 (32 bit font) === font: unhandled exception c0000005 at 00409EDC === w2008s64 (32 bit font) === font: unhandled exception c0000005 at 00409EDC === wvistau64 (64 bit font) === font: unhandled exception c0000005 at 0000000000409275 === w2008s64 (64 bit font) === font: unhandled exception c0000005 at 0000000000409275

1 0

Re: [PATCH] msvcr120: Implement more C99 math functions.
by Piotr Caban 08 Dec '14

08 Dec '14

On 12/06/14 17:07, Martin Storsjo wrote: > +/********************************************************************* > + * cbrt (MSVCR120.@) > + */ > +double CDECL MSVCR120_cbrt(double x) > +{ > +#ifdef HAVE_CBRT > + return cbrt(x); > +#else > + return x < 0 ? -powf(-x, 1.0 / 3.0) : powf(x, 1.0 / 3.0); > +#endif Please use pow instead of powf here. Thanks, Piotr

2 1

Re: [PATCH 05/10] combase: Add stub dll.
by Sebastian Lackner 08 Dec '14

08 Dec '14

Hi Martin, a few things where I am not sure about: [PATCH 05/10] [...] > +@ stub COMBASE_63 > +@ stub COMBASE_64 > +@ stub COMBASE_65 > +@ stub COMBASE_66 > +@ stub COMBASE_67 > +@ stub COMBASE_68 [...] Are these really named exports, or exports by ordinal? If they are by ordinal and have no name assigned they are probably internal, and its not worth exporting them in Wine. I also noticed that combase.dll exports a lot of functions (Co*), which in Wine are implemented in ole32. It probably makes sense to sync that, but that can also be added in a later patch in my opinion. I don't think make_specfiles already supports such a situation. [PATCH 06/10 and also following patches] > +/*********************************************************************** > + * RoInitialize (api-ms-win-core-winrt-l1-1-0.@) > + */ Those comments should probably be changed. [PATCH 07/10] Does creating an empty string really return a HSTRING or just NULL (which seems to behave identical)? It probably makes sense to add a test for that. Does WindowsCreateString or WindowsCreateStringReference strip terminating NULL chars? (Embedded NULL chars are allowed obviously, but it might be possible that trailing NULL chars are handled differently). nsivov on #winehackers also suggested that it might be worth trying to find out what the structure is on Windows, but not sure if its worth the effort. If we're not trying at all to be compatible, we could get rid of one of the two memory allocations by allocating (sizeof(hstring_private) + length) as a single chunk, and setting ->buffer according. [PATCH 09/10] I would also suggest adding tests for the content of the buffer. You can use for example memcmp(...) to verify that the content is correct. [PATCH 10/10] Is the buffer initialized? Are terminating NULLs stripped from the buffer? Regards, Sebastian

2 2

Re: [PATCH 3/4] api-ms-win-core-winrt-string: Implement a few HSTRING functions.
by Sebastian Lackner 07 Dec '14

07 Dec '14

Hi Martin, most of the patch looks okay, but I think there are a few things you should (or could) change. For patch 3/4: * I would split it up in several patches, and after adding the minimally necessary functions always combine the implementation with the corresponding tests. The huge number of functions in a single patch makes it difficult to review. * Include files should also be added as a separate patch. At the moment the formatting looks a bit ugly (random number of linebreaks?). I would also suggest to rename the function arguments to make sure they don't look exactly like MSDN. * Rename function arguments in the implementation itself, to avoid that they look identical to MSDN. * Internal helper functions (like alloc_string) do not necessarily need to return a HRESULT return value, when there are only two possible results. I would suggest using BOOL instead. * In the specfile use 'wstr' for arguments which are widechar strings. This allows to print them with the +relay debug channel. * Not sure how strict Wine is about the coding style, but generally a slighly different style is preferred for new code. Instead of --- snip --- if (...) { .... } --- snip --- the preferred version is --- snip --- if (...) { ... } --- snip --- The same applies also for for and do-while loops. Moreover cast operations like "(HSTRING)string" should usually have no space inbetween of the type and variable name. For patch 4/4: * C++-Style comments like "// ..." are not allowed in Wine source, instead use "/* ... */" for single-line comments or --- snip --- /* ... * ... */ --- snip --- for multi-line comments. * To avoid crashes on machines where this library is not available, it is recommended to skip the tests in such a case. For example: --- snip --- hmod = LoadLibraryA(...); if (!hmod) { win_skip("Failed to load api-ms-win-core-winrt-string-l1-1-0, skipping tests\n"); return; } --- snip --- * It is okay to use define macros for loading function pointers, but they should be defined directly before, and undefined immediately afterwards, to avoid collision with other definitions. I also don't think that checking for != NULL is really necessary, these api-* dlls have a well-defined set of export functions, so it is basically guaranteed that all functions are available. * check_string should also show the line number because it is used very often. The general way to do that is: --- snip --- #define check_string(str, length, has_null) _check_string(__LINE__, str, length, has_null) static void check_string(int line, HSTRING str, UINT32 length, BOOL has_null) { ... ok_(__FILE__, line)(condition, ...); ... } --- snip --- This allows to determine much easier where something goes wrong. * I would also suggest to split the tests. There is no need to put everything in a single function, especially because api-*-string only implements string functions. ;) I would prefer something like: --- snip --- START_TEST(...) { if (!init_functions()) return; test_CreateString(); test_DuplicateString(); ... } --- snip --- (Of course this doesn't mean that WindowsCreateString can only be used in one function.) Regards, Sebastian

2 4

Re: [PATCH 4/4] api-ms-win-core-winrt-string-l1-1-0: Add tests.
by Marvin 07 Dec '14

07 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10659 Your paranoid android. === build (build) === Can't determine base name

1 0

Re: [PATCH 15/15] api-ms-win-core-winrt-string: Implement a few HSTRING functions.
by Sebastian Lackner 06 Dec '14

06 Dec '14

On 01.12.2014 11:27, Martin Storsjo wrote: > + > + buf = malloc(sizeof(*buf)); > + if (!buf) > + return E_OUTOFMEMORY; > + buf->buffer = malloc((length + 1) * sizeof(*buf->buffer)); > + if (!buf->buffer) { > + free(buf); > + return E_OUTOFMEMORY; > + } Some of your previous patches also contain changes to ./configure which is an autogenerated file. Afaik its not allowed to include that when submitting patches. Feedback for this part: * HSTRING and HSTRING_HEADER should probably be defined in some include fine. To ensure that the size of private structure matches you could also use C_ASSERT(...), and maybe even disable align of the structure fields. * You should avoid using malloc(...) in Wine source * http://msdn.microsoft.com/en-us/library/br224632(v=vs.85).aspx mentions: """Calling WindowsDeleteString decrements the reference count of the backing buffer, and if the reference count reaches 0, the Windows Runtime de-allocates the buffer.""" I don't see the concept of refcounted backing buffers anywhere in your code, which is most likely wrong. Its difficult to fix that later. * I would suggest starting with some stub functions, and then add tests before sending the actual implementation. BTW: Michael Müller was also working on some api-ms-win-core-* stubs, but I think he is also fine when your patches get upstream instead: https://github.com/wine-compholio/wine-staging/tree/master/patches/api-ms-w… Regards, Sebastian

3 9

Please help spread the word about the Software Freedom Conservancy
by Jeremy White 05 Dec '14

05 Dec '14

Folks, Tony at the Conservancy reached out to us to ask our help in spreading the word about Conservancy. The Conservancy is our sponsoring organization, and they have been a great friend to Wine through the years. As they requested, I'm sending an email blast to our mailing list to spread the word. I'd ask you to scan their email and if you can help them in any of the ways they ask, please help them. They're good people, and good for Wine. Thanks, Jeremy -------- Forwarded Message -------- Subject: Conservancy projects: help us launch the Official Conservancy Supporter program! Date: Wed, 03 Dec 2014 17:17:47 -0500 From: Tony Sebro Hi, all: We at Conservancy are committed to doing whatever we can to support our member projects, and to help you produce great, freely-licensed software for the public's benefit. At this time, we could use the support of you, our member projects, as well. Today, Conservancy launched the official Conservancy Supporter program (http://sfconservancy.org/supporter/). This is our first campaign to build awareness about Conservancy, and our first attempt to really engage the public in a fundraising campaign. While we're glad to help you organize project-specific revenue-generating activities (e.g., project fundraisers, conferences, etc.), we've kept the percentage of revenue we receive from member projects under our FSA so low that it doesn't even pay for a single Conservancy staff member. So, we need our member projects' help to get the word out about who we are, what we do, and how friends of free and open source software can become Conservancy Supporters. Conservancy Supporters will receive: - an "Official Conservancy Supporter" badge for display on their personal websites; - a printable "Official Conservancy Supporter" card; and - a snazzy Conservancy T-Shirt. _ Ways__you can help spread the word_: - Follow @Conservancy on Twitter and/or Identi.ca - Tweet/Dent/Microblog about the Conservancy Supporter program on your social media platform of choice, with a link to the campaign page (please use the #ConservancySupporter hashtag) - If your project has an official social media account, please use that to microblog as well - Send email blasts to your project's mailing lists - Write a blog post or a testimonial about Conservancy (we'd really appreciate it) We thank you in advance for your support -- especially during this giving time of the year! Best, -Tony

1 0

Re: ws2_32/tests: Add SO_BSP_STATE tests
by Marvin 05 Dec '14

05 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10633 Your paranoid android. === wxppro (32 bit sock) === sock.c:610: Test failed: oob_server (190): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 9/9] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc.
by Marvin 05 Dec '14

05 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10625 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 8/9] wined3d: Filter messages generated by focus handling.
by Marvin 05 Dec '14

05 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10623 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 5/9] d3d8/tests: Test WM_SYSCOMMAND handling.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10620 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 3/9] d3d8/tests: Test focus loss message filtering.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10618 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2524: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2529: Test failed: The focus window is active. device.c:2537: Test failed: Got unexpected hr 0x88760869. device.c:2543: Test failed: Got unexpect screen size 800x600. device.c:2558: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2567: Test failed: Got unexpect screen size 800x600. device.c:2580: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2587: Test failed: Got unexpect width 640. device.c:2588: Test failed: Got unexpect height 480.

1 0

Re: ntdll: Adds support for custom serial port baudrates on Mac
by Nikolay Sivov 04 Dec '14

04 Dec '14

On 11/29/2014 07:53 PM, Nathan Fearnley wrote: > Mac OS X supports a special function call for custom baud rates. I have > implemented this feature to allow non-standard baud rates. > Unfortunately, setting any other parameters using tcsetattr will fail, > because it does not support the higher baud rates. In order to work > around this, when setting other parameters, the baud rate is temporarily > set to 9600, then reset back to custom rate after the changes are complete. > > I can't comment on functional part, but regarding code structure this should be better separated imho. Maybe it's even better to duplicate whole functions and ifdef them all in case when __APPLE__ is not defined. Also don't use C++ 'bool', use BOOL with TRUE/FALSE defines.

2 1

Re: [PATCH] winealsa: do not destroy remapping info on IsFormatSupported
by Andrew Eikum 04 Dec '14

04 Dec '14

Good catch. I don't like the copying, though. What about making: struct alsa_channel_map { int alsa_channels; int map[32]; }; and passing that into map_channels()? need_remapping can be indicated by a S_FALSE vs S_OK return from map_channels(), or maybe set outside the call in _Initialize(). What do you think? Andrew On Thu, Dec 04, 2014 at 02:26:05PM +0000, Mark Harmstone wrote: > At present, AudioClient_IsFormatSupported nukes the remapping information > if called after AudioClient_Initialize. > > --- > dlls/winealsa.drv/mmdevdrv.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 007f351..3d14a53 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -1598,6 +1598,8 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > WAVEFORMATEX *closest = NULL; > unsigned int max = 0, min = 0; > int err; > + int alsa_channels_orig, alsa_channel_map_orig[32]; > + BOOL need_remapping_orig; > > TRACE("(%p)->(%x, %p, %p)\n", This, mode, fmt, out); > > @@ -1692,9 +1694,18 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > closest->nChannels = min; > } > > + need_remapping_orig = This->need_remapping; > + alsa_channels_orig = This->alsa_channels; > + memcpy(alsa_channel_map_orig, This->alsa_channel_map, sizeof(This->alsa_channel_map)); > + > if(FAILED(map_channels(This, fmt))){ > hr = AUDCLNT_E_DEVICE_INVALIDATED; > WARN("map_channels failed\n"); > + > + This->need_remapping = need_remapping_orig; > + This->alsa_channels = alsa_channels_orig; > + memcpy(This->alsa_channel_map, alsa_channel_map_orig, sizeof(This->alsa_channel_map)); > + > goto exit; > } > if(This->alsa_channels > max){ > @@ -1702,6 +1713,10 @@ static HRESULT WINAPI AudioClient_IsFormatSupported(IAudioClient *iface, > closest->nChannels = max; > } > > + This->need_remapping = need_remapping_orig; > + This->alsa_channels = alsa_channels_orig; > + memcpy(This->alsa_channel_map, alsa_channel_map_orig, sizeof(This->alsa_channel_map)); > + > if(closest->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > ((WAVEFORMATEXTENSIBLE*)closest)->dwChannelMask = get_channel_mask(closest->nChannels); > > >

1 0

Re: [PATCH 6/8] ddraw/tests: Test WM_SYSCOMMAND handling.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10606 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:3814: Test failed: Expected WM_ACTIVATEAPP, but did not receive it. === w8 (32 bit ddraw4) === ddraw4.c:4169: Test failed: Expected WM_ACTIVATEAPP, but did not receive it.

2 1

Re: [PATCH 8/8] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10609 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 7/8] wined3d: Filter messages generated by focus handling.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10607 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: ole32: fixed CoWaitForMultipleHandles cause app hang
by Changhui Liu 04 Dec '14

04 Dec '14

Hi, it's not your recent fix cause. The app is named QQ, a very popular IM client in China. When it runs, it create two process named QQ.exe and TXPlatform.exe. The TXPlatform.exe is an out-of-process COM server, The QQ.exe is the GUI process. When the user click the exit button of the QQ.exe, the QQ.exe and TXPlatform.exe both hang. The backtrace of the GUI thread of QQ.exe is like this: =>0 0xf779d42e __kernel_vsyscall+0xe() in [vdso].so (0x0033e938) 1 0xf7598e1b __libc_read+0x4a() in libpthread.so.0 (0x0033e938) 2 0x7ef8ec9a wait_select_reply+0x30(cookie=0x33e968) 3 0x7ef8fac6 server_select+0x20c(select_op=0x33ea8c, size=0x8, flags=0x2, timeout=(nil)) 4 0x7ef998e7 NtWaitForMultipleObjects+0xbc(count=0x1, handles=0x33ebe0, wait_any=1, alertable=0, timeout=(nil)) 5 0x7ecbcd31 WaitForMultipleObjectsEx+0x191 in kernel32 (0x0033ecf8) 6 0x7e13c224 CoWaitForMultipleHandles+0x4e2 in ole32 (0x0033edf8) 7 0x7e1775b8 ClientRpcChannelBuffer_SendReceive+0x598 in ole32 (0x0033eef8) ... And the backtrace of another thread of QQ.exe is like this: Backtracing for thread 0080 in process 003c (C:\Program Files\Tencent\QQ\Bin\QQ.exe): Backtrace: =>0 0xf779d42e __kernel_vsyscall+0xe() in [vdso].so (0x020ce2a8) 1 0xf7598e1b __libc_read+0x4a() in libpthread.so.0 (0x020ce2a8) 2 0x7ef8ec9a wait_select_reply+0x30(cookie=0x20ce2d8) 3 0x7ef8fac6 server_select+0x20c(select_op=0x20ce3fc, size=0x8, flags=0x2, timeout=(nil)) 4 0x7ef998e7 NtWaitForMultipleObjects+0xbc(count=0x1, handles=0x20ce550, wait_any=1, alertable=0, timeout=(nil)) 5 0x7ecbcd31 WaitForMultipleObjectsEx+0x191 6 0x7ecbcae7 WaitForSingleObject+0x45 7 0x7e179258 dispatch_rpc+0x350(msg=0x3f24668) in ole32 (0x020ce788) 8 0x7e0c10fa process_request_packet+0x3b8(conn=0x158370, hdr=0x55a12e8, msg=0x3f24668) in rpcrt4 (0x020ce8c8) 9 0x7e0c15c6 RPCRT4_process_packet+0x114(conn=0x158370, hdr=0x55a12e8, msg=0x3f24668, auth_data=0x0(nil), auth_length=0) in rpcrt4 (0x020ce928) 10 0x7e0c1759 RPCRT4_worker_thread+0x4e( in rpcrt4 (0x020ce978) ... The dispatch_rpc thread has post a 0x400 RPC message to the GUI thread and is waiting for GUI thread to process the RPC request. But the GUI thread has received WM_QUIT message, the message_loop variable set to FALSE and it only wait for event signal, so the 0x400 RPC message can't be handled. The TXPlatform.exe hang because it is waiting for dispatch_rpc thread send RPC result to a named pipe. Because the hang is too complex , I don't know how to add a test for it. ------------------ Original ------------------ From: "Sebastian Lackner"<sebastian(a)fds-team.de>; Date: Wed, Dec 3, 2014 06:42 PM To: "liuchanghui"<liuchanghui(a)linuxdeepin.com>; Cc: "wine-devel"<wine-devel(a)winehq.org>; Subject: Re: ole32: fixed CoWaitForMultipleHandles cause app hang On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

1 0

Re: [PATCH 5/8] d3d8/tests: Test WM_SYSCOMMAND handling.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10605 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 3/8] d3d8/tests: Test focus loss message filtering.
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10603 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2524: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2529: Test failed: The focus window is active. device.c:2537: Test failed: Got unexpected hr 0x88760869. device.c:2543: Test failed: Got unexpect screen size 800x600. device.c:2558: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2567: Test failed: Got unexpect screen size 800x600. device.c:2580: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2587: Test failed: Got unexpect width 640. device.c:2588: Test failed: Got unexpect height 480.

1 0

Re: urlmon/tests: Remove unused strings (Clang)
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10595 Your paranoid android. === w2008s64 (32 bit url) === url.c:1478: Test failed: progress 2: hres = 1, expected 0 url.c:1668: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1478: Test failed: progress 1: hres = 1, expected 0 url.c:1680: Test failed: unexpected call OnProgress_CONNECTING url.c:1478: Test failed: progress 2: hres = 1, expected 0 url.c:1701: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: user32/tests: Remove unused variables (Clang)
by Marvin 04 Dec '14

04 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10592 Your paranoid android. === w7u (32 bit msg) === msg.c:12105: Test failed: unexpected hwnd 0012013C msg.c:12127: Test failed: bad time 310a2/310b2

1 0

Re: user32/tests: Remove unused variables (Clang)
by André Hentschel 03 Dec '14

03 Dec '14

Am 03.12.2014 um 23:53 schrieb André Hentschel: > --- > dlls/user32/tests/msg.c | 112 ------------------------------------------------ > 1 file changed, 112 deletions(-) Just want to note, that this code was added in 2003 and most likely has never been used, just in case someone wonders why i dare to remove so much code ;)

1 0

Re: [PATCH 08/15] msvcr120: Remove stray parameter specs for stub functions.
by Alexandre Julliard 03 Dec '14

03 Dec '14

Martin Storsjo <martin(a)martin.st> writes: > This avoids adding stray functions when using make_specfiles. There shouldn't be any reason to do that. The parameters are here on purpose. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong 03 Dec '14

03 Dec '14

Hi Indrek, On Mon, Dec 1, 2014 at 3:46 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote: > Hello > > I even saw your patch in my inbox but it does not appear at > https://source.winehq.org/patches/data/107949 for some reason, so I don't > remember what lines you changed exactly so apologies if I seem to be > re-stating things tou fixed already. > > > When checking > http://source.winehq.org/git/wine.git/blob_plain/HEAD:/loader/wine.inf.in > there is also tons of other discrepancies (if you didn't already). > > > Parameters are escaped with ""%1"" but not command: > HKCR,Msi.Package\shell\Open\command,,2,"%11%\msiexec.exe /i ""%1""" > HKCR,Msi.Package\shell\Repair\command,,2,"%11%\msiexec.exe /f ""%1""" > HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1""" > > > Command itself is escaped: > HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > > > Neither command nor parameter is escaped: > HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > > HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe > setupapi,InstallHinfSection DefaultInstall 132 %1" > > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > > > If winebrowser needs escaping because %11 contains a space then all other > places also use %11 need that escaping. And if msiexec need to escape %1 > then all other places need it too don't they? > Thanks a lot for your comment, I'm investigating a bit more... Will update later :) -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH 01/15] msvcr120: Implement the _vacopy function.
by Martin Storsjö 03 Dec '14

03 Dec '14

Hi, On Mon, 1 Dec 2014, Martin Storsjo wrote: > --- > dlls/msvcr120/msvcr120.spec | 2 +- > dlls/msvcrt/misc.c | 8 ++++++++ > include/msvcrt/crtdefs.h | 2 ++ > 3 files changed, 11 insertions(+), 1 deletion(-) I saw on http://source.winehq.org/patches/ that this one was rejected - any comment on why and what needs to be fixed? // Martin

2 1

Re: [PATCH 02/15] msvcr120: Implement more C99 math functions.
by Alexandre Julliard 03 Dec '14

03 Dec '14

Martin Storsjo <martin(a)martin.st> writes: > Implement the *rint, trunc, *round, log2, exp2 and cbrt > function families. > > These are directly passed on to the corresponding host > libc functions. You can't do that, there's no guarantee that the host has these functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ole32: fixed CoWaitForMultipleHandles cause app hang
by Sebastian Lackner 03 Dec '14

03 Dec '14

On 03.12.2014 08:15, Changhui Liu wrote: > > > Do I understand you correctly that this is caused by my recent fix of CoWaitForMultipleHandles? Which app is it? Your change might be correct, but to ensure that this is the case please add a test for it: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/ole32/tests/compobj.c… Moreover you should completely remove old code then, not just comment it out. Regards, Sebastian

1 0

Re: msi: Properly handle service control events in Start/StopService.
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10574 Your paranoid android. === wxppro (32 bit action) === The test timed out === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

1 0

Re: ole32/tests: Remove unused variable (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10569 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 00427679 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000421BDA

1 0

Re: msi/tests: Remove unused variables (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10567 Your paranoid android. === wxppro (32 bit install) === The test timed out === w7u (32 bit install) === The test timed out === w8 (32 bit install) === The test timed out

1 0

Re: mshtml/tests: Remove unused variable (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10565 Your paranoid android. === w2000pro (32 bit events) === The test timed out

1 0

Re: kernel32/tests: Remove unused strings (Clang)
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10564 Your paranoid android. === wvistau64 (32 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:365: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH 2/3] d3d8: Refuse to reset a lost device (v2).
by Marvin 02 Dec '14

02 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10563 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/5] d3d9: Refuse to reset a lost device.
by Henri Verbeet 01 Dec '14

01 Dec '14

On 28 November 2014 at 11:16, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!device->d3d_parent->extended && InterlockedCompareExchange(&device->device_state, > + D3D9_DEVICE_STATE_LOST, D3D9_DEVICE_STATE_LOST) == D3D9_DEVICE_STATE_LOST) Do you need the InterlockedCompareExchange()?

2 3

Re: mshtml: Added support for flag 2 in getAttribute.
by Marvin 01 Dec '14

01 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10556 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.
by Qian Hong 01 Dec '14

01 Dec '14

Hi, `git grep command | grep HKCR | grep -v '"""'` exposed more places which seems missing quotes in command key, anyone know if we should update every place? Any advice is great appreciated! loader/wine.inf.in:HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" loader/wine.inf.in:HKCR,cplfile\shell\cplopen\command,,2,"rundll32.exe shell32.dll,Control_RunDLL ""%1"",%*" loader/wine.inf.in:HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" loader/wine.inf.in:HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe setupapi,InstallHinfSection DefaultInstall 132 %1" loader/wine.inf.in:HKCR,inifile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,inifile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1" loader/wine.inf.in:HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" loader/wine.inf.in:HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" loader/wine.inf.in:HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" loader/wine.inf.in:HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" On Mon, Dec 1, 2014 at 1:38 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hi Piotr, > > This is a follow up of the below commit: > > commit 54833c9b7cf5f8f5e37b43038e1fa4c1c369deb0 > Author: Piotr Caban <piotr(a)codeweavers.com> > Date: Wed May 4 13:20:41 2011 +0200 > > wine.inf: Add quotes to webbrowser command keys. > > To make sure i'm not breaking anything which is intended, would you mind > have a look? > > Thanks! > > --- > loader/wine.inf.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [PATCH] ntoskrnl.exe: IoBuildSynchronousFsdRequest and IoGetAttachedDevice stub
by Austin English 30 Nov '14

30 Nov '14

On Sun, Nov 30, 2014 at 3:51 AM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > > Some work I have left lying around after trying to get a copy protection > to work. > > (Stopped at how to get IoGetAttachedDevice deliver the cdrom device > created by mountmgr.sys > which lives in a different address space.) > > Ciao, Marcus > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 51 > ++++++++++++++++++++++++++++++++++++- > dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 4 +-- > 2 files changed, 52 insertions(+), 3 deletions(-) > > @@ -733,9 +770,21 @@ NTSTATUS WINAPI IoGetDeviceObjectPointer( > UNICODE_STRING *name, ACCESS_MASK acc > { > FIXME( "stub: %s %x %p %p\n", debugstr_us(name), access, file, device > ); > > - return STATUS_NOT_IMPLEMENTED; > + *file = NULL; > + *device = NULL; > + > + return /*STATUS_NOT_IMPLEMENTED*/STATUS_SUCCESS; > Looks like a debugging leftover you forgot to remove.

1 0

Re: [PATCH 1/4] wined3d: Vertex fog uses the absolute eye position z (v3).
by Joachim Priesner 30 Nov '14

30 Nov '14

Am Donnerstag, 27. November 2014 schrieb Stefan Dösinger: > This is written from scratch, but inspired by the patch from Joachim > Priesner. The included test tests the absolute minimum necessary to show > that the abs() needs to be placed in the fixed function vertex pipeline > replacement shader. It ignores vertex and pixel shader behavior. Does this mean I can finally stop worrying about my version of the bug fix and concentrate on getting my other two pending patch sets in? If so, I'd very much like feedback on 107283 Pending Joachim Priesner ws2_32: WS_get_local_ips: Fix ordering of IP addresses by metric if two addresses have the same metric (try 2) which seems pretty straightforward and fixes a real bug, and also on [PATCH 3/3] comctl32: Implement the TaskDialog function (try 2) [PATCH 2/3] comctl32: Basic implementation of TaskDialogIndirect (try 2) [PATCH 1/3] comctl32: Move TaskDialogIndirect function to separate file (try 2) which I submitted almost two months ago, but which, after one round of feedback, vanished from the patches list without further comment. What can I do to make these patches better? Add tests? Split into smaller files? Give up altogether? NB, both patch sets fix issues with applications I work with -- does creating a bug report increase the chances of the patches getting looked at? Thanks for any help. Joachim

2 3

Re: ole32/tests: Remove unused argument from expect() helper.
by Marvin 28 Nov '14

28 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10520 Your paranoid android. === w2000pro (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wxppro (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wvistau64 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w2008s64 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w7u (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w8 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wvistau64 (64 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w2008s64 (64 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008

1 0

Re: ole32/tests: Simplify ok() check (PVS-Studio)
by Marvin 28 Nov '14

28 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10519 Your paranoid android. === w2000pro (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wxppro (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wvistau64 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w2008s64 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w7u (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w8 (32 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === wvistau64 (64 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008 === w2008s64 (64 bit propvariant) === propvariant.c:161: Test failed: VT_EMPTY (array): got 80020008 propvariant.c:161: Test failed: VT_EMPTY (byref): got 80020008 propvariant.c:161: Test failed: VT_NULL (array): got 80020008 propvariant.c:161: Test failed: VT_NULL (byref): got 80020008 propvariant.c:161: Test failed: VT_DISPATCH (vector): got 80020008 propvariant.c:161: Test failed: VT_UNKNOWN (vector): got 80020008 propvariant.c:161: Test failed: VT_DECIMAL (vector): got 80020008 propvariant.c:161: Test failed: 15 (simple): got 80020008 propvariant.c:161: Test failed: 15 (array): got 80020008 propvariant.c:161: Test failed: 15 (vector): got 80020008 propvariant.c:161: Test failed: 15 (byref): got 80020008 propvariant.c:161: Test failed: VT_INT (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (simple): got 80020008 propvariant.c:161: Test failed: VT_VOID (array): got 80020008 propvariant.c:161: Test failed: VT_VOID (vector): got 80020008 propvariant.c:161: Test failed: VT_VOID (byref): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (simple): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (array): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (vector): got 80020008 propvariant.c:161: Test failed: VT_HRESULT (byref): got 80020008 propvariant.c:161: Test failed: VT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_SAFEARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (simple): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (array): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (vector): got 80020008 propvariant.c:161: Test failed: VT_CARRAY (byref): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (simple): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (array): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (vector): got 80020008 propvariant.c:161: Test failed: VT_USERDEFINED (byref): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPSTR (byref): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (array): got 80020008 propvariant.c:161: Test failed: VT_LPWSTR (byref): got 80020008 propvariant.c:161: Test failed: 32 (simple): got 80020008 propvariant.c:161: Test failed: 32 (array): got 80020008 propvariant.c:161: Test failed: 32 (vector): got 80020008 propvariant.c:161: Test failed: 32 (byref): got 80020008 propvariant.c:161: Test failed: 33 (simple): got 80020008 propvariant.c:161: Test failed: 33 (array): got 80020008 propvariant.c:161: Test failed: 33 (vector): got 80020008 propvariant.c:161: Test failed: 33 (byref): got 80020008 propvariant.c:161: Test failed: 34 (simple): got 80020008 propvariant.c:161: Test failed: 34 (array): got 80020008 propvariant.c:161: Test failed: 34 (vector): got 80020008 propvariant.c:161: Test failed: 34 (byref): got 80020008 propvariant.c:161: Test failed: 35 (simple): got 80020008 propvariant.c:161: Test failed: 35 (array): got 80020008 propvariant.c:161: Test failed: 35 (vector): got 80020008 propvariant.c:161: Test failed: 35 (byref): got 80020008 propvariant.c:161: Test failed: VT_RECORD (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_INT_PTR (byref): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (simple): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (array): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (vector): got 80020008 propvariant.c:161: Test failed: VT_UINT_PTR (byref): got 80020008 propvariant.c:161: Test failed: 39 (simple): got 80020008 propvariant.c:161: Test failed: 39 (array): got 80020008 propvariant.c:161: Test failed: 39 (vector): got 80020008 propvariant.c:161: Test failed: 39 (byref): got 80020008 propvariant.c:161: Test failed: 40 (simple): got 80020008 propvariant.c:161: Test failed: 40 (array): got 80020008 propvariant.c:161: Test failed: 40 (vector): got 80020008 propvariant.c:161: Test failed: 40 (byref): got 80020008 propvariant.c:161: Test failed: 41 (simple): got 80020008 propvariant.c:161: Test failed: 41 (array): got 80020008 propvariant.c:161: Test failed: 41 (vector): got 80020008 propvariant.c:161: Test failed: 41 (byref): got 80020008 propvariant.c:161: Test failed: 42 (simple): got 80020008 propvariant.c:161: Test failed: 42 (array): got 80020008 propvariant.c:161: Test failed: 42 (vector): got 80020008 propvariant.c:161: Test failed: 42 (byref): got 80020008 propvariant.c:161: Test failed: 43 (simple): got 80020008 propvariant.c:161: Test failed: 43 (array): got 80020008 propvariant.c:161: Test failed: 43 (vector): got 80020008 propvariant.c:161: Test failed: 43 (byref): got 80020008 propvariant.c:161: Test failed: 44 (simple): got 80020008 propvariant.c:161: Test failed: 44 (array): got 80020008 propvariant.c:161: Test failed: 44 (vector): got 80020008 propvariant.c:161: Test failed: 44 (byref): got 80020008 propvariant.c:161: Test failed: 45 (simple): got 80020008 propvariant.c:161: Test failed: 45 (array): got 80020008 propvariant.c:161: Test failed: 45 (vector): got 80020008 propvariant.c:161: Test failed: 45 (byref): got 80020008 propvariant.c:161: Test failed: 46 (simple): got 80020008 propvariant.c:161: Test failed: 46 (array): got 80020008 propvariant.c:161: Test failed: 46 (vector): got 80020008 propvariant.c:161: Test failed: 46 (byref): got 80020008 propvariant.c:161: Test failed: 47 (simple): got 80020008 propvariant.c:161: Test failed: 47 (array): got 80020008 propvariant.c:161: Test failed: 47 (vector): got 80020008 propvariant.c:161: Test failed: 47 (byref): got 80020008 propvariant.c:161: Test failed: 48 (simple): got 80020008 propvariant.c:161: Test failed: 48 (array): got 80020008 propvariant.c:161: Test failed: 48 (vector): got 80020008 propvariant.c:161: Test failed: 48 (byref): got 80020008 propvariant.c:161: Test failed: 49 (simple): got 80020008 propvariant.c:161: Test failed: 49 (array): got 80020008 propvariant.c:161: Test failed: 49 (vector): got 80020008 propvariant.c:161: Test failed: 49 (byref): got 80020008 propvariant.c:161: Test failed: 50 (simple): got 80020008 propvariant.c:161: Test failed: 50 (array): got 80020008 propvariant.c:161: Test failed: 50 (vector): got 80020008 propvariant.c:161: Test failed: 50 (byref): got 80020008 propvariant.c:161: Test failed: 51 (simple): got 80020008 propvariant.c:161: Test failed: 51 (array): got 80020008 propvariant.c:161: Test failed: 51 (vector): got 80020008 propvariant.c:161: Test failed: 51 (byref): got 80020008 propvariant.c:161: Test failed: 52 (simple): got 80020008 propvariant.c:161: Test failed: 52 (array): got 80020008 propvariant.c:161: Test failed: 52 (vector): got 80020008 propvariant.c:161: Test failed: 52 (byref): got 80020008 propvariant.c:161: Test failed: 53 (simple): got 80020008 propvariant.c:161: Test failed: 53 (array): got 80020008 propvariant.c:161: Test failed: 53 (vector): got 80020008 propvariant.c:161: Test failed: 53 (byref): got 80020008 propvariant.c:161: Test failed: 54 (simple): got 80020008 propvariant.c:161: Test failed: 54 (array): got 80020008 propvariant.c:161: Test failed: 54 (vector): got 80020008 propvariant.c:161: Test failed: 54 (byref): got 80020008 propvariant.c:161: Test failed: 55 (simple): got 80020008 propvariant.c:161: Test failed: 55 (array): got 80020008 propvariant.c:161: Test failed: 55 (vector): got 80020008 propvariant.c:161: Test failed: 55 (byref): got 80020008 propvariant.c:161: Test failed: 56 (simple): got 80020008 propvariant.c:161: Test failed: 56 (array): got 80020008 propvariant.c:161: Test failed: 56 (vector): got 80020008 propvariant.c:161: Test failed: 56 (byref): got 80020008 propvariant.c:161: Test failed: 57 (simple): got 80020008 propvariant.c:161: Test failed: 57 (array): got 80020008 propvariant.c:161: Test failed: 57 (vector): got 80020008 propvariant.c:161: Test failed: 57 (byref): got 80020008 propvariant.c:161: Test failed: 58 (simple): got 80020008 propvariant.c:161: Test failed: 58 (array): got 80020008 propvariant.c:161: Test failed: 58 (vector): got 80020008 propvariant.c:161: Test failed: 58 (byref): got 80020008 propvariant.c:161: Test failed: 59 (simple): got 80020008 propvariant.c:161: Test failed: 59 (array): got 80020008 propvariant.c:161: Test failed: 59 (vector): got 80020008 propvariant.c:161: Test failed: 59 (byref): got 80020008 propvariant.c:161: Test failed: 60 (simple): got 80020008 propvariant.c:161: Test failed: 60 (array): got 80020008 propvariant.c:161: Test failed: 60 (vector): got 80020008 propvariant.c:161: Test failed: 60 (byref): got 80020008 propvariant.c:161: Test failed: 61 (simple): got 80020008 propvariant.c:161: Test failed: 61 (array): got 80020008 propvariant.c:161: Test failed: 61 (vector): got 80020008 propvariant.c:161: Test failed: 61 (byref): got 80020008 propvariant.c:161: Test failed: 62 (simple): got 80020008 propvariant.c:161: Test failed: 62 (array): got 80020008 propvariant.c:161: Test failed: 62 (vector): got 80020008 propvariant.c:161: Test failed: 62 (byref): got 80020008 propvariant.c:161: Test failed: 63 (simple): got 80020008 propvariant.c:161: Test failed: 63 (array): got 80020008 propvariant.c:161: Test failed: 63 (vector): got 80020008 propvariant.c:161: Test failed: 63 (byref): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (array): got 80020008 propvariant.c:161: Test failed: VT_FILETIME (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAM (array): got 80020008 propvariant.c:161: Test failed: VT_STREAM (byref): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (array): got 80020008 propvariant.c:161: Test failed: VT_STORAGE (byref): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STREAMED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_STORED_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (array): got 80020008 propvariant.c:161: Test failed: VT_BLOB_OBJECT (byref): got 80020008 propvariant.c:161: Test failed: VT_CF (array): got 80020008 propvariant.c:161: Test failed: VT_CF (byref): got 80020008

1 0

Re: [PATCH 2/5] d3d8: Refuse to reset a lost device.
by Marvin 28 Nov '14

28 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10517 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/5] wined3d: Vertex fog uses the absolute eye position z (v2).
by Henri Verbeet 28 Nov '14

28 Nov '14

On 26 November 2014 at 19:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + conv.f = tests[i].start; > + hr = IDirect3DDevice8_SetRenderState(device, D3DRS_FOGSTART, conv.d); I don't care particularly much, but it might be nicer to just add the union to tests[], and then just use "tests[i].start.d" here. > START_TEST(ddraw7) > { > HMODULE module = GetModuleHandleA("ddraw.dll"); > @@ -8089,4 +8190,5 @@ START_TEST(ddraw7) > test_resource_priority(); > test_surface_desc_lock(); > fog_interpolation_test(); > + test_negative_fixedfunction_fog(); I prefer this name, but I think it's more important that equivalent tests have the same name between D3D versions. I'd probably just rename the d3d8 and d3d9 versions instead. For what it's worth, I still plan to merge device.c and visual.c at some point in the future, and I'll probably fixup the naming of the existing tests in visual.c around that time as well. > if (settings->ortho_fog) > + { > /* Need to undo the [0.0 - 1.0] -> [-1.0 - 1.0] transformation from D3D to GL coordinates. */ > shader_addline(buffer, "gl_FogFragCoord = gl_Position.z * 0.5 + 0.5;\n"); > + } > else > + { > shader_addline(buffer, "gl_FogFragCoord = ec_pos.z;\n"); > + if (!settings->transformed) > + shader_addline(buffer, "gl_FogFragCoord = abs(gl_FogFragCoord);\n"); > + } I think this looks pretty messy. I'd suggest if (settings->ortho_fog) shader_addline(...); else if (!settings->transformed) shader_addline(...); else shader_addline(...);

2 3

Re: winetest: Skip over stub dll if detected
by Stefan Dösinger 27 Nov '14

27 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-27 04:11, schrieb Alistair Leslie-Hughes: > Hi, > > Changelog: > winetest: Skip over stub dll if detected Does LoadLibrary(LOAD_LIBRARY_AS_DATAFILE) avoid triggering the "do you want to install dplay?" message box? (I guess because DllMain is not called) > + LPSTR data = HeapAlloc(GetProcessHeap(), 0, size); > ... > + if (VerQueryValueA(data, buf, (LPVOID*)&p, &size)) LPJUNK. (Use void ** for LPVOID *) > + sprintf(buf, "\\StringFileInfo\\%04x%04x\\OriginalFilename", MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), 1200); I'll test this on my non-english Windows and see if this works as intended. > + * Windows 8 has a concept of stub DLL's. When DLLMain is called the user is prompted > + * to install that component. To bypass this check we need to look at the version resource. A matter of opinion according to Wikipedia, feel free to ignore me: "DLLs" would be better as the plural of "DLL". "DLL's" looks like the possessive, although http://en.wikipedia.org/wiki/English_plurals#Plurals_of_letters_and_abbrevi… says that using 's to form the plural of an abbreviation is legitimate. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUdu6IAAoJEN0/YqbEcdMwmZQP/i9yruybSkmeAtFnaAu6SPG9 r73Q/028i2u/mOqaxrc90L/uzM1+sOU7Y9hctp0obQJ1RjpNJqhtqV5UnyFrdWIP 2B6LsrOjk99pxUXDEsLX8r5cSnQqdXqpqey600WQDJwFp/hrnIC3QF3MPheIqkJh I7OUptt6QPTQpdJmab4rh7Bt+/hEVwol4wNF3UW6S4cYvdh6L5UtEW5OK4+qelWC 8ztulOrGkvlJfwV3ax3fKfu/7UpROyBi6yVKTuuprCxvKCHpr41Vxl+JWmBef16v VHZYJ0Jo9OrW48PGTp0mnL9tP/BVIrwcc8lJLIyvYqc3T2FoVXqQBAo/X3RUYQGF mlVdThstHTSQDldSJfwYhZETxPsjRS9hud3DWNjj5YzLPnw9kpKL+cOVDIze3GXV 9xikER+GQMPRjsh5EK1Z5Jtwn3i0V8XF5aDJBLJT8zXE8EOYjFCwl6YOPSgXRF0P FDzPfkex7NJaefjJ5tQmJw8MFYwP5HU+nBTlwwzoiAtca6+zfn/aULlmFJcDU9Zq gjnY7eUIngRqnPPVBbYz+5B7+YMwjoN7NvTtQ/C4uuufvulYa9gvuakg15HZKVE8 GIwISlj8SSbmoSNMRgfoADBiCurDNlh3rMTeuWKMNREAX+x0EsoOBVgHZ3qS+vqP ZixdoJfhP2OPm1LMWiUN =0DlV -----END PGP SIGNATURE-----

3 2

Re: [1/3] wined3d: Add a new enum for GL_EXT_geometry_shader4
by Henri Verbeet 27 Nov '14

27 Nov '14

On 22 November 2014 at 00:16, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > --- I don't think we want this. We're never going to use EXT_geometry_shader4, and in fact are likely to drop ARB_geometry_shader4 in favour of just using core contexts. We should just do the work to make core contexts work. Matteo has some initial patches if you'd like to help out with that.

3 4

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate (v2).
by Henri Verbeet 27 Nov '14

27 Nov '14

On 26 November 2014 at 19:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Needed to make AMD drivers happy. Yeah, it is not supposed to > + * have an effect on RHW draws. */ > + static const D3DMATRIX identity = > + {{{ > + 1.0f, 0.0f, 0.0f, 0.0f, > + 0.0f, 1.0f, 0.0f, 0.0f, > + 0.0f, 0.0f, 1.0f, 0.0f, > + 0.0f, 0.0f, 0.0f, 1.0f > + }}}; Is this the same projection matrix issue as in fog_test()/fog_with_shader_tests()/etc.?

2 2

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex
by Marvin 27 Nov '14

27 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10489 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex
by Nikolay Sivov 27 Nov '14

27 Nov '14

On 27.11.2014 8:11, Alistair Leslie-Hughes wrote: > + if(dwComponentID > list_count(&This->components)) > + return DPNERR_DOESNOTEXIST; > + > + LIST_FOR_EACH_ENTRY(entry, &This->components, struct component, entry) > + { > + if(count == dwComponentID) This means you really want to use array instead of a list. This will speed up GetNumComponents() and GetComponentByIndex(), while GetComponentByName() will still need to iterate.

1 0

Re: [PATCH 5/5] d3d8/tests: Call TestCooperativeLevel after Present.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10483 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Wine web down?
by Bruno Jesus 26 Nov '14

26 Nov '14

It's been around 2 hours that I cannot access the web site, source, bugzilla or appdb. Only wiki stands on (AFAIR it's in a different server). Not even ping works. Is this a known maintenance operation? Bruno

2 1

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path (try 3)
by Andrew Eikum 26 Nov '14

26 Nov '14

These two patches look OK to me. Andrew On Wed, Nov 19, 2014 at 07:07:57PM +0000, Mark Harmstone wrote: > --- > dlls/winealsa.drv/mmdevdrv.c | 114 ++++++++++++++++++++++++++++++++++++ > dlls/winealsa.drv/winealsa.drv.spec | 1 + > 2 files changed, 115 insertions(+) > > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 5ad72f9..6b1456e 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -3823,3 +3823,117 @@ HRESULT WINAPI AUDDRV_GetAudioSessionManager(IMMDevice *device, > > return S_OK; > } > + > +enum AudioDeviceConnectionType { > + AudioDeviceConnectionType_Unknown = 0, > + AudioDeviceConnectionType_PCI, > + AudioDeviceConnectionType_USB > +}; > + > +HRESULT WINAPI AUDDRV_GetPropValue(GUID *guid, const PROPERTYKEY *prop, PROPVARIANT *out) > +{ > + static const PROPERTYKEY devicepath_key = { /* undocumented? - {b3f8fa53-0004-438e-9003-51a46e139bfc},2 */ > + {0xb3f8fa53, 0x0004, 0x438e, {0x90, 0x03, 0x51, 0xa4, 0x6e, 0x13, 0x9b, 0xfc}}, 2 > + }; > + > + TRACE("%s, (%s,%u), %p\n", wine_dbgstr_guid(guid), wine_dbgstr_guid(&prop->fmtid), prop->pid, out); > + > + if(IsEqualPropertyKey(*prop, devicepath_key)) > + { > + char name[256], uevent[MAX_PATH]; > + EDataFlow flow; > + FILE *fuevent; > + int card, device; > + > + if(!get_alsa_name_by_guid(guid, name, sizeof(name), &flow)) > + { > + WARN("Unknown interface %s\n", debugstr_guid(guid)); > + return E_NOINTERFACE; > + } > + > + /* only implemented for identifiable devices, i.e. not "default" */ > + if(!sscanf(name, "plughw:%u,%u", &card, &device)) > + return E_NOTIMPL; > + > + sprintf(uevent, "/sys/class/sound/card%u/device/uevent", card); > + fuevent = fopen(uevent, "r"); > + > + if(fuevent){ > + enum AudioDeviceConnectionType connection = AudioDeviceConnectionType_Unknown; > + USHORT vendor_id = 0, product_id = 0; > + char *line = NULL; > + > + while(!feof(fuevent)) { > + char *val; > + size_t val_len, len = 0; > + > + if(getline(&line, &len, fuevent)<0) > + break; > + > + if((val = strchr(line, '='))) { > + val[0] = 0; > + val++; > + > + val_len = strlen(val); > + if(val_len > 0 && val[val_len - 1] == '\n') { val[val_len - 1] = 0; } > + > + if(!strcmp(line, "PCI_ID")){ > + connection = AudioDeviceConnectionType_PCI; > + if(sscanf(val, "%hX:%hX", &vendor_id, &product_id)<2){ > + WARN("Unexpected input when reading PCI_ID in uevent file.\n"); > + connection = AudioDeviceConnectionType_Unknown; > + break; > + } > + }else if(!strcmp(line, "DEVTYPE") && !strcmp(val,"usb_interface")) > + connection = AudioDeviceConnectionType_USB; > + else if(!strcmp(line, "PRODUCT")) > + if(sscanf(val, "%hx/%hx/", &vendor_id, &product_id)<2){ > + WARN("Unexpected input when reading PRODUCT in uevent file.\n"); > + connection = AudioDeviceConnectionType_Unknown; > + break; > + } > + } > + } > + > + if(line) > + free(line); > + > + fclose(fuevent); > + > + if(connection == AudioDeviceConnectionType_USB || connection == AudioDeviceConnectionType_PCI){ > + static const WCHAR usbformatW[] = { '{','1','}','.','U','S','B','\\','V','I','D','_', > + '%','0','4','X','&','P','I','D','_','%','0','4','X','\\', > + '%','u','&','%','0','8','X',0 }; /* "{1}.USB\VID_%04X&PID_%04X\%u&%08X" */ > + static const WCHAR pciformatW[] = { '{','1','}','.','H','D','A','U','D','I','O','\\','F','U','N','C','_','0','1','&', > + 'V','E','N','_','%','0','4','X','&','D','E','V','_', > + '%','0','4','X','\\','%','u','&','%','0','8','X',0 }; /* "{1}.HDAUDIO\FUNC_01&VEN_%04X&DEV_%04X\%u&%08X" */ > + UINT serial_number; > + > + /* As hardly any audio devices have serial numbers, Windows instead > + appears to use a persistent random number. We emulate this here > + by instead using the last 8 hex digits of the GUID. */ > + serial_number = (guid->Data4[4] << 24) | (guid->Data4[5] << 16) | (guid->Data4[6] << 8) | guid->Data4[7]; > + > + out->vt = VT_LPWSTR; > + out->u.pwszVal = CoTaskMemAlloc(128 * sizeof(WCHAR)); > + > + if(!out->u.pwszVal) > + return E_OUTOFMEMORY; > + > + if(connection == AudioDeviceConnectionType_USB) > + sprintfW( out->u.pwszVal, usbformatW, vendor_id, product_id, device, serial_number); > + else if(connection == AudioDeviceConnectionType_PCI) > + sprintfW( out->u.pwszVal, pciformatW, vendor_id, product_id, device, serial_number); > + > + return S_OK; > + } > + }else{ > + WARN("Could not open %s for reading\n", uevent); > + return E_NOTIMPL; > + } > + } > + > + TRACE("Unimplemented property %s,%u\n", wine_dbgstr_guid(&prop->fmtid), prop->pid); > + > + return E_NOTIMPL; > +} > diff --git a/dlls/winealsa.drv/winealsa.drv.spec b/dlls/winealsa.drv/winealsa.drv.spec > index 04fa05a..bd83ea2 100644 > --- a/dlls/winealsa.drv/winealsa.drv.spec > +++ b/dlls/winealsa.drv/winealsa.drv.spec > @@ -8,3 +8,4 @@ > @ stdcall -private GetEndpointIDs(long ptr ptr ptr ptr) AUDDRV_GetEndpointIDs > @ stdcall -private GetAudioEndpoint(ptr ptr ptr) AUDDRV_GetAudioEndpoint > @ stdcall -private GetAudioSessionManager(ptr ptr) AUDDRV_GetAudioSessionManager > +@ stdcall -private GetPropValue(ptr ptr ptr) AUDDRV_GetPropValue > >

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10452 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:8138: Test failed: Got unexpected color 0x000000ff, case 3. ddraw7.c:8138: Test failed: Got unexpected color 0x000000ff, case 4.

2 1

Re: [PATCH 5/5] d3d8/tests: Call TestCooperativeLevel after Present.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10453 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10451 Your paranoid android. === w8 (32 bit visual) === visual.c:17111: Test failed: Got unexpected color 0x000000ff, case 3. visual.c:17111: Test failed: Got unexpected color 0x000000ff, case 4.

1 0

Re: [PATCH 4/5] d3d/tests: Table fog does not abs the fog coordinate.
by Marvin 26 Nov '14

26 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10450 Your paranoid android. === w8 (32 bit visual) === visual.c:5508: Test failed: Got unexpected color 0x000000ff, case 3. visual.c:5508: Test failed: Got unexpected color 0x000000ff, case 4.

1 0

Re: [PATCH 3/3] d3d8: Only one fullscreen swapchain is allowed (v2).
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10437 Your paranoid android. === w8 (32 bit device) === device.c:1217: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1262: Test failed: Reset failed, hr 0x88760868. device.c:1264: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1268: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1275: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1276: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1277: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1278: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1279: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1280: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1285: Test failed: Screen width is 640, expected 800. device.c:1286: Test failed: Screen height is 480, expected 600. device.c:1292: Test failed: Back buffer width is 640, expected 800. device.c:1294: Test failed: Back buffer height is 480, expected 600. device.c:1324: Test failed: Screen width is 640, expected 1024. device.c:1325: Test failed: Screen height is 480, expected 768. device.c:2512: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2517: Test failed: The focus window is active. device.c:2525: Test failed: Got unexpected hr 0x88760869. device.c:2531: Test failed: Got unexpect screen size 800x600. device.c:2546: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2555: Test failed: Got unexpect screen size 800x600. device.c:2568: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2575: Test failed: Got unexpect width 640. device.c:2576: Test failed: Got unexpect height 480.

1 0

Re: user32/tests: Ensure ShowWindow returns false when window is already hidden
by Marvin 25 Nov '14

25 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10433 Your paranoid android. === w7u (32 bit msg) === msg.c:12214: Test failed: unexpected hwnd 00080150 msg.c:12236: Test failed: bad time 30a5c/30a6b

1 0

first patches from a new developer
by Marc Bessières 24 Nov '14

24 Nov '14

Hello, I'm new to wine development. I've just sent my first 2 patches: http://source.winehq.org/patches/data/107855 http://source.winehq.org/patches/data/107856 The second patch passed successfully on testbot: https://testbot.winehq.org/JobDetails.pl?Key=10426 I read the wiki beforehand, so hopefully I didn't make too many mistakes. But please don't hesitate to give any comments so I can improve. Marc

1 0

Re: [PATCH 2/2 try2] mshtml: Added IHTMLDocument2::execCommand implementation.
by Marvin 24 Nov '14

24 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10429 Your paranoid android. === w2000pro (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED dom.c:6147: Test failed: execCommand returned 0 === wxppro (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED dom.c:6147: Test failed: execCommand returned 0 === wvistau64 (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === w2008s64 (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === wvistau64 (64 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === w2008s64 (64 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLDocument2::execCommand implementation.
by Marvin 24 Nov '14

24 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10428 Your paranoid android. === w2000pro (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED dom.c:6147: Test failed: execCommand returned 0 === wxppro (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED dom.c:6147: Test failed: execCommand returned 0 === wvistau64 (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === w2008s64 (32 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === wvistau64 (64 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED === w2008s64 (64 bit dom) === dom.c:6138: Test failed: execCommand failed: 80070057, expected OLECMDERR_E_NOTSUPPORTED

1 0

Re: [PATCH 5/5] d3d8: Only one fullscreen swapchain is allowed.
by Henri Verbeet 24 Nov '14

24 Nov '14

On 21 November 2014 at 18:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!desc.windowed) Formatting. (Also present in the d3d9 version.)

1 0

Re: [PATCH 2/5] d3d9/tests: Fix test_cursor().
by Henri Verbeet 24 Nov '14

24 Nov '14

On 21 November 2014 at 18:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + window = CreateWindowA("d3d9_test_wc", "d3d9_test", WS_OVERLAPPEDWINDOW | WS_VISIBLE, > + 0, 0, 640, 480, NULL, NULL, NULL, NULL); > + > + ret = SetCursorPos(50, 50); > + ok(ret, "Failed to set cursor position.\n"); > + flush_events(); > memset(&info, 0, sizeof(info)); > info.cbSize = sizeof(info); > ok(GetCursorInfo(&info), "GetCursorInfo failed\n"); > cur = info.hCursor; > > - window = CreateWindowA("d3d9_test_wc", "d3d9_test", WS_OVERLAPPEDWINDOW, > - 0, 0, 640, 480, NULL, NULL, NULL, NULL); > ok(!!window, "Failed to create a window.\n"); I think I'd prefer the ok() moved as well, like in the d3d8 version.

1 0

Re: gdiplus:GdipDrawImagePointsRect has a nosie vertical line output after resampled
by Sebastian Lackner 24 Nov '14

24 Nov '14

Hi, while looking quickly over your patch I noticed a couple of mistakes / things you should probably change: On 21.11.2014 15:32, 刘昌辉 wrote: >+ int src_img_height = src_rect.Height; >+ int dest_img_width = dest_rect.X + dest_rect.Width; >+ int dest_img_height = dest_rect.Height; >+ BYTE* src_img_data = malloc (src_img_width*src_img_height*4); >+ BYTE* dest_img_data = malloc (dest_img_width*dest_img_height*4); You shouldn't use malloc(...) and free(...) in wine source, use HeapAlloc(...) and HeapFree(...) instead. >+ >+ /*first line*/ >+ value = *( (DWORD*)dest_img_data + dest_rect.X) ; >+ /*printf ("pixel(%d,%d) = %08x\n", dest_rect.X, 0, value );*/ I assume the printf was for debugging, remove it, or if it is really very important then use trace(...) instead. Other tests use GdipBitmapGetPixel(...) for reading the color of specific pixels. If its possible to use that here too, it would look a bit better than directly accessing the memory. >+ ok ( value > 0, >+ "dest image color should same as src image color\n"); You are switching between different styles in your patch several times. Try to make the style match a bit more the sourrounding code, especially whitespace before and after functions. In this case a linebreak is also not really necessary for example, other lines are much longer. Regards, Sebastian

4 4

Re: [PATCH 1/5] dxgi/tests: Test fullscreen and multiple swapchains.
by Marvin 23 Nov '14

23 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10394 Your paranoid android. === wvistau64 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w2008s64 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w7u (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w8 (32 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === wvistau64 (64 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0. === w2008s64 (64 bit device) === device.c:458: Test failed: SetFullscreenState failed, hr 0x887a0022. device.c:469: Test failed: Got unexpected hr 0x87a0001. device.c:475: Test failed: Got unexpected hr 0.

2 1

Re: [PATCH] winex11.drv: call XRRSetScreenSize when changing resolution
by Mark Harmstone 23 Nov '14

23 Nov '14

Oops, sorry, yes I did. How about the attached patch? It only calls XRRSetScreenSize if there's only one active CRTC. I've managed to scrounge another monitor now, and it works for me with both single and multiple monitors. On 20/11/14 13:19, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > Did you accidentally drop the wine-devel CC, or was this on purpose? > I'd like to CC wine-devel on my reply but don't want to forward your > mail without your consent. > > Stefan > > On 11/20/14 14:03, Mark Harmstone wrote: >> Hi, >> >> I tested this with KDE 4.14.3 and kwin 4.11.14, and it worked fine >> - if there's a KDE bug, it must have been fixed in the latest >> versions. I only have a single monitor to test with, though. >> >> Setting crtc_info->x and crtc_info->y to 0 in XRRSetCrtcConfig >> does stop it from failing outright, but in my experience these are >> only non-zero when panning is already on. For the first resolution >> change, it won't prevent the drivers from going into panning mode, >> and won't (for instance) stop Icewind Dale from failing on startup >> on low resolutions. >> >> Plus all this patch is doing is what xrandr is doing already - >> does that mean that xrandr also messes up multi-monitor setups, or >> would you need to pass it different arguments? And I'm not sure >> what the official Wine line is on this, but it seems to me sensible >> to prioritize simple common setups over complicated rare ones - I'm >> sure far more people use nvidia-drivers than have two monitors. >> >> Mark >> >> >> On 20/11/14 12:48, Stefan Dösinger wrote: On 11/20/14 13:11, Mark >> Harmstone wrote: >>>>> This changes xrandr12_set_current_mode so it behaves the same >>>>> way as xrandr does in 1.2 mode (e.g, `xrandr --output HDMI-0 >>>>> --crtc 0 --mode 640x480`). Before XRRSetCrtcConfig is called, >>>>> the CRTC is temporarily disabled, then XRRSetScreenSize is >>>>> called. (XRRSetCrtcConfig will fail if the CRTC isn't >>>>> disabled first.) >> I've experimented with this a few weeks ago, and it drastically >> improves the usability of fullscreen applications on >> Metacity-based window managers. Unfortunately I'm afraid it is not >> quite that simple. It breaks KDE (may be a bug) and it breaks >> multi-monitor setups. >> >> Testing on Windows (sorry, I did not write formal tests) shows that >> in single monitor setups the virtual screen size is adjusted to >> match the monitor's resolution when the resolution is changed. So >> the change is correct in single monitor setups, but needs tests. >> >> In multi-monitor setups the virtual screen size is changed too, but >> it still takes both monitors into account. E.g. you had two >> monitors at 1920x1080, where one is to the right of the other. So >> you have a virtual screen of 3840x1080. If you change the res of >> the left monitor to 640x480 you get a virtual screen size of >> 2560x1080. >> >> I hackily "fixed" the Nvidia panning bug by replacing crtc_info->x >> and crtc_info->y in pXRRSetCrtcConfig with 0, 0. That way the mode >> set succeeds and the CRTC is positioned correctly. The direct3d >> mouse grab takes care of the mouse moving outside the window, but >> only after clicking in the window once. The d3d grab is incorrect >> though as far as I can see. Windows doesn't grab the mouse in >> fullscreen d3d games in dual monitor setups. >> >> Passing an offset of 0, 0 to pXRRSetCrtcConfig may be the correct >> thing to do. It seems that the content of crtc_info->x and >> crtc_info->y depends on the mouse pointer location, which would be >> an odd thing for a mode change to depend on. May be an Nvidia bug. >> >> Finally, there is a bug in all window managers forked from >> Metacity. If the new resolution is smaller in width or height than >> half the virtual screen size (= old resolution for single-monitor >> setups) then the WM places the window incorrectly. xwininfo reports >> where the window *should* be - at 0x0-WxH. But the real display >> location is something different, depending on the exact incarnation >> of the WM. In Unity it is shifted by 64x64 (unity bar I guess) and >> stretched to the virtual screen size. In MATE I think the window is >> centered. I suspect this is caused by the window positioning logic >> breaking. I have not been able to isolate the bug in the window >> manager code yet. >> >> All in all I'm afraid we have a number of different bugs to fix in >> all Metacity forks, Wine, the Nvidia driver and maybe KDE. >> >> Fwiw, KDE and FVWM place fullscreen windows properly. MATE and >> Unity also adjust their title bars and window maximization to match >> the new CRTC size, not the screen size. >> >>> >> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJUbepaAAoJEN0/YqbEcdMwl0YP/2/QPABqbt3awjNBqQjAV7eA > 0nH8AqvoaSCJ6Ecy3allYa8MC21RmyhK5mCa7e4yWnqTkOaOFCqgjnwPf7C1p7MO > g/aGKsEFpHEM1YL1uvraKDVMeZGVXnSnE08eTrovNBvNvAhZn4Q/y6DZlOVjsJ44 > djJA98/cYoditLcOVSmnqPv9hY85jQYTT2jduvZ7oMbRMhdjU5KZkyEMiCN83F/t > iaY3IQfDzuoGBgH9/f+cSlNlNE8AJvXocJwOVfoW7FD/VU81N9jl5yMzujqEznos > UquZ0CzBlyEWH7i0nxtjL/rfbc4giyF8aKByhSl9PS3k+DaKNsPtt6FWl4a/5+/i > LJU4DQwdWFyQMtyR84kLvskPtNFB7ZNtzmPFvMtVBSziu0NvTGCEPTKKdPX+GgdP > MiX3hSZFhkHzmoEEzfEGI0+j2Azj1RLi7xdVW/z/XIwhsPEd3dAytMaYWe8T05qI > +ysOMuUGRz0tNVPSFiiO7FYcvsj4/o5la/fa0DbIh77GJvZqm8xHCHI6+Lf+Gx5N > EurAoLaH+m8FTA5YRUoTKbxtVY/j+/B7LiTW5x53QcQH/Cb/B9Q2dcH5g/UGugDo > eNm2ZFVqHkIRBa695sm4uTWZHj6RQUblBmLi2tIIdfIihiinZVDBci1CFua+Obsu > p7VTdlbDMVuomwzPL7FA > =DLsp > -----END PGP SIGNATURE----- >

2 2

Re: fusion: Remove unused IAssemblyCacheItem (Clang)
by Nikolay Sivov 22 Nov '14

22 Nov '14

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/fusion/asmcache.c | 94 -------------------------------------------------- > 1 file changed, 94 deletions(-) > I guess the idea was to create some instance with CreateAssemblyCacheItem(), it's trivial and I think we should do that instead of removing item code (even if it's a stub).

1 0

Re: dwrite/tests: Remove unused functions (Clang)
by Nikolay Sivov 22 Nov '14

22 Nov '14

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/dwrite/tests/analyzer.c | 7 ------- > dlls/dwrite/tests/layout.c | 7 ------- > 2 files changed, 14 deletions(-) I'll send a patch to use those helpers, don't remove them for now.

1 0

Re: dwrite: Remove unused code (Clang)
by Nikolay Sivov 22 Nov '14

22 Nov '14

On 21.11.2014 22:58, André Hentschel wrote: > --- > dlls/dwrite/bidi.c | 6 ------ > dlls/dwrite/shape.c | 2 -- > 2 files changed, 8 deletions(-) > I don't mind, let's remove that. Looks like iso_previousChar() could be removed from usp10 too then.

1 0

Re: wined3d: Add NVIDIA Geforce GT 750M to supported device list.
by Jonas Maebe 21 Nov '14

21 Nov '14

FWIW, I have such an NVIDIA Geforce GT 750M card (under OS X 10.9.5) and Crossover 13.2 returned 768MB of vram for it. Crossover 14/14.0.1 returns 128MB instead, which resulted in a number of games suddenly crashing because they ran out of VRAM. This issue was quickly diagnosed by the helpful Codeweavers support person, and resolved by adding the registry entry to override the video memory size. Looking at the current source code, I assume that's because shader_arb_get_caps() can set the shader_caps->vs_version maximally to 3, while d3d_level_from_caps() will only return WINED3D_D3D_LEVEL_10 for shader_caps->vs_version==4. As a result, d3d_level_from_caps now returns WINED3D_D3D_LEVEL_9_SM3, which is translated for an unknown NVidia card into CARD_NVIDIA_GEFORCE_6800. That one is indeed defined as having 128MB of VRAM.

5 13

Re: [PATCH 5/5] d3d8: Only one fullscreen swapchain is allowed.
by Marvin 21 Nov '14

21 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10398 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2517: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2522: Test failed: The focus window is active. device.c:2530: Test failed: Got unexpected hr 0x88760869. device.c:2536: Test failed: Got unexpect screen size 800x600. device.c:2551: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2560: Test failed: Got unexpect screen size 800x600. device.c:2573: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2580: Test failed: Got unexpect width 640. device.c:2581: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 4/5] d3d8/tests: Fix test_cursor().
by Marvin 21 Nov '14

21 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10397 Your paranoid android. === w8 (32 bit device) === device.c:1186: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1231: Test failed: Reset failed, hr 0x88760868. device.c:1233: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1237: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1244: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1245: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1246: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1247: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1248: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1249: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1254: Test failed: Screen width is 640, expected 800. device.c:1255: Test failed: Screen height is 480, expected 600. device.c:1261: Test failed: Back buffer width is 640, expected 800. device.c:1263: Test failed: Back buffer height is 480, expected 600. device.c:1293: Test failed: Screen width is 640, expected 1024. device.c:1294: Test failed: Screen height is 480, expected 768. device.c:2481: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2486: Test failed: The focus window is active. device.c:2494: Test failed: Got unexpected hr 0x88760869. device.c:2500: Test failed: Got unexpect screen size 800x600. device.c:2515: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2524: Test failed: Got unexpect screen size 800x600. device.c:2537: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2544: Test failed: Got unexpect width 640. device.c:2545: Test failed: Got unexpect height 480.

1 0

Re: gdiplus:GdipDrawImagePointsRect has a nosie vertical line output after resampled
by Vincent Povirk 21 Nov '14

21 Nov '14

This will break in cases where the destination area (defined by points) is not a rectangle. On Fri, Nov 21, 2014 at 8:32 AM, 刘昌辉 <liuchanghui(a)linuxdeepin.com> wrote: > > > >

1 0

Re: [PATCH 4/5] wined3d: Don't minimize hidden Windows.
by Henri Verbeet 21 Nov '14

21 Nov '14

On 19 November 2014 20:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2189,6 +2189,13 @@ static LRESULT CALLBACK test_proc(HWND hwnd, UINT message, WPARAM wparam, LPARAM > } > } > > + if (unexpected_messages) > + { > + const struct message *i; > + for (i = unexpected_messages; i->message; i++) > + ok(i->message != message, "Got unexpected message %x on window %p.\n", message, hwnd); Note that putting the ok() in test_proc() makes it hard to find the actual test that failed.

2 1

Re: shell32/tests: Fix a copy and paste error (PVS-Studio)
by Marvin 20 Nov '14

20 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10373 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

2 1

Re: [2/2] ws2_32: Implement returning the proper time with SO_CONNECT_TIME.
by Bruno Jesus 20 Nov '14

20 Nov '14

On Thu, Nov 20, 2014 at 10:27 AM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Based on a patch by Erich Hoover. > > To avoid calculations on the client-side, the server sends the connect time as relative (negative) value. > Needs tools/make_requests. Hi, Sebastian. Thanks for taking care of this, but actually I'm thinking by doing this in a different way. I'm thinking about moving SO_CONNECT_TIME, SO_SNDBUF and SO_RECVBUF to the server with some new server message or the one Erich created for the WSAIoctl. By doing it this way we can fix not only this bug but also https://bugs.winehq.org/show_bug.cgi?id=8606 where we can store the pretended SO_SNDBUF value and return to the client when asked. Some other messages could also be done there like SO_EXCLUSIVEADDR, SO_DEBUG and others that require only memory to store/retrieve the value. This would also help for SO_ACCEPTCONN which is bugged in OSX due to a kernel problem. Not sure if my approach would be accepted anyway. Best wishes, Bruno

2 6

Re: [PATCH 1/2] Add tests for calling ShowWindow(SW_HIDE) on a hidden window.
by Marvin 20 Nov '14

20 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10364 Your paranoid android. === w7u (32 bit msg) === msg.c:12217: Test failed: unexpected hwnd 0014013C msg.c:12239: Test failed: bad time 309c0/309cf

2 1

Re: [PATCH] explorer: Fix copy_path_string() when an unnecessary \ follow the path.
by Huw Davies 20 Nov '14

20 Nov '14

On Thu, Nov 20, 2014 at 08:29:17PM +0800, Jactry Zeng wrote: > @@ -639,6 +640,11 @@ static int copy_path_string(LPWSTR target, LPWSTR source) > while (*source && *source != ',') target[i++] = *source++; > target[i] = 0; > } > + > + last = strlenW(target) - 1; > + if (target[0] && target[last] == '\\') > + target[last] = 0; > + > return i; > } You probably want PathRemoveBackslashW() Huw.

2 1

Re: [PATCH] winex11.drv: call XRRSetScreenSize when changing resolution
by Stefan Dösinger 20 Nov '14

20 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/20/14 13:11, Mark Harmstone wrote: > This changes xrandr12_set_current_mode so it behaves the same way > as xrandr does in 1.2 mode (e.g, `xrandr --output HDMI-0 --crtc 0 > --mode 640x480`). Before XRRSetCrtcConfig is called, the CRTC is > temporarily disabled, then XRRSetScreenSize is called. > (XRRSetCrtcConfig will fail if the CRTC isn't disabled first.) I've experimented with this a few weeks ago, and it drastically improves the usability of fullscreen applications on Metacity-based window managers. Unfortunately I'm afraid it is not quite that simple. It breaks KDE (may be a bug) and it breaks multi-monitor setups. Testing on Windows (sorry, I did not write formal tests) shows that in single monitor setups the virtual screen size is adjusted to match the monitor's resolution when the resolution is changed. So the change is correct in single monitor setups, but needs tests. In multi-monitor setups the virtual screen size is changed too, but it still takes both monitors into account. E.g. you had two monitors at 1920x1080, where one is to the right of the other. So you have a virtual screen of 3840x1080. If you change the res of the left monitor to 640x480 you get a virtual screen size of 2560x1080. I hackily "fixed" the Nvidia panning bug by replacing crtc_info->x and crtc_info->y in pXRRSetCrtcConfig with 0, 0. That way the mode set succeeds and the CRTC is positioned correctly. The direct3d mouse grab takes care of the mouse moving outside the window, but only after clicking in the window once. The d3d grab is incorrect though as far as I can see. Windows doesn't grab the mouse in fullscreen d3d games in dual monitor setups. Passing an offset of 0, 0 to pXRRSetCrtcConfig may be the correct thing to do. It seems that the content of crtc_info->x and crtc_info->y depends on the mouse pointer location, which would be an odd thing for a mode change to depend on. May be an Nvidia bug. Finally, there is a bug in all window managers forked from Metacity. If the new resolution is smaller in width or height than half the virtual screen size (= old resolution for single-monitor setups) then the WM places the window incorrectly. xwininfo reports where the window *should* be - at 0x0-WxH. But the real display location is something different, depending on the exact incarnation of the WM. In Unity it is shifted by 64x64 (unity bar I guess) and stretched to the virtual screen size. In MATE I think the window is centered. I suspect this is caused by the window positioning logic breaking. I have not been able to isolate the bug in the window manager code yet. All in all I'm afraid we have a number of different bugs to fix in all Metacity forks, Wine, the Nvidia driver and maybe KDE. Fwiw, KDE and FVWM place fullscreen windows properly. MATE and Unity also adjust their title bars and window maximization to match the new CRTC size, not the screen size. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUbeMbAAoJEN0/YqbEcdMwutAP/jWwKCaDNL0OzaWoQhVM8+XN fmshL9cSYha3jVnJ8TJU92ch/7NcFsnGFL0dAEFz1bZqpM9lHwqapdjhqP7PUI0r yIpRNoBR+UjeX46zQ1oIbcib2UpXhm0YZQ0x45DaaUGvVDFGSs0d2Oo4nulDJFx+ DkEdSxe9p403rc6S2nfWHROaUmT3v/stYs9nN+A+YuBleYZwJz+e+MknElTBiboo RcIWnOICDksJ08oEhWaMxNDLtQstMYp0cuRtPNeB3jCWxRP00xsgXgZ2uAigSrrI OPcLgQ5jq3MFDdHorgz7pM3aOa5YvouFxt1OsCsbyekSovBJMj4WaB0QHmqOxPUQ 2LQzS9TMsR0CJYl6hdsykB6c8Gdqdcc8Gv+SoLUn7FjUckvXi6cgnN+XnXTFBQT2 ah6S59gVYxwvb4IVdvYuAL/AvN3tlfR6rOkw/U3Z16u0KHa2C0SQRSK8ohuFabzS SMq2VEq4Cspub3nYCSOSSFZvmUKxlHdyQPPfXEpFEfBQaM40CnsfqN/7vfchj0dQ jAExC4Z1PGvFJFqVnTFaxZ3eIOPBDIBOTgkDK14gWaxrZoGySTJtDe6513iLBsQv 75JZxcfl5VZbzIfYuUcVjvXoWyr4gqeOSJhe/oEITpd5UwEAZabcvJ/yIH8s3u0T tliUU3UuYOfzLsP7jLP2 =eGIQ -----END PGP SIGNATURE-----

1 0

Re: [PATCH] winex11.drv: call XRRSetScreenSize when changing resolution
by Henri Verbeet 20 Nov '14

20 Nov '14

On 20 November 2014 13:11, Mark Harmstone <hellas(a)burntcomma.com> wrote: > This changes xrandr12_set_current_mode so it behaves the same way as xrandr > does in 1.2 mode (e.g, `xrandr --output HDMI-0 --crtc 0 --mode 640x480`). > Before XRRSetCrtcConfig is called, the CRTC is temporarily disabled, then > XRRSetScreenSize is called. (XRRSetCrtcConfig will fail if the CRTC isn't > disabled first.) > Stefan did tests for this a while back so he'll know the details, but I'm pretty sure this will do the wrong thing on multihead systems.

1 0

Re: Update dmFormName when changing paper size in print ui.(resend, try2)
by Dmitry Timoshkov 20 Nov '14

20 Nov '14

Ralf Habacker <ralf.habacker(a)freenet.de> wrote: > + GetDlgItemTextA(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)); Please use CCHFORMNAME instead of sizeof(). > + GetDlgItemTextW(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)/sizeof(WCHAR)); Same here. -- Dmitry.

1 0

Re: [PATCH 2/2] Do not call SendMessage() to hide a window that is already hidden (try 3)
by Marvin 20 Nov '14

20 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10365 Your paranoid android. === w7u (32 bit msg) === msg.c:12214: Test failed: unexpected hwnd 00080150 msg.c:12236: Test failed: bad time 30b26/30b36

1 0

Re: Update dmFormName when changing paper size in print ui. (resend)
by Nikolay Sivov 20 Nov '14

20 Nov '14

On 20.11.2014 10:42, Ralf Habacker wrote: > - if(Sel != CB_ERR) > + if(Sel != CB_ERR) { > lpdm->u1.s1.dmPaperSize = SendDlgItemMessageW(hDlg, cmb2, > CB_GETITEMDATA, > Sel, 0); > + GetDlgItemTextW(hDlg, cmb2, lpdm->dmFormName, sizeof(lpdm->dmFormName)); > + } This looks wrong, this function takes character length, not byte length.

1 0

Re: [PATCH 4/5] wined3d: Don't minimize hidden Windows.
by Marvin 20 Nov '14

20 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10357 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2476: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2481: Test failed: The focus window is active. device.c:2489: Test failed: Got unexpected hr 0x88760869. device.c:2495: Test failed: Got unexpect screen size 800x600. device.c:2510: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2519: Test failed: Got unexpect screen size 800x600. device.c:2532: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2539: Test failed: Got unexpect width 640. device.c:2540: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 2/5] wined3d: Set the device window size on focus window activation.
by Marvin 20 Nov '14

20 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10354 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2454: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2459: Test failed: The focus window is active. device.c:2467: Test failed: Got unexpected hr 0x88760869. device.c:2473: Test failed: Got unexpect screen size 800x600. device.c:2488: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2497: Test failed: Got unexpect screen size 800x600. device.c:2633: Test failed: Expected foreground window 000500F6, got 0002004C. device.c:3009: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3013: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3036: Test failed: Failed to reset device, hr 0x88760868. device.c:3040: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3044: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3058: Test failed: Failed to set foreground window. device.c:3062: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3066: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: d3dcompiler_43: Remove a no-op statement (PVS-Studio)
by Matteo Bruni 19 Nov '14

19 Nov '14

2014-11-19 9:10 GMT+01:00 Michael Stefaniuc <mstefani(a)redhat.de>: > D3DSRO_POSITION is 0. Yes, it is 0, but I still feel like it should stay there for consistency with the other cases. What I mean is that if that line is removed I'm pretty sure I'd be like "oh wow, this is clearly broken" every time I happen to look at that piece of code. But maybe that's just me. > --- > dlls/d3dcompiler_43/bytecodewriter.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/dlls/d3dcompiler_43/bytecodewriter.c b/dlls/d3dcompiler_43/bytecodewriter.c > index 46187f9..71ee6c1 100644 > --- a/dlls/d3dcompiler_43/bytecodewriter.c > +++ b/dlls/d3dcompiler_43/bytecodewriter.c > @@ -855,7 +855,6 @@ static DWORD map_vs_output(struct bc_writer *This, DWORD regnum, DWORD mask, DWO > *has_components = TRUE; > if(regnum == This->oPos_regnum) { > token |= (D3DSPR_RASTOUT << D3DSP_REGTYPE_SHIFT) & D3DSP_REGTYPE_MASK; > - token |= D3DSRO_POSITION & D3DSP_REGNUM_MASK; /* No shift */ > return token; > } > if(regnum == This->oFog_regnum && mask == This->oFog_mask) { > -- > 1.9.3 Cheers, Matteo.

3 2

Re: [PATCH 1/2] mmdevapi: allow GetPropValue function in audio drivers (try 2)
by Andrew Eikum 19 Nov '14

19 Nov '14

Looks good, just one small note below. On Wed, Nov 19, 2014 at 02:35:14PM +0000, Mark Harmstone wrote: > + if (!drvs.pGetPropValue) > + { > + TRACE("Driver does not implement GetPropValue\n"); > + return E_NOTIMPL; > + } > + This makes the drivers without GetPropValue pretty noisy during loading. I don't think anything needs to be printed, since we'll see the TRACEs from the driver if the function is present. Andrew

1 0

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path (try 2)
by Andrew Eikum 19 Nov '14

19 Nov '14

Looking pretty good. Couple notes below. On Wed, Nov 19, 2014 at 02:35:39PM +0000, Mark Harmstone wrote: > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index 5ad72f9..c21fd0c 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -3823,3 +3823,107 @@ HRESULT WINAPI AUDDRV_GetAudioSessionManager(IMMDevice *device, > > return S_OK; > } > + > +enum AudioDeviceConnectionType { > + AudioDeviceConnectionType_Unknown = 0, > + AudioDeviceConnectionType_PCI, > + AudioDeviceConnectionType_USB > +}; > + > +HRESULT WINAPI AUDDRV_GetPropValue(GUID *guid, const PROPERTYKEY *prop, PROPVARIANT *out) > +{ > + static const PROPERTYKEY devicepath_key = { /* undocumented? - {b3f8fa53-0004-438e-9003-51a46e139bfc},2 */ > + {0xb3f8fa53, 0x0004, 0x438e, {0x90, 0x03, 0x51, 0xa4, 0x6e, 0x13, 0x9b, 0xfc}}, 2 > + }; > + > + static const char dev_info[] = "/sys/class/sound/card%u/device/uevent"; > + I'd prefer "const char *" and actually, is there any reason not to just put this string straight in the sprintf? > + TRACE("%s, (%s,%u), %p\n", wine_dbgstr_guid(guid), wine_dbgstr_guid(&prop->fmtid), prop->pid, out); > + > + if(IsEqualGUID(&prop->fmtid, &devicepath_key.fmtid) && prop->pid == devicepath_key.pid) > + { I think you can use IsEqualPropertyKey here. > + char name[256], uevent[MAX_PATH]; > + EDataFlow flow; > + FILE *fuevent; > + int card, device; > + > + if(!get_alsa_name_by_guid(guid, name, sizeof(name), &flow)) > + { > + WARN("Unknown interface %s\n", debugstr_guid(guid)); > + return E_NOINTERFACE; > + } > + > + /* only implemented for identifiable devices, i.e. not "default" */ > + if(!sscanf(name, "plughw:%u,%u", &card, &device)) > + return E_NOTIMPL; > + > + sprintf(uevent, dev_info, card); > + fuevent = fopen(uevent, "r"); > + > + if(fuevent){ > + enum AudioDeviceConnectionType connection = AudioDeviceConnectionType_Unknown; > + USHORT vendor_id = 0, product_id = 0; > + char *line = NULL; > + > + while (!feof(fuevent)) { > + char *val; > + size_t val_len, len = 0; > + > + getline(&line, &len, fuevent); > + We should probably break on failure here. > + if((val = strchr(line, '='))) { > + val[0] = 0; > + val++; > + > + val_len = strlen(val); > + if (val_len > 0 && val[val_len - 1] == '\n') { val[val_len - 1] = 0; } > + > + if(!strcmp(line, "PCI_ID")){ > + connection = AudioDeviceConnectionType_PCI; > + sscanf(val, "%hX:%hX", &vendor_id, &product_id); > + }else if (!strcmp(line, "DEVTYPE") && !strcmp(val,"usb_interface")) > + connection = AudioDeviceConnectionType_USB; > + else if (!strcmp(line, "PRODUCT")) > + sscanf(val, "%hx/%hx/", &vendor_id, &product_id); > + } > + } Can we do anything sane on sscanf failure here? Maybe dump a WARN and revert back to AudioDeviceConnectionType_Unknown. Is that preferable to falling back on 0 for one or more of the IDs? Andrew

1 0

Re: [2/2] vssapi: Add stub implementations for a couple of functions.
by Alexandre Julliard 19 Nov '14

19 Nov '14

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/vssapi/main.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/vssapi/vssapi.spec | 10 +++--- > include/Makefile.in | 1 + > include/vss.idl | 31 ++++++++++++++++++ > include/vswriter.h | 47 ++++++++++++++++++++++++++++ > 5 files changed, 167 insertions(+), 5 deletions(-) > create mode 100644 include/vss.idl > create mode 100644 include/vswriter.h It doesn't build on Mingw: ../../../wine/dlls/vssapi/main.c:33:0: warning: "__thiscall" redefined [enabled by default] <built-in>:0:0: note: this is the location of the previous definition main.o:main.c:(.text+0x14): undefined reference to `_VSSAPI_CVssWriter_Initialize@36' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] wined3d: Take abs() of vertex z coordinate as FFP fog coordinate (try 7)
by Stefan Dösinger 19 Nov '14

19 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-14 22:40, schrieb Joachim Priesner: > Take the absolute value of vertex.z as fog coordinate instead of > just the z coordinate. This fixes e.g. fog for applications that > use right-handed projection matrices. > > Also test the clamp behavior of the oFog vertex shader output. Fwiw, the start / end tests look good to me, and the results match what I expected. However I think Henri still disagrees with this patch. Henri, I'd appreciate if you would say what you want. Without that I can offer Joachim only guesswork. My guess is that the test is too complex. There are some parts that are technically not required to demonstrate the correctness of the abs(), but I see some value in the additional checks: *) The "interrupted" quad with extra vertices at z = 0. It shows that the fully fogged other quad is not a result of the interpolation failing entirely and producing INF or NaN. *) The foggy shader test: It shows how negative values coming from vertex shaders are treated. It's just logical to test this considering the behavior of the fixed function pipeline. *) The manual fog coord / unfogged shader tests: Those could be removed I guess, although at least the manual fog coord test shows that there isn't some unexpected interference with negative depth values. Joachim, I can offer you that I try to simplify those tests. If you're still motivated to work on this I'm happy to leave this up to you though. Some ideas for simplifying the test, but I don't know yet if they'll work: *) Split the shader and fixed function tests into separate tests. *) Remove the interpolation tests from the fixed function tests. fog_interpolation_test shows that the fog equation is evaluated in the vertex pipeline in the affected cases, and the fogstart = -1, fogend = 0 test shows that the abs() happens before the fog equation. So I think removing this part of the test for the fixed function part is safe. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUbK/nAAoJEN0/YqbEcdMworwP/2OytnoHiSrHWoFK9YPUvEGQ XIyIDZhe/PoMKaBGRdgqFWd4EjoVr9haUmCcPWb1BK/0R2MVSTIK0TS88RlotiMx ZIBcJJWCiiBvhNrydAW5Qqg/80h5UOgaumkWdi2qF4SfkvP/A3jLXvulXZaOU88k rmnlWXxiQun0EIMzShzms0OZmKxmyKkhm84CXAAr3hIh3k9anXVsr0Nsgi2UXTBl ey55rNaE/NBZdNMP/in/5kEq76f0WA7bx1CV2zfCds5p34thQPQLjuvYQ0mqz3Qg zo24W/J52m70W1GmqD/J2+4g5XPO2Gf3xIjV0NyJW988hsCoHIyQHFXZbRkZQpbQ ULdhBq6VgW6O9d1f9H1hy18HxVwlGPFjnu7gniMTWqtBLzyC3b6pppSqQfg1zRhj X/Njp/JBhSUWe8is4sP2R7sHl2fqMi5ROWQyXVpca/rUdoiu6dAH8zYo3IqepGDW P1RoSiwQXXDEh0tV/gzW7pVnk7nNRtcL6el0R5C7aqrytWi3xLXYfdsug6sluKK6 onN/Iz0PpBDsokaTFUMua1JgZ8fx7+Av/S/2xfPvMpSFyrp+q/Q4fw5HdQEKfCIb +JtA03sG0ZfKLjCWL3JRW2kt3G3TxQTOdaJ+Dic5S50xMjs04Ze2Ie3BzbY4FEn0 ZqXciJ+kIVCN4+LD5aJp =RHD+ -----END PGP SIGNATURE-----

1 0

Re: [PATCH 6/6] wined3d: Restore the display mode on focus change.
by Henri Verbeet 19 Nov '14

19 Nov '14

On 18 November 2014 21:26, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!EnumDisplaySettingsW(adapter->DeviceName, ENUM_REGISTRY_SETTINGS, &new_mode)) Formatting. > + else if (current_mode.dmPelsWidth == new_mode.dmPelsWidth > + && current_mode.dmPelsHeight == new_mode.dmPelsHeight > + && current_mode.dmBitsPerPel == new_mode.dmBitsPerPel > + && (current_mode.dmDisplayFrequency == new_mode.dmDisplayFrequency > + || !(new_mode.dmFields & DM_DISPLAYFREQUENCY)) > + && (current_mode.u2.dmDisplayFlags == new_mode.u2.dmDisplayFlags > + || new_mode.dmFields & DM_DISPLAYFLAGS)) Shouldn't that be "!(new_mode.dmFields & DM_DISPLAYFLAGS)"? > - struct wined3d_display_mode original_mode; > + struct wined3d_display_mode original_mode, d3d_mode; I might have just gone for "mode", but I don't care strongly.

1 0

Re: [PATCH 1/2] ole32/tests: Release() doesn't return HRESULT code
by Marvin 19 Nov '14

19 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10342 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 00425FC9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004209EA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004209EA

2 1

Re: ole32: Simplify a function by removing no-op code (PVS-Studio).
by Sebastian Lackner 19 Nov '14

19 Nov '14

On 19.11.2014 09:26, Michael Stefaniuc wrote: > MSHLFLAGS_NORMAL is 0. > --- > dlls/ole32/stubmanager.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/dlls/ole32/stubmanager.c b/dlls/ole32/stubmanager.c > index 96d710d..1aca924 100644 > --- a/dlls/ole32/stubmanager.c > +++ b/dlls/ole32/stubmanager.c > @@ -536,7 +536,6 @@ HRESULT ipid_get_dispatch_params(const IPID *ipid, APARTMENT **stub_apt, > /* returns TRUE if it is possible to unmarshal, FALSE otherwise. */ > BOOL stub_manager_notify_unmarshal(struct stub_manager *m, const IPID *ipid) > { > - BOOL ret = TRUE; > struct ifstub *ifstub; > > if (!(ifstub = stub_manager_ipid_to_ifstub(m, ipid))) > @@ -545,23 +544,7 @@ BOOL stub_manager_notify_unmarshal(struct stub_manager *m, const IPID *ipid) > return FALSE; > } > > - EnterCriticalSection(&m->lock); > - > - /* track normal marshals so we can enforce rules whilst in-process */ > - if (ifstub->flags & MSHLFLAGS_NORMAL) > - { > - if (m->norm_refs) > - m->norm_refs--; > - else > - { > - ERR("attempted invalid normal unmarshal, norm_refs is zero\n"); > - ret = FALSE; > - } > - } > - > - LeaveCriticalSection(&m->lock); > - > - return ret; > + return TRUE; > } > > /* handles refcounting for CoReleaseMarshalData */ > Although logically correct, I am not sure if this is what it should look like. In ole32/marshal for example there is also: --- snip --- if (flags & MSHLFLAGS_TABLEWEAK) TRACE(" MSHLFLAGS_TABLEWEAK"); if (!(flags & (MSHLFLAGS_TABLESTRONG|MSHLFLAGS_TABLEWEAK))) TRACE(" MSHLFLAGS_NORMAL"); if (flags & MSHLFLAGS_NOPING) TRACE(" MSHLFLAGS_NOPING"); --- snip --- This could probably mean that fixing the if condition is a more correct solution, but I don't know that part well enough.

2 1

Re: [PATCH 1/2] mmdevapi: allow GetPropValue function in audio drivers
by Nikolay Sivov 19 Nov '14

19 Nov '14

On 18.11.2014 20:59, Mark Harmstone wrote: > + if (SUCCEEDED(hr)) > + { > + MMDevice_SetPropValue(id, flow, prop, &pv); > + > + if (pv.vt == VT_LPWSTR) > + HeapFree(GetProcessHeap(), 0, pv.u.pwszVal); > + } > + out->vt = VT_LPWSTR; > + out->u.pwszVal = HeapAlloc(GetProcessHeap(), 0, 256 * sizeof(WCHAR)); This is a wrong way dealing with PROPVARIANT, you need to use PropVariantClear() and InitPropVariantFromString() - PROPVARIANT implies CoTaskMemAlloc/CoTaskMemFree memory management.

1 0

Re: [PATCH 6/6] wined3d: Restore the display mode on focus change.
by Marvin 19 Nov '14

19 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10336 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2446: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2451: Test failed: The focus window is active. device.c:2459: Test failed: Got unexpected hr 0x88760869. device.c:2465: Test failed: Got unexpect screen size 800x600. device.c:2485: Test failed: Got unexpect screen size 800x600. device.c:2621: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2997: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3001: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3024: Test failed: Failed to reset device, hr 0x88760868. device.c:3028: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3032: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3046: Test failed: Failed to set foreground window. device.c:3050: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3054: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 4/6] d3d8/tests: Test mode restoration on focus loss.
by Marvin 19 Nov '14

19 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10334 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2446: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2451: Test failed: The focus window is active. device.c:2459: Test failed: Got unexpected hr 0x88760869. device.c:2465: Test failed: Got unexpect screen size 800x600. device.c:2485: Test failed: Got unexpect screen size 800x600. device.c:2621: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2997: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3001: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3024: Test failed: Failed to reset device, hr 0x88760868. device.c:3028: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:3032: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3046: Test failed: Failed to set foreground window. device.c:3050: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:3054: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 2/2] winealsa: implement GetPropValue and return device path
by Nikolay Sivov 18 Nov '14

18 Nov '14

On 18.11.2014 20:59, Mark Harmstone wrote: > --- a/dlls/winealsa.drv/Makefile.in > +++ b/dlls/winealsa.drv/Makefile.in > @@ -1,5 +1,5 @@ > MODULE = winealsa.drv > -IMPORTS = uuid ole32 advapi32 > +IMPORTS = uuid ole32 advapi32 user32 > DELAYIMPORTS = winmm > EXTRALIBS = $(ALSA_LIBS) If you need this only for wsprintfW() you could try sprintfW() from include/wine/unicode.h.

1 0

Re: [PATCH 1/2] mshtml: Added support for IHTMLFrameBase::put_src call on detached element.
by Marvin 18 Nov '14

18 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10324 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] ddraw/tests: Test messages on focus loss (v2).
by Henri Verbeet 18 Nov '14

18 Nov '14

On 17 November 2014 21:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2291,6 +2320,18 @@ static void test_coop_level_mode_set(void) > user32_rect.left, user32_rect.top, user32_rect.right, user32_rect.bottom, > r.left, r.top, r.right, r.bottom); > > + expect_messages = exclusive_focus_loss_messages; > + SetForegroundWindow(GetDesktopWindow()); > + ok(!expect_messages->message, "Expected message %#x, but didn't receive it.\n", expect_messages->message); This fails for me on Windows: ddraw1.c:2295: Test failed: Expected message 0x46, but didn't receive it.

1 0

Re: [3/6] user32/tests: Reenable test function for WM_GETTEXT.
by Marvin 18 Nov '14

18 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10317 Your paranoid android. === w2008s64 (64 bit win) === win.c:3367: Test failed: hwnd 00000000000100F4 message 0118

2 1

Re: configure: Fix detection of gnutls on Ubuntu 14.10.
by Nicolas Le Cam 18 Nov '14

18 Nov '14

2014-11-17 9:37 GMT+01:00 Sebastian Lackner <sebastian(a)fds-team.de>: > Someone asked me to submit this, although its very Ubuntu specific. > > On some Ubuntu versions there only exists a package where libgnutls was renamed to libgnutls-deb0. As an effect ./configure fails to detect it properly because it compares the exact soname. > > http://packages.ubuntu.com/precise/amd64/libgnutls28/filelist > http://packages.ubuntu.com/utopic/amd64/libgnutls-deb0-28/filelist > > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Hi Sebastian, This also fixes libgnutls detection on Debian testing (and futur Jessie) and derivatives. What about [[libgnutls\$-deb[[0-9]]\$\\{0,1\\}]] or [[libgnutls\$-[[0-9A-Za-z]]\+\$\\{0,1\\}]] instead. I don't think the debian specific soname will bump too often but it could avoid the need for another patch. -- Nicolas Le Cam

2 1

Re: [PATCH 4/6] d3d8/tests: Test style changes on focus loss.
by Marvin 17 Nov '14

17 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10310 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2364: Test failed: Expected message 0x46 for window 0, but didn't receive it. device.c:2369: Test failed: The focus window is active. device.c:2373: Test failed: Got unexpected hr 0. device.c:2379: Test failed: Got unexpected hr 0. device.c:2393: Test failed: Got unexpected hr 0. device.c:2523: Test failed: Expected foreground window 000501B8, got 0002004C. device.c:2899: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2903: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2926: Test failed: Failed to reset device, hr 0x88760868. device.c:2930: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2934: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2948: Test failed: Failed to set foreground window. device.c:2952: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2956: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 3/6] d3d8/tests: Test messages on focus loss (v2).
by Marvin 17 Nov '14

17 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10309 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2364: Test failed: Expected message 0x46 for window 0, but didn't receive it. device.c:2369: Test failed: The focus window is active. device.c:2373: Test failed: Got unexpected hr 0. device.c:2379: Test failed: Got unexpected hr 0. device.c:2393: Test failed: Got unexpected hr 0. device.c:2523: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2898: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2902: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2925: Test failed: Failed to reset device, hr 0x88760868. device.c:2929: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2933: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3301: Test failed: Failed to reset device. device.c:3308: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3316: Test failed: Expected wndproc != 0x411620.

1 0

Re: cryptext: add stubs for CryptExtAddPFX/CryptExtAddPFXW
by Nikolay Sivov 17 Nov '14

17 Nov '14

On 17.11.2014 22:21, Austin English wrote: > +HRESULT WINAPI CryptExtAddPFX(LPCSTR filename) > +{ > + FIXME("stub: %s\n", debugstr_a(filename)); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} Return type and error code don't match here. If it should be HRESULT use E_NOTIMPL, otherwise return type should be DWORD or similar.

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLStyleSheet::cssText tests.
by Marvin 17 Nov '14

17 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10298 Your paranoid android. === w2000pro (32 bit dom) === dom: unhandled exception c0000005 at 780104AC

1 0

Re: [PATCH 2/7] d3d9/tests: Test messages on focus loss.
by Alexandre Julliard 17 Nov '14

17 Nov '14

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Resolution changing behavior will be tested in a separate patch. > --- > dlls/d3d9/tests/d3d9ex.c | 277 ++++++++++++++++++++++++++++---------------- > dlls/d3d9/tests/device.c | 293 +++++++++++++++++++++++++++++++---------------- > 2 files changed, 375 insertions(+), 195 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so d3d9ex && touch d3d9ex.ok d3d9ex.c:1656: Tests skipped: This GPU supports SM3, skipping unsupported shader test. d3d9ex.c:1942: Test failed: Expected message 0x6 for window 0x1, but didn't receive it, i=0. d3d9ex.c:1964: Test failed: Got unexpected hr 0x8760878, i=0. d3d9ex.c:1942: Test failed: Expected message 0x6 for window 0x1, but didn't receive it, i=1. d3d9ex.c:1964: Test failed: Got unexpected hr 0x8760878, i=1. make: *** [d3d9ex.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 5/5] d3d10core/tests: Port alpha_test() to d3d10core.
by Marvin 17 Nov '14

17 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10295 Your paranoid android. === w8 (32 bit visual) === visual.c:2635: Test failed: unexpected colortable on offscreen surface

1 0

Re: Update on MSNet
by Susan Cragin 14 Nov '14

14 Nov '14

You can now ask that or any other question. I just asked about the licenses, Page 6. http://blogs.msdn.com/b/dotnet/archive/2014/11/12/net-core-is-open-source.a…

2 1

Update on MSNet
by Susan Cragin 14 Nov '14

14 Nov '14

I'm sure you know this, but thought I would pass this along. MSNet framework is open-source. http://blogs.msdn.com/b/dotnet/archive/2014/11/12/net-core-is-open-source.a… An article I read said that MS has committed to developing linux and mac versions, but I don't see where MS has committed money to it. Keep up the good work! Susan

3 2

Re: [2/2] ntdll: Implement Rtl[Add|Remove]VectoredContinueHandler semi-stubs.
by Marvin 14 Nov '14

14 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10262 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/003C0001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [1/2] ntdll/tests: Add basic tests for Rtl[Add|Remove]VectoredContinueHandler.
by Marvin 14 Nov '14

14 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10261 Your paranoid android. === w2000pro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:486: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:486: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 00350000/00350001 exception: unhandled exception 80000004 at 00350000 exception.c:486: Test failed: 42: Wrong exception address 7751ED97/00350001 === w2008s64 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:486: Test failed: 42: Wrong exception address 77E5ED97/003D0001 === w7u (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:486: Test failed: 42: Wrong exception address 77CDE34F/003C0001 === w8 (32 bit exception) === exception.c:486: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:486: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 5/7] d3d8/tests: Test style changes on focus loss.
by Marvin 14 Nov '14

14 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10250 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2889: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2893: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2916: Test failed: Failed to reset device, hr 0x88760868. device.c:2920: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2924: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2938: Test failed: Failed to set foreground window. device.c:2942: Test failed: Expected device window style 0x34cf0000, got 0x4cf0000. device.c:2946: Test failed: Expected device window extended style 0x108, got 0x100.

1 0

Re: [PATCH 4/7] d3d8/tests: Test messages on focus loss.
by Marvin 14 Nov '14

14 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10249 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2361: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2366: Test failed: The focus window is active. device.c:2370: Test failed: Got unexpected hr 0. device.c:2372: Test failed: Got unexpected hr 0. device.c:2383: Test failed: Got unexpected hr 0. device.c:2513: Test failed: Expected foreground window 000301BA, got 0002004C. device.c:2888: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2892: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2915: Test failed: Failed to reset device, hr 0x88760868. device.c:2919: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2923: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3291: Test failed: Failed to reset device. device.c:3298: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3306: Test failed: Expected wndproc != 0x413100.

1 0

Re: winemac: WS_EX_DLGMODALFRAME shouldn't prevent the window being resizeable.
by Ken Thomases 13 Nov '14

13 Nov '14

Hi, On Nov 13, 2014, at 3:26 AM, Huw Davies <huw(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/window.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index e61a517..54bd56e 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -72,12 +72,12 @@ static void get_cocoa_window_features(struct macdrv_win_data *data, > if (ex_style & WS_EX_TOOLWINDOW) wf->utility = TRUE; > } > } > - if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > - else if (style & WS_THICKFRAME) > + if (style & WS_THICKFRAME) > { > wf->shadow = TRUE; > if (!data->shaped) wf->resizable = TRUE; > } > + else if (ex_style & WS_EX_DLGMODALFRAME) wf->shadow = TRUE; > else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) wf->shadow = TRUE; > } I think that's the correct logic, but it would be better to separate out setting resizable and shadow. The shadow stuff can be a single "if" with the conditions ORed together. Resizable can be a single "if" or even a simple assignment of a boolean expression. Thanks, Ken

1 1

RE: [PATCH] reg.exe: Modernise print functions
by Hugh McMaster 13 Nov '14

13 Nov '14

On Monday, 10 November 2014, Jonathan Vollebregt wrote: >> WCHAR msg_buffer[1024]; >No easy way to get the expected size and dynamically allocate the output I take it? >I looked into it before but besides _vscprintf (In msvcrt, which we're >not allowed to use) there doesn't seem to be a way to get the expected >output size besides perhaps growing the buffer over and over again until >it fits (Which seems inefficient for a simple printing function) One possible way would be to avoid using vsnprintfW() and pass everything through to output_vprintf(). static void __cdecl reg_printfW(const WCHAR* msg, ...) { __ms_va_list va_args; __ms_va_start(va_args, msg); output_vprintf(msg, va_args); __ms_va_end(va_args); } This would have the advantage of using FormatMessage() to allocate memory. But we would have to replace all format specifiers (four or five?) with their FormatMessage() equivalents. static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','x',' ',' ','d','a','t','a',' ','%','s','\n',0}; becomes static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','1','!','x','!',' ',' ','d','a','t','a',' ','%','2','\n',0};

3 4

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
by Henri Verbeet 13 Nov '14

13 Nov '14

On 12 November 2014 22:15, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > +{ > + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) > + ShowWindow(swapchain->device_window, SW_MINIMIZE); > +} This patch is mostly just blocked by the tests failing, but I'd also have to wonder if the window proc should be installed in the first place if the device is created with NOWINDOWCHANGES.

2 1

Re: [5/5] windowscodecs: Implement ComponentFactory_CreateMetadataReaderFromContainer.
by Alexandre Julliard 13 Nov '14

13 Nov '14

Vincent Povirk <madewokherd(a)gmail.com> writes: > From a3735fa76b9dc568f32561eda4617e216af82138 Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Wed, 12 Nov 2014 15:51:09 -0600 > Subject: [PATCH 5/7] windowscodecs: Implement > ComponentFactory_CreateMetadataReaderFromContainer. > > --- > dlls/windowscodecs/imgfactory.c | 101 +++++++++++++++++++++++++++++++++++- > dlls/windowscodecs/tests/metadata.c | 25 +++++---- > 2 files changed, 115 insertions(+), 11 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M windowscodecs.dll -p windowscodecs_test.exe.so metadata && touch metadata.ok metadata.c:953: Test succeeded inside todo block: unexpected count 1 make[1]: *** [metadata.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Get rid of "defined but not used" warnings on non-x86(_64) platforms
by Marvin 13 Nov '14

13 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10227 Your paranoid android. === w2000pro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:484: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:484: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00340000/00340001 exception: unhandled exception 80000004 at 00340000 exception.c:484: Test failed: 42: Wrong exception address 7751ED97/00340001 === w2008s64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 002C0000/002C0001 exception: unhandled exception 80000004 at 002C0000 exception.c:484: Test failed: 42: Wrong exception address 77E5ED97/002C0001 === w7u (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:484: Test failed: 42: Wrong exception address 77CDE34F/003D0001 === w8 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:484: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: [PATCH 6/6] ddraw/tests: Test focus loss style changes.
by Marvin 13 Nov '14

13 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10223 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 7256F329

1 0

Re: [PATCH 5/6] ddraw/tests: Test messages on focus loss.
by Marvin 13 Nov '14

13 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10222 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw1) === ddraw1: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 7256F329 === w8 (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 7256F329

1 0

Re: [PATCH 4/6] d3d9/tests: Test style changes on focus loss.
by Marvin 12 Nov '14

12 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10221 Your paranoid android. === w8 (32 bit d3d9ex) === d3d9ex.c:2354: Test failed: Expected device window style 0x4cf0000, got 0x14cf0000, i=2. d3d9ex.c:2358: Test failed: Expected device window extended style 0x100, got 0x108, i=2. d3d9ex.c:2358: Test failed: Expected device window extended style 0x100, got 0x108, i=3. d3d9ex.c:2385: Test failed: Expected device window style 0x14cf0000, got 0x34cf0000, i=3.

1 0

How to loop all server objects of type = socket?
by Bruno Jesus 12 Nov '14

12 Nov '14

Hi all, I'm wondering how to do some sort of loop to be able to check all currently opened sockets. If possible knowing the process which they belong to. Any hints are welcome. Best regards, Bruno

2 2

Re: [PATCH 2/6] wined3d: Minimize device windows on focus loss (v3).
by Stefan Dösinger 12 Nov '14

12 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The attached archives contains follow-up patches that implement resolution changes and add tests for CreateAdditionalSwapchain. I expect that many more small fixes will be needed for some games, similar in nature to patch 19. There are also problems in some window managers (read: those forked from Metacity)for which I haven't filed bugs yet. Am 2014-11-12 22:15, schrieb Stefan Dösinger: > Tests for d3d8 will follow after 107631 has been committed. > > v3: Check for D3DCREATE_NOWINDOWCHANGES. > > v2: Move to wined3d. The different behavior in d3d9ex was due to a > hidden window and not a difference how d3d9ex handles focus loss. See > patch 7. > > Another patch will add an action (resize the window to match the > backbuffer size) on window activation. For this reason the swapchain > helper function is called on both activation and deactivation. > --- > dlls/wined3d/device.c | 5 +++++ > dlls/wined3d/swapchain.c | 6 ++++++ > dlls/wined3d/wined3d_private.h | 1 + > 3 files changed, 12 insertions(+) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index ee3636e..0de444b 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4983,6 +4983,11 @@ LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL > } > else if (message == WM_ACTIVATEAPP) > { > + UINT i; > + > + for (i = 0; i < device->swapchain_count; i++) > + wined3d_swapchain_activate(device->swapchains[i], wparam); > + > device->device_parent->ops->activate(device->device_parent, wparam); > } > > diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c > index 25e2107..4c0948f 100644 > --- a/dlls/wined3d/swapchain.c > +++ b/dlls/wined3d/swapchain.c > @@ -1175,3 +1175,9 @@ void swapchain_update_draw_bindings(struct wined3d_swapchain *swapchain) > wined3d_resource_update_draw_binding(&swapchain->back_buffers[i]->resource); > } > } > + > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) > +{ > + if (!activate && !(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES)) > + ShowWindow(swapchain->device_window, SW_MINIMIZE); > +} > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 0f302c4..5f90e9a 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -2701,6 +2701,7 @@ struct wined3d_swapchain > > void x11_copy_to_screen(const struct wined3d_swapchain *swapchain, const RECT *rect) DECLSPEC_HIDDEN; > > +void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate) DECLSPEC_HIDDEN; > struct wined3d_context *swapchain_get_context(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > void swapchain_destroy_contexts(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > HDC swapchain_get_backup_dc(struct wined3d_swapchain *swapchain) DECLSPEC_HIDDEN; > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUY883AAoJEN0/YqbEcdMwU/EP/2AAyRwHeT/rJJt1ocC3EgSq ttCBQSjH0plrsm1y+zIfFJ6+iNFfXooO1ub3qC980Ub32v5EV7p9yUxbbvfpRt1T aF7kh5WDfbPvpkGdAKmSo7C3gCzHratuPxLokDIiHAKnqhsknFmIr6dwVfaYKqmd 1eoJghdpuapyQ5TiTblU54b6tuTLyWmyZlxDNHFUSQaBCLvC7pR5eXo7nvARwYLK ahP87S7htMA+rqudvctwkPNWEa7F3dSayWyLoOp6qW3abBwfpbBAWS9KEfCztc6i zAE6LOuVy9IWewmZ5j87DNZJmKSJj/tgMHhdJ5BHxEcyJALjdg4qSsgp9olFBkpm 0DXjc0qlqdrdFiNMPG2y5i6N5vMuT9srVgDEjFAW40dnu3aEPSqHmPqKhDVrAs8s Ci3G9mV4uDK4JNI/sWJd632yWaDHGNZSdZYETof3DaR6a6K8IMktG0vqBKrapZ2K RzWz8DEonbIx5W1mKQROr5Wj+0Qs5+AkeQoWbWFEYuubtU0oisp3evRCPtjCLXjB GSwObVGohUNdwiVonYCAXtu3C80HNYwMGObcoB7p9ok3RQc60e6gOb1RdshfTcvF e4oEWOHOdqmbtj8gqLftx1qsnwPmK4gHc6ho2KfXaAZTnQdkdeUw6VG+pkNUxwJb zj94p5A5sSlJEUTmCnyx =LNWo -----END PGP SIGNATURE-----

1 0

Re: d3d8/tests: Allow passing a resolution to reset_device (v2).
by Marvin 12 Nov '14

12 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10211 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2447: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2822: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2826: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2849: Test failed: Failed to reset device, hr 0x88760868. device.c:2853: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2857: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3225: Test failed: Failed to reset device. device.c:3232: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3240: Test failed: Expected wndproc != 0x412e90.

1 0

Re: dinput: Fix device type dump
by Michael Stefaniuc 12 Nov '14

12 Nov '14

Bruno, On 11/12/2014 02:06 AM, Bruno Jesus wrote: > Related to bug https://bugs.winehq.org/show_bug.cgi?id=35954 > > using a switch statement instead of the ?: chain of death looks IMHO nicer. You can even use a macro like the popular #define X(x) case (x): return #x to make it more concise and avoid copy and paste errors. > > diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c index > 0d61f57..2931832 100644 --- a/dlls/dinput/joystick.c +++ > b/dlls/dinput/joystick.c @@ -402,14 +402,30 @@ HRESULT WINAPI > JoystickAGenericImpl_SetProperty(LPDIRECTINPUTDEVICE8A iface, REF > > void _dump_DIDEVCAPS(const DIDEVCAPS *lpDIDevCaps) { + int type > = GET_DIDEVICE_TYPE(lpDIDevCaps->dwDevType); TRACE("dwSize: %d\n", > lpDIDevCaps->dwSize); TRACE("dwFlags: %08x\n", > lpDIDevCaps->dwFlags); TRACE("dwDevType: %08x %s\n", > lpDIDevCaps->dwDevType, - lpDIDevCaps->dwDevType == > DIDEVTYPE_DEVICE ? "DIDEVTYPE_DEVICE" : - > lpDIDevCaps->dwDevType == DIDEVTYPE_MOUSE ? "DIDEVTYPE_MOUSE" : - > lpDIDevCaps->dwDevType == DIDEVTYPE_KEYBOARD ? "DIDEVTYPE_KEYBOARD" > : - lpDIDevCaps->dwDevType == DIDEVTYPE_JOYSTICK ? > "DIDEVTYPE_JOYSTICK" : - lpDIDevCaps->dwDevType == > DIDEVTYPE_HID ? "DIDEVTYPE_HID" : "UNKNOWN"); + /* Directx > <= 7 definitions */ + type == DIDEVTYPE_DEVICE ? > "DIDEVTYPE_DEVICE" : + type == DIDEVTYPE_MOUSE ? > "DIDEVTYPE_MOUSE" : + type == DIDEVTYPE_KEYBOARD ? > "DIDEVTYPE_KEYBOARD" : + type == DIDEVTYPE_JOYSTICK ? > "DIDEVTYPE_JOYSTICK" : + type == DIDEVTYPE_HID ? > "DIDEVTYPE_HID" : + /* Directx >= 8 definitions */ + > type == DI8DEVTYPE_DEVICE ? "DI8DEVTYPE_DEVICE" : + type > == DI8DEVTYPE_MOUSE ? "DI8DEVTYPE_MOUSE" : + type == > DI8DEVTYPE_KEYBOARD ? "DI8DEVTYPE_KEYBOARD" : + type == > DI8DEVTYPE_JOYSTICK ? "DI8DEVTYPE_JOYSTICK" : + type == > DI8DEVTYPE_GAMEPAD ? "DI8DEVTYPE_GAMEPAD" : + type == > DI8DEVTYPE_DRIVING ? "DI8DEVTYPE_DRIVING" : + type == > DI8DEVTYPE_FLIGHT ? "DI8DEVTYPE_FLIGHT" : + type == > DI8DEVTYPE_1STPERSON ? "DI8DEVTYPE_1STPERSON" : + type == > DI8DEVTYPE_DEVICECTRL ? "DI8DEVTYPE_DEVICECTRL" : + type > == DI8DEVTYPE_SCREENPOINTER ? "DI8DEVTYPE_SCREENPOINTER" : + > type == DI8DEVTYPE_REMOTE ? "DI8DEVTYPE_REMOTE" : + type > == DI8DEVTYPE_SUPPLEMENTAL ? "DI8DEVTYPE_SUPPLEMENTAL" : + > "UNKNOWN"); TRACE("dwAxes: %d\n", lpDIDevCaps->dwAxes); > TRACE("dwButtons: %d\n", lpDIDevCaps->dwButtons); TRACE("dwPOVs: > %d\n", lpDIDevCaps->dwPOVs); bye michael

1 0

Re: [PATCH 5/5] d3d8/tests: Allow passing a resolution to reset_device.
by Henri Verbeet 12 Nov '14

12 Nov '14

On 12 November 2014 00:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2830,7 +2844,8 @@ static void test_window_style(void) > focus_rect.left, focus_rect.top, focus_rect.right, focus_rect.bottom, > r.left, r.top, r.right, r.bottom); > · > - hr = reset_device(device, device_window, TRUE); > + device_desc.flags = 0;· You have a whitespace error here.

1 0

Re: [PATCH 5/5] d3d8/tests: Allow passing a resolution to reset_device.
by Marvin 12 Nov '14

12 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10199 Your paranoid android. === w8 (32 bit device) === device.c:1181: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1226: Test failed: Reset failed, hr 0x88760868. device.c:1228: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1232: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1239: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1240: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1241: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1242: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1243: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1244: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1249: Test failed: Screen width is 640, expected 800. device.c:1250: Test failed: Screen height is 480, expected 600. device.c:1256: Test failed: Back buffer width is 640, expected 800. device.c:1258: Test failed: Back buffer height is 480, expected 600. device.c:1288: Test failed: Screen width is 640, expected 1024. device.c:1289: Test failed: Screen height is 480, expected 768. device.c:2447: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:2822: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2826: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2849: Test failed: Failed to reset device, hr 0x88760868. device.c:2853: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2857: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3225: Test failed: Failed to reset device. device.c:3232: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3240: Test failed: Expected wndproc != 0x412e90.

1 0

Re: [PATCH 2/2] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin 11 Nov '14

11 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10188 Your paranoid android. === w8 (32 bit script) === script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0

Re: [PATCH v2] cmd/tests: Add tests for 'del' (Fixes bug 35970)
by Marvin 11 Nov '14

11 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10186 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1367 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1368 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1369 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1370 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1371 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1372 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1373 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1374 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1376 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1379 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1380 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1383 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1384 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1385 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [PATCH 1/5] ddraw/tests: Rename modes and rectangles in test_coop_level_mode_set.
by Henri Verbeet 11 Nov '14

11 Nov '14

On 10 November 2014 23:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > ddraw = create_ddraw(); > ok(!!ddraw, "Failed to create a ddraw object.\n"); > > + memset(&param, 0, sizeof(param)); > + hr = IDirectDraw7_EnumDisplayModes(ddraw, 0, NULL, &param, test_coop_level_mode_set_enum_cb); > + ok(SUCCEEDED(hr), "Failed to enumerate display mode, hr %#x.\n", hr); > + ref = IDirectDraw7_Release(ddraw); > + ok(ref == 0, "The ddraw object was not properly freed: refcount %u.\n", ref); ... > + ddraw = create_ddraw(); > + ok(!!ddraw, "Failed to create a ddraw object.\n"); This seems odd, why do you recreate the ddraw object?

1 0

Re: [PATCH 4/5] d3d8/tests: Fix some wndproc comparison error messages.
by Marvin 11 Nov '14

11 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10175 Your paranoid android. === w8 (32 bit device) === device.c:1173: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1218: Test failed: Reset failed, hr 0x88760868. device.c:1220: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1224: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1231: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1232: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1233: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1234: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1235: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1236: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1241: Test failed: Screen width is 640, expected 800. device.c:1242: Test failed: Screen height is 480, expected 600. device.c:1248: Test failed: Back buffer width is 640, expected 800. device.c:1250: Test failed: Back buffer height is 480, expected 600. device.c:1280: Test failed: Screen width is 640, expected 1024. device.c:1281: Test failed: Screen height is 480, expected 768. device.c:2439: Test failed: Expected foreground window 000701B2, got 0002004C. device.c:2808: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2812: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2834: Test failed: Failed to reset device, hr 0x88760868. device.c:2838: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2842: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3209: Test failed: Failed to reset device. device.c:3216: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3224: Test failed: Expected wndproc != 0x412eb0.

1 0

Re: avifil32: Simplify comparing two unsigned ints (PVS-Studio) (try 2)
by Ken Thomases 10 Nov '14

10 Nov '14

On Nov 10, 2014, at 4:56 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > try 2: added the missing +1 thanks to a hint by ken on irc > --- > dlls/avifil32/avifile.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/avifil32/avifile.c b/dlls/avifil32/avifile.c > index 6295c7b..3d90e20 100644 > --- a/dlls/avifil32/avifile.c > +++ b/dlls/avifil32/avifile.c > @@ -466,9 +466,9 @@ static HRESULT WINAPI IAVIFile_fnDeleteStream(IAVIFile *iface, DWORD fccType, LO > /* ... so delete it now */ > HeapFree(GetProcessHeap(), 0, This->ppStreams[nStream]); > > - if (This->fInfo.dwStreams - nStream > 0) > - memcpy(This->ppStreams + nStream, This->ppStreams + nStream + 1, > - (This->fInfo.dwStreams - nStream) * sizeof(IAVIStreamImpl*)); > + if (nStream < This->fInfo.dwStreams) > + memcpy(&This->ppStreams[nStream], &This->ppStreams[nStream + 1], > + (This->fInfo.dwStreams - nStream) * sizeof(This->ppStreams[0])); > > This->ppStreams[This->fInfo.dwStreams] = NULL; > This->fInfo.dwStreams--; This is a more faithful refactoring of the original logic. However, looking at it some more, it looks like the original logic was wrong. It's removing an entry from the array and shifting the following entries up to fill the gap. There are This->fInfo.dwStreams - nStream entries from the nStream'th one to the end. There are only This->fInfo.dwStreams - (nStream + 1) entries that actually _follow_ the nStream'th one. The original logic read past the end of the array and this logic still does. -Ken

1 1

Wine Mono 4.5.4 Release
by Vincent Povirk 10 Nov '14

10 Nov '14

I have published version 4.5.4 of Wine Mono on sourceforge. Once again, it's been about a year since the last release. I really am trying to make these more frequent, but for various reasons it hasn't worked out that way. Due to some odd behavior in msi (or so I'm assuming, unfortunately I haven't had a chance to investigate in any detail), it is necessary to run 'wine64 msiexec /i wine-mono-4.5.4.msi' to install in a 64-bit prefix. Installing without the wine64 uses the 32-bit version of msiexec which somehow installs it alongside the default Wine Mono install instead of upgrading it. Any testing with .NET software (in particular .NET software that has been known to work before, if anyone knows of such a thing) would be appreciated. The source tarball is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.4/wine-mono-4.5… The binary is at https://sourceforge.net/projects/wine/files/Wine%20Mono/4.5.4/wine-mono-4.5… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 4.5.2: * Removed MonoGame. It was problematic because MG didn't have binary compatibility with XNA as a goal, I didn't have time to update from upstream, and the MS version of XNA was used anyway if it was installed, which it usually is. I may consider including a real XNA binary replacement if one appears, but for now I think it's better to work on making the MS implementation work. * It's no longer necessary to have gmcs installed to build from a tarball. Tarballs now include a build of Monolite for bootstrapping the compiler, which is the same thing the Mono project does with their tarballs. This was to avoid problems with old Mono versions not being able to bootstrap the current compiler. * A -l switch was added to build-winemono.sh, which fetches an official Monolite build and uses that to bootstrap the compiler. This is only useful if you are building from Git and don't have a sufficiently new gmcs to make this work. * The build will now abort if -t is specified and any tests fail to build. * The libmono build now specifies strict Dwarf2 debugging symbols, to keep it compatible with winedbg. * The libmono build now specifies static libgcc, to avoid linking errors on recent mingw. * We now use dllmap configuration to find MonoPosixHelper, which eliminates some diffs from upstream and will remove the need for Wine to mess with the PATH of .NET applications. * Added a Wine-specific implementation of System.Runtime.InteropServices.RuntimeEnvironment.GetRuntimeInterfaceAsObject and GetRuntimeInterfaceAsIntPtr. * Updated Mono to the master branch as of October 31, bringing in many changes including the following: * Fixed use of RVA fields pointing to zeroed static data that isn't physically in the PE file (improves managed C++ compatibility). * Added support for service processes using ServiceBase.Run. * It's now possible to change how debug output is printed via the embedding API, which will make possible a future change to Wine to send the output to the Unix stderr stream. * Beginnings of a System.Management implementation.

1 0

Re: [PATCH 3/3] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin 10 Nov '14

10 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10164 Your paranoid android. === w8 (32 bit script) === script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0

Re: [PATCH 1/3] mshtml: Ignore query and hash parts in res protocol handler.
by Marvin 10 Nov '14

10 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10163 Your paranoid android. === w2000pro (32 bit protocol) === protocol.c:144: Test failed: expected: 00000000 got: 80070716 protocol.c:255: Test failed: Start failed: 80070716 protocol.c:258: Test failed: expected ReportProgress protocol.c:259: Test failed: expected ReportData protocol.c:280: Test failed: Read failed: 80004005 protocol.c:144: Test failed: expected: 00000000 got: 80070716 protocol.c:255: Test failed: Start failed: 80070716 protocol.c:258: Test failed: expected ReportProgress protocol.c:259: Test failed: expected ReportData protocol.c:280: Test failed: Read failed: 80004005

1 0

Sourceforge says 1.5.22 is the latest version
by Rosanne DiMesio 10 Nov '14

10 Nov '14

Not really sure whose bug this is, but a user just pointed out that http://sourceforge.net/projects/wine/files/Source/ (which the source link at the bottom of our Downloads page leads to) has a line stating "Looking for the latest version? Download wine-1.5.22.tar.bz2 (21.2 MB)." The main project page, http://sourceforge.net/projects/wine/, also has a big green Download button for 1.5.22.tar.bz2.

4 3

Re: kernel32: add TRUST_E_NOSIGNATURE resource definition
by Alexandre Julliard 10 Nov '14

10 Nov '14

Austin English <austinenglish(a)gmail.com> writes: > @@ -281,8 +281,8 @@ msg : msgid sevfacsym { test_id($1); } bodies { $$ = complete_msg($4, $1); } > ; > > msgid : tMSGID '=' id { > - if($3 & (~0xffff)) > - xyyerror("Message ID value out of range (0x%08x > 0xffff)\n", $3); > + if($3 & (~0xffffffff)) > + xyyerror("Message ID value out of range (0x%08x > 0xffffffff)\n", $3); There shouldn't be any need to change the message compiler, there are severity/facility message options. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Move IME Window Procedure to user32
by Piotr Caban 10 Nov '14

10 Nov '14

Hi, could you please give me any hints related to this patch? The way how imm32 is loaded or not is quite strange in it. It's generally matching native behavior but I'm not sure if it's needed here. I also don't see a nice way of testing it inside wine test suite. Thank you, Piotr

2 4

Re: [PATCH] reg.exe: Modernise print functions
by Jonathan Vollebregt 10 Nov '14

10 Nov '14

> WCHAR msg_buffer[1024]; No easy way to get the expected size and dynamically allocate the output I take it? I looked into it before but besides _vscprintf (In msvcrt, which we're not allowed to use) there doesn't seem to be a way to get the expected output size besides perhaps growing the buffer over and over again until it fits (Which seems inefficient for a simple printing function)

1 0

RE: [PATCH v3 04/10] reg: Add sane_path function to do preliniary key validation
by Hugh McMaster 10 Nov '14

10 Nov '14

On Saturday, 8 Nov 2014 11:26:45 +0100, Jonathan Vollebregt wrote: >+static LSTATUS sane_path(const WCHAR *key) >+{ >+ if (key[0] == '\\' && key[1] == '\\' && key[2] != '\\') >+ return ERROR_NO_REMOTE; >+ >+ return ERROR_SUCCESS; >+}Where are you handling (invalid) keys beginning with backslashes, e.g.: \\HKEY_CURRENT_USER\\Console? Windows only allows two consecutive backslashes at the beginning of a key. >+ if (key[0] == '\\' && key[1] == '\\' && key[2] != '\\') HKEY... --> ERROR_SUCCESS \HKEY... --> ERROR_SUCCESS !!! \\HKEY... --> ERROR_NO_REMOTE \\\HKEY... --> ERROR_SUCCESS !!! Those two marked with !!! need to be handled. Do you do this in a later patch? -- Hugh McMaster

2 2

Re: [PATCH 2/2] user32/tests: Test exception handling for timer callbacks. (try 2)
by Marvin 10 Nov '14

10 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10156 Your paranoid android. === w7u (32 bit msg) === msg.c:12189: Test failed: unexpected hwnd 0018014A

1 0

Re: [2/2] wined3d: Take abs() of vertex z coordinate as FFP fog coordinate (try 5)
by Matteo Bruni 09 Nov '14

09 Nov '14

2014-11-06 21:51 GMT+01:00 Joachim Priesner <joachim.priesner(a)web.de>: > Take the absolute value of vertex.z as fog coordinate instead of just > the z coordinate. This fixes e.g. fog for applications that use > right-handed projection matrices. > > Also test the clamp behavior of the oFog vertex shader output. > > Tested on openSuse 13.1 and Windows 8.1 (VMware Player). > > Try 5 that fixes a test failure I overlooked. > --- > dlls/d3d8/tests/visual.c | 296 +++++++++++++++++++++++++++++++++++++ > dlls/d3d9/tests/visual.c | 360 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw7.c | 161 ++++++++++++++++++++ > dlls/wined3d/glsl_shader.c | 2 +- > 4 files changed, 818 insertions(+), 1 deletion(-) > > diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c > index 163110c..a1eabcd 100644 > --- a/dlls/d3d8/tests/visual.c > +++ b/dlls/d3d8/tests/visual.c > @@ -696,6 +696,301 @@ done: > DestroyWindow(window); > } > > +/* This test tests fog in combination with negative vertex z coordinates. */ > +static void fog_negative_z_test(void) > +{ > + enum > + { > + C_ALPHA_0x00 = 0x00000000, > + C_CLEAR = 0xffff00ff, > + C_FOGGED = 0x0000ff00, > + C_HALF_FOGGED = 0x00808000, > + C_UNFOGGED = 0x00ff0000, > + C_CLAMPED_FOG = 0xdeadbeef /* triggers special codepath when used as middle_color */ > + }; > + > + /* Fill the null-shader entry with the FVF (SetVertexShader is "overloaded" on d3d8). */ > + DWORD vertex_shader[3] = {D3DFVF_XYZ | D3DFVF_DIFFUSE | D3DFVF_SPECULAR, 0, 0}; > + DWORD pixel_shader[2] = {0, 0}; > + IDirect3D8 *d3d; > + IDirect3DDevice8 *device; > + BOOL has_vs_support, has_ps_support, has_table_fog_support; > + unsigned int i, ps, y; > + D3DCOLOR color, expected_middle_color; > + ULONG refcount; > + D3DCAPS8 caps; > + HWND window; > + HRESULT hr; > + > + /* Basic vertex shader without fog computation ("non foggy") */ > + static const DWORD vertex_shader_code1[] = > + { > + 0xfffe0100, /* vs_1_0 */ > + /* output.Pos.z = input.Pos.z * 0.5 + 0.5 */ > + 0x00000005, 0x80010000, 0x90aa0000, 0xa0000000, /* mul r0.x, v0.z, c0.x */ > + 0x00000002, 0xc0040000, 0x80000000, 0xa0000000, /* add oPos.z, r0.x c0.x */ > + /* output.Pos.xyw = input.Pos.xyw */ > + 0x00000001, 0xc00b0000, 0x90e40000, /* mov oPos.xyw, v0 */ > + /* output.Color = input.Color */ > + 0x00000001, 0xd00f0000, 0x90e40001, /* mov oD0, v1 */ > + 0x0000ffff, /* END */ > + }; Where are you setting the value of c0 in the d3d8 test?

3 3

Re: [PATCH v3 08/10] reg: Add wchar/raw data conversion functions
by Stefan Dösinger 09 Nov '14

09 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, The first 7 patches look worthy of Alexandre's review. Don't resend this yet, I'd suggest to wait for Alexandre's opinion first. Am 2014-11-08 11:26, schrieb Jonathan Vollebregt: > + static const WCHAR empty = 0; You could make this on the global scope, call it empty_wchar (or empty_string or something similar) and use it to replace the RegDeleteKeyA with RegDeleteKeyW. That's only a minor style suggestion though, not a requriement. > + FIXME("Check for integer overflow.\n"); Print this only if i == UINT_MAX. If i is smaller you know no overflow has happened. > + if (0) > + return ERROR_ARITHMETIC_OVERFLOW; > ... > + case ERROR_NOT_NUMBER: > + reg_message(STRING_NOT_INT_OR_NEG); > + return; > + case ERROR_ARITHMETIC_OVERFLOW: > + reg_message(STRING_ERANGE); > + return; I don't like the dead code. It also seems that native prints the same error message in both cases, so you don't need to separate between underflows, overflows and strings that are not numbers. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXiejAAoJEN0/YqbEcdMwWTsP/2HaBgIt6J3EqvC+jpj42MPs tgHXaZ/lhLxUTtHCcnSzsrVt5zmVN7AOnET54KQFHjbY2OoEcT9PpDDjW/9LVGTc dj0ciXNpOLuo6MdYWbjmTMtIFVBPMISSYJks2FxvZ1peYa5g+dQQZ6blHWzlcA1k dLK7UHPeh5kyHACgbr3i0wdL9CNeQ9pafWCUtpnZwxHbXVWlOB1XRZZumKg7snz8 QyLDJylKzYZEJ6CBjU5YxZKl/NXrCoiHplhkF8Tddl8Xmh+AqpWnvMwsWBbiFgXC ZybdSnHY0vvCojJPb9dYpscbY2uy2Xjap2t8a61xlI288/Tz+8tvnm3qkd99i13w S9Tf2TGmhHKN1DG/ljnvALRh9JTYH20jFf/lvgZOApew4iyuHWHsLKdjp9LvpwGW ogIpBHT+kpNPSHuPgbHm9lK/k2OAYBGUZqbH2c0bznQdVWUqEABdR/cMM/wVjYbs LpUdstKs2oLbhr2gxvLkX0C3f4zdowetYnlnynuL1S+krcAKeQgPxE14MtwKeX49 rYeT931uOvhYi9Dh8a0DU8FTVfI9DKAbRfcBRt81AgJ6zymDC050s2MkELZTyDod WhPrkpXV/FUOsn2Sef0yxI78XtgbaaGEUIdBz9rThVvJNy4Wrw7zA2MICUhgEQe1 S5rqOajVwtKqqjX0JeJJ =CJwM -----END PGP SIGNATURE-----

2 2

Re: [PATCH] vbscript: Implemented String(try 4)
by Marvin 09 Nov '14

09 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10122 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Ideas for simplifying tabular UTF-7 tests?
by Alex Henrie 08 Nov '14

08 Nov '14

Hi, I have two patches for adding tabular UTF-7 tests at https://github.com/alexhenrie/wine/commits/master However, before I submit them to wine-patches, I'd like to ask for wider feedback. Sebastian Lackner has commented: * too many values for each test, difficult to maintain, and looks redundant * initializing big structures on the stack should be avoided The problem is that I don't see a good way to simplify this any further: * The chars_written variable (number of characters actually written) cannot be eliminated and determined implicitly from the len and dstlen variables alone. See the second-to-last encoding test case, where len is 0 and dstlen is 4, but chars_written is 3. * The dst variable (destination buffer) is almost always set to the output variable, but one test requires dst to be NULL. * These are just tests, so I'm not worried about complicating the code in order to improve performance. I've tried replacing chars_written and dst with a set of flags (ONE_NOT_WRITTEN and NULL_DST) and corresponding if statements, but this looks ugly to me. Furthermore, removing the output variable from the table obscures the reason why dstlen is usually set to sizeof(output) - 1. All in all, I think that writing out all the parameters explicitly is the most intuitive way to go. What do the rest of you think? How would you write this code? -Alex

1 1

Re: msvcp90: Add std_Ctraits::Isnan implementation.
by Nikolay Sivov 08 Nov '14

08 Nov '14

On 11/4/2014 11:22, YongHao Hu wrote: > --- > dlls/msvcp90/math.c | 9 +++++++++ > dlls/msvcp90/msvcp90.spec | 6 +++--- > dlls/msvcp90/tests/misc.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+), 3 deletions(-) > > > > You need to update msvcp80.spec too.

2 1

Re: [PATCH v2 6/8] reg: Add wchar/raw data conversion functions
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-07 17:29, schrieb Jonathan Vollebregt: > + if (input[0] == '0' && (input[1] == 'x' || input[1] == 'X')) > + i = strtoulW(input, &temp, 16); > + else > + i = strtoulW(input, &temp, 10); > + > + if (input[0] == '-' || temp[0] || temp == input) > + return ERROR_NOT_INT_OR_NEG; Please add tests for a valid DWORD value >= 0x80000000 and a test with a value > 0xffffffff. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXTDPAAoJEN0/YqbEcdMw02oP/1mjnMjeqJQY3jUE6KpOUJ2c xi6mFcxcP1p9j6UfpAqVr2Ho+7Qdc3t+JR0++TYqONZw5u8PXMMYBCTbP5DcGnRq 3BuE0a9XKj+0WBsUqqfi3RDz/VXdmlHpRk28NTKtzQETnEJ9h+au6Afhivz/j23v q/SkQrrElU3DEuaYE++0nChLseLnzc2W9LoU6ltNxCEOgvWB5jNz2pQdPg1c9USp AFvkXCJbLe8H70wkRlK3soSBA1i0fB6aZShA1rnAg93VnIeprQJH38j4Aua4CBmA iZ+1mrxn2rTBxPJnyceJ68pcxT8XV8EPqRmuK9DXneMYJfW1xHS37ehOvMIKmOQ3 RjsLfZ1pV/+QPVKEWHIrNY1YIY88e1wzJmrZatygzmw0OEIzk4FP52rSrEDEhudD Ue9iddJ6gvfFl8oRT33/mJ8ss9ITr56QU9wwXo8AtnQwP1gK4GSu9tfUkgbQHfbX rrF/MaVAFNRSspxR3uO41Gr4X9zwtW0ghSFrEUDNkG0ijZ8VvOgVczmGS7x45Mh6 6TAtS1qe1+zzGhORa8VJI/VvgeD7wuLS+f+BSwB/ONp51RDJaWvPs8lGRXp5Bqzz 1FXowdYyXqX+8iaEBNzlawvbIYHKWYsdeAR2big9dXIpYSFJKgBugTeOkT1v2FA2 OxLaUmdTYdK3/ItWvsPR =yNQY -----END PGP SIGNATURE-----

1 0

Rocksmith ALSA patches test
by Luke A. Guest 07 Nov '14

07 Nov '14

Hi, I just built 1.7.29 on Gentoo with all 6 patches. I ran the game from the start, new profile, beginner, etc. So far, it seems stable, but there is a lot of noise when the guitar is not in use. Also, tuning is difficult, as the game is not responding as quickly as it should, pluck then wait until the tuner moves. This is also a problem when doing that first "Aerosmith" riff at the start. If there is anything you want me to test, I can, just email me. Thanks for the hard work, Luke (and future users of said work :D)

1 0

Re: [PATCH 4/5] mmdevapi: add property for device path
by Bruno Jesus 07 Nov '14

07 Nov '14

On Fri, Nov 7, 2014 at 12:58 PM, Mark Harmstone <hellas(a)burntcomma.com> wrote: > --- > dlls/mmdevapi/devenum.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Hi, I can't tell if your patch is right or wrong, what I can say is that you are using C++ comments in this patch, they are not allowed in wine, please switch to /* */. Best regards, Bruno

1 0

Re: [PATCH] winealsa: fix input sound distortion and heap corruption
by Andrew Eikum 07 Nov '14

07 Nov '14

On Fri, Nov 07, 2014 at 04:06:55AM +0000, Mark Harmstone wrote: > At present, winealsa attempts to call map_channels when a capture > device is opened. If a microphone can be opened in either stereo or > mono mode, and mono is requested, Wine will still return stereo > data. Not only does this result in distorted in audio, it also very > frequently results in heap corruption when snd_pcm_readi overruns > the buffer allocated by the program. > Thanks for fixing this. The patch doesn't apply because it got mangled in transit: http://source.winehq.org/patches/data/107529 The idea look OK to me, but don't we want to disable channel remapping for _all_ capture devices? Your patch only disables it if the application is using WAVE_FORMAT_EXTENSIBLE I don't think we can do capture channel remapping reliably without switching to the new ALSA channel mapping API. So it makes sense to disable it entirely for now. Andrew > I don't have a copy of World of Warcraft to test this on, but this > may also fix bug 31684. It's the same symptoms, at least. > > --- > dlls/winealsa.drv/mmdevdrv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c > index a4c02bf..91fba2f 100644 > --- a/dlls/winealsa.drv/mmdevdrv.c > +++ b/dlls/winealsa.drv/mmdevdrv.c > @@ -1164,7 +1164,7 @@ static DWORD get_channel_mask(unsigned int channels) > > static HRESULT map_channels(ACImpl *This, const WAVEFORMATEX *fmt) > { > - if(fmt->wFormatTag == WAVE_FORMAT_EXTENSIBLE || fmt->nChannels > 2){ > + if( (This->dataflow != eCapture && fmt->wFormatTag == > WAVE_FORMAT_EXTENSIBLE) || fmt->nChannels > 2){ > WAVEFORMATEXTENSIBLE *fmtex = (void*)fmt; > DWORD mask, flag = SPEAKER_FRONT_LEFT; > UINT i = 0; > -- > 2.0.4 > >

2 2

Re: [PATCH 6/8] reg: Add wchar/raw data conversion functions
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-06 22:17, schrieb Jonathan Vollebregt: > +static LSTATUS wchar_get_data( const WCHAR *input, const DWORD type, > + const WCHAR separator, DWORD *size_out, BYTE **out) This whitespace use is a bit weird. Is there a precedent for it? > + ** (DWORD **) out = i; The space between ** and ( is a bit odd too. > + /* If it's the first character or the previous one was a separator */ > + if (!p || temp[p - 1] == 0) > + { > + HeapFree(GetProcessHeap(), 0, temp); > + return ERROR_BAD_COMMAND; > + } What does advapi32 do if you have empty substrings? (I.e., the same question as with the trailing backslashes: Does this code belong into reg.exe or advapi32.dll?) If advapi32 returns an error you can probably use it instead of the internal ERROR_NOT_INT_OR_NEG. > + *out = HeapReAlloc(GetProcessHeap(), 0, temp, p * sizeof(WCHAR)); Technically this could fail. But I don't think it is necessary - the compiled code for the HeapReAlloc invocation takes probably more space than the few bytes you're freeing a little bit earlier. > + return ERROR_SUCCESS; > + } > + case REG_BINARY: > + { > + BYTE * temp = HeapAlloc(GetProcessHeap(), 0, strlenW(input)); Inconsistent style. > + case REG_BINARY: > ... > + return ERROR_BAD_COMMAND; Does native write different error messages for a negative DWORD, improperly separated REG_MULTI_SZ and invalid REG_BINARY? > + *out = HeapReAlloc(GetProcessHeap(), 0, temp-odd, p); MSDN says the third parameter has to be a pointer returned by HeapAlloc or HeapReAlloc. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXLpiAAoJEN0/YqbEcdMwEB4P/R4usEhK7b6woRAHZWXh3oSg UfhpgUpQQELq0nw2WMQrVtkhwvcJywSAkaI/MPyB0vDR6DScqTrcDe2j78yIyMiY DWJ24q+Xfix84fiOfSKbMWJZMAcZnCfn0pliwN/TjfzjOLdAZc6B0fO84wEJfHLL DstJzYgzANg1u3FZJtNpAgex2PpU8MpyATXqbvoZdPhJO3MCwuD9KVzqHgoGupbI A1BIfLWTE3ZHj+x8ygGOQcG4uhcsxWJQu+ygKvoDxGkjfQcQ1gEa9KOmWENDUj+Y 8eT+Ghzn+B7Ekl6RjgKGtNJKgVycwPqWJwR0JgWKRVlkeGrAfl6RNerAPwTODHj0 S+vmYeo6ZtrmHluagnP/hk2SB0yr6DmUITdhfE7LpMKAGutQ32PN1n5eDKpGHrez LWcvJ1beLCEVZk2fJe1r7pqZtMWPIu1wJmla+NyS/7UOuagHcskINm3cSsqNApRn ujMNALDGYozDhMl5/QJi9TJaqcwB2iRocDppkB75XnpcgLuKIION3KNi3jEhsBF8 DMIIF6/cPPFMSqvsoMcaFgm1CIz+AP5yo0LSfR/Rb2RGh+nhWFmBcNyLO6/bIWih D2ebrfCfq+SEzS/bqm3zoAXwShw3464xNuU/m9N8eF7erwUY8o2TDn+XwtXaoOlF kBkaNk8deBwwhIjLG6Pm =wFNB -----END PGP SIGNATURE-----

2 1

Re: [PATCH 8/8] reg: Clean up reg_delete
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-06 22:17, schrieb Jonathan Vollebregt: > + FIXME("Trying to delete a root key is a bad > idea.\n"); I'd phrase this as FIXME("Deleting root keys is not implemented\n"); or similar. That makes it clear that there's something in our code that needs improvement. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXMIXAAoJEN0/YqbEcdMwId4P/iDoiGb5zkUHmHICCUGtgQRY h1xl20pabBDu6CVqGfvGxEVAPvWiRU3NHGv/ZmhH7TIv/1bjiFQjPjGlHoxOQmQY +FJspMCbaYfc63pCUh0Z0ogAUImef3yDf+DPYG4ybNgm5mqn8dR8hqpuUeyw2IIa NINo8JvZAd3markcKo8nOnGtrPukAGMbROOBvbkszWJSAiFU4jLMNyGpRcnwmuer ks2Y6sx2GyAAcuIGhIk4LUQegMzltIU+pEpEqffMNqbpqJ9nCd40PNcXCa2Wu9F6 o5ld2Pxfjp5kn/3t0V2zOVfkpRWZJw8+tba9eVUSN3MheV/DNKnbwdF46au8dLsQ shvfFyPugamA0zOKIbY3RJynlUSo8Gj8rLlT9rMX/qrF7WVIVQcFj0/pywmMUN3z fg7CnYDQSglHMVueXUmeHIZrvA9cXJHcDAs31wZbxs72EWnpa4lDnHOgMto5GydB 6cCw/2dw1DHE4BY/xsQNXFJKN+w5fRjkZXgXAEig7R0CTceGHPXjx4xAx/L7L83E 3z/HIv+K/oZ18wCg4y9R/X3fEnLyVR1d5EWcYQjpJ3KbvUloBUEbjeJi+pC9EBHN ilt2/KD3EUW9FAz072VlGcnYCQ1gx2h+II8q2SE3vwTQqyM458c708URJXnnnAyG RKG8p5SmURsRIQ1hiXjc =SPe6 -----END PGP SIGNATURE-----

1 0

Re: [PATCH 5/8] reg: Add wchar/type conversion functions
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2014-11-06 22:17, schrieb Jonathan Vollebregt: > + {REG_NONE, type_none}, An idea for a future test: Test if REG_NONE does anything useful. That's not a blocker for this patch though. > +static DWORD wchar_get_type(const WCHAR *type_name) > { > ... > + for (i = 0; i < ARRAY_SIZE(type_rels); i++) > + { > + if (!strcmpiW(type_rels[i].name, type_name)) > + return type_rels[i].type; > + } > > return -1; > } > ... > if (reg_type == -1) Dmitry shout at me, but ~0u would be better since DWORD is unsigned. If REG_NONE doesn't do anything useful you could use REG_NONE for this purpose. That's just a suggestion though, ~0u is fine for me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXLWtAAoJEN0/YqbEcdMwfVEP/Ap54MfEFnTiDeM9g7/ps9Gf 41SSLz0IJLgNf+UZlifdS1jajIL7lYM6jo91skiJXPfu36kdQeGvOEwJJhCmrPH3 lvdDMetjOKj6Zx7eoawYIi1ZhUSavp6ZMeLT0zBjdzHN14fHZHlccVnw/Jmb/Gd6 zq04scw0wRenWHobb69eW6dAQXy1N9bz9o9wavA6wvVKWo+k5EMSfJB+F3wGMJHN M8/eENJLBbZcpig2Rrlu8xUG1qVHjT01rjmwEJKAl83nj0cfrvWsudm6addZFL/H mLRjJfvZcLe9qBs8gUNtzgdDNqRCjuRjHHcV7qhn7TV/VsHLr68vuvLmLrbDX/vE G9x6jbA9C/Ob8L1QyMTeJyE2aCfVklHGuGpiS8NmzLNT974tllWTnXgA9tkeXQNC xt/hEoHXlTW9o+Dv70XLbdf6Y2Cw6rrDFGRDvUUAjTGPyRG6R8zTv1Jex4KkxJiH 8/cgm552PU2SIoqNneXbQswbJ7OOGwgi64J24YzfD8x2IpT4FaIqpXqZ0dGh00iO Y/XbA57yA8gi9hRrP2xC8WODHJBctRizhW9JCRKZp4jDb3/gKoK35WWSNY3jlku5 8/fTCv94gHv+K08GH4XdJ+Zm5nSjSLhjCkx0R3KwKuf5ansmPzmSysjEqfjQs8es RcGjE3c16jM532UVuHa8 =Cjz7 -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/8] reg: Add sane_path function to do preliniary key validation
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-06 22:17, schrieb Jonathan Vollebregt: > diff --git a/programs/reg/tests/reg.c b/programs/reg/tests/reg.c > index f93df55..57e0108 100644 > --- a/programs/reg/tests/reg.c > +++ b/programs/reg/tests/reg.c > @@ -129,10 +129,10 @@ static void test_add(void) > ok(err == ERROR_FILE_NOT_FOUND, "got exit code %d\n", r); > > run_reg_exe("reg add HKCU\\" KEY_BASE "\\keytest2\\\\ /f", &r); > - todo_wine ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), > + ok(r == REG_EXIT_FAILURE || broken(r == REG_EXIT_SUCCESS /* WinXP */), > "got exit code %u\n", r); > err = RegDeleteKeyA(HKEY_CURRENT_USER, KEY_BASE "\\keytest2"); > - todo_wine ok(err == ERROR_FILE_NOT_FOUND || broken(err == ERROR_SUCCESS /* WinXP */), > + ok(err == ERROR_FILE_NOT_FOUND || broken(err == ERROR_SUCCESS /* WinXP */), > "got exit code %d\n", r); > > run_reg_exe("reg add HKCU\\" KEY_BASE "\\keytest3\\ /f", &r); I think this part should be moved into the next patch. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXK9OAAoJEN0/YqbEcdMwonwP/j9INboZdEyYIP9ShVkn3W/U vK0kn4R+dzlMsoHrxyQI8037A8SnppqFj6QcvaPBmgj682srl0NdWKlPZPYPYOp5 DVmio9kN4w3KtZ9Oezs+mMXEUTHJ4sSE1fHOkn3TujqCLqKT3Ek6ANl8yFuTUWYz 27Usan0HPlW3oMGgyhTgdltE/v0Q3ObHXMvhoKsYI9lWSHEA1stjtk0CSUMe6mdG hE2ftJb2+nhVoFckNf9IcFMaIj6Ctizi7+oLU6bUNwl4zYN5sClyQto/YwPG6n1x zRARhrDYE+2g8N7dgkdBv8v98sCe8F8O6rMIz98BcE75sof3sNxCeiHqKqhFGkMP KWe6OHungsXxNy/tA/RzB6mKTL334KBwFrGz+qsdHB/ikj0mD8ykrY0aWnPmAw4K GqxpFFMl2AFe3p65cTzZP9TQ2QpiMZt5nkZbqdSABP4nqrUsYEhnact95KrBu8R0 Lcq9ahxgs1R76BRWnfu1VoNVPKyJK6iTiXoKmUbvS8CMhq/CW9rZs5GCKzso/oSY c1wt5Lgc5ZBFUaBMhK3fdSQbfw33iTpCqLbrERarrvD0SMUvvKrN4sBYE/4pFaEU JkGnNb02YB1SrLKOE7TkMZOc9npfk/aLPEfH7q0UCmYqN2wKidMaEk9rdINm5l0S i8KHvSnvIWXixdOcN00z =a//X -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/8] reg: Add system error printing function
by Stefan Dösinger 07 Nov '14

07 Nov '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-11-06 22:17, schrieb Jonathan Vollebregt: > +static int reg_print_error(LSTATUS error_code) As mentioned yesterday this doesn't need a return value. > + FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER, NULL, > + error_code, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (WCHAR *)&message, 0, NULL); > + > + reg_message(STRING_ERROR); > + reg_printfW(error_string, error_code, message); > + HeapFree(GetProcessHeap(), 0, message); http://msdn.microsoft.com/en-us/library/windows/desktop/ms679351(v=vs.85).a… says FormatMessage uses LocalAlloc to allocate the buffer. You need to free it with LocalFree. I don't know if we have any rule for checking the return value for FormatMessage here. You are already in an error printing codepath, and if you print an error every time printing an error fails you'll never stop. Otoh it seems questionable not to check the return value. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUXK8aAAoJEN0/YqbEcdMwxuoP/RGyxXJoVN5h8Quj3L5HFGb+ Fg3xah51LzRJzQFirZ7yF13OVoZiGg7om4eAlo/eSAy1Ae/jzGxodg7PKEU7DXX/ 3s2TYE9TrkPJClt2hFq1asGoAI1uezNDJybwSXBxEgRAkUzBBhBh+9XEKffZz3iE OWpyHyCOQBwHPBq3krLP+joADngT13UfEvvrccNobvYb47WMBddJ70UdD+sYeF/i fbbYMdnhIKowbe26xCVwSDN5huXMq1f9zYuqkJwL6BRmkgD5FiwYdo8zXu2BvpEq ZkFwxUjCXFRJ7nwLAly5lNSCA1MMFD/Whwd5PxbMmVCwWK3nhqknxQdJJJIy95vd e2JeSwk/4ELavjXubMGAH5D7QfTnveO/ji/kZCWB2buN30ht5ORRH6bjupL/zIr4 hhh4HJ/6EdHhWJfffenmM9uGxN8zNO6HmVSHVnXn90QnSousjuNkFymfr9RkWycr kmjPJQw8inoEl0zmeMiDdu+Kxo9MHX7SAwAHi9OzYeU2aka8LTOASn0mmKM+GBeO 9uaJbQAa/ILzWkFaYY/C+lgnyJgjgY6+fFj1O+DFlXh4DnaZ1DXMrn4+3WrUDWQk 3cFD0/6ehVBuUouEY8dF0yDiWPO9cwTEe7S5G9u03rS72H6mRfRP8mJVI6ZVPwbU 7wj5TGWDXCcDiRHd46UI =abxe -----END PGP SIGNATURE-----

1 0

Re: [PATCH] vbscript: Implemented String(try 3)
by Piotr Caban 07 Nov '14

07 Nov '14

On 11/07/14 04:36, Shuai Meng wrote: > used mod other than division when the second argument(length of > string) is grater than 256; Your test was already showing that it doesn't work this way. You will probably need to use MultiByteToWideChar function here. + case VT_ARRAY|VT_BYREF|VT_VARIANT: + return DISP_E_TYPEMISMATCH; + default: + hres = to_short(arg + 1, &tmp); There's no need to handle VT_ARRAY|VT_BYREF|VT_VARIANT case separately. It will be done by to_short function. Thanks, Piotr

1 0

Re: shell32: Simplify check for empty string (PVS-Studio)
by Alistair Leslie-Hughes 07 Nov '14

07 Nov '14

On 07/11/14 20:22, Michael Stefaniuc wrote: > --- > dlls/shell32/shellord.c | 2 +- > dlls/shell32/tests/ebrowser.c | 2 +- > dlls/shell32/tests/shlfolder.c | 14 +++++++------- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c > index 56c9fe9..914dc5a 100644 > --- a/dlls/shell32/shellord.c > +++ b/dlls/shell32/shellord.c > @@ -947,7 +947,7 @@ void WINAPI SHAddToRecentDocs (UINT uFlags,LPCVOID pv) > /* buffer size looks good */ > ptr += 12; /* get to string */ > len = bufused - (ptr-buffer); /* get length of buf remaining */ > - if ((lstrlenA(ptr) > 0) && (lstrlenA(ptr) <= len-1)) { > + if (ptr[0] && (lstrlenA(ptr) <= len-1)) { You are changing tabs to spaces here. Best Regards Alistair Leslie-Hughes

2 1

Re: [PATCH] vbscript: Implemented String(try 3)
by Marvin 07 Nov '14

07 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10094 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] d3d8/tests: The device restores the mode settings from the registry (v5).
by Marvin 07 Nov '14

07 Nov '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10090 Your paranoid android. === w8 (32 bit device) === device.c:1173: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1218: Test failed: Reset failed, hr 0x88760868. device.c:1220: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1224: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1231: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1232: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1233: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1234: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1235: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1236: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1241: Test failed: Screen width is 640, expected 800. device.c:1242: Test failed: Screen height is 480, expected 600. device.c:1248: Test failed: Back buffer width is 640, expected 800. device.c:1250: Test failed: Back buffer height is 480, expected 600. device.c:1280: Test failed: Screen width is 640, expected 1024. device.c:1281: Test failed: Screen height is 480, expected 768. device.c:2441: Test failed: Expected foreground window 000B00F8, got 0002004C. device.c:2813: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2817: Test failed: Expected device window extended style 0x108, got 0x100. device.c:2839: Test failed: Failed to reset device, hr 0x88760868. device.c:2843: Test failed: Expected device window style 0x14cf0000, got 0x4cf0000. device.c:2847: Test failed: Expected device window extended style 0x108, got 0x100. device.c:3215: Test failed: Failed to reset device. device.c:3222: Test failed: Expected {0, 0, 1024, 768}, got {0, 0, 512, 384}. device.c:3230: Test failed: Expected wndproc 0x412ed0, got 0x412ed0.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel