- wine-devel - winehq.org

Re: typo fixes - rebased
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6332 Your paranoid android. === w2000pro (32 bit msg) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: user32: Fix DrawMenuBar test failures (try2)
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6341 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] ole32: PropVariantClear should always reset contents of the passed in PROPVARIANT.
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6360 Your paranoid android. === w2000pro (32 bit propvariant) === propvariant: unhandled exception c0000005 at 779DB8A8 === w8 (32 bit propvariant) === propvariant: unhandled exception c0000005 at 7527DF57

1 0

Re: [2/3] ole32/tests: Add more tests for PropVariantClear.
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6359 Your paranoid android. === w2000pro (32 bit propvariant) === propvariant: unhandled exception c0000005 at 779DB8A8 === w8 (32 bit propvariant) === propvariant: unhandled exception c0000005 at 7527DF57

1 0

Re: kernel32: Add a workaround for broken apps that pass negative values to ReadConsole. Take 2.
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6357 Your paranoid android. === w8 (32 bit console) === console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244

1 0

Re: user32: Fix DrawMenuBar test failures (try2)
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6341 Your paranoid android. === w2000pro (32 bit msg) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: [PATCH 2/2] msvcr90: Share the source code with msvcrt
by Alexandre Julliard 16 Apr '14

16 Apr '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcr90/Makefile.in | 32 +- > dlls/msvcr90/msvcr90.c | 199 ---- > dlls/msvcr90/msvcr90.spec | 2418 > ++++++++++++++++++++++----------------------- > dlls/msvcrt/Makefile.in | 2 +- > dlls/msvcrt/main.c | 4 + > dlls/msvcrt/msvcrt.h | 1 + > 6 files changed, 1245 insertions(+), 1411 deletions(-) > delete mode 100644 dlls/msvcr90/msvcr90.c It doesn't build on Mingw: In file included from ../../../wine/dlls/msvcr90/../msvcrt/cpp.c:34:0: ../../../wine/dlls/msvcr90/../msvcrt/cxx.h:23:0: warning: "__thiscall" redefined [enabled by default] <built-in>:0:0: note: this is the location of the previous definition ../../../wine/dlls/msvcr90/../msvcrt/data.c:144:33: warning: ‘__p___argc’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:155:35: warning: ‘__p__pgmptr’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:160:36: warning: ‘__p__wpgmptr’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:191:32: warning: ‘_set_fmode’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:204:32: warning: ‘_get_fmode’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:246:36: warning: ‘__p___argv’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/data.c:251:46: warning: ‘__p___wargv’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] In file included from ../../../wine/dlls/msvcr90/../msvcrt/exit.c:21:0: ../../../wine/dlls/msvcr90/../msvcrt/msvcrt.h:993:41: warning: ‘_get_output_format’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1026:32: error: conflicting types for ‘_splitpath_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:48:70: note: previous declaration of ‘_splitpath_s’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1114:33: warning: ‘_splitpath’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1126:32: error: conflicting types for ‘_wsplitpath_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:57:70: note: previous declaration of ‘_wsplitpath_s’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1208:33: warning: ‘_wsplitpath’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1220:45: error: conflicting types for ‘_wfullpath’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/stdlib.h:572:71: note: previous declaration of ‘_wfullpath’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1274:35: warning: ‘_fullpath’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1329:33: warning: ‘_makepath’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1376:33: warning: ‘_wmakepath’ redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1423:32: error: conflicting types for ‘_makepath_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:44:70: note: previous declaration of ‘_makepath_s’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1527:32: error: conflicting types for ‘_wmakepath_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:53:70: note: previous declaration of ‘_wmakepath_s’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1701:32: error: conflicting types for ‘_searchenv_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:46:70: note: previous declaration of ‘_searchenv_s’ was here ../../../wine/dlls/msvcr90/../msvcrt/dir.c:1832:32: error: conflicting types for ‘_wsearchenv_s’ /usr/lib/gcc/i686-w64-mingw32/4.6/../../../../i686-w64-mingw32/include/sec_api/stdlib_s.h:55:70: note: previous declaration of ‘_wsearchenv_s’ was here make[1]: *** [dir.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: typo fixes - rebased
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6332 Your paranoid android. === w2000pro (32 bit msg) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: typo fixes - rebased
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6325 Your paranoid android. === w2000pro (32 bit shlfileop) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: user32: Fix DrawMenuBar test failures
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6320 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: typo fixes - rebased
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6325 Your paranoid android. === w2000pro (32 bit shlfileop) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: user32: Fix DrawMenuBar test failures
by Marvin 16 Apr '14

16 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6320 Your paranoid android. === w2000pro (32 bit msg) === Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: [2/2] kernel32: Add a workaround for broken apps that pass negative values to ReadConsole.
by Alexandre Julliard 15 Apr '14

15 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/console.c | 7 +++++++ > dlls/kernel32/tests/console.c | 6 ------ > 2 files changed, 7 insertions(+), 6 deletions(-) Still no good I'm afraid: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so console && touch console.ok console.c:2581: Test failed: expected 0xdeadbeef, 0 make: *** [console.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Application for GSoC 2014 - riched20: implement ITextDocument::Range and ITextRange
by Jactry Zeng 15 Apr '14

15 Apr '14

Hello folks, I am Jactry Zeng, a junior who majoring in Electronic Science from China. And also a very fresh developer of Wine. My nickname in #winehackers is jactry. :) I would like to apply for this year's GSoC to work for Wine. I have entered Wine's GSoC last year. What I have work for is ITextDocument, I implemented some functions of it. I got some experience of Wine development and fixed some other bugs[0] of richedit during that time. I continued the work of ITextDocument after GSoC, I know there is still a lot of work worth to do. Such as ITextDocument::Range[1], which is used to get an ITextRange object of the content. And functions of ITextRange[2] are used to operate this range of text. Now in Wine, ITextRange was implemented mix with ITextSelection[3][4]. And ITextDocument::GetSelection[5] which is used to get an ITextSelection object is similar to ITextRange. In an easy way, we can implement ITextDocument::Range using some cast (I have a dirty hack in attachment). But I don't think it is a permanent solution. There are four parts in my plan: --- Part 0: Do some COM cleanup. --- Because ITextRange is implemented mix with ITextSelection now, so we should do some COM cleanup to create an ITextRange interface independently. And create a ITextSelection interface inherits from ITextRange. This is just the preparatory work for implementing ITextRange and I will begin this part before GSoC. ( So it is signed as part zore :b ) --- Part 1: Implement ITextDocument::Range. --- I will write more tests for ITextDocument::Range and ITextDocument::GetSelection first. Than try to implement ITextDocumen::Range. When this part is finished, bug 12458[6] and bug 18303[7] will benefit from it. --- Part 2: Implement functions of ITextRange --- In this part, I will try my best to implement some functions of ITextRange. I will write some tests for them first and than implement them. I think this is the hard part. And these functions will be implemented preferentially: GetText, GetDuplicate, GetStar, GetEnd, Copy, SetText. Because GetDuplicate and GetEnd were needed by bug 18303, and these functions seem was depend on the others. After these functions were implemented, I think bug 18303 will be fixed! ( Oh, this one of my pursues! ;) ) --- Part 3: Imporve all the code for being merged by upstream. --- This is the last part, I will improve all the patches for being merged by upstream, including what I did last year. After this part is finished, Wine will really has an initial implementation of ITextDocument and ITextRange. Maybe it will spend a lot of time, and I will continue this work after GSoC if I can't finish all of this part during GSoC. I think after all these are finished not only bug 18303 and bug 12458 will benefit from it, but also many other softwares. Because TOM interfaces are so important and be used frequently in real world applications. I appreciate for any comment. Thank you. :) attachments: dirty hack of ITextDocument::Range: dirty_hack.txt patch 0001: tests for ITextDocument_Range [0] http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&am…<http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=jactry> [1] http://msdn.microsoft.com/en-us/library/windows/desktop/bb774097(v=vs.85).a… [2] http://msdn.microsoft.com/en-us/library/windows/desktop/bb774058(v=vs.85).a… [3] http://msdn.microsoft.com/en-us/library/windows/desktop/bb774060(v=vs.85).a… [4] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/riched20/richole.c#l7… [5] http://msdn.microsoft.com/en-us/library/windows/desktop/bb774013(v=vs.85).a… [6] http://bugs.winehq.org/show_bug.cgi?id=12458 [7] http://bugs.winehq.org/show_bug.cgi?id=18303 -- Regards, Jactry Zeng

1 1

Re: user32: Fix DrawMenuBar test failures
by Alexandre Julliard 15 Apr '14

15 Apr '14

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -4819,6 +4819,8 @@ static void test_messages(void) > after_end_dialog = FALSE; > test_def_id = FALSE; > > + ok(SetCursorPos(109, 109), "SetCursorPos failed\n"); > + Please try to restore the cursor position after the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] d3d9/tests: Add a test for timestamp queries. (try 2)
by Henri Verbeet 15 Apr '14

15 Apr '14

On 14 April 2014 22:51, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + hr = IDirect3DDevice9_CreateQuery(device, D3DQUERYTYPE_TIMESTAMPDISJOINT, &disjoint_query); > + ok(hr == D3D_OK || hr == D3DERR_NOTAVAILABLE, "Got unexpected hr %#x.\n", hr); > + data_size = IDirect3DQuery9_GetDataSize(disjoint_query); ... > + hr = IDirect3DDevice9_CreateQuery(device, D3DQUERYTYPE_TIMESTAMP, &query); > + ok(hr == D3D_OK || hr == D3DERR_NOTAVAILABLE, "Got unexpected hr %#x.\n", hr); > + data_size = IDirect3DQuery9_GetDataSize(query); I don't think this really works. Either creating these queries can legitimately fail and you need to handle those failures, or TIMESTAMPDISJOINT and TIMESTAMP are always supported if TIMESTAMPFREQ is, and D3DERR_NOTAVAILABLE is not a legitimate return value.

1 0

Re: [PATCH 3/5] wined3d: Add support for timestamp queries. (try 2)
by Henri Verbeet 15 Apr '14

15 Apr '14

On 14 April 2014 22:52, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + D3DQUERYTYPE type; ... > + type = wined3d_query_get_type(query->wined3d_query); > + if (type == D3DQUERYTYPE_TIMESTAMPDISJOINT) > + ret = sizeof(BOOL); > + else > + ret = wined3d_query_get_data_size(query->wined3d_query); Strictly speaking wined3d_query_get_type() returns an enum wined3d_query_type. > + if (type == D3DQUERYTYPE_TIMESTAMPDISJOINT && data && size == sizeof(BOOL)) > + { > + struct wined3d_query_data_timestamp_disjoint data_disjoint; > + > + hr = wined3d_query_get_data(query->wined3d_query, &data_disjoint, sizeof(data_disjoint), flags); > + *(BOOL *)data = data_disjoint.disjoint; > + } > + else > + { > + hr = wined3d_query_get_data(query->wined3d_query, data, size, flags); > + } Does this do the right thing if an application were to pass sizeof(data_disjoint) as size? > + if (gl_info->supported[ARB_TIMER_QUERY]) > + { > + GL_EXTCALL(glGenQueriesARB(1, &query->id)); > + checkGLcall("glGenQueriesARB"); > + > + TRACE("Allocated timestamp query %u in context %p.\n", query->id, context); > + } > + else > + { > + WARN("Timestamp queries not supported, not allocating query id.\n"); > + query->id = 0; > + } This should never happen, so this should either be an ERR(), or just be removed. Though I'll grant that e.g. the occlusion query code has some room for improvement as well in that regard. > @@ -969,6 +1024,9 @@ static void context_destroy_gl_resources(struct wined3d_context *context) > GL_EXTCALL(glDeleteProgramsARB(1, &context->dummy_arbfp_prog)); > } > > + if (gl_info->supported[ARB_TIMER_QUERY]) > + GL_EXTCALL(glDeleteQueriesARB(context->free_timestamp_query_count, context->free_timestamp_queries)); > + What about queries that are still on the context->timestamp_queries list? > +static HRESULT wined3d_timestamp_query_ops_get_data(struct wined3d_query *query, ... > + if (!gl_info->supported[ARB_TIMER_QUERY]) > + { > + WARN("%p timestamp queries not supported. Returning 0.\n", query); > + if (u64data) > + *u64data = 0; > + return S_OK; > + } ... > +static HRESULT wined3d_timestamp_query_ops_issue(struct wined3d_query *query, DWORD flags) ... > + if (gl_info->supported[ARB_TIMER_QUERY]) > + { ... > + } > + else > + { > + FIXME("%p timestamp queries not supported.\n", query); > + } Similar to above, the query should never have been created in these cases.

1 0

Re: typo fixes - rebased
by Nikolay Sivov 14 Apr '14

14 Apr '14

> diff --git a/ANNOUNCE b/ANNOUNCE It's generated, I don't think it makes sense to fix it. > ref = IHTMLLocation_Release(location); > - ok(!ref, "location chould be destroyed here\n"); > + ok(!ref, "location could be destroyed here\n"); Not exactly what it's supposed to mean. > -# @ stub RtlGetLengthWithoutTrailingPathSeperators > +# @ stub RtlGetLengthWithoutTrailingPathSeparators This is wrong. > -static void test_Mod( int line, VARIANT *left, VARIANT *right, VARIANT *expected, HRESULT expres ) > +static void test_Mod( int line, VARIANT *left, VARIANT *right, VARIANT *expected, HRESULT express ) Wrong too. > -#define NETWORKPLACESSHELLVIEWCOLUMNS sizeof(networkplaces_header)/sizeof(shvheader) > +#define NETWORKPLACCESSHELLVIEWCOLUMNS sizeof(networkplaces_header)/sizeof(shvheader) Network placcess hell view columns.

1 0

Re: wined3d: Add NVIDIA Geforce GTX 750 to device list. (try 2)
by Bruno Jesus 14 Apr '14

14 Apr '14

While you are at it, please if possible take a look at bugs: http://bugs.winehq.org/show_bug.cgi?id=35847 http://bugs.winehq.org/show_bug.cgi?id=32694 Best regards, Bruno

1 0

Re: [2/2] kernel32: Handle memory allocation failure in ReadConsoleA.
by Alexandre Julliard 14 Apr '14

14 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2566,8 +2566,6 @@ static void test_ReadConsole(void) > ok(ret == INVALID_FILE_SIZE, "expected INVALID_FILE_SIZE, got %#x\n", ret); > ok(GetLastError() == ERROR_INVALID_HANDLE, "expected ERROR_INVALID_HANDLE, got %d\n", GetLastError()); > > -if (0) /* FIXME: uncomment once Wine doesn't hang forever */ > -{ It still hangs here on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] d3dx9: Copy the entire vector at once if there is no need of type conversions.
by Henri Verbeet 14 Apr '14

14 Apr '14

On 14 April 2014 19:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -740,6 +740,12 @@ static void set_vector(struct d3dx_parameter *param, const D3DXVECTOR4 *vector) > { > UINT i; > > + if (param->type == D3DXPT_FLOAT) > + { > + memcpy(param->data, vector, param->columns * sizeof(float)); > + return; > + } > + When called from d3dx9_base_effect_set_vector_array(), this is not quite optimal either.

1 0

Re: [PATCH 5/5] ddraw/tests: Try to make test_coop_level_mode_set() more reliable.
by Marvin 14 Apr '14

14 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6316 Your paranoid android. === w2000pro (32 bit ddraw2) === The test timed out === w2000pro (32 bit ddraw1) === The test timed out === w2000pro (32 bit ddraw7) === The test timed out === w2000pro (32 bit ddraw4) === The test timed out

1 0

Re: [advapi32] add stub for GetTraceLoggerHandle (try 2)
by Nikolay Sivov 14 Apr '14

14 Apr '14

On 4/14/2014 12:11, Vijay Kiran Kamuju wrote: > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} It's still not fixed.

1 0

Re: [advapi32] add stub for GetTraceLoggerHandle (try 2)
by Dmitry Timoshkov 14 Apr '14

14 Apr '14

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} What this API is supposed to return? -- Dmitry.

1 0

Re: typo fixes
by Nikolay Sivov 14 Apr '14

14 Apr '14

> +++ b/documentation/ChangeLog.ALPHA This file doesn't exist any more, so you need to rebase.

1 0

Re: typo fixes
by Marvin 14 Apr '14

14 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6317 Your paranoid android. === build (build) === Patch failed to apply

1 0

typo fixes
by Veres Lajos 13 Apr '14

13 Apr '14

Hi, I attached a patch with a few typo fixes. I created it a few months ago... I hope it applies easily. Thanks! Best regards, -- Veres Lajos vlajos(a)gmail.com +36 20 438 5909

1 0

Re: [advapi32] Add stub for GetTraceLoggerHandle
by Nikolay Sivov 13 Apr '14

13 Apr '14

> /****************************************************************************** > + * EnableTrace [ADVAPI32.@] > + */ > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} It returns trace handle, not an error code. Comment is wrong too.

2 1

Re: [advapi32] Add stub for GetTraceLoggerHandle
by Dmitry Timoshkov 13 Apr '14

13 Apr '14

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > /****************************************************************************** > + * EnableTrace [ADVAPI32.@] > + */ What does this belong to? > +TRACEHANDLE WINAPI GetTraceLoggerHandle( PVOID lpBuffer ) > +{ > + FIXME("(%p) stub\n", lpBuffer); > + return ERROR_INVALID_PARAMETER; > +} What this API is supposed to return? > + > +ULONG WINAPI EnableTrace( ULONG enable, ULONG flag, ULONG level, LPCGUID guid, TRACEHANDLE hSession ) > +/****************************************************************************** What's that? -- Dmitry.

2 1

Recent 64-bit kernel breaks Win16 apps
by Jan Janecek 12 Apr '14

12 Apr '14

See the discussion on LKML: http://lkml.org/lkml/2014/4/11/514

1 0

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
by Nikolay Sivov 12 Apr '14

12 Apr '14

On 4/12/2014 07:33, Jeff Latimer wrote: > +static const IWMMetadataEditorVtbl VT_Editor = { > + WMCreateEditor_QueryInterface, > + WMCreateEditor_AddRef, > + WMCreateEditor_Release, > + WMCreateEditor_open, > + WMCreateEditor_flush, > + WMCreateEditor_close > +}; Please use better naming, for method prefix it could be WMMetadataEditor_, for vtable - WMMetadataEditorVtbl. > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) All these should be static. > HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) > { > - FIXME("(%p): stub\n", editor); > + WMMetadataEditor *metadata_editor; > + TRACE("(%p)\n", editor); > > - *editor = NULL; You're removing important like for out pointer initialization.

1 0

Re: [1/2]include: Implement part of nserror.h - Try 3
by Nikolay Sivov 12 Apr '14

12 Apr '14

> +#define NS_S_CALLPENDING_HRESULT_TYPEDEF_(0x000D0000L) I don't think you need L suffix at all.

1 0

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
by Nikolay Sivov 12 Apr '14

12 Apr '14

On 4/12/2014 07:33, Jeff Latimer wrote: > Free the implementation rather that the interface > --- > dlls/wmvcore/wmvcore_main.c | 99 > +++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 96 insertions(+), 3 deletions(-) > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + WMMetadataEditor *This = impl_from_IWMMetadataEditor(iface); > + FIXME("(%p)\n", iface); > + heap_free(This); > + return S_OK; > +} > + > +static ULONG WINAPI WMCreateEditor_Release(IWMMetadataEditor *iface) > +{ > + WMMetadataEditor *This = impl_from_IWMMetadataEditor(iface); > + ULONG ref = InterlockedDecrement(&This->ref); > + TRACE("(%p) ref=%d\n", iface, ref); > + > + if (ref == 0) WMCreateEditor_close(iface); > + return ref; > +} > + > +HRESULT WINAPI WMCreateEditor_open(IWMMetadataEditor *iface, const WCHAR *filename) > +{ > + if (!filename) return E_POINTER; > + FIXME("(%p) filename=%s\n", iface, debugstr_w(filename)); > + return NS_E_FILE_OPEN_FAILED; > +} > + > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("(%p)\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > + This is wrong. You can't free implementation pointer like that, only Release() should do it. Also please use natural interface method order for implementation functions and don't make them call each other. So close(), open() and flush() should all return E_NOTIMPL, and have a 'stub' in a fixme message.

1 0

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
by Dmitry Timoshkov 12 Apr '14

12 Apr '14

Jeff Latimer <lats(a)yless4u.com.au> wrote: > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + WMMetadataEditor *This = impl_from_IWMMetadataEditor(iface); > + FIXME("(%p)\n", iface); > + heap_free(This); > + return S_OK; > +} Why not pass 'This' to WMCreateEditor_close() directly? Why a FIXME? There is still a stray empty line after WMCreateEditor(). -- Dmitry.

2 2

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation - Try 3
by Qian Hong 12 Apr '14

12 Apr '14

Hi Jeff, Thanks for the improvement, but it seems you forgot to remove the empty line.

1 0

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation - Try 2
by Dmitry Timoshkov 12 Apr '14

12 Apr '14

Jeff Latimer <lats(a)yless4u.com.au> wrote: > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} Still doesn't free the right thing. -- Dmitry.

2 1

Re: [2/2]wmvcore: add WMMetadataEditor stub implementation
by Dmitry Timoshkov 12 Apr '14

12 Apr '14

Jeff Latimer <lats(a)yless4u.com.au> wrote: > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} WMCreateEditor_close() should free the implementation not an interface pointer (although they accidently happen to be the same because of implementation structure layout, but once somebody moves/adds fields that may change and lead to unpredictable results). -- Dmitry.

1 0

Re: [1/2]include: Implement part of nserror.h
by Qian Hong 12 Apr '14

12 Apr '14

Hi Jeff, HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) { + WMMetadataEditor *metadata_editor; FIXME("(%p): stub\n", editor); Looks like now we need to use TRACE instead of FIXME here because WMCreateEditor is implemented. - *editor = NULL; + metadata_editor = HeapAlloc(GetProcessHeap(), 0, sizeof(WMMetadataEditor)); + if (!metadata_editor) return E_OUTOFMEMORY; - return E_NOTIMPL; + metadata_editor->IWMMetadataEditor_iface.lpVtbl = &VT_Editor; + metadata_editor->ref = 0; Looks like ref count should be 1 instead of 0. + *editor = &metadata_editor->IWMMetadataEditor_iface; + + return S_OK; } + Looks like this empty line is unwanted. -- Regards, Qian Hong - http://www.winehq.org

1 0

Implementing (parts of) BindImageEx
by Bernhard Reiter 11 Apr '14

11 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 I'm trying to implement parts of imagehlp's BindImageEx so that at least freezing Python scripts to .exe files (as done by cx_Freeze or py2exe) works -- see [1] (from whose comments #24 and #25 most of this message is copied), and their implementations of the StatusRoutine function [2, 3]. In both cases, BindImageEx is called with BIND_NO_BOUND_IMPORTS | BIND_NO_UPDATE | BIND_ALL_IMAGES as Flags, which I think means that no actual changes to the image's virtual address table are done, but they're only used to determine which DLLs are used by the image. So for cx_Freeze, it would be apparently enough for Wine's BindImageEx stub to iterate over all DLLs whose functions are used by the image, i.e. the exe or dll passed as the ImageName parameter, and call StatusRoutine with the Reason parameter set to BindImportModule, and DllName set to the DLL, while the "Parameter" and "virtualAddress" arguments aren't required for it to work. Py2exe also requires StatusRoutine called with BindImportProcedure as Reason, and will in that case check if Parameter is set to PyImport_ImportModule before it does something, so I think there should be another loop iterating over a DLL's functions, nested in the one mentioned above, and which invokes StatusRoutine with Status set to BindImportProcedure, and with the current function's name as Parameter. I think I have found out the crucial function required to implement this to be ImageDirectoryEntryToDataEx [4] (with dir set to IMAGE_DIRECTORY_ENTRY_IMPORT). Similar iterations like the ones sketched here seem to be found in fixup_imports() (in dlls/ntdll/loader.c) or dump_dir_imported_functions() (in tools/winedump/pe.c, though that isn't using win API functions). So I've tried to implement what I've described above, but unfortunately, I can't seem to figure out the very first part required: obtaining something that can be used as the "base" parameter for ImageDirectoryEntryToDataEx from the ImageName string passed to BindImageEx. I've tried LoadLibraryA(ImageName), LoadLibraryExA(ImageName, NULL, LOAD_LIBRARY_AS_DATAFILE), and MapAndLoad(), but unfortunately, all of them seem to either import all the PE's symbols in a fashion that collides with the already loaded ones (in particular in a python-freezing context, like running "wine C:\\Python27\\python.exe setup.py build" with the test case attached to [1]), or not load them in a way that can be used for ImageDirectoryEntryToDataEx. I'm hoping for someone to help me figure out how to do this... Bernhard [1] http://bugs.winehq.org/show_bug.cgi?id=3591 [2] https://bitbucket.org/anthony_tuininga/cx_freeze/src/de3e8865616a1048d17e95… [3] http://sourceforge.net/p/py2exe/svn/HEAD/tree/trunk/py2exe/source/py2exe_ut… [4] http://source.winehq.org/WineAPI/.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJTRa6OAAoJEKYfw19Gd1lo210P/jfWL7wxK1xDviOur3tXhGfE xPduK9CzkirMVKhSCzmCMEeW7o+ZUulOaAyUkpPVc+H9odiiTLM+4KbEp6z9P4FH 3egzgUB84+a+twZGBgTTvlEeZ5XXsvsTy3MCEiMWNbU3NUmU0DMDO2oAGP2XRG9B 55mfggCTaGQhZL11P6zYyNmb1x+oNK5eLdrYshLPuRa7fbnErtA4zYGc+tGbJBBX mTouKETgGYl+2UoYRZzxctXhsOL0AtUST75hbkh+vvD5J/e/ekYRuHVmmQ91mpbv Wdn1FnQFsTjMvdN0S8frWLFNi7gWcysItoHo9xx65E5hfIXq1tuV9VPcJTYwc+4D op8o8BHno45/K3J1VjJfqbWv4fWI7R0dQTO+igARtszux8r5zt0Wla+8TYly152w ozRMqNC7w+u8JSIPmCTL4mU8+ZwDL+Rl41lRNRVMEda/8E4EGnmwBEo6jK/NvLUJ 1/FXizp7EeNKrMLcANmQF9t/WG4xWKVTrpjWwmOVgu2tdZ099u9LqefjOxRZ0vVC qJO0PJmtlhnZsiBUEIk/x8xZ8KlXmG15FYGx/QI9phn9B5jYks7J++Xzn3PmxlqE YadhCZv5RkK/SLNxiGH726rq0dGwS7NSx3aLNaW5Noj2OuDzj57BZr1nxVGmpezy d0kdLN2Il8I/XGgezhao =wM12 -----END PGP SIGNATURE-----

2 3

Re: include: Add dvoice.h
by Dmitry Timoshkov 11 Apr '14

11 Apr '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > include: Add dvoice.h Isn't this supposed to be generated from an .idl? Also which PSDK version has this header? At least 7.1 doesn't contain it. -- Dmitry.

2 1

Re: [1/3] taskschd/tests: Add some tests for task registration info.
by Nikolay Sivov 11 Apr '14

11 Apr '14

On 4/11/2014 11:26, Dmitry Timoshkov wrote: > + hr = IRegistrationInfo_get_Description(reginfo, &bstr); > +todo_wine > + ok(hr == S_OK, "get_Description error %#x\n", hr); > +if (hr == S_OK) > +{ > + ok(bstr && !lstrcmpW(bstr, Task1), "expected Task1, got %s\n", wine_dbgstr_w(bstr)); It's redundant to check for 'bstr' being not NULL, lstrcmpW test will fail in this case too. For other tests when it returns NULL bstr it would be cleaner to set pointer to some non-zero value to test that each method actually resets it to NULL.

2 3

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties. Take 2.
by Marvin 11 Apr '14

11 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6298 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties. Take 2.
by Marvin 11 Apr '14

11 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6297 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] taskschd: Implement getters for IRegistrationInfo string properties.
by Nikolay Sivov 11 Apr '14

11 Apr '14

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > + *description = reginfo->description ? SysAllocString(reginfo->description) : NULL; > + return S_OK; SysAllocString(NULL) returns NULL, so no need to handle it separately.

1 0

Re: [3/3] taskschd: Implement setters for IRegistrationInfo string properties.
by Nikolay Sivov 11 Apr '14

11 Apr '14

On 4/11/2014 11:27, Dmitry Timoshkov wrote: > static HRESULT WINAPI RegistrationInfo_put_Description(IRegistrationInfo *iface, BSTR description) > { > - FIXME("%p,%p: stub\n", iface, debugstr_w(description)); > - return E_NOTIMPL; > + registration_info *reginfo = impl_from_IRegistrationInfo(iface); > + > + TRACE("%p,%p\n", iface, debugstr_w(description)); > + > + if (!description) return E_INVALIDARG; > + > + reginfo->description = heap_strdupW(description); > + /* FIXME: update XML on the server side */ > + return reginfo->description ? S_OK : E_OUTOFMEMORY; Looks like you need to free previously set string.

1 0

Re: [2/2] dpnet: Improve Error checking in Get/Set SP (try 6)
by Stefan Dösinger 11 Apr '14

11 Apr '14

Am 11.04.2014 um 04:21 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Fixed Copy/paste issue. > > Changelog: > dpnet: Improve Error checking in Get/Set SP > > > Best Regards > Alistair Leslie-Hughes Looks good to me!

1 0

Re: mshtml: Ignore &IID_IWebBrowserPriv2IE7 in wb_qi.
by Marvin 11 Apr '14

11 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6273 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 5)
by Stefan Dösinger 10 Apr '14

10 Apr '14

Am 10.04.2014 um 11:51 schrieb Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: Is this intentional? > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); Otherwise this looks good to me.

1 0

Re: [PATCH] gdiplus: fix segfault in gdip_format_string
by Vincent Povirk 10 Apr '14

10 Apr '14

Looks good to me, thanks. (Maybe we should consider setting format to an empty GpStringFormat if it's not specified.)

1 0

Re: wined3d: Add NVIDIA Geforce GTX 750 to device list.
by Henri Verbeet 10 Apr '14

10 Apr '14

On 10 April 2014 08:47, Ryan Turner <zdbiohazard2(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX750 = 0x1381, > + CARD_NVIDIA_GEFOREE_GTX750TI = 0x1380, Did you try to compile this?

2 1

audio reset failed
by Pawel Por 10 Apr '14

10 Apr '14

Hi I receive periodically the following error popup window: "Audio Reset Failed: Access violation at address 7BC503AA in module 'ntdll.dll'. Write of address F818611C" The message is the same every time. Even the addresses 7BC503AA and 7BC503AA are the same. When it occurs the audio hangs up and only the restart of the wine application helps. I use 64-bit Arch Linux and run 32 bit wine applications. Wine version is wine 1.7.14-1 (32 bit). The /proc/<wine app's PID>/maps is as follows. I can see that memroy region ffbd0000-ffbf0000 is not writtable and the memory region 7bc10000-7bc11000 is most likely BSS. 7bc00000-7bc10000 r-xp 00000000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bc10000-7bc11000 r-xp 00000000 00:00 0 7bc11000-7bcc6000 r-xp 00011000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc6000-7bcc7000 r--p 000c5000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc7000-7bcd1000 rwxp 000c6000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so f7747000-f7748000 r-xp 00000000 00:00 0 [vdso] f7750000-ffba0000 ---p 00000000 00:00 0 ffba8000-ffbc9000 rw-p 00000000 00:00 0 ffbd0000-ffbf0000 ---p 00000000 00:00 0 ffbf0000-ffff0000 rwxp 00000000 00:00 0 wine.log is as follows: fixme:ole:RemUnknown_QueryInterface No interface for iid {00000019-0000-0000-c000-000000000046} fixme:ole:CoResumeClassObjects stub err:ole:CoGetClassObject class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:create_server class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:CoGetClassObject no class object {a910187f-0c7a-45ac-92cc-59edafb77b53} could be created for context 0x5 dmesg sound related entries are: snd_hda_intel 0000:00:1b.0: irq 43 for MSI/MSI-X input: HDA Intel Front Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 input: HDA Intel Line Out as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 input: HDA Intel Line as /devices/pci0000:00/0000:00:1b.0/sound/card0/input6 input: HDA Intel Mic as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 lsmod sound related entries are: snd_hda_codec_analog 9307 1 snd_hda_intel 37352 0 snd_hda_codec 150017 2 snd_hda_intel,snd_hda_codec_analog snd_hwdep 6332 1 snd_hda_codec snd_pcm 77822 2 snd_hda_codec,snd_hda_intel snd_page_alloc 7298 2 snd_pcm,snd_hda_intel snd_timer 18718 1 snd_pcm snd 59029 6 snd_hwdep,snd_timer,snd_pcm,snd_hda_codec,snd_hda_intel,snd_hda_codec_analog soundcore 5418 1 snd I use alsa only (no pulse audio). Do you have any ideas how to solve this issue. I tried to use all possible sound outputs in winecfg but nothing helps. Thanks in advance.

2 1

Re: user32: Don't fail on windows without menu bar in DrawMenuBar
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6272 Your paranoid android. === w2000pro (32 bit msg) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 5)
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6271 Your paranoid android. === w2000pro (32 bit address) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

audio reset failed
by Pawel Por 10 Apr '14

10 Apr '14

Hi I receive periodically the following error popup window: "Audio Reset Failed: Access violation at address 7BC503AA in module 'ntdll.dll'. Write of address F818611C" The message is the same every time. Even the addresses 7BC503AA and 7BC503AA are the same. When it occurs the audio hangs up and only the restart of the wine application helps. I use 64-bit Arch Linux and run 32 bit wine applications. Wine version is wine 1.7.14-1 (32 bit). The /proc/<wine app's PID>/maps is as follows. I can see that memroy region ffbd0000-ffbf0000 is not writtable and the memory region 7bc10000-7bc11000 is most likely BSS. 7bc00000-7bc10000 r-xp 00000000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bc10000-7bc11000 r-xp 00000000 00:00 0 7bc11000-7bcc6000 r-xp 00011000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc6000-7bcc7000 r--p 000c5000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so 7bcc7000-7bcd1000 rwxp 000c6000 08:02 15345278 /usr/lib32/wine/ntdll.dll.so f7747000-f7748000 r-xp 00000000 00:00 0 [vdso] f7750000-ffba0000 ---p 00000000 00:00 0 ffba8000-ffbc9000 rw-p 00000000 00:00 0 ffbd0000-ffbf0000 ---p 00000000 00:00 0 ffbf0000-ffff0000 rwxp 00000000 00:00 0 wine.log is as follows: fixme:ole:RemUnknown_QueryInterface No interface for iid {00000019-0000-0000-c000-000000000046} fixme:ole:CoResumeClassObjects stub err:ole:CoGetClassObject class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:create_server class {a910187f-0c7a-45ac-92cc-59edafb77b53} not registered err:ole:CoGetClassObject no class object {a910187f-0c7a-45ac-92cc-59edafb77b53} could be created for context 0x5 dmesg sound related entries are: snd_hda_intel 0000:00:1b.0: irq 43 for MSI/MSI-X input: HDA Intel Front Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card0/input8 input: HDA Intel Line Out as /devices/pci0000:00/0000:00:1b.0/sound/card0/input7 input: HDA Intel Line as /devices/pci0000:00/0000:00:1b.0/sound/card0/input6 input: HDA Intel Mic as /devices/pci0000:00/0000:00:1b.0/sound/card0/input5 lsmod sound related entries are: snd_hda_codec_analog 9307 1 snd_hda_intel 37352 0 snd_hda_codec 150017 2 snd_hda_intel,snd_hda_codec_analog snd_hwdep 6332 1 snd_hda_codec snd_pcm 77822 2 snd_hda_codec,snd_hda_intel snd_page_alloc 7298 2 snd_pcm,snd_hda_intel snd_timer 18718 1 snd_pcm snd 59029 6 snd_hwdep,snd_timer,snd_pcm,snd_hda_codec,snd_hda_intel,snd_hda_codec_analog soundcore 5418 1 snd I use alsa only (no pulse audio). Do you have any ideas how to solve this issue. I tried to use all possible sound outputs in winecfg but nothing helps. Thanks in advance.

1 0

Re: [1/5] taskschd: Add invalid parameter check to IRegisteredTask::get_State and IRegisteredTask::get_Enabled.
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6266 Your paranoid android. === w2000pro (32 bit scheduler) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for color_fill_test().
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for fog_test().
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6264 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for test_cube_wrap().
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6263 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for z_range_test().
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6262 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for maxmip_test().
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6261 Your paranoid android. === w2000pro (32 bit visual) === The test timed out

1 0

Re: [2/2] oleaut32: Fix loading of an empty picture from a non-statable stream.
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6260 Your paranoid android. === w2000pro (32 bit olepicture) === olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:202: Test failed: OLP (NULL,..) does not return 0, but 0x8000ffff olepicture.c:203: Test failed: OLP (NULL,..) returns NULL, instead of !NULL olepicture.c:435: Test failed: OleLoadPicture failed with error 0x8000ffff olepicture: unhandled exception c0000005 at 0040A7BD

1 0

Re: [1/2] oleaut32/tests: Add a test for loading an empty picture from a non-statable stream.
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6259 Your paranoid android. === w2000pro (32 bit olepicture) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 4)
by Stefan Dösinger 10 Apr '14

10 Apr '14

> + hr = IDirectPlay8Address_SetSP(localaddr, &GUID_NULL); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); That’s a step forward, but I also meant that you should call GetSP after setting GUID_NULL manually. > +DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); Why do you have to define this? (I really don’t know; It may be correct, or maybe you just need #define INITGUID, or something else.) > static HRESULT WINAPI IDirectPlay8AddressImpl_SetUserData(IDirectPlay8Address *iface, > @@ -313,6 +323,8 @@ HRESULT DPNET_CreateDirectPlay8Address(LPCLASSFACTORY iface, LPUNKNOWN punkOuter > return E_OUTOFMEMORY; > } > client->IDirectPlay8Address_iface.lpVtbl = &DirectPlay8Address_Vtbl; > + client->SP_guid = GUID_NULL; > + client->init = FALSE; > client->ref = 0; /* will be inited with QueryInterface */ > return IDirectPlay8AddressImpl_QueryInterface (&client->IDirectPlay8Address_iface, riid, ppobj); > } You shouldn’t have to set client->init = FALSE because you allocate client with HEAP_ZERO_MEMORY. If you prefer to set it for clarity that’s ok with me. The same applies to SP_guid, for two reasons: First, it’s already initialized to zeroes, and you’re not reading it unless client->init is set to TRUE, which only happens after a successful SetSP call. IMHO you can also correct the indentation in this function, but I’ll leave the decision up to you. Cheers, Stefan

2 2

Re: [PATCH] qedit/tests: Fix a file handle leak on error path (Coverity)
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6258 Your paranoid android. === w2000pro (32 bit mediadet) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 4)
by Marvin 10 Apr '14

10 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6257 Your paranoid android. === w2000pro (32 bit address) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: [5/5] taskschd: Forward IRegisteredTask::get_Enabled to SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6250 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/5] taskschd: Forward IRegisteredTask::get_State to SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6249 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/5] schedsvc: Add SchRpcGetTaskInfo stub implementation.
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6248 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/5] schedsvc: Add some tests for SchRpcGetTaskInfo.
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6247 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/5] schedsvc: Return correct error code when a being loaded xml doesn't exist.
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6246 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for offscreen_test().
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6243 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for ds_size_test().
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6242 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for alpha_test().
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6241 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for shademode_test().
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6240 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for srgbtexture_test().
by Marvin 09 Apr '14

09 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6239 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.
by Huw Davies 09 Apr '14

09 Apr '14

On Tue, Apr 08, 2014 at 12:18:23PM +0400, Vitaly Lipatov wrote: > I think the more appropriate place for a missed libc function is > libs/port. If it is ever needed by another dll, then it can get moved there. Huw.

2 1

Problem Wine 1.4/ wintricks Mint Petra with installing mfc42.dll
by Thomas Paleschke 08 Apr '14

08 Apr '14

installing mfc42.dll with winetricks under wine version 1.4 and Linux Mint 16 (Petra) is aborted with the following error: ~/.cache/winetricks/vcrun6 $ winetricks mfc42 Executing w_do_call mfc42 Executing load_mfc42 Executing wine /home/thomas/.cache/winetricks/vcrun6/vc6redistsetup_deu.exe /T:C:\windows\Temp\_mfc42 /c wine: Unhandled page fault on read access to 0x00000001 at address 0x7bc493a0 (thread 0032), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc493a0 ------------------------------------------------------ Note: command 'wine /home/thomas/.cache/winetricks/vcrun6/vc6redistsetup_deu.exe /T:C:\windows\Temp\_mfc42 /c' returned status 5. Aborting. ------------------------------------------------------

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6231 Your paranoid android. === build (build) === Make failed

1 0

Re: services: Skip tests if OpenSCManager failed.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6230 Your paranoid android. === build (build) === Make failed

1 0

Re: mshtml: Ignore QueryHitPoint calls in activex.c tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6229 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for release_buffer_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6228 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for float_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6227 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for g16r16_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6226 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for pixelshader_blending_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for texture_transform_flags_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6224 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 6/6] ole32: Add more SetConvertStg amd WriteFmtUserTypeStg tests (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6207 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] ole32: Add OleDoAutoConvert implementation (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6206 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] dwrite: Added GetTrimming()/SetTrimming() for text format
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6217 Your paranoid android. === build (build) === Missing build status line

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Stefan Dösinger 08 Apr '14

08 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-04-08 12:12, schrieb Alistair Leslie-Hughes: > Hi, > Any feedback would be good. A few mostly minor things come to my mind. > + if(!pguidSP) > + return DPNERR_INVALIDPOINTER; > ... > + ok(hr == DPNERR_DOESNOTEXIST, "got 0x%08x\n", hr); > ... > + ok( hr == S_OK, "failed to init com\n"); > + if (hr != S_OK) Style inconsistencies. > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&localaddr); Please avoid LPVOID and similar pointer types. Just use void **. > + hr = IDirectPlay8Address_SetSP(localaddr, NULL); > + ok(hr == DPNERR_INVALIDPOINTER, "got 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random); > + ok(hr == S_OK, "got 0x%08x\n", hr); Since you're using GUID_NULL as a way to signal that no guid is set it would be a good idea to try to pass it to SetSP and see if you still get DPNERR_DOESNOTEXIST when you call GetSP. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQ9jeAAoJEN0/YqbEcdMwDisP/iFE7fHlWn2B0LYwVNgu6lD9 6OQdMWuLYAiWRWQKx9WaBAiwdq6ZmG3WnfHfuLPAI5VkHh0lUZwOTil/J7KQYVoj rVeCA6wKDHMPXUHcRC0uB7gZlzh5JKCq60iQ4xeJ9CUAk/fhVMOGd8+xXew2HYfo K4WVyEw8FYg88F+YzQh1dWj4e84dn+yn0+yGYrqSxXOTeJFcal1EOo0myGcZgBto uLUvFb/NBQFMzwN/mOL84YzY4nRCpIbenQbI+03BT7YR/lX1Q3IOdvTyB+dsN8pQ iO+ekMEFR0PYOkG6skmLlkAkRHCeq9uxyLHaxvtUPv9NuA+GgvQY6xhXielnVn8f GGzlvHd01bNjccZQTjSbvE45rsp3/PGuV3592DNbhZGmiZ10D8bY/yu2QW3F6sHP d9yhyJc4ubi3vlJ0UTUF8joZzL2rSydWvTa5VLNkWhqnZUzJqE2lwG6QI5IqUjra Khl3W5P5SyFfoBZcWQwHVOURa3IzZOsYQWm6jbjJqrBXphUGg6wZZ1YgfTqlfoqq vq9Xnr90UulxQHB4txTcviDOQi8EXAOmAIbhSImsam6hCht0A75zuxIP84LhS/mv UkjblDHxCGneNrkq7tuJiARjwj6D5RJY26iYaw70sHOhJBFKXSzARmtP5At+BwRd wplsw498wUMBAVjAl/ZB =TIUo -----END PGP SIGNATURE-----

1 0

Re: wmp: add HKLM\\Software\\Microsoft\\Multimedia\\WMPlayer\\Extensions key (try 2)
by Jacek Caban 08 Apr '14

08 Apr '14

Hi Austin, On 04/08/14 12:16, Austin English wrote: > +HKLM > +{ > + 'SOFTWARE' > + { > + 'Microsoft' > + { > + 'Multimedia' > + { Those should probably use NoRemove attribute. Jacek

1 0

Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6231 Your paranoid android. === build (build) === Missing build status line

1 0

Re: services: Skip tests if OpenSCManager failed.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6230 Your paranoid android. === build (build) === Missing build status line

1 0

Re: mshtml: Ignore QueryHitPoint calls in activex.c tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6229 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/5] d3d9/tests: Use a separate device for release_buffer_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6228 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for float_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6227 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for g16r16_texture_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6226 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for pixelshader_blending_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/5] d3d9/tests: Use a separate device for texture_transform_flags_test().
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6224 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [4/4] taskschd: Implement IRegisteredTask::get_Path.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6223 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [3/4] taskschd: Implement IRegisteredTask::get_Name.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6222 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

1 0

Re: [2/4] taskschd: Implement task management using RPC APIs.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6221 Your paranoid android. === build (build) === Could not copy the patch to the VM: the "nc -q0 '10.42.42.130' '4242'" command returned 1

1 0

Re: [2/2] schedsvc/tests: Avoid test failures on file systems with enabled directory randomization.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6220 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/2] schedsvc/tests: Fix a couple of typos.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6219 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/2] dwrite: Added partial implementation for CreateEllipsisTrimmingSign()
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6218 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/2] dwrite: Added GetTrimming()/SetTrimming() for text format
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6217 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/5] ddraw: SetPrivateData(..., data = NULL, ...) is not valid.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6216 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 4/5] dxgi/tests: Add private data tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6215 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 3/5] ddraw/tests: Nvidia has an off-by-one rectangle handling bug.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6214 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 2/5] d3d8/tests: Test locking of mipmap textures.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/5] d3d9/tests: Test locking of mipmap textures.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 6/6] ole32: Add more SetConvertStg amd WriteFmtUserTypeStg tests (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6207 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 5/6] ole32: Add OleDoAutoConvert implementation (try2)
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6206 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [4/4] user32: Emit EM_SETSEL message when choosing "Select All" from context menu.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6205 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [3/4] user32: Don't emit WM_COMMAND on choosing an item in a context menu (Edit control).
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6204 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [2/4] user32/tests: Add some tests for edit control context menu messages.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6203 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [1/4] user32/tests: Don't forget to destroy the parent window after the tests.
by Marvin 08 Apr '14

08 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6202 Your paranoid android. === build (build) === Missing build status line

1 0

Re: [PATCH 1/2] ntdll: Add a replacement getmntent for Android.
by Vitaly Lipatov 08 Apr '14

08 Apr '14

Huw Davies писал 2014-04-07 16:22: > Bionic has a stub function named getmntent which outputs an > unimplemented message. > --- > dlls/ntdll/directory.c | 101 I think the more appropriate place for a missed libc function is libs/port. -- Vitaly Lipatov, Etersoft

1 0

Re: [4/4] taskschd: Implement IRegisteredTask::get_Path.
by Alexandre Julliard 08 Apr '14

08 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/taskschd/regtask.c | 12 ++++++++++-- > dlls/taskschd/tests/scheduler.c | 34 ++++++++++++++++++++++++++-------- > 2 files changed, 36 insertions(+), 10 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M taskschd.dll -p taskschd_test.exe.so scheduler && touch scheduler.ok scheduler.c:827: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 scheduler.c:887: Test succeeded inside todo block: expected VARIANT_FALSE, got 0 make: *** [scheduler.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regsvr32: Improve a few resource strings
by Nikolay Sivov 07 Apr '14

07 Apr '14

I don't want another oversized thread on this, but: -\ [/u] Unregister a server.\n\ +\ [/u] Unregister a module.\n\ You don't really register a module, it registers COM server that's implemented in some module. So server is important part, module hosting it is details.

2 1

Re: [PATCH 3/6] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function (try2)
by Vincent Povirk 07 Apr '14

07 Apr '14

Looks good to me.

1 0

Re: [PATCH 3/5] ole32: Try to open 1Ole stream before trying to create it in SetConvertStg function
by Vincent Povirk 07 Apr '14

07 Apr '14

This looks like a no-op to me. It means we read/update the flags even if we created the stream, but in that case it should already be correct. Why do we need this?

2 1

Re: [3/5] netprofm: Add a class factory implementation.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Hi Hans, Hans Leidekker <hans(a)codeweavers.com> wrote: > +struct netprofm_cf > +{ > + const struct IClassFactoryVtbl *vtbl; > + HRESULT (*create_instance)(void **); > +}; > + > +static inline struct netprofm_cf *impl_from_IClassFactory( IClassFactory *iface ) > +{ > + return (struct netprofm_cf *)((char *)iface - FIELD_OFFSET( struct netprofm_cf, vtbl )); > +} Objects in this new dll don't follow http://wiki.winehq.org/COMGuideline, but that's not a big problem, and could be fixed later. > +static HRESULT WINAPI netprofm_cf_CreateInstance( IClassFactory *iface, LPUNKNOWN outer, > + REFIID riid, LPVOID *obj ) > +{ > + struct netprofm_cf *factory = impl_from_IClassFactory( iface ); > + IUnknown *unk; > + HRESULT r; > + > + TRACE( "%p %s %p\n", outer, debugstr_guid(riid), obj ); > + > + *obj = NULL; > + if (outer) return CLASS_E_NOAGGREGATION; > + > + r = factory->create_instance( (void **)&unk ); > + if (FAILED( r )) > + return r; > + > + r = IUnknown_QueryInterface( unk, riid, obj ); > + if (FAILED( r )) > + return r; > + > + IUnknown_Release( unk ); > + return r; > +} It seems that 'unk' is leaked if IUnknown_QueryInterface fails. -- Dmitry.

1 0

Re: loader: add HKLM\\Software\\Microsoft\\Multimedia\\WMPlayer\\Extensions key
by Jacek Caban 07 Apr '14

07 Apr '14

Hi Austin, On 04/07/14 09:32, Austin English wrote: > diff --git a/loader/wine.inf.in b/loader/wine.inf.in > index 1f08d2e..8200d41 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -662,6 +662,8 @@ HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-99 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Locale",2,"*" > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Version",2,"4,74,9273,0" > > +; Windows Media Player > +HKLM,SOFTWARE\Microsoft\Multimedia\WMPlayer\Extensions,,16 This could probably go to dlls/wmp/wmp.rgs. Jacek

1 0

Re: [2/2] include/vfw.h: Replace handmade COM method macros by widl generated ones (including inline wrappers).
by Nikolay Sivov 07 Apr '14

07 Apr '14

I think the idea was to have a proper idl file eventually.

3 3

Re: [PATCH 2/2] dwrite: Store text format properties
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT WINAPI dwritetextformat_SetLineSpacing(IDWriteTextFormat *iface, DWRITE_LINE_SPACING_METHOD method, > + FLOAT spacing, FLOAT baseline) > { > struct dwrite_textformat *This = impl_from_IDWriteTextFormat(iface); > - FIXME("(%p)->(%d %f %f): stub\n", This, spacing, line_spacing, baseline); > - return E_NOTIMPL; > + TRACE("(%p)->(%d %f %f)\n", This, method, spacing, baseline); > + This->format.spacingmethod = method; > + This->format.spacing = spacing; > + This->format.baseline = baseline; > + return S_OK; > } Probably all the format properties setters should handle invalid enum or negative floating point arguments some way. -- Dmitry.

2 3

Re: [3/5] ntdll: Implement RtlInstallFunctionTableCallback on x86_64.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > +BOOLEAN CDECL RtlInstallFunctionTableCallback( DWORD64 table, DWORD64 base, DWORD length, > + PGET_RUNTIME_FUNCTION_CALLBACK callback, PVOID context, PCWSTR dll ) > +{ http://msdn.microsoft.com/en-us/library/windows/desktop/ms680595%28v=vs.85%… claims that RtlInstallFunctionTableCallback is WINAPI, not CDECL, which one is correct? -- Dmitry.

2 1

Re: [3/5] ntdll: Implement RtlInstallFunctionTableCallback on x86_64.
by Dmitry Timoshkov 07 Apr '14

07 Apr '14

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > +@ cdecl -arch=x86_64 RtlInstallFunctionTableCallback(long long long ptr ptr ptr) ... > +BOOLEAN CDECL RtlInstallFunctionTableCallback( DWORD64 table, DWORD64 base, DWORD length, > + PGET_RUNTIME_FUNCTION_CALLBACK callback, PVOID context, PCWSTR dll ) spec entry doesn't match the implementation. Probably it should be (int64 int64 long ptr ptr wstr) -- Dmitry.

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 8
by Stefan Dösinger 06 Apr '14

06 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-04-04 13:57, schrieb Patrick Rudolph: > + static struct > + { > + const char *name; > + DDPIXELFORMAT fmt; > + } > + formats[] = You can make this const. > + /* 6: Test maximum surface height */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, > + /* 7: Test maximum surface width */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, These tests fail on Wine. Please include your patch that introduces the size check in this patch or in a separate patch to apply before this one, or mark them todo_wine. > + /* 8: Test OUTOFVIDEOMEMORY */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN | DDSCAPS_VIDEOMEMORY, > + 0xffff, 0xffff, DDERR_OUTOFVIDEOMEMORY}, This also fails on Wine. You'll have to move the adapter_adjust_memory() call in dlls/wined3d/resource.c, resource_init() ahead of the memory allocation call. > + /* 9: Test OUTOFMEMORY */ > + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY, > + 0xffff, 0xffff, DDERR_OUTOFMEMORY}, This test still fails in 64 bit on my Windows 7 test machine with D3DFMT_P8. The failure happens because CreateSurface succeeds although the test expects it to fail. I'd suggest to remove this test for the same reason as test 10. > + /* does the hardware support videomemory ? */ > + if (!(ddcaps.ddsCaps.dwCaps & DDSCAPS_VIDEOMEMORY)) > + { > + tests[8].hr = DDERR_NODIRECTDRAWHW; > + } You can remove the curly brackets here. > + for (i = 0; i < sizeof(tests) / sizeof(*tests); i ++) > + { > + if (surface) > + { > + IDirectDrawSurface_Release(surface); > + surface = NULL; > + } > + > + memset(&surfacedesc, 0, sizeof(surfacedesc)); > + surfacedesc.dwSize = sizeof(surfacedesc); > + surfacedesc.dwFlags = tests[i].dwFlags | DDSD_PIXELFORMAT; > + surfacedesc.ddsCaps.dwCaps = tests[i].dwCaps; > + surfacedesc.dwWidth = tests[i].dwWidth; > + surfacedesc.dwHeight = tests[i].dwHeight; > + surfacedesc.ddpfPixelFormat = formats[j].fmt; > + > + hr = IDirectDraw_CreateSurface(ddraw, &surfacedesc, &surface, NULL); > + ok(hr == tests[i].hr, "Pixelformat %s, test %d returned %08x\n", formats[j].name, i, hr); > + } Why is the surface release before the create call? You're potentially leaking surfaces here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTQdGlAAoJEN0/YqbEcdMwvikP/RT9mO2pARAAfY7DIRuOns3R 8rYw7skxAOwKU12NK42gaSqTjZKoRglpXyYJwD1keq9uRZnk8oAy4yQN7axg3/wq OI8gF6VN9Dlqofq6l4FD8rNC0yBFxxehZkOJXpzGXGisDau3C+pK007+fnwb0zQI IOJ+M/ok+cOvmymbktmrRryVtrttG5Z0EYqpBQw53+ZTKUyu6AhcuoXV5Sf04Jkx SnCHhRn3RLKEMTwc/XT6O5+in89CgIcrMmNWnCk0JrgywNhqOxX4A9HzkHTL3h/n OHR1fJW4SmRDwT4r+nQmOBjIY7tCipv0xK5LTOqbaNCDxTIyZL2AOji5PeR4mZWH iHPOb6826iouxE8P12cLfgueBebhY/lVCmiWwV67K7koFSmYs4MhtR/jdeiuZ8rI jYgta2gNvP8Nk+R+HGxhGg6rrykNBb+lWTI5Ua+QAa7DBdW9uldLH4U+bf6mti90 171NAQA0VTrxV/dnkAxOmZ4jXogWhShrIyElD3PG6ZCxZ6W85/tdLReAyy/+feoQ OS+QdlYDrnYJlW0Bko254YAWJHk5hViy7feDFCHl+FuI/7hN3+UmKvpVloWkD7sh EpRqmAm8GtxAyaPsJtJVkWQ6s3YTkoYIZOSVUbItRWJbQvEfB/DDIYG6lTkGAxS5 cEUsoGMsqQbBK9QZf/s2 =TT3X -----END PGP SIGNATURE-----

1 0

Re: po: Revise Russian translation
by Nikolay Sivov 06 Apr '14

06 Apr '14

Looks good. I especially like changes like these: --- -msgstr "Пожалуйста, выберите файл." +msgstr "Выберите файл." ---

4 10

Re: [PATCH] ntdll: Don't enter uninterrupted section when get_cached_fd hits
by Ken Thomases 06 Apr '14

06 Apr '14

On Apr 5, 2014, at 5:25 PM, Daniel Horn wrote: > The call to server_enter_uninterrupted_section in server_get_unix_fd > was causing 2 million syscalls over the span of several seconds when > launching many popular application suites and it was causing > significant performance overhead. > > Switching those two lines resolves the problem entirely because the > cache is sized such that it nearly never misses. You can't call get_cached_fd() without entering the critical section because the critical section is protecting the fd cache. Your patch opens the code up to race conditions and data inconsistency. -Ken

2 5

Re: [PATCH 5/5] ddraw/tests: Add mipmap locking tests.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6163 Your paranoid android. === w8 (32 bit ddraw2) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === wvistau64 (64 bit ddraw7) === Unable to set the VM system time: the "nc -q0 '10.42.42.238' '4242'" command returned 1 === w2000pro (32 bit ddraw4) === Unable to set the VM system time: the "nc -q0 '10.42.42.139' '4242'" command returned 1

1 0

Re: [PATCH 2/2] d3d8/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6166 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6165 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Test locking of mipmap textures.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6162 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0006019E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x412120, got 0x412120.

1 0

Re: [PATCH 2/5] d3d8/tests: Add a test for (sub-) resource types.
by Marvin 04 Apr '14

04 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6160 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000501D8, got 00010048. device.c:3038: Test failed: Expected wndproc 0x412120, got 0x412120.

1 0

Re: [PATCH 3/5] d3d9/tests: Test locking of mipmap textures.
by Henri Verbeet 04 Apr '14

04 Apr '14

On 4 April 2014 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + hr = IDirect3DDevice9_CreateTexture(device, 4, 4, 2, 0, D3DFMT_X8R8G8B8, > + D3DPOOL_DEFAULT, &texture_dst, NULL); > + ok(SUCCEEDED(hr), "Failed to create texture, hr %#x.\n", hr); > + hr = IDirect3DTexture9_GetSurfaceLevel(texture_dst, 0, &surface_dst); > + ok(SUCCEEDED(hr), "Failed to get surface level, hr %#x.\n", hr); > + hr = IDirect3DTexture9_GetSurfaceLevel(texture_dst, 0, &surface_dst2); > + ok(SUCCEEDED(hr), "Failed to get surface level, hr %#x.\n", hr); > + This gets two references to the same surface level, is that intentional? > + hr = IDirect3DDevice9_UpdateSurface(device, surface, NULL, surface_dst, NULL); > + ok(SUCCEEDED(hr), "Failed to update surface, hr %#x.\n", hr); > + hr = IDirect3DDevice9_UpdateSurface(device, surface2, NULL, surface_dst2, NULL); > + todo_wine ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); > + Doesn't this just fail because the surface sizes are different? (Although I would have expected this to work.)

2 1

Re: [PATCH] ddraw: add dsurface dimension tests, try 7
by Stefan Dösinger 04 Apr '14

04 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks for the patch. I'll test it on my Windows boxes as soon as they're done with Linux updates (Gentoo...) and report any failures I find. Am 2014-04-03 17:54, schrieb Patrick Rudolph: + window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW, + 100, 100, 160, 160, NULL, NULL, NULL, NULL); + + if (!(ddraw = create_ddraw())) + { + skip("Failed to create a ddraw object, skipping test.\n"); + return; + } You no longer need the skip check here. The main functions in ddraw1-ddraw7 check if ddraw creation succeeds and skip all tests if it doesn't + + ret = IDirectDraw_SetCooperativeLevel(ddraw, window, DDSCL_NORMAL); + + ddcaps.dwSize = sizeof(DDCAPS); You're not checking the return value here. I also recommend to rename "ret" to "hr" for consistency with other tests. + ret = IDirectDraw_GetCaps(ddraw, &ddcaps, NULL); + if (ret != DD_OK) + { + skip("IDirectDraw_GetCaps failed with %08x\n", ret); + return; + } Do you have hardware where GetCaps fails? If not, a simple ok(SUCCEEDED(hr), ...) should be enough. +#if _WIN64 || __x86_64__ || __ppc64__ + { + MEMORYSTATUSEX statex; + statex.dwLength = sizeof (statex); + GlobalMemoryStatusEx (&statex); + /* on 64bit surfaces with 2GByte+ are possible */ + if(statex.ullAvailVirtual > 0x80000000LL) + tests[10].ret = DD_OK; + } +#endif Is the #if necessary? Afaics GlobalMemoryStatusEx should work on 32 bit as well. In light of the testbot failures I recommend to check for available physical memory as well. I'm also fine with just dropping the SYSMEM out of memory test until we find an application that depends on this behavior. The parenthesis placement after the function call and if are inconsistent. This applies to a few other ifs as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTPmKGAAoJEN0/YqbEcdMwUwEP/A5NCz4xe855Z9jX6iUBWkhw NDhpM/9Wbk5tdekaR3QcrNyCYGCAHnOl/kUsGXeBDwZxCDzRzpfsdpFp0Nux46m+ L/xtf71bhAMYGikeV9r/C+UVBbCslO4KXFcUmx5K43AXcVQGMq+K1yvzhGtKCGZb 6zNCUmhxI2MlNrU9KDp7W7kNhVWMu2ungAjojT5BmaWDgtvS6TWu10jX1rIwQlYF wMOHSIomIBNvPi2vSr8aXLzPhgFCrMg3g8fERUqS3Vk8LJfmJYWJ87hcfPiMGd5A ntDYedg+mhV0ShTk26XCeKMNBfvjcdwWCnHEi1GYmYQ6H/nRDGxkEO/TskiNLuNn IO/rV2TAO9SfzHzHO/VPCGdb6nISGICAP/oA2ryrhINdXtn6eq1kjqQsGUURlqlk Y46P55qgRleYCtqxHjrjhQXDL4anaKj3ApZjGRa9MVC2/SPvIe3UpjlHjN4oeAix ohiOiq7GL/PXXs0zLOKFeVdUoOYpCIuP7MsR/dX9KcJwYQ2U9GT6OEoQPhZT+/B7 Tpv1maEOnn+UCkvcW6BY2eAt3nsznvlKVb73D5t1tLp/LCbKiSqY+8Dk0f75YTyG hEXkawRFLjhXeA6db8ieb2GdftaAnfq1Vxa7wjF4igAccZIhySInrvdnOFhZ4rp+ djHZm23O6ml1uV8Qt0mW =yrSd -----END PGP SIGNATURE-----

1 1

libwine-print missing when compiling from source
by Alois Schlögl 04 Apr '14

04 Apr '14

When compiling wine from source according to instructions on http://wiki.winehq.org/Wine64 "Building a shared WoW64 setup (most likely what you want)" starting Igor Pro fails in the same way, as if libwine-print is not installed. I'm using debian7:x86_64, and IgorPro is working fine when the debian version of wine (v1.4.1) with libwine-print is installed. What do I need to do in order the have libwine-print when compiling wine from source ? -- Alois

3 4

Re: [1/5] include: Add dxva2api.idl
by Nikolay Sivov 04 Apr '14

04 Apr '14

On 4/4/2014 08:44, Michael Müller wrote: > This first set of patches adds the required interface definitions and > headers which are required for the dxva2 implementation. Please note > that the ugly names of the header files were not my idea, thats exactly > the same name how they're called by MS. Yes, looks like 8.3 rule no longer applies :) > > The last patch of the series implements stub functions for every member > of dxva2.dll, such that applications do not abort anymore when they hit > one of the stub exports. > > --- > include/Makefile.in | 1 + > include/dxva2api.idl | 534 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 535 insertions(+) > create mode 100644 include/dxva2api.idl > +cpp_quote("#if 0") > +typedef DWORD IDirect3DDevice9; > +typedef DWORD IDirect3DSurface9; > + > +typedef DWORD D3DFORMAT; > +typedef DWORD D3DPOOL; > +cpp_quote("#endif") First I thought it's a bit ugly, but apparently that's how it's done in SDK. > +enum > +{ > + DXVA2_PictureParametersBufferType = 0, > + DXVA2_MacroBlockControlBufferType = 1, > + DXVA2_ResidualDifferenceBufferType = 2, > + DXVA2_DeblockingControlBufferType = 3, > + DXVA2_InverseQuantizationMatrixBufferType = 4, > + DXVA2_SliceControlBufferType = 5, > + DXVA2_BitStreamDateBufferType = 6, > + DXVA2_MotionVectorBuffer = 7, > + DXVA2_FilmGrainBuffer = 8 > +}; > + > +enum > +{ > + DXVA2_VideoDecoderRenderTarget = 0, > + DXVA2_VideoProcessorRenderTarget = 1, > + DXVA2_VideoSoftwareRenderTarget = 2 > +}; > + You don't need explicit initializers in this case. > +[ > + object, > + uuid(a0cade0f-06d5-4cf4-a1c7-f3cdd725aa75), > + helpstring("IDirect3DDeviceManager9 Interface"), > + local > +] No need for helpstring(), it's only used definitions participating in typelibs.

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 7
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6141 Your paranoid android. === w8 (32 bit ddraw4) === The test timed out === wvistau64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w8 (32 bit ddraw2) === ddraw2.c:5071: Test failed: Got unexpected refcount 3. ddraw2.c:5090: Test failed: Got unexpected refcount 3. ddraw2.c:5097: Test failed: Got unexpected hr 0. ddraw2.c:5100: Test failed: Got unexpected refcount 3. ddraw2.c:5102: Test failed: Got unexpected refcount 2. ddraw2.c:5108: Test failed: Got unexpected hr 0. ddraw2.c:5111: Test failed: Got unexpected refcount 2. ddraw2.c:5113: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 8007000e === w2000pro (32 bit ddraw7) === The test timed out === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === wvistau64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w2008s64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e === w7pro64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 10 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 10 returned 8007000e

1 0

Re: [PATCH 5/5] ws2_32: Add an interactive test for interface change notifications.
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6142 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB4047 === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [PATCH] ddraw: add dsurface dimension tests, try 6
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6140 Your paranoid android. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4) === wvistau64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw4) === ddraw4.c:6603: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw4.c:6603: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit ddraw2) === ddraw2.c:740: Test failed: Got unexpected color 0x00000000. ddraw2.c:3120: Test failed: Got unexpected color 0x000000ff. === wvistau64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw2) === ddraw2.c:5744: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw2.c:5744: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w8 (32 bit dsurface) === dsurface.c:310: Test failed: Destination data after blitting is not correct dsurface.c:344: Test failed: Destination data after blitting is not correct dsurface.c:523: Test failed: Surface data after srckey blit does not match dsurface.c:548: Test failed: Surface data after src override key blit does not match dsurface.c:602: Test failed: Surface data after dest key blit does not match dsurface.c:628: Test failed: Surface data after dest key override blit does not match dsurface.c:690: Test failed: Surface data with src key and dest key blit does not match === w8 (32 bit ddraw1) === ddraw1.c:2828: Test failed: Got unexpected color 0x000000ff. ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === wvistau64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw1) === ddraw1.c:4641: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw1.c:4641: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2000pro (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit ddraw7) === ddraw7.c:3112: Test failed: Clear with count = 0, rect != NULL has color 0xff0000. ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. The test timed out === wvistau64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w2008s64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000 === w7pro64 (64 bit ddraw7) === ddraw7.c:6458: Test failed: Pixelformat D3DFMT_A8R8G8B8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_R5G6B5, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 9 returned 8007000e ddraw7.c:6458: Test failed: Pixelformat D3DFMT_P8, test 10 returned 00000000

1 0

Re: [PATCH 3/3] scrrun: Implement FreeSpace() for a drive
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6136 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1358: Test failed: got 0x00000000 filesystem.c:1482: Test failed: got DEADBEEF filesystem.c:1495: Test failed: got 0x00000000 filesystem.c:1510: Test failed: got 0x00000000 filesystem.c:1518: Test failed: got DEADBEEF filesystem.c:1524: Test failed: got DEADBEEF filesystem.c:1543: Test failed: got 0x00000000 filesystem.c:1564: Test failed: got DEADBEEF filesystem.c:1658: Test failed: got 0x00000000 filesystem.c:1672: Test failed: got DEADBEEF filesystem.c:1691: Test failed: got 0x00000000

1 0

Re: [PATCH 2/3] scrrun: Implement Read()
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6135 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1349: Test failed: got 0x00000000 filesystem.c:1473: Test failed: got DEADBEEF filesystem.c:1486: Test failed: got 0x00000000 filesystem.c:1501: Test failed: got 0x00000000 filesystem.c:1509: Test failed: got DEADBEEF filesystem.c:1515: Test failed: got DEADBEEF filesystem.c:1534: Test failed: got 0x00000000 filesystem.c:1555: Test failed: got DEADBEEF filesystem.c:1649: Test failed: got 0x00000000 filesystem.c:1663: Test failed: got DEADBEEF filesystem.c:1682: Test failed: got 0x00000000

1 0

Re: [PATCH 1/3] scrrun: Implement ReadAll()
by Marvin 03 Apr '14

03 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6134 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1349: Test failed: got 0x00000000 filesystem.c:1473: Test failed: got DEADBEEF filesystem.c:1486: Test failed: got 0x00000000 filesystem.c:1501: Test failed: got 0x00000000 filesystem.c:1509: Test failed: got DEADBEEF filesystem.c:1515: Test failed: got DEADBEEF filesystem.c:1534: Test failed: got 0x00000000 filesystem.c:1555: Test failed: got DEADBEEF

1 0

Re: apphelp: add a stub for SdbInitDatabase (try 2)
by Dmitry Timoshkov 03 Apr '14

03 Apr '14

Austin English <austinenglish(a)gmail.com> wrote: > + if (path) > + FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please report!\n", flags, debugstr_w(path)); > + else > + FIXME("stub: %08x %s\n", flags, debugstr_w(path)); What's the reason for this if/else? What exactly is not expected and why this matters for a stub? -- Dmitry.

2 2

Re: [3/6] widl: Avoid generating negative offsets for conformant arrays of strings. Take 2.
by Alexandre Julliard 02 Apr '14

02 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the patch limits the changes to conformant arrays of > strings in order to avoid unwanted changes to other pointer types. Didn't you say that midl is doing this for all arrays? Why doesn't this work in our case? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [6/6] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 02 Apr '14

02 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6118 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH] mshtml: Implemented numeral parsing in get_frame_by_name (try 2).
by Jacek Caban 02 Apr '14

02 Apr '14

Hi Qian, On 04/01/14 22:08, Qian Hong wrote: > diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c > index a57dfba..3d6323c 100644 > --- a/dlls/mshtml/htmlwindow.c > +++ b/dlls/mshtml/htmlwindow.c > @@ -379,6 +379,20 @@ HRESULT get_frame_by_name(HTMLOuterWindow *This, const WCHAR *name, BOOL deep, H This is not the right place to do it. See callers of the function. I don't think we want that behaviour in, for example, get_target_window. > UINT32 length, i; > nsresult nsres; > HRESULT hres = S_OK; > + VARIANT v, idx; > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = SysAllocString(name); > + VariantInit(&idx); > + hres = VariantChangeType(&idx, &v, VARIANT_LOCALBOOL, VT_I4); There are better ways to do that conversion, like strtolW. > + VariantClear(&v); > + if (SUCCEEDED(hres)) > + { > + hres = get_frame_by_index(This, V_I4(&idx), ret); > + VariantClear(&idx); > + return hres; > + } > + VariantClear(&idx); Clearing VARIANT of VT_I4 type is not really useful. Also, as Austin said, this definitely needs a test case. You may write that in JavaScript, if you prefer. See existing tests in *.html files. Cheers, Jacek

2 1

Re: mshtml: Added IHTMLTable::width property implementation.
by Jacek Caban 02 Apr '14

02 Apr '14

Hi Zhenbo, On 03/31/14 16:26, Zhenbo Li wrote: > As my test case shows, windows would truncate float numbers. > I considered VarInt() in oleaut32.dll, but I think to declare > var2str_length() is more clear. +static HRESULT var2str_length(nsAString *nsstr, const VARIANT *p) +{ + static WCHAR buf[64]; + static const WCHAR formatW[] = {'%','d',0}; + LONG width; + + switch(V_VT(p)) { + case VT_BSTR: + return nsAString_Init(nsstr, V_BSTR(p)); + case VT_R8: + width = (LONG)(V_R8(p)); + break; + case VT_R4: + width = (LONG)(V_R4(p)); + break; + case VT_I4: + width = V_I4(p); + break; + default: + FIXME("unsupported arg %s\n", debugstr_variant(p)); + return E_NOTIMPL; + } + sprintfW(buf, formatW, width); + return nsAString_Init(nsstr, buf); +} I would like to see this more generic. How about having var_to_nsstr? It seems to me that we don't really have to convert floats here. Gecko and/or getter may do that instead. If we really have to it here, then some sort of flags controlling helper behaviour on floats may be cleaner. + nsAString val; + HRESULT nsres; nsresult and HRESULT, although are very similar, are two different things and should not be mixed. + DOUBLE width; + + TRACE("(%p)->(%p)\n", This, p); + nsAString_Init(&val, NULL); + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); + + V_VT(p) = VT_BSTR; + nsres = return_nsstr(nsres, &val, &V_BSTR(p)); Please don't use return_nsstr this way. It's a strange helper with unusual behaviour in terms of freeing input parameters to make common Gecko wrapping functions cleaner. Using this for string conversion looks bad. Esp in this case, where it adds unneeded BSTR allocation in cases where the string is converted to int later. However, see bellow first. + if (nsres != S_OK) + return nsres; + + nsres = VarR8FromStr(V_BSTR(p), 0, 0, &width); + if (nsres == S_OK){ + VariantClear(p); + V_VT(p) = VT_I4; + V_I4(p) = (LONG)width; + } + return S_OK; +#define cmp_length(a,b) _cmp_length(__LINE__,a,b) +static void _cmp_length(unsigned line, VARIANT got, const char * exstr) +{ + static char buf[64]; + ok_(__FILE__,line) (V_VT(&got)==VT_BSTR || V_VT(&got)==VT_I4, + "V_VT is %hu, expected VT_BSTR(%hu) or VT_I4(%hu)\n", + V_VT(&got), VT_BSTR, VT_I4); + + if (V_VT(&got) == VT_BSTR){ + ok_(__FILE__,line) (!strcmp_wa(V_BSTR(&got), exstr), + "Expected %s, got %s\n", exstr, wine_dbgstr_w(V_BSTR(&got))); + } + else { + sprintf(buf, "%d", V_I4(&got)); + ok_(__FILE__,line) (!strcmp(buf, exstr), + "Expected %s, got %d\n", exstr, V_I4(&got)); + } +} This test should be stricter. You decide on the way to compare based on the value you received. This means that if the implementation always returns VT_BSTR, this will success as well. In fact, my quick testing suggests that native IE always returns string in this case. Also, please consider using more targeted helper so that test would look like: test_table_width(table, "11"); Thanks, Jacek

2 2

Re: [PATCH 3/3] winex11: Remove unused X11DRV_GET_DRAWABLE and struct x11drv_escape_get_drawable.
by Ken Thomases 02 Apr '14

02 Apr '14

On Mar 31, 2014, at 9:47 PM, Ken Thomases wrote: > --- > dlls/winex11.drv/init.c | 8 -------- > dlls/winex11.drv/x11drv.h | 9 --------- > 2 files changed, 17 deletions(-) > > <0003-winex11-Remove-unused-X11DRV_GET_DRAWABLE-and-struct.patch> Was there something wrong with this? Is it anticipated that the GET_DRAWABLE escape will be needed in the future? -Ken

2 2

Re: [PATCH] po: Update Russian translation
by Dmitry Timoshkov 02 Apr '14

02 Apr '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +" [/u] Разрегистрировать сервер.\n" This sounds very unusual, original Windows translation provides a much better wording: "/u - Отменяет регистрацию DLL". > +" [/s] Тихий режим (сообщения не выводятся).\n" Windows translation adds the quotes around "Тихий" in order to emphasize that this has nothing to do with sound. -- Dmitry.

2 4

how to use ced1401 linux driver from wine application ?
by Alois Schlögl 01 Apr '14

01 Apr '14

Hi, I'm trying to connect through wine the CED1401 device which is connected through USB. There is a driver in the linux staging tree, (linux-source-3.10/drivers/staging/ced1401/), which I've already compiled into my kernel. The module loads fine and becomes available when connecting to the device. The are several application software for Windows (e.g. ced1401 [1], Spike [2], Signal5, and we have also one running in Igor Pro). The software runs also on Wine, but fails to identify the connected hardware device. I've tried to find relevant information in the wiki; and especially, http://wiki.winehq.org/USB as well as wine developer guide, Chapter 8 Kernel modules. I've a rough idea what is missing, but would like asking what you think is missing, and how much effort it would take to get this working ? --Alois [1] http://appdb.winehq.org/objectManager.php?sClass=application&iId=15958 [2] http://appdb.winehq.org/objectManager.php?sClass=application&iId=9146

2 4

Re: [PATCH] mshtml: Implemented numeral parsing in get_frame_by_name.
by Austin English 01 Apr '14

01 Apr '14

On Tue, Apr 1, 2014 at 12:45 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Hi all, > > When passing a numeral like string as array index to the window object, > native IE correctly parses the string into an integer value while Wine > doesn't. This patch fix the problem. Here is one simply test case: > > Testcase: > 1 <html> > 2 <body> > 3 </body> > 4 <script type="text/javascript"> > 5 var iframeEl = document.createElement('iframe'); > 6 document.body.appendChild(iframeEl); > 7 document.write(window["0"]); //buggy in Wine builtin iexplore > 8 </script> > 9 </html> > > In theory this patch need some more tests, because the above test case is > far from perfect, fortunately we have the open source ECMAScript 3 > Conformance Test Suite ver. 0.2: > http://kangax.github.io/sputniktests-webrunner/ > > Before this patch, Wine builtin iexplore hangs on the first test case of > the ECMAScript 3 Conformance Test Suite, after the patch, the Conformance > Test Suite begin to run. Guess how far does it gone? To everyone's > surprise, now Wine builtin iexplore passes all 5228 tests in the test case: > > Current test: > 15_Native_ECMA_Script_Objects/15.11_Error_Objects/15.11.4_Properties_of_the_Error_Prototype_Object/S15.11.4_A4 > Tests completed: 5228 > Total errors: 0 > Total failures: 0 > Elapsed time: 7:40 > Status: Completed. Final score (errors + failures; less is better): 0 > > > This is definitely a great step of our Wine buitin iexplore, now our > version beats Microsoft IE7 a lot. > > Since now all ECMAScript 3 conformance tests passed, it is safe to assume > that this patch is absolutely correct and no extra test cases needed, so > I'm not going to contribute any C test case for it into our test framework > because it is just duplicate work and waste of time - What can you worry if > even the whole test suite passed? > Hi Qian, The tests are partially there to prove the implementation is correct, yes, but they are also there to prevent regressions. Someone in the future changing dlls/mshtml may not run those same tests and things will break, if there is a unit test in dlls/mshtml/tests, that is not the case. Cheers, Austin

1 0

Re: [2/2] shell32/tests: Mark some test results as broken.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6106 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2443: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1220: Test failed: expected 1 args, got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1541: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1573: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.shlexec.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\test file.noassoc", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtE989.tmp\wtE99A.tmp" Exec") WaitForSingleObject returned 258

1 0

Re: [1/2] shell32/tests: Remove todo handling from DDE tests.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6105 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2430: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1211: Test failed: expected 1 args, got 4 shlexec.c:2272: Test failed: argcA expected 5, but got 4 === w8 (32 bit shlexec) === shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.noassoc', but key not found or empty shlexec.c:139: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:139: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") WaitForSingleObject returned 258 shlexec.c:1532: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc") failed: rc=33 err=2 shlexec.c:1564: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtC8C2.tmp\test file.shlexec.noassoc', but key not found or empty

1 0

Wine GPU decoding
by Michael Müller 01 Apr '14

01 Apr '14

Hi, it is probably still a bit early, but nevertheless I would like to announce a feature I am currently working on and present you the first results. As some of you have already noticed (http://bugs.winehq.org/show_bug.cgi?id=35868) I've recently submitted some simple stub patches to add the dxva2 dll. The original purposes was to get a browser plugin working, which expects that this library is available, and otherwise refuses to run. The library exports some functions which are used by several applications (like VLC, Flash, Silverlight, ...) for GPU decoding. I started to work to on these functions and I want to present you a first result which you can see here: https://dl.dropboxusercontent.com/u/61413222/dxva2.png This is actually the windows version of VLC playing a MPEG2 movie with GPU acceleration using DXVA2. My implementation of dxva2 uses the VAAPI on Linux to do the actual gpu decoding and should support AMD, Intel and NVIDIA cards. Currently only MPEG2 decoding is supported as it is one of the easier codecs and other ones like H264 needs a lot more of buffers, which need be translated from the DXVA format to VAAPI. The second easiest codec to implement would be mpeg4 but as none of my graphic cards support mpeg4, I will most probably continue with VC-1. Anyway, I need to clean up the patches a bit as they add about 3000 new lines of code and test it with some other graphic cards before I can provide them, but there are also some problems, mostly d3d9 related, for which I would like to get your opinion. The most difficult part is that DXVA2 is completely based on Direct3D9Device and Direct3DSurface9. The DXVA2 places the output images into a Surface and the applications locks the surface to get the output data or simply presents it to the screen. Although it would be much more efficient to directly blit the data in the graphic card at least VLC reads it back into system memory as the decoding and output pipeline are separated. The problem is that I actually need to allocate twice the amount of memory for decoding. since I need to provide the Direct3D Surfaces to the application and I also need to provide buffers to VAAPI. This is not a big problem for mpeg2 since it only uses 3 output images as a B Frame can only reference the last and the next frame. Anyway, for H264 this is getting insane as it requires to store up to 16 output images so that i would need to allocate 16 VAAPI buffers and 16 Direct3D surfaces. Currently i lock both kind of buffers after rendering a frame and do the synchronization in system memory, which is kind of inefficient depending on the surface type. My original idea was to do the copy in the graphic card as I can copy the image to a texture after decoding, but after Sebastian implemented this part we found out that the VAAPI implies a format conversion to RGB when copying data to a texture. This is actually a no go since VLC will refuse to use hardware acceleration when the output format is RGB. I also think it is kind of stupid to convert the RGB data back to YUV so that we end up with 3 color coder conversion (YUV->RGB->YUV->RGB). Some Intel developer wrote (see vaCopySurfaceGLX() at http://markmail.org/message/a3sav6q3dm5qvmat) that it would be possible to implement a copy in NV12 format for NVIDIA and Intel but not AMD. We could try to ask them to implement it, so that we can at least do it efficient for these two vendors. Anyway, if other applications continue to copy the data back to system memory it might be better to instead wrap the VAAPI buffers as Direct3D9 surfaces so that we can directly map the VAAPI buffers when LockRect() is called instead of copying the data. Though this would imply problems when the applications tries to pass this interface to Present(). So what do the wined3d guys think? Is it better to convince the Intel developers to allow a copy in YUV format and copy the data directly into the texture of an Direct3D9 surface or wrap the VAAPI buffers as Direct3D9Surface and add some glue code when an applications tries to render it? Or do you have any better ideas? Regards, Michael

4 8

RE: [PATCH] regsvr32: Fix some usage message issues
by Hugh McMaster 01 Apr '14

01 Apr '14

On Tuesday, 1 April 2014 4:34 PM, Nikolay Sivov wrote: > - regsvr32 itself is not a server or service > - it doesn't unregister a module from a server, module IS a server in this context The actual executable in XP and W7 describes itself a "registration server". But I'm happy to go with this change if you believe it is appropriate. There is also the RC define to consider: #define WINE_FILEDESCRIPTION_STR "Wine Register Server" >When used with [/u], regsvr32 also calls DllInstall in uninstall mode.\n > - there's no such thing as 'DLL Uninstall', same DllInstall call is used in both cases This is true; Lauri Kenttä raised that point in this post: http://www.winehq.org/pipermail/wine-devel/2014-March/103671.html In the following discussion, Lauri and Austin English chose to remove the additional reference to 'regsvr32' and 'also'. The preferred option was this text: [/i] Call DllInstall, passing an optional [cmdline]. When used with [/u], calls DllInstall to uninstall the DLL. Of course, your change reflects the original dialog: When used with [/u], regsvr32 also calls DllInstall in uninstall mode. Perhaps you could change it to: When used with [/u], calls DllInstall in uninstall mode. I'm not sure which option would be preferred. Free free to patch using the dialog from the linked thread.

2 2

Re: [1/6] widl: Pass type attributes from write_array_tfs to write_pointer_description. Resend.
by Alexandre Julliard 01 Apr '14

01 Apr '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). > > This version of the patch limits write_array_tfs() to pass attributes > to write_pointer_description() only for strings and avoids unwanted > changes to other pointer types. > > In order to test changes in the widl generated code under Windows > and make sure that widl generates the correctly working code I had > to compile widl with PSDK tools. This way I was able to test both > 32-bit and 64-bit generated code. All the patches in this sequence > have been tested under Windows as well as under Wine in both 32-bit > and 64-bit builds of the rpcrt4 Wine tests. It's also failing in 32-bit now (with the whole series applied): ../../../tools/runtest -q -P wine -T ../../.. -M ieframe.dll -p ieframe_test.exe.so ie && touch ie.ok ie.c:154: Test failed: FindConnectionPoint failed: 800706ba ie.c:177: Test failed: get_Visible failed: 800706ba ie.c:181: Test failed: put_Visible failed: 800706ba ie.c:185: Test failed: get_Visible failed: 800706ba ie.c:186: Test failed: Visible = 800706ba ie.c:189: Test failed: put_Visible failed: 800706ba ie.c:199: Test failed: Could not get IServiceProvider iface: 80004002 wine: Unhandled page fault on read access to 0x00000000 at address 0x6862ae92 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6100 Your paranoid android. === build (build) === Make failed

1 0

Re: msi: Fix infinite loop.
by Hans Leidekker 01 Apr '14

01 Apr '14

On Mon, 2014-03-31 at 16:48 -0500, Vincent Povirk wrote: > This loop never exits if progid->Parent == progid and there is no > class. There are other checks for that in the file, so I assume that > condition is supposed to be possible. Right, nothing keeps you from defining circular dependencies.

1 0

Re: [PATCH 1/2] ole32: Fix equality check in CommonPrefixWith() for pointer moniker (try2)
by Marvin 01 Apr '14

01 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6093 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: regsvr32: Replace printf calls with WriteConsole function (try 2)
by Lauri Kenttä 01 Apr '14

01 Apr '14

Sorry for being a bit late... Hugh McMaster wrote: > - printf("\t[/i] Call DllInstall passing it an optional > [cmdline];\n"); > - printf("\t when used with /u calls dll uninstall\n"); > +\ [/i] Call DllInstall, passing an optional [cmdline].\n\ > +\tWhen used with [/u], regsvr32 also calls DLL Uninstall.\n\ This whole "calls DLL Uninstall" thing is a bit weird, as there isn't a function named DLL Uninstall or DllUninstall. Maybe you should change it to something more exact like: "When used with [/u], " + 1) "passes [also] the uninstall flag [to DllInstall]" 2) "uses DllInstall to uninstall the DLL" 3) "the bInstall parameter is set to FALSE" 4) "calls DllInstall with bInstall set to FALSE" or something similar. Opinions? If this is too radical, I'd suggest that you at least remove the "also". With my English, it now says that regsvr32 /i /u calls DllInstall and also calls DLL Uninstall, which is clearly neither true nor logical. (It really calls UnregisterDll and DllInstall(FALSE,cmdline).) In addition, repeating "regsvr32" looks strange to me in this kind of context. -- Lauri Kenttä

3 4

Re: [PATCH 6/6] user32: Implement EnumDisplayDevicesW() based on EnumDisplayMonitors() and GetMonitorInfoW().
by Alexandre Julliard 31 Mar '14

31 Mar '14

Ken Thomases <ken(a)codeweavers.com> writes: > For <http://bugs.winehq.org/show_bug.cgi?id=34978>. > --- > dlls/user32/misc.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 84 insertions(+), 12 deletions(-) I think it should be the other way around, with EnumDisplayDevices being the main function, with some sort of centralized management of display devices. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/2] docobj.idl: Added some new OLDCMDID values.
by Dmitry Timoshkov 31 Mar '14

31 Mar '14

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > include/docobj.idl | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) A typo in the commit message: OLD -> OLE. -- Dmitry.

1 0

Re: apphelp: add a stub for SdbInitDatabase
by Hans Leidekker 31 Mar '14

31 Mar '14

On Sun, 2014-03-30 at 14:36 -0700, Austin English wrote: > +PDB WINAPI SdbInitDatabase(DWORD flags, LPCSTR path) > +{ > + FIXME("stub: %u %s\n", flags, debugstr_a(path)); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return NULL; > +} Return type should be HSDB. Please trace flags in hex.

1 0

Re: mshtml: Added IHTMLTable::bgColor property implementation.
by Nikolay Sivov 30 Mar '14

30 Mar '14

On 3/30/2014 19:18, Zhenbo Li wrote: > + nsAString_Init(&strColor, NULL); > + nsres = nsIDOMHTMLTableElement_GetBgColor(This->nstable, &strColor); > + nsAString_Finish(&strColor); > + > + if(NS_SUCCEEDED(nsres)) { > + nsAString_GetData(&strColor, &color); > + V_VT(p) = VT_BSTR; > + hres = nscolor_to_str(color, &V_BSTR(p)); > + }else { > + ERR("SetBgColor failed: %08x\n", nsres); > + hres = E_FAIL; > + } I think you can't do GetData() after Finish().

1 0

Re: [PATCH] comctl32/tests: Fix a couple of uninitialized variables (Coverity)
by Marvin 30 Mar '14

30 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6070 Your paranoid android. === wvistau64 (32 bit button) === button.c:654: Test failed: BM_SETCHECK on a button: the msg sequence is not complete: expected 0000 - actual 000f

2 1

Re: [PATCH 1/2] ole32: Fix equality check in CommonPrefixWith() for pointer moniker
by Marvin 30 Mar '14

30 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6068 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 004256A9 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000042024A

1 0

Re: [1/2] ntdll/tests: Add tests for RtlUnicodeToUTF8N.
by Nikolay Sivov 29 Mar '14

29 Mar '14

On 3/29/2014 20:16, Thomas Faber wrote: > + /* output truncation */ > +#define truncate_expect(len, out_len, expect_status) do { \ > + bytes_out = 0x55555555; \ > + memset(buffer, 0x55, sizeof(buffer)); \ > + status = pRtlUnicodeToUTF8N( \ > + buffer, len, &bytes_out, \ > + special_string, sizeof(special_string)); \ > + ok(status == (expect_status), "status = 0x%x\n", status); \ > + ok(bytes_out == (out_len), "bytes_out = %u\n", bytes_out); \ > + for (i = 0; i < bytes_out; i++) \ > + ok(buf[i] == special_expected[i], \ > + "buffer[%d] = 0x%x\n", i, buf[i]); \ > + for (; i < sizeof(buffer); i++) \ > + ok(buf[i] == 0x55, "buffer[%d] = 0x%x\n", i, buf[i]); \ > + } while (0) It's better to avoid large macros like this one. A common way to do that is to move code to another function and call it with a single line macro, for line information ok_() should be used.

2 1

How to cross-compile wine?
by Akira Nakagawa 29 Mar '14

29 Mar '14

./configure --host=arm-linux-androideabi then it said --with-wine-tools was needed. What do I set to the option? -- Akira Nakagawa <matyapiro31(a)gmail.com>

1 0

MS releases vintage DOS source code
by Michael Stefaniuc 28 Mar '14

28 Mar '14

Not directly relevant to us as DOS got outsourced to dosbox but here it is nevertheless: http://www.computerhistory.org/atchm/microsoft-ms-dos-2-0-source-code/ If they keep releasing the source roughly 30 years after the OS hit the market, then Windows 3.11 is still 10 years out. bye michael

3 2

Re: [3/3] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Alexandre Julliard 28 Mar '14

28 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/rpcrt4/tests/server.c | 55 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 5 ++++ > 2 files changed, 60 insertions(+) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M rpcrt4.dll -p rpcrt4_test.exe.so server && touch server.ok server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process server.c:1240: Test failed: expected Hello, got H server.c:1241: Test failed: expected World!, got W server.c:1250: Test failed: expected Hello, got L"H\0003" server.c:1251: Test failed: expected World!, got L"W\0001" server: 4 failures in child process make[1]: *** [server.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/6] winemac: Make ChangeDisplaySettingsEx() operate on the display named by the devname parameter.
by Ken Thomases 28 Mar '14

28 Mar '14

Hi, The first two patches in this series aren't quite right. Please don't commit them. They don't do the right thing with the registry settings. Patches 3 through 6 can be applied independently and are useful, so they can still be committed. (Bug 34978 won't quite be solved because DisplayFusion will be confused by enumerating the wrong modes for the second display.) -Ken

1 0

Re: user32: Change SetForegroundWindow behavior on windows with parent and no WS_CHILD flag
by Marvin 27 Mar '14

27 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6025 Your paranoid android. === w8 (32 bit win) === win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6433: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6433: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6455: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:6216: Test failed: wrong error 31

1 0

Re: loader: Add registry keys for Hidden and HideFileExt.
by Alexandre Julliard 26 Mar '14

26 Mar '14

Rico Schüller <kgbricola(a)web.de> writes: > --- > loader/wine.inf.in | 2 ++ > 1 file changed, 2 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlfolder && touch shlfolder.ok shlfolder.c:817: Test failed: SetNameOf failed! hr = 80004005 make: *** [shlfolder.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Change SetFocus behavior on windows with parent and no WS_CHILD flag
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6004 Your paranoid android. === w8 (32 bit win) === win.c:6205: Test failed: wrong error 31

1 0

Re: [PATCH 10/10] d3d9/tests: Use a separate device for alphatest_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6001 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 09/10] d3d9/tests: Use a separate device for viewport_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6000 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 08/10] d3d9/tests: Use a separate device for test_constant_clamp_vs().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5999 Your paranoid android. === w8 (32 bit visual) === visual.c:7387: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7372: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 07/10] d3d9/tests: Use a separate device for test_compare_instructions().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5998 Your paranoid android. === w8 (32 bit visual) === visual.c:7357: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7342: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7342: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 06/10] d3d9/tests: Use a separate device for test_mova().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5997 Your paranoid android. === w8 (32 bit visual) === visual.c:7325: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7310: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7310: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 05/10] d3d9/tests: Use a separate device for loop_index_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5996 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 04/10] d3d9/tests: Use a separate device for sincos_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5995 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 03/10] d3d9/tests: Use a separate device for sgn_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=5994 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 02/10] d3d9/tests: Use a separate device for clip_planes_test().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5993 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 01/10] d3d9/tests: Use a separate device for test_vshader_input().
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5992 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [2/2] netcfgx: Add INetCfgLock support (try 2)
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5989 Your paranoid android. === build (build) === Make failed

2 1

Re: [2/2] netcfgx: Add INetCfgLock support
by Marvin 26 Mar '14

26 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5988 Your paranoid android. === build (build) === Make failed

1 0

Re: setupapi: Don't confuse ARM with ARM64
by Qian Hong 25 Mar '14

25 Mar '14

On Wed, Mar 26, 2014 at 2:46 AM, André Hentschel <nerv(a)dawncrow.de> wrote: > "You screwed up but AJ missed it, send a fix before someone notices" ;-) André, you really should hide some bugs in your code as an evidence to proving someone stolen your code <grin> -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: mshtml: Added IHTMLTableRow::bgColor property implementation.
by Alexandre Julliard 25 Mar '14

25 Mar '14

Zhenbo Li <litimetal(a)gmail.com> writes: > As MSDN said, bgColor property can be a VARIANT of type VT_BSTR or > VT_I4 that receives one of the color names or RGB values in the Color > Table.[1] So I declared variant_to_nscolor(from htmlbody.c) in > mshtml_private.h > > [1]: http://msdn.microsoft.com/en-us/library/aa741715%28v=vs.85%29.aspx > --- > dlls/mshtml/htmlbody.c | 2 +- > dlls/mshtml/htmltablerow.c | 29 +++++++++++++++++++++++++---- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/tests/dom.c | 37 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+), 5 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok dom.c:5641: Test failed: get_bgColor returned L"red" dom.c:5653: Test failed: get_bgColor returned L"#Ff0000" make: *** [dom.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: Avoid a variable-length array.
by Bruno Jesus 25 Mar '14

25 Mar '14

On Tue, Mar 25, 2014 at 7:59 AM, Thomas Faber <thomas.faber(a)reactos.org> wrote: > > #ifdef HAS_IRDA > +#define MAX_IRDA_DEVICES 10 > + I guess you could #undef before the #endif for HAS_IRDA since the define is no longer used, but that is just my opinion.

2 1

Re: [PATCH 1/5] d3d9/tests: Use a separate device for test_vshader_input().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5937 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

2 1

Re: [PATCH 5/5] d3d9/tests: Use a separate device for loop_index_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 4/5] d3d9/tests: Use a separate device for sincos_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5940 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 3/5] d3d9/tests: Use a separate device for sgn_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5939 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: [PATCH 2/5] d3d9/tests: Use a separate device for clip_planes_test().
by Marvin 25 Mar '14

25 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5938 Your paranoid android. === w8 (32 bit visual) === visual.c:7297: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00 visual.c:7282: Test failed: Input test: Quad 2(1crd) returned color 0x00000000, expected 0x00ffff00

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf. (try 2)
by Nikolay Sivov 25 Mar '14

25 Mar '14

On 3/19/2014 17:02, Jactry Zeng wrote: > Update: > - Add a todo_wine. > > + ITextDocument_Open(txtDoc, &testfile, tomReadOnly|tomRTF, CP_ACP); It's a common practice to check a return value. > + /* open a rtf without } in the end */ > + result = ITextDocument_Open(txtDoc, &testfile, tomReadOnly, CP_ACP); > + /* 0x80070026 is HRESUILT_FROM_WIN32(ERROR_HANDLE_EOF) */ > + todo_wine ok(result == 0x80070026, "ITextDocument_Open: Should return an ERROR_HANDLE_EOF error.\n"); No need to put a magic number, use HRESULT_FROM_WIN32(), and don't forget to use proper type for return value. Also a typo in a comment, but that it go anyway.

2 1

Re: wintab: Incorrectly classifying cursor as stylus instead of eraser
by Alexandre Julliard 25 Mar '14

25 Mar '14

Eriks Dobelis <eriks.dobelis(a)biti.lv> writes: > Did not attach the patch in my last email :( > > For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly > detected as stylus. > The tablet returns its eraser cursor name as: > Wacom Intuos PT S Pen eraser > and type as: > ERASER > > Current code classifies this as STYLUS, because name of the cursor > contains the word 'Pen'. It is very unlikely that a cursor with type > ERASER is STYLUS. There is already a check for eraser type, you should be able to use that instead. -- Alexandre Julliard julliard(a)winehq.org

4 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel