- wine-devel - winehq.org

GSoC 2014: Student application period is almost over!
by Austin English 20 Mar '14

20 Mar '14

Howdy everyone, If you're a student that wants to apply for GSoC 2014, you have until tomorrow*, **March 21 at 19:00 UTC*, to submit your proposals. See https://www.google-melange.com/gsoc/events/google/gsoc2014 for the timeline, and https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine I'd like to also remind students that a patch or testcase must have been submitted to wine before to be considered. It is not required to have been accepted, but you must show that you are able to build/tinker on wine's source code. See http://wiki.winehq.org/SummerOfCode and http://wiki.winehq.org/SubmittingPatches for more info. Good luck! -- -Austin

1 0

Re: [PATCH 3/6] d3d8: Use the private store api for buffers.
by Henri Verbeet 20 Mar '14

20 Mar '14

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (stored_data->flags & WINED3DSPD_IUNKNOWN) > + { > + *(IUnknown **)data = stored_data->content.object; > + IUnknown_AddRef(*(IUnknown **)data); > + } > + else > + memcpy(data, stored_data->content.data, stored_data->size); + if (stored_data->flags & WINED3DSPD_IUNKNOWN) + IUnknown_AddRef(stored_data->content.object); + memcpy(data, stored_data->content.data, stored_data->size);

1 0

Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).
by Henri Verbeet 20 Mar '14

20 Mar '14

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!(caps.ddraw_caps.caps & WINEDDCAPS_3D)) > + { > + WARN("Created a wined3d object without 3D support.\n"); > + wined3d_decref(d3d8->wined3d); > + goto done; > + } I don't think that really matches Windows. Going by the testbot results, I think creating a D3D object should succeed, and creating a (hardware) device should fail.

2 5

Re: [PATCH] scrrun/tests: Update idl file in tests
by Marvin 20 Mar '14

20 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5791 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

2 1

Re: regsvr32: Replace printf calls with WriteConsole function (try 2)
by Akihiro Sagawa 20 Mar '14

20 Mar '14

On Tue, 18 Mar 2014 21:26:30 -0400, Hugh McMaster wrote: > This patch adds the function output_write to regsvr32.c. The function > calls LoadString, FormatMessage and WriteConsole to output string text > to the console. This patch sequence looks nice. It will resolve bug 28189. Thanks, Akihiro Sagawa

1 0

Re: [2/4] widl: Pass type attributes from write_array_tfs to write_pointer_description.
by Alexandre Julliard 20 Mar '14

20 Mar '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This allows to differentiate strings and write appropriate rpc type > (FC_C_C[W]STRING instead of FC_[W]CHAR). It also changes some pointers from UP to RP, that doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

2 7

wintab32: fixing a typo which prevented sending correct pkSerialNumber
by Eriks Dobelis 20 Mar '14

20 Mar '14

This submission Obsoletes patch id#103302. I split it into parts for easier review and will later submit the rest of patches, but each of them will resolve a single issue and they are not interdependent. Common goal is to resolve http://bugs.winehq.org/show_bug.cgi?id=18517. This patch fixes a typo in a code, which was a cause for wrong pkSerialNumber values to be sent in messages. TRACE entries showed correct values, because TRACE statement was executed before actual sending of the packet. Due to this it took quite a time to spot the problem :) dlls/wintab32/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

2 1

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

Did not attach the patch in my last email :( For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

wintab: Incorrectly classifying cursor as stylus instead of eraser
by Eriks Dobelis 20 Mar '14

20 Mar '14

For Wacom Pen & Touch Intuos tablet eraser cursor is incorrectly detected as stylus. The tablet returns its eraser cursor name as: Wacom Intuos PT S Pen eraser and type as: ERASER Current code classifies this as STYLUS, because name of the cursor contains the word 'Pen'. It is very unlikely that a cursor with type ERASER is STYLUS. With the patch eraser is correctly detected. Without the patch eraser works as stylus. dlls/winex11.drv/wintab.c | 3 +++ 1 file changed, 3 insertions(+)

1 0

Re: [4/4] rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Resend.
by Marvin 20 Mar '14

20 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5800 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH]msvcr110: added missing functions in msvcr110.spec
by Piotr Caban 20 Mar '14

20 Mar '14

On 03/19/14 23:39, Natalino Cordeiro wrote: > +@ stub -arch=arm ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ > @ stub -arch=win32 ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ The ?_NewTokenState@_CancellationTokenState@details@Concurrency@@SAPAV123@XZ function is already exported on arm (there's other entry with the same name and -arch=win32 specifier). > -@ stub -arch=i386,win64 __crtCompareStringEx > +@ stub -arch=arm,i386,win64 __crtCompareStringEx It's not really important but in this case -arch option may be removed. Cheers, Piotr

1 0

Re: gdi32/tests: GetGlyphOutlineA is broken for johab charset on windows.
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c

1 0

Re: riched20/tests: Add tests for ITextDocument::Open about dealing with rtf.
by Alexandre Julliard 19 Mar '14

19 Mar '14

Jactry Zeng <jactry92(a)gmail.com> writes: > From 4b124d86198a9ed553a5f6cfd924584769495a1f Mon Sep 17 00:00:00 2001 > From: Jactry Zeng <jactry92(a)gmail.com> > Date: Sat, 15 Mar 2014 00:39:57 +0800 > Subject: riched20/tests: Add tests for ITextDocument::Open about dealing with > rtf. > > --- > dlls/riched20/tests/richole.c | 70 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so richole && touch richole.ok richole.c:445: Test failed: ITextDocument_Open: Should return an ERROR_HANDLE_EOF error. make[1]: *** [richole.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Alexandre Julliard 19 Mar '14

19 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/focus.c | 1 + > dlls/user32/tests/win.c | 4 ++++ > 2 files changed, 5 insertions(+) > > > > diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c > index bd2e572..c47a82d 100644 > --- a/dlls/user32/focus.c > +++ b/dlls/user32/focus.c > @@ -277,6 +277,7 @@ HWND WINAPI SetFocus( HWND hwnd ) > HWND parent; > LONG style = GetWindowLongW( hwndTop, GWL_STYLE ); > if (style & (WS_MINIMIZE | WS_DISABLED)) return 0; > + if (!(style & WS_CHILD)) break; It doesn't look right to allow setting focus if a parent is disabled. This would need more tests. Also please write a better description of the change, "improve implementation" is not very helpful. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: Improve SetFocus implementation
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5775 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6410: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6410: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6432: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6193: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1

Re: [PATCH 2/2] user32: Improve SetForegroundWindow implementation
by Marvin 19 Mar '14

19 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0156 fg 00010048 in hook HCBT_ACTIVATE win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6405: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6405: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6427: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6188: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Ideas about mshtml for GSoC 2014
by Zhenbo Li 19 Mar '14

19 Mar '14

Hello, I'm Zhenbo Li, a student in Shanghai JiaoTong University, China. I have been a Wine user for almost 4 years, and I've been preparing for GSoC for several month. Since 2013, I've translated some wiki pages into Chinese[1], reported nearly 40 bugs[2], involved in Appdb[3], and sent few patches[4]. I'm glad to do more contribution to Wine in 2014. While using Wine, it is common to face a bug in mshtml[5]. Native iexplore may be a workaround, but it can cause other problems, too. So my idea is to implement some functions in mshtml.dll. I have a rough plan now, and I wish to get your advice. As I have about 3 months, I want to implement some functions in IHTMLTable, IHTMLTableCol, etc., and write testcaes for them. I've written some draft patches for IHTMLTableRow, and I'll send them to wine-patches after improving them with your advice. I hope I can establish a proper schedule after communicating with my mentor. I'm also open to any suggestion, and any comment or advice is great appreciated. Thank you. FYI, my first name is Zhenbo, and my last(family) name is Li. So Zhenbo Li and Li Zhenbo means the same person lol. [1]: I contributed to FAQ, RegressionTesting, Bugs, etc. [2]: http://bugs.winehq.org/buglist.cgi?email1=litimetal%40gmail.com&emailreport… [3]: http://appdb.winehq.org/objectManager.php?sClass=maintainerView&iId=281642 [4]: http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Zhenbo+Li [5]: http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&list_id=141898&namedcmd… -- Have a nice day! Zhenbo Li

3 6

Re: include: Added netcfgx.idl
by Nikolay Sivov 19 Mar '14

19 Mar '14

On 3/19/2014 08:48, Alistair Leslie-Hughes wrote: > + uuid(C0E8AE93-306E-11D1-AACF-00805FC1270E) Please use lower case for uuids.

1 0

GSOC 2014
by Udayan Tandon 19 Mar '14

19 Mar '14

Hi, I’m Udayan Tandon. Im studying computer science in India at the Indraprastha Institute of Information Technology-Delhi. I’ve been studying and coding in C for the past year. Im enthusiastic to take part in GSoC 2014 and the wine project is really interesting. Im interested in the project "CMD:implement more robust parser" and would like if you could the course action as to what to do in this project. Regards Udayan Tandon

2 1

Re: ntoskrnl.exe: Add Stub MmUnlockPagableImageSection
by Dmitry Timoshkov 19 Mar '14

19 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +VOID MmUnlockPagableImageSection(PVOID ImageSectionHandle) > +{ > + FIXME("stub %p\n", ImageSectionHandle); > +} Calling convention specifier is missing. -- Dmitry.

1 0

Re: ntoskrnl.exe: Add Stub KeInsertQueue
by Dmitry Timoshkov 19 Mar '14

19 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +LONG KeInsertQueue(PRKQUEUE Queue, PLIST_ENTRY Entry) > +{ > + FIXME( "stub: %p %p\n", Queue, Entry ); > + return 0; > +} Calling convention specifier is missing. -- Dmitry.

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (resend).
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5762 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

GSoC - Winetest Graphical User Interface
by chanchengcc＠gmail.com 18 Mar '14

18 Mar '14

Hi Developers! I am Chan, a Computer Science undergraduate from Zhejiang University, China. I am interested in the project Winetest Graphical User Interface. I've learnt about C/C++/Java programming in school, I've developed an android app (automatically login to the EAS and fetch the info we need) by my own and I've also learnt about OpenGL in class. I believe that I am capable for this project. I heard about the GSoC program yesterday and I realize that it may be a little bit late for application. So I am wondering if there's any chance I can get the opportunity to join the program and work on this project? Thank you a lot for your attention. If there's any question, please feel free to contact me. I'm looking forward to hear from the mentors. Sincerely, Chan 发自 Windows 邮件

2 1

New Idea for GSOC 2014
by Naveen Sangtani 18 Mar '14

18 Mar '14

Hi sir , As you Have mentioned that we can come up with our own idea ; So , i have one such Hope to hear from you Soon. Please find attachment Thanks

1 0

Re: how to build wine with USB support ?
by Hin-Tak Leung 18 Mar '14

18 Mar '14

------------------------------ On Tue, Mar 18, 2014 1:56 PM GMT Alois Schlögl wrote: >On 2014-03-17 17:22, Uwe Bonnes wrote: >>>> "Alois" == Alois Schlögl <alois.schloegl(a)gmail.com> writes: >> >> Alois> In one case, HKLM\System\CurrentControlSet\Services\<driver name> >> Alois> points to system32\Driver\hidusb.sys; >> >> Can you show the exports of hidusb.sys? Maybe it is also a good candidate for >> a replacement dll. >> >> Bye >> > > >I'm not sure how to export that information. nm does not work because >its a sys file. >pefile gives quite some information but no export section. grep Hint >pefile_output lists this: > Does winedump -j export... Not work? >ntoskrnl.exe.ExFreePool Hint[77] >ntoskrnl.exe.ExAllocatePoolWithTag Hint[65] >ntoskrnl.exe.KeSetEvent Hint[598] >ntoskrnl.exe.IofCallDriver Hint[482] >ntoskrnl.exe.KeWaitForSingleObject Hint[621] >ntoskrnl.exe.MmMapLockedPages Hint[687] >ntoskrnl.exe.InterlockedDecrement Hint[278] >ntoskrnl.exe.IoBuildDeviceIoControlRequest Hint[302] >ntoskrnl.exe.InterlockedIncrement Hint[281] >ntoskrnl.exe.KeResetEvent Hint[588] >ntoskrnl.exe.InterlockedExchange Hint[279] >ntoskrnl.exe.IoInvalidateDeviceState Hint[385] >ntoskrnl.exe.IoQueueWorkItem Hint[401] >ntoskrnl.exe.InterlockedCompareExchange Hint[277] >ntoskrnl.exe.IoAllocateWorkItem Hint[294] >ntoskrnl.exe.IoCancelIrp Hint[307] >ntoskrnl.exe.KeTickCount Hint[614] >ntoskrnl.exe.KeBugCheckEx Hint[502] >ntoskrnl.exe.PoCallDriver Hint[822] >ntoskrnl.exe.KeInitializeSpinLock Hint[542] >ntoskrnl.exe.KeInitializeEvent Hint[536] >ntoskrnl.exe.IoFreeWorkItem Hint[355] >ntoskrnl.exe.IofCompleteRequest Hint[483] >HIDCLASS.SYS.HidRegisterMinidriver Hint[3] >USBD.SYS.USBD_ParseConfigurationDescriptorEx Hint[22] >USBD.SYS.USBD_CreateConfigurationRequestEx Hint[6] > > >-- Alois > >

2 1

how to build wine with USB support ?
by Alois Schlögl 18 Mar '14

18 Mar '14

Hi I'm trying to use USB devices for Data acquisition on wine. The recording software is proprietary, but runs on wine. (It IgorPro with some binary called FPulse, and MultiClamp Commander 700B). The problem occurs only when trying to connect to the recording device through USB. I've already found the page [1] and trying to build wine with the recommended patch. Unfortunately, the current patches [2] do not apply cleanly to the most recent version of wine-git. Therefore, I'm asking what the recommended approach is ? Is there a more recent set up patches ? The once from [2] have been updated last in Jun 2012 ? Or would you recommend using the sources of wine from that date ? Kind regards, Alois [1] http://wiki.winehq.org/USB [2] ftp://ftp.etersoft.ru/pub/people/amorozov/usb/current/

3 7

Re: how to build wine with USB support ?
by Hin-Tak Leung 18 Mar '14

18 Mar '14

------------------------------ On Tue, Mar 18, 2014 1:56 PM GMT Alois Schlögl wrote: >On 2014-03-17 17:22, Uwe Bonnes wrote: >> "Alois" == Alois Schlögl <alois.schloegl(a)gmail.com> writes: > > Alois> In one case, HKLM\System\CurrentControlSet\Services\<driver name> > Alois> points to system32\Driver\hidusb.sys; > > Can you show the exports of hidusb.sys? Maybe it is also a good candidate for > a replacement dll. > > Bye > > > >I'm not sure how to export that information. nm does not work because >its a sys file. >pefile gives quite some information but no export section. grep Hint >pefile_output lists this: > >ntoskrnl.exe.ExFreePool Hint[77] >ntoskrnl.exe.ExAllocatePoolWithTag Hint[65] >ntoskrnl.exe.KeSetEvent Hint[598] >ntoskrnl.exe.IofCallDriver Hint[482] >ntoskrnl.exe.KeWaitForSingleObject Hint[621] >ntoskrnl.exe.MmMapLockedPages Hint[687] >ntoskrnl.exe.InterlockedDecrement Hint[278] >ntoskrnl.exe.IoBuildDeviceIoControlRequest Hint[302] >ntoskrnl.exe.InterlockedIncrement Hint[281] >ntoskrnl.exe.KeResetEvent Hint[588] >ntoskrnl.exe.InterlockedExchange Hint[279] >ntoskrnl.exe.IoInvalidateDeviceState Hint[385] >ntoskrnl.exe.IoQueueWorkItem Hint[401] >ntoskrnl.exe.InterlockedCompareExchange Hint[277] >ntoskrnl.exe.IoAllocateWorkItem Hint[294] >ntoskrnl.exe.IoCancelIrp Hint[307] >ntoskrnl.exe.KeTickCount Hint[614] >ntoskrnl.exe.KeBugCheckEx Hint[502] >ntoskrnl.exe.PoCallDriver Hint[822] >ntoskrnl.exe.KeInitializeSpinLock Hint[542] >ntoskrnl.exe.KeInitializeEvent Hint[536] >ntoskrnl.exe.IoFreeWorkItem Hint[355] >ntoskrnl.exe.IofCompleteRequest Hint[483] >HIDCLASS.SYS.HidRegisterMinidriver Hint[3] >USBD.SYS.USBD_ParseConfigurationDescriptorEx Hint[22] >USBD.SYS.USBD_CreateConfigurationRequestEx Hint[6] > > >-- Alois > >

1 0

Re: gdi32/tests: Mark Win8.1 behaviour for johab charset as broken
by Akihiro Sagawa 18 Mar '14

18 Mar '14

On Sat, 15 Mar 2014 00:15:54 +0100, André Hentschel wrote: > - {JOHAB_CHARSET, 0x8446, 0x3135, > + {JOHAB_CHARSET, 0x8446, 0x3135, TRUE /* Win8.1 */, > {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE}}, (snip) > + ok((pGetCharABCWidthsA(hdc, c[i].a, c[i].a + 1, a) && > + pGetCharABCWidthsW(hdc, c[i].w, c[i].w + 1, w) && > + memcmp(a, w, sizeof a) == 0) || broken(c[i].broken), > "GetCharABCWidthsA and GetCharABCWidthsW should return same widths. charset = %u\n", c[i].cs); Regarding this test about Johab charset, you are missing the point. Which version of Windows does succeed in? I suspect that the test is broken. Don't you think? As far as I know, other wine testbots just skip the test due to missing Johab (=130) charset font. Moreover, my Windows 7 with Arial Unicode MS or YOzFont[1] doesn't pass because GetCharABCWidthsA returns 0. But I've not tested on Korean version Windows. If you have further information, please let me know. [1] YOzFont apparently supports Johab charset. It's available from http://yozvox.web.fc2.com/446F776E6C6F6164.html Regards, Akihiro Sagawa

2 2

Re: vbscript: Allow creating RegExp object by new expression.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5757 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: mshtml: Fixed tests on old IEs and improved results on IE11.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5749 Your paranoid android. === w8 (32 bit htmldoc) === htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:5289: Test failed: elem != NULL htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6012: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2868: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2868: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2964: Test failed: unexpected call Exec_ShellDocView_138 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 133 htmldoc.c:3433: Test failed: dwFlags = 140 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:6084: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:985: Test failed: unexpected id 3000032 htmldoc.c:3300: Test failed: unexpected call {f6d02767-9c80-428d-b974-3f1729453fdb} htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2989: Test failed: unexpected command 137 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:5946: Test failed: expected Exec_ShellDocView_67 htmldoc.c:2861: Test failed: unexpected command 74 htmldoc.c:2989: Test failed: unexpected command 133 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3165: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:3165: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:7807: Test failed: expected Exec_ShellDocView_67 htmldoc.c:7811: Test failed: expected Exec_ShellDocView_84

1 0

Re: [PATCH] scrrun: Implement WriteLine/Write for ITextStream (try2)
by Dmitry Timoshkov 18 Mar '14

18 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static HRESULT textstream_writestr(struct textstream *stream, BSTR text) > +{ > + DWORD written = 0; > + BOOL ret; > + > + if (stream->unicode) { > + if (stream->first_write) { > + static const short utf16bom = 0xfeff; 'WCHAR' instead of 'short' would look more natural IMO, especially since remaining data is WCHAR based.. -- Dmitry.

2 1

Re: user32/tests: Use BOOL type where appropriate
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5739 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005009E fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030160 fg 00060064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040264 fg 00010054 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040184 fg 0001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0006019E fg 00010048 in hook HCBT_ACTIVATE win.c:6406: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6406: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6406: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6406: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6428: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040184 fg 000000000001006C in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: rpcrt4/tests: Add a couple of tests for marshalling an array of strings. Take 2.
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5736 Your paranoid android. === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned -65533 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3

2 1

Re: [PATCH] scrrun: Implement WriteLine/Write for ITextStream
by Marvin 18 Mar '14

18 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5734 Your paranoid android. === wvista (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\nT\f8a8\"\186e\7630", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === wvistau64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\008d\f8a8'\186e\7550", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w2008s64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\scrrun\\test.txt\r\nu\f8a8'\186e\75af", expected L"\feffC:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w7pro64 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\008c\f8a8(\625c\761f", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n" === w8 (32 bit filesystem) === filesystem.c:1342: Test failed: got L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n\0129\019c", expected L"\feffC:\\Users\\winetest\\AppData\\Local\\Temp\\scrrun\\test.txt\r\n"

1 0

Re: gdi32/tests: GetCharABCWidthsA is broken for johab charset on windows
by Marvin 17 Mar '14

17 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5730 Your paranoid android. === w8 (32 bit font) === font.c:3609: Test failed: W: tmLastChar for Nirmala UI Semilight got a839 expected 262c font.c:3609: Test failed: W: tmLastChar for Nirmala UI got a839 expected 262c font.c:4297: Test failed: 104 100

1 0

FYI Re: wined3d_mutex
by Max TenEyck Woodbury 17 Mar '14

17 Mar '14

I have told you about the long delays I have encountered with Guild Wars 2 under wine. I mentioned that I suspected the wined3d_mutex was the source of the problem. I have just finished a test that shows that it is NOT the source of this problem. Specifically, I dummied the wined3d_mutex_lock and wined3d_mutex_unloc procedures so that they did nothing, That version showed the same pattern of delays that the unaltered system showed. If anybody has an idea about what might be causing these delays, please tell me. Note that my review of the use of this mutex indicates that it is of very questionable value. In my opinion it should be replaced by a set of read/write locks built into the individual data structures. Comments? max

3 6

GSoC 2014: Mentor signups are open
by Austin English 17 Mar '14

17 Mar '14

Howdy, Signups for mentors is open. Please register at: https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine Our ideas page is at http://wiki.winehq.org/SummerOfCode, if you have any ideas for projects. -- -Austin

3 4

Wine test week 1
by Jeremy White 17 Mar '14

17 Mar '14

My current view: http://www.winehq.org/~jwhite/2bb1059ad249.html We have about 32 tests that fail on the new test bots. Some of the failures are timing related; most of them look hard. We've made some solid progress (There is new yellow on our main page. Yay!) I'm going to stop being so chatty; I'll try to work each day to annotate one more test, and then circle back in a few weeks with a summary. Cheers, Jeremy

1 0

Re: dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h (resend)
by Alexandre Julliard 17 Mar '14

17 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > Changelog: > dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h You can't do that: In file included from dxerr9.c:38: ../../include/dplay8.h:30: error: redefinition of typedef 'IDirectPlay8Address' ../../include/dpaddr.h:222: error: previous declaration of 'IDirectPlay8Address' was here make[1]: *** [dxerr9.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: improve GetNumaHighestNodeNumber
by Matteo Bruni 17 Mar '14

17 Mar '14

2014-03-17 11:56 GMT+01:00 Austin English <austinenglish(a)gmail.com>: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35596 > > -- > -Austin > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 60156aa..86055d3 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3911,9 +3911,9 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK */ > BOOL WINAPI GetNumaHighestNodeNumber(PULONG highestnode) > { > - FIXME("(%p): stub\n", highestnode); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + *highestnode = 0; > + WARN("(%p): semi-stub\n", highestnode); > + return TRUE; Not a big deal I guess but I don't think WARN is appropriate here, it should still be a FIXME IMO.

1 0

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev 17 Mar '14

17 Mar '14

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

4 13

Re: [PATCH 5/5] wined3d: Remove the version parameter.
by Henri Verbeet 17 Mar '14

17 Mar '14

On 16 March 2014 20:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index 7bb37d6..df725e2 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -1221,6 +1221,7 @@ enum wined3d_display_rotation > #define WINED3D_NO3D 0x00000002 > #define WINED3D_VIDMEM_ACCOUNTING 0x00000004 > #define WINED3D_PRESENT_CONVERSION 0x00000008 > +#define WINED3D_ALLOW_3D_DISABLE 0x00000010 > Do we really need this? It's perhaps unfortunate that setting "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm not sure if avoiding that is really worth an extra flag.

2 2

Re: [PATCH] widl: Fix default value types
by Alexandre Julliard 17 Mar '14

17 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=35778 > > --- > tools/widl/write_msft.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) This is causing warning: can't write value of type 29 yet during the build, that's probably not good. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: rpcrt4/tests: Add a couple of tests for marshalling an array of strings.
by Marvin 17 Mar '14

17 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5719 Your paranoid android. === w2000pro (32 bit server) === server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\86b8#\8640#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\6868#\67c0#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0198#\4d4c\4d45\7280#\6288#\7280#\0003\0004\0100\000c" server.c:1255: Test failed: expected World!, got L"W" === wxppro (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\01b8$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0178$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0408$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" === wvista (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hem3\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W;C:\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" === w2008s64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned -65533 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w2008s64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W"

3 2

Re: [PATCH 1/2] ddraw/tests: Add mipmap private data tests (try 2).
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === w8 (32 bit ddraw4) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 2/2] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5718 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] ddraw/tests: Use a custom GUID for the private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5715 Your paranoid android. === wvistau64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6044: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === No test summary line found Failure running script in VM: network read timed out (wait2:ListSize:0/4)

1 0

Re: [PATCH 3/5] ddraw/tests: Add mipmap private data tests.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5714 Your paranoid android. === w8 (32 bit ddraw7) === Failure running script in VM: timed out waiting for the child process === wvistau64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w2008s64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:6030: Test failed: Failed to create surface, hr 0x80004002. === w8 (32 bit ddraw4) === ddraw4.c:5731: Test failed: Got unexpected refcount 3. ddraw4.c:5750: Test failed: Got unexpected refcount 3. ddraw4.c:5757: Test failed: Got unexpected hr 0. ddraw4.c:5760: Test failed: Got unexpected refcount 3. ddraw4.c:5762: Test failed: Got unexpected refcount 2. ddraw4.c:5768: Test failed: Got unexpected hr 0. ddraw4.c:5771: Test failed: Got unexpected refcount 2. ddraw4.c:5773: Test failed: Got unexpected refcount 1. ddraw4.c:5775: Test failed: Got unexpected refcount 6.

1 0

Re: [PATCH 2/5] ddraw/tests: Test GetPrivateData size behavior.
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5713 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out

1 0

Re: cmd: Dont assume cmd.exe is the first argument
by Qian Hong 16 Mar '14

16 Mar '14

Hi Alistair, + args = 0; /* start at first arg, skipping cmd.exe itself */ Could you also consider fixing the comment here? Have a nice weekend :) -- Regards, Qian Hong - http://www.winehq.org

1 0

About GSoC - The Wine Project
by SpedsT . 15 Mar '14

15 Mar '14

Hello. I want to apply to this project and I have a question about this note: * Note: Beginning with Summer of Code 2014, applicants *MUST* have submitted a patch or testcase to wine-patches (see http://wiki.winehq.org/SubmittingPatches) to be considered for acceptance. What kind of patch or testcase should I submit, what would you like to be about?

2 1

Re: gdiplus: Use BOOL type where appropriate
by Vincent Povirk 15 Mar '14

15 Mar '14

On Sat, Mar 15, 2014 at 9:44 AM, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - rotate_90 = type&1; > + rotate_90 = (type & 1) != 0; > flip_x = (type&6) == 2 || (type&6) == 4; > flip_y = (type&3) == 1 || (type&3) == 2; If you must change the style, I prefer (type&1) == 1 here, as it has fewer negatives and matches the lines after it.

1 0

Re: mshtml: Added IHTMLTableRow::rowIndex property implementation.
by Zhenbo Li 15 Mar '14

15 Mar '14

Sorry, I sent the same patch twice due to network problem. Please ignore the second one. Thank you. 2014-03-15 11:23 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmltablerow.c | 11 +++++++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 2/2] wined3d: Re-use old wined3d_private_data structures if the size matches.
by Henri Verbeet 14 Mar '14

14 Mar '14

On 14 March 2014 14:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if ((old = wined3d_private_store_get_private_data(store, guid)) && old->size == data_size) > + { > + IUnknown *release = NULL; > + if (old->flags & WINED3DSPD_IUNKNOWN) > + release = old->content.object; > + memcpy(old->content.data, ptr, data_size); > + old->flags = flags; > + if (flags & WINED3DSPD_IUNKNOWN) > + IUnknown_AddRef(old->content.object); > + if (release) > + IUnknown_Release(release); > + return WINED3D_OK; > + } What is the motivation for this? It certainly doesn't make the code any prettier.

2 1

Re: [3/3] gdiplus: Limit image output to the bounds of the Graphics object.
by Vincent Povirk 14 Mar '14

14 Mar '14

Don't commit this one. I messed up the case where output is fully outside the Graphics object bounds. On Thu, Mar 13, 2014 at 4:49 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

1 0

Re: [PATCH] winedump: Improve typelib header dumping
by Jacek Caban 14 Mar '14

14 Mar '14

Hi Nikolay, On 03/14/14 14:48, Nikolay Sivov wrote: > + if (flags & 1) > + printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0); > + flags >>= 1; i should be increased on each iteration, not only when the flag is found. Cheers, Jacek

1 1

Re: [PATCH] msxml3: Fix some test failures on Win8.1
by Alexandre Julliard 13 Mar '14

13 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/msxml3/schema.c | 9 +++++++-- > dlls/msxml3/tests/domdoc.c | 28 +++++++++++++++++----------- > 2 files changed, 24 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M msxml3.dll -p msxml3_test.exe.so schema && touch schema.ok schema.c:1526: Test failed: got 0x80004003, expected 0x80004001 make: *** [schema.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: vbscript: Allow empty brackets in argument declarations.
by Marvin 13 Mar '14

13 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5671 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: shell32: Supply a module name to CreateProcess (try 5)
by Alexandre Julliard 13 Mar '14

13 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Corrected the accidental line being removed. > > Changelog: > shell32: Supply a module name to CreateProcess It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlexec && touch shlexec.ok Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 10, but got 10 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params20", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="p"): the cmdline is '(null)' instead of ' "p0"' shlexec.c:1457: Test failed: argvA4 expected 'p0', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="'p2 p3` p4\ $even"): the cmdline is '(null)' instead of ' "'p2" "p3`" "p4\" "$even" ""' shlexec.c:1457: Test failed: argvA4 expected ''p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3`', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p=2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p-3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA9 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA10 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 Fatal: test 'file.shlexec' does not exist. etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20/tests: Fix a SysAllocString leak
by Nikolay Sivov 13 Mar '14

13 Mar '14

On 3/12/2014 19:36, Jactry Zeng wrote: > I made this leak, sorry.. :( > "What goes around comes around" was confirmed! :p > VariantInit(&testfile); > V_VT(&testfile) = VT_BSTR; > V_BSTR(&testfile) = SysAllocString(filename); No need for VariantInit() here. > + SysFreeString(V_BSTR(&testfile)); It's cleaner to use VariantClear().

2 1

Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.
by Qian Hong 13 Mar '14

13 Mar '14

Hi Jacek, + + hres = get_frame_by_name(top_window, target, TRUE, &ret_window); + if(FAILED(hres) || !window) { + *use_new_window = TRUE; + return NULL; + } Is there a typo here? Is "!window" suppose to be "!ret_window"? Thanks for the work!

2 1

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation (try2)
by Alexandre Julliard 13 Mar '14

13 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL)) > + return c; You'd also have to handle the case of the length being just 1. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation
by Alexandre Julliard 13 Mar '14

13 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!MultiByteToWideChar(locinfo->lc_codepage, > + MB_ERR_INVALID_CHARS, (char*)str, p-str, &wide, 1)) > + return c; > + > + lower = tolowerW(wide); > + if(lower == wide) > + return str[0] + (str[1]<<8); > + > + WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL); You should probably also check the resulting length here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/5] d3d8/tests: Move some stateblock tests to device.c.
by Marvin 13 Mar '14

13 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5656 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0005025E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x411180, got 0x411180.

1 0

Re: TestBot job 5654 results: [PATCH] msxml3: Respect stylesheet output mode when dumping resulting document
by Nikolay Sivov 13 Mar '14

13 Mar '14

On 3/13/2014 15:41, Marvin wrote: > > === w8 (32 bit domdoc) === > > msxml3: > domdoc.c:10385: Test failed: got 00000000 > domdoc.c:10399: Test failed: got 00000000 > domdoc.c:10451: Test failed: got 0 > domdoc.c:10476: Test failed: got 00000000 > domdoc.c:10550: Test failed: got 00000000 > domdoc.c:10565: Test failed: got 00000000 > domdoc.c:10619: Test failed: got 0 > domdoc.c:11268: Test failed: got 00000000 > domdoc.c:11294: Test failed: got 00000000 This is unrelated, I'll send a patch.

1 0

Re: [PATCH] msxml3: Respect stylesheet output mode when dumping resulting document
by Marvin 13 Mar '14

13 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5654 Your paranoid android. === w8 (32 bit domdoc) === domdoc.c:10385: Test failed: got 00000000 domdoc.c:10399: Test failed: got 00000000 domdoc.c:10451: Test failed: got 0 domdoc.c:10476: Test failed: got 00000000 domdoc.c:10550: Test failed: got 00000000 domdoc.c:10565: Test failed: got 00000000 domdoc.c:10619: Test failed: got 0 domdoc.c:11268: Test failed: got 00000000 domdoc.c:11294: Test failed: got 00000000

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLDocument7 stub implementation.
by Alexandre Julliard 13 Mar '14

13 Mar '14

Jacek Caban <jacek(a)codeweavers.com> writes: > Due to how tests are written, we need to switch to IWebBrowserPriv2IE9 > in the same patch. > > --- > dlls/ieframe/ieframe.h | 2 +- > dlls/ieframe/navigate.c | 104 +---- > dlls/mshtml/Makefile.in | 1 + > dlls/mshtml/htmldoc.c | 4 + > dlls/mshtml/htmldoc7.c | 939 +++++++++++++++++++++++++++++++++++++++++++ Merging htmldoc3 and htmldoc5 was a good start, couldn't we do this with the rest of the htmldoc implementations too? There are way too many files in that dll already. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: schedsvc: Add Task Scheduler service. Try 2.
by Dmitry Timoshkov 13 Mar '14

13 Mar '14

Hi, Is there a reason why this patch is marked as 'pending'? -- Dmitry.

2 16

Glorious winetestbot results, why this matters
by Jeremy White 13 Mar '14

13 Mar '14

So here's today's data: http://www.winehq.org/~jwhite/31faed571d5a.html The main changes are the addition of some new failures in mshtml; failures that Marvin actually pointed out here: http://www.winehq.org/pipermail/wine-devel/2014-March/103419.html The glorious result is that if I get to publicly shame anyone, it's both Jacek and Alexandre. For someone with my JR, that's a rare opportunity <grin>. But really, it illustrates the problem: Alexandre does not trust the new test bot results, so he did not wait for testbot review of patches, and so he did not catch a problem. We need to restore that trust. That's why this matters. Cheers, Jeremy p.s. Looks like Francois's patch has fixed winmm:mci (yay!), and a few tests that my script felt were 'solved' have proven themselves to be actually intermittent (comctl:propsheet and user32:listbox)

5 5

[RFC 5/11] Linux FF: Linux effect parameters: time parameters
by Elias Vanderstuyft 12 Mar '14

12 Mar '14

a) Because of the higher time resolution of DInput parameters (in microseconds instead of milliseconds), e.g. dwPeriod, and because truncating may result in "periodic.period == 0", while "1 <= dwPeriod (non-zero) < 1000", and because "periodic.period == 0" is an invalid argument, we might set periodic.period to the smallest non-zero value (that is 1) when dwPeriod is non-zero, to avoid unnecessary exceptions. So change in dinput/effect_linuxinput.c:488 : This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = tsp->dwPeriod / 1000; b) Anticipate if dwPeriod < 0, otherwise periodic.period will incorrectly wrap around because it's unsigned. We can choose to let periodic.period be proportional to: - 0 (driver will generate EINVAL) - abs(dwPeriod) (no error, and is mathematically more correct) Choosing the latter, so change in dinput/effect_linuxinput.c:488 : if (0 < tsp->dwPeriod && tsp->dwPeriod <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : if (tsp->dwPeriod && abs(tsp->dwPeriod) <= 1000) This->effect.u.periodic.period = 1; else This->effect.u.periodic.period = abs(tsp->dwPeriod) / 1000; c) Something similar is needed for 'dwDuration': Set infinite replay-length in linux by "replay.length == 0": discussion: http://www.mail-archive.com/linux-input@vger.kernel.org/msg08459.html Knowing that DInput "INFINITE == -1", we convert -1 to 0. If "peff->dwDuration == 0", we can: - not start the effect - set the effect duration to the absolute minimum I would choose the latter, because otherwise more behaviour of the code would change. And lastly, we don't throw exceptions when "dwDuration < 0": MSDN does not require us to throw DIERR_INVALIDPARAM. So, change in dinput/effect_linuxinput.c:191 : if (dwFlags & DIEP_DURATION) { peff->dwDuration = (DWORD)This->effect.replay.length * 1000; } to : if (dwFlags & DIEP_DURATION) { peff->dwDuration = (This->effect.replay.length ? (DWORD)This->effect.replay.length * 1000 : -1); } And change in dinput/effect_linuxinput.c:424 : if (dwFlags & DIEP_DURATION) This->effect.replay.length = peff->dwDuration / 1000; to : if (dwFlags & DIEP_DURATION) { if (peff->dwDuration == -1) This->effect.replay.length = 0; // Infinity else if (peff->dwDuration > 1000) This->effect.replay.length = peff->dwDuration / 1000; else This->effect.replay.length = 1; // Smallest non-zero value } Elias

2 4

[RFC 2/11] Linux FF: Linux effect status management
by Elias Vanderstuyft 12 Mar '14

12 Mar '14

a) This is a bug that is either the responsibility of the Linux kernel, or of Wine: It is caused by the following situation: When uploading an effect, the specific kernel device driver may return an error, e.g. EINVAL for example when a periodic's effect period is set to zero. This error will then be returned by "ioctl(*(This->fd), EVIOCSFF, &This->effect)". With or without error, one can find out that /drivers/input/ff-core.c:input_ff_upload(...) is called, which will set effect->id >= 0, if it was set to -1 (=> new effect created) by the user. But in case of an error: - Assume effect->id was set to -1 by the user: The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will also be set >= 0 (*). The offending effect will not be saved in the ff->effects[] array (***). - Assume effect->id was set >= 0 by the user (and ff->effects[effect->id] is a valid existing effect): The error is reported by ff->upload(...) at /drivers/input/ff-core.c:167, the effect->id will remain unchanged (**). The offending effect will not overwrite the ff->effects[effect->id] element (****). Is this (see *, **, *** and ****) desired behavior? - If yes: Change the following in Wine's dinput/effect_linuxinput.c:84 : LinuxInputEffectImpl *This = impl_from_IDirectInputEffect(iface); TRACE("(this=%p)\n", This); if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { to : LinuxInputEffectImpl *This = impl_from_IDirectInputEffect(iface); int effectId_old; TRACE("(this=%p)\n", This); effectId_old = This->effect.id; if (ioctl(*(This->fd), EVIOCSFF, &This->effect) == -1) { This->effect.id = effectId_old; - If no for *: Kernel code /drivers/input/ff-core.c:input_ff_upload(...) has to be patched to revert "effect->id" back to its original value set by the user, which is only needed when the initial (by user) value of "effect->id" was equal to -1. - If no for **** (or maybe also ***): ff->effects[effect->id] could be replaced by an 'empty' effect (however this can get complex because the effect's type has to remain unchanged) This would be a change in the kernel code /drivers/input/ff-core.c:input_ff_upload(...). - If no for **: I don't really know. Discussion is needed. - In my opinion, **, *** and **** are desired behavior, while * should leave the effect->id at -1. In that case, Wine's dinput implementation does not have to be patched, and the kernel code only should apply a minor patch. => This has been discussed (see http://www.mail-archive.com/linux-input@vger.kernel.org/msg08513.html), and the following is true: My opinion appeared to be correct, but for to be sure, I was recommended to apply the change in Wine as well. b) Be more precise in returning errors. In dinput/effect_linuxinput.c:89, change : if (errno == ENOMEM) { return DIERR_DEVICEFULL; } else { FIXME("Could not upload effect. Assuming a disconnected device %d \"%s\".\n", *This->fd, strerror(errno)); return DIERR_INPUTLOST; } to : switch (errno) { case EINVAL: TRACE("Could not upload effect: Invalid argument.\n"); return DIERR_INVALIDPARAM; case ENOSPC: TRACE("Could not upload effect: No space left on device.\n"); return DIERR_DEVICEFULL; case ENOMEM: TRACE("Could not upload effect: Out of memory.\n"); return DIERR_OUTOFMEMORY; default: FIXME("Could not upload effect. Assuming a disconnected device %d \"%s\".\n", *This->fd, strerror(errno)); return DIERR_INPUTLOST; } c) The following in dinput/effect_linuxinput.c:336 : if (res != DI_OK) should be probably : if (FAILED(res)) for example if a device reports S_FALSE because it has already updated an identical effect. The same for line 549: if (retval != DI_OK) should be then : if (FAILED(retval)) Elias

2 4

Re: [5/6] user32: Set capture on the owner of popup menus.
by Alexandre Julliard 12 Mar '14

12 Mar '14

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -2057,6 +2057,19 @@ BOOL CDECL X11DRV_ScrollDC( HDC hdc, INT dx, INT dy, HRGN update ) > } > > > +BOOL CALLBACK find_popup_menu_window(HWND hwnd, LPARAM lparam) > +{ > + HWND *result = (HWND*)lparam; > + > + if (GetClassLongW(hwnd, GCW_ATOM) == MAKEINTATOM(32768)) > + { > + *result = hwnd; > + return FALSE; > + } That's ugly and unreliable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3d8/tests: Test GetPrivateData size behavior.
by Marvin 12 Mar '14

12 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5629 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000901BC, got 00010048.

1 0

Re: [PATCH 4/5] d3d8/tests: Use a custom GUID for the private data tests.
by Marvin 12 Mar '14

12 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5628 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 000401E4, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40fa10, got 0x40fa10.

1 0

Valve has released a Direct3D to OpenGL translator (for a subset of Direct3D 9.0c)
by Artem S. Tashkinov 12 Mar '14

12 Mar '14

Hi, Just wanted to let everyone know that Valve has released a Direct3D to OpenGL translator (for a subset of Direct3D 9.0c). More here: https://github.com/ValveSoftware/ToGL I don't know if it's of any use for Wine development however. The license is as permissive as possible - in short Valve allows to do anything with their code. Artem

2 1

Patches 103117 - 103120
by Hugh McMaster 12 Mar '14

12 Mar '14

Hi, Was there something wrong with the following patches? I received no warnings or errors when patching and compiling one-by-one. Also, Akihiro Sagawa reviewed and passed them. 103117 [1/4] regsvr32: Insert unicode print function (http://source.winehq.org/patches/data/103117) 103118 [2/4] regsvr32: Create resource header and move ANSI resource strings (http://source.winehq.org/patches/data/103118) 103119 [3/4] regsvr32: Replace all printf calls with calls to output_write; remove Silent check. (http://source.winehq.org/patches/data/103119) 103120 [4/4] regsvr32: Convert C source to Unicode (http://source.winehq.org/patches/data/103120) Any help is appreciated. -- Hugh McMaster

2 2

Re: [PATCH 1/5] user32: Fix TEXT_WordBreak() when no characters fit.
by jm.rodriguezceja＠yahoo.es 11 Mar '14

11 Mar '14

Enviado desde Yahoo Mail en Android

1 0

GSoC 2014
by Naveen Sahu 11 Mar '14

11 Mar '14

Hello, I'm Naveen Sahu, a 3rd yr undergraduate in Computer Science and Engineering at Indian Institute of Technology Guwahati (IIT G), India. I have a good knowledge of C, C++ and python. I would like to contribute to Wine through GSoC'14. I'm interested in '*Richedit - implement Windowless mode*' project. Can you please give me some advice which bugs to fix that can help me in this project too? I'll try my best to submit patches as soon as possible. Regards, Naveen

2 1

Re: [PATCH 3/3] mshtml: Adder _parent target support to navigate_anchor.
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5613 Your paranoid android. === w2000pro (32 bit script) === Timeout === wxppro (32 bit script) === Timeout

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLFrameBase2::onload property implementation.
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5612 Your paranoid android. === w2000pro (32 bit events) === Timeout === wxppro (32 bit events) === Timeout

1 0

Re: [PATCH 4/5] ddraw/tests: Skip the overlay tests in test_block_formats_creation() if overlays are not supported.
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5610 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:5604: Test failed: Got unexpected refcount 3. ddraw7.c:5623: Test failed: Got unexpected refcount 3. ddraw7.c:5630: Test failed: Got unexpected hr 0. ddraw7.c:5633: Test failed: Got unexpected refcount 3. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5641: Test failed: Got unexpected hr 0. ddraw7.c:5644: Test failed: Got unexpected refcount 2. ddraw7.c:5646: Test failed: Got unexpected refcount 1. ddraw7.c:5648: Test failed: Got unexpected refcount 6. ddraw7.c:5765: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out === wvistau64 (64 bit ddraw4) === Use of uninitialized value in hash element at /home/testbot/lib/WineTestBot/TestAgent.pm line 215, <DATA> line 558. Use of uninitialized value in hash element at /home/testbot/lib/WineTestBot/TestAgent.pm line 215, <DATA> line 558. Use of uninitialized value in concatenation (.) or string at /home/testbot/bin/WineRunTask.pl line 234, <DATA> line 558. Unable to set the VM system time (): the "nc -q0 '10.42.42.238' '4242'" command returned 1 === w2008s64 (64 bit ddraw4) === Use of uninitialized value in hash element at /home/testbot/lib/WineTestBot/TestAgent.pm line 215, <DATA> line 558. Use of uninitialized value in hash element at /home/testbot/lib/WineTestBot/TestAgent.pm line 215, <DATA> line 558. Use of uninitialized value in concatenation (.) or string at /home/testbot/bin/WineRunTask.pl line 234, <DATA> line 558. Unable to set the VM system time (): the "nc -q0 '10.42.42.136' '4242'" command returned 1

1 0

Wine Test Bot 1.7.14 analysis
by Jeremy White 11 Mar '14

11 Mar '14

I wrote a script to analyze winetestbot results on all of the testbot vms except the win8 vms (they are just too broken to try to analyze right now). I'm trying to get a handle on the nature of the bot failures; this current script looks for consistent failures (partly because a consistent failure that goes green is a win, and I badly want to track wins). My results are here: http://www.winehq.org/~jwhite/ecd24b5a874e.html The short summary is that we have 38 current failures. But we appear to have fixed 3 failures (at least on the testbot vms). We also have 14 that seem consistent (i.e. that should be more tractable). I intend to use this to track progress and show status. This result is arguably not that interesting; I'm mostly posting it now so I can be publicly shamed if I fail to follow through. Cheers, Jeremy

7 14

Fwd: Build a World - a sophisticated OpenGL Windows and Linux native game - can it be any help with WINE?
by Mateusz 'DevSH' Kielan 11 Mar '14

11 Mar '14

-------- Original Message -------- Subject: Build a World - a sophisticated OpenGL Windows and Linux native game - can it be any help with WINE? Date: Sun, 24 Mar 2013 14:36:31 +0000 From: Mateusz Kielan <devsh.graphicsprogramming(a)gmail.com> To: ulrich.czekalla(a)utoronto.ca I'm sorry if this email seems kind of rushed (originally planned to send to wine-devel but didnt want this email to go public). This is more of a loose proposition towards CodeWeavers rather than the wine developer community We at "Sodan Design" are developing relatively complicated video game called Build a World www.buildaworld.net <http://www.buildaworld.net> http://www.youtube.com/user/wwwbuildaworldnet/videos?view=0&flow=grid https://www.facebook.com/pages/Build-A-World/284152794990875?fref=ts http://www.kickstarter.com/projects/1895183955/build-a-world We are soon going to release our linux build to our alpha testers, I'm the graphics programming and we had a native 32bit linux build since I started working on the game. Now, I would imagine that you would very much benefit from analyzing a program which has *ALMOST* exactly the same codepath on linux as it does on linux (with the exception of a few things like threading). Right now we use the following technologies (listing more unusual stuff): --OpenGL compatibility --OpenGL 3.0 extensions --OpenGL 4.2 tessellation shaders through extensions --OpenGL Geometry shaders --OpenGL 3D textures --Boost::Libraries --Pthreads/Windows Threads with mutices --google protocol buffers --libtcmalloc (Linux) --FMOD And in the future: --libvpx --possibly ffmpeg --OpenCL (definitely) - I gather this is something wine has hickups with (at least CUDA was difficult) --OpenGL compute shaders I'm sure you'd appreciate a good piece of crossplatform software to work with, and we'd appreciate the extra linux/windows testing. Some forms of reverse engineering will be allowed in our EULA (for purpose of licence compliance with FFMPEG) I'm sure if we CodeWeavers signed an NDA then we could hand over a few nice things like executables with some debug symbols. Even without an NDA we'd be able to give a free game account to every CodeWeavers employee. P.S. It would be great if we could get some publicity or at least some mention if our 32bit windows exe gets a platinum rating or if tinkering around with Build-a-World helps with advancing wine.

1 0

Re: ntdll: Use condition variable for RtlQueueWorkItem implementation
by Alexandre Julliard 11 Mar '14

11 Mar '14

Sebastian Lackner <sebastian(a)fds-team.de> writes: > * Its also on purpose, that num_workers is (read-) accessed at one point > without locking the critical section. If num_workers > 0 we can be sure, that > a worker thread will process the work item (sooner or later). If > num_workers == 0 we enter the critical section, and check once more to > prevent race condition 2. The worker may be about to exit at the time you check. I don't think it makes any sense to add races to "optimize" an error case that's not going to happen anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] winex11: Add support for WGL_WINE_make_current extension. (try 2)
by Alexandre Julliard 11 Mar '14

11 Mar '14

Ken Thomases <ken(a)codeweavers.com> writes: > try 2: fail gracefully if the window was destroyed Still no good I'm afraid: ../../../tools/runtest -q -P wine -T ../../.. -M opengl32.dll -p opengl32_test.exe.so opengl && touch opengl.ok X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 153 (GLX) Minor opcode of failed request: 26 (X_GLXMakeContextCurrent) Serial number of failed request: 524 Current serial number in output stream: 524 make[1]: *** [opengl.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Valve releases their "ToGL" code to convert D3D to OpenGL
by Scott Ritchie 11 Mar '14

11 Mar '14

https://github.com/ValveSoftware/ToGL There might be something useful in there.

1 0

Re: [2/2] cmd/tests: Don't use "@pwd@\" when expecting a full path (try 2)
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5585 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1364 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1365 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1366 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1367 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1368 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1369 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1370 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1371 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1373 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1376 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1377 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1380 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [1/2] cmd/tests: Correctly determine script path for root directories (try 2)
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5584 Your paranoid android. === w2000pro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 266 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 267 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 302 (got 'C:\C D', wanted '@pwd@\C D@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 303 (got 'C:\E', wanted '@pwd@\E@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 338 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 339 (got 'C:\E', wanted '@pwd@\E') batch.c:304: Test failed: excess characters on line 395 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar@or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 396 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 398 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 400 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 406 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 408 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 410 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1095 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1097 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1099 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1102 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo@or_broken@A @pwd@\foobar\foo@or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1104 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo@or_broken@A R @pwd@\foobar\foo@or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2@or_broken@A @pwd@\foobar\baz\level2@or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1111 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1@or_broken@A R @pwd@\foobar\level1@or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1112 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2@or_broken@A R @pwd@\foobar\baz\level2@or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1113 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar@or_broken@A @pwd@\foobar\bar@or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1115 (got ' C:\foobar', wanted ' @pwd@\foobar@or_broken@ @pwd@\foobar@or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1116 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz@or_broken@ R @pwd@\foobar\baz@or_broken@ @pwd@\foobar\baz@or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1117 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto@or_broken@A @pwd@\foobar\baz\toto@or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1254 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1256 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1258 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1262 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1264 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1285 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1287 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1291 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1296 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1298 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1364 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1365 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1366 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1367 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1368 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1369 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1370 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1371 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1373 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1376 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1377 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1380 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar') === w8 (32 bit batch) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [PATCH 5/5] ddraw/tests: Show that a failing SetPrivateData call does not clear the old contents.
by Marvin 11 Mar '14

11 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5579 Your paranoid android. === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w8 (32 bit ddraw4) === ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5735: Test failed: Got unexpected refcount 3. ddraw4.c:5754: Test failed: Got unexpected refcount 3. ddraw4.c:5761: Test failed: Got unexpected hr 0. ddraw4.c:5764: Test failed: Got unexpected refcount 3. ddraw4.c:5766: Test failed: Got unexpected refcount 2. ddraw4.c:5772: Test failed: Got unexpected hr 0. ddraw4.c:5775: Test failed: Got unexpected refcount 2. ddraw4.c:5777: Test failed: Got unexpected refcount 1. ddraw4.c:5779: Test failed: Got unexpected refcount 6. ddraw4.c:5899: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5938: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5941: Test failed: Got unexpected hr 0. ddraw4.c:5943: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5946: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5949: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5951: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5954: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5956: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5959: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5961: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 4/5] d3d8/tests: Show that a failing SetPrivateData call does not clear the old contents.
by Marvin 10 Mar '14

10 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5578 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 00060102, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40fa10, got 0x40fa10.

1 0

Re: [PATCH 1/5] ddraw/tests: Only set DDSCAPS_OVERLAY if supported (try 2).
by Marvin 10 Mar '14

10 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5576 Your paranoid android. === w8 (32 bit ddraw7) === ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw7.c:4010: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw7.c:5608: Test failed: Got unexpected refcount 3. ddraw7.c:5627: Test failed: Got unexpected refcount 3. ddraw7.c:5634: Test failed: Got unexpected hr 0. ddraw7.c:5637: Test failed: Got unexpected refcount 3. ddraw7.c:5639: Test failed: Got unexpected refcount 2. ddraw7.c:5645: Test failed: Got unexpected hr 0. ddraw7.c:5648: Test failed: Got unexpected refcount 2. ddraw7.c:5650: Test failed: Got unexpected refcount 1. ddraw7.c:5652: Test failed: Got unexpected refcount 6. ddraw7.c:5769: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4203: Test failed: Got unexpected hr 0x80004001 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. Failure running script in VM: network read timed out

1 0

Gsoc
by P Nt 10 Mar '14

10 Mar '14

Hello, I am Pavel Nicolae Teodor from University POLITEHNICA of Bucharest. I am looking forward to contribute towards organziation. I am new to open source and need some guidance for same. I liked the proiects WineCE:Implement the Command Bar Tools and Implement new control panel applets and I want to fix some bugs in this project area to see if it's suitable for me.I'm good at C/C++ but I can write code in python too .Two years ago I wrote a 6000 line code in C(graphics ),it's not a fabulos program but it proves some of my skills if you want I can send it. Would you like to give me some links with this type of bugs .

2 1

GSoC 2014
by HuddenSin Yuan 10 Mar '14

10 Mar '14

Hello, I'm Yuanchen from China.I have compiled the Wine from the lastest git for some times and also run the winetest,submit my results with the tag of "Yuanchen".But sorry for the fact that i submit the results twice because of my personal fault. Through this process ,I know much more about what wine do and i pretty look forward to such things as find bugs, report them and try to fix them with the help of each other.It also can let softwares on windows run on the linux.This is amazing I think.I want to spend my summer on this project and contribute to this project. I read the idea list and I'm interested in "Tools-Winetest Graphical User Interface" and "Direct3D -Conformance /Performance/Interactive tests".I think both project are attractive for me and good to collecte more bugs and make Wine better. I have learned C for almost 2 years and I want to do something useful and be helpful to Wine. Regards, Yuanchen

2 1

Re: [PATCH] ddraw/tests: Only set DDSCAPS_OVERLAY if supported.
by Henri Verbeet 10 Mar '14

10 Mar '14

On 10 March 2014 14:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + hr = IDirectDraw4_GetCaps(ddraw, &hal_caps, &hel_caps); You're not using "hel_caps". > + if (!overlay_support) > + ddsd.ddsCaps.dwCaps &= ~DDSCAPS_OVERLAY; This will result in trying to create a surface with just DDSCAPS_VIDEOMEMORY set in the caps. What kind of surface do you expect that to create?

2 1

Re: [PATCH 1/2] scrrun: Fix Next() for file collection
by Marvin 10 Mar '14

10 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5554 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

3 4

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 6).
by Henri Verbeet 10 Mar '14

10 Mar '14

On 8 March 2014 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static inline HRESULT wined3d_private_store_set_private_data(struct wined3d_private_store *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) > +{ > + struct wined3d_private_data *entry; > + > + entry = wined3d_private_store_get_private_data(store, guid); > + if (entry) > + wined3d_private_store_free_private_data(store, entry); > + > + entry = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*entry)); > + if (!entry) > + return E_OUTOFMEMORY; > + > + entry->tag = *guid; > + entry->flags = flags; > + entry->size = data_size; > + > + if (flags & WINED3DSPD_IUNKNOWN) > + { > + if (data_size != sizeof(IUnknown *)) > + { > + HeapFree(GetProcessHeap(), 0, entry); > + return WINED3DERR_INVALIDCALL; > + } > + entry->content.object = (IUnknown *)data; > + IUnknown_AddRef(entry->content.object); > + } > + else > + { > + entry->content.data = HeapAlloc(GetProcessHeap(), 0, data_size); > + if (!entry->content.data) > + { > + HeapFree(GetProcessHeap(), 0, entry); > + return E_OUTOFMEMORY; > + } > + memcpy(entry->content.data, data, data_size); > + } > + list_add_tail(&store->content, &entry->entry); > + > + return WINED3D_OK; > +} > + I think this has room for improvement as well.

1 0

Re: [PATCH] ddraw/tests: Only set DDSCAPS_OVERLAY if supported.
by Marvin 10 Mar '14

10 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5559 Your paranoid android. === w8 (32 bit ddraw7) === The test timed out === w8 (32 bit ddraw4) === The test timed out

1 0

Re: [PATCH 2/2] scrrun: Fix Skip() for file collection
by Marvin 10 Mar '14

10 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5555 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

1 0

Re: [2/2] cmd/tests: Correctly compute script path for root directories
by Marvin 09 Mar '14

09 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5547 Your paranoid android. === wxppro (32 bit batch) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 690 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 691 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 694 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 695 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 697 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 699 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 707 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 708 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 710 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 713 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 716 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 729 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 742 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 767 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 780 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1364 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1365 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1366 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1367 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1368 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1369 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1370 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1371 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1373 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1376 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1377 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1380 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w8 (32 bit batch) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: [1/2] cmd/tests: Don't use "@pwd@\" when expecting a full path
by Marvin 09 Mar '14

09 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5546 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@drive@@path@C D@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@drive@@path@E@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@drive@@path@C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@drive@@path@E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @drive@@path@foobar@or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@drive@@path@foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@drive@@path@foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@drive@@path@foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@drive@@path@foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@drive@@path@foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@drive@@path@foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @drive@@path@foobar\foo@or_broken@A @drive@@path@foobar\foo@or_broken@A I @drive@@path@foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @drive@@path@foobar\foo@or_broken@A R @drive@@path@foobar\foo@or_broken@A R I @drive@@path@foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @drive@@path@foobar\baz\level2@or_broken@A @drive@@path@foobar\baz\level2@or_broken@A I @drive@@path@foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @drive@@path@foobar\level1@or_broken@A R @drive@@path@foobar\level1@or_broken@A R I @drive@@path@foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @drive@@path@foobar\baz\level2@or_broken@A R @drive@@path@foobar\baz\level2@or_broken@A R I @drive@@path@foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @drive@@path@foobar\bar@or_broken@A @drive@@path@foobar\bar@or_broken@A I @drive@@path@foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @drive@@path@foobar@or_broken@ @drive@@path@foobar@or_broken@ I @drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @drive@@path@foobar\baz@or_broken@ R @drive@@path@foobar\baz@or_broken@ @drive@@path@foobar\baz@or_broken@ R I @drive@@path@foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @drive@@path@foobar\baz\toto@or_broken@A @drive@@path@foobar\baz\toto@or_broken@A I @drive@@path@foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@drive@@path@foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@drive@@path@foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@drive@@path@foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 315 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

[RFC 6/11] Linux FF: Linux effect: conditional effect's parameters
by Elias Vanderstuyft 09 Mar '14

09 Mar '14

a) There is some ambiguity about the range of the following Linux ff_condition_effect struct members: right_saturation, left_saturation and deadband They are all __u16, but /include/uapi/linux/input.h does not say what the maximum values are. I'm doing a proposal to define and document this (in the Linux kernel) in the following way, also take a look at "interactive.fig" in the kernel documentation: Max Range of {right_saturation and left_saturation} = 0x7FFF Because the maximal value of the saturation bound can be only half of the total range covered by the max negative to max positive bounds. And also because they are related to some form of force, and all other forms of force in linux have a maximum value of 0x7FFF Max Range of {deadband} = 0xFFFF This is a bit harder to explain: - First, I would suggest to alter the deadband definition in figure "interactive.fig": I would define deadband as going from a deadband-bound to the center (=> This is how MSDN defines it: "In other words, the condition is not active between lOffset minus lDeadBand and lOffset plus lDeadBand."), instead of from a deadband-bound to the other deadband-bound. => No changes needed in Wine. - Now, knowing that ff_condition_effect->center is __s16: The worst case scenario is that "center = -32768" or "center = +32767" while still wanting to cover the whole region (this is actually not possible with DInput's specs: in that case, they can only cover half of the total region): Then, to keep the scale of "center" and "deadband" the same, "deadband = 65535" = +32767 - -32768 = 0xFFFF This means that dinput deadband 10000 maps to 32767.5. (And dinput deadband 20000 (not possible in dinput) would map to 65535) => No changes needed in Wine (actually, there was, but applying the changes to the documentation, errors cancel out) => After having discussed this (see http://www.mail-archive.com/linux-input@vger.kernel.org/msg08459.html), the following is true: - offset: [-10000, 10000] (dinput) -> [-0x7FFF, 0x7FFF] (linux) - deadband: [ 0, 10000] (dinput) -> [ 0, 0xFFFF] (linux) - p/n-coeff: [-10000, 10000] (dinput) -> [-0x7FFF, 0x7FFF] (linux) - p/n-sat: [ 0, 10000] (dinput) -> [ 0, 0xFFFF] (linux) So change dinput/effect_linuxinput.c:271 : for (i = 0; i < 2; ++i) { tsp[i].lOffset = (This->effect.u.condition[i].center / 33) * 10; tsp[i].lPositiveCoefficient = (This->effect.u.condition[i].right_coeff / 33) * 10; tsp[i].lNegativeCoefficient = (This->effect.u.condition[i].left_coeff / 33) * 10; tsp[i].dwPositiveSaturation = (This->effect.u.condition[i].right_saturation / 33) * 10; tsp[i].dwNegativeSaturation = (This->effect.u.condition[i].left_saturation / 33) * 10; tsp[i].lDeadBand = (This->effect.u.condition[i].deadband / 33) * 10; } to : for (i = 0; i < 2; ++i) { tsp[i].lOffset = (This->effect.u.condition[i].center / 33) * 10; tsp[i].lPositiveCoefficient = (This->effect.u.condition[i].right_coeff / 33) * 10; tsp[i].lNegativeCoefficient = (This->effect.u.condition[i].left_coeff / 33) * 10; tsp[i].dwPositiveSaturation = (This->effect.u.condition[i].right_saturation / 66) * 10; tsp[i].dwNegativeSaturation = (This->effect.u.condition[i].left_saturation / 66) * 10; tsp[i].lDeadBand = (This->effect.u.condition[i].deadband / 66) * 10; } And change dinput/effect_linuxinput.c:511 : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(factor[i] * (tsp->lPositiveCoefficient / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(factor[i] * (tsp->lNegativeCoefficient / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(factor[i] * (tsp->dwPositiveSaturation / 10) * 32); This->effect.u.condition[i].left_saturation = (int)(factor[i] * (tsp->dwNegativeSaturation / 10) * 32); This->effect.u.condition[i].deadband = (int)(factor[i] * (tsp->lDeadBand / 10) * 32); } to : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(factor[i] * (tsp->lPositiveCoefficient / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(factor[i] * (tsp->lNegativeCoefficient / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(factor[i] * (tsp->dwPositiveSaturation / 10) * 65); This->effect.u.condition[i].left_saturation = (int)(factor[i] * (tsp->dwNegativeSaturation / 10) * 65); This->effect.u.condition[i].deadband = (int)(factor[i] * (tsp->lDeadBand / 10) * 65); } and change dinput/effect_linuxinput.c:522 : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[i].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[i].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[i].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 32; This->effect.u.condition[i].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 32; This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 32; } to : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[i].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[i].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[i].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 65; This->effect.u.condition[i].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 65; This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 65; } b) Spring (or other conditional effects) does not work (aborted in SetParameters while setting a non-zero envelope) in FEdit: This needs discussion: MSDN says: "Typically, you can apply an envelope to a constant force, a ramp force, or a periodic effect, but not to a condition." Linux's ff_condition_effect struct doesn't contain an ff_envelope struct, so it seems to be logically to say "if (!env) return DIERR_INVALIDPARAM;" (dinput/effect_linuxinput.c:444 SetParameters), but when taking a look at the envelope (that FEdit defines for such effect), it seems to be 'neutral': "Envelope has attack (level: 10000 time: 0), fade (level: 10000 time: 0)" So what should we do? - Leave it as is, but this will disable effects on hardware that is capable of applying them (without envelope). - Only return an error if the envelope is not 'neutral', but then we have to provide a rigorous definition of 'neutral'. - Don't return an error. This seems to be the behavior of the Windows Logitech FFB driver (MOMO, MOMO2, ...). Choosing the latter: change dinput/effect_linuxinput.c:444 : if (!env) return DIERR_INVALIDPARAM; /* copy the envelope */ env->attack_length = peff->lpEnvelope->dwAttackTime / 1000; env->attack_level = (peff->lpEnvelope->dwAttackLevel / 10) * 32; env->fade_length = peff->lpEnvelope->dwFadeTime / 1000; env->fade_level = (peff->lpEnvelope->dwFadeLevel / 10) * 32; to : if (!env) WARN("We get passed an envelope for a type (0x%x) that doesn't even have one.\n", This->effect.type); else { /* copy the envelope */ env->attack_length = peff->lpEnvelope->dwAttackTime / 1000; env->attack_level = (peff->lpEnvelope->dwAttackLevel / 10) * 32; env->fade_length = peff->lpEnvelope->dwFadeTime / 1000; env->fade_level = (peff->lpEnvelope->dwFadeLevel / 10) * 32; } Elias

2 2

GSoC 2014
by HuddenSin Yuan 08 Mar '14

08 Mar '14

Hello, I'm Yuanchen,an undergraduate student from China.I have begun to use C to program sth since two years ago.I'm willing to take part in GSoC 2014. The Wine Project has many ideas programed by C,I think I can do sth helpful to you and also can apply what I learn to reality.And I want to do sth cool like fixing bugs. I'm interested in Winetest User Graphic Interface and other similiar ideas which use C. I'll appreciate it very much if you give me some advice. Regards, Yuanchen

2 1

Wine project aspirant for GSOC 2014 : Tools - Winetest Graphical User Interface
by Siddhartha Narang 08 Mar '14

08 Mar '14

Hello , I am Siddhartha Narang a second year Undergraduate in INFORMATION TECHNOLOGY at University Institute of Engineering and Technology (UIET) Panjab University, Chandigarh,India . Skill set :- I have a deep knowledge of C and C++ and have made various games on console like the snake and food, tunnel came , bouncing ball . I have a average knowledge of Data Structures ,linux, Html5. I am currently learning Css . I have gone through various projects of your's for GSOC and the one which interest me a most is Tools - Winetest Graphical User Interface . I am very keen to be a part of this project . What i could interpret from the idea's page about the project is that to build a graphical user interface where user can see the test results . I am very enthusiastic about the coding. I would put my best foot forward to learn as much as I can and try and contribute to your community . It will be very nice of you if you guide me how to go about this project and from where i could start and elaborate what i need to do . Hoping to hear from you soon. -- REGARDS SIDDHARTHA NARANG SECOND YEAR UNDERGRADUATE INFORMATION TECHNOLOGY UIET, PANJAB UNIVERSITY CHANDIGARH , INDIA

2 1

Re: [PATCH 4/4] vbscript: Added support for VARIANT references to interp_newenum.
by Marvin 08 Mar '14

08 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5511 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscipt: Allow ':' to be a separator in select case statement.
by Marvin 08 Mar '14

08 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5510 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] vbscript: Use VariantCopyInd in invoke_variant_prop.
by Marvin 08 Mar '14

08 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5509 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] vbscipt: Use VariantCopyInd in exec_script.
by Marvin 08 Mar '14

08 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5508 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

[RFC 4/11] Linux FF: Linux effect parameter: periodic effect's phase
by Elias Vanderstuyft 07 Mar '14

07 Mar '14

a) Periodic phase is not implemented conform most efficient implementations of linux FF-devices: phase should be related to time, not to angle: - HW interface example: In /drivers/input/joystick/iforce/iforce-ff.c : make_period_modifier(...): "iforce_send_packet(iforce, FF_CMD_PERIOD, data)" where data[4] = HI(phase); make_core(...): "iforce_send_packet(iforce, FF_CMD_EFFECT, data)" where data[4] = HI(duration); => Conclusion: phase likely to be related to time, not to angle - SW kernel interface example, which is going to be used for all memless FF devices in the future: (http://permalink.gmane.org/gmane.linux.kernel/1620326) in ff-memless-next.c:149 : mlnxeff->playback_time = effect->u.periodic.phase - SW interface example: SDL2-2.0.1/src/haptic/linux/SDL_syshaptic.c:640 There is also written on /include/uapi/linux/input.h:1058 : "@phase: 'horizontal' shift" where 'horizontal' most likely means time dimension, not phase of the waveform. => To be sure, I asked this at http://www.mail-archive.com/linux-input@vger.kernel.org/msg08459.html, but didn't receive any answer yet. So change the following in dinput/effect_linuxinput.c:259 : tsp->lOffset = (This->effect.u.periodic.offset / 33) * 10; tsp->dwPhase = (This->effect.u.periodic.phase / 33) * 36; tsp->dwPeriod = (This->effect.u.periodic.period * 1000); to : tsp->lOffset = (This->effect.u.periodic.offset / 33) * 10; if (!This->effect.u.periodic.period) { /* Avoid division by zero period, set tsp->dwPhase arbitrarily to zero. */ tsp->dwPhase = 0; } else tsp->dwPhase = (((int)This->effect.u.periodic.phase * 36000) / This->effect.u.periodic.period) % 36000; tsp->dwPeriod = (This->effect.u.periodic.period * 1000); and change the following in dinput/effect_linuxinput.c:486 : This->effect.u.periodic.offset = (tsp->lOffset / 10) * 32; This->effect.u.periodic.phase = (tsp->dwPhase / 9) * 8; /* == (/ 36 * 32) */ This->effect.u.periodic.period = tsp->dwPeriod / 1000; to : This->effect.u.periodic.offset = (tsp->lOffset / 10) * 32; This->effect.u.periodic.period = tsp->dwPeriod / 1000; This->effect.u.periodic.phase = ((int)(tsp->dwPhase % 36000) * This->effect.u.periodic.period) / 36000; Elias

2 2

[RFC 3/11] Linux FF: Linux effect parameter: start delay
by Elias Vanderstuyft 07 Mar '14

07 Mar '14

a) Keep in mind that startDelay is not supported in DX5 or lower: In the SetParameters(...) case, we're sure This->effect.replay.delay is set to zero, because the HEAP_ZERO_MEMORY flag was set when allocating the LinuxInputEffectImpl 'This' struct in linuxinput_create_effect(...). So change dinput/effect_linuxinput.c:223 : if (dwFlags & DIEP_STARTDELAY) { peff->dwStartDelay = This->effect.replay.delay * 1000; } to : if ((dwFlags & DIEP_STARTDELAY) && (peff->dwSize > sizeof(DIEFFECT_DX5))) { peff->dwStartDelay = This->effect.replay.delay * 1000; } and change dinput/effect_linuxinput.c:463 : if (dwFlags & DIEP_STARTDELAY) This->effect.replay.delay = peff->dwStartDelay / 1000; to : if ((dwFlags & DIEP_STARTDELAY) && (peff->dwSize > sizeof(DIEFFECT_DX5))) This->effect.replay.delay = peff->dwStartDelay / 1000; Elias

2 2

Re: oleaut32: Resolve TypeLib dependencies with GUID
by guillaume.charifi＠sfr.fr 07 Mar '14

07 Mar '14

Hello, I have no certainty, and not even a test, but the Windows version of Skype (which you know is released by Microsoft) tries to load a TypeLib named "uc.tlb", which cannot be find in path, and even in the registry. In fact, this library is into Skype.exe resources section, but it can only be found using its GUID (only the GUID is present in the library, not the name "uc.tlb". In fact it is a unnamed library). So there seems that two possibilities remains : - All the Typelibs of the executable are probed at launch (I don't think so, but...) - The Windows' oleaut32.dll scans the TypeLibs embedded into the executable and tries to match them not only by their name, but by their GUID to. Thanks for your reading, Guillaume ======================================== Message du : 07/03/2014 16:18 De : "Jacek Caban " <jacek(a)codeweavers.com> A : wine-devel(a)winehq.org, guillaume.charifi(a)sfr.fr Copie à : Sujet : Re: oleaut32: Resolve TypeLib dependencies with GUID On 03/07/14 15:53, guillaume.charifi(a)sfr.fr wrote: > Bug: http://bugs.winehq.org/show_bug.cgi?id=34184 Please send a test convincing that that's what Windows does. We already have a typelib in oleaur32 tests, so this should be a matter of loading it by GUID without having it registered. Thanks, Jacek

1 0

Re: oleaut32: Resolve TypeLib dependencies with GUID
by Jacek Caban 07 Mar '14

07 Mar '14

On 03/07/14 15:53, guillaume.charifi(a)sfr.fr wrote: > Bug: http://bugs.winehq.org/show_bug.cgi?id=34184 Please send a test convincing that that's what Windows does. We already have a typelib in oleaur32 tests, so this should be a matter of loading it by GUID without having it registered. Thanks, Jacek

1 0

Re: [PATCH 2/2] vbscript: Directly access 'this' object properties in interpreter.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscipt: Added beginning support for arrays as class members.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5489 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: ws2_32/tests: Mark some test results on Windows 8 as broken.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5487 Your paranoid android. === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 0000000000000000

1 0

Re: [PATCH 2/5] d3d8/tests: Use create_device() in more tests.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5480 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0005019E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x40f890, got 0x40f890.

1 0

Re: StrCatChainW implementation
by Nikolay Sivov 07 Mar '14

07 Mar '14

On 3/6/2014 15:17, Huw Campbell wrote: > Hello > > Please see my implementation of this function, which has not been > seen in wine previously. Explorer.exe calls it, so it's kind of important. > > I ran a lot of tests on the edge cases: including: same ends, 0 ends, > end beyond the length... Hi, Huw. We need those tests in shlwapi/tests. Now regarding patch itself. > +DWORD WINAPI StrCatChainW(PWSTR pszDst, DWORD cchDst, DWORD ichAt, PCWSTR pszSrc) Please use lower case naming that's more readable, like 'dest', 'dest_len', 'at', 'src'. > +{ > + LPWSTR d = pszDst; > + LPCWSTR s = pszSrc; It doesn't look like you need this 'd' and 's', you could use passed pointers. > + DWORD mark; > + > + TRACE("(%s,%i,%i,%s)\n", debugstr_w(pszDst), cchDst, ichAt, debugstr_w(pszSrc)); Is it possible that destination buffer is uninitialized? In this case you can't trace in like this. > + > + if (ichAt == -1) > + mark = strlenW(pszDst); > + else > + mark = ichAt; > + if (mark > cchDst || cchDst == 0) > + return mark; > + if (mark == cchDst) > + mark--; > + d = d + mark; > + if (pszSrc) > + { > + while ((mark < cchDst-1) && *s) > + { > + mark++; > + *d++ = *s++; > + } > + } > + *d = 0; What happens if 'd' is null? Could this loop be replaced with StrNCatW or something similar? > + return mark; > +}

1 0

Re: [PATCH 2/3] gdiplus: Set outer pointer to NULL when image loading functions fail.
by Dmitry Timoshkov 07 Mar '14

07 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > @@ -1365,10 +1365,12 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromFile(GDIPCONST WCHAR* filename, > if(!filename || !bitmap) > return InvalidParameter; > > + *bitmap = NULL; Is there an application that depends on this behaviour? > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if(stat != Ok) > - return stat; > + return InvalidParameter; Probably GdipCreateStreamOnFile should be fixed instead (with tests of course). > > stat = GdipCreateBitmapFromStream(stream, bitmap); > > @@ -2923,10 +2925,12 @@ GpStatus WINGDIPAPI GdipLoadImageFromFile(GDIPCONST WCHAR* filename, > if (!filename || !image) > return InvalidParameter; > > + *image = NULL; Same question as above. > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if (stat != Ok) > - return stat; > + return OutOfMemory; Same note about GdipCreateStreamOnFile. And I don't think that's a good idea to replicate weird return error codes without actually getting any memory allocation errors. -- Dmitry.

2 7

Re: [1/6] user32: Add a test for empty popup menus.
by Dmitry Timoshkov 07 Mar '14

07 Mar '14

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Even with the message test (patch 3), I think this one is worthwhile > as it includes the cases of popup menu initialization in wndproc, and > reusing the HMENU after the error path. These patches look good to me. -- Dmitry.

1 0

Re: [PATCH 1/2] dinput8: Flush input events queue before calling GetDeviceData
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5461 Your paranoid android. === w8 (32 bit device) === device.c:125: Test failed: GetDeviceData() failed: 00000000 device.c:128: Test failed: GetDeviceData() failed: 00000000 cnt:0

1 0

Re: ws2_32/tests: Free TLS after WSACleanup
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5460 Your paranoid android. === w2000pro (32 bit sock) === sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [6/6] user32: Skip menu loop for empty popup menus.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5456 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [5/6] user32: Set capture on the owner of popup menus.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5455 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/6] user32: Add message tests for TrackPopupMenu.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5454 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:8398: Test failed: did not get expected count for minimum timeout (54 != ~64). msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/3] ws2_32/tests: Get rid of the do_oob_send helper function
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5420 Your paranoid android. === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF0720C0 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0

3 4

Wine test day #2: an easy lob
by Jeremy White 06 Mar '14

06 Mar '14

So it looks like the easy test for the day is drag/drop: http://test.winehq.org/data/tests/ole32:dragdrop.html Evidence suggests both that Piotr broke it, but is also working to fix it, so I don't think I get to shame him publicly...yet <grin>. Cheers, Jeremy

3 3

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 5).
by Henri Verbeet 06 Mar '14

06 Mar '14

On 6 March 2014 16:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static inline HRESULT wined3d_private_store_free_private_data(struct wined3d_private_store *store, const GUID *guid) > +{ > + struct wined3d_private_data *entry; > + > + entry = wined3d_private_store_get_private_data(store, guid); > + if (!entry) > + return WINED3DERR_NOTFOUND; > + > + if (entry->flags & WINED3DSPD_IUNKNOWN) > + IUnknown_Release(entry->content.object); > + else > + HeapFree(GetProcessHeap(), 0, entry->content.data); > + > + list_remove(&entry->entry); > + HeapFree(GetProcessHeap(), 0, entry); > + > + return WINED3D_OK; > +} I think it would make more sense to pass this a struct wined3d_private_data pointer instead of a GUID.

2 1

Re: [PATCH] wined3d: Decouple private data from the resource structure (try 4).
by Alexandre Julliard 06 Mar '14

06 Mar '14

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This supersedes patch 103000. > > Try 4: Replace a leftover return E_OUTOFMEMORY with return FALSE. > > Try 3: Move this out of wined3d and wined3d.h and use its own header > with inline functions. This is to avoid COM-related code inside wined3d > among other reasons. I don't think that justifies adding a new global header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 3).
by Henri Verbeet 06 Mar '14

06 Mar '14

On 6 March 2014 10:42, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static inline BOOL wined3d_private_store_set_private_data(struct wined3d_private_store *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) ... > + return E_OUTOFMEMORY; That's pretty ugly.

2 1

Re: [PATCH 1/1] d3d9/tests: Use create_device() in more tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5436 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Use create_device() in more tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5434 Your paranoid android. === w2000pro (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wxppro (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvista (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === w7pro64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038 === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038 === w7pro64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038

1 0

Re: [PATCH 3/5] d3d8/tests: Don't bother handling Direct3DCreate8() failures, we verified it works earlier.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5431 Your paranoid android. === w8 (32 bit device) === device.c:2533: Test failed: Expected foreground window 00030180, got 00010048. device.c:3207: Test failed: Expected wndproc 0x410390, got 0x410390.

1 0

Re: [PATCH 2/5] ddraw/tests: Verify that creating a ddraw object works before running any real tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5430 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:5071: Test failed: Got unexpected refcount 3. ddraw2.c:5090: Test failed: Got unexpected refcount 3. ddraw2.c:5097: Test failed: Got unexpected hr 0. ddraw2.c:5100: Test failed: Got unexpected refcount 3. ddraw2.c:5102: Test failed: Got unexpected refcount 2. ddraw2.c:5108: Test failed: Got unexpected hr 0. ddraw2.c:5111: Test failed: Got unexpected refcount 2. ddraw2.c:5113: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw7) === ddraw7.c:5595: Test failed: Got unexpected refcount 3. ddraw7.c:5614: Test failed: Got unexpected refcount 3. ddraw7.c:5621: Test failed: Got unexpected hr 0. ddraw7.c:5624: Test failed: Got unexpected refcount 3. ddraw7.c:5626: Test failed: Got unexpected refcount 2. ddraw7.c:5632: Test failed: Got unexpected hr 0. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5637: Test failed: Got unexpected refcount 1. ddraw7.c:5639: Test failed: Got unexpected refcount 6. ddraw7.c:5756: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out

1 0

Re: [2/3] ws2_32/tests: Test OOB data more sequential by sending bidirectional
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5419 Your paranoid android. === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF0720C0

1 0

Re: [1/3] ws2_32/tests: Call WSACleanup only once
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5418 Your paranoid android. === w2000pro (32 bit sock) === sock.c:613: Test failed: oob_server (464): unexpectedly at the OOB mark: 0 === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (b24): unexpectedly at the OOB mark: 0 === wvistau64 (32 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:613: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 === wvistau64 (64 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:613: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: kernel32: Cache locale info from the registry.
by Alexandre Julliard 05 Mar '14

05 Mar '14

Vincent Povirk <madewokherd(a)gmail.com> writes: > + case LOCALE_ICALENDARTYPE: *cache_index = 0; return iCalendarTypeW; > + case LOCALE_ICURRDIGITS: *cache_index = 1; return iCurrDigitsW; > + case LOCALE_ICURRENCY: *cache_index = 2; return iCurrencyW; > + case LOCALE_IDIGITS: *cache_index = 3; return iDigitsW; > + case LOCALE_IFIRSTDAYOFWEEK: *cache_index = 4; return iFirstDayOfWeekW; > + case LOCALE_IFIRSTWEEKOFYEAR: *cache_index = 5; return iFirstWeekOfYearW; > + case LOCALE_ILZERO: *cache_index = 6; return iLZeroW; > + case LOCALE_IMEASURE: *cache_index = 7; return iMeasureW; > + case LOCALE_INEGCURR: *cache_index = 8; return iNegCurrW; > + case LOCALE_INEGNUMBER: *cache_index = 9; return iNegNumberW; > + case LOCALE_IPAPERSIZE: *cache_index = 10; return iPaperSizeW; > + case LOCALE_ITIME: *cache_index = 11; return iTimeW; > + case LOCALE_S1159: *cache_index = 12; return s1159W; > + case LOCALE_S2359: *cache_index = 13; return s2359W; > + case LOCALE_SCURRENCY: *cache_index = 14; return sCurrencyW; > + case LOCALE_SDATE: *cache_index = 15; return sDateW; > + case LOCALE_SDECIMAL: *cache_index = 16; return sDecimalW; > + case LOCALE_SGROUPING: *cache_index = 17; return sGroupingW; > + case LOCALE_SLIST: *cache_index = 18; return sListW; > + case LOCALE_SLONGDATE: *cache_index = 19; return sLongDateW; > + case LOCALE_SMONDECIMALSEP: *cache_index = 20; return sMonDecimalSepW; > + case LOCALE_SMONGROUPING: *cache_index = 21; return sMonGroupingW; > + case LOCALE_SMONTHOUSANDSEP: *cache_index = 22; return sMonThousandSepW; > + case LOCALE_SNEGATIVESIGN: *cache_index = 23; return sNegativeSignW; > + case LOCALE_SPOSITIVESIGN: *cache_index = 24; return sPositiveSignW; > + case LOCALE_SSHORTDATE: *cache_index = 25; return sShortDateW; > + case LOCALE_STHOUSAND: *cache_index = 26; return sThousandW; > + case LOCALE_STIME: *cache_index = 27; return sTimeW; > + case LOCALE_STIMEFORMAT: *cache_index = 28; return sTimeFormatW; > + case LOCALE_SYEARMONTH: *cache_index = 29; return sYearMonthW; You clearly want some sort of array here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] d3dx9: Always use type->Rows as D3DXPC_MATRIX_ROWS parameters size. (resend)
by Rico Schüller 05 Mar '14

05 Mar '14

On 03.03.2014 17:48, Matteo Bruni wrote: > diff --git a/dlls/d3dx9_36/tests/shader.c b/dlls/d3dx9_36/tests/shader.c > index 74ada6e..80c0f64 100644 > --- a/dlls/d3dx9_36/tests/shader.c > +++ b/dlls/d3dx9_36/tests/shader.c > @@ -120,7 +120,7 @@ static const DWORD ctab_matrices[] = { > 0x000000ac, > 0x00000058, 0x00070002, 0x00000001, 0x00000064, 0x00000000, /* Constant 1 desc (fmatrix3x1) */ > 0x00000074, 0x00000002, 0x00000004, 0x00000080, 0x00000000, /* Constant 2 desc (fmatrix4x4) */ > - 0x00000090, 0x00040002, 0x00000003, 0x0000009c, 0x00000000, /* Constant 3 desc (imatrix2x3) */ > + 0x00000090, 0x00040002, 0x00000002, 0x0000009c, 0x00000000, /* Constant 3 desc (imatrix2x3) */ Why this? Was the shader blob wrong (invalid)? Or did you just compile with vs without optimization? > 0x74616D66, 0x33786972, 0xab003178, /* Constant 1 name */ > 0x00030003, 0x00010003, 0x00000001, 0x00000000, /* Constant 1 type desc */ > 0x74616D66, 0x34786972, 0xab003478, /* Constant 2 name */ > @@ -133,8 +133,9 @@ static const DWORD ctab_matrices[] = { > > static const D3DXCONSTANT_DESC ctab_matrices_expected[] = { > {"fmatrix4x4", D3DXRS_FLOAT4, 0, 4, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 4, 4, 1, 0, 64, NULL}, > - {"imatrix2x3", D3DXRS_FLOAT4, 4, 3, D3DXPC_MATRIX_ROWS, D3DXPT_INT, 2, 3, 1, 0, 24, NULL}, > - {"fmatrix3x1", D3DXRS_FLOAT4, 7, 1, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 3, 1, 1, 0, 12, NULL}}; > + {"imatrix2x3", D3DXRS_FLOAT4, 4, 2, D3DXPC_MATRIX_ROWS, D3DXPT_INT, 2, 3, 1, 0, 24, NULL}, > + {"fmatrix3x1", D3DXRS_FLOAT4, 7, 1, D3DXPC_MATRIX_COLUMNS, D3DXPT_FLOAT, 3, 1, 1, 0, 12, NULL}, > +}; > > static const DWORD ctab_matrices2[] = { > 0xfffe0200, /* vs_2_0 */ >

2 1

winetestbot day 1: Frustrating lack of personal blame, praise required instead
by Jeremy White 05 Mar '14

05 Mar '14

Alright, So I have started my once a day attack on test.winehq.org. Summary: 049f08f4cda0 04 Mar 39 test failures on wtb * But the win8 wtb did not fire, so there are likely 38 more The first set I examined were the Wine Test Bot Win 2K tests with 12 failures. This is a relatively new VM, and it has a new set of failures, not seen on the old test bot. A number of the test failures: comctl32:listview, comctl32:propsheet, and a few others, look to be timing related. So there is not a clear person to blame; in fact, it may be a qemu bug. However, Nikolay, as the last person to touch the comctl32:listview test, has volunteered to look into this issue and see if he can get to the bottom of it. So I cannot publicly shame anyone, as I had hoped, and instead have to commend Nikolay for volunteering. Cheers, Jeremy

1 0

Re: cmd/tests: Fix a test in Windows 8
by Marvin 05 Mar '14

05 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5397 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@pwd@\C D@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@pwd@\E@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@pwd@\E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar@or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo@or_broken@A @pwd@\foobar\foo@or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo@or_broken@A R @pwd@\foobar\foo@or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2@or_broken@A @pwd@\foobar\baz\level2@or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1@or_broken@A R @pwd@\foobar\level1@or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2@or_broken@A R @pwd@\foobar\baz\level2@or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar@or_broken@A @pwd@\foobar\bar@or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @pwd@\foobar@or_broken@ @pwd@\foobar@or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz@or_broken@ R @pwd@\foobar\baz@or_broken@ @pwd@\foobar\baz@or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto@or_broken@A @pwd@\foobar\baz\toto@or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar')

1 0

Re: msi/tests: Skip some package tests if in a non-administrator, non-power user account.
by Marvin 05 Mar '14

05 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5390 Your paranoid android. === w2000pro (32 bit package) === package.c:3954: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3960: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3966: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3978: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3984: Test failed: Expected "C:\\", got "C:\" package.c:3990: Test failed: Expected "C:\\", got "C:\" package.c:4006: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4017: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4476: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4568: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4579: Test failed: Expected "C:\\", got "C:\" package.c:4590: Test failed: Expected "C:\\", got "C:\" package.c:4640: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4651: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4666: Test failed: Expected "C:\\", got "C:\" package.c:4671: Test failed: Expected "", got "C:\" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4696: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4946: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4957: Test failed: Expected "C:\\", got "C:\" package.c:4963: Test failed: Expected "C:\\", got "C:\" package.c:4984: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4995: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5235: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5241: Test failed: Expected "C:\\", got "C:\" package.c:5258: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5269: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5277: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5621: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6253: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6277: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\ or empty string, got C:\ package.c:6330: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6560: Test failed: Expected "C:\\", got "C:\" package.c:6561: Test failed: Expected 4, got 3 package.c:6568: Test failed: Expected "C:\\", got "C:\" package.c:6569: Test failed: Expected 4, got 3 package.c:6585: Test failed: Expected "C:\\", got "C:\" package.c:6586: Test failed: Expected 4, got 3 package.c:6592: Test failed: Expected "C:\\", got "C:\" package.c:6593: Test failed: Expected 4, got 3 package.c:6600: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6601: Test failed: Expected 14, got 13 package.c:6608: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6609: Test failed: Expected 19, got 18 package.c:6619: Test failed: Expected "C:\\", got "C:\" package.c:6620: Test failed: Expected 4, got 3 package.c:6627: Test failed: Expected "C:\\", got "C:\" package.c:6628: Test failed: Expected 4, got 3 package.c:6644: Test failed: Expected "C:\\", got "C:\" package.c:6645: Test failed: Expected 4, got 3 package.c:6651: Test failed: Expected "C:\\", got "C:\" package.c:6652: Test failed: Expected 4, got 3 package.c:6659: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6660: Test failed: Expected 14, got 13 package.c:6667: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6668: Test failed: Expected 19, got 18 package.c:6678: Test failed: Expected "C:\\", got "C:\" package.c:6679: Test failed: Expected 4, got 3 package.c:6686: Test failed: Expected "C:\\", got "C:\" package.c:6687: Test failed: Expected 4, got 3 package.c:6703: Test failed: Expected "C:\\", got "C:\" package.c:6704: Test failed: Expected 4, got 3 package.c:6710: Test failed: Expected "C:\\", got "C:\" package.c:6711: Test failed: Expected 4, got 3 package.c:6718: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6719: Test failed: Expected 14, got 13 package.c:6726: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6727: Test failed: Expected 19, got 18 package.c:6737: Test failed: Expected "C:\\", got "C:\" package.c:6738: Test failed: Expected 4, got 3 package.c:6745: Test failed: Expected "C:\\", got "C:\" package.c:6746: Test failed: Expected 4, got 3 package.c:6762: Test failed: Expected "C:\\", got "C:\" package.c:6763: Test failed: Expected 4, got 3 package.c:6769: Test failed: Expected "C:\\", got "C:\" package.c:6770: Test failed: Expected 4, got 3 package.c:6777: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6778: Test failed: Expected 14, got 13 package.c:6785: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6786: Test failed: Expected 19, got 18 package.c:6801: Test failed: Expected 4, got 3 package.c:6818: Test failed: Expected 4, got 3 package.c:6824: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6827: Test failed: Expected 4, got 3 package.c:6834: Test failed: Expected "C:\\", got "C:\" package.c:6835: Test failed: Expected 4, got 3 package.c:6846: Test failed: Expected "C:\\", got "C:\" package.c:6847: Test failed: Expected 4, got 3 package.c:6942: Test failed: Expected "C:\\", got "C:\" package.c:6943: Test failed: Expected 4, got 3 package.c:6950: Test failed: Expected "C:\\", got "C:\" package.c:6951: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6969: Test failed: Expected "C:\\", got "C:\" package.c:6970: Test failed: Expected 4, got 3 package.c:6976: Test failed: Expected "C:\\", got "C:\" package.c:6977: Test failed: Expected 4, got 3 package.c:6984: Test failed: Expected "C:\\", got "C:\" package.c:6985: Test failed: Expected 4, got 3 package.c:6992: Test failed: Expected "C:\\", got "C:\" package.c:6993: Test failed: Expected 4, got 3 package.c:7003: Test failed: Expected "C:\\", got "C:\" package.c:7004: Test failed: Expected 4, got 3 package.c:7011: Test failed: Expected "C:\\", got "C:\" package.c:7012: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7030: Test failed: Expected "C:\\", got "C:\" package.c:7031: Test failed: Expected 4, got 3 package.c:7037: Test failed: Expected "C:\\", got "C:\" package.c:7038: Test failed: Expected 4, got 3 package.c:7045: Test failed: Expected "C:\\", got "C:\" package.c:7046: Test failed: Expected 4, got 3 package.c:7053: Test failed: Expected "C:\\", got "C:\" package.c:7054: Test failed: Expected 4, got 3 package.c:7064: Test failed: Expected "C:\\", got "C:\" package.c:7065: Test failed: Expected 4, got 3 package.c:7072: Test failed: Expected "C:\\", got "C:\" package.c:7073: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7091: Test failed: Expected "C:\\", got "C:\" package.c:7092: Test failed: Expected 4, got 3 package.c:7098: Test failed: Expected "C:\\", got "C:\" package.c:7099: Test failed: Expected 4, got 3 package.c:7106: Test failed: Expected "C:\\", got "C:\" package.c:7107: Test failed: Expected 4, got 3 package.c:7114: Test failed: Expected "C:\\", got "C:\" package.c:7115: Test failed: Expected 4, got 3 package.c:7125: Test failed: Expected "C:\\", got "C:\" package.c:7126: Test failed: Expected 4, got 3 package.c:7133: Test failed: Expected "C:\\", got "C:\" package.c:7134: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7152: Test failed: Expected "C:\\", got "C:\" package.c:7153: Test failed: Expected 4, got 3 package.c:7159: Test failed: Expected "C:\\", got "C:\" package.c:7160: Test failed: Expected 4, got 3 package.c:7167: Test failed: Expected "C:\\", got "C:\" package.c:7168: Test failed: Expected 4, got 3 package.c:7175: Test failed: Expected "C:\\", got "C:\" package.c:7176: Test failed: Expected 4, got 3 package.c:7273: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7274: Test failed: Expected 9, got 8 package.c:7283: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7284: Test failed: Expected 9, got 8 package.c:7293: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7294: Test failed: Expected 9, got 8 package.c:7305: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7306: Test failed: Expected 8, got 7 package.c:7317: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7318: Test failed: Expected 9, got 8 package.c:7329: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7330: Test failed: Expected 8, got 7 package.c:7341: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7342: Test failed: Expected 10, got 9 package.c:7353: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7354: Test failed: Expected 8, got 7 package.c:7365: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7366: Test failed: Expected 11, got 10 package.c:7417: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7418: Test failed: Expected 10, got 9 package.c:7427: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7428: Test failed: Expected 10, got 9 package.c:7437: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7438: Test failed: Expected 10, got 9 package.c:7449: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7450: Test failed: Expected 8, got 7 package.c:7461: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7462: Test failed: Expected 10, got 9 package.c:7473: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7474: Test failed: Expected 9, got 8 package.c:7485: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7486: Test failed: Expected 10, got 9 package.c:7497: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7498: Test failed: Expected 9, got 8 package.c:7509: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7510: Test failed: Expected 11, got 10 package.c:7646: Test failed: Expected "C:\\", got "C:\" package.c:7647: Test failed: Expected 4, got 3 package.c:7658: Test failed: Expected "C:\\", got "C:\" package.c:7659: Test failed: Expected 4, got 3 package.c:7666: Test failed: Expected "C:\\", got "C:\" package.c:7667: Test failed: Expected 4, got 3 package.c:7764: Test failed: Expected "C:\\", got "C:\" package.c:7765: Test failed: Expected 4, got 3 package.c:7772: Test failed: Expected "C:\\", got "C:\" package.c:7773: Test failed: Expected 4, got 3 package.c:7780: Test failed: Expected "C:\\", got "C:\" package.c:7781: Test failed: Expected 4, got 3 package.c:7800: Test failed: Expected "C:\\", got "C:\" package.c:7801: Test failed: Expected 4, got 3 package.c:7808: Test failed: Expected "C:\\", got "C:\" package.c:7809: Test failed: Expected 4, got 3 package.c:7828: Test failed: Expected "C:\\", got "C:\" package.c:7829: Test failed: Expected 4, got 3 package.c:7836: Test failed: Expected "C:\\", got "C:\" package.c:7837: Test failed: Expected 4, got 3 package.c:7856: Test failed: Expected "C:\\", got "C:\" package.c:7857: Test failed: Expected 4, got 3 package.c:7864: Test failed: Expected "C:\\", got "C:\" package.c:7865: Test failed: Expected 4, got 3

1 0

Re: atl/tests: Update registrar's is_process_limited() to deal with non-administrator, non-power user accounts.
by Jacek Caban 05 Mar '14

05 Mar '14

Hi Francois, On 03/05/14 11:31, Francois Gouget wrote: > --- > > This should fix the test failures on the fg-win2000-rusr, fg-winxp-lusr > and fg-win7u64-1spie9usr VMs. I think we could change tests to use HKCU only so that those checks are not needed. Could you please test if the attached patch works on those boxes? Thanks, Jacek

1 0

Re: [PATCH 4/5] ddraw/tests: Avoid using EnumDevices() to get a supported Z buffer format.
by Marvin 05 Mar '14

05 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5387 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:752: Test failed: Got unexpected color 0x00000000. ddraw2.c:3207: Test failed: Got unexpected color 0x000000ff. ddraw2.c:5209: Test failed: Got unexpected refcount 3. ddraw2.c:5228: Test failed: Got unexpected refcount 3. ddraw2.c:5235: Test failed: Got unexpected hr 0. ddraw2.c:5238: Test failed: Got unexpected refcount 3. ddraw2.c:5240: Test failed: Got unexpected refcount 2. ddraw2.c:5246: Test failed: Got unexpected hr 0. ddraw2.c:5249: Test failed: Got unexpected refcount 2. ddraw2.c:5251: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:789: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:1464: Test failed: Got unexpected color 0x000000ff. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4085: Test failed: Got unexpected refcount 3. ddraw1.c:4104: Test failed: Got unexpected refcount 3. ddraw1.c:4111: Test failed: Got unexpected hr 0. ddraw1.c:4114: Test failed: Got unexpected refcount 3. ddraw1.c:4116: Test failed: Got unexpected refcount 2. ddraw1.c:4122: Test failed: Got unexpected hr 0. ddraw1.c:4125: Test failed: Got unexpected refcount 2. ddraw1.c:4127: Test failed: Got unexpected refcount 1.

1 0

Re: [PATCH 3/5] ddraw/tests: Add a test for creating surfaces with an explicit pitch.
by Marvin 05 Mar '14

05 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5386 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:746: Test failed: Got unexpected color 0x00000000. ddraw2.c:3199: Test failed: Got unexpected color 0x000000ff. === w8 (32 bit ddraw1) === ddraw1.c:783: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4103: Test failed: Got unexpected refcount 3. ddraw1.c:4122: Test failed: Got unexpected refcount 3. ddraw1.c:4129: Test failed: Got unexpected hr 0. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 2. ddraw1.c:4140: Test failed: Got unexpected hr 0. ddraw1.c:4143: Test failed: Got unexpected refcount 2. ddraw1.c:4145: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5817: Test failed: Got unexpected refcount 3. ddraw4.c:5836: Test failed: Got unexpected refcount 3. ddraw4.c:5843: Test failed: Got unexpected hr 0. ddraw4.c:5846: Test failed: Got unexpected refcount 3. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5854: Test failed: Got unexpected hr 0. ddraw4.c:5857: Test failed: Got unexpected refcount 2. ddraw4.c:5859: Test failed: Got unexpected refcount 1. ddraw4.c:5861: Test failed: Got unexpected refcount 6. ddraw4.c:5985: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6024: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6027: Test failed: Got unexpected hr 0. ddraw4.c:6029: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6032: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6035: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6037: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6040: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6042: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6045: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6047: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [4/5] schedsvc: Implement SchRpcRegisterTask.
by Hans Leidekker 05 Mar '14

05 Mar '14

On Wed, 2014-03-05 at 18:07 +0900, Dmitry Timoshkov wrote: > +static HRESULT write_xml_utf8(const WCHAR *name, DWORD disposition, const WCHAR *xmlW) > +{ > + static const char bom_utf8[] = { 0xef,0xbb,0xbf }; > + static const char comment[] = "\n"; > + HANDLE hfile; > + DWORD size; > + char *xml; > + HRESULT hr = S_OK; > + > + hfile = CreateFileW(name, GENERIC_WRITE, 0, NULL, disposition, 0, 0); > + if (hfile == INVALID_HANDLE_VALUE) > + { > + if (GetLastError() == ERROR_FILE_EXISTS) > + return HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS); > + > + return HRESULT_FROM_WIN32(GetLastError()); > + } > + > + size = WideCharToMultiByte(CP_UTF8, 0, xmlW, -1, NULL, 0, NULL, NULL); > + xml = heap_alloc(size); > + if (!xml) > + { > + CloseHandle(hfile); > + return E_OUTOFMEMORY; > + } > + WideCharToMultiByte(CP_UTF8, 0, xmlW, -1, xml, size, NULL, NULL); > + > + if (!WriteFile(hfile, bom_utf8, strlen(bom_utf8), &size, NULL)) bom_utf8 is not null-terminated.

2 1

Re: [PATCH] msxml3: Added stub support for ISAXDTDHandler/IVBSAXDTDHandler for MXWriter
by Nikolay Sivov 05 Mar '14

05 Mar '14

Please skip this one, it's a part of a series now.

1 0

[RFC 11/11] Linux FF: Debug message fixes/additions
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

a) An effectSpecific structure corresponding with a condition effect, can have 2 possible valid sizes, instead of 1: sizeof(DICONDITION) and 2*sizeof(DICONDITION); the latter is even more common. Solution: change in dinput/joystick.c:216 : if (eff->cbTypeSpecificParams != sizeof(DICONDITION)) { WARN("Effect claims to be a condition but the type-specific params are the wrong size!\n"); } else { _dump_DICONDITION(eff->lpvTypeSpecificParams); } to : if (eff->cbTypeSpecificParams == sizeof(DICONDITION)) { _dump_DICONDITION(eff->lpvTypeSpecificParams); } else if (eff->cbTypeSpecificParams == 2 * sizeof(DICONDITION)) { TRACE("Effect has two condition blocks:\n"); _dump_DICONDITION(eff->lpvTypeSpecificParams); _dump_DICONDITION(eff->lpvTypeSpecificParams + sizeof(DICONDITION)); } else { WARN("Effect claims to be a condition but the type-specific params are the wrong size (0x%x instead of 0x%x)!\n", eff->cbTypeSpecificParams, sizeof(DICONDITION)); } b) Question: consider following code in dinput/effect_linuxinput:369 : if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; Q1: Why is everything set, if dwFlags has no bits set (except DIEP_NORESTART, DIEP_NODOWNLOAD or DIEP_START)? I can see no mention of it on MSDN. Q2: Why "dwFlags = " and not "dwFlags |= "? E.g. assume dwFlags = DIEP_START, then the if-test will cause the DIEP_START flag to be lost, resulting in an effect not started. c) If Q1 is right, then the order of "dump_DIEFFECT" on dinput/effect_linuxinput:367 should be changed, from : dump_DIEFFECT(peff, &This->guid, dwFlags); if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; } to : if ((dwFlags & ~DIEP_NORESTART & ~DIEP_NODOWNLOAD & ~DIEP_START) == 0) { /* set everything */ dwFlags = DIEP_AXES | DIEP_DIRECTION | DIEP_DURATION | DIEP_ENVELOPE | DIEP_GAIN | DIEP_SAMPLEPERIOD | DIEP_STARTDELAY | DIEP_TRIGGERBUTTON | DIEP_TRIGGERREPEATINTERVAL | DIEP_TYPESPECIFICPARAMS; } dump_DIEFFECT(peff, &This->guid, dwFlags); d) Add debug info for rglDirection: Change in dinput/joystick.c:169 : TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - rglDirection: %p\n", eff->rglDirection); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); /* Only trace some members if dwFlags indicates they have data */ if (dwFlags & DIEP_AXES) { TRACE(" - cAxes: %d\n", eff->cAxes); TRACE(" - rgdwAxes: %p\n", eff->rgdwAxes); if (TRACE_ON(dinput) && eff->rgdwAxes) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rgdwAxes[i]); TRACE("\n"); } } to : TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); /* Only trace some members if dwFlags indicates they have data */ if ((dwFlags & DIEP_AXES) || (dwFlags & DIEP_DIRECTION)) { TRACE(" - cAxes: %d\n", eff->cAxes); if (dwFlags & DIEP_AXES) { TRACE(" - rgdwAxes: %p\n", eff->rgdwAxes); if (TRACE_ON(dinput) && eff->rgdwAxes) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rgdwAxes[i]); TRACE("\n"); } } if (dwFlags & DIEP_DIRECTION) { TRACE(" - rglDirection: %p\n", eff->rglDirection); if (TRACE_ON(dinput) && eff->rglDirection) { TRACE(" "); for (i = 0; i < eff->cAxes; ++i) TRACE("%d ", eff->rglDirection[i]); TRACE("\n"); } } } e) Add debug info for dwSamplePeriod: Change in dinput/joystick.c:166 : if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); to : if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); f) Why not consistently only trace set (and probably thus valid) parameters in dump_DIEFFECT? Change in dinput/joystick.c:163 : TRACE(" - dwDuration: %d\n", eff->dwDuration); TRACE(" - dwGain: %d\n", eff->dwGain); if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); to : if (dwFlags & DIEP_DURATION) TRACE(" - dwDuration: %d\n", eff->dwDuration); if (dwFlags & DIEP_GAIN) { TRACE(" - dwGain: %d\n", eff->dwGain); if (eff->dwGain > 10000) WARN("dwGain is out of range (>10,000)\n"); } if (dwFlags & DIEP_SAMPLEPERIOD) TRACE(" - dwSamplePeriod: %d\n", eff->dwSamplePeriod); if (dwFlags & DIEP_TRIGGERBUTTON) TRACE(" - dwTriggerButton: %d\n", eff->dwTriggerButton); if (dwFlags & DIEP_TRIGGERREPEATINTERVAL) TRACE(" - dwTriggerRepeatInterval: %d\n", eff->dwTriggerRepeatInterval); if (dwFlags & DIEP_TYPESPECIFICPARAMS) { TRACE(" - cbTypeSpecificParams: %d\n", eff->cbTypeSpecificParams); TRACE(" - lpvTypeSpecificParams: %p\n", eff->lpvTypeSpecificParams); } and change on dinput/joystick.c:194 : if (eff->dwSize > sizeof(DIEFFECT_DX5)) TRACE(" - dwStartDelay: %d\n", eff->dwStartDelay); to : if ((dwFlags & DIEP_STARTDELAY) && (eff->dwSize > sizeof(DIEFFECT_DX5))) TRACE(" - dwStartDelay: %d\n", eff->dwStartDelay); Note: If applying that patch, maybe we should use TRACE_ON(dinput) to circumvent all these ifs for performance reasons? Elias

1 0

[RFC 10/11] Linux FF: Linux joystick initialization
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

a) In dinput/joystick_linuxinput.c:546 : Why not change (to fill in additional device capabilities) : if (newDevice->joydev->has_ff) newDevice->generic.devcaps.dwFlags |= DIDC_FORCEFEEDBACK; to : if (newDevice->joydev->has_ff) { newDevice->generic.devcaps.dwFlags |= DIDC_FORCEFEEDBACK; newDevice->generic.devcaps.dwFlags |= DIDC_STARTDELAY; if ( test_bit(newDevice->joydev->ffbits, FF_CONSTANT) || test_bit(newDevice->joydev->ffbits, FF_PERIODIC) || test_bit(newDevice->joydev->ffbits, FF_RAMP) ) newDevice->generic.devcaps.dwFlags |= DIDC_FFATTACK | DIDC_FFFADE; if ( test_bit(newDevice->joydev->ffbits, FF_SPRING) || test_bit(newDevice->joydev->ffbits, FF_DAMPER) || test_bit(newDevice->joydev->ffbits, FF_INERTIA) || test_bit(newDevice->joydev->ffbits, FF_FRICTION) ) newDevice->generic.devcaps.dwFlags |= DIDC_POSNEGCOEFFICIENTS | DIDC_POSNEGSATURATION | DIDC_SATURATION; } Elias

1 0

[RFC 9/11] Linux FF: Linux effect parameters (global)
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

a) All DInput effect parameters to need to be translated to linux effect parameters, are either DWORD, or LONG. That means that their maximum absolute values are both equal to 2147483648 (both are 4-byte signed two-complement). All these parameters are limited to a maximum absolute value of DI_FFNOMINALMAX (=10000), except for the time parameters such as period, duration, startdelay, ... and for the elements of "rglDirection" (LONG array). All linux effect parameters do never exceed a size of 16 bits: __s16 and __u16. That means that their maximum absolute values are respectively 32768 and 65535. This means that: - If the parameters with DI_FFNOMINALMAX limits exceed this limit, we should *consistently* either: - Emit "DIERR_INVALIDPARAM" - Clamp to the correct range => The latter is preferred, and already applied in the ConstantForce case, but overall not consistently: e.g. it is not done in the Periodic case, ... So, change (e.g. for ramp levels) on dinput/effect_linuxinput.c:500 : This->effect.u.ramp.start_level = (tsp->lStart / 10) * 32; This->effect.u.ramp.end_level = (tsp->lEnd / 10) * 32; to : This->effect.u.ramp.start_level = (max(min(tsp->lStart, 10000), -10000) / 10) * 32; This->effect.u.ramp.end_level = (max(min(tsp->lEnd, 10000), -10000) / 10) * 32; And the same applies to many other lines of code, but I don't write them yet if I don't know whether this proposal will be accepted. - If the parameters are time-related, plain conversion from dinput to linux could cause parameters to wrap around (even when first dividing by 1000 (to go from millis->micros)), because all time values in linux are maximum 0x7FFF (/include/uapi/linux/input.h:966). We can not emit "DIERR_INVALIDPARAM" when these parameters exceed linux' parameters' range, because it is not forbidden by MSDN. => So we should clamp them before conversion. So, change dinput/effect_linuxinput.c:424 : if (dwFlags & DIEP_DURATION) { if (peff->dwDuration == -1) This->effect.replay.length = 0; // Infinity else if (peff->dwDuration > 1000) This->effect.replay.length = peff->dwDuration / 1000; else This->effect.replay.length = 1; // Smallest non-zero value } to : if (dwFlags & DIEP_DURATION) { if (peff->dwDuration == -1) This->effect.replay.length = 0; // Infinity else if (peff->dwDuration > 1000) This->effect.replay.length = min(peff->dwDuration / 1000, 0x7FFF); else This->effect.replay.length = 1; // Smallest non-zero value } And the same applies to many other lines of code, but I don't write them yet if I don't know whether this proposal will be accepted. - If the parameters are direction-related, we should also be careful for parameters to not wrap around, but I did not find such a problem in effect_linuxinput.c b) Provide a more accurate mapping of force levels from dinput to linux, (the "from linux to dinput" case is less important): Ensure 10000 (dinput) maps exactly to 32767 (linux), this will prevent glitches when envelopes are applied on top of an already maxed out forces. => Variations from 32000 to 32767 can occur in the attack or fade region. These may be small, but when the frequency of effects started is high, this may be significantly perceivable. Change for all force conversions from dinput to linux (e.g. for constant.level) on dinput/effect_linuxinput.c:494 : This->effect.u.constant.level = (max(min(tsp->lMagnitude, 10000), -10000) / 10) * 32; to : This->effect.u.constant.level = (max(min(tsp->lMagnitude, 10000), -10000) * 0x7FFF) / 10000; And the same applies to many other lines of code, but I don't write them yet if I don't know whether this proposal will be accepted. c) Optimize code to eliminate (almost) all floating point operations when translating effect parameters from dinput to linux. (the "from linux to dinput" case is less important) If not possible, eliminate it for the common cases. We will use the uint16_t type, so we need to include stdint.h, change on dinput/effect_linuxinput.c:26 : #include <stdarg.h> #include <string.h> to : #include <stdarg.h> #include <stdint.h> #include <string.h> Change on dinput/effect_linuxinput.c:415 : This->effect.direction = (unsigned int)((M_PI / 2 + atan2(peff->rglDirection[1], peff->rglDirection[0])) * 0x8000 / M_PI); to : if (!peff->rglDirection[1]) This->effect.direction = (peff->rglDirection[0] >= 0 ? 0x4000 : 0xC000); else if (!peff->rglDirection[0]) This->effect.direction = (peff->rglDirection[1] >= 0 ? 0x8000 : 0); else This->effect.direction = (uint16_t)((M_PI / 2 + atan2(peff->rglDirection[1], peff->rglDirection[0])) * 0x8000 / M_PI); And change on dinput/effect_linuxinput.c:416 : } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); } to : } else if (peff->dwFlags & DIEFF_SPHERICAL) { /* Avoid floating point arithmetic in most cases, while realizing same precision * (when abs(peff->rglDirection[0]) < 0x00080000 = 524288 which is much larger than 35999), * otherwise, use floating point arithmetic */ if (-0x00080000 < peff->rglDirection[0] && peff->rglDirection[0] < 0x00080000) This->effect.direction = 0x4000 + (uint16_t)((peff->rglDirection[0] * 0x1000) / 2250); else This->effect.direction = 0x4000 + (uint16_t)(((double)peff->rglDirection[0] / 2250) * 0x1000); } else /* if (peff->dwFlags & DIEFF_POLAR) */ { /* Avoid floating point arithmetic in most cases, while realizing same precision * (when abs(peff->rglDirection[0]) < 0x00080000 = 524288 which is much larger than 35999), * otherwise, use floating point arithmetic */ if (-0x00080000 < peff->rglDirection[0] && peff->rglDirection[0] < 0x00080000) This->effect.direction = (uint16_t)((peff->rglDirection[0] * 0x1000) / 2250); else This->effect.direction = (uint16_t)(((double)peff->rglDirection[0] / 2250) * 0x1000); } d) If previously a successful SetParameters(...) has been called, and then SetParameters(...) is called again, but now with only DIEP_AXES flag set in the 'dwFlags' parameter (and not DIEP_DIRECTION, because it was already done before): => Problem, "effect.direction" is not updated (and instead it should, because it's dependent of the axes config). I did not provide a patch here, because it would require to store extra data. This needs discussion. e) If previously a successful SetParameters(...) has been called with the DIEP_TYPESPECIFICPARAMS flag set, and then SetParameters(...) is called again, but now with only DIEP_AXES and/or DIEP_DIRECTION flag set: => Problem if type == DIEFT_CONDITION: "effect.u.condition[i].*" are not updated (and instead they should, because they are dependent of the axes config and the direction). I did not provide a patch here, because it would require to store extra data. This needs discussion. f) We might use 'DIEFFECT.dwGain'/10000 to multiply with all forces of the corresponding effect. In that way, we don't have to set global gain on Linux each time another DIEFFECT.dwGain value occurs. Also this can suffer from the same problem as above: if only the 'dwGain' value is updated in SetParameters(...) after the effect was previously already fully defined, the force values would also need to be updated (because they are dependent of the gain). I did not provide a patch here, because it would require to store extra data. This needs discussion. Elias

1 0

[RFC 8/11] Linux FF: Linux effect direction
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

a) Some common mistakes about linux directions: - using 0x7FFF as ~359 degrees for linux direction, instead of 0xFFFF (look at /include/uapi/linux/input.h:1117) - the everlasting confusion about how to map dinput to linux directions, this proves to be a difficult topic, only by finding out that the SDL2 haptic implementation does a different conversion than Wine does, and since only one possibility is the right one, at least one of the implementations is wrong. It turns out they're both wrong. With this explanation, I try to finally come up with the right implementation, by deriving it in a systematical way. This explanation has been verified by the linux input mailing lists: http://www.mail-archive.com/linux-input@vger.kernel.org/msg08459.html Directions ========== For conversions between different APIs, the physical behaviour should be the same. DInput ______ Extracted from http://msdn.microsoft.com/en-us/library/windows/desktop/ee417536%28v=vs.85%… : Physical situation: North (polar 0, spher[0] 270) (0, -1) -y Far West East (polar 90, spher[0] 0) (-1, 0) O (+1, 0) -x Left +x Right South (0, +1) +y Near .------. | User | '------' Remember these are the 'directions': as defined as the direction the user should exert force in to counteract the force. So the direction in which the force is applied by the joystick, is opposite. If we're interested in the direction in which the force is applied by the joystick, the physical situation becomes point-flipped: (polar 0, spher[0] 270) (0, +1) +y (polar 270, spher[0] 180) (polar 90, spher[0] 0) (+1, 0) O (-1, 0) +x -x (polar 180, spher[0] 90) (0, -1) -y Linux _____ Extracted from Linux /include/uapi/linux/input.h:1113, and from the discussion with Anssi Hannula in the mailing lists : Physical situation: Up (dir 180) (0, -1) -y Left (dir 90) Right (dir 270) (-1, 0) O (+1, 0) -x +x Down (dir 0) (0, +1) +y .------. | User | '------' It is unclear what is meant by 'directions' in this case: Possibility #1: counteraction direction of user Possibility #2: direction of force applied by joystick Anssi Hannula confirmed that Possibility #2 is the right one. Mapping _______ In the "Carts" column, you can find the Cartesian coordinates which indicate the counteraction direction of user. (This choice is arbitrary ('direction of force applied by joystick' could also have been chosen), just to have a physical reference.) These "Carts" tuples should be equal across APIs to ensure equal behavior. #Assume Possibility #1: # # DInput <-> Linux # _________________ | ___________ # Carts|Polar|Spher | Carts|Direc # -----+-----+----- | -----+----- # 0, -1| 0 | 270 | 0, -1| 180 # +1, 0| 90 | 0 | +1, 0| 270 # 0, +1| 180 | 90 | 0, +1| 0 # -1, 0| 270 | 180 | -1, 0| 90 Assume Possibility #2: => Linux Cartesian coordinates are opposite in respect to the "Carts" reference. DInput <-> Linux _________________ | ___________ Carts|Polar|Spher | Carts|Direc -----+-----+----- | -----+----- 0, -1| 0 | 270 | 0, -1| 0 +1, 0| 90 | 0 | +1, 0| 90 0, +1| 180 | 90 | 0, +1| 180 -1, 0| 270 | 180 | -1, 0| 270 This conversion table will be used in this document. On effect_linuxinput.c:385, there is written: /* some of this may look funky, but it's 'cause the linux driver and directx have * different opinions about which way direction "0" is. directx has 0 along the x * axis (left), linux has it along the y axis (down). */ The part "directx has 0 along the x axis (left)" contradicts with "angle bases: 0 -> -y (down) (linux) -> 0 -> +x (right) (windows)" on line 148, because 'left' != 'right'. Also, this comment seems to be about the dinput spherical coordinates, instead of polar. Applying the conversion table on dinput/effect_linuxinput.c:385, change : /* some of this may look funky, but it's 'cause the linux driver and directx have * different opinions about which way direction "0" is. directx has 0 along the x * axis (left), linux has it along the y axis (down). */ if (dwFlags & DIEP_DIRECTION) { if (peff->cAxes == 1) { if (peff->dwFlags & DIEFF_CARTESIAN) { if (dwFlags & DIEP_AXES) { if (peff->rgdwAxes[0] == DIJOFS_X && peff->rglDirection[0] >= 0) This->effect.direction = 0x4000; else if (peff->rgdwAxes[0] == DIJOFS_X && peff->rglDirection[0] < 0) This->effect.direction = 0xC000; else if (peff->rgdwAxes[0] == DIJOFS_Y && peff->rglDirection[0] >= 0) This->effect.direction = 0; else if (peff->rgdwAxes[0] == DIJOFS_Y && peff->rglDirection[0] < 0) This->effect.direction = 0x8000; to : /* some of this may look funky, but it's 'cause the linux driver and directx have * different opinions about which way direction "0" is. directx has 0 along the y * axis (north/far, counteract), linux has it along the y axis (down). */ if (dwFlags & DIEP_DIRECTION) { if (peff->cAxes == 1) { if (peff->dwFlags & DIEFF_CARTESIAN) { if (peff->rgdwAxes[0] == DIJOFS_X && peff->rglDirection[0] >= 0) This->effect.direction = 0x4000; else if (peff->rgdwAxes[0] == DIJOFS_X && peff->rglDirection[0] < 0) This->effect.direction = 0xC000; else if (peff->rgdwAxes[0] == DIJOFS_Y && peff->rglDirection[0] >= 0) This->effect.direction = 0x8000; else if (peff->rgdwAxes[0] == DIJOFS_Y && peff->rglDirection[0] < 0) This->effect.direction = 0; Change dinput/effect_linuxinput.c:148 : /* Major conversion factors are: * times: millisecond (linux) -> microsecond (windows) (x * 1000) * forces: scale 0x7FFF (linux) -> scale 10000 (windows) approx ((x / 33) * 10) * angles: scale 0x7FFF (linux) -> scale 35999 (windows) approx ((x / 33) * 36) * angle bases: 0 -> -y (down) (linux) -> 0 -> +x (right) (windows) */ to : /* Major conversion factors are: * times: millisecond (linux) -> microsecond (windows) (x * 1000) * forces: scale 0x7FFF (linux) -> scale 10000 (windows) approx ((x / 33) * 10) * angles: scale 0xFFFF (linux) -> scale 35999 (windows) approx ((x / 66) * 36) * angle bases: 0 -> +y (down) (linux) -> 0 -> -y (far: counteract direction) (windows polar) */ and change dinput/effect_linuxinput.c:184 : peff->rglDirection[0] = (This->effect.direction / 33) * 36 + 9000; if (peff->rglDirection[0] > 35999) peff->rglDirection[0] -= 35999; to : peff->rglDirection[0] = (This->effect.direction / 66) * 36; and change dinput/effect_linuxinput.c:415 : This->effect.direction = (int)((3 * M_PI / 2 - atan2(y, x)) * -0x7FFF / M_PI); to : This->effect.direction = (unsigned int)((M_PI / 2 + atan2(y, x)) * 0x8000 / M_PI); and change dinput/effect_linuxinput.c:505 : /* One condition block. This needs to be rotated to direction, * and expanded to separate x and y conditions. */ int i; double factor[2]; factor[0] = asin((This->effect.direction * 3.0 * M_PI) / 0x7FFF); factor[1] = acos((This->effect.direction * 3.0 * M_PI) / 0x7FFF); to : /* One condition block. This needs to be rotated to direction, * using dinput Cartesian coordinates, and expanded to separate x and y conditions. */ int i; double factor[2]; factor[0] = +sin((This->effect.direction * M_PI) / 0x8000); factor[1] = -cos((This->effect.direction * M_PI) / 0x8000); b) Applying direction seems to have no influence on X and Y force. (It's always polar 0 degrees) Tested in FEdit => Multiple things in the implementation are wrong: - typo in the bracket placement for the double-to-int conversion - forgetting (typo) that dinput works with 9000 instead of 90 (inconsistent with linux->dinput conversion of GetParameters) - common mistakes about linux directions, see above - it is more readable and accurate to use "* (0x8000 / 18000)" than "* (0xFFFF / 35999)", and wrapping of this (effect.direction) u16 is intentional. Solution: Change dinput/effect_linuxinput.c:419 : This->effect.direction = (int)(((double)peff->rglDirection[0] - 90) / 35999) * 0x7FFF; to : This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); c) Multiple things are weird/wrong here: - common mistakes about linux directions, see above - "M_PI * 3", why '3' ??? - Why "1000" as max magnitude of direction? type(rglDirection[i]) == 'LONG' => You can pick at least 10000 (DI_FFNOMINALMAX). So, change dinput/effect_linuxinput.c:174 : if (peff->dwFlags & DIEFF_CARTESIAN) { peff->rglDirection[0] = sin(M_PI * 3 * This->effect.direction / 0x7FFF) * 1000; peff->rglDirection[1] = cos(M_PI * 3 * This->effect.direction / 0x7FFF) * 1000; to : if (peff->dwFlags & DIEFF_CARTESIAN) { peff->rglDirection[0] = +sin(This->effect.direction * M_PI / 0x8000) * DI_FFNOMINALMAX; peff->rglDirection[1] = -cos(This->effect.direction * M_PI / 0x8000) * DI_FFNOMINALMAX; d) The statement "Polar and spherical are the same for 2 axes" is wrong: http://msdn.microsoft.com/en-us/library/windows/desktop/ee417536%28v=vs.85%… : "Polar coordinates are expressed as a single angle, in hundredths of a degree clockwise from whatever zero-point, or true north, has been established for the effect. Normally this is the negative y-axis; that is, away from the user." => (0, -1) direction is Polar starting direction (angle = 0) http://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_s… : "If spherical, the first angle is measured in hundredths of a degree from the (1, 0) direction, rotated in the direction of (0, 1)." => (1, 0) direction is Spherical starting direction (angle = 0) (also take a look at the conversion table) So, change dinput/effect_linuxinput.c:177 : } else { /* Polar and spherical coordinates are the same for two or less * axes. * Note that we also use this case if NO flags are marked. * According to MSDN, we should return the direction in the * format that it was specified in, if no flags are marked. */ peff->rglDirection[0] = (This->effect.direction / 66) * 36; } to : } else if (peff->dwFlags & DIEFF_SPHERICAL) { peff->rglDirection[0] = 27000 + (This->effect.direction / 66) * 36; if (peff->rglDirection[0] >= 36000) peff->rglDirection[0] -= 36000; } else /* if (peff->dwFlags & DIEFF_POLAR) */ { /* Note that we return polar coordinates if NO flags are marked. * According to MSDN, we should return the direction in the * format that it was specified in, if no flags are marked. * TODO: Return the direction in the format that it was specified in, * if no flags are marked. */ peff->rglDirection[0] = (This->effect.direction / 66) * 36; } And change dinput/effect_linuxinput.c:416 : } else { /* Polar and spherical are the same for 2 axes */ /* Precision is important here, so we do double math with exact constants */ This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); } to : } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); } e) If "first_axis_is_x" in effect_linuxinput.c happens to be "false" and "cAxes == 2", doesn't the assignment of "effect.direction" in SetParameters(...) need additional transformations if "(peff->dwFlags & DIEFF_POLAR) != 0"? Because then x and y axis are swapped. With swapped x and y axes, then the following conversions hold: #Assume Possibility #1: # # DInput <-> Linux # _________________ | ___________ # Carts|Polar|Spher | Carts|Direc # -----+-----+----- | -----+----- # -1, 0| 0 | 270 | -1, 0| 90 # 0, +1| 90 | 0 | 0, +1| 0 # +1, 0| 180 | 90 | +1, 0| 270 # 0, -1| 270 | 180 | 0, -1| 180 Assume Possibility #2: => Linux Cartesian coordinates are opposite in respect to the "Carts" reference. DInput <-> Linux _________________ | ___________ Carts|Polar|Spher | Carts|Direc -----+-----+----- | -----+----- -1, 0| 0 | 270 | -1, 0| 270 0, +1| 90 | 0 | 0, +1| 180 +1, 0| 180 | 90 | +1, 0| 90 0, -1| 270 | 180 | 0, -1| 0 (Possibility #2 is the correct one) So change dinput/effect_linuxinput.c:416 : } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); } to : } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); if (!This->first_axis_is_x) This->effect.direction = 0xC000 - This->effect.direction; } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); if (!This->first_axis_is_x) This->effect.direction = 0xC000 - This->effect.direction; } Then we can simplify the following code of dinput/effect_linuxinput.c:405 : } else { /* two axes */ if (peff->dwFlags & DIEFF_CARTESIAN) { LONG x, y; if (This->first_axis_is_x) { x = peff->rglDirection[0]; y = peff->rglDirection[1]; } else { x = peff->rglDirection[1]; y = peff->rglDirection[0]; } This->effect.direction = (unsigned int)((M_PI / 2 + atan2(y, x)) * 0x8000 / M_PI); } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); if (!This->first_axis_is_x) This->effect.direction = 0xC000 - This->effect.direction; } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); if (!This->first_axis_is_x) This->effect.direction = 0xC000 - This->effect.direction; } } to : } else { /* two axes */ if (peff->dwFlags & DIEFF_CARTESIAN) { This->effect.direction = (unsigned int)((M_PI / 2 + atan2(peff->rglDirection[1], peff->rglDirection[0])) * 0x8000 / M_PI); } else if (peff->dwFlags & DIEFF_SPHERICAL) { This->effect.direction = (unsigned int)(((9000 + (double)peff->rglDirection[0]) / 18000) * 0x8000); } else /* if (peff->dwFlags & DIEFF_POLAR) */ { This->effect.direction = (unsigned int)(((double)peff->rglDirection[0] / 18000) * 0x8000); } if (!This->first_axis_is_x) This->effect.direction = 0xC000 - This->effect.direction; } f) Condition effects (with struct-size of 2*sizeof(DICONDITION)) should keep "first_axis_is_x" into account: Change dinput/effect_linuxinput.c:520 : /* Two condition blocks. Direct parameter copy. */ int i; for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[i].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[i].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[i].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 65; This->effect.u.condition[i].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 65; This->effect.u.condition[i].deadband = (tsp[i].lDeadBand / 10) * 65; } to : /* Two condition blocks. Direct parameter copy, after a small change of axes if needed. */ int i, j; for (i = 0; i < 2; ++i) { j = (first_axis_is_x ? i : 1-i); This->effect.u.condition[j].center = (tsp[i].lOffset / 10) * 32; This->effect.u.condition[j].right_coeff = (tsp[i].lPositiveCoefficient / 10) * 32; This->effect.u.condition[j].left_coeff = (tsp[i].lNegativeCoefficient / 10) * 32; This->effect.u.condition[j].right_saturation = (tsp[i].dwPositiveSaturation / 10) * 65; This->effect.u.condition[j].left_saturation = (tsp[i].dwNegativeSaturation / 10) * 65; This->effect.u.condition[j].deadband = (tsp[i].lDeadBand / 10) * 65; } The condition effects with struct-size of 1*sizeof(DICONDITION) don't need changes regarding "first_axis_is_x", because "factor[i]" depends on "effect.direction", which already incorporates "first_axis_is_x". g) Condition effects (with struct-size of 1*sizeof(DICONDITION)) are not transformed exactly right, look at "interactive.fig" for more understanding of the suggested code: - "deadband" can't be negative - for "left/right_coeff" and "left/right_saturation", if a direction along an axis is negative, "left" and "right" should be swapped Change dinput/effect_linuxinput.c:511 : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(factor[i] * (tsp->lPositiveCoefficient / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(factor[i] * (tsp->lNegativeCoefficient / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(factor[i] * (tsp->dwPositiveSaturation / 10) * 65); This->effect.u.condition[i].left_saturation = (int)(factor[i] * (tsp->dwNegativeSaturation / 10) * 65); This->effect.u.condition[i].deadband = (int)(factor[i] * (tsp->lDeadBand / 10) * 65); } to : for (i = 0; i < 2; ++i) { This->effect.u.condition[i].center = (int)(factor[i] * (tsp->lOffset / 10) * 32); This->effect.u.condition[i].right_coeff = (int)(abs(factor[i]) * ((factor[i] >= 0 ? tsp->lPositiveCoefficient : tsp->lNegativeCoefficient) / 10) * 32); This->effect.u.condition[i].left_coeff = (int)(abs(factor[i]) * ((factor[i] >= 0 ? tsp->lNegativeCoefficient : tsp->lPositiveCoefficient) / 10) * 32); This->effect.u.condition[i].right_saturation = (int)(abs(factor[i]) * ((factor[i] >= 0 ? tsp->dwPositiveSaturation : tsp->dwNegativeSaturation) / 10) * 65); This->effect.u.condition[i].left_saturation = (int)(abs(factor[i]) * ((factor[i] >= 0 ? tsp->dwNegativeSaturation : tsp->dwPositiveSaturation) / 10) * 65); This->effect.u.condition[i].deadband = (int)(abs(factor[i]) * (tsp->lDeadBand / 10) * 65); } Elias

1 0

[RFC 7/11] Linux FF: Linux effect: axes
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

a) In dinput/effect_linuxinput.c, the GetParameters(...) and SetParameters(...) functions implicitly assume that (DIEFFECT.dwFlags & DIEFF_OBJECTOFFSETS) != 0, but the other flag 'DIEFF_OBJECTIDS' is also possible according to MSDN: The semantics of dwTriggerButton and rgdwAxes are determined by the flags DIEFF_OBJECTIDS and DIEFF_OBJECTOFFSETS. (http://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_s…) But I don't know exactly how to convert values determined by DIEFF_OBJECTIDS to values determined by DIEFF_OBJECTOFFSETS. => Suggestions? (the reason why this hasn't yet resulted in problems, is because the usage of 'DIEFF_OBJECTIDS' seems to be rare) Elias

1 0

Re: advapi32/tests: Change the current directory to a place that will be writable.
by Alexandre Julliard 04 Mar '14

04 Mar '14

Francois Gouget <fgouget(a)free.fr> writes: > --- > dlls/advapi32/tests/eventlog.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/dlls/advapi32/tests/eventlog.c b/dlls/advapi32/tests/eventlog.c > index f71529c..525d606 100644 > --- a/dlls/advapi32/tests/eventlog.c > +++ b/dlls/advapi32/tests/eventlog.c > @@ -1123,6 +1123,8 @@ static void cleanup_eventlog(void) > > START_TEST(eventlog) > { > + char curdir[MAX_PATH], tmpdir[MAX_PATH]; > + > SetLastError(0xdeadbeef); > CloseEventLog(NULL); > if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > @@ -1131,6 +1133,10 @@ START_TEST(eventlog) > return; > } > > + GetCurrentDirectoryA(MAX_PATH, curdir); > + GetTempPathA(MAX_PATH, tmpdir); > + SetCurrentDirectoryA(tmpdir); > + A better fix would be to build proper temp file names with GetTempPath+GetTempFileName instead of using hardcoded paths in file creation calls. -- Alexandre Julliard julliard(a)winehq.org

1 0

Need help getting Win32_PNPEntity WMI class added
by Luke A. Guest 04 Mar '14

04 Mar '14

Hi, I thought I understood this thing, but I don't. I'm trying to get this working so that I can work towards getting Rocksmith going. I've added: diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 4b02ea2..0051837 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -75,6 +75,8 @@ static const WCHAR class_paramsW[] = {'_','_','P','A','R','A','M','E','T','E','R','S',0}; static const WCHAR class_physicalmediaW[] = {'W','i','n','3','2','_','P','h','y','s','i','c','a','l','M','e','d','i','a',0}; +static const WCHAR class_pnpentityW[] = + {'W','i','n','3','2','_','P','N','P','E','n','t','i','t','y',0}; static const WCHAR class_qualifiersW[] = {'_','_','Q','U','A','L','I','F','I','E','R','S',0}; static const WCHAR class_process_getowner_outW[] = @@ -394,6 +396,10 @@ static const struct column col_physicalmedia[] = { { prop_serialnumberW, CIM_STRING } }; +static const struct column col_pnpentity[] = +{ + { prop_deviceidW, CIM_STRING|COL_FLAG_KEY } +}; static const struct column col_process[] = { { prop_captionW, CIM_STRING|COL_FLAG_DYNAMIC }, @@ -513,6 +519,8 @@ static const WCHAR diskdrive_manufacturerW[] = {'(','S','t','a','n','d','a','r','d',' ','d','i','s','k',' ','d','r','i','v','e','s',')',0}; static const WCHAR diskdrive_serialW[] = {'W','I','N','E','H','D','I','S','K',0}; +static const WCHAR pnpentity_rscableW[] = + {'U','S','B','\ \','V','I','D','_','1','2','B','A','&','P','I','D','_','0','0','F','F','&','R','E','V','_','0','1','0','0',0}; static const WCHAR networkadapter_pnpdeviceidW[]= {'P','C','I','\ \','V','E','N','_','8','0','8','6','&','D','E','V','_','1','0','0','E','&', 'S','U','B','S','Y','S','_','0','0','1','E','8','0','8','6','&','R','E','V','_','0','2','\\', @@ -796,6 +804,10 @@ static const struct record_physicalmedia data_physicalmedia[] = { { diskdrive_serialW } }; +static const struct record_physicalmedia data_pnpentity[] = +{ + { pnpentity_rscableW } +}; static const struct record_qualifier data_qualifier[] = { { class_process_getowner_outW, param_userW, CIM_SINT32, FLAVOR_ID, prop_idW, 0 }, @@ -2241,6 +2253,7 @@ static struct table builtin_classes[] = { class_osW, SIZEOF(col_os), col_os, 0, 0, NULL, fill_os }, { class_paramsW, SIZEOF(col_param), col_param, SIZEOF(data_param), 0, (BYTE *)data_param }, { class_physicalmediaW, SIZEOF(col_physicalmedia), col_physicalmedia, SIZEOF(data_physicalmedia), 0, (BYTE *)data_physicalmedia }, + { class_pnpentityW, SIZEOF(col_pnpentity), col_pnpentity, SIZEOF(data_pnpentity), 0, (BYTE *)data_pnpentity }, { class_processW, SIZEOF(col_process), col_process, 0, 0, NULL, fill_process }, { class_processorW, SIZEOF(col_processor), col_processor, 0, 0, NULL, fill_processor }, { class_qualifiersW, SIZEOF(col_qualifier), col_qualifier, SIZEOF(data_qualifier), 0, (BYTE *)data_qualifier }, With the *_pnpentity* elements being mine. I've hardcoded the USB device hardware ID in for now. I also added a TRACE to get_propval, but that's not being called. Here's the relevant part of the log: 0009:trace:wbemprox:wbem_services_CreateInstanceEnum 0x3cd6b58, L"Win32_PNPEntity", 000000000, (nil), 0x32f858 0009:trace:wbemprox:parse_query parse_query: L"SELECT * FROM Win32_PNPEntity" 0009:trace:wbemprox:parse_query wql_parse returned 0 0009:trace:wbemprox:EnumWbemClassObject_create 0x32f858 0009:trace:wbemprox:EnumWbemClassObject_create returning iface 0x3cd6ea8 0009:trace:wbemprox:enum_class_object_Next 0x3cd6ea8, 10000, 20, 0x32f888, 0x32f864 0009:fixme:wbemprox:enum_class_object_Next timeout not supported 0009:trace:wbemprox:enum_class_object_Release destroying 0x3cd6ea8 0009:trace:wbemprox:wbem_locator_Release destroying 0x3cd6cc8 0009:trace:wbemprox:wbem_services_Release destroying 0x3cd6b58 0009:trace:wbemprox:DllGetClassObject {4590f811-1d3a-11d0-891f-00aa004b2e24} {00000001-0000-0000-c000-000000000046} 0x32f80c 0009:trace:wbemprox:wbemprox_cf_CreateInstance (nil) {dc12a687-737f-11cf-884d-00aa004b2e24} 0x32f85c 0009:trace:wbemprox:WbemLocator_create (0x32f78c) 0009:trace:wbemprox:WbemLocator_create returning iface 0x3cd6b78 0009:trace:wbemprox:wbem_locator_QueryInterface 0x3cd6b78 {dc12a687-737f-11cf-884d-00aa004b2e24} 0x32f85c 0009:trace:wbemprox:wbem_locator_ConnectServer 0x3cd6b78, L"\\\\.\\root\ \cimv2", (null), (null), (null), 0x00000000, (null), (nil), 0x32f860) 0009:trace:wbemprox:WbemServices_create (0x32f860) 0009:trace:wbemprox:WbemServices_create returning iface 0x3cd6f10 Have I missed something here? Thanks, Luke.

2 4

Re: mshtml: Don't use fragment navigation for SuperNavigate calls.
by Marvin 04 Mar '14

04 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5364 Your paranoid android. === w8 (32 bit webbrowser) === webbrowser.c:425: Test failed: unexpected nsCmdID 74 webbrowser.c:702: Test failed: V_I4(V_VARIANTREF(flags)) = 100, expected 0x40 or 0 webbrowser.c:442: Test failed: unexpected nCmdID 119 webbrowser.c:454: Test failed: unexpected nCmdID 178 webbrowser.c:454: Test failed: unexpected nCmdID 135 webbrowser.c:425: Test failed: unexpected nsCmdID 74

1 0

Discussion and Improvement of Wine's Linux Force Feedback implementation
by Elias Vanderstuyft 04 Mar '14

04 Mar '14

Hi, In the past few weeks I've been reviewing Wine's Linux Force Feedback implementation. I annotated questions and proposals for improvement and bundled them in a file "Improvements.txt". Now, I think it's time to post my results, before someone begins to work on the dinput files I started from (untouched since wine-1.7.11-206-g82b3813). The reason why I don't send this to wine-patches, is because it is more a review and discussion, than a set of actual diff-generated patch files. Because of the rather massive amount of text I've written, I decided to split them up in separate mails in subjects, each containing 3 questions/proposals on average: Subjects [11] ------------- - Joystick control panel program [2] - Linux effect status management [3] - Linux effect parameter: start delay [1] - Linux effect parameter: periodic effect's phase [1] - Linux effect parameters: time parameters [3] - Linux effect: conditional effect's parameters [2] - Linux effect: axes [1] - Linux effect direction [7] - Linux effect parameters (global) [6] - Linux joystick initialization [1] - Debug message fixes/additions [6] I'll send them with the prefix "[RFC x/11] Linux FF: <subject>". Am I allowed to send this? Thanks, Elias

2 1

Drowning in a sea of red
by Jeremy White 04 Mar '14

04 Mar '14

Alright, one month from FOSDEM, and I load test.winehq.org, and I'm still drowning in a sea of red. This is shameful. At the very least, all of the test bot vms should be green. How do we fix this? Should I just pick one failure at a time, and publicly shake it, and shame people as best I can? Cheers, Jeremy

1 0

Re: [PATCH 5/5] winex11: Add support for WGL_WINE_make_current extension. (resend)
by Alexandre Julliard 04 Mar '14

04 Mar '14

Ken Thomases <ken(a)codeweavers.com> writes: > --- > dlls/winex11.drv/opengl.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d8.dll -p d3d8_test.exe.so device && touch device.ok X Error of failed request: GLXBadDrawable Major opcode of failed request: 153 (GLX) Minor opcode of failed request: 26 (X_GLXMakeContextCurrent) Serial number of failed request: 3303 Current serial number in output stream: 3303 make: *** [device.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Assorted spelling fixes
by Marvin 04 Mar '14

04 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5347 Your paranoid android. === w8 (32 bit crypt) === crypt.c:554: Test failed: got 11 expected ERROR_INVALID_PARAMETER

1 0

Re: Assorted spelling fixes
by Marvin 04 Mar '14

04 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5346 Your paranoid android. === w8 (32 bit sync) === sync.c:1670: Test failed: SleepConditionVariableCS should still return TRUE on crit unlock delay

1 0

Re: Assorted spelling fixes
by Marvin 04 Mar '14

04 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5341 Your paranoid android. === w2000pro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 263 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 264 (got 'C:\', wanted '@pwd@\') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 299 (got 'C:\C D', wanted '@pwd@\C D@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 300 (got 'C:\E', wanted '@pwd@\E@or_broken@%~ff') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 303 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 304 (got '\', wanted '@path@@or_broken@%~pd') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 310 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 311 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 312 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 321 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 322 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 335 (got 'C:\C D', wanted '@pwd@\C D') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 336 (got 'C:\E', wanted '@pwd@\E') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 339 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x5c position 0 in line 340 (got '\', wanted '@path@') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 346 (got ''C:\R S'', wanted ''@drive@@shortpath@R S'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 347 (got ''C:\T'', wanted ''@drive@@shortpath@T'@or_broken@''') batch.c:312: Test failed: unexpected char 0x27 position 0 in line 348 (got ''C:\ABCDEFGHIJK.LMNOP'', wanted ''@drive@@shortpath@ABCDEFGHIJK.LMNOP'@or_broken@''') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 349 (got 'C:\', wanted '@drive@@path@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 350 (got 'C:\', wanted '@drive@@path@') batch.c:304: Test failed: excess characters on line 392 (got 'Current dir: C:\foobar', wanted 'Current dir: @pwd@\foobar@or_broken@Current dir:@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 393 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 395 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 397 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 401 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 402 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 403 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 404 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 405 (got 'C:\foobar\bar bak', wanted '@pwd@\foobar\bar bak') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1090 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1092 (got 'C:\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1093 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1094 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1096 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1099 (got 'A C:\foobar\foo', wanted 'A @pwd@\foobar\foo@or_broken@A @pwd@\foobar\foo@or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1101 (got 'A R C:\foobar\foo', wanted 'A R @pwd@\foobar\foo@or_broken@A R @pwd@\foobar\foo@or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1107 (got 'A C:\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2@or_broken@A @pwd@\foobar\baz\level2@or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1108 (got 'A R C:\foobar\level1', wanted 'A R @pwd@\foobar\level1@or_broken@A R @pwd@\foobar\level1@or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1109 (got 'A R C:\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2@or_broken@A R @pwd@\foobar\baz\level2@or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1110 (got 'A C:\foobar\bar', wanted 'A @pwd@\foobar\bar@or_broken@A @pwd@\foobar\bar@or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1112 (got ' C:\foobar', wanted ' @pwd@\foobar@or_broken@ @pwd@\foobar@or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1113 (got ' R C:\foobar\baz', wanted ' R @pwd@\foobar\baz@or_broken@ R @pwd@\foobar\baz@or_broken@ @pwd@\foobar\baz@or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1114 (got 'A C:\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto@or_broken@A @pwd@\foobar\baz\toto@or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1251 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1253 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1255 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1259 (got 'C:\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1261 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1279 (got 'C:\foobar\foodir3', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1282 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1284 (got 'C:\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1288 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1290 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1293 (got 'C:\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1295 (got 'C:\foobar', wanted '@pwd@\foobar') === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x43 position 0 in line 407 (got 'C:\Documents and Settings\winetest\My Documents', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 410 (got 'C:\Documents and Settings\winetest>type foobaz ', wanted '@pwd@>type foobaz@space@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 413 (got 'C:\Documents and Settings\winetest>echo --- ', wanted '@pwd@>echo ---@space@') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 686 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 687 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 688 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 689 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 690 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 691 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 692 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 693 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 694 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 696 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 697 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 698 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 700 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 701 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 702 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 703 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 705 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 711 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 713 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 714 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 717 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 723 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 724 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 726 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 727 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 733 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 739 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 740 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 753 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 754 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 755 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 756 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 757 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 764 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 766 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 767 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 768 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 769 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 770 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 777 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1168 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1170 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1172 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1174 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1175 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1176 (got 'C:\Documents and Settings\winetest\foobar\baz', wanted '@pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1177 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1178 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1179 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1180 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1181 (got 'C:\Documents and Settings\winetest', wanted '@pwd@') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1183 (got 'A C:\Documents and Settings\winetest\foobar\foo', wanted 'A @pwd@\foobar\foo@or_broken@A @pwd@\foobar\foo@or_broken@A I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1185 (got 'A R C:\Documents and Settings\winetest\foobar\foo', wanted 'A R @pwd@\foobar\foo@or_broken@A R @pwd@\foobar\foo@or_broken@A R I @pwd@\foobar\foo') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1191 (got 'A C:\Documents and Settings\winetest\foobar\baz\level2', wanted 'A @pwd@\foobar\baz\level2@or_broken@A @pwd@\foobar\baz\level2@or_broken@A I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1192 (got 'A R C:\Documents and Settings\winetest\foobar\level1', wanted 'A R @pwd@\foobar\level1@or_broken@A R @pwd@\foobar\level1@or_broken@A R I @pwd@\foobar\level1') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1193 (got 'A R C:\Documents and Settings\winetest\foobar\baz\level2', wanted 'A R @pwd@\foobar\baz\level2@or_broken@A R @pwd@\foobar\baz\level2@or_broken@A R I @pwd@\foobar\baz\level2') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1194 (got 'A C:\Documents and Settings\winetest\foobar\bar', wanted 'A @pwd@\foobar\bar@or_broken@A @pwd@\foobar\bar@or_broken@A I @pwd@\foobar\bar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1196 (got ' C:\Documents and Settings\winetest\foobar', wanted ' @pwd@\foobar@or_broken@ @pwd@\foobar@or_broken@ I @pwd@\foobar') batch.c:312: Test failed: unexpected char 0x20 position 0 in line 1197 (got ' R C:\Documents and Settings\winetest\foobar\baz', wanted ' R @pwd@\foobar\baz@or_broken@ R @pwd@\foobar\baz@or_broken@ @pwd@\foobar\baz@or_broken@ R I @pwd@\foobar\baz') batch.c:312: Test failed: unexpected char 0x41 position 0 in line 1198 (got 'A C:\Documents and Settings\winetest\foobar\baz\toto', wanted 'A @pwd@\foobar\baz\toto@or_broken@A @pwd@\foobar\baz\toto@or_broken@A I @pwd@\foobar\baz\toto') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1335 (got 'C:\Documents and Settings\winetest\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1337 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1339 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1343 (got 'C:\Documents and Settings\winetest\foobar\foobar2', wanted '@pwd@\foobar\foobar2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1345 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1361 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1362 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1363 (got 'C:\Documents and Settings\winetest\foobar\foodir2', wanted '@pwd@\foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1364 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1365 (got 'C:\Documents and Settings\winetest\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1366 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1367 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1368 (got '--- Extra endlocal in called batch', wanted '@pwd@\foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1370 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1372 (got 'C:\Documents and Settings\winetest\foobar\foodir2', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1373 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1374 (got 'C:\Documents and Settings\winetest\foobar', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1375 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1376 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1377 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1378 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1379 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@pwd@\foobar') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 315 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: Assorted spelling fixes
by Marvin 04 Mar '14

04 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5339 Your paranoid android. === w2000pro (32 bit shlfolder) === shlfolder.c:557: Test failed: Got 0x80004005 shlfolder.c:601: Test failed: Got 0x80004005 shlfolder.c:627: Test failed: Got 0x80004005

1 0

Re: comctl32/tests: Use BOOL type where appropriate (try 2)
by Nikolay Sivov 03 Mar '14

03 Mar '14

On 2/28/2014 13:58, Frédéric Delanoy wrote: > --- > dlls/comctl32/tests/toolbar.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c > index 29c80fb..1206429 100644 > --- a/dlls/comctl32/tests/toolbar.c > +++ b/dlls/comctl32/tests/toolbar.c > @@ -42,8 +42,8 @@ static struct msg_sequence *sequences[NUM_MSG_SEQUENCES]; > static HWND hMainWnd; > static BOOL g_fBlockHotItemChange; > static BOOL g_fReceivedHotItemChange; > -static BOOL g_fExpectedHotItemOld; > -static BOOL g_fExpectedHotItemNew; > +static int g_fExpectedHotItemOld; > +static int g_fExpectedHotItemNew; > static DWORD g_dwExpectedDispInfoMask; > static BOOL g_ResetDispTextPtr; This is correct. > > @@ -623,12 +623,12 @@ static void test_hotitem(void) > g_fReceivedHotItemChange = FALSE; > ret = SendMessageA(hToolbar, TB_SETHOTITEM, 0xbeaf, 0); > ok(ret == 3, "TB_SETHOTITEM returned %ld, expected 3\n", ret); > - ok(g_fReceivedHotItemChange == FALSE, "TBN_HOTITEMCHANGE received for invalid parameter\n"); > + ok(!g_fReceivedHotItemChange, "TBN_HOTITEMCHANGE received for invalid parameter\n"); And this is not better than it was. I prefer original patch, with variable type fixes only.

1 0

Re: msi: Expand REG_EXPAND_SZ keys when resolving AppSearch entries (resend)
by Marvin 03 Mar '14

03 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5094 Your paranoid android. === w2000pro (32 bit package) === package.c:3945: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:3951: Test failed: Expected "C:\\FileName2", got "C:\FileName2" package.c:3957: Test failed: Expected "C:\\FileName3", got "C:\FileName3" package.c:3969: Test failed: Expected "C:\\FileName5", got "C:\FileName5" package.c:3975: Test failed: Expected "C:\\", got "C:\" package.c:3981: Test failed: Expected "C:\\", got "C:\" package.c:3997: Test failed: Expected "C:\\FileName8.dll", got "C:\FileName8.dll" package.c:4008: Test failed: Expected "C:\\FileName10.dll", got "C:\FileName10.dll" package.c:4467: Test failed: Expected ERROR_SUCCESS, got 1627 package.c:4559: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4570: Test failed: Expected "C:\\", got "C:\" package.c:4581: Test failed: Expected "C:\\", got "C:\" package.c:4631: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:4642: Test failed: Expected "C:\\FileName5.dll", got "C:\FileName5.dll" package.c:4657: Test failed: Expected "C:\\", got "C:\" package.c:4662: Test failed: Expected "", got "C:\" package.c:4678: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4687: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4937: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:4948: Test failed: Expected "C:\\", got "C:\" package.c:4954: Test failed: Expected "C:\\", got "C:\" package.c:4975: Test failed: Expected "C:\\FileName2.dll", got "C:\FileName2.dll" package.c:4986: Test failed: Expected "C:\\FileName4.dll", got "C:\FileName4.dll" package.c:5226: Test failed: Expected "C:\\FileName1", got "C:\FileName1" package.c:5232: Test failed: Expected "C:\\", got "C:\" package.c:5249: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5260: Test failed: Expected "C:\\one\two\three\FileName2", got "C:\one\two\three\FileName2" package.c:5268: Test failed: Expected "C:\\FileName3.dll", got "C:\FileName3.dll" package.c:5612: Test failed: Expected C:\\winetest-package.msi, got C:\winetest-package.msi package.c:6244: Test failed: Expected C:\\abelisaurus or empty string, got C:\abelisaurus package.c:6268: Test failed: Expected C:\\ or empty string, got C:\ package.c:6312: Test failed: Expected C:\\ or empty string, got C:\ package.c:6321: Test failed: Expected C:\\neosodon\ or empty string, got C:\neosodon\ package.c:6551: Test failed: Expected "C:\\", got "C:\" package.c:6552: Test failed: Expected 4, got 3 package.c:6559: Test failed: Expected "C:\\", got "C:\" package.c:6560: Test failed: Expected 4, got 3 package.c:6576: Test failed: Expected "C:\\", got "C:\" package.c:6577: Test failed: Expected 4, got 3 package.c:6583: Test failed: Expected "C:\\", got "C:\" package.c:6584: Test failed: Expected 4, got 3 package.c:6591: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6592: Test failed: Expected 14, got 13 package.c:6599: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6600: Test failed: Expected 19, got 18 package.c:6610: Test failed: Expected "C:\\", got "C:\" package.c:6611: Test failed: Expected 4, got 3 package.c:6618: Test failed: Expected "C:\\", got "C:\" package.c:6619: Test failed: Expected 4, got 3 package.c:6635: Test failed: Expected "C:\\", got "C:\" package.c:6636: Test failed: Expected 4, got 3 package.c:6642: Test failed: Expected "C:\\", got "C:\" package.c:6643: Test failed: Expected 4, got 3 package.c:6650: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6651: Test failed: Expected 14, got 13 package.c:6658: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6659: Test failed: Expected 19, got 18 package.c:6669: Test failed: Expected "C:\\", got "C:\" package.c:6670: Test failed: Expected 4, got 3 package.c:6677: Test failed: Expected "C:\\", got "C:\" package.c:6678: Test failed: Expected 4, got 3 package.c:6694: Test failed: Expected "C:\\", got "C:\" package.c:6695: Test failed: Expected 4, got 3 package.c:6701: Test failed: Expected "C:\\", got "C:\" package.c:6702: Test failed: Expected 4, got 3 package.c:6709: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6710: Test failed: Expected 14, got 13 package.c:6717: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6718: Test failed: Expected 19, got 18 package.c:6728: Test failed: Expected "C:\\", got "C:\" package.c:6729: Test failed: Expected 4, got 3 package.c:6736: Test failed: Expected "C:\\", got "C:\" package.c:6737: Test failed: Expected 4, got 3 package.c:6753: Test failed: Expected "C:\\", got "C:\" package.c:6754: Test failed: Expected 4, got 3 package.c:6760: Test failed: Expected "C:\\", got "C:\" package.c:6761: Test failed: Expected 4, got 3 package.c:6768: Test failed: Expected "C:\\subsource\", got "C:\subsource\" package.c:6769: Test failed: Expected 14, got 13 package.c:6776: Test failed: Expected "C:\\subsource\sub2\", got "C:\subsource\sub2\" package.c:6777: Test failed: Expected 19, got 18 package.c:6792: Test failed: Expected 4, got 3 package.c:6809: Test failed: Expected 4, got 3 package.c:6815: Test failed: Expected ERROR_MORE_DATA, got 0 package.c:6818: Test failed: Expected 4, got 3 package.c:6825: Test failed: Expected "C:\\", got "C:\" package.c:6826: Test failed: Expected 4, got 3 package.c:6837: Test failed: Expected "C:\\", got "C:\" package.c:6838: Test failed: Expected 4, got 3 package.c:6933: Test failed: Expected "C:\\", got "C:\" package.c:6934: Test failed: Expected 4, got 3 package.c:6941: Test failed: Expected "C:\\", got "C:\" package.c:6942: Test failed: Expected 4, got 3 package.c:6951: Test failed: Expected "C:\\", got "C:\" package.c:6952: Test failed: Expected 4, got 3 package.c:6960: Test failed: Expected "C:\\", got "C:\" package.c:6961: Test failed: Expected 4, got 3 package.c:6967: Test failed: Expected "C:\\", got "C:\" package.c:6968: Test failed: Expected 4, got 3 package.c:6975: Test failed: Expected "C:\\", got "C:\" package.c:6976: Test failed: Expected 4, got 3 package.c:6983: Test failed: Expected "C:\\", got "C:\" package.c:6984: Test failed: Expected 4, got 3 package.c:6994: Test failed: Expected "C:\\", got "C:\" package.c:6995: Test failed: Expected 4, got 3 package.c:7002: Test failed: Expected "C:\\", got "C:\" package.c:7003: Test failed: Expected 4, got 3 package.c:7012: Test failed: Expected "C:\\", got "C:\" package.c:7013: Test failed: Expected 4, got 3 package.c:7021: Test failed: Expected "C:\\", got "C:\" package.c:7022: Test failed: Expected 4, got 3 package.c:7028: Test failed: Expected "C:\\", got "C:\" package.c:7029: Test failed: Expected 4, got 3 package.c:7036: Test failed: Expected "C:\\", got "C:\" package.c:7037: Test failed: Expected 4, got 3 package.c:7044: Test failed: Expected "C:\\", got "C:\" package.c:7045: Test failed: Expected 4, got 3 package.c:7055: Test failed: Expected "C:\\", got "C:\" package.c:7056: Test failed: Expected 4, got 3 package.c:7063: Test failed: Expected "C:\\", got "C:\" package.c:7064: Test failed: Expected 4, got 3 package.c:7073: Test failed: Expected "C:\\", got "C:\" package.c:7074: Test failed: Expected 4, got 3 package.c:7082: Test failed: Expected "C:\\", got "C:\" package.c:7083: Test failed: Expected 4, got 3 package.c:7089: Test failed: Expected "C:\\", got "C:\" package.c:7090: Test failed: Expected 4, got 3 package.c:7097: Test failed: Expected "C:\\", got "C:\" package.c:7098: Test failed: Expected 4, got 3 package.c:7105: Test failed: Expected "C:\\", got "C:\" package.c:7106: Test failed: Expected 4, got 3 package.c:7116: Test failed: Expected "C:\\", got "C:\" package.c:7117: Test failed: Expected 4, got 3 package.c:7124: Test failed: Expected "C:\\", got "C:\" package.c:7125: Test failed: Expected 4, got 3 package.c:7134: Test failed: Expected "C:\\", got "C:\" package.c:7135: Test failed: Expected 4, got 3 package.c:7143: Test failed: Expected "C:\\", got "C:\" package.c:7144: Test failed: Expected 4, got 3 package.c:7150: Test failed: Expected "C:\\", got "C:\" package.c:7151: Test failed: Expected 4, got 3 package.c:7158: Test failed: Expected "C:\\", got "C:\" package.c:7159: Test failed: Expected 4, got 3 package.c:7166: Test failed: Expected "C:\\", got "C:\" package.c:7167: Test failed: Expected 4, got 3 package.c:7264: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7265: Test failed: Expected 9, got 8 package.c:7274: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7275: Test failed: Expected 9, got 8 package.c:7284: Test failed: Expected "C:\\long\", got "C:\long\" package.c:7285: Test failed: Expected 9, got 8 package.c:7296: Test failed: Expected "C:\\two\", got "C:\two\" package.c:7297: Test failed: Expected 8, got 7 package.c:7308: Test failed: Expected "C:\\four\", got "C:\four\" package.c:7309: Test failed: Expected 9, got 8 package.c:7320: Test failed: Expected "C:\\six\", got "C:\six\" package.c:7321: Test failed: Expected 8, got 7 package.c:7332: Test failed: Expected "C:\\eight\", got "C:\eight\" package.c:7333: Test failed: Expected 10, got 9 package.c:7344: Test failed: Expected "C:\\ten\", got "C:\ten\" package.c:7345: Test failed: Expected 8, got 7 package.c:7356: Test failed: Expected "C:\\twelve\", got "C:\twelve\" package.c:7357: Test failed: Expected 11, got 10 package.c:7408: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7409: Test failed: Expected 10, got 9 package.c:7418: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7419: Test failed: Expected 10, got 9 package.c:7428: Test failed: Expected "C:\\short\", got "C:\short\" package.c:7429: Test failed: Expected 10, got 9 package.c:7440: Test failed: Expected "C:\\one\", got "C:\one\" package.c:7441: Test failed: Expected 8, got 7 package.c:7452: Test failed: Expected "C:\\three\", got "C:\three\" package.c:7453: Test failed: Expected 10, got 9 package.c:7464: Test failed: Expected "C:\\five\", got "C:\five\" package.c:7465: Test failed: Expected 9, got 8 package.c:7476: Test failed: Expected "C:\\seven\", got "C:\seven\" package.c:7477: Test failed: Expected 10, got 9 package.c:7488: Test failed: Expected "C:\\nine\", got "C:\nine\" package.c:7489: Test failed: Expected 9, got 8 package.c:7500: Test failed: Expected "C:\\eleven\", got "C:\eleven\" package.c:7501: Test failed: Expected 11, got 10 package.c:7637: Test failed: Expected "C:\\", got "C:\" package.c:7638: Test failed: Expected 4, got 3 package.c:7649: Test failed: Expected "C:\\", got "C:\" package.c:7650: Test failed: Expected 4, got 3 package.c:7657: Test failed: Expected "C:\\", got "C:\" package.c:7658: Test failed: Expected 4, got 3 package.c:7755: Test failed: Expected "C:\\", got "C:\" package.c:7756: Test failed: Expected 4, got 3 package.c:7763: Test failed: Expected "C:\\", got "C:\" package.c:7764: Test failed: Expected 4, got 3 package.c:7771: Test failed: Expected "C:\\", got "C:\" package.c:7772: Test failed: Expected 4, got 3 package.c:7791: Test failed: Expected "C:\\", got "C:\" package.c:7792: Test failed: Expected 4, got 3 package.c:7799: Test failed: Expected "C:\\", got "C:\" package.c:7800: Test failed: Expected 4, got 3 package.c:7819: Test failed: Expected "C:\\", got "C:\" package.c:7820: Test failed: Expected 4, got 3 package.c:7827: Test failed: Expected "C:\\", got "C:\" package.c:7828: Test failed: Expected 4, got 3 package.c:7847: Test failed: Expected "C:\\", got "C:\" package.c:7848: Test failed: Expected 4, got 3 package.c:7855: Test failed: Expected "C:\\", got "C:\" package.c:7856: Test failed: Expected 4, got 3

2 2

Re: [PATCH 1/5] d3dx9: Turn D3DXCreateEffectEx FIXME into a TRACE, improve it a bit.
by Henri Verbeet 03 Mar '14

03 Mar '14

On 3 March 2014 16:28, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/d3dx9_36/effect.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index a4325af..0ec17c1 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -5294,8 +5294,10 @@ HRESULT WINAPI D3DXCreateEffectEx(struct IDirect3DDevice9 *device, const void *s > struct ID3DXEffectImpl *object; > HRESULT hr; > > - FIXME("(%p, %p, %u, %p, %p, %p, %#x, %p, %p, %p): semi-stub\n", device, srcdata, srcdatalen, defines, include, > - skip_constants, flags, pool, effect, compilation_errors); > + TRACE("device %p, srcdata %p, srcdatalen %u, defines %p, include %p,\n", > + device, srcdata, srcdatalen, defines, include); > + TRACE("skip_constants %p, flags %#x, pool %p, effect %p, compilation_errors %p.\n", > + skip_constants, flags, pool, effect, compilation_errors); > Mostly just FWIW, I think it's generally nicer to keep that as a single TRACE.

2 2

gihanshanuka20@gmail.com has indicated you're a friend. Accept?
by gihanshanuka20＠gmail.com 03 Mar '14

03 Mar '14

Hi, gihanshanuka20(a)gmail.com wants to follow you. ****** Is gihanshanuka20(a)gmail.com you friend? ****** If Yes please follow the link below: http://invites.fliporamail.com/signup_e.html?fullname=Gihanshanuka20+Achala… If No please follow the link below: http://invites.fliporamail.com/signup_e.html?fullname=Gihanshanuka20+Achala… Follow the link below to remove yourself from all such emails http://invites.fliporamail.com/uns.jsp?email=wine-devel@winehq.org&iid=3074…

1 0

Re: [PATCH 2/6] wininet: Added support for MSG_DONTWAIT to secure NETCON_recv.
by Alexandre Julliard 03 Mar '14

03 Mar '14

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/netconnection.c | 82 > ++++++++++++++++++++++++++++++-------------- > 1 file changed, 56 insertions(+), 26 deletions(-) This breaks the Windows build (missing MSG_DONTWAIT). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: fonts: Add Liberation Sans (SIL Open Font License) as an Arialreplacement.
by Mariusz Wawrzyński 03 Mar '14

03 Mar '14

thank you very much for message. I do not know NET platform. Dnia 27 lutego 2014 23:14 "Erich E. Hoover" <erich.e.hoover(a)gmail.com> napisał(a): The attached patch adds the Arial font (arial.ttf) using version 2.00.1 of the Liberation Sans font. The Liberation Sans font is licensed under the SIL Open Font License, which is, to the best of my knowledge, compatible with our other license restrictions. This patch fixes an issue where several Silveright and .NET applications expect either Arial or Verdana to be installed on the system (Bug #32323).

2 1

Re: [PATCH 1/6] wininet: Fixed tests for the new winehq.org cert.
by Marvin 03 Mar '14

03 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5325 Your paranoid android. === w2000pro (32 bit http) === http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 === w8 (32 bit http) === http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800000, expected 800000 http.c:4308: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800000, expected 800000 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS flags = 1800080, expected 800080 http.c:4311: Test failed: INTERNET_OPTION_SECURITY_FLAGS(98) flags = 1800080, expected 800080 http.c:318: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) http.c:318: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) http.c:318: Test failed: unexpected status 20 (INTERNET_STATUS_CONNECTING_TO_SERVER) http.c:318: Test failed: unexpected status 21 (INTERNET_STATUS_CONNECTED_TO_SERVER) http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:957: Test failed: expected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 2 times, received 1 times http.c:958: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 2 times, received 1 times http.c:318: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) http.c:318: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) http.c:4477: Test failed: HttpSendRequest failed: 12037 http.c:4482: Test failed: expected secure flag to be set http.c:4076: Test failed: dwKeySize = 0 http.c:4513: Test failed: expected a non-zero key size http.c:4536: Test failed: HttpSendRequest failed: 12037 http.c:4541: Test failed: expected secure flag to be set, got 0 http.c:4565: Test failed: expected a non-zero key size http.c:4597: Test failed: expected a non-zero key size http.c:4636: Test failed: expected ERROR_HTTP_HEADER_NOT_FOUND, got 0

1 0

Re: kernel32/time: Implement GetSystemTimes using /proc/stat.
by André Hentschel 03 Mar '14

03 Mar '14

Am 03.03.2014 14:44, schrieb Bernard Ladenthin: > Hi André, > > you wrote me a few suggestions for my patch at 29.09.2013 20:08. > > I wrote a new patch and tried it three times, the patch is always > "pending". Maybe you can examine the patch and write to me what is > wrong? Thank you for any help. > > http://source.winehq.org/patches/data/102340 > > From: Bernard Ladenthin <bernard.ladenthin(a)gmail.com> > Subject: kernel32/time: Implement GetSystemTimes using /proc/stat. > Message-Id: <52F9075B.4000601(a)gmail.com> > Date: Mon, 10 Feb 2014 18:07:39 +0100 mostly code style, spaces, variable names, variable types think about the use of ERR, FIXME, WARN, TRACE

1 0

Re: patch:add HANDLE
by Nikolay Sivov 03 Mar '14

03 Mar '14

On 3/3/2014 16:32, Akira Nakagawa wrote: > It was a little hurtful that you have said... > what did you mean of "dead code"? I mean that code that your patch adds is not used. > > I've checked Windows itself uses it as public handle. What does a public handle mean and what did you check exactly? > My patch is not enough,you say,to be send,then I send after finished > eventlog functions works. You shouldn't send everything as one patch either, it needs to be incremental but without dead parts. Please CC wine-devel(a)winehq.org if you want my reply. > 2014年3月3日月曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead@gmail.com>> さんは書きました: > > On 3/2/2014 15:18, 中川祥 wrote: >> Hum? >> I thought all the HANDLEs are hosted by server. > I don't think you need event log handles to be handled by server, > I'd rather had a service handling them. >> Hence,I did. >> It need be hosted by server because you need to distinguish one >> eventlog from the ohter,any way. >> > I'm not sure I follow you here.Anyway, you'll need some plan for > all parts involved (advapi32, logging service, something else?) > before sending such dead code patches. > > Please keep wine-devel CC. >> 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>> さんは書 >> きました: >> >> On 3/2/2014 14:13, 中川祥 wrote: >>> Handle for eventlog. >>> It is different from event. >>> It's almost same as hfile,but more info needed. >>> Is it implemented? >> What event log API are you talking about? Why does this >> handle have to be maintained by a server? >>> >>> >>> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com>: >>> >>> On 3/2/2014 10:44, Akira Nakagawa wrote: >>> >>> What's that about? >>> >>> >> >

1 0

About GSoC 2014
by Nemina Amarasinghe 03 Mar '14

03 Mar '14

Hi, I am willing to participate GSoC this year. I looked through the accepted organization list and I'm interested in wine. So I would like to know how to connect with mentors to get more details. I would really appreciate if someone help me to get above information Best regards, Nemina

2 1

Re: patch:add HANDLE
by Nikolay Sivov 03 Mar '14

03 Mar '14

On 3/2/2014 15:18, 中川祥 wrote: > Hum? > I thought all the HANDLEs are hosted by server. I don't think you need event log handles to be handled by server, I'd rather had a service handling them. > Hence,I did. > It need be hosted by server because you need to distinguish one > eventlog from the ohter,any way. > I'm not sure I follow you here.Anyway, you'll need some plan for all parts involved (advapi32, logging service, something else?) before sending such dead code patches. Please keep wine-devel CC. > 2014年3月2日日曜日、Nikolay Sivov<bunglehead(a)gmail.com > <mailto:bunglehead@gmail.com>> さんは書きました: > > On 3/2/2014 14:13, 中川祥 wrote: >> Handle for eventlog. >> It is different from event. >> It's almost same as hfile,but more info needed. >> Is it implemented? > What event log API are you talking about? Why does this handle > have to be maintained by a server? >> >> >> 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com >> <javascript:_e(%7B%7D,'cvml','bunglehead(a)gmail.com');>>: >> >> On 3/2/2014 10:44, Akira Nakagawa wrote: >> >> What's that about? >> >> >

1 0

Re: dpnet: Check if DirectDplay is installed
by Marvin 02 Mar '14

02 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5312 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: patch:add HANDLE
by Nikolay Sivov 02 Mar '14

02 Mar '14

On 3/2/2014 14:13, 中川祥 wrote: > Handle for eventlog. > It is different from event. > It's almost same as hfile,but more info needed. > Is it implemented? What event log API are you talking about? Why does this handle have to be maintained by a server? > > > 2014-03-02 16:19 GMT+09:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead@gmail.com>>: > > On 3/2/2014 10:44, Akira Nakagawa wrote: > > What's that about? > >

1 0

Re: patch:add HANDLE
by Nikolay Sivov 02 Mar '14

02 Mar '14

On 3/2/2014 10:44, Akira Nakagawa wrote: What's that about?

1 0

Re: [PATCH 3/3] gdiplus/tests: Added tests for GdipCreateStreamOnFile.
by Dmitry Timoshkov 02 Mar '14

02 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > +static void test_gdipstream(void) > +{ > + IStream *stream; > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + GpStatus stat; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Same problem with temp files in current directory. > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonexistentW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + stream = (IStream *)0xdeadcafe; > + stat = GdipCreateStreamOnFile(nonshareW, GENERIC_READ, &stream); > + todo_wine ok(stat == NotImplemented, "returned %d, expected NotImplemented\n", stat); > + todo_wine ok(stream == (IStream *)0xdeadcafe, "returned %p\n", stream); > + > + CloseHandle(hfile); > +} Please use common 0xdeadbeef instead of new inventions. -- Dmitry.

1 0

Re: [PATCH 1/3] gdiplus/tests: Added more tests for image loading functions.
by Dmitry Timoshkov 02 Mar '14

02 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > + WCHAR nonexistentW[] = {'n','o','n','e','x','i','s','t','.','b','m','p','\0'}; > + WCHAR nonshareW[] = {'n','o','n','s','h','a','r','e','.','b','m','p','\0'}; > + HANDLE hfile; > + > + hfile = CreateFileW(nonshareW, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_FLAG_DELETE_ON_CLOSE, 0); > + ok(hfile != INVALID_HANDLE_VALUE, "failed to create file\n"); Please use official temporary storage instead of creating files in current directory. -- Dmitry.

1 0

Conferences wiki page
by Rosanne DiMesio 01 Mar '14

01 Mar '14

FYI, I've created a wiki page to collect information on conferences that might be good venues for Wine outreach efforts, http://wiki.winehq.org/Conferences2014. Please add any conferences/meetings you think might be suitable, even if the deadline for this year has passed (it will serve as a reminder to check earlier for next year). -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: [PATCH] Avoid a divide by zero crash.
by Dmitry Timoshkov 01 Mar '14

01 Mar '14

Max Woodbury <mtewoodbury(a)gmail.com> wrote: > While tmHeight is not _supposed_ to ever be zero, it is an external > > input and has been found to be zero in a few rare fonts. Detecting > > and fixing THAT problem should be handled elsewhere. This change just > > keeps the application from being blown away by a divide by zero > > exception. This change needs at least more details and preferrably a test case. -- Dmitry.

2 5

Fwd: [The Wine Project] Your organization application has been accepted.
by Austin English 28 Feb '14

28 Feb '14

We're in for GSoC 2014! Please update http://wiki.winehq.org/SummerOfCode#head-008ecfc639831c4db4d11a0e8983ef4eb0… any ideas you have for potential students. Let me or Andre know if you have any questions. ---------- Forwarded message ---------- From: <no-reply(a)google-melange.appspotmail.com> Date: Mon, Feb 24, 2014 at 10:40 AM Subject: [The Wine Project] Your organization application has been accepted. To: austinenglish(a)gmail.com Congratulations! Your Organization Application for The Wine Project to Google Summer of Code 2014 has been accepted. Your organization's information will be auto-populated from your Organization profile onto our Participating Organizations page. Please click http://www.google-melange.com/gsoc/org/profile/edit/google/gsoc2014/wine if you want to modify your Organization profile. We recommend you take time to review your profile carefully and add relevant information and links for the students where applicable. If you have questions about items on this profile we would recommend you read over the Melange User's Guide's section titled "Our organization was accepted! How do I create my organization homepage?<http://en.flossmanuals.net/melange/org-application-period/> " Please be aware the your organization's information is now available to students, so you should expect to get contact from potential applicants very soon. If you have any questions, please email Carol Smith directly at carols(a)google.com, but generally, you are off to the races. Student applications formally open on 10 March at 19:00 UTC. Best regards, -- -Austin

1 0

Re: itss: Use BOOL type where appropriate
by Nikolay Sivov 28 Feb '14

28 Feb '14

On 2/28/2014 20:17, Frédéric Delanoy wrote: > --- > dlls/itss/lzx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c > index 01a9492..9e343da 100644 > --- a/dlls/itss/lzx.c > +++ b/dlls/itss/lzx.c > @@ -85,14 +85,14 @@ struct LZXstate > ULONG window_posn; /* current offset within the window */ > ULONG R0, R1, R2; /* for the LRU offset system */ > UWORD main_elements; /* number of main tree elements */ > - int header_read; /* have we started decoding at all yet? */ > + BOOL header_read; /* have we started decoding at all yet? */ > UWORD block_type; /* type of this block */ > ULONG block_length; /* uncompressed length of this block */ > ULONG block_remaining; /* uncompressed bytes still left to decode */ > ULONG frames_read; /* the number of CFDATA blocks processed */ > LONG intel_filesize; /* magic header value used for transform */ > LONG intel_curpos; /* current offset in transform space */ > - int intel_started; /* have we seen any translatable data yet? */ > + BOOL intel_started; /* have we seen any translatable data yet? */ > This is a part of another project, I don't think we need it to differ more than it does already.

1 0

Re: TestBot job 5278 results: [PATCH] scrrun: Implement CreateTextFile() method (try2)
by Nikolay Sivov 28 Feb '14

28 Feb '14

On 2/28/2014 18:42, Marvin wrote: > === w2000pro (32 bit filesystem) === > > scrrun: > filesystem.c:140: Test failed: got 0x800a0046 I don't think it's related, this test already supposed to fail, with a different error code however.

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method (try2)
by Marvin 28 Feb '14

28 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5278 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method
by Dmitry Timoshkov 28 Feb '14

28 Feb '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + /* map access mode */ > + if (mode & (ForWriting | ForAppending)) > + access = GENERIC_WRITE; > + if (mode & ForReading) > + access |= GENERIC_READ; Probably append mode needs additional handling. -- Dmitry.

1 0

Re: [PATCH] scrrun: Implement CreateTextFile() method
by Marvin 28 Feb '14

28 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5276 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:140: Test failed: got 0x800a0046

1 0

Re: [PATCH 4/5] ddraw/tests: Don't trust what EnumDevices() tells us about the supported Z buffer formats.
by Marvin 28 Feb '14

28 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5274 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:746: Test failed: Got unexpected color 0x00000000. ddraw2.c:3199: Test failed: Got unexpected color 0x000000ff. Failure running script in VM: network read timed out === w8 (32 bit ddraw1) === ddraw1.c:783: Test failed: Got unexpected color 0x00000000. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:1297: Test failed: Expected color 0x00ff0000 for test 1, got 0x0000ff00. ddraw1.c:1319: Test failed: Expected color 0x000000ff for test 1, got 0x0000ff00. ddraw1.c:2909: Test failed: Got unexpected color 0x000000ff. ddraw1.c:4103: Test failed: Got unexpected refcount 3. ddraw1.c:4122: Test failed: Got unexpected refcount 3. ddraw1.c:4129: Test failed: Got unexpected hr 0. ddraw1.c:4132: Test failed: Got unexpected refcount 3. ddraw1.c:4134: Test failed: Got unexpected refcount 2. ddraw1.c:4140: Test failed: Got unexpected hr 0. ddraw1.c:4143: Test failed: Got unexpected refcount 2. ddraw1.c:4145: Test failed: Got unexpected refcount 1.

1 0

Re: [PATCH 3/5] ddraw/tests: Properly create offscreen plain surfaces.
by Marvin 28 Feb '14

28 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5273 Your paranoid android. === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057. ddraw4.c:5817: Test failed: Got unexpected refcount 3. ddraw4.c:5836: Test failed: Got unexpected refcount 3. ddraw4.c:5843: Test failed: Got unexpected hr 0. ddraw4.c:5846: Test failed: Got unexpected refcount 3. ddraw4.c:5848: Test failed: Got unexpected refcount 2. ddraw4.c:5854: Test failed: Got unexpected hr 0. ddraw4.c:5857: Test failed: Got unexpected refcount 2. ddraw4.c:5859: Test failed: Got unexpected refcount 1. ddraw4.c:5861: Test failed: Got unexpected refcount 6. ddraw4.c:5985: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:6024: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:6027: Test failed: Got unexpected hr 0. ddraw4.c:6029: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6032: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6035: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:6037: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6040: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:6042: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:6045: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:6047: Test failed: Got unexpected hr 0x887601c2.

1 0

Re: [PATCH 2/5] ddraw/tests: Try 24 bpp display modes if 32 bpp modes are unavailable.
by Marvin 28 Feb '14

28 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5272 Your paranoid android. === w2000pro (32 bit ddraw2) === ddraw2: unhandled exception c0000005 at 00425FE5 === w8 (32 bit ddraw2) === ddraw2.c:5217: Test failed: Got unexpected refcount 3. ddraw2.c:5236: Test failed: Got unexpected refcount 3. ddraw2.c:5243: Test failed: Got unexpected hr 0. ddraw2.c:5246: Test failed: Got unexpected refcount 3. ddraw2.c:5248: Test failed: Got unexpected refcount 2. ddraw2.c:5254: Test failed: Got unexpected hr 0. ddraw2.c:5257: Test failed: Got unexpected refcount 2. ddraw2.c:5259: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:4120: Test failed: Got unexpected refcount 3. ddraw1.c:4139: Test failed: Got unexpected refcount 3. ddraw1.c:4146: Test failed: Got unexpected hr 0. ddraw1.c:4149: Test failed: Got unexpected refcount 3. ddraw1.c:4151: Test failed: Got unexpected refcount 2. ddraw1.c:4157: Test failed: Got unexpected hr 0. ddraw1.c:4160: Test failed: Got unexpected refcount 2. ddraw1.c:4162: Test failed: Got unexpected refcount 1. === w2000pro (32 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0045AFE8 === w8 (32 bit ddraw7) === Failure running script in VM: network read timed out === w2000pro (32 bit ddraw4) === ddraw4: unhandled exception c0000005 at 0043FF75 === w8 (32 bit ddraw4) === ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 1x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 2x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 3x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 4x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 5x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 6x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 7x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x1, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x2, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x3, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x4, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x5, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x6, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x7, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_YUY2, resource type videomemory overlay, size 8x8, expected 0. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 1x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 2x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 3x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 4x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 5x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 6x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 7x8, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x1, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x2, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x3, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x4, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x5, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x6, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x7, expected 0x80070057. ddraw4.c:4251: Test failed: Got unexpected hr 0x88760104 for format D3DFMT_UYVY, resource type videomemory overlay, size 8x8, expected 0x80070057.

1 0

Re: msi: Use BOOL type where appropriate
by Hans Leidekker 28 Feb '14

28 Feb '14

On Fri, 2014-02-28 at 10:35 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h > index 75d1920..62d69b2 100644 > --- a/dlls/msi/msipriv.h > +++ b/dlls/msi/msipriv.h > @@ -409,13 +409,13 @@ typedef struct tagMSIPACKAGE > struct list sourcelist_info; > struct list sourcelist_media; > > - unsigned char scheduled_action_running : 1; > - unsigned char commit_action_running : 1; > - unsigned char rollback_action_running : 1; > - unsigned char need_reboot_at_end : 1; > - unsigned char need_reboot_now : 1; > - unsigned char need_rollback : 1; > - unsigned char full_reinstall : 1; > + BOOL scheduled_action_running; > + BOOL commit_action_running; > + BOOL rollback_action_running; > + BOOL need_reboot_at_end; > + BOOL need_reboot_now; > + BOOL need_rollback; > + BOOL full_reinstall; > } MSIPACKAGE; > > typedef struct tagMSIPREVIEW > @@ -486,10 +486,10 @@ typedef struct tagMSICOMPONENT > MSIASSEMBLY *assembly; > int num_clients; > > - unsigned int anyAbsent:1; > - unsigned int hasAdvertisedFeature:1; > - unsigned int hasLocalFeature:1; > - unsigned int hasSourceFeature:1; > + BOOL anyAbsent; > + BOOL hasAdvertisedFeature; > + BOOL hasLocalFeature; > + BOOL hasSourceFeature; > } MSICOMPONENT; > > typedef struct tagComponentList I don't think it's worth the extra memory use here.

1 0

Swat4 -too dark shadows maybe solved
by Jarkko Korpi 28 Feb '14

28 Feb '14

I downloaded swat4 demo. It has too dark swats and shadows. http://bugs.winehq.org/show_bug.cgi?id=8848 (which is reported here too also with demo) I think I figured out what is causing it. I noticed that setting windows registerykey useGLSL=disabled made swats look like normal (see my sent pics). I debuged the game and there wasn't many different lines. fixme:exec:SHELL_execute flags ignored: 0x00000100 fixme:process:GetProcessWorkingSetSize (0xffffffff,0x33eac4,0x33eac0): stub fixme:win:EnumDisplayDevicesW ((null),0,0x33ed48,0x00000000), stub! fixme:wbemprox:client_security_SetBlanket 0x7cf14558, 0x1396f0, 10, 0, (null), 3, 3, (nil), 0x00000000 fixme:wbemprox:client_security_Release 0x7cf14558 fixme:wbemprox:wbem_services_CreateInstanceEnum unsupported flags 0x00000030 fixme:win:EnumDisplayDevicesW ((null),0,0x33ec68,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x33ef58,0x00000000), stub! fixme:system:SystemParametersInfoW Unimplemented action: 59 (SPI_SETSTICKYKEYS) fixme:win:EnumDisplayDevicesW ((null),0,0x33ca58,0x00000000), stub! fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. etc etc But I think wine is missing the next feature, what's causing the black shadows http://msdn.microsoft.com/en-us/library/windows/desktop/bb173461%28v=vs.85%… "You can include the D3DSGR_CALIBRATE value for the first parameter of SetGammaRamp", well its definitely trying to set gamma, but it's IGNORED. Here are the pics, before and setting that useGLSL registery key http://postimg.org/image/kxct6863j/ http://postimg.org/image/n48bm1dk9/ But setting that registery key dosn't help on shadows which are too dark. According to my knowledge reading some part of that Microsoft explanation making this setgammaramp function shoulnt be too hard, it just adjust the amount of RGB.

1 0

Failing dpnet tests
by Alistair Leslie-Hughes 28 Feb '14

28 Feb '14

Hi, On Windows 8, the dpnet are failing with a timeout. After manually running the tests, I found a possible cause. The dpnet.dll cause the dpnsvr.exe to be loaded which attempts to create a socket. In turn the firewall dialog appears prompting whether it's allowed to do so. So no communication between the dpnet test exe and dpnsvr.exe thus the timeout. Could someone run the dpnet test manually and allow the dpnsvr.exe to create connections? Best Regards Alistair Leslie-Hughes

2 4

Re: dmime: Do not try to query a NULL direct sound buffer
by Nikolay Sivov 28 Feb '14

28 Feb '14

On 2/26/2014 13:03, Aric Stewart wrote: > --- > dlls/dmime/audiopath.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) Why is it NULL though? The only place I found that sets it is this: --- hr = IDirectSound8_CreateSoundBuffer ((LPDIRECTSOUND8) This->pDirectSound, &desc, &buffer, NULL); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, default_path); *ppNewPath = NULL; return DSERR_BUFFERLOST; } default_path->pDSBuffer = buffer; --- That means CreateSoundBuffer() doesn't return error code properly?

2 1

Re: shell32: Supply a module name to CreateProcess
by Alexandre Julliard 27 Feb '14

27 Feb '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -330,9 +332,14 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, > /* ShellExecute specifies the command from psei->lpDirectory > * if present. Not from the current dir as CreateProcess does */ > if( lpDirectory ) > + { > if( ( gcdret = GetCurrentDirectoryW( MAX_PATH, curdir))) > if( !SetCurrentDirectoryW( lpDirectory)) > ERR("cannot set directory %s\n", debugstr_w(lpDirectory)); > + > + PathCombineW(module_path, psei->lpDirectory, psei->lpFile); > + path = module_path; > + } We'd want to specify the path in all cases, not only when we have a directory. Also the SetCurrentDirectory shouldn't be needed with a proper path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox() (try 2)
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5256 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8158: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8172: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8172: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8172: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8213: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8228: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

1 0

Re: [PATCH 2/2] d3dx9/tests: Add a mesh test for D3DXCreateBox()
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5232 Your paranoid android. === w8 (32 bit mesh) === mesh.c:8156: Test failed: Mesh 27: new_num_vertices == 6, expected 4. mesh.c:8170: Test failed: Mesh 27: indices[3] == 3, expected 1 mesh.c:8170: Test failed: Mesh 27: indices[4] == 4, expected 3 mesh.c:8170: Test failed: Mesh 27: indices[5] == 5, expected 2 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[3] == 3, expected 4 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[4] == 4, expected -1 mesh.c:8211: Test failed: Mesh 27: vertex_remap_ptr[5] == 5, expected -1 mesh.c:8226: Test failed: Mesh 27: Got (2.000000, 3.000000, 0.000000) for vertex 3 position, expected (3.000000, 0.000000, 0.000000).

2 1

Re: urlmon: Fixed url.c tests on IE11.
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5243 Your paranoid android. === wxppro (32 bit url) === url.c:1669: Test failed: unexpected call OnProgress_FINDINGRESOURCE url.c:1878: Test failed: binding failed: 800c0005, expected 00000000 url.c:1889: Test failed: res = 00002efd, expected 00000000 url.c:3146: Test failed: expected OnProgress_SENDINGREQUEST url.c:3152: Test failed: expected OnResponse url.c:3156: Test failed: expected OnProgress_MIMETYPEAVAILABLE url.c:3157: Test failed: expected OnProgress_BEGINDOWNLOADDATA url.c:3158: Test failed: expected OnProgress_ENDDOWNLOADDATA url.c:3170: Test failed: expected OnDataAvailable

2 1

Use of wined3d_mutex?
by Max TenEyck Woodbury 27 Feb '14

27 Feb '14

I have been looking at the use of the wined3d_mutex_lock and wined3d_mutex_unlock functions in the drawing code. I strongly suspect that it is being badly over-used. In particular, user call back functions are being called in several places with this mutex held. If the callback starts another thread to do something graphical where the thread needs the mutex, and then waits for the thread to finish, both threads will hang until the mutex times out. There are also places where a function that takes out the mutex is called with the mutex already held. Switching to another terminal window and back again sometimes breaks these deadlocks. It used to be that I had to do this several times doing a 'make test', but it just takes a long time now. (Yes, years ago I left the test running for several hours when I went out for a few hours and it was still hung when I got back. That does not happen now,) This shows up running Guild Wars 2. I have a CPU monitor running while I play and I can see the game chomping on both cores, except that the game will sometimes hang for 30-45 seconds and then resume. I am in the process of annotating the drawing routines use of the mutex, and there is simply a lot of code to go through. Could someone with a good understanding of the drawing part of wine comment please. In particular, are there places where the lock-like action of the reference counts can be used in place of taking out the mutex? max

3 2

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken
by Marvin 27 Feb '14

27 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5238 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0 === w7pro64 (64 bit sock) === sock.c:622: Test failed: oob_server (98c): not at the OOB mark: 1

2 1

Re: [PATCH 1/2] d3dx9: Implement D3DXCreateBox()
by Henri Verbeet 27 Feb '14

27 Feb '14

I'm not really in charge of d3dx9, and I would've expected Matteo or Rico to write this instead, but here are some comments. On 27 February 2014 11:38, Gediminas Jakutis <gediminas(a)varciai.lt> wrote: > + static const float sign_x[24] = {-1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, > + -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f}; The explicit array size isn't needed, and I don't think it adds much for clarity. The indentation looks pretty arbitrary, the usual style for tables like these is to put the brace on a new line, and then indent the elements once. I.e.: static const float sign_x[] = { -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, -1.0f, -1.0f, 1.0f, 1.0f, -1.0f, 1.0f, 1.0f, -1.0f, -1.0f, -1.0f, 1.0f, 1.0f, }; > + TRACE("(%p, %f, %f, %f, %p, %p)\n", device, width, height, depth, mesh, adjacency); I know d3dx9 isn't terribly consistent about this, but: TRACE("device %p, width %.8e, height %.8e, depth %.8e, mesh %p, adjacency %p.\n", device, width, height, depth, mesh, adjacency); > + hr = D3DXCreateMeshFVF(12, 24, D3DXMESH_MANAGED, D3DFVF_XYZ | D3DFVF_NORMAL, device, &box); > + > + if (FAILED(hr)) > + { > + return hr; > + } > + > + if (FAILED(hr = box->lpVtbl->LockVertexBuffer(box, 0, (void **)&vertices))) > + { > + box->lpVtbl->Release(box); > + return hr; > + } These are inconsistent. I'd prefer the second. > + for (i = 0; i < 24; i++) > + { > + vertices[i].position.x = width * sign_x[i]; > + vertices[i].position.y = height * sign_y[i]; > + vertices[i].position.z = depth * sign_z[i]; I suppose this works, but I think it would be clearer to store a unit box as an array of D3DXVECTOR3s, and then call D3DXVec3Scale() on the vectors. The "24" would then become "ARRAY_SIZE(unit_box)" as well. > + hr = D3DXCreateBuffer(36 * sizeof(DWORD), adjacency); > + > + if (FAILED(hr)) if (FAILED(hr = D3DXCreateBuffer(sizeof(adjacency_table), adjacency)))

1 0

Re: ws2_32/tests: Mark a SIOCATMARK test result as broken
by Bruno Jesus 27 Feb '14

27 Feb '14

On Thu, Feb 27, 2014 at 11:33 AM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > dlls/ws2_32/tests/sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 2252245..3f27b02 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -610,7 +610,7 @@ static VOID WINAPI oob_server ( server_params *par ) > ok ( pos == -1, "simple_server (%x): test pattern error: %d\n", id, pos); > > ioctlsocket ( mem->sock[0].s, SIOCATMARK, &atmark ); > - ok ( atmark == 1, "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); > + ok ( atmark == 1 || broken(atmark == 0), "oob_server (%x): unexpectedly at the OOB mark: %i\n", id, atmark ); There is other test failing too, right? At least for me. So this would only "solve" half of the problem. What we need to do IMO is simplify the test using a more sequential way to ensure normal and OOB data does not get mixed. Regards, Bruno

1 0

ddraw/tests: Don't crash after a failed CreateSurface() call.
by Francois Gouget 27 Feb '14

27 Feb '14

So there are a number of CreateSurface() calls that fail and these are causing the tests to crash. For instance for ddraw2: http://test.winehq.org/data/tests/ddraw:ddraw2.html Is there a way to check what surface types are supported? create_device() calls EnumDevices() but finding a match clearly does not guarantee we'll be able to create a surface given the error we get there (but presumably that check was more for the following CreateDevice() call). I tried using EnumSurfaces() but without much luck. I'm also a bit worried that DDENUMSURFACES_MATCH is not used anywhere in Wine (*). Alternatively we can just react to failing CreateSurface() calls and clean up + abort a bit like is done in the following patch. (*) Also the DDENUMSURFACES_{SEARCH,MATCH}TYPE macros found in dlls/ddraw/ddraw.c are not used anymore since c8901d6f. diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 5a3bd77..2a5a9c4 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -227,7 +227,7 @@ static IDirect3DDevice2 *create_device(IDirectDraw2 *ddraw, HWND window, DWORD c surface_desc.dwWidth = 640; surface_desc.dwHeight = 480; hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &ds, NULL); - ok(SUCCEEDED(hr), "Failed to create depth buffer, hr %#x.\n", hr); + ok(SUCCEEDED(hr) || broken(hr == DDERR_INVALIDPIXELFORMAT), "Failed to create depth buffer, hr %#x.\n", hr); if (FAILED(hr)) { IDirect3D2_Release(d3d); @@ -4451,6 +4451,8 @@ static void test_surface_lock(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, type %s, hr %#x.\n", tests[i].name, hr); + if (FAILED(hr)) + continue; memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -4817,6 +4819,8 @@ static void test_set_surface_desc(void) hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + goto done; hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); @@ -5113,6 +5117,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw2_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw2_Release(ddraw); + DestroyWindow(window); + return; + } hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface3, (void **)&surface3); ok(SUCCEEDED(hr), "Failed to get IDirectDrawSurface3 interface, hr %#x.\n", hr); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 81c043c..5da4a71 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -5423,6 +5423,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5715,6 +5721,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw4_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw4_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 8e01238..4735fca 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -5301,6 +5301,12 @@ static void test_set_surface_desc(void) hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } reset_ddsd(&ddsd); ddsd.dwFlags = DDSD_LPSURFACE; @@ -5594,6 +5600,12 @@ static void test_user_memory_getdc(void) ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY; hr = IDirectDraw7_CreateSurface(ddraw, &ddsd, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); + if (FAILED(hr)) + { + IDirectDraw7_Release(ddraw); + DestroyWindow(window); + return; + } memset(data, 0xaa, sizeof(data)); reset_ddsd(&ddsd);

2 1

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Henri Verbeet 27 Feb '14

27 Feb '14

On 24 February 2014 23:54, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > Most of the IDirect3D9_CreateDevice() calls in device.c should be calls to create_device() instead. (And then just skip() if it fails to create a device.) I think the only exceptions are test_fpu_setup() and test_swvp_buffer().

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel