- wine-devel - winehq.org

[PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 04 Feb '14

04 Feb '14

This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations The patchset avoids data races problem on newely created files: open with O_CREAT can return the -ESHAREDENIED error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets not mix one share reservation approach with another. Patches #1, #2 and #3 add O_DENY* flags to fcntl and implement VFS part. A patch #4 is related to CIFS client changes, #5 -- NFSD, #6 and #7 describe NFSv4 client parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. NFS returns -EINVAL for opens with this flag. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts CIFS: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS NFSv4: Add deny state handling for nfs4_state struct NFSv4: Add O_DENY* open flags support arch/alpha/include/uapi/asm/errno.h | 2 + arch/alpha/include/uapi/asm/fcntl.h | 3 + arch/mips/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/fcntl.h | 3 + arch/sparc/include/uapi/asm/errno.h | 2 + arch/sparc/include/uapi/asm/fcntl.h | 3 + fs/cifs/cifsacl.c | 2 + fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 17 +- fs/cifs/cifssmb.c | 2 +- fs/cifs/dir.c | 6 + fs/cifs/file.c | 20 ++- fs/cifs/inode.c | 12 +- fs/cifs/link.c | 2 + fs/cifs/netmisc.c | 2 +- fs/cifs/smb1ops.c | 3 + fs/cifs/smb2inode.c | 1 + fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 6 + fs/cifs/smb2pdu.c | 2 +- fs/fcntl.c | 5 +- fs/locks.c | 161 ++++++++++++++++-- fs/namei.c | 56 +++++- fs/nfs/dir.c | 39 ++++- fs/nfs/inode.c | 8 +- fs/nfs/internal.h | 3 +- fs/nfs/nfs4_fs.h | 83 ++++++++- fs/nfs/nfs4file.c | 8 +- fs/nfs/nfs4proc.c | 310 +++++++++++++++++++++++----------- fs/nfs/nfs4state.c | 65 ++++--- fs/nfs/nfs4super.c | 9 +- fs/nfs/nfs4xdr.c | 21 ++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 ++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 15 ++ include/linux/nfs_fs.h | 5 +- include/linux/nfs_xdr.h | 1 + include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 ++ include/uapi/linux/fs.h | 1 + 43 files changed, 789 insertions(+), 166 deletions(-) -- 1.7.10.4

4 18

Re: Assorted typos fixes (resend)
by Michael Stefaniuc 04 Feb '14

04 Feb '14

Hello Andrey, On 02/04/2014 12:19 PM, Andrey Gusev wrote: > diff --git a/dlls/dpnet/client.c b/dlls/dpnet/client.c > index 637dcb8..e94eea6 100644 > --- a/dlls/dpnet/client.c > +++ b/dlls/dpnet/client.c > @@ -54,7 +54,7 @@ static HRESULT WINAPI IDirectPlay8ClientImpl_QueryInterface(IDirectPlay8Client * > return DPN_OK; > } > > - WARN("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppobj); > + WARN("(%p)->(%s,%p), not found\n",This,debugstr_guid(riid),ppobj); when you do those can you please fix the obvious whitespace issues and add a space after the "," in the argument list? thanks bye michael

1 0

Re: Assorted typos fixes
by Alexandre Julliard 04 Feb '14

04 Feb '14

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > @@ -81,6 +81,6 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) > */ > HRESULT WINAPI DllUnregisterServer(void) > { > - FIXME(":stub\n"); > + FIXME(": stub\n"); I'm not against fixing real typos, but please don't overdo it, that kind of whitespace change is not necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] taskschd: Add IRegisteredTaskCollection stub implementation.
by Alexandre Julliard 04 Feb '14

04 Feb '14

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/taskschd/Makefile.in | 1 + > dlls/taskschd/folder.c | 9 ++- > dlls/taskschd/regtask_collection.c | 161 +++++++++++++++++++++++++++++++++++++ > dlls/taskschd/taskschd_private.h | 1 + > 4 files changed, 170 insertions(+), 2 deletions(-) > create mode 100644 dlls/taskschd/regtask_collection.c > > diff --git a/dlls/taskschd/Makefile.in b/dlls/taskschd/Makefile.in > index a1835fc..c85da9b 100644 > --- a/dlls/taskschd/Makefile.in > +++ b/dlls/taskschd/Makefile.in > @@ -5,6 +5,7 @@ C_SRCS = \ > folder.c \ > folder_collection.c \ > regtask.c \ > + regtask_collection.c \ Please try to group related interfaces into the same source file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: add CM_Get_Device_Interface_List_Size(A/W) stubs (1/2)
by Dmitry Timoshkov 04 Feb '14

04 Feb '14

Austin English <austinenglish(a)gmail.com> wrote: > +@ stdcall CM_Get_Device_Interface_List_SizeA(ptr str ptr long) > +@ stdcall CM_Get_Device_Interface_List_SizeW(ptr wstr ptr long) These entries are completely wrong. Same goes for 2/2. -- Dmitry.

1 0

Re: [2/2] bcrypt/tests: Add tests for BCryptGenRandom
by Bruno Jesus 03 Feb '14

03 Feb '14

Please, ignore this patch. It will fail the tests since wine will load the stubbed function and crash. I thought it would fail to load the function in GetProcAddress. On Mon, Feb 3, 2014 at 3:51 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > -- universe* god::bigbang (void); //and then it all began...

1 0

RFC - bcrypt: Semi-stub BCryptGenRandom
by Bruno Jesus 03 Feb '14

03 Feb '14

Hi, I'm looking for comments related to the attached patch. Is it valid to use advpi32? It seems to be the most easy way to generate random numbers. If not valid, what other ways are there to generate random numbers? If anyone would like to compile this patch please also get http://source.winehq.org/patches/data/102143 Thanks in advance, Bruno

2 1

Re: Assorted typos fixes
by Marvin 02 Feb '14

02 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4563 Your paranoid android. === wxppro (32 bit device) === device.c:107: Test failed: GetDeviceData() failed: 00000000

1 0

dpnet patches
by Stefan Dösinger 01 Feb '14

01 Feb '14

Hi Alistair, A while ago I promised to have a closer look at your dpnet patches. It’s a bit delayed, but here are some comments. How serious are you about dplay? Do you intend to do more work towards implementing it, or is that just wishful thinking on my part? http://source.winehq.org/patches/data/101857: The entire patch doesn’t do all that much, I think it’s best to hold of on that change until the function is meaningfully implemented - unless having a proper return value helps you in some way I’m missing. > + void *buffer = malloc(256); Please use HeapAlloc / HeapFree. http://source.winehq.org/patches/data/101856: > +DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); Isn’t that defined somewhere already? Do you need GUID_NULL to signal an uninitialized GUID? Is there a reason why setting the pointer to NULL doesn’t work? > -IMPORTS = dpnet ole32 > +IMPORTS = ole32 I’m not sure about this one, but winetest can automatically skip tests if the tested DLL doesn’t exist. It might use the imported libraries for that, or maybe just the name of the test. In the former case I think you want to keep the dpnet import. http://source.winehq.org/patches/data/101855: http://source.winehq.org/patches/data/101854: Did you think about sharing code between IDirectPlay8Peer and IDirectPlay8Server? The interfaces themselves have no relationship, but their methods are similar. http://source.winehq.org/patches/data/101853: > +typedef struct IDirectPlay8ClientImpl > +{ > + IDirectPlay8Client IDirectPlay8Client_iface; > + LONG ref; > +} IDirectPlay8ClientImpl; Are you sure you want to move the definition out of the library-wide header? If that works out ok it’s great, but you may need something other than the public interface in some other files in this library. I recommend to work without the typedef, but that should be changed in a separate patch. > - ULONG refCount = InterlockedIncrement(&This->ref); > + ULONG ref = InterlockedIncrement(&This->ref); > - TRACE("(%p)->(ref before=%u)\n", This, refCount - 1); > + TRACE("(%p) ref=%d\n", This, ref); ULONG is unsigned, you have to use %u. http://source.winehq.org/patches/data/101852 > + 'DPNSPModemModem' > + { > + val 'Friendly Name' = s 'Modem Connection For DirectPlay' > + val 'GUID' = s '{6D4A3650-628D-11D2-AE0F-006097B01411}' > + } > + > + 'DPNSPModemSerial' > + { > + val 'Friendly Name' = s 'Serial Connection For DirectPlay' > + val 'GUID' = s '{743B5D60-628D-11D2-AE0F-006097B01411}' > + } I know that those always exist on Windows, but wouldn’t it be better to not advertise them until we have an actual implementation? I think advertising DPNSPWinsockTCP alone should be ok for the start.

2 1

Re: [PATCH v7 1/7] VFS: Introduce new O_DENY* open flags
by Jeff Layton 01 Feb '14

01 Feb '14

On Fri, 17 Jan 2014 18:18:47 +0000 One Thousand Gnomes <gnomes(a)lxorguk.ukuu.org.uk> wrote: > > +#define ESHAREDENIED 258 /* File is locked with a sharelock */ > > Have you prepared C library patches to match this ? > > (and why not just use EPERM, it has the meaning you want already) > Tough call... On the one hand, ESHAREDENIED is a distinct error code so an application has the ability to determine what happened when an open or unlink fails. OTOH, a lot of applications won't understand ESHAREDENIED and may barf on it. Those apps might handle EPERM better. I'm not sure what the right approach is there... > > > + * Check to see if there's a share_reservation conflict. LOCK_READ/LOCK_WRITE > > + * tell us whether the reservation allows other readers and writers. > > + */ > > +static int > > +locks_mand_conflict(struct file_lock *caller_fl, struct file_lock *sys_fl) > > +{ > > Shouldn't this also check for CAP_SYS_DAC or some similar permission so > that root can override such a mess (eg to fix full disks in an > emergency) ? > > Agreed. This needs a mechanism that allows you to override it, IMO. CAP_DAC_OVERRIDE doesn't seem quite like the right thing since this isn't dealing with permissions, per-se. A new capability bit may even be warranted. > > + > > + /* > > + * For sharelock mounts if a file was created but not opened, we need > > + * to keep parent i_mutex until we finish the open to prevent races when > > + * somebody opens newly created by us file and locks it with a sharelock > > + * before we open it. > > + */ > > + if (IS_SHARELOCK(dir->d_inode) && error > 0 && *opened & FILE_CREATED) { > > + /* Don't check for write permission, don't truncate */ > > + open_flag &= ~O_TRUNC; > > + will_truncate = false; > > + acc_mode = MAY_OPEN; > > + path_to_nameidata(path, nd); > > + > > + error = may_open(&nd->path, acc_mode, open_flag); > > + if (error) { > > + mutex_unlock(&dir->d_inode->i_mutex); > > + goto out; > > + } > > + file->f_path.mnt = nd->path.mnt; > > + error = finish_open(file, nd->path.dentry, NULL, opened); > > + if (error) { > > + mutex_unlock(&dir->d_inode->i_mutex); > > + if (error == -EOPENSTALE) > > + goto stale_open; > > + goto out; > > + } > > + error = sharelock_lock_file(file); > > + mutex_unlock(&dir->d_inode->i_mutex); > > + if (error) > > + goto exit_fput; > > + goto opened; > > + } > > + > > mutex_unlock(&dir->d_inode->i_mutex); > > What stops the file system changing mount flags via a remount between > these two ? > > > > > if (error <= 0) { > > @@ -3034,6 +3073,18 @@ finish_open_created: > > goto stale_open; > > goto out; > > } > > + > > + if (IS_SHARELOCK(dir->d_inode)) { > > + /* > > + * Lock parent i_mutex to prevent races with sharelocks on > > + * newly created files. > > + */ > > + mutex_lock(&dir->d_inode->i_mutex); > > + error = sharelock_lock_file(file); > > + mutex_unlock(&dir->d_inode->i_mutex); > > + if (error) > > + goto exit_fput; > > + } > > opened: > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jeff Layton <jlayton(a)redhat.com>

1 0

spam filtering errors
by Jonas Maebe 31 Jan '14

31 Jan '14

Hi, Since the latest update of the mailing list server, a lot of mails sent to this list are wrongly classified as spam by CodeWeavers' mail server. I've already sent a mail about this to postmaster(a)codeweavers.com several months ago, but got no reply and nothing appears to have changed. It seems that the main culprit is the "SINGLE_HEADER_3K" spamassassin check, in combination with a very low spam score threshold (1.0). Below is an example from Stefan Dösinger's last mail (titled "dpnet patches"). Jonas X-Spam-Flag: YES X-Spam-Report: Spam detection software, running on the system "wine.codeweavers.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Alistair, A while ago I promised to have a closer look at your dpnet patches. ItXs a bit delayed, but here are some comments. How serious are you about dplay? Do you intend to do more work towards implementing it, or is that just wishful thinking on my part? [...] Content analysis details: (1.1 points, 1.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.0 SINGLE_HEADER_3K A single header contains 3K-4K characters 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefandoesinger[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid

3 2

Re: user32/tests: Don't compare boolean expressions with TRUE or FALSE
by Marvin 31 Jan '14

31 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4560 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] oleaut32: Fix RecordCopy()/RecordClear() behavior (try2)
by Marvin 30 Jan '14

30 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4552 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH] oleaut32: Fix RecordCopy()/RecordClear() behavior
by Alexandre Julliard 30 Jan '14

30 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/oleaut32/recinfo.c | 75 +++++++++++++++++++++- > dlls/oleaut32/tests/test_tlb.idl | 6 +- > dlls/oleaut32/tests/vartype.c | 130 +++++++++++++++++++++++++++++++++++++++ > dlls/oleaut32/usrmarshal.c | 3 +- > dlls/oleaut32/variant.h | 2 +- > 5 files changed, 210 insertions(+), 6 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok typelib.c:3977: Test failed: typeattr->cbSizeInstance expected 4 got 16 make: *** [typelib.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] wmp: Added tests.
by Marvin 30 Jan '14

30 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4551 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: [3/4] msxml3: Add separate QueryInterface implementation for IEnumVARIANT interface exported by IXMLElementCollection. Resend.
by Henri Verbeet 30 Jan '14

30 Jan '14

On 30 January 2014 06:07, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > + FIXME("interface %s not implemented\n", debugstr_guid(riid)); > + return E_NOINTERFACE; I don't know about xmlelem_collection_IEnumVARIANT_QueryInterface() specifically, but in general QueryInterface() should set *ppvObj to NULL on failure.

1 0

Re: wininet: InternetGetConnectedStateExW must return TRUE for success (try 2)
by Henri Verbeet 30 Jan '14

30 Jan '14

On 29 January 2014 23:01, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Citavi relies on == TRUE comparison so return TRUE instead of != FALSE > I think that in general this kind of change benefits from a comment indicating that the extra compare is on purpose, mostly to avoid someone from removing it again in the future.

2 1

Re: [2/2] kernel32: Don't leak extrabuf when HeapReAlloc fails
by Henri Verbeet 30 Jan '14

30 Jan '14

On 29 January 2014 23:41, André Hentschel <nerv(a)dawncrow.de> wrote: > - extrabuf = HeapReAlloc( GetProcessHeap(), 0, extrabuf, ebufsize ) ; > + if (newbuf = HeapReAlloc( GetProcessHeap(), 0, extrabuf, ebufsize )) > + extrabuf = newbuf; > + else > + break; This will introduce a warning: computername.c: In function ‘dns_gethostbyname’: computername.c:90:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] I happen to think + if (!(newbuf = HeapReAlloc( GetProcessHeap(), 0, extrabuf, ebufsize ))) + break; + extrabuf = newbuf; would be slightly nicer anyway.

1 0

Re: [PATCH] oleaut32: Fix RecordCopy()/RecordClear() behavior
by Marvin 30 Jan '14

30 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4547 Your paranoid android. === build (build) === Make failed

2 1

Re: mshtml/tests: Use common wine_dbgstr_guid implementation from test.h (resend)
by Marvin 30 Jan '14

30 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4536 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: [PATCH] shell32: Older shell32 doesn't support CSIDL_PROGRAM_FILES
by Alexandre Julliard 29 Jan '14

29 Jan '14

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > This should fix the failing NT4 tests. > > These tests are _really_ old, like 2005. I'm surprised they haven't > been fixed by now. Is there something I'm missing? They should probably have been fixed back then, but at this point NT4 isn't worth the trouble anymore, we should simply get rid of it in the test results. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] winhttp/tests: Only advance to the next notification test if the function is ok.
by Marvin 29 Jan '14

29 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4521 Your paranoid android. === wvista (32 bit notification) === notification.c:363: Test failed: failed to receive response 12029 notification.c:368: Test failed: request failed unexpectedly 0 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 441: expected status 0x00000008 got 0x00200000 notification.c:99: Test failed: 447: expected status 0x00000008 got 0x00200000 notification.c:455: Test failed: failed unexpectedly 12019 notification.c:456: Test failed: request failed unexpectedly 2293700 notification.c:460: Test failed: failed to query data available 12019 Timeout === w7pro64 (32 bit notification) === notification.c:455: Test failed: failed unexpectedly 12019 notification.c:456: Test failed: request failed unexpectedly 2686916 notification.c:460: Test failed: failed to query data available 12019 Timeout === w2008s64 (64 bit notification) === notification.c:359: Test failed: failed to send request 12029 notification.c:363: Test failed: failed to receive response 12017 notification.c:367: Test failed: failed unexpectedly 12019 notification.c:368: Test failed: request failed unexpectedly 4 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 === w7pro64 (64 bit notification) === notification.c:359: Test failed: failed to send request 12002 notification.c:363: Test failed: failed to receive response 12019 notification.c:368: Test failed: request failed unexpectedly 4 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:100: Test failed: 370: expected function 3 got 8

1 0

Re: [1/2] winhttp/tests: Ignore some missing notifications.
by Marvin 29 Jan '14

29 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4520 Your paranoid android. === wvista (32 bit notification) === notification.c:363: Test failed: failed to receive response 12029 notification.c:368: Test failed: request failed unexpectedly 0 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 4 got 8 notification.c:99: Test failed: 441: expected status 0x00000008 got 0x00200000 notification.c:99: Test failed: 447: expected status 0x00000008 got 0x00200000 notification.c:455: Test failed: failed unexpectedly 12019 notification.c:456: Test failed: request failed unexpectedly 2293700 notification.c:460: Test failed: failed to query data available 12019 Timeout === w2008s64 (64 bit notification) === notification.c:359: Test failed: failed to send request 12029 notification.c:363: Test failed: failed to receive response 12017 notification.c:367: Test failed: failed unexpectedly 12019 notification.c:368: Test failed: request failed unexpectedly 4 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:99: Test failed: 370: expected status 0x00000008 got 0x00000800 notification.c:100: Test failed: 370: expected function 3 got 8 notification.c:99: Test failed: 441: expected status 0x00000008 got 0x00200000 notification.c:99: Test failed: 447: expected status 0x00000008 got 0x00200000 notification.c:455: Test failed: failed unexpectedly 12019 notification.c:456: Test failed: request failed unexpectedly 0 notification.c:460: Test failed: failed to query data available 12019 Timeout === w7pro64 (64 bit notification) === notification.c:100: Test failed: 447: expected function 3 got 4

1 0

Re: wininet: InternetGetConnectedStateExW must return TRUE for success
by Michael Stefaniuc 29 Jan '14

29 Jan '14

Bruno, On 01/29/2014 02:27 AM, Bruno Jesus wrote: > Citavi relies on == TRUE comparison so return TRUE instead of != FALSE > > Fixes bug 17796 > > See http://bugs.winehq.org/show_bug.cgi?id=17796#c6 for AF analysis. > > > connect.txt > > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index a49026c..e0f8f1b 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -1219,7 +1219,7 @@ BOOL WINAPI InternetGetConnectedStateExW(LPDWORD lpdwStatus, LPWSTR lpszConnecti > WARN("always returning LAN connection.\n"); > *lpdwStatus = INTERNET_CONNECTION_LAN; > } > - return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen); > + return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen) ? TRUE : FALSE; we're getting rid of "? TRUE : FALSE" constructs in Wine as those are ugly and confusing. In this case a "return LoadStringW() != 0;" or even "> 0" is better as LoadString returns 0 on failure and a string length on success. bye michael

2 1

Re: [patch]: include : Add missing API to direct-x 9's shader header
by Henri Verbeet 29 Jan '14

29 Jan '14

On 28 January 2014 16:13, Kai Tietz <ktietz70(a)googlemail.com> wrote: > Resent patch without inlining. > Well, inline is prefered, but using git send-email makes it much easier to not mess that up. > +#define D3DXCONSTTABLE_LARGEADDRESSAWARE»······ 0x20000 You have a stray tab here. > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); I may not have explicitly said this in my previous mail about this patch, but I think the headers should be consistent. So if you make this change, you can't keep D3DX_SDK_VERSION at 36. If you bump it to 43, there may be changes to other interfaces you need to make as well. This could also have consequences for the actual implementation. > + STDMETHOD(GetConstantBuffer)(THIS_ LPD3DXBUFFER *ppConstantBuffer) PURE; Please avoid names like "ppConstantBuffer" and typedefs like LPD3DXBUFFER unless required for compatibility. So e.g.: + STDMETHOD(GetConstantBuffer)(THIS_ ID3DXBuffer **constant_buffer) PURE;

1 0

Re: gdiplus: Add tests for GetMetafileHeader functions.
by Marvin 28 Jan '14

28 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4513 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === wvista (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w2008s64 (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w7pro64 (32 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991 === w2008s64 (64 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279999 metafile.c:339: Test failed: Expected 72.000000, got 81.279999 metafile.c:372: Test failed: Expected 72.000000, got 81.279999 metafile.c:373: Test failed: Expected 72.000000, got 81.279999 metafile.c:399: Test failed: Expected 72.000000, got 81.279999 metafile.c:400: Test failed: Expected 72.000000, got 81.279999 === w7pro64 (64 bit metafile) === metafile.c:338: Test failed: Expected 72.000000, got 81.279991 metafile.c:339: Test failed: Expected 72.000000, got 81.279991 metafile.c:372: Test failed: Expected 72.000000, got 81.279991 metafile.c:373: Test failed: Expected 72.000000, got 81.279991 metafile.c:399: Test failed: Expected 72.000000, got 81.279991 metafile.c:400: Test failed: Expected 72.000000, got 81.279991

1 0

FOSDEM planning - last mailing list warning
by Jeremy White 28 Jan '14

28 Jan '14

Hi folks, This is it. If you are not subscribed to the wineconf mailing list, but you're planning to be at FOSDEM, you are going to be left out of all the cool parties and fun. We'll move our chatter and planning exclusively to that email list. So, if you're coming to FOSDEM, and you didn't get two copies of this email, sign up for it now: http://www.winehq.org/mailman/listinfo/wineconf Cheers, Jeremy

1 0

Re: shell32/tests: Add test for GetLastError in shlfileop
by Dmitry Timoshkov 28 Jan '14

28 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > ret = SHFileOperationA(&shfo); > todo_wine > ok(ret == 1026 || > ret == ERROR_FILE_NOT_FOUND || /* Vista */ > broken(ret == ERROR_SUCCESS), /* NT4 */ > "Expected 1026 or ERROR_FILE_NOT_FOUND, got %d\n", ret); > + todo_wine > + ok(GetLastError() == 0 || > + broken(GetLastError()==ERROR_FILE_NOT_FOUND), /* win 2000 */ > + "gle = %d\n", GetLastError() ); 'ret == ERROR_SUCCESS (0)' case is marked as broken above, so using broken for 'GetLastError() == 0' instead of ERROR_FILE_NOT_FOUND would match that behaviour. Same comment applies for other added tests. In general I don't think that adding last error tests for SHFileOperation is very useful because 1) this API returns error codes directly 2) according to the tests both returned error codes and set last error values differ in almost every Windows version, so it's very unlikely that there is an app that depends on this. -- Dmitry.

2 5

Re: winhttp/test: Fix a test that fails on Windows.
by Marvin 28 Jan '14

28 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4504 Your paranoid android. === wxppro (32 bit winhttp) === winhttp.c:324: Test failed: WinHttpSendRequest failed: 12029 winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:340: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:341: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:346: Test failed: WinHttpReceiveResponse failed: 12017. winhttp.c:350: Test failed: WinHttpReadData failed: 12019. winhttp.c:352: Test failed: Read 0 bytes instead of 14. winhttp.c:353: Test failed: Data read did not match. winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 === wvista (32 bit winhttp) === winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 winhttp.c:952: Test failed: failed to send request 12029 winhttp.c:955: Test failed: failed to receive response 12017 winhttp.c:962: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:966: Test failed: failed unexpectedly 12019 winhttp.c:967: Test failed: unexpected size 0 winhttp.c:972: Test failed: failed unexpectedly 12019 winhttp.c:973: Test failed: request failed unexpectedly 4287119 winhttp.c:1765: Test failed: failed to send request winhttp.c:2420: Test failed: got 80072efd === w7pro64 (32 bit winhttp) === winhttp.c:859: Test failed: failed to send request 12175 winhttp.c:939: Test failed: failed to receive response 12002 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 4287119 === w2008s64 (64 bit winhttp) === winhttp.c:936: Test failed: failed to send request 12029 winhttp.c:939: Test failed: failed to receive response 12017 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 0 winhttp.c:955: Test failed: failed to receive response 12029 winhttp.c:973: Test failed: request failed unexpectedly 0 === w7pro64 (64 bit winhttp) === winhttp.c:939: Test failed: failed to receive response 12002 winhttp.c:943: Test failed: failed unexpectedly 12019 winhttp.c:944: Test failed: request failed unexpectedly 0 winhttp.c:952: Test failed: failed to send request 12002 winhttp.c:955: Test failed: failed to receive response 12019 winhttp.c:962: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:966: Test failed: failed unexpectedly 12019 winhttp.c:967: Test failed: unexpected size 0 winhttp.c:972: Test failed: failed unexpectedly 12019 winhttp.c:973: Test failed: request failed unexpectedly 0

1 0

Re: shell32: Use boolean return value in boolean function
by Michael Stefaniuc 28 Jan '14

28 Jan '14

On 01/28/2014 12:07 AM, André Hentschel wrote: > --- > dlls/shell32/shellstring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/shell32/shellstring.c b/dlls/shell32/shellstring.c > index 6b511d2..9eb8536 100644 > --- a/dlls/shell32/shellstring.c > +++ b/dlls/shell32/shellstring.c > @@ -183,7 +183,7 @@ static BOOL StrToOleStrNW (LPWSTR lpWide, INT nWide, LPCWSTR lpStrW, INT nStr) > if (lstrcpynW (lpWide, lpStrW, nWide)) > { return lstrlenW (lpWide); > } > - return 0; > + return FALSE; This looks ugly. StrToOleStrNW() as well as StrToOleStrNA() return string length and not BOOL. What StrToOleStrN() (the sole user of about two functions) should return is not documented nor is there a Wine test for it. > } > > BOOL WINAPI StrToOleStrNAW (LPWSTR lpWide, INT nWide, LPCVOID lpStr, INT nStr) bye michael

1 0

Re: [PATCH] widl: Uuid attribute is allowed for 'struct'
by Marvin 28 Jan '14

28 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4497 Your paranoid android. === build (build) === Make failed

2 1

Re: user32/tests: Avoid preprocessor check to ensure it compiles (try 2)
by Marvin 27 Jan '14

27 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4477 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH 3/3] d3d9/tests: Improve testing of display formats and IDirect3D9_CheckDeviceType().
by Henri Verbeet 27 Jan '14

27 Jan '14

On 22 January 2014 23:42, Ken Thomases <ken(a)codeweavers.com> wrote: > > Consolidates duplicated code by using a simpler table-driven mechanism. > Instead of manually listing out certain combinations of display formats vs. > backbuffer formats, it just lists the formats and some metadata about them. > The algorithm tests every format against every format, using the metadata > to predict success or failure. This also tests that CheckDeviceType() fails > for display formats for which there are no adapter modes, rather than > skipping those. > > Tests windowed mode. > --- > dlls/d3d9/tests/device.c | 162 ++++++++++++++++++---------------------------- > 1 files changed, 64 insertions(+), 98 deletions(-) > This fails on native (Win 7, AMD Radeon HD 6310), and produces quite a lot of output in general: device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_R5G6B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_X1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_R5G6B5(23) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X1R5G5B5(24) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A1R5G5B5(25) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_X8R8G8B8(22) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A8R8G8B8(21) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_A2R10G10B10(35) windowed passed while it wasn't expected to device.c:2347: Testing display format D3DFMT_X1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2357: Test failed: format D3DFMT_X1R5G5B5(24) D3DFMT_UNKNOWN(0) windowed passed while it wasn't expected to device.c:2316: Display format D3DFMT_A1R5G5B5 not supported device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A1R5G5B5, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 1 device.c:2347: Testing display format D3DFMT_X8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 1 device.c:2316: Display format D3DFMT_A8R8G8B8 not supported device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A8R8G8B8, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 1 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_A2R10G10B10, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0 device.c:2316: Display format D3DFMT_UNKNOWN not supported device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 0, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_R5G6B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A1R5G5B5, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_X8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A8R8G8B8, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_A2R10G10B10, windowed 1, shouldPass 0 device.c:2347: Testing display format D3DFMT_UNKNOWN, backbuffer format D3DFMT_UNKNOWN, windowed 1, shouldPass 0

2 5

Re: [PATCH] scrrun: Implement IFolder::get_Path()
by Alexandre Julliard 27 Jan '14

27 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/scrrun/filesystem.c | 10 ++++++++-- > dlls/scrrun/tests/filesystem.c | 9 ++++++++- > 2 files changed, 16 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M scrrun.dll -p scrrun_test.exe.so filesystem && touch filesystem.ok filesystem.c:886: Test failed: got L"wine_ppds", expected L"a" filesystem.c:892: Test failed: got L"C:\\users\\julliard\\Temp\\wine_ppds", expected L"C:\\users\\julliard\\Temp\\a" make[1]: *** [filesystem.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] includes: Fix IDirect3DSwapChain8_Present argument count.
by Henri Verbeet 27 Jan '14

27 Jan '14

On 27 January 2014 14:41, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -#define IDirect3DSwapChain8_Present(p,a,b,c) (p)->lpVtbl->Present(p,a,b,c) > +#define IDirect3DSwapChain8_Present(p,a,b,c,d) (p)->lpVtbl->Present(p,a,b,c,d) I think you should fix the C++ version as well.

1 0

Re: [PATCH] api-ms-win-core-synch-l1-2-0: Add stub dll.
by Dmitry Timoshkov 27 Jan '14

27 Jan '14

Martin Storsjo <martin(a)martin.st> wrote: > --- /dev/null > +++ b/dlls/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.spec Windows 7 64-bit here has only api-ms-win-core-synch-l1-1-0.dll, did you really mean 1-2-0 and what version of Windows provides it? > +@ stdcall OpenEventA(long long str) kernel32.OpenEventA > +@ stdcall OpenEventW(long long wstr) kernel32.OpenEventW > +@ stdcall OpenMutexW(long long wstr) kernel32.OpenMutexW > +@ stdcall OpenSemaphoreWlong long wstr) kernel32.OpenSemaphoreW The string with OpenSemaphoreW has a typo. If somebody else like me wonders why there is no OpenMutexA and OpenSemaphoreA then the answer is that at least 1-1-0 version of this dll in Windows 7 doesn't export them. -- Dmitry.

2 1

Re: [PATCH 1/2] kernel32: threadpool definitions and prototypes
by Dmitry Timoshkov 26 Jan '14

26 Jan '14

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +#define WINPR_API WINBASEAPI This definition doesn't exist in PSDK 7.1. > +typedef DWORD TP_VERSION,*PTP_VERSION; PSDK 7.1 has this one and many other definitions in winnt.h instead. -- Dmitry.

3 3

Re: [PATCH 2/2] kernel32: very simple initial threadpool test
by Dmitry Timoshkov 26 Jan '14

26 Jan '14

Marcus Meissner <marcus(a)jet.franken.de> wrote: > +static NTAPI void threadpool_workcallback(PTP_CALLBACK_INSTANCE instance, void *context, PTP_WORK work) { > + int *foo = (int*)context; > + > + (*foo)++; > +} Although this most likely compiles without warnings 'NTAPI' should be replaced by the correct one, and its placement should be fixed. -- Dmitry.

1 0

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev 26 Jan '14

26 Jan '14

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

1 0

Re: [17/28] msxml3/tests: Use common wine_dbgstr_guid implementation from test.h (resend)
by Marvin 25 Jan '14

25 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4440 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: [16/28] mshtml/tests: Use common wine_dbgstr_guid implementation from test.h (resend)
by Marvin 25 Jan '14

25 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4439 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: [PATCH 5/5] wmp: Added WindowsMediaPlayer object stub implementation.
by Dmitry Timoshkov 25 Jan '14

25 Jan '14

Jacek Caban <jacek(a)codeweavers.com> wrote: > +struct WindowsMediaPlayer { > + IOleObject IOleObject_iface; > + LONG ref; > +}; > + > +static inline WindowsMediaPlayer *impl_from_IOleObject(IOleObject *iface) > +{ > + return CONTAINING_RECORD(iface, WindowsMediaPlayer, IOleObject_iface); > +} Will this and below code which needs 'struct WindowsMediaPlayer' but instead gets just 'WindowsMediaPlayer' compile without a typedef? -- Dmitry.

2 1

Re: [PATCH 2/5] wmp: Added new DLL.
by Dmitry Timoshkov 25 Jan '14

25 Jan '14

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 2)
by Marvin 24 Jan '14

24 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4420 Your paranoid android. === wxppro (32 bit bcrypt) === Timeout

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 5)
by Marvin 24 Jan '14

24 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4419 Your paranoid android. === wxppro (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === wvista (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w2008s64 (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w7pro64 (32 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w2008s64 (64 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737 === w7pro64 (64 bit file) === file.c:2454: Test failed: FindFirstFile failed, Error number -559038737

1 0

Re: [PATCH 2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode
by Bruno Jesus 24 Jan '14

24 Jan '14

On Thu, Jan 23, 2014 at 9:41 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 +++ > dlls/bcrypt/tests/bcrypt.c | 59 > +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 65 insertions(+) > Hi, Kai. > + status = pBCryptGetFipsAlgorithmMode(&result); > + ok(!status, "expected status STATUS_SUCCESS(0), got 0x%08X\n", status); > + ok(!result, "expected result FALSE, got %d\n", result); If the value depends on a registry entry how can you be sure it will always return 0? If the registry key is the only parameter required to return in this function IMO you should read the registry here and check against that instead of a fixed value. Best wishes, Bruno

2 1

Re: mscms: make missing lcms2 an error, not a fixme
by Hans Leidekker 23 Jan '14

23 Jan '14

On Wed, 2014-01-22 at 21:28 -0800, Austin English wrote: > It breaks applications (e.g., the Adobe Flash installer), it should be an error. In that case many other fixme's also qualify as errors ;-) Loading mscms without liblcms2 support doesn't necessarily mean that the application will break. It may not actually use it or it may only use functions that don't depend on liblcms2.

2 1

Re:[PATCH 4/5] gdiplus: Implement SetPageTransform playback.
by Akira Nakagawa 23 Jan '14

23 Jan '14

You have written the following: but you missed break;at the end of case {}. + case EmfPlusRecordTypeSetPageTransform: + { + EmfPlusSetPageTransform *record = (EmfPlusSetPageTransform*)header; + GpUnit unit = (GpUnit)flags; + + if (dataSize + sizeof(EmfPlusRecordHeader) < sizeof(EmfPlusSetPageTransform)) + return InvalidParameter; + + real_metafile->page_unit = unit; + real_metafile->page_scale = record->PageScale; + + return METAFILE_PlaybackUpdateWorldTransform(real_metafile); + } default:

2 1

Re: [PATCH] bcrypt: Added stub implementation for BCryptGetFipsAlgorithmMode
by Dmitry Timoshkov 23 Jan '14

23 Jan '14

Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > diff --git a/dlls/bcrypt/tests/Makefile.in b/dlls/bcrypt/tests/Makefile.in > new file mode 100644 > index 0000000..363986e > --- /dev/null > +++ b/dlls/bcrypt/tests/Makefile.in > @@ -0,0 +1,5 @@ > +TESTDLL = bcrypt.dll > +IMPORTS = user32 gdi32 bcrypt user32 and gdi32 APIs are not used in the test and should be removed from the imports list. > +static void test_getFipsAlgorithmMode(void) > +{ > + BOOLEAN result = TRUE; > + NTSTATUS status = BCryptGetFipsAlgorithmMode(&result); > + ok(!status, "expected status STATUS_SUCCESS(0), got %d\n", status); > + ok(!result, "expected result FALSE, got %d\n", result); > +} Probably BCryptGetFipsAlgorithmMode should be loaded dynamically. A usual test for invalid (NULL) argument would be useful. Also status should be printed in hex to match ntstatus.h definitions. -- Dmitry.

2 1

Re: shlwapi/tests: Avoid preprocessor check to ensure it compiles
by Dmitry Timoshkov 23 Jan '14

23 Jan '14

André Hentschel <nerv(a)dawncrow.de> wrote: > -#if 0 /* This test crashes on WinXP SP2 */ > +if (0) > +{ > ret = (*pSHCreateStreamOnFileA)(test_file, mode | stgm, NULL); > ok(ret == E_INVALIDARG, "SHCreateStreamOnFileA: expected E_INVALIDARG, got 0x%08x\n", ret); > -#endif > +} Please keep the comment. -- Dmitry.

1 0

Re:Add support to arguments with dash in taskkill
by Akira Nakagawa 23 Jan '14

23 Jan '14

if (*argdata != '/' && *argdata != '-') argdata is wchar type,so you should do as if (*argdata != L'/' && *argdata != L'-')

2 1

Re: [PATCH 1/2] advapi32: Foundation for HKCR merge
by Marvin 23 Jan '14

23 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4407 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: user32/tests: Avoid preprocessor checks to ensure it compiles
by Marvin 22 Jan '14

22 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4400 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: add Japanese man page of wine.
by Akihiro Sagawa 22 Jan '14

22 Jan '14

On Tue, 21 Jan 2014 23:56:15 +0900, Akira Nakagawa wrote: > diff --git a/loader/Makefile.in b/loader/Makefile.in > index 665bdda..80966fa 100644 > --- a/loader/Makefile.in > +++ b/loader/Makefile.in > @@ -8,6 +8,7 @@ MANPAGES = \ > wine.de.UTF-8.man.in \ > wine.fr.UTF-8.man.in \ > wine.man.in \ > + wine.ja.UTF-8.man.in \ > wine.pl.UTF-8.man.in > > IN_SRCS = \ Please keep alphabetical order. > diff --git a/loader/wine.ja.UTF-8.man.in b/loader/wine.ja.UTF-8.man.in > new file mode 100644 > index 0000000..c07adaa > --- /dev/null > +++ b/loader/wine.ja.UTF-8.man.in > @@ -0,0 +1,304 @@ (..) > +CUIの実行可能プログラム(Windowsコンソールプログラム)を実行するには、 > +.BR wineの代わりに The last line should be ".BR wine の代わりに" (note the space character after wine). Because groff thinks "wineの代わりに" is one word, whole of the sentence outputs in bold face. But, we just need to emphasize "wine". Please recheck other .RI, .RB, .BR, .IR macro lines. groff_man(7) describes these macro usages. Akihiro Sagawa

1 0

Re: Add support to arguments with dash in taskkill
by 中川祥 22 Jan '14

22 Jan '14

you compare the text without checking if it is 2 byte word. Is there any problem?

2 1

Re: [PATCH 2/3] riched20: Use codepage in ME_ToUnicode. (try 7)
by Alexandre Julliard 21 Jan '14

21 Jan '14

Jactry Zeng <jactry92(a)gmail.com> writes: > From 4bda4b989cef6ee1f45e6ee989e63db05ef770de Mon Sep 17 00:00:00 2001 > From: Jactry Zeng <jactry92(a)gmail.com> > Date: Sun, 5 Jan 2014 20:58:55 +0800 > Subject: riched20: Use codepage in ME_ToUnicode. > > --- > dlls/riched20/editor.c | 15 ++++++++------- > dlls/riched20/editor.h | 4 ++-- > dlls/riched20/string.c | 12 ++++++------ > 3 files changed, 16 insertions(+), 15 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so editor && touch editor.ok editor.c:7423: Test failed: GetWindowText returned 1 editor.c:7424: Test failed: buf = l make: *** [editor.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [patch]: include : Add missing API to direct-x 9's shader header
by Dmitry Timoshkov 21 Jan '14

21 Jan '14

Kai Tietz <ktietz70(a)googlemail.com> wrote: > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, > 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b); > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7, > 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1); A quick google search seems to contradict this change. Where does this come from? Also all of this looks like a plain copy/paste from MS headers, you can't do that. -- Dmitry.

3 2

Re: [PATCH v7 1/7] VFS: Introduce new O_DENY* open flags
by Pavel Shilovsky 21 Jan '14

21 Jan '14

2014/1/20 One Thousand Gnomes <gnomes(a)lxorguk.ukuu.org.uk>: >> > Shouldn't this also check for CAP_SYS_DAC or some similar permission so >> > that root can override such a mess (eg to fix full disks in an >> > emergency) ? >> >> May be it's better to let root an ability to remount the system >> without sharelock mount option and then fix an emergency? > > Doesn't that involve breaking the service for all users of the system > relying upon those locks, while root being allowed to ignore the locks > does not ? If we allow root to remount without "sharelock" (or bypass conflict checks), it will definitely break the service for all users. Probably it's better to stop the service (that cause all sharelocks to be unlocked), fix the emergency and start the service again. In the current state, the patchset doesn't allow any sort of ignoring those locks for mounts with "sharelock" option (either remount without "sharelock" or set special capabilities). It was done to make sure nothing breaks applications relying upon sharelock behavior. Also, that's why "sharelock" mount option was added: this behavior is dangerous to be on critical system paths like "/" or "/lib" and not suitable for global use. -- Best regards, Pavel Shilovsky.

1 0

Re: msxml3: Don't return implementation pointer as an interface.
by Nikolay Sivov 21 Jan '14

21 Jan '14

On 1/21/2014 09:08, Dmitry Timoshkov wrote: > --- > dlls/msxml3/xmlelem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c > index 2130c713..c525c8b 100644 > --- a/dlls/msxml3/xmlelem.c > +++ b/dlls/msxml3/xmlelem.c > @@ -663,7 +663,7 @@ static HRESULT WINAPI xmlelem_collection_get__newEnum(IXMLElementCollection *ifa > if (!ppUnk) > return E_INVALIDARG; > > - *ppUnk = (IUnknown *)This; > + *ppUnk = (IUnknown *)&This->IXMLElementCollection_iface; > IUnknown_AddRef(*ppUnk); > return S_OK; > } It's not necessary wrong, but it's possible it returns IEnumVARIANT here, it's easy to test.

1 0

Re: [website] Portuguese translation for release 1.7.10
by Bruno Jesus 20 Jan '14

20 Jan '14

2014/1/20 Lucas Zawacki <lfzawacki(a)gmail.com>: > + <li>Extensão do suporte ao protocolo IPX.</li> Should be "Suporte ao protocolo IPX estendido". Regards, Bruno

1 0

Re: [PATCH v7 1/7] VFS: Introduce new O_DENY* open flags
by Pavel Shilovsky 20 Jan '14

20 Jan '14

2014/1/17 One Thousand Gnomes <gnomes(a)lxorguk.ukuu.org.uk>: >> +#define ESHAREDENIED 258 /* File is locked with a sharelock */ > > Have you prepared C library patches to match this ? I don't have it for now. > > (and why not just use EPERM, it has the meaning you want already) We need to determine if we have a share reservation error to map it accurately in file servers and wine. > > >> + * Check to see if there's a share_reservation conflict. LOCK_READ/LOCK_WRITE >> + * tell us whether the reservation allows other readers and writers. >> + */ >> +static int >> +locks_mand_conflict(struct file_lock *caller_fl, struct file_lock *sys_fl) >> +{ > > Shouldn't this also check for CAP_SYS_DAC or some similar permission so > that root can override such a mess (eg to fix full disks in an > emergency) ? May be it's better to let root an ability to remount the system without sharelock mount option and then fix an emergency? > > >> + >> + /* >> + * For sharelock mounts if a file was created but not opened, we need >> + * to keep parent i_mutex until we finish the open to prevent races when >> + * somebody opens newly created by us file and locks it with a sharelock >> + * before we open it. >> + */ >> + if (IS_SHARELOCK(dir->d_inode) && error > 0 && *opened & FILE_CREATED) { >> + /* Don't check for write permission, don't truncate */ >> + open_flag &= ~O_TRUNC; >> + will_truncate = false; >> + acc_mode = MAY_OPEN; >> + path_to_nameidata(path, nd); >> + >> + error = may_open(&nd->path, acc_mode, open_flag); >> + if (error) { >> + mutex_unlock(&dir->d_inode->i_mutex); >> + goto out; >> + } >> + file->f_path.mnt = nd->path.mnt; >> + error = finish_open(file, nd->path.dentry, NULL, opened); >> + if (error) { >> + mutex_unlock(&dir->d_inode->i_mutex); >> + if (error == -EOPENSTALE) >> + goto stale_open; >> + goto out; >> + } >> + error = sharelock_lock_file(file); >> + mutex_unlock(&dir->d_inode->i_mutex); >> + if (error) >> + goto exit_fput; >> + goto opened; >> + } >> + >> mutex_unlock(&dir->d_inode->i_mutex); > > What stops the file system changing mount flags via a remount between > these two ? Nothing, but it doesn't bring problems here: if the first IS_SHARELOCK condition is true, we don't get into the second (see 'goto opened'). > >> >> if (error <= 0) { >> @@ -3034,6 +3073,18 @@ finish_open_created: >> goto stale_open; >> goto out; >> } >> + >> + if (IS_SHARELOCK(dir->d_inode)) { >> + /* >> + * Lock parent i_mutex to prevent races with sharelocks on >> + * newly created files. >> + */ >> + mutex_lock(&dir->d_inode->i_mutex); >> + error = sharelock_lock_file(file); >> + mutex_unlock(&dir->d_inode->i_mutex); >> + if (error) >> + goto exit_fput; >> + } >> opened: > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Pavel Shilovsky.

1 0

Re: [PATCH] oleaut32: Improve ITypeLib::FindName
by Nikolay Sivov 20 Jan '14

20 Jan '14

On 1/17/2014 21:40, Andrew Eikum wrote: > --- > dlls/oleaut32/tests/typelib.c | 99 +++++++++++++++++++++++++++++++++++++++++-- > dlls/oleaut32/typelib.c | 19 ++++++--- > 2 files changed, 107 insertions(+), 11 deletions(-) > + > for(fdc = 0; fdc < pTInfo->cFuncs; ++fdc) { > TLBFuncDesc *func = &pTInfo->funcdescs[fdc]; > int pc; > > - if(!TLB_str_memcmp(name, func->Name, len)) goto ITypeLib2_fnFindName_exit; > - for(pc = 0; pc < func->funcdesc.cParams; pc++) { > - if(!TLB_str_memcmp(name, func->pParamDesc[pc].Name, len)) > - goto ITypeLib2_fnFindName_exit; > + if(!TLB_str_memcmp(name, func->Name, len)) { > + memid[count] = func->funcdesc.memid; > + goto ITypeLib2_fnFindName_exit; > } > } > Minor problem, 'pc' should be removed.

1 0

Re: [PATCH] widl: Fix pointer size for SYS_WIN64 typelibs (try2)
by Marvin 19 Jan '14

19 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4361 Your paranoid android. === w2008s64 (64 bit typelib) === typelib.c:3925: Test failed: typeattr->cbSizeInstance expected 8 got 4 typelib.c:3925: Test failed: typeattr->cbSizeInstance expected 8 got 4 === w7pro64 (64 bit typelib) === typelib.c:3925: Test failed: typeattr->cbSizeInstance expected 8 got 4 typelib.c:3925: Test failed: typeattr->cbSizeInstance expected 8 got 4

2 1

Re: ws2_32/tests: Add missing closesocket calls (Coverity)
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4360 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (22c): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Re: [28/28] xmllite/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4340 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [27/28] windowscodecs/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4339 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [26/28] vbscript/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4338 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [25/28] urlmon/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4337 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [24/28] shell32/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4336 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [23/28] rpcrt4/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4335 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [22/28] riched20/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4334 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [17/28] msxml3/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4329 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: [16/28] mshtml/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 18 Jan '14

18 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4328 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: [21/28] qcap/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4333 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [20/28] oledb32/tests: Use common wine_dbgstr_guid implementation from test.h
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/6] dpnet: Add stubbed interface IDirectPlay8Server (try 4)
by Stefan Dösinger 17 Jan '14

17 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2014-01-17 02:07, schrieb Alistair Leslie-Hughes: > Added server tests. I noticed that you still have style inconsistencies in these patches. I haven't done a deeper review of the content yet. I'll get to that once I'm done with my own patches :-\ . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS2RGzAAoJEN0/YqbEcdMwTPEP/0ugKXy7Ecy6Dev1yXp4k/KG HqDB5DS3pbMcFtFLte8qa0DrtQNz0YsX0Po1Hbsrz6dB1GzVLa0VhqzJxJJ3C48j kkyz2IIXlTTzy2I/53MrZ8/pcjXWbIztkNRuki3OQA31k9VNo1d27cdYWysc2uxs OJKO+QSfM3ZMdrdHJF0sgfynudDnrq7A25KZbwPxnu1io1GKFQFLQVPz1pulnrkz Jp6i8sr2PhtfJU6YrxABP3sOOx8LQSCTVdpHhwOJez4eYSToYs+B5Fa67Ed/ol2m QfeAiwdD1xzA1FtwwzrbOGuy7GK4YB9CM0oNSSCCl2g92jGDR4YAG504L5QfjtBa GtN4CDQETi7phx292cCwNYApPYPwHFeL3lgKW+F6HnkF9oVPXx9IoaX6fwIf9P/Z ADX5coB/wgBsCj5wrjN8axVtFDwzSGTdv+OvHQKwllQKF3RLAthJpeJozg7NXz9N caFZ2Gbs6Sz00RZ7n7LokwMv8p32TY6P9hyKrJfDs0olMymTYCjVvJWUPEaoskIW ZfMAKZrgSgMvCf+ROdmh0ZhfpS+D2A4867vuDO48GfP6HzHG+rEffKwMACJ0uI2+ 7GuKJ83mw5s24pxMoyeByzj7KJgUtMalE+WGSqO8R70B3+aeaR29g6xn5fGu2NL7 TAouZUc5fcNM67Dsr8zp =2wkj -----END PGP SIGNATURE-----

2 2

Re: tests: Avoid duplicating debugstr_guid()
by Jacek Caban 17 Jan '14

17 Jan '14

Hi Frédéric, On 01/15/14 23:53, Frédéric Delanoy wrote: > diff --git a/include/wine/test.h b/include/wine/test.h > index 373fe76..d7ce8c1 100644 > --- a/include/wine/test.h > +++ b/include/wine/test.h > @@ -65,6 +65,7 @@ extern void winetest_add_failures( LONG new_failures ); > extern void winetest_wait_child_process( HANDLE process ); > > extern const char *wine_dbgstr_wn( const WCHAR *str, int n ); > +extern const char *debugstr_guid( const GUID *guid ); You probably want to follow existing test.h convention and call it wine_dbgstr_guid. This has a bonus advantage that you may split the patch for function introduction and per-dll replace. > static inline const char *wine_dbgstr_w( const WCHAR *s ) { return wine_dbgstr_wn( s, -1 ); } > > /* strcmpW is available for tests compiled under Wine, but not in standalone > @@ -523,6 +524,21 @@ const char *wine_dbgstr_wn( const WCHAR *str, int n ) > return res; > } > > +const char *debugstr_guid( const GUID *guid ) > +{ > + static char buf[50]; > + > + if (!guid) > + return "(null)"; > + > + sprintf(buf, "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", > + guid->Data1, guid->Data2, guid->Data3, guid->Data4[0], > + guid->Data4[1], guid->Data4[2], guid->Data4[3], guid->Data4[4], > + guid->Data4[5], guid->Data4[6], guid->Data4[7]); > + > + return buf; > +} It would be a good idea to use get_temp_buffer, like wine_dbgstr_wn, instead of static variable. Thanks, Jacek

2 2

Re: mmdevapi/tests: Remove unused dbgstr_guid function
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4313 Your paranoid android. === wvista (32 bit render) === render.c:1206: Test failed: GetPosition failed: 00000001 === w7pro64 (32 bit render) === render.c:654: Test failed: Wait(event) after Stop gave 102

1 0

Re: [PATCH 2/3] ddraw/tests: Rewrite AttachmentTest() and AttachmentTest7().
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4304 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:5769: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:5795: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:5769: Test failed: Failed to create surface, hr 0x80004002. ddraw7.c:5795: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [5/5] gdiplus: Add test for page transform in metafiles.
by Marvin 17 Jan '14

17 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4302 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === wvista (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w2008s64 (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w7pro64 (32 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w2008s64 (64 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279999 metafile.c:880: Test failed: Expected 00000168, got 00000196 === w7pro64 (64 bit metafile) === metafile.c:872: Test failed: Expected 72.000000, got 81.279991 metafile.c:880: Test failed: Expected 00000168, got 00000196

1 0

Re: [PATCH] widl: Fix pointer size for SYS_WIN64 typelibs
by Alexandre Julliard 16 Jan '14

16 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > tools/widl/write_msft.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) It breaks the tests: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok typelib.c:3909: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:3909: Test failed: typeattr->cbSizeInstance expected 4 got 8 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tests: Avoid duplicating debugstr_guid()
by Marvin 16 Jan '14

16 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4266 Your paranoid android. === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: tests: Avoid duplicating debugstr_guid()
by Marvin 16 Jan '14

16 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4252 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9845: Test failed: got 00244F94

1 0

Re: dpnet: Improve Error checking in Get/Set SP
by Stefan Dösinger 15 Jan '14

15 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, > + hr = IDirectPlay8Address_GetSP(localaddr, &guidsp); > + ok(hr == DPNERR_DOESNOTEXIST, "got 0x%08x\n", hr); For the sake of completion I'd test setting GUID_NULL, IID_IUnknown and something nonsensical like IID_IDirectDrawGammaControl (or maybe something you have access to without additional headers like IID_IDirectPlay8Address). Some style nitpicks follow. If you end up becoming the de-facto maintainer of dplay it's up to you how important they are: > + sprintf(buf, > + "{%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}", > + guid->Data1, guid->Data2, guid->Data3, > + guid->Data4[0], guid->Data4[1], guid->Data4[2], guid->Data4[3], > + guid->Data4[4], guid->Data4[5], guid->Data4[6], guid->Data4[7]); In the d3d code we use 8 space indentations. You may want to follow that. Also, there's debugstr_guid in wine/debug.h. It seems you're aware of that and used your own functions because wine/debug.h doesn't work in the tests. Is this correct? > + if(!pguidSP) > + return DPNERR_INVALIDPOINTER; > ... > + if( SUCCEEDED(hr) ) > + { > ... > + if (hr != S_OK) The whitespaces around the () are inconsistent. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS1kqJAAoJEN0/YqbEcdMwfngP/RUrjrAH/vDvQH+jtBSOQwd8 OymWNEWmt4jqzt3febi5Mo15oDGSuuqIjcyoRwpOTPrlmwGYmeAjm/z5JxAcH+o1 XFhZF8zL85u0sAlW8A3bAEuPB/a0nP2/K8y523mt+uFYz/4cOwv11sR/fAJjCgR5 SkkWI29t/JXBkQmPhQHArdyi1CgRTQ+MSNEwzM3B+nudn8zhjV3VH+WYDyLkl8D6 GS3GBJqAAka0Iqo6KdVC4VTdxSVUJVivfAZSlSTZVHcYAlC49k6F5uYtTLd+MQRZ bUlnHSkJtveC1lj9FiIliJexO1M9zLr+lY5/RtD9ntbe4K5i+tgEpjExg6uSNbmD cw6IjE+qcrQsp2x9NBED7j1OetUmjeUgwUQcWo56FoVQBp9N7ynSLF2HOPQ7rf8Q SHroMxtOzwPHxmyXNFDCbDYwnVviq17KqSOXcD46VvY99NbFEmm5nyPBNuLUzPQb JkkakS4i1+eUigD3QnY5eHE5NPWJBq4/WeEF9TYtBUjg30Q0pU5CmDf888fyFPj2 UYsheWKR5LcUIZ3oXFPrzcaiS+1hLAfEiKCH8VXsNCPMV4S6KDS2hIhHJQh3mWEj z//uLe23Ll2bNrZOOfzwWBGfAmLNB+TfW+Q2phXlTTH5lgITxU4N0KR/pNpCkqz8 KrWsuFvS8iZSfT3G+fSw =XG/n -----END PGP SIGNATURE-----

2 1

Re:My ideas of New wine function.
by Akira Nakagawa 15 Jan '14

15 Jan '14

http://wiki.winehq.org/AkiraNakagawa Please write your opinion here. I think the compatibility is the first we maintain. So we should do it optionally.

1 0

Re: wine.inf: Add DirectPlay8 Registry keys
by Bruno Jesus 14 Jan '14

14 Jan '14

On Fri, Jan 10, 2014 at 5:06 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > wine.inf: Add DirectPlay8 Registry keys This patch seems to make Rise of Nations go a lit bit further in it's attempt to get multiplayer running. > Best Regards > Alistair Leslie-Hughes Regards, Bruno

4 7

Re: [bcrypt] add missing definitions
by Dmitry Timoshkov 14 Jan '14

14 Jan '14

Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +#define MS_PRIMITIVE_PROVIDER L"Microsoft Primitive Provider" > + > +/* Algorithm Identifiers */ > +#define BCRYPT_RSA_ALGORITHM L"RSA" This can't work properly in Wine. -- Dmitry.

4 5

[2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Ralf Habacker 14 Jan '14

14 Jan '14

>On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: >> @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, >> } >> } >> >> + XFORM old; >> + BOOL exclude_rotation = FALSE; >> + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) >> + { >> + GetWorldTransform( hdc, &old ); >> + XFORM xf = old; >> + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) >> + { >> + exclude_rotation = TRUE; >> + removeRotationFromMatrix( &xf, NULL ); >> + SetWorldTransform( hdc, &xf ); >> + } >> + } > >Does Windows really do this only in the same-scaled, non-sheared case? The updated patch http://www.winehq.org/pipermail/wine-patches/2014-January/129505.html contains a related hint from the developer: "Note: The current implementation only works on matrixes with uniform scale and shear, which has to be checked by a call to xform_has_rotate_and_uniform_scale_and_shear(). Hints how to get *unique* values for non-uniform matrixes are welcome." The application, for which the patch has been written (http://appdb.winehq.org/objectManager.php?sClass=application&iId=13649) works fine with this patches, as it only uses dc rotatation. Regards Ralf

1 0

[2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Ralf Habacker 14 Jan '14

14 Jan '14

>On 1/7/2014 17:33, Ralf Habacker wrote: >> This patch detects operational condition first and then removes >> temporary rotation from the world transform. >> Bug: http://bugs.winehq.org/show_bug.cgi?id=33190 >> --- >> dlls/gdi32/font.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> + XFORM old; >> + BOOL exclude_rotation = FALSE; >> + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) >> + { >> + GetWorldTransform( hdc, &old ); >> + XFORM xf = old; >> + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) >> + { >> + exclude_rotation = TRUE; >> + removeRotationFromMatrix( &xf, NULL ); >> + SetWorldTransform( hdc, &xf ); >> + } >> + } >> + >Flag really means do we need to restore transform or not. done http://www.winehq.org/pipermail/wine-patches/2014-January/129513.html > >> + if ( GetGraphicsMode( hdc ) == GM_ADVANCED && exclude_rotation == TRUE ) >> + { >> + SetWorldTransform( hdc, &old ); >> + } >> + >Doesn't look like you need to check a mode again. done, see above link Regards Ralf

1 0

[1/4] gid32: Add matrix helper functions.
by Ralf Habacker 14 Jan '14

14 Jan '14

>On 1/7/2014 17:31, Ralf Habacker wrote: >> Contains basic functions required by further patches >> --- >> dlls/gdi32/dibdrv/graphics.c | 49 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> >That should be merged with a first patch that uses it. done http://www.winehq.org/pipermail/wine-patches/2014-January/129505.html >> +/* >> + check matrix for condition >> +*/ >> +BOOL hasRotatedAndSameScaledMatrixOnly(XFORM *xform) >> +{ >> + return xform->eM11 == xform->eM22 && >> + -xform->eM21 == xform->eM12; >> +} >> + >Comment is telling nothing, 'xform' should be const probably. done, see above link > >> + double determinant = 0; >> + >> + /* xform = xfrom-transposed * xform */ >> + xform->eM11 = sqrt( xform->eM11 * xform->eM11 + xform->eM21 * xform->eM21 ); >> + xform->eM22 = sqrt( xform->eM12 * xform->eM12 + xform->eM22 * xform->eM22 ); >> + xform->eM12 = 0; >> + xform->eM21 = 0; >> + xform->eDx = 0; >> + xform->eDy = 0; >> + >> + if ( rotation_and_translation == NULL ) >> + return TRUE; >> + >> + determinant = xform->eM11 * xform->eM22; >> + >> + inverse_matrix_scale.eM11 = xform->eM22 / determinant; >Is it possible to get 0 determinant here? Function never returns FALSE, >so return value is useless. fixed in above mentioned file. > >Also please follow function and variable naming conventions used in this >file. done, found also better names for this functions. Regards Ralf

1 0

Re: [PATCH 2/2] oleaut32/tests: Added some IRecordInfo tests
by Marvin 14 Jan '14

14 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4221 Your paranoid android. === w2008s64 (64 bit vartype) === vartype.c:6379: Test failed: got size 12 vartype.c:6410: Test failed: got 00000000DEADBEEF vartype: unhandled exception c0000005 at 000007FEFF93127F === w7pro64 (64 bit vartype) === vartype.c:6379: Test failed: got size 12 vartype.c:6410: Test failed: got 00000000DEADBEEF vartype: unhandled exception c0000005 at 000007FEFEBE30FA

1 0

Re: My idea about new wine functions.
by Akira Nakagawa 14 Jan '14

14 Jan '14

I understand 1 is difficult.(Then I want to use winelib from Synaptic!) But 2 is very easy,isn't it? Most wine function call Trace() at first,so you patch Trace() that translates argument.

2 1

My idea about new wine functions.
by Akira Nakagawa 13 Jan '14

13 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 1.export Directx from winelib and publish as a development package. In other word,let winelib Directx be used as OpenGL be in Unix native applications.(and support pkg-config) 2.Dynamic translation using gettext on windows application. That is,in short,enable windows application to translate through Wine API although the applications don't support internationalization. This is how,for example. An application supposed to create new windows titled "New Windows". Then,wine receive string "New Window" and replace it to "新しいウィンドウ" in Japanese or "新窗口" in Chinese.Most applications use Windows API to show string,so you can use wine to translate dynamically. 3.Unite Wine settings(winecfg and uninstaller) to OS's control panel which wine runs in. (I want GUI font replacement configuration,too.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS01SIAAoJEGIH3IGNPdCozn8P/3OD/w/p89N1q0TF5DcczXHn 9dVjeogZHo1KHihWUXxUHow6+dzrfkYXnFAPVcEqViYpv/c5tgKLAaSojmfwYW19 W7XdHLL/9qZrFVWm9TmEqC34ikjvyLAurL5DYbBZq1SvJktzD0nzWr0WMPUzT7E3 j5Lg/4gHTipPhqr7xwwz5pIH7Vr84YxN5ZcsiMGWEVvV/y/9sSzKs0FLWlSWgSVh EkRuVZNLoYEy0kXN+NIUH3ojapYGsNgL4lNOr4uuH7NuESV+a/+h4wEMLYpOGHv+ NiUOZrF/dDpwDxRok7NTP+utQSN4UACwy8XpYHpcYBaEZhwNSH6Y3HP6mNRZDQSs zRzmCfWs6Ml1p99lLwn3V6Iak+D5aDGGzBZZuboD1tiae0asVwXrFYTyjmh6yNPB WgLIQYj/6WhHGWqqiKpFoMpJswMKzV/2IgpiNlQ3bCbgDyoI78a6FVmEJyN09710 RZGmy2iCfAK8YfmMMcHWKNP6KgdcE0JKkDPrP4OJsnbVDbiR10B5jBEoSCIbQt4+ funbn+3CZNAHCHMzGEV+C+H3OCn9+pMSDeEpPfDjbXVAzVdYtSZQwdqQRI8eakzf ZrmR+KogboT1YlH0XFBWsAtA8QfBb74jto9RyyGmrvvC1J9CVQMvgb+p44buhP80 Mc12miN6vkVge93IdpHc =+JHI -----END PGP SIGNATURE-----

3 2

Re: dssenh/tests: Added Cylink Mek algorithm definition and crypto provider algorithm tests for dssenh (try 2).
by Alexandre Julliard 13 Jan '14

13 Jan '14

Marek Chmiel <kcmark(a)gmail.com> writes: > + for(i = 0; i < testLen; i++) > + { > + SetLastError(0xdeadbeef); > + dataLen = sizeof(dataBuffer); > + > + result = CryptGetProvParam(hProv, PP_ENUMALGS_EX, dataBuffer, &dataLen, flag); > + ok(result, "Failed to get parameter from CSP."); > + > + pointer = dataBuffer; That's better but you should still check that you reached the end of the enumeration. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Add INFINITY and NAN definitions to math.h.
by Jacek Caban 13 Jan '14

13 Jan '14

Hi Francois, On 01/10/14 15:29, Francois Gouget wrote: > --- > > The INFINITY and NAN definitions have been added to math.h in recent > versions of msvcrt (i.e. they were not present in Visual C++ 2008 but > are in Visual C++ 2013). This means we have to provide them too > otherwise code that compiles with Visual C++ could fail to compile with > Winelib. > > To do so I'm just reusing the definition we have in wine/port.h. > > This definition bothers me a bit in that it clearly depends on the > in-memory representation of these floating point constants, which might > not be very portable (depending on whether the system uses IEEE 754 or > not, etc). In d3dx9_36 we used to define NAN as '0.0f / 0.0f'. Other > definitions would be variants like 'INFINITY * 0.0f', etc. I can't > really claim that those are really more portable and the compiler may > (and some do) complain about them. Hence why I went with the wine/port.h > definitions in the end. If they're good enough for port.h they should be > good for math.h too. > > > include/msvcrt/math.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/include/msvcrt/math.h b/include/msvcrt/math.h > index 34aa268..42d6bfe 100644 > --- a/include/msvcrt/math.h > +++ b/include/msvcrt/math.h > @@ -146,6 +146,26 @@ static const union { > # endif > #endif > > +#ifndef INFINITY > +/* From wine/port.h */ > +static inline float __port_infinity(void) > +{ > + static const unsigned __inf_bytes = 0x7f800000; > + return *(const float *)&__inf_bytes; > +} > +#define INFINITY __port_infinity() > +#endif > + > +#ifndef NAN > +/* From wine/port.h */ > +static inline float __port_nan(void) > +{ > + static const unsigned __nan_bytes = 0x7fc00000; > + return *(const float *)&__nan_bytes; > +} > +#define NAN __port_nan() > +#endif > + > #ifdef __cplusplus > } > #endif In wine/port.h, we implement worst-case scenario where math.h doesn't define NAN/INFINITY. In this case, since glibc/system math.h won't be used and our msvcrt math.h will be included instead, we should try to provide better NAN/INFINITY versions when possible. Looking at how it's done in my Linux headers, there is __builtin_nanf() and __builtin_inff() guarded by GCC >= 3.3 that we could use. How is it defined on MSVC? Jacek

2 3

Re: oleaut32/tests: Mark W2k results as broken
by Dmitry Timoshkov 13 Jan '14

13 Jan '14

André Hentschel <nerv(a)dawncrow.de> wrote: > - ok(sa->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR), "got 0x%08x\n", sa->fFeatures); > - ok(sacopy->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR), "got 0x%08x\n", sacopy->fFeatures); > + ok(sa->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR) || > + sa->fFeatures == broken(FADF_CREATEVECTOR /* W2k */), > + "got 0x%08x\n", sa->fFeatures); > + ok(sacopy->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR) || > + sacopy->fFeatures == broken(FADF_CREATEVECTOR /* W2k */), > + "got 0x%08x\n", sacopy->fFeatures); > hres = SafeArrayCopyData(sa, sacopy); > ok(hres == S_OK, "got 0x%08x\n", hres); > - ok(sacopy->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR), "got 0x%04x\n", sacopy->fFeatures); > + ok(sacopy->fFeatures == (FADF_HAVEVARTYPE|FADF_CREATEVECTOR) || > + sacopy->fFeatures == broken(FADF_CREATEVECTOR /* W2k */), > + "got 0x%04x\n", sacopy->fFeatures); Usage of 'broken' statement is incorrect. -- Dmitry.

1 0

Re: dmscript/tests: Add COM tests for DirectMusicScriptTrack. (2nd try)
by Marvin 12 Jan '14

12 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4196 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 08/11] dmscript/tests: Add COM tests for DirectMusicScriptTrack.
by Marvin 12 Jan '14

12 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4193 Your paranoid android. === wxppro (32 bit dmscript) === dmscript.c:147: Test failed: DirectMusicScriptTrack create failed: 80040110, expected E_POINTER === wvista (32 bit dmscript) === dmscript.c:147: Test failed: DirectMusicScriptTrack create failed: 80040110, expected E_POINTER === w7pro64 (32 bit dmscript) === dmscript.c:147: Test failed: DirectMusicScriptTrack create failed: 80040110, expected E_POINTER

1 0

Re: Command Stream Update
by Forest 12 Jan '14

12 Jan '14

On Tue, 07 Jan 2014 22:31:24 +0100, Stefan Dösinger wrote: >I have published an update to the command stream patches from >September. The code is available on Github at >https://github.com/stefand/wine Thanks, Stefan! I used a snapshot of your repository for my latest Ubuntu PPA release. This ought to please the users who have been asking for an update. (Last time I checked, Launchpad said there were a hundred or so people using my builds.) https://launchpad.net/~foresto/+archive/winepatched/ I was pleasantly surprised to find that a long-standing Guild Wars visual bug (reproducible by changing between armor and town clothes) seems to be fixed by your latest code. Here's the bug report: http://bugs.winehq.org/show_bug.cgi?id=29872

1 0

Fwd: nearly all applications immediately crash
by MadLoisae＠gmx.net 11 Jan '14

11 Jan '14

Hello wine-users, have an issue with my wine. My system is debian wheezy x86_64 with installed multiarch and wine-bin:i386, the packages are all from debian so it's wine version 1.4.1. nearly all applications crash immediately on useraction. the attached output was from most recent notepad++ installer - I can start it and click on next, I can see the license a very short moment and the installer disappears with an error in console I started from. wine: Unhandled page fault on write access to 0x000000f9 at address 0x7bc4aa6b (thread 0009), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc4aa6b the attached output is with WINEDEBUG=+relay if I copy a windows-installed Notepad++ to program directory and start it from there, I can open files and immediately it crashes. Sometimes the text is displayed, if I then scroll or do anything in program it ... crashes. :-/ I tried so far some gdi based winetricks, also I tried several times purging wine complete (including removing .wine), did not help. my system is headless, no monitor attached. vncserver runs on it, icewm as window manager. any ideas? Thanks! Alois

1 0

Re: iphlpapi: Return error for IP address with value zero in IcmpSendEcho
by Bruno Jesus 11 Jan '14

11 Jan '14

Hi, Alexandre. I see this patch is pending and unfortunately it's not obvious to me what the reason is. The IP 0.0.0.0 need to be stopped otherwise linux will turn it into 127.0.0.1 and successfully ping it. Best wishes, Bruno On Thu, Jan 9, 2014 at 8:45 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > I missed the function name in the subject. Please ignore 101595. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=33272

1 0

Command Stream Update
by Stefan Dösinger 10 Jan '14

10 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I have published an update to the command stream patches from September. The code is available on Github at https://github.com/stefand/wine (direct git url at https://github.com/stefand/wine). A small change summary: *) Tons of bug fixes. *) Dynamic surface maps. This improves World of Warcraft and many other games. *) The code avoids acquiring a GL context on the main thread, with few exceptions. This improves stability on all drivers, especially on fglrx. *) This version essentially matches the command stream code we shipped in CrossOver 13, just applied on top of Wine. *) The Wine version this tree is based on is the git head from this evening, 460991a8. As with the last version you have to set HKEY_CURRENT_USER/Software/Wine/Direct3D/CSMT="enabled" to use it. You should disable StrictDrawOrdering because it is no longer needed with CSMT on. I plan to push updates to this repository at irregular intervals. I probably won't send an announcement to wine-devel every time I do this. I also don't promise any schedule - it mostly depends on how busy I am with other work and how difficult the rebases are. Enjoy, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzHIsAAoJEN0/YqbEcdMw10wQAIBZ1LuNK4By0WLZzujwww3Z mZjd/kgux13THVtTzVoxVL38nzhOxIuGV0B5P6yoXJlKpxILSCdjr208EWMf+qo7 j4m3DGibrSrjPOCog4hXQeMrn2YjHC2BnFtDIiCYKq33ZPjJ60mSKEkpOzzbeEa8 7C7l9Y+mGKHQl6WViUp7HMoxFo3irZ1DCxRiDiOcFXdQhOZEpuuClB+vabUh15OH 3iNQdAwIiH9YZk9ir7nF5zcbnnLJGNjKNNUPEPu91P1PQ9LdM3zNqz7jU2Klo0Kl 7ZA+O6JVHSuWw04w1Lz6UM7Exu1dY6hRL9BfZQxodBOXtC0NwqIMbeW0bKn1VMEL cF4a+3sqGTJhni0dITEP1BzqmZH3sqYBPuOCb244+UOYwUjLTtx2QcASE3khb8D8 XVry6zrGJl1t1WzwPC/SK6/IOWHhvcznX+JeoYQiNIfOuFUsoVjKcswDxDLLi/+0 qUSpdWvI9fWy/udpaJoemspX0fjvNud6TcdLA/hHvfpoa6+fbHEJV+EC0M6PHFw8 RZ6Hi3VTlg0FBKYqowarqjjYNAxYWecTo9LKjMYTzFVpH4fTKcZUOpMdV+A2sRvv F0Hy0beXyih+Q03HwKmIbWQqWME1Fr62iCa88uO6leT4tPJ5SG3oZ2Reb2zmvFJq QbfNO3JMTqTqrXyUcsQj =dysQ -----END PGP SIGNATURE-----

3 8

Re: [website] Make https for wiki
by Jeremy Newman 10 Jan '14

10 Jan '14

We cannot apply this patch until the Wiki has a certificate and has been setup with an SSL vhost. -N On 01/10/2014 08:10 AM, Andrey Gusev wrote: > This should fix bug http://bugs.winehq.org/show_bug.cgi?id=34443

1 0

Re: ws2_32/tests: Add a trailing '\n' to a win_skip() call.
by Marvin 10 Jan '14

10 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4157 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [2/2] dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo (try 2)
by Bruno Jesus 10 Jan '14

10 Jan '14

On Fri, Jan 10, 2014 at 5:38 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Remove pointer checks > > Changelog: > dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo > Hi, I'm not used to review patches but please take a look at the points below. + if(This->peername) + HeapFree(GetProcessHeap(), 0, This->peername); + if(This->data) + HeapFree(GetProcessHeap(), 0, This->data); + You don't need to check for NULL. + len = lstrlenW(pdpnPlayerInfo->pwszName); + This->peername = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); + memcpy(This->peername, pdpnPlayerInfo->pwszName, len * sizeof(WCHAR)); If peername is a string don't you need a len + 1 to mark NULL in the end? I'm not sure but since you can use lstrlenW can't you use heap_strdupW? + This->data = HeapAlloc(GetProcessHeap(), 0, pdpnPlayerInfo->dwDataSize); + memcpy(This->data, pdpnPlayerInfo->pvData, pdpnPlayerInfo->dwDataSize); Don't you need to store the dwDataSize in datasize you created in the struct? > Best Regards > Alistair Leslie-Hughes > Best regards, Bruno

1 0

Re: [2/2] dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo
by Nikolay Sivov 10 Jan '14

10 Jan '14

On 1/10/2014 11:18, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > dpnet: Partial Implement IDirectPlay8Peer SetPeerInfo > > > Best Regards > Alistair Leslie-Hughes > > + if(This->peername) > + HeapFree(GetProcessHeap(), 0, This->peername); > + if(This->data) > + HeapFree(GetProcessHeap(), 0, This->data); > + You don't need to check for NULL.

1 0

Re: [PATCH 1/2] ddraw: Make DirectDrawEnumerateEx only enumerate secondary display devices when requested.
by Henri Verbeet 09 Jan '14

09 Jan '14

I think this looks ok in principle, but a test wouldn't hurt.

2 3

Re: Assorted spelling fixes
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4101 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Re: Command Stream Update
by Yuri Shishenko 09 Jan '14

09 Jan '14

Civilization V has performance regression with this wine version. It shows less FPS than unpatched wine-1.7.10: 20 FPS on maximum camera distance while with unpatched wine it shows 40-50 FPS. My PC specs: openSUSE 13.1, linux 3.12.6 x86_64, nVidia GTX660 with 331.20 driver, Intel Core I5-3570k.

1 0

Re: [PATCH 4/5] d3dx9_36/tests: Use a window with a non-zero size.
by Henri Verbeet 09 Jan '14

09 Jan '14

On 9 January 2014 13:43, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > WS_SYSMENU | WS_POPUP follows the existing code in D3DXCreateBoxTest, > which is the only test that created a useable device on my system. I think you might as well just use WS_OVERLAPPEDWINDOW like e.g. the d3d9 tests do, but I don't care that much.

1 0

Re: [PATCH 6/6] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger 09 Jan '14

09 Jan '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-01-09 12:17, schrieb Henri Verbeet: > + hr = IDirectDrawSurface7_GetAttachedSurface(surface, &caps, > &tmp); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr > %#x.\n", hr); + hr = IDirectDrawSurface7_GetColorKey(tmp, > DDCKEY_SRCBLT, &color_key); + ok(hr == DDERR_NOCOLORKEY, "Got > unexpected hr %#x, i %u.\n", hr, i); + + > color_key.dwColorSpaceLowValue = 0x0000ff00; + > color_key.dwColorSpaceHighValue = 0x0000ff00; + hr = > IDirectDrawSurface7_SetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to set color key, hr > %#x.\n", hr); + memset(&color_key, 0, sizeof(color_key)); + > hr = IDirectDrawSurface7_GetColorKey(surface, DDCKEY_SRCBLT, > &color_key); + ok(SUCCEEDED(hr), "Failed to get color key, hr > %#x.\n", hr); + ok(color_key.dwColorSpaceLowValue == 0x0000ff00, > "Got unexpected value 0x%08x.\n", + > color_key.dwColorSpaceLowValue); + > ok(color_key.dwColorSpaceHighValue == 0x0000ff00, "Got unexpected > value 0x%08x.\n", + color_key.dwColorSpaceHighValue); + > + IDirectDrawSurface_Release(tmp); Did you mean to call SetColorKey and GetColorKey on tmp instead of surface here? For the sake of completion it might be interesting to test SetColorKey on cube textures. 5 of the faces are attached to a root surface but aren't mipmap sublevels. (I guess it'll still return DDERR_NOTONMIPMAPSUBLEVEL.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSzpDjAAoJEN0/YqbEcdMwyl0P/3OHO0kK93dh6XdY1RU9IvNv BASe8YHhv1a6rRxYNGDzGoX5bsnefWLcqUnsWsGGjlxdA13BxAB4NCenaMecu49v d3egCH547Bd94K/9wqqlDxl+aEe0Hh86Ig9t0LNBuruNh1hNKTG9OdohzJBuX1VD TcVYRv6S8wEwM2Gb24RL8wN359497vn58G3fAVxK7PiK/edqxlDTg+6oi6P0/L+x HLGFlSVL9bgtxpwAUVh3i9SRsnA6iS07qPmSHOXdoCz/OhoY29Lx7HLFRCOgUbJS XAo00HKWP+qB4myqt3Iir9QgtiFLFZiyBBn0HQQEWGeRsDpZTazH/EMZrbUPhP03 f9AiW/r7XX5fOoRG5HBv7i/eXdOw6XexVLEyXb57sEilNJfBF3ux2wDw/E34AiGT wUTkgY2VwjgaxNl022qsFYz6fboORwbQm0VyvWzxbKw7326pdt6Y3Q2WTvPEQ5Rk JvlVJ8McRzkrYU5hXjRW1D7/2rVmV8z+xGGi6IU1JoS3PBWIYMKjUDRlFg0n+JQG UzLnJcnxm/js8Ah4R8MWje1v4cq3TlKnc7WrMIwNtu3Wmvwjo34s4A84xdVPneY/ jIqgUGFBOeH/XnK+FAdU+ZFuUn4k/ttVNOuSrPe5HsZxc1uxGnec5OtuZB8FTjFH EH0rn+AxEiyaGPON+4w6 =GtY2 -----END PGP SIGNATURE-----

2 2

Re: [PATCH 5/6] ddraw: Return DDERR_NOTONMIPMAPSUBLEVEL for ddraw_surface7_SetColorKey() on mipmap sub levels.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4096 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH 4/5] devenum: Make CLSID_VideoCompressorCategory a special category.
by Alexandre Julliard 09 Jan '14

09 Jan '14

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/devenum/createdevenum.c | 1 + > 1 file changed, 1 insertion(+) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dxdiagn.dll -p dxdiagn_test.exe.so provider && touch provider.ok provider.c:84: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:88: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:125: Test failed: Expected IDxDiagProvider::Initialize to return S_OK, got 80070002 provider.c:128: Tests skipped: IDxDiagProvider::Initialize failed make: *** [provider.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32/tests: Add broken for a WSALookupServiceBegin test in NT
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4089 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (174): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:566: Test failed: oob_server (964): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 5/5] devenum: Added more strict CLSID_VideoCompressorCategory test.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4077 Your paranoid android. === w2008s64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found === w7pro64 (64 bit devenum) === devenum.c:124: Test failed: mrle codec not found devenum.c:124: Test failed: mrle codec not found

1 0

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Marvin 09 Jan '14

09 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4071 Your paranoid android. === w2008s64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002. === w7pro64 (64 bit ddraw7) === ddraw7.c:1621: Test failed: Failed to create surface, hr 0x80004002.

1 0

Re: [PATCH] oleaut32: Mask out certain features on array copy
by Dmitry Timoshkov 08 Jan '14

08 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +/* features listed here are not propagated to newly created array or data copy > + created with SafeArrayCopy()/SafeArrayCopyData() */ > +static const USHORT ignored_copy_features = > + FADF_AUTO | > + FADF_STATIC | > + FADF_EMBEDDED | > + FADF_FIXEDSIZE | > + FADF_CREATEVECTOR | > + FADF_DATADELETED; ... > - (*ppsaOut)->fFeatures = psa->fFeatures & ~FADF_CREATEVECTOR; > + (*ppsaOut)->fFeatures = psa->fFeatures & ~(FADF_CREATEVECTOR|ignored_copy_features); ignored_copy_features already includes FADF_CREATEVECTOR. > --- a/dlls/oleaut32/tests/safearray.c > +++ b/dlls/oleaut32/tests/safearray.c > @@ -57,6 +57,14 @@ static BOOL has_i8; > /* Has INT_PTR/UINT_PTR type? */ > static BOOL has_int_ptr; > > +static const USHORT ignored_copy_features[] = > + { > + FADF_AUTO, > + FADF_STATIC, > + FADF_EMBEDDED, > + FADF_FIXEDSIZE > + }; Tested and actually ignored flags do not match. Either the test is not complete or the ignored list includes too much. -- Dmitry.

2 1

Re: [PATCH 2/5] ddraw/tests: Add some color key tests for complex surfaces.
by Stefan Dösinger 08 Jan '14

08 Jan '14

Am 08.01.2014 um 10:56 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > + for (i = 0; i < 7; ++i) > + { > + hr = IDirectDrawSurface_GetAttachedSurface(mipmap, &caps, &tmp); > + ok(SUCCEEDED(hr), "Failed to get attached surface, i %u, hr %#x.\n", i, hr); > + hr = IDirectDrawSurface_GetColorKey(tmp, DDCKEY_SRCBLT, &color_key); > + ok(hr == DDERR_NOCOLORKEY, "Got unexpected hr %#x, i %u.\n", hr, i); > + IDirectDrawSurface_Release(mipmap); > + mipmap = tmp; > + } What is the 3D rendering and blitting behavior of the mipmap sublevels? Does an application have to set the color key on all surfaces to get proper color keying on a mipmapped texture, or do the sublevels use the color key from the root surface?

2 6

Re: dpnet: Add stubbed interface IDirectPlay8Server
by Michael Stefaniuc 08 Jan '14

08 Jan '14

Hello Alistair, On 01/08/2014 06:26 AM, Alistair Leslie-Hughes wrote: > Changelog: > dpnet: Add stubbed interface IDirectPlay8Server > diff --git a/dlls/dpnet/dpnet_private.h b/dlls/dpnet/dpnet_private.h > index 72012cd..5195d51 100644 > --- a/dlls/dpnet/dpnet_private.h > +++ b/dlls/dpnet/dpnet_private.h > @@ -37,6 +37,7 @@ typedef struct IDirectPlay8AddressImpl IDirectPlay8AddressImpl; > typedef struct IDirectPlay8LobbiedApplicationImpl IDirectPlay8LobbiedApplicationImpl; > typedef struct IDirectPlay8PeerImpl IDirectPlay8PeerImpl; > typedef struct IDirectPlay8ThreadPoolImpl IDirectPlay8ThreadPoolImpl; > +typedef struct IDirectPlay8ServerImpl IDirectPlay8ServerImpl; please add the struct directly to server.c as it is used only there. > +static ULONG WINAPI IDirectPlay8ServerImpl_AddRef(IDirectPlay8Server *iface) > +{ > + IDirectPlay8ServerImpl *This = impl_from_IDirectPlay8Server(iface); > + ULONG refCount = InterlockedIncrement(&This->ref); > + > + TRACE("(%p)->(ref before=%u)\n", This, refCount - 1); The standard to which Wine moves is to print the current refcount. See http://wiki.winehq.org/COMGuideline under "COM aggregation" for sample AddRef / Release functions. > +HRESULT DPNET_CreateDirectPlay8Server(LPCLASSFACTORY iface, LPUNKNOWN punkOuter, REFIID riid, LPVOID *ppobj) IClassFactory* and IUnknown* are much nicer. > +{ > + IDirectPlay8ServerImpl *server; > + > + TRACE("(%p, %s, %p)\n", punkOuter, debugstr_guid(riid), ppobj); > + > + server = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectPlay8ServerImpl)); > + if (!server) > + { > + *ppobj = NULL; > + return E_OUTOFMEMORY; > + } > + server->IDirectPlay8Server_iface.lpVtbl = &DirectPlay8ServerVtbl; > + server->ref = 1; > + > + *ppobj = (LPVOID*)&server->IDirectPlay8Server_iface; This will fail to fail for an unsupported riid. I have added the correct way to the COMGuideline wiki page. thanks bye michael

1 0

Re: dssenh/tests: Added Cylink Mek algorithm definition and crypto provider algorithm tests for dssenh.
by Alexandre Julliard 08 Jan '14

08 Jan '14

Marek Chmiel <kcmark(a)gmail.com> writes: > + while(GetLastError() != ERROR_NO_MORE_ITEMS) > + { > + SetLastError(0xdeadbeef); > + dataLen = sizeof(dataBuffer); > + > + result = CryptGetProvParam(hProv, PP_ENUMALGS_EX, dataBuffer, &dataLen, flag); > + ok(result || (!result && GetLastError() == ERROR_NO_MORE_ITEMS), > + "Failed to get parameter, got %x\n", GetLastError()); > + > + pointer = dataBuffer; > + algid = *(ALG_ID *)pointer; pointer += sizeof(ALG_ID); > + defaultLen = *(DWORD *)pointer; pointer += dwIncrement; It doesn't make sense to test last error before the first call, or to test the buffer contents on failure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Nikolay Sivov 08 Jan '14

08 Jan '14

On 1/8/2014 12:47, Zhenbo Li wrote: > try 3: > Add 'static' in my code > I forgot to call test_SHGetPathFromIDListA() in try2 > Check GetLastError() as well > try 2: > Move code to string.c to avoid creating a new file. > Avoid malloc() and free(). > > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/string.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > +static void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + ok(GetLastError() == ERROR_PROC_NOT_FOUND, > + "Bad GetLastError = %d\n", GetLastError()); > +} > + You need to set last error to something like 0xdeadbeef, your test suggest that this call doesn't set it. I guess you're trying to test return value only, but it could be interesting to test what happens to path buffer too. P.S. please avoid psz* style prefixes in names.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA (try 3)
by Marvin 08 Jan '14

08 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4066 Your paranoid android. === wxppro (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === wvista (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w2008s64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (32 bit string) === string.c:107: Test failed: Bad GetLastError = 1114 === w2008s64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 0 === w7pro64 (64 bit string) === string.c:107: Test failed: Bad GetLastError = 1114

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Dmitry Timoshkov 08 Jan '14

08 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + char pszPath[MAX_PATH]; > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > +} 1. the test should be 'static'. 2. who is supposed to call this test? 3. it would be ineteresting to see whether the tested API should set an error code or somehow indicate a reason of the failure. -- Dmitry.

2 1

WineHQ Downtime
by Jeremy Newman 07 Jan '14

07 Jan '14

Starting tomorrow at 10:00 CST we will be performing updates and maintenance to the WineHQ server. The service window should be around 2 hours at most. Various services will experience outages during this time frame. This will affect www.winehq.org, appdb.winehq.org, bugs.winehq.org, forum.winehq.org, source.winehq.org, mailing lists, and GIT. wiki.winehq.org will not be affected.

3 4

Re: [PATCH 1/5] wined3d: Check parameters directly in wined3d_surface_update_desc.
by Henri Verbeet 07 Jan '14

07 Jan '14

On 7 January 2014 13:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/surface.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 2fca299..9155c6b 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2810,15 +2810,17 @@ HRESULT CDECL wined3d_surface_update_desc(struct wined3d_surface *surface, > struct wined3d_device *device = surface->resource.device; > const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; > const struct wined3d_format *format = wined3d_get_format(gl_info, format_id); > - UINT resource_size = wined3d_format_calculate_size(format, device->surface_alignment, width, height, 1); > BOOL create_dib = FALSE; > HRESULT hr; > > TRACE("surface %p, width %u, height %u, format %s, multisample_type %#x, multisample_quality %u.\n", > surface, width, height, debug_d3dformat(format_id), multisample_type, multisample_type); > > - if (!resource_size) > + if (!width || !height || !format) That's not quite equivalent. For example, a format like WINED3DFMT_NVDB has a zero format->byte_count.

2 1

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Huw Davies 07 Jan '14

07 Jan '14

On Tue, Jan 07, 2014 at 02:33:32PM +0100, Ralf Habacker wrote: > @@ -1327,6 +1327,20 @@ BOOL WINAPI GetTextExtentExPointW( HDC hdc, LPCWSTR str, INT count, INT max_ext, > } > } > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } Does Windows really do this only in the same-scaled, non-sheared case? Huw.

1 0

Re: [2/4] gdi32: Fix text rotation problem in GM_ADVANCED graphics mode.
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 17:33, Ralf Habacker wrote: > This patch detects operational condition first and then removes > temporary rotation from the world transform. > Bug: http://bugs.winehq.org/show_bug.cgi?id=33190 > --- > dlls/gdi32/font.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > + XFORM old; > + BOOL exclude_rotation = FALSE; > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED ) > + { > + GetWorldTransform( hdc, &old ); > + XFORM xf = old; > + if ( hasRotatedAndSameScaledMatrixOnly( &xf ) ) > + { > + exclude_rotation = TRUE; > + removeRotationFromMatrix( &xf, NULL ); > + SetWorldTransform( hdc, &xf ); > + } > + } > + Flag really means do we need to restore transform or not. > + if ( GetGraphicsMode( hdc ) == GM_ADVANCED && exclude_rotation == TRUE ) > + { > + SetWorldTransform( hdc, &old ); > + } > + Doesn't look like you need to check a mode again.

1 0

Re: [1/4] gid32: Add matrix helper functions.
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 17:31, Ralf Habacker wrote: > Contains basic functions required by further patches > --- > dlls/gdi32/dibdrv/graphics.c | 49 > ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > That should be merged with a first patch that uses it. > +/* > + check matrix for condition > +*/ > +BOOL hasRotatedAndSameScaledMatrixOnly(XFORM *xform) > +{ > + return xform->eM11 == xform->eM22 && > + -xform->eM21 == xform->eM12; > +} > + Comment is telling nothing, 'xform' should be const probably. > + double determinant = 0; > + > + /* xform = xfrom-transposed * xform */ > + xform->eM11 = sqrt( xform->eM11 * xform->eM11 + xform->eM21 * xform->eM21 ); > + xform->eM22 = sqrt( xform->eM12 * xform->eM12 + xform->eM22 * xform->eM22 ); > + xform->eM12 = 0; > + xform->eM21 = 0; > + xform->eDx = 0; > + xform->eDy = 0; > + > + if ( rotation_and_translation == NULL ) > + return TRUE; > + > + determinant = xform->eM11 * xform->eM22; > + > + inverse_matrix_scale.eM11 = xform->eM22 / determinant; Is it possible to get 0 determinant here? Function never returns FALSE, so return value is useless. Also please follow function and variable naming conventions used in this file.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Nikolay Sivov 07 Jan '14

07 Jan '14

On 1/7/2014 16:08, Zhenbo Li wrote: > I'm working on Bug 33750, so I'll add test cases for > SHGetPathFromIDListA gradually. > --- > dlls/shell32/tests/pidl.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 dlls/shell32/tests/pidl.c > Please use some existing file. > +void test_SHGetPathFromIDListA(void) > +{ > + BOOL ret; > + LPCSTR pszPath; > + > + pszPath = malloc(MAX_PATH); > + > + ret = SHGetPathFromIDListA(NULL, pszPath); > + ok(!ret, "SHGetPathFromIDListA should fail.\n"); > + > + free((void *)pszPath); > +} > + You don't need to allocate it here, even if had to Heap* functions should be used.

1 0

Re: shell32/tests: Add test for SHGetPathFromIDListA
by Marvin 07 Jan '14

07 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4048 Your paranoid android. === wxppro (32 bit pidl) === No test summary line found === wvista (32 bit pidl) === No test summary line found === w2008s64 (32 bit pidl) === No test summary line found === w7pro64 (32 bit pidl) === No test summary line found === w2008s64 (64 bit pidl) === No test summary line found === w7pro64 (64 bit pidl) === No test summary line found

1 0

Re: user32/tests: Use BOOL type where appropriate
by Marvin 07 Jan '14

07 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4032 Your paranoid android. === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000800C4 fg 00030052 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00060106 fg 00010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 00000000 win.c:2951: Test failed: GetFocus() = 00000000 win.c:2974: Test failed: GetActiveWindow() = 00000000 win.c:2974: Test failed: GetFocus() = 00000000 win.c:3035: Test failed: GetActiveWindow() = 00000000 win.c:3035: Test failed: GetFocus() = 00000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2951: Test failed: GetActiveWindow() = 0000000000000000 win.c:2951: Test failed: GetFocus() = 0000000000000000 win.c:2974: Test failed: GetActiveWindow() = 0000000000000000 win.c:2974: Test failed: GetFocus() = 0000000000000000 win.c:3035: Test failed: GetActiveWindow() = 0000000000000000 win.c:3035: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/2] ws2_32/tests: Show that the last WSACleanup must destroy sockets
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4029 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4220C0

1 0

Re: [1/2] ws2_32/tests: Add some FIONREAD tests
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4028 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (4bc): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

[PATCH] Add support for GNU/Hurd
by Svante Signell 06 Jan '14

06 Jan '14

Hi, Currently wine-1.6.1 FTBFS on Debian GNU/Hurd, see https://buildd.debian.org/status/fetch.php?pkg=wine&arch=hurd-i386&ver=1.6.… Attached is a patch enabling the build: - dlls/ntdll/directory.c: Define a character array on the heap of size 4096 instead of using PATH_MAX, which is not defined for GNU/Hurd. This approach was used in dlls/ntdll/file.c:server_get_unix_name() where an array of size 1024 was defined. In case this solution is not OK, a fixed size array on the stack could be used, or as a last resort adding #ifndef PATH_MAX; #define PATH_MAX 4096 to that file (not recommended, at least from a GNU/Hurd aspect). - libs/wine/ldt.c: Add LDT support for GNU/Hurd - dlls/ntdll/signal_i386.c: Add i386 signal handling support for GNU/Hurd Applications tested so far (slow to start) include cmd, hostname, clock, winemine, wineconsole, notepad, wordpad and explorer. This patch is sent upstream on recommendation by the Debian Wine maintainers, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733605 Thanks!

3 7

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Aric Stewart 06 Jan '14

06 Jan '14

On 1/3/14, 10:08 AM, Jacek Caban wrote: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) > Also just so you are aware, all the strmbase stuff is based off actual microsoft strmbase stuff for directshow http://msdn.microsoft.com/en-us/library/windows/desktop/dd318897%28v=vs.85%… Not that this patch specifically breaks that, I have not dug that much, but just so that you are aware of the base for the implementation. -aric

2 1

Re: [1/7] gdi32: Relax vertical face requirements.
by Dmitry Timoshkov 06 Jan '14

06 Jan '14

Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2148,6 +2148,9 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ > #endif /* HAVE_CARBON_CARBON_H */ > > do { > + const DWORD DBCS_MASK = 0x3e0000; dlls/gdi32/font.c,GetFontLanguageInfo() defines DBCS_MASK as 0x3f0000, I'd guess that one of these places needs to be fixed. -- Dmitry.

2 1

Re: msvcp: Return if module is not loaded (Coverity)
by Piotr Caban 06 Jan '14

06 Jan '14

On 01/04/14 19:24, André Hentschel wrote: > 1147949 > --- > dlls/msvcp90/msvcp_main.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp_main.c b/dlls/msvcp90/msvcp_main.c > index 489aacb..d946f3b 100644 > --- a/dlls/msvcp90/msvcp_main.c > +++ b/dlls/msvcp90/msvcp_main.c > @@ -67,7 +67,14 @@ static void init_cxx_funcs(void) > { > HMODULE hmod = GetModuleHandleA( MSVCRT_NAME(_MSVCP_VER) ); > > - if (!hmod) FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + if (!hmod) > + { > + FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > + MSVCRT_operator_new = NULL; > + MSVCRT_operator_delete = NULL; > + MSVCRT_set_new_handler = NULL; > + return; > + } If we want to handle GetModuleHandle failure we should probably fail to load msvcpXX.dll (I'm not sure if it may ever happen unless we forget to import proper msvcrXX dll in makefile).

1 0

Re: ws2_32: Fix FreeBSD compiling issue on ipx address structure
by Francois Gouget 06 Jan '14

06 Jan '14

On Sun, 5 Jan 2014, Bruno Jesus wrote: > Manually tested on PC-BSD which also shows the issue. I think it would even work to compare sipx_network and sipx_node in one go. There is already code that copies them that way in ws_sockaddr_ws2u(): memcpy(&uipx->sipx_network,wsipx->sa_netnum,sizeof(uipx->sipx_network)+sizeof(uipx->sipx_node)); So we could do (compiles but not tested): diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 0391554..a92c5c3 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1473,7 +1473,10 @@ static BOOL is_sockaddr_bound(const struct sockaddr *uaddr, int uaddrlen) { static const struct sockaddr_ipx emptyAddr; struct sockaddr_ipx *ipx = (struct sockaddr_ipx*) uaddr; - return ipx->sipx_port || ipx->sipx_network || memcmp(&ipx->sipx_node, &emptyAddr.sipx_node, sizeof(emptyAddr.sipx_node)); + + /* compare sipx_network and sipx_node in one go to ease portability */ + return ipx->sipx_port || + memcmp(&ipx->sipx_network, &emptyAddr.sipx_network, sizeof(emptyAddr.sipx_network) + sizeof(emptyAddr.sipx_node)); } #endif case AF_INET6: But your patch works too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [PATCH] msvcp90: mark _invalid_parameter as noreturn (Coverity)
by Piotr Caban 06 Jan '14

06 Jan '14

On 01/04/14 18:25, Marcus Meissner wrote: > 1147947 Dereference after null check > > after not seeing that _invalid_parameter will not return, > so just mark the function as such, perhaps coverity then notices it. The function may return if application sets custom invalid parameter handler. I guess it shouldn't be marked as DECLSPEC_NORETURN. Probably all the places where it's used should be changed to return an error after calling _invalid_parameter.

1 0

Build fixes for wine-1.6.1 (FreeType2)
by David Naylor 06 Jan '14

06 Jan '14

Dear Wine-developers, On behalf of Gerald Pfeifer and the FreeBSD/Wine team I would like to report that wine-1.6.1 does not build against recent versions of FreeType2. This has been fixed in master in commit 67f9b6e3c5d2397446d39ab454f691c1ee46d2c0 by Alexandre Julliard. We would like to request this commit be back-ported to the stable branch. Regards, David P.S. I'm not on the mailing list, please CC me in related correspondence, thanks.

3 2

Re: Assorted spelling fixes
by Marvin 06 Jan '14

06 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4014 Your paranoid android. === wvista (32 bit render) === render.c:1276: Test failed: GetPosition failed: 00000001 === w7pro64 (64 bit render) === render.c:664: Test failed: Wait(event) after Stop gave 102

1 0

Re: DxDiag Demo Patch
by khuaja_lucky＠yahoo.com 05 Jan '14

05 Jan '14

Sent from my iPhone

1 0

Re: bcrypt: Added BCryptGenRandom stub
by Dmitry Timoshkov 05 Jan '14

05 Jan '14

Jascha Knack <jascha.knack(a)smail.inf.h-brs.de> wrote: > +NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE hAlgorithm, PUCHAR > pbBuffer, > + ULONG cbBuffer, ULONG dwFlags) > +{ > + FIXME("%08x, %08x, %08x, %08x - stub\n", hAlgorithm, pbBuffer, > cbBuffer, dwFlags); > + > + return ERROR_CALL_NOT_IMPLEMENTED; > +} If the API is supposed to return NTSTATUS it can't return a win32 error code. Also some of the printf format specifiers should be %p. P.S. Your mailer has mangled the patch. -- Dmitry.

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 4:33 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > What do you mean saying 'to group together' ? I mean typo fixes in dll_A and dll_B should be in the same patch. -- Frédéric Delanoy

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Bruno Jesus 04 Jan '14

04 Jan '14

On Sat, Jan 4, 2014 at 3:25 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Please ignore this patch, I didn't see Erich was trying to get in his interface change notifications patches. They are specially useful for a complete implementation of WSASLookupService*, when they get commited I'll be able to create a more complete test. Best wishes, Bruno

1 0

Re: d3d10core: Fix a typo
by Frédéric Delanoy 04 Jan '14

04 Jan '14

You'd probably want to group together all those typo/spelling patches. They aren't generally susceptible to breaking things. -- Frédéric Delanoy

1 0

Re: comctl32: Add opening and closing brackets and remove spaces
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > --- a/dlls/comctl32/animate.c > +++ b/dlls/comctl32/animate.c > @@ -499,7 +499,7 @@ static BOOL ANIMATE_GetAviInfo(ANIMATE_INFO *infoPtr) > > if ((ckMainRIFF.ckid != FOURCC_RIFF) || > (ckMainRIFF.fccType != mmioFOURCC('A', 'V', 'I', ' '))) { > - WARN("Can't find 'AVI ' chunk\n"); > + WARN("Can't find 'AVI' chunk\n"); This change is wrong. -- Dmitry.

1 0

Re: [7/7] gdi32: Improve vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3982 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [6/7] gdi32/tests: Add tests for vertical writing metrics.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3981 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [5/7] gdi32: Fix ABC metrics for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3980 Your paranoid android. === wxppro (32 bit font) === font.c:1329: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (32 bit font) === font.c:1330: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1330: Test failed: got 1, expected 0

1 0

Re: [4/7] gdi32/tests: Add more GetCharABCWidths tests for rotated font.
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3979 Your paranoid android. === wxppro (32 bit font) === font.c:1330: Test failed: got 8, expected 7 === wvista (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (32 bit font) === font.c:1331: Test failed: got 1, expected 0 === w2008s64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0 === w7pro64 (64 bit font) === font.c:1331: Test failed: got 1, expected 0

1 0

Re: [4/4] ws2_32/tests: Add some FIONREAD tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3976 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:3963: Test failed: FIONREAD should have returned 4 bytes, got 0 instead

1 0

Re: [3/4] ws2_32/tests: Add some WSALookupService[Begin|Next|End] tests
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3975 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 3)
by Dmitry Timoshkov 04 Jan '14

04 Jan '14

Zhenbo Li <litimetal(a)gmail.com> wrote: > + > + err = GetLastError(); > + ok ( handle != INVALID_HANDLE_VALUE, "FindFirstFile on %s failed\n", buffer2 ); > + ok ( !err , "FindFirstFile failed, Error number %d\n", err ); > + This block looks like an orphaned part of some removed test. -- Dmitry.

2 2

Question about test_RemoveDirectory()
by Zhenbo Li 04 Jan '14

04 Jan '14

Hello, I found that test_RemoveDirectory() is in dlls/kernel32/tests/file.c, while RemoveDirectoryA() and RemoveDirectoryW() are in dlls/kernel32/path.c I checked git log, and found that they came from commit ad9b79932410f7c, Reimplemented CreateDirectoryW and RemoveDirectoryW using ntdll functions. Should I move test_RemoveDirectory() to dlls/kernel32/tests/path.c? Thanks. -- Have a nice day! Zhenbo Li

1 0

Re: kernel32/tests: Add test for FindFirstFileA() (try 2)
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3973 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile failed, Error number 0

1 0

Re: ntdll/tests: Add test for deleting via NtOpenFile
by Marvin 04 Jan '14

04 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3962 Your paranoid android. === w7pro64 (32 bit file) === file.c:331: Test failed: open L"system32" failed c000003b file.c:338: Test failed: open L"SYSTEM32" failed c000003b file.c:346: Test failed: open L"\\SYSTEM32" failed c0000034 file.c:356: Test failed: open L"\\SYSTEM32" failed c000003b

2 1

Re: [PATCH 5/5] d3dx9_36/tests: Use NAN.
by Francois Gouget 03 Jan '14

03 Jan '14

On Thu, 2 Jan 2014, Stefan Dösinger wrote: [...] > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -4800,7 +4800,7 @@ static void test_create_skin_info(void) [...] > - exp_weights[1] = 0.0f / 0.0f; /* NAN */ > + exp_weights[1] = NAN; This patch breaks the compilation on Solaris because it does not define NAN (except in math_c99.h but we cannot use that, see below). But independently from that I think it's wrong because one should be able to compile the conformance tests on Windows. This means we cannot use things like config.h or port.h and should only use stuff that's defined in Windows headers. But as far as I can tell the Windows SDK does not define NAN. There is a definition of NAN in the CRT xmath.h header but Wine does not have that header and we're obviously not including it here. So one solution would be to revert the patch. Another would be to copy wine/port.h's __port_nan() definition. Yet another might be to add xmath.h and a dependency on msvcrt.dll. But maybe there's a better way still? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

2 2

Re: strmbase: Store BasePinFuncTable inside Base*PinFuncTable structs.
by Alexandre Julliard 03 Jan '14

03 Jan '14

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/amstream/mediastreamfilter.c | 15 +++++++-------- > dlls/qcap/avico.c | 32 ++++++++++++++------------------ > dlls/qcap/avimux.c | 32 ++++++++++++++------------------ > dlls/qcap/vfwcapture.c | 15 +++++++-------- > dlls/quartz/filesource.c | 15 +++++++-------- > dlls/quartz/parser.c | 15 +++++++-------- > dlls/strmbase/pin.c | 24 ++++++++++++------------ > dlls/strmbase/renderer.c | 17 ++++++++--------- > dlls/strmbase/transform.c | 30 ++++++++++++++---------------- > include/wine/strmbase.h | 7 +++++-- > 10 files changed, 95 insertions(+), 107 deletions(-) There are other users, like winegstreamer and wineqtdecoder. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Add test for FindFirstFileA()
by Marvin 03 Jan '14

03 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3963 Your paranoid android. === wxppro (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooD.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === wvista (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooFB6A.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w2008s64 (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo9FA.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w7pro64 (32 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo580A.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w2008s64 (64 bit file) === file.c:2452: Test failed: FindFirstFile on C:\foo93F.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267 === w7pro64 (64 bit file) === file.c:2452: Test failed: FindFirstFile on C:\fooF4B6.tmp should Fail file.c:2453: Test failed: Bad Error number 0 file.c:2459: Test failed: Bad Error number 267

1 0

Re: [PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection (try2)
by Dmitry Timoshkov 03 Jan '14

03 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static inline ULONG get_refcount(IUnknown *iface) > +{ > + ULONG ref = IUnknown_AddRef(iface); > + IUnknown_Release(iface); > + return ref-1; > +} This one still looks somewhat strange. Why not do something more straightforward like the following one? static inline ULONG get_refcount(IUnknown *iface) { IUnknown_AddRef(iface); return IUnknown_Release(iface); } -- Dmitry.

1 0

Re: [PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection
by Dmitry Timoshkov 03 Jan '14

03 Jan '14

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +static inline ULONG get_refcount(IUnknown *iface) > +{ > + ULONG ref = IUnknown_AddRef(iface); > + IUnknown_Release(iface); > + return ref; > +} This implementation may lead to wrong conclusions. -- Dmitry.

2 3

How to bisect the 1.6.x series of commits
by Alan W. Irwin 03 Jan '14

03 Jan '14

I have bisected Wine regressions several times in the last year following the cookbook in http://wiki.winehq.org/RegressionTesting. Those bisections were for the principal branch (or whatever you call it) of development. How do you do similar bisections for the branch of development from 1.6 to 1.6.1? I need the name of that branch of development and how you specify it to the bisect process. Sorry for the git newbie question, but following the above cookbook has been essentially my only git experience to date. The reason I am asking about bisecting from 1.6 to 1.6.1 is I have recently found some fairly strong evidence that there is an important regression in behavior between 1.6-rc4 and 1.6.1. I have used Wine 1.6-rc4 with a lot of success as a test platform for MinGW/MSYS PLplot builds and tests, but when I recently tried 1.6.1, my usual parallel tests of PLplot software failed with an error indicating plot devices (small dll's) cannot be dynamically loaded by the PLplot principal library for that version of Wine. (The problem disappears if I do the tests sequentially for 1.6.1, but I obviously want to avoid that method of testing because it doubles the test time for my two-cpu PC.) The tests of 1.6-rc4 and 1.6.1 were quite similar but not absolutely identical so I do have to confirm the regression in behaviour for 1.6.1 with absolutely identical tests. But assuming I can do that, then I still have to discover if the problem occurred for 1.6. If so, the bisection needs to be an ordinary principal branch one that I am already familiar with between 1.6-rc4 and 1.6, but if not it needs to follow the 1.6.x development branch between 1.6 an 1.6.1. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

4 4

Re: advapi32/tests: Use BOOL type where appropriate
by Dmitry Timoshkov 03 Jan '14

03 Jan '14

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c > index 9f1e611..232a729 100644 > --- a/dlls/advapi32/tests/security.c > +++ b/dlls/advapi32/tests/security.c > @@ -4526,13 +4526,14 @@ static void test_mutex_security(HANDLE token) > STANDARD_RIGHTS_ALL | MUTEX_ALL_ACCESS }; > static const struct > { > - int todo, generic, mapped; > + BOOL todo; > + int generic, mapped; > } map[] = > { > - { 1, GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE }, > - { 0, GENERIC_WRITE, STANDARD_RIGHTS_WRITE }, > - { 0, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE }, > - { 0, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE } > + { TRUE, GENERIC_READ, STANDARD_RIGHTS_READ | MUTANT_QUERY_STATE }, > + { FALSE, GENERIC_WRITE, STANDARD_RIGHTS_WRITE }, > + { FALSE, GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SYNCHRONIZE }, > + { FALSE, GENERIC_ALL, STANDARD_RIGHTS_ALL | MUTANT_QUERY_STATE } > }; Please don't touch these tests, 'int' is intentionally used here, and 'BOOL' buys you nothing. It's better to actually fix the source of these todos and remove them altogether. -- Dmitry.

1 0

Re: ddraw/tests: Use BOOL type where appropriate
by Marvin 03 Jan '14

03 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3950 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH] ntdll: Improve handling of THUMB_MOV32 relocations
by André Hentschel 02 Jan '14

02 Jan '14

Am 02.01.2014 17:01, schrieb Martin Storsjo: > Since the delta variable actually is signed, the delta > 0xffff > condition could be false even if the high part of the delta > was nonzero, ending up with not updating the high half of the > relocation at all. > > Additionally, carry any overflow from the low word into the > high word delta. Hi, Do you have an App that triggers that? So you mean the case when the sign bit is used, e.g. 10101010b... Then the delta is negative, but is everything set correctly in the instruction? > --- > dlls/ntdll/loader.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index e0907e7..1f13424 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -2230,19 +2230,19 @@ IMAGE_BASE_RELOCATION * WINAPI LdrProcessRelocationBlock( void *page, UINT count > DWORD inst = *(INT_PTR *)((char *)page + offset); > DWORD imm16 = ((inst << 1) & 0x0800) + ((inst << 12) & 0xf000) + > ((inst >> 20) & 0x0700) + ((inst >> 16) & 0x00ff); > + int hi_delta; Why you're using int here? DWORD looks much better for this.

2 2

Re: msvcp80: Fix ostreambuf_iterator<char> structure definition
by Alexandre Julliard 02 Jan '14

02 Jan '14

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcp90/ios.c | 88 > +++++++++++++++++++++++++++++++++++++------------- > dlls/msvcp90/msvcp90.h | 6 ++++ > 2 files changed, 72 insertions(+), 22 deletions(-) It breaks the Mingw build: locale.o:locale.c:(.text+0x94c): undefined reference to `_num_put_char_do_put_long@28' locale.o:locale.c:(.text+0x954): undefined reference to `_num_put_char_put_long@28' locale.o:locale.c:(.text+0x95c): undefined reference to `_num_put_char_do_put_ulong@28' locale.o:locale.c:(.text+0x964): undefined reference to `_num_put_char_put_ulong@28' locale.o:locale.c:(.text+0x96c): undefined reference to `_num_put_char_do_put_double@32' locale.o:locale.c:(.text+0x974): undefined reference to `_num_put_char_put_double@32' locale.o:locale.c:(.text+0x97c): undefined reference to `_num_put_char_put_ldouble@32' locale.o:locale.c:(.text+0x984): undefined reference to `_num_put_char_do_put_ptr@28' locale.o:locale.c:(.text+0x98c): undefined reference to `_num_put_char_put_ptr@28' locale.o:locale.c:(.text+0x994): undefined reference to `_num_put_char_do_put_int64@32' locale.o:locale.c:(.text+0x99c): undefined reference to `_num_put_char_put_int64@32' locale.o:locale.c:(.text+0x9a4): undefined reference to `_num_put_char_do_put_uint64@32' locale.o:locale.c:(.text+0x9ac): undefined reference to `_num_put_char_put_uint64@32' locale.o:locale.c:(.text+0x9b4): undefined reference to `_num_put_char_do_put_bool@28' locale.o:locale.c:(.text+0x9bc): undefined reference to `_num_put_char_put_bool@28' locale.o:locale.c:(.text+0xa0c): undefined reference to `_num_put_wchar_do_put_long@28' locale.o:locale.c:(.text+0xa14): undefined reference to `_num_put_short_do_put_long@28' locale.o:locale.c:(.text+0xa1c): undefined reference to `_num_put_wchar_put_long@28' locale.o:locale.c:(.text+0xa24): undefined reference to `_num_put_wchar_do_put_ulong@28' locale.o:locale.c:(.text+0xa2c): undefined reference to `_num_put_short_do_put_ulong@28' locale.o:locale.c:(.text+0xa34): undefined reference to `_num_put_wchar_put_ulong@28' locale.o:locale.c:(.text+0xa3c): undefined reference to `_num_put_wchar_do_put_double@32' locale.o:locale.c:(.text+0xa44): undefined reference to `_num_put_short_do_put_double@32' locale.o:locale.c:(.text+0xa4c): undefined reference to `_num_put_wchar_put_double@32' locale.o:locale.c:(.text+0xa54): undefined reference to `_num_put_wchar_put_ldouble@32' locale.o:locale.c:(.text+0xa5c): undefined reference to `_num_put_wchar_do_put_ptr@28' locale.o:locale.c:(.text+0xa64): undefined reference to `_num_put_short_do_put_ptr@28' locale.o:locale.c:(.text+0xa6c): undefined reference to `_num_put_wchar_put_ptr@28' locale.o:locale.c:(.text+0xa74): undefined reference to `_num_put_wchar_do_put_int64@32' locale.o:locale.c:(.text+0xa7c): undefined reference to `_num_put_short_do_put_int64@32' locale.o:locale.c:(.text+0xa84): undefined reference to `_num_put_wchar_put_int64@32' locale.o:locale.c:(.text+0xa8c): undefined reference to `_num_put_wchar_do_put_uint64@32' locale.o:locale.c:(.text+0xa94): undefined reference to `_num_put_short_do_put_uint64@32' locale.o:locale.c:(.text+0xa9c): undefined reference to `_num_put_wchar_put_uint64@32' locale.o:locale.c:(.text+0xaa4): undefined reference to `_num_put_wchar_do_put_bool@28' locale.o:locale.c:(.text+0xaac): undefined reference to `_num_put_short_do_put_bool@28' locale.o:locale.c:(.text+0xab4): undefined reference to `_num_put_wchar_put_bool@28' locale.o:locale.c:(.text+0xaec): undefined reference to `_time_put_char_do_put@36' locale.o:locale.c:(.text+0xaf4): undefined reference to `_time_put_char_put@36' locale.o:locale.c:(.text+0xafc): undefined reference to `_time_put_char_put_format@36' locale.o:locale.c:(.text+0xb5c): undefined reference to `_time_put_wchar_do_put@36' locale.o:locale.c:(.text+0xb64): undefined reference to `_time_put_wchar_put@36' locale.o:locale.c:(.text+0xb6c): undefined reference to `_time_put_wchar_put_format@36' collect2: ld returned 1 exit status -- Alexandre Julliard julliard(a)winehq.org

1 0

testbot problem
by Stefan Leichter 02 Jan '14

02 Jan '14

Hello, i'm trying to understand why job 27632 did not build on the testbot. It builds fine for Linux 32/64 bit and Windows (make crosstest) on my computer. From the build log it looks like a problem inside the Makefile (make: Nothing to be done for `all'.). Is there a way to access the Makefile after the job is finished? Regards Stefan

1 0

Better managing icons files names
by Pedro Henrique Lara Campos 02 Jan '14

02 Jan '14

Can Wine or could it in newer versions, use a prefix for their icons, like wine_56BA_Tcharam.png, or maybe their own folder? My ~/.local/share/icons is like... full of bottles, every corner I look, I find an icon from wine :P

3 2

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Marvin 01 Jan '14

01 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3919 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

Re: [PATCH 12/21] kernel32: conditional variable support (try 6)
by Marcus Meissner 01 Jan '14

01 Jan '14

Hmm, THis should have been patch 0021 instead of 0012 , please disregard. Ciao, Marcus On Wed, Jan 01, 2014 at 07:44:16PM +0100, Marcus Meissner wrote: > Hi, > > Additional tightening and cleaning of comments. > > After Alexandres last guidance ("no global allocation") > and some hours of hair pulling I now did a implementation > with just a linked list of waiters. > > variable->Ptr points to the head of this list. > > The bit 0 of variable->Ptr is used for atomic locking of > the list and also its content, avoiding need for a lock variable. > > Small issues: > We are busy waiting on the bit 0 lock, not the most performance > wise best thing. > > Ciao, Marcus > --- > dlls/kernel32/kernel32.spec | 4 ++ > dlls/kernel32/sync.c | 151 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 155 insertions(+) > > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 7779a75..e8d2bf0 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -750,6 +750,7 @@ > @ stdcall InitOnceComplete(ptr long ptr) > @ stdcall InitOnceExecuteOnce(ptr ptr ptr ptr) > @ stdcall InitOnceInitialize(ptr) ntdll.RtlRunOnceInitialize > +@ stdcall InitializeConditionVariable(ptr) > @ stdcall InitializeCriticalSection(ptr) > @ stdcall InitializeCriticalSectionAndSpinCount(ptr long) > @ stdcall InitializeCriticalSectionEx(ptr long long) > @@ -1194,6 +1195,7 @@ > @ stdcall SignalObjectAndWait(long long long long) > @ stdcall SizeofResource(long long) > @ stdcall Sleep(long) > +@ stdcall SleepConditionVariableCS(ptr ptr long) > @ stdcall SleepEx(long long) > @ stdcall SuspendThread(long) > @ stdcall SwitchToFiber(ptr) > @@ -1263,6 +1265,8 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stdcall WakeAllConditionVariable (ptr) > +@ stdcall WakeConditionVariable (ptr) > @ stdcall WerRegisterFile(wstr long long) > @ stdcall WerRegisterMemoryBlock(ptr long) > @ stdcall WerRegisterRuntimeExceptionModule(wstr ptr) > diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c > index 3c9e42a..34f39cd 100644 > --- a/dlls/kernel32/sync.c > +++ b/dlls/kernel32/sync.c > @@ -2327,3 +2327,154 @@ __ASM_STDCALL_FUNC(InterlockedDecrement, 4, > "ret $4") > > #endif /* __i386__ */ > + > +/* See http://locklessinc.com/articles/mutex_cv_futex/ for a futex implementation > + * See http://www.cs.wustl.edu/~schmidt/win32-cv-1.html for various implementations > + * of pthread_cond_* with Win32 primitives. > + * See glibc/nptl/DESIGN-condvar.txt for the glibc implementation > + * > + * This implementation uses a linked list as waiter queue, and the list > + * and its content is locked for access via bit 0 of variable->Ptr. > + * The actual waiting is done using a Win32 Event. > + */ > + > +struct _condvar_intern { > + struct _condvar_intern *next; > + HANDLE event; > +}; > + > +/********************************************************************** > + * InitializeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + variable->Ptr = NULL; > +} > + > +/* > + * We lock the condition variable by setting bit 0 in variable->Ptr > + * atomically. We busy loop until we succeed and return the current value. > + * We also lock the empty list (NULL). > + * > + * List unlocking is done with "variable->Ptr = <retvalue>" > + */ > +static struct _condvar_intern* > +_lock_list (PCONDITION_VARIABLE variable) { > + struct _condvar_intern *oldvar, *var; > + > + do { > + __asm__ __volatile__("":::"memory"); > + var = variable->Ptr; > + if ((DWORD_PTR)var & 1) continue; /* locked already, retry. */ > + > + oldvar = InterlockedCompareExchangePointer (&variable->Ptr, (void*)((DWORD_PTR)var|1), var); > + if (oldvar == var) > + break; > + /* failed atomic locking, retry. */ > + } while (1); > + return var; > +} > + > +/********************************************************************** > + * WakeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI WakeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condvar_intern *var; > + > + if (!variable->Ptr) > + return; > + > + var = _lock_list (variable); > + if (!var) { > + variable->Ptr = NULL; > + return; > + } > + > + /* remove and wake up the first entry */ > + NtSetEvent (var->event, NULL); > + > + variable->Ptr = var->next; > +} > + > +/********************************************************************** > + * WakeAllConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI WakeAllConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condvar_intern *var; > + > + if (!variable->Ptr) > + return; > + > + var = _lock_list (variable); > + > + /* dequeue the whole waiter chain and wake it up */ > + while (var) { > + NtSetEvent (var->event, NULL); > + var = var->next; > + } > + > + variable->Ptr = NULL; > +} > + > +/********************************************************************** > + * SleepConditionVariableCS (KERNEL32.@) > + */ > +BOOL WINAPI SleepConditionVariableCS(PCONDITION_VARIABLE variable, > + LPCRITICAL_SECTION crit, DWORD timeout > +) > +{ > + struct _condvar_intern myself; > + struct _condvar_intern **xvar, *var; > + BOOL ret = TRUE; > + OBJECT_ATTRIBUTES attr; > + DWORD res; > + > + attr.Length = sizeof(attr); > + attr.RootDirectory = 0; > + attr.Attributes = OBJ_INHERIT; > + attr.ObjectName = NULL; > + attr.SecurityDescriptor = NULL; > + attr.SecurityQualityOfService = NULL; > + > + NtCreateEvent (&myself.event, EVENT_ALL_ACCESS, &attr, NotificationEvent, 0); > + myself.next = NULL; > + > + var = _lock_list (variable); > + /* Attach our stack based struct to the end of the list. > + * (at the end for fairness) > + */ > + xvar = &var; > + while (*xvar) > + xvar = &(*xvar)->next; > + *xvar = &myself; > + variable->Ptr = var; > + > + RtlLeaveCriticalSection(crit); > + > + res = WaitForSingleObject(myself.event, timeout); > + > + var = _lock_list (variable); > + > + /* Remove our entry */ > + xvar = (struct _condvar_intern **)&var; > + while (*xvar) { > + if (*xvar == &myself) { > + *xvar = (*xvar)->next; > + break; > + } > + xvar = &(*xvar)->next; > + } > + variable->Ptr = var; > + > + CloseHandle (myself.event); > + RtlEnterCriticalSection(crit); > + > + if (res == WAIT_TIMEOUT) { > + ret = FALSE; > + /* expected from caller, but not set by WaitForSingleObject */ > + SetLastError(ERROR_TIMEOUT); > + } > + return ret; > +} > -- > 1.7.10.4 > > > >

1 0

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Nikolay Sivov 01 Jan '14

01 Jan '14

On 1/1/2014 22:15, Marcus Meissner wrote: > 1127305 Double free > --- > dlls/msxml3/tests/domdoc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index df11197..f653a8b 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -11047,7 +11047,6 @@ static void test_xmlns_attribute(void) > ok( hr == S_OK, "got 0x%08x\n", hr); > todo_wine ok( lstrcmpW(str, _bstr_("<Testing xmlns:dt=\"urn:schemas-microsoft-com:datatypes\" dt:dt=\"bin.base64\"/>")) == 0, > "got %s\n", wine_dbgstr_w(str)); > - SysFreeString(str); This is a correct fix technically, but it's better to remove second SysFreeString(), not this one. Speaking of style, I'd probably remove all 'if (hr == S_OK)' check, it never fails, or reduced a scope of 'str'.

1 0

Re: [PATCH] msxml3: avoid double free of str (Coverity)
by Marvin 01 Jan '14

01 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3918 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

about eventlog
by Akira Nakagawa 01 Jan '14

01 Jan '14

I examined the design of RegistereventSource(). The return value type is HANDLE,but the details of it is unknown. However,I suppose,the code should be like this(I'm not good at coding of Win32) /****************************************************************************** * RegisterEventSourceW [ADVAPI32.@] * * See RegisterEventSourceA. */ HANDLE WINAPI RegisterEventSourceW( LPCWSTR lpUNCServerName, LPCWSTR lpSourceName ) { int arg_length,path_length; LPDWORD existance; LPWSTR reg_fullpath; LPWSTR filename; LPDWORD lptype; LPWSTR lpdata,gldata; HKEY hkeyp; HANDLE eventhandle; int number_of_entry,length_of_dat; FIXME("(%s,%s): stub\n", debugstr_w(lpUNCServerName), debugstr_w(lpSourceName)); if(lpUNCServerName!=NULL) { FIXME("lpUNCServerName:%s\nExecution in another server is not suppported.", debugstr_w(lpUNCServerName)); } else { existance = NULL; number_of_entry = 0; length_of_dat = 0; filename = (LPWSTR)"Application";//FIXME:this should be all of sub keies. reg_fullpath = lstrcatW((LPWSTR)"System\\CurrentControlSet\\Sevices\\Eventlog\\Application\\",lpSourceName); arg_length = lstrlenW(lpSourceName); RegCreateKeyExW(HKEY_LOCAL_MACHINE,reg_fullpath,0, NULL,REG_OPTION_NON_VOLATILE,KEY_READ,NULL,&hkeyp,existance);//Create or open key. RegQueryInfoKeyW(hkeyp,NULL,0,NULL,NULL,NULL,NULL, (LPDWORD)number_of_entry,NULL,(LPDWORD)length_of_dat,NULL,NULL); if(length_of_dat<2 || number_of_entry<2)//Key entry is void. return NULL; *lptype=(REG_SZ); RegQueryValueExW(hkeyp,(LPWSTR)"EventMessageFile",NULL,lptype,(LPBYTE)lpdata,(LPDWORD)path_length); RegCloseKey(hkeyp); eventhandle = GlobalAlloc(GHND,(arg_length+path_length)*sizeof(LPWSTR)); gldata=(LPWSTR)GlobalLock(eventhandle); //After that,store data follows:filename,file path,source name;I do not know how to. if(eventhandle==INVALID_HANDLE_VALUE) { ERR_(eventlog)("%s\n", debugstr_w(lpUNCServerName)); return NULL; } } return eventhandle; }

1 0

Re: [PATCH 3/3] ws2_32: Add an interactive test for interface change notifications (rebased).
by Marvin 01 Jan '14

01 Jan '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3915 Your paranoid android. === wxppro (32 bit sock) === sock.c:554: Test failed: oob_server (5a8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock.c:554: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:554: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9CD9

1 0

Re: winex11: Implement X11DRV_FLUSH_GDI_DISPLAY ExtEscape command
by Alexandre Julliard 31 Dec '13

31 Dec '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > This patch implements an additional ExtEscape command > X11DRV_FLUSH_GDI_DISPLAY, which can be used by external applications in > order to flush all drawing operations to the Xserver. > > This patch is necessary for a new feature of Pipelight: In NPAPI > windowlessmode the browser provides an X11 drawable, and expects the > plugin (= the wine application) to draw on it. The current > implementation uses CreateDCA() to create a new hDC and then > X11DRV_SET_DRAWABLE to draw on an arbitrary X11 drawable. The additional > command implemented in this patch is required to ensure that the drawing > is finished before the PAINT event returns. Normally an XSync would be > even better, but a lot of testing shows that XFlush is also sufficient > (and faster), thats why we decided to use this approach. You should call MsgWaitForMultipleObjects or some similar function instead of adding private escapes. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] ntdll: Dynamically grow buffer in read_changes_apc
by Alexandre Julliard 31 Dec '13

31 Dec '13

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/ntdll/directory.c | 35 +++++++++++++++++++++++++++-------- > 1 file changed, 27 insertions(+), 8 deletions(-) You can't allocate memory inside an APC callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Status of WineD3D on Windows
by Peter Lehmkuhle 31 Dec '13

31 Dec '13

Hi all, I'm not sure if this is the right list for this question, but I guess I'll find out soon. :) On http://wiki.winehq.org/WineD3DOnWindows it is written that "DirectDraw [..] can't be used at this point due to a conflict with opengl32.dll." I guess that's the current status, because the ddraw.dll is not included in the last build. Are there any plans to change this in the near future? TIA for an answer. Best regards, Peter

2 1

Re: [PATCH 1/4] ole32: Fix parameter validation for CreateClassMoniker()
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3908 Your paranoid android. === wvista (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 00424509 === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000041F2CA === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 000000000041F2CA

1 0

Re: kernel32/tests: Add test for FindFirstFileA
by Zhenbo Li 31 Dec '13

31 Dec '13

2013/12/30 Zhenbo Li <litimetal(a)gmail.com>: > As MSDN[1] mentioned, "This parameter should not ... end in a trailing > backslash (\)." So I think I should add this test case. > > [1]: > http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418%28v=vs.85%… > --- > dlls/kernel32/tests/file.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Sorry, I made a mistake while reading the previous code. Please reject this patch, and I'll send another patch later. Sorry for this inconvenience.

1 0

Re: winhttp/tests: Constify a character string
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3905 Your paranoid android. === w7pro64 (32 bit winhttp) === winhttp.c:859: Test failed: failed to send request 12175

1 0

Re: [4/4] ws2_32: Cope with invalid hints in getaddrinfo/GetAddrInfoW
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3900 Your paranoid android. === wxppro (32 bit sock) === sock.c:554: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 === wvista (32 bit sock) === sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost === w2008s64 (32 bit sock) === sock.c:554: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost === w2008s64 (64 bit sock) === sock.c:554: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost sock: unhandled exception c0000005 at 000007FEFE4C9CD9 === w7pro64 (64 bit sock) === sock.c:554: Test failed: oob_server (980): unexpectedly at the OOB mark: 0 sock.c:5410: Test failed: test 0: expected one result when hints are used for localhost sock.c:5410: Test failed: test 1: expected one result when hints are used for localhost sock.c:5410: Test failed: test 2: expected one result when hints are used for localhost sock.c:5410: Test failed: test 3: expected one result when hints are used for localhost sock.c:5410: Test failed: test 8: expected one result when hints are used for localhost sock.c:5410: Test failed: test 9: expected one result when hints are used for localhost sock.c:5410: Test failed: test 10: expected one result when hints are used for localhost sock.c:5410: Test failed: test 11: expected one result when hints are used for localhost sock.c:5410: Test failed: test 20: expected one result when hints are used for localhost sock.c:5410: Test failed: test 21: expected one result when hints are used for localhost sock.c:5518: Test failed: test 0: expected one result when hints are used for localhost sock.c:5518: Test failed: test 1: expected one result when hints are used for localhost sock.c:5518: Test failed: test 2: expected one result when hints are used for localhost sock.c:5518: Test failed: test 3: expected one result when hints are used for localhost sock.c:5518: Test failed: test 8: expected one result when hints are used for localhost sock.c:5518: Test failed: test 9: expected one result when hints are used for localhost sock.c:5518: Test failed: test 10: expected one result when hints are used for localhost sock.c:5518: Test failed: test 11: expected one result when hints are used for localhost sock.c:5518: Test failed: test 20: expected one result when hints are used for localhost sock.c:5518: Test failed: test 21: expected one result when hints are used for localhost

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support (try 2, resend)
by Marvin 31 Dec '13

31 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3899 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 1/6] qcap: Added IPersistPropertyBag::Load implementation.
by Marvin 30 Dec '13

30 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3892 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: msrle32: Added tests.
by Marvin 30 Dec '13

30 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3886 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Win32_PnPEntity WMI class
by Luke A. Guest 29 Dec '13

29 Dec '13

Hi, Is anybody working on this at the moment? I need this working for bug 35224. If not, what do I need to be looking at to get this to work? I know nothing about this API tbh. Thanks, Luke.

1 1

Help about implementing WSACleanup (ws2_32)
by Bruno Jesus 29 Dec '13

29 Dec '13

Hi, in an attempt to fix bugs 18670 and 26031 I would like to try implementing WSACleanup more properly. My limited knowledge in the interactions between the ws2_32 dll and wine server makes me think this is easy. The idea is to add the created socket in WSASocketW in a list and remove it from the list when closesocket is called. When the last WSACleanup is called it would iterate through the socket list and destroy the remaining sockets. When WSASocketW is called it calls the server to create the socket, when closesocket is called the server is also called and the function sock_destroy takes care of shutting down the socket. Currently I'm thinking about doing this in the dll side because the server is not aware of WSACleanup, but maybe it should because it needs to avoid calling any async operation completion. My questions are: 1) When I open 2 programs that use ws2_32 dll the global variables memory is not shared, right? Otherwise the WSAStartup/Cleanup count could be messed up if one application didn't call the Cleanup function. I hope this true so the socket list would not have to take care of different processes id. I understand that one application can have multiple threads and that's what the struct per_thread_data is about, but I hope the dll is not shared among different processes. 2) Is this a reasonable approach? If yes, is there any example of a critical protected list (add, iterate, remove items) that I could use? Best wishes, Bruno

1 0

Re: [PATCH 2/2] dmusic/tests: Add some COM tests for IDirectMusic/IDirectMusicCollection
by Marvin 28 Dec '13

28 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3877 Your paranoid android. === w2008s64 (32 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 00401FDE === w2008s64 (64 bit dmusic) === dmusic.c:244: Test failed: DirectMusic8 create failed: 80040154, expected CLASS_E_NOAGGREGATION dmusic.c:251: Test failed: DirectMusic8 create failed: 80040154, expected E_NOINTERFACE dmusic.c:256: Test failed: DirectMusic8 create failed: 80040154, expected S_OK dmusic: unhandled exception c0000005 at 0000000000401EC2

1 0

Re: qedit/tests: Constify some character strings
by Marvin 28 Dec '13

28 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3869 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 0040185A === w2008s64 (64 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017C3

1 0

Re: wtsapi32: partial implementation of WTSEnumerateProcessesW (resend)
by André Hentschel 28 Dec '13

28 Dec '13

> diff --git a/dlls/wtsapi32/wtsapi32.c b/dlls/wtsapi32/wtsapi32.c > index 898b95d..53c6325 100644 > --- a/dlls/wtsapi32/wtsapi32.c > +++ b/dlls/wtsapi32/wtsapi32.c > @@ -18,9 +18,13 @@ > #include "config.h" > #include <stdarg.h> > #include <stdlib.h> > -#include "windef.h" > -#include "winbase.h" > +#include "ntstatus.h" > +#define WIN32_NO_STATUS > +#include "winternl.h" > #include "wtsapi32.h" > +#include "wine/library.h" > +#include "wine/server.h" > +#include "wine/unicode.h" > #include "wine/debug.h" do you need that all? > WINE_DEFAULT_DEBUG_CHANNEL(wtsapi); > @@ -84,14 +88,65 @@ BOOL WINAPI WTSEnumerateProcessesA(HANDLE hServer, DWORD Reserved, DWORD Version > BOOL WINAPI WTSEnumerateProcessesW(HANDLE hServer, DWORD Reserved, DWORD Version, > PWTS_PROCESS_INFOW* ppProcessInfo, DWORD* pCount) > { > - FIXME("Stub %p 0x%08x 0x%08x %p %p\n", hServer, Reserved, Version, > - ppProcessInfo, pCount); > + SYSTEM_PROCESS_INFORMATION *spi; > + ULONG size = 0x4000; > + void *buf = NULL; > + NTSTATUS status; > + DWORD i,lcount = 0; > + WTS_PROCESS_INFOW *linfo; can't you use sizeof(*spi) or a multiple of it for size? or clean it up somehow else... > if (!ppProcessInfo || !pCount) return FALSE; > > *pCount = 0; > *ppProcessInfo = NULL; > > + if (hServer != WTS_CURRENT_SERVER_HANDLE) > + { > + FIXME("Only WTS_CURRENT_SERVER_HANDLE is impemented\n"); > + return FALSE; > + } > + > + do { > + size *= 2; > + HeapFree(GetProcessHeap(), 0, buf); > + buf = HeapAlloc(GetProcessHeap(), 0, size); > + if (!buf) > + return FALSE; > + > + status = NtQuerySystemInformation(SystemProcessInformation, buf, size, NULL); > + } while(status == STATUS_INFO_LENGTH_MISMATCH); > + > + if (status != STATUS_SUCCESS) > + { > + HeapFree(GetProcessHeap(), 0, buf); > + SetLastError(RtlNtStatusToDosError(status)); > + return FALSE; > + } > + > + spi = buf; why not dropping buf completely? > + do { > + lcount++; > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); > + } while(spi->NextEntryOffset != 0); isn't there an easier way to get the count? > + linfo = HeapAlloc(GetProcessHeap(), 0, lcount * sizeof(WTS_PROCESS_INFOW)); > + if(!linfo) > + return FALSE; > + > + for(i = 0, spi = buf; i < lcount; i++) > + { > + linfo[i].SessionId = 0; > + linfo[i].ProcessId = HandleToUlong(spi->UniqueProcessId); > + linfo[i].pProcessName = spi->ProcessName.Buffer; > + linfo[i].pUserSid = NULL; > + spi = (SYSTEM_PROCESS_INFORMATION *)(((PCHAR)spi) + spi->NextEntryOffset); > + } > + *ppProcessInfo = linfo; > + *pCount = lcount; > + FIXME("pUserSid not filled\n"); > + > + HeapFree(GetProcessHeap(), 0, buf); > return TRUE; > } > > diff --git a/include/wtsapi32.h b/include/wtsapi32.h > index f4bab56..0476478 100644 > --- a/include/wtsapi32.h > +++ b/include/wtsapi32.h > @@ -135,6 +135,8 @@ typedef struct _WTS_SERVER_INFOW > DECL_WINELIB_TYPE_AW(WTS_SERVER_INFO) > DECL_WINELIB_TYPE_AW(PWTS_SERVER_INFO) > > +#define WTS_CURRENT_SERVER_HANDLE NULL > + maybe some more WTS_ defines while you're at it > void WINAPI WTSCloseServer(HANDLE); > BOOL WINAPI WTSConnectSessionA(ULONG, ULONG, PSTR, BOOL); > BOOL WINAPI WTSConnectSessionW(ULONG, ULONG, PWSTR, BOOL); >

2 1

Re: kernel32/tests: add test for RemoveDirectory
by Dmitry Timoshkov 28 Dec '13

28 Dec '13

Zhenbo Li <litimetal(a)gmail.com> wrote: > + /* remove a nonexist directory */ > + rc = RemoveDirectoryA(directory); > + todo_wine > + ok(!rc && GetLastError() == ERROR_FILE_NOT_FOUND, > + "Expected ERROR_FILE_NOT_FOUND, got ret=%d, gle=%d\n", rc, GetLastError() ); This kind of test for several values simultaneously is really very awkward as a starting point for any person who is going to work on this, or just is looking for a simple bug to fix and greps for todo_wine in the tests. First of all it's not clear where the failure is: is it the API failing to return correct return value, or is it just last error which is set differently? I admit that the error message mentions both values, but it's often more useful to spot areas with todo_wine statements and clearly see the reason of a failure without actually running the test. -- Dmitry.

3 3

Re: Bruno Jesus : ws2_32: Do not convert EAI_xxx return in case of success.
by Bruno Jesus 27 Dec '13

27 Dec '13

On Fri, Dec 27, 2013 at 5:31 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: fc5884c23296c0f121442d0832b0187074e95a10 > ... > @@ -5365,6 +5365,8 @@ static int convert_aiflag_u2w(int unixflags) { > static int convert_eai_u2w(int unixret) { > int i; > > + if (!unixret) return 0; > + > for (i=0;ws_eai_map[i][0];i++) > if (ws_eai_map[i][1] == unixret) > return ws_eai_map[i][0]; Hi, Alexandre. I just would like to say that my patch was based on the other use case of the convert_eai_u2w function, that is just call the function to convert EAI results. Zero is not an EAI result (there is no EAI_SUCCESS or something like that) so in my patch I just avoided calling the conversion function. I'm talking about this use case: http://source.winehq.org/source/dlls/ws2_32/socket.c#L5488 In summary, I think my original patch [1] could get a new reviewing. [1] - http://source.winehq.org/patches/data/101198 Best wishes, Bruno

1 0

Re: [4/4] ws2_32: Add extended IPX protocol support (try 2, resend)
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3867 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE4C9D54

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support (try 2)
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3866 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (194): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: loader: bump XP 64-bit to service pack 2
by Qian Hong 27 Dec '13

27 Dec '13

Hi Austin, you forgot the patch? On Sat, Dec 28, 2013 at 4:04 AM, Austin English <austinenglish(a)gmail.com> wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=35084 > > (follow up to 0463d01f151fb3d7c7acf26c7628683fefb6c130) > > > -- > -Austin > > -- Regards, Qian Hong - http://www.winehq.org

2 1

Re: [4/4] ws2_32/tests: Fix some test message typos
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3861 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (5a8): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 71AB3F3A === wvista (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (654): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 000007FEFE4C9CD9 === w7pro64 (64 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047

1 0

Re: [3/4] ws2_32: Add extended IPX protocol support
by Marvin 27 Dec '13

27 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3860 Your paranoid android. === wxppro (32 bit sock) === sock.c:522: Test failed: oob_server (c0): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 sock: unhandled exception c0000005 at 71AB3F3A === wvista (32 bit sock) === sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (32 bit sock) === sock.c:522: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (32 bit sock) === sock.c:522: Test failed: oob_server (578): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w2008s64 (64 bit sock) === sock.c:522: Test failed: oob_server (7a4): unexpectedly at the OOB mark: 0 sock.c:2101: Test failed: Expected 10043, received 10047 === w7pro64 (64 bit sock) === sock.c:531: Test failed: oob_server (988): not at the OOB mark: 1 sock.c:2101: Test failed: Expected 10043, received 10047

1 0

Re: ws2_32/tests: Add some IPX socket tests
by Bruno Jesus 27 Dec '13

27 Dec '13

On Thu, Dec 26, 2013 at 8:11 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > > It looks like testbot does not support IPX but I manually tested this in XP SP3 and NT4 and the tests are OK. > > These are initial tests to find the problem for bug 6941. Please ignore this patch, I have a better one. Best regards, Bruno

1 0

Re: ws2_32/tests: Add some IPX socket tests
by Marvin 26 Dec '13

26 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3859 Your paranoid android. === wxppro (32 bit sock) === sock.c:521: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:521: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:521: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: msxml3/tests: Constify some character strings
by Marvin 26 Dec '13

26 Dec '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=3855 Your paranoid android. === wxppro (32 bit domdoc) === domdoc.c:9860: Test failed: got 00244F94

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel