- wine-devel - winehq.org

Re: dlls/explorerframe: build tests with -D__WINESRC__
by Marvin 14 Oct '13

14 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2750 Your paranoid android. === wvista (32 bit nstc) === nstc.c:1934: Test failed: Got event 7, count 0 nstc.c:1936: Test failed: Got event 4, count 0 nstc.c:1949: Test failed: Got event 4, count 0

1 0

Re: wsock32: Add a fallback for inet_network.
by Alexandre Julliard 14 Oct '13

14 Oct '13

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/wsock32/protocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't build on MingW: protocol.o: In function `WSOCK32_inet_network@4': /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_inet_addr' /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined reference to `_ntohl' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Help / Mentoring
by Hugh McMaster 14 Oct '13

14 Oct '13

Hi everyone, I just wanted to know if anyone would mind helping/mentoring me with a few small patches. I am working primarily on wineconsole's screen buffer problems (to which I believe I have the solution), but am also looking at implementing some stub Win32 console functions found in dlls/kernel32. Obviously, my aim is to have these patches committed, as the changes will benefit the entire Wine community. I had initially thought of Eric Poeuch, a significant wineconsole developer, however he appears to be extremely busy. So I'm not sure who else to contact. If time is a consideration, please note that I won't be constantly contacting you to review patches or answer questions. Thank you, Hugh

2 3

Re: [PATCH] d3drm: added some freeing of memory in error paths (Coverity)
by Henri Verbeet 14 Oct '13

14 Oct '13

On 13 October 2013 11:13, Marcus Meissner <marcus(a)jet.franken.de> wrote: > 1104553 Resource leak > Fixing the memory leak is fine of course, but I think it would be better to handle the array initialization in d3drm_visual_array_create() etc. instead, so that those functions actually return an object that's properly initialized.

1 0

Re: [2/4] dnsapi/tests: Compile with -D__WINESRC__.
by Marvin 14 Oct '13

14 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2733 Your paranoid android. === wxppro (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === wvista (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (32 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w2008s64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w7pro64 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly === w864 (64 bit record) === record.c:46: Test failed: succeeded unexpectedly record.c:49: Test failed: succeeded unexpectedly

1 0

Re: ntdll: Support pinning module refcount with LdrAddRefDll()
by Dmitry Timoshkov 14 Oct '13

14 Oct '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + FreeLibrary(mod); Please add the tests for FreeLibrary return value. -- Dmitry.

2 1

d3d11 patch
by Max . 13 Oct '13

13 Oct '13

Hi, I would like to know when the first patchs for d3d11 will be introduce into wine ? Beginning of 2014 ? middle 2014 ? End 2014 ? Thanks,

2 2

MSYS touch.exe timestamp resolution issue on Wine-1.6
by Alan W. Irwin 13 Oct '13

13 Oct '13

Under MSYS bash.exe if I use the touch command I only get 1-second resolution when reading the results. bash.exe-3.1$ touch touch1.test touch2.test bash.exe-3.1$ ls --full-time touch*.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch1.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.000000000 -0700 touch2.test Would somebody be willing to make the above test for MSYS on the Microsoft version of Windows (which I don't have access to) to see if time stamps are being read with 1-second resolution as above. That test should help distinguish whether this is a Wine issue or else an MSYS issue. I have also done some tests with the MSYS find.exe and make.exe commands, and in all cases touch2.test is not newer than touch1.text. This can be an important issue for the make command where one-second time resolution can potentially screw up file dependencies. If I use the equivalent Linux ls (and find and make) commands to read the time stamps on the above files, then touch2.test is newer than touch1.text, e.g., wine@raven> ls --full-time touch*.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.391000000 -0700 touch1.test -rw-r--r-- 1 wine wine 0 2013-10-12 13:57:58.408000000 -0700 touch2.test So I think this implies the MSYS touch.exe command is writing high-resolution (i.e., millisecond) time stamps, and it is only reading that high-resolution time stamp that seems to be an issue for MSYS on Wine. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

3 2

Re: mscoree: Add support for ICLRMetaHostPolicy interface
by Dmitry Timoshkov 13 Oct '13

13 Oct '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > +static HRESULT WINAPI metahostpolicy_QueryInterface(ICLRMetaHostPolicy *iface, REFIID riid, void **ppvObject) > +{ > + TRACE("%s %p\n", debugstr_guid(riid), ppvObject); > + > + if ( IsEqualGUID( riid, &IID_ICLRMetaHostPolicy ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = iface; > + } > + else > + { > + FIXME("Unsupported interface %s\n", debugstr_guid(riid)); > + return E_NOINTERFACE; > + } > + > + ICLRMetaHostPolicy_AddRef( iface ); > + > + return S_OK; > +} I think that a common COM convention is to set the object pointer to NULL in case of an unsupported interface. Also you're doing pretty good job in avoiding hungarian notation except for ppvObject. Another nitpick is the choice for if/else construct (although I understand that other places also use this sub-optimal one). A more elegant way of implementing QueryInterface would be IMHO: static HRESULT WINAPI xxx_QueryInterface(IFace *iface, REFIID riid, void **object) { if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IAnotherSupported) { xxx_AddRef(iface); *object = iface; return S_OK; } *object = NULL; return E_NOINTERFACE; } -- Dmitry.

1 0

Re: winmm/tests: Use BOOL type where appropriate
by Marvin 11 Oct '13

11 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2721 Your paranoid android. === wxppro (32 bit wave) === wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13211 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13229 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13075 bytes, should be 13230 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13091 samples (13091 bytes), should be 13230 (13230 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 594 ms, (13108 bytes), should be 600 (13230 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 13220 bytes, should be 13230 wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17621 bytes, should be 17640 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 17634 samples (17634 bytes), should be 17640 (17640 bytes) wave.c:498: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22016 bytes, should be 22050 wave.c:509: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 22027 samples (22027 bytes), should be 22050 (22050 bytes) wave.c:522: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 999 ms, (22044 bytes), should be 1000 (22050 bytes)

1 0

Re: wined3d: Use BOOL type where appropriate
by Henri Verbeet 11 Oct '13

11 Oct '13

On 11 October 2013 22:51, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - DWORD onesided_enable = FALSE; > - DWORD twosided_enable = FALSE; > + DWORD onesided_enable = 0; > + DWORD twosided_enable = 0; Actually, all of those initializations are redundant.

1 0

Fwd: Re: kernel32/tests: Add tests for job objects (try 7)
by Andrew Cook 11 Oct '13

11 Oct '13

(no idea why my client sent this to wine-patches) On 10/10/13 15:23, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 159 > +++++++++++++++++++++++++++++++++++++++++- > include/winbase.h | 1 + > include/winnt.h | 90 ++++++++++++++++++++++++ > 3 files changed, 249 insertions(+), 1 deletion(-) > > there appears to be a window between the all processes leaving a job and the job actually being considered empty, and no apparent way to wait for this. I can't reproduce this locally either. Is there an accepted way to wait for some inaccessible kernel-side event? reordering some calls would likely hide the issue but i'd rather avoid that. https://newtestbot.winehq.org/JobDetails.pl?Key=2687 failure on w8 https://newtestbot.winehq.org/JobDetails.pl?Key=2709 failure on w864 https://newtestbot.winehq.org/JobDetails.pl?Key=2685 same patch, success on w864

1 0

Re: xmllite: Use BOOL type where appropriate
by Nikolay Sivov 10 Oct '13

10 Oct '13

On 10/10/2013 00:36, Frédéric Delanoy wrote: > --- > dlls/xmllite/reader.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c > index 0a4423c..a216951 100644 > --- a/dlls/xmllite/reader.c > +++ b/dlls/xmllite/reader.c > @@ -726,7 +726,7 @@ static void readerinput_grow(xmlreaderinput *readerinput, int length) > } > } > > -static inline int readerinput_is_utf8(xmlreaderinput *readerinput) > +static inline BOOL readerinput_is_utf8(xmlreaderinput *readerinput) > { > static char startA[] = {'<','?'}; > static char commentA[] = {'<','!'}; > @@ -953,7 +953,7 @@ static void reader_skipn(xmlreader *reader, int n) > } > } > > -static inline int is_wchar_space(WCHAR ch) > +static inline BOOL is_wchar_space(WCHAR ch) > { > return ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n'; > } > @@ -1055,7 +1055,7 @@ static HRESULT reader_parse_versioninfo(xmlreader *reader) > } > > /* ([A-Za-z0-9._] | '-') */ > -static inline int is_wchar_encname(WCHAR ch) > +static inline BOOL is_wchar_encname(WCHAR ch) > { > return ((ch >= 'A' && ch <= 'Z') || > (ch >= 'a' && ch <= 'z') || > @@ -1269,7 +1269,7 @@ static HRESULT reader_parse_comment(xmlreader *reader) > } > > /* [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF] */ > -static inline int is_char(WCHAR ch) > +static inline BOOL is_char(WCHAR ch) > { > return (ch == '\t') || (ch == '\r') || (ch == '\n') || > (ch >= 0x20 && ch <= 0xd7ff) || > @@ -1279,7 +1279,7 @@ static inline int is_char(WCHAR ch) > } > > /* [13] PubidChar ::= #x20 | #xD | #xA | [a-zA-Z0-9] | [-'()+,./:=?;!*#@$_%] */ > -static inline int is_pubchar(WCHAR ch) > +static inline BOOL is_pubchar(WCHAR ch) > { > return (ch == ' ') || > (ch >= 'a' && ch <= 'z') || > @@ -1292,7 +1292,7 @@ static inline int is_pubchar(WCHAR ch) > (ch == '_') || (ch == '\r') || (ch == '\n'); > } > > -static inline int is_namestartchar(WCHAR ch) > +static inline BOOL is_namestartchar(WCHAR ch) > { > return (ch == ':') || (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1312,7 +1312,7 @@ static inline int is_namestartchar(WCHAR ch) > } > > /* [4 NS] NCName ::= Name - (Char* ':' Char*) */ > -static inline int is_ncnamechar(WCHAR ch) > +static inline BOOL is_ncnamechar(WCHAR ch) > { > return (ch >= 'A' && ch <= 'Z') || > (ch == '_') || (ch >= 'a' && ch <= 'z') || > @@ -1336,7 +1336,7 @@ static inline int is_ncnamechar(WCHAR ch) > (ch >= 0xfdf0 && ch <= 0xfffd); > } > > -static inline int is_namechar(WCHAR ch) > +static inline BOOL is_namechar(WCHAR ch) > { > return (ch == ':') || is_ncnamechar(ch); > } I don't actually see what this will achieve, but I see such patches are accepted. Is it a new style rule?

3 2

Re: mshtml: Compile tests with __WINESRC__ define.
by Marvin 10 Oct '13

10 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2689 Your paranoid android. === w864 (64 bit activex) === activex.c:1346: Test failed: unexpected call SetObjectRects === wxppro (32 bit htmldoc) === htmldoc.c:2898: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:7601: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:5978: Test failed: mon(0026BFD0) != exmon(00269670) htmldoc.c:2898: Test failed: mon(0029CA28) != exmon(00286FF8) htmldoc.c:7601: Test failed: mon(0029CA28) != exmon(00286FF8) htmldoc.c:5978: Test failed: mon(0029CA28) != exmon(00286FF8) === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: ieframe: Compile tests with __WINESRC__ define.
by Marvin 10 Oct '13

10 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2688 Your paranoid android. === wxppro (32 bit webbrowser) === webbrowser.c:792: Test failed: ReadyState = 1, expected 4

1 0

Re: wmvcore: Stub implementation of IWMMetadataEditor interface
by Nikolay Sivov 10 Oct '13

10 Oct '13

On 10/10/2013 14:58, Jeff Latimer wrote: > --- > dlls/wmvcore/Makefile.in | 2 +- > dlls/wmvcore/wmvcore_main.c | 100 > +++++++++++++++++++++++++++++++++++++++++++- > include/wmsdkidl.idl | 11 ++--- > 3 files changed, 105 insertions(+), 8 deletions(-) > +typedef struct MetadataEditorImpl { > + IWMMetadataEditor MetadataEditor_iface; > + LONG ref; > +} MetadataEditorImpl; > +static inline MetadataEditorImpl *impl_from_MetadataEditor(IWMMetadataEditor *iface) Please follow naming convetions for interfaces. > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} This looks totally wrong. Also please keep implementation functions order and interface methods order the same.

1 0

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.
by Qian Hong 10 Oct '13

10 Oct '13

Hello, this patch is in pending status, is there any way I can improve it? IMO there is no way to 'correctly' implement OpenInputDesktop before implementing SwitchDesktop, as far as SwitchDesktop is a stub, it is safe to assume that OpenInputDesktop will always return either NULL or Winsta0/Default, that is what the patch does and what the tests in [PATCH 3/5] shows.. It is not trivial to implement SwitchDesktop, also I don't know any real world app needing SwitchDesktop except some virtual desktop manager, so I'm not sure it is worth to spend time on implementing SwitchDesktop. However, OpenInputDesktop is needed by multiple apps (TeamViewer, QQ International, Inspect tool from Windows Platform SDK as bug 12067), is it acceptable to submit such a 'better stub' to Wine and leaving SwitchDesktop as a stub? Any comment is great appreciated! On Tue, Oct 8, 2013 at 11:41 AM, Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=12067 , let QQ users happy :) > > --- > dlls/user32/tests/winstation.c | 22 ---------------------- > dlls/user32/winstation.c | 22 +++++++++++++++++++--- > 2 files changed, 19 insertions(+), 25 deletions(-) > > -- Regards, Qian Hong - http://www.codeweavers.com

2 2

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().
by Alexandre Julliard 10 Oct '13

10 Oct '13

Ralf Habacker <ralf.habacker(a)freenet.de> writes: > With other patches i have been told to implement such stuff in the dib > driver. Unfortunally this do not works in this case, because in the top > level function it looks like having driver specific stuff using display > coordinates. It would still most likely have to be in the driver, though maybe the driver would not be calling that exact entry point. In any case, you can't change the DC transform like this. and you'll need test cases. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: kernel32/tests: Add tests for job objects (try 7)
by Marvin 10 Oct '13

10 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2683 Your paranoid android. === w864 (64 bit process) === process.c:2092: Test failed: Unexpected completion event: 6, 0000000000000158, 00000000000002F0

1 0

Re: ddraw/tests: Use BOOL type where appropriate
by Marvin 09 Oct '13

09 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2682 Your paranoid android. === wxppro (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === wvista (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w2008s64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag === w7pro64 (32 bit d3d) === d3d.c:1261: Test failed: Homogeneous output was generated despite UNCLIPPED flag

1 0

Re: [PATCH] d3dx9: Move object initialization into a separate function.
by Matteo Bruni 09 Oct '13

09 Oct '13

Hi Rico, 2013/10/8 Rico Schüller <kgbricola(a)web.de>: > Hi, > > this moves the object initialization into a separate function, so it could > be used for strings and resources. It also removes the STATE_TYPE as we > could distinguish the types at the object level. > > 1. When an object has a destination, it points to another shader variable. > This was state ST_PARAMETER. > > 2. If a variable has something in data, it is fxlc, shader (preshader) or a > string. This was state ST_CONSTANT and ST_FXLC. > > 3. If it has both (destination and data), it points to an array of shader > variables. The name is in the destination, the index could be calculated > with the data. This will be added in a later patch. > There's still the issue of distinguishing between ST_CONSTANT and ST_FXLC, checking object_id and type might cover that though. > Also saving the destination parameter in the object gains some speed when we > need to access the variable as we don't need to run get_parameter_by_name() > each time we need the variable ... > I'm not sure storing additional info into the objects is the right thing to do. Take a look at the D3DXFX_NOT_CLONEABLE flag from http://msdn.microsoft.com/en-us/library/windows/desktop/bb172855%28v=vs.85%…. Notice that GetPassDesc() doesn't return the shader data if the object was created with the flag. What I've been thinking is that it simply can't because the original shader data, stored in an object, were freed after parsing. While nothing forces us to do the same (except probably avoiding to use more memory than strictly necessary) I think it's better not to put additional stuff into the objects or generally assume that the objects are still available after parsing. That means creating the shaders and the strings at parse time or right after that and storing any additional required information (e.g. preshader) in the parameter. So, directly storing the referenced parameter is a good idea but I'd prefer that pointer to be in d3dx_parameter. > Cheers > Rico > > --- > dlls/d3dx9_36/effect.c | 98 > ++++++++++++++++++-------------------------------- > 1 Datei geändert, 34 Zeilen hinzugefügt(+), 64 Zeilen entfernt(-) > Cheers, Matteo

2 2

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg 09 Oct '13

09 Oct '13

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: [PATCH 4/5] d3drm: Compare with the correct IID in IDirect3DRMVisualArrayImpl_QueryInterface().
by Dmitry Timoshkov 09 Oct '13

09 Oct '13

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > +static HRESULT WINAPI IDirect3DRMVisualArrayImpl_QueryInterface(IDirect3DRMVisualArray *iface, REFIID riid, void **out) > { > - TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); > + TRACE("iface %p, riid %s, out %p.\n", iface, debugstr_guid(riid), out); > > - if (IsEqualGUID(riid, &IID_IUnknown) || > - IsEqualGUID(riid, &IID_IDirect3DRMFrameArray)) > + if (IsEqualGUID(riid, &IID_IDirect3DRMVisualArray) > + || IsEqualGUID(riid, &IID_IUnknown)) > { > - *ret_iface = iface; > IDirect3DRMVisualArray_AddRef(iface); > + *out = iface; > return S_OK; > } Although this is existing code the assignment '*out = iface' is wrong, especially since next patch introduces impl_from_IDirect3DRMVisualArray() helper. Looks like that file needs a bit of COM clean up. -- Dmitry.

2 1

Re: ws2_32/tests: Use BOOL type where appropriate
by Marvin 09 Oct '13

09 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2674 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (bc): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (2c8): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (8a4): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (8a4): unexpectedly at the OOB mark: 0 === w864 (32 bit sock) === sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for domain: 11004 sock.c:1740: Test failed: getservbyname could not retrieve information for telnet: 11004 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (118): unexpectedly at the OOB mark: 0

1 0

Wrong status of gdi32
by Akira Nakagawa 08 Oct '13

08 Oct '13

I found this page <http://www.nirsoft.net/dll_information/windows8/gdi32_dll.html> shows that gdi32 dll has more than 800 functions,but the spec file has only 500 .

3 2

RE: binfmt support
by xantares 09 08 Oct '13

08 Oct '13

From: xantares09(a)hotmail.com To: hverbeet(a)gmail.com Subject: RE: binfmt support Date: Mon, 7 Oct 2013 11:47:05 +0000 > Date: Mon, 7 Oct 2013 12:23:30 +0200 > Subject: Re: binfmt support > From: hverbeet(a)gmail.com > To: xantares09(a)hotmail.com > CC: wine-devel(a)winehq.org > > On 7 October 2013 12:06, xantares 09 <xantares09(a)hotmail.com> wrote: > > ... I don't see a reason why to not include it at the wine level instead of > > every linux distros, see: > > https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf… > > > > What do you think ? > > > Ignoring the discussion if we want this or not for the moment, I'd > guess this would break as soon as you pass something other than /usr > for --prefix to configure. Yes, It'll only work when prefix=/usr, which is always what happens when building packaging. This is what we want ; we still want to honor the prefix var. x.

1 0

Re: gdi32/tests: Skip linked font like SimSun-ExtB in fixed-pitch font selection.
by Marvin 08 Oct '13

08 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2669 Your paranoid android. === wvista (32 bit font) === The test timed out === w2008s64 (32 bit font) === Timeout Failure running script in VM: network read timed out

1 0

Re: (try 6)[3/5] imm32: use thread data from target HWND
by Alexandre Julliard 08 Oct '13

08 Oct '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1597,7 +1612,9 @@ BOOL WINAPI ImmGetConversionStatus( > HWND WINAPI ImmGetDefaultIMEWnd(HWND hWnd) > { > HWND ret; > - IMMThreadData* thread_data = IMM_GetThreadData(0); > + IMMThreadData* thread_data = IMM_GetThreadDataForWindow(hWnd); > + if (!thread_data) > + return NULL; > if (thread_data->hwndDefault == NULL) > thread_data->hwndDefault = CreateWindowExW( WS_EX_TOOLWINDOW, > szwIME, NULL, WS_POPUP, 0, 0, 1, 1, 0, 0, 0, 0); It doesn't seem right to create the default window from a different thread. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] wined3d: Handle sRGB_decode when reading the sampler state.
by Henri Verbeet 08 Oct '13

08 Oct '13

On 8 October 2013 00:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 52eac16..eb8ca7e 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -5608,8 +5608,6 @@ HRESULT surface_load_location(struct wined3d_surface *surface, DWORD location, c > } > } > > - if (location == SFLAG_INSRGBTEX && gl_info->supported[EXT_TEXTURE_SRGB_DECODE]) > - location = SFLAG_INTEXTURE; > > if (surface->flags & location) > { > @@ -5671,12 +5669,6 @@ HRESULT surface_load_location(struct wined3d_surface *surface, DWORD location, c > surface_evict_sysmem(surface); > } > > - if (surface->flags & (SFLAG_INTEXTURE | SFLAG_INSRGBTEX) > - && gl_info->supported[EXT_TEXTURE_SRGB_DECODE]) > - { > - surface->flags |= (SFLAG_INTEXTURE | SFLAG_INSRGBTEX); > - } > - > return WINED3D_OK; > } > This change seems good on its own, as far as I can tell all callers already handle this correctly. I'm less sure about the other changes, the texture code seems like the right place to handle EXT_texture_sRGB_decode.

2 2

Re: [1/3] xmllite: Use buffer offset instead of pointers
by Nikolay Sivov 08 Oct '13

08 Oct '13

On 10/6/2013 19:06, Nikolay Sivov wrote: > It's normal to grow destination buffer, in this case all stored > pointers will be trashed. This patch uses offsets from start of a > buffer instead. > Hi, Alexandre. Patches list shows a build failure for this one, and I don't see any failures on testbot for it so assuming something it fails on your machine. So what's the exact failure you get?

2 2

Re: riched20: Set control content in WM_CREATE message
by Akihiro Sagawa 08 Oct '13

08 Oct '13

On Sat, 05 Oct 2013 14:54:07 +0200, Piotr Caban wrote: > + if (!(editor->styleFlags & ES_MULTILINE)) > + { > + len = 0; > + while(textW[len] != '0' && textW[len] != '\r' && textW[len] != '\n') > + len++; > + } Although this patch has been committed as e660bf676c111ce20d9e868280094f1c5bb81c79, I doubt that it works properly. Did you mean '\0' or 0? Regards, Akihiro Sagawa

2 1

winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Kevin Eaves 08 Oct '13

08 Oct '13

Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually go fullscreen 'natively' but simply resizes the window fullscreen, and automatically moves it to its own space. As far as Wine is concerned the window resized — just like clicking the zoom button and manually assigning the window to its own space. I doubled the MaxTrackSize in user32/winpos.c, but it only needs +15 for the height.

2 2

Re: msi/tests: Use BOOL type where appropriate (resend)
by Marvin 08 Oct '13

08 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2667 Your paranoid android. === wvista (32 bit msi) === Timeout === w2008s64 (32 bit msi) === Timeout Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout

1 0

Re: msi/tests: Use BOOL type where appropriate
by Marvin 07 Oct '13

07 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2660 Your paranoid android. === wvista (32 bit msi) === The test timed out === w2008s64 (32 bit msi) === The test timed out === w7pro64 (32 bit msi) === No test summary line found Failure running script in VM: network read timed out === w2008s64 (64 bit msi) === Timeout === w7pro64 (64 bit msi) === Timeout

1 0

Re: mscoree: Partial implement ICLRMetaHost RequestRuntimeLoadedNotification (try 2)
by Vincent Povirk 07 Oct '13

07 Oct '13

HRESULT CLRMetaHost_CreateInstance(REFIID riid, void **ppobj) { + GlobalCLRMetaHost.callback = NULL; return ICLRMetaHost_QueryInterface(&GlobalCLRMetaHost.ICLRMetaHost_iface, riid, ppobj); } I don't think we should be changing global state every time someone creates an instance of this object. We can't assume it only happens once.

1 0

Re: riched20: Set control content in WM_CREATE message
by Alexandre Julliard 07 Oct '13

07 Oct '13

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/riched20/editor.c | 21 +++++++++++++++++++++ > dlls/riched20/tests/editor.c | 38 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so txtsrv.c && touch txtsrv.ok wine: Unhandled page fault on read access to 0x00000024 at address 0x7ac23e94 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000024 in 32-bit code (0x7ac23e94). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ac23e94 ESP:0032f290 EBP:0032fb98 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:7ac58c00 ECX:0032fc80 EDX:003338e8 ESI:003338e8 EDI:00000001 Stack dump: 0x0032f290: 0032fc80 00000000 00000000 00000000 0x0032f2a0: 00000001 00000000 00000000 00333428 0x0032f2b0: 4d430002 00000008 00000004 7bc3c8e3 0x0032f2c0: 00333558 00333550 00000000 7bc3c8e3 0x0032f2d0: 00000780 000004b0 0032f300 6890a34c 0x0032f2e0: 00000000 0000001f 0032f318 688bd210 Backtrace: =>0 0x7ac23e94 ME_HandleMessage+0x32d4(editor=0x3338e8, msg=0x1, wParam=0, lParam=0, unicode=0x1, phresult=0x32fbdc) [/home/julliard/wine/wine/dlls/riched20/editor.c:4029] in riched20 (0x0032fb98) 1 0x7ac3d3ab CreateTextServices+0x11a(pUnkOuter=<couldn't compute location>, pITextHost=<couldn't compute location>, ppUnk=<couldn't compute location>) [/home/julliard/wine/wine/dlls/riched20/txtsrv.c:417] in riched20 (0x0032fbf8) 2 0x686569cb func_txtsrv+0x2fa() [/home/julliard/wine/wine/dlls/riched20/tests/txtsrv.c:864] in riched20_test (0x0032fd38) 3 0x6862a5a7 main+0x386(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/riched20/tests/../../../include/wine/test.h:570] in riched20_test (0x0032fe08) 4 0x68657e30 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in riched20_test (0x0032fe58) 5 0x7b85f36c call_process_entry+0xb() in kernel32 (0x0032fe78) 6 0x7b86054b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1085] in kernel32 (0x0032feb8) 7 0x7bc7fe70 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 8 0x7bc82d7d call_thread_func+0x7c(entry=0x7b8604e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 9 0x7bc7fe4e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 10 0x7bc54a1e start_process+0x1d(kernel_start=0x7b8604e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 11 0x6803128d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 12 0x6803134b wine_switch_to_stack+0x2a(func=0x7bc54a00, arg=0x7b8604e0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff8b7288) 13 0x7bc5a557 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xff8b72f8) 14 0x7b866ac0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1257] in kernel32 (0xff8b8208) 15 0x7bc5ac23 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xff8b8298) 16 0x6802eeda wine_init+0x2b9(argc=0x3, argv=0xff8b87d4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:952] in libwine.so.1 (0xff8b82f8) 17 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff8b8738) 18 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x7ac23e94 ME_HandleMessage+0x32d4 [/home/julliard/wine/wine/dlls/riched20/editor.c:4029] in riched20: movl 0x24(%eax),%eax 4029 : (void*)((CREATESTRUCTA*)lParam)->lpszName); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling (try2)
by Marvin 07 Oct '13

07 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2651 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1329: Test failed: 125: Got name "?_dispatch@_impl_Engine@SalomeApp@@$R4CE@BA@PPPPPPPM@7AE_NAAVomniCallHandle@@@Z" cpp.c:1332: Test failed: 125: Expected "[thunk]:public: virtual bool __thiscall SalomeApp::_impl_Engine::_dispatch`vtordispex{36,16,4294967292,8}' (class omniCallHandle &)"

1 0

Re: [PATCH 3/3] msvcrt: Add support for vtordispex demangling
by Marvin 07 Oct '13

07 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2650 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1328: Test failed: 124: Got name "[thunk]: __thiscall CView::`vcall'{392,{flat}}' " cpp.c:1331: Test failed: 124: Expected "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'" cpp.c:1328: Test failed: 125: Got name "?_dispatch@_impl_Engine@SalomeApp@@$R4CE@BA@PPPPPPPM@7AE_NAAVomniCallHandle@@@Z" cpp.c:1331: Test failed: 125: Expected "[thunk]:public: virtual bool __thiscall SalomeApp::_impl_Engine::_dispatch`vtordispex{36,16,4294967292,8}' (class omniCallHandle &)"

1 0

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling
by Marvin 07 Oct '13

07 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2649 Your paranoid android. === wxppro (32 bit cpp) === cpp.c:1326: Test failed: 124: Got name "[thunk]: __thiscall CView::`vcall'{392,{flat}}' " cpp.c:1329: Test failed: 124: Expected "[thunk]: __thiscall CView::`vcall'{392,{flat}}' }'"

1 0

Re: msvcrt: add support for _chsize_s (try #2)
by Piotr Caban 07 Oct '13

07 Oct '13

Hi, On 10/06/13 00:45, morphiend wrote: > + * _chsize_s (MSVCRT.@) > + */ > +int CDECL MSVCRT__chsize_s(int fd, __int64 size) > +{ > + LARGE_INTEGER cur, pos; > + LARGE_INTEGER temp = { 0 }; This causes compilation warnings. There's also a trailing space in this line. > + TRACE("(fd=%d, size=%lld)\n", fd, size); You can't print 64-bit numbers this way, it's not portable. You can use wine_dbgstr_longlong function. > + handle = msvcrt_fdtoh(fd); > + if (!MSVCRT_CHECK_PMT_ERR(handle == INVALID_HANDLE_VALUE, MSVCRT_EBADF) || > + !MSVCRT_CHECK_PMT_ERR(size < 0, MSVCRT_EINVAL)) You're validating parameters incorrectly. Did you test this patch? > + { > + ret = SetEndOfFile(handle); > + if (!ret) > + { > + msvcrt_set_errno(GetLastError()); > + ret = *MSVCRT__errno(); > + } This causes the _chsize_s function to return TRUE in case of success. > + /* restore the file pointer */ > + MSVCRT__lseek(fd, cur.QuadPart, SEEK_SET); MSVCRT__lseek takes LONG as second argument. Cheers, Piotr

1 0

binfmt support
by xantares 09 07 Oct '13

07 Oct '13

Hello, I made a patch to add a configuration file to be picked up by binfmt to allow to associate windows executables to wine. As binfmt is now a part of systemd in most linux disttributions: http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html ... I don't see a reason why to not include it at the wine level instead of every linux distros, see: https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf… What do you think ? x.

2 1

Re: msvcrt: add support for _chsize_s (try #2)
by Frédéric Delanoy 06 Oct '13

06 Oct '13

On Sun, Oct 6, 2013 at 12:45 AM, morphiend <morphiend(a)gmail.com> wrote: > This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. > This was tested on Ubuntu 12.10 using IDA 6.4 as a test application. Without > the implementation of _chsize_s(), certain binaries caused an internal crash > of IDA. This patch fixed that crash. > You need to use your real name when sending patches. -- Frédéric Delanoy

2 1

Re: mshtml/tests: Fix compilation on systems that don't support nameless unions.
by Marvin 05 Oct '13

05 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2637 Your paranoid android. === wxppro (32 bit htmldoc) === htmldoc.c:2898: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:7601: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:5978: Test failed: mon(0026BF78) != exmon(00269670) htmldoc.c:2898: Test failed: mon(002ADFE8) != exmon(00265FE8) htmldoc.c:7601: Test failed: mon(002ADFE8) != exmon(00265FE8) htmldoc.c:5978: Test failed: mon(002ADFE8) != exmon(00265FE8) === wvista (32 bit htmldoc) === No test summary line found === w7pro64 (32 bit htmldoc) === No test summary line found

1 0

Re: kernel32/tests: Fix compilation on systems that don't support nameless unions.
by Marvin 05 Oct '13

05 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2634 Your paranoid android. === w7pro64 (64 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:883: Test failed: WaitCommEvent error 0 comm.c:885: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:889: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:891: Test failed: WaitCommEvent used 1014 ms for waiting

1 0

BiDi, Unicode 6.3 and Wine.
by Aric Stewart 04 Oct '13

04 Oct '13

Hello, So Unicode 6.3 was just recently released. One of the things it features is an updated BIDI (Bidirectional) algorithm. This is revision 29 to the algorithm. (http://www.unicode.org/reports/tr9/tr9-29.html#Modifications) Looking at the code I moved from gdi32 to usp10, it looks like the existing code is based off of revision 17. This implementation was originally by Shachar and Maarten. I simply integrated it into uniscribe. I am tempted to update our code to match the revision 29 version of the algorithm. But this raises a question. Right now our code mostly correctly mimics Windows. It may be that I am not testing the correct edge cases that would reveal if windows is coded to a later version of the algorithm or not. But if we update to revision 29 then we will almost assuredly be using a later version of the algorithm. What is more important to us in this regard? Do we want to have the latest algorithm based on the unicode standard, or do we want to try to match the algorithm that Windows makes use of? Thanks! -aric

3 2

Re: [3/3] ntdll: Add support for FILE_APPEND_DATA to NtWriteFile. Take 2.
by Alexandre Julliard 04 Oct '13

04 Oct '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -979,6 +986,12 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent, > goto done; > } > > + if (append_write) > + { > + offset_eof.QuadPart = (LONGLONG)-1; /* FILE_WRITE_TO_END_OF_FILE */ > + offset = &offset_eof; > + } > + Please add a test for the file position after the write, to show that this is the correct behavior. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.
by Henri Verbeet 04 Oct '13

04 Oct '13

On 4 October 2013 15:02, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > Client storage only applies to GL textures, which won't be created for sysmem surfaces. > I don't think that's necessarily true at the moment. In particular, ddraw blits can in principle cause a texture to be created for sysmem surfaces. There might be restrictions in the ddraw API that prevent this from happening in practice, but even if there are, we certainly don't enforce them.

2 4

Re: [PATCH 5/5] wininet: Added InternetLockRequestFile tests.
by Marvin 04 Oct '13

04 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2625 Your paranoid android. === w2008s64 (64 bit http) === http.c:3521: Test failed: HttpQueryInfo failed 0 === w7pro64 (64 bit http) === http.c:3521: Test failed: HttpQueryInfo failed 0

1 0

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded
by Henri Verbeet 04 Oct '13

04 Oct '13

On 3 October 2013 21:16, Lasse Rasinen <lrasinen(a)iki.fi> wrote: > According to debugging output, Artemis Spaceship Bridge Simulator 2.0 > calls LockRect twice on the same texture (for whatever reason) and crashes. > > http://bugs.winehq.org/show_bug.cgi?id=34271 > > This change prevents the locked_rect being overwritten with garbage in > that case, and the game no longer crashes. > I think this patch makes sense, but could you please add a test case as well? Ideally we'd also have similar tests for other resources (i.e., textures, volumes, vertex buffers, index buffers) and D3D versions (ddraw, d3d8), but that's not a strict requirement. > + if (hr == WINED3D_OK) { > + locked_rect->Pitch = map_desc.row_pitch; > + locked_rect->pBits = map_desc.data; > + } > Minor style issue, this should be: if (SUCCEEDED(hr)) { ... }

3 2

Re: [PATCH 2/2] advapi32: Don't cache HKCR if WOW64 redirection flags are set
by Marvin 04 Oct '13

04 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2624 Your paranoid android. === wxppro (32 bit registry) === Timeout

1 0

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.
by Henri Verbeet 04 Oct '13

04 Oct '13

On 4 October 2013 00:03, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2883,10 +2886,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem > /* Now the surface memory is most up do date. Invalidate drawable and texture. */ > surface_validate_location(surface, SFLAG_INSYSMEM); > surface_invalidate_location(surface, ~SFLAG_INSYSMEM); > - > - /* For client textures OpenGL has to be notified. */ > - if (surface->flags & SFLAG_CLIENT) > - surface_release_client_storage(surface); > } > else if (surface->flags & SFLAG_USERPTR) > { > @@ -2899,9 +2898,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct wined3d_surface *surface, void *mem > surface->resource.allocatedMemory = NULL; > surface->flags &= ~(SFLAG_USERPTR | SFLAG_INSYSMEM); > > - if (surface->flags & SFLAG_CLIENT) > - surface_release_client_storage(surface); > - > surface_prepare_system_memory(surface); > } > What makes this safe, and why is it needed?

1 0

Re: [PATCH 3/3] winemac: Tell Wine when Cocoa has brought a window to the front.
by Ken Thomases 04 Oct '13

04 Oct '13

On Oct 4, 2013, at 12:17 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/cocoa_app.m | 8 ++++++-- > dlls/winemac.drv/cocoa_window.h | 1 + > dlls/winemac.drv/cocoa_window.m | 16 +++++++++++++--- > dlls/winemac.drv/event.c | 5 +++++ > dlls/winemac.drv/macdrv.h | 1 + > dlls/winemac.drv/macdrv_cocoa.h | 1 + > dlls/winemac.drv/window.c | 12 ++++++++++++ > 7 files changed, 39 insertions(+), 5 deletions(-) > > <0003-winemac-Tell-Wine-when-Cocoa-has-brought-a-window-to.patch> Don't commit this one. It has caused some strange behavior on Mavericks. The other two in the series are OK and useful independently of this one. -Ken

1 0

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.
by Henri Verbeet 03 Oct '13

03 Oct '13

On 3 October 2013 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/volume.c | 46 +++++++++++++++++++++--------------------- > dlls/wined3d/wined3d_private.h | 6 ++++-- > 2 files changed, 27 insertions(+), 25 deletions(-) > What about surfaces and buffers?

2 5

Re: kernel32: Add tests for job objects (try 4)
by Alexandre Julliard 03 Oct '13

03 Oct '13

Andrew Cook <ariscop(a)gmail.com> writes: > + sprintf(buffer, "\"%s\" tests/process.c ignored \"%s\"", selfname, "wait"); > + > + IOPort = CreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1); > + ok(IOPort != INVALID_HANDLE_VALUE, "CreateIoCompletionPort (%d)", GetLastError()); > + > + JobObject = pCreateJobObjectW(NULL, NULL); > + ok(JobObject != INVALID_HANDLE_VALUE, "CreateJobObject (%d)\n", GetLastError()); These functions don't return INVALID_HANDLE_VALUE. -- Alexandre Julliard julliard(a)winehq.org

1 0

Looking for an icon for the Mac driver: generic program running under Wine
by Ken Thomases 03 Oct '13

03 Oct '13

Hi, I have a need for a new icon in Wine and I'm hoping somebody with some graphics-design skills might be able to create it. The Mac driver attempts to extract an icon from the executable to use for the Dock icon of its process. This is also the icon that appears in the Command-Tab application switcher. This often works, but not always. When it doesn't, the Dock just uses the generic "Unix executable" icon from Mac OS X. You can see that here: <http://i.imgur.com/b1JrMDJ.png>. It's not very nice. I would prefer to have a Wine-specific generic program icon. Any graphic designer care to take on the task of creating such an icon? I'm told Wine has been using the Tango icons as the template for its. Tango provides application-x-executable.svg at <http://cgit.freedesktop.org/tango/tango-icon-theme/tree/svg> that might be suitable. That could be badged with the Wine glass logo to produce an icon for a program running under Wine. On the other hand, if this icon were to be used only by the Mac driver, it might be more appropriate to use a Mac-themed icon. Some time back, Jeremiah posted an archive of icons. <http://www.winehq.org/pipermail/wine-devel/2013-February/098783.html> That included one which had a miniature Mac window badged with the Wine glass logo. I'm not sure of the copyright/licensing situation with that icon. It's bitmap-only, not vector, but that might be fine for a Mac-only icon. It does have some issues with rough edges around the window, rather than a smooth alpha-blended edge. Although Mac app icons can go up to 1024x1024 pixels (512x512 "points" at 2x resolution for Retina displays), this icon would only appear in the Dock and the application switcher. So, it needn't be larger than 256x256 pixels (128x128@2x). Thanks, Ken

2 1

Re: rpcss: Convert to a service
by Andrew Cook 03 Oct '13

03 Oct '13

Ignore this, for some reason this randomly forks a huge number of rpcss instances, and decided to not do so while i was testing it On 03/10/13 14:00, Andrew Cook wrote: > --- > dlls/rpcrt4/rpc_epmap.c | 40 ++++++++----------- > programs/rpcss/Makefile.in | 2 +- > programs/rpcss/rpcss_main.c | 97 > +++++++++++++++++++++++++++++++++++---------- > tools/wine.inf.in | 11 +++++ > 4 files changed, 104 insertions(+), 46 deletions(-) > >

1 0

Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.
by Dmitry Timoshkov 03 Oct '13

03 Oct '13

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > diff --git a/server/file.c b/server/file.c > index 2ecf97c..94d3060 100644 > --- a/server/file.c > +++ b/server/file.c > @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) > > access = generic_file_map_access( access ); > if (access & FILE_READ_DATA) mode |= 4; > - if (access & FILE_WRITE_DATA) mode |= 2; > + if (access & (FILE_WRITE_DATA|FILE_APPEND_DATA)) mode |= 2; > if (access & FILE_EXECUTE) mode |= 1; > return mode; > } I don't think that this patch should be in 'superseded' state. -- Dmitry.

1 0

Re: [5/5] ws2_32: Always return the source address from WSAAccept.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2610 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (618): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 74AA9799 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (600): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 0000000000000000

1 0

Re: [4/5] ws2_32: Return an error from accept if the address buffer is too small.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2609 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (520): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 74AA9799 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (78c): unexpectedly at the OOB mark: 0

1 0

Re: [3/5] ws2_32: Add some tests for getpeername.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2608 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (c8): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (320): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 74AA9799 === w2008s64 (64 bit sock) === sock.c:509: Test failed: oob_server (808): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (808): unexpectedly at the OOB mark: 0

1 0

Re: [2/5] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2607 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (108): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (7c4): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 74AA9799 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (470): unexpectedly at the OOB mark: 0

1 0

Re: [1/2] gdi32: Fix the B spacing value of empty glyph. (try 3)
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2605 Your paranoid android. === wvista (32 bit font) === The test timed out === w2008s64 (32 bit font) === Failure running script in VM: network read timed out

1 0

Re: [2/2] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)
by Alexandre Julliard 02 Oct '13

02 Oct '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/gdi32/freetype.c | 12 ++++++++---- > dlls/gdi32/tests/font.c | 5 +++++ > 2 files changed, 13 insertions(+), 4 deletions(-) It looks like something is not quite right, this is causing strange spacing, for instance in the About dialog. -- Alexandre Julliard julliard(a)winehq.org

1 0

I'm not sure why it was rejected
by Akira Nakagawa 02 Oct '13

02 Oct '13

I cannnot make sure my patch 99266 <cid:part1.07050802.08000504@gmail.com> was rejected. From: Akira Nakagawa <matyapiro31(a)gmail.com> Subject: add ualapi directory(try 15) Message-Id: <52496BA8.1020908(a)gmail.com> Date: Mon, 30 Sep 2013 21:16:40 +0900 I think it has no problem without what Bruno said. So this is the last one. From e7b788f927621f5d8544bbf73f1e155e05098387 Mon Sep 17 00:00:00 2001 Message-Id: <e7b788f927621f5d8544bbf73f1e155e05098387.1380543383.git.matyapiro31(a)gmail.com> From: Akira Nakagawa <matyapiro31(a)gmail.com> Date: Mon, 30 Sep 2013 21:13:52 +0900 Subject: [PATCH] add ual directory (try 15) --- dlls/ualapi/Makefile.in | 6 ++++ dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++ dlls/ualapi/ualapi.spec | 4 +++ include/ual.h | 47 +++++++++++++++++++++++++++ 4 files changed, 143 insertions(+) diff --git a/dlls/ualapi/Makefile.in b/dlls/ualapi/Makefile.in new file mode 100644 index 0000000..59e56fe --- /dev/null +++ b/dlls/ualapi/Makefile.in @@ -0,0 +1,6 @@ +MODULE = ualapi.dll +IMPORTLIB = ualapi + +C_SRCS = main.c + +@MAKE_DLL_RULES@ diff --git a/dlls/ualapi/main.c b/dlls/ualapi/main.c new file mode 100644 index 0000000..7b3ff7b --- /dev/null +++ b/dlls/ualapi/main.c @@ -0,0 +1,86 @@ +/* + * main.c + * This file is part of wine + * + * Copyright (C) 2013 - Akira Nakagawa + * + * wine is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * wine is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with wine. If not, see <http://www.gnu.org/licenses/>. + */ +#include <stdio.h> +#include "windef.h" +#include "winbase.h" +#include "winuser.h" +#include "wine/debug.h" +#include "ual.h" + +WINE_DEFAULT_DEBUG_CHANNEL(ualapi); + +/***************************************************** + * DllMain + */ +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) +{ + TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); + switch (fdwReason) + { + case DLL_WINE_PREATTACH: + return FALSE; /* prefer native version */ + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls(hinstDLL); + break; + } + return TRUE; +} + +/* + * Return S_OK if succeed,or return error code + * It records Data of the user. + */ +HRESULT +WINAPI +UalStart( + PUAL_DATA_BLOB Data){ + FIXME("This function is not supported.\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return S_OK; +} + +HRESULT +WINAPI +UalStop( + PUAL_DATA_BLOB Data){ + FIXME("This function is not supported.\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return S_OK; +} + +HRESULT +WINAPI +UalInstrument( + PUAL_DATA_BLOB Data){ + FIXME("This function is not supported.\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return S_OK; +} + +HRESULT +WINAPI +UalRegisterProduct( + const WCHAR* wszProductName, + const WCHAR* wszRoleName, + const WCHAR* wszGuid){ + FIXME("This function is not supported.\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return S_OK; +} diff --git a/dlls/ualapi/ualapi.spec b/dlls/ualapi/ualapi.spec new file mode 100644 index 0000000..b7682fb --- /dev/null +++ b/dlls/ualapi/ualapi.spec @@ -0,0 +1,4 @@ +@ stdcall UalStart(ptr) +@ stdcall UalStop(ptr) +@ stdcall UalInstrument(ptr) +@ stdcall UalRegisterProduct(wstr wstr wstr) diff --git a/include/ual.h b/include/ual.h new file mode 100644 index 0000000..14f1c74 --- /dev/null +++ b/include/ual.h @@ -0,0 +1,47 @@ +/* + * ual.h: User Access Logging + * This file is part of wine + * + * Copyright (C) 2013 - Akira Nakagawa + * + * wine is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * wine is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with wine. If not, see <http://www.gnu.org/licenses/>. + */ + + +#ifndef _UAL_H_INCLUDED +#define _UAL_H_INCLUDED + +#include <winsock2.h> + +typedef struct tagUAL_DATA_BLOB +{ + DWORD Size; + GUID RoleGuid; + GUID TenantId; + SOCKADDR_STORAGE Address; + WCHAR UserName[MAX_PATH]; +} UAL_DATA_BLOB, *PUAL_DATA_BLOB; + +HRESULT WINAPI UalStart(PUAL_DATA_BLOB Data); + +HRESULT WINAPI UalStop(PUAL_DATA_BLOB Data); + +HRESULT WINAPI UalInstrument(PUAL_DATA_BLOB Data); + +HRESULT WINAPI UalRegisterProduct( + const WCHAR* wszProductName, + const WCHAR* wszRoleName, + const WCHAR* wszGuid); +#endif + -- 1.8.1.2

4 3

Re: [PATCH 4/7] msvcr90/tests: Use the W form of CreateEvent().
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2457 Your paranoid android. === wxppro (32 bit msvcr90) === No test summary line found

1 0

Re: [PATCH 2/7] qedit/tests: Use the W version of FindResource().
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2455 Your paranoid android. === w2008s64 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 0040184A === w2008s64 (64 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00000000004017A3

1 0

Re: Re: kernel32/tests: Fix the test_waittxempty() timeout.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2434 Your paranoid android. === wxppro (32 bit comm) === comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... No test summary line found Failure running script in VM: network read timed out === w2008s64 (32 bit comm) === comm.c:1670: test_AbortWaitCts timeout 500 handle 000000C4 comm.c:1637: Changing CommMask on the fly for handle 000000C4 after timeout 500 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 No test summary line found Failure running script in VM: network read timed out === w7pro64 (32 bit comm) === comm.c:1670: test_AbortWaitCts timeout 500 handle 00000130 comm.c:1637: Changing CommMask on the fly for handle 00000130 after timeout 500 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1094: Test failed: WriteFile failed with a timeout comm.c:1096: Test failed: GetOverlappedResult reported error 996 comm.c:1097: Test failed: expected 64000, written 0 Timeout === w2008s64 (64 bit comm) === comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 Timeout === w7pro64 (64 bit comm) === comm.c:887: WaitCommEvent for EV_TXEMPTY took 0 ms (timeout 1000) comm.c:1670: test_AbortWaitCts timeout 500 handle 00000000000000CC comm.c:1637: Changing CommMask on the fly for handle 00000000000000CC after timeout 500 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:1064: Test failed: WaitCommEvent failed with a timeout comm.c:1075: recovering after WAIT_TIMEOUT... comm.c:1086: Test failed: WaitCommEvent error 0 comm.c:1087: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 Timeout

1 0

Re: Assorted spelling fixes.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2433 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2432 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2431 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2430 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2429 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [5/5] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)
by Marvin 02 Oct '13

02 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2426 Your paranoid android. === wvista (32 bit font) === The test timed out === w2008s64 (32 bit font) === Failure running script in VM: network read timed out === w2008s64 (64 bit font) === Failure running script in VM: network read timed out

1 0

Re: kernel32: Add tests for job objects (try 3)
by Nikolay Sivov 02 Oct '13

02 Oct '13

On 10/2/2013 12:58, Andrew Cook wrote: > + if(!pCreateJobObjectW) { > + win_skip("No job object support\n"); > + return; > + } Once you checked that I suppose you don't need to check for pIsProcessInJob being null, or it still could happen? > + if (option && strcmp(option, "wait") == 0) { > + /* for job object tests */ > + Sleep(3000); > + return; > + } Is it really necessary?

1 0

Re: winemac: Reapply display modes when switching back to app after "escaping" with Command-Tab.
by Ken Thomases 02 Oct '13

02 Oct '13

On Oct 1, 2013, at 11:24 PM, Ken Thomases wrote: > May fix bug <http://bugs.winehq.org/show_bug.cgi?id=34475>. Should fix bug <http://bugs.winehq.org/show_bug.cgi?id=34209>, too. -Ken

1 0

Re: mshtml: Added support for 'document' and 'window' script for attribute values.
by Marvin 01 Oct '13

01 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2427 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: imm32: ImmGetCandidateWindow should not return unset data
by Alexandre Julliard 01 Oct '13

01 Oct '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) > gl->dwSize = sizeof(GUIDELINE); > ImmUnlockIMCC(new_context->IMC.hGuideLine); > > + memset(new_context->IMC.cfCandForm, -1, sizeof(new_context->IMC.cfCandForm)); > + That's ugly. If you are using the index for validity checking then you should put some appropriate value in there, there's no reason to put garbage in the whole structure. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mscoree: Implement CreateInterface
by Vincent Povirk 01 Oct '13

01 Oct '13

Any reason not to share code with CLRCreateInstance?

1 0

Re: [4/5] gdi32: Fix the B spacing value of empty glyph. (try 2)
by Alexandre Julliard 01 Oct '13

01 Oct '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 2: > - Get rid of redundant trace message in the last patch. > > --- > dlls/gdi32/freetype.c | 2 +- > dlls/gdi32/tests/font.c | 8 +++++++- > 2 files changed, 8 insertions(+), 2 deletions(-) This is causing failures here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:1133: Test succeeded inside todo block: LTR -1 advanced: abcA's sign should be unchanged font.c:1141: Test succeeded inside todo block: LTR -1 advanced: abcfA's sign should be unchanged font.c:1133: Test succeeded inside todo block: RTL 1 advanced: abcA's sign should be unchanged font.c:1141: Test succeeded inside todo block: RTL 1 advanced: abcfA's sign should be unchanged -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests: Fix the test_waittxempty() timeout.
by Francois Gouget 01 Oct '13

01 Oct '13

On Tue, 1 Oct 2013, Francois Gouget wrote: [...] > The timeout was too short and would only work for UARTs that have a > FIFO and where the trigger level was set just right. With this patch > we calculate how much time sending the test data will actually take > and tack on a small margin to take into account scheduling delays. I should note that this does not fix the test failuers on the QEmu VMs, specifically the WineTestBot ones. If QEmu 1.1.2 is anything like QEmu 1.6.0, then the serial port seems to operate at a fixed speed of about 1800000bps. This is so out of line with the 150bps that we request that it causes the test to fail. [...] > * Windows reports that all bytes have been sent not when the UART's > buffer is empty but when they all made it to the UART's buffer. Note > that this can be tested (see next mail). And here is this test. IT IS NOT MEANT TO BE COMMITTED. (but seeing the WineTestBot results would still be interesting) On my one Windows PC with a real UART (Intel(R) 82801DBM LPC Interface Controller - 24CC, i.e. ICH4 which emulates a 16550A UART) I get the following results which clearly illustrate the impact of the FIFO/trigger level. comm.c:1100: WaitCommEvent(1 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(2 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(3 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(4 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(5 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(6 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(7 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(8 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(9 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(10 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(11 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(12 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(13 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(14 bytes) for EV_TXEMPTY took 0 ms comm.c:1100: WaitCommEvent(15 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(16 bytes) for EV_TXEMPTY took 872 ms comm.c:1100: WaitCommEvent(17 bytes) for EV_TXEMPTY took 872 ms comm.c:1100: WaitCommEvent(18 bytes) for EV_TXEMPTY took 872 ms comm.c:1100: WaitCommEvent(19 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(20 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(21 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(22 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(23 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(24 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(25 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(26 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(27 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(28 bytes) for EV_TXEMPTY took 871 ms comm.c:1100: WaitCommEvent(29 bytes) for EV_TXEMPTY took 1802 ms comm.c:1100: WaitCommEvent(30 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(31 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(32 bytes) for EV_TXEMPTY took 1802 ms comm.c:1100: WaitCommEvent(33 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(34 bytes) for EV_TXEMPTY took 1802 ms comm.c:1100: WaitCommEvent(35 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(36 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(37 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(38 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(39 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(40 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(41 bytes) for EV_TXEMPTY took 1802 ms comm.c:1100: WaitCommEvent(42 bytes) for EV_TXEMPTY took 1803 ms comm.c:1100: WaitCommEvent(43 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(44 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(45 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(46 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(47 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(48 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(49 bytes) for EV_TXEMPTY took 2734 ms comm.c:1100: WaitCommEvent(50 bytes) for EV_TXEMPTY took 2734 ms -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

1 0

Re: [3/3] ws2_32: Always return the source address from WSAAccept.
by Marvin 01 Oct '13

01 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2421 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (b0): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (624): unexpectedly at the OOB mark: 0

1 0

Re: [2/3] ws2_32: Return an error from accept if the address buffer is too small.
by Marvin 01 Oct '13

01 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2420 Your paranoid android. === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 757A9799 === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (778): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (7f8): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH] dsound: fixup IDirectSoundCaptureBuffer_QueryInterface
by Andrew Eikum 01 Oct '13

01 Oct '13

Seems reasonable, but could you put together some tests to show this? Andrew On Sat, Sep 28, 2013 at 10:41:15AM +0200, Maarten Lankhorst wrote: > diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c > index 40f1702..0fe300c 100644 > --- a/dlls/dsound/capture.c > +++ b/dlls/dsound/capture.c > @@ -51,7 +51,7 @@ typedef struct IDirectSoundCaptureBufferImpl > IDirectSoundCaptureBuffer8 IDirectSoundCaptureBuffer8_iface; > IDirectSoundNotify IDirectSoundNotify_iface; > LONG numIfaces; /* "in use interfaces" refcount */ > - LONG ref, refn; > + LONG ref, refn, has_dsc8; > /* IDirectSoundCaptureBuffer fields */ > DirectSoundCaptureDevice *device; > DSCBUFFERDESC *pdscbd; > @@ -241,8 +241,9 @@ static HRESULT WINAPI IDirectSoundCaptureBufferImpl_QueryInterface(IDirectSoundC > > *ppobj = NULL; > > - if ( IsEqualGUID( &IID_IDirectSoundCaptureBuffer, riid ) || > - IsEqualGUID( &IID_IDirectSoundCaptureBuffer8, riid ) ) { > + if ( IsEqualIID( &IID_IUnknown, riid ) || > + IsEqualIID( &IID_IDirectSoundCaptureBuffer, riid ) || > + (This->has_dsc8 && IsEqualIID( &IID_IDirectSoundCaptureBuffer8, riid )) ) { > IDirectSoundCaptureBuffer8_AddRef(iface); > *ppobj = iface; > return S_OK; > @@ -1239,6 +1240,8 @@ static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer(IDirectSoundCa > > if (hr != DS_OK) > WARN("IDirectSoundCaptureBufferImpl_Create failed\n"); > + else > + This->device->capture_buffer->has_dsc8 = This->has_dsc8; > > return hr; > } > > >

1 0

Re: [3/3] ws2_32: Always return the source address from WSAAccept.
by Bruno Jesus 01 Oct '13

01 Oct '13

On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/ws2_32/socket.c | 9 +-------- > dlls/ws2_32/tests/sock.c | 6 +++--- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c34de4b..6855298 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -6546,12 +6546,8 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > TRACE("Socket %04lx, sockaddr %p, addrlen %p, fnCondition %p, dwCallbackData %ld\n", > s, addr, addrlen, lpfnCondition, dwCallbackData); > > - > - size = sizeof(src_addr); > - cs = WS_accept(s, &src_addr, &size); > - > + cs = WS_accept(s, addr, addrlen); The parameter addr may be NULL in WSAAccept, I can't check the source code right now but what will WS_accept do in this case? Best wishes, Bruno

2 1

Re: [1/3] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.
by Marvin 01 Oct '13

01 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2419 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (2a4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (774): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (884): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:509: Test failed: oob_server (af8): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (af8): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (af8): error 10054: sock.c:534: Test failed: oob_server (af8): not at the OOB mark: 1

1 0

Re: [PATCH 2/5] wined3d: Move location management into the resource.
by Henri Verbeet 01 Oct '13

01 Oct '13

Please split this.

1 0

Re: [PATCH 2/5] wined3d: Move location management into the resource.
by Stefan Dösinger 01 Oct '13

01 Oct '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, To illustrate the goal of these patches I've attached an archive of all surface cleanup patches to this mail. The goal is to merge GL buffer object handling of buffers, surfaces and volumes. The main motivation for this is to handle WINED3D_MAP_DISCARD in one central place once dynamic resource handling is implemented in the command stream. The 4 patches in this series move location and buffer handling code from volume.c to resource.c. The next patches remove broken(overlay, partial rectangle handling) and half-broken(direct DIB maps, buffers) surface features. The next step is migrating surfaces to the resource location and loading code in resource.c. After that WINED3D_LOCATION_DISCARDED handling is improved and previously removed surface features re-added. Due to the removal of some surface features, performance regressions are possible. I think it's unlikely because the existing surface PBO code doesn't really do what it is supposed to do. Functional regressions should not happen. This patchset does not deal with d3d buffers. The central aspect of merging buffer handling is removing color and rhw conversion support. (or, alternatively, adding a separate location WINED3D_LOCATION_CONVBUFFER if we really want to keep the conversion code.) There are some problems later in the patchset that need fixing: Patch 24 is too big, patches 48 and 52 need to be moved. Non-GL ddraw rendering is broken at the moment (black screen). My patches don't make this any worse, but I'd like to fix it to make sure non-GL operation works as intended. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSSqzhAAoJEN0/YqbEcdMww1wP/jYYo0B/igDHd0QwOkwk8DIz ip4PKHxRgqaSYzswcBGZge+iBrJrvXSHh3cScG9KJ1a/VeaRlPyhDsFDzPce1VDK 0IX7iF/gKpZazPVy21lSIPQMlErSVy58fkIsd/PqKV/zyU8zNyZDkYU3n80itYrq Y3hPhaKbJIDN8QbhIOZu0egaiHObcwomBgZCfrUv+hr+xf+gMERYbqN9gj2JWFwJ dx4EzdeTFw1CZkFExbAJKt5zWA2KeFyitVU887WOSJpa3UbqemGpOID8vnYZlABZ mmqrS22XWjXlo2+0s0NufxeQJHvzpkcludLkg8a12r4FDs+ORYYnGbUeUy2o2Rud uV2quoeucA1TEAyF20JCrVNuCvDz5nvQq19rzR51k7FF/IsKGiI823ZGA54F4Dkn DZkyDcE0rnI2Re+br1aM31ZUt/maTxQMpk10BAAjwz1jbXQ4plZ9dtO9/DObdw8r nfPDJz+DsuBv19Th7MPjTxvXRjxVFTzlfuXNk/cOfAhgNdpEFSOGCAexGi6moSq1 6slQeLb8PqmO/83JQBuz4OI86dSoGSC6O9c/TtWXdW1PgCDyHgFvNb3jmQHsf7ya U1o2TkkNhLvfYz5Eo85Ep8oyVIF09CDrqQzUo10q33K5Y2E3RM8Xbxc+crGtjgxA TGwCwR8SRvAW+DfeP7bq =MEk/ -----END PGP SIGNATURE-----

1 0

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.
by Alexandre Julliard 01 Oct '13

01 Oct '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/ntdll/file.c | 3 ++- > dlls/ntdll/tests/file.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) I don't see the point. Do you actually have an app that depends on this? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: ntdll: Fix the version reported for 64-bit Windows XP.
by Alexandre Julliard 01 Oct '13

01 Oct '13

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -129,11 +129,19 @@ static const RTL_OSVERSIONINFOEXW VersionData[NB_WINDOWS_VERSIONS] = > 4, 0, 0, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field with a value! */ > }, > /* WINXP */ > +#ifdef _WIN64 > + { > + sizeof(RTL_OSVERSIONINFOEXW), 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, > + {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','1',0}, > + 1, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 0 > + }, > +#else > { > sizeof(RTL_OSVERSIONINFOEXW), 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, > {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','3',0}, > 3, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field with a value! */ > }, > +#endif This would mean that the 32-bit side sees a different version. I don't think that's correct. -- Alexandre Julliard julliard(a)winehq.org

1 0

mscoree: Implement CreateInterface
by Alistair Leslie-Hughes 01 Oct '13

01 Oct '13

Hi, Changelog: mscoree: Implement CreateInterface Best Regards Alistair Leslie-Hughes

1 0

oledb32: Implement IDataSourceLocator get/put hWnd (try 4)
by Alistair Leslie-Hughes 01 Oct '13

01 Oct '13

Hi, Corrected warnings. Changelog: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes

1 0

Re: ws2_32: Implement WSASendMsg() (try 3)
by Marvin 01 Oct '13

01 Oct '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2414 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (210): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 71AB8D62 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (6b0): unexpectedly at the OOB mark: 0

1 0

Increasing max_req_size and subsequent errors
by Hugh McMaster 01 Oct '13

01 Oct '13

I need to increase the $max_req_size in tools/make_requests. A new request structure for GetConsoleScreenBufferInfoEx is 80 bytes and primarily made up of 16 unsigned long integers. This is fine, but raises the error: wineserver: request.c:755: open_master_socket: Assertion `sizeof(union generic_reply) == sizeof(struct request_max_size)' failed. It looks like this error is connected to struct request_max_size { int pad[16]; }; in include/wine/server_protocol.h. But other than increasing the size of the array, I'm not sure how to fix this appropriately. Any advice will be appreciated.

1 1

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)
by Bruno Jesus 01 Oct '13

01 Oct '13

On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa <sagawa.aki(a)gmail.com> wrote: > > Fixes bug 18440, 20847. > > Try 3: > - Rebase to recent source. > - Separate ABC metrics change. > - Use conditional operator. > --- > dlls/gdi32/freetype.c | 4 ++-- > dlls/gdi32/tests/font.c | 24 ++++++++---------------- > 2 files changed, 10 insertions(+), 18 deletions(-) > + ok(gm.gmBlackBoxY == 1, "%2d:expected 1, got %u\n", fmt[i], gm.gmBlackBoxX); There seems to be a copy&paste issue in all lines related to gmBlackBoxY reporting the error as gmBlackBoxX. Regards, Bruno

1 0

Re: wldap32: Use BOOL type where appropriate
by Rico Schüller 30 Sep '13

30 Sep '13

On 01.10.2013 00:06, Frédéric Delanoy wrote: > --- > dlls/wldap32/init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/wldap32/init.c b/dlls/wldap32/init.c > index b5aed58..54b5b24 100644 > --- a/dlls/wldap32/init.c > +++ b/dlls/wldap32/init.c > @@ -113,13 +113,13 @@ oom: > } > > /* Determine if a URL starts with a known LDAP scheme */ > -static int has_ldap_scheme( char *url ) > +static BOOL has_ldap_scheme( char *url ) > { > if (!strncasecmp( url, "ldap://", 7 ) || > !strncasecmp( url, "ldaps://", 8 ) || > !strncasecmp( url, "ldapi://", 8 ) || > - !strncasecmp( url, "cldap://", 8 )) return 1; > - return 0; > + !strncasecmp( url, "cldap://", 8 )) return TRUE; > + return FALSE; > } > > /* Flatten an array of hostnames into a space separated string of URLs. > You probably may return the "value" of the if statement directly instead of returning TRUE / FALSE. Cheers Rico

1 0

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)
by Alexandre Julliard 30 Sep '13

30 Sep '13

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID buffer, DWORD data_size, DWORD > } > > /*********************************************************************** > + * WSASendMsg > + */ > +int WINAPI WSASendMsg( SOCKET s, LPWSAMSG msg, DWORD dwFlags, LPDWORD lpNumberOfBytesSent, > + LPWSAOVERLAPPED lpOverlapped, > + LPWSAOVERLAPPED_COMPLETION_ROUTINE lpCompletionRoutine) > +{ > + int ret = SOCKET_ERROR, fd, sock_type; > + socklen_t optlen = sizeof(sock_type); > + > + if (!msg) > + { > + SetLastError(WSAEFAULT); > + return SOCKET_ERROR; > + } > + > + if ( (fd = get_sock_fd( s, 0, NULL )) == -1) > + return SOCKET_ERROR; > + > + if (getsockopt(fd, SOL_SOCKET, SO_TYPE, &sock_type, &optlen) == -1) > + { > + SetLastError((errno == EBADF) ? WSAENOTSOCK : wsaErrno()); > + goto cleanup; > + } > + > + if (sock_type != SOCK_DGRAM && sock_type != SOCK_RAW) > + { > + SetLastError(WSAEINVAL); > + goto cleanup; > + } > + > + ret = WS2_sendto( s, msg->lpBuffers, msg->dwBufferCount, lpNumberOfBytesSent, > + dwFlags, msg->name, msg->namelen, > + lpOverlapped, lpCompletionRoutine ); This is redundant, WS2_sendto will already fetch the file descriptor, any necessary error checking should happen there. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)
by Nikolay Sivov 30 Sep '13

30 Sep '13

On 9/30/2013 00:51, Daniel Jeliński wrote: > +struct progress_list { > + const DWORD progress_retval_init; /* value to return from progress routine */ > + const BOOL cancel_init; /* value to set Cancel flag to */ > + const DWORD progress_retval_end; /* value to return from progress routine */ > + const BOOL cancel_end; /* value to set Cancel flag to */ > + const DWORD progress_count; /* number of times progress is invoked */ > + const BOOL copy_retval; /* expected CopyFileEx result */ > + const DWORD lastError; /* expected CopyFileEx error code */ > +} ; I don't see a point making them 'const'. > +static DWORD WINAPI progress(LARGE_INTEGER TotalFileSize, > + LARGE_INTEGER TotalBytesTransferred, > + LARGE_INTEGER StreamSize, > + LARGE_INTEGER StreamBytesTransferred, > + DWORD dwStreamNumber, > + DWORD dwCallbackReason, > + HANDLE hSourceFile, > + HANDLE hDestinationFile, > + LPVOID lpData) > +{ > + progressInvoked++; Please pass all globals as context data with lpData, and please use 'void*' instead of LPVOID.

3 3

Re: atl90: Add new DLL
by Zhenbo Li 30 Sep '13

30 Sep '13

2013/9/4 Zhenbo Li <litimetal(a)gmail.com>: > This patch could fix bug 34431, which is caused by missing atl90.dll > > --- > configure | 1 + > configure.ac | 1 + > dlls/atl90/Makefile.in | 7 ++++ > dlls/atl90/atl90.c | 93 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/atl90/atl90.spec | 52 ++++++++++++++++++++++++++++ > include/atlbase.h | 1 + > tools/make_specfiles | 1 + > 7 files changed, 156 insertions(+) Excuse me, this is my first time to submit a patch to Wine. And I don't know that if I had made some mistakes. Would someone please review my patch and tell me what to do? Thank you. -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 1/2] setupapi: Also look in datadir/fakedlls for the re-compiled fakedlls.
by Alexandre Julliard 30 Sep '13

30 Sep '13

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/setupapi/fakedll.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) I don't think that's correct. The datadir is for platform-independent files, but the fakedlls are platform specific. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mmdevapi/tests: test MMDevPropStore_GetAt
by Marvin 30 Sep '13

30 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2403 Your paranoid android. === wvista (32 bit propstore) === propstore.c:108: Test failed: DEVPKEY_Device_FriendlyName not found

1 0

Re: kernel32/time: Implement GetSystemTimes for linux.
by Bernard Ladenthin 29 Sep '13

29 Sep '13

Am 29.09.2013 20:08, schrieb André Hentschel: > Am 28.09.2013 21:51, schrieb Bernard Ladenthin: >> --- >> dlls/kernel32/time.c | 149 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 149 insertions(+) > > > Hi, > please don't use C++ comments, also the rest of the coding style isn't often seen in Wine... > (e.g. missing space between if/for/... and the bracket, your way of variable definig/initializing, most likely more) > > maybe you also want to change the FIXME into something like "not implemented for this platform" and add a TRACE for the linux way. > > > Hi, thanks for the feedback, I will write a new patch. Regards, Bernard

1 0

Re: add ualapi directory (try 12)
by Bruno Jesus 29 Sep '13

29 Sep '13

I still don't understand why the copyright is different for the .c and .h file. In one file you add your first name only and in the other your full name. Regards, Bruno On Sat, Sep 28, 2013 at 4:14 AM, Akira Nakagawa <matyapiro31(a)gmail.com> wrote: > > > > > > -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2393 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (1d0): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (5a0): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:509: Test failed: oob_server (b64): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (b64): unexpectedly at the OOB mark: 0 === w7pro64 (64 bit sock) === sock.c:509: Test failed: oob_server (650): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (650): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (650): error 10054: sock.c:534: Test failed: oob_server (650): not at the OOB mark: 1

1 0

Re: [1/3] ws2_32/tests: Fix an ok() call comment
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2392 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (748): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:519: Test failed: oob_server (998): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (2f0): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (2f0): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (2f0): error 10054: sock.c:534: Test failed: oob_server (2f0): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:509: Test failed: oob_server (938): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (938): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 000007FEFE229CD9

1 0

Re: [website] templates: More protocol relative urls
by Jactry Zeng 28 Sep '13

28 Sep '13

Hi André, This patch seem let some urls in non-english version broken. Such as some urls in this page in Chinese: http://www.winehq.org/site/forums >- [<a href="http://www.winehq.org/mailman/listinfo/wine-announce ">（取消）订阅</a>] >- [<a href="http://www.winehq.org/pipermail/wine-announce/">存档 1</a>] >+ [<a href=//www.winehq.org/mailman/listinfo/wine-announce">（取消）订阅</a>] >+ [<a href=//www.winehq.org/pipermail/wine-announce/">存档 1</a>] You will find there is a quotation mark in the end of some urls in this page. We may need to remove the / in the end? >-<p> Wine 将会永远是<a href="http://www.winehq.org/license"title="Wine licensing">自由软件</a>。 >+<p> Wine 将会永远是<a href=//www.winehq.org/license"title="Wine licensing">自由软件</a>。 And the about page in Chinese, the urls of "自由软件" (Free Software) also been broken. There seem need a space or a enter between the url and 'title'. Thanks for your work! 2013/9/23 André Hentschel <nerv(a)dawncrow.de> > --- > templates/he/about.template | 2 +- > templates/he/forums.template | 46 > +++++++++++++++++++-------------------- > templates/he/help.template | 8 +++---- > templates/he/home.template | 4 ++-- > templates/he/license.template | 6 +++--- > templates/he/resources.template | 6 +++--- > templates/pl/forums.template | 2 +- > templates/pt/about.template | 4 ++-- > templates/pt/forums.template | 48 > ++++++++++++++++++++--------------------- > templates/pt/help.template | 8 +++---- > templates/pt/home.template | 4 ++-- > templates/zh-cn/about.template | 6 +++--- > templates/zh-cn/forums.template | 44 ++++++++++++++++++------------------- > templates/zh-cn/help.template | 8 +++---- > templates/zh-cn/home.template | 4 ++-- > templates/zh-cn/irc.template | 4 ++-- > 16 files changed, 102 insertions(+), 102 deletions(-) > > > > > > -- Regards, Jactry Zeng

1 0

Re: add ualapi directory (try 11)
by Marcus Meissner 28 Sep '13

28 Sep '13

On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote: > > > > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapiro31(a)gmail.com> > From: Akira Nakagawa <matyapiro31(a)gmail.com> > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [PATCH] add ual directory (try9) > > --- > configure | 2 + Not needed to be submitted > configure.ac | 2 + also not actually needed as these parts are autogenerated. > dlls/ualapi/Makefile.in | 6 +++ > dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++ > dlls/ualapi/tests/Makefile.in | 8 ++++ > dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++ You have no working tests yet, so leave these two files out. Add them with the patch with the first tests. > dlls/ualapi/ualapi.spec | 4 ++ > include/Makefile.in | 1 + include/Makefile.in is also autoadjusted. > include/ual.h | 48 +++++++++++++++++++++++ > 9 files changed, 195 insertions(+) rest looks ok, but you really only should submit: dlls/ualapi/Makefile.in dlls/ualapi/main.c dlls/ualapi/ualapi.spec include/ual.h as the rest are autogenerated. Ciao, Marcus

2 1

Re: add ualapi directory (try 12)
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2391 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2388 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (1c4): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:509: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (870): unexpectedly at the OOB mark: 0 sock.c:288: Test failed: do_synchronous_recv (870): error 10054: sock.c:534: Test failed: oob_server (870): not at the OOB mark: 1

1 0

Re: [1/2] ws2_32/tests: Fix an ok() call comment
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2387 Your paranoid android. === wxppro (32 bit sock) === sock.c:519: Test failed: oob_server (408): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:509: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 sock.c:519: Test failed: oob_server (bb8): unexpectedly at the OOB mark: 0 === w7pro64 (32 bit sock) === sock.c:528: Test failed: oob_server (6f0): not at the OOB mark: 1 === w2008s64 (64 bit sock) === sock.c:519: Test failed: oob_server (940): unexpectedly at the OOB mark: 0

1 0

Re: [2/2] ws2_32: Implement WSASendMsg()
by Bruno Jesus 28 Sep '13

28 Sep '13

On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

1 0

Re: add ualapi directory (try 11)
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2386 Your paranoid android. === build (build) === Make failed

1 0

Re: (try 6)[5/5] imm32: limit cross thread access to ImmSet* functions
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2377 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[4/5] imm32: Restrict crossthread Association and destruction
by Marvin 28 Sep '13

28 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2376 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 6)[3/5] imm32: use thread data from target HWND
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2375 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] appwiz.cpl: Use the same dialog template for Mono and Gecko downloader.
by Vincent Povirk 27 Sep '13

27 Sep '13

Isn't this going to make the caption "Wine Gecko Installer" in both cases?

1 0

Re: add ualapi directory (try 10)
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2370 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.
by Stefan Dösinger 27 Sep '13

27 Sep '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: > - swapchain->swapchain_ops->swapchain_present(swapchain, > src_rect, dst_rect, dirty_region, flags); + > wined3d_cs_emit_present(swapchain->device->cs, swapchain, > src_rect, + dst_rect, dst_window_override, dirty_region, > flags); I think we should place comments like "This function is called through the command stream" for all functions that are called through the CS, similar to what we do for context activation. Also note that swapchain_gl_present contains calls to wined3d_surface_blt and wined3d_device_clear that are going to cause problems with the multithreaded CS. I have patches to remove them, so feel free to ignore this problem for now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSRWaKAAoJEN0/YqbEcdMw9VgP/i2n/G2CHOA8XShC8CZnRzSq TNzbfIXwAQljQYtf66U98JmbMIoeS3SMPaJ4O1+mMiT062Udi3YddiTk2AVF9bi+ f6X4y9W8Q3jPolcuTxKpZ26/WFkViHtPEUtFaa5oBtksCNGZ0b3A4oK9zbrPBram EXwovsq649RqCoBf76aidtbypdkFKLfmC6P6KxtjB3C9cdKJ58kMD0YbVsua6zNc g8gUgExEQ0no9WEyWPtlN7PRf3tQlLtuUeqrRockqnK48cKbwk3VaEgfq8o6+INs EvgjoZvc2C/+YoEWUT+n7nCtIKo9IiMSG20Ey0sbmak/K/LrvZvsyHl78nQD4ss+ t5jRCS9QZs/VzJc0VakGsZARP9jGBvzapsrAcy6Ittu1d53fpji6ySwKeUrPKim+ wMtWGtu+q0FXtIRtgDYUOofd9b1o1sB3xPqUIpRm7+yBRpXiBvuGqbmbsa/14wBe vkI5b5S/djskw9M5bV1lAOCgGmo+zFIYyebxwvx8H+sqz4HmYql9uPLTOHqWvHtn J7iXcETOlcOrC+zOOT8nieR8YYuFcda51auvK5lnXtCTQvoQse5egV16x2hJkkjx Pujit58jX2/O0WS0hqR5oAfhYtPydqUf2BayXgkLUODiZa0z1UWD2eerlOvGSvcq AUs+vi2QpDjeWmQH37BZ =QcW+ -----END PGP SIGNATURE-----

2 3

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)
by Alexandre Julliard 27 Sep '13

27 Sep '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Fixes bug 18440, 20847. > > Try 3: > - Rebase to recent source. > - Separate ABC metrics change. > - Use conditional operator. It breaks the tests: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c && touch dib.ok dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 1 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 dib.c:2827: Test failed: hash mismatch - aa 0 make[1]: *** [dib.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)
by Nikolay Sivov 27 Sep '13

27 Sep '13

On 9/13/2013 13:27, Jactry Zeng wrote: > Re-based to latest git. > > Does it actually accept any other value besides CP_ACP or 1200? Documentation is unclear here, and makes impression that only two these values are valid.

2 2

Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Marvin 27 Sep '13

27 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid android. === w7u (32 bit font) === The test timed out

1 0

Re: [3/3] gdi32: Don't modify output glyph metrics unless the function succeeds. (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2352 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/3] gdi32: Return GDI_ERROR when requested empty glyph bitmaps. (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2350 Your paranoid android. === w7u (32 bit font) === No test summary line found Failure running script in VM: network read timed out

1 0

Re: [PATCH 1/2] gdi32: fix for rotated Arc, ArcTo, Chord and Pie drawing problem (try 2)
by Alexandre Julliard 26 Sep '13

26 Sep '13

Daniel Wendt <daniel.wendt(a)linux.com> writes: > @@ -308,6 +308,11 @@ static int get_arc_points( PHYSDEV dev, const RECT *rect, POINT start, POINT end > } > > memmove( points, points + count, (pos - count) * sizeof(POINT) ); > + > + if (GetGraphicsMode( dev->hdc ) == GM_ADVANCED) > + { > + LPtoDP( dev->hdc, points, pos - count ); > + } > return pos - count; > } > > @@ -322,7 +327,17 @@ static BOOL draw_arc( PHYSDEV dev, INT left, INT top, INT right, INT bottom, > BOOL ret = TRUE; > HRGN outline = 0, interior = 0; > > - if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + if (GetGraphicsMode(dev->hdc ) != GM_ADVANCED) > + { > + if (!get_pen_device_rect( pdev, &rect, left, top, right, bottom )) return TRUE; > + } > + else > + { > + rect.left = left; > + rect.top = top; > + rect.right = right; > + rect.bottom = bottom; > + } I don't think that you want to draw arcs in logical space, that can be very inefficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation (try2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2349 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: imm32: ImmGetDescriptionA return does not include NULL byte
by Alexandre Julliard 26 Sep '13

26 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1684,7 +1684,7 @@ UINT WINAPI ImmGetDescriptionA( > > HeapFree( GetProcessHeap(), 0, buf ); > > - return len; > + return min( len - 1, uBufLen ); > } This may do the right thing on failure, but in an ugly way. A few overflow tests would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] riched20: Implement ITextDocument_fnOpen.
by Alexandre Julliard 26 Sep '13

26 Sep '13

Jactry <jactry92(a)gmail.com> writes: > + chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2); > + if(!chBuffer) > + { > + CloseHandle(hFile); > + return HRESULT_FROM_WIN32(GetLastError()); > + } It's not useful to zero the buffer since you are reading into it. Also GetLastError won't do anything useful here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)
by Alexandre Julliard 26 Sep '13

26 Sep '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > @@ -6519,11 +6519,17 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, > } > > lpgm->gmBlackBoxX = (right - left) >> 6; > + if (lpgm->gmBlackBoxX == 0) > + lpgm->gmBlackBoxX = 1; > lpgm->gmBlackBoxY = (top - bottom) >> 6; > + if (lpgm->gmBlackBoxY == 0) > + lpgm->gmBlackBoxY = 1; > lpgm->gmptGlyphOrigin.x = origin_x >> 6; > lpgm->gmptGlyphOrigin.y = origin_y >> 6; > abc->abcA = left >> 6; > abc->abcB = (right - left) >> 6; > + if (abc->abcB == 0) > + abc->abcB = 1; > abc->abcC = adv - abc->abcA - abc->abcB; It would be a good idea to add tests for the ABC metrics too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 26 Sep '13

26 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -530,12 +591,18 @@ static BOOL CALLBACK _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) > */ > BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > { > + IMMThreadData* thread_data = NULL; > + > TRACE("(%p, %p, 0x%x):\n", hWnd, hIMC, dwFlags); > > - if (!IMM_GetThreadData()->defaultContext) > - IMM_GetThreadData()->defaultContext = ImmCreateContext(); > + thread_data = IMM_GetInitializedThreadData(); > + if (!thread_data) > + return FALSE; > > - if (!hWnd) return FALSE; > + LeaveCriticalSection(&threaddata_cs); > + > + if (!hWnd) > + return FALSE; > > switch (dwFlags) > { > @@ -543,7 +610,7 @@ BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > ImmAssociateContext(hWnd,hIMC); > return TRUE; > case IACE_DEFAULT: > - ImmAssociateContext(hWnd,IMM_GetThreadData()->defaultContext); > + ImmAssociateContext(hWnd,thread_data->defaultContext); > return TRUE; > case IACE_IGNORENOCONTEXT: > if (GetPropW(hWnd,szwWineIMCProperty)) You shouldn't be accessing thread data outside of the critical section. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2346 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2344 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2343 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2342 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2341 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dlls: Replace the remaining CONSTs.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2340 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Perform the offset checks in NtWriteFile also for a serial device.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2339 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Perform the offset checks also for a serial device.
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2267 Your paranoid android. === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:892: WaitCommEvent for EV_TXEMPTY took 1014 ms (timeout 1000) comm.c:894: Test failed: WaitCommEvent used 1014 ms for waiting comm.c:1561: test_AbortWaitCts timeout 500 handle 000000F8 comm.c:1528: Changing CommMask on the fly for handle 000000F8 after timeout 500

3 7

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (try 2)
by Marvin 26 Sep '13

26 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2338 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: user32: Avoid using CONST.
by Marvin 25 Sep '13

25 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2332 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify
by Alexandre Julliard 25 Sep '13

25 Sep '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > --- > dlls/winex11.drv/event.c | 99 > +++++++++++++++++++++++++++------------------- > 1 file changed, 58 insertions(+), 41 deletions(-) These should go in the patches that need them. Also you should start your series with reparent support, the rest doesn't make sense without it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.
by Matteo Bruni 25 Sep '13

25 Sep '13

2013/9/24 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/effect.c | 248 > +++++++++++++++++++------------------------------ > 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) > I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * param = state->parameter; + /* + * TODO: Do we need to create the shader/string here or later when we access them? + */ Here it's fine AFAICS. What are the other options you are thinking about? Something like creating the shaders at the first Begin / BeginPass call?

3 2

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)
by Jacek Caban 25 Sep '13

25 Sep '13

Hi Hans, On 09/18/13 13:40, Hans Leidekker wrote: > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index bf57223..2526681 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -4777,8 +4777,37 @@ static const struct notification async_send_request_ex_resolve_failure_test[] = > { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING, 0, } > }; > > +static const struct notification async_send_request_ex_chunked_test[] = > +{ > + { internet_connect, INTERNET_STATUS_HANDLE_CREATED }, > + { http_open_request, INTERNET_STATUS_HANDLE_CREATED }, > + { http_send_request_ex, INTERNET_STATUS_DETECTING_PROXY, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_COOKIE_SENT, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_RESOLVING_NAME, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_NAME_RESOLVED, 1, 0, 1 }, > + { http_send_request_ex, INTERNET_STATUS_CONNECTING_TO_SERVER, 1 }, > + { http_send_request_ex, INTERNET_STATUS_CONNECTED_TO_SERVER, 1 }, > + { http_send_request_ex, INTERNET_STATUS_SENDING_REQUEST, 1 }, > + { http_send_request_ex, INTERNET_STATUS_REQUEST_SENT, 1 }, > + { http_send_request_ex, INTERNET_STATUS_REQUEST_COMPLETE, 1 }, > + { http_end_request, INTERNET_STATUS_RECEIVING_RESPONSE, 1 }, > + { http_end_request, INTERNET_STATUS_RESPONSE_RECEIVED, 1 }, > + { http_end_request, INTERNET_STATUS_REQUEST_COMPLETE, 1 }, > + { internet_close_handle, INTERNET_STATUS_CLOSING_CONNECTION }, > + { internet_close_handle, INTERNET_STATUS_CONNECTION_CLOSED }, > + { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING }, > + { internet_close_handle, INTERNET_STATUS_HANDLE_CLOSING } > +}; > + > static const struct notification_data notification_data[] = { > { > + async_send_request_ex_chunked_test, > + sizeof(async_send_request_ex_chunked_test)/sizeof(async_send_request_ex_chunked_test[0]), > + "GET", > + "test.winehq.org", > + "tests/data.php" > + }, > + { > async_send_request_ex_test, > sizeof(async_send_request_ex_test)/sizeof(async_send_request_ex_test[0]), > "POST", > @@ -5100,6 +5129,7 @@ START_TEST(http) > test_async_HttpSendRequestEx(&notification_data[0]); > test_async_HttpSendRequestEx(&notification_data[1]); > test_async_HttpSendRequestEx(&notification_data[2]); > + test_async_HttpSendRequestEx(&notification_data[3]); > InternetOpenRequest_test(); > test_http_cache(); > InternetOpenUrlA_test(); I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the right direction, so I'm fine with your patch. Thanks, Jacek

2 2

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts
by Nikolay Sivov 25 Sep '13

25 Sep '13

On 9/25/2013 16:03, Aric Stewart wrote: > defaultContext = ImmCreateContext(); > + if (defaultContext) > + ((InputContextData*)defaultContext)->threadDefault = TRUE; I think a nicer way is to let ImmCreateContext() set this attribute.

2 1

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Nikolay Sivov 25 Sep '13

25 Sep '13

On 9/25/2013 16:03, Aric Stewart wrote: > + if (!thread_data->defaultContext) > + { > + HIMC defaultContext; > + LeaveCriticalSection(&threaddata_cs); > + defaultContext = ImmCreateContext(); > + thread_data = IMM_GetThreadData(0); Why do you need to unlock/lock around ImmCreateContext()? Is it related to SendMessage() it calls?

2 1

Re: (try 4)[1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 25 Sep '13

25 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/imm32/imm.c | 153 +++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 116 insertions(+), 37 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok err:ntdll:RtlpWaitForCriticalSection section 0x55ec38e8 "imm.c: threaddata_cs" wait timed out in thread 005c, blocked by 0031, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7bccc200 "loader.c: loader_section" wait timed out in thread 0060, blocked by 005c, retrying (60 sec) -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Gecko 2.24-beta1
by Jacek Caban 25 Sep '13

25 Sep '13

Hi all, It's time to do another update of Wine Gecko, so I prepared a new beta build. It's already on Sourceforge [1]. Until server-side support for auto install of the package is committed [2], its manual installation is required [3]. I attached a patch to Wine that is required for the new Gecko. Anything that uses MSHTML is worth testing. All help with testing is appreciated! Cheers, Jacek [1] https://sourceforge.net/projects/wine/files/Wine%20Gecko/2.24-beta1/ [2] http://source.winehq.org/patches/data/97881 [3] http://wiki.winehq.org/Gecko

2 2

Re: crypt32: Support HCCE_LOCAL_MACHINE.
by Juan Lang 25 Sep '13

25 Sep '13

Hi Ben, thanks for having a whack at this. Some tests would be nice. -static HCERTCHAINENGINE CRYPT_defaultChainEngine; +/* There are two default chain engines which correspond to HCCE_CURRENT_USER and + * HCCE_LOCAL_MACHINE. +*/ +static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL, NULL }; C automatically initializes statics to 0, so the initialization here is unnecessary. I'm also a little uncertain about the use of an array of two objects, I'm not sure that two distinct objects wouldn't be easier to follow, but I'm not religious on this point. + if (hChainEngine > HCCE_LOCAL_MACHINE + && InterlockedDecrement(&engine->ref) == 0) I think a function that returns whether an HCERTCHAINENGINE is one of the special ones would make this easier to read, e.g.: static int is_special_chain_engine(HCERTCHAINENGINE h) { return h == HCCE_CURRENT_USER || h == HCCE_LOCAL_MACHINE; } then: + if (is_special_chain_engine(hChainEngine) + && InterlockedDecrement(&engine->ref) == 0) +static HCERTCHAINENGINE CRYPT_GetDefaultChainEngine(HCERTCHAINENGINE h) { - if (!CRYPT_defaultChainEngine) + if (!CRYPT_defaultChainEngine[(int)h]) The constant casting is a little awkward. At least introduce a local pointer to the one you intend to modify, so we're not constantly having to re-read that cast. + if (hChainEngine <= HCCE_LOCAL_MACHINE) + engine = (CertificateChainEngine*)CRYPT_GetDefaultChainEngine( + hChainEngine); if (TRACE_ON(chain)) dump_chain_para(pChainPara); /* FIXME: what about HCCE_LOCAL_MACHINE? */ See my earlier suggestion on is_special_chain_engine. Also, what about that comment three lines down? Can't it be removed? -void default_chain_engine_free(void) +void default_chain_engine_free(HCERTCHAINENGINE h) { - CertFreeCertificateChainEngine(CRYPT_defaultChainEngine); + CertFreeCertificateChainEngine(CRYPT_defaultChainEngine[(int)h]); The function default_chain_engine_free is a thin wrapper around CryptFreeCertificateChainEngine; its intended use is to clear memory at shutdown. Rather than shift the responsibility of knowing which engines to free to the caller, just have it free the two engines itself. Thanks, --Juan

1 0

Re: [2/2] oleaut32: LoadRegTypeLib() should check actual typelib version
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2330 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (try 3) [1/4] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 24 Sep '13

24 Sep '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -443,6 +473,28 @@ static InputContextData* get_imc_data(HIMC hIMC) > return data; > } > > +static BOOL ensure_default_imc(IMMThreadData** thread_data) > +{ > + if (!(*thread_data)->defaultContext) > + { > + HIMC defaultContext; > + LeaveCriticalSection(&threaddata_cs); > + defaultContext = ImmCreateContext(); > + *thread_data = IMM_GetThreadData(0); > + if (!(*thread_data)) > + { > + IMM_DestroyContext(defaultContext); > + return FALSE; > + } > + > + if ((*thread_data)->defaultContext) /* someone beat us */ > + IMM_DestroyContext(defaultContext); > + else > + (*thread_data)->defaultContext = defaultContext; > + } > + return TRUE; > +} That's fairly inelegant, try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Android has struct user in asm/user.h
by André Hentschel 24 Sep '13

24 Sep '13

Am 24.09.2013 17:13, schrieb Huw Davies: > --- > configure.ac | 1 + > server/ptrace.c | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) is that for the warning about the missing casts?

2 1

Virus spread via wine
by Dan Kegel 24 Sep '13

24 Sep '13

Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

2 3

Re: [PATCH 4/5] d3d8/tests: Add a volume V16U16 test.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2318 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2317 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: server/protocol.def and array types
by Hugh McMaster 24 Sep '13

24 Sep '13

Any help for this? -------------------------------------------------------------- I'm testing support for GetConsoleScreenBufferInfoEx. At the moment, I've extended the screen_buffer struct in server/console.c to look like this: struct screen_buffer { struct object obj; /* object header */ struct list entry; /* entry in list of all screen buffers */ struct console_input *input; /* associated console input */ int mode; /* output mode */ int cursor_size; /* size of cursor (percentage filled) */ int cursor_visible;/* cursor visibility flag */ int cursor_x; /* position of cursor */ int cursor_y; /* position of cursor */ int width; /* size (w-h) of the screen buffer */ int height; int max_width; /* size (w-h) of the window given font size */ int max_height; char_info_t *data; /* the data for each cell - a width x height matrix */ unsigned short attr; /* default attribute for screen buffer */ rectangle_t win; /* current visible window on the screen buffer * * as seen in wineconsole */ struct fd *fd; /* for bare console, attached output fd */ unsigned short popup_attr; /* the console popup fill attribute */ BOOL fullscreen; /* indicates whether fullscreen mode is supported */ COLORREF colortable[16];/* an array of DWORD values */ }; In server/protocol.def I have: @REQ(get_console_output_info) obj_handle_t handle; /* handle to the console */ @REPLY short int cursor_size; /* size of cursor (percentage filled) */ short int cursor_visible;/* cursor visibility flag */ short int cursor_x; /* position of cursor (x, y) */ short int cursor_y; short int width; /* width of the screen buffer */ short int height; /* height of the screen buffer */ short int attr; /* default attribute */ short int win_left; /* window actually displayed by renderer */ short int win_top; /* the rect area is expressed within the */ short int win_right; /* boundaries of the screen buffer */ short int win_bottom; short int max_width; /* maximum size (width x height) for the window */ short int max_height; short int popup_attr; /* the console popup fill attribute */ short int fullscreen; /* indicates whether fullscreen mode is supported */ --> type??? colortable; /* a COLORREF array of DWORD values */ @END While colortable is a COLORREF array, protocol.def does not allow types such as DWORD, COLORREF, etc. What type should colortable be given to pass tools/make_requests?

1 0

Re: [PATCH 5/5] ddraw: Avoid VOID.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2316 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: add ualapi directory (try 9
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2313 Your paranoid android. === build (build) === Missing build status line The build timed out

2 1

Re: advapi32/tests: Mark a test result as broken.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2315 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [1/2] winhttp/tests: Remove explicit zero-intialization of static data.
by Marvin 24 Sep '13

24 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2314 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] wined3d: Introduce a function to initialize swapchain specific device state.
by Alexandre Julliard 24 Sep '13

24 Sep '13

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/wined3d/device.c | 51 +++++++++++++++++---------------------------- > dlls/wined3d/stateblock.c | 5 +---- > 2 files changed, 20 insertions(+), 36 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok wine: Unhandled page fault on read access to 0x0000002c at address 0x686aa077 (thread 004f), starting debugger... Unhandled exception: page fault on read access to 0x0000002c in 32-bit code (0x686aa077). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686aa077 ESP:0032f890 EBP:0032f978 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:6879e6d0 ECX:0032f9e0 EDX:00000000 ESI:0014e23c EDI:00000000 Stack dump: 0x0032f890: 00000001 00000001 00000000 567a5784 0x0032f8a0: 0000851a 00000000 00008058 00000001 0x0032f8b0: 00000001 00000001 00000000 00000000 0x0032f8c0: 0000001e 00000012 0032f9ec 00000000 0x0032f8d0: 00000001 00000000 00000000 00000000 0x0032f8e0: 00000000 7e0bd298 0032f9ec 00008035 Backtrace: =>0 0x686aa077 device_clear_render_targets+0x77(device=0x142208, rt_count=0x8, fb=0x14e23c, rect_count=0, rects=(nil), draw_rect=0x32f9e0, flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d (0x0032f978) 1 0x686b0b67 wined3d_device_clear+0x136(device=0x142208, rect_count=0, rects=(nil), flags=0x1, color=0x6875e2bc, depth=1.000000, stencil=0) [/home/julliard/wine/wine/dlls/wined3d/device.c:3501] in wined3d (0x0032fa08) 2 0x686b613c wined3d_device_init_3d+0x3fb(device=<couldn't compute location>, swapchain_desc=<couldn't compute location>) [/home/julliard/wine/wine/dlls/wined3d/device.c:940] in wined3d (0x0032fa98) 3 0x6864d008 dxgi_factory_CreateSwapChain+0x127(iface=<couldn't compute location>, device=<couldn't compute location>, desc=<couldn't compute location>, swapchain=<couldn't compute location>) [/home/julliard/wine/wine/dlls/dxgi/factory.c:232] in dxgi (0x0032fb38) 4 0x6862b5aa func_device+0x13f9() [/home/julliard/wine/wine/dlls/dxgi/tests/../../../include/dxgi.h:2037] in dxgi_test (0x0032fcf8) 5 0x6862c165 run_test+0x144(name=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:570] in dxgi_test (0x0032fd48) 6 0x68629c23 main+0x152(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/dlls/d3d10core/tests/../../../include/wine/test.h:640] in dxgi_test (0x0032fe08) 7 0x6862cbb0 __wine_spec_exe_entry+0x7f(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in dxgi_test (0x0032fe58) 8 0x7b85f36c call_process_entry+0xb() in kernel32 (0x0032fe78) 9 0x7b86054b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0032feb8) 10 0x7bc7fd50 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 11 0x7bc82c5d call_thread_func+0x7c(entry=0x7b8604e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2602] in ntdll (0x0032ffa8) 12 0x7bc7fd2e call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 13 0x7bc5492e start_process+0x1d(kernel_start=0x7b8604e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2694] in ntdll (0x0032ffe8) 14 0x6803125d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 15 0x6803131b wine_switch_to_stack+0x2a(func=0x7bc54910, arg=0x7b8604e0, stack=0x330000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xff8613b8) 16 0x7bc5a467 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2750] in ntdll (0xff861428) 17 0x7b866ac0 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xff862338) 18 0x7bc5ab33 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2959] in ntdll (0xff8623c8) 19 0x6802eea2 wine_init+0x2a1(argc=0x3, argv=0xff862904, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xff862428) 20 0x7bf00d3b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xff862868) 21 0x682518c5 __libc_start_main+0xf4() in libc.so.6 (0x00000000) 0x686aa077 device_clear_render_targets+0x77 [/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d: movl 0x2c(%edx),%eax 219 || draw_rect->right < target->resource.width -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching
by Austin English 23 Sep '13

23 Sep '13

---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Sep 23, 2013 at 12:04 PM Subject: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: "Pencils Down" and Final Evaluation Dates Approaching To: GSoC Mentors Announce <gsoc-mentors-announce(a)googlegroups.com> Hi GSoC 2013 mentors and org admins, This is just a friendly reminder that final evaluations are now open and must be submitted by this Friday, 27 September at 19:00 UTC. Don't delay, submit today! Thanks, Carol -- -Austin

1 0

Re: [1/3] winex11: Splitted functions X11DRV_FocusOut (try 2)
by Alexandre Julliard 23 Sep '13

23 Sep '13

Sebastian Lackner <sebastian(a)fds-team.de> writes: > - when "virtually" reparenting the plugin window as a child of a > "foreign" window (similar to the systray code) its not possible to get > the focus anymore - the focus code always tries to request the focus for > the WS_POPUP parent, which is a foreign window in this case, and thus > fails. I don't see an easy way to detect/handle if a window is embedded > from user32-code without changing a lot of stuff there - thats why > Pipelight creates the plugin window as a WS_POPUP and makes wine think > it doesn't have any parent (which only has the disadvantage that wine > cannot track the correct window position). I think you really should make it work like the systray and keep track of the hierarchy. You'll run into a lot of hard to fix bugs otherwise. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: add ualapi directory (try 9
by Jacek Caban 23 Sep '13

23 Sep '13

Hi Akira, On 09/23/13 10:00, Akira Nakagawa wrote: > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapiro31(a)gmail.com> > From: Akira Nakagawa <matyapiro31(a)gmail.com> > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [PATCH] add ual directory (try9) > > --- > configure | 2 + > configure.ac | 2 + > dlls/ualapi/Makefile.in | 6 +++ > dlls/ualapi/main.c | 86 +++++++++++++++++++++++++++++++++++++++++ > dlls/ualapi/tests/Makefile.in | 8 ++++ > dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++ > dlls/ualapi/ualapi.spec | 4 ++ > include/Makefile.in | 1 + > include/ual.h | 48 +++++++++++++++++++++++ > 9 files changed, 195 insertions(+) Please don't include tests in this patch. Tests won't be committed until they are useful, so send them once you have something useful in them and as separated patch. For now, just strip them from the patch. Also, you may consider sending public header (include/ual.h) as a separated patch. And you don't need to include changes to generated files (configure, configure.ac and include/Makefile.in). Cheers, Jacek

1 0

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.
by Henri Verbeet 23 Sep '13

23 Sep '13

On 23 September 2013 13:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Note that Windows drivers disagree on which format they support. Nvidia > has V16U16, AMD supports Q8W8V8U8, at least on r200. I am working on a > more comprehensive converted format test that tests all supported signed > formats with surfaces. Just out of curiosity, do you happen to know if any hardware/driver supports these for render targets?

2 2

Re: [3/4] kernel32/tests: Add 0-length read tests for a pipe.
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid android. === wvista (32 bit pipe) === Failure running script in VM: network read error: Resource temporarily unavailable

1 0

Re: add ualapi directory (try 8)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2311 Your paranoid android. === build (build) === Make failed

1 0

Re: add ualapi directory (try 7)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2310 Your paranoid android. === build (build) === Make failed

1 0

Re: add ualapi directory (try 5)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2309 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: add ualapi directory (try 4)
by Marvin 23 Sep '13

23 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2308 Your paranoid android. === build (build) === Make failed

1 0

Re: Re: add ualapi directory (try 3)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2304 Your paranoid android. === build (build) === Make failed

1 0

winebuild examples
by paul.clarke85＠btinternet.com 22 Sep '13

22 Sep '13

Hi, I am new to WINE and indeed winebuild. What I need to do is write a wrapper C part and Spec file and build a wrapper around an existing Linux shared library so that my wrapper DLL can be dynamically loaded into my program running in WINE. This, I believe, is supposed to be a simple thing to do and one of the main purposes of winebuild. I have failed miserably to understand the winebuild manual. It just lists a whole bunch of options. Whatever I try I just get an assembler file spat at me. I have searched the web and although I see a few people with the same problem as me I don’t see anyone posting any answers. Does ANYONE have any simple examples or example scripts which will show how to use winebuild to build a DLL I can load. Cheers, Paul Paul Clarke www.mqgem.com

2 1

Re: [PATCH 5/6] d3d8/tests: Add a volume V16U16 test.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2292 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] d3d9/tests: Add a volume V16U16 test.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2291 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9: Avoid CONST.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2290 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] ddraw/tests: Add a test for render target surface capabilities.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2289 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ws2_32: ConnectEx should not work on unbound socket
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2286 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] d3d9/tests: Implemented tests for IDirect3DSwapChain9Ex_GetDisplayModeEx
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2282 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [2/3] d3d9/tests: Test if IDirect3DSwapChain9Ex is available with IDirect3D9(Ex)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2281 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] oleaut32: Implement ICreateTypeInfo::SetFuncDocString
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: rsaenh: Add support for retrieving the security descriptor on key containers.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2276 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] mshtml: Added external MIME handling tests.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2275 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: add ualapi directory (try 2)
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2273 Your paranoid android. === build (build) === Missing build status line The build timed out

1 0

Re: ws2_32/tests: Mark WinNT result as broken
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2271 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d8/tests: Test invalid volume lock boxes.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2270 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Add tests for block-based volume formats.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2269 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d9/tests: Read the caps from the device.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2268 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: shlwapi/tests: Fix stream test failures under some win2000 versions.
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2266 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Marvin 22 Sep '13

22 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2263 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: (resend)[3/4] imm32: use thread data from target HWND
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2262 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] d3dx9/tests: Add matrix column register count clamp test.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2259 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] imm32: Prevent assocating cross thread default contexts
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2257 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/4] imm32: use thread data from target HWND
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2256 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2255 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Test invalid volume lock boxes.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Add tests for block-based volume formats (try 2).
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2253 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2252 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.
by Marvin 21 Sep '13

21 Sep '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().
by Roderick Colenbrander 20 Sep '13

20 Sep '13

That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this part in the past, so there maybe a small typo (it may just be off by 1). Roderick On Thu, Sep 19, 2013 at 6:37 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winex11.drv/opengl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > >

2 1

Re: D3D command stream patches for testing
by Forest 20 Sep '13

20 Sep '13

>In the past months I have been working on a command stream / worker >thread for wined3d. It moves most OpenGL calls into a separate thread >to improve performance (bug 11674) and fix some bugs that are >otherwise hard to fix (24684). Thank you, Stefan! I applied your patches to the Ubuntu PPA that I maintain for Guild Wars 2 players: https://launchpad.net/~foresto/+archive/winepatched/ I'm not seeing a spectacular difference with the CSMT patches, but I am seeing a difference. I ran some quick tests in Guild Wars 2 while standing still outside the Lion's Arch bank, looking down at the forge with a moderate number of players milling about and fireworks being launched. Pierre Franco said (earlier in this discussion) that he gets better results when running with the -dx9single command line switch, so I tested with and without it. Note that I play with the WINEDEBUG=-all environment variable. Here are my results: CSMT="disabled", running with -dx9single: 15-16 fps CSMT="enabled" running without -dx9single: 19-21 fps CSMT="enabled", running with -dx9single: 22-23 fps So, almost 50% improvement for me, which is not what I remember when running natively under Windows, but is still a very welcome improvement. I wonder if the 80%+ gains reported in other games are not to be seen in Guild Wars 2, or if they're heavily dependent on CPU, GPU, graphics driver, and screen resolution. For the record, I'm using an Intel i5-3570K (stock speeds), GeForce GTX 660Ti (factory overclocked), nVidia driver 313.30, and a 1920x1200 display. I'm running Xubuntu 64-bit. My in-game options are: Resolution: Full Screen - 1920x1200 Refresh Rate: Default Frame Limiter: Unlimited Interface Size: Normal Animation: High Anti-Aliasing: FXAA Environment: High LOD Distance: High Reflections: Terrain & Sky Textures: Medium Render Sampling: Native Shadows: Medium Shaders: Medium Post-Processing: High Character Model Limit: High Character Model Quality: High + Best Texture Filtering + Depth Blur + Effect LOD + High-Res Character Textures - Vertical Sync

3 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel