- wine-devel - winehq.org

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)
by Hans Leidekker 28 May '13

28 May '13

On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so it would be better to fix it in that helper, without touching the parameter on error.

1 0

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode
by Marvin 28 May '13

28 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android. === WXPPROSP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === W2K3R2SESP2 (32 bit dsound) === dsound.c:1433: Test failed: validbits: 0 === WXPX64 (64 bit dsound) === dsound.c:1433: Test failed: validbits: 0

1 0

Re: [5/5] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 2)
by Alexandre Julliard 28 May '13

28 May '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This closes bug 14819. > > try 2: > * tests/heap.c was updated to avoid dependency on heap reallocation > strategies. > * Use HeapAlloc instead of LocalAlloc in some places. In those cases, > they want large memory blocks, not pinned memory addresses. They are using LMEM_MOVEABLE though. A few more tests for this flag would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

dxgi, directx 11 and code duplication
by John Yani 28 May '13

28 May '13

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

2 1

dxgi, directx 11 and code duplication
by John Yani 27 May '13

27 May '13

Hi. I'm trying to set up a minimal implementation that will allow to run Assasin's Creed III. It uses these 2 functions: dxgi.dll.CreateDXGIFactory1 d3d11.dll.D3D11CreateDevice See http://bugs.winehq.org/show_bug.cgi?id=24517 I need an advice on how to implement CreateDXGIFactory1 without duplicating a lot of code. There are problems with a straight-forward implementation: interface IWineDXGIFactory : IDXGIFactory { struct wined3d *get_wined3d(); } interface IWineDXGIFactory1 : IDXGIFactory1 { struct wined3d *get_wined3d(); } The problem is how to reuse functions where IWineDXGIFactory is used. Obviously we can't pass IWineDXGIFactory1 object where IWineDXGIFactory is required. Because the next time we call get_wined3d, a crash will occur (a different function will be called). Is there a more elegant solution than duplicating code and replacing all occurencdes of IWineDXGIFactory by IWineDXGIFactory1? Btw, D3D11CreateDevice accepts both IDXGIFactory and IDXGIFactory1: http://msdn.microsoft.com/en-us/library/windows/desktop/ff476082(v=vs.85).a…

1 0

Release plans
by Alexandre Julliard 27 May '13

27 May '13

Folks, Now that the Mac driver is fully merged and all the bugs fixed (right?), it's time to think about the next stable release. I would like to start the code freeze after the next release cycle, so two weeks from now. Hopefully, like last time we can keep the freeze period relatively short, so that it won't impact the Summer of Code projects too much. Note that in general, new test cases can be accepted during code freeze, and it's always a good idea to start a GSoC project by writing tests. On a related note, the test results on test.winehq.org haven't been looking very good lately; in particular, we need to make the full test suite succeed on the new testbot VMs, since the old ones are being phased out. Fixes to make tests succeed on Windows can go in during code freeze, since by definition they don't impact the Wine code, so this would be a good opportunity to try to improve the situation. OTOH the regression status is looking good, I'm very pleased with how we've kept the regression count under control during the 1.5 series. Hopefully we can even fix a few more during code freeze and set a lower baseline for the next development series. Thanks all for your help, and let's make this another great release! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: load winealsa if winepulse is found
by cfsworks＠gmail.com 27 May '13

27 May '13

Wouldn't this cause applications which use winmm for waveout to be diverted to ALSA as well? Maybe both drivers should be loaded side by side, with winepulse handling everything but MIDI.

1 0

Re: [PATCH v23] winepulse: add pulseaudio driver
by Marvin 27 May '13

27 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25724 Your paranoid android. === WVISTAX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W2K8SE (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 00000000 === W7PROX64 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === TEST64_W7SP1 (32 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 00000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 00000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 00000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 00000000 === WVISTAX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 00000000 0000000000000000 === W7PROX64 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000 === TEST64_W7SP1 (64 bit render) === render.c:520: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:527: Test failed: Shared IsFormatSupported with nAvgBytesPerSec=0 and nBlockAlign=0 returned 88890008 0000000000000000 render.c:586: Test failed: Shared IsFormatSupported with wValidBitsPerSample=0 returned 88890008 0000000000000000 render.c:599: Test failed: Shared IsFormatSupported with wValidBitsPerSample += 1 returned 88890008 0000000000000000 render.c:616: Test failed: Shared IsFormatSupported with wBitsPerSample=256 returned 88890008 0000000000000000

1 0

Making SetThreadPriorityBoost claim success
by Dan Kegel 27 May '13

27 May '13

http://bugs.winehq.org/show_bug.cgi?id=22280 just got another dup. How awful would it be to make SetThreadPriorityBoost just return success, as in the patch attached to http://bugs.winehq.org/show_bug.cgi?id=22280#c1 http://bugs.winehq.org/attachment.cgi?id=27224&action=diff&context=patch&co… ? We'd have to mark one more test TODO_WINE. Related if catty discussion: http://www.codinghorror.com/blog/2006/08/thread-priorities-are-evil.html

2 1

Re: [PATCH 4/5] d3drm: Avoid LPDIRECT3DRMTEXTURE.
by Christian Costa 27 May '13

27 May '13

Le 27/05/2013 09:22, Henri Verbeet a écrit : > --- > dlls/d3drm/d3drm.c | 20 ++++++++------------ > dlls/d3drm/frame.c | 22 +++++++--------------- > dlls/d3drm/meshbuilder.c | 14 +++++++------- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > include/d3drm.h | 4 ++-- > include/d3drmobj.h | 26 +++++++++++++------------- > 6 files changed, 45 insertions(+), 57 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 8dfa4bb..fe728a8 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -317,24 +317,20 @@ static HRESULT WINAPI IDirect3DRMImpl_CreateUserVisual(IDirect3DRM* iface, D3DRM > return E_NOTIMPL; > } > > -static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM* iface, const char* filename, > - LPDIRECT3DRMTEXTURE* Texture) > +static HRESULT WINAPI IDirect3DRMImpl_LoadTexture(IDirect3DRM *iface, > + const char *filename, IDirect3DRMTexture **texture) > { > - IDirect3DRMImpl *This = impl_from_IDirect3DRM(iface); > - > - FIXME("(%p/%p)->(%s,%p): stub\n", iface, This, filename, Texture); > + FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > > Do you really need to change the way traces are displayed?

2 6

Re: jscript: Added RegExp.toString() implementation.
by Marvin 27 May '13

27 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25722 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: riched20: Added tests for ITextDocument::Open
by Alexandre Julliard 27 May '13

27 May '13

Jactry Zeng <jactry92(a)gmail.com> writes: > diff --git a/dlls/riched20/tests/test.txt b/dlls/riched20/tests/test.txt > new file mode 100644 > index 0000000..e69de29 If you need an external file you have to create a temp file in the test. You can't rely on running from inside the source tree. -- Alexandre Julliard julliard(a)winehq.org

2 1

Spam again ...
by Joerg Schiermeier 27 May '13

27 May '13

Hi maintainer, ---<cite>--- Message: 1 Date: Sun, 26 May 2013 01:07:06 +0000 (UTC) From: xerox_xerox2000(a)yahoo.co.uk To: <wine-devel(a)winehq.org>, <vidar268(a)yahoo.com>, <vladdy(a)utchat.com> Subject: RE: Message-ID: <823277.37895.bm(a)smtp104.mail.ir2.yahoo.com> Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06 ---</cite>--- UCE/Spam again in this list ...! Please remove this user. Thanks a lot. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D
by Nozomi Kodama 26 May '13

26 May '13

Hello What happens for this patch? Nozomi

1 1

Re: [PATCH] wininet: do avoid overwriting the buffer (Coverity)
by Marvin 26 May '13

26 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25714 Your paranoid android. === WXPX64 (32 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 7722EDEA === WXPX64 (64 bit http) === http.c:4291: Test failed: 4462: expected status 100 got 10 http.c:4291: Test failed: 4506: expected status 100 got 40 http.c:4264: Test failed: ar->dwResult = 0, expected 1 http.c:4291: Test failed: 4515: expected status 70 got 100 http: unhandled exception c0000005 at 0000000000495D94

1 0

RE:
by xerox_xerox2000＠yahoo.co.uk 26 May '13

26 May '13

Moussoiddik%20Aboudou588 http://fonio-bio.org/w/87Elsie%20Mills045 Mon, 27 May 2013 5:04:06

1 0

Re: [PATCH] kernel32: Don't move fixed memory area in GlobalReAlloc().
by Marvin 25 May '13

25 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25705 Your paranoid android. === W7PROX64 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000 === TEST64_W7SP1 (32 bit heap) === heap.c:234: Test failed: got 00000000 heap.c:400: Test failed: got 00000000

1 0

Re: [2/2] server: A being destroyed object may need to access other objects using a handle.
by Alexandre Julliard 24 May '13

24 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- a/server/handle.c > +++ b/server/handle.c > @@ -165,7 +165,6 @@ static void handle_table_destroy( struct object *obj ) > for (i = 0, entry = table->entries; i <= table->last; i++, entry++) > { > struct object *obj = entry->ptr; > - entry->ptr = NULL; > if (obj) release_object( obj ); You can't do that, the object can't be accessed after being released. -- Alexandre Julliard julliard(a)winehq.org

2 5

Adding names to the authors file.
by Tae Wong 24 May '13

24 May '13

The only Croatian person is Marko Nikolić, but with no accented letter. Could you also add Joško Nikolić (the Croatian translator) and Volkan Gezer (the Turkish translator) to the authors file as well? The file name (in all capitals) is AUTHORS. It is very great so that you have to accentuate Marko's name at the message. But you use "straight quotes" or “smart quotes”. And Van Schaik's name is credited under the surname (and not on the particle). Here is the sort that you want for the section: va. South African and Namibian names in Dutch should have been sorted on the prefix (particle), but not in the surname. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl (Note that this is on a letter by letter sort.) Vaughn, Charles

1 0

Re: po: Added Croatian translation.
by Frédéric Delanoy 24 May '13

24 May '13

On Thu, May 23, 2013 at 3:45 PM, Joško Nikolić <josko.nikolic1(a)gmail.com> wrote: > > --- > configure | 1 + > po/LINGUAS | 1 + > po/hr.po | 13923 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 13925 insertions(+) > create mode 100644 po/hr.po As mentioned on IRC, you should remove the #| msgid "foo" lines, and modify 'configure.ac' instead of 'configure', which is autogenerated. Frédéric

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25680 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] oledb32: DataConvert only variant length types can have a null dst
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25679 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] oledb32: DataConvert Support NULL variant
by Marvin 24 May '13

24 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25677 Your paranoid android. === WVISTAX64 (64 bit convert) === No test summary line found === W7PROX64 (64 bit convert) === No test summary line found === TEST64_W7SP1 (64 bit convert) === No test summary line found

1 0

Re: [5/5] oledb32: GetConversionSize only returns a valid size of BSTR
by Nikolay Sivov 23 May '13

23 May '13

On Thu, May 23, 2013 at 11:48 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oledb32: GetConversionSize only returns a valid size of BSTR > + if(V_VT((VARIANT*)src) != VT_BSTR) + *dst_len = 110; else - return hr; + *dst_len = (SysStringLen(V_BSTR((VARIANT*)src)) + 1) * sizeof(WCHAR); + + return S_OK; So it returns previous result if type is invalid, meaning it's not VT_BSTR? You can't just return a random constant that appears in tests just because of previously made call (which is my guess). If you really want to implement this broken behaviour it will need more tests, at least one more that shows it returns a result from last successful call. > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: advapi32/tests: Fix copy&paste typo
by Guo Jian 23 May '13

23 May '13

Hi Andre, According to my test plan of the registry merging project, I will add new tests for HKCR. At first I tried to add them to the old code but I find it become too long and hard-reading. I had to rewrite them to a series of strict and neat tests, classified as read/write operations, including keys & values enumerating and deleting. I used many pre-definitions which make the test look fluent, but I'm not sure if the code is acceptable. http://newtestbot.winehq.org/JobDetails.pl?Key=942 static void test_classesroot(void) { DWORD res, len, i; HKEY hkey; char name[32]; #define CREATE_KEY(key, path) \ { \ HKEY tmp; \ if ((res = RegCreateKeyExA( key, path, 0, NULL, 0, \ KEY_ENUMERATE_SUB_KEYS|KEY_SET_VALUE|KEY_QUERY_VALUE|KEY_CREATE_SUB_KEY, \ NULL, &tmp, NULL )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegCreateKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ RegCloseKey(tmp); \ } \ } #define DELETE_KEY(key, path) \ { \ DWORD res; \ if ((res = RegDeleteKey(key, path)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteKey %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ } #define SET_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegSetValueEx( tmp, name, 0, REG_SZ, \ (CONST BYTE*)value, strlen(value) )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegSetValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_EXIST_KEY(key, path) \ ok(exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_NOT_EXIST_KEY(key, path) \ ok(!exist_key(key, path), "key %p\\%s should exist\n", key, path); #define CHECK_VALUE(key, path, name, value) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ ok(!strcmp(value, buf), "%s expected '%s' but got '%s' in %p\\%s\n", name, value, buf, key, path); \ RegCloseKey(tmp); \ } \ } #define CHECK_NON_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ char buf[32]; \ DWORD type = REG_SZ, size = sizeof(buf); \ if ((res = RegQueryValueEx( tmp, name, 0, &type, \ (BYTE*)buf, &size )) == ERROR_SUCCESS) \ { \ ok(FALSE, "%s should not exist in %p\\%s\n", name, key, path); \ } \ else if (res != ERROR_FILE_NOT_FOUND) \ { \ ok(FALSE, "RegQueryValueEx %p\\%s failed with %08X\n", tmp, name, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define DELETE_VALUE(key, path, name) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_SET_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ if ((res = RegDeleteValueA(tmp, name)) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegDeleteValue %s in %p\\%s failed with %08X\n", name, key, path, res); \ return; \ } \ RegCloseKey(tmp); \ } \ } #define CHECK_KEY_INFO(key, path, c1, c2) \ { \ HKEY tmp; \ if ((res = RegOpenKeyExA( key, path, 0, \ KEY_QUERY_VALUE, &tmp )) != ERROR_SUCCESS) \ { \ ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", key, path, res); \ return; \ } \ else \ { \ DWORD n1, n2; \ if (ERROR_SUCCESS != (res = RegQueryInfoKeyA( tmp, NULL, NULL, NULL, \ &n1, NULL, NULL, &n2, NULL, NULL, NULL, NULL ))) \ { \ ok(FALSE, "RegQueryInfoKeyA failed with %08X\n\n", res); \ return; \ } \ ok(n1 == c1, "subkey count expected %d but got %d in %p\\%s\n", c1, n1, key, path); \ ok(n2 == c2, "value count expected %d but got %d in %p\\%s\n", c2, n2, key, path); \ RegCloseKey(tmp); \ } \ } /* test create_key priority */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, STANDARD_RIGHTS_READ, &hkey )) != ERROR_SUCCESS) { skip("classes merging not supported\n"); cleanup_classes(); return; } /* test create_key priority */ /* create from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu then hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); /* further test based on the below */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_CREATE_SUB_KEY, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* create subkey under the handle opened from the key that exists only in hkcu but not hklm */ CREATE_KEY(hkey, "subkey1"); RegCloseKey(hkey); /* check that subkey is created in hklm, proving that the handle from hkcr is not same as opened in hkcu, even when it does not conflict with hklm */ CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); /* test delete_key priority */ /* create from hkcu and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hklm and delete from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* create from hkcu and hklm and delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* delete again */ DELETE_KEY(HKEY_CLASSES_ROOT, "WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); /* test set_value priority */ /* set new value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* set value from hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hkcu and hklm and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcr"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* set value from hklm in a key not conflict with hkcu and reset value from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); SET_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcr"); CHECK_NOT_EXIST_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcr"); /* test delete_value priority, no need to test when not conflict */ /* set value from hkcu and hklm then delete twice from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1"); CHECK_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); /* delete again */ DELETE_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1"); CHECK_NON_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1"); /* test query_value priority, noneed to test when not conflict */ /* set value to hkcu and create the key in hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set value to hklm and create the key in hkcu then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hklm"); /* set conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); /* set non conflict value both to hkcu and hklm then query from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hklm"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val1", "hkcu"); CHECK_VALUE(HKEY_CLASSES_ROOT, "WineTestCls", "val2", "hklm"); /* test query_info_key priority, no need to test when queried key does not conflict */ /* check subkey and value count for conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 1, 1); /* check subkey and value count for non conflict subkeys from hkcr */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 2, 2); /* test enum_key priority, no need to test when enumerated key does not conflict */ /* create subkeys and values in hkcu and hklm */ cleanup_classes(); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey1"); CREATE_KEY(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls\\subkey3"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val1", "hkcu"); SET_VALUE(HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", "val3", "hkcu"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey3"); CREATE_KEY(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls\\subkey2"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val3", "hkcu"); SET_VALUE(HKEY_LOCAL_MACHINE, "Software\\Classes\\WineTestCls", "val2", "hkcu"); /* check the count */ CHECK_KEY_INFO(HKEY_CLASSES_ROOT, "WineTestCls", 3, 3); if ((res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, KEY_ENUMERATE_SUB_KEYS|KEY_QUERY_VALUE, &hkey )) != ERROR_SUCCESS) { ok(FALSE, "RegOpenKeyExA %p\\%s failed with %08X\n", hkey, "WineTestCls", res); return; } /* check the names and order of subkeys when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumKeyExA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra subkey name %s\n", name); } else if (strncmp(name, "subkey", 6) || name[6] != (i + '0') || name[7]) { ok(FALSE, "got unexpected subkey name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumKeyExA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 subkeys but got only %d\n", i); } /* check the names and order of values when enumerating */ i = 0; len = sizeof(name); while (ERROR_SUCCESS == (res = RegEnumValueA(hkey, i, name, &len, NULL, NULL, NULL, NULL))) { ++ i; if (i > 3) { ok(FALSE, "got extra value name %s\n", name); } else if (strncmp(name, "val", 3) || name[3] != (i + '0') || name[4]) { ok(FALSE, "got unexpected value name or order %s at index %d\n", name, i); } len = sizeof(name); } if (res != ERROR_NO_MORE_ITEMS) { ok(FALSE, "RegEnumValueA failed with %08X\n", res); return; } if (i < 3) { ok(FALSE, "expected 3 value but got only %d\n", i); } RegCloseKey(hkey); cleanup_classes(); } -- Regards, Guo Jian

1 0

Regression for bash.exe redirection of ctest.exe for wine-1.5.30 compared to wine-1.5.19
by Alan W. Irwin 22 May '13

22 May '13

Generally I have found in still fairly limited testing that MSYS bash.exe redirection is fine on wine-1.5.30 (which I have now been able to build in 32-bit mode on Debian wheezy x86_64 thanks to the 32-bit library symlink trick discussed in my previous recent thread). However, I have just discovered a puzzling case where MSYS bash.exe redirection now fails for ctest.exe compared to wine-1.5.19. To reproduce this regression download the Windows binary version of cmake-1.8.10.2 (which includes cmake.exe and ctest.exe) and install it. Also download and install MinGW/MSYS. In the past, I have found results depend very much on how you get into the MSYS bash.exe environment. In my case I execute wineconsole --backend=curses MinGW_4.7.0/msys/1.0/bin/bash.exe to do that, and then from that interactive environment execute the commands below. Here is how I try the --version option for cmake and ctest with redirection under bash.exe. bash.exe-3.1$ cmake --version >& cmake_version.out bash.exe-3.1$ ctest --version >& ctest_version.out For Wine-1.5.19 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== ctest version 2.8.10.2 For Wine-1.5.30 bash.exe-3.1$ head *.out ==> cmake_version.out <== cmake version 2.8.10.2 ==> ctest_version.out <== N.B. note the incorrect empty ctest_version.out file for Wine-1.5.30. For both Wine-1.5.19 and Wine-1.5.30 if I don't redirect the output I simply get the following results bash.exe-3.1$ cmake --version cmake version 2.8.10.2 bash.exe-3.1$ ctest --version ctest version 2.8.10.2 So somehow bash.exe redirection for ctest (but not cmake and a small number of other commands I have tried) generates an incorrect empty file for Wine-1.5.30. I never have had trouble with bash.exe redirection for any command (including ctest) on either Linux bash or MSYS bash.exe on Wine-1.5.19. So it is likely there is some minor (but probably standard) variation in how ctest handles its stdout that is triggering this Wine-1.5.30 regression compared to Wine-1.5.19. So there might be other commands as well where bash.exe redirection doesn't work for Wine-1.5.30. If it is already known that MSYS bash.exe redirection is sometimes problematic with Wine-1.5.30 compared to earlier versions, is there some patch I could try to see if it fixes this specific issue? My primary motivation is developing my own free software. Therefore, I only have limited time to help figure out wine bugs although I am willing to report the ones I discover here (and on the bug tracker once discussed here to reduce bug tracker noise). That said, it does appear that git-bisect would be an ideal way to find which commit between Wine-1.5.19 and Wine-1.5.30 caused the bash.exe redirection issue with ctest.exe. Unfortunately, I have zero experience with git-bisect. However, if somebody could give me some step-by-step instructions I could follow by rote that would be great. Ideally, those instructions would be a simple template bash script I could run unattended overnight from Linux that used git-bisect to detect the first commit between Wine-1.5.19 and Wine-1.5.30 where ctest --version >& ctest_version.out produces an empty file under MSYS bash.exe. I can fill in the parts of that template script concerning the wine build for each git commit that is being tested since I have such builds (including necessary *.so links for later wine versions) largely automated now. But I am not sure about how you get into MSYS bash.exe directly (my normal method using wineconsole as above appears to be interactive rather than something you could run unattended) from a Linux bash script so I would need advice about that. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

2 3

Patches 96314 & 96328
by Christian Costa 22 May '13

22 May '13

Hi, Is there any problem with these patches? http://source.winehq.org/patches/data/96314 http://source.winehq.org/patches/data/96328 Christian

1 0

Re: [PATCH 2/5] dinput: Support SendForceFeedbackCommand for OSX joysticks
by Charles Davis 22 May '13

22 May '13

On May 21, 2013, at 1:34 PM, Andrew Eikum wrote: > --- > dlls/dinput/joystick_osx.c | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 94398e7..8fb675d 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -1135,6 +1135,36 @@ static HRESULT WINAPI JoystickAImpl_CreateEffect(IDirectInputDevice8A *iface, > type, params, out, outer); > } > > +static HRESULT WINAPI JoystickWImpl_SendForceFeedbackCommand(IDirectInputDevice8W *iface, > + DWORD flags) > +{ > + JoystickImpl *This = impl_from_IDirectInputDevice8W(iface); > + HRESULT hr; > + > + TRACE("%p 0x%x\n", This, flags); > + > + if(!This->ff) > + return DI_NOEFFECT; > + > + hr = FFDeviceSendForceFeedbackCommand(This->ff, flags); > + if(FAILED(hr)){ > + WARN("FFDeviceSendForceFeedbackCommand failed: %08x\n", hr); > + return hr; You can't return the straight HRESULT from ForceFeedback here. That's because the codes in the FACILITY_NULL range on Mac get their values from the 16-bit COM runtime (cf. <CoreFoundation/CFPlugInCOM.h>). You must turn them into their corresponding Win32 codes. Chip

2 1

wine-osX developer for winmm joystick project?
by DavidL 22 May '13

22 May '13

To anybody interested, I think I've found a solution to an old problem of implementing winmm joystick support in WINE for Mac, but lack the necessary skills and experience to code it up myself. WINE-Linux has had it implemented for awhile, but it was never coded up for OS X. winmm is an older interface used for a lot of different peripherals, included joysticks in quite a few classic games. As there were also some problems with dinput for WINE-OSX, originally it was thought the problems with winmm were also a bug. However, the problems with dinput have been solved and it seems the necessary code for winmm joystick support, rather than being buggy, was never actually written for WINE for the Mac. Thus it is an issue in need of development rather than a bug report. So I thought I'd ask if anyone was interested in developing the code to get winmm working in in the Mac-WINE environment? I have an idea about what needs to be written but I lack the experience in Mac-system level programming to be of much use. I did take a look but found the API very arcane. That's why I am asking for someone with more experience. From what I can tell, the code should not be difficult to write for someone who knew what they were doing with regards to Mac system programming. There aren't many functions that need to be written and what ones there are seem simple enough. I have an outline about what functions need to written and modified to get winmm functionality working for the Mac-WINE environment. The requisite changes are here: ( http://bugs.winehq.org/show_bug.cgi?id=18424#c75) It is written in a bug report because originally it was part of the same conversation as the dinput bug. I look forward to hearing back from anyone interested in taking this (I think) short development project up. I'd be happy to learn and help test the code with some classic games that require winmm. Cheers, David

1 0

Re: [PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests
by Henri Verbeet 22 May '13

22 May '13

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void test_coop_level_versions(void) It may make more sense to move that to ddraw2.c and ddraw4.c instead. (IIRC you can't QI a ddraw1 interface from ddraw7.)

2 2

Re: [PATCH 1/4] ddraw: Restore resolution on EXCLUSIVE->NORMAL switch
by Henri Verbeet 22 May '13

22 May '13

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The new code does not deliver the resolution change messages to the > correct window, see the todo_wine markers in the next patch. Getting > this right isn't simply a matter of passing the correct window to > wined3d_device_restore_fullscreen_window because the delivery of the > correct messages in the new window == old window case is mostly a lucky > side effect of the window style hacks. Those hacks fail if we pass a > different window, because the style of the new window is different from > what wined3d expects, so it doesn't send any messages. Well, wined3d_device_restore_fullscreen_window() isn't really supposed to generate messages at all, the resize on mode changes happens in device_parent_mode_changed(). The implication seems to be that restoring the display mode is supposed to happen after the new swapchain is created, but before "ddraw->cooperative_level" is updated. > /***************************************************************************** > + * IDirectDraw7::RestoreDisplayMode > + * > + * Restores the display mode to what it was at creation time. Basically. > + * > + * Returns > + * DD_OK on success > + * DDERR_NOEXCLUSIVE mode if the device isn't in fullscreen mode > + * > + *****************************************************************************/ I don't think that really adds anything. > -static HRESULT WINAPI ddraw7_SetCooperativeLevel(IDirectDraw7 *iface, HWND window, DWORD cooplevel) > +static HRESULT WINAPI ddraw_set_cooperative_level(struct ddraw *ddraw, HWND window, > + DWORD cooplevel, BOOL restore_mode) Shadowing the global "restore_mode" is a bit unfortunate. > - TRACE("iface %p, window %p, flags %#x.\n", iface, window, cooplevel); > + TRACE("ddraw %p, window %p, flags %#x, restore_mode %s.\n", ddraw, window, cooplevel, > + restore_mode ? "true" : "false"); I think %#x is generally clear enough for BOOLs. > if(cooplevel & DDSCL_ALLOWREBOOT) > - WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWREBOOT, harmless\n", ddraw); > if(cooplevel & DDSCL_ALLOWMODEX) > - WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_ALLOWMODEX, harmless\n", ddraw); > if(cooplevel & DDSCL_FPUSETUP) > - WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", This); > + WARN("(%p) Unhandled flag DDSCL_FPUSETUP, harmless\n", ddraw); The "(%p)" there is pretty pointless, I usually remove them if I'm editing the line anyway. > @@ -86,6 +86,7 @@ struct ddraw > > /* DirectDraw things, which are not handled by WineD3D */ > DWORD cooperative_level; > + BOOL setcooplevel_ddraw1; > We should probably consolidate the various BOOLs in struct ddraw into a flags field.

2 2

Question about legal requirement on gsoc page
by Christian Costa 22 May '13

22 May '13

*Hi, * *I read on the GSoC page this: * *"You are not allowed to analyze Windows files with the trace functions of Wine" * *What does that mean? * *Thanks * *Christian *

2 2

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called (try 2).
by Alexandre Julliard 22 May '13

22 May '13

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -5383,7 +5383,11 @@ int WINAPI WSAEventSelect(SOCKET s, WSAEVENT hEvent, LONG lEvent) > ret = wine_server_call( req ); > } > SERVER_END_REQ; > - if (!ret) return 0; > + if (!ret) > + { > + _enable_event(SOCKET2HANDLE(s), 0, FD_WINE_NONBLOCKING, 0); > + return 0; > + } You shouldn't need 2 server calls for this. > @@ -3578,6 +3584,12 @@ static void test_events(int useMessages) > goto end; > } > > + if (set_blocking(src2, TRUE)) > + { > + ok(0, "set_blocking failed, error %d\n", WSAGetLastError()); > + goto end; > + } There's no reason to abort on every failure. -- Alexandre Julliard julliard(a)winehq.org

2 1

Troubles configuring and building wine-1.5.30 on Debian wheezy
by Alan W. Irwin 22 May '13

22 May '13

My use case is building and testing software packages on Wine. My 32-bit build of wine-1.5.19 on x86_64 hardware was fine for this purpose for MinGW/MSYS builds so I stuck with it until today when I attempted to expand my building and testing of software to the Cygwin on Wine platform. I immediately ran into some issues with the Cygwin setup.exe installer so my first instinct was to try the latest experimental wine release, wine-1.5.30, but it's build has changed quite a bit since when I built wine-1.5.19, and I need some help figuring out what to do. The first issue was the configure script complained that the 32-bit version of the X libraries was missing and errored out. I then decided to try the 64-bit version of wine instead (since my Debian system has mostly 64-bit libraries). I got that 64-bit-only build and install to work perfectly, but I could not run anything with it. For example: wine@raven> wine64 wine64: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory I then looked at http://wiki.winehq.org/Wine64 which recommended a WoW64 configuration, where you build both 64-bit and 32-bit versions of Wine and install both. So following those directions, the 64-bit version again built and installed without issues (in fact I just renamed what I did before) but the 32-bit version again errored out on lack of a 32-bit X library. Now Debian wheezy has multiarch implemented properly for some (but not all) packages so I was able to install libx11-dev:i386 which coexisted fine with the installed libx11-dev:amd64 and also solved the 32-bit X issue. But then the 32-bit wine-1.5.30 configure continued further and ran into a similar issue with missing 32-bit freetype6. The error message was configure: error: FreeType 32-bit development files not found. Fonts will not be built. Use the --without-freetype option if you really want this. Accordingly I attempted to install libfreetype6-dev:i386 but on Debian wheezy that conflicts with libfreetype6-dev:amd64, and it appears the only way around this packaging issue for now (until the libfreetype6-dev:i386 and libfreetype6-dev:amd64 packages are taught to coexist) is to create a pure 32-bit Debian wheezy system (which I don't want to do). So here are my questions and further comments: 1. Is there a way to stick with a pure 64-bit Wine system, or is that normally pretty useless because downloaded applications such as the Cygwin installer which apparently is 32-bit, i.e., wine@raven> file setup.exe setup.exe: PE32 executable (GUI) Intel 80386 (stripped to external PDB), for MS Windows, UPX compressed wont run on it? 2. If the WoW64 configuration is really the best solution, what are the consequences of dropping libfreetype from the 32-bit configuration (but obviously including it in the 64-bit configuration). IOW, if I just say --without-freetype for the 32-bit configuration (suggested as a possibility above by that error message) will the fonts be built and installed by the 64-bit configuration that includes libfreetype? 3. I would have liked to continue with pure 32-bit wine since that was what I have been used to all these years, but it appears wine-1.5.30 32-bit dependencies are really fearsome compared to the relative modest 32-bit dependencies for wine-1.5.19 so this effectively makes it impossible to build a standalone 32-bit wine system on Debian Wheezy (because no fonts will be built if --without-freetype is used) and might also compromise WoW64 builds (see question 2 above). It obviously doesn't affect pure 64-bit Wine builds, but I couldn't get that to work at all at run time (missing libwine.so.1 (see above)), but if there are workarounds for that issue, then it still might be useless (see question 1 above). Any help/comments on the correct way to build wine-1.5.30 would be much appreciated for the case (as on Debian wheezy) where 32-bit and 64-bit libfreetype packages cannot be installed simultaneously. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

5 8

Re: server: Always redraw children when parent's pos/size changed in any way (Try 2).
by Sergey Guralnik 21 May '13

21 May '13

On 2013-05-06 13:24, Sergey Guralnik wrote: > Alexandre Julliard writes: >> ... >> It doesn't make sense to have all these complicated tests if we are >> going to always repaint anyway, which is essentially what your patch >> does. There has to be more to it than that. > > This version uses the same logic as used before, but also it > removes all redundant checks. > > --- > dlls/user32/tests/win.c | 1 - > server/window.c | 32 ++++++-------------------------- > 2 files changed, 6 insertions(+), 27 deletions(-) Is there some problem with this patch? -- Sergey

2 1

Re: dbghelp: Add stub SymGetLineNextW64
by Alexandre Julliard 21 May '13

21 May '13

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -1717,6 +1717,17 @@ BOOL WINAPI SymGetLineNext64(HANDLE hProcess, PIMAGEHLP_LINE64 Line) > } > > /****************************************************************** > + * SymGetLineNextW64 (DBGHELP.@) > + * > + */ > +BOOL WINAPI SymGetLineNextW64(HANDLE hProcess, PIMAGEHLP_LINEW64 Line) > +{ > + FIXME("(%p %p) stub \n", hProcess, Line); > + > + return FALSE; > +} It wouldn't be much harder to implement this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20: Added tests for ITextDocument::Open
by Nikolay Sivov 21 May '13

21 May '13

On Tue, May 21, 2013 at 3:45 PM, Jactry Zeng <jactry92(a)gmail.com> wrote: > > > > > If the whole purpose of storing flags names is to output readable debug info I think it's better to have a single separate function that takes flags combination and returns static buffer pointer with a name. This way it will need just to append after bitwise 'and' check. + /* tests for ITextDocument::Open */ + for(; tomNunSingle >= 0; tomNunSingle--) Do you really need to go from the tail here?

1 0

Re: Alexandre Julliard : msvcrt: Don't bother to clean up at process exit.
by Dmitry Timoshkov 21 May '13

21 May '13

Alexandre Julliard <julliard(a)winehq.org> wrote: > case DLL_PROCESS_DETACH: > - msvcrt_free_popen_data(); > msvcrt_free_io(); > + if (lpvReserved) break; > + msvcrt_free_popen_data(); > msvcrt_free_mt_locks(); > msvcrt_free_console(); > msvcrt_free_args(); Shouldn't msvcrt_free_io() be also protected by this guard? -- Dmitry.

3 6

Re: [PATCH] d3dxof: Cleanup separators handling and allow multi-semicolons + single comma separator.
by Alexandre Julliard 21 May '13

21 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > There is one test becoming todo. This will be fixed in another patch. > This patch also should fix bug 30897. > --- > dlls/d3dxof/parsing.c | 35 ++++++++++------------------------- > dlls/d3dxof/tests/d3dxof.c | 22 +++++++++++----------- > 2 files changed, 21 insertions(+), 36 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:275: Test failed: Cannot load mesh data (hr = 88760311) d3drm.c:280: Test failed: Retrieved name '' instead of 'Object' d3drm.c:283: Test failed: IDirect3DRMMeshBuilder_GetName returned hr = 0 d3drm.c:298: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:301: Test failed: Wrong number of faces 0 (must be 3) d3drm.c:305: Test failed: Wrong number of vertices 0 (must be 4) d3drm.c:306: Test failed: Wrong number of normals 0 (must be 4) d3drm.c:307: Test failed: Wrong number of face data bytes 0 (must be 22) d3drm.c:315: Test failed: Wrong component n[1].x = 0.000000 (expected -0.229416) d3drm.c:318: Test failed: Wrong component n[2].x = 0.000000 (expected -0.229416) d3drm.c:319: Test failed: Wrong component n[2].y = 4021199976020422122536960.000000 (expected 0.688247) d3drm.c:320: Test failed: Wrong component n[2].z = 9973638011820690691325952.000000 (expected 0.688247) d3drm.c:321: Test failed: Wrong component n[3].x = 0.000000 (expected -0.577350) d3drm.c:323: Test failed: Wrong component n[3].z = 1387759860774554023173815085733773312.000000 (expected 0.577350) d3drm.c:329: Test failed: Cannot get texture coordinates (hr = 88760316) d3drm.c:330: Test failed: Wrong coordinate 1.230000 (must be 0.0) etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin 21 May '13

21 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25647 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin 21 May '13

21 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25646 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Jacek Caban 21 May '13

21 May '13

Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way, without > any introduced helper function. > > This patch also add tests for any corner cases, and it has passed testbot's > testing. > > --- > dlls/vbscript/global.c | 14 ++++++++++++-- > dlls/vbscript/tests/api.vbs | 23 +++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 2 deletions(-) As you may check here: http://source.winehq.org/patches/ your patch is marked as 'Apply failure'. Did you prepare the patch against recent Wine Git? Please rebase and resend the patch. Cheers, Jacek

1 0

Re: Troubles configuring and building wine-1.5.30 on Debian wheezy
by Hugh McMaster 21 May '13

21 May '13

On Monday May 20 at 22:24:58, Alan W. Irwin wrote: >wine at raven> wine64 >wine64: error while loading shared libraries: libwine.so.1: cannot >open shared object file: No such file or directory Hi Alan, This error is caused by a regression in Wine 1.5.30. It is not present in version 1.5.29. The general source for Wine 1.5.30 on WineHQ does contain a patch to resolve the issue. The patch is available from http://source.winehq.org/git/wine.git/patch/ce4b6451aabbe83809c7483c748cfa0…. To apply it, you will need to save the patch with either the extension .patch or .txt in the Wine source directory. You will then need to run the patch command from the source directory: patch -p1 < name.patch Alternatively, you can use Git to obtain the latest source: git clone git://source.winehq.org/git/wine.git ~/wine-git This option will come with the patch already applied and a lot of other changes. --- Hugh

1 0

Re: [1/4] server: Add support for console font size, maximum window size, etc.
by Dmitry Timoshkov 21 May '13

21 May '13

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote: > This patch modifies server/protocol.def and server/console.c to add support > for console font size detection and console window size rendering. It also > tidies up a few inconsistencies in the repeated usage of aspects of the > screen buffer struct. Your patches are full of formatting and white space changes, please don't do that. -- Dmitry.

2 1

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Charles Davis 20 May '13

20 May '13

On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = { > BitmapImpl_SetResolution > }; > > +static HRESULT WINAPI IMILBitmapImpl_QueryInterface(IMILBitmapSource *iface, REFIID iid, > + void **ppv) > +{ > + BitmapImpl *This = impl_from_IMILBitmapSource(iface); > + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); > + > + if (!ppv) return E_INVALIDARG; > + > + if (IsEqualIID(&IID_IUnknown, iid) || > + IsEqualIID(&IID_IMILBitmapSource, iid)) > + { > + *ppv = &This->IMILBitmapSource_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + return S_OK; > + } You're violating COM rules here: when you QI an object for an interface pointer, the QI must always return the same result no matter what. Here, however, you're returning this interface pointer in response to a query for IUnknown, when the already-existing QueryInterface method on the IWICBitmap interface returns *itself* for IUnknown! Now when you QI for IUnknown on both of these interfaces, they won't compare equal. (I suspect you're not convinced. After all, native might violate COM rules here, too. I doubt that (see below), but it might. So, write a test that QI's for IUnknown from both interfaces, and checks if they're equal or not. Then we'll see who's right.) > diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h > index dddb327..29f7726 100644 > --- a/dlls/windowscodecs/wincodecs_private.h > +++ b/dlls/windowscodecs/wincodecs_private.h > @@ -27,6 +27,46 @@ DEFINE_GUID(GUID_WineContainerFormatTga, 0x0c44fda1,0xa5c5,0x4298,0x96,0x85,0x47 > > DEFINE_GUID(GUID_VendorWine, 0xddf46da1,0x7dc1,0x404e,0x98,0xf2,0xef,0xa4,0x8d,0xfc,0x95,0x0a); > > +DEFINE_GUID(IID_IMILBitmapSource,0x7543696a,0xbc8d,0x46b0,0x5f,0x81,0x8d,0x95,0x72,0x89,0x72,0xbe); > +#define INTERFACE IMILBitmapSource > +DECLARE_INTERFACE_(IMILBitmapSource,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; You know you can just use the STDMETHOD() macro (no trailing underscore), e.g.: STDMETHOD(QueryInterface)(THIS_ REFIID,void **) PURE; for methods that return an HRESULT, right? Or do you prefer explicitly declaring the return type like that, even if it is more typing? > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > + /*** IMILBitmapSource methods ***/ > + STDMETHOD_(HRESULT,GetSize)(THIS_ UINT *,UINT *); > + STDMETHOD_(HRESULT,GetPixelFormat)(THIS_ int *); > + STDMETHOD_(HRESULT,GetResolution)(THIS_ double *,double *); > + STDMETHOD_(HRESULT,CopyPalette)(THIS_ IWICPalette *); > + STDMETHOD_(HRESULT,CopyPixels)(THIS_ const WICRect *,UINT,UINT,BYTE *); > + STDMETHOD_(HRESULT,UnknownMethod1)(THIS_ void **); > +}; > +#undef INTERFACE > + > +#define INTERFACE IMILUnknown1 > +DECLARE_INTERFACE_(IMILUnknown1,IUnknown) > +{ > + /*** IUnknown methods ***/ > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID,void **) PURE; > + STDMETHOD_(ULONG,AddRef)(THIS) PURE; > + STDMETHOD_(ULONG,Release)(THIS) PURE; > +}; > +#undef INTERFACE Wouldn't that just make this interface a plain old IUnknown? Or does it have its own IID? (Or does that not even matter, given that it's returned from that "UnknownMethod1" above?) If it is nothing more than a plain IUnknown, why did you even add this, since it doesn't really extend the IUnknown interface with any new methods? It's telling that its v-table is the very first v-table in the object. This probably indicates that this really is the canonical IUnknown (i.e. the one that gets returned when you QI for IUnknown), and the other interfaces' IUnknown methods just delegate to this one. If I haven't missed my guess about this object's QI implementation, then this is the IUnknown that should get returned from a QI for IUnknown. This might actually be an object that supports aggregation; you may want to test for that, too ;). Chip

2 1

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests
by Henri Verbeet 20 May '13

20 May '13

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > These tests have the potential to break on Windows when other > applications create or release a large number of video memory resources > while the test is running. > Yeah, maybe we don't really need this to be in the tree, although it's good to see for reference.

4 3

Re: msvcm80: Remove pre-attach handler for a dll with manifest.
by Alexandre Julliard 20 May '13

20 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Manifest prevents loading of a native dll anyway. Not if it's installed globally. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.
by Dmitry Timoshkov 20 May '13

20 May '13

Qian Hong <qhong(a)codeweavers.com> wrote: > Fixed http://bugs.winehq.org/show_bug.cgi?id=33076 > > Reference: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms741621%28v=vs.85%… > > See also comment in WSAIoctl: > /* AsyncSelect()'ed sockets are always nonblocking */ This change requires a test case, MSDN is often wrong, so its claims at least need to be very carefully checked. -- Dmitry.

2 5

Re: oledb32: Support DBSTATUS_S_ISNULL when converting to VARIANT
by Marvin 20 May '13

20 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25629 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Add support for IMILBitmapSource interface.
by Marvin 20 May '13

20 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25624 Your paranoid android. === WVISTAX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77370897 === W2K8SE (32 bit bitmap) === bitmap: unhandled exception c0000005 at 778A81CB === W7PROX64 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77E035F2 === TEST64_W7SP1 (32 bit bitmap) === bitmap: unhandled exception c0000005 at 77593772 === W7PROX64 (64 bit bitmap) === No test summary line found === TEST64_W7SP1 (64 bit bitmap) === Timeout

1 0

Duplicate relocations in DLL
by Alessandro Pignotti 19 May '13

19 May '13

Hi everyone, Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure about what could be a right way to support such (broken) DLLs. A possibility would be to keep track of already relocated pages and skip them if needed. Suggestions are welcome. Regards, Alessandro Pignotti

3 7

wineconsole screen scenarios
by Hugh McMaster 19 May '13

19 May '13

In my effort to improve wineconsole and its calculations of the largest possible window size, three scenarios come into play. 1. wineconsole with --backend=user (or more simply, 'wineconsole app.exe, in which case 'user' is the default). 2. wineconsole with --backend=curses. 3. wineconsole with --backend=curses, but no X server running. Detecting the screen resolution is a simple task with (1) and (2). SystemParametersInfo for (1) and wine's own XRandR for (2) can be used. My concern is with scenario (3). Wine is designed to be used with an X server, but wineconsole can be used in non-X-based environment. While this is possible, it would seem unlikely. Nonetheless, the issue has come up on the wine-devel list before. The question is, should I worry about supporting such a scenario?

5 6

Re: [PATCH] ieframe: Add a IServiceProvider stub to IBindStatusCallback
by Alistair Leslie-Hughes 19 May '13

19 May '13

On 18/05/2013 11:11 PM, Detlef Riekenberg wrote: > -- > By by ... Detlef > > --- > dlls/ieframe/navigate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 51 insertions(+), 0 deletions(-) Tests to prove the interface exists. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow (resend)
by Marvin 18 May '13

18 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25614 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: GSoC proposal
by George Stephanos 17 May '13

17 May '13

As we know already from [1], the merge is going to happen according to certain rules. The list at the end of the page signifies which subkeys are going to be *merged* from HKLM\Software\Classes\subkey and HKCU\Software\Classes\subkey and not simply linked to. Now there's a comment on the article that says that list is stored in a key. That lead me into thinking that the list is dynamic and should be determined at runtime using that key. However that key doesn't exist on my Win8 box or the web even. Should I just assume the list is static and build my tests/code according to it? Is there something I'm missing? [1] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… On Wed, May 8, 2013 at 1:26 AM, George Stephanos <gaf.stephanos(a)gmail.com>wrote: > I'm done. Sorry for the font massacre. They're not changing :| > > > On Tue, May 7, 2013 at 6:45 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > >> I'll leave it open till tomorrow (my time.) Thanks, >> --Juan >> >> >> On Tue, May 7, 2013 at 9:44 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >> >>> Oh, hang on, I just flipped it so you can modify it. >>> >>> >>> On Tue, May 7, 2013 at 9:43 AM, Juan Lang <juan.lang(a)gmail.com> wrote: >>> >>>> I think you can add more of a timeline in a response. Will that work? >>>> --Juan >>>> >>>> >>>> On Tue, May 7, 2013 at 9:40 AM, George Stephanos < >>>> gaf.stephanos(a)gmail.com> wrote: >>>> >>>>> I had responded already but yes I'm a little bit shallow on the >>>>> timeline details. Alright. >>>>> Could you give me permission to modify the proposal? >>>>> >>>> >>>> >>> >> >

2 2

Re: [PATCH 4/6] gdi32: Use the default character when the glyph is missing.
by Alexandre Julliard 17 May '13

17 May '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > This change is useful for a bitmap font. Because its glyph index 0 isn't the > default glyph in some cases. This doesn't seem to match what GetGlyphIndices does, and we probably don't want to do that in two different places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25605 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25604 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.
by Austin English 17 May '13

17 May '13

On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com> wrote: > Also remove fixme in wined3d_device_get_software_vertex_processing since it does what it is supposed to do. > --- > dlls/wined3d/device.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 47da78b..89fc525 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4281,9 +4281,9 @@ void CDECL wined3d_device_set_software_vertex_processing(struct wined3d_device * > > TRACE("device %p, software %#x.\n", device, software); > > - if (!warned) > + if (software && !warned) > { > - FIXME("device %p, software %#x stub!\n", device, software); > + FIXME("Software vertex processing not supported. Fake it and use harware one."); > warned = TRUE; Typo, should be hardware. -- -Austin

2 1

Re: msvcp90: Prefer native version.
by Piotr Caban 17 May '13

17 May '13

On 05/17/13 08:01, Dmitry Timoshkov wrote: > Just like msvcp60,msvcp70,msvcp71,msvcp80,msvcp100,msvcp110 do. > --- > dlls/msvcp90/msvcp90_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/dlls/msvcp90/msvcp90_main.c b/dlls/msvcp90/msvcp90_main.c > index 7a7aafe..ce56c14 100644 > --- a/dlls/msvcp90/msvcp90_main.c > +++ b/dlls/msvcp90/msvcp90_main.c > @@ -80,10 +80,13 @@ static void init_cxx_funcs(void) > > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > { > - TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + TRACE("(%p,%u,%p)\n", hinstDLL, fdwReason, lpvReserved); > > switch (fdwReason) > { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ > + > case DLL_PROCESS_ATTACH: > init_cxx_funcs(); > init_lockit(); > msvcp90 has some wine specific exports. This patch breaks other msvcpXX dlls when native msvcp90 is installed.

3 5

GSoC 2013 - Registry Merging Project
by orzhvs 17 May '13

17 May '13

Hi. I'm applying for the Google Summer of Code 2013, this is my proposal for the registry merging project. I'll work on improving Wine's registry in its stability and simulation to solve frequently seen non user-friendly problems, which usually caused by that application or system settings are not stored and fetched correctly. Project & My Understand: I'm most interested in the project "Registry - implement merging between HKEY_CLASSES_ROOT and HKEY_CURRENT_USER\Software\Classes". Its core task is to implement RegOpenUserClassesRoot, which returns a key token of merging view of HKCU & HKLM classes rather than present returning HKCR Classes. The difficulity is that as a view of two independent registry trees, how to treat conflicts and make changes to two seperated entrys when using HKCR as root, and how to achieve the function with no or least effect on other part of registry operation such as RegOpenKeyExX. I have some seed ideas that maybe not mature but I like solving problems initially from a burst port : Scheme 1. Registry operations based on hKey ( handle ) under HKEY_CLASSES_ROOT will be degeneration to full path in text, like "HKEY_CLASSES_ROOT\Subdir1", and try the operation after "HKEY_CLASSES_ROOT" replaced with "HKEY_CURRENT_USER\Software\Classes" and "HKEY_LOCAL_MACHINE\Software\Classes" in order, only the first success operation will be applied. This may satisfy the demand, both for query and modify. For details like the correct order, I'll make it out once get working on it. In this way, the HKCR key subtree does not exist in fact but only exists as a name. Scheme 2. After the base registry is initialized, build the HKCR's subkey trees with a new pulled in object type (say it 'symbol link') that directly point to the correct keys from HKLM or HKCU. Thus operation in HKCR tree are redirected to corresponding branch internally. When operating the HKCR itself, like creating new subkeys direct under HKCR, the operation is redirected to HKCU classes. This scheme seems more fluent but needs some tricks in the server part. What I'll Do : First of all I'll do a lot of tests on pure winows registry to definite my questions and guesses, write one or more test reports on different version of windows, some of which is already being done now. Followed by I will design the algorithms and data structures and make a complete development planation. Then enjoying coding and debuging Wine. I love the procedure, during the longest part of this project, keep writing daily report. Got the plan finished, I will applying improvement. Finally strict tests will be done to show if I achieved the final goal and a conclude paper will be carefully submitted. I'd like not only settle down the main project, but also several ideas to make Wine better, which are found in my daily use of Wine, such as add support for the shell context menu in Wine explorer for many convenient shotcuts of some software like the famous 7zip. I'll do this once time allows. Why Me : I myself is a faithful user of Wine. I know the thought of Wine and know not only basic usage but also a little implement of it. I understand Windows registry both Windows API pretty well from nearly 8 years coding. Have done much test and hooks in windows including RegXXX in advapi32.dll or lower level NtOpenKey in ntdll.dll. Further more, I used to do some kernel debug tests and hacks on registry, like hiding, protecting a subkey from regedit, resolving values from hive file rather than using API. These things are done under interests. I've been learning Windows API and OS theories from books and network like msdn for long. Ofcourse there will be no problem in registry knowledge. It's usual for me to write codes more than 1000 lines a day, for self use or for the competation ACM. I believe that I'm a careful man in codes and other things, I like discovering, guessing and proving. To prove I've developed a not too bad coding style, please refer to my submisions on codeforces http://codeforces.com/submissions/adnim (to view code click numbers under column "#"). And this may be a little evidence denoting that at least I've used git before, https://code.google.com/p/eryapass/ I know what should I do and what should not. I'm sure aware of the legal requirements. All of my tests will be done only in the black-box ways. No reverse work on Windows files is allowed and needed in Wine project, though I'm good at that. All codes will be written creatively and nothing will be copied from existing ones like WRK, RcactOS or something else. I love open source. I benefited much from the open source world and I'd be really happy to contribute to it one day. The last but most important, I'm much willing and I'm looking forward to throwing myself among the crowd of codes this entire summer, making maxium effort to improve Wine. I'd like schedule my personal activities to avoid conflicts with the development, meaning it won't be too busy in my schoolwork. Wine & Me : In my childhood, I've been coding in F-Basic on Subor (a kind of TV-based computer made in China) when friends are playing football in yard, at about 8 years old. When I was 12 years old, i was building some little games to happy classmates, and have learned c and c++ 2 years latter, then x86 asm 2 more years latter. And have done some graduation-designs for college brothers before I got to university. Also I've developed some projects for local companies. I first installed Ubuntu in 2010 and gradually I'm interested in open source projects. I'm 21 years old now, studying software engineering in Shandong University of Science and Technology in China. I'm a really enthusiastic user of Wine, who has been using it from version 1.2 to 1.4, on ubuntu, debian and gentoo. Since the first day I apt-got it I could not help trying all applications I used in Windows to it and making them running stably, during which I have learned much about configuring Wine. Another day I began to emerging that and I was once deep interested in building my customed Wine and Wine based tests. I heard about GSoC last year but missed the time. This year, I decided that I will try my best to contribute, transform my ideas to powerful codes that people will run with satisfaction. Please do not hesitate to contact me. Thanks. Guo Jian

3 9

gdi32: GetGlyphIndices doesn't substitute glyph incorrect
by Aric Stewart 17 May '13

17 May '13

Hi there, I know I am a year late to the party here but I am digging deep into tategaki for a few Japanese programs that are having serious rendering issues and I believe that this patch is incorrect. I am attaching the test patch that proves it to me. Kusanagi-san, we should try to make sure that this does not break what it was that you where trying to fix with your original patch. -aric

2 4

Re: [PATCH 5/5] mshtml: Added whitespace parser tests.
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25599 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] mshtml: Added parsing custom tag name tests.
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25598 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] mshtml: Added more parser compatMode tests.
by Marvin 17 May '13

17 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25597 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] user32/tests: Test that sending WM_CANCELMODE cancels tracking in window's menu bar.
by Dmitry Timoshkov 17 May '13

17 May '13

Ken Thomases <ken(a)codeweavers.com> wrote: > dlls/user32/tests/menu.c | 21 ++++++++++++++++++++- Please add a message test instead, it would much more clearer show what is going on. > + {MSG msg; while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessage(&msg);} Please avoid creating such embedded blocks. -- Dmitry.

2 2

Re: winemac.drv: add fullscreen mode support for Mac OS X 10.7+
by Ken Thomases 16 May '13

16 May '13

Hi Kevin, I'm bringing this back to wine-devel. Please CC the list unless you intend to take things private, in which case please say so. On May 10, 2013, at 6:48 PM, Kevin Eaves wrote: > I should have made everything clear, sorry. It was for personal use, so it's pretty nasty, but works great. The only real problem is with user32. Everything else is easy to clean up and get working with Wine properly without any issues. Just wanted to show that. Sure, that's what I figured. > On May 9, 2013, at 9:56 PM, Ken Thomases wrote: > >>> The fullscreen button appears if a main window is resizable. >> >> We may want to narrow this down a bit. For example, the common file dialogs are resizable, but probably shouldn't be full-screen-enabled. Perhaps no owned window should be. > > Only windows in the windows cycle should be fullscreen enabled. If the window can be manually moved to its own space, then it should be able to go fullscreen. No dialogs are enabled. These follow the main window to spaces. If in Cocoa fullscreen, the new window automatically opens fullscreen in its own space. Everything works just like Mac applications with this setting. Ah, I failed to notice before that the use of NSWindowCollectionBehaviorFullScreenPrimary was only in the same code path as NSWindowCollectionBehaviorParticipatesInCycle. Yes, that makes sense. >> From cocoa_window.m.diff: >> >>> +#import <Cocoa/Cocoa.h> >> >> >> Was that actually needed? cocoa_window.h already imports <AppKit/AppKit.h>. >> >> ... >> >>> + if (style & NSResizableWindowMask) >>> + [[self standardWindowButton:NSWindowZoomButton] setEnabled:!self.disabled]; > > These should have not been included in the diff. It's unrelated to Cocoa fullscreen, however, the zoom button is currently bugged. It is not disabled when the window is disabled. To reproduce the problem: launch regedit, open the import window, and click the zoom button on the main window. I sent a patch for it. I'm not seeing that problem happen here. Mind you, I'm currently testing on 10.6. I'll have to run some tests on 10.7+ tomorrow. I find it improbable that removing NSResizableWindowMask from the style doesn't disable the zoom button. That style is the only thing which enables the zoom button to begin with. In other words, in a normal Mac app, one would not need to disable the zoom button separately. >>> - if (captured || fullscreen) >>> + if (captured || (fullscreen && !(normalStyleMask & NSResizableWindowMask))) >> >> You're trying to distinguish between a window that was full-screened at the instigation of the Windows program versus one which has been full-screened by Cocoa, right? Hmm. I think we need a better technique to determine that. I agree that it's not likely the Windows program would make its window full-screen while still allowing it to be resized but it feels wrong to assume that. >> >> Also, I think we can entirely avoid setting the window level for windows that have been Cocoa full-screened. Setting the window level is mostly about relationship to other windows, but a Cocoa full-screen window should be on a space by itself, shouldn't it? >> >>> + else if ([self styleMask] & NSFullScreenWindowMask) >>> + level = NSMainMenuWindowLevel + 2; >> >> I'm not following why Cocoa full-screened windows should be at +2 vs. +1. > > The window levels are automatically adjusted and the menu is in a hover state. We need to prevent the menu from being hidden, and hide the menu if the Windows program goes fullscreen while in Cocoa fullscreen (+1 doesn't cut it). I'm going to have to do some testing to understand this, too. NSMainMenuWindowLevel should be in the same level as the menu (meaning could be above or below due to normal window ordering operations). NSMainMenuWindowLevel + 1 should always be above the menu, regardless. NSMainMenuWindowLevel + 2 should not be necessary. But maybe something weird is going on. Also, if the Windows program changes a window from resizable to non-resizable, then we should probably pull the window out of Cocoa fullscreen. The Windows program _may_ have intended to make the window full-screen but we can't know that. It may simply be changing the window style for some other purpose, and that may make it no longer a candidate for Cocoa full-screen mode. >>> + - (NSSize)window:(NSWindow *)window willUseFullScreenContentSize:(NSSize)proposedSize >>> + { >>> + return NSMakeSize(proposedSize.width, proposedSize.height); >>> + } >> >> Is this actually needed? I assume that's the default behavior when the delegate method is absent. (Also, if it is necessary, it can just return proposedSize without making a new size struct.) > > This little gem will resize ANY window — non-resizable, disabled, a dialog box... Add this and poof!! There is no reason to ever disable Cocoa fullscreen. Mac applications don't so neither should Wine. I disagree. Windows programs that are not expecting their window to resize (because they haven't made them resizable) can misbehave badly if the window does resize. Just because that didn't happen in your testing doesn't mean it won't. As you mentioned in your original email, Cocoa full-screen is roughly akin to window resizing. So, it should be disabled if/when the window is made non-resizable. > I haven't tested this enough with non-resizable windows, but it is possible to resize any window. I don't follow this. It is possible to resize any window even non-resizable ones? To what are you referring? Possible how? Do you mean specifically just with this full-screen patch? > I use this feature to resize a few non-resizable game windows. Maybe add a registry key to allow non-resizable windows to go fullscreen. Perhaps. Cheers, Ken

2 2

Re: [PATCH 1/6] fonts: Add default glyph to Tahoma.
by Alexandre Julliard 16 May '13

16 May '13

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > fonts/tahoma.sfd | 94 +++++++++++++++++++++++++++++------------------------- > fonts/tahoma.ttf | Bin 100420 -> 97836 bytes > 2 files changed, 50 insertions(+), 44 deletions(-) We already have .notdef, we shouldn't need a second one. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: configure: try to use -Werror=unknown-warning-option if available (2/2)
by Alexandre Julliard 16 May '13

16 May '13

Austin English <austinenglish(a)gmail.com> writes: > @@ -1773,6 +1773,7 @@ then > fi > > dnl Check for some compiler flags > + WINE_TRY_CFLAGS([-Werror=unknown-warning-option]) > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) I don't think we want to build with that, it should be used only for the configure checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: vbscript: Round half to even in to_int.
by Marvin 16 May '13

16 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25581 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Participate in GSoC
by Adam Chyła 16 May '13

16 May '13

Hi all, I'm a student who would like to participate in GSoC with task "Tools - Winetest Graphical User Interface". What should I do? Adam Ch.

2 1

Re: WM_IME_REQUEST gets passed into ImmIsUIMessage
by Alexandre Julliard 15 May '13

15 May '13

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/imm32/imm.c | 2 ++ > dlls/user32/defwnd.c | 19 +++++++++++++++++++ > dlls/winemac.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > dlls/winex11.drv/ime.c | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 89 insertions(+) It breaks the tests: ../../../tools/runtest -q -P wine -M imm32.dll -T ../../.. -p imm32_test.exe.so imm32.c && touch imm32.ok imm32.c:580: Test failed: ImmIsUIMessageA returned 1 for 288 imm32.c:584: Test failed: ImmIsUIMessageA returned 1 for 288 make: *** [imm32.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] wined3d: Use d3d_level_from_gl_info in match_dx10_capable
by Henri Verbeet 15 May '13

15 May '13

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -613,14 +635,7 @@ static BOOL match_apple_nonr500ati(const struct wined3d_gl_info *gl_info, const > static BOOL match_dx10_capable(const struct wined3d_gl_info *gl_info, const char *gl_renderer, > enum wined3d_gl_vendor gl_vendor, enum wined3d_pci_vendor card_vendor, enum wined3d_pci_device device) > { > - /* DX9 cards support 40 single float varyings in hardware, most drivers report 32. ATI misreports > - * 44 varyings. So assume that if we have more than 44 varyings we have a dx10 card. > - * This detection is for the gl_ClipPos varying quirk. If a d3d9 card really supports more than 44 > - * varyings and we subtract one in dx9 shaders its not going to hurt us because the dx9 limit is > - * hardcoded > - * > - * dx10 cards usually have 64 varyings */ > - return gl_info->limits.glsl_varyings > 44; > + return d3d_level_from_gl_info(gl_info) >= 10; > } > I'm not sure d3d_level_from_gl_info() is quite reliable enough for this. For example, Mesa doesn't implement EXT_gpu_shader4, and possibly never will. Using an actual hardware limit seems more reliable.

1 0

Re: [PATCH 5/6] d3d: d3d9ex does not do video memory accounting for D3DPOOL_DEFAULT resources
by Henri Verbeet 15 May '13

15 May '13

On 14 May 2013 23:46, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -922,6 +922,8 @@ enum wined3d_display_rotation > #define WINED3DCREATE_DISABLE_DRIVER_MANAGEMENT 0x00000100 > #define WINED3DCREATE_ADAPTERGROUP_DEVICE 0x00000200 > > +#define WINED3DCREATE_NO_VIDMEM_ACCOUNTING 0x10000000 > + I think it makes more sense to make this a wined3d_create() flag, and in invert it, since we also want this for d3d10+. E.g. something along the lines of WINED3D_NO_GPU_VMM.

1 0

Wacom Graphire3 tablet not detected as tablet (MacOSX 10.8)
by Andrey Upadyshev 14 May '13

14 May '13

Hi, I have Wacom Graphire3 tablet and it's working well under Windows, MacOS or MacOS + X (Inkscape). But Wine can't detect it as tablet and disables the wintab support. The actual stylus device is Device 6 [id 8|name pen|type |num_classes 2|use 4], but log says it is not apparently a tablet cursor type device. There is a wintab log: > trace:wintab32:DllMain 0x43d60000, 1, 0x0 > trace:wintab32:DllMain Initialization > trace:wintab32:TABLET_WindowProc Incoming Message 0x81 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x83 (0x00000000, > 0x0032f400) > trace:wintab32:TABLET_WindowProc Incoming Message 0x1 (0x00000000, > 0x0032f6b0) > trace:wintab32:TABLET_WindowProc Incoming Message 0x5 (0x00000000, > 0x00000000) > trace:wintab32:TABLET_WindowProc Incoming Message 0x3 (0x00000000, > 0x00000000) > trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x10126 > trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 9 devices > trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 2|name Virtual core > pointer|type |num_classes 2|use 0] > trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 3|name Virtual core > keyboard|type |num_classes 1|use 1] > trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 4|name Virtual core > XTEST pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 2 [name Virtual core > XTEST pointer|type ]; not apparently a tablet cursor type device. If this > is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 5|name Virtual core > XTEST keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 4: [id 6|name xquartz virtual > pointer|type |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 4 [name xquartz > virtual pointer|type ]; not apparently a tablet cursor type device. If > this is wrong, please report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 5: [id 7|name xquartz virtual > keyboard|type |num_classes 1|use 3] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo No buttons, Non Tablet Device > trace:wintab32:X11DRV_LoadTabletInfo Device 6: [id 8|name pen|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > warn:wintab32:X11DRV_LoadTabletInfo Skipping device 6 [name pen|type ]; > not apparently a tablet cursor type device. If this is wrong, please > report it to wine-devel(a)winehq.org > trace:wintab32:X11DRV_LoadTabletInfo Device 7: [id 9|name cursor|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:X11DRV_LoadTabletInfo Device 8: [id 10|name eraser|type > |num_classes 2|use 4] > trace:wintab32:X11DRV_LoadTabletInfo Is XExtension: Device, Keyboard, or > Pointer > trace:wintab32:X11DRV_LoadTabletInfo ButtonInput 0: [class 1|length > 12|num_buttons 3] > trace:wintab32:X11DRV_LoadTabletInfo ValidatorInput 1: [class 2|length > 80|num_axes 5|mode 1|motion_buffer 256] > trace:wintab32:trace_axes Axis 0: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 1: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 2: [resolution 1|min_value > 0|max_value 65536] > trace:wintab32:trace_axes Axis 3: [resolution 1|min_value > -65536|max_value 65536] > trace:wintab32:trace_axes Axis 4: [resolution 1|min_value > -65536|max_value 65536] > warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus, unable to > determine system context parameters. Wintab is disabled. > It would be great if someone can fix this problem. Thank you, Andrey Upadyshev

1 0

Re: [PATCH 3/3] d3dx9_36: Add support for D3DFMT_P8 and conversion to other ARGB formats + tests.
by Alexandre Julliard 14 May '13

14 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -36,6 +36,16 @@ static void la_to_rgba(const struct vec4 *la, struct vec4 *rgba) > rgba->w = la->w; > } > > +static void index_to_rgba(const struct vec4 *index, struct vec4 *rgba, const PALETTEENTRY *palette) > +{ > + ULONG idx = (ULONG)(index->x * 255.0f + 0.5f); > + > + rgba->x = palette[idx].peBlue / 255.0f; > + rgba->y = palette[idx].peGreen / 255.0f; > + rgba->z = palette[idx].peRed / 255.0f; > + rgba->w = palette[idx].peFlags / 255.0f; > +} PALETTEENTRY doesn't seem to be the right type for what you need. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Added capture test for child window when parent window is disabled.(try 4)
by Alexandre Julliard 14 May '13

14 May '13

Guo Jian <orzhvs(a)gmail.com> writes: > This is my first patch, could you please have a review? Thank you. Looks OK, but you could probably merge it into one of the existing capture tests, it doesn't really need a brand-new window. Also when sending patches that depend on each other, please number them so that the testbot can make sense of it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (resend).
by Alexandre Julliard 14 May '13

14 May '13

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-streaming sites as well). > > With this patch the SIO_ADDRESS_LIST_CHANGE call gets passed on to > NotifyAddrChange, which effectively fixes a problem where Silverlight > apps can loop forever calling SIO_ADDRESS_LIST_CHANGE (Bug #32328). > Part 2 actually implements the NotifyAddrChange call on Linux, though > this patch is sufficient to resolve the bug since the overlapped IO > event no longer gets triggered. The notification is supposed to be tied to the socket. I don't think that NotifyAddrChange can do the job. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: Disable the zoom button for windows that are disabled.
by Ken Thomases 14 May '13

14 May '13

Hi Kevin, As mentioned in the other thread, I'm not seeing the problem that this is meant to solve on 10.6. I will test 10.7+ tomorrow. Also, I'm pretty sure that setting the style mask after disabling the buttons can reenable them. At least in some versions of the frameworks, we've seen that -setStyleMask: basically resets the standard buttons from scratch. Indeed, in my testing, this patch reenables the close and minimize buttons on a disabled window. Regards, Ken

1 2

[PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)
by Guo Jian 14 May '13

14 May '13

Hello everyone, This is my first patch to wine, which has been submitting since the last day. Please help that what is the safe way sending patches that makes sure the patch is not corrupt by my mail client? Is it the most correct way to attach a path with .txt suffix rather than past inline? Or which mail client should I use that may avoid this problem? Thunderbird wraps long lines and join lines terminating with a space, I have to manually correct that, it does slows me down. Thanks. Guo Jian A window will lose capture if it's disabled, but it's children should not. Related to bug 33542. The test is to show that mouse capture of a window is lost when disabling its parent window. It has been tested fine with newtestbot. --- dlls/user32/tests/win.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+)

2 1

Re: user32: Use PostMessage to send WM_DRAWCLIPBOARD
by Alexandre Julliard 13 May '13

13 May '13

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/user32/clipboard.c | 4 +-- > dlls/user32/tests/clipboard.c | 78 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 80 insertions(+), 2 deletions(-) We already have tests that show that this is wrong: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:12683: Test failed: set viewer NULL->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12690: Test failed: clear clipbd (viewer=owner=1): 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12695: Test failed: clear clipbd (viewer=1, owner=2): 1: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12700: Test failed: set viewer 1->1: 0: the msg sequence is not complete: expected 0308 - actual 0000 msg.c:12751: Test failed: clear clipbd (no viewer, owner=1): 0: the msg sequence is not complete: expected 0307 - actual 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] wined3d: Pass the state and private data to shader_select
by Henri Verbeet 13 May '13

13 May '13

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Disable shaders */ > - device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE); > + device->shader_backend->shader_select(context, WINED3D_SHADER_MODE_NONE, WINED3D_SHADER_MODE_NONE, > + NULL, device->shader_priv); I think that's a bit questionable. Passing NULL state happens to work for this set of arguments, but I don't think we want that to be part of the interface.

3 3

Re: po: Fix typos in German translation
by Julian Rüger 13 May '13

13 May '13

Hi André, > -msgstr "Datagramme gesendet" > +msgstr "Datenpakete gesendet" In all my university classes, (UDP) Datagrams were translated or referred to as "Datagramme" and more or less strictly distinguished from packets. "Vollzugriff" vs. "voller Zugriff" is a matter of taste, I picked the first because back when I used Windows, that was a common term to read, but that could have just been my firewall or something. I would have preferred for it to be added to Francois' wordlist, but whatever. Best, Julian

2 1

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify (try 2).
by Marvin 13 May '13

13 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25553 Your paranoid android. === WXPX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === WVISTAX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === W7PROX64 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120 === TEST64_W7SP1 (64 bit iphlpapi) === iphlpapi.c:1077: Test failed: Overlapped IO returned c0000120, expected c0000120

1 0

Re: [PATCH 4/5] wined3d: Explicitly pass the state to shader_load_constants
by Henri Verbeet 13 May '13

13 May '13

On 12 May 2013 15:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -806,7 +806,8 @@ struct wined3d_shader_backend_ops > void (*shader_deselect_depth_blt)(void *shader_priv, const struct wined3d_gl_info *gl_info); > void (*shader_update_float_vertex_constants)(struct wined3d_device *device, UINT start, UINT count); > void (*shader_update_float_pixel_constants)(struct wined3d_device *device, UINT start, UINT count); > - void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS); > + void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS, > + const struct wined3d_state *state, void *shader_priv); > void (*shader_load_np2fixup_constants)(void *shader_priv, const struct wined3d_gl_info *gl_info, > const struct wined3d_state *state); > void (*shader_destroy)(struct wined3d_shader *shader); > I think we'll want shader_priv to be the first argument, for consistency with the other calls. I don't think usePS and useVS are needed anymore.

1 0

Re: [PATCH 3/3] iphlpapi: Implement CancelIPChangeNotify.
by Hans Leidekker 13 May '13

13 May '13

On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote: > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -210,8 +210,14 @@ DWORD WINAPI AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable, > */ > BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED overlapped) > { > - FIXME("(overlapped %p): stub\n", overlapped); > - return FALSE; > + HANDLE handle; > + > + TRACE("(overlapped %p)\n", overlapped); > + > + if (!overlapped) > + return FALSE; > + handle = (HANDLE) overlapped->u.Pointer; > + return TerminateThread(handle, STATUS_CANCELLED); > } TerminateThread is not the right tool here. If the thread is blocked on the recv call while being terminated it will leak the netlink socket. You'd need a way to synchronize the threads, but an overhead of one thread per caller is rather costly in the first place. This suggests that the server should poll the socket.

3 9

Re: [2/2] server: Remove a not necessary check for 'current' being not NULL.
by Alexandre Julliard 13 May '13

13 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > 'current' is already dereferenced twice before this point. > --- > server/request.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) You can't do that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [website] Simplified Chinese translation for release 1.5.30
by Qian Hong 13 May '13

13 May '13

2013/5/11 Jactry Zeng <jactry92(a)gmail.com>: > + <li>WinInet 对代理旁路的支持。</li> This translation seems suspect, but I don't have a very good alternative yet. In 'Internet Options' setting of MSIE7, 'Bypass proxy server for local address' is translated to '跳过本地地址的代理服务器' Thanks for the work. -- Regards, Qian Hong - http://www.winehq.org

2 2

IPC between linux processes and wine processes
by Alexandre Bique 12 May '13

12 May '13

Hi, I plan to write a Linux VST bridge to Windows VST. This could improve windows VST support in our native DAW. I wonder what is the best strategy and what do you recommend? - spawn a wine vst host process from the linux vst and then do IPC through unix socket - spawn a wine vst host process from the linux vst and then do IPC through tcp socket - spawn a wine vst host process from the linux vst and then do IPC through shared memory - load the windows vst into the Linux process and directly call its functions (with appropriate calling convention). Thanks a lot! Regards, -- Alexandre Bique

3 4

[PATCH] Tests that prove ntdll has no notion of HKCR.
by George Stephanos 12 May '13

12 May '13

As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't stored and rather fetched live. These tests prove that advapi32 calls that reference HKCR are either pointed there to \REGISTRY\MACHINE or \REGISTRY\USER and hence, that the merge is to be done in advapi32. http://newtestbot.winehq.org/JobDetails.pl?Key=976 --- dlls/advapi32/tests/registry.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index b2483a7..8437e4d 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -43,6 +43,7 @@ static DWORD (WINAPI *pRegDeleteTreeA)(HKEY,LPCSTR); static DWORD (WINAPI *pRegDeleteKeyExA)(HKEY,LPCSTR,REGSAM,DWORD); static BOOL (WINAPI *pIsWow64Process)(HANDLE,PBOOL); static NTSTATUS (WINAPI * pNtDeleteKey)(HANDLE); +static NTSTATUS (WINAPI * pNtQueryKey)(HANDLE,int,PVOID,ULONG,PULONG); static NTSTATUS (WINAPI * pRtlFormatCurrentUserKeyPath)(UNICODE_STRING*); static NTSTATUS (WINAPI * pRtlFreeUnicodeString)(PUNICODE_STRING); @@ -136,6 +137,7 @@ static void InitFunctionPtrs(void) pRtlFormatCurrentUserKeyPath = (void *)GetProcAddress( hntdll, "RtlFormatCurrentUserKeyPath" ); pRtlFreeUnicodeString = (void *)GetProcAddress(hntdll, "RtlFreeUnicodeString"); pNtDeleteKey = (void *)GetProcAddress( hntdll, "NtDeleteKey" ); + pNtQueryKey = (void *)GetProcAddress( hntdll, "NtQueryKey" ); } /* delete key and all its subkeys */ @@ -2104,6 +2106,7 @@ static void test_classesroot(void) DWORD type = REG_SZ; static CHAR buffer[8]; LONG res; + void *buf = malloc(300*sizeof(wchar_t)); /* create a key in the user's classes */ if (!RegOpenKeyA( HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", &hkey )) @@ -2132,6 +2135,9 @@ static void test_classesroot(void) RegCloseKey( hkey ); return; } + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp((wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in user's classes */ res = RegSetValueExA(hkey, "val1", 0, REG_SZ, (const BYTE *)"user", sizeof("user")); @@ -2200,6 +2206,9 @@ static void test_classesroot(void) RegCloseKey( hklm ); return; } + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in hklm classes */ res = RegSetValueExA(hklm, "val2", 0, REG_SZ, (const BYTE *)"hklm", sizeof("hklm")); @@ -2227,6 +2236,9 @@ static void test_classesroot(void) KEY_QUERY_VALUE|KEY_SET_VALUE, &hkcr ); ok(res == ERROR_SUCCESS, "test key not found in hkcr: %d\n", res); + pNtQueryKey( hkcr, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\USER", 14) == 0, + "key not from \\REGISTRY\\USER\n"); /* set a value in user's classes */ res = RegSetValueExA(hkey, "val2", 0, REG_SZ, (const BYTE *)"user", sizeof("user")); @@ -2267,6 +2279,9 @@ static void test_classesroot(void) /* try to open that subkey in hkcr */ res = RegOpenKeyExA( hkcr, "subkey1", 0, KEY_QUERY_VALUE|KEY_SET_VALUE, &hkcrsub1 ); ok(res == ERROR_SUCCESS, "test key not found in hkcr: %d\n", res); + pNtQueryKey( hkcrsub1, 3 /*KeyNameInformation*/, buf, 500*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\MACHINE", 17) == 0, + "key created in hkcr not found in \\REGISTRY\\MACHINE\n"); /* set a value in hklm classes */ res = RegSetValueExA(hklmsub1, "subval1", 0, REG_SZ, (const BYTE *)"hklm", sizeof("hklm")); @@ -2326,6 +2341,9 @@ static void test_classesroot(void) /* new subkey in hkcr */ if (RegCreateKeyExA( hkcr, "subkey2", 0, NULL, 0, KEY_QUERY_VALUE|KEY_SET_VALUE, NULL, &hkcrsub2, NULL )) return; + pNtQueryKey( hkcrsub2, 3 /*KeyNameInformation*/, buf, 256*sizeof(wchar_t), (ULONG*)&res ); + ok( wcsncmp( (wchar_t*)buf+2, L"\\REGISTRY\\MACHINE", 17) == 0, + "key not found in \\REGISTRY\\MACHINE"); res = RegSetValueExA(hkcrsub2, "subval1", 0, REG_SZ, (const BYTE *)"hkcr", sizeof("hkcr")); ok(res == ERROR_SUCCESS, "RegSetValueExA failed: %d, GLE=%x\n", res, GetLastError()); -- 1.8.1.msysgit.1

3 11

Re : Full software of Wine version 1.4
by Nick Kucan 11 May '13

11 May '13

Dear Sir/madam, My name is Nick Kucan and I have ubuntu 11.04 at home - In the last three month I had a major issue with my the operating system (which I am currently investigating the source error) - Each time the system crashes (fails to load and screen says "input signal out of range" and does not load Ubuntu 11.04). I have tried Ubuntu 12.10 but unfortunatly there is a major issue with my modem - Every time i tried to connect - less than a second later - it cuts it right off. I have tried get help with the ubuntu website and provider - no such luck at this point of time. There is no such issue with version 11.04. I am forced to re-install and restore from backup - the wine program that I backed up wont even load so I am forced to download at least 170mb (and at least 1 hour to download from your headquaters website which I am tired of downloading the last 30 times - that cost me a lot of money to from my pre-paid account. I wish to download that .deb package from another source and burn into a dvd for my personal use only instead of downloading every time from your website each time and restore everything from its point. Can provide me a good link that I can directly download that file and I need to burn only one copy for my home pc so it can make my life a little easy - this copy of windows wine will NOT be distributed to anyone else except for my own stand alone pc in an emergency so that I can restore it back the way it is please. I have backed up the firefox and adobe flashplayer on the backup dvd - it works fine - the only issue is that the wine program full file cant get it working so its forced me to go back to the software source and download that painfully long software again!. Can u help me please.... Nick Kucan.

2 1

Re: [1/2] winex11: Cache XRandR 1.0 display mode. (try 2)
by Ruslan Kabatsayev 10 May '13

10 May '13

Hi, Won't such code fail if the mode is changed outside wine? Regards, Ruslan On Fri, May 10, 2013 at 8:07 PM, Sam Edwards <cfsworks(a)gmail.com> wrote: > > > >

2 1

Re: [1/3] winex11: Select for XRandR screen change events and implement an event handler.
by Alexandre Julliard 10 May '13

10 May '13

Sam Edwards <cfsworks(a)gmail.com> writes: > This patch adds an event handler to xrandr.c to process > RRScreenChangeNotify events, so that when non-Wine applications change > the display resolution, Wine can find out about it. > > Two main discussion points: > > - Previously, there was nothing pulling events out of gdi_display's > queue, thus necessitating the need for a new event handler. I opted to > put it in xrandr.c since this handler only manages XRandR events, but > it might be cleaner to move it over to event.c. > > - Are we okay with having to call the event handler, or would this > work better in a continuously-running background thread instead? It's okay only because you are not actually calling it ;-) But no, you can't select for events on the gdi display; actually I don't think you want to do it this way at all. Handling external resizes should be done in the desktop process, and most likely involves the wineserver too. It certainly won't be an easy task. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [2/3] kernel32: Terminate threads before unloading DLLs on process exit.
by Alexandre Julliard 10 May '13

10 May '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > If it's not yet time to make this change please let me know what else needs > to be tested/fixed/investigated. The heap behavior would need testing, since freeing memory is probably the most common thing done in a detach routine. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] d3dcompiler: Add a LUT to find compilation targets info. (try 3)
by Alexandre Julliard 10 May '13

10 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > - if (strlen(target) != 6 || target[1] != 's' || target[2] != '_' || target[4] != '_') > + for (i = 0; i < nb_targets; i++) > { > - FIXME("Unknown compilation target %s.\n", debugstr_a(target)); > - return D3DERR_INVALIDCALL; > + if (!strcmp(target, targets_info[i].name) || > + (targets_info[i].altname && !strcmp(target, targets_info[i].altname))) A binary search would be much better. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ieframe: Added more InternetExplorer object tests.
by Marvin 10 May '13

10 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25508 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: Re: Ask for mentor - Improve Bcrypt
by Marek Chmiel 10 May '13

10 May '13

Hey Kaiyi Zhang, Welcome to wine dev! If you decide to move forward with this(DH and DSS), I wish to share with you all that I have finished up to now. Using a few things from RSAENH I have all the related algorithms functioning. Also using LibTomCrypt I have partially implemented DSA but you would have to choose on the PRNG that DSA will use. My plan was to use RC4 but have not gotten to test that. I have yet to touch anything with DH_EPHEM (Ephemeral) or DH_SF (Store and Forward). If you have any questions shoot them to Juan or me (Juan is the better choice). Best of luck! -- Marek >Hi Kaiyi Zhang, > >(or is Zhang Kaiyi?) > >I think there's a little misconception in your proposal. Bcrypt the >algorithm is not the same as the BCrypt functions in crypt32. I believe >that Microsoft redesigned their CryptoAPI and more or less renamed their >functions BCrypt*. I don't believe they have any relationship to the Bcrypt >algorithm by Niels Provos and David Mazieres. I don't know how many >applications depend on the Bcrypt* functions in newer crypt32 >implementations, vs. the the Crypt* functions that are present in all >versions of crypt32. > >If you want feedback on Wine crypto stuff, I'm probably the best to help >you with that. Sorry if I've been a little absent, I'm pretty busy between >my family and my day job of late. > >I have another idea for you that I think is tractable, and perhaps up your >alley. The DH and DSS algorithms are still unimplemented in Wine. We >already have tests for them, so I think it should be possible to contribute >implementations. See the tests in dlls/dssenh/tests. > >I hope that helps. >--Juan

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang 10 May '13

10 May '13

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

2 2

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.
by Alexandre Julliard 09 May '13

09 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > { > ID3DXFileImpl *object; > HRESULT ret; > + const char expand_string[] = "expand_string"; > > TRACE("(%p)\n", d3dxfile); > > @@ -701,6 +702,11 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) > object->ID3DXFile_iface.lpVtbl = &ID3DXFile_Vtbl; > object->ref = 1; > > + /* Enable string expansion extension in d3dxof */ > + ret = IDirectXFile_RegisterTemplates(object->dxfile, (void*)expand_string, sizeof(expand_string)); > + if (ret != DXFILE_OK) > + ERR("Native d3dxof.dll used. Use builtin one to avoid problem.\n"); That's really ugly. You have to find a better way. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH] mscms: Use lcms2, when available
by wine.dev＠web.de 09 May '13

09 May '13

Hi Hans. >> lcms2 was released on 8. May 2010 >> lcms v1 is on the way to be phased out in the newest >> distribution versions. >Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for replacing lcms v1. There is no reason, that Wine is the last app, which depends on lcms v1. -- By by ... Detlef

4 4

Patches 96113 & 96114
by Christian Costa 09 May '13

09 May '13

Hi, Is there anything wrong with these patches? http://source.winehq.org/patches/data/96113 http://source.winehq.org/patches/data/96114 Christian

1 0

Re: [PATCH 2/3] oleaut32: COM cleanup for ITypeInfo object
by Andrew Eikum 09 May '13

09 May '13

Looks like I missed replacing the ITypeInfo casts with impl_from calls, e.g.: static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, ITypeComp * *ppTComp) { ITypeInfoImpl *This = (ITypeInfoImpl *)iface; You can apply these, or wait until I amend them to fix that, too. Whichever. Andrew On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote: > --- > dlls/oleaut32/typelib.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index e62fa84..c6d2189 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -1094,8 +1094,8 @@ typedef struct tagTLBImplType > /* internal TypeInfo data */ > typedef struct tagITypeInfoImpl > { > - const ITypeInfo2Vtbl *lpVtbl; > - const ITypeCompVtbl *lpVtblTypeComp; > + ITypeInfo2 ITypeInfo2_iface; > + ITypeComp ITypeComp_iface; > LONG ref; > BOOL not_attached_to_typelib; > TYPEATTR TypeAttr ; /* _lots_ of type information. */ > @@ -1125,7 +1125,7 @@ typedef struct tagITypeInfoImpl > > static inline ITypeInfoImpl *info_impl_from_ITypeComp( ITypeComp *iface ) > { > - return (ITypeInfoImpl *)((char*)iface - FIELD_OFFSET(ITypeInfoImpl, lpVtblTypeComp)); > + return CONTAINING_RECORD(iface, ITypeInfoImpl, ITypeComp_iface); > } > > static const ITypeInfo2Vtbl tinfvt; > @@ -4884,7 +4884,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if (pTypeInfo->Name && !strcmpW(pTypeInfo->Name, szName)) > { > *pDescKind = DESCKIND_TYPECOMP; > - pBindPtr->lptcomp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + pBindPtr->lptcomp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(pBindPtr->lptcomp); > TRACE("module or enum: %s\n", debugstr_w(szName)); > return S_OK; > @@ -4894,7 +4894,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_MODULE) || > (pTypeInfo->TypeAttr.typekind == TKIND_ENUM)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > > hr = ITypeComp_Bind(pSubTypeComp, szName, lHash, wFlags, ppTInfo, pDescKind, pBindPtr); > @@ -4910,7 +4910,7 @@ static HRESULT WINAPI ITypeLibComp_fnBind( > if ((pTypeInfo->TypeAttr.typekind == TKIND_COCLASS) && > (pTypeInfo->TypeAttr.wTypeFlags & TYPEFLAG_FAPPOBJECT)) > { > - ITypeComp *pSubTypeComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + ITypeComp *pSubTypeComp = &pTypeInfo->ITypeComp_iface; > HRESULT hr; > ITypeInfo *subtypeinfo; > BINDPTR subbindptr; > @@ -5013,9 +5013,9 @@ static HRESULT WINAPI ITypeLibComp_fnBindType( > if (pTypeInfo->Name && !strcmpiW(pTypeInfo->Name, szName)) > { > TRACE("returning %p\n", pTypeInfo); > - *ppTInfo = (ITypeInfo *)&pTypeInfo->lpVtbl; > + *ppTInfo = (ITypeInfo *)&pTypeInfo->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > - *ppTComp = (ITypeComp *)&pTypeInfo->lpVtblTypeComp; > + *ppTComp = &pTypeInfo->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -5046,8 +5046,8 @@ static ITypeInfoImpl* ITypeInfoImpl_Constructor(void) > pTypeInfoImpl = heap_alloc_zero(sizeof(ITypeInfoImpl)); > if (pTypeInfoImpl) > { > - pTypeInfoImpl->lpVtbl = &tinfvt; > - pTypeInfoImpl->lpVtblTypeComp = &tcompvt; > + pTypeInfoImpl->ITypeInfo2_iface.lpVtbl = &tinfvt; > + pTypeInfoImpl->ITypeComp_iface.lpVtbl = &tcompvt; > pTypeInfoImpl->ref = 0; > pTypeInfoImpl->hreftype = -1; > pTypeInfoImpl->TypeAttr.memidConstructor = MEMBERID_NIL; > @@ -5238,7 +5238,7 @@ static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, > > TRACE("(%p)->(%p)\n", This, ppTComp); > > - *ppTComp = (ITypeComp *)&This->lpVtblTypeComp; > + *ppTComp = &This->ITypeComp_iface; > ITypeComp_AddRef(*ppTComp); > return S_OK; > } > @@ -6999,7 +6999,7 @@ static HRESULT WINAPI ITypeInfo_fnGetRefTypeInfo( > > if ((This->hreftype != -1) && (This->hreftype == hRefType)) > { > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > result = S_OK; > } > @@ -7913,7 +7913,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_FUNCDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } else { > @@ -7923,7 +7923,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > if (FAILED(hr)) > return hr; > *pDescKind = DESCKIND_VARDESC; > - *ppTInfo = (ITypeInfo *)&This->lpVtbl; > + *ppTInfo = (ITypeInfo *)&This->ITypeInfo2_iface; > ITypeInfo_AddRef(*ppTInfo); > return S_OK; > } > @@ -7934,7 +7934,7 @@ static HRESULT WINAPI ITypeComp_fnBind( > ITypeInfo *pTInfo; > ITypeComp *pTComp; > HRESULT hr; > - hr=ITypeInfo_GetRefTypeInfo((ITypeInfo *)&This->lpVtbl, This->impltypes[0].hRef, &pTInfo); > + hr=ITypeInfo2_GetRefTypeInfo(&This->ITypeInfo2_iface, This->impltypes[0].hRef, &pTInfo); > if (SUCCEEDED(hr)) > { > hr = ITypeInfo_GetTypeComp(pTInfo,&pTComp); > -- > 1.8.2.2 > > > >

1 0

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow
by Qian Hong 09 May '13

09 May '13

Hello Guo Jian, On Fri, May 10, 2013 at 1:36 AM, Guo Jian <orzhvs(a)gmail.com> wrote: > A window should not lose mouse capture even when it's parent window is > disabled. Did you forget to remove the todo_wine introduced in [patch 1/2]? Thanks for your work on it. -- Regards, Qian Hong

2 1

Re: [PATCH] user32: initialize just the members we need (Coverity)
by Marvin 09 May '13

09 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25499 Your paranoid android. === W2KPROSP4 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WXPPROSP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=4154256 max=0 scroll.c:446: Test failed: unexpected initialization === WXPX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=32203072 max=0 scroll.c:446: Test failed: unexpected initialization === W2K3R2SESP2 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=16706472 scroll.c:446: Test failed: unexpected initialization === W2K8SE (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1965166079 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (32 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2684764 max=1952452095 scroll.c:446: Test failed: unexpected initialization === WXPX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=0 max=100 scroll.c:446: Test failed: unexpected initialization === WVISTAX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === W7PROX64 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization === TEST64_W7SP1 (64 bit scroll) === scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:446: Test failed: unexpected initialization scroll.c:434: Test failed: unexpected initialization(SB_VERT): min=2291168 max=0 scroll.c:446: Test failed: unexpected initialization

1 0

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Qian Hong 08 May '13

08 May '13

Hi orzhvs, Thanks for your work on it, however, it seems gmail's line wrap 'feature' (hmm, isn't that a bug...) breaks your patch, you could try fight with that feature or send your patch as attachment instead.

1 0

Re: [Patch 1/2] user32/tests: Added test to show EnableWindow cause wrong ReleaseCapture
by Marvin 08 May '13

08 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25486 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3dx9_36: Fix typo in ID3DXFileDataImpl_GetName.
by Dmitry Timoshkov 08 May '13

08 May '13

Christian Costa <titan.costa(a)gmail.com> wrote: > - if (!name || !size) > + if (!name && !size) > return E_POINTER; > > dxfile_size = *size; So, what happens if name is not NULL, but size is? -- Dmitry.

2 1

Ask for mentor - Improve Bcrypt
by Kaiyi Zhang 08 May '13

08 May '13

Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of GSOC. However, There are some exams which takes a lot of time, So lack of communication with the wine developers. I know it is late to apply for GSoC, however, I'm still interesting to the cryptography work in Wine even if I'm not accept as an official GSoC2013 student. Cryptography work is difficult, and Wine is difficult, so cryptography in Wine is double difficult for a beginner like me, could I ask for a mentor for the cryptography work even if my proposal is not accepted? To my dear kindly future mentor: I don't know how to thank you, but I'll work hard on contributing to the Wine project as more as I can. Sincerely appreciate. My idea is bcrypt improvement, I think it's very suitable for me, I learned the information security. Cryptography is one of my courses. I once development a Elliptic curve cryptography Demonstration system which makes the ECC Graphical. And i found there is blank in bcrypt, I want to do some improvement in this. I know there it's difficult for me to develop. but i can code some test code firstly. I read the dlls/rsaendh/tests/rsaenh.c: test_hashes(),test_des(),test_rsa() etc. and test the code on ubuntu successfully. Here is my plan: Week 1 - Week 2 - Get the Winedebug and document more adept - Get more information about bcrypt - Bcrypt Wiki: http://en.wikipedia.org/wiki/Bcrypt - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - File of Bcrypt: http://bcrypt.sourceforge.net/ - Read the Document of MSDN about Bcrypt and code some examples - MSDN about Bcrypt: http://msdn.microsoft.com/en-us/library/windows/desktop/aa833130(v=vs.85).a… Week 3 - Week 5 -Read some wine tests code and run some tests like: - the basic encryption dll/crypt32/ - Understand the bcrypt algorithm, there is a lot of code for learning like: - A Future-Adaptable Password Scheme: http://static.usenix.org/events/usenix99/provos/provos_html/node1.html - https://github.com/rg3/bcrypt - https://code.google.com/p/py-bcrypt/source/browse/bcrypt/bcrypt.c Week 6 - Week 11 - Code the BCrypt. According to the MSDN The Steps of Bcrypt - Open the Algorithm Provider - Get or Set Algorithm Properties - Create or Import a key - Perform Cryptiographic Operations - Close the Algorithm Provider There is a cross platform Bcrypt at http://bcrypt.sourceforge.net. if it is possible we can use it and its license compatible with the wine lgpl license. - add stub functions for Tests functions() and code the Tests functions(). The dlls/rsaenh/tests/rsaenh.c is a good reference. encrypt the pdData and compare with the right value. stub BCryptCreateHash() BCryptHashData() BCryptDuplicateHash() BCryptDuplicateHash BCryptDestroyHash() for test_hashes(). stub BCryptGenerateSymmetricKey() BCryptKeyDerivation() BCryptDestroyKey() for test_key_derivation(). stub BCryptGenRandom() for test_gen_random(). Week 12 - End - There are also some more cryptions need to tests, I can do more improvement these Thank you.

1 0

Re: [PATCH] msi: Specify in FIXME that functions are semi-stub as for MsiMessageBoxEx. (resend)
by Alexandre Julliard 08 May '13

08 May '13

Christian Costa <titan.costa(a)gmail.com> writes: > { > - FIXME("%p %s %s %u %08x %08x\n", hWnd, debugstr_w(lpText), debugstr_w(lpCaption), > - uType, wLanguageId, f); > - return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); > + FIXME("(%p, %s, %s, %u, 0x%08x, 0x%08x): semi-stub\n", hWnd, debugstr_w(lpText), > + debugstr_w(lpCaption), uType, wLanguageId, f); > + return MessageBoxExW(hWnd,lpText,lpCaption,uType,wLanguageId); That sort of thing is not useful. If you are changing the function for other reasons you can update the trace, but otherwise it's just adding noise in the change history. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdi32: Simplify font->aveWidth sanity-checking to fix possible division by zero. (try 2)
by Christian Costa 08 May '13

08 May '13

Le 08/05/2013 11:45, Sam Edwards a écrit : > After feedback from Dmitry (thanks!), I redid this patch with the > following changes: > > * I misunderstood before what the test did; I initially thought this > was just a workaround to get aveWidth to behave, but as it turns out, > Windows has the same "maximum ratio of 100" limit. I changed the > comment to reflect that; hopefully this stops someone else from making > my mistake. :) > * Negative aveWidth checking is removed. I agree that there should be > a test to put this in, but Windows treats negative aveWidths as > invalid (according to Aric), so it can't be tested on Windows. That's > a much bigger mess than a simple "fix divide by zero" patch is worth. > * The division is done differently, to avoid potential overflow > problems. The result of the comparison is still exactly the same as > before the patch, except zero values are now handled gracefully. > > This supersedes 96111 (which, I forgot to mention before, supersedes > 96053 and 96047). > > Best, > Sam > + if (font->aveWidth && + (font->aveWidth - 1) / 100 >= font->potm->otmTextMetrics.tmHeight) { - if ((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / font->potm->otmTextMetrics.tmHeight > 100) - { Hi Sam, The test in the if is not that long. Shouldn't this fit into a single like as the previous test? Christian

1 0

Re: [2/2] comdlg32: Add a test for nCopies/dmCopies returned by PrintDlg.
by Marvin 08 May '13

08 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25483 Your paranoid android. === WVISTAX64 (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W2K8SE (32 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (32 bit printdlg) === Timeout === TEST64_W7SP1 (32 bit printdlg) === Timeout === WVISTAX64 (64 bit printdlg) === printdlg.c:242: Test failed: expected nCopies 1234, got 1 Timeout === W7PROX64 (64 bit printdlg) === Timeout === TEST64_W7SP1 (64 bit printdlg) === Timeout

1 0

Re: [PATCH] mscms: Use lcms2, when available
by Hans Leidekker 08 May '13

08 May '13

On Tue, 2013-05-07 at 22:45 +0200, Detlef Riekenberg wrote: > lcms2 was released on 8. May 2010 and should be present in important > distributions since a while. > > lcms v1 is on the way to be phased out in the newest distribution > versions. Are there any distributions that have released without v1?

1 0

Re: [1/5] kernel32: Add more remote process tests.
by Marvin 08 May '13

08 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25479 Your paranoid android. === TEST64_W7SP1 (32 bit loader) === loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1210: Test failed: expected thread exit code 195, got 259 loader.c:1220: Test failed: expected WAIT_ABANDONED, got 0x102 loader.c:1236: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:1238: Test failed: expected WAIT_OBJECT_0, got 0x102

2 1

Re: gdi32: Simplify font->aveWidth sanity-checking to remove possible division by zero.
by Dmitry Timoshkov 08 May '13

08 May '13

Sam Edwards <cfsworks(a)gmail.com> wrote: > It makes the most sense to get rid of this sanity check altogether, but > until then, this should be a more robust way of doing it. > + * TODO: This sounds like a workaround for a much deeper bug involving > + * aveWidth's calculation. We should investigate if/why this is needed. > + */ This comment is confusing and wrong. There is a test case for which this check is required. > + if (font->aveWidth < 0 || font->aveWidth > font->potm->otmTextMetrics.tmHeight * 100) A check for an overflow is probably needed. Also a check for negative aveWidth should be a separate patch at best, and needs a test case. -- Dmitry.

1 0

Re: [PATCH 1/8] ole32: Use MSHLFLAGS_TABLEWEAK marshaling in CoRegisterClassObject.
by Alexandre Julliard 07 May '13

07 May '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/ole32/compobj.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wscript.exe -T ../../.. -p wscript.exe_test.exe.so run.c && touch run.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x555a9468 (thread 0088), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x555a9468). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555a9468 ESP:0033f7d0 EBP:0033f868 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:555d2cac ECX:0033f810 EDX:00000001 ESI:00000000 EDI:0033f828 Stack dump: 0x0033f7d0: 0033f828 00000005 00000000 555c7f30 0x0033f7e0: 0033f814 001407a4 0000000c 0013c414 0x0033f7f0: 0000000c 00000000 00000000 00000000 0x0033f800: 00142020 00000000 00000000 001373b0 0x0033f810: ffffffff 00000000 0033f868 7b85382e 0x0033f820: 00000000 00000001 178fc166 4e24f585 Backtrace: =>0 0x555a9468 Global_CreateObject+0x178() in vbscript (0x0033f868) 1 0x555b6b3c DispatchEx_InvokeEx+0x65b(iface=<couldn't compute location>, id=<couldn't compute location>, lcid=<couldn't compute location>, wFlags=<couldn't compute location>, pdp=<couldn't compute location>, pvarRes=<couldn't compute location>, pei=<couldn't compute location>, pspCaller=<couldn't compute location>) [/home/julliard/wine/wine/dlls/vbscript/vbdisp.c:215] in vbscript (0x0033f958) 2 0x555b899d disp_call+0x9c(ctx=0x1373b0, disp=0x13f368, id=0xaf, dp=0x33fa40, retv=0x33fa80) [/home/julliard/wine/wine/dlls/vbscript/../../include/dispex.h:299] in vbscript (0x0033f9e8) 3 0x555af05c do_icall+0x20b(ctx=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:511] in vbscript (0x0033fa68) 4 0x555af1dd interp_icall+0x2c(ctx=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:558] in vbscript (0x0033fa98) 5 0x555aeb42 exec_script+0x191(ctx=<is not available>, func=<is not available>, this_obj=<is not available>, dp=<is not available>, res=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/interp.c:1918] in vbscript (0x0033fb58) 6 0x555be4a7 exec_global_code+0x46(ctx=0x1373b0, code=<is not available>) [/home/julliard/wine/wine/dlls/vbscript/vbscript.c:83] in vbscript (0x0033fb88) 7 0x555bedab VBScript_SetScriptState+0x17a() in vbscript (0x0033fbe8) 8 0x684fc3dd wWinMain+0x9bc(hInst=<couldn't compute location>, hPrevInst=<couldn't compute location>, cmdline=<couldn't compute location>, cmdshow=<couldn't compute location>) [/home/julliard/wine/wine/programs/wscript/../../include/activscp.h:1013] in wscript (0x0033fd88) 9 0x684fc671 wmain+0xb0(argc=0x5, argv=0x110380) [/home/julliard/wine/wine/dlls/winecrt0/exe_wmain.c:50] in wscript (0x0033fe18) 10 0x684fc5a5 __wine_spec_exe_wentry+0x84(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/winecrt0/exe_wentry.c:36] in wscript (0x0033fe58) 11 0x7b86053c call_process_entry+0xb() in kernel32 (0x0033fe78) 12 0x7b86171b start_process+0x6a(peb=<couldn't compute location>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0033feb8) 13 0x7bc7a800 call_thread_func_wrapper+0xb() in ntdll (0x0033fed8) 14 0x7bc7d70d call_thread_func+0x7c(entry=0x7b8616b0, arg=0x7ffdf000, frame=0x33ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2567] in ntdll (0x0033ffa8) 15 0x7bc7a7de call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 16 0x7bc5004e start_process+0x1d(kernel_start=0x7b8616b0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2691] in ntdll (0x0033ffe8) 17 0x6802947d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 18 0x6802953b wine_switch_to_stack+0x2a(func=0x7bc50030, arg=0x7b8616b0, stack=0x340000) [/home/julliard/wine/wine/libs/wine/port.c:59] in libwine.so.1 (0xffeb7758) 19 0x7bc55b27 LdrInitializeThunk+0x3a6(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2747] in ntdll (0xffeb77c8) 20 0x7b867d00 __wine_kernel_init+0xbbf() [/home/julliard/wine/wine/dlls/kernel32/process.c:1256] in kernel32 (0xffeb86d8) 21 0x7bc561f3 __wine_process_init+0x182() [/home/julliard/wine/wine/dlls/ntdll/loader.c:2956] in ntdll (0xffeb8768) 22 0x680270c2 wine_init+0x2a1(argc=0x6, argv=0xffeb8cb4, error="", error_size=0x400) [/home/julliard/wine/wine/libs/wine/loader.c:847] in libwine.so.1 (0xffeb87c8) 23 0x7bf00e7b main+0x7a(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/wine/loader/main.c:237] in <wine-loader> (0xffeb8c08) 24 0x681cee46 __libc_start_main+0xe5() in libc.so.6 (0xffeb8c88) 0x555a9468 Global_CreateObject+0x178 in vbscript: movl 0x0(%eax),%edx -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] dlls/gdi32/freetype.c: A better divide by zero fix, report bad fonts.
by Sam Edwards 07 May '13

07 May '13

On 05/06/2013 03:05 PM, Max TenEyck Woodbury wrote: > Just to make this clear, the most recent version of this patch is such > a graceful handling, right? I haven't worked on gdi32/freetype.c much, so I wouldn't be the one to say for sure (you should probably talk to Alexandre Julliard, Dmitry Timoshkov, or Huw Davies), but I'll give you my thoughts anyway: On 05/05/2013 12:48 PM, max(a)mtew.isa-geek.net wrote: > > + /* HACKHACK: If a font has tmHeight=0, let us know. */ > + if (!font->potm->otmTextMetrics.tmHeight) { > + ERR("Font named '%s' has tmHeight=0, aveWidth=%d!\n", font->ft_face->family_name, font->aveWidth); > + } > + Since we've learned that tmHeight=0 is not actually an error, it doesn't make sense to log it using ERR(...). I would suggest a TRACE(...) or (preferably) nothing at all. Also, when I wrote the ERR message patch for you, it was intended only to help you locate the problematic font and wasn't meant to be included in upstream Wine. (Which is why I marked it with HACKHACK and didn't bother to use debugstr_a.) As for the actual check, it makes sense to consider what the math is trying to do: If aveWidth is extremely large (relative to tmHeight), then assume aveWidth is wrong and set it to 0. If tmHeight is 0, then it seems reasonable to assume that aveWidth isn't valid either. I'm not sure why the sanity check cares to do this: (aveWidth+tmHeight-1) / tmHeight > 100 When it can just do this: (aveWidth+tmHeight-1) / tmHeight > 100 = (aveWidth-1)/tmHeight + 1 > 100 = (aveWidth-1)/tmHeight > 99 = (aveWidth-1) > tmHeight*99 = aveWidth > tmHeight*99 + 1 ≈ aveWidth > tmHeight*100 This allows us to write out tmHeight just once, and is also much easier to understand at a glance. So, I would just simplify the whole sanity check to something like: /* Make sure that the font has sane width/height ratio */ if (font->aveWidth > font->potm->otmTextMetrics.tmHeight * 100) { WARN("Ignoring too large font->aveWidth %d\n", font->aveWidth); font->aveWidth = 0; } But even then, the sanity check itself sounds like a workaround for a much deeper bug. Maybe add a "FIXME: Investigate why this is necessary" comment while you're at it? Best, Sam

2 1

[PATCH] msvcrt: fix character/byte confusion in buffer overflow branch
by Max Kellermann 07 May '13

07 May '13

The first memcpy() call in puts_clbk_str_w() confuses character count and byte count. It uses the number of characters (out->len) as number of bytes. This leaves half of the buffer undefined. Interestingly, the second memcpy() call in the same function is correct. This bug potentially makes applications expose internal (secret) data. Usually, the destination buffer is on the stack, and the stack often contains secrets. Therefore, one could argue that this bug constitutes a security vulnerability. --- dlls/msvcrt/printf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h index cfba4b7..8b749bc 100644 --- a/dlls/msvcrt/printf.h +++ b/dlls/msvcrt/printf.h @@ -48,7 +48,7 @@ static int FUNC_NAME(puts_clbk_str)(void *ctx, int len, const APICHAR *str) return len; if(out->len < len) { - memcpy(out->buf, str, out->len); + memcpy(out->buf, str, out->len*sizeof(APICHAR)); out->buf += out->len; out->len = 0; return -1;

3 4

Re: user32: Implement IMR_QUERYCHARPOSITION handling in the edit control
by Dmitry Timoshkov 07 May '13

07 May '13

Aric Stewart <aric(a)codeweavers.com> wrote: > dlls/user32/edit.c | 21 +++++++++++++++++++++ > include/imm.h | 9 +++++++++ > 2 files changed, 30 insertions(+) Using usual 4 spaces indentation would slightly improve the readability. -- Dmitry.

2 2

Re: [PATCH 6/8] ieframe: Added more InternetExplorer object tests.
by Marvin 07 May '13

07 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25463 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.
by Dmitry Timoshkov 06 May '13

06 May '13

max(a)mtew.isa-geek.net wrote: > + if ( font->aveWidth && font->potm->otmTextMetrics.tmHeight ) { > + if (((font->aveWidth + font->potm->otmTextMetrics.tmHeight - 1) / > + font->potm->otmTextMetrics.tmHeight) > 100) { > WARN("Ignoring too large font->aveWidth %d\n", font->aveWidth); > font->aveWidth = 0; > } In which case font->potm->otmTextMetrics.tmHeight is going to be 0? -- Dmitry.

6 19

Re: d3dx9 [patch 2 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation
by Rico Schüller 06 May '13

06 May '13

On 05.05.2013 23:01, Nozomi Kodama wrote: > > + FLOAT xw, xx, xy, xz, yw, yy, yz, zw, zz; > I'm not very happy with the additional amount of variables... Please have a look at the attached patches. I think something like the first one (d3dx9: Apply rotationcenter only when a rotation is done.) should be done but has no influence on your patch (it is only attached, because the second patch influences the same part). 1. The amount of variables needed could be reduced to 3 by reordering the calculations (see patch 2, lines 36 - 58). This could also be done in your patch. Though I'm not sure that's a good idea ... comments and other opinions are welcome. Below this the points are not directly related to your patch: 2. In the next step we could also avoid a couple of multiplications by multiplying the scaling and adjusting the constants (see patch 2, lines 70 - 79). 3. We could also avoid the temps by reordering the calculation (Doing rotationcenter before the scaling). This way the tempxx could be avoided by using the out matrix directly. Cheers Rico

1 0

Re: d3dx9 [patch 1 / 3]: Avoid useless computations in D3DXMatrixAffineTransformation2D
by Rico Schüller 06 May '13

06 May '13

On 05.05.2013 23:00, Nozomi Kodama wrote: > + FLOAT tmp1, tmp2; > > + tmp1 = cosf(rotation); > + tmp2 = sinf(rotation); > As of it is really clear what's in those variables, we may name them with a better name instead of tmp1/tmp2 ... but I'm fine with either version. Cheers Rico

1 0

Re: [1/3] server: Add a process flag indicating whether the process is terminating, use it to block thread creation in a bei
by Marvin 06 May '13

06 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25445 Your paranoid android. === W7PROX64 (64 bit loader) === loader.c:1638: Test failed: expected WAIT_OBJECT_0, got 0x102 loader.c:1648: Test failed: expected thread exit code 196, got 259 loader.c:1210: Test failed: expected thread exit code 196, got 259 loader.c:1220: Test failed: expected WAIT_ABANDONED, got 0x102 loader.c:1236: Test failed: expected WAIT_OBJECT_0, got 0x102

2 1

GSoC 2013 - Registry Merging Project
by orzhvs 04 May '13

04 May '13

Hi, everyone. Thank you for your viewing and comments on the proposal. Sorry that the rough plan is kind of mess and now I've rewritten this part a little more like a Time Schedule. I appreciate it if you have a glance at it. >From now to 27th, May. Work on some basic knowledge such as the usage of WineTestBot, getting familiar to debugging in wine or so, with help of the community, and do some favor if possible. 28th, May to 16th, June. Have interviews with the mentor at any time if convenient. Put forward my initial frame design and make puzzles clear, then adjust the plan under the guide of the mentor. So that the testing and development plan will be settled down after this part. 17th, June to 24, June. Carry out pre-work tests on variety versions of Windows. Write test reports which definite some questions and guesses. I wish to report some bugs during this part once I found one. Some invoking tests vie different layer of dlls both some additional test code (maybe for difference between versions of windows) to the existing one in the advapi32.dll should be written. 25th, June to 24th, July. Prophase of the official development. I'll implement almost all of the registry merging feature, especially code in the server part, so that I can submit my patch and looking forward to feedbacks as early as possible. 25th, July to 31st, July. The Mid-term evaluations will be finished and submitted. 1st, Auguest to 31st, August. Second stage of the development. Implement the rest part of our scheme. In this part, changes will be real-time reported in the mailing-list and apply improvement timely to make it closer to a final product. 1st, September to 27th, September. Only clean-ups and small fix of code should be left here. I'll write and verify the final evaluations and final test results, together with other documents produced in the project. Then with some modification from the mentor it's submitted to Google. The schedule will be carried out up to speed so that I may finish ahead of the end date in each part, in which case I'd like make prepare for the next part and contritube my spare time to the commutiry, rather that only such narrowed in one project. Considering that it may be a little fuzzy in boundarys of different phases, I came up with some Possible Milestones : 1.Pre-development test works are finished. 2.Complete the mostly full test codes. 3.Merging of classes in HKCU and HKLM is implemented in server part. 4.Merging is implemented in all aviable layer. 5.Compatibility of different Windows versions are fullfilled. 6.All the work including documents are done on time. That's most of the schedule I can think of now, and I'll be very happy to improve it before submitting it to the mentor If you have futher advise, to save time and make the communication smoother. Best Regards, Guo Jian

1 0

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis. (try 2)
by Alexandre Julliard 04 May '13

04 May '13

Christopher Cope <ccope3(a)utk.edu> writes: > @@ -286,8 +286,10 @@ static void enable_xinput2(void) > class->number, class->min, class->max, class->resolution, class->mode, > XGetAtomName( data->display, class->label )); > if (class->label == x11drv_atom( Rel_X ) || class->label == x11drv_atom( Rel_Y )) count++; > - /* workaround for drivers that don't provide labels */ > - if (!class->label && class->number <= 1 && class->mode == XIModeRelative) count++; > + /* workaround for drivers that don't provide correct labels */ > + if (((!class->label && class->number <= 1) || class->label == x11drv_atom( Abs_X ) || > + class->label == x11drv_atom( Abs_Y )) > + && class->mode == XIModeRelative) count++; The whole point of testing labels was because some platforms don't set the relative mode correctly, so this is going to break them again. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/6] ole32: Added IExternalConnection support.
by Alexandre Julliard 03 May '13

03 May '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/ole32/compobj_private.h | 2 ++ > dlls/ole32/stubmanager.c | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so defaulthandler.c && touch defaulthandler.ok defaulthandler.c:189: Test failed: unexpected interface: {00000019-0000-0000-C000-000000000046} make: *** [defaulthandler.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3dcompiler: Add a LUT to find compilation targets info.
by Matteo Bruni 03 May '13

03 May '13

2013/5/2 Christian Costa <titan.costa(a)gmail.com>: > > --- > dlls/d3dcompiler_43/compiler.c | 101 +++++++++++++++++++++++------ > dlls/d3dcompiler_43/d3dcompiler_private.h | 1 > 2 files changed, 81 insertions(+), 21 deletions(-) > > diff --git a/dlls/d3dcompiler_43/compiler.c b/dlls/d3dcompiler_43/compiler.c > index 4942985..a6a9867 100644 > --- a/dlls/d3dcompiler_43/compiler.c > +++ b/dlls/d3dcompiler_43/compiler.c > @@ -490,6 +490,66 @@ HRESULT WINAPI D3DAssemble(const void *data, SIZE_T datasize, const char *filena > return hr; > } > > +struct { Please make it static const. > + const char *name; > + enum shader_type type; > + DWORD sm_major; > + DWORD sm_minor; > + DWORD level_major; > + DWORD level_minor; > + BOOL sw; > + BOOL support; > +} targets_info[] = { > + /* SM 1 */ > + { "vs_1_0", ST_VERTEX, 1, 0, 0, 0, FALSE, TRUE }, > + { "vs_1_1", ST_VERTEX, 1, 1, 0, 0, FALSE, TRUE }, > + { "ps_1_0", ST_PIXEL, 1, 0, 0, 0, FALSE, TRUE }, > + { "ps_1_1", ST_PIXEL, 1, 1, 0, 0, FALSE, FALSE }, > + { "ps_1_2", ST_PIXEL, 1, 2, 0, 0, FALSE, FALSE }, > + { "ps_1_3", ST_PIXEL, 1, 3, 0, 0, FALSE, FALSE }, > + { "ps_1_4", ST_PIXEL, 1, 4, 0, 0, FALSE, FALSE }, > + { "tx_1_0", ST_UNKNOWN, 1, 0, 0, 0, FALSE, FALSE }, > + /* SM 2 */ > + { "vs_2_0", ST_VERTEX, 2, 0, 0, 0, FALSE, TRUE }, > + { "vs_2_a", ST_VERTEX, 2, 1, 0, 0, FALSE, FALSE }, > + { "vs_2_sw", ST_VERTEX, 2, 0, 0, 0, TRUE, FALSE }, > + { "ps_2_0", ST_PIXEL, 2, 0, 0, 0, FALSE, TRUE }, > + { "ps_2_a", ST_PIXEL, 2, 1, 0, 0, FALSE, FALSE }, > + { "ps_2_b", ST_PIXEL, 2, 2, 0, 0, FALSE, FALSE }, > + { "ps_2_sw", ST_PIXEL, 2, 0, 0, 0, TRUE, FALSE }, > + { "fx_2_0", ST_UNKNOWN, 2, 0, 0, 0, FALSE, FALSE }, > + /* SM 3 */ > + { "vs_3_0", ST_VERTEX, 3, 0, 0, 0, FALSE, TRUE }, > + { "vs_3_sw", ST_VERTEX, 3, 0, 0, 0, TRUE, FALSE }, > + { "ps_3_0", ST_PIXEL, 3, 0, 0, 0, FALSE, TRUE }, > + { "ps_3_sw", ST_PIXEL, 3, 0, 0, 0, TRUE, FALSE }, > + /* SM 4 */ > + { "vs_4_0_level_9_0", ST_VERTEX, 4, 0, 9, 0, FALSE, FALSE }, > + { "vs_4_0_level_9_1", ST_VERTEX, 4, 0, 9, 1, FALSE, FALSE }, > + { "vs_4_0_level_9_3", ST_VERTEX, 4, 0, 9, 3, FALSE, FALSE }, > + { "vs_4_0", ST_VERTEX, 4, 0, 0, 0, FALSE, TRUE }, > + { "vs_4_1", ST_VERTEX, 4, 1, 0, 0, FALSE, TRUE }, > + { "ps_4_0_level_9_0", ST_PIXEL, 4, 0, 9, 0, FALSE, FALSE }, > + { "ps_4_0_level_9_1", ST_PIXEL, 4, 0, 9, 1, FALSE, FALSE }, > + { "ps_4_0_level_9_3", ST_PIXEL, 4, 0, 9, 3, FALSE, FALSE }, > + { "ps_4_0", ST_PIXEL, 4, 0, 0, 0, FALSE, TRUE }, > + { "ps_4_1", ST_PIXEL, 4, 1, 0, 0, FALSE, TRUE }, > + { "gs_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "gs_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + { "cs_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "cs_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + { "fx_4_0", ST_UNKNOWN, 4, 0, 0, 0, FALSE, FALSE }, > + { "fx_4_1", ST_UNKNOWN, 4, 1, 0, 0, FALSE, FALSE }, > + /* SM 5 */ > + { "vs_5_0", ST_VERTEX, 5, 0, 0, 0, FALSE, TRUE }, > + { "ps_5_0", ST_PIXEL, 5, 0, 0, 0, FALSE, TRUE }, > + { "hs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "gs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "ds_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "cs_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > + { "fx_5_0", ST_UNKNOWN, 5, 0, 0, 0, FALSE, FALSE }, > +}; > + > static HRESULT compile_shader(const char *preproc_shader, const char *target, const char *entrypoint, > ID3DBlob **shader_blob, ID3DBlob **error_messages) > { > @@ -500,38 +560,37 @@ static HRESULT compile_shader(const char *preproc_shader, const char *target, co > ID3DBlob *buffer; > char *pos; > enum shader_type shader_type; > + ULONG i; > + ULONG nb = sizeof(targets_info) / sizeof(targets_info[0]); > > TRACE("Preprocessed shader source: %s\n", debugstr_a(preproc_shader)); > > TRACE("Parsing compilation target %s.\n", debugstr_a(target)); > - if (strlen(target) != 6 || target[1] != 's' || target[2] != '_' || target[4] != '_') > + for (i = 0; i < nb; i++) > { > - FIXME("Unknown compilation target %s.\n", debugstr_a(target)); > - return D3DERR_INVALIDCALL; > + if (!strcmp(target, targets_info[i].name)) > + { > + if (!targets_info[i].support) > + { > + FIXME("Compilation target %s not yet supported\n", debugstr_a(target)); > + return D3DERR_INVALIDCALL; > + } > + else > + { > + shader_type = targets_info[i].type; > + major = targets_info[i].sm_major; > + minor = targets_info[i].sm_minor; > + break; > + } > + } > } > > - if (target[0] == 'v') > - shader_type = ST_VERTEX; > - else if (target[0] == 'p') > - shader_type = ST_PIXEL; > - else > + if (i == nb) > { > - FIXME("Unsupported shader target type %s.\n", debugstr_a(target)); > + FIXME("Unknown compilation target %s\n", debugstr_a(target)); > return D3DERR_INVALIDCALL; > } > > - major = target[3] - '0'; > - if (major == 0 || major > 5) > - { > - FIXME("Unsupported shader target major version %d.\n", major); > - return D3DERR_INVALIDCALL; > - } > - minor = target[5] - '0'; > - if (minor > 1 || (minor == 1 && (shader_type != ST_VERTEX || major > 1))) > - { > - FIXME("Unsupported shader target minor version %d.\n", minor); > - return D3DERR_INVALIDCALL; > - } > shader = parse_hlsl_shader(preproc_shader, shader_type, major, minor, entrypoint, &messages); > > if (messages) > diff --git a/dlls/d3dcompiler_43/d3dcompiler_private.h b/dlls/d3dcompiler_43/d3dcompiler_private.h > index c8a92f1..63745e0 100644 > --- a/dlls/d3dcompiler_43/d3dcompiler_private.h > +++ b/dlls/d3dcompiler_43/d3dcompiler_private.h > @@ -51,6 +51,7 @@ enum shader_type > { > ST_VERTEX, > ST_PIXEL, > + ST_UNKNOWN > }; > I'd prefer ST_UNKNOWN to be in the first place here (so that it doesn't get pushed down when we'll add more target types) but it's not a big deal. > typedef enum BWRITER_COMPARISON_TYPE { > > > The patch is probably fine otherwise but can you check that targets in the form "vs.1.0" aren't accepted by native D3DCompile? I suppose those tokens are assembler-only, but better be safe than sorry.

2 1

IID mess
by Daniel Jeliński 03 May '13

03 May '13

Hello, I just tried compiling all of Wine with my patch series applied and, to my surprise, compilation failed. The reason was that IID_IResourceManager was already declared elsewhere. Now, according to this page: http://mikolajapp.appspot.com/uuid/query?q={56a868ac-0ad4-11ce-b03a-0020af0… Wine's strmif.h declares IID_IResourceManager, while SDK declares __declspec(uuid) as IResourceManager. SDK declares IID_IResourceManager elsewhere: http://mikolajapp.appspot.com/uuid/query?q={03741d21-87eb-11ce-8081-0080c75… I'm new to COM, so I'm not sure what exactly is the difference between IID and declspec(uuid). Could anyone explain or suggest a fix? Thanks, Daniel

2 3

Re: [PATCH 5/6] ieframe: Added more InternetExplorer object tests.
by Marvin 03 May '13

03 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25429 Your paranoid android. === W2KPROSP4 (32 bit ie) === Timeout

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Hin-Tak Leung 03 May '13

03 May '13

------------------------------ On Fri, May 3, 2013 00:35 BST Rosanne DiMesio wrote: >On Thu, 2 May 2013 23:26:24 +0100 (BST) >Hin-Tak Leung <htl10(a)users.sourceforge.net> wrote: >> >> - "volunteer" is what it means: "volunteer". To try to make anybody "volunteer" in any activity any manner which is less than whole-heartedly willingly, sounds wrong. >> > >Nobody's trying to make anyone volunteer. I doubt anyone will. > >> There is no reason why the AppDB shouldn't work that way. i.e. just deal with the persistent ones, and let the individual readers skip over the occasional rest as they come. > >And who do you propose should "deal with" the persistent spammers? people who are bothered by them, or people who are paid to spend such time. I am neither. To be honest, i am more bothered by this thread (in a list which i subscribe to) than spam on appdb (which i don't). >> To ban such exchanges - between people who ask for help and might even offer incentives, and those who can offer help but not willing/possible to commit to a regular role - seem over-zealous. > >We have a perfectly good user's forum for such exchanges. > >-- >Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Frédéric Delanoy 02 May '13

02 May '13

On Thu, May 2, 2013 at 7:23 PM, Rosanne DiMesio <dimesio(a)earthlink.net>wrote: > On Thu, 2 May 2013 17:57:16 +0200 > Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > > > > > This won't prevent it, but I'm not sure hiding/disabling comments won't > do > > more harm than good. > > My opinion, based on close to 5 years experience as an active AppDB admin > and maintainer, is it will inconvenience a few people, but overall do far > more good than harm, for reasons that go beyond simple spam control. The > number of unmaintained apps with an active community of commenters is > small; in most unmaintained apps, questions posted just sit there > unanswered. Users seeking help would be much better off posting on the forum. > Of course, but we don't want people to ask the same questions over and over again on the forum. I thought the whole point of the appdb entry was to centralize information on running apps with wine (comments being common to all versions of the software tested)... > Since Andre's patch (thank you, Andre) merely disables comments for > unmaintained apps, any user who really thinks it's vital that the comments > appear in a particular entry can make that happen themselves simply by > volunteering to be a maintainer. If it's not important enough to someone to > put forth the trivial effort required to do that, then it's not important > to them, period. Maintaining/testing app entries may not be so trivial for everyone, and you can't expect everyone wanting to know how to run an app to become a maintainer... Maybe merely disabling *new* (vs all) comments for unmaintained apps would also do the job??? Frédéric

3 2

Google Summer of Code 2013, Tools - Implement new control panel applets
by Brock York 02 May '13

02 May '13

Hey Everyone, I've been wanting to get into Google Summer of Code and Wine development for quite a while now. I was looking on the wine ideas page : http://wiki.winehq.org/SummerOfCode I'm interested in doing the first one: Tools - Implement new control panel applets, but am wondering what I would actually be able to do. I've done basic opengl applications before but using a library like SDL to do the lowerlevel stuff. What kind of opengl test would be preferred? Something like a port of GLXgears to wine or something that just tests if it can create a Opengl context and then exits saying success? I don't know how to test whether opengl was compiled into wine either, would that be very hard to do? I've never had write code to test if a feature was enabled before. Any suggestions on what kind of test I should try and implement would be greatly appreciated so I can try and get a proposal in. I know I'm leaving it pretty late but I only found out it was open a few hours ago. For a background of my knowledge I'm currently in my 3rd year of a computer science degree at my University, I also did a year of programming at a college. I've been using linux for 6 years but haven't been able to get to grips with programming for wine I always get confused or lost when trying to learn how wine works when trying to debug a game. I'm hoping doing something like this will be able to get me started on wine with a mentors help to guide me. Thanks. Regards Brock York

2 1

Re: [2/6] uuid: add transact.h and txdtc.h
by Frédéric Delanoy 02 May '13

02 May '13

On Wed, May 1, 2013 at 11:19 PM, Daniel Jeliński <djelinski1(a)gmail.com>wrote: > #include "msdasc.h" > > +#include "transact.h" > +#include "txdtc.h" > > A patch only adding new headers for inclusion is likely not acceptable. You should merge it with another patch making use of it. Frédéric

2 1

Re: [AppDB] version: Only display comments section in case version has maintainers
by Christopher Cope 02 May '13

02 May '13

I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. "André Hentschel" <nerv(a)dawncrow.de> wrote: >Am 28.04.2013 18:57, schrieb Rosanne DiMesio: >> Forced moderation of comments could work for apps with maintainers >who are doing their job, but most of the spam I recently deleted was in >unmaintained apps. My suggestion would be to block comments altogether >on unmaintained apps, not just because of spam, but because of other >inappropriate things that are not being monitored, such as posting >links to illegal downloads. As for the maintainers who clearly aren't >doing their jobs (about 20-25% of the spam I found was in entries with >maintainers), admins already have the capability of removing them. > > >--- > include/version.php | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/include/version.php b/include/version.php >index 8f02b24..bf1d7ab 100644 >--- a/include/version.php >+++ b/include/version.php >@@ -1180,9 +1180,12 @@ class version { > > echo note::displayNotesForEntry($this->iVersionId); > >- // Comments Section >- if($this->iVersionId) >- Comment::view_app_comments($this->iVersionId); >+ if(sizeof($aMaintainers)>0) >+ { >+ // Display comments section in case version has >maintainers >+ if($this->iVersionId) >+ Comment::view_app_comments($this->iVersionId); >+ } > } > > public static function lookup_name($versionId) >-- >1.7.10.4

3 4

Re: Re: msi/tests: Add a trailing '\n' to an ok() call.
by Marvin 02 May '13

02 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25396 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msi/tests: Add a trailing '\n' to an ok() call.
by Christian Costa 02 May '13

02 May '13

2013/5/2 Francois Gouget <fgouget(a)free.fr> > --- > dlls/msi/tests/install.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c > index e5d996e..0c322be 100644 > --- a/dlls/msi/tests/install.c > +++ b/dlls/msi/tests/install.c > @@ -3110,7 +3110,7 @@ static void test_continuouscabs(void) > > /* Filename from msi is right and the one from cab is wrong */ > create_cc_test_files(); > - ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab"); > + ok(MoveFile("test2.cab", "test2_.cab"), "Cannot rename test3.cab to > test3_.cab\n"); > create_database(msifile, cc3_tables, sizeof(cc3_tables) / > sizeof(msi_table)); > > MsiSetInternalUI(INSTALLUILEVEL_NONE, NULL); > -- > 1.7.10.4 > > > Hi François, Can you fix the typo test3 to test2 as well please ? Thanks Christian

1 0

Re: [1/6] include: add transact.h, txdtc.h and txcoord.h (try 2)
by Alexandre Julliard 02 May '13

02 May '13

Daniel Jeliński <djelinski1(a)gmail.com> writes: > From 6b7cd0b30b3eaf22d9b9bbef733163e74cc04ca8 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Wed, 1 May 2013 20:28:10 +0200 > Subject: include: add transact.h, txdtc.h and txcoord.h > > this time based on minGW headers. Originals found here: > http://sourceforge.net/apps/trac/mingw-w64/browser/experimental/headers_add… This clearly needs to be generated from idl instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-patches
by Daniel Jeliński 02 May '13

02 May '13

Hello, I sent a ~200KB patch to wine-patches last night and it disappeared without a trace. I'm wondering if it got lost or just went to moderation. Regards, Daniel PS.I just resent it, still no luck.

2 1

Re: [2/4] include: added transact.idl (resend)
by Alexandre Julliard 01 May '13

01 May '13

Daniel Jeliński <djelinski1(a)gmail.com> writes: > +import "unknwn.idl"; > + > +interface ITransaction; > +interface ITransactionDispenser; > +interface ITransactionOptions; > +interface ITransactionOutcomeEvents; > +interface ITransactionCompletionEvents; > + > +/*========================================================================== > + * Transaction related types > + *==========================================================================*/ > + > +[local,pointer_default(unique)] > +interface BasicTransactionTypes > + { > + > + typedef struct BOID { > + byte rgb[16]; > + } BOID; > + > + cpp_quote("#define BOID_NULL (*((BOID*)(&IID_NULL)))") > + > + /* change the following two line together */ > + cpp_quote("#ifndef MAX_TRAN_DESC_DEFINED") /* conflicts with uimsg.h. This is temporary work around */ > + cpp_quote("#define MAX_TRAN_DESC_DEFINED") > + typedef enum TX_MISC_CONSTANTS > + { > + MAX_TRAN_DESC = 40 > + } TX_MISC_CONSTANTS; > + cpp_quote("#endif") > + > + /* Unit Of Work. */ > + > + typedef BOID XACTUOW; > + > + /* Data type for isolation level values. */ > + > + typedef LONG ISOLEVEL; > + > + /* Constants that specifiy isolation level of a transaction. */ > + > + typedef enum ISOLATIONLEVEL { > + ISOLATIONLEVEL_UNSPECIFIED = 0xFFFFFFFF, > + ISOLATIONLEVEL_CHAOS = 0x00000010, > + ISOLATIONLEVEL_READUNCOMMITTED = 0x00000100, > + ISOLATIONLEVEL_BROWSE = 0x00000100, /* Synonym for _READUNCOMITTED */ > + ISOLATIONLEVEL_CURSORSTABILITY = 0x00001000, > + ISOLATIONLEVEL_READCOMMITTED = 0x00001000, /* Synonym for _CURSORSTABILITY */ > + ISOLATIONLEVEL_REPEATABLEREAD = 0x00010000, > + ISOLATIONLEVEL_SERIALIZABLE = 0x00100000, > + ISOLATIONLEVEL_ISOLATED = 0x00100000, /* Synonym for _SERIALIZABLE */ > + } ISOLATIONLEVEL; > + > + /* Transaction information structure, used in ITransaction */ > + > + typedef struct XACTTRANSINFO { > + XACTUOW uow; /* The current unit of work */ > + ISOLEVEL isoLevel; /* The isolation level for the current UOW */ > + ULONG isoFlags; /* Values from ISOFLAG enumeration */ > + DWORD grfTCSupported; /* Flags indicating capabilities */ > + DWORD grfRMSupported; /* ... of this transaction wrt */ > + DWORD grfTCSupportedRetaining; /* ... parameters to Commit */ > + DWORD grfRMSupportedRetaining; /* ... */ > + } XACTTRANSINFO; > + > + typedef struct XACTSTATS { > + ULONG cOpen; /* The number of currently extant transactions. */ > + ULONG cCommitting; /* The number of transactions which are proceding towards committing. */ > + ULONG cCommitted; /* The number of transactions that are have been committed. */ > + ULONG cAborting; /* The number of transactions which are in the process of aborting. */ > + ULONG cAborted; /* The number of transactions that are have been aborted. */ > + ULONG cInDoubt; /* The number of transactions which are presently in doubt. */ > + ULONG cHeuristicDecision; /* The number of transactions that have completed by heuristic decision. */ > + FILETIME timeTransactionsUp; /* The amount of time that this transaction service has been up. */ > + } XACTSTATS; This is clearly a straight copy of the SDK header. You can't do that. -- Alexandre Julliard julliard(a)winehq.org

3 3

GSoC proposal
by George Stephanos 01 May '13

01 May '13

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

3 2

Re: server: Map update region to children even if window just moved.
by Alexandre Julliard 01 May '13

01 May '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -1618,7 +1618,7 @@ static void set_window_pos( struct window *win, struct window *previous, > const rectangle_t old_visible_rect = win->visible_rect; > const rectangle_t old_client_rect = win->client_rect; > rectangle_t rect; > - int client_changed, frame_changed; > + int client_changed, frame_changed, frame_moved = 0; > int visible = (win->style & WS_VISIBLE) || (swp_flags & SWP_SHOWWINDOW); > > if (win->parent && !is_visible( win->parent )) visible = 0; > @@ -1727,9 +1727,10 @@ static void set_window_pos( struct window *win, struct window *previous, > client_rect->bottom - old_client_rect.bottom != y_offset || > !valid_rects || > memcmp( &valid_rects[0], client_rect, sizeof(*client_rect) )); > + frame_moved = x_offset || y_offset; > } > > - if (frame_changed || client_changed) > + if (frame_changed || client_changed || frame_moved) It doesn't make sense to have all these complicated tests if we are going to always repaint anyway, which is essentially what your patch does. There has to be more to it than that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Marvin 01 May '13

01 May '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25385 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Hans Leidekker 01 May '13

01 May '13

On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..4145c76 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table => use latter one\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); The cabinet name alone can be up 256 characters so you should at least check that you're not overflowing the buffer.

2 1

winex11.drv
by Christopher Cope 01 May '13

01 May '13

I am unsure how the "enum x11drv_atoms" in the file dlls/winex11.dev/x11drv.h works. My /usr/include/Xatom.h defines XA_LAST_PREDEFINED as 68. Presumably, therefore XATOM_Rel_X and XATOM_Rel_X should be 81 and 82 respectively. However, when I dump the values I get 195 and 196. I am attempting to add XATOM_Abs_X and XATOM_Abs_X with values of 480 and 481 for a patch I'm working on. I could simply define the values elsewhere, but I assumed I should try to make it blend with the other code as much as possible. Any help is appreciated thank you.

2 4

GSoC proposal
by George Stephanos 01 May '13

01 May '13

Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the "Arab Academy for Science and Technology" situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't developed for Wine before though I've always been a big fan of the project. I'm fairly good with C/C++ and Python and I think I have enough Win32 API experience. I've previously developed small WinSock, DirectX and classic GUI applications (with and without MFC). I'm a freelancer. I've worked (alone) on around 25-30 projects rating 4+/5 in each. I've enrolled in Google Code-In 2010 and 2011 (which is basically GSoC for high school students) writing lots of ARM assembly code for VideoLAN (#x264dev on freenode). In 2011, I would have ranked 12th if not for an issue that occurred between VideoLAN and Google. Proposal: I've read your ideas page and the only registry task [1] has particularly caught my attention. I'm aware of what I need to do. I've read [2], [3] and [4]. I haven't yet browsed the Wine tree at all and I'll probably be missing implementation strategies but that'll hopefully be worked out with my mentor. [1] - http://wiki.winehq.org/SummerOfCode?#head-40e316e01066b5a129cd65073fa4b89dd… [2] - http://bugs.winehq.org/show_bug.cgi?id=14771 [3] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724475(v=vs.85).a… [4] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).a… Tell me if you need more information. Hope you consider me! Thanks, George

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)
by Alexandre Julliard 01 May '13

01 May '13

Sam Edwards <cfsworks(a)gmail.com> writes: > Content-wise, this is the same as try 2. However, there are two differences: > > 1. I merged the tests down into the same patch. > 2. This won't crash anymore: see patch 1 in this series. It still crashes: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 6389 ((unsigned int)src[hmul * x + rgb_interval * 2] << 0) | (gdb) bt #0 0x00007ffff550f680 in get_glyph_outline (incoming_font=<optimized out>, glyph=<optimized out>, format=24, lpgm=0x20, abc=0x22c7d0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:6389 #1 0x00007ffff550fd1e in freetype_GetGlyphOutline (dev=0x40df0, glyph=<optimized out>, format=<optimized out>, lpgm=0x22c9f0, buflen=288, buf=0x538c4, lpmat=0x7ffff5535140) at ../../../wine/dlls/gdi32/freetype.c:7133 #2 0x00007ffff54fcd84 in GetGlyphOutlineW (hdc=<optimized out>, uChar=103, fuFormat=17, lpgm=0x22c9f0, cbBuffer=288, lpBuffer=0x538c4, lpmat2=0x7ffff5535140) at ../../../wine/dlls/gdi32/font.c:2813 #3 0x00007ffff54c97b5 in render_string (hdc=0x490031, dib=<optimized out>, font=0x43cb0, x=95, y=11, flags=12288, str=0x51b70, count=13, dx=0x53470, clipped_rects=0x22cbb0, bounds=0x22cba0) at ../../../wine/dlls/gdi32/dibdrv/graphics.c:707 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] d3dx9_36: Remove todo in tests as it works now with last d3dxof fixes.
by Matteo Bruni 01 May '13

01 May '13

2013/4/29 Christian Costa <titan.costa(a)gmail.com>: > > --- > dlls/d3dx9_36/tests/xfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c > index 1238bcd..e514a5f 100644 > --- a/dlls/d3dx9_36/tests/xfile.c > +++ b/dlls/d3dx9_36/tests/xfile.c > @@ -77,7 +77,7 @@ static void test_templates(void) > ok(ret == D3DXFERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_BADFILEFLOATSIZE); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates_parse_error, sizeof(templates_parse_error) - 1); > - todo_wine ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > + ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); > > ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates, sizeof(templates) - 1); > ok(ret == S_OK, "RegisterTemplates failed with %#x\n", ret); Hi Christian, good catch for that todo_wine. However, this should be merged with the patch actually fixing the test (I guess it's patch 2).

2 1

Re: [1/4] xolehlp: fix calling convention
by Nikolay Sivov 01 May '13

01 May '13

On 5/1/2013 01:43, Daniel Jeliński wrote: Please fix spec file accordingly.

2 2

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Alexandre Julliard 30 Apr '13

30 Apr '13

Sam Edwards <cfsworks(a)gmail.com> writes: > From a2905abf287ff1ac44c93119d76b14b6fc3992c3 Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks(a)gmail.com> > Date: Sat, 20 Apr 2013 05:48:07 -0600 > Subject: gdi32: Clip font glyphs to fit within text metrics. It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so ../../../../wine/dlls/comctl32/tests/listview.c && touch listview.ok wine: Unhandled page fault on write access to 0x400053b34 at address 0x2b4c3d69e6b7 (thread 0398), starting debugger... winedbg: Internal crash at 0x2b53f78066b7 make: *** [listview.ok] Error 84 -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [2/2] include: Make KNONVOLATILE_CONTEXT_POINTERS match PSDK definition.
by Dmitry Timoshkov 30 Apr '13

30 Apr '13

Hi, This patch has status "Build failure", but it compiles without errors here with 32 and 64-builds. What kind of a failure is that? -- Dmitry.

2 1

Re: kernel32: Add some tests for PEB and loader locks.
by Marvin 30 Apr '13

30 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25367 Your paranoid android. === TEST64_W7SP1 (32 bit loader) === loader.c:1952: Test failed: WaitForSingleObject failed: 102 loader.c:1954: Test failed: expected exit code 199, got 259 loader.c:1963: Test failed: WaitForSingleObject failed: 102 loader.c:1968: Test failed: expected 198, got 259 loader.c:1972: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0 loader.c:2018: Test failed: expected ERROR_ACCESS_DENIED, got 487 loader.c:2028: Test failed: VirtualFreeEx should fail loader.c:2029: Test failed: expected ERROR_ACCESS_DENIED, got -559038737 loader.c:2032: Test failed: VirtualAllocEx should fail loader.c:2033: Test failed: expected ERROR_ACCESS_DENIED, got -559038737 loader.c:2042: Test failed: expected STATUS_PROCESS_IS_TERMINATING, got 0

1 0

Re: riched20: Fix richtext copy/paste to OOffice.
by Nikolay Sivov 30 Apr '13

30 Apr '13

On 4/30/2013 10:20, Sergey Guralnik wrote: > When copying cyrillic text from wordpad (or any richedit) > to Open Office document I get unreadable text. It seems > like some another codepage was used to display text. > This path solves this problem. > --- > dlls/riched20/writer.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > Is it really supposed to do that? Does native module help?

2 1

Re: server: Map update region to children even if window just moved.
by Sergey Guralnik 30 Apr '13

30 Apr '13

On 2013-04-25 16:06, Sergey Guralnik wrote: > --- > dlls/user32/tests/win.c | 1 - > server/window.c | 5 +++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Is something wrong with this one? -- Sergey

1 0

[GSOC2013] [Tools - Winetest Graphical User Interface]
by Nouri Hamza 30 Apr '13

30 Apr '13

Hi, My name is Hamza Nouri,23 years old. I'm in my second year of computer science engineering at Esprit,Tunis,Tunisia. I'm also Candidate for “Informatique et mathématiques Appliqués à la finance et aux assurances” (I.M.A.F.A) – a one year specialized postgraduate degree in computer science and mathematics applied to finance and insurances. I've took a look at Wine and found the project very promising. and i'm excited to partipate in coding for Wine and giving a help to Wine Users around the world. Regarding my technical skills, i have an experience in c/c++, java ,php,mysql and HTML5. i've done some projects using these languages that you can find in my personnal blog (http://tunisiansimpson.blogspot.com/). Here an example of Kakuro game made with language C that i've made last year : http://tunisiansimpson.blogspot.com/2012/12/kakuro.html I'm interested in the project "Tools - Winetest Graphical User Interface". I've already installed Wine and i'm starting using it. I have no prior experience in Open Source development, and i found this a good opportunity to begin coding for the good wealth of the international community. About my availability at the summer, i'll be free starting from the 9th June. I'll be pleased if you can provide me more details about the "Tools - Winetest Graphical User Interface" project and advice me with the better ways to succed my proposal. Hamza nouri best regards. Email address : hamza.nouri(a)esprit.tn CV : docs.google.com/a/esprit.tn/file/d/0B9vfb3FMh7gDU2JrRUQ2aF9PZGM/edit CV : twitter.com/tunisiansimpson Blog : tunisiansimpson.blogspot.com/ Facebook : www.facebook.com/nourihamza89

1 0

[GSOC 2013] Tools - Implement new control panel applets
by Kaiyi Zhang 30 Apr '13

30 Apr '13

I'm Kaiyi Zhang,A Computer Science and Engineering student from Civil Aviation University of China.I hear the GSOC and I'm very Interested in this,I look through many projects until i see the "Tools - Implement new control panel applets". I have used wine for a long time,it's very useful and i love it,it is the first time i apply for the GSOC. when i see the wine is also in the list,i decide to contribute to the wine ,i have learned the c program language which required to this project, but i know the more things i need to learn..I have confidence in doing this well,one of my best technologies is using the internet ,search the information i want.. I send for this email to see if i'm on the right track. Look forward to you reply,Thanks for reading..

2 2

Re: [PATCH] kernel32: Fixed string comparision for non-canonical locale identifiers such as zh_CN VS zh-Hans on OS X.
by Ken Thomases 29 Apr '13

29 Apr '13

On Apr 29, 2013, at 3:41 PM, Qian Hong wrote: > Thanks Ken for many helps! You're welcome and, regarding the patch: looks good to me. -Ken

1 0

Re: [AppDB]: Only display comments section in case version has maintainers
by Joerg Schiermeier 29 Apr '13

29 Apr '13

Hi list, > Forced moderation of comments could work for apps with maintainers > who are doing their job, but most of the spam I recently deleted was > in unmaintained apps. This will be the first step towards a better maintained AppDB! > My suggestion would be to block comments > altogether on unmaintained apps, not just because of spam, but > because of other inappropriate things that are not being monitored, > such as posting links to illegal downloads. For me it seems to be a got idea to get the maintainers more in charge also to everything around their maintained applications. I general I would like to have this submitted patch in the actual AppDB. And if it is so bad for some maintainers, they might start a new discussion here.. Thanks to all who did some work when creating an patch and wrote some issues here! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: opengl32: add a test for WGL_EXT_swap_control [try 2]
by Ken Thomases 29 Apr '13

29 Apr '13

On Apr 29, 2013, at 10:42 AM, Roderick Colenbrander wrote: > Updated version of the patch which marks the failing test as todo_wine. The > final goal is to make the swap interval in the winex11 driver not global > anymore (and store it with the drawable) and add some new functionality. > <0001-opengl32-add-a-test-for-WGL_EXT_swap_control.patch> For what it's worth, the Mac driver does it (apparently) wrong but in the other way. In the Mac driver, the swap interval is currently part of the context state, so not part of the drawable. But it's definitely not global. -Ken

1 0

Re: opengl32: add a test for WGL_EXT_swap_control
by Alexandre Julliard 29 Apr '13

29 Apr '13

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > From 1a9ce7c13bef6e600bc9893f93da8770c8fc7767 Mon Sep 17 00:00:00 2001 > From: Roderick Colenbrander <thunderbird2k(a)gmail.com> > Date: Sun, 28 Apr 2013 16:39:28 -0700 > Subject: [PATCH] opengl32: add a test for WGL_EXT_swap_control > > --- > dlls/opengl32/tests/opengl.c | 123 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 123 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -M opengl32.dll -T ../../.. -p opengl32_test.exe.so opengl.c && touch opengl.ok opengl.c:1584: Test failed: Expected swap interval 1, got 0 make[1]: *** [opengl.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [AppDB] version: Only display comments section in case version has maintainers
by Rosanne DiMesio 29 Apr '13

29 Apr '13

> > So volunteer to be a maintainer. > > > > > That is all good and well, but most of the time I check the wine page > before I buy a game. If there are no maintainers and this is active, > there will be no comments, I will be unsure about the likelihood of it > working. Reports would still be helpful, but most of the time, the > majority of the information ends up in the comments section. > All the more reason to disable comments. The information belongs in test reports. Comments get deleted periodically, test reports don't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier 28 Apr '13

28 Apr '13

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: winex11.drv: Fixed XInput2 errors with mislabeled mice axis.
by Dmitry Timoshkov 28 Apr '13

28 Apr '13

"Cope, Christopher Edward" <ccope3(a)utk.edu> wrote: > @@ -1638,16 +1636,14 @@ static void X11DRV_RawMotion( XGenericEventCookie *xev ) > if (XIMaskIsSet( event->valuators.mask, class->number )) > { > double val = *values++; > - if (class->label == x11drv_atom( Rel_X ) || > - (!class->label && class->number == 0 && class->mode == XIModeRelative)) > + if (class->label == x11drv_atom( Rel_X ) || class->mode == XIModeRelative) > { > input.u.mi.dx = dx = val; > if (class->min < class->max) > input.u.mi.dx = val * (virtual_screen_rect.right - virtual_screen_rect.left) > / (class->max - class->min); > } > - else if (class->label == x11drv_atom( Rel_Y ) || > - (!class->label && class->number == 1 && class->mode == XIModeRelative)) > + else if (class->label == x11drv_atom( Rel_Y ) || class->mode == XIModeRelative) > { > input.u.mi.dy = dy = val; > if (class->min < class->max) How is this supposed to distinguish motion in X and Y direction? -- Dmitry.

1 0

Re: qedit/tests: Improve test messages
by Marvin 27 Apr '13

27 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

Re: qedit/tests: Improve test messages
by Marvin 27 Apr '13

27 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25328 Your paranoid android. === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588 === W2K8SE (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401588

1 0

[AppDB]: Recent UCE/Spam waves in AppDBs comments
by Joerg Schiermeier 27 Apr '13

27 Apr '13

Hi list, hello Rosanne, I just saw again a lot of spam posted into the AppDB. Thanks to Rosanne who deleted this senseless and useless mails rapidly. But isn't there a real solution for this problem? OK, to kill this guys maybe the best way, but than I will get seriously problems. :-) So please, isn't there a way to set up a filter - for user names or, with more effect, for IPs of this bad guys ISPs? I know, this will cause 'collateral damage' but if it helps to prevent the next wave of spam - I think it's OK. This maybe a task for AppDBs administrator, isn't it? -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: netapi32: Add stub for NetGetAnyDCName
by Christian Costa 27 Apr '13

27 Apr '13

Hi, + FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), + debugstr_w(domainname), bufptr); + return ERROR_NO_SUCH_DOMAIN; +} Please use 4 spaces indentation as the rest of the file. Christian Le 27/04/2013 14:05, Ruslan Kabatsayev a écrit : > Hello, > > This patch adds a stub for netapi32!NetGetAnyDCName(), which is needed > for e.g. KDE's dolphin to launch first time. I've done it similarly to > already present NetGetDCName() stub, but with another error code > return, which is among valid ones listed in MSDN. > > Regards, > Ruslan > >

2 1

Re: user32: SetTimer should respect the minimum and maximum timeout limits (try 2).
by Alexandre Julliard 26 Apr '13

26 Apr '13

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > So, this particular patch fixes the minimum and maximum timeout limits > for SetTimer, which has a significant impact on any application using > SetTimer to render video (Bug #32489). The old minimum timeout (55 > ms) is nowhere near short enough to render video at 24 FPS, causing > "choppy" video behavior in a variety of Silverlight apps. Even though > MSDN indicates that the minimum timeout should be 10 ms, I'm using the > value established from the included tests instead (15 ms). That doesn't mean you can change the constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt.h: Use inline function to forward hypot to _hypot.
by Alexandre Julliard 26 Apr '13

26 Apr '13

Jacek Caban <jacek(a)codeweavers.com> writes: > This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. > Previous versions had a separated library that contained forwards from > underscored functions to non-underscored, which I believe made using > hypot work. Those were currently moved directly to msvcr* import libs, > which we don't use in favour of our our own ones. Don't you need to do that for the other functions too? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Jacek Caban 26 Apr '13

26 Apr '13

Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217,6 +221,27 @@ static HRESULT to_string(VARIANT *v, BSTR *ret) > return S_OK; > } > > + > +static HRESULT banker_rounding(double dbval, int *result_val) > +{ > + double frac_part; > + double int_part; > + > + *result_val = round(dbval); This has two problems: - you don't handle values that are out of int range by assigning double value to int - round is not portable. As I mentioned you before, Wine needs to be C89 compatible. If we need some features that are not part of C89, we need to be careful about that and it often requires things like configure checks. In case of round, replacing it with floor(x+0.5) does the trick pretty well. Cheers, Jacek

2 3

Names with particles on South Africa and Namibia should be in the particle on the AUTHORS file.
by Tae Wong 26 Apr '13

26 Apr '13

You have posted a message to show how surnames with particles of South Africa and Namibia show in the credits, like van Schayck listed in S and not under V: For example, van Schayck is under S and not in V. Note that the name of the file is in all capitals. Here is a correction of the va section, with van Schyack placed on the letter by letter system. The file name is AUTHORS. It is a file in all capitals and the file content contains just the heading and some names of the developers. Note that the file is out of date. Vainer, Moshe Valoska, Hleb Valtonen, Hannu Vance, Carroll Vanek, Tomas van Schaik, Carl Vaughn, Charles

1 0

Re: [PATCH 1/2] wined3d: Set GL_NONE for glReadBuffer / glDrawBuffer on FBO initialization.
by Henri Verbeet 26 Apr '13

26 Apr '13

Seems ok, though a small comment explaining the issue this patch fixes probably wouldn't hurt. On 25 April 2013 20:43, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (target == GL_READ_FRAMEBUFFER) > + context_bind_fbo(context, GL_DRAW_FRAMEBUFFER, draw_binding ? &draw_binding : 0); > + else > + context_bind_fbo(context, GL_READ_FRAMEBUFFER, read_binding ? &read_binding : 0); > I don't think using 0 here is strictly wrong, but a proper NULL would probably be clearer. As a followup, I think we can actually get rid of the glGenFramebuffers() in context_bind_fbo() these days and just pass a GLuint instead of a pointer. The only place left that actually creates FBOs should be context_apply_fbo_entry().

2 2

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 3)
by Marvin 25 Apr '13

25 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25302 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)
by Marvin 25 Apr '13

25 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] wined3d: Add a new structure for for d3d limits and other info
by Stefan Dösinger 25 Apr '13

25 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Please ignore this patch. I figured that my series might collide with Henri's, so I canceled the send process. And indeed there are conflicts, so I'll resend my patches rebased on top of Henri's. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJReSS/AAoJEN0/YqbEcdMwElkP/AiDEqVSaMxTW+sOaQava97g a0cOBpHTU+lInUuUXIS2WVe65D+IhkdYJHnMIrSUVdquvT1x+pLVgr+2J4jczFX7 /9Ay0gAjMVbKsKIYO4tvOQgSru/RdAljTg6uaIw+qTDrHZvQLW/sJu3JcbAp0GW7 9pGEzPvRr6hNsOyXE+DQlTEsT3vkbEUTRr01j4+znF50laYV2s3e5saZHyXULyY8 ObEf3n2ppQgcO4keQg7wAPLydw+xiNcYOw9724fh/xyezj8MXoT1CDHeio7yPfhg xp76kNWzNERQcWaDT7QXwuWLRXy5H3VodWm4PEMXvqXyxkJJycm2jECvTOTjrrke iswKGqh9n0gTWQjse2eUY/fKxpjhh/ySxDcJq093swHHbvrCngL8Q5dYu/Ch3cFu JbLu4pHla3iAmJKftVTT/iRq6vwsLB7tzloCoA7e8T+GFmsA39RPFI6zttCIoA60 kui5a4Ofd6/sGMFaqg2VBK+2crGJzVzN6VRvglg63A0hNr0UGbkFC/6iQK8FzxyA A+uPGr5Xrd/vGpKZksMMH68JiK5kYXm+fsiVI1F1rcAcfdh6STQBoThcig1N/HXu fA8daluv4+PgQ9RhgzlioBsVFGxkZ1FbM8XjKlcnKQb0ZK3DXLHLEzspvmBnr3Pi MK94F9BvqMDa6Wi57sgT =Wh/i -----END PGP SIGNATURE-----

1 0

Re: [0/4] Improve wineconsole and kernel32
by Frédéric Delanoy 25 Apr '13

25 Apr '13

On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This series of four patches will improve various three functions in > kernel32: > > * GetConsoleFontSize > * GetCurrentConsoleFont > * GetLargestConsoleWindowSize > > This is achieved by moving logical calculations to wineconsole itself. > kernel32.dll only receives the final values. > > The first and second patches should be applied to source before compiling > Wine. If this is not done, the compiler will exit with errors. (The first > is a patch for server/protocol.def and requires tools/make_requests to be > run). > After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric

2 1

Wine Gecko 2.21-beta1
by Jacek Caban 25 Apr '13

25 Apr '13

Hi all, As some of you might have noticed, the final Wine Gecko 2.20 was never been released, although it was scheduled for about three weeks ago. This is mostly due to my lack of time, combined with the fact that part of that time I was busy with some Gecko work that would be nice to have in Wine. Being 3 weeks late means that we also have 3 weeks until the next Firefox release, so we may just wait a bit longer and do another release based on newer upstream code base. This way I may use the new beta to include some of the changes that I did lately, which would be too risky to go straight to release. Those new improvements contain, among others, a fix for Adobe CS4 products installers. In this beta, the testing is easier than ever. Our auto installer knows about the beta which, combined with the fact that we cache downloaded packages now, means that the attached Wine patch is all you need to comfortably test the new package. Just apply the patch you the Wine tree and everything should work. All tests are appreciated. Thanks, Jacek

1 0

Re: [PATCH 2/5] wined3d: Introduce a wined3d_vertex_pipe_ops structure.
by Rico Schüller 25 Apr '13

25 Apr '13

On 25.04.2013 09:59, Henri Verbeet wrote: > -static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct fragment_pipeline *fragment_pipe) > +static HRESULT shader_arb_alloc(struct wined3d_device *device, const struct wined3d_vertex_pipe_ops *vertex_pipe, > + const struct fragment_pipeline *fragment_pipe) > { > struct shader_arb_priv *priv = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*priv)); > struct fragment_caps fragment_caps; > - void *fragment_priv; > + void *vertex_priv, *fragment_priv; > + > + if (!(vertex_priv = vertex_pipe->vp_alloc(&arb_program_shader_backend, priv))) > + { > + ERR("Failed to initialize vertex pipe.\n"); > + HeapFree(GetProcessHeap(), 0, priv); > + return E_FAIL; > + } > > if (!(fragment_priv = fragment_pipe->alloc_private(&arb_program_shader_backend, priv))) > { > ERR("Failed to initialize fragment pipe.\n"); > + fragment_pipe->free_private(device); Shouldn't that vertex_pipe->vp_free(device)? > HeapFree(GetProcessHeap(), 0, priv); > return E_FAIL; > }

2 1

Clang static analyzer results / wine-1.5.28-66-g6899279
by Austin English 25 Apr '13

25 Apr '13

With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@17976891177308-0d34-0410-b5e6-… clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@17977191177308-0d34-0410-b5e6-9… ./configure --disable-tests was used to reduce noise [austin@localhost ~]$ sha1sum scan-build-2013-04-18-2.tar.bz2 51e28c96a04ebe9ef937678149f9e7e3ed4cb20f scan-build-2013-04-18-2.tar.bz2 [austin@localhost ~]$ du -h scan-build-2013-04-18-2.tar.bz2 35M scan-build-2013-04-18-2.tar.bz2 http://www.mediafire.com/?xwb05d6er0aclfe -- -Austin

5 7

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)
by Sam Edwards 24 Apr '13

24 Apr '13

This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote: >

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)
by Christian Costa 24 Apr '13

24 Apr '13

2013/4/24 James Eder <jimportal(a)gmail.com> > This version should either pass or skip on W2KPROSP4. > --- > dlls/kernel32/cpu.c | 23 ++++++++++++++++++----- > dlls/psapi/tests/psapi_main.c | 36 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+), 5 deletions(-) > > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 0ebf8f3..124e5c0 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -216,16 +216,29 @@ BOOL WINAPI IsProcessorFeaturePresent ( > */ > BOOL WINAPI K32GetPerformanceInfo(PPERFORMANCE_INFORMATION info, DWORD > size) > { > - NTSTATUS status; > + MEMORYSTATUSEX mem_status; > > TRACE( "(%p, %d)\n", info, size ); > > - status = NtQuerySystemInformation( SystemPerformanceInformation, > info, size, NULL ); > - > - if (status) > + if(size < sizeof(PERFORMANCE_INFORMATION)) > { > - SetLastError( RtlNtStatusToDosError( status ) ); > + SetLastError(ERROR_BAD_LENGTH); > return FALSE; > } > + > + mem_status.dwLength = sizeof(mem_status); > + if (!GlobalMemoryStatusEx( &mem_status )) > + return FALSE; > + > + memset(info, 0, sizeof(PERFORMANCE_INFORMATION)); > + > + info->cb = sizeof(PERFORMANCE_INFORMATION); > + info->CommitLimit = min((mem_status.ullTotalPageFile / > system_info.PageSize), MAXDWORD); > + info->PhysicalTotal = min((mem_status.ullTotalPhys / > system_info.PageSize), MAXDWORD); > + info->PhysicalAvailable = min((mem_status.ullAvailPhys / > system_info.PageSize), MAXDWORD); > + info->PageSize = system_info.PageSize; > + > + FIXME("stub\n"); > + > Hi James, That would be better to change the trace at the beginning by FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", info, size ); instead of adding another fixme (which is not really correct since it's not a stub). Christian

2 3

Re: msvcr110.dll: add a stub for crtGetShowWindowMode (try 2)
by Alexandre Julliard 24 Apr '13

24 Apr '13

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=33195 > > try 2: return SW_SHOWWINDOW instead of SW_HIDE It's not much harder to return the correct value. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] shell32: Add a semi-stub for SHGetStockIconInfo
by Nikolay Sivov 24 Apr '13

24 Apr '13

On Wed, Apr 24, 2013 at 6:38 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > -- > By by ... Detlef > --- > dlls/shell32/iconcache.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/shell32/shell32.spec | 1 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c > index 637dbca..df6675d 100644 > --- a/dlls/shell32/iconcache.c > +++ b/dlls/shell32/iconcache.c > @@ -46,6 +46,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +static const WCHAR shell32dll[] = > {'\\','s','h','e','l','l','3','2','.','d','l','l',0}; > + > Please put this in function that needs it.

1 0

Re: [PATCH 4/5] d3d9/tests: Don't test for equality in d3d9's depth_blit_test
by Henri Verbeet 24 Apr '13

24 Apr '13

On 24 April 2013 11:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This makes the test pass on nv40 GPUs on Linux. I'm not sure if testing > equality was intentional or an accident, if it was intentional please > ignore this patch. > I don't quite remember, but probably not. Arguably the nicer way to fix it is to change the z-value for quad1 to 0.33f though.

1 0

Re: oledb32: Implement DataConvert DBTYPE_BOOL->VARIANT
by Jacek Caban 24 Apr '13

24 Apr '13

On 04/24/13 10:41, Alistair Leslie-Hughes wrote: > + case DBTYPE_BOOL: > + V_VT(v) = VT_BOOL; > + V_BOOL(v) = *(BOOL*)src; You're mixing BOOL and VARIANT_BOOL here. This can't work, they even have a different size. From your test I guess that you meant to cast src to VARIANT_BOOL*. Cheers, Jacek

1 0

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo
by Marvin 24 Apr '13

24 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25251 Your paranoid android. === W2KPROSP4 (32 bit psapi_main) === psapi_main.c:76: Test failed: GetProcAddress(GetPerformanceInfo) failed

1 0

Application for GSoC 2013 - improve Richedit
by Jactry Zeng 23 Apr '13

23 Apr '13

Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy patches[2] for wine. And I feel quite good to study in wine community. I am so interested in Richedit module[3]. Because a lot of software I tested was blocked by bugs of Richedit, such as wordpad, GTalk, QQ, Weibo Desktop and AliWangwang etc. I would like to work for this module during GSoC. I've reported a few bugs regarding Richedit[4]. And for bug 33191[5], I have written a simple testcase to reproduce this bug. And I found ITextDocument is just a stub now, I want to implement some function of it, such as ITextDocument::New, ITextDocument::Open, ITextDocument::Save, ITextDocument::Range, ITextDocument ::GetName and ITextDocument::GetDefaultTabStop etc. These functions are documented in MSDN[6], what's better, thanks to kind people on codeproject[7], there are some sample applications for study, which will give me a lot of help on re-implementing ITextDocument. I think if I can finish this work, there are a lot of software will benefit from it[8]. I appreciate for any comment. Thank you. :-) [1] http://bugs.winehq.org/buglist.cgi?email1=jactry92%40gmail.com&emailtype1=e… [2]http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Jactry [3] http://bugs.winehq.org/buglist.cgi?cmdtype=runnamed&namedcmd=richedit&list_… [4]bug of Richedit I reported: http://bugs.winehq.org/buglist.cgi?emailreporter1=1&emailtype1=exact&query_… [5]bug 33191: http://bugs.winehq.org/show_bug.cgi?id=33191 [6]http://social.msdn.microsoft.com/Search/en-US?query=ITextDocument&ac=4 [7]http://www.codeproject.com/search.aspx?q=ITextDocument&x=0&y=0&sbo=kw [8]bug of ITextDocument: http://bugs.winehq.org/buglist.cgi?quicksearch=ITextDocument&list_id=104255 -- Regards, Jactry Zeng

2 2

Re: [PATCH 3/3] mshtml: Support IObjectIdentity interface in HTMLWindow object
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25244 Your paranoid android. === WXPPROSP2 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (32 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 dom: unhandled exception c0000005 at 00421C52 === WXPX64 (64 bit dom) === dom.c:7033: Test failed: Could not get ITravelLogClient interface: 80004002 dom.c:7040: Test failed: IsEqualObject returned: 0x80004003 Timeout

1 0

Re: [PATCH 2/3] mshtml: Added IOmHistory::get_length test
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25243 Your paranoid android. === WXPX64 (32 bit htmldoc) === htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call htmldoc.c:2560: Test failed: unexpected call GetExternal htmldoc.c:486: Test failed: unexpected riid: {719C3050-F9D3-11CF-A493-00400523A8A0} htmldoc.c:486: Test failed: unexpected riid: {A0AAC450-A77B-11CF-91D0-00AA00C14A7C} htmldoc.c:516: Test failed: unexpected call

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_STR->DBTYPE_WSTR
by Marvin 23 Apr '13

23 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25234 Your paranoid android. === W2KPROSP4 (32 bit convert) === convert.c:2537: Test failed: 12

1 0

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Ken Thomases 23 Apr '13

23 Apr '13

On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote: > On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: >> As I understand it, some fonts deliberately have glyphs larger than >> their metrics bounding boxes. Clipping them is almost certainly not a >> good idea. > > Forgive my disbelief, but can you provide an example? It seems like Windows has the same clipping behavior (see my test http://source.winehq.org/patches/data/95792). > > From my understanding, the intent of the ascent metric is that it indicates the maximum ascender on any glyph in the font (and likewise for descent), so the only real reason for the ascent/descent metrics to be wrong is if the font designer made a mistake. (And some tools, like FontForge, will automatically set the ascent/descent metrics correctly for you on export.) > > I can't think of any reason why a font author would want to create a font with an invalid ascent/descent metric. I can't speak to how Windows would render it, but one such font is Zapfino. It's an "exuberant" calligraphic font with lots of flourishes, some of which have strokes extending into the line above or below. http://en.wikipedia.org/wiki/Zapfino https://www.google.com/images?q=zapfino -Ken

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory. (try 2)
by Rico Schüller 23 Apr '13

23 Apr '13

On 22.04.2013 23:08, Christian Costa wrote: > +typedef struct { > + DWORD bc2Size; > + DWORD bc2Width; > + DWORD bc2Height; > + WORD bc2Planes; > + WORD bc2BitCount; > + DWORD bc2Compression; > + DWORD bc2SizeImage; > + DWORD bc2XRes; > + DWORD bc2YRes; > + DWORD bc2ClrUsed; > + DWORD bc2ClrImportant; > + /* same as BITMAPINFOHEADER until this point */ > + WORD bc2ResUnit; > + WORD bc2Reserved; > + WORD bc2Orientation; > + WORD bc2Halftoning; > + DWORD bc2HalftoneSize1; > + DWORD bc2HalftoneSize2; > + DWORD bc2ColorSpace; > + DWORD bc2AppData; > +} BITMAPCOREHEADER2; Do we really need a typedef here? For only locally used structs, I think we shouldn't use a typedef. Also the struct is only used to determine the size and for nothing else? There may be a better way to do that... Maybe something like in dlls/windowscodecs/icoformat.c ? I think you got inspired by dlls/windowscodecs/bmpdecode.c, there is the same issue. Why do we need a typedef, if we only use it in one file to calculate the size? > > + BITMAPFILEHEADER *header; > > + if ((header_size == sizeof(BITMAPINFOHEADER)) || > + (header_size == sizeof(BITMAPV4HEADER)) || > + (header_size == sizeof(BITMAPV5HEADER)) || > + (header_size == sizeof(BITMAPCOREHEADER2))) > + { > + /* All structures have the same memory layout as BITMAPINFOHEADER */ > + BITMAPINFOHEADER*header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > > + else if (header_size == sizeof(BITMAPCOREHEADER)) > + { > + BITMAPCOREHEADER*header = (BITMAPCOREHEADER*)*data; I don't think it's a good idea to use variable names multiple times. While this works fine it may be a bit confusing... Cheers Rico

2 1

d3dx9: Implement D3DXSHMultilpy5
by Nozomi Kodama 23 Apr '13

23 Apr '13

Is there a problem with this patch? http://source.winehq.org/patches/data/95555 Nozomi

4 8

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.
by Dmitry Timoshkov 23 Apr '13

23 Apr '13

Sam Edwards <cfsworks(a)gmail.com> wrote: > This change only affects malformed fonts that have glyphs with splines > that go above the maximum ascent as specified in the font's hhea/os2 > table. For that reason, any tests for this change would have to include > a malformed font, so I did not write tests. If we want in-tree tests, > we'll need to figure out how to include a malformed font to test against. Please add a test case, Wine test suite already includes custom fonts, you can either use an existing font, or add a new one. -- Dmitry.

3 2

kernel32/path: Potential off-by-one error, help needed!
by Kirill Smirnov 23 Apr '13

23 Apr '13

Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with this module, please, take a look at this wanna-be-a-bug and the proposed patch. -- Kirill

2 1

Re: user32: add assembly wrapper for calling hook procedures.
by James Eder 23 Apr '13

23 Apr '13

Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

2 1

Wine History
by André Hentschel 22 Apr '13

22 Apr '13

Hi, meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. So i did some research on this and found "Wine History" mails by Dan Kegel from 2002 and much earlier Bob Amstadt talking about late May or early June 1993. The date listed on Wikipedia is July the 4th, but i was still curious about that late May. I think i finally found this late May (30th) discussion and want to share it: https://groups.google.com/d/msg/comp.os.linux/7TFhxP6IUVQ/gVHAeP_ZBVUJ It's of course hard to tell when a project was really born, but as far as i understand, this discussion inspired Bob to write an initial loader. I was just 5 at this time, so maybe someone can tell some more about it? :) Some more Links: http://en.wikipedia.org/wiki/Wine_%28software%29 http://www.winehq.org/pipermail/wine-devel/2002-November/010567.html http://www.winehq.org/pipermail/wine-devel/2002-November/010603.html https://groups.google.com/d/msg/comp.os.linux/RKpNL1M8vSE/Z-rgUyrSFlYJ https://groups.google.com/d/msg/comp.os.linux/mb1BwP7LckY/IV44zjGkO98J http://www.linuxjournal.com/article/2757 and of course http://wiki.winehq.org/WineHistory Ok, i somehow lost the mentioning of "late may", but it's already quite late here, sry.

2 1

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()
by Qian Hong 22 Apr '13

22 Apr '13

Hi Dan, Thanks for working on it! It is really an annoying bug, however, is adding DECLSPEC_NOINLINE a workaround or a real fix? If it is only a workaround, would that hide some real bug behind it? Or is that possible that there is a gcc bug here that we want to report to gcc? Thanks for your time!

4 7

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation
by Henri Verbeet 22 Apr '13

22 Apr '13

On 21 April 2013 16:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (texture && texture->target == GL_TEXTURE_RECTANGLE_ARB) > - sample_flags |= WINED3D_GLSL_SAMPLE_RECT; > + if (priv->cur_ps_args->np2_fixup & (1 << sampler_idx)) > + { > + sample_flags |= WINED3D_GLSL_SAMPLE_NPOT; > + } I don't think the added braces are an improvement, but otherwise this looks ok.

2 3

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Christian Costa <titan.costa(a)gmail.com> writes: > + if (header_size == sizeof(BITMAPINFOHEADER)) > + { > + BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; > + ULONG count = header->biClrUsed; > + > + if (!count && header->biBitCount <= 8) > + count = 1 << header->biBitCount; > + > + offset = sizeof(BITMAPFILEHEADER) + header_size + sizeof(RGBQUAD) * count; This isn't correct for all DIB types. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] extrac32: Add /D switch support.
by Alexandre Julliard 22 Apr '13

22 Apr '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -202,6 +228,9 @@ int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int sho > WCHAR path[MAX_PATH]; > LPCWSTR cabfile = NULL; > > + extr_printf = (void*)GetProcAddress(LoadLibraryA("msvcrt"), "printf"); > + if(!extr_printf) > + return 1; Mixing C runtimes is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel