- wine-devel - winehq.org

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Vincent Povirk 22 Apr '13

22 Apr '13

Dealing with the bits of a floating point number directly is a bit odd, and it makes it hard to review the code. Is there a reason you don't want to use things like modf, floor, and ceil?

2 3

re: Google Summer of Code 2013
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Anulesh, improving wine's support of cygwin is a toughie. ( I gave http://bugs.winehq.org/show_bug.cgi?id=15679 the old college try, but failed. ) You should probably be more specific about what you have in mind. - Dan

1 0

re: Willing to work on CMD - implement more robust parser
by Dan Kegel 20 Apr '13

20 Apr '13

Hi Gaurab! Glad to hear you're interested in wine, and in cmd. You might start by reading previous discussion on the topic, e.g. the full thread following http://www.winehq.org/pipermail/wine-devel/2009-December/080643.html and http://kegel.com/wine/sweng/2010/ Two tips that might help smooth your way: There is a lot of bison in wine already, so using bison might be the path of least resistance. Switching just one command to bison, while leaving the rest using the existing code, would likely be much easier to get committed than a big patch that changed lots of things. Good luck! - Dan

1 0

Willing to work on CMD - implement more robust parser
by Gaurab Patra 20 Apr '13

20 Apr '13

Respected sir/madam, Through this mail I'd like to inform you that I am a Computer Science student at Bengal Engineering and Science University, Shibpur (India) in my 3rd year of undergraduate studies. I have gone through the project CMD - implement more robust parser and would like to work on this project this summer. As it is mentioned in the required skill set I am quite proficient in C, CMD commands, datastructure and algorithm etc. I'm attaching my resume with this mail. If you want to give me the opportunity to work on this please reply with some necessary resources and guide me with more information on this. Thank you GaurabPatraResume(1).pdf<https://docs.google.com/file/d/0B99XscJv40waenczeWh3ZVNkVlk/edit?usp=drive_…> Gaurab Patra 3rd yr Computer Science BESU, Shibpur

1 0

Re: oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR
by Nikolay Sivov 20 Apr '13

20 Apr '13

On 4/20/2013 13:43, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > oledb32: Implement GetConversionSize DBTYPE_WSTR->DBTYPE_WSTR > > > Best Regards > Alistair Leslie-Hughes Please add a test when caller supplies source length, at least one case is interesting - supplied length is less than lstrlenW result. Another case would be embedded nulls and source length larger than null terminated length.

1 0

Re: [PATCH 2/2]vbscript: Implemented builtin function CBool(try 2)
by Marvin 20 Apr '13

20 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25206 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)
by Marvin 20 Apr '13

20 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25204 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] wined3d: Use ARB_internalformat_query2 to check for texture format rendering and blending support, where available.
by Henri Verbeet 19 Apr '13

19 Apr '13

On 18 April 2013 21:19, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (!format->glInternal) continue; > + > + gl_info->gl_ops.ext.p_glGetInternalformativ(GL_TEXTURE_2D, format->glInternal, > + GL_FRAMEBUFFER_RENDERABLE, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s is supported as FBO color attachment.\n", debug_d3dformat(format->id)); > + format->flags |= WINED3DFMT_FLAG_RENDERTARGET | WINED3DFMT_FLAG_FBO_ATTACHABLE; > + format->rtInternal = format->glInternal; > + > + if (!(format->flags & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + query_format_flag(gl_info, format, format->glInternal, GL_FRAMEBUFFER_BLEND, > + WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING, "post-pixelshader blending"); > + } This may be a bit dangerous, since you're now potentially adding WINED3DFMT_FLAG_RENDERTARGET for formats like e.g. WINED3DFMT_R8G8B8A8_SNORM that didn't previously had it, and where it's a bit questionable if it's really going to work as intended. Also, the depth/stencil check that follows is either redundant, or we're now also potentially setting WINED3DFMT_FLAG_RENDERTARGET for depth/stencil formats. At least initially we'll probably want to stick with formats that already have WINED3DFMT_FLAG_RENDERTARGET set, and only clear it if unsupported. At a later point we may want to do something more centered around the information we get from internalformat_query2, but I suspect it will be a bit harder than just checking if there's no fixup, no conversion function, etc.

2 1

Re: [PATCH 2/7] wined3d: Store vs_clipping in the adapter
by Henri Verbeet 19 Apr '13

19 Apr '13

On 19 April 2013 11:20, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Potential alternatives include keeping the status quo or introducing a > separate structure that holds these derived limits that is owned by the > device and linked in the contexts. We could also put it into gl_info, > but I dislike this idea because these limits are not GL limits, but > limits of our shader and fixed function pipeline implementations. I think we'll want a separate structure for this. Note that you essentially have two different kinds of data you're concerned with here though. One is derived state like e.g. the texture unit map, the stream info, or the view_indent from patch 1/7. We don't really want that in wined3d_state, because there's no reason for e.g. every stateblock to have a copy of that. Having the derived state structure be owned by the device is probably ok, although there may also be something to be said for making it part of the context instead. The other type of data is immutable data like derived caps and limits, as in this patch and following ones. In principle the adapter is the right place for that, but I do think we want a separate structure for that, and probably a pointer to it in the context, for similar reasons as having one to gl_info. Arguably things like the state table, format info and the shader backend would belong in the same structure. I.e., essentially we'd have a setup like wined3d_gl_info, but for more wined3d specific / derived info.

2 2

Re: [PATCH 3/7] wined3d: Use ARB_internalformat_query2 for the other texture format caps too.
by Henri Verbeet 19 Apr '13

19 Apr '13

On 18 April 2013 21:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + /* FIXME: We can't handle "partial" sRGB decode support right now, we could > + * introduce a new format flag and check for that. */ As mentioned on IRC, I don't think this is really an issue. The patch looks otherwise ok.

1 0

Re: [PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.
by Akihiro Sagawa 19 Apr '13

19 Apr '13

On Fri, 19 Apr 2013 14:42:50 +0800, Jactry Zeng wrote: > +/********************************************************************* > + * _mbsncoll_l(MSVCRT.@) > + */ > +int CDECL _mbsncoll_l(const unsigned char *str1, const unsigned char *str2, MSVCRT_size_t count, > + MSVCRT__locale_t locale) > +{ > + return _mbsnbcoll_l(str1, str2, count, locale); > +} According to MSDN, _mbsncoll_l receives a number of characters, but _mbsnbcoll_l receives a number of bytes. This is a big difference in multibyte code page. So you should properly handle this situation, or add FIXME message based on multibyte code page if your application just needs this function. Regards, Akihiro Sagawa

2 1

Google Summer of Code 2013
by Anulesh Tiwari 19 Apr '13

19 Apr '13

Sir, I will be applying for GSoC 2013 under your mentoring team. Sorry for contacting very late with you as I was not aware of this program. I came to know yesterday that Gsoc is going to start. As a CS student and I have a well understanding of C C++ and Java and Data structures I am always very keenly interested in programming and coding. I devote my daily 8 hrs to it. As a potential linux user I have chosen Ideas from your list Cygwin Improvement I wish to apply on this topic and devote my each and every day of this summer to help my friends and colleagues to run Wine without bugs. Well one more thing to say Sir please give more Information and details what I have to do to assure my project to be done. Regards Anulesh Tiwari Bachelor of Science Department of Computer Science BHU INDIA

1 0

Fun with GCC 4.8
by James Eder 18 Apr '13

18 Apr '13

As many of you no doubt know, GCC recently released 4.8.0. This new version introduces a new optimization level enabled by -Og with the following description (from the man page): "Optimize debugging experience. -Og enables optimizations that do not interfere with debugging. It should be the optimization level of choice for the standard edit-compile-debug cycle, offering a reasonable level of optimization while maintaining fast compilation and a good debugging experience." Of course I had to try it out. I found that building Wine lead to GCC dieing with ... dlls/kernel32/console.c:1691:1: internal compiler error: Segmentation fault I also found ... dlls/kernel32/computername.c:701:1: internal compiler error: Segmentation fault I eventually stumbled my way into the enclosed patch which lets GCC build Wine with -Og. I'm not sure if this change (or something similar) makes sense for Wine. I'm fairly certain some changes make sense for GCC (I suspect that GCC should not segfault). I haven't submitted a bug for GCC because I suspect they'll want me to provide something simpler to compile than the Wine source tree. I certainly won't be upset if someone beats me too it. I'm not sure how much time in the near future I'll spend on it. "Eventually" is probably the word that fits. At any rate, I wanted to at least share my experiences in case anyone is interested in heading down the same path. -- Jim

3 3

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Alexandre Julliard 18 Apr '13

18 Apr '13

Simon Lipp <sloonz(a)gmail.com> writes: > @@ -389,6 +389,10 @@ static int process_events( Display *display, Bool (*filter)(Display*, XEvent*,XP > count++; > if (XFilterEvent( &event, None )) > { > + KeySym keysym = 0; > + XLookupString(&event.xkey, NULL, 0, &keysym, NULL); > + BOOL is_dead = (keysym >= XK_dead_grave && keysym <=XK_dead_semivoiced_sound); You can't assume that you have a key event here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32/tests: Use if(0) instead of #if 0 to make sure the code still compiles.
by Marvin 18 Apr '13

18 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25164 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

testbot: Default set of VMs to run the tests
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

Hi all, recently the set of VMs suggested to run the tests on by default has changed. It no more includes NT4, XP and Vista (although it does include win2000), 32-bit VMs for NT4, XP and Vista don't even exist in the list of available VMs (64-bit XP and Vista do exist, but for some reason are not used). Is there a reason for that? -- Dmitry.

2 5

Re: GetKeyboardState problems in Age of Empires II
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

[please don't omit wine-devel when replying] Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > Stevie Trujillo <stevie.trujillo(a)gmail.com> wrote: > > > Another (minor) problem raised in the bugzilla entry is that, if a > > > key is pressed when changing window, and released before returning, > > > GetKeyboardState() will claim the key is still pressed (0x80). But > > > this is easy to workaround, just hit the key again inside the game > > > and it will stop scrolling. > > > > dlls/winex11.drv/keyboard.c,X11DRV_KeymapNotify() should take care of > > that, if it doesn't - please debug why (probably a bug in your WM). > > I think this function only applies to "modifier keys". It was tested > with arrow keys. It should work for all keys. > Anyway I don't think it's a big issue, since it doesn't cause > any big problem, and it doesn't happen very often. It was just a > situation where Windows and Wine exhibited slightly different behavior. > > The first bug is much more annoying since one has to completely exit > the game each time. My comment was targeting both problems that you mentioned. -- Dmitry.

2 2

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Jacek Caban 18 Apr '13

18 Apr '13

On 04/17/13 18:18, larmbr zhan wrote: > + double tmp; > + WCHAR trueW[] = {'T','r','u','e','\0'}; > + WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > + TRACE("%s\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + switch(V_VT(arg)) { > + case VT_I2: > + tmp = V_I2(arg); > + break; > + case VT_I4: > + tmp = V_I4(arg); > + break; I don't think converting to double is a good idea here. Why don't you do conversions directly to BOOL for all cases? > + case VT_R4: > + tmp = V_R4(arg); > + break; > + case VT_R8: > + tmp = V_R8(arg); > + break; > + default: > + ERR("Not a numeric vaule: %s\n", debugstr_variant(arg)); > + return E_FAIL; > + } > + > + if (tmp < 0.0 || tmp > 0.0) > + str = SysAllocString(trueW); > + else > + str = SysAllocString(falseW); > + > + > + return return_bstr(res, str); Are you sure you want to return string type here? I'd expect a bool value (of type VT_BOOL) here... > } > > static HRESULT Global_CByte(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index 6bd4065..9b25e87 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -442,4 +442,9 @@ Call ok(CInt(36.50) = 36, "CInt(36.50) = " & CInt(36.50)) > Call ok(CInt(36.75) = 37, "CInt(36.75) = " & CInt(36.75)) > Call ok(CInt(300) = 300, "CInt(300) = " & CInt(300)) > Call ok(CInt(-300) = -300, "CInt(-300) = " & CInt(-300)) > + > +Call ok(CBool(5) = "True", "CBool(5) = " & CBool(5)) > +Call ok(CBool(0) = "False", "CBool(0) = " & CBool(0)) > +Call ok(CBool(-5) = "True", "CBool(-5) = " & CBool(-5)) ...and that's why getVT(...) test would be nice here. Thanks, Jacek

2 1

Application for GSoC 2013
by larmbr zhan 18 Apr '13

18 Apr '13

Hi all, I'm a junior student from a non-famous college, I apply to parcitipate in GSoC , to help do some vbscript module implementation. I've just submitted a patchset on this. Thanks. -- Regards, Zhan Jianyu

3 4

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Jacek Caban 18 Apr '13

18 Apr '13

On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V_VT(v) == VT_R8) { //... your conversion }else { hres = to_int(v); } + case VT_R8: { + double n = rint(V_R8(v)); rint is not portable. Please avoid using it. @@ -424,4 +424,22 @@ Call ok(getVT(vbYes) = "VT_I2", "getVT(vbYes) = " & getVT(vbYes)) Call ok(vbNo = 7, "vbNo = " & vbNo) Call ok(getVT(vbNo) = "VT_I2", "getVT(vbNo) = " & getVT(vbNo)) +Call ok(CInt(-36.75) = -37, "CInt(-36.75) = " & CInt(-36.75)) +Call ok(CInt(-36.50) = -36, "CInt(-36.50) = " & CInt(-36.50)) +Call ok(CInt(-36.25) = -36, "CInt(-36.25) = " & CInt(-36.25)) Please add some tests using getVT to verify underlying types. Thanks, Jacek

1 0

Re: [2/3] mountmgr.sys: Remove an artificial limitation for removable drive letters.
by Alexandre Julliard 18 Apr '13

18 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Under Windows removable drives (USB sticks) can have drive letters such > as J: or K:. They are not considered floppy devices though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] kernel32: Count precise amount of child process failures.
by Marvin 18 Apr '13

18 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25160 Your paranoid android. === W2K8SE (32 bit loader) === lloader.c:1686: Test failed: expected exit code 0, got 196

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 3)
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

Austin English <austinenglish(a)gmail.com> wrote: > +LPTOP_LEVEL_EXCEPTION_FILTER MSVCR110__crtSetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER filter) > +{ > + return SetUnhandledExceptionFilter(filter); > +} msvcrt APIs need an explicit calling convention specifier. -- Dmitry.

2 1

GetKeyboardState problems in Age of Empires II
by Stevie Trujillo 18 Apr '13

18 Apr '13

"Age of Empires II scrolling gets stuck after Alt-Tab away and back" ( http://bugs.winehq.org/show_bug.cgi?id=30814 ) has been debugged now. The problem is that GetKeyboardState starts returning 0x40 after changing window. Documentation seems to only define LSB and MSB ( http://msdn.microsoft.com/en-us/library/windows/desktop/ms646299(v=vs.85).a… ). This leads Age of Empires II to believe that all keys are pressed after changing window, making it scroll unstoppably. Should this be fixed by removing extra bits in GetKeyboardState like in the bugzilla entry, or should it be fixed in wineserver? Also does the similar functions GetAsyncKeyboardState() and GetKeyState() need fixing? Another (minor) problem raised in the bugzilla entry is that, if a key is pressed when changing window, and released before returning, GetKeyboardState() will claim the key is still pressed (0x80). But this is easy to workaround, just hit the key again inside the game and it will stop scrolling.

2 1

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Dmitry Timoshkov 18 Apr '13

18 Apr '13

larmbr zhan <nasa4836(a)gmail.com> wrote: > + case VT_BOOL: > + *ret = V_BOOL(v) ? -1 : 0; > + break; Shouldn't this be VARIANT_TRUE/VARIANT_FALSE instead of -1/0? -- Dmitry.

1 0

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25139 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt
by Marvin 17 Apr '13

17 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP2 (32 bit) === No test summary line found === WXPX64 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAX64 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === WXPX64 (64 bit) === No test summary line found === WVISTAX64 (64 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/5] wined3d: Enable GL_ARB_texture_rectangle in GLSL ffp fragment shaders
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (gl_info->supported[ARB_TEXTURE_RECTANGLE]) > + shader_addline(buffer, "#extension GL_ARB_texture_rectangle : enable\n"); > + This may be a good idea anyway, but is this strictly required? IIRC ARB_texture_rectangle is the one special extension that's always implicitly enabled in GLSL if it's supported.

2 2

Re: [PATCH 2/5] d3d9/tests: Test NPOT texture creation
by Henri Verbeet 16 Apr '13

16 Apr '13

On 16 April 2013 14:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright (C) 2006 Chris Robinson > + * Copyright (C) 2006 Chris Robinsontes This looks unintentional. > + UINT refcount; Technically refcounts are ULONGs, although I suppose it doesn't matter a whole lot.

1 0

Re: winex11.drv: Transmit WM_DEADCHAR messages to applications
by Dmitry Timoshkov 16 Apr '13

16 Apr '13

Simon Lipp <sloonz(a)gmail.com> wrote: > + * Moreover, let dead chars be processed or we will never have > + * WM_DEADCHAR events That's how it's supposed to work. Wine should never generate WM_DEADCHAR message, it relies in the driver to handle dead keys and generate final events. X11 even has an ability to support user defined key sequences which are handled by XFilterEvent and which will be broken by your patch. -- Dmitry.

3 4

Re: kernel32: Add a test to check event and mutex states during process termination.
by Alexandre Julliard 16 Apr '13

16 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/loader.c | 40 +++++++++++++++++++++++++++++++++------- > 1 file changed, 33 insertions(+), 7 deletions(-) That's not a very meaningful test if nobody holds the mutex. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25096 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.
by Marvin 16 Apr '13

16 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25086 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2631: Test failed: expected GetOverridesKeyPath webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3076: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WVISTAX64 (64 bit webbrowser) === webbrowser.c:978: Test failed: unexpected dispIdMember 271 webbrowser.c:1604: Test failed: unexpected call TranslateUrl webbrowser.c:454: Test failed: unexpected nCmdID 14 Timeout

2 1

Re: [PATCH 5/6] ieframe: Return document as IHTMLDocument2 iface from get_document.
by Marvin 15 Apr '13

15 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25085 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3060: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Re: [PATCH 1/1] d3d8: Don't assert on invalid IDirect3DBaseTexture8 interfaces.
by Stefan Dösinger 15 Apr '13

15 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-04-14 16:53, schrieb Rico Schüller: > + if (iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DTexture8_Vtbl + && iface->lpVtbl != (const > IDirect3DBaseTexture8Vtbl *)&Direct3DCubeTexture8_Vtbl + > && iface->lpVtbl != (const IDirect3DBaseTexture8Vtbl > *)&Direct3DVolumeTexture8_Vtbl) + { + WARN("%p is not a > valid IDirect3DBaseTexture8 interface.\n", iface); + return > NULL; + } A test would be a good idea. Are you sure that the assert is the actual problem, and not some memory corruption that changes the vtable poiner? What does e.g. GetTexture do after a bogous SetTexture call? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRa7lTAAoJEN0/YqbEcdMwNjEP/RLeLk3+009+Cp2n5sWOUprn Z5ED8iL3RXRjsCJNU5Fi2JIkCcVRmdkkn2RTBN9Q9KEkUL0qjg6B7Admy5sWtMIk LDtYpjS6BeDIJm8e0D0HwGItv2ekxW37ggg9fsArcXUO/lKf2GrJmUiyAjQfzmT9 IDlewcLSzUiAdbzZ4WUZzkqIa9lQgDpZBAvOgvgqhY2suf+YpJi6oTMfgwzpiSyB L2mlXx4cb0/hYaPAdWZUbc9uHvsCQ5ZwE4EhIxWpMlZM8FENMN3Gc0vrpzWAXoBo XRifoh3n0VKaYyZ+Wi+zGRaFX40P4ouBUKuFcBdjEPq6Fhz46GEGY8KFf1MVZKwM 7pzkhv6yc8/GTr2q5wthhmnZxDLHIZNyVEoMU0AFB1M0V/k0sJQfXpCCA/6vql+g dgUtyPggMSefwT0lc/7S/UwQdvuRYyIcdVd47alDJyRfU5NOMx091IiqkKXm9nby nqGAfdO3GDQoOIXJpWD5E1UMPHt6AGXGsfypkuVTtTljvOx+U7S9ngBeFkjuor8+ VFwStSFGboPxAjfKqzubdFcPcp4t8E5/qqkXR+Nc2UBJV5XeC3Pg5GOZxBsDZvbz zU4btX6kgC1Si1vIkf+D8CyZgaoPSwiVgGfVkTaqYSqnO39JZ0SpjYlv7e4yuhfa jkXNYd+XevrLq435YYir =TVml -----END PGP SIGNATURE-----

2 3

GSoC '13 - Hello!
by Eric Zheng 15 Apr '13

15 Apr '13

Hello everyone, My name is Eric Zheng, I'm a junior in Computer Engineering at the University of Illinois Urbana-Champaign. I just wanted to introduce myself and state my interest in the "Xinput / Xbox 360 controller compatibility" project. I hope to be able to jump on IRC later in the week to speak with you all. Best, Eric Zheng

2 1

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 15 Apr '13

15 Apr '13

--- On Sun, 14/4/13, Vincent Povirk <madewokherd(a)gmail.com> wrote: > Well, here's a simple thing you can > check: Does your zlib dll link to > _lseek or _lseeki64? The first one uses a 32-bit offset. > Wine's > implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) > expands that to 64-bit and later truncates the file offset > to 32-bit. > For a file larger than 2 GB, that could account for the > large negative > value you're seeing. > > And since this would only matter in cases where zlib uses > lseek (the > first time through I guess it wouldn't, as it has to read > the whole > everything up to the offset you give at least once) and is > at least 2 > GB into the file, that might also explain why it doesn't > fail > initially. > > But without really digging into the zlib code, all I can do > it speculate. > > I should probably also check coapp's build of zlib > sometime. It is not a dll - as you suggested and I already wrote, due to past experience of other's packaging of slightly outdated, it is being built against a private *source* copy of the latest zlib. Also the bogus offset is not large negative but large (larger than 2^32) positive. Here is an example of the debug output under wine: --------------- set_filepos failed at 34307 returning 134127533721091 Re-opening to re-try Retry successful set_filepos failed at 96919 returning 146686018157207 Re-opening to re-try Retry successful set_filepos failed at 128254 returning 12103217968382 Re-opening to re-try Retry successful ... --------------- This is generated by this code snipplet which is called inside a loop, all wrapped in the c++ class: --------------- off_t offset = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset != filepos) { //implicitly converted to off_t by template streamoff() LOG.printLOG("set_filepos failed at " + LOG.streampos2str(filepos) + " returning " + LOG.off_t2str(offset) + "\n"); LOG.printLOG("Re-opening to re-try\n"); close(); open(); off_t offset1 = gzseek(gzvcf_in, filepos, SEEK_SET); if (offset1 == filepos) LOG.printLOG("Retry successful\n"); else LOG.error("Retry failed\n"); // this also aborts } ------------------- This code runs silently on linux i.e. the "if (offset != filepos)" condition is not triggered.

2 2

request.h: size of unnamed array is negative
by Hugh McMaster 15 Apr '13

15 Apr '13

I've been adding a new handler to Wine's server. Unfortunately, I've run into a problem with C_ASSERT that I can't seem to resolve. In server/request.h, I've added the following code: C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_request, spi_workarea) == 16 ); C_ASSERT( sizeof(struct get_desktop_workarea_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_x) == 4 ); C_ASSERT( FIELD_OFFSET(struct get_desktop_workarea_reply, screen_y) == 4 ); C_ASSERT( sizeof(struct get_desktop_workarea_reply) == 8 ); But the compiler ends with output errors, as in the following: In file included from request.c:69:0: request.h:1527:1: error: size of unnamed array is negative request.h:1528:1: error: size of unnamed array is negative request.h:1529:1: error: size of unnamed array is negative request.h:1530:1: error: size of unnamed array is negative request.h:1531:1: error: size of unnamed array is negative Each error represents the C_ASSERT code listed above. I'm probably missing something obvious here. Can someone please offer any advice on resolving these errors? Thank you.

3 8

Re: zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

------------------------------ On Sun, Apr 14, 2013 22:34 BST Vincent Povirk wrote: >> considering how old zlib is and the vast number of windows application which uses zlib > >Given how many people duplicate the effort to package zlib, the fact >that they're rarely updated, and the sort of problems gnulib exists to >work around, it would not surprise me if your particular zlib binary >is broken somehow. got nobody else to blame - because of exactly the issue you outlined encountered in the past, i am building the application with a private copy of the source of zlib 1.2.7.

2 1

zlib's gzseek return gabbage and fails intermittently under wine.
by Hin-Tak Leung 14 Apr '13

14 Apr '13

I am porting an application which uses zlib's gzseek quite extensively to do pseudo- random access of the content of large gz'ed files, in the same manner of some's use of posix's lseek. On small test data, it works correctly on wine. (identical result as linux). On production data - a large 9GB file - it gives gabbage. I thought it is 32-bit file access problem, until I check the return value of gzseek explicitly. It is supposed to return the same value as input on success, -1 on error. On wine, it does neither, *occasionally*! I found that a first gzseek works correctly, then a 2nd fails. It does not fails with a -1, but fails with a large bogus value. Currently I am working around this strange behavior by closing the file and re-opening until it gets a correct offset. The large bogus value increases gradually and wrap around about 8-10 such repeated set of gzseek calls. Anybody has any suggestion why gzseek would behave badly *intermittently* in wine? I assume it works correctly in windows - hardly to think that it doesn't work, considering how old zlib is and the vast number of windows application which uses zlib. On a separate note, the application seems extraordinary slow in wine (again I haven't tried in windows..) - even when it works correctly without the work-around, it is hundreds of times slower in wine than in linux.

2 1

Re: [PATCH 1/4] wined3d: 1x1 texures have a power of two size
by Henri Verbeet 14 Apr '13

14 Apr '13

On 13 April 2013 16:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -965,8 +965,6 @@ static HRESULT texture_init(struct wined3d_texture *texture, UINT width, UINT he > && !(format->id == WINED3DFMT_P8_UINT && gl_info->supported[EXT_PALETTED_TEXTURE] > && wined3d_settings.rendertargetlock_mode == RTL_READTEX)) > { > - if (width != 1 || height != 1) > - texture->flags &= ~WINED3D_TEXTURE_POW2_MAT_IDENT; > > texture->pow2_matrix[0] = (float)width; > texture->pow2_matrix[5] = (float)height; I think we'll want the empty line here gone as well, but otherwise the series looks ok.

1 0

Google Summer of Code
by Liu Tuo 13 Apr '13

13 Apr '13

Hi, How much knowledge should I have before applying for the wine project of implementing missing D3DX9 apis? Currently I have learnt opengl; I am familiar with the opengl and glut functions and the concepts behind these functions. Thanks for your help, Liu Tuo

1 0

Re: gdiplus: fix a clipping problem
by Vincent Povirk 13 Apr '13

13 Apr '13

This looks wrong. scaled_rect is an internally calculated value, not something supplied by the user, and comparing it to 0.5 doesn't make sense, especially since by this point the width was altered to add padding.

1 0

GSoC 2013 proposal: Implement XPath from scratch
by John Chadwick 12 Apr '13

12 Apr '13

Hello, I am a student of computer science interested in entering Wine development via GSoC 2013. Upon looking at the various suggested proposals, the project of reimplementing XPath without libxml2 looked particularly interesting. I am familiar with the C language, W3C DOM and XPath, and I believe this is something I could do. I have a few questions I'd be interested in seeing answered: * One of the 'important things to keep in mind' is that "changes should be incremental, with a fallback to libxml2 until new processor is fully functional." Does this mean at compile time, or at runtime, when the evaluator recognizes unimplemented features in an expression, or something else entirely? * Is only MSXML 3.0 supported? It appears to be the only version implemented in the Wine source tree. * What should I aim at doing first? Because what I'd be working on is a library, I would probably need some application to test features with (test cases aside.) Should I be using an existing program, or writing a new one? Thanks, John Chadwick

3 2

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 5).
by Sergey Guralnik 12 Apr '13

12 Apr '13

On 2013-04-10 14:28, Sergey Guralnik wrote: >> >> It's better, but testing the message sequence doesn't seem very >> useful, >> particularly since you don't differentiate parent and child >> messages. >> Also you should test the region before the move to show that it's >> the >> move that's changing it. > > Changes since last version: > - message sequence testing removed at all > - added update region testing for all windows > before and after moving. > > --- > dlls/user32/tests/win.c | 68 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 68 insertions(+), 0 deletions(-) Is something wrong with this version? -- Sergey

1 0

Re: [PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used
by Henri Verbeet 12 Apr '13

12 Apr '13

On 11 April 2013 11:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1069,17 +1069,17 @@ static void shader_generate_glsl_declarations(const struct wined3d_context *cont > shader_addline(buffer, "uniform sampler1D %s_sampler%u;\n", prefix, i); > break; > case WINED3DSTT_2D: > - texture = state->textures[i]; > + tex_rect = version->type == WINED3D_SHADER_TYPE_PIXEL && (ps_args->np2_fixup & (1 << i)); The basic idea is ok, but the conditions for when np2_fixup is set are a bit more complicated than that. Specifically, look at how the WINED3D_TEXTURE_POW2_MAT_IDENT texture flag is set / cleared in texture_init().

2 4

Re: [3/3] server: Add support for NtTerminateProcess(0). Resend.
by Alexandre Julliard 12 Apr '13

12 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This patch fixes the problem reported in the bug 33331. Before you can start killing threads, you'll need to fix the various synchronization primitives (with appropriate tests of course) to take process shutdown into account, otherwise it will deadlock all over the place. Other things like protecting the loader data structures will also need more thought. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fresh WineWiki Theme, Straight from the Farm
by Kyle Auble 11 Apr '13

11 Apr '13

So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin. It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues. I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5). For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone. One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped. As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables. I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin. - Kyle

3 4

Re: user32: SetTimer should respect the minimum and maximum timeout limits.
by Marvin 11 Apr '13

11 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25036 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === msg.c:8247: Test failed: did not get expected count for minimum timeout (57 != ~64).

1 0

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.
by Ken Thomases 11 Apr '13

11 Apr '13

On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef transport, const void *buff, > return ret; > } > > +DWORD schan_imp_enabled_protocols(void) > +{ > + /* NOTE: No support for TLS 1.1 and TLS 1.2 */ > + return SP_PROT_SSL2_CLIENT | SP_PROT_SSL3_CLIENT | SP_PROT_TLS1_0_CLIENT; > +} Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. You can test at build time with: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 ... #else ... #endif If we want to support building on 10.8 for deployment to earlier versions, we'd do something like: #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 SSLProtocol maxProtocol; if (SSLGetProtocolVersionMax != NULL && SSLGetProtocolVersionMax(context, &maxProtocol) == noErr) { ... compare maxProtocol against kTLSProtocol11 and kTLSProtocol12 ... } ... #else ... #endif The idea is that SSLGetProtocolVersionMax() would be weak linked, so we'd check if it was actually available before calling it. Of course, the other complication is that that function requires a context parameter, but we can create one just for the query if we're interested in the framework capabilities (as opposed to what's been configured for a particular context). -Ken

3 10

Re: [2/5] include/wine/test.h: Report child process failures using shared memory.
by Alexandre Julliard 11 Apr '13

11 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Alexandre Julliard <julliard(a)winehq.org> wrote: > >> > As far as I can see ExitProcess returns 'failures' as the child process exit >> > code, but variable 'failures' is not visible from the tests. Do you have a >> > suggestion how to fix that? >> >> You need to report the status a different way. For instance you could >> store it in a file. > > How does this one look like? (In theory this approach could be used > to transfer other child process information to the parent). Something like this would work, but it should be done in the test that needs it, not in the generic code. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args
by Henri Verbeet 11 Apr '13

11 Apr '13

On 11 April 2013 11:40, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + for (i = 0; i < 6; ++i) > + { This could probably do with an appropriate constant. > +enum shader_tex_types > +{ > + shader_tex_2d = 0, > + shader_tex_3d = 1, > + shader_tex_cube = 2, > +}; Please use uppercase for enum elements. Some "wined3d" prefixes probably wouldn't hurt either, although I guess it doesn't matter so much for things that are only used internally.

1 0

Google Summer of Code
by Liu Tuo 10 Apr '13

10 Apr '13

Hi, I am Liu Tuo from National University of Singapore. I am interested in implementing missing D3DX9 APIs, how can I know more about this project and how can I apply for it? Is there anyone who can help me with this? Regards, Liu Tuo

2 1

We're in GSoC 2013
by Austin English 10 Apr '13

10 Apr '13

If you're interested in mentoring, please apply at: https://www.google-melange.com/gsoc/org/google/gsoc2013/wine In either case, please take a look at http://wiki.winehq.org/SummerOfCodeand update/remove/any projects you're familiar with. If you have any questions, feel free to contact me. Thanks for your help everyone! -- -Austin

2 2

Re: [PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/wined3d/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index da8fc7b..5010676 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct wined3d_gl_info *gl_info, struct wined > GLenum status; > GLuint tex; > > + if (!(format->flags & WINED3DFMT_FLAG_TEXTURE)) > + return; > + I'm not sure about this one, what exactly should this achieve? In either case, this probably belongs in init_format_fbo_compat_info(), together with the other similar checks.

2 3

[PATCH v5 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 10 Apr '13

10 Apr '13

Main changes fom v4: 1) deny_lock_file uses FS_DOES_SHARELOCK flag from fs_flags to determine whether to use VFS locks or not. 2) Make nfs code return -EBUSY for share conflicts (was -EACCESS). Main changes from v3 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 ++++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------- fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 +++--- fs/fcntl.c | 5 +- fs/locks.c | 105 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 +++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 4 +- fs/nfs/nfs4super.c | 9 ++-- fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 7 ++- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 8 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 29 files changed, 364 insertions(+), 130 deletions(-) -- 1.8.1.5

4 14

Re: [PATCH 1/2] wined3d: Handle texture types via ps/vs_compile_args
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 13:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch only changes the way the texture types are fed into the > shader generation code. Generating the proper shader code (hardcoded > values instead of relying on the dummy textures) is a task I've left for > Matteo, who worked on this problem before. > > This patch originates from my work-in-progress command stream work. It > is one of the few that I think makes sense on its own. > --- Why do you need the sampler type for anything other than SM1 pixel shaders? Also, while in principle I'm all for not accessing wined3d_state from the shader backend, I don't think there should be anything in the command stream patches that would prevent that.

4 4

Re: [PATCH 1/8] wined3d: Remove useless glClearxxx calls.
by Henri Verbeet 10 Apr '13

10 Apr '13

On 10 April 2013 01:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - /* Clear the screen */ > - gl_info->gl_ops.gl.p_glClearColor(1.0f, 0.0f, 0.0f, 0.0f); > - checkGLcall("glClearColor"); > - gl_info->gl_ops.gl.p_glClearIndex(0); > - gl_info->gl_ops.gl.p_glClearDepth(1); > - gl_info->gl_ops.gl.p_glClearStencil(0xffff); > - > - checkGLcall("glClear"); > And actually potentially harmful, if the new context is created after an existing one already did drawing on the same drawable. (Although that's fairly unlikely, especially with "AlwaysOffscreen" enabled.)

2 1

Re: tools: add ProductId to the Windows NT Current Version block
by Alexandre Julliard 10 Apr '13

10 Apr '13

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -3019,6 +3019,7 @@ HKLM,%CurrentVersionNT%,"CSDVersion",2,"Service Pack 3" > HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"2600" > HKLM,%CurrentVersionNT%,"CurrentType",2,"Uniprocessor Free" > HKLM,%CurrentVersionNT%,"ProductName",2,"Microsoft Windows XP" > +HKLM,%CurrentVersionNT%,"ProductId",,"12345-oem-0000001-54321" I'm not sure it's a good idea to hardcode this. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: kernel32: Add a test for threads state when a process is being terminated. Take 2.
by Alexandre Julliard 10 Apr '13

10 Apr '13

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This test demonstrates the problem reported in the bug 33331. > > This version of the patch moves the ExitProcess test into a child process. It still won't report failures properly though. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [3/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Nikolay Sivov 10 Apr '13

10 Apr '13

On Mon, Apr 8, 2013 at 3:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This file recreates most, if not all, of the source found in > dlls/advapi32/registry.c in dlls/kernel32. It provides registry > functionality. > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > dlls/kernel32/advapi32_registry.c | 2928 > +++++++++++++++++++++++++++++++++++++ > 1 file changed, 2928 insertions(+) > create mode 100644 dlls/kernel32/advapi32_registry.c > > > Why do you need this? (not to mention that you can't just duplicate it like that)

3 8

Google Summer of code
by Liu Tuo 10 Apr '13

10 Apr '13

Hi, I am Liu Tuo from National University of Singapore, a second year student in computer science. I am interested in joining this year's google summer of code in wine project. Have a nice day, Liu Tuo

1 0

Google summer of code
by Tabibel Sami 09 Apr '13

09 Apr '13

Hi, I am sami, i am student at limoges university in france am doing a master degree: Cryptology and information security and am interesting to work on wine project this summer I like C programming. Regards

1 0

[AppDB] -more spam-
by Joerg Schiermeier 09 Apr '13

09 Apr '13

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 1

Re: [1/3] include: Add COM interface definitions needed for PrintDlgEx implementation.
by Nikolay Sivov 09 Apr '13

09 Apr '13

Why not use DECLARE_INTERFACE_ here? And why bother checking UNICODE? On Mon, Apr 8, 2013 at 12:10 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/uuid/uuid.c | 1 + > include/commdlg.h | 80 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 81 insertions(+) > > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index fd96fe3..fb06f2d 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -83,6 +83,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "sensevts.h" > #include "ocmm.h" > #include "commoncontrols.h" > +#include "commdlg.h" > #include "tlogstg.h" > #include "msdasc.h" > > diff --git a/include/commdlg.h b/include/commdlg.h > index 1a6e1d9..6eeb615 100644 > --- a/include/commdlg.h > +++ b/include/commdlg.h > @@ -762,6 +762,86 @@ typedef struct tagPDEXW > DECL_WINELIB_TYPE_AW(PRINTDLGEX) > DECL_WINELIB_TYPE_AW(LPPRINTDLGEX) > > +#ifdef STDMETHOD > +DEFINE_GUID(IID_IPrintDialogCallback, > 0x5852a2c3,0x6530,0x11d1,0xb6,0xa3,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogCallback IPrintDialogCallback; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("5852a2c3-6530-11d1-b6a3-0000f8757bf9") > +IPrintDialogCallback : public IUnknown > +{ > + virtual HRESULT STDMETHODCALLTYPE InitDone() = 0; > + virtual HRESULT STDMETHODCALLTYPE SelectionChange() = 0; > + virtual HRESULT STDMETHODCALLTYPE > HandleMessage(HWND,UINT,WPARAM,LPARAM,LRESULT *) = 0; > +}; > +#else > +typedef struct IPrintDialogCallbackVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogCallback > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogCallback *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogCallback *This); > + /*** IPrintDialogCallback methods ***/ > + HRESULT (STDMETHODCALLTYPE *InitDone)(IPrintDialogCallback *This); > + HRESULT (STDMETHODCALLTYPE *SelectionChange)(IPrintDialogCallback > *This); > + HRESULT (STDMETHODCALLTYPE *HandleMessage)(IPrintDialogCallback > *,HWND,UINT,WPARAM,LPARAM,LRESULT *); > + > + END_INTERFACE > +} IPrintDialogCallbackVtbl; > +interface IPrintDialogCallback > +{ > + CONST_VTBL IPrintDialogCallbackVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > + > +DEFINE_GUID(IID_IPrintDialogServices, > 0x509aaeda,0x5639,0x11d1,0xb6,0xa1,0x00,0x00,0xf8,0x75,0x7b,0xf9); > +typedef interface IPrintDialogServices IPrintDialogServices; > + > +#if defined(__cplusplus) && !defined(CINTERFACE) > +MIDL_INTERFACE("509aaeda-5639-11d1-b6a1-0000f8757bf9") > +IPrintDialogServices : public IUnknown > +{ > +#ifdef UNICODE > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEW,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPWSTR,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPWSTR,UINT *) = > 0; > +#else > + virtual HRESULT STDMETHODCALLTYPE GetCurrentDevMode(LPDEVMODEA,UINT > *) = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPrinterName(LPSTR,UINT *) > = 0; > + virtual HRESULT STDMETHODCALLTYPE GetCurrentPortName(LPSTR,UINT *) = > 0; > +#endif > +}; > +#else > +typedef struct IPrintDialogServicesVtbl > +{ > + BEGIN_INTERFACE > + > + /*** IUnknown methods ***/ > + HRESULT (STDMETHODCALLTYPE *QueryInterface)(IPrintDialogServices > *This,REFIID riid,void **ppvObject); > + ULONG (STDMETHODCALLTYPE *AddRef)(IPrintDialogServices *This); > + ULONG (STDMETHODCALLTYPE *Release)(IPrintDialogServices *This); > + /*** IPrintDialogServices methods ***/ > +#ifdef UNICODE > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEW *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPWSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPWSTR,UINT *); > +#else > + HRESULT (STDMETHODCALLTYPE *GetCurrentDevMode)(IPrintDialogServices > *,LPDEVMODEA *,UINT *); > + HRESULT (STDMETHODCALLTYPE > *GetCurrentPrinterName)(IPrintDialogServices *,LPSTR,UINT *); > + HRESULT (STDMETHODCALLTYPE *GetCurrentPortName)(IPrintDialogServices > *,LPSTR,UINT *); > +#endif > + > + END_INTERFACE > +} IPrintDialogServicesVtbl; > +interface IPrintDialogServices > +{ > + CONST_VTBL IPrintDialogServicesVtbl *lpVtbl; > +}; > +#endif /* CINTERFACE */ > +#endif /* STDMETHOD */ > + > BOOL WINAPI ChooseColorA(LPCHOOSECOLORA lpChCol); > BOOL WINAPI ChooseColorW(LPCHOOSECOLORW lpChCol); > #define ChooseColor WINELIB_NAME_AW(ChooseColor) > -- > 1.8.2 > > > >

3 3

[AppDB] -more spam-
by Joerg Schiermeier 09 Apr '13

09 Apr '13

Hi list, again a spammer used the AppDB for his nasty activities: 1.) > Comment for 'Adobe Photoshop CS3 (10.0)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=6584#Comment-8… 2.) > Comment for 'ElsterFormular 12.0 (2010 + 2011)' added by tokoku12345 > ------------------------------------------------------- > To reply to this email please use the link provided below. > DO NOT reply via your email client as it will not reach the person who wrote the comment > http://appdb.winehq.org/objectManager.php?sClass=version&iId=22570#Comment-… No. #2 is maintained by me, so I deleted the comment just some minutes ago. Is it possible, to mail to all maintainers to inform them about the actual mail food and to have an eye on their applications? If so please do it. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

[GSoC] My (new) proposal for GSoC 2013
by Gediminas Jakutis 09 Apr '13

09 Apr '13

Hello! My previous application[1] turned out to be a total failure, hence making a completely different one. My proposal this time goes as follows: Write various D3D tests, mostly focusing on ones that can be later re-used for dxdiag in one way or another. Along with writing a tool that would allow users to easily test if d3d and wgl / opengl work & are set up properly. Info about me (copied over from [1]): >My name is Gediminas Jakutis. I study Informatics Engineering >[bachelor / undergraduate] at Kaunas University of Technology, second >year. >I wish to try out GSoC for the first time by helping to improve Wine. >My primary programming language is C. I am self-taught in C, but I >believe my knowledge is good enough. >I am quite familiar with Wine - I use it and experiment with it for >many years now. I am subscribed to and read wine-devel for more than a >year. >I browse through Wine's source code once in a while out of curiosity. >Thus, I have some knowledge of its structure. >Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. [1] http://www.winehq.org/pipermail/wine-devel/2013-March/099213.html Thank You for Your time Gediminas Jakutis -- LDK Varčiai www.varciai.lt

2 4

Re: kernel32: Add a test for threads state when a process is being terminated.
by Marvin 09 Apr '13

09 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24997 Your paranoid android. === W2KPROSP4 (32 bit loader) === No test summary line found === W2K3R2SESP2 (32 bit loader) === No test summary line found === W2K8SE (32 bit loader) === No test summary line found === W7PROX64 (32 bit loader) === No test summary line found === TEST64_W7SP1 (32 bit loader) === No test summary line found

1 0

[AppDB] Comment for 'Microsoft Outlook 2007' added by bayu
by Joerg Schiermeier 09 Apr '13

09 Apr '13

On Monday, April 8, 2013 at 07:49:47 an anonymous spammer wrote into the AppDB: > Comment for 'Microsoft Outlook 2007' added by bayu > http://appdb.winehq.org/objectManager.php?sClass=version&iId=7533#Comment-8… (...garbage killed...) Could someone of AppDBs admin please kill this comment and the user 'bayu'. Thanks lot! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

4 3

Re: [1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
by Frédéric Delanoy 09 Apr '13

09 Apr '13

On Mon, Apr 8, 2013 at 2:53 PM, Hugh McMaster < hugh.mcmaster(a)masterindexing.com> wrote: > This patch creates winecon_private.h in 'include/wineconsole'. The header > is now a shared header. Note that the source code is the same as that in > programs/wineconsole/winecon_private.h. (This latter file will be removed > later.) > > Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). > > --- > include/wineconsole/winecon_private.h | 103 > +++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 include/wineconsole/winecon_private.h > Please don't send 13 patches with the same name. Also, for long patch series, you should describe the whole purpose of the series in the first patch [1/N] (or even better in a [0/N] patch) Finally,even if "one change per patch" is the rule, don't overdo it... Frédéric

2 1

Dosbox integration
by Fabian Ebner 09 Apr '13

09 Apr '13

Hello, I'm Fabian Ebner and work with wine as a hobby. I found that GetShortNameA converts the example path C:\123456789\dn\DN.COM to C:\1234~Q4C\dn\DN.COM which causes problems with dosbox integration. Dosbox would need the path as C:\123456~1\dn\DN.COM Is there another function that converts the path in the way, dosbox needs it, should it be implemented or should dosbox be able to handle the first form of the path too? Also wine often tries to mount his z: drive, which isn't possible, because dosbox already mounts an own Z: drive http://www.dosbox.com/wiki/ZDrive Maybe wine should mount his Z: as Y:? Thanks in advance ~Fabian

2 1

Re: [3/3] comdlg32: Add an interactive PrintDlgEx test. Resend.
by Marvin 09 Apr '13

09 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24996 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Alexandre Julliard 08 Apr '13

08 Apr '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > There are two ways to solve this promlem: > - write own parser for extrac32, > - perform some translation for command line before > passing to CommandLineToArgvW(). > > I think that second variant is more appropriate. The first one would be cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Properly handle backbuffer_width/_height=0 in wined3d_device_reset. (try 3)
by Alexandre Julliard 08 Apr '13

08 Apr '13

Sam Edwards <cfsworks(a)gmail.com> writes: > This patch differs from try 2 in formatting alone. > > From ac2134cfce1139cb35c4ea5c3943a870183fc2f4 Mon Sep 17 00:00:00 2001 > From: Sam Edwards <CFSworks(a)gmail.com> > Date: Sat, 6 Apr 2013 18:03:34 -0600 > Subject: wined3d: Properly handle backbuffer_width/_height=0 in > wined3d_device_reset. It fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so d3d9ex.c && touch d3d9ex.ok d3d9ex.c:693: Test succeeded inside todo block: Got unexpected scissor rect {0, 0, 200, 150}. d3d9ex.c:701: Test succeeded inside todo block: Got unexpected vp.Width 200. d3d9ex.c:702: Test succeeded inside todo block: Got unexpected vp.Height 150. d3d9ex.c:710: Test succeeded inside todo block: Got unexpected backbuffer width 200. d3d9ex.c:711: Test succeeded inside todo block: Got unexpected backbuffer height 150. make[1]: *** [d3d9ex.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, resend]: Floatify fabs into fabs
by Matteo Bruni 08 Apr '13

08 Apr '13

2013/4/7 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Both patches are fine for me (note that the email subject is missing an "f" but the actual patch has the correct title).

1 0

[PATCH v4 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 08 Apr '13

08 Apr '13

Main changes from the previous one: 1) O_DENYMAND is removed, sharelock mount option is introduced. 2) Patch fcntl.h and VFS patches are united into one. 3) flock/LOCK_MAND is disabled for sharelock mounts. This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows us to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), The patchset avoid data races problem on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This let us not mix one share reservation approach with another. The #1 patch adds flags to fcntl and implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -EBUSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with O_DENYMAND flag and READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with O_DENYMAND flag and WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYMAND and O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYMAND and O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -EBUSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags CIFS: Add share_access parm to open request CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts fs/cifs/cifsacl.c | 8 +-- fs/cifs/cifsglob.h | 18 ++++++- fs/cifs/cifsproto.h | 8 +-- fs/cifs/cifssmb.c | 50 +++++++++--------- fs/cifs/dir.c | 16 +++--- fs/cifs/file.c | 20 +++++--- fs/cifs/inode.c | 16 +++--- fs/cifs/link.c | 25 +++------ fs/cifs/readdir.c | 5 +- fs/cifs/smb1ops.c | 16 +++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +-- fs/cifs/smb2proto.h | 14 ++--- fs/fcntl.c | 5 +- fs/locks.c | 108 ++++++++++++++++++++++++++++++++++++--- fs/namei.c | 45 ++++++++++++++-- fs/nfs/internal.h | 3 +- fs/nfs/nfs4proc.c | 2 + fs/nfs/nfs4xdr.c | 21 ++++++-- fs/nfs/super.c | 3 +- fs/nfsd/nfs4state.c | 46 ++++++++++++++++- fs/proc_namespace.c | 1 + include/linux/fs.h | 7 +++ include/uapi/asm-generic/fcntl.h | 11 ++++ include/uapi/linux/fs.h | 1 + 27 files changed, 355 insertions(+), 124 deletions(-) -- 1.8.1.5

2 10

Re: [3/3] comdlg32: Add an interactive PrintDlgEx test.
by Marvin 08 Apr '13

08 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24985 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Sergey Guralnik 08 Apr '13

08 Apr '13

On 2013-04-04 15:19, Sergey Guralnik wrote: > Playing with one application, that uses extrac32.exe, > I've found that Wine's extrac32 can't process some > command lines, that cause no problem with native one. > ... Is this patch or explanation not clear enough? (Still marked as "New") -- Sergey

1 0

Re: wbemprox: Implement some properties of Win32_ComputerSystem and Win32_DiskPartition.
by Hans Leidekker 08 Apr '13

08 Apr '13

On Mon, 2013-04-08 at 01:56 +0900, Kim Jung Eon (김중언) wrote: > @@ -241,18 +243,21 @@ static const struct column col_compsys[] = > { prop_modelW, CIM_STRING }, > { prop_numlogicalprocessorsW, CIM_UINT32, VT_I4 }, > { prop_numprocessorsW, CIM_UINT32, VT_I4 }, > - { prop_totalphysicalmemoryW, CIM_UINT64 } > + { prop_totalphysicalmemoryW, CIM_UINT64 }, > + { prop_nameW, CIM_STRING|COL_FLAG_DYNAMIC } Please keep properties sorted.

1 0

Re: d3dx9 [patch 1/3]: Avoid two useless computations
by Rico Schüller 07 Apr '13

07 Apr '13

On 05.04.2013 09:13, Nozomi Kodama wrote: > s = 0.75f; > - if ( order > 2 ) > - s += 5.0f / 16.0f; > - if ( order > 4 ) > - s -= 3.0f / 32.0f; > + if (order > 2) > + s = 1.0625f; > + if (order > 4) > + s = 0.96875f; > s /= D3DX_PI; Doesn't the compiler do that already? If not something like this would probably better: s = 0.23873...f; /* 0.75f / D3DX_PI */ if (order > 2) s = 1.0625f / D3DX_PI; if (order > 4) s = 0.96875f / D3DX_PI; Cheers Rico

2 1

Re: wbemprox: Implement some properties of Win32_ComputerSystem and Win32_DiskPartition.
by Nikolay Sivov 07 Apr '13

07 Apr '13

Please use your real name. On Sun, Apr 7, 2013 at 7:46 PM, mog422 <admin(a)mog422.net> wrote: > > > > >

1 0

64bit winelib test app fails on AMD CPU, but works on Intel - need help to identify possible problem, please :)
by jordan 07 Apr '13

07 Apr '13

Hey List, A few days ago, i posted to the list about possibly porting a winelib app to support x86_64. (currently supports x86). the original post is here (for those interested, but not entirely relevant to this post): http://wine.1045685.n5.nabble.com/exploring-possibly-porting-winelib-app-to… moving on. So we have a simple test app, that successfully loads 64bit DLLs on my friend's Intel based machines, while on my AMD Phenom II 965 X4 - the code fails. -> Successful on Intel: xj@xj:~/Muzyka/fsthost/trunk$ ./test64.exe ../../VST/ColourEQ_64.dll Load plugin ../../VST/ColourEQ_64.dll fixme:heap:HeapSetInformation 0x3c4000 0 0x22f610 4 Main entry: 0x1800077d0 Revive plugin V: 66048 U: 1131365713 NI: 2 NO: 2 NPr: 10 NPa: 42 Open Close So intel computers tested (2 that i know of) work just fine. -> Failure on AMD: http://pastebin.com/x64pig3s and a little snippet: ./test64.exe '/home/ninez/Desktop/ColourEQ_64.dll' fixme:heap:HeapSetInformation 0x2c4000 0 0x23fce0 4 Load plugin /home/ninez/Desktop/ColourEQ_64.dll fixme:heap:HeapSetInformation 0x3d4000 0 0x23f5f0 4 Main entry: 0x1800077d0 Revive plugin wine: Unhandled page fault on read access to 0xffffffff at address 0xffffffff (thread 002a), starting debugger... fixme:dbghelp:elf_search_auxv can't find symbol in module <snip> fixme:dbghelp:elf_search_auxv can't find symbol in module Unhandled exception: page fault on read access to 0xffffffff in 64-bit code (0x00000000ffffffff). fixme:dbghelp:elf_search_auxv can't find symbol in module Register dump: rip:00000000ffffffff rsp:000000000023fa78 rbp:000000000023fbd0 eflags:00010246 ( R- -- I Z- -P- ) rax:00000000003d8de0 rbx:0000000000000000 rcx:0000000000000000 rdx:0000000000000001 rsi:00000000ffffffff rdi:00007f1205f559d0 r8:0000000000000000 r9:0000000000000000 r10:0000000000000001 r11:0000000000000000 r12:0000000000000000 r13:00007f1205f50040 r14:000000007b86f920 r15:00007fffffbe8000 Stack dump: 0x000000000023fa78: 0000000180007756 00000000003d8de0 0x000000000023fa88: 00007f1206ff14d3 0000000000010ac1 0x000000000023fa98: 000000000000000d 0000000000000000 0x000000000023faa8: 00007f1200000000 fffffffffffffffe 0x000000000023fab8: 000000000023fbd0 00007f1205f559d0 0x000000000023fac8: 00007f1205f55b09 2020202020202020 0x000000000023fad8: 0000000000010ac1 00007f1207324323 0x000000000023fae8: 0000000000002000 ffff00ffffffffff 0x000000000023faf8: ffff00ffffffffff 0000000000202020 0x000000000023fb08: 00000001800077d0 0000000180000000 0x000000000023fb18: 0000000000010ac1 5b5b5b5b5b5b5b5b 0x000000000023fb28: 5b5b5b5b5b5b5b5b 2020202020202020 It's odd that it is working on Intel H/W, but not my AMD system. ~ what could be a possible reason for this? We've made s simple test app that doesn't require jackd, or FSThost functions, to simplify things. The source code can be found here: https://sourceforge.net/p/fsthost/code/171/tree/ SVN code required: svn checkout svn://svn.code.sf.net/p/fsthost/code/trunk fsthost-code the test app source code is called 'test64-most-simple.c' The test app can be compiled with; $ make -f Makefile64-most-simple then $ ./test64.exe /path/to/64bitVST a tester can be found here: http://www.ddmf.eu/freeware.php grab 'ColourEQ' (contains both 32bit and 64bit versions... and obviously use the 64bit version to try/test.) anyway, i am not sure what the problem is, maybe someone here has an idea or two? ... i've been wondering if there is some sort of misalignment/compiler issue, that is causing the problem...but i want to rule out Wine64 being an issue, first - if possible. any help is appreciated. Thanks Jordan

5 12

Build and override a simple winelib DLL
by Maxime Sednaoui 06 Apr '13

06 Apr '13

Hi, First, I already asked for the same thing at the forum where I've been told to post here for my question Link here : http://forum.winehq.org/viewtopic.php?f=8&t=18675 I have a Windows executable that load a really simple DLL (it is a test) and I want to create a Winelib DLL that will override the Windows DLL. Basically, I created mylib_main.c and mylib.spec to build the Winelib DLL with the command: winegcc -mwindows -o mylib.dll.so mylib_main.c -I${WINE_ROOT}/include -shared mylib.spec winebuild -w --def -o libmylib.def --export mylib.spec Now I have mylib.dll.so and I want to override mylib.dll What should I do ? I removed the Windows library but then I got a Page Fault when the function is called. I also tried to configure the override with winecfg or set environment variables like WINEDLLPATH or add a DllMain in my library. I don't understand how to proceed. Is this because of the way I build my library ? Or maybe I forget a step to link it properly ? In attachment, a tar with the sources and binaries myapp.exe : the Windows executable mylib.dll : the Windows library mylib_main.c , mylib.spec : the sources to build the Winelib library

3 3

Portability - Port Wine to Wayland
by André Hentschel 05 Apr '13

05 Apr '13

Hi Dan, i just removed your gsoc idea and i want to let you know why. There was a quite short discussion on IRC: Andre_H_laptop: austin_laptop: Dan added a quite controversal gsoc idea... afaik ken needed 1 year for the mac driver and dan further suggests to have a look at xwayland first to see if a new driver is needed. So the time needed for that job is some days to 1 year. what do you think? julliard: Andre_H_laptop: writing a graphics driver is definitely not suitable for gsoc

2 1

Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 3)
by Marvin 05 Apr '13

05 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24967 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Trying Battle for Wesnoth in Wine.
by Tae Wong 05 Apr '13

05 Apr '13

You haven’t tried Battle for Wesnoth latest version in Wine on Ubuntu so you have uploaded the about.cfg file to MediaFire which contains over 1000 lines and some un-terminated quoted strings in many names. Check it here (http://www.mediafire.com/?mbw9y2i834z2k7r)! Swear at error message (Quoted string not terminated) whilst you fix the un-terminated quoted strings.

2 1

Trying Battle for Wesnoth in Wine.
by Tae Wong 05 Apr '13

05 Apr '13

You haven’t tried Battle for Wesnoth latest version in Wine on Ubuntu so you have uploaded the about.cfg file which contains over 1000 lines and some un-terminated quoted strings in many names.

1 0

[PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 04 Apr '13

04 Apr '13

This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why one extra flag O_DENYMAND is added. It indicates to underlying layer that an application want to use O_DENY* flags semantic. It allows us not affect native Linux applications (that don't use O_DENYMAND flag) - so, these flags (and the semantic of open syscall that they bring) are used only for those applications that really want it proccessed that way. So, we have four new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations (this flag is not implemented in VFS and NFS part and only suitable for CIFS module), O_DENYMAND - to switch on/off three flags above. Also, this version of the patchset fixes the problem of data races on newely created files: open with O_CREAT can return the -ETXTBSY error for a successfully created file if this files was locked with a deny lock by another task. The #1 patch adds flags to fcntl, the #2 patch implements VFS part. The patches #3, #4, #5 are related to CIFS-specific changes, #6 and #7 describe NFS and NFSD parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYMAND - used to inforce a mandatory share reservation scheme of the file access. If this flag is passed, the open fails with -ETXTBSY in following cases: 1) if O_DENYREAD flag is specified and there is another open with O_DENYMAND flag and READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with O_DENYMAND flag and WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYMAND and O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYMAND and O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ETXTBSY untill this open is closed. Now this flag is processed by CIFS filesystems only. This mechanism is done through flocks. If O_DENYMAND is specified and flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) O_DENYMAND -> LOCK_MAND 2) !O_DENYREAD -> LOCK_READ 3) !O_DENYWRITE -> LOCK_WRITE ----- Pavel Shilovsky (7): fcntl: Introduce new O_DENY* open flags vfs: Add O_DENYREAD/WRITE flags support for open syscall CIFS: Add O_DENY* open flags support CIFS: Use NT_CREATE_ANDX command for forcemand mounts CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2 NFSv4: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS fs/cifs/cifsacl.c | 6 +- fs/cifs/cifsglob.h | 12 +++- fs/cifs/cifsproto.h | 9 +-- fs/cifs/cifssmb.c | 47 ++++++++-------- fs/cifs/dir.c | 14 +++-- fs/cifs/file.c | 18 ++++-- fs/cifs/inode.c | 11 ++-- fs/cifs/link.c | 10 ++-- fs/cifs/readdir.c | 2 +- fs/cifs/smb1ops.c | 15 ++--- fs/cifs/smb2file.c | 10 ++-- fs/cifs/smb2inode.c | 4 +- fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 10 ++-- fs/cifs/smb2pdu.c | 6 +- fs/cifs/smb2proto.h | 14 +++-- fs/fcntl.c | 5 +- fs/locks.c | 117 +++++++++++++++++++++++++++++++++++---- fs/namei.c | 44 ++++++++++++++- fs/nfs/nfs4xdr.c | 24 ++++++-- fs/nfsd/nfs4state.c | 46 ++++++++++++++- include/linux/fs.h | 6 ++ include/uapi/asm-generic/fcntl.h | 14 +++++ 23 files changed, 345 insertions(+), 101 deletions(-) -- 1.8.1.2

8 36

Re: wined3d: Properly handle backbuffer_width/_height=0 in wined3d_device_reset.
by Henri Verbeet 04 Apr '13

04 Apr '13

Is this really the correct behaviour when windowed is FALSE and the backbuffer width / height is 0? That may just not be allowed at all, but it seems weird to use the window's dimensions in that case, instead of e.g. the current display mode. > if (!swapchain_desc->backbuffer_width || !swapchain_desc->backbuffer_height > || swapchain_desc->backbuffer_width != swapchain->desc.backbuffer_width > || swapchain_desc->backbuffer_height != swapchain->desc.backbuffer_height) Double indent for line continuations, please. > window = swapchain_desc->device_window ? > swapchain_desc->device_window : device->create_parms.focus_window; This is really just the same as "window = swapchain->device_window;". > if(swapchain_desc->backbuffer_width) Space between control statements and '('.

1 0

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().
by Sergey Guralnik 04 Apr '13

04 Apr '13

On 2013-04-04 15:19, Sergey Guralnik wrote: > Playing with one application, that uses extrac32.exe, > I've found that Wine's extrac32 can't process some > command lines, that cause no problem with native one. > ... > There are two ways to solve this promlem: > - write own parser for extrac32, > - perform some translation for command line before > passing to CommandLineToArgvW(). P.S. Replacing wWinMain() with wmain() doesn't solve this problem. -- Sergey

1 0

Wine Gecko 2.20-beta1
by Jacek Caban 04 Apr '13

04 Apr '13

Hi all, I've uploaded a new Gecko builds to SourceForge [1]. This one is based on Firefox 20 beta and, other than usual update of Gecko, it should fix some crashes like bug b*ug 32753* <http://bugs.winehq.org/show_bug.cgi?id=32753>. To test them, you need recent Wine Git version with the attached patch. As usually, grab the build from SourceForge, put it in the right place [2] and run patched Wine. All help with testing is appreciated! Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/2.20-beta1/ [2] http://wiki.winehq.org/Gecko

1 1

Re: cmd: Remove a pointless linefeed in an error message.
by Julian Rüger 04 Apr '13

04 Apr '13

Sorry for nagging ;) Wasn't the convention to assume an 80-character wide terminal? This line would wrap, then. So the linefeed is not totally pointless here. Please correct me, if I'm mistaken. Best regards, Julian Am Mittwoch, den 03.04.2013, 16:07 +0200 schrieb Francois Gouget: > --- > programs/cmd/cmd.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/cmd/cmd.rc b/programs/cmd/cmd.rc > index c3cdb52..d464cab 100644 > --- a/programs/cmd/cmd.rc > +++ b/programs/cmd/cmd.rc > @@ -360,5 +360,5 @@ Enter HELP <command> for further information on any of the above commands.\n" > WCMD_NOOPERAND, "Expected an operand.\n" > WCMD_NOOPERATOR, "Expected an operator.\n" > WCMD_BADPAREN, "Mismatch in parentheses.\n" > - WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12),\n hexadecimal (0x34) or octal (056).\n" > + WCMD_BADHEXOCT, "Badly formed number - must be one of decimal (12), hexadecimal (0x34) or octal (056).\n" > }

2 1

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter (try 2)
by Dmitry Timoshkov 04 Apr '13

04 Apr '13

Austin English <austinenglish(a)gmail.com> wrote: > Try 2: use cdecl calling convention > -@ stub __crtSetUnhandledExceptionFilter > +@ cdecl __crtSetUnhandledExceptionFilter(ptr) kernel32.SetUnhandledExceptionFilter It's not acceptable to mix calling conventions when forwarding an API with number of arguments != 0. -- Dmitry.

1 0

Re: [PATCH 2/2] winspool.drv: Check the value of pDeviceName.(try 2, resend)
by Marvin 03 Apr '13

03 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24942 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 1/2] winspool.drv/tests: Add DocumentProperties test with empty pDeviceName.
by Marvin 03 Apr '13

03 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24941 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 8/8] configure: Get rid of no longer needed OpenSSL checks.
by Marcus Meissner 03 Apr '13

03 Apr '13

Hi, I have one concern ... Licensing. GNUTLS is (L)GPLv3+ these days. Wine will now turn into a LPGLv3+ licensed binary (not the sources, just the binaries will turn into it implicitly by linking against gnutls 3). Ciao, Marcus On Wed, Apr 03, 2013 at 02:06:09PM +0200, Jacek Caban wrote: > --- > configure.ac | 13 ------------- > 1 file changed, 13 deletions(-) > > > diff --git a/configure.ac b/configure.ac > index d8f2e8d..080e961 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -66,8 +66,6 @@ AC_ARG_WITH(openal, AS_HELP_STRING([--without-openal],[do not use OpenAL]), > AC_ARG_WITH(opencl, AS_HELP_STRING([--without-opencl],[do not use OpenCL]), > [if test "x$withval" = "xno"; then ac_cv_header_CL_cl_h=no; ac_cv_header_OpenCL_opencl_h=no; fi]) > AC_ARG_WITH(opengl, AS_HELP_STRING([--without-opengl],[do not use OpenGL])) > -AC_ARG_WITH(openssl, AS_HELP_STRING([--without-openssl],[do not use OpenSSL]), > - [if test "x$withval" = "xno"; then ac_cv_header_openssl_err_h=no; ac_cv_header_openssl_ssl_h=no; fi]) > AC_ARG_WITH(osmesa, AS_HELP_STRING([--without-osmesa],[do not use the OSMesa library])) > AC_ARG_WITH(oss, AS_HELP_STRING([--without-oss],[do not use the OSS sound support])) > AC_ARG_WITH(png, AS_HELP_STRING([--without-png],[do not use PNG]), > @@ -469,8 +467,6 @@ AC_CHECK_HEADERS(\ > netinet/in_systm.h \ > netinet/tcp.h \ > netinet/tcp_fsm.h \ > - openssl/err.h \ > - openssl/ssl.h \ > png.h \ > poll.h \ > port.h \ > @@ -1604,15 +1600,6 @@ fi > WINE_NOTICE_WITH(fontconfig,[test "x$ac_cv_lib_soname_fontconfig" = "x"], > [fontconfig ${notice_platform}development files not found, fontconfig won't be supported.]) > > -dnl **** Check for SSL **** > -if test "$ac_cv_header_openssl_err_h" = "yes" -a "$ac_cv_header_openssl_ssl_h" = "yes" > -then > - WINE_CHECK_SONAME(ssl,SSL_library_init) > - WINE_CHECK_SONAME(crypto,BIO_new_socket) > -fi > -WINE_WARNING_WITH(openssl,[test "x$ac_cv_lib_soname_ssl" = "x" -o "x$ac_cv_lib_soname_crypto" = "x"], > - [OpenSSL ${notice_platform}development files not found, SSL won't be supported.]) > - > dnl **** Check for gsm codec **** > if test "$ac_cv_header_gsm_h" = "yes" -o "$ac_cv_header_gsm_gsm_h" = "yes" > then > >

1 1

Re: [PATCH] winspool.drv: Check the value of pDeviceName.(try 2)
by Nikolay Sivov 03 Apr '13

03 Apr '13

On Wed, Apr 3, 2013 at 1:31 PM, Tatyana Fokina <tatyana(a)etersoft.ru> wrote: > Function DocumentPropertiesA calling GDI_CallExtDeviceMode16: If value > pDeviceName is "", from GDI_CallExtDeviceMode16 return -1. > > Is it possible to add a test for that?

2 1

Re: ieframe: Added GoForward tests.
by Marvin 03 Apr '13

03 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24939 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2615: Test failed: expected GetOverridesKeyPath webbrowser.c:2620: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2621: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3065: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21

1 0

Hi Res Icons
by Joel Holdsworth 03 Apr '13

03 Apr '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Alexandre (+ Others), I notice you've been working on hi-res icons. I just have a couple of comments to chip in. So 2 years ago when I was doing the wine icon refresh, I decided not to try and tackle the problem of hi-res icons. Just getting the normal sized icons merged had proved to be a gargantuan task that took me over a year to complete - I didn't have the stomach to embark on another round of artwork. We also didn't support PNG icons in those days. As you can see in these hi-res icon patches, scaling icons is never as simple as people think. http://source.winehq.org/git/wine.git/blob/HEAD:/programs/iexplore/iexplore… As you can see here, scaling the iexplore icons really shows the limits of this artwork. The line caps are wrong in several places. The worst being in the highlight of the yellow swoosh at the bottom - you see the highlight doesn't line up with the border. A lot of things don't quite line up correctly. Moreover what were sharp single pixel lines in the 48x48 image have become fat strokes, which look rather play-schoolish to my eye. The solution is to have dedicated artwork specifically for these large sizes. This has been done in the Mango icon project: http://jimmac.musichall.cz/i.php?i=MIME2 http://jimmac.musichall.cz/i.php?i=git3 http://jimmac.musichall.cz/i.php?i=Tango-NG This is the work of Jakub Steiner and Lapo Calamandrei. They did a workshop on how to do this artwork here: https://www.youtube.com/watch?v=2T7833s2MJI Notice the fine detailing and beautiful shading. In the network filter they even used a paper texture for the card of the folder! These guys have done a fantastic job. So I wanted to sound out how much desire there is for this for Wine. I'm probably not going to be able to contribute this myself, due to time constraints. I wondered if there were any other developers cum artists interested in having a go. 2 years ago I asked Jakub if he would be interested in doing this, but he said he was quite busy. It might be worth reaching out to him or Lapo again, to see if they'd like to contribute. Also, I don't know how much this work is being driven by CodeWeavers Mac product, but another approach would be to for CodeWeavers to solicit contract work or a bounty for this. Jakub or Lapo might be more able to make time on those terms - but of course I don't know if that's a deal they or CodeWeavers would be interested in making. Another source of volunteers might be the tango-artists ML, but I don't know how many there are there. Finally, I've rebased my patch for the joy.cpl icon. It doesn't have a 256px icon though. Is this wanted? Best Regards Joel Holdsworth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRW/TtAAoJEIsWlGmq62IgaEcIAJYY9q/B3fA2AZQnR5M41qWn Q84e/5jrc1u2w1skmWAkCNdHNHu/R6AURklQ0Hysbnzxp+5GfftPHTKkRzA59cgs jVmkTSiqdVGGeGDRW2YWAcaFiH25xEOqSb9APzMLT4IRVypLbTwWYWhAsaZCa6+0 1USLRakqs5SF7+lCt5VcSHqiko/HPZZsTtNZYDy7cE4DPoNGbajPR9/0fEUfOEj+ b6xyu62tzPHfUcH4hj7YLa7ukJhq2Hh2ELA6gXnjr6yk+pZfx2uMTtfPZ4joWZzw 1DVcyoTkmeCOnasKJU2Obj7vdWgZxWG+WG4KTneH9a+rkSLo6T6Jojae+BXU4O8= =tNa1 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/5] wined3d: Make fullscreen windows use HWND_TOPMOST instead of HWND_TOP. (try 3)
by Henri Verbeet 03 Apr '13

03 Apr '13

I think this series looks good.

1 0

Fwd: GSoC 2013 Ideas Page
by Austin English 02 Apr '13

02 Apr '13

I cleaned this up a couple months ago and removed completed/obsolete projects, but it needs further improvements (mostly new ideas). Please contribute any ideas that you have. Thanks! -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Tue, Apr 2, 2013 at 1:41 PM Subject: GSoC 2013 Ideas Page To: Carol Smith <carols(a)google.com> Hi there, You're receiving this email because we've reviewed your application for GSoC 2013. We're currently disappointed with the quality of your Ideas Page and would like to give you an opportunity to improve it and your chances of getting into GSoC this year. Please review the FAQs on Ideas Pages<http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc20…> as well as the Mentor Manual section about creating an ideaspage<http://en.flossmanuals.net/GSoCMentoring/making-your-ideas-page/> . You have 24 hours from now to improve your ideas page.We will review it again tomorrow. Please let me know if you have any questions. Cheers, Carol -- -Austin

1 1

Re: d3dx9 [patch1/3, try 2]: Do not use relative error for small numbers
by Matteo Bruni 02 Apr '13

02 Apr '13

2013/4/1 Nozomi Kodama <nozomi.kodama(a)yahoo.com> > > Since there are only at most 7 significant digits for a float, we must not be too picky about the expected difference for small numbers > > -#define relative_error(exp, out) ((exp == 0.0f) ? fabs(exp - out) : (fabs(1.0f - (out) / (exp)))) > +#define relative_error(exp, out) (fabs(exp) < 0.01f ? fabs(exp - out) : fabs(1.0f - (out) / (exp))) This doesn't make much sense. Being floating point numbers, they have the same relative precision regardless of the magnitude of the value (as long as you are inside the range of representable values and excluding special values and denormals, but that should be irrelevant to our case here). If using a larger tolerance for the test in patch 2 makes it pass, then I think that's all you have to change. Otherwise you need to figure out why the test result differs so much from the expected value. Slightly unrelated, I think we should use fabsf() instead of fabs() there. We are already using fabsf() in a bunch of places, including d3dx9 tests, so there shouldn't be problems with that.

1 0

Re: uxtheme/tests: Don't test for themed app
by Alexandre Julliard 02 Apr '13

02 Apr '13

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -84,18 +84,14 @@ static void test_IsThemed(void) > SetLastError(0xdeadbeef); > bThemeActive = pIsThemeActive(); > trace("Theming is %s\n", (bThemeActive) ? "active" : "inactive"); > + ok( GetLastError() == ERROR_SUCCESS || > + broken(GetLastError() == ERROR_FILE_NOT_FOUND /* Win2k8 */), > + "Expected ERROR_SUCCESS, got 0x%08x\n", > + GetLastError()); Testing last error when there's no failure is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

exploring/possibly porting winelib app to support 64bit.
by jordan 01 Apr '13

01 Apr '13

Hi list. A friend of mine and myself, have been exploring expanding a (currently, 32bit only) winelib app to support 64bit plugins in wine (64). The app is called FSThost, which is used to host win32 VST instruments and effects (.dll) as a standalone app in Gnu/linux. Webpage: http://sourceforge.net/projects/fsthost/ We currently have a example/test app in the source code, which compile as test64.exe / test.exe.so ... you then use the exeutable 'foo'. ~ in this case 'foo' could be /path/to/your/64bitVSTplugin. Currently, the code fails to load the 64bit dll. We are not sure exactly why it is failing, but suspect a couple of reasons. this is where we at at; 1) LoadLibrary - OK 2) GetProcAddress (get address of VSTPluginMain function from DLL library) - OK 3) Initialize plugin - i.e. call VSTPluginMain function from library - FAIL. Potential reasons: - Vestige mismatch - Wine GetProcAddress on 64 bit platform My friend thought someone more familiar with Wine / WinAPI could take a look on this 64bit DLL and at least confirm that address returned by GetProcAddress is correct. (or give us good tips and/or adive). Since, i am already subbed (to wine-devel), i thought i would see if any one was interested in having a look and/or giving us some pointers, tips, etc. Here's an example (with WINEDEBUG="+relay'), full ouput: http://pastebin.com/5b5srr2a A little snippet: 0042:Call ntdll.RtlEncodePointer(002c4620) ret=18002d9aa 0042:Ret ntdll.RtlEncodePointer() retval=c90b263e5a54eb02 ret=18002d9aa 0042:Ret PE DLL (proc=0x18002f27c,module=0x180000000 L"Automaton.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 0042:Ret KERNEL32.LoadLibraryA() retval=180000000 ret=7f77bb394167 0042:Call KERNEL32.GetProcAddress(180000000,7f77bb3950b0 "VSTPluginMain") ret=7f77bb394182 0042:Ret KERNEL32.GetProcAddress() retval=180012900 ret=7f77bb394182 Revive plugin: Automaton 0042:Call KERNEL32.UnhandledExceptionFilter(0023e7f0) ret=7f77bbf1fc1a wine: Unhandled page fault on read access to 0x0000022f at address 0x22f (thread 0042), starting debugger... fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module fixme:dbghelp:elf_search_auxv can't find symbol in module (goto pastebin for the rest / just scroll to bottom of page) If you want to take a look and/or test the code yourself (you need latest code): svn checkout svn://svn.code.sf.net/p/fsthost/code/trunk fsthost-code the source tree is small (like 2 seconds to download). Makefile64 is used to compile the test app (test.c). (just use 'make -f makefile64' from /src dir). alternatively, on sourceforge you can view the test64 app / source code online / here; http://sourceforge.net/p/fsthost/code/154/ (there are several commits following this one, but i believe this one is the most relevant. then to run it (from source dircetory); './test64.exe /path/to/64bitVSTplugin You can get a 'tester' 64bit VST (.dll) to load into test64.exe from here: http://kunz.corrupt.ch/products/tal-elek7ro anyway, any of your insights, help, tips, comments, etc would be both appreciated and helpful. thanks. Jordan

4 8

Re: includes: avoid confusing the preproccesor
by Alexandre Julliard 01 Apr '13

01 Apr '13

Austin English <austinenglish(a)gmail.com> writes: > See http://savannah.nongnu.org/bugs/?38557 > > ==== > > In fact, after some investigation, I found out that it's the correct > behavior as '0xfe+1' is considered as a number token by the > preprocessor. I've learned something today :) This has nothing to do with the preprocessor. It's a compiler bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winehtml5.drv: Added new HTML5 driver.
by Ken Thomases 01 Apr '13

01 Apr '13

On Apr 1, 2013, at 6:41 AM, Jacek Caban wrote: > There are still some missing features. Most notably, it lacks support > for system tray baloons. I know; that's, like, the hardest thing to do! Great work, though! Actually, since HTML is available everywhere, there's little reason for me to continue with the Mac driver. -Ken

4 3

Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)
by Henri Verbeet 01 Apr '13

01 Apr '13

On 1 April 2013 02:40, Sam Edwards <cfsworks(a)gmail.com> wrote: > I opted not to write ddraw tests. The existing ddraw window style tests > suggest that DirectDraw doesn't even set WS_VISIBLE when initializing a > (non-visible) window, which is very odd, so any new tests would have been > todo_wine anyway. Nonetheless, my changes to wined3d are minimal and > shouldn't affect ddraw's behavior. > I think it's ok for the tests to be todo_wine, but we do want ddraw coverage for this in the tests. > + ZeroMemory( &d3dpp, sizeof(d3dpp) ); > + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; > + d3dpp.Windowed = TRUE; > + d3dpp.BackBufferWidth = screen_width / 2; > + d3dpp.BackBufferHeight = screen_height / 2; > + hr = IDirect3DDevice9_Reset(device, &d3dpp); > + ok(hr == D3D_OK, "IDirect3DDevice9_Reset failed with %08x\n", hr); I think you'll want to use reset_device() here. (Although I also just notice 766e732fb changed that to use screen_width x screen_height instead of 640x480, which is perhaps a bit of an unfortunate choice. It's fine to change reset_device() to use screen_width / 2 x screen_height / 2, if needed.)

2 2

Re: [1/4] windowscodecs: Basic tests for tiff encoder options (try3)
by Ludger Sprenker 01 Apr '13

01 Apr '13

Is there anything wrong with my patches? The first one is marked as "Pending". Am Dienstag, 26. März 2013, 18:46:23 schrieb Ludger Sprenker: > Try3: > - Removed last named value initialization > - Do not check initial value of properties, if the > precondition/initial-type is not matching > (both pointed out by Vincent) > > Note: This was priviously a set of 5 patches, but the original part one has > already been committed. > > --- > dlls/windowscodecs/tests/converter.c | 145 > ++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+)

2 1

Re: dpnet: Increase reported buffer size
by Marvin 01 Apr '13

01 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24918 Your paranoid android. === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Problem about declarations of strcoll functions
by Jactry Zeng 01 Apr '13

01 Apr '13

Hi folks, I tried to implement a lot of strcoll function these days, and I meet some trouble when I added the declaration into include/msvcrt/*.h. With "grep coll *.spec" in dlls/msvcrt/ we can find there was a lot of strcoll function. Some of them was implemented and some of them not: @ cdecl ___lc_collate_cp_func() @ stub __lc_collate @ extern __lc_collate_cp MSVCRT___lc_collate_cp @ cdecl _mbscoll(str str) @ cdecl _mbscoll_l(str str ptr) @ cdecl _mbsicoll(str str) @ cdecl _mbsicoll_l(str str ptr) @ cdecl _mbsnbcoll(str str long) @ cdecl _mbsnbcoll_l(str str long ptr) @ cdecl _mbsnbicoll(str str long) @ cdecl _mbsnbicoll_l(str str long ptr) @ stub _mbsncoll(str str long) # stub _mbsncoll_l(str str long ptr) @ stub _mbsnicoll(str str long) # stub _mbsnicoll_l(str str long ptr) @ cdecl _strcoll_l(str str ptr) MSVCRT_strcoll_l @ cdecl _stricoll(str str) MSVCRT__stricoll @ cdecl _stricoll_l(str str ptr) MSVCRT__stricoll_l @ cdecl _strncoll(str str long) MSVCRT_strncoll_l @ cdecl _strncoll_l(str str long ptr) MSVCRT_strncoll @ cdecl _strnicoll(str str long) MSVCRT__strnicoll @ cdecl _strnicoll_l(str str long ptr) MSVCRT__strnicoll_l # stub _wcscoll_l(wstr wstr ptr) @ cdecl _wcsicoll(wstr wstr) MSVCRT__wcsicoll # stub _wcsicoll_l(wstr wstr ptr) @ cdecl _wcsncoll(wstr wstr long) MSVCRT__wcsncoll @ cdecl _wcsncoll_l(wstr wstr long ptr) MSVCRT__wcsncoll_l @ cdecl _wcsnicoll(wstr wstr long) MSVCRT__wcsnicoll # stub _wcsnicoll_l(wstr wstr long ptr) @ cdecl strcoll(str str) MSVCRT_strcoll @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll With "grep coll *.h" in include/msvcrt/ we can find some declarations of some strcoll function: crtdefs.h: unsigned int lc_collate_cp; mbstring.h:int __cdecl _mbscoll(const unsigned char*,const unsigned char*); mbstring.h:int __cdecl _mbsicoll(const unsigned char*,const unsigned char*); mbstring.h:int __cdecl _mbsnbcoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsnbicoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsncoll(const unsigned char*,const unsigned char*,size_t); mbstring.h:int __cdecl _mbsnicoll(const unsigned char*,const unsigned char*,size_t); string.h:int __cdecl _stricoll(const char*,const char*); string.h:int __cdecl strcoll(const char*,const char*); string.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); string.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t); string.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*); string.h:static inline int stricoll(const char* s1, const char* s2) { return _stricoll(s1, s2); } string.h:static inline int wcsicoll(const wchar_t* str1, const wchar_t* str2) { return _wcsicoll(str1, str2); } wchar.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); wchar.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t); wchar.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*); As we can see, _strcoll_l and _mbsnbcoll_l were implemented but they were not declared. Should we declare all of them? And whether the sequence was important? Thank you. -- Regards, Jactry Zeng

2 2

Re: mshtml: Fixed builtin getter call with arguments.
by Marvin 01 Apr '13

01 Apr '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24910 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH] wined3d: Add a registry key to configure buffer object placement
by Henri Verbeet 01 Apr '13

01 Apr '13

On 1 April 2013 10:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (wined3d_settings.placebo == PLACEBO_VIDMEM) > + { > + TRACE("Placing buffer %p in video memory\n", This); > + glHint(This->buffer_type_hint, GL_FASTEST); > + } > + I'm going to go out on a limb and call April fools on this. The state of GL drivers being what it is though, there's a slight chance such a thing actually exists, in which case please link to the documentation instead. Somewhat related, I do actually have a patch to change the usage hint for static vertex buffers to GL_STATIC_DRAW_ARB in my tree, which should actually make the driver more likely to initially place those in VRAM instead of GTT. (It mostly just helps with initial fps after a VB is just created, most drivers eventually figure out the optimal placement anyway and migrate the buffer to vram.)

1 0

Float printf precision
by Stefan Dösinger 31 Mar '13

31 Mar '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Henri, While overhauling the patch to hardcode local constants in the shader code I came across the TRACEs in wined3d_device_set_{vs,ps}_consts_f, which print the floats with %.8e. You changed this from %f in 979e3744f7721bef9e88fd671dfd7591c9f85392. I was curious how you ended up with 8 digits. My thinking was that 32 bit floats have a 23 bit mantissa, and one digit in the printout encodes lb(10) bits - so you need ~6,9 digits to encode the mantissa, which rounds up to 7. Thinking further, %.6e should do the job as well, as there's one additional digit leading the decimal. Is my thinking correct, or am I missing something? Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRWAiyAAoJEN0/YqbEcdMw+4AQAIW57gxqJJcPEKzS35K4R++Q aMy1rma7JV4/cUmRIqkmOROc6Y3T2bz7x3e12mNpLVvI9YUBdaZKsofuBJk9QCtL R6nWL266dLc3aRdIFazwjxK6GmohqjxoLidpCAPSXGkekjw48DqhA+5fdXO2YYm/ 2g1Fhyy/cpi6BN2AUh760YNy3ojk/x9eH25oTmifFxCUbWlhYNGsIVt8OTTW9YBE RnQyyoO2lPjNi5mlNIqoSkkYriG5m97nS8bSMXvu9BjKW8rSmmErLGPf2zDL7Big wdibKxbXaSSx74upJaOTLjoOx04sqoi4SuPnX/55ftFKj7s2SeoFJaOUwgdNJoN+ UxKcd0HzfaXBi/VikYvtfMd0+SLA8wFIVjrJsWeBwgNU9cEAA3OiRFPWyizZCPqu 4UQOSnxuK6LZ7Ke58ikcG6JqMVTye8iTeEmr6r3NhkRdmCKrFbVGmJ1POb8Q26Hu q2yQBHq2L5CZ0Vx7fruvqq9Ap8auI/l5B6tneDM/RUdvpWxQTJneVRpSqIE50ZmW U3XH2cx4eLaEGJnSnHBgxnqgSAmcVTJEkFHtd8tCiqsPcnkw2g3Ng3gQZhjkDJ45 ZxvXNxVUl3B899Y1CwFd3FVJhKQq2jFS0NQvNQYZXhx0djZ2ok8rvtmoJzTaNN1s SMfTtZDHxHFtluASd6zJ =7CAL -----END PGP SIGNATURE-----

2 1

Re: wined3d: Properly handle WS_VISIBLE and WS_EX_TOPMOST style flags on fullscreen windows.
by Henri Verbeet 31 Mar '13

31 Mar '13

On 29 March 2013 03:31, Sam Edwards <cfsworks(a)gmail.com> wrote: > Note that the tests are NOT (primarily) intended to make sure that > WS_VISIBLE and WS_EX_TOPMOST are still set. The main purpose of this patch > is to fix a slightly more serious bug: > > - Create a window without WS_VISIBLE. > - Create a fullscreen Direct3D device. > - wined3d applies its own flags (including WS_VISIBLE) to the window, to > make it fullscreen. > - Reset the device back to windowed mode. > - Because wined3d_device_setup_fullscreen_window didn't see the window had > WS_VISIBLE, wined3d_device_restore_fullscreen_window won't restore the > style. > > This patch corrects that behavior, and the window restores back to its > original style as on Windows. > I think the idea is basically ok, but I do have some comments: I think test_window_style() is a more appropriate place for the tests, and you should add them to the variants in ddraw as well. Ddraw applications in particular are very fragile in this regard. Note that the test_window_style() tests are fairly similar to what your tests do, except that they don't test restoring the window as such. That test also shows that we're actually not supposed to touch the styles at all, but that's hard to make work without calling into winex11. > - SetWindowPos(window, HWND_TOP, 0, 0, w, h, SWP_FRAMECHANGED | SWP_SHOWWINDOW | SWP_NOACTIVATE); > + SetWindowPos(window, HWND_TOPMOST, 0, 0, w, h, SWP_FRAMECHANGED | SWP_SHOWWINDOW | SWP_NOACTIVATE); This is really a separate change. > + device->style ^= (device->style^style) & WS_VISIBLE; Spaces around the (second) ^, please.

2 2

[website try2] Simplified Chinese translation for release 1.5.27
by Jactry Zeng 31 Mar '13

31 Mar '13

1 0

Windows API on Linux
by Abhinav Jangda 30 Mar '13

30 Mar '13

Hello everyone, I'm working on a project which aims to develop a port of Windows API on Linux, so that programs written using Windows API could directly be compiled and executed on Linux with its native look and feel. Anyone, interested in working on this project. I think some Wine developers will be as they would be having a good knowledge of Windows API. If anyone interested then please let me know. Thank You :)

4 3

Re: [website] Simplified Chinese translation for release 1.5.27
by Hin-Tak Leung 30 Mar '13

30 Mar '13

--- On Sat, 30/3/13, Jactry Zeng <jactry92(a)gmail.com> wrote: From: Jactry Zeng <jactry92(a)gmail.com> Subject: Re: [website] Simplified Chinese translation for release 1.5.27 To: htl10(a)users.sourceforge.net Cc: "Wine Devel" <wine-devel(a)winehq.org>, "Qian Hong" <fracting(a)gmail.com> Date: Saturday, 30 March, 2013, 10:41 2013/3/30 Hin-Tak Leung <htl10(a)users.sourceforge.net> > > > I think both are terrible translations but could not think of a better alternative off my head, so I went to consult google translate. It defaults to 運行時庫 for "runtime library" but allow me to choose a few other alternatives, among which is > > "執行階段程式庫" > > Don't you think that's much better!? Hi Hin-Tak, Thanks for your review. I also think both "运行时" or "运行时库" was not best translation. But I have seen a lot of documents in Simplified Chinese translated it in this way. Maybe it was not too accurate... And in my opinion, "运行时" meaning some function, "运行时库" meaning a runtime library. To be honest, I think a lot of Chinese translations of technical topics (or even not-technical topics) are quite poor, and little beyond a word-for-word substitution. run -> 运行 ("to convey/process", the more common use of "run", of 'using your legs faster than walking' is obviously wrong) time -> 时 ("hour", "during") library -> 库 ("storage container", the more common use of "library" to mean "collection of books" obviously wrong). Whereas "執行階段程式庫" meaning "the program/routine library of/in the execute stage" is quite a lot more fitting to what 'runtime library' actually means. As I was saying, one needs to be vigilant about automated translations being 'not quite correct'. I suspect it is a much abused practice in China, so you see the same (mis-)usage over and over. There are entire web sites devoted to poorly translated public signs in China and making fun of them. It is quite educational - one gets lazy and and accepts the occasional poor translation, but seeing similar but slightly different mistakes collected in a large quantity really makes one think. 2013/3/30 Jactry Zeng <jactry92(a)gmail.com> > > I translated it as "高质量" meaning a picture have hight resolution. Here has a typo, hight -> higher .... -- Regards, Jactry Zeng

1 0

Re: [website] Simplified Chinese translation for release 1.5.27
by Qian Hong 30 Mar '13

30 Mar '13

Hi Jactry, 2013/3/30 Jactry Zeng <jactry92(a)gmail.com>: > + <li>一些 C 运行时的改进。</li> I think it is better to translate "C runtime" to “C 运行时库“ rather than just ”C 运行时“。 + <li>为内建程序提供更高质量的图标。</li> Large icon means 大图标，not 高质量图标。You can verify this by the git commits。 Thanks for the work. -- Regards, Qian Hong - http://www.winehq.org

3 4

Re: [PATCH 1/3] jscript: Use helpers to access string buffers in jsregexp.c.
by Alexandre Julliard 29 Mar '13

29 Mar '13

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/jsregexp.c | 114 > +++++++++++++++++++++++++++++++----------------- > 1 file changed, 73 insertions(+), 41 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 run.c:1804: Test failed: expected global_success_d run.c:1805: Test failed: expected global_success_i run.c:1807: Test failed: parse_script failed: 80004005 make: *** [run.ok] Error 18 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 4]: Implement D3DXSHEvalSphericalLight
by Alexandre Julliard 29 Mar '13

29 Mar '13

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > From bb40ba80a24a954d21c44cbe55b4b9c79e2087c5 Mon Sep 17 00:00:00 2001 > From: "nozomi.kodama" <nozomi.kodama(a)yahoo.com> > Date: Wed, 27 Mar 2013 22:38:51 -1000 > Subject: d3dx9: Implement D3DXSHEvalSphericalLight It still fails the same way... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcp110: Add VS2012 C/C++ runtime
by Piotr Caban 29 Mar '13

29 Mar '13

On 03/28/13 23:22, Stefan Leichter wrote: > --- > configure.ac | 1 + > dlls/msvcp110/Makefile.in | 5 + > dlls/msvcp110/msvcp110.c | 37 + > dlls/msvcp110/msvcp110.spec | 3900 > +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 3943 insertions(+), 0 deletions(-) > create mode 100644 dlls/msvcp110/Makefile.in > create mode 100644 dlls/msvcp110/msvcp110.c > create mode 100644 dlls/msvcp110/msvcp110.spec You can use tools/make_specfiles script to generate forwards to other msvcpXX dlls. The script will generate big parts of the spec file differently (because it prefers to forward to msvcp90, not to msvcp100).

1 0

Re: [PATCH 1/3] extrac32: Implement more strict command line processing.
by Sergey Guralnik 29 Mar '13

29 Mar '13

On 2013-03-26 10:17, Sergey Guralnik wrote: > Is some problem with this series? -- Sergey

1 0

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent (try 2)
by Alexandre Julliard 28 Mar '13

28 Mar '13

André Hentschel <nerv(a)dawncrow.de> writes: > + /* the bias could be because the app wanted something like a "red shift" > + * like when you're hit in Quake, but XVidMode doesn't support it, > + * so we have to reject a significant bias */ Clearly gdi32 doesn't care about XVidMode. > @@ -1325,6 +1405,18 @@ BOOL WINAPI SetDeviceGammaRamp(HDC hDC, LPVOID ptr) > if (GetObjectType( hDC ) != OBJ_MEMDC) > { > PHYSDEV physdev = GET_DC_PHYSDEV( dc, pSetDeviceGammaRamp ); > + struct gamma_ramp > + { > + WORD red[256]; > + WORD green[256]; > + WORD blue[256]; > + } *ramp = ptr; > + > + if (!check_gamma_ramp(ramp->red) || > + !check_gamma_ramp(ramp->green) || > + !check_gamma_ramp(ramp->blue)) > + return FALSE; This can't work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: Track drawn surface rect to reduce black flicker for new or resized windows.
by Ken Thomases 28 Mar '13

28 Mar '13

On Mar 27, 2013, at 3:31 PM, Ken Thomases wrote: > dlls/winemac.drv/macdrv.h | 12 +++++++++++- > dlls/winemac.drv/surface.c | 16 ++++++++++++++-- > dlls/winemac.drv/window.c | 17 ++--------------- > 3 files changed, 27 insertions(+), 18 deletions(-) > > <0001-winemac-Track-drawn-surface-rect-to-reduce-black-fli.patch> Please don't commit this. I've thought of a different approach. -Ken

1 0

Re: user32: ImmProcessKey is only called on WM_KEYDOWN and if the message is being removed
by Dmitry Timoshkov 28 Mar '13

28 Mar '13

Aric Stewart <aric(a)codeweavers.com> wrote: > Worked out with testing on Japanese windows XP. Resolves issues with > keystrokes and accelerators in menus when the IME is active. You should really start adding the tests and base your patches on test results instead of some sort of speculation. -- Dmitry.

3 4

Re: winemac: Null-terminate an snprintf-ed key name buffer in case of short buffer.
by Per Johansson 28 Mar '13

28 Mar '13

On Wed, Mar 27, 2013 at 7:22 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- This has probably been discussed before, but shouldn't snprintfW be safe against this kind of thing, the way POSIX snprintf is? Regards, -- Per Johansson

2 1

Linker error when improving GetLargestConsoleWindowSize
by Hugh McMaster 28 Mar '13

28 Mar '13

Hi, I've written a function to determine the largest possible screen buffer that wineconsole is able to display. This function replaces the hard-coded constants listed in both instances of GetLargestConsoleWindowSize in dlls/kernel32/console.c. [snip] #include <windows.h> #include <winuser.h> [snip] COORD GetLargestConsoleWindowSize_helper(HANDLE hConsoleOutput) { RECT workarea; COORD console_fontsize; COORD max_console; SystemParametersInfoA(SPI_GETWORKAREA, 0, &workarea, 0); console_fontsize = GetConsoleFontSize(hConsoleOutput, 0); max_console.X = (workarea.right / console_fontsize.X) - 6; max_console.Y = (workarea.bottom / console_fontsize.Y) - 6; return max_console; } While dlls/kernel32/console.c compiles, I'm having trouble with the final compile-time linking. It seems that SystemParametersInfoA is an undefined reference, but windows.h and winuser.h are included in console.c. This is the terminal output: make[1]: Entering directory `/home/hugh/wine-1.5.26/dlls/kernel32' [snip] ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./kernel32.spec actctx.o atom.o change.o comm.o computername.o console.o cpu.o debugger.o editline.o environ.o except.o fiber.o file.o format_msg.o heap.o kernel_main.o lcformat.o locale.o lzexpand.o module.o nameprep.o oldconfig.o path.o powermgnt.o process.o profile.o resource.o string.o sync.o tape.o term.o thread.o time.o toolhelp.o version.o virtual.o volume.o wer.o locale_rc.res version.res winerror.res -nodefaultlibs -Wb,-F,KERNEL32.dll -Wl,--image-base,0x7b800000 -o kernel32.dll.so -lwinecrt0 -lntdll ../../libs/port/libwine_port.a console.o: In function `GetLargestConsoleWindowSize_helper': /home/hugh/wine-1.5.26/dlls/kernel32/console.c:1377: undefined reference to `SystemParametersInfoA' /usr/bin/ld: kernel32.dll.so: hidden symbol `SystemParametersInfoA' isn't defined /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status winegcc: gcc failed make[1]: *** [kernel32.dll.so] Error 2 Unfortunately, my knowledge of C is terrible, so I'm not sure what to do from here. If someone could help me solve this, I'd appreciate it. If it helps, I'm able to use winegcc to build a simple Windows executable using SystemParametersInfo without any problems. Thank you in advance, Hugh

3 4

Re: [1/3] kernel32: Set GetLargestConsoleWindowSize based on screen resolution
by Ken Thomases 27 Mar '13

27 Mar '13

On Mar 27, 2013, at 6:41 AM, Hugh McMaster wrote: > This patch modifies the dlls/kernel32 Makefile.in to (1) compile a new source file (screensize.c) (patch 3/3) and (2) add -lX11 to the ExtraDllFlags line. This approach is untenable. Kernel32 can't be made to depend on X11. It has to still work when X11 isn't available. Also, X11 is just one possible graphics/windowing system that Wine can use, so it's not always the right authority to consult about screen size. Eric Pouech suggested in the other thread to calculate the console window size in wineconsole, at which point you can use user32 and SystemParametersInfo(). Finally, your patch series is broken in the sense that each patch in the series must still be able to compile. You introduce a dependency on screensize.c in the first patch but don't actually provide that source file until the third. -Ken

2 2

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight
by Alexandre Julliard 27 Mar '13

27 Mar '13

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > From 3d331ffa908f69ca58686b4601effbb16d89d1da Mon Sep 17 00:00:00 2001 > From: "nozomi.kodama" <nozomi.kodama(a)yahoo.com> > Date: Thu, 14 Mar 2013 18:34:48 -1000 > Subject: d3dx9: Implement D3DXSHEvalSphericalLight It fails on 64-bit: ../../../../wine/tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so ../../../../wine/dlls/d3dx9_36/tests/math.c && touch math.ok math.c:2930: Test failed: Red: case 1, order 5: expected[20] = 0.000529, received 0.000529 math.c:2939: Test failed: Green: case 1, order 5: expected[20] = 0.000809, received 0.000809 math.c:2949: Test failed: Blue: case 1, order 5: expected[20] = 0.001089, received 0.001089 math.c:2930: Test failed: Red: case 1, order 6: expected[20] = 0.000529, received 0.000529 math.c:2939: Test failed: Green: case 1, order 6: expected[20] = 0.000809, received 0.000809 math.c:2949: Test failed: Blue: case 1, order 6: expected[20] = 0.001089, received 0.001089 math.c:2930: Test failed: Red: case 2, order 5: expected[20] = -0.000715, received -0.000714 math.c:2939: Test failed: Green: case 2, order 5: expected[20] = -0.001093, received -0.001093 math.c:2949: Test failed: Blue: case 2, order 5: expected[20] = -0.001471, received -0.001471 math.c:2930: Test failed: Red: case 2, order 6: expected[20] = -0.000715, received -0.000714 math.c:2939: Test failed: Green: case 2, order 6: expected[20] = -0.001093, received -0.001093 math.c:2949: Test failed: Blue: case 2, order 6: expected[20] = -0.001471, received -0.001471 make: *** [math.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools/wine.inf: add HKLM\\System\\CurrentControlSet\\Services\\Eventlog\\Application registry key
by Alexandre Julliard 27 Mar '13

27 Mar '13

Austin English <austinenglish(a)gmail.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=22026 It breaks the tests: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so eventlog.c && touch eventlog.ok eventlog.c:524: Tests skipped: We don't have a backup eventlog to work with eventlog.c:457: Tests skipped: No records in the 'Application' log eventlog.c:835: Test failed: Expected 1 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 2 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 3 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 4 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 5 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 6 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 7 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 8 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 9 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:835: Test failed: Expected 10 records, got 0 eventlog.c:840: Test failed: Expected oldest to be 1 or higher, got 0 eventlog.c:858: Test failed: Expected 10 records, got 0 eventlog.c:863: Tests skipped: No events were written to the eventlog eventlog.c:1086: Test failed: Expected an eventlog file eventlog.c:1113: Test succeeded inside todo block: Could not delete the registry tree : 0 eventlog.c:1120: Test succeeded inside todo block: Expected MoveFileEx to succeed: 1 make: *** [eventlog.ok] Error 24 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wiki is down
by Rosanne DiMesio 27 Mar '13

27 Mar '13

I'm getting an "Internal Server Error" message when I try to access the wiki. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 5

Re: [PATCH 1/3] msvcr90: Forward some functions directly to ntdll
by Alexandre Julliard 27 Mar '13

27 Mar '13

Piotr Caban <piotr(a)codeweavers.com> writes: > These functions are currently forwarded from msvcr90 to msvcrt which > forwards to ntdll. Naver LINE is crashing while trying to call them. Does it work if you remove the forward in msvcrt instead? That would be a better fix. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: advapi32: Do not terminate a regular program if it calls StartServiceCtrlDispatcher.
by Alexandre Julliard 27 Mar '13

27 Mar '13

Alexander Morozov <amorozov(a)etersoft.ru> writes: > @@ -592,7 +586,26 @@ BOOL WINAPI StartServiceCtrlDispatcherA( const SERVICE_TABLE_ENTRYA *servent ) > services[i] = info; > } > > - service_run_main_thread(); > + disp = HeapAlloc( GetProcessHeap(), 0, sizeof(*disp) ); > + > + if (!(disp->manager = OpenSCManagerW( NULL, NULL, SC_MANAGER_CONNECT ))) > + { > + ERR("failed to open service manager error %u\n", GetLastError()); > + HeapFree( GetProcessHeap(), 0, disp ); > + return FALSE; > + } > + > + disp->pipe = service_open_pipe(); > + if (disp->pipe == INVALID_HANDLE_VALUE) > + { > + WARN("failed to create control pipe error %u\n", GetLastError()); > + CloseServiceHandle( disp->manager ); > + HeapFree( GetProcessHeap(), 0, disp ); > + SetLastError( ERROR_FAILED_SERVICE_CONTROLLER_CONNECT ); > + return FALSE; > + } > + > + service_run_main_thread( disp ); There's no reason to duplicate that code, just do it in service_run_main_thread instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Fix handling of mailto URIs in CoInternetCombineUrlEx.
by Jacek Caban 27 Mar '13

27 Mar '13

Hi Hans, On 03/27/13 10:43, Hans Leidekker wrote: > --- > dlls/urlmon/tests/uri.c | 63 +++++++++++++++++++++++++++++++++++++++++++---- > dlls/urlmon/uri.c | 15 ++++++++--- > 2 files changed, 69 insertions(+), 9 deletions(-) > > diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c > index e5faa81..29bd859 100644 > --- a/dlls/urlmon/tests/uri.c > +++ b/dlls/urlmon/tests/uri.c > @@ -7005,8 +7005,61 @@ static const uri_combine_test uri_combine_tests[] = { > {URL_SCHEME_FILE,S_OK}, > {URLZONE_INVALID,E_NOTIMPL} > } > + }, > + { "http://winehq.org",0, > + "mailto://",0, > + 0,S_OK,FALSE, You are changing parts that are not combining-specific. Since the relative URI is absolute in this case, there is not much happening other than parsing the URI during combining. Those tests are fine, but please add also tests for CreateUri, see uri_tests array. This should be straightforward based on tests you already wrote. > diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c > index 0f6ee31..c6b5166 100644 > --- a/dlls/urlmon/uri.c > +++ b/dlls/urlmon/uri.c > @@ -422,7 +422,7 @@ static inline BOOL is_hierarchical_uri(const WCHAR **ptr, const parse_data *data > else if(is_hierarchical_scheme(data->scheme_type) && (*ptr)[0] == '\\' && (*ptr)[1] == '\\') { > *ptr += 2; > return TRUE; > - } else if(check_hierarchical(ptr)) > + } else if(data->scheme_type != URL_SCHEME_MAILTO && check_hierarchical(ptr)) > return TRUE; > > *ptr = start; > @@ -2980,6 +2980,9 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > const BOOL known_scheme = data->scheme_type != URL_SCHEME_UNKNOWN; > const BOOL is_file = data->scheme_type == URL_SCHEME_FILE; > const BOOL is_mk = data->scheme_type == URL_SCHEME_MK; > + const BOOL is_javascript = data->scheme_type == URL_SCHEME_JAVASCRIPT; > + const BOOL is_mailto = data->scheme_type == URL_SCHEME_MAILTO; > + DWORD offset = 0; > > if(!data->path) { > uri->path_start = -1; > @@ -2996,7 +2999,7 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > } > > /* For javascript: URIs, simply copy path part without any canonicalization */ > - if(data->scheme_type == URL_SCHEME_JAVASCRIPT) { > + if(is_javascript) { > if(!computeOnly) > memcpy(uri->canon_uri+uri->canon_len, data->path, data->path_len*sizeof(WCHAR)); > uri->path_len = data->path_len; > @@ -3007,7 +3010,11 @@ static BOOL canonicalize_path_opaque(const parse_data *data, Uri *uri, DWORD fla > /* Windows doesn't allow a "//" to appear after the scheme > * of a URI, if it's an opaque URI. > */ > - if(data->scheme && *(data->path) == '/' && *(data->path+1) == '/') { > + if (is_mailto && *(data->path) == '/' && *(data->path+1) == '/') { > + if (!*(data->path+2)) uri->path_start = -1; > + offset += 2; I think this should be done in parsing phrase, not during canonicalization. Jacek

1 0

Re: comctl32: Make an attempt to update notification handle
by Dmitry Timoshkov 27 Mar '13

27 Mar '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + case WM_WINDOWPOSCHANGING: > + { > + HWND parent = GetParent(hwnd); > + if (parent) infoPtr->hwndNotify = parent; > + return DefWindowProcW(hwnd, uMsg, wParam, lParam); > + } What if an application subclasses tab and doesn't pass WM_WINDOWPOSCHANGING to the original proc? Why not just call GetParent() every time when a notification is being sent? -- Dmitry.

3 7

Re: iads.idl: Add missing interfaces
by Nikolay Sivov 27 Mar '13

27 Mar '13

On 3/27/2013 09:05, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > iads.idl: Add missing interfaces > > > Best Regards > Alistair Leslie-Hughes > +typedef enum > +{ > + ADS_SEARCHPREF_ASYNCHRONOUS = 0, > + ADS_SEARCHPREF_DEREF_ALIASES = 1, You don't need to do it manually, widl will generate values for each entry.

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight
by Matteo Bruni 27 Mar '13

27 Mar '13

2013/3/15 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > Patch series is fine to me.

4 3

Re: msvcr110: forward __crtSetUnhandledExceptionFilter to kernel32.SetUnhandledExceptionFilter
by Alexandre Julliard 26 Mar '13

26 Mar '13

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec > index 4a94dbe..babfc67 100644 > --- a/dlls/msvcr110/msvcr110.spec > +++ b/dlls/msvcr110/msvcr110.spec > @@ -928,7 +928,7 @@ > @ stub -arch=i386,win64 __crtLCMapStringEx > @ cdecl __crtLCMapStringW(long long wstr long ptr long long long) msvcrt.__crtLCMapStringW > @ stub -arch=i386,win64 __crtSetThreadStackGuarantee > -@ stub __crtSetUnhandledExceptionFilter > +@ stdcall __crtSetUnhandledExceptionFilter(ptr) kernel32.SetUnhandledExceptionFilter A quick test shows that the crt functions are cdecl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Mac driver status: ready for contributions
by Ken Thomases 26 Mar '13

26 Mar '13

Hi, With my latest set of patches, the Mac driver in Wine is up to speed with what's in CrossOver 12 (plus some extra goodies). Of course, that's not to say that the Mac driver is done, but if you were holding off getting involved because you figured big chunks of already-done work were pending, that's no longer the case. From here on out, all work on the Mac driver will be new coding, so it's ready for anybody to contribute. Testing is one excellent way of contributing. I encourage any Mac Wine users to enable the Mac driver, test your favorite programs, and file bugs for any new problems (and there _will_ be bugs to find). Please try to distinguish between general Wine bugs which also happen with the X11 driver vs. bugs which only happen with the Mac driver. Currently, you have to set a registry key to enable the Mac driver: [HKEY_CURRENT_USER\Software\Wine\Drivers] "Graphics"="mac,x11" Swap the order to "x11,mac" – or just remove the "Graphics" value altogether – to revert to using the X11 driver. Aside from bugs, the Mac driver is pretty close to complete. Here's a list of stuff that I know is incomplete. Not all of these things are hard. In fact, I expect some will be quite easy and the only reason I didn't get to them was to get broader coverage of general areas of functionality by CrossOver 12's release. * The Quit menu item should do a graceful shutdown of the Windows process rather than abruptly terminating it. Same for requests to quit from the system such as during logout, restart, or shutdown. * A registry setting to govern whether full-screen at full-resolution should capture the display (which will disable active screen corners but also application switching and UI overlays). Full-screen at other resolutions already captures the displays. * A registry setting to govern whether the Option/Alt key sends an Alt keystroke instead of accessing additional characters from the Mac keyboard layout. * Support for maximizing windows. * Reduce or eliminate flashes of black before windows (re)draw. * Support for Mac input methods (Asian languages, press-and-hold, keyboard and character viewers). * Rework the Graphics tab of winecfg. Most of it doesn't apply to the Mac driver. As Mac-driver-specific registry settings are implemented, they may need to be revealed in winecfg. * Maybe implement a Cocoa Preferences dialog for the Mac driver's settings as an alternative to putting them in winecfg. * Activating a Wine GUI process all of whose windows are minimized should maybe unminimize one. * Add some additional standard items to the Mac menus, such as Hide Wine, Hide Others, and Show All. * Support for metafile clipboard formats. * Support for mouse capture. * Improved system tray functionality like detecting mouse moves and right-clicks and presenting notification balloons. * Support localization of the few UI strings in the Mac driver (basically the menu item titles). (Charles Betts has already submitted work to support disabling and reenabling the screen saver. As I understand it, Alexandre has some unspecified ideas about how he wants to change the driver interface for the SystemParametersInfo entry point.) Cheers, Ken

3 3

Re: gdi32: Printer drivers don't use the character extra spacing if lpdx is supplied.
by Alexandre Julliard 26 Mar '13

26 Mar '13

Huw Davies <huw(a)codeweavers.com> writes: > Ideally this would be done in wineps.drv, but by that point the conversion to device units would cause rounding errors. What about GetTextExtent functions? Do they need this too? Some test cases would be nice. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: explorer: Create desktop window hidden and only show it if it wins the race.
by Dmitry Timoshkov 26 Mar '13

26 Mar '13

Ken Thomases <ken(a)codeweavers.com> wrote: > + ShowWindow( hwnd, SW_SHOW ); > SetWindowLongPtrW( hwnd, GWLP_WNDPROC, (LONG_PTR)desktop_wnd_proc ); > SendMessageW( hwnd, WM_SETICON, ICON_BIG, (LPARAM)LoadIconW( 0, MAKEINTRESOURCEW(OIC_WINLOGO))); > if (name) set_desktop_window_title( hwnd, name ); You can postpone calling ShowWindow() after setting window text and icon, since they are drawn as part of a non-client area, and changing them forces another set of redraws. -- Dmitry.

2 1

[1/3] Make mac driver the default on OS X
by Joerg-Cyril.Hoehle＠t-systems.com 26 Mar '13

26 Mar '13

Hi, Ken Thomases wrote: >I think that the Mac driver should not be made the default >until OpenGL and clipboard support are in. Exactly :-( Following Josh DuBois explanation about HKCU/Software/Wine/Drivers "Graphics"="mac,x11" I decided to give it a try over the week-end and was very disappointed to see that seemingly *not any* app would run. It took me some time to understand that they all want graphics. Please don't waste the user's time when such "basics" don't work. What you can do is post to wine-devel and the user forum, asking for people to test your work. That would be polite. Josh DuBois wrote: >I propose an environment variable, WINEDRIVERLOADORDER Too generic. Include "DISPLAY" into the name, if at all, e.g. WINEDISPLAYDRIVER, or "GRAPHICS" as in the registry. The winepulse driver might face similar issues. I have not looked how Maarten thinks that it may coexist nicely with winealsa. Bug report: Toying around with built-in notepad, clock, winhlp32, I noticed that notepad and winhlp32 are not resizable, whereas the system preferences "control" is. By comparison, with the x11 driver, notepad's window is resizable even though it has no triangle widget at the bottom left. Also, the virtual desktop seems gone or not yet implemented. This is a key requirement for enough apps that do not handle today's huge resolutions. Another annoyance was that there's no HIDE function or short cut and some dialogues do not provide the orange button (middle one) to iconify the window. As a result, those pesky windows clutter your screen. That alone is enough reason to me a reason not to use that driver. It is not acceptable that one cannot get rid of a set of windows! Example: wine control, then navigate to the root CA certificates. The menu bar sometimes was refreshed badly, causing some texts therein to be displayed twice, shifted by a few pixels, or with varying fonts. Regards, Jörg Höhle

4 10

Re: [4/5] hlink: Implement IHlinkBrowseContext_GetHlink()
by Marvin 25 Mar '13

25 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24822 Your paranoid android. === W2KPROSP4 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W2K3R2SESP2 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W2K8SE (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W7PROX64 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === TEST64_W7SP1 (32 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === W7PROX64 (64 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005 === TEST64_W7SP1 (64 bit browse_ctx) === browse_ctx.c:61: Test failed: got 0x80004005 browse_ctx.c:64: Test failed: got 0x80004005

1 0

Re: ntdll: Improve stub for FileFsAttributeInformation in NtQueryVolumeInformationFile
by Marvin 24 Mar '13

24 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24819 Your paranoid android. === W2KPROSP4 (32 bit file) === file.c:1675: Test failed: got 8 === W2K3R2SESP2 (32 bit file) === file.c:1675: Test failed: got 8 === W2K8SE (32 bit file) === file.c:1675: Test failed: got 8 === W7PROX64 (32 bit file) === file.c:1675: Test failed: got 8 === TEST64_W7SP1 (32 bit file) === file.c:1675: Test failed: got 8 === W7PROX64 (64 bit file) === file.c:1675: Test failed: got 8 === TEST64_W7SP1 (64 bit file) === file.c:1675: Test failed: got 8

1 0

Re: winemac: Calculate surface rect correctly in macdrv_UpdateLayeredWindow().
by Ken Thomases 22 Mar '13

22 Mar '13

On Mar 22, 2013, at 1:21 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/window.c | 33 ++++++++++++++++----------------- > 1 files changed, 16 insertions(+), 17 deletions(-) > > <0001-winemac-Calculate-surface-rect-correctly-in-macdrv_U.patch> Hmm. On further consideration, I'm not sure this is right. I think the intent was for the window surface of a ULW window to have a full surface even if it's partially off-screen. So, perhaps macdrv_WindowPosChanging() needs to use the same calculation as macdrv_UpdateLayeredWindow() for that kind of window so the surface rect doesn't keep ping-ponging. Also, the same issue exists in the X11 driver. I'll have to discuss with Alexandre when he gets back. -Ken

1 0

Re: [PATCH 4/5] winemac: Implement rudimentary support for system tray icons as Mac status items.
by C.W. Betts 22 Mar '13

22 Mar '13

On Mar 17, 2013, at 9:40 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > Doesn't support right-clicks, mouse moves, or notification balloons. Notification balloons can probably be done using either Notification Center or Growl, but either due to an out-of-date version of Growl in Twitter or a bug in Growl itself, clicking on the Growl notification doesn't bring Twitter to the front for me. > --- > dlls/winemac.drv/Makefile.in | 2 + > dlls/winemac.drv/cocoa_status_item.m | 175 +++++++++++++++++ > dlls/winemac.drv/event.c | 5 + > dlls/winemac.drv/image.c | 2 +- > dlls/winemac.drv/macdrv.h | 3 + > dlls/winemac.drv/macdrv_cocoa.h | 13 ++ > dlls/winemac.drv/systray.c | 358 ++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/winemac.drv.spec | 3 + > 8 files changed, 560 insertions(+), 1 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_status_item.m > create mode 100644 dlls/winemac.drv/systray.c > > <0004-winemac-Implement-rudimentary-support-for-system-tra.patch>

4 8

Parameterizing the places Wine suggests people report bugs
by Josh DuBois 22 Mar '13

22 Mar '13

Hi all, There are a couple of places wine suggests that people report bugs to wine-devel. The crash reporting dialog in winedbg suggests this, and a couple of places in code refer to wine-devel(a)winehq.org in error messages. The configure script has a PACKAGE_BUGREPORT macro which could be used to allow someone building wine to redirect those errors somewhere else. At least for wine's crash dialog, an alternate approach for a repackager to redirect bug reports would be to read the url / email address for where to send bugs from the registry. Would Wine accept a patch for making winedbg read the 'destination' for bug reports from the registry or some other runtime variable? Or would the project prefer to have all the bug reports routed directly to winehq, so that a repackager who wants to re-route bugs would have to build that facility on its own?

2 1

Re: gdi32: Copy gamma ramp validation from winex11 to make it driver independent
by Dmitry Timoshkov 22 Mar '13

22 Mar '13

André Hentschel <nerv(a)dawncrow.de> wrote: > - this was done for the mac driver > - i tried to follow the file-style, except of the original variable naming The ERRs should be downgraded to WARNs or even TRACEs, there is no point to loudly complain on application input. -- Dmitry.

1 0

[GSoC] My proposal for GSoC 2013
by Gediminas Jakutis 21 Mar '13

21 Mar '13

Hello! My name is Gediminas Jakutis. I study Informatics Engineering [bachelor / undergraduate] at Kaunas University of Technology, second year. I wish to try out GSoC for the first time by helping to improve Wine. My primary programming language is C. I am self-taught in C, but I believe my knowledge is good enough. I am quite familiar with Wine - I use it and experiment with it for many years now. I am subscribed to and read wine-devel for more than a year. I browse through Wine's source code once in a while out of curiosity. Thus, I have some knowledge of its structure. Sadly, I have not written any patches for Wine yet. Mostly due to lack of confidence. For GSoC, I am suggesting my own idea. In case this idea is not good, I am open to changing it, thinking of a new one, or adopting one. My idea: I have noticed that Wine's virtual desktop feature is very limited - if the first program on a prefix starts without a virtual desktop, all programs launched during the same session also start without a VD, disregarding any VD settings and/or requests with environment variables. And vice versa - if the first program starts inside a VD, all other programs in that sessions start in the VD. Often, this can be worked around by using separate Wine prefixes. Yet sometimes, this workaround is not possible. A good example: steam and games that only run properly in a VD. This forces the user to start steam in a VD and makes steam itself unusable while a game is running, especially if the game does not support the steam overlay. I would like to fix this limitation and make it possible to properly choose to run different programs on one prefix with or without a VD regardless what was chosen to programs already running in that prefix. I can already see this requiring changes in the winecfg utility, by the way. In case this turns out to be too easy of a project, I could implement some way to perform "alt-tabbing" between programs in a VD and/or an optional (enable-able in winecfg) rudimentary taskbar for changing/checking focus. I am very excited about participating in GSoC. And even more excited about starting to contribute to Wine by writing patches! Regardless if I get accepted or not, I wish to make Wine better. Thus, expect me to start submitting patches in the future even if I do not get accepted. ;] Sincerely, Gediminas Jakutis ---- LDK Varčiai www.varciai.lt

3 3

Re: winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().
by André Hentschel 20 Mar '13

20 Mar '13

Am 18.03.2013 04:41, schrieb Ken Thomases: > --- > dlls/winemac.drv/display.c | 131 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/gdi.c | 4 +- > dlls/winemac.drv/macdrv.h | 2 + > 3 files changed, 135 insertions(+), 2 deletions(-) Hi, wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp. It might happen that apps try bad ramps and the screen simply gets dark without validation. I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent. -- Best Regards, André Hentschel

2 1

Re: [PATCH 2/2] msvcrt: Fixed fgetwc behavior on multibyte characters and unicode files
by Akihiro Sagawa 20 Mar '13

20 Mar '13

On Mon, 18 Mar 2013 17:11:04 +0100, Piotr Caban wrote: > + char mbs[2]; This should be a constant, like MSVCRT_MB_LEN_MAX. > + int len = 0; > + ch = MSVCRT_fgetc(file); > + if(ch != MSVCRT_EOF) { > + mbs[0] = (char)ch; > + if(MSVCRT_isleadbyte(mbs[0])) { This doesn't work correctly if char is signed. Because _isleadbyte() expects the value of unsigned char or EOF as well as other is- functions. I wrote some fgetwc() tests. Please refer following page: https://testbot.winehq.org/JobDetails.pl?Key=24806 Akihiro Sagawa

2 1

Re: [7/10] winemenubuilder: Create a basic Info.plist.
by Ken Thomases 20 Mar '13

20 Mar '13

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + namestr = CFStringCreateWithCString(NULL, link_name, CFStringGetSystemEncoding()); You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings from POSIX path strings. > + pathstr = CFStringCreateWithCString(NULL, path, CFStringGetSystemEncoding()); Same thing here. > + data = CFPropertyListCreateData(NULL, propertyList, format, 0, &err); Since you don't use "err", just pass NULL. -Ken

2 1

Re: [10/10] winemenubuilder: Put appbundle icon inside the bundle.
by Ken Thomases 19 Mar '13

19 Mar '13

On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > + CFStringRef iconstr = CFStringCreateWithCString(NULL, icon, CFStringGetSystemEncoding()); Another place to use CFStringCreateWithFileSystemRepresentation(). -Ken

1 0

Re: msvcr110: add a stub for __crtGetShowWindowMode
by Dmitry Timoshkov 18 Mar '13

18 Mar '13

Austin English <austinenglish(a)gmail.com> wrote: > +int CDECL __crtGetShowWindowMode(void) > +{ > + FIXME(": stub!\n"); > + return 0; > +} Isn't it supposed to return SW_SHOW and other SW_xxx commands, specified at process creation time (SW_SHOWDEFAULT)? In that case returning 0 (SW_HIDE) is not a very good choice. -- Dmitry.

1 0

Re: [0/10] Launcher app bundles on OS X
by C.W. Betts 18 Mar '13

18 Mar '13

A quick glance at the source revealed that you removed static from some functions. Why? If a function isn't being called outside a source file, it's better to have it be static. This includes functions referenced in structs (but not the structs themselves). A more seasoned developer is welcome to correct me if I'm wrong. On Mar 17, 2013, at 11:18 AM, Per Johansson <per(a)morth.org> wrote: > I'm resending this now after testing it with the Mac driver. > They work well together, the launcher bundle will first briefly > appear in the dock, then exit, and the mac driver icon appears. > > It's split it up into parts for easier review. I've also tried > to make sure that even if e.g. part 6 fails review, part 1 - 5 > can still be applied. > > File type associations are not included because I plan to move > that code into the mac driver but haven't gotten around to it yet. > > Regards, > -- > Per Johansson > > >

2 1

Re: [website] Portuguese translation for release 1.5.25
by Bruno Jesus 18 Mar '13

18 Mar '13

2013/3/18 Lucas Zawacki <lfzawacki(a)gmail.com>: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > --- > news/pt/2013030101.xml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 news/pt/2013030101.xml > > diff --git a/news/pt/2013030101.xml b/news/pt/2013030101.xml > new file mode 100644 > index 0000000..ae13cfd > --- /dev/null > +++ b/news/pt/2013030101.xml > @@ -0,0 +1,14 @@ > +<news> > +<date>1 de Março de 2013</date> > +<title>Wine 1.5.25 lançado</title> > +<body> > + A versão de desenvolvimento 1.5.25 já está disponível agora. > + <a href="{$root}/announce/1.5.25">Novidades</a> desta versão: > +<ul> > + <li>Suporte adequado ao cursor no driver de Mac.</li> > + <li>Correções no suporte a escrita direita-para-esquerda no RichEdit.</li> > + <li>Versão inicial da uma fonte Wingdings.</li> Should be: Versão inicial de uma fonte Wingdings. Or: Versão inicial da fonte Wingdings. > + <li>Várias correções de bugs.</li> > +O código fonte está <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.25.tar.bz2">disponível agora</a>. > +Pacotes binários estão em processo de construção e irão aparecer em breve em suas respectivas <a href="{$root}/download">sessões da área de downloads</a>. > +</body></news> > -- > 1.7.9.5 > > > Best wishes, Bruno

2 1

Re: usp10: Support GPOS extension lookup subtables
by Aric Stewart 18 Mar '13

18 Mar '13

Hi Phil, Thank you for being patient I am back from vacation and reviewing your patch. The logic looks great and just fine. Do you happen to have a font that uses lookup type 9 that I can run my usp test suite on to make sure it functions as expected? thanks! -aric On 3/8/13 10:47 AM, Phil Krylov wrote: > > > >

1 0

WineD3D performance
by Graham Knap 18 Mar '13

18 Mar '13

Hi everyone I would like to try to help with improving the performance of StarCraft II on Wine. I'm working with a friend. Over the past couple of weeks, we have tried to read whatever documentation we could find. We have tried a couple of different approaches to profiling, without much success. My friend got WineD3D running on Windows. We built Wine from current source code, tested this on two different configurations, and got similar results. - my Core 2 E8500 + GeForce 9600GT + Windows XP x86 - his i5-2500 + GeForce 660 + Windows 7 x64 It looks like WineD3D is the cause of most of the performance difference. Windows with its own D3D gave us at least twice the frame rate of Windows + WineD3D. There is some difference between the numbers for Windows + WineD3D and Linux + Wine, but it's much smaller, i.e. something like 25%. Can anyone offer some hints on how to find the most significant causes of the performance difference? Any tips for effective profiling or tracing? Thanks. -- graham

2 2

Re: wined3d: add NVidia GeForce 315M
by Stefan Dösinger 18 Mar '13

18 Mar '13

Am 17.03.2013 um 17:08 schrieb Daniel Jeliński <djelinski1(a)gmail.com>: > why can't we get these values from X? They are definitely present in > my Xorg.log. Propose a patch. A few notes though: *) The upcoming GLX_MESA_query_renderer extension will provide a good way to query this info. If this extension will be adopted by the binary drivers is an open question. *) The X.org log would be an extremely ugly way to read this info. The log is at an unknown place, might be readable only by root or might not exist at all. There format of the log messages might change. *) There are vendor specific X11, GLX and GL extensions to query some GPU info *) Wined3d should not deal with GLX_MESA_query_renderer or any other X11 specific things. This should be handled by winex11.drv. > {"GT 320M", CARD_NVIDIA_GEFORCE_GT320M}, /* Geforce 300 - midend mobile */ > + {"315M", CARD_NVIDIA_GEFORCE_315M}, /* Geforce 300 - midend mobile */ > {"320M", CARD_NVIDIA_GEFORCE_320M}, /* Geforce 300 - midend mobile */ Afaics this table is sorted in descending order, for consistency you should swap the 315M and 320M

2 1

Re: msxml3: Embed user/password to uri used to create a moniker (try2)
by Nikolay Sivov 18 Mar '13

18 Mar '13

On 3/15/2013 21:43, Nikolay Sivov wrote: > try2: fixed builder leak > Please ignore this one, it removes too much, I have a better version.

1 0

Updating WineWiki Theme?
by Kyle Auble 16 Mar '13

16 Mar '13

Hi everybody, Although my hiatus was longer than expected, I've been making progress with updating the wiki code over the past few days (spring break is a very good thing). My workflow is a bit non-linear so I want to sort my changes into patches first, but fingers-crossed, I'll be pushing them to my Bitbucket account by the weekend. I did want to ask for input on a few things: 1. Should we just keep Moinmoin's search, replace it with the custom Google search, or offer both? 2. How about the icon? I can get the standard WineHQ one to display fine, but I'm not sure about which approach to take. Essentially, do what's simplest for us, or should I make it play well with other themes too? 3. Finally, the credits are currently just text links. In the future though, if Dimi wanted to, we could have a "sponsored by Lattica" banner like the Codeweavers ones on the other pages. After I get the theme together & test it some more on different browsers, I can look into migrating the data to the newest Moinmoin version. -Kyle

3 4

Vacation
by Alexandre Julliard 15 Mar '13

15 Mar '13

Folks, There won't be any commits next week, as I'll be out skiing... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] Make mac driver the default on OS X (try 2)
by Alexandre Julliard 15 Mar '13

15 Mar '13

Josh DuBois <duboisj(a)codeweavers.com> writes: > Ken also noted that the error reporting could be simpler if it were in > gdi instead of user32. My impression, after having poked at it a > while with Ken, is that it is in theory possible that an application > which never tried to create a window would print less noise with the > errors being reported as they are here than it would if the errors > were reported directly from gdi, so that this may be superior because > it is quieter. However, I'm not an expert and if the rigamarole is > not worth the extra lines, I'm sure Alexandre will indicate so by not > applying this. It needs to be printed on window creation because of command line apps, but that's not a reason for doing something as ugly and complicated as this... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] atl100/tests: Added class name test for AtlAxWinInit.
by Alexandre Julliard 15 Mar '13

15 Mar '13

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -562,6 +562,34 @@ static void test_source_iface(void) > ok(maj_ver == 4 && min_ver == 0, "ver = %d.%d\n", maj_ver, min_ver); > } > > +static void test_ax_win(void) > +{ > + BOOL ret; > + WNDCLASSEXW wcex; > + static const WCHAR AtlAxWin100[] = {'A','t','l','A','x','W','i','n','1','0','0',0}; > + static const WCHAR AtlAxWinLic100[] = {'A','t','l','A','x','W','i','n','L','i','c','1','0','0',0}; > + static HMODULE huser32 = 0, hinstance = 0; > + static BOOL (WINAPI *pGetClassInfoExW)(HINSTANCE, LPCWSTR, WNDCLASSEXW *); > + > + huser32 = GetModuleHandleA("user32.dll"); > + pGetClassInfoExW= (void *)GetProcAddress(huser32, "GetClassInfoExW"); It's not useful to load this dynamically if you are not going to check that it was found. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winmm: Fix notification when recording using MSACM.
by Alexandre Julliard 15 Mar '13

15 Mar '13

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > To achieve this, we eliminate the tail call and turn it into a loop, > which allows us to preserve the local state in the variable "last". Please do this as a proper loop, not with a goto. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 3)
by Alexandre Julliard 15 Mar '13

15 Mar '13

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > The only comments about v2 were Michael Stefaniuc > suggesting a refactoring and me explaining why > in this particular case, that would not be a good idea. > http://www.winehq.org/pipermail/wine-devel/2013-March/099068.html It's still a good idea, even if the function is ultimately used only in one place. > For v3, I've renamed MulDiv64 to UMulDiv64. Unlike QueryPerformanceCounter, > mmdevapi GetPosition operates on unsigned values. That's a bad name. Don't make internal functions look like Win32 APIs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.
by Phil Krylov 14 Mar '13

14 Mar '13

Hello Aric, On Tue, Feb 5, 2013 at 11:25 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: ef4b7c5948e43d4ceeed98ba4ddbf6c222259d36 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ef4b7c5948e43d4ceeed98ba4… > > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Tue Feb 5 08:57:44 2013 -0600 > > usp10: Update diacritical script handling for non OpenType Itemization. (snip) > + for (j = i-1; j >= 0 && scripts[j] == first_script && pwcInChars[j] != Numeric_space; j--) > + { > + WORD original = scripts[j]; > + if (original == Script_Ideograph || original == Script_Kana || original == Script_Yi || original == Script_CJK_Han || original == Script_Bopomofo) > + { > + asian = TRUE; > + break; > + } > + if (original != Script_MathAlpha && scriptInformation[scripts[j]].props.fComplex) > + break; > + scripts[j] = scripts[i]; > + if (original == Script_Punctuation2) > + break; > + } > + if (scriptInformation[scripts[j]].props.fComplex || asian) > + scripts[i] = scripts[j]; I am not sure about the logic of this, so I can't commit a good patch, but in the last statement you definitely access scripts[-1] when j reaches the value of 0. Which may cause a crash here or (in my case) later. -- Ph.

2 2

RE: d3dx9 [patch 1/2]: Implement D3DXSHEvalSphericalLight
by Nozomi Kodama 14 Mar '13

14 Mar '13

Hello Any problem with the patch http://source.winehq.org/patches/data/94777 and http://source.winehq.org/patches/data/94776 ? Nozomi.

2 2

Re: winegcc: Add support for -Ttext-segment linker flag to set image base of a dll. (try 2)
by André Hentschel 14 Mar '13

14 Mar '13

Am 03.03.2013 16:58, schrieb Tijl Coosemans: > --- > README | 3 +++ > tools/winegcc/utils.h | 3 ++- > tools/winegcc/winegcc.c | 11 ++++++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/README b/README > index 783e798..75aff5a 100644 > --- a/README > +++ b/README > @@ -40,6 +40,9 @@ support kernel threads may be supported in the future. > > FreeBSD info: > Wine will generally not work properly on versions before FreeBSD 7.0. > + You need GCC with GNU Binutils 2.20 or higher and run configure with > + environment variables like CC, CFLAGS, CXX, CXXFLAGS, CPP, CPPFLAGS, > + LD and LDFLAGS set correctly to use this compiler and linker. > See http://wiki.freebsd.org/Wine for more information. > Do you really need that? is there no script on freebsd to set the compiler toolchain or something? > > enum target_platform > { > - PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_WINDOWS, PLATFORM_CYGWIN > + PLATFORM_UNSPECIFIED, PLATFORM_APPLE, PLATFORM_SOLARIS, PLATFORM_ELF, > + PLATFORM_WINDOWS, PLATFORM_CYGWIN > }; > You would rather call it PLATFORM_FREEBSD > + if (opts->image_base && !opts->target && opts->target_platform == PLATFORM_UNSPECIFIED) I'm in doubt here -- Best Regards, André Hentschel

3 5

Re: [PATCH 2/2] ole32: Don't pass CLSCTX_INPROC_SERVER and CLSCTX_INPROC_HANDLER flags to CoCreateInstance in DefaultHandler
by Marvin 13 Mar '13

13 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24750 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Ignore gdiplus page and world transformations when creating a gdi32 clipping region.
by Vincent Povirk 13 Mar '13

13 Mar '13

I guess this makes sense, because having the clipping region change with transforms would be weird when drawing recursively and changing the transform. I had assumed clipping regions were in world coordinates because most things are, but I didn't really have any information either way.

1 0

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Henri Verbeet 13 Mar '13

13 Mar '13

On 13 March 2013 02:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This provides a small GPU-side performance boost on dx10+ capable Nvidia > cards - about 5% in World of Tanks on my Geforce 9600, and more in a > dedicated test program. > > This is essentially a revert of cd7825c89374fb9dd4c20aef2dbfd258713efe6a, > with proper precision. > This is probably ok, although one concern is applications setting constants to e.g. NaN or infinity. It may be worth using ARB_shader_bit_encoding when available, or perhaps even only doing this when that extension is available.

2 1

Re: [PATCH 1/2] wined3d: Put local constants into the shader code again
by Stefan Dösinger 13 Mar '13

13 Mar '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-03-12 18:19, schrieb Stefan Dösinger: > The test program is available at > https://84.112.174.163/~git/perftest file const_gl/const_gl.cpp. My server is currently turned off (and I should move this to github or somewhere at some point), so I've attached the test program here for reference. Resolution and constant mode are hardcoded into it. Tab/space mixup thanks to Visual Studio. Compile the Linux version with g++ const_gl.cpp -o const_gl -lGL -lglut -lGLEW . A d3d version is attached as well. It does not load the same values when using the global constants, but this doesn't seem to affect performance. I haven't tested ARB shaders, but from the WoT results before and after patch 2, their behavior seems to be the same as GLSL and native d3d. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRP9WcAAoJEN0/YqbEcdMwdmoP/2LvEFpPpmTiZDzxqhp38WfU DKs2S8m1kP86fL55GwLtth289WC9MsQyOosOVOqt8r3YWZyckeisZyhdP2ez2KRV 9kgxMnEXwzcZBtmm/+nrl0FwJghy86AnZ0YJ9PpnCpY0k4VTQYjaWQALlyqtF+qm Uup4UE+m4yR4DoNL/u/161Zxh+OLOA8PXEhWWfDozNL/8yMlRfPs6gzLMN/oKTIL UMA90gesZWPt7/J2Bp0+OeZvMWqNa54A2akxsLvtxVP/rB8baym4iYLn5Y2IPXa2 lBqALc+POMcVk45FCgkzjUw5b/7ck9V5n0PKOw/9Jwrm8/ChHE4i0ZwGEmHzh3So y1d/KydwesYtyCadmlklgJy1J+CxyCd/fNVUmsNtpzDEo6OF7oEagvwBUlTnCdR9 W9B9lmpsDCuBIxEnAy7C3HEZ18o70HdoUsKe5hX8fVn5lnwFPWdp7hBA0nVbO0y0 Fybps006cQmc0Rm9nHJjeJ9JoGzl/iuSX0AnQ5fiJS6fS5RrrGAnFBEb1g2O879X pNSIgBdKUSSfGBoUZKKIy+GZzC+VhDm4UqhtSaYudlUB9pcoMDFYRGQ3Rk48kRuD tJ8Ah2VBYeFUvI+x4Xty9AtOwwFWYejNG+6cNNF3EOALz2JvhFKDEJCI0p7bdmgR XCfPxQyYN7+JGFw8JiO5 =RgiG -----END PGP SIGNATURE-----

1 0

Re: [PATCH] activeds: Exclude unused headers.
by Alexandre Julliard 12 Mar '13

12 Mar '13

Amine Khaldi <amine.khaldi(a)reactos.org> writes: > @@ -28,13 +28,10 @@ > > #include "windef.h" > #include "winbase.h" > -#include "winuser.h" > > #include "objbase.h" > #include "iads.h" > -#include "adshlp.h" > > -#include "wine/unicode.h" > #include "wine/debug.h" It's not worth the trouble, particularly since the file ends up including windows.h anyway. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ntdll: Make msync() asynchronous in NtFlushVirtualMemory (resubmit with real name)
by Alexandre Julliard 12 Mar '13

12 Mar '13

Mathis Beer <default_357-line(a)yahoo.de> writes: > diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c > index a99bca4..e4f2bb6 100644 > --- a/dlls/ntdll/virtual.c > +++ b/dlls/ntdll/virtual.c > @@ -62,6 +62,10 @@ WINE_DECLARE_DEBUG_CHANNEL(module); > #define MS_SYNC 0 > #endif > > +#ifndef MS_ASYNC > +#define MS_ASYNC 1 > +#endif That's questionable, there's no reason the value would be 1. We defined MS_SYNC to 0 on the theory that it's better to pass 0 than making up values, but probably not calling the function at all would be preferable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcp60: Avoid signed-unsigned integer comparisons
by larmbr zhan 11 Mar '13

11 Mar '13

On Sun, Mar 10, 2013 at 5:48 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > msvcp60: Avoid signed-unsigned integer comparisons. Hi, Andrew Talbot. I find that you are working on these "Avoid signed-unsigned integer comparisons" things recently. I DO agree on that using _ unsigned int _ instead of _ int _(which implies _ signed int _). But I think using size_t maybe more standard-compliant, more efficient, and less bug-prone, . To hold this, I think something has to be clarified... * The overflow behavior is instrinsic because the finite range that a object of INT type can hold. But It behaves different when it is signed or not. According to C Standard, - For the signed case, once it overflows, resulting in representing a negative value . - For the unsigned case, once it overflows, resulting in representing a value reduced modulo the largest value that object could hold. So see this example: --- snip --- size_t num = get_max_object_num(); // which may give a large number. unsigned int i; for ( i = 0; i < num; i++) something_important[i] = vital_evaluate_for(i); --- snip --- For this case, though we use unsinged int ,it still may issue problem if num >= UINT_MAX, which will cause i to wrap to 0, then something_important maybe assigned a invalid value, as like. This problem may occur if using in a 64-bit enviroment, where size_t is typeof 'ed unsigned 64bit while unsigned int is still 32-t wide. Some may argue that in Wine this problem will NEVER happen. I don't doubt it. But * since we have a cleared and more standard-compliant way (which means less bug-prone), and * predictably Wine will support more platforms, portable way shall be taken it account. So I think we should use size_t in this case. -- Cheers, Zhan JIanyu

4 3

Re: ntdll: make NtDelayExecution a bit more efficient
by Alexandre Julliard 11 Mar '13

11 Mar '13

Graham <graham.knap(a)gmail.com> writes: > This patch is vaguely related to bug 24558. It eliminates a few > syscalls in NtDelayExecution: > > 1. If the caller requests a zero-wait yield, then do just that, and > nothing more. That's what the existing code already does. > 2. If you're about to block on select(), then I don't see any point in > preceding that with a call to sched_yield(). This was added for a reason; most likely you'll have to write tests. -- Alexandre Julliard julliard(a)winehq.org

7 7

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)
by Nikolay Sivov 11 Mar '13

11 Mar '13

On 3/11/2013 16:36, Jeff Latimer wrote: > + if (!ppv) return E_INVALIDARG; You don't need this most likely. > + IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. > +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + return 2; > +} > + > +static ULONG WINAPI WMCreateEditor_Release(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return 1; > +} What's this supposed to mean? > +HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} > + > +HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface) > +{ > + FIXME("iface=%p\n", iface); > + HeapFree(GetProcessHeap(), 0, iface); > + return S_OK; > +} I don't think so. > HRESULT WINAPI WMCreateEditor(IWMMetadataEditor **editor) > { > + IWMMetadataEditor *This; > FIXME("(%p): stub\n", editor); > > - *editor = NULL; > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(IWMMetadataEditor)); > + if (!This) return E_OUTOFMEMORY; > > - return E_NOTIMPL; > + This->lpVtbl = &Editor_vtable; > + *editor = This; > + > + return S_OK; > } That's not how it's done, there's plenty of examples already. > -}; > +} That change is ok I think.

1 0

Re: [1/2] include: Implement part of nserror.h
by Nikolay Sivov 11 Mar '13

11 Mar '13

On 3/11/2013 10:27, Jeff Latimer wrote: > --- > include/nserror.h | 226 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 226 insertions(+) > create mode 100644 include/nserror.h > +#ifndef _NSERROR_H > +#define _NSERROR_H This doesn't look right. > +#define NS_S_CALLPENDING_HRESULT_TYPEDEF_(0x000D0000L) This is usually done with a suffix. > + > +#endif Please add a comment here.

2 2

Re: wininet: Skip test_open_url_async on IEs older than 7.
by Marvin 09 Mar '13

09 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24685 Your paranoid android. === WVISTAADM (32 bit http) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: dpnet/tests: Allow buffersize used by Win8
by Marvin 09 Mar '13

09 Mar '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24682 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Crash confuses me
by Graham 09 Mar '13

09 Mar '13

I use a LD_PRELOAD before running wine so that i can debug my application. The library which is preloaded is able to replace system dlsym and from that, other consequence library call. There is no problem until, i put some Detour code(hot patching) into the kernel32.dll.so address space. But the very funny things is this ** THE PROGRAM CRASHES BEFORE MY HOTPATCH IS APPLIED ** so it seems somehow the order of cause and effect is extremely weird and frightening to me. How can a piece of code which is not excecuted be teh cause for errors PRIOR/BEFORE to its execution. And this is surely happening because when i uncomment the Hotpatch/detour lines the problem goes away. here are some lines from the crashs ... err:module:attach_process_dlls "user32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\winemenubuilder.exe" failed, status c0000005 wine: Unhandled page fault on execute access to 0x7c9e4cd7 at address 0x7c9e4cd7 (thread 000b), starting debugger... err:module:DelayLoadFailureHook failed to delay load user32.dll.BroadcastSystemMessageW wine: Call from 0x7b83ba92 to unimplemented function user32.dll.BroadcastSystemMessageW, aborting wine: Unimplemented function user32.dll.BroadcastSystemMessageW called at address 0x7b83ba92 (thread 001d), starting debugger... Another thing to notice is that this was tested using wine1.4.1 However it DOES work with wine1.5.10 ... to get something to work for me is not the challenge, its to understand the logic behind why something does not. THanks a lot and I am grateful for any who contributes his knowledge to this problem i am a real NOVICE

5 8

Re: comctl32/listview: fix overwriting of item values
by Nikolay Sivov 09 Mar '13

09 Mar '13

On 3/9/2013 10:03, Daniel Jelinski wrote: Makes sense, thanks. I briefly searched for such cases and LISTVIEW_FindItemW() seems to be broken the same way.

1 0

spec file and -arch
by Stefan Leichter 08 Mar '13

08 Mar '13

Hi, when i look into msvcr100.spec file i find lots of different parameters for the switch (?) -arch . So fare i have seen: arm, i386, win32, win64 and x86_64 . To me it is not clear what is the difference between win64 and x86_64. The same for i386 and win32. What are is the criteria to choose the first or the second? If it makes a difference do i have to distinguish between arm and ... ? Does -i386 and -arch=i386 mean the same? Thank you for enlightening me Stefan

2 1

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Alexandre Julliard 08 Mar '13

08 Mar '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > This patch demonstrates the most interest case from previous versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It's better, but testing the message sequence doesn't seem very useful, particularly since you don't differentiate parent and child messages. Also you should test the region before the move to show that it's the move that's changing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcr110: Add VS2012 C/C++ runtime
by Alexandre Julliard 08 Mar '13

08 Mar '13

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -0,0 +1,2260 @@ > +# MS VC++2012 runtime library > + > +@ stub -arch=arm ??0?$_SpinWait@$00@details@Concurrency@@QAA@P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$00@details@Concurrency@@QAE@P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$00@details@Concurrency@@QEAA@P6AXXZ@Z > +@ stub -arch=arm ??0?$_SpinWait@$0A@@details@Concurrency@@QAA@P6AXXZ@Z > +@ stub -arch=win32 ??0?$_SpinWait@$0A@@details@Concurrency@@QAE@P6AXXZ@Z > +@ stub -arch=win64 ??0?$_SpinWait@$0A@@details@Concurrency@@QEAA@P6AXXZ@Z > +@ stub -arch=arm,win32 ??0SchedulerPolicy@Concurrency@@QAA@IZZ That doesn't make much sense, arm is win32 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO. (try 2)
by Alexandre Julliard 08 Mar '13

08 Mar '13

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/winhttp/session.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > dlls/winhttp/tests/winhttp.c | 62 ++++++++++++++++++++++++++++++++++++ > include/winhttp.h | 16 ++++++++++ > 3 files changed, 149 insertions(+) Now it breaks the Android build... i686-linux-android-gcc -c -I../../../../wine/dlls/winhttp -I. -I../../../../wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -o session.o ../../../../wine/dlls/winhttp/session.c ../../../../wine/dlls/winhttp/session.c: In function 'convert_sockaddr': ../../../../wine/dlls/winhttp/session.c:609:25: error: 'struct WS_sockaddr_in' has no member named '__pad' make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac: fix compilation on Lion and later
by Ken Thomases 08 Mar '13

08 Mar '13

On Mar 7, 2013, at 4:15 PM, C.W. Betts wrote: > This patch defines __gltypes_h_ so that the Mac header doesn't get included. Thanks! -Ken

1 0

Re: [PATCH 1/7] winemac: Implement OpenGL support.
by C.W. Betts 07 Mar '13

07 Mar '13

It seems like there's conflicting types for GLhandleARB, one defined by Wine, the other by OS X, on Mountain Lion. I assume that the #define __gl_h_ is a try to work around the issue, but OS X's gltypes.h still gets included. On Mar 6, 2013, at 3:59 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/Makefile.in | 4 +- > dlls/winemac.drv/cocoa_opengl.h | 32 + > dlls/winemac.drv/cocoa_opengl.m | 154 ++++ > dlls/winemac.drv/cocoa_window.m | 187 ++++ > dlls/winemac.drv/gdi.c | 2 +- > dlls/winemac.drv/macdrv.h | 10 + > dlls/winemac.drv/macdrv_cocoa.h | 15 + > dlls/winemac.drv/opengl.c | 1912 +++++++++++++++++++++++++++++++++++++++ > dlls/winemac.drv/window.c | 11 +- > 9 files changed, 2322 insertions(+), 5 deletions(-) > create mode 100644 dlls/winemac.drv/cocoa_opengl.h > create mode 100644 dlls/winemac.drv/cocoa_opengl.m > create mode 100644 dlls/winemac.drv/opengl.c > > <0001-winemac-Implement-OpenGL-support.patch>

2 3

Re: [2/2] winhttp: Implement WINHTTP_OPTION_CONNECTION_INFO.
by Alexandre Julliard 07 Mar '13

07 Mar '13

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -25,6 +25,9 @@ > > #include "windef.h" > #include "winbase.h" > +#define USE_WS_PREFIX > +#include "winsock2.h" > +#include "ws2ipdef.h" > #include "winhttp.h" > #include "wincrypt.h" > #include "winreg.h" This breaks the Mingw build here: In file included from ../../../wine/dlls/winhttp/session.c:39:0: ../../../wine/dlls/winhttp/winhttp_private.h:124:29: error: field ‘sockaddr’ has incomplete type ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:230:49: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] ../../../wine/dlls/winhttp/winhttp_private.h:238:66: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:594:44: warning: ‘struct sockaddr’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:596:21: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:598:10: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:598:10: note: each undeclared identifier is reported only once for each function it appears in ../../../wine/dlls/winhttp/session.c:604:39: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:605:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:609:10: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:615:40: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:616:44: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:617:49: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:627:283: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: In function ‘request_query_option’: ../../../wine/dlls/winhttp/session.c:731:25: error: storage size of ‘local’ isn’t known ../../../wine/dlls/winhttp/session.c:732:9: error: unknown type name ‘socklen_t’ ../../../wine/dlls/winhttp/session.c:746:9: warning: implicit declaration of function ‘getsockname’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:748:9: warning: passing argument 1 of ‘convert_sockaddr’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:594:13: note: expected ‘const struct sockaddr *’ but argument is of type ‘const struct sockaddr *’ ../../../wine/dlls/winhttp/session.c:731:25: warning: unused variable ‘local’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1230:63: warning: ‘struct sockaddr_in’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘printf_addr’: ../../../wine/dlls/winhttp/session.c:1233:15: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] ../../../wine/dlls/winhttp/session.c:1233:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1234:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1235:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1236:41: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1239:41: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c:1248:66: warning: ‘struct addrinfo’ declared inside parameter list [enabled by default] ../../../wine/dlls/winhttp/session.c: In function ‘build_wpad_url’: ../../../wine/dlls/winhttp/session.c:1252:15: error: ‘NI_MAXHOST’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:20: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:35: error: ‘AF_INET’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:48: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1256:63: error: ‘AF_INET6’ undeclared (first use in this function) ../../../wine/dlls/winhttp/session.c:1256:80: error: dereferencing pointer to incomplete type ../../../wine/dlls/winhttp/session.c:1259:5: warning: passing argument 1 of ‘reverse_lookup’ from incompatible pointer type [enabled by default] ../../../wine/dlls/winhttp/session.c:1239:12: note: expected ‘const struct addrinfo *’ but argument is of type ‘const struct addrinfo *’ ../../../wine/dlls/winhttp/session.c:1252:10: warning: unused variable ‘name’ [-Wunused-variable] ../../../wine/dlls/winhttp/session.c: At top level: ../../../wine/dlls/winhttp/session.c:1205:14: warning: ‘get_computer_name’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1221:13: warning: ‘is_domain_suffix’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1230:13: warning: ‘printf_addr’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c:1248:15: warning: ‘build_wpad_url’ defined but not used [-Wunused-function] ../../../wine/dlls/winhttp/session.c: In function ‘convert_sockaddr’: ../../../wine/dlls/winhttp/session.c:630:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [session.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalConeLight
by Nozomi Kodama 07 Mar '13

07 Mar '13

hello Still problems with this patch? Nozomi.

2 1

wiki.winehq.org is down
by Michael Stefaniuc 07 Mar '13

07 Mar '13

Hey Dimi, the wiki is down: <puk> is the wiki down? <puk> it pings <puk> but with high latency <puk> and while port 80 connects a GET / doesn't returns thanks bye michael

1 0

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).
by Sergey Guralnik 07 Mar '13

07 Mar '13

On 2013-03-04 10:39, Sergey Guralnik wrote: > This patch demonstrates the most interest case from previous > versions. > When SetWindowPos() moves child window, that has some invalid > area, it also invalidates children of this window according to its > update region, even if moved window has WS_CLIPCHILDREN style. > > Wine doesn't perform this invalidation. > One pretty large application depends on this feature, and now, > runned under Wine, it has broken output. > > Hope this variant is more clear than all previous. It stays queued since Monday without any reply. Is something wrong with it? -- Sergey

1 0

Re: Use accented letters in their names.
by Frédéric Delanoy 06 Mar '13

06 Mar '13

> On 3/4/13, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: >> On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: >>> The authors file is outdated and you want this updated with the >>> missing authors. Andrej Znidarsic should have Slovenian accented >>> letters for his last name. >>> >>> On 2/4/13, Tae Wong <seotaewong40(a)gmail.com> wrote: >>>> You will want to use accented letters in their authors names. >>>> >>>> Caolan McNamara >>>> Ferenc Wagner >>>> Marko Nikolic >>>> >>>> Every once and a while the GNOME Live website is down with an error on >>>> Netscape called “The operation timed out when attempting to contact .” >>>> - This paragraph should have a website name. You want to be unbanned >>>> in Amaterasu Translations and the DOS ain’t dead forums. >> >> Feel free to send a patch to wine-patches fixing those issues. >> On Wed, Mar 6, 2013 at 3:02 PM, Tae Wong <seotaewong40(a)gmail.com> wrote: > You’ve sent a patch to wine-patches but never got them fixed! I didn't send a patch, but you did (well, sort of, this wasn't really a patch, but a mere email) See http://wiki.winehq.org/SubmittingPatches for instructions (http://source.winehq.org/patches/ helps you see what is the status of your patch, in this case 94687) Note however that this authors list is likely autogenerated from git.("John Doo <email address>") email addresses, so it's up to the patch submitter to correctly spell his/her own name to begin with. Rewriting the history to fix this seems overkill to me. Hence, if you fix the AUTHORS file, your changes might be overwritten the next time the file is generated. Frédéric

1 0

ntdll: make NtDelayExecution a bit more efficient
by Joerg-Cyril.Hoehle＠t-systems.com 06 Mar '13

06 Mar '13

You may try and find that MSDN or blog page where people explain the subtle differences of Sleep(0) and Sleep(1) on multi-core machines. Regards, Jörg Höhle

1 0

Re: [1/3] Make mac driver the default on OS X
by Ken Thomases 06 Mar '13

06 Mar '13

On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote: > --- > dlls/gdi32/driver.c | 102 +++++++++++++++++++++++++++++++++++++++++++-- > dlls/gdi32/gdi32.spec | 1 + > dlls/gdi32/gdi_private.h | 2 + > dlls/user32/driver.c | 27 ++++++------ > include/wine/gdi_driver.h | 11 +++++ > 5 files changed, 125 insertions(+), 18 deletions(-) > > <0001-Track-and-report-multiple-errors-loading-display-drive.txt> As I believe you're aware, I think that the Mac driver should not be made the default until OpenGL and clipboard support are in. So, maybe this was just submitted in preparation for that time, but there should probably have been a note to that effect. Also, this patch seems exceedingly complex for a relatively simple problem. Just because it has historically been user32 that reported failure to load the driver doesn't mean it must remain so, at least to my way of thinking. Why not just print out the diagnostics directly in gdi32 as each attempt to load a driver fails? In user32, there can be a secondary, driver-agnostic message about failure to create a window. > + case ERROR_DLL_INIT_FAILED: > + load_err->err_msg = "Make sure you have permission to create \na window or check for errors with Console.app. \n(The Mac driver cannot do remote display: try X11 if you need that.)"; > + break; "Make sure you have permission to create a window" doesn't mean anything to me. Checking Console.app isn't very useful either. If the user sees this message, then they're already looking at wherever the process's output is going. Running Wine from a shell won't write anything to the console logs. As of Mountain Lion, running it from a GUI app won't either; Apple changed things so that stdout and stderr of GUI apps go to /dev/null rather than console logs. (Only things like NSLog() or asl_log() go to the console log.) Probably it's just best to say that the Mac driver is running in a non-GUI session such as a remote login. -Ken

2 1

Re: qcap: Fix compilation on systems that have v4l1 but not VIDIOCMCAPTURE & co.
by Alexandre Julliard 06 Mar '13

06 Mar '13

Francois Gouget <fgouget(a)free.fr> writes: > In particular this fixes compilation on FreeBSD 8.1. > > configure | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 18 +++++++++++++ > dlls/qcap/v4l.c | 4 +-- > include/config.h.in | 3 +++ > 4 files changed, 97 insertions(+), 2 deletions(-) It's not very useful to add a configure check for a #define, you can check for it directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] Make mac driver the default on OS X
by Ken Thomases 06 Mar '13

06 Mar '13

On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote: > diff --git a/dlls/winemac.drv/macdrv_main.c b/dlls/winemac.drv/macdrv_main.c > index cd1cc0c..1f16694 100644 > --- a/dlls/winemac.drv/macdrv_main.c > +++ b/dlls/winemac.drv/macdrv_main.c > @@ -85,7 +85,7 @@ static BOOL process_attach(void) > macdrv_err_on = ERR_ON(macdrv); > if (macdrv_start_cocoa_app(GetTickCount64())) > { > - ERR("Failed to start Cocoa app main loop\n"); > + TRACE("Failed to start Cocoa app main loop\n"); > return FALSE; > } > I would think that this should still be at least a WARN, although I'm not sure why it's being demoted from ERR in the first place. (In fact, I should probably have added a WARN in my patch for refusing to run in non-GUI sessions.) -Ken

1 0

Re: msxml3: Implement IXMLParser Get/Set Factory
by Nikolay Sivov 06 Mar '13

06 Mar '13

On 3/6/2013 09:11, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Implement IXMLParser Get/Set Factory You also need to release factory reference on parser release it seems. > > > Best Regards > Alistair Leslie-Hughes > >

1 0

Re: comctl32/imagelist: use proper color format for merged image lists (try 2)
by Alexandre Julliard 05 Mar '13

05 Mar '13

Daniel Jelinski <djelinski1(a)gmail.com> writes: > +static void test_merge_colors(void) > +{ > + HIMAGELIST himl[5], hmerge; > + int sizes[] = { ILC_COLOR4, ILC_COLOR8, ILC_COLOR16, ILC_COLOR24, ILC_COLOR32 }; You should also test COLORDDB, and probably the mask behavior too. -- Alexandre Julliard julliard(a)winehq.org

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel