- wine-devel - winehq.org

Re: [3/6] windowscodecs: Implement tiff encoder options (TiffCompressionMethod and CompressionQuality)
by Dmitry Timoshkov 20 Jan '13

20 Jan '13

Ludger Sprenker <ludger(a)sprenker.net> wrote: > + read_hr = IPropertyBag2_Read(pIEncoderOptions, 2, pb, NULL, v, hr); > + if (SUCCEEDED(hr)) Looks like a typo. -- Dmitry.

2 1

Re: [3/5] comctl32/listview: always use large icon size when calculating icon spacing
by Marvin 20 Jan '13

20 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24024 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [5/5] comctl32/listview: fix LVM_SETICONSPACING on 64bit machines
by Marvin 20 Jan '13

20 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24026 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] comctl32/listview: do not touch icon spacing if set explicitly
by Marvin 20 Jan '13

20 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24025 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

User driver function conventions
by C.W. Betts 19 Jan '13

19 Jan '13

I'm wondering what the user driver functions GetScreenSaveActive and SetScreenSaveActive are supposed to do. I have an implementation against CodeWeaver's changes to Wine and I just want to make sure that I'm making the functions properly. First is GetScreenStateActive. Does it check for if the screen saver is disabled for the whole system or just the app. And SetScreenStateActive. Is it supposed to set the activity for the whole system (I.E. if two apps call SetScreenStateActive to yes, then one to no, does the screen saver run) or is it per-app?

2 3

Re: [1/6] windowscodecs: Implementation of IPropertyBag2
by Vincent Povirk 19 Jan '13

19 Jan '13

You'll probably have to split this into smaller patches. + return E_FAIL; /* FIXME: Function is not atomar on error, but MSDN does not say anything about it */ I don't understand. Are you saying native leaks memory on error, and if so how do you know this? + FIXME("Application tried to set the unknown option %s. " + "This may be an application error but is probably caused by an incomplete implementation in wine\n", + debugstr_w(pPropBag[i].pstrName)); I don't think the extra explanation of why this is a FIXME adds anything. + if (This->properties[idx].vt != V_VT(pvarValue+i)) + return E_FAIL; Are you sure this shouldn't be converted? + while (TRUE) + { + CoTaskMemFree( pPropBag[--i].pstrName ); + if(i == 0) + break; + } This could be written more simply as a do/while loop. +extern HRESULT CreateEncoderPropertyBag(PROPBAG2 *options, UINT count, IPropertyBag2 **property) DECLSPEC_HIDDEN; This adds code that's not really used. You might want to start out by changing the arguments of CreatePropertyBag2 and adding the IWICComponentFactory method. Then you can write tests first and remove todo's as you go. I don't think there's any reason to keep a constructor with the old set of arguments around.

1 0

winetestbot back online, for now
by Maarten Lankhorst 19 Jan '13

19 Jan '13

Hey, It looks like the vmware licensing issues are resolved, so all testbot vm's are online again. I hope the replacement testbot is coming along nicely, because winetestbot is still scheduled to go permanently offline in may. ~Maarten

1 0

Truncate MIDI SysEx messages after termination byte
by Joerg-Cyril.Hoehle＠t-systems.com 18 Jan '13

18 Jan '13

Hi, Johannes Kroll wrote: >+ for(i = 0; i < lpMidiOutHdr->dwBufferLength; i++) >+ if((unsigned char)lpMidiOutHdr->lpData[i] == 0xF7 && i < lpMidiOutHdr->dwBufferLength-1) What about for(i = 0; i+1 < lpMidiOutHdr->dwBufferLength, i++) without the redundant second if(&&) half? I'm always happy when somebody with real MIDI HW speaks up, because I'm not convinced that the Wine MIDI code does TRT about SysEx -- based on my readings, not experience, as I own no MIDI device... In particular, do you have any experience with multi-part SysEx messages (e.g. large data, such as uploads)? Still, I'm not persuaded that your patch is at the right place. I believe the midi* functions should be tiny wrappers around MODM_* messages, same for the wave* functions. Every time I see somebody attempt to violate this 1:1 mapping, I'm suspicious. Perhaps the logic that you're adding belongs to the individual wine*.drv/midi.c? Do you get to see this warning from winealsa.drv where it specifically checks for a terminating F7 (but not intermediate F7)? http://source.winehq.org/source/dlls/winealsa.drv/midi.c#L969 964 /* FIXME: MS doc is not 100% clear. Will lpData only contain system exclusive 965 * data, or can it also contain raw MIDI data, to be split up and sent to 966 * modShortData() ? 967 * If the latest is true, then the following WARNing will fire up 968 */ 969 if (lpData[0] != 0xF0 || lpData[lpMidiHdr->dwBufferLength - 1] != 0xF7) { 970 WARN("Alleged system exclusive buffer is not correct\n\tPlease report with MIDI file\n"); 971 lpNewData = HeapAlloc(GetProcessHeap(), 0, lpMidiHdr->dwBufferLength + 2); 972 } Therefore, I'd be happy if you could invest some more time and check, based on your real MIDI HW, and perhaps native w* machines, whether MODM_LONGDATA and midiOutLongMsg are equivalent or whether midiOut* does some additional processing. Regards, Jörg Höhle

3 6

Re: include: Make sure interlocked_cmpxchg128 is defined on ARM64
by André Hentschel 18 Jan '13

18 Jan '13

Am 18.01.2013 18:05, schrieb André Hentschel: > --- > include/wine/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/wine/port.h b/include/wine/port.h > index bd6f513..d6904c0 100644 > --- a/include/wine/port.h > +++ b/include/wine/port.h > @@ -435,7 +435,7 @@ extern __int64 interlocked_cmpxchg64( __int64 *dest, __int64 xchg, __int64 compa > extern int interlocked_xchg( int *dest, int val ); > extern void *interlocked_xchg_ptr( void **dest, void *val ); > extern int interlocked_xchg_add( int *dest, int incr ); > -#ifdef _WIN64 > +#if defined(__x86_64__) || defined(__aarch64__) || defined(_WIN64) > extern unsigned char interlocked_cmpxchg128( __int64 *dest, __int64 xchg_high, > __int64 xchg_low, __int64 *compare ); > #endif > > > > oops that's not fully correct, I'll fix it next week, not a bad warning. -- Best Regards, André Hentschel

1 0

Re: qcap: Fix compilation on older systems.
by Damjan Jovanovic 18 Jan '13

18 Jan '13

What does this patch do? libv4l1.h includes libv4l1-videodev.h which is a copy of linux/videodev.h. You should only need the one or the other. Are you saying there is a system where libv4l1.h is present but incomplete, and you need to include linux/videodev.h together with it? Thank you Damjan On Tue, Jan 15, 2013 at 6:47 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/qcap/v4l.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/qcap/v4l.c b/dlls/qcap/v4l.c > index f5baaeb..2562c48 100644 > --- a/dlls/qcap/v4l.c > +++ b/dlls/qcap/v4l.c > @@ -47,7 +47,8 @@ > #endif > #ifdef HAVE_LIBV4L1_H > #include <libv4l1.h> > -#elif defined(HAVE_LINUX_VIDEODEV_H) > +#endif > +#ifdef HAVE_LINUX_VIDEODEV_H > #include <linux/videodev.h> > #endif > #ifdef HAVE_UNISTD_H > -- > 1.8.0.2 > > >

3 4

Re: configure.ac: check for a recent enough libv4l1.h
by Alexandre Julliard 18 Jan '13

18 Jan '13

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * configure.ac: check for a recent enough libv4l1.h > > libv4l1.h can only be used instead of linux/videodev.h as of version > 0.8.3, so check for the version using pkg-config (the only possible > way) and don't try to compile with older versions. This fixes > compilation on systems like FreeBSD 8.2, where there is no > linux/videodev.h, and libv4l1.h is too old. You should check for the definitions we need, not the version number. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used. (try 2) (resend)
by Alexandre Julliard 18 Jan '13

18 Jan '13

Charles Davis <cdavis5x(a)gmail.com> writes: > Try 2: Clarify that this is a Mac OS-only change. Don't use $CC as the assembler. Use the right flags to select 32/64-bit assembly with Clang. > > The configure script invokes the system compiler to figure out if .cfi > pseudo-ops are supported, on the assumption that it will invoke the > system assembler. Winebuild, on the other hand, invokes the system > assembler directly. This caused a problem on Mac OS hosts when compiling > with Clang: configure would detect that .cfi ops were supported, because > Clang's integrated assembler supports them; however, when winebuild then > emitted assembly with .cfi ops in them, the system assembler would then > choke. This patch makes winebuild invoke Clang's assembler if a) we are > on Mac OS, b) $CC is detected to be Clang, and c) it is using (whether > by request or by default) its built-in assembler. You can't use ifdefs in winebuild. This would have to be a runtime check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] vbscript: Added VBScript.RegExp version 5.5 typelib
by Jacek Caban 18 Jan '13

18 Jan '13

Hi Piotr, On 01/18/13 11:48, Piotr Caban wrote: > +#define DISPID_SUBMATCHES_ITEM 0 > +#define DISPID_SUBMATCHES_COUNT 1 > +#define DISPID_SUBMATCHES__NEWENUM -4 > + > +#define DISPID_MATCHCOLLECTION_ITEM 0 > +#define DISPID_MATCHCOLLECTION_COUNT 1 > +#define DISPID_MATCHCOLLECTION__NEWENUM -4 > + > +#define DISPID_MATCH_VALUE 0 Please use DISPID_VALUE and DISPID_NEWENUM instead. Jacek

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests (try2)
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23996 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] msvcrt: Added basic _popen tests
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23995 Your paranoid android. === WNT4WSSP6 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2KPROSP4 (32 bit misc) === misc.c:340: Test failed: errno = -559038737 === W2K3R2SESP2 (32 bit misc) === misc.c:340: Test failed: errno = -559038737

1 0

Re: [PATCH 3/3] d3dx9_36: Make variables static in xfile tests.
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23990 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32/tests: Test standard scrollbar's initialization (try 2).
by Sergey Guralnik 18 Jan '13

18 Jan '13

On 2013-01-15 12:27, Sergey Guralnik wrote: > I have no feedback yet. Is it not clear enough? -- Sergey

1 0

Re: po: Update Russian translation
by Dmitry Timoshkov 18 Jan '13

18 Jan '13

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > #: jscript.rc:40 > msgid "Can't have 'break' outside of loop" > -msgstr "Выражение 'break' не может находится вне цикла" > +msgstr "Оператор 'break' не может находится вне цикла" > > #: jscript.rc:41 > msgid "Can't have 'continue' outside of loop" > -msgstr "Выражение 'continue' не может находится вне цикла" > +msgstr "Оператор 'continue' не может находится вне цикла" It would be also nice to fix obvious spelling errors, it really hurts the eyes :) - "не может находит[ь]ся", and run spell checker for the whole translation. -- Dmitry.

1 0

Re: ws2_32/tests: Add SO_ERROR [set|get]sockopt tests
by Marvin 18 Jan '13

18 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23986 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] kernel32/path : use code from copyfileW to implement copyfileexW
by Alexandre Julliard 17 Jan '13

17 Jan '13

Patrick Rudolph <siro(a)das-labor.org> writes: > From 6ff3329003b6b9001ad608f802f235f5433b1c5d Mon Sep 17 00:00:00 2001 > From: Patrick Rudolph <siro(a)das-labor.org> > Date: Fri, 11 Jan 2013 15:55:32 +0100 > Subject: a > > --- > dlls/kernel32/path.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 86 insertions(+), 5 deletions(-) You need to move the code, not duplicate it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/tests : added tests for copyfileex try4
by Alexandre Julliard 17 Jan '13

17 Jan '13

Patrick Rudolph <siro(a)das-labor.org> writes: > + if(!GetTempPathA( MAX_PATH,tmppath )) > + { > + win_skip("GetTempPathA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAin",0,source_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + if(!GetTempFileNameA( tmppath,"CopyFileExAout",0,dest_name )) > + { > + win_skip("GetTempFileNameA failed\n"); > + return; > + } > + > + source_handle = CreateFileA( source_name, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0 ); > + if(!source_handle) > + { > + win_skip("CreateFileA failed, no write permissions ?\n"); > + return; > + } > + > +#define COPYFILEEXFILESIZE 10000000 > + > + /* create a dummy file for copy tests */ > + buffer = malloc(COPYFILEEXFILESIZE); > + if(!WriteFile(source_handle,buffer,COPYFILEEXFILESIZE,&ret,NULL)) > + { > + free(buffer); > + win_skip("WriteFile failed, enough free disk space ?\n"); > + return; > + } > + free(buffer); > + CloseHandle(source_handle); There are better ways to create a test file than writing 10Mb of uninitialized data. Also you should check how GetTempFileName works. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character. (try 4)
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23979 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] winealsa.drv: Cleanup modLongData and Fix F0 and F7 byte insertion + memory leak.
by Alexandre Julliard 17 Jan '13

17 Jan '13

Christian Costa <titan.costa(a)gmail.com> writes: > @@ -927,12 +927,12 @@ static DWORD modData(WORD wDevID, DWORD dwParam) > } > > /************************************************************************** > - * modLongData [internal] > + * modLongData internal] > */ > static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > { > - int len_add = 0; > - LPBYTE lpData, lpNewData = NULL; > + int len_add = 0; > + BYTE *lpData, *lpNewData = NULL; > snd_seq_event_t event; > > TRACE("(%04X, %p, %08X);\n", wDevID, lpMidiHdr, dwSize); > @@ -941,23 +941,23 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > * but it seems to be used only for midi input. > * Taking a look at the WAVEHDR structure (which is quite similar) confirms this assumption. > */ > - > + > if (wDevID >= MODM_NumDevs) return MMSYSERR_BADDEVICEID; > if (!MidiOutDev[wDevID].bEnabled) return MIDIERR_NODEVICE; > > - if (midiSeq == NULL) { > - WARN("can't play !\n"); > - return MIDIERR_NODEVICE; > + if (!midiSeq) { > + WARN("Can't play !\n"); > + return MIDIERR_NODEVICE; > } > > - lpData = (LPBYTE) lpMidiHdr->lpData; > - > - if (lpData == NULL) > - return MIDIERR_UNPREPARED; > + lpData = (BYTE*)lpMidiHdr->lpData; > + > + if (!lpData) > + return MIDIERR_UNPREPARED; > if (!(lpMidiHdr->dwFlags & MHDR_PREPARED)) > - return MIDIERR_UNPREPARED; > + return MIDIERR_UNPREPARED; > if (lpMidiHdr->dwFlags & MHDR_INQUEUE) > - return MIDIERR_STILLPLAYING; > + return MIDIERR_STILLPLAYING; > lpMidiHdr->dwFlags &= ~MHDR_DONE; > lpMidiHdr->dwFlags |= MHDR_INQUEUE; Please avoid gratuitous formatting changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] wmiutils: Implement IWbemPath::RemoveNamespaceAt.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] wmiutils: Implement IWbemPath::GetNamespaceAt.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23975 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/5] wmiutils: Implement IWbemPath::SetClassName.
by Marvin 17 Jan '13

17 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23974 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

kernel32/path: tests and patches
by Patrick Rudolph 16 Jan '13

16 Jan '13

Any comments on my copyfileexW patches ?

1 0

Re: [PATCH 2/3] d3d8/tests: Create a plain DS surface in test_reset_resources
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23963 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: mshtml: Remove duplicated property entries in preprocess_dispex_data
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23961 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Reload a DLL and _getptd returns zero
by Michael Ost 16 Jan '13

16 Jan '13

On 01/12/2013 05:21 PM, Dan Kegel wrote: >> The library in question is using static vc runtime linkage, so _getptd() >> is linked in > > That's somewhat worrisome. So you have multiple instances > of the C runtime library active in the same app? > > Maybe you're not unloading that dll gracefully enough. > > Might be heap corruption. I wonder if Valgrind might be helpful. > > I second the suggestion to post a minimal testcase. Here's a link to a zip file that includes the prebuilt .exe and .dll windows binaries that crash in wine. Plus the code. https://dl.dropbox.com/u/97386125/msvcrt-dll-problem.zip So, again, the bug is that MSVCRT calls are failing when called from a DLL that has been reloaded. If the calls come from a thread and if the DLL is built with static MSVCRT runtimes. There is no crash for the program in Windows. I also tried rebuilding the code for winelib, and it doesn't appear to have the same behavior. So the problem doesn't happen if Wine's MSVCRT is used, only if a windows DLL that uses static MSVCRT linkage is reloaded. Thanks -- mo

2 5

Re: [12/15] kernel32/tests: Add ARM64 support
by Marvin 16 Jan '13

16 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23957 Your paranoid android. === WINEBUILD (build) === Making build dependencies failed

2 1

My Wine static analysis tool
by Damjan Jovanovic 15 Jan '13

15 Jan '13

Hi I've hacked together a simple tool for analyzing Wine code. Currently it can do the following: 1. Find BOOL functions returning non-BOOL. 2. Find HRESULT functions returning non-HRESULTs. 3. Generate a TRACE() for each function showing all its parameters. It isn't really a formal C parser, as it ignores all preprocessor directives, but this makes it *much* simpler and shorter than a real C parser, and it sees original Windows types like LPCWSTR etc. It's not 100% accurate, but it's very effective. 3 of my recent patches have been generated with its help - and I've barely gotten started. I'd like to add the following features at some stage: * Populate all functions with a TRACE() of their arguments, if they don't already have it. * Scan all GUIDs in include/ and generate a full list of all GUIDs and their names. Then patch debugstr_guid() to also output the name of the GUID when available, and/or search and replace GUIDs in WINEDEBUG traces after they've been recorded. * Update .spec files from .c file contents, and verify .spec file accuracy. * It could be extended to examine contents of functions and enforce the absence of W->A and 32->16 calls, etc. * etc. Anybody interested in using it or helping develop it? Regards Damjan

3 4

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum 15 Jan '13

15 Jan '13

On Tue, Jan 15, 2013 at 06:51:59PM +0100, Maarten Lankhorst wrote: > Op 07-01-13 16:58, Andrew Eikum schreef: > > This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA > > without PulseAudio. I didn't test OSS. It skips around on the ship's > > shooting noises. I've attached good and bad logs on ALSA here. > > > > [1] > > http://www.classic-retro-games.com/Zaxxon_70.html > > > I don't see anything suspicious in the log. Did it work after the complete patch series was applied or did you not test? Yeah, I was testing with the whole series when I found the problem, and rolled back patch-by-patch until I found that the first one caused it. Andrew

1 0

Re: gdi32/tests: GetTextExtentPoint should give repeatable results
by Alexandre Julliard 15 Jan '13

15 Jan '13

Daniel Jelinski <djelinski1(a)gmail.com> writes: > These are tests for bug 32529. Since commit ebaf5ea17623268fb1c0f68b1cf9a5984bd4e46e > (Don't load bitmap glyphs when using subpixel rendering in GetGlyphOutline) > GetTextExtentPoint returns different results before and after glyphs are loaded, > at least for wine's Tahoma. I don't see that here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:4818: Test succeeded inside todo block: extents different: first 76, second 76 -- Alexandre Julliard julliard(a)winehq.org

2 1

Truncate MIDI SysEx messages after termination byte
by Joerg-Cyril.Hoehle＠t-systems.com 15 Jan '13

15 Jan '13

Hi, Christian Costa wrote: >I took a look at the >alsa code and this code simply does not do what it is supposed to. I also looked at it today and noted those bogus lines you quote. Needs a patch (+ fix memory leak). However, Johannes' change is presumably different, as he wants to scan the buffer contents for a F7 terminator and ignore subsequent bytes. If I were to decide, I'd like to see more supporting evidence. I'd appreciate if Johannes would open a bug report and attach some WINEDEBUG=+midi,+mmdevapi,+alsa,+winmm,+driver,+tid,+timestamp logs to bugzilla, much like bug #26928. http://bugs.winehq.org/show_bug.cgi?id=26928 Having some logs with *complete* SysEx contents helps. There's also a "closed as abandoned" bug about microKORG http://bugs.winehq.org/show_bug.cgi?id=17608 which might be of interest to Johannes. Regards, Jörg Höhle

2 7

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Henri Verbeet 15 Jan '13

15 Jan '13

On 15 January 2013 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > -static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed) > +static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWND focus_window, BOOL windowed, > + DWORD flags) > { > D3DPRESENT_PARAMETERS present_parameters = {0}; > IDirect3DDevice9 *device; > @@ -90,7 +91,7 @@ static IDirect3DDevice9 *create_device(IDirect3D9 *d3d9, HWND device_window, HWN > present_parameters.AutoDepthStencilFormat = D3DFMT_D24S8; > > if (SUCCEEDED(IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, focus_window, > - D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device))) return device; > + flags, &present_parameters, &device))) return device; > If this fails, we're going to try hardware vertex processing again, but I don't think this is something we want to specify for every single test anyway. If this is just for a single test that needs software vertex processing, just write it out. If you already know there are going to be multiple tests like this, you could probably introduce a function like create_swvp_device().

2 1

Re: [PATCH 3/3] d3d8/tests: Add a software vertexprocessing buffer discard test (try 2)
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23943 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] mshtml: Added IHTMLScriptElement::put_text tests
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23941 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] ddraw: Only modify the ddraw destination window at the end of ddraw7_SetCooperativeLevel().
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23930 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] ddraw: Add a small tests for SetCooperativeLevel() calls with different windows.
by Marvin 15 Jan '13

15 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Wine Wiki needs your help!
by Dimi Paun 15 Jan '13

15 Jan '13

Yes it is done. Ill update the spreadsheet bit later... André Hentschel <nerv(a)dawncrow.de> wrote: >Am 14.01.2013 21:40, schrieb Andrew Eikum: >> On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote: >>> OK, we might be onto something. I've wrote a script >>> to determine the deleted pages: 20162. >>> >>> Should I just go ahead and nuke those? >>> >> >> Probably, yes. >> >> One common way for spammers to abuse wikis is to intentionally get the >> pages deleted, so that they live on permanently in the revision >> history. >> >> See this example from today: >> It's rightfully deleted as spam: >> http://wiki.winehq.org/SheriOci >> But the "Get Info" link leads you to the old revision, with the >> linkspam intact: >> http://wiki.winehq.org/SheriOci?action=recall&rev=1 >> >> I don't know if there's a way to keep Moinmoin from preserving >> revision history on deleted pages, but it might be sufficient to >> simply disable that. I doubt there's much useful history on deleted >> pages anyway. > >seems done, and know what? The wiki seems to be more than 10 times faster. (i tried e.g. editing -> preview) >good choice! >Thanks Dimi for working on this!!! > > >-- > >Best Regards, André Hentschel

1 0

Re: [PATCH 5/5] d3d8/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/5] d3d9/tests: Add a software vertexprocessing buffer discard test
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23926 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] d3d9/tests: Allow the creation of SWVP devices
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23925 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: comctl32/listview: fix icon spacing calculation [try 2]
by Nikolay Sivov 14 Jan '13

14 Jan '13

On 1/15/2013 00:53, Daniel Jelinski wrote: > + if(lParam == -1) > + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); > + return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), HIWORD(lParam)); Why do you need to handle this case specially? If it's -1 for 64bit comctl32 it should give you the same values with HIWORD/LOWORD as it does for 32bit.

2 7

Patches for winspool.drv and other locations
by Detlef Riekenberg 14 Jan '13

14 Jan '13

Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: > - if(!pDeviceName) { > + if(!pDeviceName && !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not test such a code change. -- By by ... Detlef

1 0

Re: user32/tests: Add test for SetScrollInfo().
by Alexandre Julliard 14 Jan '13

14 Jan '13

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +static void test_setscrollinfo ( HWND hwnd, INT nBar ) > +{ > + SCROLLINFO cur, expected; > + char ok_format[] = "unexpected state: (bar: %d)\n" > + " expected: min: %d, max: %d, page: %d, pos: %d\n" > + " got: min: %d, max: %d, page: %d, pos: %d\n"; > +#define SCROLL_OK_ARGS nBar, \ > + expected.nMin, expected.nMax, expected.nPage, expected.nPos, \ > + cur.nMin, cur.nMax, cur.nPage, cur.nPos Please avoid that sort of macro abuse. Write an inline function if you don't want to duplicate the ok statement. -- Alexandre Julliard julliard(a)winehq.org

1 0

testbot
by Daniel Jelinski 14 Jan '13

14 Jan '13

Hello, the testbot does not revert patches submitted through testbot.winehq.org after testing. As a result it is almost impossible to test another patch affecting the same area in code as a previous one. Could anyone please fix it? Or at least add git reset to cron... Regards, Daniel

1 0

Re: comctl32/listview: fix icon spacing calculation [try 2]
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23921 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: include: flesh out d3d11.idl (try 2)
by Dmitry Timoshkov 14 Jan '13

14 Jan '13

Austin English <austinenglish(a)gmail.com> wrote: > Try 2: > Remove L suffixes, C++ comment. > +/* Forward declarations */ You've copied too much from the PSDK version, better leave it to someone else, and do it step by step when particular functionality gets implemented. -- Dmitry.

3 4

Re: vbscript: Added support for more constants
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23911 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] xmllite: Support whitespace nodes reporting
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23910 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters (try 3)
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23904 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] wmiutils: Implement IWbemPath::GetClassName.
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23902 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] kernel32: implement condition variables
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23900 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.
by Vincent Povirk 14 Jan '13

14 Jan '13

Looks good to me.

1 0

Re: windowscodecs: Implement CreateBitmapFromHICON. Take 2.
by Marvin 14 Jan '13

14 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23899 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Reload a DLL and _getptd returns zero
by Michael Ost 13 Jan '13

13 Jan '13

Hi list, Does anyone know why _getptd() calls would return zero on a DLL that has been reloaded? Does something happen to the TLS used by _getptd? At Muse Research we have been struggling with a deep bug for years where there is a crash _sometimes_ if you load a DLL a second time. Finally (with a big tip of the hat to Julien Pommier at PianoTeq!) we have a test case that demonstrates a (if not _the_) crash. The sequence is: 1. [main] start a thread 2. [main] load a library 3. [thread] call std::cout<< from the library 4. [main] free the library 5. [main] reload the library 6. [thread] call std::cout<< from the library -> crash! It looks like the crash happens because the MSVCRT function _getptd() is returning zero in step 6. This is dereferenced and crashes. In windows, there is no crash. The library in question is using static vc runtime linkage, so _getptd() is linked in and I don't know exactly what it is doing. But Wine's MSVCRT implementation of _getptd() gets its data from TlsGetValue. And I can see that just before the crash there is a TlsGetValue call that returns zero. Looking at TlsGetValue(), there must be something wrong with the values in TlsSlots. Maybe they persist for DLLs in Windows in a way they don't for Wine...? Or maybe Wine doesn't reinitialize them the same way when the DLL is reloaded? Any hints, thoughts? clues? Thanks! -- Michael Ost

4 4

Re: comctl32/listview: fix icon spacing calculation
by Nikolay Sivov 13 Jan '13

13 Jan '13

On 1/14/2013 00:00, Daniel Jelinski wrote: > -static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, INT cx, INT cy) > +static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, WORD cx, WORD cy) I don't really like it as WORD, what it really is a int value with special meaning reserved for -1. For 64bits and lParam == -1 you'll still get two -1 values. > + /* LPARAM = -1 - restore default processing */ > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELPARAM(-1,-1)); > +todo_wine > + expect(100, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > + > + /* NOTE: -1 is not the same as MAKELPARAM(-1,-1) in 64bit listview */ > + if(sizeof(LPARAM) == 8) > + { > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, -1); > +todo_wine { > + expect(0xFFFF, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > + } > + } That means you should just use lParam == -1. Also this message is supposed to use MAKELONG apparently, not sure if it makes a difference.

1 0

Re: comctl32/listview: fix icon spacing calculation
by Marvin 13 Jan '13

13 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23897 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] advapi32: add RegSetKeyValue{A,W}
by Nikolay Sivov 13 Jan '13

13 Jan '13

On 1/13/2013 09:27, danielfsantos(a)att.net wrote: > Adds RegSetKeyValue{A,W} to advapi32.dll > Refactors RegSetValue{A,W} to call RegSetKeyValue{A,W} > Fixes bug #32711 > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/registry.c | 81 +++++++++++++++++++++++++++++++++---------- > 2 files changed, 64 insertions(+), 21 deletions(-) > > diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec > index 21357fa..336518b 100644 > --- a/dlls/advapi32/advapi32.spec > +++ b/dlls/advapi32/advapi32.spec > @@ -645,8 +645,8 @@ > # @ stub RegSaveKeyExW > @ stdcall RegSaveKeyW(long ptr ptr) > @ stdcall RegSetKeySecurity(long long ptr) > -# @ stub RegSetKeyValueA > -# @ stub RegSetKeyValueW > +@ stdcall RegSetKeyValueA(long str str long ptr long) > +@ stdcall RegSetKeyValueW(long str str long ptr long) This should use wstr. > +LSTATUS WINAPI RegSetValueW( HKEY hkey, LPCWSTR name, DWORD type, LPCWSTR data, DWORD count ) > +{ > + return RegSetKeyValueW(hkey, name, NULL, type, data, count); > +} Don't use tabs please. And as I said in bug comment this needs tests.

1 0

Re: libwine: Use rpath-based install name and library references for libwine on Mac.
by Alexandre Julliard 12 Jan '13

12 Jan '13

Ken Thomases <ken(a)codeweavers.com> writes: > --- > configure.ac | 3 ++- > libs/wine/Makefile.in | 6 +++--- > 2 files changed, 5 insertions(+), 4 deletions(-) It doesn't seem to work when installed: wine: failed to initialize: dlopen(/usr/local/lib/wine/ntdll.dll.so, 258): image not found -- Alexandre Julliard julliard(a)winehq.org

2 4

Problem with editing FAQ and other pages at wiki
by Romanoff Alexei 12 Jan '13

12 Jan '13

Hello! I've tried editing wine FAQ and several other wiki pages, but failed. When I click on "Preview" or "Save" buttons, I always see error message like [Errno 31] Too many links: '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' If you want to report a bug, please save this page and attach it to your bug report. A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred. 1. /usr/lib/python2.4/site-packages/MoinMoin/request.py in *run* (self=<MoinMoin.request.RequestModPy object>) 1. 1170 self.page.send_page(self, msg=msg) 2. 1171 else: 3. 1172 handler(self.page.page_name, self) 4. 1173 5. 1174 # generate page footer (actions that do not want this footer use - *handler* = <function do_edit> - *self* = <MoinMoin.request.RequestModPy object> - self.*page* = <MoinMoin.Page.Page instance> - self.page.*page_name* = u'FAQ' 2. /usr/lib/python2.4/site-packages/MoinMoin/wikiaction.py in *do_edit* (pagename=u'FAQ', request=<MoinMoin.request.RequestModPy object>) 1. 651 request.form.has_key('button_spellcheck') or 2. 652 request.form.has_key('button_newwords')): 3. 653 pg.sendEditor(preview=savetext, comment=comment) 4. 654 5. 655 # Preview with mode switch - *pg* = <MoinMoin.PageEditor.PageEditor instance> - pg.*sendEditor* = <bound method PageEditor.sendEditor of <MoinMoin.PageEditor.PageEditor instance>> - preview *undefined* - *savetext* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" - *comment* = u'Fixed shell code example with invalid redirection of stderr to stdout instead of file' 3. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *sendEditor* (self=<MoinMoin.PageEditor.PageEditor instance>, **kw={'comment': u'Fixed shell code example with invalid redirection of stderr to stdout instead of file', 'preview': u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n"}) 1. 284 # Make backup on previews - but not for new empty pages 2. 285 if preview and raw_body: 3. 286 self._make_backup(raw_body) 4. 287 5. 288 # Generate default content for new pages - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*_make_backup* = <bound method PageEditor._make_backup of <MoinMoin.PageEditor.PageEditor instance>> - *raw_body* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" 4. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *_make_backup* (self=<MoinMoin.PageEditor.PageEditor instance>, newtext=u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n", **kw={}) 1. 738 intro += _('## backup of page "%(pagename)s" submitted %(date)s') % { 2. 739 'pagename': pagename, 'date': date,} + u'\n' 3. 740 backuppage._write_file(intro + newtext) 4. 741 5. 742 return backuppage.url(self.request) - *backuppage* = <MoinMoin.PageEditor.PageEditor instance> - backuppage.*_write_file* = <bound method PageEditor._write_file of <MoinMoin.PageEditor.PageEditor instance>> - *intro* = u'#acl AlexeiRomanoff:read,write,delete All:\n\n' - *newtext* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" 5. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *_write_file* (self=<MoinMoin.PageEditor.PageEditor instance>, text=u'#acl AlexeiRomanoff:read,write,delete All:\n\n#pra..., it can delete your entire hard drive.\nDeleted/\n', action='SAVE', comment=u'', extra=u'') 1. 801 # The local log should be the standard edit log, not the 2. 802 # underlay copy log! 3. 803 pagelog = self.getPagePath('edit-log', use_underlay=0, isfile=1) 4. 804 llog = editlog.EditLog(self.request, filename=pagelog, 5. 805 uid_override=self.uid_override) - pagelog *undefined* - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*getPagePath* = <bound method PageEditor.getPagePath of <MoinMoin.PageEditor.PageEditor instance>> - use_underlay *undefined* - isfile *undefined* 6. /usr/lib/python2.4/site-packages/MoinMoin/Page.py in *getPagePath* (self=<MoinMoin.PageEditor.PageEditor instance>, *args=('edit-log',), **kw={'isfile': 1, 'use_underlay': 0}) 1. 348 """Return path to the page storage area.""" 2. 349 3. 350 return self.getPageStatus(*args, **kw)[1] 4. 351 5. 352 def split_title(self, request, force=0): - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*getPageStatus* = <bound method PageEditor.getPageStatus of <MoinMoin.PageEditor.PageEditor instance>> - *args* = ('edit-log',) - *kw* = {'isfile': 1, 'use_underlay': 0} 7. /usr/lib/python2.4/site-packages/MoinMoin/Page.py in *getPageStatus* (self=<MoinMoin.PageEditor.PageEditor instance>, *args=('edit-log',), **kw={'isfile': 1, 'use_underlay': 0}) 1. 342 dirname = fullpath 2. 343 if not os.path.exists(dirname): 3. 344 filesys.makeDirs(dirname) 4. 345 return underlay, fullpath 5. 346 - *global* *filesys* = <module 'MoinMoin.util.filesys' from '/usr/lib/python2.4/site-packages/MoinMoin/util/filesys.pyc'> - filesys.*makeDirs* = <function makedirs> - *dirname* = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' 8. /usr/lib/python2.4/site-packages/MoinMoin/util/filesys.py in *makedirs* (name='/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup', mode=511) 1. 49 return 2. 50 try: 3. 51 os.mkdir(name, mode & config.umask) 4. 52 except OSError, err: 5. 53 if err.errno != errno.EEXIST: - *global* *os* = <module 'os' from '/usr/lib/python2.4/os.pyc'> - os.*mkdir* = <built-in function mkdir> - *name* = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - *mode* = 511 - *global* *config* = <module 'MoinMoin.config' from '/usr/lib/python2.4/site-packages/MoinMoin/config.pyc'> - config.*umask* = 504 OSError [Errno 31] Too many links: '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - args = (31, 'Too many links') - errno = 31 - filename = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - strerror = 'Too many links' It seems, something wrong happened at server side with MoinMoin. But how could be possible to contribute, if wiki isn't editable? I haven't found any specific mailing list or forum for wiki editors and decided to write here. -- Best regards, Alexei Romanoff software developer, Melesta

3 4

Re: Ken Thomases : libwine: Use rpath-based install name and library references for libwine on Mac.
by Charles Davis 11 Jan '13

11 Jan '13

On Jan 11, 2013, at 12:46 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: f377591e98c490ca00e6479627832e41b2ad01b9 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=f377591e98c490ca00e647962… > > Author: Ken Thomases <ken(a)codeweavers.com> > Date: Fri Jan 11 03:25:07 2013 -0600 > > libwine: Use rpath-based install name and library references for libwine on Mac. Huh? I thought this broke running installed Wine for you. Why did you commit this anyway? (Or is there another email message that I didn't see? Gmail has been acting wonky lately about delivering my email...) Chip

2 1

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation.
by Vincent Povirk 11 Jan '13

11 Jan '13

You appear to be leaking the IWICBitmapLock object. Also, it seems odd that you're using the buffer AND IWICBitmapLock. I assume the point of passing a buffer to BitmapImpl_Create (and wasting a bit of time/memory) was to avoid IWICBitmapLock.

2 1

Re: kernel32/tests : try3 added tests for copyfileex
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Patrick Rudolph <siro(a)das-labor.org> wrote: > + if (!pCopyFileExA) > + win_skip("CopyFileExA is not available\n"); Continuing at this point doesn't seem much useful. Also you need to use pCopyFileExA instead of direct CopyFileExA calls everywhere in the test, otherwise .exe won't even load under Windows due to dynamic linking errors. Sorry, I missed that in previous review. -- Dmitry.

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation. Resend.
by Vincent Povirk 11 Jan '13

11 Jan '13

I hadn't noticed you had resent this, and made comments on the earlier mail which still apply.

1 0

Re: kernel32/tests : try3 added tests for copyfileex
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23881 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters
by Henri Verbeet 11 Jan '13

11 Jan '13

On 11 January 2013 09:49, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright 2006-2007, 2010 Stefan Dösinger for CodeWeavers > + * Copyright 2006-2008,2010-2011,2013 Stefan Dösinger for CodeWeavers I'm going to assume you're changing this because you checked it, but the formatting is a bit off. > + memset(&caps, 0, sizeof(caps)); That's redundant.

2 2

Re: [PATCH 2/2] d3d8: Return D3D_OK from the palette setters (try 2)
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23877 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Merge surface.c into device.c.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23875 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Merge texture.c into device.c.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23874 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation. Resend.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23872 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON. Take 2.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23871 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXFileDataImpl_Lock and ID3DXFileDataImpl_Unlock.
by Rico Schüller 11 Jan '13

11 Jan '13

On 11.01.2013 09:40, Christian Costa wrote: > static HRESULT WINAPI ID3DXFileDataImpl_Unlock(ID3DXFileData *iface) > { > - FIXME("(%p)->(): stub\n", iface); > + TRACE("(%p)->()\n", iface); > > - return E_NOTIMPL; > + /* Nothing to do */ > + > + return S_OK; > } Hi Christian, I stumble over MSDN, it says in Remarks on http://msdn.microsoft.com/de-de/library/windows/desktop/bb205846%28v=vs.85%… ... from that sentence I'd think that you have to do some lock count. A test would probably be nice. Though, msdn has a bool as return value for the unlock function but in the header it's a HRESULT... Is msdn wrong here? Cheers Rico

2 1

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON.
by Nikolay Sivov 11 Jan '13

11 Jan '13

On 1/11/2013 14:39, Dmitry Timoshkov wrote: > + icon = CreateIconIndirect(&info); > + ok(icon != 0, "CreateIconIndirect failed\n"); > + DeleteObject(info.hbmColor); > + DeleteObject(info.hbmMask); > + > + hr = IWICImagingFactory_CreateBitmapFromHICON(factory, icon, &bitmap); > + ok(hr == S_OK, "CreateBitmapFromHICON error %#x\n", hr); > + > + IWICBitmap_GetPixelFormat(bitmap, &format); > + ok(IsEqualGUID(&format, &GUID_WICPixelFormat32bppBGRA), > + "unexpected pixel format %s\n", debugstr_guid(&format)); > + > + IWICBitmap_GetSize(bitmap, &width, &height); > + ok(hr == S_OK, "IWICBitmap_GetSize error %#x\n", hr); > + ok(width == 16, "expected 16, got %u\n", width); > + ok(height == 16, "expected 16, got %u\n", height); > + > + IWICBitmap_Release(bitmap); > +} Who is responsible for freeing icon handle? I guess it should be done here cause your implementation doesn't free it either.

3 4

Re: [PATCH 6/6] msvcrt: Added fwprintf tests
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23870 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23866 Your paranoid android. === WXPPROSP3 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === WVISTAADM (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PRO (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PROX64 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === TEST64_W7SP1 (32 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === W7PROX64 (64 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192 === TEST64_W7SP1 (64 bit bitmap) === bitmap.c:492: Test failed: 2: expected 255, got 192 bitmap.c:510: Test failed: 2: expected 255, got 192

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation.
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23867 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] d3d8: Return D3D_OK from the palette setters
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23865 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23864 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: kernel32/tests : try2 added tests for copyfileex
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

siro(a)das-labor.org wrote: > OK, but how do I know that the old behavior is broken ? WindowsXp behaves > like msdn quotes while newer windows don't. Do you always assume that the > latest implementation is correct ? Should wine just match the latest > test-results and ignore osversioninfo at all ? It's reasonable to assume that a later Windows implementation should be considered as the one to follow. Changing the reported Windows version in winecfg doesn't change an API behaviour (there are exceptions, but they don't apply in this case). -- Dmitry.

1 0

Re: kernel32/tests : try2 added tests for copyfileex
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Patrick Rudolph <siro(a)das-labor.org> wrote: > try2: > check the os version in case of PROGRESS_STOP > + ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, (void*)&fileInfo); > + > + /* Windows Vista and newer delete the file, while prior versions don't */ > + ok((!ret && info.dwMajorVersion > 5) || (ret && info.dwMajorVersion <= 5), > + "GetFileAttributesEx return-value wrong, got %u and MajorVersion is %u\n", ret, info.dwMajorVersion); Then you should mark old behaviour as broken() and don't check Windows version at all. -- Dmitry.

2 1

Re: d3dx9: Implement D3DXSHEvalConeLight (resend)
by Marvin 11 Jan '13

11 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23862 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32: fix non-BOOL returns in BOOL functions
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * user32: fix non-BOOL returns in BOOL functions GetClassInfo is special, it actually returns class atom on success, not just a boolean value. So it's better to leave it as it is now. -- Dmitry.

1 0

Re: [PATCH 2/4] kernel32/path : try2 implement copyfileexW progressroutine callback
by Dmitry Timoshkov 11 Jan '13

11 Jan '13

Patrick Rudolph <siro(a)das-labor.org> wrote: > try 2: > set progress routine pointer to NULL to disable progress reporting > test osversion and delete destination file on PROGRESS_STOP on vista > and newer This kind of version check is useless in Wine. -- Dmitry.

1 0

Re: [2/2] comctl32/listview: Add a special case for deselect all attempt when nothing is selected
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23861 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: include: flesh out d3d11.idl
by Nikolay Sivov 10 Jan '13

10 Jan '13

On 1/10/2013 22:35, Austin English wrote: Some minor things. > +typedef enum D3D11_RESOURCE_DIMENSION > +{ > + D3D11_RESOURCE_DIMENSION_UNKNOWN = 0, > + D3D11_RESOURCE_DIMENSION_BUFFER = 1, > + D3D11_RESOURCE_DIMENSION_TEXTURE1D = 2, > + D3D11_RESOURCE_DIMENSION_TEXTURE2D = 3, > + D3D11_RESOURCE_DIMENSION_TEXTURE3D = 4, > +} D3D11_RESOURCE_DIMENSION; > + You could remove values in cases like that, result will be the same. > + D3D11_BIND_VERTEX_BUFFER = 0x00000001L, I think L suffix could be omitted. > +//FIXME: ...

1 0

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.
by Matteo Bruni 10 Jan '13

10 Jan '13

2013/1/10 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/texture.c | 6 +++--- > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(- > > - DWORD i, v; > + DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << format->bits[c]) - 1); Usually we prefer to use ~0U instead of -1 with unsigned variables. Nice cleanups and fixes for larger pixel formats. Is this for Alan Wake?

2 1

Re: Truncate MIDI SysEx messages after termination byte
by Johannes Kroll 10 Jan '13

10 Jan '13

On Wed, 9 Jan 2013 16:10:18 +0100 Christian Costa <titan.costa(a)gmail.com> wrote: > 2013/1/9 Johannes Kroll <jkroll(a)lavabit.com> > > > On Wed, 09 Jan 2013 10:19:54 +0100 > > Christian Costa <titan.costa(a)gmail.com> wrote: > > > > > Le 09/01/2013 04:26, Johannes Kroll a écrit : > > > > Hi, > > > > > > > > On Wed, 09 Jan 2013 03:55:25 +0100 > > > > Christian Costa <titan.costa(a)gmail.com> wrote: > > > > > > > >> Hi, > > > >> > > > >> Please be consistent when using space. 1 space before and after > > > >> operators (<, ==, =, ...). > > > > spaces inserted. HTH. > > > > > > > > J. > > > That's better. You forgot some occurences in the for loop though. > > > > Is it OK if I leave the rest of the formatting to you? Any style is > > fine with me, whatever makes you happy and hopefully gets the patch > > included. > > > > Formatting only patch are not allowed. Clean patch and consistency in code > style help your patch get in. > Alexandre Julliard is the only judge not me. If he is ok with your patch > that's fine. > Anyway having the for loop consistent with rest should not be that hard. > > for(i= 0; i<lpMidiOutHdr->dwBufferLength; i++) The original patch was consistent with my coding style. To make assignments stick out visually, I use no space to the left of the assignment operator, one space to the right. On comparison operators, I use space either on both sides, or none. You will see this in all code I write. I attached another version of the patch. I added 3 more spaces and one line break in a long comment line. You or Alexandre can choose the version they like best. If you still see style issues, please consider changing the style to your liking. If that's not possible, the patch will have to be rejected. If anybody sees non-style-related issues with the patch, please let me know. Please keep any replies on the list(s). Have a nice day. Johannes

2 8

Re: [PATCH] d3dx9: Shift only as much as needed.
by Rico Schüller 10 Jan '13

10 Jan '13

Hi, please don't apply this patch. There are several other occurrences in the same file. I'll send an improved version. Cheers Rico On 10.01.2013 13:55, Rico Schüller wrote: > Hi, > > this patch removes useless shifts, which may result in wrong data when > the shift is bigger than 24. > > Cheers > Rico > > --- > dlls/d3dx9_36/texture.c | 15 ++++++++++++--- > 1 Datei geändert, 12 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) > > > > >

1 0

Re: [2/2] comctl32/listview: Use LVM_SETITEMSTATE directly in tests
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23848 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 3)
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23842 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Merge query.c into device.c.
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23841 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Merge buffer.c into device.c.
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23840 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 17/17] msvcrt: Added read tests on unicode files
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23838 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 13/17] msvcrt: Added _setmode tests
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23836 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/17] msvcrt: Added write tests on unicode files
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23835 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 05/17] msvcrt: Added fopen_s test with ccs option
by Marvin 10 Jan '13

10 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23834 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 0/7] Series short description
by Alexandre Julliard 09 Jan '13

09 Jan '13

Eric Pouech <eric.pouech(a)orange.fr> writes: > The following series implements a new scheme for managing 'bare' consoles. > We now force every program started without a wine parent to be run under > wineconsole (transparently for the user). > This is done using a new backend in wineconsole called 'line'. This backend > only takes care of input; output is kept as a client side operation. > All terminal related code is moved from dlls/kernel32 to programs/wineconsole. > > This basically ensures that: > - Only wineconsole reads from standard input (and writes into input queue). > This fixes bug reported by Jason when $CONIN is opened with read access only. > - It also enforces that wineconsole always has control of the unix terminal, > hence ensuring that we properly reset the terminal settings upon exit. Running make test with this series hangs in the hlink.c test, there seems to be a wineconsole process that never terminates. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] crypt32: free the encoded msg (Coverity)
by Juan Lang 09 Jan '13

09 Jan '13

In case this was awaiting an ACK from me, this looks good. Thanks. --Juan

1 0

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable
by Huw Davies 09 Jan '13

09 Jan '13

On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: > +typedef struct { > + WORD LigatureAnchor[1]; > +} GPOS_ComponentRecord; > + > +typedef struct { > + WORD ComponentCount; > + GPOS_ComponentRecord ComponentRecord[1]; > +} GPOS_LigatureAttach; > + > + for (i = 0; i < component_count && !offset; i++) > + { > + int k; > + for (k = 0; k < class_count && !offset; k++) > + offset = GET_BE_WORD(lt->ComponentRecord[i].LigatureAnchor[k]); > + } Hi Aric, This can't work as ComponentRecord is a variable-sized struct. Huw.

2 1

Re: [PATCH (try3)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23822 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3d8/tests: Merge surface.c into device.c.
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23820 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: aclocal: Use -Werror when checking compiler flags (try 2)
by Alexandre Julliard 09 Jan '13

09 Jan '13

Per Johansson <per(a)morth.org> writes: > ...if supported by compiler. > This makes clang exit with error on unsupported warnings. > --- > aclocal.m4 | 2 +- > configure.ac | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 14cf916..a6d9f12 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 > @@ -74,7 +74,7 @@ AC_DEFUN([WINE_TRY_CFLAGS], > [AS_VAR_PUSHDEF([ac_var], ac_cv_cflags_[[$1]])dnl > AC_CACHE_CHECK([whether the compiler supports $1], ac_var, > [ac_wine_try_cflags_saved=$CFLAGS > -CFLAGS="$CFLAGS $1" > +CFLAGS="$CFLAGS $ac_wine_try_cflags_werror $1" > AC_LINK_IFELSE([AC_LANG_SOURCE([[int main(int argc, char **argv) { return 0; }]])], > [AS_VAR_SET(ac_var,yes)], [AS_VAR_SET(ac_var,no)]) aclocal macros should be stand-alone, they shouldn't depend on things done by the main configure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.
by Vincent Povirk 09 Jan '13

09 Jan '13

Series looks fine to me. And yes, testbot has been broken for a while now..

1 0

Re: [PATCH 5/5] d3d8/tests: Merge surface.c into device.c.
by Alexandre Julliard 09 Jan '13

09 Jan '13

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/d3d8/tests/Makefile.in | 1 - > dlls/d3d8/tests/device.c | 704 ++++++++++++++++++++++++++++++++++++++++++- > dlls/d3d8/tests/surface.c | 653 --------------------------------------- > 3 files changed, 702 insertions(+), 656 deletions(-) > delete mode 100644 dlls/d3d8/tests/surface.c It doesn't work here: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok device.c:4088: Test failed: Got unexpected hr 0x88760867. device.c:4091: Test failed: Got unexpected refcount 3, expected 4. device.c:4092: Test failed: Got unexpected ptr 0x15, expected 0x21fdb8. wine: Unhandled page fault on read access to 0x00000015 at address 0x684e3686 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Jacek Caban 09 Jan '13

09 Jan '13

Hi Andrew, On 01/09/13 16:56, Andrew Eikum wrote: > --- > > This should fix the Office 2007 half of Bug 17271. > > try2: Fix test failures on XP by expanding the expected path name. > > dlls/ieframe/navigate.c | 7 +++++- > dlls/ieframe/tests/webbrowser.c | 56 ++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 59 insertions(+), 4 deletions(-) > > > 0001-ieframe-Strip-file-from-file-URLs-in-BEFORENAVIGATE2.patch > > > diff --git a/dlls/ieframe/navigate.c b/dlls/ieframe/navigate.c > index dd4a976..2601ba8 100644 > --- a/dlls/ieframe/navigate.c > +++ b/dlls/ieframe/navigate.c > @@ -566,6 +566,8 @@ static void on_before_navigate2(DocHost *This, LPCWSTR url, SAFEARRAY *post_data > VARIANT var_url, var_flags, var_frame_name, var_post_data, var_post_data2, var_headers; > DISPPARAMS dispparams; > VARIANTARG params[7]; > + WCHAR file_path[MAX_PATH]; > + DWORD file_path_len = sizeof(file_path) / sizeof(*file_path); > > dispparams.cArgs = 7; > dispparams.cNamedArgs = 0; > @@ -607,7 +609,10 @@ static void on_before_navigate2(DocHost *This, LPCWSTR url, SAFEARRAY *post_data > V_VT(params+5) = (VT_BYREF|VT_VARIANT); > V_VARIANTREF(params+5) = &var_url; > V_VT(&var_url) = VT_BSTR; > - V_BSTR(&var_url) = SysAllocString(url); > + if(PathCreateFromUrlW(url, file_path, &file_path_len, 0) == S_OK) > + V_BSTR(&var_url) = SysAllocString(file_path); > + else > + V_BSTR(&var_url) = SysAllocString(url); > > V_VT(params+6) = (VT_DISPATCH); > V_DISPATCH(params+6) = (IDispatch*)This->wb; > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index 25cce8a..70c785b 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -151,7 +151,7 @@ static VARIANT_BOOL exvb; > static IWebBrowser2 *wb; > > static HWND container_hwnd, shell_embedding_hwnd; > -static BOOL is_downloading, is_first_load, use_container_olecmd, test_close, is_http, use_container_dochostui; > +static BOOL is_downloading, is_first_load, use_container_olecmd, test_close, is_http, is_file, use_container_dochostui; > static HRESULT hr_dochost_TranslateAccelerator = E_NOTIMPL; > static HRESULT hr_site_TranslateAccelerator = E_NOTIMPL; > static const char *current_url; > @@ -690,8 +690,14 @@ static void test_OnBeforeNavigate(const VARIANT *disp, const VARIANT *url, const > ok(V_VT(V_VARIANTREF(url)) == VT_BSTR, "V_VT(V_VARIANTREF(url))=%d, expected VT_BSTR\n", > V_VT(V_VARIANTREF(url))); > ok(V_BSTR(V_VARIANTREF(url)) != NULL, "V_BSTR(V_VARIANTREF(url)) == NULL\n"); > - ok(!strcmp_wa(V_BSTR(V_VARIANTREF(url)), current_url), "unexpected url %s, expected %s\n", > - wine_dbgstr_w(V_BSTR(V_VARIANTREF(url))), current_url); > + if(is_file){ > + char full_path[MAX_PATH]; > + GetLongPathNameA(current_url, full_path, sizeof(full_path)); I think expanding the path would be better done while constructing the URL instead of here. + test_DoVerb(webbrowser); + test_Navigate2(webbrowser, file_url); + + IWebBrowser2_Release(webbrowser); This is not enough for proper clean up. You may verify that by checking ref count here. At least setting client site to NULL is needed. Cheers, Jacek

1 0

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3320: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3461: Test failed: Creating WebBrowser object failed: 80040154 webbrowser: unhandled exception c0000005 at 0040816F === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2607: Test failed: expected GetOverridesKeyPath webbrowser.c:2612: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2613: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3046: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21 === WXPPROSP3 (32 bit webbrowser) === webbrowser.c:693: Test failed: unexpected url L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\wine_test.html", expected C:\DOCUME~1\winetest\LOCALS~1\Temp\wine_test.html === W2K3R2SESP2 (32 bit webbrowser) === webbrowser.c:693: Test failed: unexpected url L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\wine_test.html", expected C:\DOCUME~1\winetest\LOCALS~1\Temp\wine_test.html

1 0

Re: Truncate MIDI SysEx messages after termination byte
by Christian Costa 09 Jan '13

09 Jan '13

Le 09/01/2013 03:12, Johannes Kroll a écrit : > While using the KORG Kontrol Editor software [1] under Wine to configure > my nanoPAD2 MIDI controller, I noticed that uploading parameters to the > hardware doesn't work. The program displays a timeout message. > > The program relies on the MIDI driver to remove data after the SysEx > termination byte [2], but the Wine's winmm implementation doesn't do > this. The complete MIDIHDR buffer is sent, including excess bytes in the > case when the buffer is larger than the MIDI message. > > The attached patch fixes the problem by truncating SysEx messages after > the termination byte, ignoring any excess bytes. > > I tested the patch with KORG Kontrol Editor under Ubuntu 12.04 64-bit > (32-bit wine). > > [1] http://www.korg.co.uk/support/downloads/nano2_dl.php > [2] http://home.roadrunner.com/~jgglatt/tech/midispec/sysex.htm > > Hi, Please be consistent when using space. 1 space before and after operators (<, ==, =, ...). Christian

2 3

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback
by Nikolay Sivov 09 Jan '13

09 Jan '13

On 1/8/2013 22:19, Patrick Rudolph wrote: > + BOOL progressRoutine_enabled = progressRoutine != 0; Why do you need this? You could always check for callback pointer directly.

2 2

Re: vbscript: Added support for a few more constants
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23812 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23802 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [2/2] windowscodecs: BMP decoder should always return valid image resolution.
by Marvin 09 Jan '13

09 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23803 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback
by Nikolay Sivov 08 Jan '13

08 Jan '13

On 1/8/2013 22:19, Patrick Rudolph wrote: > This should fix bug http://bugs.winehq.org/show_bug.cgi?id=29232 > It fixes lots of tests on wine. That's suspicious cause you don't have test diff in this patch. > >

1 0

Re: kernel32/tests : added tests for copyfileex
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23794 Your paranoid android. === WVISTAADM (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W2K8SE (32 bit path) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W7PRO (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W7PROX64 (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === TEST64_W7SP1 (32 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === W7PROX64 (64 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0 === TEST64_W7SP1 (64 bit path) === path.c:1809: Test failed: Expected GetFileAttributesEx to return nonzero, got 0

1 0

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Nikolay Sivov 08 Jan '13

08 Jan '13

On 1/8/2013 16:34, Tatyana Fokina wrote: > + > + memset(a, 'a', sizeof(a)); > + SetLastError(NO_ERROR); > + ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a)); > + error = GetLastError(); > + ok(!error && ret == CSTR_EQUAL, "ret %d (expected %d), error %d\n", ret, CSTR_EQUAL, error); It's better to set it to some value you don't expect to be ever used as error code, like 0xdeadbeef or 0xb19b00b5.

2 1

[PATCH] winspool.drv: Ignore pDevModeInput if fMode not equal DM_IN_BUFFER
by Tatyana Fokina 08 Jan '13

08 Jan '13

1 0

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23793 Your paranoid android. === W2K8SE (32 bit locale) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [2/3] xmllite: Report value for PI nodes
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23792 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Report node value for comment nodes
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23791 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d8/tests: Merge d3d8_main.c into device.c.
by Marvin 08 Jan '13

08 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23788 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] dplayx: check return of CoCreateInstance (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23787 Your paranoid android. === W2K8SE (32 bit dplayx) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 2)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === W2K8SE (32 bit ddraw7) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W2K8SE (32 bit ddraw4) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] advapi32: close scm_handle on error exit (Coverity)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23785 Your paranoid android. === W2KPROSP4 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === WXPPROSP3 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K3R2SESP2 (32 bit service) === service.c:1859: Test failed: Expected ERROR_INSUFFICIENT_BUFFER, got 487 service.c:1862: Test failed: Expected QueryServiceObjectSecurity to succeed: result 0 === W2K8SE (32 bit service) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 7/7] d3dcompiler43/tests: Don't use IUnknown_Release(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23784 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] d3dx9: Handle invalid byte code in D3DXGetShaderConstantTableEx(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23783 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] d3dx9: Always set the table = NULL in D3DXGetShaderConstantTableEx(). (resend)
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23782 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: windowscodecs: Don't copy extra data from the end of a row.
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23777 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section. [try 2]
by Alexandre Julliard 07 Jan '13

07 Jan '13

Ken Thomases <ken(a)codeweavers.com> writes: > @@ -731,11 +731,13 @@ case $host_os in > AC_SUBST(IOKITLIB,"-framework IOKit -framework CoreFoundation") > AC_SUBST(APPLICATIONSERVICESLIB,"-framework ApplicationServices") > AC_SUBST(CORESERVICESLIB,"-framework CoreServices") > + AC_SUBST(WINE_INFO_PLIST,"wine_info.plist") > + AC_CONFIG_FILES(loader/$WINE_INFO_PLIST) This should be generated from the Makefile. The convention is that configure generates makefiles, and makefiles generate the rest. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.
by Charles Davis 07 Jan '13

07 Jan '13

On Jan 6, 2013, at 6:54 PM, Ken Thomases wrote: > diff --git a/loader/wine_info.plist.in b/loader/wine_info.plist.in > new file mode 100644 > index 0000000..c332649 > --- /dev/null > +++ b/loader/wine_info.plist.in > @@ -0,0 +1,28 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> > +<plist version="1.0"> > +<dict> > + <key>CFBundleDevelopmentRegion</key> > + <string>English</string> > + <key>CFBundleExecutable</key> > + <string>wine</string> > + <key>CFBundleIdentifier</key> > + <string>org.winehq.wine</string> > + <key>CFBundleInfoDictionaryVersion</key> > + <string>6.0</string> > + <key>CFBundleName</key> > + <string>Wine</string> > + <key>CFBundlePackageType</key> > + <string>APPL</string> > + <key>CFBundleShortVersionString</key> > + <string>@PACKAGE_VERSION@</string> > + <key>CFBundleSignature</key> > + <string>????</string> > + <key>CFBundleVersion</key> > + <string>@PACKAGE_VERSION@</string> > + <key>LSMinimumSystemVersion</key> > + <string>10.6</string> With this, you won't be able to launch Wine from the Finder or with open(1) prior to 10.6. Chip > + <key>NSPrincipalClass</key> > + <string>WineApplication</string> > +</dict> > +</plist> >

4 4

Re: wininet: Fixed handling NULL buffer in INTERNET_OPTION_PROXY queries
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23776 Your paranoid android. === W2K8SE (32 bit internet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/5] dsound: rework ugly mixer logic
by Andrew Eikum 07 Jan '13

07 Jan '13

This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA without PulseAudio. I didn't test OSS. It skips around on the ship's shooting noises. I've attached good and bad logs on ALSA here. [1] http://www.classic-retro-games.com/Zaxxon_70.html Andrew On Wed, Jan 02, 2013 at 02:46:43PM +0100, Maarten Lankhorst wrote: > --- > dlls/dsound/dsound.c | 1 - > dlls/dsound/dsound_main.c | 6 - > dlls/dsound/dsound_private.h | 6 +- > dlls/dsound/mixer.c | 253 +++++++++++-------------------------------- > dlls/dsound/primary.c | 95 ++++++---------- > 5 files changed, 99 insertions(+), 262 deletions(-)

1 0

Re: [PATCH 2/3] mshtml: Added IHTMLStyle::put_pixelLeft implementation
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23774 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] mshtml: Added IHTMLStyle::get_pixelLeft implementation
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23773 Your paranoid android. === W2K8SE (32 bit style) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/3] xmllite: Support name reporting for comments and PIs
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23772 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] xmllite: Support streams starting with comments, simplify tests
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23771 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] xmllite: Implement PI parsing
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23770 Your paranoid android. === W2K8SE (32 bit reader) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [PATCH] kernel32: implement condition variables
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23769 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] kernel32: improve condition variable testcase
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23768 Your paranoid android. === W2K8SE (32 bit sync) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: d3dx9_36: Make error_dxfile_to_d3dxfile() and test_templates() static.
by Marvin 07 Jan '13

07 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23767 Your paranoid android. === W2K8SE (32 bit xfile) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [cmd] Add beginnings of support for delayed expansion
by Marvin 06 Jan '13

06 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23766 Your paranoid android. === W2K8SE (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] advapi32: close hTemp on error (Coverity)
by Marvin 06 Jan '13

06 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23763 Your paranoid android. === W2K8SE (32 bit security) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [1/2] winedbg: Add modified immediate dataprocessing operators to Thumb2 disassembler
by André Hentschel 06 Jan '13

06 Jan '13

Am 06.01.2013 17:57, schrieb André Hentschel: > After that patch i'll consider the parser as fully implemented and every missing thing should be filed as a bug > i'm now planning to better detect which instructionsset we need to disassemble > > --- > programs/winedbg/be_arm.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 95 insertions(+) sry, wrong subject, i just sent a new one

1 0

Re: [PATCH 3/5] wined3d: state->user_stream is always FALSE in device_stream_info_from_declaration().
by Stefan Dösinger 06 Jan '13

06 Jan '13

Am 04.01.2013 um 12:02 schrieb Henri Verbeet <hverbeet(a)codeweavers.com>: > Since user pointer draws were removed, state->user_stream will only ever be > set for "strided" draws, and device_stream_info_from_declaration() is never > called for those. I have some patches in my tree that remove draw_primitive_strided and user_stream entirely but didn't get around to sending them yet due to reasons unrelated to the patches. I think I should have time to rebase and send them on monday.

2 1

Re: comctl32/listview: support header images
by Nikolay Sivov 06 Jan '13

06 Jan '13

On 1/6/2013 02:55, Daniel Jelinski wrote: > They are unrelated, except by file modified, and I'm sending them as I > create them, but of course I can defer sending them a little. > Do you mean message sequence tests or something else? I tested that > visually with delphi, but I guess that's not what you're asking for. I mean to test that header gets image list after it's set for listview, and that same handle is reused. > > 2013/1/5 Nikolay Sivov <bunglehead(a)gmail.com>: >> On 1/6/2013 02:25, Daniel Jelinski wrote: >> >> This one needs tests. Also even if each patch applies cleanly, please send >> them in series, it makes it easier to review.

1 0

Re: comctl32/listview: support header images
by Nikolay Sivov 05 Jan '13

05 Jan '13

On 1/6/2013 02:25, Daniel Jelinski wrote: This one needs tests. Also even if each patch applies cleanly, please send them in series, it makes it easier to review.

1 0

Re: comctl32/listview: fix calculating item height
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23746 Your paranoid android. === W2K8SE (32 bit listview) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

3 2

Re: msvcrt/tests: Add a trailing '\n' to a win_skip() call.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23752 Your paranoid android. === W2K8SE (32 bit string) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23751 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23750 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23749 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23748 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Assorted spelling fixes.
by Marvin 05 Jan '13

05 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23747 Your paranoid android. === W2K8SE (32 bit hlsl) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)
by Dmitry Timoshkov 05 Jan '13

05 Jan '13

Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > + BYTE buffer[MAX_PATH]; This should be WCHAR if you decided to test unicode version of the API (although testing ANSI variant would be much easier), that will help to avoid all those casts, and protect from insufficient buffer size. Also please use a font that exists in Wine, such as sserife.fon, but be prepared that it could be not found since font file name is locale dependent. -- Dmitry.

2 4

Re: Patchsets that need review by experienced Wine Developers
by Michael Ost 05 Jan '13

05 Jan '13

Hi, list. We at Muse Research are happy help move our patches from custom one-offs to the main fork. Background info below... >>> The original patches/sources (that i have based my version on, are >>> found here: http://www.museresearch.com/support/receptor-faq.php >>> >>> ...at the bottom of the page / last link: >>> http://www.museresearch.com/support/receptor-faq.php >>> >> >> I looked over them briefly. > >> 0005-Expand-dos-has-entropy-in-order-to-make-collision-le.patch >> Not sure why this is needed? > > I'm not sure why either, but i am guessing it improves things in a > linux-rt/VST setting (in fact, removing it causes regressions on my > L_pa systems - so i am keeping it. This is a really old patch. IIRC there were different long filenames that were being converted to the same 8.3 filename. I don't have more details. >> 0010-If-a-child-of-the-window-being-disabled-is-the-captu.patch >> a user32.EnableWindow 2008 patch ... is it still needed for you, >> as quite some enhancements have happened... >> >> Would need review (likely from julliard or other user32 guru) >> and testcases. > > Seems to be, yeah. This fixed a problem where FM8's 'save' window would get stuck. Once you opened and cancelled it, any mouse click would open it again. >> 0012-ntdll-Use-pipes-for-synchronization-objects.patch >> 0050-pipe-check-and-thread-safe-read.patch >> >> A new synchronization method using UNIX pipe(2)s. >> This is definitely not going in as is... > > Figured as much :) (that was pretty obvious lol.) > >> It would be interesting to know what deficit in regular Wine is >> fixed by it. wineserver overhead? > > Yeah, Wineserver is probably the number one thing that slows down > when, when you are looking for low-latency / high-performance. (ext4 > is also terrible on stock settings). This removes key synchronization calls from the wineserver and keeps them on the app side. Without it realtime performance is impossible. We developed this with Codeweavers, and they were pretty sure it wasn't general enough for the main fork. >> 0023-improve-IoRegisterDeviceInterface.patch >> >> Remove the MUSE specific fixmes and use the same FIXME() style >> for stub parameters as in the other FIXME()s. Then >> its ready for wine-patches I would say. > > Awesome :) I must have missed that ~ you will notice that i removed > them from the new variables used by L_ (didn't want any > hassles/trademark issues with Muse). Don't worry, no problem with us! This was helpful in getting Pace CDRM ilok support to work. >> 0025-Add-stub-for-IoSetDeviceInterfaceState.patch >> Use same FIXME() style as used for other stub functions, then >> ready for submission. > > Great. > >> 0027-Add-stub-for-PoSetPowerState.patch >> Good for submission as-is. > > Great. :) Ditto from 0023. >> 0033-overridable-default-filesystem-type.patch >> Not submittable as-is ... >> It would be good to know the reason and/or what MUSE expects. > > You can contact them. They don't seem to get the idea of FOSS - by > having our help, they could have _Less_ of a delta they are keeping. > But as far as this patch is concerned, i am not sure. (this is why i > got in touch with you guys). This is internal and not generally useful. >> 0044-get-windows-label-from-registry.patch >> Smells like the wrong place to do it. Perhaps mountmgr.sys, >> but perhaps different. >> Also unclear if Alexandre likes it. > > I think for their purposes it probably is though, so i have kept it as > well (for now, unless told that i shouldn't for good reason). This one is internal too. >> 0052-NI-drag-and-drop.patch >> Looks already good for submission to me. > > Yeah, it fixes BIG hassles for N.I users like myself. Cool. >> 0054-set-realtime-priority-without-wineserver.patch >> wine-rt-101107.patch >> Needs design and discussion... So far a RT solution >> was not accepted for Wine yet. > > Yeah - that is in fact, one of the most important patches for us > (linuxaudio folks). The FSThost developer (wraps wineVSTs, single > hosted) said it is the 'holy grail' for fixing his software to > properly handle windows VSTs and it does so very well :) ~ windows > VSTs are highly performant, synchronized and run like normal > Jack_cleints without wineserver getting in the way. Same as above, moving sync calls out of the wineserver is the only way to use Wine for realtime audio applications. Especially with more complicated plugins like Kontakt. >> 0061-fix-broken-cross-compiled-winegcc.patch This fixed a compiler problem when cross compiling a 32bit winelib application on a 64bit system. The messages were: > /usr/include/wine/windows/rpcndr.h:176:16: error: ‘_MIDL_STUB_MESSAGE’ has a > field ‘_MIDL_STUB_MESSAGE::SavedContextHandles’ whose type uses the anonymous > namespace [-Werror] > /usr/include/wine/windows/rpcndr.h:479:16: error: ‘_SCONTEXT_QUEUE’ has a field > ‘_SCONTEXT_QUEUE::ArrayOfObjects’ whose type uses the anonymous namespace > [-Werror] >> 0063-disable-winedbg-auto-crash-dialog.patch >> local hacks Yep. One-offs for us. > k. > >> 0062-disable-crashing-alpha-bitmaps-for-gdb.patch >> Seems like a mistaken patch that was needed as we had >> the old DIB sections. >> >> gdb would have accepted "continue" here. >> >> Should not be necessary anymore these days with the >> DIBENGINE. > > Okay, i will try reverting it locally and make sure everything is good. Yes to all of that. I just hated having to hit CONTINUE all the time. And, right, my understanding is that the DIBENGINE no longer uses the same tricks with memory that it used to. >> add-implementation-setProcessWorkingSetSize.patch >> Might be submittable as-is. >> >> Might need autoconf checks for non-Linux. > > good. but i am not the guy to do this ~ i have a _ton_ of work right > now, both professionally and for my own projects. I just wanted to > make sure anything that _should_ be in wine goes into Wine to improve > the experience for everyone. Ditto that on the "busy" thing. ;) >> Fix-disk-geometry-ioctl.patch >> Alexandre usually does not like override files >> like this unless necessary. >> >> What is actually expected? you mentioned rendering issues? > > I am not sure about this one. it needs investigating but i have it > applied. As far as rendering issues, yes upstream wine causes ugly The drive geometry from a disk wasn't being reported correctly or consistently. It caused problems with SampleTank from IK Multimedia. > flickering in some apps/VSTs, while L_pa-Wine does not (at all, ever). >> fix-obscured-windows.patch >> Hmm, needs user32 windowing guru review. > > probably. The 'prefs' menu from SampleTank wasn't opening with Metacity. Old bugzilla notes say "It comes down to the WS_DLGFRAME|WS_THICKFRAME flags. If they are both present then the window is not visible. Turn on or the other off in the example and the window shows up. The second window must have a parent and have the WS_OVERLAPPED style as well." Hope that helps. -- Michael Ost Muse Research and Development

5 5

Re: [website] Wine 1.5.21 freigegeben
by Frédéric Delanoy 05 Jan '13

05 Jan '13

On Fri, Jan 4, 2013 at 10:33 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > --- > news/de/2012122101.xml~ | 17 +++++++++++++++++ Not sure checking in your editor backup file is a good idea ;) Frédéric

1 0

Re: [1/4] windowscodecs: Introduce 24bppRGB PixelFormat
by Vincent Povirk 04 Jan '13

04 Jan '13

The series looks good to me. Of course, we can already read 8-bit tiffs just fine, but I guess your app makes use of the 8bpp RGB format. We could probably avoid a double conversion between rgb and bgr when reading an 8-bit tiff as rgb, by implementing and using the IWICBitmapSourceTransform interface, but MSDN seems to claim that the native TIFF decoder doesn't do this.

1 0

Re: [3/4] windowscodecs: Test conversions of the 24bpp PixelFormats
by Marvin 04 Jan '13

04 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23739 Your paranoid android. === W2K8SE (32 bit converter) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Patchsets that need review by experienced Wine Developers
by jordan 04 Jan '13

04 Jan '13

Hi, I have been experimenting with some patchsets for Wine -> based on an implementation of Wine originally developed By Muse Research. It has improved support for a bunch of stuff, fixes (most) bottlenecks for Linux proaudio folks making use of Wine + Jack, and also contains some bug fixes for wine (that may or may not be acceptable to wine-devs.) I have a project that now lives on SF.net, but has been running for months now, on my machine(s), locally. It's called L-ProAudio, and the version of wine (L_pa-Wine) is geared towards proaudio users. We also have support in 1 linux application ~ which now properly handles the new method of mapping win/prio -> linux/prio. Some of the patchset fixes synchronization issues (with jack), disk geomtery-io-syscl, fixes rendering bugs in VSTs (probably other apps too) and a bunch of other improvements (geared for proaudio users). L_ProAudio SF.net Page: https://sourceforge.net/projects/l-proaudio/ -> Wine-L_Proaudio_Arch_n_patches.tar.gz contains a pkgbuild for Archlinux (like gentoo' ebuild) + all patches (and probably one or two others, not used in my builds). But please note: this is NOT a fork of Wine. It is necessary for me to be able to run the applications that i want with Wine. I am just carrying patchwork and re-basing it, as time passes. But i decided to release it - since it benefits the larger community who uses this stuff (greatly). note 2: I am posting, in order to shed light on any improvements/bug fixes that _might_ be suitable for upstream. ~ If so, once a given stable release of Wine is issued, I would then be able to remove them from my patchset, minimizing duplicate efforts, among other things. The original patches/sources (that i have based my version on, are found here: http://www.museresearch.com/support/receptor-faq.php ...at the bottom of the page / last link: http://www.museresearch.com/support/receptor-faq.php these patches fix Wine problems (in most areas) for people using linux(-rt) + jack + ProAudio ... but may have other benefits/bug-fixes for wine. It's Gpl'd (obviously), so it would be worthwhile to have a look anyway. - didn't include every patch (some of them aren't of interest to me, outdated, etc). Take care Jordan

2 3

Re: windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory. Take 2.
by Vincent Povirk 04 Jan '13

04 Jan '13

This looks good to me (and it's hard for me to stick to my preference for IWICBitmapLock, given how little code is needed here to accomplish the same thing). The remaining todo is an unrelated bug that's my fault, and I'll resend my patch for it if this one is accepted.

1 0

Re: windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory. Take 2.
by Marvin 04 Jan '13

04 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23734 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3dx9_36: Implement ID3DXFileImpl_RegisterTemplates + tests. (resend)
by Marvin 04 Jan '13

04 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23733 Your paranoid android. === W2K8SE (32 bit xfile) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Fwd: Re: netstat: Initial implementation (try 2)
by André Hentschel 04 Jan '13

04 Jan '13

-------- Original-Nachricht -------- Betreff: Re: netstat: Initial implementation (try 2) Datum: Sat, 29 Dec 2012 15:39:54 +0100 Von: André Hentschel <nerv(a)dawncrow.de> An: Wine Devel <wine-devel(a)winehq.org> Am 28.12.2012 23:10, schrieb Frédéric Delanoy: > On Thu, Dec 27, 2012 at 7:03 PM, André Hentschel <nerv(a)dawncrow.de> wrote: >> +#define IDS_TCP_UNKNOWN 0 >> +#define IDS_TCP_CLOSED 1 >> +#define IDS_TCP_LISTENING 2 >> +#define IDS_TCP_SYN_SENT 3 >> +#define IDS_TCP_SYN_RCVD 4 >> +#define IDS_TCP_ESTABLISHED 5 >> +#define IDS_TCP_FIN_WAIT1 6 >> +#define IDS_TCP_FIN_WAIT2 7 >> +#define IDS_TCP_CLOSE_WAIT 8 >> +#define IDS_TCP_CLOSING 9 >> +#define IDS_TCP_LAST_ACK 10 >> +#define IDS_TCP_TIME_WAIT 11 >> +#define IDS_TCP_DELETE_TCB 12 >> <...> >> + IDS_TCP_CLOSED, "CLOSED" >> + IDS_TCP_LISTENING, "LISTENING" >> + IDS_TCP_SYN_SENT, "SYN_SENT" >> + IDS_TCP_SYN_RCVD, "SYN_RCVD" >> + IDS_TCP_ESTABLISHED, "ESTABLISHED" >> + IDS_TCP_FIN_WAIT1, "FIN_WAIT1" >> + IDS_TCP_FIN_WAIT2, "FIN_WAIT2" >> + IDS_TCP_CLOSE_WAIT, "CLOSE_WAIT" >> + IDS_TCP_CLOSING, "CLOSING" >> + IDS_TCP_LAST_ACK, "LAST_ACK" >> + IDS_TCP_TIME_WAIT, "TIME_WAIT" >> + IDS_TCP_DELETE_TCB, "DELETE_TCB" > > Are these really supposed to be translated? If not they probably > should be "hardcoded" in a C file. > > Frédéric > In german Windows they are, not sure about the french one. see also http://www.winehq.org/pipermail/wine-devel/2012-December/098259.html -- Best Regards, André Hentschel

3 2

Re: user32: Initialize cbSize of NONCLIENTMETRICSW struct in GetSystemMetrics
by Dmitry Timoshkov 03 Jan '13

03 Jan '13

Jacek Caban <jacek(a)codeweavers.com> wrote: > - NONCLIENTMETRICSW ncm; > + NONCLIENTMETRICSW ncm = {sizeof(ncm)}; ncm.cbSize = sizeof(ncm); would be more explicit IMO. -- Dmitry.

1 0

Re: [3/3] wmiutils/tests: Add more tests.
by Marvin 03 Jan '13

03 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23729 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: comctl32/listview: Improve LVM_GETSUBITEMRECT implementation for out-of-bounds item indices
by Marvin 03 Jan '13

03 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23728 Your paranoid android. === W2K8SE (32 bit listview) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [PATCH 2/2] atl100: Added AtlUnadvise implementation
by Marvin 03 Jan '13

03 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23726 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] atl100: Added AtlAdvise implementation
by Marvin 03 Jan '13

03 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23725 Your paranoid android. === W2K8SE (32 bit atl) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.
by Dmitry Timoshkov 03 Jan '13

03 Jan '13

Vincent Povirk <madewokherd(a)gmail.com> wrote: > + hr = IWICBitmap_Lock(bitmap, NULL, WICBitmapLockWrite, &lock); > + if (SUCCEEDED(hr)) > + { > + UINT buffersize; > + BYTE *buffer; > + > + hr = IWICBitmapLock_GetDataPointer(lock, &buffersize, &buffer); > + > + memcpy(buffer, pbBuffer, uiHeight * cbStride); > + > + IWICBitmapLock_Release(lock); > + } It's better to actually check return value of IWICBitmapLock_GetDataPointer before memecpy(), or if that's not supposed to fail drop 'hr' assignment. My approach to pass buffer directly to BitmapImpl_Create looks much simpler than fiddling with IWICBitmap_Lock IMHO. -- Dmitry.

2 2

wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole
by Alan W. Irwin 02 Jan '13

02 Jan '13

The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simple test programme should demonstrate the issue for wine-1.5.20 which is not present in wine-1.5.19 and a fairly large selection of 1.5.x and MinGW versions I have tried over the last year or so. I would be happy to supply more details if there is any difficulty replicating this reversion. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

3 7

Re: [PATCH] ntdll/tests: Fix SYSTEM_CACHE_INFORMATION failures [try 2]
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23718 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] ntdll/tests: Fix SYSTEM_CACHE_INFORMATION failures on WIN64
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23712 Your paranoid android. === W2KPROSP4 (32 bit info) === info.c:550: Test failed: 35: got 0x0 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) === WXPPROSP3 (32 bit info) === info.c:550: Test failed: 35: got 0x0 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) === W2K3R2SESP2 (32 bit info) === info.c:550: Test failed: 35: got 0x0 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) === WVISTAADM (32 bit info) === info.c:550: Test failed: 35: got 0x0 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) info.c:556: Test failed: 0: got 0xc0000004 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) === W2K8SE (32 bit info) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W7PRO (32 bit info) === info.c:550: Test failed: 35: got 0x0 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36) info.c:556: Test failed: 0: got 0xc0000004 and 12 (expected STATUS_INFO_LENGTH_MISMATCH and 36)

1 0

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23710 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Test whether CreateBitmapFromMemory stride is stored.
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23709 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.
by André Hentschel 02 Jan '13

02 Jan '13

Am 02.01.2013 02:56, schrieb Charles Davis: > --- a/tools/winebuild/utils.c > +++ b/tools/winebuild/utils.c > @@ -345,10 +345,22 @@ struct strarray *get_as_command(void) > > if (!as_command) > { > +#ifdef CLANG_AS > + /* The native assembler might not support CFI pseudo-ops, > + * but clang does. So if we were compiled with > + * clang, we should assemble with clang, too. > + */ > + static const char * const commands[] = { CLANG_AS, "clang", NULL }; > + as_command = find_tool( "clang", commands ); > +#else > static const char * const commands[] = { "gas", "as", NULL }; > as_command = find_tool( "as", commands ); > +#endif > } > strarray_add_one( args, as_command ); > +#ifdef CLANG_AS > + strarray_add( args, "-xassembler", "-c", NULL ); > +#endif > > if (force_pointer_size) > { > Not sure if you can do it like that, as i understand it winebuild should always be able to crosscompile something, these ifdefs would destroy that feature. -- Best Regards, André Hentschel

3 2

[website] Are we doing something wrong with our secure connections?
by André Hentschel 02 Jan '13

02 Jan '13

Hi, FWIW i have just seen: https://www.ssllabs.com/ssltest/analyze.html?d=testbot.winehq.org&hideResul… https://www.ssllabs.com/ssltest/analyze.html?d=test.winehq.org&hideResults=… https://www.ssllabs.com/ssltest/analyze.html?d=winehq.org&hideResults=on&ig… which tells me we have some problems with secure website connection, the question is, do we need more security here? -- Best Regards, André Hentschel

2 1

Re: winebuild: Add configure option to use llvm-mc as assembler.
by Charles Davis 02 Jan '13

02 Jan '13

On Jan 1, 2013, at 9:35 AM, Per Johansson wrote: > Needed to build with clang on OS X, the normal as program can't parse clang > output. > It's a configure option since llvm-mc takes different options than the normal > assembler, and on OS X is most often installed by a different name > (llvm-mc-mp-3.1 in my case). But llvm-mc isn't a tool intended to be used by the end user. It's an LLVM developer's tool intended to be used to test and play with LLVM's MC library (which Clang uses to implement its integrated assembler). The help output even says "llvm machine code playground". That's why Apple doesn't distribute it with Xcode. The right thing IMO is to test if we're compiling with Clang. If we are, then we should test if Clang is using its integrated assembler; if it is, then we should invoke Clang instead of the system assembler to assemble. This way, the user doesn't have to pass yet another option to configure in case he's using Clang. I have a patch to hack-fix winebuild to invoke Clang if we're being compiled by Clang; I can fix it to test for Clang and Clang's integrated assembler in configure and send it to the list--something I really should've done a while ago. Chip > --- > configure.ac | 8 ++++++++ > tools/winebuild/build.h | 6 +++++- > tools/winebuild/import.c | 4 ++-- > tools/winebuild/res32.c | 2 +- > tools/winebuild/utils.c | 22 +++++++++++++++++----- > 5 files changed, 33 insertions(+), 9 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 620ad07..84232e0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -59,6 +59,7 @@ AC_ARG_WITH(jpeg, AS_HELP_STRING([--without-jpeg],[do not use JPEG]), > [if test "x$withval" = "xno"; then ac_cv_header_jpeglib_h=no; fi]) > AC_ARG_WITH(ldap, AS_HELP_STRING([--without-ldap],[do not use LDAP]), > [if test "x$withval" = "xno"; then ac_cv_header_ldap_h=no; ac_cv_header_lber_h=no; fi]) > +AC_ARG_WITH(llvm-mc, AS_HELP_STRING([--with-llvm-mc=NAME],[Use llvm-mc as assembler])) > AC_ARG_WITH(mpg123, AS_HELP_STRING([--without-mpg123],[do not use the mpg123 library]), > [if test "x$withval" = "xno"; then ac_cv_header_mpg123_h=no; fi]) > AC_ARG_WITH(openal, AS_HELP_STRING([--without-openal],[do not use OpenAL]), > @@ -294,6 +295,13 @@ AC_CHECK_PROGS(CONVERT, convert, false) > AC_CHECK_PROGS(ICOTOOL, icotool, false) > AC_CHECK_PROGS(MSGFMT, msgfmt, false) > > +dnl Check if user wants llvm-mc > +if test "x${with_llvm_mc:-no}" != "xno" > +then > + if test "${with_llvm_mc}" = "yes"; then with_llvm_mc=llvm-mc; fi > + AC_DEFINE_UNQUOTED(LLVM_MC, ["${with_llvm_mc}"], [Define to name of llvm-mc program, if preferred.]) > +fi > + > if test "x$enable_maintainer_mode" != "xyes" > then > AC_SUBST([MAINTAINER_MODE],[\#]) > diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h > index 05adf31..71e87f6 100644 > --- a/tools/winebuild/build.h > +++ b/tools/winebuild/build.h > @@ -209,6 +209,10 @@ struct strarray > #define IMAGE_SUBSYSTEM_WINDOWS_CUI 3 > #define IMAGE_SUBSYSTEM_WINDOWS_CE_GUI 9 > > +/* find_tool flags */ > + > +#define FT_SKIP_TARGET_ALIAS 1 > + > /* global functions */ > > #ifndef __GNUC__ > @@ -246,7 +250,7 @@ extern int output( const char *format, ... ) > extern void output_cfi( const char *format, ... ) > __attribute__ ((__format__ (__printf__, 1, 2))); > extern void spawn( struct strarray *array ); > -extern char *find_tool( const char *name, const char * const *names ); > +extern char *find_tool( const char *name, const char * const *names, int flags ); > extern struct strarray *get_as_command(void); > extern struct strarray *get_ld_command(void); > extern const char *get_nm_command(void); > diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c > index c73b86c..821b5b8 100644 > --- a/tools/winebuild/import.c > +++ b/tools/winebuild/import.c > @@ -1325,14 +1325,14 @@ void output_import_lib( DLLSPEC *spec, char **argv ) > fclose( output_file ); > output_file = NULL; > > - strarray_add( args, find_tool( "dlltool", NULL ), "-k", "-l", output_file_name, "-d", def_file, NULL ); > + strarray_add( args, find_tool( "dlltool", NULL, 0 ), "-k", "-l", output_file_name, "-d", def_file, NULL ); > spawn( args ); > strarray_free( args ); > > if (argv[0]) > { > args = strarray_init(); > - strarray_add( args, find_tool( "ar", NULL ), "rs", output_file_name, NULL ); > + strarray_add( args, find_tool( "ar", NULL, 0 ), "rs", output_file_name, NULL ); > strarray_addv( args, argv ); > spawn( args ); > strarray_free( args ); > diff --git a/tools/winebuild/res32.c b/tools/winebuild/res32.c > index 729aa2f..bddca83 100644 > --- a/tools/winebuild/res32.c > +++ b/tools/winebuild/res32.c > @@ -682,7 +682,7 @@ void output_res_o_file( DLLSPEC *spec ) > free( output_buffer ); > > args = strarray_init(); > - strarray_add( args, find_tool( "windres", NULL ), "-i", res_file, "-o", output_file_name, NULL ); > + strarray_add( args, find_tool( "windres", NULL, 0 ), "-i", res_file, "-o", output_file_name, NULL ); > spawn( args ); > strarray_free( args ); > > diff --git a/tools/winebuild/utils.c b/tools/winebuild/utils.c > index 09f9b73..0fe24a9 100644 > --- a/tools/winebuild/utils.c > +++ b/tools/winebuild/utils.c > @@ -276,7 +276,7 @@ void spawn( struct strarray *args ) > } > > /* find a build tool in the path, trying the various names */ > -char *find_tool( const char *name, const char * const *names ) > +char *find_tool( const char *name, const char * const *names, int flags ) > { > static char **dirs; > static unsigned int count, maxlen; > @@ -286,7 +286,7 @@ char *find_tool( const char *name, const char * const *names ) > unsigned int i, len; > struct stat st; > > - if (target_alias) return strmake( "%s-%s", target_alias, name ); > + if (target_alias && !(flags & FT_SKIP_TARGET_ALIAS)) return strmake( "%s-%s", target_alias, name ); > > if (!dirs) > { > @@ -345,11 +345,22 @@ struct strarray *get_as_command(void) > > if (!as_command) > { > +#ifdef LLVM_MC > + as_command = find_tool( LLVM_MC, NULL, FT_SKIP_TARGET_ALIAS ); > +#else > static const char * const commands[] = { "gas", "as", NULL }; > - as_command = find_tool( "as", commands ); > + as_command = find_tool( "as", commands, 0 ); > +#endif > } > strarray_add_one( args, as_command ); > > +#ifdef LLVM_MC > + strarray_add( args, "-filetype", "obj", NULL); > + if (target_alias) > + strarray_add( args, "-triple", target_alias, NULL); > + else if (force_pointer_size) > + strarray_add( args, "-arch", (force_pointer_size == 8) ? "x86_64" : "x86", NULL ); > +#else > if (force_pointer_size) > { > switch (target_platform) > @@ -370,6 +381,7 @@ struct strarray *get_as_command(void) > break; > } > } > +#endif > > if (cpu_option) strarray_add_one( args, strmake("-mcpu=%s", cpu_option) ); > return args; > @@ -382,7 +394,7 @@ struct strarray *get_ld_command(void) > if (!ld_command) > { > static const char * const commands[] = { "ld", "gld", NULL }; > - ld_command = find_tool( "ld", commands ); > + ld_command = find_tool( "ld", commands, 0 ); > } > strarray_add_one( args, ld_command ); > > @@ -417,7 +429,7 @@ const char *get_nm_command(void) > if (!nm_command) > { > static const char * const commands[] = { "nm", "gnm", NULL }; > - nm_command = find_tool( "nm", commands ); > + nm_command = find_tool( "nm", commands, 0 ); > } > return nm_command; > } > -- > 1.8.0 > > >

2 5

Re: aclocal: Use -Werror when checking compiler flags.
by Alexandre Julliard 02 Jan '13

02 Jan '13

Per Johansson <per(a)morth.org> writes: > This makes clang exit with error on unsupported warnings. You'd need to check if -Werror is supported first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 7/7] d3dcompiler43/tests: Don't use IUnknown_Release(). (try 3)
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23693 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] d3dx9: Handle invalid byte code in D3DXGetShaderConstantTableEx(). (try 3)
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23692 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] d3dx9: Always set the table = NULL in D3DXGetShaderConstantTableEx(). (try 3)
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23691 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] d3dx9: Handle invalid byte code in D3DXFindShaderComment().
by Matteo Bruni 02 Jan '13

02 Jan '13

2013/1/1 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/shader.c | 16 +++++++++++----- > dlls/d3dx9_36/tests/shader.c | 21 +++++++++++++++++++++ > 2 Dateien geändert, 32 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) > +static inline BOOL is_valid_bytecode(DWORD token) +{ + token &= 0xFFFF0000; + return token == 0xFFFF0000 || token == 0xFFFE0000; +} This series looks good to me, but I'd prefer you use lowercase hexadecimal constants in the future.

2 1

Re: d3dcompiler_43: Avoid signed-unsigned integer comparisons
by Matteo Bruni 02 Jan '13

02 Jan '13

2013/1/1 Andrew Talbot <andrew.talbot(a)talbotville.com>: > Changelog: > d3dcompiler_43: Avoid signed-unsigned integer comparisons. > > diff --git a/dlls/d3dcompiler_43/bytecodewriter.c b/dlls/d3dcompiler_43/bytecodewriter.c > index d10f6bc..17289d2 100644 > --- a/dlls/d3dcompiler_43/bytecodewriter.c > +++ b/dlls/d3dcompiler_43/bytecodewriter.c > @@ -609,7 +609,7 @@ static void write_declarations(struct bc_writer *This, > } > > static void write_const(struct constant **consts, int num, DWORD opcode, DWORD reg_type, struct bytecode_buffer *buffer, BOOL len) { > - DWORD i; > + int i; > DWORD instr_def = opcode; > const DWORD reg = (1<<31) | > ((reg_type << D3DSP_REGTYPE_SHIFT) & D3DSP_REGTYPE_MASK) | > I think it's better if you turn the num parameter into an unsigned int (or DWORD) instead.

1 0

Re: [7/7] wmiutils: Add tests. (try 2)
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23688 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [7/7] wmiutils: Add tests.
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23686 Your paranoid android. === WNT4WSSP6 (32 bit path) === path.c:102: Test failed: got 80040154 path: unhandled exception c0000005 at 00401303 === W2KPROSP4 (32 bit path) === path.c:102: Test failed: got 80040154 path: unhandled exception c0000005 at 00401303

1 0

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws
by Henri Verbeet 02 Jan '13

02 Jan '13

On 2 January 2013 12:26, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Fixes bug 32485. I'm sure we've had this discussion wrt. commit messages before, but this tells me just about nothing about what problem this patch is supposed to fix, or why this is the correct solution. Also, do you have tests for this?

2 1

Re: [11/12] kernel32: Add support for {Get|Set}NamedPipeHandleState().
by Marvin 02 Jan '13

02 Jan '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23681 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: xbox 360 emulation with logitech cordless and dinput joy disable
by Stefan Dösinger 01 Jan '13

01 Jan '13

Hi, The patch needs a few improvements before it can be accepted into Wine. I can't comment on the dinput / xinput specifics of the patch, so this is a non- exhaustive list of general suggestions. Concerning the big picture, this patch needs a few discussions about xinput.dll design. There have been some discussions about that in the past, and I hope that some dinput devs can help out. Am Dienstag, 12. Juni 2012, 23:48:53 schrieb Giovanni Ongaro: > From: root <root(a)joe.(none)> Please configure git correctly, see http://wiki.winehq.org/GitWine section 3.3. Also consider using a non-root user, but that's your personal setup, so not really my business. > + if (getenv("LINIXFORCENOJOY") != NULL) return FALSE; /*JoeFix disable joystick*/ The problem with dinput vs xinput conflicts should probably be solved in a different manner. That aside, such configurations are usually done via registry keys. Also comments like /* I changed this here */ are useless, the git history stores this information anyway. > + <...> //JoeFix DEAD ZONE This is a C++ comment and not allowed in Wine. See http://wiki.winehq.org/SubmittingPatches > + fdJoy=open("/dev/input/js0",O_RDONLY | O_NONBLOCK); Xinput.dll should not open joystick devices directy, and definitely not a hardcoded one. I don't know if there's consensus about how xinput should be implemented, but basing it on top of dinput might be a start. A good start would be to write a few tests to test how Windows announces(or doesn't announce) Xbox gamepads and other gamepads/joysticks to games. My understanding is that xinput.dll only works for Xbox gamepads. Do those show up in dinput on Windows? > +#define DEAD_ZONE 4096 > ... > + if (e.number == 4) { > + if (e.value == 1) { > + FIXME("TRIGGER LEFT PRESSED\n"); > + pState->Gamepad.bLeftTrigger=32767; > + } > + else { > + pState->Gamepad.bLeftTrigger=0; > + } > ... > +#define JOYMAX 30000 > +#define JOYMIN -30000 The hardcoded numbers look questionable. The 4 and 1 are probably specific to the joystick, the 32767 might have a symbolic name like XINPUT_MAX or something. A part of this seems to be needed due to the attempt to emulate an xbox gamepad with a different device. Personally I'm not opposed to doing that, and you might need some device specific tricks to pull this off. However, this needs a more structured approach than hardcoding the values needed for one specific Logitech device in the code. Best regards, Stefan

3 2

Re: [PATCH] dsound: rework ugly mixer logic
by Andrew Eikum 01 Jan '13

01 Jan '13

On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: > + if(!maxq){ > + /* nothing to do! */ > + LeaveCriticalSection(&device->mixlock); > + return; > } This was removed in 8ba4090fc304993. It breaks starting the device in some situations (write primary mode iirc). > + if (native) { > + void *buffer = NULL; > + > + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); > + if(FAILED(hr)){ > + WARN("GetBuffer failed: %08x\n", hr); > + LeaveCriticalSection(&device->mixlock); > + return; > + } I think this (mixing directly to RenderClient and skipping WaveQueue) could be split into a separate patch. > hres = IAudioClient_Initialize(device->client, > AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); ... > + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; Could you #define the 800000? Anyway, I gave it a test on ALSA+Pulse and didn't find any issues. I'll test the other backends when you resubmit. Andrew

2 3

Mail problems for wine-patches
by Detlef Riekenberg 31 Dec '12

31 Dec '12

I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef

2 1

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin 31 Dec '12

31 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper
by Marvin 31 Dec '12

31 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

1 0

Help Splitting Patches
by Adam Martinson 31 Dec '12

31 Dec '12

Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. ~Adam

2 1

[AppDB] Cannot submit rejected Test results after change
by Joerg Schiermeier 31 Dec '12

31 Dec '12

¡Hola! In AppDB I got a problem, exactly with one of my maintained applications: some days ago someone filed a test about the mail program 'The Bat!'. This test has this URL: <http://appdb.winehq.org/objectManager.php?sClass=version&iId=23662&iTesting…> So AppDB sent me an email about this test and I went to its web interface. There I rejected this test result because of some incorrect version numberings. Than I got some days later a mail about a new submitted test. I logged into AppDB again to my control panel but I didn't saw this new submitted test there. So I had and have no change to commit this test results. If you follow the link above you will see: the test results are still there. So my conclusion: 1.) Someone, maybe you will have to commit this test. 2.) Something went wrong with the AppDB. Thanks for your attention and your help! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

1 0

Re: d3dx9: Implement D3DXSHEvalConeLight [try 4]
by Marvin 30 Dec '12

30 Dec '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23666 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K3R2SESP2 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === WVISTAADM (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K8SE (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PRO (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === TEST64_W7SP1 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351 === TEST64_W7SP1 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351

1 0

Re: [PATCH 2/2] kernel32: conditional variable support
by Nikolay Sivov 29 Dec '12

29 Dec '12

On 12/29/2012 23:04, Marcus Meissner wrote: > From: Marcus Meissner <marcus(a)jet.(none)> > > Modeled pretty much after the implementation described > in glibc/nptl/DESIGN-condvar.txt with its futex usage > sofar replaced by regular Win32 Semaphores. > > An additional futex implementation is possible. > > I *think* I have the semantics correct, there is 1 small > place where it might have unnecessary CPU usage though. > > Ciao, Marcus > +/********************************************************************** > + * InitializeConditionVariable (KERNEL32.@) > + */ > +VOID WINAPI InitializeConditionVariable(PCONDITION_VARIABLE variable) > +{ > + struct _condition_var_intern *var; > + variable->Ptr = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(struct _condition_var_intern)); > + var = variable->Ptr; > + if (!var) return; > + InitializeCriticalSection (&var->crit); > + var->crit.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": ConditionVariable.cs"); > +} I don't think it allocates anything at all, what makes me believe that is that stuff like CONDITION_VARIABLE_INIT exists. After googling a bit for it I see that gallium from mesa has some platform dependent stuff in code that uses this API like that: --- +#define pipe_static_condvar(cond) \ + /*static*/ pipe_condvar cond = CONDITION_VARIABLE_INIT --- So this structure has nothing more than a single pointer value, value 0 of it means it's initialized. I think you could just add some tests to see if it's really reset to 0 from initial value. Also regarding tests I don't think randomizing timeouts is a good idea cause it adds some unpredictable behaviour and it's not really clear if we could rely on such tests results.

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel