- wine-devel - winehq.org

Re: [PATCH] vbscript: Undefined variables resolve as EMPTY without Option Explicit
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22090 Your paranoid android. === W2KPROSP4 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === WXPPROSP3 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W2K3R2SESP2 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (32 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === W7PROX64 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5" === TEST64_W7SP1 (64 bit run) === run.c:939: Test failed: api.vbs: L"CStr(3,5) = 3,5"

1 0

Re: shell32: Fix ShellExecute()'s handling of file URLs.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22079 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1440: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: shell32/tests: Simplify shlexec's test_directory() and add some more tests.
by Marvin 11 Oct '12

11 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22078 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\TEMP\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""' === W2KPROSP4 (32 bit shlexec) === shlexec.c:1420: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\test file.shlexec", params="p2 "p3" "p4 is lost"): the cmdline is ' "p2" "p3" "p3" "" ""' instead of ' "p2" "p3" "" "" ""'

1 0

Re: d3dx9_36 [patch 5/5, try 3]: Implement D3DXSHEvalSphericalLight
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:49, Nozomi Kodama wrote: > math.c:2994: Test failed: Red: case 9, order 7: expected[10] = 0.000000, > received -134495294795062701298349336420239278080.000000 > math.c:2994: Test failed: Red: case 9, order 7: expected[15] = 0.000000, > received -131556728585661638158151798785793064960.000000 But the values are different each time? So no app could depend on the returned values? Does this implementation return the same values? Is everyone else ok with accessing the array out of bounds? > > + for (i = 0; i < order ; i++) > > + scale = cap[i] * coeff[i]; > > + for (order = D3DXSH_MINORDER ; order <= D3DXSH_MAXORDER; order++) Spaces. These are also in the D3DXSHEvalConeLight patch. Is there a point against using the same coeff variables in D3DXSHEvalConeLight and D3DXSHEvalSphericalLight? Maybe they should be static or the capintegral simply should integrate the multiplication if the capintegral function is only used in these two functions. I think there is no need to add the same variables twice. > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; sqrtf .... These are also in the D3DXSHEvalConeLight patch. Does the compiler optimize the function call away to a constant value? If not it may be better to use something like 1.7724538509f for sqrtf(pi)... Cheers Rico

1 0

Re: msvcp90: in codecvt<wchar_t>::do_out, copy local buffer to *to_next
by Piotr Caban 10 Oct '12

10 Oct '12

On 10/10/12 19:42, Daniel Lehman wrote: + memcpy_s(*to_next, MB_LEN_MAX, buf, size); You may use memory after to_end in this code. to_next buffer size should be probably following: memcpy_s(*to_next, to_end-to_next, buf, size); Cheers, Piotr

1 0

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.
by Dmitry Timoshkov 10 Oct '12

10 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > + objectName.Buffer = (WCHAR *)&lpFileID->DUMMYUNIONNAME.FileId; This doesn't look right. > + if (status) > + { > + SetLastError( RtlNtStatusToDosError( status ) ); > + return INVALID_HANDLE_VALUE; > + } > + else if (!result) > + { > + return INVALID_HANDLE_VALUE; > + } > + else > + { > + return result; > + } It looks like some braces and all 'else' statements may go. -- Dmitry.

2 2

Re: [PATCH 3/3] vbscript: Added RTrim implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Add more font transformation tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22066 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22064 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22063 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] shell32/tests: Some more type consistency fixes for the ShellExecute() return value checks.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22057 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22056 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] shell32/tests: Improve the shell_execute{_ex}() tracing.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22055 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] shell32/tests: Fix test_one_cmdline() and add a few more tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22054 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d10: Handle blend state in d3d10_effect_object_apply().
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22053 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: mshtml: Return dispinterface from PHEventSink::QueryInterface
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22047 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: vbscript: Added CStr implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Test GIF metadata using a specially created GIF image with a bunch of extensions.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Add a bunch of tests for GIF Comment Extenstion metadata reader.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22044 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] gdiplus: Add a font transformation test.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22043 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [6/6] dwrite: Implement GetString()
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22042 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [5/6] dwrite: Implement GetStringLength method
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/6] dwrite: Added IDWriteFontFace stub
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22040 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/6] dwrite: Added IDWriteLocalizedStrings stub
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22039 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/6] dwrite: Store font family name in IDWriteFontFamily implementation
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22038 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 25/25] mciseq: MCI tempo is expressed in beats per minute, not microseconds.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22031 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: oledb32: Add IDBProperties support in IDBInitialize
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22030 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 18/25] winmm/tests: Add more MCI MIDI tests (auto-open).
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22027 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22025 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] shell32/tests: Greatly expand the test_argify() tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22024 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] shell32/tests: Merge shlexec's test_exes_long() with the other parameter passing tests.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22023 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] ole32: Implement StgConvertVariantToProperty.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22019 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] ole32: Add tests for StgConvertVariantToProperty.
by Marvin 10 Oct '12

10 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22018 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] winemaker: Generate def file from spec file with winebuild (try 2)
by Alexandre Julliard 10 Oct '12

10 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2569,6 +2570,7 @@ sub generate_project_files($) > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.def)\n"; > } elsif (@$target[$T_TYPE] == $TT_DLL) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "\t\$(WINEBUILD) --def -E \$(${canon}_MODULE:.dll=.spec) -o lib\$(${canon}_MODULE:.dll=.def)\n"; That's not much better. You should have a proper target for it, and a dependency from the modules that import that dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 2/5, try 3]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:44, Nozomi Kodama wrote: > + if ( green_out ) Same as last time: I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch! Please make all consistent in the patch.

1 0

Re: d3dx9_36 [patch 3/5, try 3]: Implement handy computations for small orders in D3DXSHRotate
by Rico Schüller 10 Oct '12

10 Oct '12

On 10.10.2012 09:45, Nozomi Kodama wrote: > + CONST FLOAT coeff[]={ > > + out[7] -= (matrix->u.m[1][0] * matrix->u.m[0][2] + matrix->u.m[1][2] * matrix->u.m[0][0]) * in[4]; > + > + out[7] += (matrix->u.m[1][0] * matrix->u.m[2][2] + matrix->u.m[1][2] * matrix->u.m[2][0]) * in[5]; Empty line too much? > + for ( l = 0; l < 1; l++) > > + if (l == 0) > + out_temp = out; > + else > + out_temp = in; The test change is completely new in the try... What do you like to achieve with this? l is always 0, isn't it? Beside this, there are some white space issues.

1 0

Re: [PATCH 1/5] include: Added definitions used by GetFileInformationByHandleEx.
by Dmitry Timoshkov 10 Oct '12

10 Oct '12

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> wrote: > +typedef struct _FILE_ID_DESCRIPTOR { > + DWORD dwSize; > + FILE_ID_TYPE Type; > + union { > + LARGE_INTEGER FileId; > + GUID ObjectId; > +#if (_WIN32_WINNT >= 0x0602) > + EXT_FILE_ID_128 ExtendedFileId; > +#endif > + } DUMMYUNIONNAME; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR; The '#if/#endif' part is useless in Wine (here in in other places as well). Also you should add new structures in every patch that needs them, one by one, not adding a bunch of not used stuff at once. P.S. In PSDK 7.1 (targeting Windows 7) some of the structures look different. Where does this come from? -- Dmitry.

1 0

Wine test bot
by Christian Costa 09 Oct '12

09 Oct '12

Hi, Is there a problem with Wine test bost? Jobs seem to be stuck and some VMs show problem of memory. Christian

1 1

Re: wbemprox: support for getting methods from WBEM objects
by Hans Leidekker 09 Oct '12

09 Oct '12

On Tue, 2012-10-09 at 20:30 +0200, Daniel Jelinski wrote: > diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c > index c414aa9..71c62c8 100644 > --- a/dlls/wbemprox/table.c > +++ b/dlls/wbemprox/table.c > @@ -63,6 +63,7 @@ UINT get_type_size( CIMTYPE type ) > return sizeof(INT64); > case CIM_DATETIME: > case CIM_STRING: > + case CIM_OBJECT: > return sizeof(WCHAR *); This should be fixed differently. I already have a patch in my tree.

1 0

Updated Wine Wiki Repo
by Kyle Auble 09 Oct '12

09 Oct '12

Just wanted to let everyone know I've created a git repo for the Wine Wiki from the CVS one at SourceForge. You can find it at: https://bitbucket.org/kauble/wine-wiki-migration Since it's a fresh repo, I thought editing the history should be ok (just moved the right info into Author & Committer fields and made the commit message formatting more consistent). I do still have the unedited branches from cvsimport and can put those up too if there's any demand for them. I've been talking with Dimi about what we would need to upgrade MoinMoin, and once he can find some time, he said he would setup a regular archive of the Wine Wiki's data. I also like the idea of using tags to mark which wiki version is in use, but I'm not sure how many times the wiki has been upgraded. If anyone knows what versions of MoinMoin we've used and when the upgrades took place, I can add the extra tags. I don't know if there's much interest in just moving this to the Wine git repo yet. If not, I can probably review patches, but would be happy to add someone else as an admin if they have a bitbucket account. - Kyle

4 6

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. (try 2)
by Austin English 09 Oct '12

09 Oct '12

On Tue, Oct 9, 2012 at 4:27 AM, Roman Dadkov <romand(a)etersoft.ru> wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will not > be able to run the newly created object. > Unfortunately, the test for this case can't be added to Wine, because it > leads a crash. You could put the test inside if(0), so that it's still documented, see, for example, dlls/ole32/tests/stg_prop.c or dlls/user32/tests/input.c. Cheers, Austin

1 0

Re: d3dx9_36 [patch 5/5]: Implement D3DXSHEvalSphericalLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:50, Nozomi Kodama wrote: > + CONST FLOAT coeff[6] = { > + 2.0f * sqrtf(D3DX_PI), 2.0f * sqrtf(D3DX_PI / 3.0f), 0.4f * sqrtf(5.0f * D3DX_PI), > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; Pretty much the same comments as for D3DXSHEvalConeLight apply here too. Beside that, does it make sens to define the coeffs with a better name as static and reuse them? They seem to be the same for both usages. Cheers Rico

1 0

Re: d3dx9_36 [patch 4/5]: Implement D3DXSHEvalConeLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:50, Nozomi Kodama wrote: > +static void CapIntegrale(FLOAT *out, FLOAT order, FLOAT angle) > +{ I'd use a lower case name. > + if (order == 5) > + return; Indentation. If you break to a new line, please indent 8 spaces (in the case for ok(...)). > + 2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; sqrtf. > + FLOAT cap[6], clamped_angle, norm, scale, temp[36]; No need for temp/scale? (see below) > + TRACE("order %u, dir %p, radius %f, red %f, green %f, blue %f, rout %p, gout %p, bout %p\n", order, dir, radius, Rintensity, Gintensity, Bintensity, rout, gout, bout); Long line. Please break. > + for (i = 0; i < order ; i++) Space. > + if (gout) > + for (i = 0; i < order; i++) > + { > + scale = cap[i] * Gintensity * coeff[i] / norm; > + for (j = 0; j < 2 * i + 1; j++) > + gout[i * i + j] = temp[i * i + j] * scale; > + } > + > + if (bout) > + for (i = 0; i < order; i++) > + { > + scale = cap[i] * Bintensity * coeff[i] / norm; > + for (j = 0; j < 2 * i + 1; j++) > + bout[i * i + j] = temp[i * i + j] * scale; > + } Pretty much the same calculation is done again and again. What happens if order is 100? You'll get a access violation. This is also true for cap and coeff in my sample here (It needs some tests ... Order may be clamped to D3DXSH_MAXORDER ... Does native crash in that case? Should we touch the values for order >= D3DXSH_MAXORDER at all?): D3DXSHEvalDirection(rout, order, dir); for (i = 0; i < order; i++) { FLOAT scale = cap[i] * coeff[i] / norm; for (j = 0; j < 2 * i + 1; j++) { FLOAT temp = rout[i * i + j] * scale; rout[i * i + j] = temp * Rintensity; if (gout) gout[i * i + j] = temp * Gintensity; if (bout) bout[i * i + j] = temp * Bintensity; } } Cheers Rico

1 0

Re: d3dx9_36 [patch 3/5]: Implement handy computations for small orders in D3DXSHRotate
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:49, Nozomi Kodama wrote: > + FLOAT temp[25]; > + CONST FLOAT coeff[]={ > + matrix->u.m[1][0] * matrix->u.m[0][0], matrix->u.m[1][1] * matrix->u.m[0][1], > + matrix->u.m[1][1] * matrix->u.m[2][1], matrix->u.m[1][0] * matrix->u.m[2][0], > + matrix->u.m[2][0] * matrix->u.m[2][0], matrix->u.m[2][2] * matrix->u.m[2][2], > + matrix->u.m[2][1] * matrix->u.m[2][1], matrix->u.m[0][0] * matrix->u.m[2][0], > + matrix->u.m[0][1] * matrix->u.m[2][1], matrix->u.m[0][1] * matrix->u.m[0][1], > + matrix->u.m[1][0] * matrix->u.m[1][0], matrix->u.m[1][1] * matrix->u.m[1][1], > + matrix->u.m[0][0] * matrix->u.m[0][0], matrix->u.m[1][2] * matrix->u.m[1][2], }; > > + out[4] = temp[0] * in[4] + temp[1] * in[5] + temp[2] * in[6] + temp[3] * in[7] + temp[4] * in[8]; Do we really need that much temps? They aren't reused? What are the coeff used for and why are they calculated separately? Are those variables used more than once (coeff[5] and [13] are only used once), maybe it's a mathematical background? What about something like: temp = (matrix->u.m[1][1] * matrix->u.m[0][0] + matrix->u.m[0][1] * matrix->u.m[1][0]) * in[4]; temp -= (matrix->u.m[1][0] * matrix->u.m[2][1] + matrix->u.m[1][1] * matrix->u.m[2][0]) * in[5]; temp += ... out[4] = temp; (using out[4] += may also work, but I'm not sure for cases where in = out, if it's working, we don't need the temp at all, it may be needed to reorder the calculation in that case to start with the index needed in the result ... out[5] = y * in[5]; out[5] += x * in[4]; out[5] += z * in[6]; ...). Cheers Rico

1 0

Re: gdiplus: Add more font transformation tests.
by Vincent Povirk 09 Oct '12

09 Oct '12

> +todo_wine > + expectf(133.203125, bounds.Height); Should we have this level of precision in our font tests?

2 1

Re: d3dx9_36 [patch 2/5]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 09 Oct '12

09 Oct '12

On 09.10.2012 09:49, Nozomi Kodama wrote: > +HRESULT WINAPI D3DXSHEvalHemisphereLight(UINT order, CONST D3DXVECTOR3 *dir, D3DXCOLOR top, D3DXCOLOR bottom, FLOAT *rout, FLOAT *gout, FLOAT *bout) The number of columns used for the code seems to be a little high again. > + if (j >= 4 && j < order * order) > + expected = 0.0f; > + else if ( j >= order * order ) I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch. Cheers Rico

1 0

Fwd: Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Nikolay Sivov 09 Oct '12

09 Oct '12

Forwarding to wine-devel as well P.S. Roman, please reply to wine-devel list next time. -------- Original Message -------- Subject: Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. Date: Tue, 09 Oct 2012 15:27:10 +0400 From: Roman Dadkov <romand(a)etersoft.ru> Organization: Etersoft To: Nikolay Sivov <bunglehead(a)gmail.com> Yes, it's my fail, I forgot, that can be use one enumeration CLSCTX_ALL in this case. Unfortunately, the test for this case can't be added to Wine, because it leads a crash. But I have attached a small test program that shows a problem. It uses CLSID which entered into the registry after installing Office using Wine. Nikolay Sivov 08.10.2012 10:07: > On 10/6/2012 19:29, Roman Dadkov wrote: >> This patch change dwClsContext parameter of a CoCreateInstance call >> in function DefaultHandler_Run. >> Because even if there is some clsid in the registry, the function >> will not be able to run the newly created object. >> >> >> >> - hr = CoCreateInstance(&This->clsid, NULL, CLSCTX_LOCAL_SERVER, >> + hr = CoCreateInstance(&This->clsid, NULL, >> + CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER| >> + CLSCTX_LOCAL_SERVER|CLSCTX_REMOTE_SERVER, >> &IID_IOleObject, (void **)&This->pOleDelegate); > This could be replaced with CLSCTX_ALL. > > Is it possible to add a test for that?

1 0

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Roman Dadkov 09 Oct '12

09 Oct '12

Unfortunately, the test for this case can't be added to Wine, because it leads a crash. But I have attached a small test program that shows a problem. It uses CLSID which entered into the registry after installing Office using Wine.

1 0

Re: [3/3] winemaker: Generate def file from spec file with winebuild
by Alexandre Julliard 09 Oct '12

09 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2576,7 +2577,9 @@ sub generate_project_files($) > if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & $TF_HASDEF)) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.def)\n"; > } elsif (@$target[$T_TYPE] == $TT_DLL) { > - print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "lib\$(${canon}_MODULE:.dll=.def): \$(${canon}_MODULE:.dll=.spec)\n"; > + print FILEO "\t\$(WINEBUILD) --def -E \$(${canon}_MODULE:.dll=.spec) -o lib\$(${canon}_MODULE:.dll=.def)\n\n"; > + print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:.dll=.spec) lib\$(${canon}_MODULE:.dll=.def)\n"; The .so doesn't depend on the .def. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)
by Alexandre Julliard 08 Oct '12

08 Oct '12

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class = > editW, /* name */ > CS_DBLCLKS | CS_PARENTDC, /* style */ > WINPROC_EDIT, /* proc */ > -#ifdef __i386__ > - sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > -#else > +#ifdef _WIN64 > sizeof(EDITSTATE *), /* extra */ > +#else > + sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > #endif Why do you need that? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 2/2] gdi32/tests: Fixed broken tests on non English system Part 2.
by Qian Hong 08 Oct '12

08 Oct '12

Hello Dmitry, Any feedback for this patch? Thanks a lot for any comments! On Thu, Oct 4, 2012 at 3:02 PM, Qian Hong <fracting(a)gmail.com> wrote: > Dmitry, could you review this patch? Thanks a lot ;-) > > This series of patch fix some broken tests on Japanese Windows and Chinese Windows: -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

2 2

Re: [1/3] scrrun: Implement IDictionary_Add and Count
by Alexandre Julliard 08 Oct '12

08 Oct '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > static HRESULT WINAPI dictionary_get_Count(IDictionary *iface, LONG *pCount) > { > dictionary *This = impl_from_IDictionary(iface); > > - FIXME("(%p)->(%p)\n", This, pCount); > + TRACE("(%p)->(%p)\n", This, pCount); > > - *pCount = 0; > + *pCount = list_count(&This->items); You don't want to use list_count(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] gdiplus: Add a font transformation test.
by Vincent Povirk 08 Oct '12

08 Oct '12

Series looks good to me.

1 0

Re: [3/4] ole32: Move the propvariant serialization into a helper function.
by Alexandre Julliard 08 Oct '12

08 Oct '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From eb900b2807167f25ad8f4e97c558dec8b71b070c Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Thu, 4 Oct 2012 16:58:48 -0500 > Subject: [PATCH 3/4] ole32: Move the propvariant serialization into a helper > function. It doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so suminfo.c && touch suminfo.ok suminfo.c:441: Test succeeded inside todo block: value incorrect suminfo.c:450: Test failed: MsiSummaryInfoSetProperty failed 0 make: *** [suminfo.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add retail NVIDIA GeForce GTX 660Ti/660/650
by Henri Verbeet 08 Oct '12

08 Oct '12

On 8 October 2012 03:52, Jimmy Hon <honyuenkwun(a)gmail.com> wrote: > + CARD_NVIDIA_GEFORCE_GTX650 = 0x0FC6, > + CARD_NVIDIA_GEFORCE_GTX660 = 0x11C0, > + CARD_NVIDIA_GEFORCE_GTX660TI = 0x1183, Please use lower case constants like everywhere else.

1 0

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run.
by Nikolay Sivov 08 Oct '12

08 Oct '12

On 10/6/2012 19:29, Roman Dadkov wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will > not be able to run the newly created object. > > > - hr = CoCreateInstance(&This->clsid, NULL, CLSCTX_LOCAL_SERVER, > + hr = CoCreateInstance(&This->clsid, NULL, > + CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER| > + CLSCTX_LOCAL_SERVER|CLSCTX_REMOTE_SERVER, > &IID_IOleObject, (void **)&This->pOleDelegate); This could be replaced with CLSCTX_ALL. Is it possible to add a test for that?

1 0

Re: iphlpapi/tests: Skip tests if functions are not supported
by Dmitry Timoshkov 08 Oct '12

08 Oct '12

André Hentschel <nerv(a)dawncrow.de> wrote: > For Mac, BSD, Solaris If it's Wine specific, then probably there shouild be a todo_wine somewhere to make it clear that under Windows there is no skips. -- Dmitry.

1 0

Please remove this email address
by Ken Sharp 07 Oct '12

07 Oct '12

Hi, I have been receiving daily digests from this mailbox for a while. I tried emailing the "list owner" according to the website but that had no effect. I have been filtering the digests away so I didn't see that people had replied (thanks to everyone who did, sorry I haven't replied). I have tried changing the preferences but it just tells me that this email address doesn't exist. I can't do anything with this. Could someone with relevant access please remove me so that I can add myself again, properly? Thanks, Ken

1 0

Help getting amd64 assembly patch into wine?
by Joerg-Cyril.Hoehle＠t-systems.com 06 Oct '12

06 Oct '12

Dan, I found your message very unclear. >The patch adds support for OpenMP programs like this: And then you start talking about vcomp_fork without telling us where it comes from and what it should do. So I'll guess from the names. - vcomp_for_static/sections_init sound like startup code initialisation of BSS and DATA segments. - fork sounds like running code with thread-local copies to BSS and DATA I guess vcomp eats up one register or parameter to keep a pointer to the thread-local storage. > p_vcomp_fork(0, 1, _test_vcomp_fork_worker1, &ncalls); Your code does not explain what the first parameter is. I believe that va_list etc. is not going to lead you anywhere. First, va_* is only one side. E.g. include/wine/test.h uses va_list and __builtin_ms_va_list You need the other side too, namely, given a va_* structure, call a function X with the parameters given in that structure. The GNU ffcall library http://www.gnu.org/software/libffcall/ distinguishes both. One half is called vacall, the other one avcall :-) Your tests show that you need 2 different va_lists: > p_vcomp_fork(0, 5, _test_vcomp_fork_worker5, 1, 2, 3, 4, 5); 1. On the receiver side, va_start would create a va_list for the parameter set (0, 5, function pointer, 1, 2, 3, 4, 5) 2. But now you need to call something with the apparent parameter set (1, 2, 3, 4, 5) (I say apparent because you don't explain the vcomp execution model. Is a hidden parameter added somewhere? What's that first parameter 0 to fork?) Obviously, if you don't know the internals of a va_list, you'll not be able to transform one structure into the other. So bad, now what is actually needed? Think assembly. Using your test example: + p_vcomp_fork(0, 5, _test_worker5, 1, 2, 3, 4, 5); _vcomp_fork finds data: 1. on the stack 2. in registers 3. in FP registers The C stack layout is (topmost first): 0, then 5, &_test_worker5, 1, 2, etc. What you obviously need to do is, supposing the first parameters are duplicated in registers: - Save registers and possibly FP registers into a structure - Remember the stack pointer and number of elements, -- hereby creating a va_args structure whose layout you know. - CreateThread?? etc. - Restore registers - Shift register parameters by 3 items: (assuming 5 such registers) register-for-param-1 (1) <- register-for-param-4 register-for-param-2 (2) <- register-for-param-5 - Copy from stack into registers register-for-param-3 (3) <- from stack register-for-param-4 (4) <- from stack register-for-param-5 (5) <- from stack - POP 0 and 5 - POP &_test_worker5 into scratch register - JMPTO _test_worker5 via scratch register This assumes there's nothing like CreateThread so you can run from the original stack. If there were, you'd need to copy the 5 elements from the stack to the new one (which is presumably why vcomp_fork receives their number as parameter). Does this help? Jörg Höhle

3 3

Windows audio architecture
by Saulius Krasuckas 06 Oct '12

06 Oct '12

One link catched my eye here: "The evolution of a data structure – the WAVEFORMAT" https://www.assembla.com/spaces/portaudio/wiki/Win32AudioBackgroundInfo Maybe it is of some use for Wine developers too:) Some URLs need adjustment, though. Eg. Creative Labs description of Vista audio architecture changed to: http://forums.creative.com/showthread.php?t=302341 S.

1 0

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'
by Nikolay Sivov 05 Oct '12

05 Oct '12

On 10/5/2012 06:43, max+git(a)mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury <max+git(a)mtew.isa-geek.net> > > --- > dlls/windowscodecs/pngformat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c > index 686f9c6..e8e7cbe 100644 > --- a/dlls/windowscodecs/pngformat.c > +++ b/dlls/windowscodecs/pngformat.c > @@ -899,8 +899,10 @@ static HRESULT WINAPI PngDecoder_Block_GetContainerFormat(IWICMetadataBlockReade > static HRESULT WINAPI PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, > UINT *pcCount) > { > - FIXME("%p,%p: stub\n", iface, pcCount); > - return E_NOTIMPL; > + PngDecoder *This = impl_from_IWICMetadataBlockReader(iface); > + if (!pcCount) return E_INVALIDARG; > + *pcCount = This->ref; > + return S_OK; > } > > static HRESULT WINAPI PngDecoder_Block_GetReaderByIndex(IWICMetadataBlockReader *iface, Return reference count as block count?

3 6

Re: [PATCH 2/3] ntoskrnl.exe: Improve IoGetCurrentProcess stub.
by Dmitry Timoshkov 05 Oct '12

05 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > +EPROCESS process_info; > + > #ifdef __i386__ > #define DEFINE_FASTCALL1_ENTRYPOINT( name ) \ > __ASM_STDCALL_FUNC( name, 4, \ > @@ -1200,8 +1203,11 @@ NTSTATUS WINAPI FsRtlRegisterUncProvider(PHANDLE MupHandle, PUNICODE_STRING Redi > */ > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + FIXME("(): partial stub\n"); > + > + process_info.UniqueProcessId = (PVOID)PsGetCurrentProcessId(); > + > + return &process_info; > } Why do you think that returning the structure filled with garbage is better than returning NULL? -- Dmitry.

3 7

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Paul Chitescu 05 Oct '12

05 Oct '12

On Friday 05 October 2012 10:00:00 am Christian Costa wrote: > --- > include/ddk/ntifs.h | 555 > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 555 > insertions(+) > create mode 100644 include/ddk/ntifs.h > > diff --git a/include/ddk/ntifs.h b/include/ddk/ntifs.h > new file mode 100644 > [...] What version of Windows were these extracted from?

2 2

Re: [PATCH 1/3] ntoskrnl.exe: Add include/ddk/ntifs.h header with EPROCESS struct definition.
by Dmitry Timoshkov 05 Oct '12

05 Oct '12

Did you check the DDK where it's supposed to be declared? -- Dmitry.

1 0

Help getting amd64 assembly patch into wine?
by Dan Kegel 04 Oct '12

04 Oct '12

As you might know from watching too many of my patches scroll by, I've been working on adding support for OpenMP to wine. (A handful of games, and a lot of serious apps, seem to use that api.) After getting it nicely organized and cleaned up to the point where it passed all the tests I could throw at it, I submitted it as http://source.winehq.org/patches/data/90524, Alexandre rejected the patch, saying it had multiple problems, but declining to provide any further hints. He suggested I find someone to work with to get it in... so here I am, hat in hand, asking for help. The patch adds support for OpenMP programs like this: // Compile with "cl test.c /openmp" #include <omp.h> #include <stdio.h> int main (int argc, char **argv) { #pragma omp parallel { printf("%d\n", omp_get_thread_num()); } } Later patches add support for other OpenMP constructs. My patch doesn't actually parallelize the app, but it does let it run rather than crash on unimplemented _vcomp_fork. Visual C will happily provide an assembly listing of this program showing how _vcomp_fork is called, so understanding that interface well enough to pass simple tests wasn't hard. The main challenge was figuring out how to get the variable list of arguments off the stack, and then put them back onto the stack when calling the provided function pointer. This bit of varargs hackery can't be done in pure C as far as I can tell, so I used assembly. I started programming in machine language long ago, so getting that working wasn't too hard once I realized that's what was needed. Getting it to pass the Alexandre test is another matter. Alexandre did give feedback on one earlier iteration of the patch, telling me I was re-inventing the wheel, so I tossed my old assembly and copied the helper-calling code nearly verbatim from call_method in oleaut32/typelib.c. Maybe he objects to not passing copies of the arguments in the floating point registers on amd64... but the arguments are always pointers, so that shouldn't be needed. I'm definitely not yet comfortable with the ASM_CFI stuff, so perhaps there's a problem there, but I did at least verify that injecting a fault into _test_vcomp_fork_worker5() still yielded a good stack trace on both x86 and amd64 in winedbg. There aren't many comments, and the ones I did add aren't the greatest, but I doubt that's the issue. Perhaps he objects to breaking up _vcomp_fork into three functions, but I couldn't see any other way to write it without making later patches like http://source.winehq.org/patches/data/90527 (and a future patch that adds actual multiple threads) put more logic than seems wise into assembly. So maybe it's none of the above. If someone can suggest what I might be missing, I'd appreciate it. Even just "It will break if..." or "Better compare how this was done in..." would be very helpful. Thanks!

2 2

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22013 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 5/5] winex11: Don't send SC_RESTORE when a maximized window switches to fullscreen.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > - if (style & WS_MAXIMIZE) > + if ((style & WS_MAXIMIZE) && (style & WS_CAPTION) == WS_CAPTION) Probably you should test for WS_MAXIMIZEBOX instead. -- Dmitry.

1 0

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + TRACE("()\n"); > + > + /* Return current process id since PEPROCESS is opaque and drivers should not access the struct directly */ > + return (PEPROCESS)PsGetCurrentProcessId(); > } The returned pointer is supposed to be passed to various other ntoskrnl APIs, and it's needs to be a valid pointer to the kernel object. Besides many not trivial kernel drivers (if not all) really dig into internal kernel structures. Same for KeGetCurrentThread. -- Dmitry.

4 4

Re: [PATCH] reg.exe: comparing the names of registry keys
by Jacek Caban 04 Oct '12

04 Oct '12

On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > + int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropriate function name. > + if ((!lpString1 || !*lpString1) && (!lpString2 || !*lpString2)) /* both empty */ > + return TRUE; > + if ( !lpString1 || !*lpString1 || !lpString2 || !*lpString2 ) /* one empty */ > + return FALSE; How about simplifying it to: if(!str1 || !*str1) return !str2 || !*str2; if(!str2 || !*str2) return FALSE; > + cchCount = strlenW(lpString2); > + if (strlenW(lpString1)<cchCount) /* too short */ > + return FALSE; > + > + if ( (CompareStringW(CP_ACP,NORM_IGNORECASE,lpString1,cchCount,lpString2,cchCount)==CSTR_EQUAL) > + && ((lpString1[cchCount] == 0) || (lpString1[cchCount] == (WCHAR){'\\'}))) > + return TRUE; > + else > + return FALSE; This could be simplified: len = strlenW(str2); return !strncmpiW(str1, str2, len) && (!str1[len] || str1[len] == '\\'); Cheers, Jacek

1 0

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Qian Hong <fracting(a)gmail.com> wrote: > --- > dlls/gdi32/tests/font.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.

2 5

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.
by Dmitry Timoshkov 04 Oct '12

04 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > + /* Read memory from the client process memory */ > + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dmitry.

2 1

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22000 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21999 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.
by Marvin 04 Oct '12

04 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21998 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain an applications maintainer to do his work are also switched off. This isn't really what I want. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

2 3

Overriding the check for ownership of a prefix
by Scott Ritchie 03 Oct '12

03 Oct '12

So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the user launches the app (via desktop file) this in turn launches a script that does the following: 1) Makes a temporary folder 2) Sets up a unionfs-fuse copy-on-write mount between ~/.appname and the read-only packaged prefix in /opt, mounted in the temporary folder 3) Runs the app with WINEPREFIX= the temp folder 4) When the app is finished, unmounts the temp folder This all works quite fine: new (or modified) files within the prefix get stored in ~/.appname, to be restored the next time the user runs the app. Distinct users can run the app simultaneously, as they each have their own prefix. Excess file-copying is avoided, as only the user-modified files need to be stored in the home folders. There is one major snag, however: unionfs displays the owner as root until the user has modified/copied it. This means Wine refuses to launch as the user with the "root-owned" prefix. Simply commenting out this part of the code makes Wine work fine, however I'd like to be able to have a proper solution. Would something like a command-line switch or environment variable be acceptable here? Thanks, Scott Ritchie * Note that there is a problem with this setup if the app modifies the registry and we then need to update the prefix-default registry, but that's a different feature request

2 3

Re: [PATCH] advapi32: avoid memory leaks (Coverity)
by Alexandre Julliard 03 Oct '12

03 Oct '12

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -530,8 +530,10 @@ static void test_enum_providers(void) > /* alloc provider to half the size required > * cbName holds the size required */ > providerLen = cbName / 2; > - if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) > + if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) { > + LocalFree(pszProvName); > return; > + } Actually, checking for allocation failures in tests is not useful, it's not going to happen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban 03 Oct '12

03 Oct '12

Hi Marcus, On 10/01/12 23:00, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. > > Second reiteration with Jaceks comment applied Sorry for not catching this later, I was concentrated on your comment instead of the code, but the important thing is that true call_ret means success (and wininet doing request asynchronously is signalled as an error). It means that in this case we want to return RPC_S_OK. What is the exact problem? Jacek

2 2

Re: [PATCH 2/2] vbscript: Added Right() implementation
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21987 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

ImmIsUIMessageA/W
by Aric Stewart 03 Oct '12

03 Oct '12

Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test and fix ImmIsUIMessageA/W. in that patch I see that you eliminate the part where we check if there is a default IME window and if not then create one. if (!IMM_GetThreadData()->hwndDefault) ImmGetDefaultIMEWnd(NULL); also you eliminate the part where if the incoming hWndIME is NULL we send the message to the thread's default IME window. These changes cause the IME to stop working for IME unaware applications. Where the changed intentional and if so based on what documentation? thanks! -aric

3 9

Re: AppDB: Could someone please block this Spammer (UCE)
by Joerg Schiermeier 03 Oct '12

03 Oct '12

Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new account. couldn't you simply reset the spammers password? So if his account is powned he will have to get a new one. > We really do need some sort of moderation for > AppDB comments similar to what's on the forum. In general this is a good idea. -- Regards Joerg Schiermeier Bielefeld/Germany

1 0

AppDB: Could someone please block this Spammer (UCE)
by newsletter [at] Schiermeier-Software 03 Oct '12

03 Oct '12

Hello everybody, could someone of the AppDB admin team please block this UCE-Mails which comes via AppDB-notifications? I'm speaking about this: 1.) Tue, 02 Oct 2012 04:58:05 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631#Comment-8…> 2.) Tue, 02 Oct 2012 12:01:08 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992#Comment-8…> 3.) Tue, 02 Oct 2012 15:11:12 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=2631> 4.) Tue, 02 Oct 2012 15:35:39 -0500 <http://appdb.winehq.org/objectManager.php?sClass=version&iId=4992> Please Rosane, help us...! Thanks a lot! -- Gruss von Joerg Schiermeier

3 2

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Jacek Caban 03 Oct '12

03 Oct '12

Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: > Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek

2 1

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION
by Alexandre Julliard 03 Oct '12

03 Oct '12

Aric Stewart <aric(a)codeweavers.com> writes: > resolves bug 31832 > --- > dlls/imm32/imm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Is there any reason why we are not simply calling DefWindowProc? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] vbscript: Support vb* constants for message box return value (try2)
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21981 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons (try2)
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21980 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] vbscript: Support vb* constants for message box return value
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21979 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [1/2] vbscript: Support vb* constants for message box buttons
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21978 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [2/2] oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin 03 Oct '12

03 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21975 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

1 0

Re: wininet: Fixed failing test
by Dmitry Timoshkov 03 Oct '12

03 Oct '12

Piotr Caban <piotr(a)codeweavers.com> wrote: > - ok(ret, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); > + ok(ret || broken(!ret) /* IE6 */, "GetUrlCacheEntryInfoExW failed with error %d\n", GetLastError()); This kind of blanket test results coverage is broken from the start. -- Dmitry.

1 0

Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.
by Jacek Caban 03 Oct '12

03 Oct '12

On 10/02/12 23:02, Erich E. Hoover wrote: > If a cleanup occurs because HTML Help window creation fails then > list_remove() causes a crash, since the window was never added to the > window list. The attached patch fixes this issue, allowing safe > reloading of files (needed for part 2). This looks like a hack. It would be better to have always valid list entry (if this really can't be added to the list earlier, you may always initialize it by list_init) or make sure to not call ReleaseHelpViewer before HHInfo is fully initialized. Jacek

1 0

Re:cmd: /r is equivalent to /c
by Ann and Jason Edmeades 03 Oct '12

03 Oct '12

Concept of patch is fine (and we ought to support it), but I dont think this would work as coded (if (tolowerW(c)=='c'||'r') will always be true). Also, can you add a quick test for it (there's cmd.exe /c tests - just add a cmd.exe /r echo test worked). PS You might want to just hold off until the patch I submitted last night gets committed as well otherwise there will be merge conflicts ("Change command line parsing away from argv/argc")

1 0

Re: cmd: /r is equivalent to /c
by Dmitry Timoshkov 03 Oct '12

03 Oct '12

Ken Sharp <kennybobs(a)o2.co.uk> wrote: > - if (tolowerW(c)=='c') { > + if (tolowerW(c)=='c'||'r') { In C it doesn't work this way. -- Dmitry.

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Write proper tests for CommandLineToArgvW().
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21949 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 7/7] mshtml: Added script 'for' and 'event' attributes tests
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21945 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet/tests(1/2): Test CommitUrlCacheEntry with the original URL parameter
by Piotr Caban 02 Oct '12

02 Oct '12

On 10/02/12 03:30, Juan Lang wrote: + /* On the other hande, GetUrlCacheEntryInfoEx allows you to query the + * original URL. + */ There's a typo, should be "On the other hand". + /* Strangely, you can create a cache entry redirected to itself. */ + ret = CreateUrlCacheEntry(test_url, 0, "html", filenameA, 0); + ok(ret, "CreateUrlCacheEntry failed with error %d\n", GetLastError()); + create_and_write_file(filenameA, &zero_byte, sizeof(zero_byte)); + ret = CommitUrlCacheEntry(test_url, filenameA, filetime_zero, filetime_zero, + NORMAL_CACHE_ENTRY, NULL, 0, NULL, test_url); In this case original url is ignored. Probably it's a more appropriate comment. Your test is leaving an entry in index.dat file. Please remove test_original_url entry from cache after testing it. Cheers, Piotr

1 0

Re: [PATCH 2/3] vbscript: Added LTrim() implementation
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21943 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] vbscript: Added Trim() implementation
by Marvin 02 Oct '12

02 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21942 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: wininet(2/2): Fail to commit a url cache entry when the original URL is specified and no local filename is given
by Piotr Caban 02 Oct '12

02 Oct '12

On 10/02/12 03:31, Juan Lang wrote: @@ -3084,6 +3084,11 @@ static BOOL CommitUrlCacheEntryInternal( SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } + if (lpszOriginalUrl && !lpszLocalFileName) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } if (lpszOriginalUrl) WARN(": lpszOriginalUrl ignored\n"); The function should succeed if lpszOriginalUrl is specified and it operates on history container. Probably the check for lpszLocalFileName with STICKY_CACHE_ENTRY is also redundant. I guess that the lpszLocalFileName should be validated in following way: if(pContainer->default_entry_type==NORAML_CACHE_ENTRY && !lpszLocalFileName) { SetLastError(ERROR_INVALID_PARAMETER); return FALSE; } I haven't check what happens for cookies containers. Cheers, Piotr

1 0

Re: [PATCH] scsiport.sys: Add stub implementaton of scsiport.sys.
by André Hentschel 02 Oct '12

02 Oct '12

Am 02.10.2012 00:10, schrieb Christian Costa: > This is needed by prosync1.sys (StarForce protection) used in Obscure. > --- > configure | 284 +++++++++++++++++------------------ > configure.ac | 1 > dlls/scsiport.sys/Makefile.in | 9 + > dlls/scsiport.sys/scsiport.c | 39 +++++ > dlls/scsiport.sys/scsiport.sys.spec | 48 ++++++ > 5 files changed, 238 insertions(+), 143 deletions(-) > create mode 100644 dlls/scsiport.sys/Makefile.in > create mode 100644 dlls/scsiport.sys/scsiport.c > create mode 100644 dlls/scsiport.sys/scsiport.sys.spec > > diff --git a/configure b/configure > index 54675b4..801dcf8 100755 > --- a/configure > +++ b/configure > @@ -1,11 +1,13 @@ > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > -# Generated by GNU Autoconf 2.69 for Wine 1.5.14. > +# Generated by GNU Autoconf 2.68 for Wine 1.5.14. You should not include configure changes

2 1

Wine Mono 0.0.8 Release
by Vincent Povirk 01 Oct '12

01 Oct '12

Since I messed up the 0.0.6 release, here's another one, almost identical. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package. * Build process now fails immediately if wine or gmcs is missing, instead of waiting until they're used. (Austin English)

1 0

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)
by Dmitry Timoshkov 01 Oct '12

01 Oct '12

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0); Adding some spaces to make this slightly more readable wouldn't hurt IMHO. -- Dmitry.

2 1

Re: [PATCH 6/6] wininet/tests: Remove all temporary files
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21929 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/6] wininet: Set entry type based on container type
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21928 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/6] wininet: Added support for cache entries overwritting
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21927 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/4] Assorted spelling fixes.
by Julian Rüger 01 Oct '12

01 Oct '12

Hi Francois, > - * size [I] How much percent of cache space should be free. > + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. However I'm not sure of the intended meaning here, it could be "freed". Best regards, Julian

2 1

Re: [PATCH 1/2] vbscript: Added Left() implementation
by Marvin 01 Oct '12

01 Oct '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21919 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Implement IHTMLFrameBase_put_name()
by Jacek Caban 01 Oct '12

01 Oct '12

Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko builds. Jacek

2 1

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error
by Jacek Caban 01 Oct '12

01 Oct '12

Hi Marcus, On 09/29/12 11:44, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. Agreed, thanks for catching it. > Ciao, Marcus > --- > dlls/rpcrt4/rpc_transport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 686ce68..e572b78 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -1882,7 +1882,7 @@ static RPC_STATUS wait_async_request(RpcHttpAsyncData *async_data, BOOL call_ret > > if(call_ret) { > RpcHttpAsyncData_Release(async_data); > - return RPC_S_OK; > + return call_ret; /* The Http* status codes map into the RPC_S namespace */ Not really, Http* APIs return BOOL and GetLastError() call is needed to get error code. AFAIR, when I tested this code, most HTTP-related errors were translated to RPC_S_SERVER_UNAVAILABLE by rpcrt4. That may be a better choice here as well. Jacek

1 0

Re: d3dx9_36 [patch 2/5, try 4]: Speed-up some tests.
by Rico Schüller 01 Oct '12

01 Oct '12

On 01.10.2012 03:28, Nozomi Kodama wrote: > + for (order = 0; order <= D3DXSH_MAXORDER + 1 ; order++) Well, I'm not sure what you are doing with the spaces ... I say it again, if you got a comment, read it carefully take a look at your code and fix it. I mentioned white space issues a couple of times. And I think I mentioned the problem already ... I accidentally send it to wine-patches instead of wine-devel (sorry, this was my mistake): http://www.winehq.org/pipermail/wine-patches/2012-September/118230.html. Cheers Rico

1 0

Re: d3dx9_36 [patch 1/5, try 4]: Implement D3DXSHMultiply4
by Rico Schüller 01 Oct '12

01 Oct '12

On 01.10.2012 03:27, Nozomi Kodama wrote: > I used FLOAT * WINAPI, though I don't like it. Yeah, that's not much of an issue... and this is not the showstopper. > + TRACE("(out %p, a %p, b %p)\n", out, a, b); What I'm a bit curious about is, why do you reinvent a new style in a new patch (see http://www.winehq.org/pipermail/wine-devel/2012-September/097133.html and http://www.winehq.org/pipermail/wine-devel/2012-September/097131.html)? I'm not sure if my wording is that hard to understand. For me the preferred option for the TRACE is: "TRACE("out %p, a %p, b %p\n", out, a, b);" And the one also used in the file is: "TRACE("(%p, %p, %p)\n", out, a, b);" Please use exactly one of those. Not mixture, no extra brackets... Sorry, I should have written an answer to the (try 3), but I wasn't fast enough. Cheers Rico

1 0

Re: ws2_32: Fix TRACE format in WS_getsockname
by Dmitry Timoshkov 01 Oct '12

01 Oct '12

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > @@ -2444,7 +2444,7 @@ int WINAPI WS_getsockname(SOCKET s, struct WS_sockaddr *name, int *namelen) > int fd; > int res; > > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, *namelen); > > /* Check if what we've received is valid. Should we use IsBadReadPtr? */ > if( (name == NULL) || (namelen == NULL) ) Taking into account check after the trace printing the contents of namelen should be replaced by printing its pointer. -- Dmitry.

1 0

Re: [PATCH 5/5] ntoskrnl.exe: Implement IoAllocateMdl.
by Dmitry Timoshkov 01 Oct '12

01 Oct '12

Christian Costa <titan.costa(a)gmail.com> wrote: > PMDL WINAPI IoAllocateMdl( PVOID VirtualAddress, ULONG Length, BOOLEAN SecondaryBuffer, BOOLEAN ChargeQuota, PIRP Irp ) > { > PMDL mdl; > + ULONG address = (ULONG)VirtualAddress; This won't work on 64-bit. > + mdl->StartVa = (PVOID)page_address; and this. > + mdl->ByteCount = Length; > + mdl->ByteOffset = address - page_address; Probably the type of size holding parameters/variables should be SIZE_T. -- Dmitry.

1 0

Re: dmusic: Fix a copy and paste error
by Christian Costa 29 Sep '12

29 Sep '12

Le 29/09/2012 17:11, Sven Baars a écrit : > This should fix http://bugs.winehq.org/show_bug.cgi?id=31805 > > Good catch !

1 0

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.
by Hans Leidekker 29 Sep '12

29 Sep '12

On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote: > diff --git a/dlls/msi/media.c b/dlls/msi/media.c > index 612624d..8a39fcd 100644 > --- a/dlls/msi/media.c > +++ b/dlls/msi/media.c > @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE fdint, > > if (strcmpiW( mi->cabinet, cab )) > { > - ERR("Continuous cabinet does not match the next cabinet in the Media table\n"); > - goto done; > + LPSTR next_cab; > + > + WARN("Continuous cabinet %s does not match the next cabinet %s in the media table\n", debugstr_w(cab), debugstr_w(mi->cabinet)); > + > + /* Use cabinet name from the media table */ > + next_cab = strdupWtoA(mi->cabinet); > + /* Modify path to cabinet file with full filename (psz3 points to a 256 bytes buffer that can be modified contrary to psz1 and psz2) */ > + strcat(pfdin->psz3, "\\"); > + strcat(pfdin->psz3, next_cab); > + /* Path psz3 and cabinet psz1 are concatenated by FDI so just reset psz1 */ > + *pfdin->psz1 = 0; > + msi_free(next_cab); > } > > if (!(cabinet_file = get_cabinet_filename(mi))) The requirement that the continuous cabinet name matches the next cabinet in the media table might simply be too strict. Perhaps we need to try them one by one and let FDI decide based on the setID and iCabinet fields. Can you please add some tests?

2 3

Re: [PATCH] wined3d: move texture reference decrement to end of usage (Coverity)
by Henri Verbeet 29 Sep '12

29 Sep '12

On 29 September 2012 11:14, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > I do not fully understand all this, but it seem the decref needs to > be behind the last usage of prev. > Sort of. It's probably better to do it like this, but a non-zero bind_count implies a non-zero reference count as well, so in practice there's no danger of using prev after it's free'd.

1 0

Fwd: CIA going down: KGB wants your commits!
by Austin English 29 Sep '12

29 Sep '12

-- -Austin ---------- Forwarded message ---------- From: Martín Ferrari <martin.ferrari(a)gmail.com> Date: Thu, Sep 27, 2012 at 3:52 PM Subject: CIA going down: KGB wants your commits! To: debian-project(a)lists.debian.org, Debian Developers <debian-devel(a)lists.debian.org> Hi there! Not to "to knock 'em when they're down", but since it seems that the CIA.vc service has officially closed recently (cannot find exactly when did that happen), I think it's worthwhile offering this little project we (dam@, gregoa@, and me) have since a few years ago, called KGB (ha-ha). It's a very simple and dumb client-server architecture: IRC bots running in our personal servers listen for SOAP messages sent by kgb-clients called from post-commit hooks in repos out there. The bot just relays and formats a message, nothing fancier than that. So, if you're looking for a simple IRC notification of your commits, this might be of help. You can either run your own bot (debian package kgb-bot), or use ours. As for the client, alioth does not have it installed, but you can run it off /home/groups/kgb. There's a sample configuration there too. In /home/groups/pkg-perl/meta/pkg-perl-post-receive you can see how to use it from a post-commit hook. If you rather use our bots, we'll need you to provide: a project/repository name, an IRC channel, and a password (used to avoid spam, not really secure). -- Martín Ferrari -- To UNSUBSCRIBE, email to debian-devel-REQUEST(a)lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org Archive: http://lists.debian.org/CAL60Pd_7zoPk4w4rta49-jymxzKOU+K7DdqZUiqsP32KZ9bQBA…

3 2

Re: comctl32: use GetWindowLong to check for scrollbar (try 2)
by Nikolay Sivov 28 Sep '12

28 Sep '12

On 9/28/2012 20:43, Daniel Jelinski wrote: > Corrected from first try: > - uses GetWindowLong instead of GetWindowLongPtr > - does not touch dwStyle Sorry, was busy to reply earlier. I think this fix is ok if it really helps, thanks for working on this.

1 0

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0
by Alexandre Julliard 28 Sep '12

28 Sep '12

Anssi Hannula <anssi.hannula(a)iki.fi> writes: > Some Linux distributions (at least Mageia) build packages with > -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which > checks for enabled fortify and adds "-U_FORTIFY_SOURCE > -D_FORTIFY_SOURCE=0". Unfortunately, -Wp,-Dfoo are applied after -Dfoo, > so the added flags fail to override the fortify in the CFLAGS. I would say that's a distro bug. Defaulting to Fortify is already broken enough, but making it even harder to disable is stupid. I don't think we want to get into that kind of arms race. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame. Take 2.
by Vincent Povirk 28 Sep '12

28 Sep '12

Looks good, thanks.

1 0

Re: [PATCH 2/2] vbscript: Added MonthName implementation
by Marvin 28 Sep '12

28 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21880 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdi32: Fixed freetype working function
by Alexandre Julliard 28 Sep '12

28 Sep '12

Сергей Мосин <svmosin(a)gmail.com> writes: > The function WineEngAddFontMemResourceEx in gdi32/fretype.c contained > strange XOR operation with some random number 0x87654321, instead of > returning the real font handle. Do you have an app that depends on this? What does it do with the handle? -- Alexandre Julliard julliard(a)winehq.org

1 0

is CreateThread(CREATE_SUSPENDED) fully functional?
by Joerg-Cyril.Hoehle＠t-systems.com 27 Sep '12

27 Sep '12

Hi, Recently I thought I found a use-case for CreateThread(CREATE_SUSPENDED). The idiom is to get the thread handle before the thread starts a life on its own. I looked at the kernel tests, http://source.winehq.org/source/dlls/kernel32/tests/thread.c#L460 However, both invocations with CREATE_SUSPENDED actually test the pair CreateThread + SuspendThread. The tests do not prove that CREATE_SUSPENDED works! They only prove that the suspend counter and perhaps SuspendThread work. a) Does Wine not support CREATE_SUSPENDED, so that the tests do the best they can? In such a case, a WARN("ignoring SUSPENDED flag, beware of race conditions\n") would be appropriate. or b) CREATE_SUSPENDED is fully supported on all platforms. Then the tests need some refinement. Thank you, Jörg Höhle

3 2

Re: [1/3] gdiplus: Move font substitution test into a separate body.
by Vincent Povirk 27 Sep '12

27 Sep '12

The series looks good to me. Very cool to have a fix for this.

1 0

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame.
by Vincent Povirk 27 Sep '12

27 Sep '12

> @@ -3898,7 +3894,7 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d > return Ok; > } > > - IStream_Release(stream); > + IStream_Release(image->stream); > return stat; > } I don't think it's necessary to AddRef/Release the stream anymore in GdipImageSelectActiveFrame. Creating the new image and freeing the old one will update the refcount as necessary. And it's a bit confusing since technically the current image->stream is released by free_image_data then overwritten (with the same value, fortunately) by copying new_image to image. Looks good otherwise.

1 0

'sort' implementation (Bug 27933) - any easy way?
by Ann and Jason Edmeades 27 Sep '12

27 Sep '12

Hello, While working on more of the 'for' processing in the command shell, I've come across a stumbling block that wildcard expansion 'ordering' is not guaranteed (findfirst/findnext) meaning I cannot automate tests for some of the key bits - this is frustrating as we really need tests for the things I'm looking at as the code is getting complex. Looking in the cmd testsuite, there's already some commented out tests as well, saying we really need a 'sort' implementation, and that would also resolve the problem I have at the moment. Therefore, I'd like to know if there's any simple way to implement a command line sort program which we can call from the command shell. This has subsequently been raised as bug 27933. My first thought was to avoid reinventing the wheel and to have a windows program called sort which parses its parameters and then runs the Unix 'sort' command with an equivalent command line. I think most of the windows command line parameters have Unix equivalents, and for the majority of cases it would be a case of transposing a windows path to a Unix path, and just running the Unix sort. However, I then started to get concerned about stdin / stdout... Is there any way to take the windows stdin and 'connect it' to the unix program you spawn, and vica-versa for the stdout. Whilst I dont accurately need this for the testsuite, without it the wine implementation would not match the windows one. So I think my specific questions are... 1. Is wrappering an existing (Linux) 'sort' program an option for this, or do we really need a whole unique implementation of sort (which I would have no idea how to write!)? If it is an option, the two key questions I have are: 2. How do I handle stdin / stdout, so sort can work in pipes / redirects 3. Is it ok to use wine_get_unix_file_name to convert files and directories to the unix equivalents when building the unix equivalent command line? (as per winepath) Thanks. Jason

1 0

Re: d3dx9_36 [patch 6/6]: Implement D3DXSHEvalHemisphereLight
by Rico Schüller 27 Sep '12

27 Sep '12

Well I think, if you rework a series, please add something like try xyz or so ... Also try to avoid to add / remove some patches, at least if they actually don't have anything todo with the rest of the patch set (if they could be submitted on their own). On 27.09.2012 10:00, Nozomi Kodama wrote: > + TRACE("%u, %p, %p, %p, %p, %p, %p\n", order, dir, &top, &bottom, rout, gout, bout); Sure, that's an other form of the trace. I think we hadn't one with such a version... other traces in the file look like (the one marked with * is my preferred version): TRACE("out %p, order %u, a %p, b %p\n", out, order, a, b); * TRACE("(%p, %p, %u)\n", pout, pin, n); I don't think it makes much sense to print the address for &top. It doesn't gather some useful information, does it? Instead you may print the actual content for r,g,b if you like. > + if ( gout ) Also here, I prefer "if (gout)" ... I know there are several occurrences for the other style ... I should have mentioned that earlier ... it's not something which is critical... git grep "if (" dlls/d3dx9_36/* | wc -l reveals ~2000 while git grep "if ( " dlls/d3dx9_36/* | wc -l does ~100 > + ok(relative_error(expected, blue_out[j]) < admitted_error, > + "Blue: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, blue_out[j]); Please indent 8 instead of 2 spaces when a new line is used ... Cheers Rico

1 0

dsound: Don't bother shrinking the secondary buffer list.
by Joerg-Cyril.Hoehle＠t-systems.com 27 Sep '12

27 Sep '12

Michael, >+#include <assert.h> your patch is already committed, yet I believe that the least that dsound needs is new asserts. Asserts in dsound have been a PITA in Wine for the last decade. It's ok for the kernel to crash in an assert. IMHO it is not ok for an optional thing like sound. The assert's backtrace will not help anybody, because the logical error will have happened much earlier. Instead, a plain ERR would have been just as telling. Let's quote http://www.winehq.org/docs/winedev-guide/debugging#DBG-CLASSES "ERR: Messages in this class indicate serious errors in Wine, such as as conditions that should never happen by design." I recommend: - assert(device->buffers[0] == pDSB); + if (pdevice->buffers[0] != pDSB) + ERR("broken device buffer %p\n", device->buffers[0]); HeapFree(GetProcessHeap(), 0, device->buffers); device->buffers = NULL; The ERR is IMHO revealing enough in a user's log. If a sound component detects a bogus state, I'd very much prefer that it disables sound -- without crashing. Regards, Jörg Höhle

2 1

Re: d3dx9_36 [patch 1/6]: Implement D3DXSHMultiply4
by Rico Schüller 27 Sep '12

27 Sep '12

On 27.09.2012 09:56, Nozomi Kodama wrote: > +FLOAT* WINAPI D3DXSHMultiply4(FLOAT *out, CONST FLOAT *a, CONST FLOAT *b) FLOAT * WINAPI D3DXSHMultiply4(FLOAT *out, const FLOAT *a, const FLOAT *b) A minor nitpick, anyone against something like? I think that was what Matteo meant in http://www.winehq.org/pipermail/wine-devel/2012-September/096924.html with "Fix the FLOAT*"? > + TRACE("(%p, %p, %p)\n", out, a, b); I would probably prefer: TRACE("out %p, a %p, b %p\n", out, a, b); I know the other Multiply functions and so on use your trace format... > + out[0] = 0.28209479f * a[0] * b[0]; There are still double spaces ... Hint: it's not the only occurrence. Cheers Rico

1 0

Re: d3dx9_36 [patch 2/6]: Speed-up some tests
by Rico Schüller 27 Sep '12

27 Sep '12

On 27.09.2012 09:57, Nozomi Kodama wrote: > - FLOAT a[64], b[64], got; > + FLOAT a[49], b[49], got; > CONST FLOAT expected[] = > { 0.5f, 0.5f, 25.0f, 262.5f, 1428.0f, 5362.0f, 15873.0f, 39812.0f, 88400.0f, }; > > - for (i = 0; i < 64; i++) > + for (i = 0; i < 49; i++) > > - for (i = 0; i < 9; i++) > + for (i = 0; i <= D3DXSH_MAXORDER + 1; i++) Again: You may correct the (array) size for the expected value ... If we run til element 7 instead of 8, I think the last element could be thrown away? Cheers Rico

1 0

Re : d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Nozomi Kodama 26 Sep '12

26 Sep '12

>On 26.09.2012 12:17, Nozomi Kodama wrote: >> + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; >> + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; >> + out[13] += ta * b[13] + tb * a[13]; <> + t = a[13] * b[13]; >> + out[0] +=0.28209479f *t; >Please use spaces with care. >The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if >you like to indent something, that's mostly not the case when calculating a value. Even then, please be >consistent across your patch. oops!!! I will take care of this one. >> + D3DXSHMultiply4(c, a, b); >>What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Tests in native show that D3DXSHMultiply gives what I implemented. We can not reuse a input variable as output (we don't obtain what we expect logically). >Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we >use defines? A problem might be to find good names... Maybe the Multiply functions could share the >same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see >comment above) then it may be possible to rearrange the calculation. > >ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; >vs >ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; I do the computations with a formal computation software. Unfortunately I did not use the same for D3DXSHMultiply4 and D3DXSHMultiply3 ..... (Xcas vs Maple). And obtain the exact values look beyond the capacities of these softwares. And even the worst, since the integrated functions oscillate, the internal algorithm of the software are not robust to compute the integrals. For a given number of significative digits, that's why we obtain slightly different values for the both softwares. Addind defines will add tons on variables for no gain. But I can simplify slightly the function by calling D3DXSHMultiply3. I will give it a try. I worry about efficiency. Best regards Nozomi >Cheers >Rico

2 1

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Alexandre Julliard 26 Sep '12

26 Sep '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > oledb32: Add support for IDBInitialize interface in IDataInitialize It doesn't work here: ../../../tools/runtest -q -P wine -M oledb32.dll -T ../../.. -p oledb32_test.exe.so database.c && touch database.ok database.c:43: Test failed: Unable to load oledb library make[1]: *** [database.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 3) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard 26 Sep '12

26 Sep '12

Aric Stewart <aric(a)codeweavers.com> writes: > - if (data->imeWnd == NULL) > + if (defWnd == NULL) > { > /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + defWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + SetWindowLongPtrW(defWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = defWnd; So now, shouldn't you be resetting IMMGWL_IMC at some point? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: (resend) imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard 26 Sep '12

26 Sep '12

Aric Stewart <aric(a)codeweavers.com> writes: > This corrects issues with applications that create and manage multiple IMCs > try 2: > avoid premature destruction of the window > --- > dlls/imm32/imm.c | 22 ++++++++++++---------- > dlls/imm32/tests/imm32.c | 28 ++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+), 10 deletions(-) > > > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 7394101..a18aa26 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -678,10 +678,6 @@ static BOOL IMM_DestroyContext(HIMC hIMC) > data->immKbd->pImeSelect(hIMC, FALSE); > SendMessageW(data->IMC.hWnd, WM_IME_SELECT, FALSE, (LPARAM)GetKeyboardLayout(0)); > > - if (IMM_GetThreadData()->hwndDefault == data->imeWnd) > - IMM_GetThreadData()->hwndDefault = NULL; > - DestroyWindow(data->imeWnd); > - > ImmDestroyIMCC(data->IMC.hCompStr); > ImmDestroyIMCC(data->IMC.hCandInfo); > ImmDestroyIMCC(data->IMC.hGuideLine); > @@ -2323,12 +2319,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So why is there a window in the IMC at all, if it's not used for anything? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/8] vbscript: Added VT_R8 support to to_int
by Marvin 26 Sep '12

26 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21824 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] vbscript: Added Round implementation
by Marvin 26 Sep '12

26 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21823 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: d3dx9 [patch 1/5]: Implement D3DXSHMultiply4
by Rico Schüller 26 Sep '12

26 Sep '12

On 26.09.2012 12:17, Nozomi Kodama wrote: > + ta =0.28209479f * a[0]+ 0.14567312f * a[8]+ 0.12615663f * a[6]; > + tb =0.28209479f * b[0]+ 0.14567312f * b[8]+ 0.12615663f * b[6]; > + out[13] += ta * b[13] + tb * a[13]; > + t = a[13] * b[13]; > + out[0] +=0.28209479f *t; Please use spaces with care. The preferred way is "x = 123 * a[0] + 456 * b[234]; Mostly one space is enough, only use two or more if you like to indent something, that's mostly not the case when calculating a value. Even then, please be consistent across your patch. > + D3DXSHMultiply4(c, a, b); What happens if you use something like D3DXSHMultiply4(c, c, c). Is that allowed? Also is there a reason why it uses slightly different values than e.g. D3DXSHMultiply3? Why don't we use defines? A problem might be to find good names... Maybe the Multiply functions could share the same base? To me it looks like they do share a lot of calculations, And if the order doesn't matter (see comment above) then it may be possible to rearrange the calculation. ta = 0.28209479f * a[0] - 0.12615663f * a[6] - 0.21850969f * a[8]; vs ta = 0.28209479f * a[0] - 0.12615662f * a[6] - 0.21850968f * a[8]; Cheers Rico

1 0

Re: winspool/tests: Don't crash when AddJob/GetJob fails (win8)
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21799 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine Mono 0.0.6 Release - Because hey, why not?
by Vincent Povirk 25 Sep '12

25 Sep '12

I have published version 0.0.6 of Wine Mono on Sourceforge, because it's probably not good to let it get too stale. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.4: * Updated the visual basic class libraries from upstream. * Updated mono from 2.11.1 to 2.11.4. Unfortunately, there wasn't a nice changelog like 2.11.1 had. Here are some highlights: * Beginnings of support for hosting ActiveX controls inside winforms. (Alistair Leslie-Hughes) * Various HttpClient-related fixes. (Martin Baulig) * "Intermediate" state check boxes now rendered in winforms. (Steven Boswell II) * ACL support on Windows. (James Bellinger) * One can now specify WINE_MONO_TRACE=wrapper to log all transitions between native and managed code, which is sort of the Mono equivalent of a relay log. * RVA fields can now be accessed properly via the ldsfld[a] instruction. This should help with Managed C++ support. * Fix for winehq bug 30947 - Mono would cause a hang when a dll is loaded after Mono is loaded but before it is used to run any .NET code. * Because of a problem with the build system, MonoPosixHelper.dll was not present, and this prevented some builtin methods in Mono from working correctly. This has been resolved. * Added hashes for all included files in the msi package, which is needed for msi to replace the files on upgrade. * Added 64-bit registry entries to the msi package.

1 1

Re: imm32: there is only 1 default Hwnd per thread
by Alexandre Julliard 25 Sep '12

25 Sep '12

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > > if (data->imeWnd == NULL) > { > - /* create the ime window */ > - data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > - data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > - 0, data->immKbd->hIME, 0); > - SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > - IMM_GetThreadData()->hwndDefault = data->imeWnd; > + HWND def = IMM_GetThreadData()->hwndDefault; > + if (def == NULL) > + { > + /* create the ime window */ > + data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > + data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > + 0, data->immKbd->hIME, 0); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > + IMM_GetThreadData()->hwndDefault = data->imeWnd; > + } > + else > + data->imeWnd = def; So what happens to the window if the first IMC is destroyed? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.
by Juan Lang 25 Sep '12

25 Sep '12

Hi Qian, > There is a winpcap based network authentication client which check for the DhcpEnabled value, this patch make the app happy and then the app works with André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement DhcpEnabled status? I think this is fine, but you'd want to remove/fix some outdated comments I wrote at the same time: * NOTES * Since GetAdaptersInfo never returns adapters that have DHCP enabled, * this function does nothing. * * FIXME * Stub, returns ERROR_NOT_SUPPORTED. */ DWORD WINAPI IpReleaseAddress(PIP_ADAPTER_INDEX_MAP AdapterInfo) { TRACE("AdapterInfo %p\n", AdapterInfo); /* not a stub, never going to support this (and I never mark an adapter as DHCP enabled, see GetAdaptersInfo, so this should never get called) */ The same comments are in IpRenewAddress. Historical reason: when I wrote iphlpapi's first implementation, I had recently been working on a Windows app that released and renewed IP addresses on DHCP-enabled interfaces, because Windows at the time was pretty poor at doing so in response to changes to wireless connection state. I figured I wouldn't be the only one to have had to work around this issue, so I didn't want to have to implement IpReleaseAddress and IpRenewAddress in Wine. That was almost 10 years ago now, so these reasons no longer apply. I'm pretty sure the app I wrote isn't in use any longer, and even if it is, it isn't in use on Wine (I also wrote a Linux version.) Thanks, --Juan

3 2

Re: vbscript: Added Space() implementation
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21787 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] mshtml: Added DISPATCH_PROPERTYGET|DISPATCH_METHOD flags support for elements exposed as window properties
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21785 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: shlwapi: PathCreateFromUrlA() should not crash when given NULL buffers.
by Alexandre Julliard 25 Sep '12

25 Sep '12

Francois Gouget <fgouget(a)codeweavers.com> writes: > Add NULL and insufficient buffer tests for PathCreateFromUrl(). > --- > dlls/shlwapi/path.c | 3 +++ > dlls/shlwapi/tests/path.c | 49 +++++++++++++++++++++++++++++---------------- > 2 files changed, 35 insertions(+), 17 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so path.c && touch path.ok path.c:322: Test succeeded inside todo block: got len = 22 expected 22 from url file:///localhost/c:/foo/bar path.c:322: Test succeeded inside todo block: got len = 19 expected 19 from url file://host//c:/foo/bar make: *** [path.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oledb32: Add support for IDBInitialize interface in IDataInitialize
by Marvin 25 Sep '12

25 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21782 Your paranoid android. === WNT4WSSP6 (32 bit marshal) === marshal.c:66: Test failed: CoMarshalInterface failed with error 0x80040155 marshal.c:239: Test failed: "CoUnmarshalInterface" failed with error 0x8003001e marshal: unhandled exception c0000005 at 004165D0

2 1

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)
by Per Johansson 25 Sep '12

25 Sep '12

Hi, I should probably add a note that when I wrote this I had some doubts it it belongs in start.exe, and I still somewhat do. The alternative would be to write a new program. The advantage to that is: 1. start.exe is left more similar to it's windows counterpart. 2. This other program could handle multiple files sent in the same AppleEvent, which is possible. 3. The same program could also act as a proxy for a dock icon, handling clicks and activating windows (this is a later project). I'd imagine it'd be called winehostproxy or somesuch and handle several types of interaction with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson <pelle(a)morth.org> >

2 2

Re: [5/5] dxgi/tests: Test some reference counts.
by Alexandre Julliard 25 Sep '12

25 Sep '12

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/device.c | 69 > ++++++++++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 18 deletions(-) In general testing reference count values is not useful, unless you have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spam applications for testbot accounts
by Scott Ritchie 25 Sep '12

25 Sep '12

Never underestimate the overeagerness of bots, I suppose... We're getting a lot of spam applications for testbot accounts now, maybe 2-3 per day. Some are easy to discard because they put stuff like penis pills into the info field, but others look like just names. Suggestions are welcome. In the meantime it would be nice if anyone requesting a legit account put some sort of non-spammy text in there like "Hey I'm a human I read wine-devel"

2 1

Overriding the check for ownership of a prefix
by Joerg-Cyril.Hoehle＠t-systems.com 25 Sep '12

25 Sep '12

Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: >Note that there is a problem with this setup if the app modifies the >registry and we then need to update the prefix-default registry I've excellent experience with symbolic links. In fact, none of the apps (games) I use are installed directly within any .wine prefix. Drive_c/Program Files/Games is a symbolic link to a large partition. >Imagine a distro package containing a Windows game in the form of a >read-only copy of an installed prefix (into, say, /opt). So I recommend the following setup: - Have the game's main directory be something like /opt/games/XYZ in UNIX, but tell it to install to C:\games/XYZ - During installation, write down all registry keys that the app creates and every file that it stores outside of its local directory. Beware: the name of the directory C:\Program.. depends upon every user's locale at .wine creation time! Use C:\Games\ instead to avoid that pitfall. For every user: - After .wine is created normally, add a symlink from Drive_c/Games to /opt/games - Add registry keys or dlls needed by the app. wineprefixcreate ln -s /opt/games/XYZ $HOME/.wine/drive_c/games cp -p whatever.dll $HOME/.wine/drive_c/windows/system32/ wine regedit xyz.reg Trivial, isn't it? Typically, you don't need to recreate the content of user-local APPDATA directories. The app will create them upon each run, since they ought to run with different users on one machine. Caveat: Although my .wine and games directories are distinct, I've no experience with write-protecting the games partition. Obviously, this only has a chance to work with modern apps, written after MS started recommending separating the app's dir from its per-local configuration files to be since stored in ~/LOCALAPPDATA or the like. Thus w9x/w2k-era games are ruled out. Still, I don't know where those apps attempt to store e.g. crash logs. I've seen apps write high-scores or savegames to their central directory when w2k was set in winecfg, and use HKCU/LOCALAPPDATA (what's the exact name?) when running in xp mode. I've made excellent experience with plenty of apps sharing a single .wine-games prefix with such a setup. I.e. you don't need one prefix per app. Like on a real box, the apps ought to be able to coexist. Drawback: when I was initially attracted to Wine 5 years ago, every .wine was a tiny 3-4MB. Nowadays it's more than 10 times that size, and I'm not happy with that. Using a single onion-union-fs to share drive_c/xyz may be interesting -- for as long as one single version of Wine is in use. Regards, Jörg Höhle

2 1

d3dx9: Implement D3DXSHEvalDirectionalLight
by Nozomi Kodama 24 Sep '12

24 Sep '12

Hello, do it remain problems with this patch? Nozomi

1 0

Re: [PATCH] dmusic: Add master clock tests.
by Andrew Eikum 24 Sep '12

24 Sep '12

On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > + hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > + ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > + ok(clock != NULL, "No clock returned\n"); > + trace(" guidPort = %s\n", debugstr_guid(&guid_clock)); > + Minor nit-pick: you never release the clock.

1 0

Re: [PATCH 2/2] mshtml: Added function overriding tests
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: Assorted spelling fixes.
by Julian Rüger 24 Sep '12

24 Sep '12

Hi Francois, > - /* if we set the bufferpointer to NULL here UrlUnescape fails and string gets not converted */ > + /* if we set the buffer pointer to NULL here UrlUnescape fails and the string is not converted */ for consistency with the other buffer pointer comments and better readability, I suggest you add a comma here: + /* if we set the buffer pointer to NULL here, UrlUnescape fails and the string is not converted */ Best regards, Julian

1 0

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] mshtml: Added function overriding tests
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

RFC: Locale-independent case-insensitive string comparison
by Francois Gouget 24 Sep '12

24 Sep '12

diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } - if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE, + if(CSTR_EQUAL != CompareStringW( LOCALE_INVARIANT, NORM_IGNORECASE, request->path, strlenW(request->path), szHttp, strlenW(szHttp) ) && request->path[0] != '/') /* not an absolute path ?? --> fix it !! */ { In this code snippet it feels wrong to have this string comparison depend on the system locale, which in Wine's case would come from the user's Unix locale. Isn't this a case where LOCALE_INVARIANT would be better? However I have not found a case where this makes a difference anyway, either with 'http:' or with 'file:'. That is, 'file:' always matches 'FILE:', even in Turkish, as long as I don't use NORM_LINGUISTIC_CASING. Conversely, 'fîle:' is different from 'FILE:' no matter what. Once I have a CompareString() test-case I can make some for UrlIs(), PathCreateFormURL(), possibly ShellExecute(), etc. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.
by Józef Kucia 24 Sep '12

24 Sep '12

Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote: > + hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > + ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) > + for (i = 0; i < 16; i++) > + ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i], > "Byte at index %u is 0x%02x, expected 0x%02x\n", i, > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]); > + IDirect3DTexture9_Release(texture); > You should call IDirect3DTexture9_UnlockRect before IDirect3DTexture9_Release.

2 1

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Henri Verbeet 24 Sep '12

24 Sep '12

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > + ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > + for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++) I generally prefer "sizeof(*refresh_list)", or perhaps "sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this kind of situation. > + "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator); These are unsigned variables.

1 0

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.
by Henri Verbeet 24 Sep '12

24 Sep '12

On 23 September 2012 22:40, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) "rational" should be const.

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Józef Kucia 24 Sep '12

24 Sep '12

On Sun, Sep 23, 2012 at 10:40 PM, Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> wrote: > +struct refresh_rates refresh_list[] = > +{ > + {60, 60, FALSE, FALSE}, > + {60, 0, TRUE, FALSE}, > + {60, 1, TRUE, TRUE}, > + { 0, 60, TRUE, FALSE}, > + { 0, 0, TRUE, FALSE}, > +}; It's probably better to declare it inside test_createswapchain(). It could also be static const. > + hr = IDXGISwapChain_Release(swapchain); > + ok(hr == 0, "Release failed, hr %d.\n", hr); It should be assigned to refcount. > + hr = IDXGIFactory_Release(factory); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IDXGIAdapter_Release(adapter); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); > + > + hr = IUnknown_Release(obj); > + ok(SUCCEEDED(hr), "Release failed, hr %#x.\n", hr); Release doesn't return HRESULT and the value returned by Release shouldn't be tested with SUCCEEDED. refcount = IDXGIFactory_Release(factory); ok(!refcount, "ID3DXGIFactory has %u references left\n", refcount);

1 0

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.
by Alexandre Julliard 24 Sep '12

24 Sep '12

Ričardas Barkauskas <rbarkauskas(a)codeweavers.com> writes: > --- > dlls/dxgi/tests/Makefile.in | 2 +- > dlls/dxgi/tests/device.c | 147 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 148 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p dxgi_test.exe.so device.c && touch device.ok device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. device.c:425: Test failed: SetFullscreenState failed, hr 0x80004001. make: *** [device.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Assorted spelling fixes.
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21742 Your paranoid android. === W2K3R2SESP2 (32 bit sync) === sync.c:972: Test failed: DeleteTimerQueueTimer

1 0

Re: [7/8] windowscodecs: Calculate transparent color index for global GIF palette.
by Marvin 24 Sep '12

24 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21729 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/8] windowscodecs: Add some tests for GIF palette.
by Vincent Povirk 24 Sep '12

24 Sep '12

Series looks good to me.

1 0

WineHQ on CMS/Framework
by Kyle Auble 23 Sep '12

23 Sep '12

After working on the wiki for a while, I finally wanted to ask about possibly moving WineHQ to a CMS or web framework. First off, while there are a couple of mentions on the wiki and mailing lists, is there still much interest in doing this? If there is, I think the second question is which kind of system do we want to use? While http://wiki.winehq.org/WinehqDesign mentions Drupal, which has a lot of plugins and features for easy editing, I've read that a CMS can become a hassle if your website needs to do more complex things than serving regular chunks of content. WineHQ provides a bug-tracker, a forum, a wiki, mailing lists, source-code browsers, and other tools besides static content, with lots of interconnections between them. If we did go with a web framework, we could still probably run a CMS on top of it for the AppDB and static pages. Finally, for the frameworks, it seems that one of the main differences is simply which language we want to deal with. Is there a strong preference for using a specific language? Right now the various parts outside of Wine proper use a mix of Perl, PHP, and Python. This also raises the question of whether there's any desire to (over the very long term) try consolidating all the code outside Wine around one or two languages. I'm guessing it wouldn't be worth the trouble (different tools for different jobs), but if there is a strong reason to, it would probably be good to pick a framework in the language we want to emphasize. - Kyle

2 2

re: Question from new developer
by Dan Kegel 23 Sep '12

23 Sep '12

Chris wrote: > 1. I discovered later that I don't think this is the root of my > original bug - and in fact doesn't seem to affect behavior of my > program. Is it still worth submitting? Generally, fixes are more likely to get committed when they don't break anything (did you run all the conformance tests?), their tests cases pass on all versions of windows (did you send your patch to testbot?), improve the behavior of a real program (I don't think you have demonstrated this yet), and are written from a position of relatively deep understanding. So you might want to find a more solid fix for your first submission. Welcome, and good luck! - Dan

1 0

Re: comctl32/listview: update dwStyle before checking for scrollbar
by Nikolay Sivov 23 Sep '12

23 Sep '12

On 9/21/2012 23:07, Daniel Jelinski wrote: > dwStyle is updated only in WM_STYLECHANGED, which is not sent > when displaying and hiding scrollbars. > Fixes the issue where there was a large margin between items > and horizontal scrollbar (e.g. in file open dialog). Are you sure it's really not supposed to be sent when WS_HSCROLL/WS_VSCROLL bits are changed? A quick test with ControlSpy shows style changing messages when I set/reset these. So it's possible there's a bug outside of comctl32.

2 4

Question from new developer
by Chris Teague 23 Sep '12

23 Sep '12

I submitted bug 31753 for an application that I use, and started making an attempt to fix it. I started with the last few messages from the log: fixme:win:LockWindowUpdate (0x501c4), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! wine: Unhandled page fault on read access to 0x00000023 at address 0x78680087 (thread 0009), starting debugger... Looking at LockWindowUpdate(), I discovered that it had no conformance tests. I wrote a few covering all the possible scenarios I could think of (only 4 of them), and ran them on wine as well as cross compiling them and running on XP. To my surprise, one of the tests fails on wine, but passes on WinXP! This was great news, so I dug a little further. Specifically the problem was attempting to do a "unlock" operation by passing NULL, when the the function was already unlocked. Windows treats this as an error and returns 0, while wine returns 1. So I fixed it, patch is attached (also at: https://dl.dropbox.com/u/477050/0001-Fixed-LockWindowUpdate.txt) I have two big questions: 1. I discovered later that I don't think this is the root of my original bug - and in fact doesn't seem to affect behavior of my program. Is it still worth submitting? I do believe it alleviates the need for the "fixme" in the LockWindowUpdate function. 2. If it is worth submitting, could someone take a look at it and point out all the dumb things I've done? I'm happy with the logic of the code, but I'm sure I've done something horribly wrong in terms of doing it the preferred way. Thanks, Chris Teague

2 1

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats. Take 2.
by Vincent Povirk 21 Sep '12

21 Sep '12

This looks good to me.

1 0

Re: scrrun: Correct Invoke parameter
by Jacek Caban 21 Sep '12

21 Sep '12

Hi Alistair, On 09/21/12 14:12, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Correct Invoke parameter > --- a/dlls/scrrun/dictionary.c +++ b/dlls/scrrun/dictionary.c @@ -153,7 +153,7 @@ static HRESULT WINAPI dictionary_Invoke(IDictionary *iface, DISPID dispIdMember, hr = get_typeinfo(IDictionary_tid, &typeinfo); if(SUCCEEDED(hr)) { - hr = ITypeInfo_Invoke(typeinfo, &iface, dispIdMember, wFlags, + hr = ITypeInfo_Invoke(typeinfo, This, dispIdMember, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); This really should be an interface, not an object. &This->IDistionary_iface or simply iface would be the right thing to do. Jacek

1 0

Re: [3/3] gdiplus: Add an ability to cache bitmap properties and use distinct metadata loaders for different image formats.
by Vincent Povirk 20 Sep '12

20 Sep '12

> @@ -2123,6 +2125,8 @@ static void move_bitmap(GpBitmap *dst, GpBitmap *src, BOOL clobber_palette) > if (dst->metadata_reader) > IWICMetadataReader_Release(dst->metadata_reader); > dst->metadata_reader = src->metadata_reader; > + dst->prop_count = src->prop_count; > + dst->prop_item = src->prop_item; > if (dst->image.stream) > IStream_Release(dst->image.stream); > dst->image.stream = src->image.stream; I think you should be freeing dst->prop_item here. > @@ -2850,6 +2923,12 @@ GpStatus WINGDIPAPI GdipGetAllPropertyItems(GpImage *image, UINT size, > > if (prop_count != count || prop_size != size) return InvalidParameter; > > + if (((GpBitmap *)image)->prop_item) > + { > + memcpy(buf, ((GpBitmap *)image)->prop_item, prop_size); > + return Ok; > + } > + > reader = ((GpBitmap *)image)->metadata_reader; > if (!reader) return PropertyNotFound; I think you have to change the values here so they point into the user buffer. > +typedef GpStatus (*metadata_reader_func)(GpBitmap *bitmap, IWICBitmapDecoder *decoder, UINT frame); ... > + if (metadata_reader) > + metadata_reader(bitmap, decoder, active_frame); > + else if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void Either your metadata reader function should return void, or you should check the returned status. Otherwise, this looks good to me.

1 0

Re: jscript: Added support for RegExp.$* properties
by Marvin 20 Sep '12

20 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21683 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin 20 Sep '12

20 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [8/8] winemenubuilder: Implement OS X application bundles. (try 2)
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21663 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [7/8] winemenubuilder: Use a dispatch table to access XDG specific parts, extracted to different file.
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21662 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs. (try2)
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21655 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === Timeout === W2KPROSP4 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Documents and Settings/winetest/Local Settings/Temp/wt1.tmp/test file.shlexec", null, null) failed: rc=5 err=2 === WVISTAADM (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt9C72.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W2K8SE (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt370A.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PRO (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtE079.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtFCD5.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (32 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt2712.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === W7PROX64 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wtF41B.tmp/test file.shlexec", null, null) failed: rc=2 err=2 === TEST64_W7SP1 (64 bit shlexec) === shlexec.c:1380: Test failed: ShellExecute(null, "file:/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/nonexistent.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://///C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://localhost:80/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://127.0.0.1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://::1/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://notahost/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2 shlexec.c:1380: Test failed: ShellExecute(null, "file://www.winehq.org/C|/Users/winetest/AppData/Local/Temp/wt205C.tmp/test file.shlexec", null, null) failed: rc=2 err=2

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [3/8] winemenubuilder/tests: Added tests for XDG files
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21661 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Juan Lang 19 Sep '12

19 Sep '12

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif + test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_exes(); @@ -2308,6 +2422,7 @@ START_TEST(shlexec) test_commandline(); test_directory(); test_trojans(); +#endif --Juan

1 0

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.
by Marvin 19 Sep '12

19 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21649 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] scrrun: Moved creating filesystem object to its own function
by Alexandre Julliard 19 Sep '12

19 Sep '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -194,13 +245,33 @@ HRESULT WINAPI DllUnregisterServer(void) > > HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID* ppv) > { > + scrruncf *This; > + HRESULT hr = CLASS_E_CLASSNOTAVAILABLE; > + > + TRACE("(%s, %s, %p): stub\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); > + > + if(!ppv) > + return E_INVALIDARG; > + > + This = HeapAlloc(GetProcessHeap(), 0, sizeof(scrruncf)); > + > + This->IClassFactory_iface.lpVtbl = &scrruncf_vtbl; > + This->pfnCreateInstance = NULL; > + This->ref = 1; > + > if(IsEqualGUID(&CLSID_FileSystemObject, rclsid)) { > - TRACE("(CLSID_WshShell %s %p)\n", debugstr_guid(riid), ppv); > - return IClassFactory_QueryInterface(&FileSystemFactory, riid, ppv); > + TRACE("(CLSID_FileSystemObject %s %p)\n", debugstr_guid(riid), ppv); > + This->pfnCreateInstance = &create_filesystem; > + This->clsid = IID_IFileSystem3; > + } You could just as well continue using static instances of the class factory, and using the IID as a clsid doesn't make much sense. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3).
by Alexandre Julliard 19 Sep '12

19 Sep '12

Sergey Guralnik <serhio(a)etersoft.ru> writes: > +todo_wine > + ok( hsmicon != NULL, "GetClassLong should return non-zero handle\n"); > + for(i = 0; i < 100; i++) > + if(hsmicon != (HICON)GetClassLongPtrW(hwnd, GCLP_HICONSM)) > + { > + ok(FALSE, "Always should return the same icon handle\n"); > + break; > + } This doesn't make sense, it's not going to return the same thing 99 times and then suddenly something different. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Add CoGetDefaultContext stub
by Michael Stefaniuc 19 Sep '12

19 Sep '12

Hallo Alistair, > --- > dlls/ole32/compobj.c | 9 +++++++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,6 +4279,15 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > return S_OK; > } > > +/*********************************************************************** > + * CoGetContextToken [OLE32.@] copy and paste error ^^^ > + */ > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

2 1

user32/tests: Add tests for class small icons (try 3).
by Sergey Guralnik 19 Sep '12

19 Sep '12

There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3). From 49d6118117ccfb4efecbb9839b279cc286b19392 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Tue, 11 Sep 2012 13:40:54 +0400 Subject: [PATCH 2/2] user32: Add internal class small icons functionality (try 3). Is something wrong with them? -- Sergey

1 0

user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 19 Sep '12

19 Sep '12

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

1 0

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386
by Jacek Caban 18 Sep '12

18 Sep '12

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

2 2

Re: [PATCH 3/6] vbscript: Added support for do..loop statement without an expression
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21628 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] vbscript: Added Len implementation
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21627 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] vbscript: Fixed parsing if statements with empty body
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21626 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] jscript: Added support for host objects being part of scope chain
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21625 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).
by Michael Stefaniuc 18 Sep '12

18 Sep '12

Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis <cdavis(a)mymail.mines.edu> > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of a > pointer, and not 8*sizeof(UINT) as was intended here. Since the array was please fix it in a way to not confuse a novice C programmer; e.g. passing it a pointer to a MYSTRUCT. That way you can avoid the magic constant 8 too. > explicitly declared as being 8 elements long, just use the number 8 in > the for loop instead. > --- > dlls/oleaut32/tests/tmarshal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index be8ef94..ad56123 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -596,10 +596,10 @@ static HRESULT WINAPI Widget_VarArg( > } > > > -static BOOL mystruct_uint_ordered(UINT uarr[8]) > +static BOOL mystruct_uint_ordered(UINT uarr[]) > { > int i; > - for (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > + for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.
by Dmitry Timoshkov 17 Sep '12

17 Sep '12

Hi, Can I please get a feedback on this gdiplus series along with another one "gdiplus: Add some tests for GIF properties." ? -- Dmitry.

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 17 Sep '12

17 Sep '12

Alexandre Julliard wrote: > Sergey Guralnik <serhio at etersoft.ru> writes: > >> I've sent next patch more than month ago, and have no comments about >> it. >> >> From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 >> 2001 >> From: Sergey Guralnik <serhio at etersoft.ru> >> Date: Thu, 9 Aug 2012 17:12:56 +0400 >> Subject: user32/tests: Add test for SetFocus() (with few todo)(Try >> 2). >> >> Is anything wrong with this one? > > That's mostly testing the window manager focus policy, I don't think > that makes sense. What are you trying to demonstrate with this? I try to show that some applications rely on finishing all side focus switching, which are result of call to some window management function, before this function returns. For example my app hopes that result of call to SetFocus() will not be distorted in message loop due call to DestroyWindow(), that made before call to SetFocus(). Is my explanation clear enough? -- Sergey

2 1

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller 17 Sep '12

17 Sep '12

On 17.09.2012 00:33, Nozomi Kodama wrote: > + { { rout, gout, bout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, ... > + { rout, bout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, > + { bout, rout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, I think it doesn't make much sense to test this, they are doing basically all three the same. The name of the variable doesn't matter. Besides we test for (rout, rout, rout), these might be good to test: (rout, gout, gout), (rout, rout, bout), (rout, gout, rout). Maybe the naming of the variables is a bit confusing... I used the starting name for the name, hence you could also use the expected value name or rename the variables to out1, out2, out3 to not make confusion with the expected / started color. Though I'm fine with all cases... > + } > + > + startindex += order * order; > + } I would indent the startindex... Some style comments (I have no strong opinion about that, just like to mention it): The brackets "()" in &(table[90]) could be left out. You may also break the longer lines into two. Though, I don't know the actual recommended line length, but 200 seems a bit long... I only found this http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . Cheers Rico

2 1

Wine Mono update
by Alistair Leslie-Hughes 16 Sep '12

16 Sep '12

Hi, Mono 2.11.4 has been released which contains a few patches which removes most of the exceptions from the AxHost class. This class has been the cause of a few applications from starting (DDO and LOTRO launchers to name a few) I purpose a new wine-mono to be built. What sort of milestones should we look for to trigger a new wine-mono release? Best Regards Alistair Leslie-Hughes

1 0

very slow updating of client area
by Andrew Makhorin 16 Sep '12

16 Sep '12

Hello, Please see below a function that processes WM_PAINT message. Being run under Wine this function updates the client area (50x120 chars) about 50 times slower than under Windows XP. Could anyone please explain me what might be wrong and suggest how to fix that? Thank you, Andrew Makhorin /*********************************************************************** * update_panel_area - update client area of panel window * * This routine updates the client area of the window associated with * the specified panel. (It is called when the panel window procedure * receives the message WM_PAINT.) */ void update_panel_area(PANELX *px) { PAINTSTRUCT ps; HFONT old_hfont; HPEN old_hpen, hpen; int row, col, row1, row2, col1, col2; xassert(px != NULL); /* if the update region is empty, do nothing */ if (!GetUpdateRect(px->window, NULL, FALSE)) goto done; /* start updating */ BeginPaint(px->window, &ps); old_hfont = SelectObject(ps.hdc, px->hfont); hpen = CreatePen(PS_SOLID, 0, 0x000000); old_hpen = SelectObject(ps.hdc, hpen); /* given the update region, determine which rows and columns of the display area should be updated (note that the update region reported by BeginPaint does not include right-most and bottom-most pixels, so we subtract 1 in order not to update an extra row and column out of the update region) */ row1 = 1 + ps.rcPaint.top / px->fy; row2 = 1 + (ps.rcPaint.bottom - 1) / px->fy; col1 = 1 + ps.rcPaint.left / px->fx; col2 = 1 + (ps.rcPaint.right - 1) / px->fx; /* updating is performed according to information in the buffer array of the panel display area (see rpsed.h) */ for (row = row1; row <= row2; row++) { for (col = col1; col <= col2; col++) { FMTCHAR c; int x, y; char buf[1]; /* get formatted character at position (row,col) */ if (1 <= row && row <= px->p->nrows+1 && 1 <= col && col <= px->p->ncols+1) c = px->p->c[row][col]; else c = px->p->std_char[FMT_SPACE]; /* paint this character */ x = (col - 1) * px->fx; y = (row - 1) * px->fy; SetTextColor(ps.hdc, palette->value[c.f]); SetBkColor(ps.hdc, palette->value[c.b]); SetBkMode(ps.hdc, OPAQUE); buf[0] = c.c; TextOut(ps.hdc, x, y, buf, 1); /* paint the underline, if specified */ if (c.a & FMT_UNDERLINE) { SetBkMode(ps.hdc, TRANSPARENT); TextOut(ps.hdc, x, y, "_", 1); } /* paint the vertical bar, if specified */ if (c.a & FMT_MARGIN) { MoveToEx(ps.hdc, x, y, NULL); LineTo(ps.hdc, x, y + px->fy); } } } /* finish updating */ SelectObject(ps.hdc, old_hfont); SelectObject(ps.hdc, old_hpen); DeleteObject(hpen); EndPaint(px->window, &ps); done: return; }

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel