- wine-devel - winehq.org

user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 19 Sep '12

19 Sep '12

Alexandre Julliard writes: > Not really. If you want to test purely the Wine behavior, then you > shouldn't be waiting for window manager events. If the window manager > is > involved then you can't guarantee that a given window will always get > focus. > If your app breaks because the window manager doesn't give it focus > at a > certain point, then pretty much the only solution is to change the wm > policy, or use a different wm. Thanks for explanations. -- Sergey

1 0

Re: [PATCH 3/3] jscript: Added support for no new line between return and expression rule
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21637 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386
by Jacek Caban 18 Sep '12

18 Sep '12

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c | 4 +- > dlls/jscript/jsval.h | 143 > +++++++++++++++++++++++++++++++++++++---------- > 2 files changed, 114 insertions(+), 33 deletions(-) >

2 2

Re: [PATCH 3/6] vbscript: Added support for do..loop statement without an expression
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21628 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] vbscript: Added Len implementation
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21627 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] vbscript: Fixed parsing if statements with empty body
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21626 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] jscript: Added support for host objects being part of scope chain
by Marvin 18 Sep '12

18 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21625 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).
by Michael Stefaniuc 18 Sep '12

18 Sep '12

Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis <cdavis(a)mymail.mines.edu> > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of a > pointer, and not 8*sizeof(UINT) as was intended here. Since the array was please fix it in a way to not confuse a novice C programmer; e.g. passing it a pointer to a MYSTRUCT. That way you can avoid the magic constant 8 too. > explicitly declared as being 8 elements long, just use the number 8 in > the for loop instead. > --- > dlls/oleaut32/tests/tmarshal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index be8ef94..ad56123 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -596,10 +596,10 @@ static HRESULT WINAPI Widget_VarArg( > } > > > -static BOOL mystruct_uint_ordered(UINT uarr[8]) > +static BOOL mystruct_uint_ordered(UINT uarr[]) > { > int i; > - for (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > + for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 3.
by Dmitry Timoshkov 17 Sep '12

17 Sep '12

Hi, Can I please get a feedback on this gdiplus series along with another one "gdiplus: Add some tests for GIF properties." ? -- Dmitry.

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 17 Sep '12

17 Sep '12

Alexandre Julliard wrote: > Sergey Guralnik <serhio at etersoft.ru> writes: > >> I've sent next patch more than month ago, and have no comments about >> it. >> >> From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 >> 2001 >> From: Sergey Guralnik <serhio at etersoft.ru> >> Date: Thu, 9 Aug 2012 17:12:56 +0400 >> Subject: user32/tests: Add test for SetFocus() (with few todo)(Try >> 2). >> >> Is anything wrong with this one? > > That's mostly testing the window manager focus policy, I don't think > that makes sense. What are you trying to demonstrate with this? I try to show that some applications rely on finishing all side focus switching, which are result of call to some window management function, before this function returns. For example my app hopes that result of call to SetFocus() will not be distorted in message loop due call to DestroyWindow(), that made before call to SetFocus(). Is my explanation clear enough? -- Sergey

2 1

Re: d3dx9 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller 17 Sep '12

17 Sep '12

On 17.09.2012 00:33, Nozomi Kodama wrote: > + { { rout, gout, bout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, ... > + { rout, bout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, > + { bout, rout, gout, table, &(table[90]), &(table[180]), 1.01f, 1.02f, 1.03f, }, I think it doesn't make much sense to test this, they are doing basically all three the same. The name of the variable doesn't matter. Besides we test for (rout, rout, rout), these might be good to test: (rout, gout, gout), (rout, rout, bout), (rout, gout, rout). Maybe the naming of the variables is a bit confusing... I used the starting name for the name, hence you could also use the expected value name or rename the variables to out1, out2, out3 to not make confusion with the expected / started color. Though I'm fine with all cases... > + } > + > + startindex += order * order; > + } I would indent the startindex... Some style comments (I have no strong opinion about that, just like to mention it): The brackets "()" in &(table[90]) could be left out. You may also break the longer lines into two. Though, I don't know the actual recommended line length, but 200 seems a bit long... I only found this http://www.winehq.org/pipermail/wine-devel/2010-September/086996.html . Cheers Rico

2 1

Wine Mono update
by Alistair Leslie-Hughes 16 Sep '12

16 Sep '12

Hi, Mono 2.11.4 has been released which contains a few patches which removes most of the exceptions from the AxHost class. This class has been the cause of a few applications from starting (DDO and LOTRO launchers to name a few) I purpose a new wine-mono to be built. What sort of milestones should we look for to trigger a new wine-mono release? Best Regards Alistair Leslie-Hughes

1 0

very slow updating of client area
by Andrew Makhorin 16 Sep '12

16 Sep '12

Hello, Please see below a function that processes WM_PAINT message. Being run under Wine this function updates the client area (50x120 chars) about 50 times slower than under Windows XP. Could anyone please explain me what might be wrong and suggest how to fix that? Thank you, Andrew Makhorin /*********************************************************************** * update_panel_area - update client area of panel window * * This routine updates the client area of the window associated with * the specified panel. (It is called when the panel window procedure * receives the message WM_PAINT.) */ void update_panel_area(PANELX *px) { PAINTSTRUCT ps; HFONT old_hfont; HPEN old_hpen, hpen; int row, col, row1, row2, col1, col2; xassert(px != NULL); /* if the update region is empty, do nothing */ if (!GetUpdateRect(px->window, NULL, FALSE)) goto done; /* start updating */ BeginPaint(px->window, &ps); old_hfont = SelectObject(ps.hdc, px->hfont); hpen = CreatePen(PS_SOLID, 0, 0x000000); old_hpen = SelectObject(ps.hdc, hpen); /* given the update region, determine which rows and columns of the display area should be updated (note that the update region reported by BeginPaint does not include right-most and bottom-most pixels, so we subtract 1 in order not to update an extra row and column out of the update region) */ row1 = 1 + ps.rcPaint.top / px->fy; row2 = 1 + (ps.rcPaint.bottom - 1) / px->fy; col1 = 1 + ps.rcPaint.left / px->fx; col2 = 1 + (ps.rcPaint.right - 1) / px->fx; /* updating is performed according to information in the buffer array of the panel display area (see rpsed.h) */ for (row = row1; row <= row2; row++) { for (col = col1; col <= col2; col++) { FMTCHAR c; int x, y; char buf[1]; /* get formatted character at position (row,col) */ if (1 <= row && row <= px->p->nrows+1 && 1 <= col && col <= px->p->ncols+1) c = px->p->c[row][col]; else c = px->p->std_char[FMT_SPACE]; /* paint this character */ x = (col - 1) * px->fx; y = (row - 1) * px->fy; SetTextColor(ps.hdc, palette->value[c.f]); SetBkColor(ps.hdc, palette->value[c.b]); SetBkMode(ps.hdc, OPAQUE); buf[0] = c.c; TextOut(ps.hdc, x, y, buf, 1); /* paint the underline, if specified */ if (c.a & FMT_UNDERLINE) { SetBkMode(ps.hdc, TRANSPARENT); TextOut(ps.hdc, x, y, "_", 1); } /* paint the vertical bar, if specified */ if (c.a & FMT_MARGIN) { MoveToEx(ps.hdc, x, y, NULL); LineTo(ps.hdc, x, y + px->fy); } } } /* finish updating */ SelectObject(ps.hdc, old_hfont); SelectObject(ps.hdc, old_hpen); DeleteObject(hpen); EndPaint(px->window, &ps); done: return; }

1 0

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight
by Rico Schüller 14 Sep '12

14 Sep '12

On 14.09.2012 11:07, Nozomi Kodama wrote: > Hello > > one remark about this patch. > > Test in real windows shows that D3DXSHEvalDirectionalLight accepts order > > D3DXSH_MAXORDER or order < D3DXSH_MINORDER. > But in these cases, the colour outputs are unpredictable. For the same > calling arguments, D3DSXHEvalDirectionalLight returns different colours. > > That explains the simplicity of the implementation of this function. > > Nozomi. > + FLOAT s, temp[max( 1, order * order )]; Is this allowed in c and does it really work the way one would expect? + for (order = D3DXSH_MINORDER; order <= D3DXSH_MAXORDER; order++) ... + if ( ( order == 0 ) || ( j >= order * order ) ) Why would you check for order == 0? That's imho never the case that this is true. At least if you only test from D3DXSH_MINORDER onward. + unsigned int j, order, start[] = {0, 4, 13, 29, 54}; Using the start[] looks a bit ugly ... why don't you calculate the index? + expected = table[start[order - 2] + j]; ! You've again trailing white spaces. What happens in the following test case? Which result is returned? D3DXSHEvalDirectionalLight(order, &dir, 1.7f, 2.6f, 3.5f, rout, rout, rout); Well the implementation seems to be correct, but it may be nice to test for this as well. Maybe in another patch. Cheers Rico

2 1

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).
by Sergey Guralnik 14 Sep '12

14 Sep '12

I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik <serhio(a)etersoft.ru> Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything wrong with this one? -- Sergey

2 1

Re: [PATCH] advapi32: Eliminate dead stores (Clang).
by Alexandre Julliard 14 Sep '12

14 Sep '12

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b > attr_list.count = 0; > attr_list.attr = NULL; > } > - status = SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > - preserve_blob ? 0 : strlen(password), > - preserve_blob ? NULL : password); > + SecKeychainItemModifyAttributesAndData(keychain_item, &attr_list, > + preserve_blob ? 0 : strlen(password), > + preserve_blob ? NULL : password); I expect you'd want to handle that error instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] windowscodecs: Implement Graphic Control Extension metadata reader.
by Marvin 14 Sep '12

14 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21585 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.
by Marvin 14 Sep '12

14 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21584 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: vcomp: better stub for _vcomp_fork
by Alexandre Julliard 13 Sep '12

13 Sep '12

Dan Kegel <dank(a)kegel.com> writes: > @@ -41,6 +42,80 @@ double CDECL omp_get_wtime(void) > return GetTickCount() / 1000.0; > } > > +/* Call helper with the ncount args after ncount */ > +extern void WINAPIV _vcomp_fork(DWORD parallel, int ncount, void *helper, ...); > +#ifdef __i386__ > +__ASM_GLOBAL_FUNC( _vcomp_fork, > + "push %ebp\n\t" > + "movl %esp,%ebp\n\t" > + > + /* Push varargs */ > + "movl 12(%ebp),%ecx\n\t" /* if (nargs > 0) */ > + "test %ecx,%ecx\n\t" > + "jz copyend\n\t" > + "leal 20(%ebp),%edx\n\t" /* dx -> first vararg */ > + "leal (%edx,%ecx,4),%edx\n\t" /* dx += nargs * sizeof arg */ > + "copyloop:\n\t" /* while (nargs-- > 0) */ > + "sub $4,%edx\n\t" > + "pushl (%edx)\n\t" /* push next vararg */ > + "dec %ecx\n\t" > + "jnz copyloop\n\t" > + "copyend:\n\t" > + > + /* Call helper and return */ > + "call *16(%ebp)\n\t" > + "movl %ebp,%esp\n\t" > + "pop %ebp\n\t" > + "ret\n\t" > + ) > +#endif There are several places that already implement that sort of thing the right way, you should copy one of them instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36 [patch 1/2: try 2]: Implement D3DXSHEvalDirectionalLight
by Alexandre Julliard 13 Sep '12

13 Sep '12

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > @@ -2231,6 +2231,40 @@ FLOAT* WINAPI D3DXSHEvalDirection(FLOAT *out, UINT order, CONST D3DXVECTOR3 *dir > return out; > } > > +HRESULT WINAPI D3DXSHEvalDirectionalLight(UINT order, CONST D3DXVECTOR3 *dir, FLOAT Rintensity, FLOAT Gintensity, FLOAT Bintensity, FLOAT *Rout, FLOAT *Gout, FLOAT *Bout) > +{ > + FLOAT s, temp[36]; > + UINT j; > + > + TRACE("Order %u, Vector %p, Red %f, Green %f, Blue %f, Rout %p, Gout %p, Bout %p\n", order, dir, Rintensity, Gintensity, Bintensity, Rout, Gout, Bout); > + > + if ( order > D3DXSH_MAXORDER ) > + { > + FIXME("This case is not implemented yet. Anyway, following to MSDN, this case should not happen\n"); > + > + return D3D_OK; > + } You should test the expected results for that case too, the implementation should be easy either way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation
by Alexandre Julliard 13 Sep '12

13 Sep '12

James Eder <jimportal(a)gmail.com> writes: > @@ -2261,7 +2242,19 @@ NTSTATUS WINAPI NtInitiatePowerAction( > SystemAction,MinSystemState,Flags,Asynchronous); > return STATUS_NOT_IMPLEMENTED; > } > - > + > +#ifdef linux > +static int have_cpufreq(void) > +{ > + FILE* f = fopen("/sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq", "r"); > + if(f) > + { > + fclose(f); > + return 1; > + } > + return 0; > +} > +#endif You don't want to open a file just to see if you will be able to open it for real later on. You'll need to check the subsequent open anyway, so you can do the fallback at that point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] jscript: Don't leave current scope in return statement before evaluating the expression
by Marvin 13 Sep '12

13 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21565 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/6] mshtml: Added IHTMLDocument4::fireEvent implementation
by Marvin 13 Sep '12

13 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21559 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Translations of the About Pages
by Kyle Auble 13 Sep '12

13 Sep '12

I just submitted a draft rewrite of WineHQ's About page in English that integrates some things from the wiki page, but there are still Hebrew and Spanish about pages on the wiki. I started working on translating the Spanish one, but realized someone else should probably do it after one paragraph, and my Hebrew is even weaker. I think the goal is still to move all central pages to WineHQ so I'd like to remove those versions from the wiki soon too. If any Hebrew or Spanish-speaking contributors would prefer to work from the wiki content though, I can leave it up for a while. If you would rather translate from the new English version to keep the different translations in sync though, I'll go ahead and clean up the wiki some more. - Kyle

1 0

Re: [2/2] windowscodecs: Create Graphic Control Extension metadata block for a GIF frame.
by Marvin 13 Sep '12

13 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21552 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] windowscodecs: Create Image Descriptor metadata block for a GIF frame.
by Vincent Povirk 13 Sep '12

13 Sep '12

> + stream = create_stream(&IMD_data, sizeof(IMD_data)); Er, where is create_stream defined? I don't see it in git or a previous patch.

2 1

dssenh: implementing the dssenh cryptographic service provider
by Marek Chmiel 12 Sep '12

12 Sep '12

Hello all, over the summer I had a chance to complete the regression test suite for the DSSENH cryptographic provider; thank you to those that helped along the way. I am currently researching how to implement the actual provider, and any suggestions would be greatly appreciated. A question I have is: RSAENH AND DSSENH both use the same encryption algorithms (I am not 100% sure about that yet), so for example could I use one that was written for RSAENH or shall I write those functions on my own using Libtomcrypt? Thank you. --Marek

2 1

Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome
by Michael Stefaniuc 12 Sep '12

12 Sep '12

After talking to Henri on irc, please ignore this patch. There are patches out there to enumerate more devices than the primary one and then the flags do play a role. On 09/12/2012 11:08 PM, Michael Stefaniuc wrote: > --- > dlls/ddraw/main.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c > index 61e8ec9..b79b12e 100644 > --- a/dlls/ddraw/main.c > +++ b/dlls/ddraw/main.c > @@ -377,12 +377,9 @@ HRESULT WINAPI DirectDrawEnumerateExA(LPDDENUMCALLBACKEXA Callback, void *Contex > DDENUM_NONDISPLAYDEVICES)) > return DDERR_INVALIDPARAMS; > > - if (Flags) > - FIXME("flags 0x%08x not handled\n", Flags); > - > TRACE("Enumerating default DirectDraw HAL interface\n"); > > - /* We only have one driver by now */ > + /* We have only one driver (primary) which is always enumerated regardless of the flags */ > __TRY > { > static CHAR driver_desc[] = "DirectDraw HAL", > bye michael

1 0

Re: [PATCH 4/4] ntdll: Add more complete implementation of NtPowerInformation
by Ken Thomases 12 Sep '12

12 Sep '12

On Sep 12, 2012, at 2:17 PM, James Eder wrote: > - valSize = sizeof(longVal); > - if (!sysctlbyname("hw.cpufrequency", &longVal, &valSize, NULL, 0)) > - cpuHz = longVal; I haven't tried building, but this would still leave the warning about longVal being declared but never used, right? I don't see you removing that declaration. Regards, Ken

1 0

Re: [2/2] windowscodecs: Add a bunch of GIF metadata tests.
by Marvin 12 Sep '12

12 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msls31: Add stub dll.
by Austin English 11 Sep '12

11 Sep '12

On Tue, Sep 11, 2012 at 9:32 AM, Josh DuBois <duboisj(a)codeweavers.com> wrote: > Presence of a stub of msls31.dll allows Visio 2003 to open .svg files, which > it fails to do without the stub. > Visio 2003 does complain that some values in the files are missing or of the > incorrect data type when opening these files, but it will nonetheless open > them and can edit them successfully when the stubbed .dll is present. @@ -0,0 +1,79 @@ +70 stub LssbFDoneDisplay +65 stub LsCompressSubline +1 stub LsCreateContext +3 stub LsCreateLine ..etc. Does it really need them by ordinal? The spec files are typically sorted alphabetically by function name, e.g.,: +@ stub LsCompressSubline +@ stub LsCreateContext +@ stub LsCreateLine +@ stub LssbFDoneDisplay ..etc. Some other minor things: A) you don't need to include the changes to configure, just configure.ac. B) Your comments are formatted a bit strange /* --------------------------------------------------------------- ** msls31.dll ** Copyright CodeWeavers, Inc. ** Created: 9/10/2012 by Josh DuBois for CodeWeavers. most files have: /* * msls31.dll * * Copyright 2012 Josh DuBois for CodeWeavers, Inc. * */ similar for your comment about preferring the native version. Welcome to Wine! -- -Austin

2 1

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation
by James Eder 11 Sep '12

11 Sep '12

I've sent a patch set that I need some help testing. The first four in the series should be fine as they don't change anything specific to a particular platform. The last one however makes some changes which are platform specific (affects Linux, Apple, and various BSDs). I've tested the Linux code but I do not have an Apple, for example, to test that code. While the code looks good to me and is is largely based off of code removed from fill_cpu_info(), it is still worth some concern that it hasn't seen any real testing. If you have a Mac or BSD, I would be grateful if you could try the patches out to make sure things are working as expected. You'll find a few more details in the commit message http://source.winehq.org/patches/data/89698 . Also of concern is that the testbot seems to have only one processor. This results in most of the tests added in http://source.winehq.org/patches/data/89697 being skipped. So testbot doesn't seem that helpful for this test. As for the implementation of the test itself, would it be better to use broken() and just test Wine for the Win7 behavior? From my testing, the test as is works for XP, Win7, and Wine with my patch set. If we can write the test to work everywhere, don't use broken()? There are more details in the patch itself so please have a look and let me know what you think. -- Jim

2 2

Re: wininet: disable TLSv1.1/1.2 by default
by Hiroshi Miura 11 Sep '12

11 Sep '12

Hi, Are there any comment for it? It is a motivation that Evernote windows client cannot connect its server on Wine/OpenSSL 1.0.1. it is caused by server is only support TLS1.0/SSL3.0 , apache2/openssl 0.9.8 thing, but client ask TLS1.1/1.2 and then server returns that session is fails. I know wininet(in Microsoft implementation) has a behavior to re-try by TLS1.0 after TLS1.2 fails. It is discussed in IETF TLS maillist http://www.ietf.org/mail-archive/web/tls/current/msg08218.html How do you think whether we should implement similar way or not? If we adopt similar fall back mechanism, compatibility may become well, but is it good behavior? Hiroshi On 2012.08.26 11:51, Hiroshi Miura wrote: > > OpenSSL 1.0.x now support TLSv1.1 and TLSv1.2 > but Windows7 is disabled by default. > > Schannel registry indicate TLSv1.1/1.2 config. > > It fixes the error of Evernote client connection. > http://bugs.winehq.org/show_bug.cgi?id=30598 > > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/wininet/netconnection.c | 68 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > > > > >

2 1

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default
by Marcus Meissner 10 Sep '12

10 Sep '12

On Mon, Sep 10, 2012 at 12:14:51AM +0900, Hiroshi Miura wrote: > -Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > > See registry entry for schannel and control > enable/disable tls versions. > > It also see grbitEnabledProtocols defined in > credentials that take precedence over registry. I think the regression issue with TLS 1.1/1.2 is the "empty fragments" sending, right? Perhaps we can just disable that and not all of TLS 1.1/1.2? Ciao, Marcus

2 1

Re: [PATCH 3/5] gdi32: Fixed localized font style name.
by Qian Hong 10 Sep '12

10 Sep '12

Hello, On Tue, Sep 11, 2012 at 1:05 AM, Qian Hong <fracting(a)gmail.com> wrote: > and the symbol font bug (with todo_wine because it need to be fixed in [PATCH 4/5].) Sorry for a typo, should be: with todo_wine because it need to be fixed in [PATCH 5/5]. Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [PATCH 2/3] jscript: Added support for no new line between continue and identifier rule
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21489 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] jscript: Added support for no new line between break and identifier rule
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21488 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Added support for navigating to anchors with IDs containing '#'
by Alexandre Julliard 10 Sep '12

10 Sep '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/navigate.c | 42 +++++++++++++++++++++++++++++++++++++++--- > dlls/mshtml/nsiface.idl | 11 +++++++++++ > 2 files changed, 50 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:4650: Test failed: unexpected riid {5C8B21BC-EF6E-4599-A26F-FACC05B4ADBE} make: *** [htmldoc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] vbscript: Added support for VT_NULL in stack_pop_bool
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21486 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] vbscript: Added support for comparing to null
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21485 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21484 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] mshtml: Use first script host's GUID as default script guid
by Marvin 10 Sep '12

10 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21483 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid
by Alexandre Julliard 10 Sep '12

10 Sep '12

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/mshtml/htmlwindow.c | 1 - > dlls/mshtml/mshtml_private.h | 1 - > dlls/mshtml/script.c | 18 ++++++++++-------- > dlls/mshtml/tests/vbtest.html | 15 +++++++++++++-- > 4 files changed, 23 insertions(+), 12 deletions(-) It doesn't work here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so ../../../../wine/dlls/mshtml/tests/script.c && touch script.ok script.c:620: Test failed: L"got an exception" script.c:620: Test failed: L"counter = 3" make: *** [script.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] secur32/schannel: diabled TLS1.1/1.2 by Default
by Henri Verbeet 09 Sep '12

09 Sep '12

On 2 September 2012 10:58, Hiroshi Miura <miurahr(a)linux.com> wrote: > > -Set TLS1.1/1.2 disabled by Default that is > same as Windows 7 default. > Aside from whether disabling TLS1.1+ is appropriate or not, or if this is the right implementation, this patch also add %COMPAT to the priority string, which wasn't there before.

2 1

Wine, fullscreen applications, and RandR 1.2
by Andy Ritger 08 Sep '12

08 Sep '12

Hello wine developers, I work on NVIDIA's Linux graphics driver team, and have a few questions about how Wine should interact with X driver mode lists. Sorry if this isn't the correct forum for these questions. Starting in release 302.xx, we finally added RandR 1.2 support to NVIDIA's X driver. At the same time, we reworked some things about how modetimings are validated and configured by the NVIDIA X driver. For the following, the important part is that we eliminated implicit flat panel scaling, and instead made it explicitly configurability through NVIDIA's MetaMode syntax and through RandR 1.2. The user-visible change is that only modes reported by a digital flat panel's EDID are in the mode list for an RandR output. A little background: modern GPUs (at least NVIDIA, and I expect other vendors) have a flexible display scaling pipeline that consists of: * A "RasterSize": this is the resolution of pixels that will be sent to the monitor; this is what people normally think of as the size of the "mode". * A "ViewPortIn": this is the resolution of pixels that the display engine will fetch from the X screen. * A "ViewPortOut": this is the region _within_ the RasterSize to which the pixels of ViewPortIn should be sent. The pixels fetched in ViewPortIn can be scaled up or down by specifying different sizes for ViewPortIn and ViewPortOut. Also, letterboxing and overscan compensation can be configured by making ViewPortOut smaller than RasterSize. For example, if your monitor accepts a mode of 1920x1200, and you want a desktop resolution of 1280x720 aspect-scaled to fill 1920x1200 (i.e., 1280x720 scaled to 1920x1080, with 60 blank scanlines above and below it in a 1920x1200 mode), then in NVIDIA MetaMode syntax you could do: "1920x1200 { ViewPortIn = 1280x720, ViewPortOut = 1920x1080+0+60 }" While the MetaMode syntax is NVIDIA-specific, the same can be configured through RandR: * The RandR transformation matrix can be used to describe the scaling between ViewPortOut and ViewPortIn. * The RandR "Border" output property can be used, when available, to describe a ViewPortOut that is smaller than the RasterSize. Note: most RandR X drivers, including NVIDIA, don't yet provide this property, though I'm in the process of adding it for NVIDIA. In practice this means that most resolutions (i.e., not just a fixed modelist), from the perspective of desktop size, are achievable with RandR. Questions: * Looking at dlls/winex11.drv/xrandr.c, the first RandR CRTC/output's modelist is used to populate Wine's list of available modes. Is the data flow between Wine and Windows applications always such that you need to advertise a list of (width, height, refreshRate)s? Or would an application ever tell Wine what resolution it wants? * Would you be open to patches to make dlls/winex11.drv/xrandr.c generate a larger set of (width, height, refreshRate)s, and then have xrandr12_set_current_mode() use RandR transformation matrix and Border property to satisfy those? I was envisioning something where we take the "preferred" mode for the RandR output, and create all of the following resolutions using ViewPort{In,Out}: 1920 x 1200 1920 x 1080 1600 x 1200 1280 x 1024 1280 x 720 1024 x 768 800 x 600 640 x 480 * The current xrandr.c code picks the first CRTC/output, which may not be currently active. At the least, it should scan for an active CRTC+output. I imagine it would be even better if the user could configure which RandR output they want. Would that be reasonable? What mechanisms are available in Wine for users to provide runtime configuration? * From the current code, it does not look like Wine's RandR support tries to do anything with multiple simultaneous RandR outputs. Ironically: this actually works better with RandR 1.1 + NVIDIA: users can configure their MetaModes to describe what mode (plus viewport configuration) they want on each monitor, and then RandR 1.1 chooses the MetaMode. Would it make sense for the user to be able to specify to Wine the RandR configuration (spanning all of the RandR outputs on the X screen)? I guess that depends on what runtime configuration mechanisms are possible. I'm curious what you guys think, before I code up any patches to propose. Thanks, - Andy Ritger

2 8

Re: [PATCH 1/2] gdi32/tests: Added tests for symbol fonts.
by Marvin 08 Sep '12

08 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21461 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

2 1

Re: [PATCH 2/2] gdi32: Fixed get_name_table_entry for symbol fonts.
by Marvin 08 Sep '12

08 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21462 Your paranoid android. === W7PROX64 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (32 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === W7PROX64 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular === TEST64_W7SP1 (64 bit font) === font.c:4139: Test failed: style names don't match: returned Webdings, expect Regular font.c:4139: Test failed: style names don't match: returned Wingdings, expect Regular

1 0

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21417 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

2 2

Re: [PATCH 2/2] user32: Correct class small icons behavior (try 2).
by Sergey Guralnik 07 Sep '12

07 Sep '12

On 2012-09-07 15:24, Sergey Guralnik wrote: > This patch based on MSDN's description of WNDCLASSEX structure: ... hIconSm: Handle to a small icon that is associated with the window class. If this member is NULL, the system searches the icon resource specified by the hIcon member for an icon of the appropriate size to use as the small icon. ... -- Sergey

1 0

Re: [PATCH 9/9] vbscript: Added support for VT_NULL in stack_pop_bool
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21447 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 8/9] vbscript: Added support for comparing to null
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21446 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 7/9] mshtml: Check if value is function only when it needs to be in invoke_builtin_prop
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21445 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21444 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] user32: Correct class small icons behavior.
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21433 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/2] user32/tests: Added test for class icons handling.
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.
by Alexandre Julliard 07 Sep '12

07 Sep '12

Qian Hong <fracting(a)gmail.com> writes: > @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) > > bufW[0] = 0; > bufA[0] = 0; > - ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size), "FAMILY (family name) could not be read\n"); > + ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, GetSystemDefaultLangID()) || > + get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, buf_size, TT_MS_LANGID_ENGLISH_UNITED_STATES), You should avoid that sort of thing, it will be hard to debug, particularly since get_ttf_nametable_entry itself has ok() calls. Store the result in a variable instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] user32: Implement RegisterRawInputDevices().
by Alexandre Julliard 07 Sep '12

07 Sep '12

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > @@ -2931,3 +2965,14 @@ DECL_HANDLER(set_cursor) > reply->new_clip = input->desktop->cursor.clip; > reply->last_change = input->desktop->cursor.last_change; > } > + > +DECL_HANDLER(update_rawinput_devices) > +{ > + const struct rawinput_device *devices = get_req_data(); > + unsigned int i; > + > + for (i = 0; i < req->device_count; ++i) > + { > + update_rawinput_device(&devices[i]); > + } > +} device_count is redundant (and unsafe), this should use the data size instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin 07 Sep '12

07 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.
by Dmitry Timoshkov 07 Sep '12

07 Sep '12

I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.

1 0

Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)
by Alexandre Julliard 06 Sep '12

06 Sep '12

Piotr Caban <piotr(a)codeweavers.com> writes: > try2: > - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)
by Alexandre Julliard 06 Sep '12

06 Sep '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const DVD_READ_STRUCTURE *structure, > } > > if (ioctl(dev, DVD_READ_STRUCT, &s) < 0) > - return STATUS_INVALID_PARAMETER; > + /* Will be converted into ERROR_INVALID_FUNCTION */ > + return (errno == ENOMEDIUM) ? STATUS_INVALID_DEVICE_REQUEST : STATUS_INVALID_PARAMETER; That doesn't make much sense, you probably want to use FILE_GetNtStatus. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [cmd] move issues when overwriting files
by Alexandre Julliard 06 Sep '12

06 Sep '12

Ann and Jason Edmeades <jason(a)edmeades.me.uk> writes: > @@ -1709,8 +1709,13 @@ void WCMD_move (void) > WINE_TRACE("Source '%s'\n", wine_dbgstr_w(src)); > WINE_TRACE("Dest '%s'\n", wine_dbgstr_w(dest)); > > - /* If destination exists, prompt unless /Y supplied */ > - if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) { > + /* If we have src == dest, skip moving this one */ > + if (strcmpW(src,dest)==0) ok = FALSE; You can't detect identical files by comparing file names. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] msvcrt: Fixed RTTI structure on 64-bit systems
by Alexandre Julliard 06 Sep '12

06 Sep '12

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/cpp.c | 129 > ++++++++++++++++++---------------------------------- > dlls/msvcrt/cxx.h | 114 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 155 insertions(+), 88 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c && touch cpp.ok cpp.c:405: Test failed: bad rtti for e wine: Unhandled exception 0xe06d7363 at address 0x7b84a70a (thread 0025), starting debugger... Unhandled exception: C++ exception(object = 0x0022f870, type = 0x2b780f15a760) in 64-bit code (0x000000007b84a70a). Register dump: rip:000000007b84a70a rsp:000000000022f680 rbp:00002b780f1635f0 eflags:00000202 ( - -- I - - - ) rax:000000000022f6c0 rbx:000000000022f6a0 rcx:000000000022f6a0 rdx:0000000000000000 rsi:000000000022f838 rdi:000000000022f6d8 r8:00002b780f15a760 r9:000000000022f820 r10:2161746164204954 r11:00002b780d5712b0 r12:000000000022fa90 r13:0000000000013198 r14:000000007b8739b0 r15:00007fffffbe8000 Stack dump: 0x000000000022f680: 000000000022f6a0 ff000000ffffff00 0x000000000022f690: 0000000000000000 0000000000000000 0x000000000022f6a0: 00000001e06d7363 0000000000000000 0x000000000022f6b0: 000000007b84a70a 0000000000000003 0x000000000022f6c0: 0000000019930520 000000000022f870 0x000000000022f6d0: 00002b780f15a760 000000000022f870 0x000000000022f6e0: 000000000022f858 00002b780ef3c000 0x000000000022f6f0: 000000000022f858 0000000000000021 0x000000000022f700: 0000000000013198 000000007b8739b0 0x000000000022f710: 00007fffffbe8000 00002b780eefafdc 0x000000000022f720: 00000002c0000005 0000000000000000 0x000000000022f730: 00002b780d54eb28 00002b780d3224e0 Backtrace: =>0 0x000000007b84a70a RaiseException+0xba(code=<is not available>, flags=<is not available>, nbargs=<is not available>, args=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32 (0x00002b780f1635f0) 1 0x00002b780eee29c1 _CxxThrowException+0x30(object=<is not available>, type=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:1109] in msvcrt (0x00002b780f1635f0) 2 0x00002b780eee3242 MSVCRT___RTtypeid+0x171(cppobj=0x2b780f1635f0) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/../../../wine/dlls/msvcrt/cpp.c:901] in msvcrt (0x00002b780f1635f0) 3 0x00002b780ec60326 func_cpp+0x20c5() [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/dlls/msvcrt/tests/cpp.c:411] in msvcrt_test (0x00002b780f1635f0) 4 0x00002b780ec5c82c main+0x28b(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/msvcrt/tests/../../../../wine/include/wine/test.h:557] in msvcrt_test (0x0000000000000003) 5 0x00002b780ec8dc42 __wine_spec_exe_entry+0xa1(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in msvcrt_test (0x00002b780d2f38f0) 6 0x000000007b873a61 start_process+0xb0(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1052] in kernel32 (0x00002b780ec8dba0) 7 0x00002b780db5982e call_thread_func+0x6d(entry=0x7b8739b0, arg=0x7fffffbef000, frame=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3230] in ntdll (0x00007fff5630f450) 8 0x00002b780db52f1a call_thread_entry_point+0x29() in ntdll (0x00007fff5630f450) 9 0x00002b780db24a56 start_process+0x15(kernel_start=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2653] in ntdll (0x00007fff5630f450) 10 0x00002b780cfcd283 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff5630f450) 11 0x00002b780cfcd2d9 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 12 0x00002b780db2a500 LdrInitializeThunk+0x45f(kernel_start=0x7b8739b0, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2709] in ntdll (0x00007fffffbef000) 13 0x000000007b879ebd __wine_kernel_init+0x91c() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1255] in kernel32 (0x00002b780ddbb800) 14 0x00002b780db2ad74 __wine_process_init+0x143() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2918] in ntdll (0x00007fff56310700) 15 0x00002b780cfcb488 wine_init+0x297(argc=0x3, argv=0x7fff56310bf8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fff56310700) 16 0x000000007bf00da2 main+0x71(argc=0x3, argv=0x7fff56310bf8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:230] in <wine-loader> (0x00007fff56310bf8) 17 0x00002b780d55dead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff56310be8) [/home/aurel32/eglibc-sid/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 18 0x000000007bf00e9d _start+0x28() in <wine-loader> (0x0000000000000000) 0x000000007b84a70a RaiseException+0xba [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/except.c:85] in kernel32: 85 } -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Add AMD Radeon HD 7700 series and HD 7800 series graphics cards
by Henri Verbeet 06 Sep '12

06 Sep '12

On 6 September 2012 15:27, Jiang Yike <futureway(a)asia.com> wrote: > This patch adds the recognition of AMD Radeon HD 7700 series and HD 7800 > series graphics cards. > This patch has whitespace errors.

1 0

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests
by Marvin 06 Sep '12

06 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21412 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next (resend)
by Marvin 06 Sep '12

06 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21408 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork (resend)
by Marvin 06 Sep '12

06 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21407 Your paranoid android. === WNT4WSSP6 (32 bit main) === Timeout

1 0

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next
by Marvin 06 Sep '12

06 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21405 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] vcomp: better stub for _vcomp_fork
by Marvin 06 Sep '12

06 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21404 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).
by Alexandre Julliard 05 Sep '12

05 Sep '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -266,7 +266,7 @@ void MergeChmProperties(HH_WINTYPEW *src, HHInfo *info) > if (merge & HHWIN_PARAM_PROPERTIES) dst->fsWinProperties = src->fsWinProperties; > if (merge & HHWIN_PARAM_STYLES) dst->dwStyles = src->dwStyles; > if (merge & HHWIN_PARAM_EXSTYLES) dst->dwExStyles = src->dwExStyles; > - if (merge & HHWIN_PARAM_RECT) dst->rcWindowPos = src->rcWindowPos; > + if (merge & HHWIN_PARAM_RECT || override) dst->rcWindowPos = src->rcWindowPos; > if (merge & HHWIN_PARAM_NAV_WIDTH) dst->iNavWidth = src->iNavWidth; > if (merge & HHWIN_PARAM_SHOWSTATE) dst->nShowState = src->nShowState; > if (merge & HHWIN_PARAM_INFOTYPES) dst->paInfoTypes = src->paInfoTypes; You still need to check the source flags. -- Alexandre Julliard julliard(a)winehq.org

1 0

Building winetest-latest.exe?
by Dan Kegel 05 Sep '12

05 Sep '12

Hi folks, how does one build the native version of winetest.exe? I looked around a bit, and didn't see any obvious instructions. http://www.winehq.org/pipermail/wine-devel/2011-July/091144.html touches on it, but doesn't say much. I ask because I'm interested in tracking down why testbot doesn't think vcomp.dll is installed. ( cf. http://www.winehq.org/pipermail/wine-devel/2012-August/096642.html ) - Dan

5 7

Re: d3dx9_36 [try 4 ]: Implement D3DXSHRotate
by Rico Schüller 05 Sep '12

05 Sep '12

On 05.09.2012 08:02, Nozomi Kodama wrote: + out[15] = -0.9682458639f * in[13] + 0.25f * in[15]; ! You didn't find all trailing white spaces. I made a !, so it could be seen. You could easily get around that by changing your editors preference. Most editors are able to remove that automatically (see e.g. for vim http://vim.wikia.com/wiki/Remove_unwanted_spaces). You may also have a look at http://wiki.winehq.org/GitWine#head-b20b05157175835751686365f9818ae978ceca23 . Both are really easy to use. Be warned, that's not the only occurrence, so please look carefully if you remove them by hand. What you get from a comment to a patch are only hints. But you may check for all mentioned hints to the specific patch (even to previous tries), if you have fulfilled them or you may add a comment why you think the hint is bad. If you don't understand a hint, please ask - before sending another try, sometimes the hints could be wrong and sometimes they are worth to think about it. That's all I have to say, there won't be any more comments from my side to this patch. I need my time to get my own screwed up patches into wine. :-) Cheers Rico

1 0

Re: [PATCH 1/3] [cmd] "PATH=value" fails whereas "PATH value" works
by Marvin 04 Sep '12

04 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21386 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes.
by Vincent Povirk 04 Sep '12

04 Sep '12

> match = memcmp(dst_8x1, td[i].image, sizeof(dst_8x1)) == 0; > + if (!match) > + todo_wine ok(match, "%d: data should match\n", i); > + else > ok(match, "%d: data should match\n", i); This sort of thing makes me nervous. Couldn't you do this in such a way that we'll notice if the existing tests break, like adding a todo field to the structure?

1 0

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate
by Rico Schüller 04 Sep '12

04 Sep '12

On 04.09.2012 13:19, Nozomi Kodama wrote: + FLOAT expected, in[100], out[100], ... + for (i = 0; i < 49; i++) + in[i] = i + 1.01f; I guess this belongs together. I'd like to make some suggestions, please don't take it personally. When you got a comment on a patch, read it carefully. Think about it, if it makes sens to do the change (just adding what I've said is not always the best, it just gives you a hint, that you may improve some things, the list is not always complete and different people may have different suggestions) and try to improve your patch. After you are done, read your patch. Well mistakes happen, especially when you try to get something done really fast. (1) Take you some time and read it again and see if you've done that as best as possible and if you are happy with the code you've done, then submit it. If you've found a bug don't submit, fix it and go to #1. The earlier a bug is found the cheaper is it to solve it. I hope this helps a bit and it hopefully saves you some time to get a patch in the feature accepted. Thought I'd like to thank you for your patience and hopefully I haven't annoyed you and we'll see some good quality patches in the feature from you. :-) Cheers Rico

3 4

Re: wininet: Set last error for invalid URL argument
by Marvin 04 Sep '12

04 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21380 Your paranoid android. === W2KPROSP4 (32 bit internet) === Timeout

1 0

Re: [2/2] gdiplus: Add preliminary support for pixel offset modes.
by Vincent Povirk 04 Sep '12

04 Sep '12

> return sample_bitmap_pixel(src_rect, bits, width, height, > - gdip_round(point->X), gdip_round(point->Y), attributes); > + point->X + pixel_offset, point->Y + pixel_offset, attributes); > + } This is going to break tiling. By removing gdip_round you're implicitly truncating the number instead of flooring, which will give you the wrong result when X or Y is negative. I suggest explicitly adding a floorf.

1 0

Re: jscript: Fixed empty cases in the end of switch statement
by Marvin 04 Sep '12

04 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] mshtml: Properly expose frame and iframe element's windows to scripts
by Marvin 04 Sep '12

04 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21376 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Wine Gecko 1.8-beta1
by Jacek Caban 04 Sep '12

04 Sep '12

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

3 3

Re: d3dx9_36 [try 2]: Implement D3DXSHRotate
by Rico Schüller 04 Sep '12

04 Sep '12

On 03.09.2012 20:59, Nozomi Kodama wrote: > Thanks Rico and Henri for your help. > > Nozomi > > > The patch looks much better now. But I have some minor things which I didn't mention last time... + ok(received_ptr == out, "order %u, Expected %p, received %p\n", order, out, received_ptr); We may write the variables all starting with upper or lower char, maybe the first word will start with a upper char and the rest with a lower char. The mixture as is looks a bit ugly, doesn't it? Please have a look at the surrounding code, but not at test_D3DXSHRotateZ. ;-) And of course only going til 7 we won't need the in/out array till 100. 49 should fit, shouldn't it? That would be reducing the time spend in the for loops, even if it's only the test... Cheers Rico

1 0

vcomp.dll, vcomp90.dll missing on testbot?
by Dan Kegel 03 Sep '12

03 Sep '12

I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

3 9

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function
by Alexandre Julliard 03 Sep '12

03 Sep '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/htmlwindow.c | 127 > ++++++++++++++++++++++++++-------------------- > 1 files changed, 72 insertions(+), 55 deletions(-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -Werror -I/usr/include/freetype2 -g -O2 -o htmlwindow.o htmlwindow.c htmlwindow.c: In function ‘HTMLWindow2_item’: htmlwindow.c:416:13: error: variable ‘hres’ set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [htmlwindow.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.
by Alexandre Julliard 03 Sep '12

03 Sep '12

Alex Henrie <alexhenrie24(a)gmail.com> writes: > I was asked to split this patch up, so I did. The complaint about the > last version was "You are still overflowing the source." I have not > been able to find any test case that my implementation handled > incorrectly, however, I did find that (*src == 0 && srclen < 0) will > never evaluate to true, so I removed this if statement from the code. I > also changed example #2 in the tests to be slightly more stringent, but > the last patch would also have passed. > > If this patch series is rejected, please show me a test case that > demonstrates what I am doing wrong. You don't have a single test with an explicit source length, so obviously you are not going to find problems in that area. Like I said, you need a lot more tests. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] msctf: also free the sink in the non-source branch (Coverity)
by Marvin 03 Sep '12

03 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21357 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

Re: wined3d: Use backup swapchain DC for devices created with desktop window.
by Henri Verbeet 03 Sep '12

03 Sep '12

On 3 September 2012 00:51, Adam Jakubek <ajakubek(a)gmail.com> wrote: > Hi, > > This patch causes wined3d to use backup swapchain DC when > IDirect3DDevice9 is created using the desktop window. > Windows allows to create such device as long its type is > D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF. > > Unpatched Wine will fail in IDirect3D9_CreateDevice method, since it > incorrectly uses the X root window. > > Relevant d3d test case is included. > Patch closes bug #18490. > How is actual rendering to the desktop window supposed to work?

2 1

Re: [PATCH 6/6] mshtml: Added IHTMLIFrameElement3 stub implementation
by Marvin 03 Sep '12

03 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21355 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:5225: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:5262: Test failed: Could not get {30510433-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller 03 Sep '12

03 Sep '12

I had another look and like to give some suggestion. On 02.09.2012 22:28, Nozomi Kodama wrote: + sinb = sqrt( 1.0f - matrix->u.m[2][2] * matrix->u.m[2][2] ); I'd prefer to declare the variables as locally as possible. + D3DXSHRotateZ(temp5, order, alpha, temp4); + memcpy(out, temp5, sizeof(float) * order * order); + + return out; You probably may avoid the memcpy. What do you think about something like: return D3DXSHRotateZ(out, order, alpha, temp4); + FLOAT alpha, beta, gamma, sinb, temp1[36], temp2[36], temp3[36], temp4[36], temp5[36]; Do we really need that much temps? I think one is enough, but definitively 2 (I think you are able to use out as one "temp"). If you don't like the usage of out, you may use temp2 instead, but I think it could be avoided. D3DXSHRotateZ(out, order, gamma, in); RotateX(temp, order, 1, out); D3DXSHRotateZ(out, order, beta, temp); RotateX(temp, order, 0, out); D3DXSHRotateZ(out, order, alpha, temp); +static FLOAT* RotateX(FLOAT *out, UINT order, UINT pm, FLOAT *in) The return value is never used. Probably you may return void or you'd like to stack the function calls above a bit and reuse the returned pointer. You also may use "BOOL pm" since it uses only 0 and 1 or you may pass the "FLOAT a" directly to the function. Whatever pm stands for... Cheers Rico

2 1

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)
by Dmitry Timoshkov 03 Sep '12

03 Sep '12

Marcus Meissner <meissner(a)suse.de> wrote: > + if (!pInitializeConditionVariable) { > + skip("no condition variable support.\n"); > + return; > + } Probably this should be a win_slip(). > + /* fprintf(stderr,"produced %d, c1 %d, c2 %d\n", totalproduced, cnt1, cnt2); */ > + > + /* The sleeps of the producer or consumer should not go above 10000, otherwise > + * the implementation does not sleep correctly. */ > + > + /* fprintf(stderr,"producer sleep %d, consumer sleep %d\n", condvar_producer_sleepcnt, condvar_consumer_sleepcnt); */ There is trace() for debug output, it's shorter and more convenient IMHO. -- Dmitry.

4 3

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller 03 Sep '12

03 Sep '12

On 02.09.2012 23:46, Nozomi Kodama wrote: > For instance, D3DXSHAdd and D3DXSHDot accept order>D3DXSH_MAXORDER. So > we must check whether it is acceptable for other D3DXSH functions to > give such an order. If it is not acceptable, then we must know what the > function returns. Yes, they do and I agree with you. But why do you chose to try from 0 to 9 (<10) instead of 0-7 (<8) - which I think is enough and nothing more changes? (It includes the first round of not touched values.) Asking the other way around, why don't you try lets say till 1000? I guess the easy answer is, because the output values won't be touched for orders >6. The test results show the same for the tests 7-9 (and would til 1000) and thus testing for 7 is enough, testing 8 and 9 brings no new information, beside you would miss to test from 10 to open end. > > For the out of bound problem, I agree that we reach an out of bound. But > it is not a problem, since for such an index, expected is defined by an > other value. > If there is a complaining compiler about this, I can modify the tests > though. I'm not sure if the compiler is complaining, but I think it's much better to set it in the else case. You may get an unhandled exception and this is not what the software should do in the first place, it should run and not produce exceptions! :-) The same is done in test_D3DXSHRotateZ, which I'm not happy about it. Cheers Rico

1 0

Re: wined3d: Use backup swapchain DC for devices created with desktop window.
by Marvin 02 Sep '12

02 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21350 Your paranoid android. === WXPPROSP3 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W2K3R2SESP2 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === WVISTAADM (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W2K8SE (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PRO (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PROX64 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === TEST64_W7SP1 (32 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === W7PROX64 (64 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a. === TEST64_W7SP1 (64 bit device) === device.c:3541: Test failed: Failed to create REF device using desktop window, hr 0x8876086a.

1 0

Re : d3dx9_36: Implement D3DXSHRotate
by Nozomi Kodama 02 Sep '12

02 Sep '12

For instance, D3DXSHAdd and D3DXSHDot accept order>D3DXSH_MAXORDER. So we must check whether it is acceptable for other D3DXSH functions to give such an order. If it is not acceptable, then we must know what the function returns. For the out of bound problem, I agree that we reach an out of bound. But it is not a problem, since for such an index, expected is defined by an other value. If there is a complaining compiler about this, I can modify the tests though. Nozomi

1 0

Re: d3dx9_36: Implement D3DXSHRotate
by Rico Schüller 02 Sep '12

02 Sep '12

On 02.09.2012 22:28, Nozomi Kodama wrote: > > + for (order = 0; order < 10; order++) > Is there a reason why we'd want to test til 9? D3DXSH_MAXORDER is 6, so 7 Should be enough? I know the other test do this, but technically I see no reason for that. Specifically the if (.. order > D3DXSH_MAXORDER) says exactly that, so no need to further than 7, since the parameters or did I miss something? I guess you'd also out of bounds? table[36 * j + i]; (for j=3 and i=99 => 207) since the table only has 4*36 => 144 elements. Cheers Rico

1 0

Re: winhttp: disable TLSv1.1/1.2 by default
by Henri Verbeet 02 Sep '12

02 Sep '12

On 26 August 2012 18:56, André Hentschel <nerv(a)dawncrow.de> wrote: > It's for http://bugs.winehq.org/show_bug.cgi?id=30598 > So it has its reason > So assuming I don't feel like reading through various bug trackers to figure this out, what is the specific issue this patch is supposed to address?

1 0

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).
by Charles Davis 02 Sep '12

02 Sep '12

On Sep 2, 2012, at 11:23 AM, Erich E. Hoover wrote: > This patch adds the final feature to make the embedded help work > properly, allowing Elster to resize the HTML Help window whenever the > application window is resized. Without this feature the HTML Help > window would always remain at the same size as when the window was > first created. Er, uh, what patch? Chip

2 1

Re: [PATCH] kernel32: add condition variables prototypes and tests
by Marvin 02 Sep '12

02 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21332 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH] kernel32: add condition variables prototypes and tests
by Marvin 02 Sep '12

02 Sep '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21331 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: netapi32: Add stub for NetScheduleJobAdd
by Jacek Caban 01 Sep '12

01 Sep '12

Hi Jong, On 09/01/12 17:13, Jong Bin, Chae wrote: > --- > dlls/netapi32/netapi32.c | 6 ++++++ > dlls/netapi32/netapi32.spec | 2 +- > 2 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/dlls/netapi32/netapi32.c b/dlls/netapi32/netapi32.c > index 470adf0..f6c6d20 100644 > --- a/dlls/netapi32/netapi32.c > +++ b/dlls/netapi32/netapi32.c > @@ -238,6 +238,12 @@ NET_API_STATUS WINAPI NetUseEnum(LMSTR server, > DWORD level, LPBYTE* bufptr, DWOR > return ERROR_NOT_SUPPORTED; > } > > +NET_API_STATUS WINAPI NetScheduleJobAdd(LPCWSTR server, LPBYTE > bufptr, LPDWORD jobid) > +{ > + FIXME("stub (%s, %p, %p)\n", debugstr_w(server), bufptr, jobid); It looks like your mail client wraps lines. Please send patches as attachments or reconfigure your mail client. Cheers, Jacek

1 0

Wine Gecko 1.8-beta1
by Jacek Caban 01 Sep '12

01 Sep '12

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko PS: This is a second resend. For some reason this mail didn't make to wine-devel yesterday.

1 0

Re: winhttp: disable TLSv1.1/1.2 by default
by Hiroshi Miura 01 Sep '12

01 Sep '12

Hi, Thanks André to point the discussion On 2012年08月27日 01:56, André Hentschel wrote: > Am 26.08.2012 17:46, schrieb Marcus Meissner: >> On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: >>> >>> Windows 7 disables TLSv1.1/1.2 by default. >>> This patch intend to behave same as Windows. >> >> >> Please do not... The newer TLSv1.x fix some shortcomings >> of the older TLS versions. >> >> Is there a specific problem you see? >> >> Otherwise, I object. >> > > It's for http://bugs.winehq.org/show_bug.cgi?id=30598 > So it has its reason > Yes it has a reason to disable TLS 1.1 1.2 by DEFAULT. It also provide interface to enable it through registry entry, which is same as windows does. I also prefer to use TLS 1.1/1.2 than before SSL3.0/TLS1.0. but here is a interoperability issue with SSL3.0/TLS 1.0 only site and TLS1.1/1.2 enabled Wine program. In evernote case, client program use wininet dll instead of winhttp. Even such a case, it should be a same behavior for registry values in secur32/schannel, wininet, and winhttp dlls. I understand that wininet/winhttp has a issue to re-implement it using schannel instead of openssl. It means if we support a behavior disabling/enabling TLS1.1/1.2 with registry entry for Schannel, wininet/winhttp should also have a same behavior. We need to add function that enable/disable TLS1.1/1.2 in secur32/schannel according to this registry, but I've not implemented it yet. registry entry is like; ---- Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Client] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.1\Server] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Client] "DisabledByDefault"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\SecurityProviders\SCHANNEL\Protocols\TLS 1.2\Server] "DisabledByDefault"=dword:00000000 ----- see http://netsekure.org/2009/10/tls-1-2-in-windiows-7/ Hiroshi

1 0

Re: [1/16] po: Update Russian translation
by Nikolay Sivov 31 Aug '12

31 Aug '12

On 8/24/2012 10:13, Oleg Yarigin wrote: > > > "To install a new program from a floppy disk, CD-ROM drive, or your hard " > "drive, click Install." > msgstr "" > -"Чтобы установить программу с CD-ROM, дискеты или жёсткого диска, нажмите " > -"Установить." > +"Для установки программы с компакт- или жёсткого диска нажмите «Установить»." You only need to fix quotation marks in original string, the variant you proposed doesn't say what English string is saying. > #: appwiz.rc:62 > -msgid "" > -"The following software can be automatically removed. To remove a program or " > -"to modify its installed components, select it from the list and click Modify/" > -"Remove." > -msgstr "" > -"Перечисленные программы можно автоматически удалить. Чтобы удалить программу " > -"или изменить состав установленных компонентов, выберите её в списке и " > +msgid "The following software can be automatically removed. To remove a " > +"program or to modify its installed components, select it from the list and " > +"click Modify/Remove." > +msgstr "Перечисленные программы могут быть удалены. Для удаления " > +"или изменения состава установленных компонентов, выберите их в списке и " > "нажмите кнопку Изменить/Удалить." Again, don't alter original meaning, no reason to remove 'automatically' here. > #: appwiz.rc:76 > msgid "The following information can be used to get technical support for %s:" > -msgstr "" > -"Указанная информация может быть использована для получения технической " > +msgstr "Указанная информация может быть использована для получения технической " > "поддержки приложения %s:" Nothing changed here. > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" That's questionable. If you really want to change that it will need to depend on context I guess. > #: avifil32.rc:33 > msgid "Wine AVI-default-filehandler" > -msgstr "Обработчик по умолчанию avi-файлов в Wine" > +msgstr "Обработчик avi-файлов по умолчанию в Wine" This alters a meaning a bit, now what you did means that there're some default avi-files in Wine.

3 5

Re: kernel32: Return correct drive type for empty drives
by Alexandre Julliard 31 Aug '12

31 Aug '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > I followed your advice and now, I only ask the mountmgr when needed. > --- > dlls/kernel32/volume.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) This is failing here when the drive is empty: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:132: Tests skipped: can't test removing fake drive volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87 make: *** [volume.ok] Error 1 If I put a DVD in I get: volume.c:813: Test failed: IOCTL_DVD_READ_STRUCTURE should have failed Probably the tests need some fixing. -- Alexandre Julliard julliard(a)winehq.org

4 3

Wine Gecko 1.8-beta1
by Jacek Caban 31 Aug '12

31 Aug '12

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper <noscript> tag handling - Synchronous ActiveX loading - Possibility to properly call APIs requiring JSContext - Possibility to implement HTMLStyleElement::styleSheet property As usually, to test it you need the attached patch and Gecko build placed in the right place [2]. Any help with testing is appreciated! On related note, I seriously consider dropping debug builds and replace them by unstripped release build or even just a separated package containing only debug symbols for the release build. Here are my thoughts about reasoning (in random order): - People use debug build mostly to retrieve better backtraces. Unstripped builds also give that ability. - If someone really needs debug build, it's easy enough to build it himself (and that's usually a good idea anyway) - Debug builds are seriously different than release build, so it occasionally exposes different set of problems, leading to invalid assumptions. This is really something for developers rather than users. - It costs my time spent builds and tests. And I consider it a serious matter. Amount of work needed to keep Gecko relevant is constantly growing. I try to mitigate it by doing long-term improvements upstream, automating the process and improving my hardware, but that has its limits. And the time spent on Gecko maintenance (as in pure maintenance, not real improvements) costs Wine in terms of improvements I could make in this time. If someone has a reason to keep debug builds, let me know. Any comments are welcomed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.8-beta1/ [2] http://wiki.winehq.org/Gecko

1 0

Re: kernel32: Add UTF-7 support. (try 5)
by Alexandre Julliard 31 Aug '12

31 Aug '12

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Try 5 adds two tests for the case where srclen < -1 and passes them both. You are still overflowing the source. You need to spend more time on this. You also need to split the patch, and write some sort of table-driven tests so you can test a lot more cases, the ones you have are clearly not sufficient. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Moving pages to/from wiki
by Kyle Auble 31 Aug '12

31 Aug '12

Wed, Aug 29, 2012 16:09, André Hentschel wrote: > get the website source and do "grep -Ri cvs *" > then ignore wwn/ and news/ ... > all that should somehow bring you to http://www.winehq.org/cvs or be deleted grep -r "...." * is rapidly becoming a very good friend of mine ;) I just checked http://cvs.winehq.org and sure enough, there is still a very outdated CVS repository there, but I can't find a template or a PHP applet for it, just the same links you found (most in WWN issues). I've CCed Jeremy Newman because I'm guessing the site admin would have to remove it. As for redirecting to http://www.winehq.org/cvs, since that was designed as a notice page for people trying to browse the source code, I was picturing just redirecting the links to http://source.winehq.org/git and deleting http://www.winehq.org/cvs as only WWN issues and news would still have dangling links. I don't want to remove it if there's another reason for keeping it though. - Kyle

5 6

Re: [PATCH 2/5] hhctrl.ocx: Implement HH_SET_WIN_TYPE (try 7).
by Alexandre Julliard 30 Aug '12

30 Aug '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > @@ -1784,11 +1785,25 @@ void ReleaseHelpViewer(HHInfo *info) > OleUninitialize(); > } > > -HHInfo *CreateHelpViewer(LPCWSTR filename, HWND caller) > +static BOOL info_in_list(HHInfo *info) > +{ > + HHInfo *i; > + > + LIST_FOR_EACH_ENTRY(i, &window_list, HHInfo, entry) > + { > + if(i == info) > + return TRUE; > + } > + return FALSE; > +} You should never need that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Add UTF-7 support. (try 4)
by Alexandre Julliard 30 Aug '12

30 Aug '12

Alex Henrie <alexhenrie24(a)gmail.com> writes: > + do > + { > + if (src[source_index] == 0 && srclen == -1) > + { > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, 0)) return -1; > + /* when srclen=-1, terminate at the first null character found */ > + break; > + } > + else if (src[source_index] == '+') > + { > + WCHAR byte_pair = 0; > + short offset = 0; > + > + source_index++; /* skip the + sign */ > + > + if (src[source_index] == '-') > + { > + /* just a plus sign escaped as +- */ > + if (dry_run) dest_index++; else if (write_to_w_string(dst, dstlen, &dest_index, '+')) return -1; > + source_index++; > + continue; > + } You are not checking properly for the source string length. Also please add tests for such cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Moving pages to/from wiki
by Kyle Auble 29 Aug '12

29 Aug '12

I'm starting to work on moving static pages to and from the wiki, but I wanted to ask for opinions on a few changes first: 1. Move all static IRC pages to the wiki or add info from the wiki to the static templates? The static pages only mention #winehq and don't describe guidelines, but IRC details shouldn't change much right? 2. For the static About page, some languages also have wiki versions. Do we want to keep the sparser versions currently in use, or add the more detailed information from the wiki version? Both versions seem well-written, and exist for English, Hebrew, & Spanish (I deleted the Polish wiki version; it was a duplicate). 3. Do we still need the static "cvs" page, or should I just redirect any links to it, then delete? On a related note, the WineHQ ToDo on the wiki still claims that a browser for the old CVS source tree is lurking on the site somewhere. Is that true, or do I need to cut that line from the ToDo list? 4. Since licensing tends to be really static could we just redirect the WikiLicense page to the static license page, or should they be kept separate? While I'd think it wouldn't be too hard to reword the static page's intro to include other projects, I'm leery of editing any legal-ese without asking first. By the way, the WikiLicense page says it's LGPL v2.1 in the intro text, but the included license actually looks like v2.0 of the GPL with a modification for libraries. If the wiki version of the page should stay, I'll put in a copy of v2.1 - Kyle

2 1

Re: [Tools] testbot: Add LICENSE and COPYING.LIB files.
by Henri Verbeet 29 Aug '12

29 Aug '12

On 29 August 2012 16:35, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > I think this made total sense when th WineTestBot was in its own > repository. Now maybe the COPYING.LIB and LICENSE files can be > considered to apply to all of the Wine tools and should go to the > top-level directory? > Not all of the code in tools.git is under LGPL 2.1. (And personally I'd argue that GPL 3 is probably more appropriate for most of the things in there anyway.)

2 1

Wine bot results
by Alistair Leslie-Hughes 29 Aug '12

29 Aug '12

Hi, I have a patch that when run on on the testbot, it fails on all but two machines. However when I build the exe myself and run it, it pass on all but two machines. http://testbot.winehq.org/JobDetails.pl?Key=21257 http://testbot.winehq.org/JobDetails.pl?Key=21256 Ubuntu 12.04. Any Ideas on the different results? Best Regards Alistair Leslie-Hughes

5 7

Re: d3dx9: ID3DXConstantTable
by Józef Kucia 29 Aug '12

29 Aug '12

On Tue, Aug 21, 2012 at 10:52 PM, gurketsky <gurketsky(a)googlemail.com>wrote: > I just like to present the state of the ID3DXConstantTable implementation, > so that possibly no work is done twice. This goes specifically to Józef. > I'm not sure what's the plan on this. There are two problems which arise > and I did not had time to sort those out, yet. > Thanks for notifying me. I was about to write some tests for structures in constant tables. I see that you've already written such tests. Cheers, Józef Kucia

4 8

Re: gdiplus: Make GdipMeasureCharacterRanges/GdipMeasureString/GdipDrawString add extra space around the text. Take 2.
by Vincent Povirk 28 Aug '12

28 Aug '12

This looks correct to me. Lack of shared logic and GenericTypographic still makes me sad, but not too sad because the added logic is simple.

1 0

Re: About WineHQ Wiki
by Kyle Auble 28 Aug '12

28 Aug '12

Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: > When I edited pages in the WineHQ Wiki, I notised, its markup lankuage > isn`t so good as MediaWiki`s one. How do you think about moving the Wiki > into MediaWiki engine? Besides, moving each language section of the Wiki > into separated subdomain (like in Wikipedia) would be a good idea too. I've been working a lot on the wiki recently, and I actually brought up something similar in this thread: http://www.winehq.org/pipermail/wine-devel/2012-July/096198.html While I'm busy with other things right now, I wanted to discuss this in more detail in the near future, particularly how it ties into possibly migrating the entire site over to a CMS. The Moinmoin syntax was new to me too, but after using it a little, I don't mind it too much. There are definitely a few missing features and rough edges compared to MediaWiki. However, and this is just my impression, I think MediaWiki has really evolved to fit Wikipedia's needs. I'm not sure how well it integrates (style-wise at least) if you don't run your entire site off of it, and while I haven't actually looked at MediaWiki's code, I've heard that it can be really tricky to setup, maintain, and reprogram. There are some pluggable parsers for Moinmoin, and there may be one that allows MediaWiki syntax. After going through and checking, categorizing, and editing so many pages, I definitely agree with your suggestion that each language be given a domain, instead of one flat namespace. Then maybe just add a single common "translation" menu to the side toolbar? I've come to the opinion that we should probably stick with Moinmoin, and migrate to a new engine other than MediaWiki only if there are strong reasons. What might be best is if we actually got in touch with some of the Moinmoin developers and put in some feature requests. Helping with the wiki's engine is on my list so I'd like to hear some more opinions. -Kyle

5 8

Re: [PATCH 1/5] d3dx9: Add some traces to D3DXLoadSurfaceFromMemory().
by Henri Verbeet 28 Aug '12

28 Aug '12

2012/8/28 Rico Schüller <kgbricola(a)web.de>: > + FIXME("Format conversation missing %#x -> %#x\n", src_format, surfdesc.Format); I don't think that's really what we want it to say.

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path (resend)
by Alexandre Julliard 28 Aug '12

28 Aug '12

Erik van Pienbroek <erik(a)vanpienbroek.nl> writes: > +#if defined(HAVE_FORK) && defined(HAVE_WAITPID) > +static UINT_PTR SHELL_try_native_execute ( const char *openCmd, const char *unixName ) > +{ > + UINT_PTR retval = SE_ERR_NOASSOC; > + pid_t cpid; > + struct stat st; > + > + if (stat(openCmd, &st) == -1) > + { > + TRACE("stat() %s failed: %s\n", openCmd, strerror(errno)); > + return retval; > + } > + > + cpid = fork(); > + if (!cpid) > + { > + /* Prevent the situation where the native file association database > + * tries to run wine to execute a program and we trigger this fallback > + * path again and end up in a recursive loop */ > + if (getenv("WINE_INSIDE_SHELLEXECUTE")) > + { > + TRACE("recursive loop detected, not continuing with ShellExecute call\n"); > + exit(EXIT_SUCCESS); > + } > + setenv("WINE_INSIDE_SHELLEXECUTE", "1", 0); > + > + TRACE("running %s %s\n", openCmd, unixName); > + execlp(openCmd, openCmd, unixName, (char*) NULL); > + /* execlp replaces the current process image with a new process image, > + * so no code below here should get executed by the forked child */ > + } else { > + int status; > + waitpid(cpid, &status, 0); > + TRACE("status %x\n", status); > + if(!WEXITSTATUS(status)) > + retval = 33; > + } > + > + return retval; > +} You want spawnvp(), but that sort of thing should probably go in winebrowser or something like that, and be configurable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Try to get the drive type from the mountmgr first [resend]
by Alexandre Julliard 28 Aug '12

28 Aug '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Should fix bug #17037 > Now that my patch disappeared from source.winehq.org/patches, I'm resending it. > Before commenting, please read the e-mail I sent in July (winehq.org/pipermail/wine-devel/2012-July/096587.html) The goal here is to avoid a mountmgr round-trip for the common case, calling mountmgr first defeats this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin 28 Aug '12

28 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21287 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin 28 Aug '12

28 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21286 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/6] Always define WIDL_C_INLINE_WRAPPERS
by Marvin 28 Aug '12

28 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21285 Your paranoid android. === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: gdiplus: When copying an image do not round pixel positions up.
by Vincent Povirk 28 Aug '12

28 Aug '12

I know this looks wrong, but it's there for a reason, and it matches the behavior of the other interpolations. In my tests, the center of a bitmap pixel is at an integral value, meaning that the pixel at (0,0) is a rectangle extending from (-0.5, -0.5) to (0.5, 0.5), and if you enlarge an image you do get out-of-bounds bits on the lower right. I'm pretty sure I also tested GdipDrawImageRect separately and got the same result.

2 7

re: xmllite: Store DTD processing mode in reader
by Dan Kegel 28 Aug '12

28 Aug '12

Alexandre Julliard wrote: > Explicit ok() calls are better than hiding them inside a macro. Uh-oh. Want me to get rid of this macro +#define CHECK_RET_ERRNO(ret, ex) \ + do { \ + ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \ + ok(errno == ex, "errno is %d, expected %d\n", errno, ex); \ + } while (0) in http://source.winehq.org/patches/data/89349 ?

2 1

Re: [3/3] gdiplus: Make GdipMeasureCharacterRanges/GdipMeasureString/GdipDrawString add extra space around the text.
by Vincent Povirk 28 Aug '12

28 Aug '12

> These APIs use different logic for adding extra space, so at the moment > I don't see how gdip_format_string() can be used to do this in one place, > but if somebody has an idea how to do that - patches are welcome. That is highly unlikely, particularly given that MeasureCharacterRanges is the accepted practice for highlighting parts of a string. You should make sure you do your tests so the size in pixels is the em size of the font, or at least at a consistent size between them, as native may cut into the padding if hinting makes the characters proportionally larger (this is the point of having the padding, but for the record I think it is behavior that we shouldn't try to duplicate). Do you have a visual test program for this? I'd like to see something that draws a string overlayed with the measurements, to confirm that the functions are not consistent on Windows (or, if they are, confirm that they are consistent with your patch). If not, I'll write one and send you the source code. + /* FIXME: GenericTypographic format prevents extra margins */ Since no margins is the current behavior, won't that cause a regression? It should be fairly easy to include that exception. Then again, I think I've heard reports that GenericTypographic doesn't work.

2 10

Re: gdiplus: Use outside color from image attributes for an out of bounds pixel.
by Vincent Povirk 28 Aug '12

28 Aug '12

> if (src_pointf.X >= srcx && src_pointf.X < srcx + srcwidth && src_pointf.Y >= srcy && src_pointf.Y < srcy+srcheight) > *dst_color = resample_bitmap_pixel(&src_area, src_data, bitmap->width, bitmap->height, &src_pointf, imageAttributes, interpolation); > else > - *dst_color = 0; > + *dst_color = imageAttributes->outside_color; It's like this for a reason. This isn't out of the bounds of the source image, which is when imageAttributes would apply. This is out of the bounds of the parallelogram we're drawing, and we should be leaving that pixel alone.

1 0

Re: [PATCH 1/2] msvcrt: Detect UTF-8 mode
by Alexandre Julliard 27 Aug '12

27 Aug '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1286,6 +1288,17 @@ static int msvcrt_get_flags(const MSVCRT_wchar_t* mode, int *open_flags, int* st > case '+': > case ' ': > break; > + case ',': > + if (!memcmp(mode, encoding_utf8, sizeof(encoding_utf8)) ) > + { > + *open_flags |= MSVCRT__O_U8TEXT; > + *open_flags &= ~(MSVCRT__O_TEXT | MSVCRT__O_BINARY | MSVCRT__O_WTEXT | MSVCRT__O_U16TEXT); > + mode += (sizeof(encoding_utf8)/sizeof(MSVCRT_wchar_t)); > + } > + else > + FIXME("mode %s not supported\n", debugstr_w(mode -1)); Your string parsing needs more work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite: Store DTD processing mode in reader
by Alexandre Julliard 27 Aug '12

27 Aug '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -350,34 +353,47 @@ static void test_reader_create(void) > HRESULT hr; > IXmlReader *reader; > IUnknown *input; > + DtdProcessing dtd; > > /* crashes native */ > if (0) > { > pCreateXmlReader(&IID_IXmlReader, NULL, NULL); > - pCreateXmlReader(NULL, (LPVOID*)&reader, NULL); > + pCreateXmlReader(NULL, (void**)&reader, NULL); > } > > - hr = pCreateXmlReader(&IID_IXmlReader, (LPVOID*)&reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + hr = pCreateXmlReader(&IID_IXmlReader, (void**)&reader, NULL); > + EXPECT_HR(hr, S_OK); > > test_read_state(reader, XmlReadState_Closed, -1, FALSE); > > + dtd = 2; > + hr = IXmlReader_GetProperty(reader, XmlReaderProperty_DtdProcessing, (LONG_PTR*)&dtd); > + EXPECT_HR(hr, S_OK); > + ok(dtd == DtdProcessing_Prohibit, "got %d\n", dtd); > + > + dtd = 2; > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, dtd); > + EXPECT_HR(hr, E_INVALIDARG); > + > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, -1); > + EXPECT_HR(hr, E_INVALIDARG); > + > /* Null input pointer, releases previous input */ > hr = IXmlReader_SetInput(reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + EXPECT_HR(hr, S_OK); Explicit ok() calls are better than hiding them inside a macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Unused msvcp100 functions?
by Francois Gouget 27 Aug '12

27 Aug '12

There are a lot of msvcp100 functions that look like they are unused: * In string.c all of the MSVCP__String_base_*(), MSVCP_basic_string_*(), MSVCP_basic_string_wchar_*() and MSVCP_char_traits_*() functions, basic_string_w?char_replace_helper(). * In locale.c _Locinfo__Locinfo_ctor_bstr(), codecvt_{short,wchar}__Id_func(), collate_{char,short}__Getcat(), various ctype_*() functions, etc. * In ios.c, the basic_istream_*() and basic_ostream_*() functions, ios_base_Index_func() and ios_base_Sync_func(). * In math.c a lot of std_Ctraits_{double,float,long}_*() functions. Is it just that the spec file needs to catch up or that they will be used soon? I attached a more precise list of the suspects. I did not actually verify that all of them are unused but based on the ones I looked at it seems to be the case. If they are indeed unused and will remain so I can submit a patch to remove them. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx
by Dmitry Timoshkov 27 Aug '12

27 Aug '12

Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? -- Dmitry.

2 1

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.
by Vincent Povirk 27 Aug '12

27 Aug '12

> + GdipFree(backup); I think you want GdipDeletePath. This seems very convoluted. Couldn't we just skip the size conversion in get_log_fontW when graphics is NULL? Any cases where the scaling would produce a size other than the em size need to be fixed in GdipAddPathString anyway.

2 2

Re: msxml3: Implement xmldecl-version property for a reader
by Marvin 27 Aug '12

27 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21252 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WXPPROSP3 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WVISTAADM (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K8SE (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PRO (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout

1 0

re: msvcr100: Add wmemmove_s and wmemcpy_s
by Dan Kegel 26 Aug '12

26 Aug '12

I asked Alexandre what http://source.winehq.org/patches/data/88732 needed before it could be reviewed. He said it needed to adapt to the recent parameter checking changes. I see that when he took my patch http://www.winehq.org/pipermail/wine-patches/attachments/20120728/bea2581d/… and committed it as http://source.winehq.org/git/wine.git/patch/49560458426cf25b6a36bbf9bad35aa… he could remove a few assignments to *MSVCRT__errno() because MSVCRT_CHECK_PMT now does that for you. But msvcr100's wmemmove_s/wmemcpy_s are different; they do not change errno. Tests in my patch confirm this. So changing msvcr100's CHECK_PMT macro to assign to errno doesn't seem appropriate. So, is there still anything that needs changing?

2 2

Re: About WineHQ Wiki
by Kyle Auble 26 Aug '12

26 Aug '12

Sorry if my replies come in large batches, I'm subscribed to the mailing list digest. Sun, 26 Aug 2012 10:08, Cheer Xiao wrote: > Hi all, > I'm a MoinMoin contributor, one of MoinMoin's participating students > in this year's Summer of Code. > 2012/8/26 Kyle Auble <randomidman48(a)yahoo.com>: >> Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: >>> When I edited pages in the WineHQ Wiki, I notised, its markup lankuage >>> isn`t so good as MediaWiki`s one. How do you think about moving the Wiki >>> into MediaWiki engine? Besides, moving each language section of the Wiki >>> into separated subdomain (like in Wikipedia) would be a good idea too. >> There are some pluggable parsers for Moinmoin, and there may be one >> that allows MediaWiki syntax. After going through and checking, >> categorizing, and editing so many pages, I definitely agree with your >> suggestion that each language be given a domain, instead of one flat >> namespace. Then maybe just add a single common "translation" menu to >> the side toolbar? > Indeed there is a MediaWiki parser[1]. > Also, take a look at MoinMoin 2.0[2]. It has multiple markups support > out of the box (including mediawiki of course). You can even mix them > in a single wiki instance - this is not necessarily a good idea, but > it helps when you have to migrate some content from another wiki by > hand. ... > Feature requests are welcome, but be noted that MoinMoin 2.0 is the > current development version (it's not a development "branch" since the > codebase is almost a total rewrite) and quite likely the feature you > want is already there (or a TODO). :) Hello, I'm glad to hear there's already a line of communication. Allowing people to use MediaWiki syntax will probably be a big plus. There have been performance problems, but I noticed both the Ubuntu and Moinmoin wikis are pretty snappy so I'm thinking it's due to a strained server and using an old version of Moinmoin (although the SystemInfo macro seems to be disabled, I ran across version info somewhere, and I think Wine Wiki is running Moinmoin 1.5 or 1.6). I'm not sure if other problems I've noticed have been fixed in v1.8 or 1.9 so I would have to try out those versions before checking against v2.0. One thing I have done is written up some python code to help convert HTML tables to Moinmoin ones. I checked in Moinmoin's script market, but could only find full-blown page converters, and their output was kind of messy. I probably got carried away, but I'll attach it to http://wiki.winehq.org/WineStatus because I'm using it to move WineHQ's static status pages to the wiki. I guess that would make it LGPL so if you want to salvage a few parts from it or have me submit it to your utility marketplace, just let me know. Sun, 26 Aug 2012 16:07, Andre Hentschel wrote: > Further it seems a bit more complicated with Wine, the moinmoin wiki is sponsored by http://lattica.com/ (whatever > sponsored means, didn't find further information) and the code > is not accessable via a wine git repo (maybe it should be in tools.git, website.git or its own). This also leads to the > fact that we still have no new wiki theme years after the > theme change on the website. > Now that we upgraded the Forum engine we (we as in laxdragon xD) could maybe do something about the wiki, it > needs love. > It seems Kyle is doing a good job at the content, but the content is not everything. Thank you for the compliment. I am actually planning on doing more coding soon, but besides ramping up, I though cleaning up the wiki some first would let me see where the different parts of the project are. Applying the theme from the rest of the WineHQ is on both the WikiToDo and my own list (no guarantees about how long I would take though). Sun, 26 Aug 2012 22:46, Cheer Xiao wrote: > And yes, as I noted in a previous post moin2 is *not* production-ready > yet and I don't suggest you jump ship now. :) > What I do strongly suggest, however, is that you upgrade to moin1.9 > first, since 1) there has been many security fixes[1] which are not > backported to old versions, and 2) upgrade to moin2 will only be > supported from moin1.9. Helping to upgrade the wiki is on my list somewhere between finishing a first round of polishing content and trying a couple of patches to Wine itself. Although the maintainer would actually have to deploy it, I could test and work some of the kinks out of the upgrade using a local install. Dimi Paun put a lot of work into setting up the wiki in the first place and is the maintainer at lattica. From the git logs and mail list, it seems like he has been really busy with other things for a while. At times, Jeremy Newman has raised the possibility of moving the wiki to WineHQ: http://www.winehq.org/pipermail/wine-devel/2006-June/048712.html I remember stumbling across another email too, but I can't find it right now. If it's still a possibilty, I think the first step would be somehow setting up datadumps so we could start on the upgrade. If there is already a feature for admins to do that, maybe Dimi could start putting a daily/weekly tarball on WineHQ's FTP site. If it requires a custom patch though, I could look into doing that too. -Kyle

1 0

Re: po: Update German translation
by Julian Rüger 26 Aug '12

26 Aug '12

Hi André, war ich zu langsam? ;) Das Komma ist an der Stelle grammatikalisch falsch, glaube ich. "Die verbundenen Controller" sollten auch Plural bleiben. Mein Vorschlag wäre irgendwie so etwas: "Nach dem De-/Aktivieren eines Gerätes wird die Liste der verbundenen Controller bis zum Neustart dieses Applets nicht [mehr] aktualisiert." Viele Grüsse, Julian Am Samstag, den 25.08.2012, 13:40 +0200 schrieb André Hentschel: > "After disabling or enabling a device, the connected joysticks won't be " > "updated here until you restart this applet." >-msgstr "" >+msgstr "Nach dem deaktivieren oder aktivieren eines Gerätes, wird der " >+"verbundene Controller hier bis zum Neustart des Applets nicht mehr " >+"aktualisiert."

1 1

Re: winhttp: disable TLSv1.1/1.2 by default
by Marcus Meissner 26 Aug '12

26 Aug '12

On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: > > Windows 7 disables TLSv1.1/1.2 by default. > This patch intend to behave same as Windows. Please do not... The newer TLSv1.x fix some shortcomings of the older TLS versions. Is there a specific problem you see? Otherwise, I object. Ciao, MArcus > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/winhttp/net.c | 74 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > > > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 5ec4e1a..03cf9b7 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -52,6 +52,7 @@ > #include "winbase.h" > #include "winhttp.h" > #include "wincrypt.h" > +#include "winreg.h" > > #include "winhttp_private.h" > > @@ -109,8 +110,10 @@ MAKE_FUNCPTR( SSL_load_error_strings ); > MAKE_FUNCPTR( SSLv23_method ); > MAKE_FUNCPTR( SSL_CTX_free ); > MAKE_FUNCPTR( SSL_CTX_new ); > +MAKE_FUNCPTR( SSL_CTX_ctrl ); > MAKE_FUNCPTR( SSL_new ); > MAKE_FUNCPTR( SSL_free ); > +MAKE_FUNCPTR( SSL_ctrl ); > MAKE_FUNCPTR( SSL_set_fd ); > MAKE_FUNCPTR( SSL_connect ); > MAKE_FUNCPTR( SSL_shutdown ); > @@ -408,12 +411,66 @@ static int netconn_secure_verify( int preverify_ok, X509_STORE_CTX *ctx ) > } > return ret; > } > + > +static long get_tls_option(void) { > + long tls_option; > + DWORD type, val, size; > + HKEY hkey,tls12_client,tls11_client; > + LONG res; > + const WCHAR Schannel_Prot[] = { /* SYSTEM\\CurrentControlSet\\Control\\SecurityProviders\\SCANNEL\\Protocols */ > + 'S','Y','S','T','E','M','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l','\\', > + 'S','e','c','u','r','i','t','y','P','r','o','v','i','d','e','r','s','\\', > + 'S','C','H','A','N','N','E','L','\\', > + 'P','r','o','t','o','c','o','l','s',0 }; > + const WCHAR TLS12_Client[] = {'T','L','S',' ','1','.','2','\\','C','l','i','e','n','t',0}; > + const WCHAR TLS11_Client[] = {'T','L','S',' ','1','.','1','\\','C','l','i','e','n','t',0}; > + const WCHAR DisabledByDefault[] = {'D','i','s','a','b','l','e','d','B','y','D','e','f','a','u','l','t',0}; > + > + tls_option = SSL_OP_NO_SSLv2; /* disable SSLv2 for security reason, and secur32/Schannel(GnuTLS) don't support it */ > + res = RegOpenKeyExW(HKEY_LOCAL_MACHINE, > + Schannel_Prot, > + 0, KEY_READ, &hkey); > + if (res != ERROR_SUCCESS) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + tls_option |= SSL_OP_NO_TLSv1_1; > + goto end; > + } > + if (RegOpenKeyExW(hkey, TLS12_Client, 0, KEY_READ, &tls12_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls12_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_2:0; > + } > + RegCloseKey(tls12_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } > + if (RegOpenKeyExW(hkey, TLS11_Client, 0, KEY_READ, &tls11_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls11_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_1:0; > + } > + RegCloseKey(tls11_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } > + RegCloseKey(hkey); > + > +end: > + return tls_option; > +} > #endif > > BOOL netconn_init( netconn_t *conn, BOOL secure ) > { > #if defined(SONAME_LIBSSL) && defined(SONAME_LIBCRYPTO) > int i; > + long tls_option; > #endif > > conn->socket = -1; > @@ -453,8 +510,10 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( SSLv23_method ); > LOAD_FUNCPTR( SSL_CTX_free ); > LOAD_FUNCPTR( SSL_CTX_new ); > + LOAD_FUNCPTR (SSL_CTX_ctrl); > LOAD_FUNCPTR( SSL_new ); > LOAD_FUNCPTR( SSL_free ); > + LOAD_FUNCPTR( SSL_ctrl ); > LOAD_FUNCPTR( SSL_set_fd ); > LOAD_FUNCPTR( SSL_connect ); > LOAD_FUNCPTR( SSL_shutdown ); > @@ -494,11 +553,20 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( sk_num ); > #undef LOAD_FUNCPTR > > +#define pSSL_CTX_set_options(ctx,op) \ > + pSSL_CTX_ctrl((ctx),SSL_CTRL_OPTIONS,(op),NULL) > +#define pSSL_set_options(ssl,op) \ > + pSSL_ctrl((ssl),SSL_CTRL_OPTIONS,(op),NULL) > + > pSSL_library_init(); > pSSL_load_error_strings(); > > method = pSSLv23_method(); > ctx = pSSL_CTX_new( method ); > + > + tls_option = get_tls_option(); > + pSSL_CTX_set_options(ctx, tls_option); > + > if (!pSSL_CTX_set_default_verify_paths( ctx )) > { > ERR("SSL_CTX_set_default_verify_paths failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > @@ -676,12 +744,18 @@ BOOL netconn_connect( netconn_t *conn, const struct sockaddr *sockaddr, unsigned > BOOL netconn_secure_connect( netconn_t *conn, WCHAR *hostname ) > { > #ifdef SONAME_LIBSSL > + long tls_option; > + > if (!(conn->ssl_conn = pSSL_new( ctx ))) > { > ERR("SSL_new failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > set_last_error( ERROR_OUTOFMEMORY ); > goto fail; > } > + > + tls_option = get_tls_option(); > + pSSL_set_options(conn->ssl_conn, tls_option); > + > if (!pSSL_set_ex_data( conn->ssl_conn, hostname_idx, hostname )) > { > ERR("SSL_set_ex_data failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > > >

1 0

Question about some Linux integration
by Oleg Yarigin 25 Aug '12

25 Aug '12

Hi! I have an idea to move some Wine parts into Linux subsystems. For instance, Wine apps windows and window content can be drawn with Desktop Manager via USER32.DLL opposite of using Wine Server. Similar thing can be with clipboard. I understand, it`s a big work, what is must to be started with an EXE loader. So I have a few questions before I can start: 1. Does Wine loader have any mechanism for loading .so files. 2. May I move all loader stuff from NTDLL to the loader. Is it rational? I asked, becouse there are a lot of stuff, that can be unloaded after program loading. And an off-top question: where is wine_server_call realisation defined? --- Oleg

2 2

About WineHQ Wiki
by Oleg Yarigin 25 Aug '12

25 Aug '12

Hi to all! When I edited pages in the WineHQ Wiki, I notised, its markup lankuage isn`t so good as MediaWiki`s one. How do you think about moving the Wiki into MediaWiki engine? Besides, moving each language section of the Wiki into separated subdomain (like in Wikipedia) would be a good idea too. --- Oleg

1 0

Re: [1/16] po: Update Russian translation
by Dmitry Timoshkov 24 Aug '12

24 Aug '12

These new translations look at least questionable to say the least. -- Dmitry.

2 1

Re: advapi32/tests: Skip a couple of registry tests on NT4 to avoid crashing it.
by Alexandre Julliard 24 Aug '12

24 Aug '12

Francois Gouget <fgouget(a)free.fr> writes: > I know it's bad form to test for the Windows version but I'm not sure > what other check would be relevant here. I think we can safely ignore such old versions at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

configure --with-osmesa fails to link
by Peter Urbanec 24 Aug '12

24 Aug '12

I just turned on --with-osmesa and configure fails for me: > checking for -lOSMesa... not found > configure: error: libOSMesa development files not found (or too old), > OpenGL rendering in bitmaps won't be supported. > This is an error since --with-osmesa was requested config.log output would suggest that perhaps the test is being treated as C code, but libOSMesa needs to link with C++ libs. > configure:9067: checking for -lOSMesa > configure:9092: gcc -o conftest -g3 -feliminate-unused-debug-symbols > -O0 -mtune=core2 conftest.c -lOSMesa -lSM -lICE -lXext -lX11 > -lm >&5 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete[](void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new(unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_proc_address' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete(void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_dispatch_table_size' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new[](unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__cxa_pure_virtual' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__gxx_personality_v0' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__vmi_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_add_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_check_multithread' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__si_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Dispatch' > collect2: ld returned 1 exit status This is on Gentoo x64 with: media-libs/mesa-8.1_rc1_pre20120814 (classic egl g3dvl gallium llvm nptl osmesa shared-glapi vdpau xvmc -bindist -d3d -debug -gbm -gles1 -gles2 -kernel_FreeBSD -openvg -pax_kernel -pic -r600-llvm-compiler -selinux -video_cards_i915 -video_cards_i965 -video_cards_intel -video_cards_nouveau -video_cards_r100 -video_cards_r200 -video_cards_r300 -video_cards_r600 -video_cards_radeon -video_cards_radeonsi -video_cards_vmware -wayland -xa -xorg) sys-devel/gcc-4.6.3 (cxx fortran graphite mudflap multilib nls nptl openmp -altivec -bootstrap -build -doc -fixed-point -gcj -go -gtk -hardened -libssp -multislot -nocxx -nopie -nossp -objc -objc++ -objc-gc -test -vanilla) Any suggestions as to how this could be fixed? My autoconf skills are no match for this problem :-( Thanks.

3 3

Re: quartz/tests: Use proper method macros
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21196 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154

1 0

Re: wshom.ocx/tests: Use proper method macro
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21198 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [2/16] po: Update Russian translation
by Nikolay Sivov 24 Aug '12

24 Aug '12

On 8/24/2012 10:14, Oleg Yarigin wrote: > #: comctl32.rc:88 > msgid "&Add ->" > -msgstr "&Добавить ->" > +msgstr "&Добавить →" > #: comctl32.rc:89 > msgid "<- &Remove" > -msgstr "<- &Удалить" > +msgstr "← &Удалить" I don't think so. > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" New translation is traditionally used for 'folders' mostly. I agree there's a mess in directory/folder/catalogue here though. > #: comdlg32.rc:223 > msgid "[none]" > -msgstr "[нет]" > +msgstr "(нет)" Why? > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" The reason was it doesn't fit a dialog template otherwise, did you check that? > #: comdlg32.rc:52 > msgid "Unreadable Entry" > -msgstr "Нечитаемый элемент" > +msgstr "Нераспознаваемый элемент" You translated 'unrecognised' instead of 'unreadable'. > #: comdlg32.rc:65 > msgid "Cannot find the printer." > -msgstr "Не удалось найти принтер." > +msgstr "Принтер не найден." However I like this kind of changes, it's a good example of keeping it short while it means the same. > #: comdlg32.rc:91 > msgid "Output tray is full; " > -msgstr "Лоток переполнен бумагой; " > +msgstr "Лоток для бумаги переполнен; " Could be "Лоток полон;" ... I can't comment on the rest of this series but there's a lot to fix already.

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21195 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WXPPROSP3 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WVISTAADM (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W2K8SE (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PRO (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Dmitry Timoshkov 24 Aug '12

24 Aug '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY Please resend the test separately, your fix conflicts with the patch sent by Roman Dadkov. -- Dmitry.

1 0

Re: dssenh/tests: Added key exchange tests for the DSSENH cryptographic service provider
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21186 Your paranoid android. === TEST64_W7SP1 (32 bit dssenh) === dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008

1 0

Have there been any problems with Wine on GCC 4.7?
by Scott Ritchie 23 Aug '12

23 Aug '12

Wine is the last remaining package still depending on GCC 4.5 in the current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port Wine, however 4.6 is known to not work too well. But now we have 4.7 -- have there been any bugs attributed to its usage? Thanks, Scott Ritchie

4 15

Re: hhctrl.ocx: Make MergeChmProperties() static.
by Erich E. Hoover 23 Aug '12

23 Aug '12

I'm going to need MergeChmProperties() for HH_SET_WIN_TYPE. I've just been really busy lately and have not had a chance to cleanup my patches yet (from discussions with Jacek it looks like we need to redo storing HH_WINTYPE data a little bit). Erich

1 0

Re: [PATCH 1/3] dinput: Disable linuxinput or linux joysticks based on registry key (try 2)
by Alexandre Julliard 23 Aug '12

23 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "controllername(drivername)"="disabled" key > > Examples: > Disable the linux js driver for "Usb Controller" device > "Usb Controller(js)"="disabled" > > Disable the linux js and event drivers for "Other Controller" device > "OtherController(event)"="disabled" > "OtherController(js)"="disabled" That's better, thanks. You probably want to put them under a subkey though, to avoid mixing up the joystick names with the other configuration values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/3] joy.cpl: Using joystick name suffixed with driver when in Linux (try 2)
by Alexandre Julliard 23 Aug '12

23 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > @@ -57,6 +57,34 @@ BOOL WINAPI DllMain(HINSTANCE hdll, DWORD reason, LPVOID reserved) > return TRUE; > } > > +static void get_joystick_name(struct Joystick *joy) > +{ > + /* Base product guids as Wine defines them in DirectInput */ > + /* 9e573ed9-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linux_guid = { 0x9e573ed9, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + /* 9e573eda-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linuxinput_guid = { 0x9e573eda, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + static REFGUID wine_guids[] = { &linux_guid, &linuxinput_guid }; > + static const WCHAR wine_device_names[2][9] = { {'(','j','s',')','\0'}, {'(','e','v','e','n','t',')','\0'} }; I think dinput should be appending that to the returned name, joy.cpl shouldn't have to know about the specific naming scheme of the driver. -- Alexandre Julliard julliard(a)winehq.org

2 1

Testing Gdi+
by Stepa Nick 23 Aug '12

23 Aug '12

Hi! I`m new in WINE development. I have some tests cases, that works incorrect in current version of WINE and I want to fix this mistakes. So, I`m interesting are there some testing systems that compares bitmap(for example)? I look thru WINE tests, http://www.winehq.org/docs/winedev-guide/testing and had found only tests, that compare some variables to constant. I think, that WINE needs graphics test. Thanks.

2 1

Re: wine/server: removed obsolete one-iteration loop from request forming macro (try 2)
by Marcus Meissner 23 Aug '12

23 Aug '12

On Thu, Aug 23, 2012 at 11:14:23AM +0400, Oleg Yarigin wrote: > An original message was sent with wrong author`s name by mistake, so > I resend this patch with hope it was the only reason to reject it. It was not the only reason. A single loop is a common pattern in C to allow safe encapsulation and handling of blocks, or doing "break;"/"continue;" style things. One thing that it allows here in Wine is that the variable definitions are at the begin of a { } block and not in the middle of the code to allow old C standard builds to work still. There is no "break;" usage, although I spotted 1 "goto done;" which could be just a break; ;) The compiler will optimize everything of those loops away, so this change also brings no performance improvement. Ciao, Marcus > --- > include/wine/server.h | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/include/wine/server.h b/include/wine/server.h > index d573d1f..dcbc7fa 100644 > --- a/include/wine/server.h > +++ b/include/wine/server.h > @@ -124,19 +124,15 @@ static inline void *wine_server_get_ptr( client_ptr_t ptr ) > /* macros for server requests */ > > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ > - struct type##_request * const req = &__req.u.req.type##_request; \ > - const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > - memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > - __req.u.req.request_header.req = REQ_##type; \ > - __req.data_count = 0; \ > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ > + struct type##_request * const req = &__req.u.req.type##_request; \ > + const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > + memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > + __req.u.req.request_header.req = REQ_##type; \ > + __req.data_count = 0; \ > + (void)reply; > + > +#define SERVER_END_REQ > > > #endif /* __WINE_WINE_SERVER_H */ > -- 1.7.9.5 > > -- Open Linux Security Engineer Position at SUSE: http://bit.ly/Li4RbS

1 0

Re: configure.ac: provide a --disable-dwarf2 configure option
by Alexandre Julliard 22 Aug '12

22 Aug '12

Austin English <austinenglish(a)gmail.com> writes: > This should address the concerns from > http://bugs.winehq.org/show_bug.cgi?id=31501 I don't think that justifies adding a configure option, people shouldn't have to worry about that kind of detail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/server: removed obsolete one-iteration loop from request forming macro
by Sergey Guralnik 22 Aug '12

22 Aug '12

On 2012-08-22 6:26, Архад wrote: > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ ... > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ ... > + (void)reply; > + > +#define SERVER_END_REQ Are you try at least to rebuild project with it? -- Sergey

1 0

Re: opengl32/test: do not pass NULL attrib list to wglCreatePBufferARB
by Marvin 22 Aug '12

22 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus: GdipMeasureCharacterRanges should respect device units and transformations.
by Vincent Povirk 22 Aug '12

22 Aug '12

> GetTextExtentExPointW(hdc, string + index, range_start - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.X = bounds->X + range_size.cx; > + range_rect.X = bounds->X / args->rel_width + range_size.cx; > > GetTextExtentExPointW(hdc, string + index, range_end - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.Width = (bounds->X + range_size.cx) - range_rect.X; > + range_rect.Width = (bounds->X / args->rel_width + range_size.cx) - range_rect.X; Shouldn't you be scaling range_size.cx as well?

2 3

Re: user32: Don't limit time needed for WM_DDE_INITIATE processing.
by Alexandre Julliard 21 Aug '12

21 Aug '12

Piotr Caban <piotr(a)codeweavers.com> writes: > Current timeout is too small for Microsoft Office 2010 in some cases. > I've checked that DdeConnect succeeds on windows when it needs to wait > for 10 minutes. Are you sure that you want to remove the SMTO_ABORTIFHUNG flag? Does a hung process really prevent all DDE connections? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] dinput: Disable linuxinput or linux joysticks based on registry key
by Alexandre Julliard 21 Aug '12

21 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "Disable Controllername"="driver" > > Examples: > Disable "Usb Controller"="js" disable linux js driver > Disable "OtherController"="event,js" disable linux js and event drivers That's a fairly complicated way to disable a given joystick. What you probably want is to give them a unique name and have a enable/disable value for each name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mountmgr.sys: For loop-mounted devices, use the backing file
by Alexandre Julliard 21 Aug '12

21 Aug '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > As part of their copy protection, some games use some ioctl's to check some physical attributes. > Unfortunately, when using the loop device, some ioctl fail (like IOCTL_SCSI_GET_ADDRESS). > A simple fix is to use /path/to/the/file.ISO instead of /dev/loopX. Several places depend on this being a device. Besides, failing to get the SCSI address of a loop mount seems like correct behavior to me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH] kernel32: add basic conditional variables support (try 2)
by Alexandre Julliard 21 Aug '12

21 Aug '12

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > Started with patch from Austin, brought up to a point > where Adobe Lightroom 4.1 starts up. > > The synchronisation is probably not 100% correct and > not sufficiently atomic. Synchronization routines have to be 100% correct, half stubs are worse than no implementation at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)
by Lucas Zawacki 20 Aug '12

20 Aug '12

Hello, this patch caused a regression with Rayman 2, all the text in the menus is rendered wrong now. Should I open a bug or is this email enough? A demo of the game can be downloaded here ftp://ftp.ubisoft.com/Rayman2/rayman2high.zip Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png Regression test: a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit commit a488e574497d674631b4036d4b179ce349ddb764 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Aug 15 00:38:26 2012 +0200 wined3d: Improve post-pixelshader blending test. :040000 040000 1a61c91a146de3e7a5206ccde1cc239fa0771e40 a9759ba603b3b52f2feccc716daff3d875a90b74 M dlls

2 1

Re: [6/7] d3dx9: Implement ID3DXConstantTable::SetMatrixPointerArray.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > + if (desc.Class == D3DXPC_MATRIX_ROWS || desc.Class == D3DXPC_MATRIX_COLUMNS) > + { ... > + } > + else if (desc.Class == D3DXPC_SCALAR) Could you also set D3DXPC_VECTOR variables with this call? It should be easy to add a test for a scalar and a vector. But that may also be a separate patch. In general I think it would be fine to try to set all variable class and see which work / fail. That way you would also verify, that the non common way works too, which has no test, yet, but a implementation. This holds true for all the Set(Matrix/Vector/...) functions. That way you'd ensure that the setting is correct for the specific class. ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "c2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "r2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "vec3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "scalar", matrix_pointer, 1); Cheers Rico

1 0

Re: [3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device) > out[8], out[9], out[10], out[11], > out[12], out[13], out[14], out[15]); > > + ID3DXConstantTable_SetFloat(ctable, device, "mvp", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res); You probably may save res (= ID3DXConstantTable_SetFloat) before checking it. Otherwise you are checking the same res value multiple times. > + ID3DXConstantTable_SetFloat(ctable, device, "f4", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res); Cheers Rico

1 0

Re: [PATCH 1/2] oleaut32: Ensure that the right interface is passed to the callee in ITypeInfo::Invoke
by Alexandre Julliard 20 Aug '12

20 Aug '12

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( > { > prgpvarg[i] = src_arg; > } > + > + if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR && tdesc->u.lptdesc->vt == VT_USERDEFINED)) > + && (V_VT(prgpvarg[i]) == VT_DISPATCH || V_VT(prgpvarg[i]) == VT_UNKNOWN)) { > + const TYPEDESC *userdefined_tdesc = tdesc; > + IUnknown *userdefined_iface; > + ITypeInfo *tinfo2; > + TYPEATTR *tattr; > + > + if(tdesc->vt == VT_PTR) > + userdefined_tdesc = tdesc->u.lptdesc; typelib.c: In function ‘ITypeInfo_fnInvoke’: typelib.c:6516:41: error: variable ‘userdefined_tdesc’ set but not used [-Werror=unused-but-set-variable] make[1]: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Microsecond unit
by Francois Gouget 20 Aug '12

20 Aug '12

The microsecond unit is 'µs' and yet, in dlls/sane.ds/sane.rc, we define it as 'us' and then rely on the British and American English PO files to convert it to 'µs'. Why not put the right unit directly in the RC file? It's UTF-8 anyway... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Add UTF-7 support. (try 4)
by Alex Henrie 20 Aug '12

20 Aug '12

Correction: I meant to write that try 4 exits the loop slightly faster when ending a base64 sequence, it has nothing to do with escaped plus signs which are handled a few lines earlier. -Alex

1 0

Re: [6/7] gdiplus: Add a test for extra space added by GdipMeasureString. Resend.
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msctf: Call interface methods properly
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21043 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

How to convert msvcp names to legible names?
by Bruno Jesus 19 Aug '12

19 Aug '12

Which is the roseta stone used to read all msvcp function names like "msvcp80.dll.??0?$basic_stringstream@GU?$char_traits@G@std@@V?$allocator@G@2@@std@@QAE@H@Z, aborting" as the real function name in source code? Thanks in advance, Bruno

3 2

Re: winedbg: Use standard fixed pitch UI font for the crash dialog.
by Dmitry Timoshkov 17 Aug '12

17 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > static void set_fixed_font( HWND dlg, UINT id ) > { > - HFONT hfont = (HFONT)SendDlgItemMessageW( dlg, id, WM_GETFONT, 0, 0); > - LOGFONTW font; > + HFONT hfont; > > - GetObjectW(hfont, sizeof(LOGFONTW), &font); > - font.lfPitchAndFamily = FIXED_PITCH; > - font.lfFaceName[0] = 0; > - hfont = CreateFontIndirectW(&font); > + hfont = GetStockObject( ANSI_FIXED_FONT ); > SendDlgItemMessageW( dlg, id, WM_SETFONT, (WPARAM)hfont, TRUE ); > } To clarify things a bit: current code uses empty font face name, and GDI uses "System" font in that case (regardless of requested FIXED_PITCH), which is absolutely not readable. ANSI_FIXED_FONT should use built-in "Courier", which is actually a FIXED_PITCH font and much more readable. -- Dmitry.

2 3

Re: [10/10] gdiplus: Filter tabs out until they are properly supported using stringformat.
by Vincent Povirk 17 Aug '12

17 Aug '12

This should probably be handled somehow by gdip_format_string. DrawDriverString doesn't have access to the StringFormat, and there's a good change that the native implementation really does draw tabs as squares. Also, MeasureCharacterRanges and MeasureString will have to account for tabstops. gdip_format_string already has logic to ignore certain characters, but it needs more thought as to how we can do that and keep the offsets passed to the callback accurate, and how to eventually pass information about tabs to the callback. If this does turn out to be a correct change for DrawDriverString (I predict that it is not), then MeasureDriverString should be updated as well.

2 1

Re: [08/10] gdiplus: GdipMeasureString/GdipDrawString should add extra space around the text.
by Vincent Povirk 17 Aug '12

17 Aug '12

Why can't this logic go in gdip_format_string?

2 6

Re: Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider (try2)
by Marvin 17 Aug '12

17 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20983 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [02/10] gdiplus: If source and destination rectangles differ it's not a reason to fallback to software blitting.
by Vincent Povirk 17 Aug '12

17 Aug '12

> Both StretchBlt and GdiAlphaBlend handle that case just fine. Only if the graphics interpolation mode happens to be nearest neighbor, which isn't the default.

2 3

Re: DSSENH/tests: Added block cipher mode tests for the DSSENH cryptographic service provider
by Marvin 17 Aug '12

17 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20977 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] riched20: Added support for UTF8 BOM stream. (Try 2)
by Alexandre Julliard 16 Aug '12

16 Aug '12

Qian Hong <fracting(a)gmail.com> writes: > @@ -304,8 +307,19 @@ static LRESULT ME_StreamInText(ME_TextEditor *editor, DWORD dwFormat, ME_InStrea > > if (!(dwFormat & SF_UNICODE)) > { > - /* FIXME? this is doomed to fail on true MBCS like UTF-8, luckily they're unlikely to be used as CP_ACP */ > - nWideChars = MultiByteToWideChar(CP_ACP, 0, stream->buffer, stream->dwSize, wszText, STREAMIN_BUFFER_SIZE); > + if (!is_read) > + { > + is_read = TRUE; > + if (stream->dwSize >= 3 && !memcmp(stream->buffer, bom_utf8, 3)) > + { > + cp = CP_UTF8; > + stream->dwSize -= 3; > + memmove(stream->buffer, stream->buffer + 3, stream->dwSize); There's no reason to move the data. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Nikolay Sivov 16 Aug '12

16 Aug '12

On Thu, Aug 16, 2012 at 5:20 PM, Sergey Guralnik <serhio(a)etersoft.ru> wrote: > > -- > Sergey > > > You can use simple assignment with st_null instead of that: + memset(&nmsc.stSelEnd, 0, sizeof nmsc.stSelEnd);

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 2/2] comctl32: Correct values passed in MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20934 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1257: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

1 0

Re: [PATCH 1/2] comctl32/tests: Add test for MCN_SELECT/MCN_SELCHANGE notifications.
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20933 Your paranoid android. === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2KPROSP4 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WXPPROSP3 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K3R2SESP2 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === WVISTAADM (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W2K8SE (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PRO (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === W7PROX64 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead === TEST64_W7SP1 (64 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead

2 1

Re: comdlg32: Use proper helpers for iface calls
by Marvin 16 Aug '12

16 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20929 Your paranoid android. === TEST64_W7SP1 (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 75AF1AC3

1 0

Re: [PATCH 1/4] include/wine/test.h: Added wine_dbgstr_a[n] to test framwork.
by Qian Hong 16 Aug '12

16 Aug '12

On Thu, Aug 16, 2012 at 4:55 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > This shouldn't be necessary, you can use a simple printf. Functions > should only be added to test.h if there's a clear need across a wide > range of tests. Thanks for review! Will provide an updated patch set soon. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [PATCH] kernel32: add support for CAL_ICALINTVALUE
by Alexandre Julliard 16 Aug '12

16 Aug '12

Michael Blumenkrantz <michael.blumenkrantz(a)gmail.com> writes: > @@ -656,8 +656,8 @@ int WINAPI GetCalendarInfoW(LCID Locale, CALID Calendar, CALTYPE CalType, > * for the CALTYPES not requiring GetLocaleInfoA */ > switch (CalType & ~(CAL_NOUSEROVERRIDE|CAL_RETURN_NUMBER|CAL_USE_CP_ACP)) { > case CAL_ICALINTVALUE: > - FIXME("Unimplemented caltype %d\n", CalType & 0xffff); > - return 0; > + return GetLocaleInfoW(Locale, LOCALE_RETURN_NUMBER|LOCALE_ICALENDARTYPE, > + (LPWSTR)lpValue, sizeof(CALID)/sizeof(WCHAR)); I doubt that you want to hardcode LOCALE_RETURN_NUMBER here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: windowscodecs: Implement Palette_InitializeFromBitmap.
by Vincent Povirk 15 Aug '12

15 Aug '12

This does not agree with MSDN's description of the function. According to MSDN, InitializeFromBitmap should compute a palette based on the contents of the (presumably) non-paletted bitmap data.

2 2

Re: Use WM_PAINT to redraw button instead of directly calling unthemed paint routine
by Dmitry Timoshkov 15 Aug '12

15 Aug '12

Ruslan Kabatsayev <b7.10110111(a)gmail.com> wrote: > This patch makes buttons render correctly themed in various cases when > e.g. they are pressed and released, made active etc. Without this > patch they look win95-like in such cases even if desktop integration > is used. Let me guess, you didn't run 'make test' with these changes? -- Dmitry.

2 1

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20875 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20871 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [05/17] gdiplus: GdipMeasureString should apply its internal scaling factors to layout rectangle.
by Alexandre Julliard 14 Aug '12

14 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/gdiplus/graphics.c | 10 ++++++++-- > dlls/gdiplus/tests/graphics.c | 29 ----------------------------- > 2 files changed, 8 insertions(+), 31 deletions(-) This fails here on 64-bit: ../../../../wine/tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so ../../../../wine/dlls/gdiplus/tests/graphics.c && touch graphics.ok graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 graphics.c:3609: Test failed: Expected 100.000000, got 98.999786 make: *** [graphics.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] ole32: Added ISynchronizeHandle tests
by Marvin 14 Aug '12

14 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20841 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: user32: search more aggressively for a window under a tooltip
by Dmitry Timoshkov 14 Aug '12

14 Aug '12

Daniel Jelinski <djelinski1(a)gmail.com> wrote: > Fixes bug 9512 and bug 8914, tested with Delphi and DVD Profiler. > Still not perfect - according to MSDN the function should never return > a window belonging to another thread. This kind of change requires a test case, and I suspect it's plain wrong. -- Dmitry.

3 9

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template
by Dmitry Timoshkov 13 Aug '12

13 Aug '12

Eric Pouech <eric.pouech(a)orange.fr> wrote: > MMRESULT WINAPI acmFormatChooseW(PACMFORMATCHOOSEW pafmtc) > { > - return DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > - pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + MMRESULT ret; > + > + if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATEHANDLE) > + ret = DialogBoxIndirectParamW(MSACM_hInstance32, (LPCDLGTEMPLATEW)pafmtc->hInstance, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else if (pafmtc->fdwStyle & ACMFORMATCHOOSE_STYLEF_ENABLETEMPLATE) > + ret = DialogBoxParamW(pafmtc->hInstance, pafmtc->pszTemplateName, > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + else > + ret = DialogBoxParamW(MSACM_hInstance32, MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > + pafmtc->hwndOwner, FormatChooseDlgProc, (LPARAM)pafmtc); > + return ret; > } It would look much better without all those 'ret' + 'else' things. -- Dmitry.

2 3

Re: [PATCH 2/4] wined3d: Fix pixel format alpha/red masks.
by Henri Verbeet 13 Aug '12

13 Aug '12

On 13 August 2012 20:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + * Pixel formats with more than 4 bpp do not have correct masks, because the > + * high masks do not fit into the 32 bit values needed for ddraw. The masks > + * are only used for ddraw mostly, and to figure out if the format has an alpha > + * component (the POSTPIXELSHADER_BLENDING test also uses those masks to know > + * if there is more than 1 alpha bit and a red component), so that doesn't > + * matter. The 64 and 128 bit formats are not supported by ddraw anyway. > */ We'll probably want these as offset + mask, or perhaps offset + size.

1 0

Re: joy.cpl: Corrected misplaced elements when using high DPIs
by Alexandre Julliard 13 Aug '12

13 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Zawacki <lfzawacki(a)gmail.com> > > Fixes bug #31316 > > joy.cpl uses CreateWindow and SetWindowPos to draw some elements > and the hardcoded coordinates where wrong when the dpi was set to anything > bigger than 96px in winecfg. My approach to solve is normalize the > coordinates based on the dialog window size. You probably want to use MapDialogRect instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

_vcomp_fork stack frame puzzle
by Dan Kegel 12 Aug '12

12 Aug '12

Having fun trying to figure out what's in the black box of _vcomp_fork(), the helper function that spawns threads in Visual C's OpenMP support library. The C source code #include <stdio.h> #include <omp.h> int main(int argc, char **argv) { double d; double e; int i; printf("&d is %p, &e is %p\n", &d, &e); #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p\n", &d); } #pragma omp parallel for for (i=0; i<3; i++) { printf("&d is %p, &e is %p\n", &d, &e); } return 0; } when compiled with cl /MD /openmp /FAs odd.c generates an .exe and a mixed assembly / source .asm listing. The compiler puts the loop into a helper function, and invokes the helper using _vcomp_fork(), which is called with a flag saying whether to parallelize, a pointer to the helper function, a count, and then a pointer to each variable referenced by the loop from the outer scope. The code in the helper function knows to get the addresses of the variables from the stack. When run with native vcomp.dll, this prints out the right addresses inside the loop. When run with my slightly less stubby builtin vcomp patch attached to http://bugs.winehq.org/show_bug.cgi?id=26688 (based on Andre's earlier patch), it prints out garbage. It seems like Andre's varargs code should be right, but something's not connecting. I even tried beer, and it still didn't work. I guess I should fire up a debugger and see what's going on, but I don't want to accidentally see too much about what native's doing. Suggestions, anyone? - Dan

2 5

Wiki is down
by Austin English 10 Aug '12

10 Aug '12

Mind taking a look? :) Have a great weekend! -- -Austin

2 1

Re: user32: Menu should not be activated by menu key while mouse buttons are down.
by Jan Boon 10 Aug '12

10 Aug '12

Okay, will write a test case later today or tomorrow. When trying to fix the issue I had, I noticed that in the function where it currently handles the logic for the menu key, it only received messages WM_MOUSEACTIVATE on pressing and WM_CAPTURECHANGED on release (in the tested application), but no mouse down or up messages, which caused the mouse down not to set the iMenuSysKey to 0 if the mouse button was pressed after holding alt (and additionally it also needs to not select the menu either when hitting alt while the mouse button is already down). (Also, when trying this manually on linux, gnome desktop wm mouse-button-modifier should be changed from Alt to something else, because it intercepts the alt-mouse combos before wine sees them it seems.) So, since the function is not receiving all the messages here, which I assume are not all forwarded to the default handler by 3ds Max, would it be better to hook into the messages or mouse status at an earlier point in the code (to handle the first case where the mouse is pressed after alt)? And is there a saner way that can be used here to check if the mouse is down (when alt is pressed after mouse down)? On Fri, Aug 10, 2012 at 8:14 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Jan Boon <jan.boon(a)kaetemi.be> wrote: > > > Fix for bug #31434. > > 1. this kind of change requires a test case, some of the changes look wrong > 2. formatting is broken due to not standard tab size > 3. patch introduces compile-time warnings, that's not accepatable > > -- > Dmitry. >

1 0

Re: [01/17] gdiplus: Add more tests for GdipMeasureString using device with custom resolution. Take 4.
by Vincent Povirk 09 Aug '12

09 Aug '12

Other than patch 15 the series looks good to me, and I've seen or thought about most of this before, but do you really have to send a series of 17 patches at once?

2 1

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.
by Vincent Povirk 09 Aug '12

09 Aug '12

This will break text rendering. We need the correct font to be selected on the hdc during the call to gdip_format_string.

2 3

Re: [1/4] gdiplus: Add a test for GdipDrawImage scaling.
by Vincent Povirk 08 Aug '12

08 Aug '12

This series looks good to me.

1 0

__wine_uuidof causing a wall of "warning: returning reference to temporary" on g++
by Ilya Konstantinov 08 Aug '12

08 Aug '12

Hi, I've just started porting my C++ application to Linux with Winelib. Upon first attempts to compile, I've received a wall of "warning: returning reference to temporary" on Wine's headers from g++. All of those seem to stem from guidgen.h definition of __wine_uuidof / __CRT_UUID_DECL for C++. All in all, g++ seems to be right -- we are indeed returning a reference to a IID struct that's allocated on the stack. If I remove the '&' in this definition (in guidgen.h): template<typename T> const GUID &__wine_uuidof(); the warnings stop, but then I wonder, did the original author have some good reasoning for returning a reference in the first place? Thanks.

2 4

Re: [3/4] gdiplus: Destination points passed to GdipDrawImagePointsRect should be in device units.
by Dmitry Timoshkov 08 Aug '12

08 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > + scale_x = units_scale(srcUnit, graphics->unit, graphics->xres); > + scale_y = units_scale(srcUnit, graphics->unit, graphics->yres); This depends on a not yet sent series which introduces units_scale(), please ignore for now, I'll resend it a bit later. -- Dmitry.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel