- wine-devel - winehq.org

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).
by Alexandre Julliard 14 Jun '12

14 Jun '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. As of version > 3 of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and it also includes some additional cleanup. It > is important to note that HTML Help only supports characters within > the ANSI code pages, so support for multi-byte characters is not > necessary. I don't see why you'd want to use ANSI code pages for this, since they will be converted to Unicode anyway. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: msvcrt/tests: Fix portuguese locale test on NT4
by Marvin 14 Jun '12

14 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19045 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: msvcrt: Fix the name of the Portuguese locale alias.
by Bruno Jesus 14 Jun '12

14 Jun '12

On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget <fgouget(a)free.fr> wrote: > ... > dlls/msvcrt/locale.c | 2 +- > dlls/msvcrt/tests/locale.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > ... > - "portugese", "ptb", > + "portuguese", "ptb", Just a side note. Although I'm not sure I think portuguese is "ptg", brazilian portuguese is "ptb". So the correct may be: > + "portuguese", "ptg", A Portugal user would be able to check that, or maybe it's easier to write a testcase. If I'm wrong I ask apologies in advance, Bruno

3 2

DllMain() seems unused in ntoskrnl.exe
by Francois Gouget 14 Jun '12

14 Jun '12

The DllMain() function in ntoskrnl.exe appears to be unused: making it static causes a compiler warning to that effect and removing it entirely does not cause a compilation failure. Should it be removed or is there a build issue with ntoskrnl.exe? diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 2b84297..ffeb2f8 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1711,30 +1711,6 @@ VOID WINAPI IoInitializeRemoveLockEx(PIO_REMOVE_LOCK lock, ULONG tag, } /***************************************************** - * DllMain - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - static void *handler; - LARGE_INTEGER count; - - switch(reason) - { - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); -#ifdef __i386__ - handler = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); -#endif - KeQueryTickCount( &count ); /* initialize the global KeTickCount */ - break; - case DLL_PROCESS_DETACH: - RtlRemoveVectoredExceptionHandler( handler ); - break; - } - return TRUE; -} - -/***************************************************** * Ke386IoSetAccessProcess (NTOSKRNL.EXE.@) */ BOOLEAN WINAPI Ke386IoSetAccessProcess(PEPROCESS *process, ULONG flag) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

2 1

Re: [11/11] windowscodecs: Implement GetMetadataFormat. Resend.
by Dmitry Timoshkov 14 Jun '12

14 Jun '12

Please ignore this patch, it doesn't really belong to this series, and correct implementation should use MetadataReaderInfo interface instead. -- Dmitry.

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19010 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19009 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] windowscodecs: Add test for IWICMetadataReaderInfo.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19007 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19006 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.
by Nikolay Sivov 13 Jun '12

13 Jun '12

On 6/12/2012 11:52, Ulrik Dickow wrote: > Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; > + > + VARIANT var; > + HRESULT hr; > + BSTR str; > + > + /* create on element and try to alter namespace after that */ > + doc = (doc_version == 0 ? > + create_document(&IID_IXMLDOMDocument) : > + create_document_version(60, &IID_IXMLDOMDocument)); > + if (!doc) return; Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples for that in saxreader.c. > + test_namespaces_change(0); > + test_namespaces_change(60); > > free_bstrs(); > } It's better to avoid nested test calls like that imho, you could just add another call in main test list. > +static void test_namespaces_change(int doc_version) > +{ > + IXMLDOMDocument *doc; > + IXMLDOMElement *elem; > + IXMLDOMNode *node; ... > + > + IXMLDOMElement_Release(elem); > + IXMLDOMDocument_Release(doc); > +} > + When this is running on all CLSIDs please add free_bstrs() here.

3 4

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1
by Matteo Bruni 13 Jun '12

13 Jun '12

2012/6/12 Nozomi Kodama <nozomi.kodama(a)yahoo.com>: > > + if ( (pq->w >= 1.0f) || (pq->w == -1.0f) ) I think the second comparison should be '<=', if you want to avoid getting NaNs.

2 2

Re: wined3d: Avoid sizeof on structs with variable length arrays.
by Henri Verbeet 13 Jun '12

13 Jun '12

On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat stupid array of size 1.

2 2

Misspelt Portuguese in msvcrt
by Francois Gouget 13 Jun '12

13 Jun '12

Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = "german-swiss", "des", "italian-swiss", "its", "german-austrian", "dea", - "portugese", "ptb", + "portuguese", "ptb", "portuguese-brazil", "ptb", "spanish-mexican", "esm", "norwegian-bokmal", "nor", diff --git a/dlls/msvcrt/tests/locale.c b/dlls/msvcrt/tests/locale.c index 8d6a34f..638a3d2 100644 --- a/dlls/msvcrt/tests/locale.c +++ b/dlls/msvcrt/tests/locale.c @@ -472,7 +472,7 @@ static void test_setlocale(void) if(ret) ok(!strcmp(ret, "Polish_Poland.1250"), "ret = %s\n", ret); - ret = setlocale(LC_ALL, "portugese"); + ret = setlocale(LC_ALL, "portuguese"); ok(ret != NULL || broken (ret == NULL), "ret == NULL\n"); if(ret) ok(!strcmp(ret, "Portuguese_Brazil.1252"), "ret = %s\n", ret); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ E-Voting: Those who cast the votes decide nothing. Those who count the votes decide everything.

2 1

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).
by Jacek Caban 13 Jun '12

13 Jun '12

Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control, the search is a > now a binary search, and some additional cleanup. It is important to > note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. Many > apologizes to Jacek Caban for missing some of his comments in his > original reply. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. The patch looks much better. There is one remaining problem: + int pos = sizeof(html_encoded_symbols)/sizeof(html_encoded_symbols[0]); + float step = pos/2; + int dir = +1; + + do + { + const char *encoded_symbol; + + pos += -dir*ceil(step); Using float here is definitely not needed, esp. that you always use ceil() on it. You've made it more complicated than it really is. See [1] for an example. Also feel free to send linear search with FIXME comment. That's fine for the first iteration patch. Jacek [1] http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/dispex.c#l709

1 0

Re: [11/11] windowscodecs: Implement GetMetadataFormat.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:530: Test failed: 20: expected count 3, got 4 metadata.c:531: Test failed: 20: expected abc, got abcd

1 0

Re: [10/11] windowscodecs: Handle IFD fields with count 0 same way as with count 1.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18988 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:505: Test failed: 20: expected count 3, got 4 metadata.c:506: Test failed: 20: expected abc, got abcd

1 0

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:497: Test failed: 20: expected count 3, got 4 metadata.c:498: Test failed: 20: expected abc, got abcd

1 0

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.
by Marvin 13 Jun '12

13 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid android. === W7PRO (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (32 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === W7PROX64 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd === TEST64_W7SP1 (64 bit metadata) === metadata.c:494: Test failed: 20: expected count 3, got 4 metadata.c:495: Test failed: 20: expected abc, got abcd

1 0

Re: po: Update Russian translation (try 3) (resend)
by Francois Gouget 13 Jun '12

13 Jun '12

msgid "KeyID=" -msgstr "Код ключа=" +msgstr "Код ключа: " [...] msgid "Other Name=" -msgstr "Другое имя=" +msgstr "Альтернативное имя: " and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen anything to suggest that the typographic rules would be different in this regard. But Nikolay Sivov, who speaks Russian, seems to concur. Note that this was reported to you back in May: http://www.winehq.org/pipermail/wine-devel/2012-May/095672.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.
by Stefan Dösinger 12 Jun '12

12 Jun '12

Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: > + if (state->vertex_shader->reg_maps.input_registers & (1 << i)) > + GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific behavior here that pretty much matches their GL counterparts.

1 0

re: Command line parameters
by Dan Kegel 12 Jun '12

12 Jun '12

John asked > [ How do I launch Windows apps from Unix apps and pass filenames to them?] > execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate command_line_parameter_for_windows_app, and any paths that appear in data files, from Unix to Windows before launching the app. The winepath utility may help there, or you can translate them yourself once you know how Wine maps filenames. Also, I recall being in a situation where I had to put the commandline in a batch file and do wine cmd.exe /c foo.bat because there wasn't another other way to make the windows app happy... something about the commandline that made me need to use CreateProcess, and cmd.exe was the easiest way to use CreateProcess. - Dan

5 10

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).
by Jacek Caban 12 Jun '12

12 Jun '12

Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying international characters in some CHM files. With this > version of the patch the decoding is done manually by parsing the HTML > characters instead of using the web browser control. It is important > to note that HTML Help only supports characters within the ANSI code > pages, so support for multi-byte characters is not necessary. > > Changelog: > hhctrl.ocx: Add HTML to Unicode decoding capability. You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. Jacek

2 1

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)
by Alexandre Julliard 12 Jun '12

12 Jun '12

André Hentschel <nerv(a)dawncrow.de> writes: > Inspired by Matias Colli, see bug 17896. > I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that cups-config requires. It sounds like OpenBSD should fix their libcups build. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped
by Alexandre Julliard 12 Jun '12

12 Jun '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) > { > HANDLE mi; > > - > SetLastError(0xdeadbeef); > pPSetupDestroyMonitorInfo(NULL); > - /* lasterror is returned */ > - trace("returned with %u\n", GetLastError()); > + /* lasterror is untouched */ > + ok(GetLastError() == 0xdeadbeef, "returned with 0x%x\n", GetLastError()); Testing last error on success is not useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin 12 Jun '12

12 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] loader: On Mac OS, don't use external symbols for the DOS and shared heap segments.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Charles Davis <cdavis(a)mymail.mines.edu> writes: > My first idea was to just add some '.globl' directives in the code. But > then I asked myself: why are we using an indirect symbol at all? Why are > we treating this like an external symbol when it clearly isn't? So now, > the arrays are declared static, and their owning section is explicitly > declared to the C compiler. While compile times have gone up, at least > the compiled loader executable actually works. This core dumps instantly when build with gcc on Mac OS 10.5, and doesn't even compile on 10.6. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] winspool: Install the ppd files into the driver directory.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Huw Davies <huw(a)codeweavers.com> writes: > @@ -488,18 +638,70 @@ static void *cupshandle; > DO_FUNC(cupsGetPPD); \ > DO_FUNC(cupsParseOptions); \ > DO_FUNC(cupsPrintFile); > +#define CUPS_OPT_FUNCS \ > + DO_FUNC(cupsGetPPD3); > > #define DO_FUNC(f) static typeof(f) *p##f > CUPS_FUNCS; > +CUPS_OPT_FUNCS; > #undef DO_FUNC This still requires the function to be defined: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SPOOL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/local/include/freetype2 -I/usr/local/include -g -O2 -o info.o info.c info.c:732: error: 'cupsGetPPD3' undeclared here (not in a function) info.c:732: warning: type defaults to 'int' in declaration of 'pcupsGetPPD3' info.c: In function 'cupsGetPPD3_wrapper': info.c:741: error: called object 'pcupsGetPPD3' is not a function info.c: In function 'get_cups_ppd': info.c:771: error: 'CUPS_HTTP_DEFAULT' undeclared (first use in this function) info.c:771: error: (Each undeclared identifier is reported only once info.c:771: error: for each function it appears in.) make[1]: *** [info.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: po: Update Russian translation (try 3) (resend)
by Nikolay Sivov 11 Jun '12

11 Jun '12

On 6/9/2012 07:43, Oleg Yarigin wrote: > To avoid encode breaks I send a patch as an attachment. > > I packed it into *.GZ archive, becouse (I suppose so) some > intermediate servers can block messages with big attachments. > > Please split it to several patches with changes grouped by some criteria, it's really hard to review when it's that long.

1 0

Re: po: Update Italian translation
by Matteo Bruni 11 Jun '12

11 Jun '12

Hi Luca, just a couple of nitpicks: -"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a href=" -"\"http://wiki.winehq.org/Gecko\">http://wiki.winehq.org/Gecko</a> per i " -"dettagli." +"Nota: è raccomandato usare i pacchetti delle distribuzioni. Leggi <a " +"href=\"http://wiki.winehq.org/Mono\">http://wiki.winehq.org/Mono</a> " +"per i dettagli." This sounds a bit awkward, I'd go for something like "Nota: si raccomanda di usare i pacchetti forniti dalla tua distribuzione." #: cryptui.rc:413 -#, fuzzy -#| msgid "&Personal Information Exchange/PKCS #12 (.pfx)" msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "Scambia di Informazioni &Personali/PKCS #12 (.pfx)" +msgstr "Scambia di Informazioni &Personali/PKCS #12 (*.pfx)" "Scambio". #: joy.rc:33 msgid "Joysticks" -msgstr "" +msgstr "Joysticks" I'm quite sure foreign words are always wrote in singular form in Italian language, so this would be "Joystick".

1 0

Re: [1/4] msi: Add support for 64-bit registry components. (resend)
by Marvin 11 Jun '12

11 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18942 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/4] kernel32/tests: Move a cdrom test to its own file
by Alexandre Julliard 11 Jun '12

11 Jun '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > The cdrom test file will be used to test ioctl (results, structure size...) > Each drive is tested and skipped gracefully if ioctl not supported or not a CDROM drive. I don't see a need for a new file, particularly since disk extents are not CDROM-specific. But even DVD ioctls can be tested in volume.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Alexandre Julliard 11 Jun '12

11 Jun '12

Andrew Eikum <aeikum(a)codeweavers.com> writes: > There's a lengthy comment in ready_pulse() describing why we're using > pthreads syncro primitives instead of Win32 primitives. I was under > the impression (thanks to the CoreAudio driver, mostly) that threads > not created through CreateThread() cannot use CRITICAL_SECTION, ERR, > WARN, TRACE, and so on. However, when I was testing, I noticed that > debug printing _does_ work in callbacks from the pthread thread. You can't do that, you need to create a proper Win32 thread, and solve the loader lock issue some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] loader: On Mac OS, don't emit a __PAGEZERO segment.
by Alexandre Julliard 11 Jun '12

11 Jun '12

Charles Davis <cdavis(a)mymail.mines.edu> writes: > This is the reason we couldn't put the WINE_DOS segment at address 0. We don't need page zero, we don't run DOS apps on the Mac. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2 resend] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin 11 Jun '12

11 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18940 Your paranoid android. === W2K8SE (32 bit http) === http.c:533: Test failed: req_error = 12007 http.c:544: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:533: Test failed: req_error = 12007 http.c:557: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:558: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:559: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:560: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:562: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:569: Test failed: flags = 8, expected 0 http.c:583: Test failed: Wrong URL http://test.winehq.org/tests/redirect http.c:657: Test failed: Returned zero size in response to request complete http.c:269: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:269: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED)

1 0

Re: [PATCH] winepulse.drv: Add PulseAudio driver
by Dmitry Timoshkov 11 Jun '12

11 Jun '12

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > configure.ac | 31 +- > dlls/mmdevapi/main.c | 4 +- > dlls/winepulse.drv/Makefile.in | 9 + > dlls/winepulse.drv/mmdevdrv.c | 3216 +++++++++++++++++++++++++++++++++ > dlls/winepulse.drv/winepulse.drv.spec | 5 + > 5 files changed, 3261 insertions(+), 4 deletions(-) > create mode 100644 dlls/winepulse.drv/Makefile.in > create mode 100644 dlls/winepulse.drv/mmdevdrv.c > create mode 100644 dlls/winepulse.drv/winepulse.drv.spec How does it follow the Alexandre's requirement to split the patch into smaller pieces before submitting? -- Dmitry.

1 0

Re: [PATCH] kernel32: Don't use putenv(3) on temporary strings.
by Ken Thomases 10 Jun '12

10 Jun '12

The putenv() calls occur in a forked grandchild process just before an exec(). The strings are sure to survive the current process image. After that, it's the kernel's problem. Regards, Ken On Jun 10, 2012, at 11:47 AM, Charles Davis wrote: > The Darwin manpage for putenv() warns that it no longer makes a copy of > its input, but directly stores the pointer in environ. Wine was passing > stack- and heap-allocated strings to putenv(), which could have caused a > crash. We were very lucky it didn't. Instead, use setenv(3), which still > copies its inputs. > > Found while tracking down an insidious bug in Clang-built optimized > (-O2) Wine. > --- > dlls/kernel32/process.c | 24 +++++++++++------------- > 1 files changed, 11 insertions(+), 13 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 42716c2..1ec3e3d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1741,17 +1741,14 @@ static const char *get_alternate_loader( char **ret_env ) > int len = strlen( loader_env ); > if (!is_win64) > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len + 2 ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len + 2 ))) return NULL; > + strcpy( env, loader_env ); > strcat( env, "64" ); > } > else > { > - if (!(env = HeapAlloc( GetProcessHeap(), 0, sizeof("WINELOADER=") + len ))) return NULL; > - strcpy( env, "WINELOADER=" ); > - strcat( env, loader_env ); > - len += sizeof("WINELOADER=") - 1; > + if (!(env = HeapAlloc( GetProcessHeap(), 0, len ))) return NULL; > + strcpy( env, loader_env ); > if (!strcmp( env + len - 2, "64" )) env[len - 2] = 0; > } > if (!loader) > @@ -1860,14 +1857,14 @@ static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, > /* Reset signals that we previously set to SIG_IGN */ > signal( SIGPIPE, SIG_DFL ); > > - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); > - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", > + sprintf( socket_env, "%u", socketfd ); > + sprintf( preloader_reserve, "%lx-%lx", > (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); > > - putenv( preloader_reserve ); > - putenv( socket_env ); > - if (winedebug) putenv( winedebug ); > - if (wineloader) putenv( wineloader ); > + setenv( "WINESERVERSOCKET", socket_env, 1 ); > + setenv( "WINEPRELOADRESERVE", preloader_reserve, 1 ); > + if (winedebug) setenv( "WINEDEBUG", winedebug, 1 ); > + if (wineloader) setenv( "WINELOADER", wineloader, 1 ); > if (unixdir) chdir(unixdir); > > if (argv) > @@ -1976,6 +1973,7 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW > static const WCHAR WINEDEBUG[] = {'W','I','N','E','D','E','B','U','G','=',0}; > if (!winedebug && !strncmpW( env_end, WINEDEBUG, sizeof(WINEDEBUG)/sizeof(WCHAR) - 1 )) > { > + env_end += sizeof(WINEDEBUG)/sizeof(WCHAR) - 1; > DWORD len = WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, NULL, 0, NULL, NULL ); > if ((winedebug = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_UNIXCP, 0, env_end, -1, winedebug, len, NULL, NULL ); > -- > 1.7.5.4 > > >

1 0

Re: [PATCH 4/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdCopyrightDescriptor) test
by Marvin 10 Jun '12

10 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18927 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:85: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 3/4] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test
by Marvin 10 Jun '12

10 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18926 Your paranoid android. === W2KPROSP4 (32 bit cdrom) === cdrom.c:84: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 87

1 0

Re: [PATCH 1/5] hhctrl.ocx: Add HTML to Unicode parsing capability.
by Jacek Caban 10 Jun '12

10 Jun '12

Hi Erich, On 06/07/12 23:09, Erich E. Hoover wrote: > + /* Post the HTML text to the document */ > + array = SafeArrayCreateVector(VT_VARIANT, 0, 1); > + if(!array) > + goto cleanup; > + hr = SafeArrayAccessData(array, (LPVOID*)&array_param); > + if (FAILED(hr)) > + goto cleanup; > + V_VT(array_param) = VT_BSTR; > + V_BSTR(array_param) = SysAllocString(html_fragment); > + hr = SafeArrayUnaccessData(array); > + if (FAILED(hr)) > + goto cleanup; > + hr = IHTMLDocument2_write(html_parsing_doc, array); Did you test indexes like '<script>alert("really!?")</script>' ? :) Seriously, HTMLDocument is not the right tool for the job. Cheers, Jacek

2 4

Re: Patch 1/2 - [scrrun] - Add initial support for Dictionary - try 2
by Jacek Caban 10 Jun '12

10 Jun '12

Hi Vijay, On 06/08/12 03:15, Vijay Kiran Kamuju wrote: > + *ppvObject = NULL; > + if ( IsEqualGUID( riid, &IID_IDictionary ) || > + IsEqualGUID( riid, &IID_IPersist ) || > + IsEqualGUID( riid, &IID_IDispatch ) || > + IsEqualGUID( riid, &IID_IUnknown ) ) > + { > + *ppvObject = This; > + } That's not the right way to cast object to interface. See http://wiki.winehq.org/COMGuideline Cheers, Jacek

2 2

joy.cpl icon
by Joel Holdsworth 10 Jun '12

10 Jun '12

Hi All, I've just submitted an icon for joy.cpl to wine-patches. Unfortunatly I've uncovered a problem with the buildimage script. When I first wrote the script, I used the "rsvg" command to convert svg to png. rsvg has been depreciated in favour of rsvg-convert, which has slightly different semantics: rsvg-convert in.svg > out.png instead of rsvg in.svg out.png Moving over to rsvg-convert is trivial of course, except one question. Is it present on enough platforms? I'm using Ubunut 12.04. Is maintainer mode meant to work on Debian Squeeze? We could support both, but I'd rather not do that. Joel

2 1

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.
by Dan Kegel 08 Jun '12

08 Jun '12

-#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that an undefined symbol was treated as false by the preprocessor. When I compile #if defined(HAVE_SYS_SYSCTL_H) && defined(IPCTL_STATS) && (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) defined #else not defined #endif with gcc -E or cl /E, I get not defined

3 4

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Alexandre Julliard 08 Jun '12

08 Jun '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/tests/Makefile.in | 2 +- > dlls/wininet/tests/http.c | 38 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:3020: Test failed: InternetGetSecurityInfoByURLA returned: 1(12028), exected 12028 http.c:3153: Test failed: InternetGetSecurityInfoByURLA returned: 1(997), exected 12028 make[1]: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] wininet: Added InternetGetSecurityInfoByURL tests
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18903 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3293: Test failed: HttpSendRequest failed: 12002

2 1

Re: msxml3: Implement IXMLParser Get/Set Flags
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18891 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 4/4] mshtml: Added IWindowForBindingUI tests
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18890 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration. Resend.
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18888 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Re: Patch 2/2 - [scrrun] - Add initial tests for Dictionary - resend
by Marvin 08 Jun '12

08 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18875 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/1] shell32: Fix FindExecutable search path when a default directory is supplied.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18869 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\System32\notepad.exe] === W2KPROSP4 (32 bit shlexec) === shlexec.c:1336: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe] shlexec.c:1342: Test failed: FindExecutable(notepad.exe) returned command=[C:\WINNT\system32\notepad.exe]

1 0

Re: [4/5] propsys: Implement IPropertyStoreCache::SetState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/5] propsys: Implement IPropertyStoreCache::GetValueAndState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18852 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] propsys: Implement IPropertyStoreCache::GetState.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18851 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.
by Vincent Povirk 07 Jun '12

07 Jun '12

It should be trivial to implement this correctly. On Wed, Jun 6, 2012 at 11:21 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index 013fe04..0ea404b 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -152,7 +152,8 @@ static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface, > if (!pcCount) return E_INVALIDARG; > > FIXME("(%p,%p): stub\n", iface, pcCount); > - return E_NOTIMPL; > + *pcCount = 0; > + return S_OK; > } > > static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface, > -- > 1.7.10.1 > > >

2 1

Re: [PATCH 1/7] urlmon: Use file content to verify MIME type reported by file protocol handler
by Jacek Caban 07 Jun '12

07 Jun '12

On 06/07/12 15:40, Jacek Caban wrote: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) > Please skip this one. I didn't mean to send it in the series. Thanks, Jacek

1 0

Re: mscoree: Use .NET 2.0 for 1.0 assemblies
by Vincent Povirk 07 Jun '12

07 Jun '12

I was planning to do something like this eventually, as I was advised on #mono this was the way to go, but I didn't expect it to be that simple. +1. On Thu, Jun 7, 2012 at 4:27 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Mono will use .NET 2.0 when a .NET 1.0/1.1 application is run. > > http://www.mono-project.com/Release_Notes_Mono_2.8 > Find: Removed .NET 1.1 Profile > > > Changelog: > mscoree: Use .NET 2.0 for 1.0 assemblies > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

Re: po: Update Russian translation (try 2)
by Nikolay Sivov 07 Jun '12

07 Jun '12

On 6/5/2012 11:16, Архад wrote: Please, configure your mail client to use your real name in sent mails. > > #: appwiz.rc:28 > msgid "Add/Remove Programs" > -msgstr "Установка/удаление программ" > +msgstr "Установка/Удаление программ" Looks better as it is. Only start letter of a sentence supposed to be capital, if it's not a part of some name of course, which is not in this case. > > > #: appwiz.rc:35 shell32.rc:141 shell32.rc:238 regedit.rc:122 winefile.rc:104 > msgid "Name" > -msgstr "Имя" > +msgstr "Название" I don't think so. > > > > #: appwiz.rc:39 > msgid "Programs (*.exe)" > -msgstr "Программы (*.exe)" > +msgstr "Исполняемые файлы (*.exe)" No reason for that. > > #: appwiz.rc:40 avifil32.rc:30 cryptui.rc:80 shell32.rc:196 notepad.rc:73 > #: oleview.rc:101 progman.rc:79 regedit.rc:195 winedbg.rc:39 winhlp32.rc:87 > @@ -248,7 +247,7 @@ msgid "" > "file." > msgstr "" > "Ошибка контрольной суммы загруженного файла. Установка поврежденного файла " > -"отменяется." > +"будет отменена." English string doesn't say that it 'will be aborted', it says 'aborting' which means it's already in process to abort it. > > > > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" It's better as it is. > > #: comdlg32.rc:160 comdlg32.rc:182 > msgid "List Files of &Type:" > -msgstr "Показывать файлы &типа:" > +msgstr "&Тип файлов:" This doesn't reflect original meaning. > > > > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" String length matters for this dialog as I remember. > > > > #: comdlg32.rc:315 comdlg32.rc:336 > msgid "Match &Whole Word Only" > @@ -817,20 +816,18 @@ msgid "" > "File does not exist.\n" > "Do you want to create file?" > msgstr "" > -"Файла не существует.\n" > -"Хотите ли вы его создать?" > +"Файла не существует. Создать?" This supposed to match original line splitting probably. > > > #: comdlg32.rc:68 > msgid "Unknown printer driver." > -msgstr "Неизвестный драйвер принтера." > +msgstr "Неопознанный драйвер принтера." This sounds like 'unknown' from UFO now. > > #: crypt32.rc:55 > msgid "On-line Certificate Status Protocol" > @@ -1371,7 +1367,7 @@ msgstr "Имя SSL-сервера Netscape" > > #: crypt32.rc:67 > msgid "Netscape Comment" > -msgstr "Комментарий Netscape" > +msgstr "Комментарии Netscape" Original word is in singular. ... I'm skipping the rest as it's too much to comment at once, but I think you got the idea how to improve that. Also winerror strings should be left as it is, cause nobody cares much anyway. And please pay attention to actual dialog testing, cause updated strings should fit in.

1 0

Re: Command line parameters
by Hin-Tak Leung 07 Jun '12

07 Jun '12

--- On Thu, 7/6/12, John Emmas <johne53(a)tiscali.co.uk> wrote: <snipped> > Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. > John "Use the source, Luke!"... THe relevant code is in dlls/ntdll/file.c and dlls/ntdll/path.c which do the right thing. As a general windows programming note, in windows' land, file path related WIN32 APIs tend to have two variants, those ending with *A, and those ending with *W. The former expects ascii inputs, the latter expects WCHAR (I think it is basically UT16LE). The long answer is that wine leaves the former unchanged (except path separator translation, e.g. from unix "/" to windows "\", adding or removing drive letter prefixes, depending on the direction of translation), but will convert from utf8 to WCHAR for the latter, so that the application itself receives the right thing. It is still up to the application's author to use the right Windows APIs for reading/writing files, and whether the application itself expects ascii file paths or unicode (WCHAR) file paths. The short answer is that wine *does* translate from unix-like to windows-like file paths so that the application receives the right stuff. You have nothing to worry about.

2 1

Command line parameters
by John Emmas 07 Jun '12

07 Jun '12

Originally, I was going to post this on wine-users but after I wrote it, it seemed like wine-devel might be more appropriate. Please let me know if I need to re-submit it to wine-users. I understand that Wine is mostly used for running Windows apps on Linux - i.e. in most cases, the user will be launching the Windows app manually. But what about a Linux application that needs to launch a Windows app? What does Wine do (if anything) about command-line parameters..? After using fork() to create a new process, this would be a typical program command to start Wine and the Windows app:- execl (the_path_to_wine, "wine", path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Notice that execl() passes two command-line parameters to Wine (one of which gets passed to the Windows app). Let's assume this is a file path as that's easy to visualize. In the vast majority of cases, those command-line parameters will get passed to Wine as UTF8 strings. Wine will hopefully understand this when interpreting 'path_to_the_windows_program'. However, Windows programs themselves don't understand UTF8 at all - except for a very limited set of (mostly English) characters. So if that parameter was a file path (e.g. a file that the Windows program needed to open) it would only get understood in an English speaking locale. Non-English characters (accented characters etc) would only get understood if a locale translation takes place. Is Wine clever enough to realise that the UTF8 string needs to be converted to a locale-specific string, so that the Windows app can understand it? Or does Wine simply pass whatever characters it received, without attempting any translation? Thanks. John

1 0

Re: [4/4] windowscodecs: Add WICIfdMetadataReader registration.
by Marvin 07 Jun '12

07 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18837 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 2

re: comctl: allow label edit only if treeview style allows editing
by Dan Kegel 06 Jun '12

06 Jun '12

> I stopped doing > make test on my machine some time ago Bad developer, no donut :-) > , when I found out that some > tests do consistently fail on my machine (clean prefix or not), and > others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to skip the bad tests. It was written for buildbot, but can be run standalone. Try downloading http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh and http://winezeug.googlecode.com/svn/trunk/buildbot/dotests_blacklist.txt then run sh dotests.sh goodtests That will skip all the tests known to hang or fail. (The list might be a bit out of date, but it's easy to add new tests to the blacklist.) > I don't install wine-gecko, maybe that's the reason. Run https://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh then you'll never have to install it again. (Until it's updated, anyway.) - Dan

2 1

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Alexandre Julliard 06 Jun '12

06 Jun '12

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/file.c | 8 +++++++- > dlls/urlmon/tests/protocol.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2447: Test failed: expected ReportProgress_MIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE protocol.c:2445: Test failed: expected ReportProgress_VERIFIEDMIMETYPEAVAILABLE etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

1.4 has dropped off the list for AppDB submissions
by Rosanne DiMesio 06 Jun '12

06 Jun '12

As of the release of 1.5.5, 1.4 has dropped off the list of Wine versions for which AppDB test reports can be submitted. Can someone please add it to the list of stable releases that are always available in the dropdown list? Until it's put back, users will not be able to submit new test reports for 1.4. We could avoid having this problem every time there's a new stable release if users were allowed to submit test reports for any version. Bugzilla lists every version, I don't see why the AppDB doesn't. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 2

Re: [PATCH 2/3] server: STATUS_MORE_PROCESSING_REQUIRED does not indicate that an async operation is complete (try 4).
by Alexandre Julliard 06 Jun '12

06 Jun '12

"Erich E. Hoover" <compholio(a)gmail.com> writes: > @@ -285,7 +285,9 @@ void async_set_result( struct object *obj, unsigned int status, unsigned int tot > if (async->timeout) remove_timeout_user( async->timeout ); > async->timeout = NULL; > async->status = status; > - if (async->data.cvalue) > + if (status == STATUS_MORE_PROCESSING_REQUIRED) > + async->status = STATUS_PENDING; > + else if (async->data.cvalue) Why are you marking the async pending? That doesn't seem right, it's terminated at that point. -- Alexandre Julliard julliard(a)winehq.org

2 1

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
by Dan Kegel 06 Jun '12

06 Jun '12

http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. (I've also deprecated the copy that was in winezeug; that one now just tells users to get it from the winetricks repo.)

11 20

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader to TIFF decoder.
by Vincent Povirk 06 Jun '12

06 Jun '12

Looks good. Here are some notes in case you get around to implementing this before I do: I found it very surprising that no metadata handlers seem to implement IWICMetadataBlockReader, while many of them advertise that they can be found in other metadata formats. I'm guessing that metadata handlers return child IWICMetadataReader objects from the IWICMetadataReader interface, but I haven't tested this. It probably doesn't make sense to reimplement GetEnumerator for each decoder, and we should be able to make a common implementation based on the other methods. We should probably implement GetReaderByIndex based on CreateMetadataReaderFromContainer, which I'm guessing expects a copy of the image stream (using IWICStream because we can't use IStream::Clone) seeked to the beginning of some metadata, or a region of the image stream, maybe depending on the container format.

1 0

Re: urlmon: Use file content to verify MIME type reported by file protocol handler
by Marvin 06 Jun '12

06 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18815 Your paranoid android. === WXPPROSP3 (32 bit protocol) === protocol.c:1046: Test failed: unexpected call ReportResult protocol.c:1051: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2838: Test failed: Read failed: 00000001

2 1

Re: [2/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region. Take 2.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > This version of the test tries harder to avoid races that could cause > the test failures. It's not races, it's failing consistently here, even with your latest version. I don't think you can reliably test expose events processing from a Windows app. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] shell32: do not crash "wine control.exe nonexisting"
by Jacek Caban 06 Jun '12

06 Jun '12

Hi Marcus, On 06/06/12 10:17, Marcus Meissner wrote: > Hi, > > wine control.exe joy crashed in this line, as it should be wine control.exe joy.cpl. > > The list is just not setup yet as we fail... > > Ciao, Marcus > --- > dlls/shell32/control.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c > index cb080d5..b3eddb6 100644 > --- a/dlls/shell32/control.c > +++ b/dlls/shell32/control.c > @@ -55,7 +55,7 @@ void Control_UnloadApplet(CPlApplet* applet) > } > if (applet->proc) applet->proc(applet->hWnd, CPL_EXIT, 0L, 0L); > FreeLibrary(applet->hModule); > - list_remove( &applet->entry ); > + if (applet->entry.next) list_remove( &applet->entry ); > HeapFree(GetProcessHeap(), 0, applet->cmd); > HeapFree(GetProcessHeap(), 0, applet); > } The way Wine standard list implementation works, it should not be NULL here. It seems that list_init call is missing where the CPlApplet is allocated. Cheers, Jacek

3 6

Re: [PATCH 3/5] d3drm: Handle texture associated with the materail when loading a mesh.
by Alexandre Julliard 06 Jun '12

06 Jun '12

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3drm/meshbuilder.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M d3drm.dll -T ../../.. -p d3drm_test.exe.so d3drm.c && touch d3drm.ok d3drm.c:375: Test failed: No texture should be present wine: Unhandled page fault on write access to 0x00162708 at address 0x68353cb7 (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/action.c | 30 +++++++--- > dlls/msi/msi_main.c | 1 + > dlls/msi/msipriv.h | 1 + > dlls/msi/package.c | 2 - > dlls/msi/tests/install.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 162 insertions(+), 12 deletions(-) This breaks the Gecko installer on 64-bit for me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/2] user32: Add a test to demonstrate the z-order problem for a top level window with a region.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/user32/tests/win.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so ../../../../wine/dlls/user32/tests/win.c && touch win.ok win.c:7111: Test succeeded inside todo block: expected next window 0x400ea, got 0x400ea win.c:7114: Test succeeded inside todo block: expected previous window 0x400f0, got 0x400f0 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] server: Make sure that region and rectangle have the same origin before calling rect_in_region().
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2457,7 +2457,9 @@ DECL_HANDLER(update_window_zorder) > if (!(ptr->style & WS_VISIBLE)) continue; > if (ptr->ex_style & WS_EX_TRANSPARENT) continue; > if (!intersect_rect( &tmp, &ptr->visible_rect, &rect )) continue; > - if (ptr->win_region && !rect_in_region( ptr->win_region, &rect )) continue; > + tmp = rect; > + offset_rect( &tmp, -ptr->client_rect.left, -ptr->client_rect.top ); > + if (ptr->win_region && !rect_in_region( ptr->win_region, &tmp )) continue; The window region is not in client coordinates. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Use NAN.
by Ruslan Kabatsayev 05 Jun '12

05 Jun '12

Hello, This patch stops wine from building on my system with following errors: In file included from arb_program_shader.c:35:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from device.c:32:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from ati_fragment_shader.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from context.c:27:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from directx.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) In file included from gl_compat.c:26:0: wined3d_private.h: In function ‘float_16_to_32’: wined3d_private.h:203:21: error: ‘NAN’ undeclared (first use in this function) wined3d_private.h:203:21: note: each undeclared identifier is reported only once for each function it appears in wined3d_private.h: In function ‘float_24_to_32’: wined3d_private.h:225:21: error: ‘NAN’ undeclared (first use in this function) make[1]: *** [ati_fragment_shader.o] Error 1 Regards, Ruslan On Wed, May 30, 2012 at 6:14 PM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > --- > dlls/wined3d/drawprim.c | 2 ++ > dlls/wined3d/utils.c | 2 ++ > dlls/wined3d/wined3d_private.h | 4 ++-- > 3 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c > index 2e30175..c8944e5 100644 > --- a/dlls/wined3d/drawprim.c > +++ b/dlls/wined3d/drawprim.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d_draw); > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index dc63d8b..f8f301a 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -25,6 +25,8 @@ > */ > > #include "config.h" > +#include "wine/port.h" > + > #include "wined3d_private.h" > > WINE_DEFAULT_DEBUG_CHANNEL(d3d); > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 096fe60..6632f6e 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -200,7 +200,7 @@ static inline float float_16_to_32(const unsigned short *in) { > return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); > } else { > if(m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > @@ -222,7 +222,7 @@ static inline float float_24_to_32(DWORD in) > else > { > if (m == 0) return sgn / 0.0f; /* +INF / -INF */ > - else return 0.0f / 0.0f; /* NAN */ > + else return NAN; > } > } > > -- > 1.7.3.4 > > >

2 2

Re: [PATCH 5/5] d3dcompiler: Parse variable declarations.
by Stefan Dösinger 05 Jun '12

05 Jun '12

Am Montag, 4. Juni 2012, 17:58:24 schrieb Matteo Bruni: > +struct hlsl_type > +{ > ... > + unsigned int dimx; > + unsigned int dimy; > ... > +}; One thing I noticed when I wrote my compiler was that a float1x1 is not the same as a float1 or float. I did not implement this difference nor do I know if any games depend on it. (That's no reason to hold up this patch, just something to keep in mind for further work)

3 4

Re: [4/5] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.
by Marvin 05 Jun '12

05 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18792 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [1/5] msi: Add support for 64-bit registry components.
by Marvin 05 Jun '12

05 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18791 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6053: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: oleaut32: Add a test for BSTR cache. Take 3.
by Alexandre Julliard 05 Jun '12

05 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > + for (i = 0; i < sizeof(bstr)/sizeof(bstr[0]); i++) > + { > + INTERNAL_BSTR *data = Get(bstr[i]); > + > + for (j = 0; j < i; j++) str[j] = '0' + i % 10; > + > + if (data->dwLen == i * sizeof(WCHAR)) > + good_length_entries++; > + if (!memcmp(data->szString, str, i * sizeof(WCHAR))) > + good_string_entries++; > + } > + > + trace("good_length_entries %d, good_string_entries %d\n", good_length_entries, good_string_entries); > + ok(good_length_entries >= 95, "good_length_entries %d out of 256\n", good_length_entries); > +todo_wine > + ok(good_string_entries >= 190, "good_string_entries %d out of 256\n", good_string_entries); That doesn't seem very useful. What use case would there be for an app to rely on some random 75% of its strings to remain valid? -- Alexandre Julliard julliard(a)winehq.org

3 6

Wine in Humble Indie Bundle
by Dan Kegel 04 Jun '12

04 Jun '12

I see the Humble Indie Bundle includes a game ported via wine, http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. So I put together a pro-wine petition: http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi… How's that look? If you agree with it, please sign and forward to your friends. Thanks, Dan

5 5

Re: [PATCH 1/2] joystick.cpl: First version of the joystick configuration applet
by Alexandre Julliard 04 Jun '12

04 Jun '12

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > This adds a control panel applet to configure the joysticks. It is > a property sheet and has 3 pages: > > * Joystick listing > * Axes and Button Testing > * Force Feedback testing > > All the function are stubs at the moment, the panel has no icon too. > > --- > configure.ac | 1 + > dlls/joystick.cpl/Makefile.in | 14 +++ > dlls/joystick.cpl/forcefeedback.c | 60 +++++++++++ > dlls/joystick.cpl/joystick.cpl.spec | 3 + > dlls/joystick.cpl/joystick.h | 63 ++++++++++++ > dlls/joystick.cpl/joystick.rc | 55 ++++++++++ > dlls/joystick.cpl/list.c | 57 +++++++++++ > dlls/joystick.cpl/main.c | 191 +++++++++++++++++++++++++++++++++++ > dlls/joystick.cpl/test.c | 60 +++++++++++ > 9 files changed, 504 insertions(+) > create mode 100644 dlls/joystick.cpl/Makefile.in > create mode 100644 dlls/joystick.cpl/forcefeedback.c > create mode 100644 dlls/joystick.cpl/joystick.cpl.spec > create mode 100644 dlls/joystick.cpl/joystick.h > create mode 100644 dlls/joystick.cpl/joystick.rc > create mode 100644 dlls/joystick.cpl/list.c > create mode 100644 dlls/joystick.cpl/main.c > create mode 100644 dlls/joystick.cpl/test.c It's called joy.cpl on Windows. Please also use compatible exports, and avoid creating a lot of empty source files. I'd expect that a single source file is sufficient for this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/4] server: Move completion from async object to async queue.
by Alexandre Julliard 04 Jun '12

04 Jun '12

"Erich E. Hoover" <ehoover(a)mymail.mines.edu> writes: > Real Name: > Erich Hoover > > Description: > It seems that the completion information should be associated with > the async queue, rather than the async object, since the completion > information for a file handle can be updated after an async IO has > been queued. So, the attached patch moves the completion information > from the async object into the async queue so that we can properly > handle associating a completion with a file descriptor after an async > IO is queued (part 2). Does it even need to be stored in the queue then? Why not retrieve it from the fd when needed? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [website] Publish a sign button for the Wine in Humble Indie Bundle petition
by Jeremy Newman 04 Jun '12

04 Jun '12

I'm not sure this belongs in the news section on WineHQ. I need some further convincing. -Newman On 06/04/2012 01:11 PM, André Hentschel wrote: > http://www.winehq.org/pipermail/wine-devel/2012-June/095722.html needs more cow bell > > --- > news/en/2012060401.xml | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 news/en/2012060401.xml > > diff --git a/news/en/2012060401.xml b/news/en/2012060401.xml > new file mode 100644 > index 0000000..1bcd3d5 > --- /dev/null > +++ b/news/en/2012060401.xml > @@ -0,0 +1,23 @@ > +<news> > +<date>June 4, 2012</date> > +<title>Wine in Humble Indie Bundle</title> > +<body> > +<div style="float: left; margin: 0 20px 20px 0; display:block; clear:both; text-align: left; background: #000 url(http://www.ipetitions.com/assets/images/widgets/black.png) no-repeat top left; width: 200px;"> > +<iframe src="http://www.ipetitions.com/widget/view/black/437775" marginheight="0" marginwidth="0" style="width: 200px; height:150px; border:0;" scrolling="no"></iframe> > +<div style="text-align:center; font-family:Arial;font-size: 9px; width: 196px; margin-top: -3px; padding: 1px 2px 2px; color: #8a8a8a; font-style: italic;"> > +<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com/">Petitions</a> by<a style="color: #8a8a8a; text-decoration:none;" href="http://www.ipetitions.com">iPetitions.com</a> > +</div> > +</div> > +<p> > + The Humble Indie Bundle includes a game (Limbo) > +<a href="http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition">ported via wine</a>. > +</p> > +<p> > + That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. > +</p> > +<p> > + So Dan Kegel put together a pro-wine petition: > +<a href="http://www.ipetitions.com/petition/use-wine-as-needed-in-future-humble-indi…">Use Wine as needed in future Humble Indie Bundles</a> > +</p> > +</body> > +</news> > > > >

1 0

Re: wininet: Added support for undocumented InternetQueryOption(98)
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18739 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3203: Test failed: HttpSendRequest failed: 12007 http.c:3208: Test failed: expected secure flag to be set http.c:3220: Test failed: expected a non-empty subject name http.c:3223: Test failed: expected a non-empty issuer name http.c:3232: Test failed: expected a non-zero key size http.c:3252: Test failed: expected a non-empty subject name http.c:3255: Test failed: expected a non-empty issuer name http.c:3264: Test failed: expected a non-zero key size

1 0

Re: Fix the FIXME message to reflect the real problem.
by Piotr Caban 04 Jun '12

04 Jun '12

On 06/02/12 13:35, max(a)mtew.isa-geek.net wrote: > @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( > goto cleanup; > } > > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("collision handler needed - the entry is already in use!\n"); This message is not about entry being used. I think the old message is quite accurate. The "don't know what to do" part is quite strange but I don't see reason to change it.

2 1

Re: comctl: allow label edit only if treeview style allows editing
by Alexandre Julliard 04 Jun '12

04 Jun '12

Daniel Jelinski <djelinski1(a)gmail.com> writes: > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 > From: Daniel Jelinski <djelinski1(a)gmail.com> > Date: Sat, 2 Jun 2012 07:23:32 +0200 > Subject: comctl: allow label edit only if treeview style allows editing > > Native comctl behaves this way - noticed when debugging regedit It breaks the tests: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok brsfolder.c:225: Test failed: The new folder did not get the name foo brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder' make: *** [brsfolder.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Alistair Leslie-Hughes 04 Jun '12

04 Jun '12

Hi Vijay, On 4/06/2012 8:06 PM, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > +static HRESULT WINAPI dictionary_put_Item(IDictionary *iface, VARIANT *key, VARIANT *item) > +{ > + FIXME("%p %p\n", iface, key); Please include all parameters in FIXME, they all seem to be missing the last one. Best Regards Alistair Leslie-Hughes

1 0

Re: [scrrun] Add initial support for Dictionary patch - 1/3
by Jacek Caban 04 Jun '12

04 Jun '12

Hi Vijay On 06/04/12 12:06, Vijay Kiran Kamuju wrote: > Sending patch series for initial support for Scripting.Dictionary in scrrun.dll > > The first patch will add dictionary.c > The second will add the necessary changes to Makefile and the scrrun.c > (mistake done will doing git commit - hence two patches) This split doesn't make sense. Please merge those patches. +static ULONG WINAPI dictionary_AddRef(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 2; +} + +static ULONG WINAPI dictionary_Release(IDictionary *iface) +{ + TRACE("%p\n", iface); + + return 1; +} Dictionary object should be heap-based. That requires proper reference counting and object structure. Cheers, Jacek

1 0

Re: [scrrun] - Add initial support for Dictionary - tests - patch 3/3
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18733 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: oleaut32: Add a test for BSTR cache.
by Marvin 04 Jun '12

04 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18731 Your paranoid android. === W2KPROSP4 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 98 out of 256 === WXPPROSP3 (32 bit vartype) === vartype.c:6166: Test failed: good_length_entries 99 out of 256

1 0

Re: [3/3] iphlpapi: Check for the right TCP statistics structure name (for DragonFly BSD)
by Juan Lang 03 Jun '12

03 Jun '12

Hi André, +#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT + struct tcpstat tcp_stat; +#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT + struct tcp_stats tcp_stat; +#endif struct tcpstat tcp_stat; I think you meant to remove the declaration outside of the #if. --Juan

2 1

Re: [1/4] user32/tests: remove WM_DESTROY processing in test (it is of no use and causes tests skipping) (try 2)
by Marvin 03 Jun '12

03 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18723 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1370: Test failed: Dialog should not be visible.

1 0

Mono?!?
by Max TenEyck Woodbury 03 Jun '12

03 Jun '12

When did WINE start requiring MONO? I have a VERY strong DISLIKE for MONO and do NOT want it on my machines. Seems to be a recent addition. Is it possible to NOT use it? PLEASE!

6 15

Re: shell32: fix compilation error with strcpy_chk: buffer overflow detected
by Nikolay Sivov 02 Jun '12

02 Jun '12

A static string constant would be better here. On Sat, Jun 2, 2012 at 12:42 PM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > --- > dlls/shell32/pidl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index c394e5b..5906a4f 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -1752,16 +1752,17 @@ LPITEMIDLIST _ILCreateDrive(LPCWSTR lpszNew) > LPITEMIDLIST _ILCreateEntireNetwork(void) > { > LPITEMIDLIST pidlOut; > + DWORD alen = sizeof("Entire Network"); > > TRACE("\n"); > > - pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[sizeof("Entire Network")])); > + pidlOut = _ILAlloc(PT_NETWORK, FIELD_OFFSET(PIDLDATA, > u.network.szNames[alen])); > if (pidlOut) > { > LPPIDLDATA pData = _ILGetDataPointer(pidlOut); > > pData->u.network.dummy = 0; > - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", alen + 1); > } > return pidlOut; > } > -- > 1.7.9.7 > > -- > С уважением, > Виталий Липатов, > Etersoft > >

1 0

Re: shell32: Make ShellExecute use native file association databases as fallback path
by Francois Gouget 02 Jun '12

02 Jun '12

On Thu, 31 May 2012, Erik van Pienbroek wrote: [...] > Tested successfully on a Fedora 17 environment using the start.exe > command and Outlook 2007 by trying to open a .pdf file (where there > is no file association registered inside the wine prefix) There are two issues with this patch: * In some cases xdg-open returns 0 whether or not there is a native file association. This is the case in KDE for instance. That would cause ShellExecute() to be unable to return anything but success. * There is a risk of infinite loops if the native association calls Wine. One such scenario is if you create the native association using Wine but later wipe out the Wine prefix so that there is no handler on the Wine side anymore. However I believe it can also happen simply because Windows' associations are based on extensions and Unix's on MIME types so that neither thinks they handle that case. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Alexandre Julliard 01 Jun '12

01 Jun '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Any chance for at least a comment? You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS. -- Alexandre Julliard julliard(a)winehq.org

2 5

size of wine packages
by Marcus Meissner 01 Jun '12

01 Jun '12

Hi, As we have crossed the 100MB installed size (stripped) for the Wine RPM packages (stripped), this makes a Wow64 capable installation taking around 200MB these days. Can we reduce this size? eg. kernel32.dll.so has 1.6MB of static data inside itself, which is puzzling me a bit. (winerror.res is 1.3MB, winerror.mc is 0.068 MB ... Huh? Translations blowing this up?) Out of 100MB /usr/lib/wine/, e.g. I have here 67 MB of .text (73MB on x86_64) 11 MB of .data (static data) Ciao, Marcus

1 0

Judge rules: APIs can not be copyrighted.
by Detlef Riekenberg 01 Jun '12

01 Jun '12

1 0

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Dmitry Timoshkov 31 May '12

31 May '12

sir-lexa <sir-lexa(a)yandex.ru> wrote: > case WM_DESTROY: > - PostQuitMessage(0); > + /* PostQuitMessage(0); It lets some tests to be skipped */ > return TRUE; This is not acceptable, there is much more behind the scene. You need to figure out the real reason of skipping the tests. -- Dmitry.

2 2

Re: [PATCH 3/5] ddraw/tests: Add test_coop_level_mode_set() for older ddraw versions.
by Marvin 31 May '12

31 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18687 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:2282: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2284: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2310: Test failed: Expected surface width 640, got 800. ddraw2.c:2312: Test failed: Expected surface height 480, got 600. ddraw2.c:2327: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2338: Test failed: Expected surface width 640, got 800. ddraw2.c:2340: Test failed: Expected surface height 480, got 600. ddraw2.c:2406: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw2.c:2408: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2434: Test failed: Expected surface width 640, got 800. ddraw2.c:2436: Test failed: Expected surface height 480, got 600. ddraw2.c:2451: Test failed: Expected message 0x7e, but didn't receive it. ddraw2.c:2462: Test failed: Expected surface width 640, got 800. ddraw2.c:2464: Test failed: Expected surface height 480, got 600. === WNT4WSSP6 (32 bit ddraw1) === ddraw1.c:2145: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2147: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2173: Test failed: Expected surface width 640, got 800. ddraw1.c:2175: Test failed: Expected surface height 480, got 600. ddraw1.c:2190: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2201: Test failed: Expected surface width 640, got 800. ddraw1.c:2203: Test failed: Expected surface height 480, got 600. ddraw1.c:2269: Test failed: SetDipslayMode failed, hr 0x887600e1. ddraw1.c:2271: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2297: Test failed: Expected surface width 640, got 800. ddraw1.c:2299: Test failed: Expected surface height 480, got 600. ddraw1.c:2314: Test failed: Expected message 0x7e, but didn't receive it. ddraw1.c:2325: Test failed: Expected surface width 640, got 800. ddraw1.c:2327: Test failed: Expected surface height 480, got 600.

1 0

Re: [PATCH 3/3] ntdll/tests: Add tests for RtlGetProductInfo [resend]
by Alexandre Julliard 31 May '12

31 May '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > Clone the kernel32 tests to verify, that the NULL pointer > check is present in ntdll.dll That's not useful, it's clearly the same function, it doesn't need to be tested twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] win16/int21: make found filename uppercase.
by Alexandre Julliard 31 May '12

31 May '12

Oleksij Rempel <bug-track(a)fisher-privat.net> writes: > @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context ) > INT21_FindPath = dta->fullPath = NULL; > } > dta->count = n; > + p = dta->filename; > + for ( ; *p; p++) *p = toupper(*p); Using toupper is probably not a good idea on OEM codepage strings. Which app depends on this? -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [4/4] windowscodecs: Add stub IWICMetadataBlockReader to PNG decoder.
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18675 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

Re: [3/4] windowscodecs: Add test for IWICMetadataBlockReader interface.
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18674 Your paranoid android. === WXPPROSP3 (32 bit metadata) === metadata: unhandled exception c0000005 at 4CCA826D === W2K8SE (32 bit metadata) === metadata: unhandled exception c0000005 at 72C28045

1 0

crypt32/tests(1/6): Don't shadow a variable with a variable of a different type
by Juan Lang 30 May '12

30 May '12

--Juan

1 0

Re: [2/2]kernel32/test: added test for OutputDebugStringA called with NULL pointer
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18671 Your paranoid android. === WXPPROSP3 (32 bit debugger) === Timeout === W2K3R2SESP2 (32 bit debugger) === Timeout

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream. (try 2)
by Dmitry Timoshkov 30 May '12

30 May '12

Józef Kucia <joseph.kucia(a)gmail.com> wrote: > + offset.QuadPart = 0; > + size.u.LowPart = 0xffffffff; > + size.u.HighPart = 0xffffffff; > + return IWICStream_InitializeFromIStreamRegion(iface, pIStream, offset, size); What prevents you from discovering correct stream size? -- Dmitry.

3 5

Re: [1/2] mscoree: Install Wine Mono on prefix update.
by Alexandre Julliard 30 May '12

30 May '12

Vincent Povirk <madewokherd(a)gmail.com> writes: > From d271ba591f6afb4e0b2356da24841f54d5f11b9b Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue, 29 May 2012 10:35:36 -0500 > Subject: [PATCH 1/2] mscoree: Install Wine Mono on prefix update. > > --- > dlls/mscoree/mscoree_main.c | 120 +++++++++++++++++++++++++++++++++++++++++++ > tools/wine.inf.in | 1 + > 2 files changed, 121 insertions(+) This is breaking 64-bit prefixes, because things are not done in the correct order. It also looks like the package is not creating the 64-bit registry keys. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 4/4] jscript: Added VT_I2 tests
by Marvin 30 May '12

30 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18657 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] jscript: Get rid of ret_nan hack
by Ruslan Kabatsayev 30 May '12

30 May '12

Hello, This patch (committed as d0a719a79dae001df341db907fcae54118691d35) leads to compilation error: make[1]: Entering directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/fastdocs/programmer/wine-git/dlls/msadp32.acm' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -I/opt/Xorg-7.5/include -L/opt/Xorg-7.5/lib -o string.o string.c lex.c: In function ‘cc_token’: lex.c:936:71: error: ‘NAN’ undeclared (first use in this function) lex.c:936:71: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [lex.o] Error 1 I've tried doing git clean -xdf, but this still doesn't compile. Regards, Ruslan On Tue, May 29, 2012 at 2:53 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/jscript/date.c | 28 ++++++++++++++-------------- > dlls/jscript/error.c | 3 ++- > dlls/jscript/global.c | 2 +- > dlls/jscript/jscript.h | 7 ------- > dlls/jscript/jsutils.c | 6 +++--- > dlls/jscript/lex.c | 2 +- > 6 files changed, 21 insertions(+), 27 deletions(-) > > > > >

2 1

ru.po: improved an Russian translation
by Oleg Yarigin 30 May '12

30 May '12

There are some improvements of a style (now it is more official) and non-translated empty lines. To avoid an character encoding interruption, I send the diff file as a packed text file attachment (ru_diff.txt.bz2, 22.3 KB).

3 2

stub for SetThreadStackGuarantee
by Daniel Jelinski 29 May '12

29 May '12

Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

1 0

Re: kernel32/volume: Don't modify the last error in GetVolumeInformation
by Alexandre Julliard 29 May '12

29 May '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -729,6 +731,8 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > + /* At this point, last error is ERROR_NOT_SUPPORTED. Restoring the previous one */ > + SetLastError(lastError); You should never need to do that sort of thing, there are no guarantees about last error on success. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementing joystick ids in DirectInput
by Lucas Zawacki 29 May '12

29 May '12

Hey guys, asking for a little code review here... I was looking at the solution for this bug http://bugs.winehq.org/show_bug.cgi?id=30705 and it comes down to implementing the DIPROP_JOYSTICKSID property for joystick devices. After some research on what this is I know it's always a number between (0,n), where n is the number of joysticks connected, and is analogous to the winmm driver joystick id. The solution I came up is in the attached patch, it's a little weird but I found it hard to give a unique ID to each joystick on Linux when they can come from different drivers. This solution uses the order which dinput puts the joysticks on it's device list and will work regardless. If someone has a better way to do it I'd like to know. Cheers,

2 2

Re: [PATCH 1/3] ntdll: Implement RtlGetProductInfo and use it for GetProductInfo
by Alexandre Julliard 29 May '12

29 May '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > The wrapper in kernel32 is not needed. > RtlGetProductInfo and GetProductInfo have the same signature and > tests show the same results. No they don't have the same signature, look closer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] d3dx9: Implement D3DXSaveSurfaceToFileInMemory.
by Vincent Povirk 28 May '12

28 May '12

> - hr = IWICImagingFactory_CreateStream(factory, &stream); > + hr = IWICImagingFactory_CreateStream(factory, &wic_stream); > IWICImagingFactory_Release(factory); > if (FAILED(hr)) goto cleanup_err; > > - hr = IWICStream_InitializeFromFilename(stream, dst_filename, GENERIC_WRITE); > + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); > if (FAILED(hr)) goto cleanup_err; > > + hr = IWICStream_InitializeFromIStream(wic_stream, stream); Why bother creating an IWICStream here? Just use your HGLOBAL stream to initialize the encoder.

1 0

Re: [1/5] windowscodecs: Implement IWICStream::InitializeFromIStream.
by Vincent Povirk 28 May '12

28 May '12

> +static HRESULT WINAPI StreamOnStream_Seek(IStream *iface, > + LARGE_INTEGER dlibMove, DWORD dwOrigin, ULARGE_INTEGER *plibNewPosition) > +{ > + StreamOnStream *This = StreamOnStream_from_IStream(iface); > + HRESULT hr=S_OK; > + TRACE("(%p)\n", This); > + > + EnterCriticalSection(&This->lock); > + hr = IStream_Seek(This->stream, dlibMove, dwOrigin, plibNewPosition); > + LeaveCriticalSection(&This->lock); > + > + return hr; > +} The IWICStream needs to have an independent position from the underlying stream. Also, why not just forward to InitializeFromIStreamRegion?

1 0

Re: [1/3] user32/tests: Comment-out PostQuitMessage (causes tests skip)
by Marvin 28 May '12

28 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18630 Your paranoid android. === W7PROX64 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (32 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === W7PROX64 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible. === TEST64_W7SP1 (64 bit dialog) === dialog.c:1373: Test failed: Dialog should not be visible.

1 0

Re: d3dx9_36/tests: Add tests for D3DXCreatePolygon
by Marvin 27 May '12

27 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18615 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

func or pFunc in tests ?
by GOUJON Alexandre 27 May '12

27 May '12

Hi, I'm planning to add a test in the wine test suite and I noticed a difference. Some tests call directly the function by its name (i.e. GetWindowsDirectory, CreateFileA, CloseHandle...) while others declare a pointer to the function (prefixing its name by 'p' and followed by a capital letter) retrieved via GetProcAddress. I know that tests have been written by lots of different people at different times and the general rule is "follow the style of the test file to be consistent" but here, both styles exist in the same file (kernel32/tests/volume.c). Is there any rule concerning using func over pFunc ? Is it related to the module it comes from ? Thanks

2 2

[website] Logo license? Usable in a propritary App?
by André Hentschel 25 May '12

25 May '12

Hey, they use the "old" WineHQ Logo in this 99 Cent App: https://play.google.com/store/apps/details?id=com.appdevandroid.framework.w… Is that ok? If not, could the creater please contact them. The Icon could be misleading. -- Best Regards, André Hentschel

1 0

Fwd: [Freerdp-devel] WinPR: Windows Portable Runtime
by Pau Garcia i Quiles 25 May '12

25 May '12

FYI ---------- Forwarded message ---------- From: Marc-André Moreau <marcandre.moreau(a)gmail.com> Date: Fri, May 25, 2012 at 3:04 AM Subject: [Freerdp-devel] WinPR: Windows Portable Runtime To: freerdp-devel <freerdp-devel(a)lists.sourceforge.net> Dear FreeRDP community, I have an announcement to make regarding a new spin-off project which I've been preparing for a while. Please read as this will set the tone of future development :) You can find most current WinPR development work on the winpr branch: https://github.com/FreeRDP/FreeRDP/tree/winpr WinPR is a spin-off project of FreeRDP which aims at providing a portable implementation of important portions of the Windows API. Just like FreeRDP, WinPR is released under the Apache license. Unlike Wine, WinPR does not provide binary compatibility, and does not require applications to be built for Windows. Instead, WinPR provides API compatibility for applications targeting non-Windows environments. When on Windows, the original native API is being used instead of the equivalent WinPR implementation, without having to modify the code using it. WinPR is the result of long and thoughtful process that came up after years of FreeRDP development. RDP, as you know, is a protocol designed by Microsoft and is primarily “Windows to Windows”. In many instances, protocol messages rely heavily on Windows-specific APIs which have no direct equivalent on other operating systems. For instance, core graphical messages are based on GDI, network level authentication makes use of the Microsoft SSPI authentication modules (CredSSP, NTLM), and terminal server gateway makes use of both SSPI and MSRPC. That’s not even mentioning all the effort that went into mapping keyboard systems and time zones. Developing FreeRDP is in many ways all about implementing Windows APIs outside of Windows. Immense efforts have gone into the implementation of such features, to the point where they begin having value outside of FreeRDP itself. At this point, one of the most valuable part of WinPR is the set of SSPI modules. Various NTLM implementations exist, all with different interfaces, but the WinPR implementation is a direct replacement of the original. This is an advantage because the API is already well documented, with expected inputs and outputs. FreeRDP can also optionally build against the native SSPI modules when on Windows. Making this code easily reusable to any one means that application developers now have an easy way of porting their applications to make use of the Windows authentication architecture. WinPR is also a response to a recurrent problem in FreeRDP development: the proliferation of custom helpers and utility functions. While those are useful, they often need to be modified and updated to meet new requirements, causing frequent API changes. Breaking the API regularly obviously makes a lot of developers unhappy. By choosing to implement an existing and mature API, we can effectively get rid of the core of the problem. If a certain API has been used for years and it fits the needs of most people, you are less likely to need to break it yourself. Besides the argument of API stability, there is another huge advantage in using the Windows API over custom utility functions: the ability to easily share code with other projects that aim at implementing the same API. For instance, the SSPI modules currently developed in WinPR are of high interest to the ReactOS project. If the code was filled with custom utility functions, it would be much harder to use outside of FreeRDP, hindering such collaboration opportunities. For instance, instead of wrapping calls to MultiByteToWideChar() in a custom unicode conversion utility, we can use MultiByteToWideChar() as the utility function and provide an implementation on non-Windows systems. As a general rule in WinPR, if a utility function can be replaced by a part of the Windows API, then the Windows API will have precedence. Otherwise, a utility method can be used, keeping in mind the downsides of it. WinPR is also designed to be as modular as possible, using the MinWin architecture as a reference. MinWin is a refactoring effort of the Windows API which is more cleaner and comprehensive than the original. The API has been separated into logical sets, each with a DLL. Not a lot of documentation is available online about MinWin, but one can find its structure in the MSDN article “Windows API Sets”: http://msdn.microsoft.com/en-us/library/hh802935/ Just like MinWin, WinPR aims at being minimalistic and modular, such that one can have fine grained control over what is to be used. For projects making use of only a small amounts of WinPR, it should be possible to depend only on the minimum required. At last, why not simply use Wine or code from other projects like ReactOS or Samba? In all of these cases, there are both licensing and architectural problems which make it fairly hard for us to use in FreeRDP. For instance, Wine provides binary compatibility, and it’s not easy for a native Linux application to make use of parts of it without being built for Windows. Samba has an interesting MSRPC implementation, but it’s a fairly big dependency, without counting the fact that we can forget about portability on mobile platforms like Android and iOS. Unfortunately, none of these provide a highly portable implementation of the Windows API in the way we would like and under a license which is suitable to us, justifying the existence of WinPR. Through WinPR, investment done in FreeRDP development will take a new life and become even more valuable. We will open new doors to even higher levels of interoperability. We will foster collaboration with other projects following similar goals and reach new heights at an increasingly faster pace. Stay tuned, you will be amazed! ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freerdp-devel mailing list Freerdp-devel(a)lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: [5/5] propsys: Implement IPropertyStore::GetCount.
by Marvin 24 May '12

24 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18573 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] propsys: Implement IPropertyStore::SetValue and GetValue.
by Marvin 24 May '12

24 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18572 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: gdiplus: Reimplement GdipIsEmptyRegion.
by Dmitry Timoshkov 24 May '12

24 May '12

Hello, I'm surprised that such a trivial patch wasn't accepted yet. But just in case it matters, current implementation doesn't work for paths and combined/complex regions. -- Dmitry.

2 2

Re: windowscodecs: Add a stubbed out IWICMetadataBlockReader interface.
by Vincent Povirk 24 May '12

24 May '12

Please add a test showing that some builtin metadata handler implements this interface. On Thu, May 24, 2012 at 4:39 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/windowscodecs/metadatahandler.c | 69 ++++++++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c > index afcff21..ffe6763 100644 > --- a/dlls/windowscodecs/metadatahandler.c > +++ b/dlls/windowscodecs/metadatahandler.c > @@ -39,6 +39,7 @@ typedef struct MetadataHandler { > IWICMetadataWriter IWICMetadataWriter_iface; > LONG ref; > IWICPersistStream IWICPersistStream_iface; > + IWICMetadataBlockReader IWICMetadataBlockReader_iface; > const MetadataHandlerVtbl *vtable; > MetadataItem *items; > DWORD item_count; > @@ -55,6 +56,11 @@ static inline MetadataHandler *impl_from_IWICPersistStream(IWICPersistStream *if > return CONTAINING_RECORD(iface, MetadataHandler, IWICPersistStream_iface); > } > > +static inline MetadataHandler *impl_from_IWICMetadataBlockReader(IWICMetadataBlockReader *iface) > +{ > + return CONTAINING_RECORD(iface, MetadataHandler, IWICMetadataBlockReader_iface); > +} > + > static void MetadataHandler_FreeItems(MetadataHandler *This) > { > int i; > @@ -92,6 +98,10 @@ static HRESULT WINAPI MetadataHandler_QueryInterface(IWICMetadataWriter *iface, > { > *ppv = &This->IWICPersistStream_iface; > } > + else if (IsEqualIID(&IID_IWICMetadataBlockReader, iid)) > + { > + *ppv = &This->IWICMetadataBlockReader_iface; > + } > else > { > *ppv = NULL; > @@ -317,6 +327,64 @@ static const IWICPersistStreamVtbl MetadataHandler_PersistStream_Vtbl = { > MetadataHandler_SaveEx > }; > > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_QueryInterface(IWICMetadataBlockReader *iface, > + REFIID iid, void **ppv) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_QueryInterface(&This->IWICMetadataWriter_iface, iid, ppv); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_AddRef(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_AddRef(&This->IWICMetadataWriter_iface); > +} > + > +static ULONG WINAPI MetadataHandler_MetadataBlockReader_Release(IWICMetadataBlockReader *iface) > +{ > + MetadataHandler *This = impl_from_IWICMetadataBlockReader(iface); > + return IWICMetadataWriter_Release(&This->IWICMetadataWriter_iface); > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetContainerFormat( > + IWICMetadataBlockReader *iface, GUID *guid) > +{ > + FIXME("(%p,%p): stub\n", iface, guid); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetCount( > + IWICMetadataBlockReader *iface, UINT *count) > +{ > + FIXME("(%p,%p): stub\n", iface, count); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetReaderByIndex( > + IWICMetadataBlockReader *iface, UINT index, IWICMetadataReader **reader) > +{ > + FIXME("(%p,%u,%p): stub\n", iface, index, reader); > + return E_NOTIMPL; > +} > + > +static HRESULT WINAPI MetadataHandler_MetadataBlockReader_GetEnumerator( > + IWICMetadataBlockReader *iface, IEnumUnknown **enum_metadata) > +{ > + FIXME("(%p,%p): stub\n", iface, enum_metadata); > + return E_NOTIMPL; > +} > + > +static const IWICMetadataBlockReaderVtbl MetadataHandler_MetadataBlockReader_Vtbl = > +{ > + MetadataHandler_MetadataBlockReader_QueryInterface, > + MetadataHandler_MetadataBlockReader_AddRef, > + MetadataHandler_MetadataBlockReader_Release, > + MetadataHandler_MetadataBlockReader_GetContainerFormat, > + MetadataHandler_MetadataBlockReader_GetCount, > + MetadataHandler_MetadataBlockReader_GetReaderByIndex, > + MetadataHandler_MetadataBlockReader_GetEnumerator > +}; > + > HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkOuter, REFIID iid, void** ppv) > { > MetadataHandler *This; > @@ -333,6 +401,7 @@ HRESULT MetadataReader_Create(const MetadataHandlerVtbl *vtable, IUnknown *pUnkO > > This->IWICMetadataWriter_iface.lpVtbl = &MetadataHandler_Vtbl; > This->IWICPersistStream_iface.lpVtbl = &MetadataHandler_PersistStream_Vtbl; > + This->IWICMetadataBlockReader_iface.lpVtbl = &MetadataHandler_MetadataBlockReader_Vtbl; > This->ref = 1; > This->vtable = vtable; > This->items = NULL; > -- > 1.7.10.1 > > >

1 0

Testing regedit
by Daniel Jelinski 24 May '12

24 May '12

Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel

3 3

Re: [PATCH variant 1] dsound: use a low-quality FIR for games
by Andrew Eikum 23 May '12

23 May '12

Thanks Alexander. Thoughts below... On Sat, May 19, 2012 at 09:09:35PM +0600, Alexander E. Patrakov wrote: > There are two ways to implement a high-performance resampler, and I > have prepared (conflicting, pick no more than one) patches for both: > > 1 (this patch): Use a shorter FIR with the existing code. This has the > advantage of higher quality (unwanted frequencies are at least > attempted to be rejected) and almost no new code. > 2 (the other patch): Write new code. E.g., linear interpolation. This > is what Windows XP does at its lowest quality setting, and it eats > less CPU than variant 1. > Do you have an opinion on which of these patches to use? The low-quality FIR has the advantage of not introducing another codepath. On the other hand, the linear resampler codepath is very simple, and even easier on the CPU. I'm leaning towards the linear resampler for its larger CPU usage benefits. > Also note that, as evicenced by the debugging patch, a Core 2 Duo > E6420 @ 2.13 GHz _can_ resample more than 32 streams simultaneously > from various weird rates to 48000 Hz. As GTA:SA reportedly creates > only 16 secondary buffers, it _should_ have more than enough CPU time > to mix them. IMHO, this makes bug #30639 look somewhat strange: on > GyB's computer, GTA:SA stutters, while Darwinia (which looks more > demanding about sound) doesn't. It may well be that in fact none of my > patches are needed, and that the real bug is that the CPU-intensive > cp_fields() function is called from a wrong thread or process. I don't > have the expertise needed to debug this. > I did some research on this. Darwinia creates up to 32 buffers, like you said. GTA:SA creates and destroys buffers as needed, and I saw it go as high as 31 in a quick test. Darwinia's buffer frequencies range in the 40-90 kHz range and resample to 22050 Hz, while GTA:SA's range around 10-20 kHz and resample to 48 kHz. So in each time step, GTA:SA requires about 1000-2000 get_current_sample() calls, but 4800 FIR convolutions per buffer. Darwinia requires 4000-9000 get_current_sample() calls, but only about 2200 convolutions per buffer. I suspect the convolutions are considerably more expensive than the get_current_sample() calls, so I would actually expect GTA:SA to be more CPU taxing. That should explain what's going on here. We could test this on Gyb's machine by setting DefaultSampleRate=22050 and hacking <dlls/dsound/primary.c:primarybuffer_SetFormat> to return S_OK without actually changing the primary buffer's format. That should give GTA:SA similar cp_fields performance to Darwinia, and I expect it would fix the lag issue. Andrew

2 2

Re: vbscript: Add support for integer values in conditional jumps.
by Marvin 23 May '12

23 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18547 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

2 1

Re: [2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.
by Bruno Jesus 22 May '12

22 May '12

On Mon, Apr 30, 2012 at 6:52 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > --- > dlls/gdi32/freetype.c | 35 +++++++++++++++++++- > dlls/gdi32/tests/font.c | 83 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 116 insertions(+), 2 deletions(-) I don't know if this patch was directly related to a bug or not but now we are sure it does really fix at least this bug: http://bugs.winehq.org/show_bug.cgi?id=12476 Best wishes, Bruno

1 0

Re: wineqtdecoder: Recreate audio extraction session when we run out of frames.
by Alexandre Julliard 22 May '12

22 May '12

Aric Stewart <aric(a)codeweavers.com> writes: > This is instead of waiting until a movie is fully loaded before being > able to start playing. This eliminates the up to several second pause > when starting some, mostly avi, movies. > --- > dlls/wineqtdecoder/qtsplitter.c | 66 > +++++++++++++++++++++++++++++++++------ > 1 files changed, 56 insertions(+), 10 deletions(-) What about the comment that says that we can't do that? -- Alexandre Julliard julliard(a)winehq.org

2 1

winetricks & DLL overrides
by wylda＠volny.cz 22 May '12

22 May '12

Hi Dan, i'm happy user of winetricks and thanks for all that work. Today i found out, that i wasn't able to reveal, that apps uses some native dll when using: winetricks settings alldlls=builtin further checking revealed, that winetricks(20120308) has several no longer available dll override compared to winecfg and some are missing, thus application uses them as native. So i add/del dlls from override_all_dlls list based on winecfg (1.5.3-164-gdec3d50) and the result is attached as a patch. Probably unusable for you, because: * no care about line length * i do not know whether removing no longer available dll's override is allowed (what's happen for users using old wine-1.0 and need dlls's override no longer available in wine-1.5.3) * shouldn’t be the dll's override in user.reg simply overwritten? As i noticed the names are there twice - 2nd one with "*" prefix making it confusing, which value will be used and the list in winecfg is twice as long. Thanks and regards, W.

2 2

Re: [1/2] ole32: Forward OleCreateLinkFromData and OleCreateStaticFromData to OleCreateFromData.
by Alexandre Julliard 22 May '12

22 May '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +/****************************************************************************** > + * OleCreateLinkFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateLinkFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} > + > +/****************************************************************************** > + * OleCreateStaticFromData [OLE32.@] > + */ > +HRESULT WINAPI OleCreateStaticFromData(LPDATAOBJECT data, REFIID iid, > + DWORD renderopt, LPFORMATETC fmt, > + LPOLECLIENTSITE client_site, LPSTORAGE stg, > + LPVOID *obj) > +{ > + return OleCreateFromData(data, iid, renderopt, fmt, client_site, stg, obj); > +} Surely there's more to these functions than that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: quartz/tests: Fix compilation on systems that don't support nameless structs.
by Marvin 21 May '12

21 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18512 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:96: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:233: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:347: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:405: Test failed: CoCreateInstance failed with 80040154

2 1

Re: [PATCH 3/3] shell32: Move the pidl handling to the ExtractIcon_Constructor
by Nikolay Sivov 20 May '12

20 May '12

On 5/20/2012 18:47, Detlef Riekenberg wrote: > } else if (IsEqualIID(riid,&IID_IExtractIconA)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconA_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], FALSE, ppvOut); > } else if (IsEqualIID(riid,&IID_IExtractIconW)&&(cidl == 1)) { > - pidl = ILCombine(This->pidlRoot, apidl[0]); > - pObj = (LPUNKNOWN) IExtractIconW_Constructor(pidl); > - SHFree(pidl); > - hr = S_OK; > + return IExtractIconAW_Constructor(This->pidlRoot, apidl[0], TRUE, ppvOut); > } else if ((IsEqualIID(riid,&IID_IShellLinkW) || IsEqualIID(riid,&IID_IShellLinkA)) I think it's better to pass riid to constructor helper and return appropriate vtable according to that riid. That will also collapse this to a single 'if' testing for both interfaces. > +HRESULT IExtractIconAW_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, BOOL is_unicode, void ** ppvOut) > { > - IExtractIconWImpl *ei; > + IExtractIconWImpl *ei = HeapAlloc(GetProcessHeap(), 0, sizeof(IExtractIconWImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > > - TRACE("%p\n", pidl); > + if (!pidl || !ei) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, ei); > + return E_OUTOFMEMORY; > + } > > - ei = HeapAlloc(GetProcessHeap(), 0, sizeof(*ei)); > ei->ref=1; > ei->IExtractIconW_iface.lpVtbl =&eivt; > ei->IExtractIconA_iface.lpVtbl =&eiavt; > ei->IPersistFile_iface.lpVtbl =&pfvt; > ei->pidl=ILClone(pidl); > > - pdump(pidl); Same here as in previous patch - storing combined result vs. making another clone.

1 0

Re: [PATCH 1/3] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf [try 2]
by Nikolay Sivov 20 May '12

20 May '12

On 5/20/2012 18:47, Detlef Riekenberg wrote: > +HRESULT IQueryInfo_Constructor(LPCITEMIDLIST root, LPCITEMIDLIST item, void ** ppvOut) > +{ > + IQueryInfoImpl *qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + LPITEMIDLIST pidl = ILCombine(root, item); > + > + if (!pidl || !qi) { > + SHFree(pidl); > + HeapFree(GetProcessHeap(), 0, qi); > + return E_OUTOFMEMORY; > + } > + > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref = 1; > + qi->pidl = ILClone(pidl); > + > + SHFree(pidl); I don't see a reason to ILClone() here. You could just store ILCombine() result.

1 0

Re: dsound: Fixed compilation error caused by 942f2ce7
by Jacek Caban 19 May '12

19 May '12

Hi Alexander, On 5/19/12 3:35 PM, Alexander E. Patrakov wrote: > There is no dummy union u anymore. > This doesn't seem right. They are still present, just generated by widl. Jacek

2 2

re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by Dan Kegel 18 May '12

18 May '12

Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or third party software. Really? IMHO they should still be silver. Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. - Dan

7 13

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling (try 3)
by Marvin 18 May '12

18 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18480 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === Timeout

1 0

Re: [PATCH 1/5] programs: First version of the joystick testing tool. Just lists connected joysticks.
by Alexandre Julliard 18 May '12

18 May '12

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > configure.ac | 1 + > programs/joystick/Makefile.in | 17 +++++++ > programs/joystick/main.c | 102 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 120 insertions(+) > create mode 100644 programs/joystick/Makefile.in > create mode 100644 programs/joystick/main.c I don't think it makes sense to add a command-line application for this. If there are really things that the user needs to configure, it should be a control panel. But ideally we should retrieve the settings from the Unix environment. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: quartz: COM cleanup for Parser_OutputPin
by Michael Stefaniuc 18 May '12

18 May '12

Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: > diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c > index 5027e90..bac1b24 100644 > --- a/dlls/quartz/avisplit.c > +++ b/dlls/quartz/avisplit.c > @@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl *This, DWORD streamnumbe > > static HRESULT AVISplitter_Receive(AVISplitterImpl *This, IMediaSample *sample, DWORD streamnumber) > { > - Parser_OutputPin *pin = (Parser_OutputPin *)This->Parser.ppPins[1+streamnumber]; > + Parser_OutputPin *pin = impl_Parser_OutputPin_from_IPin(This->Parser.ppPins[1+streamnumber]); this isn't right. impl_from_... should be used only from methods of the respective implementation. You can either: - Make This->Parser.ppPins an array of Parser_OutputPin instead of IPin - Or if you need to support application provided IPin then you'll need an unsafe_impl_from_... > HRESULT hr; > LONGLONG start, stop, rtstart, rtstop; > StreamData *stream = &This->streams[streamnumber]; bye michael

2 1

Logging issue ?
by GOUJON Alexandre 18 May '12

18 May '12

Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines are half-printed and joined with the following I know sometimes a trailing \n is missing in TRACE() so the output is uncertain. But that doesn't seem to be the case here. Maybe it's not thread safe or something like that ? I tried using taskset 1 wine .. to force using one core but no luck. Here a small part of my log (order not modified, I just remove lines from other threads): 0030:Call KERNEL32.GetVolumeInformationA(09732288 "D:",097321ec,0000007f,00000000,00000000,097321d8,00000000,00000000) ret=0057b045 0030:trace:volume:GetVolumeInformationW L"\\??\\D:\\": found fs type 50009:Call wined3d.wined3d_mutex_unlock() ret=7ed6e3a6 0030:Ret KERNEL32.CreateFileA() retval=000001f4 ret=00c8b5ab 0030:Call KERNEL32.DeviceIoControl(000001f4,00041018,00000000,00000000,09732190,00000008,097321a4,00000000) ret=00c8b64a The game calls GetVolumeInformationA .. the trace is mixed with output of another thread .. I guess the game open the device (no call line) .. and then do some ioctl. No trace of how the game opened the device.. I can do several logs and try to compare each other to have a complete puzzle but that's not very handy. Any thought ? idea ? advice ? (I'm using packaged wine on x86_64) Thanks

2 1

Fwd: Re: Logging issue ?
by GOUJON Alexandre 18 May '12

18 May '12

Also replying to wine-devel -------- Original Message -------- Subject: Re: Logging issue ? Date: Fri, 18 May 2012 16:52:34 +0200 From: GOUJON Alexandre <ale.goujon(a)gmail.com> To: Nikolay Sivov <bunglehead(a)gmail.com> On 05/18/2012 05:31 PM, Nikolay Sivov wrote: > On 5/18/2012 17:23, GOUJON Alexandre wrote: >> Any thought ? idea ? advice ? > I believe there was a discussion about that in the past, It usually > helps to use a ">>" redirect that appends to log file instead of > replacing its contents. But you'll obviously need to clean a log file > before starting anything Using>> instead of> seems to work. It's weird but if it works... Thanks for the advice !

1 0

Re: [PATCH 3/4] shell32: Add IQueryInfo to more shellfolder
by Nikolay Sivov 18 May '12

18 May '12

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + } else if (IsEqualIID(riid,&IID_IQueryInfo)&& (cidl == 1)) { > + pidl = ILCombine (This->pidlRoot, apidl[0]); > + pObj = (IUnknown *) IQueryInfo_Constructor (pidl); > + SHFree (pidl); > + hr = S_OK; > } else { Patch doesn't have a cast here, and looks really redundant. If you really need that it's better to make IQueryInfo_Constructor look more like class factory call - with HRESULT and void** parameter. Also it looks like you always need to combine pidls and cleanup after that, I think it's better to combine them in constructor and keep result in QueryInfo impl. (instead of making a clone). So constructor could look like "HRESULT constructor(root, pidl, pObj)".

1 0

Re: [PATCH 1/4] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf
by Nikolay Sivov 18 May '12

18 May '12

On 5/18/2012 14:06, Detlef Riekenberg wrote: > + if (ppv == NULL) > + return E_POINTER; This is usually redundant. > + > + if (IsEqualGUID(&IID_IUnknown, riid) || > + IsEqualGUID(&IID_IQueryInfo, riid)) { > + *ppv =&This->IQueryInfo_iface; > + IUnknown_AddRef((IUnknown*)*ppv); > + TRACE("returning IQueryInfo: %p\n", *ppv); > + return S_OK; > + } Instead of using IUnknown for some reason a clean way could be to call IQueryInfo_AddRef(iface). Trace is not needed here - you have a trace on top of that and FIXME trace on a failure, so you'll know. > + > + *ppv = NULL; > + FIXME("(%p)->(%s %p) interface not supported\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > +} > +IQueryInfo *IQueryInfo_Constructor(LPCITEMIDLIST pidl) > +{ > + IQueryInfoImpl *qi; > + > + TRACE("(%p)\n", pidl); > + > + qi = HeapAlloc(GetProcessHeap(), 0, sizeof(IQueryInfoImpl)); > + qi->IQueryInfo_iface.lpVtbl =&IQueryInfo_vtbl; > + qi->ref=1; > + qi->pidl=ILClone(pidl); > + > + TRACE("==> %p (pidl: %p)\n", qi, qi->pidl); > + return&qi->IQueryInfo_iface; > +} This doesn't handle HeaoAlloc() or ILClone failures.

1 0

Installing 64 bit visual c++ 2010 runtime?
by Dan Kegel 17 May '12

17 May '12

I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650… wine vcredist_x64 and that installs fine... but only puts anything in c:\windows\syswow64, and the 64 bit app I'm trying is rather upset that it can't find mfc100.dll. The log it writes into c:\users\$LOGNAME\*.html says (if you look at the source, or click 'verbose' in a web browser) "platform not supported". This happens even if I use winecfg to set win7 mode. Happily, it looks like one can just grab the file from the .cab with something like this: mkdir foo cd foo cabextract ../vcredist_x64.exe cabextract vc_red.cab cp F_CENTRAL_mfc100_x86 ~/.wine/windows/system32 cd .. rm -rf foo That gets the app I'm trying to the point where it needs a newer builtin vcrun100, http://source.winehq.org/git/wine.git/?a=commit;h=6cb3713e26aa4d89d4dc67601… which is great. (Now I just have to get around to following up on previous posts about how to build biarch wine on ubuntu 12.04.) But I still wonder why the installer doesn't want to install the 64 bit files.

1 1

Re: comctl32: When created with TCS_VERTICAL, TCS_MULTILINE is set automatically
by Stefan Leichter 17 May '12

17 May '12

Thursday 17 May 2012 Nikolay Sivov <nsivov(a)codeweavers.com> > - DWORD dwStyle; > + DWORD style; Any reason for changing the name?

2 1

Re: kernel32: check the last parameter of K32EnumProcessModules for NULL before use (with test)
by Nikolay Sivov 17 May '12

17 May '12

On 5/17/2012 11:46, Stefan Leichter wrote: > SetLastError(0xdeadbeef); > + pEnumProcessModules(hpQI,&hMod, sizeof(HMODULE), NULL); > + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ret = pEnumProcessModules(hpQV,&hMod, sizeof(HMODULE), NULL); > + ok(!ret, "succeeded\n"); > + ok(GetLastError() == ERROR_NOACCESS, "expected error=ERROR_NOACCESS but got %d\n", GetLastError()); > + Why don't you check return value from the first call?

2 1

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold
by K.King 17 May '12

17 May '12

<< A "runs well with patched wine" checkbox might be useful, but would be very confusing. Maybe if it forced the rating to be garbage that would be ok. >> If it was possible my preference would be to be able to see separate rating per vanilla and per non vanilla. The per vanilla should be first and more obvious. If I see a rating of Garbage infers even with patching it would not run? problem with "runs well with patched wine" is it's an on or off, whereas you could start wishing for an indication of how well it can be made to run? Keeping the steps, results, capabilities, not tested, etc for patched wine could/should maybe be kept quite separate to the quick and obvious vanilla out of box results section? K.

1 0

kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions
by Alex Henrie 16 May '12

16 May '12

Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it. -Alex

2 1

AppDB, ratings and native vs. builtin trouble
by Alexey Loukianov 16 May '12

16 May '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Good day to all subscribers of this list, I've got a small decision trouble I have to deal with as an AppDB maintainer. I know that years ago there had been discussion on this topic, but I want to bring this once on a surface once again so we would get a fresh modern look an thus minor problem. As we all know, Wine isn't perfect, thus applications often require native DLLs to behave properly. AppDb treats such cases as being "Gold" rating. It's easy to distinguish between "Platinum" and "Gold" case most of the time, but sometimes there are cases where native dll overrides happen automagically as a result of app installed installing third-party lib redists himself. Good example is idSoftware's Rage game which require XAudio2 to functions - which is not implemented in Wine. User would have to install and use native lib for game to function, but most of the times it would be done automatically by Steam (its "auto-install required libs" feature would try to install DirectX redist at the first time user would try to launch the game). How should we treat situations like that? From user PoV it's "Platinum" - app is working out of the box. From real side of things - it is "Gold", as native dll override is required for app to function - Wine's stubbed xaudio2 implementation is obviously not enough for game to work. With the recent release of Diablo III we're are at the same spot: game installer auto-installs vcrun2008 redist as a part of installation process, so end-user experience is like this game "works out of a box". Problem is that D3 installed isn't working unless user patches Wine's AcceptEx implementation with Erichs patchset, so for vast majority of Wine's userbase installing D3 would be something like "copy already installed D3 from other PC" - and that would bring the problem of the game requiring native VC++ 2008 runtime on the surface. How should we treat/assign ratings for these cases? P.S. Aside from that, I want to once again bring up the discussion on extending AppDB so more detailed test reports would be possible. IMO it might be reasonable to add to AppDB test report form is an ability to specify whether the version used was "vanilla" or "patched with some out-of-tree patches" one. For most reporters sane default would be "vanilla", while at some circumstances most of the test reports would come for "patched" version: good examples are SW:KOTR, WoT, D3 and many other games that require out-of-tree patches to function best under Wine. Thanks for spending your time reading this, and thanks in advance for your answers. - -- Best regards, Alexey Loukianov mailto:mooroon2@mail.ru System Engineer, Mob.:+7(926)218-1320 *nix Specialist -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPs34GAAoJEPB9BOdTkBUL5KMH+gOtjQv1ckZ4tZ9X+kysZ/+0 gM1uCSHvuUdHuY+aVlUs688NU76mJcUu+ORPSuMrdltm7BCn5DbAN3ITjMSf2Y7y KHvvDFbGcKkiDupCyQhdNHpEyfC3PFzWjuI7o8nG/2eZGum5zRwGdbgvDvSc2Qo1 md208/6WDAGNjN2943orolG5pqhKapDvjvpoKSavgW1ykHeKDiTvCiNKXvcRU2ox bRZomHY93DNV0RoLnExcp8HnA/DooWQdGfwF4uTp+wgmIbwbWM4iw3Zw5CuXim+6 VzetXUPU9iVr2h3xqBgmVq5a7rMri7mykDXACo7ex30ekWM9XQBqSgT0jxqIi14= =16iP -----END PGP SIGNATURE-----

3 6

Re: [1/2] wmvcore: Add stub for WMCreateSyncReader (try 2) (resend)
by Nikolay Sivov 16 May '12

16 May '12

On 5/16/2012 19:46, André Hentschel wrote: > + wmsdkidl.idl \ > + wmsbuffer.idl \ This is supposed to be sorted. Also I think you need to add .gitignore changes as well.

1 0

RE: localspl: Only store the file part of the filenames in the registry
by Detlef Riekenberg 16 May '12

16 May '12

Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variable names everywhere in the patch? HP is using a subdirectory for some driver files, but i can't remember the driver name at the moment. -- By by ... Detlef

2 1

re: AppDB, ratings and native vs. builtin trouble
by Dan Kegel 16 May '12

16 May '12

16.05.2012 17:34, Rosanne DiMesio wrote: > If the user didn't have to manually do anything, it should be rated > platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required, and the game works perfectly, it's platinum even if under the hood the game has snuck in a native (and Microsoft-copyrighted) DLL. (DLLs not copyrighted by Microsoft are not generally a concern.) In parallel, people who care about making Wine run without any native DLLs should make sure there's a "purist" bug in wine's bugzilla describing what breaks if you force wine to use its own builtin DLL for the game. (And should then try to fix that bug. :-) - Dan

2 1

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.
by Vincent Povirk 16 May '12

16 May '12

Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data.

2 1

Re: [PATCH 2/2] ieframe: Added GetExternal tests
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18421 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3280: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3402: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3377: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040AE8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2594: Test failed: expected GetOverridesKeyPath webbrowser.c:2599: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2600: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3019: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402FCA

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling
by Nikolay Sivov 16 May '12

16 May '12

On 5/15/2012 22:53, Daniel Jelinski wrote: > > > + PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); > + /* this sequence should NOT send WM_CONTEXTMENU */ > + SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); Please use defined names for wParam and a MAKELPARAM macro to make a coordinate dword. > + test_mouse(); Also this deserves a more descriptive name, something like test_rbutton().

1 0

Re: mstask: Actually run a test and fix the expected behaviour.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

1 0

Re: mstask/tests: Add missing call to the tested function.
by Marvin 16 May '12

16 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18417 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task === W2KPROSP4 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WXPPROSP3 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K3R2SESP2 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === WVISTAADM (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W2K8SE (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PRO (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (32 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === W7PROX64 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000 === TEST64_W7SP1 (64 bit task_trigger) === task_trigger.c:307: Test failed: Expected E_INVALIDARG: 0x00000000

1 0

Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)
by Dmitry Timoshkov 16 May '12

16 May '12

Detlef Riekenberg <wine.dev(a)web.de> wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > + static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("(%p)->(%p, %p, %s, %p)\n", This, pbc, pmkToLeft, debugstr_guid(riid), ppvObj); > > *ppvObj = NULL; > > - if (pbc || pmkToLeft) > + if (pbc != old_bc) > + { > + FIXME("ignoring IBindCtx %p\n", pbc); > + old_bc = pbc; > + } This doesn't look sane. -- Dmitry.

1 0

wine/clang warnings
by Austin English 15 May '12

15 May '12

Howdy, I tried Wine with LLVM/Clang from svn recently, thought others may like some of the results. I've also ran the static analyzer. For reference, this is with: wine-1.5.4-61-g8327e6f, plus the following patch: diff --git a/include/windef.h b/include/windef.h index 9cf98e7..e95388a 100644 --- a/include/windef.h +++ b/include/windef.h @@ -53,7 +53,7 @@ extern "C" { #ifndef __stdcall # ifdef __i386__ # ifdef __GNUC__ -# ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ +# if defined (__APPLE__) || defined (__clang__) /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ # define __stdcall __attribute__((__stdcall__)) __attribute__((__force_align_arg_pointer__)) # else # define __stdcall __attribute__((__stdcall__)) see http://wiki.winehq.org/Clang for more info. Wine was compiled using: #!/bin/bash export CC="clang" export CXX="$CC" export CFLAGS="-g -O0 -std=gnu89 -Wno-conversion -Wno-invalid-source-encoding" ./configure -Wno-invalid-source-encoding, because clang does not like our encoding of strings in winex11/keyboard.c. There are 851 warnings of: clang -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/usr/include/freetype2 -g -O0 -std=gnu89 -Wno-conversion -o keyboard.o keyboard.c keyboard.c:267:17: warning: illegal character encoding in string literal [-Winvalid-source-encoding] "`","1!","2\"","3<A3>","4$","5%","6^","7&","8*","9(","0)","-_","=+", The static analyzer found 2231 bugs (--disable-tests was used). http://www.sendspace.com/file/qsbv3k austin@aw21 ~ $ du -h scan-build-2012-05-15-2.tar.bz2 42M scan-build-2012-05-15-2.tar.bz2 austin@aw21 ~ $ sha1sum scan-build-2012-05-15-2.tar.bz2 442cf6faddb45515792d116717c992282496dfbe scan-build-2012-05-15-2.tar.bz2 Cheers, Austin

1 0

Re: comctl32: Fix message sequence when right-clicking a treeview
by Nikolay Sivov 15 May '12

15 May '12

On 5/15/2012 21:30, Daniel Jelinski wrote: > Patch dropped out of the pending list, resending. Please add a test for this fix.

2 2

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation (try2)
by Alexandre Julliard 15 May '12

15 May '12

Piotr Caban <piotr(a)codeweavers.com> writes: > This patch serie is based on Andrew Eikum's and Rein Klazes's work. > --- > dlls/user32/menu.c | 94 > ++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 87 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:11511: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:12297: Test failed: popup menu command: 17: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12297: Test failed: popup menu command: 18: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12297: Test failed: popup menu command: 19: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12297: Test failed: popup menu command: 21: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12297: Test failed: popup menu command: 22: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12315: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12315: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12315: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12315: Test failed: submenu of a popup menu command: 28: the msg 0x0126 was expected, but got msg 0x0212 instead msg.c:12315: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0126 instead msg.c:12315: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 msg.c:12363: Test failed: submenu of a popup menu command: 22: the msg 0x0004 was expected, but got msg 0x0125 instead msg.c:12363: Test failed: submenu of a popup menu command: 23: the msg 0x0125 was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 26: the msg 0x011f was expected, but got msg 0x0004 instead msg.c:12363: Test failed: submenu of a popup menu command: 27: the msg 0x0212 was expected, but got msg 0x011f instead msg.c:12363: Test failed: submenu of a popup menu command: 28: the msg 0x0111 was expected, but got msg 0x0212 instead msg.c:12363: Test failed: submenu of a popup menu command: 30: the msg 0x0101 was expected, but got msg 0x0111 instead msg.c:12363: Test failed: submenu of a popup menu command: 31: the msg sequence is not complete: expected 0000 - actual 0101 make[1]: *** [msg.ok] Error 19 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Forward AddAttachedSurface to the correct equivalent
by Stefan Dösinger 15 May '12

15 May '12

Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > + hr = ddraw_surface3_AddAttachedSurface(&This- >IDirectDrawSurface3_iface, > + attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7. Do you have tests or bug reports to back this up?

3 3

Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > - > - TRACE("Mixed at least %d from all buffers\n", minlen); > - return minlen; Hi. You have removed the message that could say "Mixed at least 0 from all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for foobar2000). What was the reason for that "0" (or, rather, 1024, 1024, 1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed by your patch? (this mail is a question, not an objection) -- Alexander E. Patrakov

2 1

Re: [PATCH 1/4] dsound: Change mix_buffer to float instead of INT
by Alexander E. Patrakov 15 May '12

15 May '12

Andrew Eikum wrote: > +static LONG f_to_24(float value) > +{ > if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFF / 0x800000) > + return 0x7FFFFF00; > + return lrintf(value * 0x80000000U); > } ... > +static inline LONG f_to_32(float value) > +{ > + if(value <= -1.f) > + return 0x80000000; > + if(value >= 1.f * 0x7FFFFFFF / 0x80000000U) /* this rounds to 1.f */ > + return 0x7FFFFFFF; > + return le32(lrintf(value * 0x80000000U)); > +} [sorry for a possible duplicate, the previous mail contained a typo] Minor nitpick: I'd say these functions are identical on little-endian systems if the least significant bits are discarded. Are you sure that we indeed want two functions here, and not, say, use f_to_32() in put24()? -- Alexander E. Patrakov

1 0

Wine Mono 0.0.4 Release - I'm serious now!
by Vincent Povirk 14 May '12

14 May '12

I have published version 0.0.4 of Wine Mono on Sourceforge. I fully intend to make this release a part of Wine. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.4/wine-mono-0.0.… For developers, the source repository is at https://github.com/madewokherd/wine-mono Changes since 0.0.2: * With Wine 1.5.4 and Wine Mono 0.0.4, it's now possible to run mixed-mode assemblies. * The random hang that was introduced in Mono 2.11 is now fixed (0.0.2 contained a hacky work-around). * A replacement for XNA 4.0 based on MonoGame is now included, to be used if MS XNA 4.0 is not installed. * Updated Mono from 2.11.0 to 2.11.1, bringing in the changes listed here: http://mono.1490590.n4.nabble.com/Mono-2-11-1-is-out-td4575466.html * Changes from Hans Leidekker to make upgrading and removing the msi work better. * Added more registry keys to prevent native .NET from trying to install while Wine Mono is installed. * Various improvements to the build script. Some programs that worked with the official Mono for Windows package will fail with this one because gluezilla (Mono's web browser component) is missing. In all other respects I expect this to work as well as or better than the official Mono for Windows package, and if not I'd like to hear about it. If nothing new seems to be horribly wrong with this build other than the lack of gluezilla, I will try to make it an official part of Wine. It's not really clear where the bugs should be reported at the moment, but I think Wine bugzilla is appropriate.

1 0

XINPUT JOYSTICK PATCH
by Giovanni Ongaro 14 May '12

14 May '12

I have written a modification of the xinput1_3 dll that simulates xbox joystick with a logitech rumblepad 2 joystick,also provided is a way to disable dinput joysticks through an environment variable, it seems to work well,may it be of interest to the wine project?

2 1

Re: wmvcore: Add stub for WMCreateSyncReader
by Nikolay Sivov 14 May '12

14 May '12

On 5/14/2012 19:34, André Hentschel wrote: > Otherwise GTA San Andreas runs into it and crashes. This stub let's it work again. > a workaround is to disable wmvcore in winecfg... > --- > dlls/wmvcore/wmvcore.spec | 2 +- > dlls/wmvcore/wmvcore_main.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/dlls/wmvcore/wmvcore.spec b/dlls/wmvcore/wmvcore.spec > index 1c6cb1f..e0fa2e9 100644 > --- a/dlls/wmvcore/wmvcore.spec > +++ b/dlls/wmvcore/wmvcore.spec > @@ -11,7 +11,7 @@ > @ stub WMCreateProfileManager > @ stub WMCreateReader > @ stub WMCreateReaderPriv > -@ stub WMCreateSyncReader > +@ stdcall WMCreateSyncReader(ptr long ptr) > @ stub WMCreateWriter > @ stub WMCreateWriterFileSink > @ stub WMCreateWriterNetworkSink > diff --git a/dlls/wmvcore/wmvcore_main.c b/dlls/wmvcore/wmvcore_main.c > index 096328b..5fce972 100644 > --- a/dlls/wmvcore/wmvcore_main.c > +++ b/dlls/wmvcore/wmvcore_main.c > @@ -22,6 +22,7 @@ > > #include "windef.h" > #include "winbase.h" > +#include "objbase.h" > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(wmvcore); > @@ -43,3 +44,10 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > return TRUE; > } > + > +HRESULT WINAPI WMCreateSyncReader(IUnknown *pcert, DWORD rights, > + IUnknown /* FIXME: IWMSyncReader */ **syncreader) > +{ > + FIXME("(%p, %x, %p): stub\n", pcert, rights, syncreader); > + return E_NOTIMPL; > +} You'll be probably requested to add a proper .idl for that with interface definition. Also it makes sense to init out parameter to 0, as a common practice for such creation methods/calls. >

1 0

Re: [1/2] gdiplus: Measure the passed in string without height clipping in order to compute correct Y offset. Take 3.
by Vincent Povirk 14 May '12

14 May '12

Looks good to me.

1 0

Re: Using an IDE on Wine?
by Michael Ost 14 May '12

14 May '12

On 5/13/12 10:00 AM, wine-devel-request(a)winehq.org wrote: > How many of you use an Integrated Development Environment (IDE) when > working on Wine? > > If you do, which one do you use and how, how useful is it and how hard > was it to set up? I use Qt Creator for Linux for our winelib application. Our app is a hybrid winelib + Qt/X11 app, so we get the extra Qt "goodies" with Qt Creator. But it does work for other project types too. Getting the integrated gdb debugger to work was a trick. The main thing is to set WINELOADERNOEXEC=1 in the environment and run /usr/bin/wine as the debuggee. We also built and copied in a debug version of /usr/bin/wine to keep Qt Creator from complaining when a debug session got underway. The last "gotcha" was that we had to hack out alpha channel support for cursors when running under GDB. (IIRC) the DIB engine uses segfaults in normal operation which confuses GDB. I can send along that patch if you are interested. Of course, if you are trying to debug a straight windows application then all of this is irrelevant! But if you are doing winelib, then these tricks can help. -- Michael Ost

1 0

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset. Take 2.
by Vincent Povirk 14 May '12

14 May '12

If the string wraps, and you don't give the width to GdipMeasureString, won't it return a too small height? On Mon, May 14, 2012 at 9:11 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > GdipMeasureString() clips the string extents to passed rectangle width and > height, but that leads to wrong offsety calculation if the string doesn't > fit into that rectangle. > --- > dlls/gdiplus/graphics.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 38335a8..1c9780d 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -5162,14 +5162,18 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > /* Should be no need to explicitly test for StringAlignmentNear as > * that is default behavior if no alignment is passed. */ > if(format->vertalign != StringAlignmentNear){ > + static const RectF empty_rect = { 0.0, 0.0, 0.0, 0.0 }; > RectF bounds; > - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &empty_rect, format, &bounds, 0, 0); > + > + TRACE("bounds %s\n", debugstr_rectf(&bounds)); > > if(format->vertalign == StringAlignmentCenter) > offsety = (rect->Height - bounds.Height) / 2; > else if(format->vertalign == StringAlignmentFar) > offsety = (rect->Height - bounds.Height); > } > + TRACE("vertical align %d, offsety %f\n", format->vertalign, offsety); > } > > save_state = SaveDC(hdc); > -- > 1.7.10.1 > > >

2 3

Re: [PATCH 1/5] d3dcompiler: Make SlWriteBytecode return the shader size.
by Stefan Dösinger 14 May '12

14 May '12

Am Montag, 14. Mai 2012, 17:24:01 schrieb Matteo Bruni: > - CopyMemory(pos, messages, strlen(messages) + 1); > + memcpy(pos, messages, strlen(messages) + 1); > ... > - if (shader == NULL) > + if (!shader) This looks unrelated. The changes are OK, but should be in another patch.

1 0

Re: [1/3] user32/tests: Add GetUserObjectInformation tests
by Alexandre Julliard 14 May '12

14 May '12

Owen Rudge <orudge(a)codeweavers.com> writes: > There appears to be a bug in the GetUserObjectInformationA function on > Windows that results in an incorrect buffer length being returned when > the buffer size provided by the caller is insufficient. The 'A' > function returns the Unicode length instead of the ANSI length. These > patches modify Wine's behaviour to provide that incorrect > behaviour. They also fix an issue whereby the wrong error code is set > when the buffer is too short. Using the number of Unicode chars multiplied by 2 is a reasonable upper bound on the A string size, and it's used in a number of places. This can't really be considered a Windows bug. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.
by Vincent Povirk 14 May '12

14 May '12

> - GdipMeasureString(graphics, string, length, font, rect, format, &bounds, 0, 0); > + GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0); You probably shouldn't use the same GpRect* for both parameters there.

2 3

Re: msxml3: avoid a dangling else (LLVM/Clang)
by Michael Stefaniuc 14 May '12

14 May '12

Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 6805c75..14fd01b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( > > /* skip leading spaces if needed */ > if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26) > + { > while (*ptr) > if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the "else" on a separate line. > + } > > xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE); > if ( !xmldoc ) bye michael

2 2

Re: wininet: Fixed typo in tests and accompanying implementation
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18349 Your paranoid android. === W7PROX64 (64 bit http) === http.c:2853: Test failed: HttpSendRequest failed: 12002

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Jacek Caban 14 May '12

14 May '12

Hi Austin, On 05/14/12 08:19, Austin English wrote: > clang -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits > -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith > -I/usr/include/freetype2 -g -O0 -std=gnu89 -o http.o http.c > http.c:212:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > http.c:212:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_NUMBER, &code, &size, &index); > ^~~~~~~~~~~~~~~~~~~~~~~~ > | > http.c:218:52: warning: use of logical '||' with constant operand > [-Wconstant-logical-operand] > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > ^ > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > http.c:218:52: note: use '|' for a bitwise operation > res = HttpQueryInfo(req, > HTTP_QUERY_STATUS_CODE||HTTP_QUERY_FLAG_REQUEST_HEADERS, &code, &size, > NULL); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Thanks for the patch. The problem found by those warnings was more serious as we were tested a wrong thing, causing the implementation to be wrong. That said, we need to fix tests and implementation as well. I've sent a patch. Thanks, Jacek

1 0

Re: wininet/tests: fix a compiler warning on LLVM/Clang
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18347 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K3R2SESP2 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === WVISTAADM (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W2K8SE (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PRO (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (32 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === W7PROX64 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) === TEST64_W7SP1 (64 bit http) === http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154) http.c:1920: Test failed: HttpQueryInfo failed: 0(12154) http.c:1970: Test failed: HttpQueryInfo failed: 0(12154) http.c:2021: Test failed: HttpQueryInfo failed: 0(12154) http.c:2076: Test failed: HttpQueryInfo failed: 0(12154) http.c:2086: Test failed: HttpQueryInfo failed: 0(12154) http.c:2096: Test failed: HttpQueryInfo failed: 0(12154) http.c:2106: Test failed: HttpQueryInfo failed: 0(12154) http.c:2350: Test failed: HttpQueryInfo failed: 0(12154) http.c:2380: Test failed: HttpQueryInfo failed: 0(12154) http.c:2406: Test failed: HttpQueryInfo failed: 0(12154) http.c:2456: Test failed: HttpQueryInfo failed: 0(12154) http.c:2541: Test failed: HttpQueryInfo failed: 0(12154) http.c:476: Test failed: HttpQueryInfo failed: 0(12154)

1 0

Re: [2/2] msxml3: Support iso-8859-x encodings in writer
by Marvin 14 May '12

14 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18346 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-4: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-5: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-7: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-9: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-13: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?> === WXPPROSP3 (32 bit saxreader) === saxreader.c:3759: Test failed: got 0x80004005, expected 0x00000000 saxreader.c:3780: Test failed: iso-8859-3: got <?xml version="1.0" encoding="iso-8859-2" standalone="no"?>

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: jscript/tests: Fix the spelling of the testEmbeddedFunctions() function name.
by Marvin 13 May '12

13 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18345 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Using an IDE on Wine?
by Max TenEyck Woodbury 13 May '12

13 May '12

How many of you use an Integrated Development Environment (IDE) when working on Wine? If you do, which one do you use and how, how useful is it and how hard was it to set up? Max

4 3

re: Using an IDE on Wine?
by Dan Kegel 13 May '12

13 May '12

I suspect most people don't use IDEs with wine. Someone recently posted how to use eclipse during debugging, though: http://www.winehq.org/pipermail/wine-devel/2012-April/095162.html

1 0

Re: d3dx9_36: Equality between floats is too strict.
by Marvin 12 May '12

12 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18337 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K3R2SESP2 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === WVISTAADM (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W2K8SE (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PRO (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (32 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === W7PROX64 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0 === TEST64_W7SP1 (64 bit math) === math.c:2343: Test failed: 0-0: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 1-1: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 2-4: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 3-9: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 4-16: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 5-25: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 6-36: D3DXSHAdd() failed, got 0.000000, expected 0.0 math.c:2343: Test failed: 7-49: D3DXSHAdd() failed, got 0.000000, expected 0.0

1 0

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Stefan Dösinger 12 May '12

12 May '12

Am Mittwoch, 9. Mai 2012, 23:32:05 schrieb Józef Kucia: > + *pitch = width * format_desc->bytes_per_pixel; > + *size = *pitch * height; Usually surface pitches are either 4 or 8 byte aligned(depending on the API and pool). I recommend to write some tests for this. The most likely problematic formats are D3DFMT_P8, any 16 bit format like R5G6B5 and 24 bit R8G8B8. Maybe you're supposed to honor the pitch_or_linear_size member of the DDSURFACEDESC.

3 5

Re: [PATCH 1/3] user32: Added GetMenuBarInfo implementation
by Alexandre Julliard 12 May '12

12 May '12

Piotr Caban <piotr(a)codeweavers.com> writes: > + __TRY > + { > + mbi.cbSize = pmbi->cbSize; > + if (mbi.cbSize == sizeof(MENUBARINFO)) > + memcpy(pmbi, &mbi, sizeof(MENUBARINFO)); > + } > + __EXCEPT_PAGE_FAULT > + { > + SetLastError(ERROR_NOACCESS); > + return FALSE; > + } > + __ENDTRY Do you really have an app that requires an exception handler? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] d3dx9: Forward D3DXSaveSurfaceToFileA to D3DXSaveSurfaceToFileW.
by Józef Kucia 11 May '12

11 May '12

On Wed, May 2, 2012 at 2:55 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > --- > dlls/d3dx9_36/surface.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c > index 44d4e06..70627fd 100644 > --- a/dlls/d3dx9_36/surface.c > +++ b/dlls/d3dx9_36/surface.c > @@ -1364,11 +1364,27 @@ HRESULT WINAPI D3DXLoadSurfaceFromSurface(LPDIRECT3DSURFACE9 pDestSurface, > } > > > -HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > - LPDIRECT3DSURFACE9 pSrcSurface, const PALETTEENTRY* pSrcPalette, const RECT* pSrcRect) > +HRESULT WINAPI D3DXSaveSurfaceToFileA(LPCSTR dst_filename, D3DXIMAGE_FILEFORMAT file_format, > + IDirect3DSurface9 *src_surface, const PALETTEENTRY *src_palette, const RECT *src_rect) > { > - FIXME("(%p, %d, %p, %p, %p): stub\n", pDestFile, DestFormat, pSrcSurface, pSrcPalette, pSrcRect); > - return D3DERR_INVALIDCALL; > + int len; > + LPWSTR filename; > + HRESULT hr; > + > + TRACE("(%s, %d, %p, %p, %p): relay\n", > + wine_dbgstr_a(dst_filename), file_format, src_surface, src_palette, src_rect); > + > + if (!dst_filename) return D3DERR_INVALIDCALL; > + > + len = MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, NULL, 0); > + filename = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len * sizeof(WCHAR)); > + if (!filename) return E_OUTOFMEMORY; > + MultiByteToWideChar(CP_ACP, 0, dst_filename, -1, filename, len); > + > + hr = D3DXSaveSurfaceToFileW(filename, file_format, src_surface, src_palette, src_rect); > + > + HeapFree(GetProcessHeap(), 0, filename); > + return hr; > } > > HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR pDestFile, D3DXIMAGE_FILEFORMAT DestFormat, > -- > 1.7.8.6 > This mail is the lost mail from 2nd May. Please ignore it.

1 0

Re: [PATCH 1/2 resend] mshtml.idl: Added DispHTMLHistory declaration
by Jacek Caban 11 May '12

11 May '12

There must have been some problem with mail servers. These mails were sent last week and should replace already committed patches. The fix from try 2 (fixing tests on old IEs) is also already committed. Cheers, Jacek

1 0

Re: [1/8] d3dx9: Add missing pixel formats.
by Matteo Bruni 11 May '12

11 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c > index 4dbf44c..ad8a6ea 100644 > --- a/dlls/d3dx9_36/util.c > +++ b/dlls/d3dx9_36/util.c > @@ -62,6 +62,7 @@ static const PixelFormatDesc formats[] = > {D3DFMT_G16R16, {0, 16, 16, 0}, { 0, 0, 16, 0}, 4, 1, 1, 4, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8, {8, 0, 0, 0}, { 0, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_A8L8, {8, 8, 0, 0}, { 8, 0, 0, 0}, 2, 1, 1, 2, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > + {D3DFMT_A4L4, {4, 4, 0, 0}, { 4, 0, 0, 0}, 1, 1, 1, 1, FORMAT_ARGB, la_from_rgba, la_to_rgba}, > {D3DFMT_DXT1, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 8, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT2, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, > {D3DFMT_DXT3, {0, 0, 0, 0}, { 0, 0, 0, 0}, 1, 4, 4, 16, FORMAT_ARGB, NULL, NULL }, I guess it would make sense to add all the new pixel formats to the table, assuming it doesn't break the tests or other stuff.

3 2

Re: [PATCH 3/4] dmusic: COM cleanup of IReferenceClock.
by Nikolay Sivov 11 May '12

11 May '12

On 5/11/2012 09:19, Christian Costa wrote: > > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h > index 73a05d4..96334c9 100644 > --- a/dlls/dmusic/dmusic_private.h > +++ b/dlls/dmusic/dmusic_private.h > @@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(REFIID riid, LPVOID *ppobj, LPUNK > * IReferenceClockImpl implementation structure > */ > struct IReferenceClockImpl { > - /* IUnknown fields */ > - const IReferenceClockVtbl *lpVtbl; > - LONG ref; > + /* IUnknown fields */ > + IReferenceClock IReferenceClock_iface; > + const IReferenceClockVtbl *lpVtbl; You forgot to remove that, right? > + LONG ref; > > >

2 1

Re: Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.
by Charles Davis 11 May '12

11 May '12

On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b741… > > Author: Vincent Povirk <vincent(a)codeweavers.com> > Date: Tue May 8 10:49:22 2012 -0500 > > windowscodecs: Add wrapper functions for IWICPalette methods. I have to say, these patches all seem really mechanical. Correct me if I'm wrong, but I think MIDL has an option to generate the proxy wrappers automatically. Even if it doesn't, I'm sure this would be a good feature to add to widl (if we don't already have it) so we don't have to laboriously write and maintain each and every one of the proxy wrappers. Chip

2 1

Re: [PATCH 2/2 try 2] mshtml: Added IHTMLWindow2::get_history implementation
by Marvin 10 May '12

10 May '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18319 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

GSoC Joystick Configuration Tools
by Lucas Zawacki 10 May '12

10 May '12

Hello all, I'll use this thread to post information and ask questions regarding my GSoC project. First there's a wiki which aggregates some information and lists tasks I'm working on: http://lfzawacki.heroku.com/wine/published/HomePage Then there's a github repo: https://github.com/lfzawacki/wine-joysticks In the repository you'll find the different tools I'll be implementing. They can be easily built and tested, even before they make it into wine. At the moment there's an intial version of the command line joystick tester. This tool is useful for listing connected joysticks, testing if they work correctly in wine, testing axis remapping, watching for dinput trace messages, etc... It's also the basis for the joystick testing GUI. I'll start cleaning up, splitting this code and commiting it to wine next week. For now I'll make a similar tool to this one that tests force feedback. I'll try to make it in the style of the Linux fftest program, but using the dinput interfaces so that a user can test the differences. Cheers, Lucas

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Józef Kucia 10 May '12

10 May '12

On Wed, May 9, 2012 at 11:32 PM, Józef Kucia <joseph.kucia(a)gmail.com> wrote: > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index ab56593..3d5a50f 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -917,6 +917,20 @@ static void test_D3DXCreateVolumeTexture(IDirect3DDevice9 *device) > } > } > > +static void test_D3DXCreateTextureFromFileInMemory(IDirect3DDevice9 *device) > +{ > + HRESULT hr; > + IDirect3DTexture9 *texture; > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_16bit, sizeof(dds_16bit), &texture); > + ok(hr == D3D_OK, "D3DCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > + > + hr = D3DXCreateTextureFromFileInMemory(device, dds_24bit, sizeof(dds_24bit), &texture); > + ok(hr == D3D_OK, "D3DXCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); > + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); > +} > + I noticed that I put more and more texture functions tests in tests/surface.c, because these tests needs the dds files which are in tests/surface.c. I wonder if it would be better to copy needed dds files to tests/texture.c and move texture function tests to their proper place. I think the dds files could be used to tests other texture functions, e.g. D3DXCreateTextureFromFileInMemoryEx doesn't seem to have any tests.

2 1

Re: [1/5] gdiplus: Retrive LOGFONT from a GpFont using GdipGetLogFontW instead of accessing it directly.
by Alexandre Julliard 10 May '12

10 May '12

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -4926,12 +4925,15 @@ GpStatus WINGDIPAPI GdipMeasureCharacterRanges(GpGraphics* graphics, > TRACE("(%p %s %d %p %s %p %d %p)\n", graphics, debugstr_w(string), > length, font, debugstr_rectf(layoutRect), stringFormat, regionCount, regions); > > - if (!(graphics && string && font && layoutRect && stringFormat && regions)) > + if (!graphics || !string || !font || !layoutRect || !stringFormat || !regions) > return InvalidParameter; Please avoid mixing that sort of gratuitous change with the real changes. > + stat = GdipGetLogFontW((GpFont *)font, graphics, &lfw); > + if (stat != Ok) return stat; I'm not sure it's an improvement, since you need to add these ugly casts. You should find a way that doesn't require that. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions (try 4)
by Juan Lang 10 May '12

10 May '12

Hi Alex, first, thanks for taking the time to respond to feedback. Showing responsiveness helps a great deal. Next, on your patch: I'm trying to help you get this committed, so this is meant to be constructive feedback. +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR src, + INT srclen, LPSTR dst, INT dstlen, + LPCSTR defchar, BOOL* used, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + WideCharToMultiByte(page, flags, src, srclen, dst, dstlen, defchar, used); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} + +static void test_MultiByteToWideChar_error(UINT page, DWORD flags, LPCSTR src, + INT srclen, LPWSTR dst, INT dstlen, + const char* test_description, + DWORD expected_error) +{ + SetLastError(ERROR_SUCCESS); + MultiByteToWideChar(page, flags, src, srclen, dst, dstlen); + ok(GetLastError() == expected_error, + "codepage %i, %s, expected error %i got error %i\n", page, + test_description, expected_error, GetLastError()); +} These helpers don't really gain you anything here, there's really not enough code to be worth using helpers. Please just copy/paste the changes everyplace you're currently using them. Also, a common convention we use is to set last error to 0xdeadbeef prior to a test we expect to set last error on failure. Thanks, --Juan

2 1

Re: [PATCH] winmm: Don't call MMDevAPI during process exit
by Alexandre Julliard 10 May '12

10 May '12

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > This fixes bug 30631, introduced by > 31291cdc6ccc4c172ccf86f383c6a90f31a50ba1. > > In addition to safely exiting on process exit, we do much more > thorough cleanup on process detach. There shouldn't be any reason to do cleanup on process exit (and you can't really do anything reliably at that point anyway). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/8] d3dx9: Add DDS support in D3DXCreateTextureFromFile functions.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) DECLSPEC_HIDDEN; ... > +HRESULT load_texture_from_dds(IDirect3DTexture9 *texture, const void *src_data, UINT srd_data_size, > + const PALETTEENTRY *palette, DWORD filter, D3DCOLOR color_key, const D3DXIMAGE_INFO *src_info) I guess that was meant to be called "src_data_size". More to the point, anyway, you're not using that value right now, you should probably add a check against it or remove the parameter altogether.

2 1

Re: [4/8] d3dx9: Implement D3DXCreateCubeTextureFromFileInMemoryEx.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > + mip_levels = min(src_info->MipLevels, IDirect3DCubeTexture9_GetLevelCount(cube_texture)); > + for (face = D3DCUBEMAP_FACE_POSITIVE_X; face <= D3DCUBEMAP_FACE_NEGATIVE_Z; face++) > + { > + size = src_info->Width; > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; > + > + SetRect(&src_rect, 0, 0, size, size); > + > + IDirect3DCubeTexture9_GetCubeMapSurface(cube_texture, face, mip_level, &surface); > + hr = D3DXLoadSurfaceFromMemory(surface, palette, NULL, pixels, src_info->Format, src_pitch, > + NULL, &src_rect, filter, color_key); > + IDirect3DSurface9_Release(surface); > + if (FAILED(hr)) return hr; > + > + pixels += mip_level_size; > + size = max(1, size / 2); > + } > + > + /* if texture has fewer mip levels than DDS file, skip excessive mip levels */ > + while (mip_level < src_info->MipLevels) > + { > + calculate_dds_surface_size(src_info, size, size, &src_pitch, &mip_level_size); > + pixels += mip_level_size; > + size = max(1, size / 2); > + mip_level++; > + } > + } Really a nitpick, you could merge the "while" into the "for" loop above. > + if ((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && (pool != D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC)) > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, pool, &tex); > + buftex = NULL; > + } > + else > + { > + hr = D3DXCreateCubeTexture(device, size, mip_levels, usage, format, D3DPOOL_SYSTEMMEM, &buftex); > + tex = buftex; > + } The "if" condition doesn't look correct to me, since e.g. you don't need a temporary texture if pool == D3DPOOL_DEFAULT and usage == D3DUSAGE_DYNAMIC.

2 1

Re: [2/8] d3dx9: Check the size of a DDS file in D3DXGetImageInfoFromFileInMemory.
by Matteo Bruni 10 May '12

10 May '12

2012/5/9 Józef Kucia <joseph.kucia(a)gmail.com>: > +static HRESULT get_image_info_from_dds(const void *buffer, UINT length, D3DXIMAGE_INFO *info) > { > + UINT i; > + UINT faces = 0; ... > + /* calculate the expected length */ > + width = info->Width; > + height = info->Height; > + for (i = 0; i < info->MipLevels; i++) > + { > + UINT pitch, size = 0; > + calculate_dds_surface_size(info, width, height, &pitch, &size); > + expected_length += size; > + width = max(1, width / 2); > + height = max(1, width / 2); > + } > + > + if (length < expected_length) > + return D3DXERR_INVALIDDATA; It looks like you're not actually using the faces variable.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel