- wine-devel - winehq.org

Re: [PATCH 5/7] jscript: Don't pass EXPR_NEWREF to name expression in array_expression_eval
by Marvin 15 Dec '11

15 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15993 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] jscript: Throw type error on invalid delete
by Marvin 15 Dec '11

15 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15992 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: kernel32: Add the tests for various combinations of CreateFileMapping/MapViewOfFile protections.
by Marvin 15 Dec '11

15 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15981 Your paranoid android. === W2KPROSP4 (32 bit virtual) === virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 === WXPPROSP3 (32 bit virtual) === virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 === W2K3R2SESP2 (32 bit virtual) === virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 virtual.c:2104: Test failed: VirtualProtect error 87 === WVISTAADM (32 bit virtual) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: Patch for #29144
by Damian Ivanov 15 Dec '11

15 Dec '11

Thank you! I'll test it and include it with my this Saturday. Best regards On Dec 1, 2011 10:50 AM, "Aurélien COUDERC" <zecoucou(a)free.fr> wrote: > Please find an attached patch for #29144. > > It probably fixes a hole range of freezes with fglrx (Tested on Sykrim and > Might & Magic Heroes VI for instance). > > Regards, > Aurélien > > > >

1 1

wined3d crosscompiling, implementing loadICD
by Patrick Rudolph 14 Dec '11

14 Dec '11

Hi, I'm trying to get ddraw/d3d7 running in my virtual WindowsXP machine using wined3d. I managed to cross-compile all neccessary files and implemented a function that loads the ICD instead of opengl32.dll. The name of the ICD is stored in the registry, so my functions just searches the registry for the correct key, depending on the OS version. What name should i choose for this function ? Where to place this function ? I'm not sure if directx.c is a good place for it. At the moment this function returns a handle to the loaded ICD. Would it be better to return the name of the ICD dll (for testing purposes) ? Regards, Patrick

2 1

Re: [12/12]usp10: add Private Use Area and Surrogates Area from Unicode Chapter 16
by Marvin 14 Dec '11

14 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15958 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [11/12]usp10: add Braille script
by Marvin 14 Dec '11

14 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15957 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [7/12]usp10: add Cherokee script
by Marvin 14 Dec '11

14 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15953 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] include: Update the nldef.h and *mib.h headers.
by Alexandre Julliard 14 Dec '11

14 Dec '11

Francois Gouget <fgouget(a)free.fr> writes: > Make use of the new types and update Wine's code as appropriate. > --- > > I think the new types can potentially bring more type safety and more > readable code. There are lots of #ifdefs in that code, please make sure you try to build on all supported platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msxml3: Added IXMLDOMParseError2 support
by Marvin 14 Dec '11

14 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15935 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 0042BD6E === W2K3R2SESP2 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 0042BD6E

1 0

Re: [PATCH 1/5] ddraw: Move clipper handling to ddraw.
by Stefan Dösinger 13 Dec '11

13 Dec '11

Am Montag, 12. Dezember 2011, 20:53:55 schrieb Henri Verbeet: > --- a/dlls/wined3d/clipper.c > +++ /dev/null Assuming that msdn[1] is correct, implies that we'll have to move overlays to ddraw as well. I'm not opposed to that, just mentioning it. In fact I'm actually inclined to move the overlay blits to ddraw, but I'm not sure yet because they have some similarities to d3d8/9 software cursors. If we move overlays to ddraw this also means the ddraw shadow frontbuffer is here to stay. 1: http://msdn.microsoft.com/en- us/library/windows/desktop/gg426213(v=VS.85).aspx

2 1

Re: [PATCH 2/4] d3dx9: Implement ID3DXBaseEffect::SetVector().
by Matteo Bruni 13 Dec '11

13 Dec '11

Hi Rico, 2011/12/13 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/effect.c | 52 > +++++++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 49 insertions(+), 3 deletions(-) > > +static void set_vector(struct d3dx_parameter *param, CONST D3DXVECTOR4 *vector) > +{ > + set_number((float *)param->data, param->type, vector, D3DXPT_FLOAT); > + if (param->columns > 1) set_number((FLOAT *)param->data + 1, param->type, (FLOAT *)vector + 1, D3DXPT_FLOAT); > + if (param->columns > 2) set_number((FLOAT *)param->data + 2, param->type, (FLOAT *)vector + 2, D3DXPT_FLOAT); > + if (param->columns > 3) set_number((FLOAT *)param->data + 3, param->type, (FLOAT *)vector + 3, D3DXPT_FLOAT); > +} Can't you use a for loop instead? While you're at it, you should also pick one between "float" and "FLOAT".

2 1

Re: [PATCH 4/4] d3dx9: Implement ID3DXBaseEffect::SetValue().
by Matteo Bruni 13 Dec '11

13 Dec '11

2011/12/13 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dx9_36/effect.c | 42 ++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 40 insertions(+), 2 deletions(-) > > + TRACE("Copy %u bytes\n", param->bytes); > + memcpy(param->data, data, bytes); That trace is not correct.

1 0

Re: [PATCH 2/5] ddraw: Add support for clipped blits.
by Stefan Dösinger 13 Dec '11

13 Dec '11

Am Montag, 12. Dezember 2011, 20:53:56 schrieb Henri Verbeet: > + if (!dst_surface->clipper) I think some tests would be a good idea, e.g. if clippers work on offscreen surfaces or backbuffers, or what happens when a D3D render target has a clipper attached. Msdn also suggests that BltFast fails if the surface has a clipper attached.

1 0

Re: [PATCH] comdlg32: Remove system menu from Find and Replace dialogs
by Dmitry Timoshkov 13 Dec '11

13 Dec '11

2 1

Re: [1/6] gdi32/tests: Add tests for vertical font. (try 3)
by Alexandre Julliard 12 Dec '11

12 Dec '11

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > vertical.sfd and vertical.ttf were generated from > M+ 1p regular (http://mplus-fonts.sourceforge.jp/) > by the following fontforge script. I'm getting a failure here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:4129: Test succeeded inside todo block: @WineTestVertical is not installed make: *** [font.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] jscript: Properly handle NULL IDispatch in stack_pop_object
by Marvin 12 Dec '11

12 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15897 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] jscript: Don't use EXPR_NEWREF in forin_statement_event
by Marvin 12 Dec '11

12 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15896 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] jscript: Don't use EXPR_NEWREF in for_statement_event
by Marvin 12 Dec '11

12 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15895 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH] user32: Remove system menu from Yes/No/Cancel dialog
by Dmitry Timoshkov 12 Dec '11

12 Dec '11

1 0

Re: [PATCH 1/3] wined3d: Relax depth blit requirements
by Henri Verbeet 09 Dec '11

09 Dec '11

On 9 December 2011 12:54, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This fixes bug 10636. A proper commit message would be a good start. > + BOOL in_scene; A test to show that this is actually needed for d3d9 wouldn't hurt. The condition in wined3d is there because it was already there when we actually implemented depth blits, but it's probably a leftover from your original ddraw code or something.

2 2

Re: [PATCH 3/3] d3d8/tests: Port the depth blit test to d3d8
by Henri Verbeet 09 Dec '11

09 Dec '11

On 9 December 2011 12:54, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + d3d = pDirect3DCreate8(D3D_SDK_VERSION); > + ok(d3d != NULL, "Direct3DCreate8 failed.\n"); > + hwnd = CreateWindow("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, 100, 100, 160, 160, NULL, NULL, NULL, NULL); > + ok(hwnd != NULL, "CreateWindow failed.\n"); > + if (!d3d || !hwnd) > + goto cleanup; > + > + IDirect3D8_GetAdapterDisplayMode(d3d, D3DADAPTER_DEFAULT, &d3ddm); > + ZeroMemory(&d3dpp, sizeof(d3dpp)); > + d3dpp.Windowed = TRUE; > + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; > + d3dpp.BackBufferWidth = 800; > + d3dpp.BackBufferHeight = 600; > + d3dpp.BackBufferFormat = d3ddm.Format; > + d3dpp.EnableAutoDepthStencil = TRUE; > + d3dpp.AutoDepthStencilFormat = D3DFMT_D24S8; > + > + hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd, > + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &device); > + ok(hr == D3D_OK || hr == D3DERR_INVALIDCALL || broken(hr == D3DERR_NOTAVAILABLE), > + "CreateDevice failed, hr %#x.\n", hr); > + if (!device) > + { > + skip("Could not create device, IDirect3D8_CreateDevice returned %#x.\n", hr); > + goto cleanup; > + } > + Copy / paste is bad for you. It looks like you're trying to create a device. Would you like to use create_device() instead?

1 0

Re: [PATCH 3/5] wined3d: Introduce a helper function for checking colors against a color key.
by Stefan Dösinger 09 Dec '11

09 Dec '11

The patch is OK, this mail is just an answer to Henri's comment. 2011/12/8 Henri Verbeet <hverbeet(a)codeweavers.com> > +static BOOL color_in_range(const struct wined3d_color_key *color_key, > DWORD color) > +{ > + /* FIXME: Is this really how color keys are supposed to work? I think > it > + * makes more sense to compare the individual channels. */ > + return color >= color_key->color_space_low_value > + && color <= color_key->color_space_high_value; > +} > I tried to test this a while ago, but no GPU supported range color keys for blitting, and the HEL doesn't support that either. At least one of my GPUs seems to support this for YUV overlays(DDCKEYCAPS_SRCOVERLAYCLRSPACEYUV), but not RGB overlays or YUV blits. That could satisfy our curiosity, but an automated test is not possible.

1 0

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.
by Marvin 09 Dec '11

09 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass.
by Marvin 09 Dec '11

09 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15856 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [1/2] user32: Add some SetFocus message tests.
by Marvin 09 Dec '11

09 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15855 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH] Fixed a couple of warnings for 64bit targets
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15850 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

how to debug wine
by winepp 08 Dec '11

08 Dec '11

Dear sir: I downloaded the source of wine1.3.29.I want to know how does it work,so I must debug the source of wine! Can you tell me how to debug wine? Shall I need to install any other tools? Thank you very much! -- View this message in context: http://wine.1045685.n5.nabble.com/how-to-debug-wine-tp5054956p5054956.html Sent from the Wine - Devel mailing list archive at Nabble.com.

2 1

Re: usp10: add Myanmar script
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15845 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:424: Test failed: 0:Wrong fRTL(1) usp10.c:424: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:424: Test failed: 0:Wrong BidiLevel(1) usp10.c:456: Test failed: 0:Wrong fRTL(1) usp10.c:456: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:456: Test failed: 0:Wrong BidiLevel(1) === W2KPROSP4 (32 bit usp10) === usp10.c:424: Test failed: 0:Wrong fRTL(1) usp10.c:424: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:424: Test failed: 0:Wrong BidiLevel(1) usp10.c:456: Test failed: 0:Wrong fRTL(1) usp10.c:456: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:456: Test failed: 0:Wrong BidiLevel(1)

1 0

Re: [5/6] gdi32: Substitute glyph for vertical font only. (try 2)
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15835 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [4/6] gdi32: Add vertical fonts to font list. (try 2)
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15834 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [3/6] gdi32: Don't remove leading '@' from face name. (try 2)
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15833 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [2/6] gdi32: Don't use preferred family. (try 2)
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15832 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font. (try 2)
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15831 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WXPPROSP3 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K3R2SESP2 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === WVISTAADM (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W2K8SE (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PRO (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (32 bit font) === font.c:3872: Test failed: FindResource error 1814 === W7PROX64 (64 bit font) === font.c:3872: Test failed: FindResource error 1814 === TEST64_W7SP1 (64 bit font) === font.c:3872: Test failed: FindResource error 1814

1 0

Re: Antw.: Remove obsolete and unused cmdlgtst.
by Dmitry Timoshkov 08 Dec '11

08 Dec '11

"André Hentschel" <nerv(a)dawncrow.de> wrote: > Yes, i just recently modified it to test a bug, please don't remove it You can always get through git when needed it. Please avoid reposting huge messages without any purpose, strip the content you are not going to comment on. -- Dmitry.

3 2

Re: [6/6] gdi32: Add a helper function to convert a string from A to W.
by Dmitry Timoshkov 08 Dec '11

08 Dec '11

Kusanagi Kouichi <slash(a)ac.auone-net.jp> wrote: > +static WCHAR *towstr(const UINT cp, const char * const str) > +{ You are overusing 'const' modifiers. -- Dmitry.

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font.
by Dmitry Timoshkov 08 Dec '11

08 Dec '11

Kusanagi Kouichi <slash(a)ac.auone-net.jp> wrote: > @@ -4099,4 +4186,5 @@ START_TEST(font) > * is properly implemented. > */ > test_CreateScalableFontResource(); > + test_vertical_font(); > } Did you read the comment above the added line? -- Dmitry.

1 0

Re: [5/6] gdi32: Substitute glyph for vertical font only.
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15830 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4110: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4115: Test failed: @@WineTestVertical is not installed font.c:4116: Test failed: @@WineTestVertical is not selected font.c:4117: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4122: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [4/6] gdi32: Add vertical fonts to list.
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15829 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4105: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4108: Test failed: @WineTestVertical is not installed font.c:4109: Test failed: @WineTestVertical is not selected font.c:4111: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4116: Test failed: @@WineTestVertical is not installed font.c:4117: Test failed: @@WineTestVertical is not selected font.c:4118: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4123: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [3/6] gdi32: Don't remove leading '@' from face name.
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15828 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4110: Test failed: @WineTestVertical is not selected font.c:4112: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4118: Test failed: @@WineTestVertical is not installed font.c:4120: Test failed: @@WineTestVertical is not selected font.c:4122: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4127: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [2/6] gdi32: Don't use preferred family.
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15827 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4109: Test failed: @WineTestVertical is not installed font.c:4111: Test failed: @WineTestVertical is not selected font.c:4113: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4119: Test failed: @@WineTestVertical is not installed font.c:4121: Test failed: @@WineTestVertical is not selected font.c:4123: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4128: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [1/6] gdi32/tests: Add tests for vertical font.
by Marvin 08 Dec '11

08 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15826 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === WXPPROSP3 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W2K3R2SESP2 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4083: Test failed: GetGlyphOutlineW failed font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === WVISTAADM (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W2K8SE (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PRO (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (32 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === W7PROX64 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2 === TEST64_W7SP1 (64 bit font) === font.c:4106: Test failed: AddFontResourceExA should add 2 fonts from vertical.ttf font.c:4110: Test failed: @WineTestVertical is not installed font.c:4112: Test failed: @WineTestVertical is not selected font.c:4114: Test failed: gmBlackBoxX(0) should be greater than gmBlackBoxY(0) if horizontal font.c:4120: Test failed: @@WineTestVertical is not installed font.c:4122: Test failed: @@WineTestVertical is not selected font.c:4124: Test failed: gmBlackBoxX(0) should be less than gmBlackBoxY(0) if vertical font.c:4129: Test failed: RemoveFontResourceEx() error 2

1 0

Re: [PATCH 3/3] ddraw/tests: Extend the CreateSurface(NULL test), use own function
by Marvin 07 Dec '11

07 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15825 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:4626: Test failed: SetSurfaceDesc failed, hr 0x80070057. dsurface.c:4630: Test failed: SetSurfaceDesc failed, hr 0x80070057. === W7PRO (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === W7PROX64 (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E584 === W7PROX64 (64 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:4708: Test failed: CreateSurface failed, hr 0x88760233. Timeout

1 0

Re: [PATCH 2/3] ddraw: SetSurfaceDesc can set width, height and pitch under certain conditions
by Marvin 07 Dec '11

07 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15824 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:4628: Test failed: SetSurfaceDesc failed, hr 0x80070057. dsurface.c:4632: Test failed: SetSurfaceDesc failed, hr 0x80070057. === W7PRO (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === W7PROX64 (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === TEST64_W7SP1 (32 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. dsurface: unhandled exception c0000005 at 0042E5E4 === W7PROX64 (64 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. Timeout === TEST64_W7SP1 (64 bit dsurface) === dsurface.c:4710: Test failed: CreateSurface failed, hr 0x88760233. Timeout

1 0

Re: [PATCH 1/3] wininet: Use test.winehq.org instead of crossover.codeweavers.com in test_async_HttpSendRequestEx
by Marvin 07 Dec '11

07 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15809 Your paranoid android. === WXPPROSP3 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12002 === WVISTAADM (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W2K8SE (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === TEST64_W7SP1 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (64 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set

2 1

Re: [PATCH 3/3] wininet: Added more connection failure tests
by Marvin 07 Dec '11

07 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15810 Your paranoid android. === W2K3R2SESP2 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === WVISTAADM (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W2K8SE (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set === W7PROX64 (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12057 http.c:2878: Test failed: expected secure flag to be set http.c:2957: Test failed: HttpSendRequest failed: 12057 http.c:2962: Test failed: expected secure flag to be set

1 0

Re: [PATCH 5/6] jscript: Use bytecode for post-increment expression
by Marvin 07 Dec '11

07 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15795 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: mshtml: Don't use WINAPI for assembly functions to avoid linker warnings on mingw
by Francois Gouget 07 Dec '11

07 Dec '11

> #ifdef __i386__ > > #define DEFINE_WRAPPER_FUNC(n, off, x) \ > HRESULT wrapper_func_##n(IUnknown*); \ [...] > #elif defined(__x86_64__) > > #define DEFINE_WRAPPER_FUNC(n, x, off) \ > HRESULT WINAPI wrapper_func_##n(IUnknown*); \ [...] > #else > > #define DEFINE_WRAPPER_FUNC(n, x, off) \ > static HRESULT WINAPI wrapper_func_##n(IUnknown *iface) { \ [...] Is it normal that these functions are still marked as WINAPI in the 64bit and other platform cases? Also, is there a reason not to mark these functions as static in the Intel cases? Because they are coded in assembly? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: riched20: fix memory leak
by Alexandre Julliard 07 Dec '11

07 Dec '11

Pierre Schweitzer <pierre(a)reactos.org> writes: > @@ -102,6 +102,7 @@ ME_UndoItem *ME_AddUndoItem(ME_TextEditor *editor, ME_DIType type, const ME_Disp > } > default: > assert(0 == "AddUndoItem, unsupported item type"); > + ME_DestroyDisplayItem(pItem); > return NULL; It's not useful to free memory in unreachable code paths. -- Alexandre Julliard julliard(a)winehq.org

1 0

dosdevices/c not present.. how is it created?
by Roger Cruz 07 Dec '11

07 Dec '11

I'm getting the following error when running Wine. err:process:init_windows_dirs directory L"C:\\windows" could not be created, error 2 err:process:init_windows_dirs directory L"C:\\windows\\system32" could not be created, error 3 Using the debugger, I think I found where the problem is: 2140 int fd = open( unix_name, O_RDONLY | O_DIRECTORY ); (gdb) p unix_name $25 = 0x4040b2e8 "/data/winehome/dosdevices/c:" (gdb) n 2141 if (fd != -1) (gdb) p fd $26 = -1 (gdb) where #0 find_file_in_dir (unix_name=0x4040b2e8 "/data/winehome/dosdevices/c:", pos=29, name=0x4040b2c6, length=7, check_case=0, is_win_dir=0x0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2141 #1 0x80236cf4 in lookup_unix_name (name=0x4040b2c6, name_len=0, buffer=0xbebc45e4, unix_len=295, pos=28, disposition=2, check_case=0 '\0') at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2759 #2 0x80237ad4 in wine_nt_to_unix_file_name (nameW=0xbebc48f8, unix_name_ret=0xbebc4844, disposition=2, check_case=0 '\0') at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2981 #3 0x80237004 in nt_to_unix_file_name_attr (attr=0xbebc4900, unix_name_ret=0xbebc4844, disposition=2) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/directory.c:2821 #4 0x8023b744 in FILE_CreateFile (handle=0xbebc48ec, access=2147483648, attr=0xbebc4900, io=0xbebc48f0, alloc_size=0x0, attributes=128, sharing=1, disposition=2, options=33, ea_buffer=0x0, ea_length=0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/file.c:125 #5 0x8023bd40 in NtCreateFile (handle=0xbebc48ec, access=2147483648, attr=0xbebc4900, io=0xbebc48f0, alloc_size=0x0, attributes=128, sharing=1, disposition=2, options=33, ea_buffer=0x0, ea_length=0) at /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/file.c:271 #6 0x8045d210 in ?? () export WINEPREFIX=/data/winehome When I look in my $WINEPREFIX directory, I can see that the c: directory is not there # ls /data/winehome system.reg dosdevices drive_c user.reg # ls /data/winehome/dosdevices # How does that c: directory get created and by whom? I have deleted the $WINEPREFIX several times already to no avail. Thanks Roger R. Cruz # ls /data/winehome system.reg dosdevices drive_c user.reg # ls /data/winehome/dosdevices #

2 2

Re: cmd: Use FormatMessage() for better internationalization support.
by Frédéric Delanoy 06 Dec '11

06 Dec '11

On Tue, Dec 6, 2011 at 17:40, Francois Gouget <fgouget(a)free.fr> wrote: > This makes it possible to reorder the format string placeholders in message translations. > Also add a WCMD_format_string() function to mirror the WCMD_output*() ones and so all resources can use the same formatting style. > This also simplifies the padding code for the 'dir /w' command. > + static const WCHAR empty[] = {'\0'}; There's already a suitable nullW string available

1 0

Re: [2/2] msi/tests: Try harder to remove a shortcut file.
by Marvin 06 Dec '11

06 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15780 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5994: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 1/7] msvcrt: Added _get_current_locale impementation
by Piotr Caban 06 Dec '11

06 Dec '11

This patches are broken, please ignore them. I'll need to implement locale reference counters inside msvcrt first.

1 0

Updated Clang static analysis results / Valgrind update
by Austin English 05 Dec '11

05 Dec '11

Web space usage was getting a bit high, so I've uploaded a tarball to a file download service: http://www.sendspace.com/file/5hot36 austin@aw21 ~ $ sha1sum scan-build-2011-07-02.tar.bz2 ac3cb3920ef97641fff1f5376f8136cef01f15bf scan-build-2011-07-02.tar.bz2 to use, just extract and open in your favorite browser: $ firefox index.html this was run against Clang from svn: clang version 3.0 (trunk 134320) Please send me any false positives that you'd like me to report upstream. Cheers, Austin P.S. For those of you wanting Valgrind results, I'm currently hitting a nasty Valgrind bug, waiting on upstream to fix: https://bugs.kde.org/show_bug.cgi?id=275673 (Thanks to Andrew N for finding the faulty commit)

4 7

Re: wined3d: recognize Nvidia 540M
by Henri Verbeet 05 Dec '11

05 Dec '11

On 5 December 2011 21:43, Austin English <austinenglish(a)gmail.com> wrote: > {"GTS 450", CARD_NVIDIA_GEFORCE_GTS450}, /* Geforce 400 - midend low */ > + {"GT 540M", CARD_NVIDIA_GEFORCE_GT540M}, /* Geforce 500 - midend mobile */ > {"GT 440", CARD_NVIDIA_GEFORCE_GT440}, /* Geforce 400 - lowend */ The tables are sorted roughly by generation.

1 0

Re: [PATCH] gdi32: Check get_dc_ptr result (Coverity)
by Alexandre Julliard 05 Dec '11

05 Dec '11

Marcus Meissner <meissner(a)suse.de> writes: > Checked 199 out of 204 times, so do it here too. > CID 5484 It cannot fail inside driver functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] jscript: Use bytecode for invalid assignments
by Marvin 05 Dec '11

05 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15759 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/6] jscript: Use bytecode for assignment to identifier
by Marvin 05 Dec '11

05 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15758 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] ddraw/tests: Update a copyright line
by Marvin 04 Dec '11

04 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15757 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: dinput: Clarify a translatable string
by Vitaliy Margolen 04 Dec '11

04 Dec '11

On 12/04/2011 01:33 AM, Frédéric Delanoy wrote: > me> Could you explain what that "Sort Assigned" means? > author> I was planning on sorting the button/action mappings putting the > ones which already have an assigned mapping first, and then all the > others. > --- > + AUTOCHECKBOX "Sort Assigned Mappings", IDC_CHECKBOXSORT, 120, 215, 90, 8 A better way of saying this would be "Show assigned first". Vitaliy.

3 3

Re: user32: Avoid crashing if we can't alloc text buffer
by Nikolay Sivov 03 Dec '11

03 Dec '11

On 12/3/2011 04:35, Bruno Jesus wrote: > If LocalLock fails the buffer is not allocated and get_text_length, which is used in several different places, will make wine crash. LocalLock doesn't allocate anything. You need to figure out why buffer is not allocated at this point.

2 1

Re: [PATCH] dsound: Validate format in primary buffer's SetFormat()
by Marvin 02 Dec '11

02 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15748 Your paranoid android. === WVISTAADM (32 bit dsound) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetCaps (try 4)
by Alexandre Julliard 02 Dec '11

02 Dec '11

stefan(a)codeweavers.com writes: > +static inline BOOL check_d3ddevicedesc_size(DWORD size) > +{ > + if (size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; > + return FALSE; > +} You should use something like FIELD_OFFSET instead of these magic constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Print error messages on stderr, not on stdout. (try3)
by Frédéric Delanoy 02 Dec '11

02 Dec '11

On Fri, Dec 2, 2011 at 10:07, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > I meant to resend this one as [2/2] in my previous series but forgot. > With the resynchronization points we can now handle the fixed output > correctly in the tests this time. > > programs/cmd/builtins.c | 20 ++++++++++---------- > programs/cmd/tests/test_builtins.cmd | 1 - > programs/cmd/tests/test_builtins.cmd.exp | 7 +++---- > 3 files changed, 13 insertions(+), 15 deletions(-) Hi François. Would you mind updating the http://wiki.winehq.org/CmdConformanceTests page with your synchronization stuff? I'm not quite sure what/how it does exactly. There is now a discrepancy between wine output, and testrunner output, e.g. echo ------ eol option for /f "eol=@" %%i in (" ad") do echo %%i echo bar gave ------ eol option Syntax error bar but not gives ------ eol option bar Shouldn't cmd output always give the same as test runner output (which is supposed to run cmd on the input file (test_builtins.cmd), albeit with some preprocessing)? Frédéric

2 5

Re: [PATCH 3/3] user32: If a dialog has no tab-accessible controls, set focus to first control (with tests)
by Marvin 02 Dec '11

02 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15740 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] winecfg: Bump NT 3.51 to Service Pack 5
by Vitaliy Margolen 02 Dec '11

02 Dec '11

On 12/01/2011 12:15 PM, André Hentschel wrote: > --- > - { "nt351", "Windows NT 3.5", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 2", 0, 0, "WinNT"}, > + { "nt351", "Windows NT 3.51", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack 5", 5, 0, "WinNT"}, You need to do the same in ntdll/version.c Vitaliy.

1 0

Re: shell32/tests: Initialize all fields of SHFILEOPSTRUCT variables (Coverity)
by Marvin 02 Dec '11

02 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15738 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:1011: Test failed: Expected aborted operations shlfileop.c:2214: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15731 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] kernel32: Add a bunch of VirtualProtect tests on a memory-mapped file. Resend.
by Alexandre Julliard 01 Dec '11

01 Dec '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > --- > dlls/kernel32/tests/virtual.c | 187 +++++++++++++++++++++++++++++++++------- > 1 files changed, 154 insertions(+), 33 deletions(-) That's a good start, but it would be interesting to try this with various combinations of CreateFileMapping/MapViewOfFile protections, as I expect that the mapping protections would influence what you can then do in VirtualProtect. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test
by Henri Verbeet 01 Dec '11

01 Dec '11

On 1 December 2011 11:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > An IDirect3DDevice3 test will follow once the d3d initialization design has > been approved. > If we're going to redo the way the tests work anyway, we probably shouldn't reuse the same objects for everything either.

2 1

Re: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc (try 3)
by Henri Verbeet 01 Dec '11

01 Dec '11

On 1 December 2011 11:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Subject: [PATCH 1/3] ddraw: Size handling fixes for IDirect3DDevice::GetDesc There is no IDirect3DDevice::GetDesc(). > + if(size == 172 || size == 204 || size == sizeof(D3DDEVICEDESC) /* 252 */) return TRUE; Please fix the formatting here as well.

1 0

Re: [PATCH 2/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15726 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15727 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

difficulties compiling or installing git on precise pagolin
by Susan Cragin 01 Dec '11

01 Dec '11

In the development version of ubuntu, wine can neither be compiled nor installed. ~$ sudo apt-get build-dep wine1.3 [sudo] password for susan: Reading package lists... Done Building dependency tree Reading state information... Done The following packages have unmet dependencies: ia32-libs : Depends: ia32-libs-multiarch libsane-dev : Depends: libjpeg-dev Depends: libtiff4-dev but it is not going to be installed E: Build-dependencies for wine1.3 could not be satisfied. $ sudo apt-get install wine1.3 The following packages have unmet dependencies: wine1.3 : Depends: ia32-libs (>= 1.6) but it is not going to be installed ia32-libs is now a transitional package. There is no ia32-libs-multiarch. It has been replaced by ia32-libs-multiarch:386. It seems as if the problem can first be solved by installing ia32-libs-multiarch:386, but when I try to do this it involves removing other packages that seem important. ??

2 1

Re: [3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15723 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] ddraw/tests: Add a IDirect3DDevice7 GetCaps test
by Marvin 01 Dec '11

01 Dec '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15722 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: Patch for #29144
by Henri Verbeet 01 Dec '11

01 Dec '11

2011/12/1 Aurélien COUDERC <zecoucou(a)free.fr>: > @@ -5189,7 +5189,7 @@ static void fillGLAttribFuncs(const struct wined3d_gl_info *gl_info) > multi_texcoord_funcs[WINED3D_FFP_EMIT_USHORT4N] = invalid_texcoord_func; > multi_texcoord_funcs[WINED3D_FFP_EMIT_UDEC3] = invalid_texcoord_func; > multi_texcoord_funcs[WINED3D_FFP_EMIT_DEC3N] = invalid_texcoord_func; > - if (gl_info->supported[NV_HALF_FLOAT]) > + if (gl_info->supported[NV_VERTEX_PROGRAM] && gl_info->supported[NV_HALF_FLOAT]) > { > /* Not supported by ARB_HALF_FLOAT_VERTEX, so check for NV_HALF_FLOAT */ > multi_texcoord_funcs[WINED3D_FFP_EMIT_FLOAT16_2] = (glMultiTexCoordFunc)GL_EXTCALL(glMultiTexCoord2hvNV); I missed this the first time, but this one shouldn't depend on NV_VERTEX_PROGRAM, only the functions for specifying vertex attributes do.

1 0

Re: Patch for #29144
by Frédéric Delanoy 01 Dec '11

01 Dec '11

2011/12/1 Aurélien COUDERC <zecoucou(a)free.fr>: > Please find an attached patch for #29144. > > It probably fixes a hole range of freezes with fglrx (Tested on Sykrim and > Might & Magic Heroes VI for instance). Please follow WineHQ Patch submission guidelines as described on http://wiki.winehq.org/SubmittingPatches

1 0

Re: [PATCH 2/6] appwiz.cpl: Add Catalan translation
by André Hentschel 30 Nov '11

30 Nov '11

Am 30.11.2011 08:39, schrieb Alex Henrie: > --- > dlls/appwiz.cpl/Ca.rc | 85 +++++++++++++++++++++++++++++++++++++++++++ > dlls/appwiz.cpl/Makefile.in | 1 + > 2 files changed, 86 insertions(+), 0 deletions(-) > create mode 100644 dlls/appwiz.cpl/Ca.rc > > diff --git a/dlls/appwiz.cpl/Ca.rc b/dlls/appwiz.cpl/Ca.rc > new file mode 100644 > index 0000000..e411bf0 > --- /dev/null > +++ b/dlls/appwiz.cpl/Ca.rc > @@ -0,0 +1,85 @@ > +/* > +* Add/Remove Programs English resources > +* > +* Copyright 2001-2002, 2008 Owen Rudge > +* Copyright 2005-2006 Jacek Caban really? :) -- Best Regards, André Hentschel

1 0

Re: [PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.
by Stefan Dösinger 30 Nov '11

30 Nov '11

Am Donnerstag, 24. November 2011, 22:52:32 schrieb Henri Verbeet: > + if (surface->flags & SFLAG_CONVERTED) > + { > + ENTER_GL(); > + glEnable(textype); > + checkGLcall("glEnable(textype)"); > + LEAVE_GL(); > + return WINED3D_OK; > + } I don't think this is correct. E.g. signed formats without GL_NV_texture_shader have load time and read time fixups and both have to be applied. What exactly are you trying to fix? I assume it is something about P8 blits, but P8->P8 blits don't enter the ARB blitting code(due to the dest fixup check), and I don't know of any app that uses P8->RGB or SNORM->UNORM blits. Stefan

3 16

Re: [PATCH 3/5] ddraw: Keep the primary surface mapped at the same address for early ddraw versions.
by Stefan Dösinger 30 Nov '11

30 Nov '11

Am Mittwoch, 30. November 2011, 06:01:46 schrieb Henri Verbeet: > + if (flags & WINED3D_SURFACE_PIN_SYSMEM) > + surface->flags |= SFLAG_PIN_SYSMEM; The address will still change when GetDC is called. Is this intentional? > + /* Some applications assume that the primary surface will always be > + * mapped at the same address. Some of those also assume that this > + * address is valid even when the surface isn't mapped, and that > + * updates done this way will be visible on the screen. The game Nox > + * is such an application. */ I've seen ddraw applications that create systemmem primaries, and we currently allow this. What surface caps does Nox use? Does Nox expect us to magically pick up the new data, or does it map and unmap the surface to get the data onto the screen?

1 0

Re: [PATCH 2/4] jscript: Use bytecode for delete on array expression implementation
by Marvin 30 Nov '11

30 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15711 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] ddraw: Resize the swapchain window on mode changes in exclusive mode.
by Marvin 30 Nov '11

30 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15710 Your paranoid android. === WVISTAADM (32 bit d3d) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

2 1

Re: [PATCH 5/5] user32: Implement GetRawInputDeviceInfoW completely on user side. (resend)
by Marvin 29 Nov '11

29 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15692 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W2K8SE (32 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PRO (32 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (32 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (32 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (64 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (64 bit input) === input.c:1787: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737

1 0

Re: [PATCH 3/5] user32: Implement GetRawInputDeviceList completely on user side. (resend)
by Marvin 29 Nov '11

29 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15691 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W2K8SE (32 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PRO (32 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (32 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (32 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (64 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (64 bit input) === input.c:1794: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737

1 0

Re: [PATCH 2/5] user32: Add initial input parameter validations to RawInput functions. (resend)
by Marvin 29 Nov '11

29 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15690 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W2K8SE (32 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PRO (32 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (32 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (32 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (64 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (64 bit input) === input.c:1797: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737

1 0

Re: [PATCH 1/5] user32/tests: Initial tests for RawInput functions. (try 2)
by Marvin 29 Nov '11

29 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15689 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W2K8SE (32 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PRO (32 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (32 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (32 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === W7PROX64 (64 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737 === TEST64_W7SP1 (64 bit input) === input.c:1803: Test failed: GetRawInputDeviceInfoA should have failed: 32, 32, -559038737

1 0

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).
by Dmitry Timoshkov 28 Nov '11

28 Nov '11

"Erich E. Hoover" <ehoover(a)mines.edu> wrote: > The attached patch changes the test_timers() crash function to use > RtlRaiseException (if available) rather than attempting to write to memory > address 0. This change stops the timer tests from hanging on the 64-bit VM. Why not use kernel32.RaiseException (which is always available) instead? -- Dmitry.

2 4

Re: [1/2] kernel32: Add a test for protections accepted by CreateFileMapping, make it pass under Wine.
by Alexandre Julliard 28 Nov '11

28 Nov '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -350,9 +350,6 @@ HANDLE WINAPI CreateFileMappingW( HANDLE hFile, LPSECURITY_ATTRIBUTES sa, > > switch(protect) > { > - case 0: > - protect = PAGE_READONLY; /* Win9x compatibility */ > - /* fall through */ Did you try your test on Win9x? -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: [3/5] cmd/tests: Tweak subsection headers so they are treated as resynchronization points.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15676 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] cmd/tests: Standardize the batch file section headers.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15675 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] cmd/tests: Standardize the batch file section headers.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15675 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] cmd/tests: Standardize the batch file section headers.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15675 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] cmd/tests: Standardize the batch file section headers.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15675 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: kernel32/tests: Test deleting a timer right after creating it.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15671 Your paranoid android. === W2KPROSP4 (32 bit sync) === sync.c:685: Test failed: DeleteTimerQueueTimer ret=1 le=997 === WXPPROSP3 (32 bit sync) === sync.c:685: Test failed: DeleteTimerQueueTimer ret=1 le=997 === W2K3R2SESP2 (32 bit sync) === sync.c:685: Test failed: DeleteTimerQueueTimer ret=1 le=997 === WVISTAADM (32 bit sync) === sync.c:741: Test failed: Timer callback 0 === W2K8SE (32 bit sync) === sync.c:741: Test failed: Timer callback 0 === W7PRO (32 bit sync) === sync.c:741: Test failed: Timer callback 0 === W7PROX64 (32 bit sync) === sync.c:741: Test failed: Timer callback 0 === TEST64_W7SP1 (32 bit sync) === sync.c:741: Test failed: Timer callback 0 === W7PROX64 (64 bit sync) === sync.c:741: Test failed: Timer callback 0 === TEST64_W7SP1 (64 bit sync) === sync.c:741: Test failed: Timer callback 0

1 0

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15670 Your paranoid android. === WVISTAADM (32 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. swapchain: unhandled exception c0000005 at 004027AA === W2K8SE (32 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. swapchain: unhandled exception c0000005 at 004027AA === W7PRO (32 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. swapchain: unhandled exception c0000005 at 004027AA === W7PROX64 (32 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. swapchain: unhandled exception c0000005 at 004027AA === TEST64_W7SP1 (32 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. swapchain: unhandled exception c0000005 at 004027AA === W7PROX64 (64 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. Timeout === TEST64_W7SP1 (64 bit swapchain) === swapchain.c:76: Test failed: Failed to create device and swapchain, hr 0x8007000e. Timeout

1 0

Re: [PATCH 1/5] user32/tests: Initial tests for RawInput functions.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15663 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W2K8SE (32 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PRO (32 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (32 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (32 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (64 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (64 bit input) === input.c:1807: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87

2 1

Re: [PATCH 5/5] user32: Implement GetRawInputDeviceInfoW completely on user side.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15666 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W2K8SE (32 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PRO (32 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (32 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (32 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (64 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (64 bit input) === input.c:1791: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87

1 0

Re: [PATCH 3/5] user32: Implement GetRawInputDeviceList completely on user side.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15665 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W2K8SE (32 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PRO (32 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (32 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (32 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (64 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (64 bit input) === input.c:1799: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87

1 0

Re: [PATCH 2/5] user32: Add initial input parameter validations to RawInput functions.
by Marvin 28 Nov '11

28 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15664 Your paranoid android. === WVISTAADM (32 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W2K8SE (32 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PRO (32 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (32 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (32 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === W7PROX64 (64 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87 === TEST64_W7SP1 (64 bit input) === input.c:1801: Test failed: GetRawInputDeviceInfoA failed: -1, 1024, 87

1 0

Compiling Wine without prelink
by Roger Cruz 28 Nov '11

28 Nov '11

What is the proper way to ask the configure script not to use 'prelink' on the generated shared libraries? I don't want to remove the prelink from my development platform but just tell the configurator to ignore it. Thanks Roger R. Cruz

3 5

Re: [PATCH 2/5] d3d8/tests: Test the window and backbuffer dimensions after display mode changes.
by Marvin 27 Nov '11

27 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15656 Your paranoid android. === WNT4WSSP6 (32 bit device) === Timeout

1 0

Re: [PATCH 1/5] d3d9/tests: Test the window and backbuffer dimensions after display mode changes.
by Marvin 27 Nov '11

27 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15655 Your paranoid android. === WNT4WSSP6 (32 bit device) === Timeout

1 0

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL
by Henri Verbeet 27 Nov '11

27 Nov '11

On 27 November 2011 18:15, Eduard - Gabriel Munteanu <eduard.munteanu(a)linux360.ro> wrote: > On Sun, Nov 27, 2011 at 05:25:08PM +0100, Henri Verbeet wrote: >> What happens for cases like "60 / 0"? Do we get an exception, or does >> the function return an error? MSDN for DXGI_RATIONAL says that whole >> numbers should be represented with a denominator of 1, is something >> like "120 / 2" valid? > > I'm wasn't sure what needed to be done for stuff like 60 / 0, so I > thought that should result in division by zero for now. Maybe it should > be NaN if we convert to a float, or maybe UINT_MAX for UINT, but the > MSDN docs for DXGI_RATIONAL don't say anything about that. > > Perhaps an ERR/WARN/FIXME is in order? > > As for 120 / 2, I took "should" as a recommendation, rather than a > definitive "must". > Possibly. The point of writing the tests is to find out what actually happens.

1 0

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL
by Henri Verbeet 27 Nov '11

27 Nov '11

On 26 November 2011 15:52, Eduard - Gabriel Munteanu <eduard.munteanu(a)linux360.ro> wrote: > + if (!rational->Denominator && !rational->Numerator) > + return 0; That's pretty much the same as returning 0 when the numerator is 0. > C_SRCS = \ > - device.c > + device.c \ > + swapchain.c > I don't think we really need a new test file for this, you can probably just add it to device.c. > + hr = D3D10CreateDeviceAndSwapChain(NULL, D3D10_DRIVER_TYPE_HARDWARE, > + NULL, 0, D3D10_SDK_VERSION, &scdesc, swapchain, device); I suppose you can test D3D10CreateDeviceAndSwapChain() for completeness if you want, but the interesting part is testing IDXGIFactory_CreateSwapChain(). What happens for cases like "60 / 0"? Do we get an exception, or does the function return an error? MSDN for DXGI_RATIONAL says that whole numbers should be represented with a denominator of 1, is something like "120 / 2" valid?

1 0

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation
by Charles Davis 26 Nov '11

26 Nov '11

Hi, On Nov 24, 2011, at 4:21 AM, Claudio Fontana wrote: > First implementation of GetLogicalProcessorInformation. > Limitations: all logical processors are added to the same NUMA set, > and all cores are added to the same package. > Only the linux-specific helper function is implemented, so for now > everybody else gets the fallback hard-coded results only. > The fallback is also triggered when the OS-specific APIs fail. > > The linux-specific function is based on sysfs. > > The new OS-specific functions can be easily added as additional > ifdefs by following the linux example. > --- > dlls/kernel32/process.c | 350 ++++++++++++++++++++++++++++++++++++++- > dlls/kernel32/tests/Makefile.in | 1 + > dlls/kernel32/tests/glpi.c | 82 +++++++++ You should really implement this in ntdll.NtQuerySystemInformation (information class SystemLogicalProcessorInformation). In general, kernel32 forwards most of its implementation to ntdll, which reduces code duplication. > 3 files changed, 430 insertions(+), 3 deletions(-) > create mode 100644 dlls/kernel32/tests/glpi.c IMO, you should add the test to dlls/ntdll/tests/info.c, and test NtQuerySystemInformation() with info class SystemLogicalProcessorInformation. > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index b6c0b9d..de39244 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -51,6 +51,12 @@ > > #include "ntstatus.h" > #define WIN32_NO_STATUS > + > +#include "windef.h" > +#include "winbase.h" > +#include "winerror.h" > +#include "winnt.h" > + > #include "winternl.h" > #include "kernel_private.h" > #include "psapi.h" > @@ -3705,14 +3711,352 @@ HANDLE WINAPI GetCurrentProcess(void) > return (HANDLE)~(ULONG_PTR)0; > } > > +/*************** > + * glpi_impl_fb: > + * a fallback implementation of GetLogicalProcessorInformation > + * for the systems we do not support yet, > + * or for when the OS-specific API fails. > + * Same arguments and return value as glpi. > + */ This comment should really come right before the function you're documenting. Also, it's formatted wrong. It should look more like this: /*********************************************************************************** * logical_processor_info_fallback * * Fallback implementation of NtQuerySystemInformation() with info class * SystemLogicalProcessorInfo. */ > + > +#undef SLPI > +#ifdef NONAMELESSUNION > +#define SLPI(buffer, idx) buffer[idx].DUMMYUNIONNAME > +#else > +#define SLPI(buffer, idx) buffer[idx] > +#endif /* NONAMELESSUNION */ You could avoid the ifdef if you used the U() macro. In fact, why are you defining a macro at all? Just use U(buffer[idx]). > + > +static BOOL > +glpi_impl_fb(PSYSTEM_LOGICAL_PROCESSOR_INFORMATION buffer, PDWORD pbuflen) Surely you could use a more descriptive name. (See one example in my example doc comment.) This isn't 1978, you know. > +{ > + int glpi_n = 5; > + FIXME("(%p,%p): reporting hard coded information\n", buffer, pbuflen); > + > + if (*pbuflen < sizeof(*buffer) * glpi_n) > + { > + SetLastError(ERROR_INSUFFICIENT_BUFFER); > + *pbuflen = sizeof(*buffer) * glpi_n; > + return FALSE; > + } > + > + buffer[0].ProcessorMask = (ULONG_PTR)0x01; > + buffer[1].ProcessorMask = (ULONG_PTR)0x01; > + buffer[2].ProcessorMask = (ULONG_PTR)0x01; > + buffer[3].ProcessorMask = (ULONG_PTR)0x01; > + buffer[4].ProcessorMask = (ULONG_PTR)0x01; These casts aren't necessary. > + > + buffer[0].Relationship = RelationProcessorCore; > + buffer[1].Relationship = RelationNumaNode; > + buffer[2].Relationship = RelationCache; > + buffer[3].Relationship = RelationCache; > + buffer[4].Relationship = RelationProcessorPackage; > + > + SLPI(buffer, 0).ProcessorCore.Flags = (BYTE)0x00; > + SLPI(buffer, 1).NumaNode.NodeNumber = (DWORD)0x00; Neither are these. > + > + SLPI(buffer, 2).Cache.Level = (BYTE)0x01; > + SLPI(buffer, 2).Cache.Associativity = (BYTE)0x08; > + SLPI(buffer, 2).Cache.LineSize = (WORD)64; > + SLPI(buffer, 2).Cache.Size = (DWORD)16 << 10; /* 16 KB */ Or these. > + SLPI(buffer, 2).Cache.Type = CacheData; > + > + SLPI(buffer, 3).Cache.Level = (BYTE)0x02; > + SLPI(buffer, 3).Cache.Associativity = (BYTE)0x08; > + SLPI(buffer, 3).Cache.LineSize = (WORD)64; > + SLPI(buffer, 3).Cache.Size = (DWORD)1024 << 10; /* 1024 KB */ Or these. > + SLPI(buffer, 3).Cache.Type = CacheUnified; > + /* no additional info for processor package at buffer[4] needed. */ > + > + *pbuflen = sizeof(*buffer) * glpi_n; > + return TRUE; > +} > + > +#ifdef linux > +/****************** > + * glpi_impl_linux: > + * an implementation of GetLogicalProcessorInformation > + * for linux sysfs. > + * Returns: -1 on API failure (trigger fallback), > + * otherwise see glpi. > + */ See above. > + > +#define SYS_CPU "/sys/devices/system/cpu/cpu" > +#define SYS_CPU_MAX 63 I'd criticize your use of a static limit, if only Windows didn't have that limit ;). Actually, you can only have 32 processors on a 32-bit system because a ULONG_PTR is 32 bits there. > +#define SYS_CPU_COREID "/topology/core_id" > +#define SYS_CPU_PACKAGEID "/topology/physical_package_id" > +#define SYS_CPU_CACHE "/cache/index" > +#define SYS_CPU_CACHE_MAX 12 > +#define SYS_CPU_CACHE_LEVEL "/level" > +#define SYS_CPU_CACHE_SIZE "/size" > +#define SYS_CPU_CACHE_TYPE "/type" > +#define SYS_CPU_CACHE_LINE "/coherency_line_size" > +#define SYS_CPU_CACHE_ASSOC "/ways_of_associativity" > + > +static int glpi_impl_linux(SYSTEM_LOGICAL_PROCESSOR_INFORMATION *buffer, > + PDWORD pbuflen) > +{ > + /* remember the glpi results, so that subsequent calls are faster */ > + static int n_cores = 0; > + static int n_caches = 0; > + static PSYSTEM_LOGICAL_PROCESSOR_INFORMATION cores = NULL; > + static PSYSTEM_LOGICAL_PROCESSOR_INFORMATION caches = NULL; > + static SYSTEM_LOGICAL_PROCESSOR_INFORMATION numa[1]; > + static SYSTEM_LOGICAL_PROCESSOR_INFORMATION package[1]; > + > + if (!n_cores) > + { > + int n_cpus = 0; int cpu_i; > + char path[PATH_MAX]; > + > + TRACE("building new cached result.\n"); > + > + for (n_cpus = 0; n_cpus < SYS_CPU_MAX; n_cpus++) > + { > + snprintf(path, sizeof(path), SYS_CPU "%d", n_cpus); > + if (access(path, R_OK | X_OK) != 0) Don't use access(2). There's a big fat warning on the man-page telling you not to use it because of a race condition. Another way to solve the problem you're trying to solve might be to scan the "/sys/devices/system/cpu/" directory for the number of entries using the POSIX readdir(3) interface. You could scan them all up front, or you could take each one as you go, re-allocating the table for each new entry. > + break; > + } > + > + TRACE("detected %d logical cpus.\n", n_cpus); > + if (n_cpus < 1) > + { > + TRACE("requesting fallback implementation.\n"); > + return -1; > + } > + > + cores = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*cores) * n_cpus); > + caches = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*caches) * 1); > + > + for (cpu_i = 0; cpu_i < n_cpus; cpu_i++) > + { > + FILE *f; int core_id; int i; > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_COREID, cpu_i); > + cores[n_cores].ProcessorMask = (ULONG_PTR)0x01 << cpu_i; This cast might be needed if there are more than 32 CPUs, so that's OK. > + cores[n_cores].Relationship = RelationProcessorCore; > + > + if (!(f = fopen(path, "r")) || fscanf(f, "%d", &core_id) != 1) > + { > + /* topology info not available, provide default cpuid=cpu_i */ > + ERR("could not read cpu%d topology.\n", cpu_i); > + SLPI(cores, n_cores).Reserved[0] = cpu_i; > + n_cores++; > + if (f) > + fclose(f); > + continue; /* next cpu */ > + } > + > + /* normal sane case */ > + fclose(f); > + /* store the core_id to catch cpus with same core_id */ > + SLPI(cores, n_cores).Reserved[0] = core_id; > + > + /* look for this core_id in previous elements */ > + for (i = 0; i < n_cores; i++) > + if (SLPI(cores, i).Reserved[0] == SLPI(cores, n_cores).Reserved[0]) > + break; > + > + if (i < n_cores) > + { > + TRACE("found existing coreid %d for cpu%d.\n", core_id, cpu_i); > + /* add this logical processor to the existing mask */ > + cores[i].ProcessorMask |= cores[n_cores].ProcessorMask; > + /* do not advance n_cores: this element can be overwritten. */ > + } > + else > + { > + TRACE("found new coreid %d for cpu%d.\n", core_id, cpu_i); > + > + /* look for caches */ > + for (i = 0; i < SYS_CPU_CACHE_MAX; i++) > + { > + unsigned long value; > + char string[80]; > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d", > + cpu_i, i); > + if (access(path, R_OK | X_OK) != 0) Don't use access(2). > + break; /* no more caches found. */ > + > + caches = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + caches, sizeof(*caches) * (n_caches + 1)); > + > + /* we keep the index into the cores array to set > + the right value at the end. */ > + caches[n_caches].ProcessorMask = (ULONG_PTR)n_cores; This cast, however, is definitely not needed. > + caches[n_caches].Relationship = RelationCache; > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d" > + SYS_CPU_CACHE_LEVEL, cpu_i, i); > + if (!(f = fopen(path, "r")) || fscanf(f, "%lu", &value) != 1) > + SLPI(caches, n_caches).Cache.Level = (BYTE)0x01; Neither is this. > + else > + SLPI(caches, n_caches).Cache.Level = (BYTE)value; > + if (f) > + fclose(f); > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d" > + SYS_CPU_CACHE_ASSOC, cpu_i, i); > + if (!(f = fopen(path, "r")) || fscanf(f, "%lu", &value) != 1) > + SLPI(caches, n_caches).Cache.Associativity = 0x08; > + else > + SLPI(caches, n_caches).Cache.Associativity = (BYTE)value; > + if (f) > + fclose(f); > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d" > + SYS_CPU_CACHE_LINE, cpu_i, i); > + if (!(f = fopen(path, "r")) || fscanf(f, "%lu", &value) != 1) > + SLPI(caches, n_caches).Cache.LineSize = (WORD)64; This cast is not needed. > + else > + SLPI(caches, n_caches).Cache.LineSize = (WORD)value; > + if (f) > + fclose(f); > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d" > + SYS_CPU_CACHE_SIZE, cpu_i, i); > + if (!(f = fopen(path, "r")) || fscanf(f, "%lu", &value) != 1) > + SLPI(caches, n_caches).Cache.Size = (DWORD)16 << 10; This cast isn't needed unless an int is less than 32 bits in size. > + else > + SLPI(caches, n_caches).Cache.Size = (DWORD)value << 10; > + if (f) > + fclose(f); > + > + snprintf(path, sizeof(path), SYS_CPU "%d" SYS_CPU_CACHE "%d" > + SYS_CPU_CACHE_TYPE, cpu_i, i); > + if (!(f = fopen(path, "r")) || !fgets(string, sizeof(string), f)) > + SLPI(caches, n_caches).Cache.Type = CacheData; > + else switch (string[0]) > + { > + case 'D': > + SLPI(caches, n_caches).Cache.Type = CacheData; break; > + case 'I': > + SLPI(caches, n_caches).Cache.Type = CacheInstruction; break; > + case 'U': default: > + SLPI(caches, n_caches).Cache.Type = > + string[2] == 'i' ? CacheUnified : CacheTrace; break; > + } > + > + if (f) > + fclose(f); > + > + n_caches++; > + } > + n_cores++; > + TRACE("detected %d caches for coreid %d\n", i, core_id); > + } > + } > + > + if (n_caches < 1) > + { > + HeapFree(GetProcessHeap(), 0, caches); > + caches = NULL; > + } > + > + /* trim leftovers */ > + cores = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + cores, sizeof(*cores) * n_cores); > + > + if (1) /* final cleanup work */ Why the if (1)? > + { > + int i; > + /* set the real processor mask in the caches. */ > + for (i = 0; i < n_caches; i++) > + { > + int cores_i; > + cores_i = caches[i].ProcessorMask; > + caches[i].ProcessorMask = cores[cores_i].ProcessorMask; > + } > + > + /* remove the reserved values from the cores, set flags, > + build numa and package. */ > + > + numa[0].ProcessorMask = 0x00; > + numa[0].Relationship = RelationNumaNode; > + SLPI(numa, 0).NumaNode.NodeNumber = 0x00; > + package[0].Relationship = RelationProcessorPackage; > + > + for (i = 0; i < n_cores; i++) > + { > + SLPI(cores, i).Reserved[0] = 0; > + SLPI(cores, i).ProcessorCore.Flags = 0x00; /* ?unclear */ > + numa[0].ProcessorMask |= cores[i].ProcessorMask; > + } > + > + package[0].ProcessorMask = numa[0].ProcessorMask; > + } > + } > + > + TRACE("getting cached result.\n"); > + > + if (1) /* final check for required size, final result */ Same here. > + { > + DWORD required; required = sizeof(*cores) * (n_cores + n_caches + 2); > + if (*pbuflen < required) > + { > + TRACE("return with failure (ERROR_INSUFFICIENT_BUFFER).\n"); > + SetLastError(ERROR_INSUFFICIENT_BUFFER); > + *pbuflen = required; > + return 0; > + } > + > + *pbuflen = required; > + > + /* beware: buffer is SYSTEM_LOGICAL_PROCESSOR_INFORMATION *buffer; */ > + memcpy(buffer, cores, sizeof(*cores) * n_cores); > + buffer += n_cores; > + > + if (n_caches > 0) > + { > + memcpy(buffer, caches, sizeof(*caches) * n_caches); > + buffer += n_caches; > + } > + > + *buffer++ = package[0]; > + *buffer++ = numa[0]; > + } > + > + TRACE("return success!\n"); Is this really necessary? IMO it's generally better to be quiet if you have nothing interesting to say (in typical Unix fashion). And a function succeeding isn't interesting. > + return 1; > +} > + > +#undef SYS_CPU > +#undef SYS_CPU_MAX > +#undef SYS_CPU_COREID > +#undef SYS_CPU_PACKAGEID > +#undef SYS_CPU_CACHE > +#undef SYS_CPU_CACHE_MAX > +#undef SYS_CPU_CACHE_LEVEL > +#undef SYS_CPU_CACHE_SIZE > +#undef SYS_CPU_CACHE_TYPE > +#undef SYS_CPU_CACHE_LINE > +#undef SYS_CPU_CACHE_ASSOC > + > +#endif /* linux */ > + > /*********************************************************************** > * GetLogicalProcessorInformation (KERNEL32.@) > */ > BOOL WINAPI GetLogicalProcessorInformation(PSYSTEM_LOGICAL_PROCESSOR_INFORMATION buffer, PDWORD pBufLen) > { > - FIXME("(%p,%p): stub\n", buffer, pBufLen); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + int rv; > + > + if (pBufLen == NULL || buffer == NULL) > + { > + SetLastError(ERROR_BAD_ARGUMENTS); > + return FALSE; > + } > + > +#if defined linux > + rv = glpi_impl_linux(buffer, pBufLen); > +#else /* no supported OS found */ > + rv = -1; > +#endif > + > + /* fallback hard-coded result */ > + if (rv < 0) > + rv = glpi_impl_fb(buffer, pBufLen); > + > + return rv; > } > > /*********************************************************************** > diff --git a/dlls/kernel32/tests/Makefile.in b/dlls/kernel32/tests/Makefile.in > index dce27db..1505944 100644 > --- a/dlls/kernel32/tests/Makefile.in > +++ b/dlls/kernel32/tests/Makefile.in > @@ -17,6 +17,7 @@ C_SRCS = \ > file.c \ > format_msg.c \ > generated.c \ > + glpi.c \ > heap.c \ > loader.c \ > locale.c \ > diff --git a/dlls/kernel32/tests/glpi.c b/dlls/kernel32/tests/glpi.c > new file mode 100644 > index 0000000..a81d1d5 > --- /dev/null > +++ b/dlls/kernel32/tests/glpi.c Like I said, this should be integrated into ntdll:info instead of being its own test in kernel32. Note that the style of reporting errors is different between ntdll and kernel32. In kernel32, the function returns a BOOL, and if it's false, you have to check the LastError. In ntdll, however, functions simply return the status code directly. Also, ntdll functions return an NTSTATUS instead of a constant from <winerror.h>. > @@ -0,0 +1,82 @@ > +#include <stdarg.h> > +#include <stdlib.h> > +#include <time.h> > +#include <stdio.h> > + > +#include "wine/test.h" > +#include "windef.h" > +#include "winbase.h" > +#include "winerror.h" > + > +static void test_glpi(void) > +{ > + SYSTEM_LOGICAL_PROCESSOR_INFORMATION buffer[200]; > + DWORD buflen = sizeof(buffer); > + BOOL ret; int i, n; > + > + ret = GetLogicalProcessorInformation(NULL, &buflen); > + ok(!ret, "Passing NULL as buffer should not be ok.\n"); > + > + ret = GetLogicalProcessorInformation(buffer, NULL); > + ok(!ret, "Passing NULL as pbuflen should not be ok.\n"); > + > + ret = GetLogicalProcessorInformation(buffer, &buflen); > + ok(ret, "Normal glpi call (%d)\n", GetLastError()); Don't call GetLastError() inside an ok(). (Actually, that's moot, because this test belongs in ntdll:process, but in general, you shouldn't call GetLastError() inside an ok().) > + > + ret = GetLogicalProcessorInformation(buffer, &buflen); > + ok(ret, "glpi call with the resulting buflen (%d)\n", buflen); Showing the last error (ntdll: return status) here might help diagnosing any problems with this test. (But don't call GetLastError() inside the ok().) > + > + buflen--; > + > + ret = GetLogicalProcessorInformation(buffer, &buflen); > + ok(!ret, "glpi call with insufficient buflen (%d)\n", buflen); Here you should make sure the LastError is ERROR_INSUFFICIENT_BUFFER (corresponding NTSTATUS: STATUS_BUFFER_TOO_SMALL, or possibly STATUS_INVALID_BUFFER_SIZE), and not some other error. > + > + ret = GetLogicalProcessorInformation(buffer, &buflen); > + ok(ret, "glpi call with resulting buflen (%d)\n", buflen); Trace the LastError (ntdll: return status) here, too. > + > + n = buflen / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION); > + > + printf("glpi result: %d array elements.\n", n); Don't use printf(3); use trace(). > + > +#ifdef NONAMELESSUNION > +#define BUFFER_I buffer[i].u > +#else > +#define BUFFER_I buffer[i] > +#endif /* NONAMELESSUNION */ Like I said above, just use U(buffer[i]). > + > + for (i = 0; i < n; i++) > + { > + switch (buffer[i].Relationship) > + { > + case RelationProcessorCore: > + printf("ProcessorCore idx=%03d mask=%lxh flags=%u\n", > + i, buffer[i].ProcessorMask, BUFFER_I.ProcessorCore.Flags); > + break; > + case RelationNumaNode: > + printf("NumaNode idx=%03d mask=%lxh noden=%u\n", > + i, buffer[i].ProcessorMask, BUFFER_I.NumaNode.NodeNumber); > + break; > + case RelationCache: > + printf("Cache idx=%03d mask=%lxh " > + "l=%u, a=%u, ls=%u, sz=%u, ty=%u\n", > + i, buffer[i].ProcessorMask, > + BUFFER_I.Cache.Level, BUFFER_I.Cache.Associativity, > + BUFFER_I.Cache.LineSize, BUFFER_I.Cache.Size, > + BUFFER_I.Cache.Type); > + break; > + case RelationProcessorPackage: > + printf("ProcessorPack idx=%03d mask=%lxh\n", > + i, buffer[i].ProcessorMask); For all of these, use trace() instead of printf(3). > + break; > + default: > + ok(0, "invalid relationship %d", buffer[i].Relationship); > + } > + } > +#undef BUFFER_I > +} > + > +START_TEST(glpi) > +{ > + test_glpi(); > +} > + > -- > 1.6.4 > > > One general note about your patch: use spaces, not tabs. The rest of the file only uses tabs in doc comments. Chip

4 7

Re: dinput: Stub IDirectInputJoyConfig8 interface. (try 2)
by Jacek Caban 25 Nov '11

25 Nov '11

Hi Vitaliy, On 11/25/11 04:17, Vitaliy Margolen wrote: > Fix QueryInterface, simplify use of AddRef, and replace "LPDIRECTINPUTJOYCONFIG8" > with "IDirectInputJoyConfig8 *". > --- > dlls/dinput/dinput_main.c | 7 ++ > dlls/dinput/dinput_private.h | 2 + > dlls/dinput/joystick.c | 196 ++++++++++++++++++++++++++++++++++ > include/dinputd.h | 243 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 448 insertions(+), 0 deletions(-) > create mode 100644 include/dinputd.h > + if (IsEqualGUID(&IID_IDirectInputJoyConfig8, riid )) + { + return create_joy_config( riid, ppobj ); + } This has the same problem as we discussed about msxml3 lately: http://www.winehq.org/pipermail/wine-devel/2011-November/093279.html Are you sure native is broken the same way? +static const IDirectInputJoyConfig8Vtbl JoyConfig8vt; + +HRESULT create_joy_config(REFIID riid, LPVOID *object) +{ + IDirectInputJoyConfig8Impl *new_joy_config; + + TRACE("(%s, %p)\n", debugstr_guid(riid), object); + + new_joy_config = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*new_joy_config)); + if (!new_joy_config) return DIERR_OUTOFMEMORY; + + new_joy_config->IDirectInputJoyConfig8_iface.lpVtbl =&JoyConfig8vt; + *object = new_joy_config; + + return DI_OK; +} If you moved create_joy_config to the bottom of the file, you wouldn't need JoyConfig8vt forward declaration. +static HRESULT WINAPI JoyConfig8Impl_QueryInterface(IDirectInputJoyConfig8 *iface, REFIID riid, void** object) +{ + IDirectInputJoyConfig8Impl *This = impl_from_IDirectInputJoyConfig8(iface); + + TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), object); + + if (IsEqualGUID(&IID_IUnknown, riid) || + IsEqualGUID(&IID_IDirectInput8W, riid)) Here is a typo, it should be IID_IDirectInputJoyConfig8. Jacek

2 1

Re: [PATCH] server: assert on failure to open /dev/null (Coverity)
by Eric Pouech 25 Nov '11

25 Nov '11

Marcus, IMO,fatal_error() should be preferred over assert() (hoping that fatal_error() is actually marked as no_return) A+ 2011/11/25 Marcus Meissner <meissner(a)suse.de> > Hi, > > if we cannot open /dev/null something is really broken. > CID 5470 > > Ciao, Marcus > --- > server/request.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/server/request.c b/server/request.c > index 05c7464..06fdbe8 100644 > --- a/server/request.c > +++ b/server/request.c > @@ -760,6 +760,7 @@ void open_master_socket(void) > > /* make sure the stdio fds are open */ > fd = open( "/dev/null", O_RDWR ); > + assert (fd != -1); > while (fd >= 0 && fd <= 2) fd = dup( fd ); > > if (!server_dir) fatal_error( "directory %s cannot be accessed\n", > config_dir ); > -- > 1.7.1 > > > > -- -- Eric Pouech

2 1

Re: [PATCH 1/2] kernel32: implement GetLogicalProcessorInformation
by Marvin 25 Nov '11

25 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15626 Your paranoid android. === WNT4WSSP6 (32 bit glpi) === Timeout === W2KPROSP4 (32 bit glpi) === Timeout

1 0

Re: cmd: Use WCMD_output_asis*() for strings that are not supposed to contain formating directives.
by Frédéric Delanoy 24 Nov '11

24 Nov '11

On Thu, Nov 24, 2011 at 00:30, Francois Gouget <fgouget(a)free.fr> wrote: > Using WCMD_output*() instead could cause crashes. > --- > > For instance if a filename is '%s'. > This patch should not interfere with the previous one. > - WCMD_output(newline); > + WCMD_output_asis(newline); ... > static const WCHAR newLine2[] = {'\n','\n','\0'}; > - if (!bare) WCMD_output (newLine2); > + if (!bare) WCMD_output_asis (newLine2); ... > - WCMD_output(anykey); > + WCMD_output_asis(anykey); No need to change those, since we control those strings, and those are generic strings with no '%' directive. > - WCMD_output (version_string); > + WCMD_output_asis (version_string); This one does contain a %s ( WCMD_VERSION,"CMD Version %s\n"), but we control the version string as well (currently Wine version), so shouldn't probably be changed. > @@ -430,13 +430,13 @@ static DIRECTORY_STACK *WCMD_list_directory (DIRECTORY_STACK *inputparms, int le > strcatW(&temp[toWrite], space); > toWrite++; > if (toWrite > 99) { > - WCMD_output(temp); > + WCMD_output_asis(temp); > toWrite = 0; > strcpyW(temp, nullW); > } > padding--; > } > - WCMD_output(temp); > + WCMD_output_asis(temp); > } It's just doing padding with plain spaces, so no changes needed here. The remaining hunks should be OK. Frédéric

2 2

Re: winhttp: Resolve the server name only on the first request.
by Alexandre Julliard 24 Nov '11

24 Nov '11

Hans Leidekker <hans(a)codeweavers.com> writes: > - send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_RESOLVING_NAME, connect->servername, strlenW(connect->servername) + 1 ); > + if (connect->sockaddr.ss_family == 0xffff) > + { This won't work on Mac OS, ss_family is a byte: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/sw/include/freetype2 -I/sw/include -I/sw/include -g -O2 -o request.o request.c request.c: In function 'open_connection': request.c:931: warning: comparison is always false due to limited range of data type -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: Stub IDirectInputJoyConfig8 interface.
by Michael Stefaniuc 24 Nov '11

24 Nov '11

Hello Vitaliy, On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: > --- > dlls/dinput/dinput_main.c | 7 ++ > dlls/dinput/dinput_private.h | 2 + > dlls/dinput/joystick.c | 195 +++++++++++++++++++++++++++++++++ > include/dinputd.h | 243 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 447 insertions(+), 0 deletions(-) > create mode 100644 include/dinputd.h we are trying to get rid off the LPJUNK, IDirectInputJoyConfig8 * is so much more nicer than LPDIRECTINPUTJOYCONFIG8. While the above is more of a nit-pick (and an easy search and replace patch for me) the QueryInterface implementation is not correct: - Query for IID_IUnknown is not supported. - Use IDirectInputJoyConfig8_AddRef() on the interface without the cast - You can save the round trip over impl_from_IDirectInputJoyConfig8() as iface and &This->IDirectInputJoyConfig8_iface are the exact same thing. bye michael

2 2

Sugestion about wine
by Kane Jade 24 Nov '11

24 Nov '11

Perhaps the program Zynamics BinNavi is useful to analyze the win32 applications, etc: Zynamics BinNavi is the primary binary code reverse engineering tool based on graph visualization Description BinNavi is a binary code reverse engineering tool that was built to assist vulnerability researchers who look for vulnerabilities in disassembled code. With BinNavi you can analyze disassembled x86, ARM, PowerPC, and MIPS code using the powerful built-in static code analysis techniques. In cases where static code analysis is not enough, you can use the built-in debuggers to get a live view on the program you are analyzing. Use Cases - Do *control flow based code analysis* of disassembled x86, ARM, MIPS, and PowerPC code - *Cut down on complexity* by removing unimportant code from functions - Use *powerful remote debuggers* to debug programs on different operating systems - Use Differential Debugging to *quickly locate relevant code* - Create and assign user-defined tags to *mark important functions and basic blocks* - Use *advanced code analysis algorithms* to keep track of data and code - Manage all your reverse engineering projects in *one central database* - Write *scripts and plugins to extend BinNavi* to meet your specific goals - Rename and *annotate variables and functions* to make them self-explanatory - Use the REIL meta-language to *write platform-independent program analysis code* To learn more about the features and use cases of BinNavi please take a look at the BinNavi manual<http://www.zynamics.com/binnavi/manual/index.htm> . I think that it is easier to see how they are running operations on files connected with the BinNavi program. Since is a transparent, simpler and interesting debugger. link http://www.zynamics.com/binnavi.html Forgive this text is translated by translatica.pl.

2 1

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation
by Marvin 24 Nov '11

24 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15612 Your paranoid android. === WNT4WSSP6 (32 bit glpi) === Timeout === W2KPROSP4 (32 bit glpi) === Timeout

1 0

Re: cmd: Print error messages on stderr, not on stdout.
by Frédéric Delanoy 24 Nov '11

24 Nov '11

On Thu, Nov 24, 2011 at 00:29, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > I consider messages like 'Not Yet Implemented' and 'No Argument' to be > errors so that they should go to stderr. But maybe there's a strong > argument for not doing it that way. Your point is valid. I changed some/most of those myself some time ago. However the test suite fails with your patch applied (e.g. for the incomplete "for" construct). Some of the hunks might be applied though, but you'd have to run the test suite to be sure. Frédéric

1 0

Re: [PATCH] wininet: Initialize netconn_stream's content_length
by Jacek Caban 23 Nov '11

23 Nov '11

Hi Andy, On 11/22/11 5:49 AM, Andy Clayton wrote: > The size that net_conn_read reads is limited by netconn_stream's > remaining content_length, so if the content_length is zero it reads > nothing. It also means that the read size it returns is 0, which > typically indicates that the socket was closed. As a result of the > change from 193da884ad9b982d9b740b15453aa8d3c19b054f, > HTTP_ReceiveRequestData acts on the read size of 0 and closes the > connection. HttpSendRequest calls HTTP_ReceiveRequestData if there is no > post data, closing the connection with none of the response data ever > being read. > > This patch fixes this case by initializing netconn_stream's > content_length to ~0. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=27816 > This doesn't seem right. At the point where we call HTTP_ReceiveRequestData, content_length is supposed to be set based on response header. The bug must be somewhere else. Jacek

2 3

Re: po: Update French translation (try 2)
by Frédéric Delanoy 22 Nov '11

22 Nov '11

2011/11/22 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > try 2: xB -> xO > --- > po/fr.po | 52 +++++++++++++++++++--------------------------------- > 1 files changed, 19 insertions(+), 33 deletions(-) Seems you have committed the initial version. I'll change 'bytes' to 'octets' on next po update round, therefore you may forget about this patch. Frédéric

1 0

Re: po: Update French translation
by Francois Gouget 22 Nov '11

22 Nov '11

On Mon, 21 Nov 2011, Frédéric Delanoy wrote: [...] > msgid "%1!u!MB used, %2!u!MB available" > -msgstr "%u MB utilisés, %u MB disponibles" > +msgstr "%1!u! MB utilisés, %2!u! MB disponibles" [...] > msgctxt "unit kilobyte" > msgid "kB" > -msgstr "" > +msgstr "kB" > > #: winefile.rc:122 > msgctxt "unit megabyte" > msgid "MB" > -msgstr "" > +msgstr "MB" > > #: winefile.rc:123 > msgctxt "unit gigabyte" > msgid "GB" > -msgstr "" > +msgstr "GB" kB, MB and GB should be translated to ko, Mo and Go respectively. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

2 3

Re: [PATCH 1/2] jscript: Added tests of unary '+' on not existent property
by Marvin 22 Nov '11

22 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15587 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [4/5] ntdll: Remove an invalid test.
by Alexandre Julliard 22 Nov '11

22 Nov '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The test initializers that call GetProcAddress() do write to the same section > where the static buffer resides, which leads to the image section protection > change. That doesn't make the test invalid. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL
by Henri Verbeet 22 Nov '11

22 Nov '11

On 22 November 2011 00:42, Eduard - Gabriel Munteanu <eduard.munteanu(a)linux360.ro> wrote: > This fixes a division by zero generated in Unigine Tropics in D3D10 > mode. It also adds a helper to handle such conversions, which takes the > form of a macro so we don't need to worry about the result's type. > I'd prefer an actual function. A small test for this probably wouldn't hurt either.

1 0

Re: winefile: Make it possible to translate the disk size units.
by Francois Gouget 22 Nov '11

22 Nov '11

On Sat, 19 Nov 2011, Francois Gouget wrote: [...] > - static const WCHAR sFmtGB[] = {'%', '.', '1', 'f', ' ', 'G', 'B', '\0'}; > - static const WCHAR sFmtMB[] = {'%', '.', '1', 'f', ' ', 'M', 'B', '\0'}; > - static const WCHAR sFmtkB[] = {'%', '.', '1', 'f', ' ', 'k', 'B', '\0'}; To be totally correct these should actually be 'GiB', 'MiB' and 'kiB' (the code divides by powers of 1024). However that may be too geeky for regular users so I'm not sure we want to do that. But now is probably a good time to debate this. Here are two reference points: * On Windows winefile and explorer use 'KB' & co for the disk space although they divide by '1024'. * Nautilus uses 'kiB' & co. Another point is that we always display the exact byte count for file sizes instead of converting it to 'KB', 'MB', etc. That actually matches winfile but seems pretty cubersome. On Windows Explorer does show file sizes as 'KB', 'MB', etc. so that's what users would expect and I think it's a place where we could follow suite. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

3 2

regression bisected to commit: gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function.
by Wolfgang Walter 21 Nov '11

21 Nov '11

Hello, I just tested version 1.3.33. With this version an application we use shows its icons with wrong colors. The background of the icons is wrong, too. I bisected it to commit c9a7bb715d2db1512db30deb11e4676e76791a07. I then checked that by replacing nulldrv_StretchDIBits in 1.3.33 with its older implementation. c9a7bb715d2db1512db30deb11e4676e76791a07 is the first bad commit commit c9a7bb715d2db1512db30deb11e4676e76791a07 Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Oct 17 15:46:07 2011 +0100 gdi32: Implement nulldrv_StretchDIBits using the PutImage gdi driver function. :040000 040000 e4cfeee3adcb0fe2c0502909c87b2740a8de08e5 00851b246b095bdf4cafd3e6f9965c811d1c87a4 M dlls Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Abteilungsleiter IT Leopoldstraße 15 80802 München

2 1

Question about messages and the windows these need.
by Joerg-Cyril.Hoehle＠t-systems.com 21 Nov '11

21 Nov '11

Hi, Alexandre Julliard wrote in http://www.winehq.org/pipermail/wine-devel/2011-July/090969.html >If you are going to wait for a reply it would be better to create a >HWND_MESSAGE window and do a SendMessage to it, then you get all the >synchronization for free. MMSYSTEM_MidiStream_Player needs a patch to fix bug #28388. Such a patch will likely introduce sending Suspend & Resume messages to the MIDI player (to be able to wait for the resume signal). So I believe this same advice applies. MMSYSTEM_MidiStream_PostMessage already contains a PostThreadMessage + MsgWait pair that looks like it should be replaced, correct? OTOH, I'm unsettled whether MidiStreamSuspend & -Restart should wait for a reply to the message, so PostThreadMessage may be enough. Furthermore, I'm unsure about the implications of adding a dummy window and message queue. The MSDN blogs contain repeated warnings about the obligation to pump the message queue and GUI apps hanging when some random app fails to do so in all situations. Won't that window receive all kinds of broadcast messages? No, says MSDN http://msdn.microsoft.com/en-us/library/windows/desktop/ms632599%28v=vs.85%… The MIDI sequencer uses simplistic timing based on GetTickCount. Won't that allow arbitrary foreign window callbacks to disturb the timing of the MIDI sequencer? Instead of inventing message names like #define WINE_MSM_STOP (WM_USER+1) Why not re-use message names like MCI_STOP even if it's not in MCI format? (sounds like a hack...) Thank you for your help, Jörg Höhle

1 0

Re: [PATCH 1/1] user32: Fix 64-bit 'msg' test hang in test_timers.
by Alexandre Julliard 21 Nov '11

21 Nov '11

"Erich E. Hoover" <ehoover(a)mines.edu> writes: > Real Name: > Erich Hoover > > Description: > The TestBot ran into a hanging issue (noticed with, but unrelated > to, my previous user32 patch) and I took some time today to track the > problem down. Currently, on the 64-bit test system the test_timers() > tests hang waiting for PeekMessage() to clear the message queue. The > attached patch kills the timer just prior to the PeekMessage() call, > thereby keeping the test from hanging indefinitely. > > Changelog: > user32: Fix 64-bit 'msg' test hang in test_timers. That defeats the purpose of the test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/4] msxml3: Added common ISupportErrorInfo implementation
by Jacek Caban 21 Nov '11

21 Nov '11

Hi Nikolay, On 11/21/11 08:24, Nikolay Sivov wrote: > Added common ISupportErrorInfo implementation +/* common ISupportErrorInfo implementation */ +typedef struct { + ISupportErrorInfo ISupportErrorInfo_iface; + LONG ref; + + const tid_t* iids; +} SupportErrorInfo; + +static inline SupportErrorInfo *impl_from_ISupportErrorInfo(ISupportErrorInfo *iface) +{ + return CONTAINING_RECORD(iface, SupportErrorInfo, ISupportErrorInfo_iface); +} + +static HRESULT WINAPI SupportErrorInfo_QueryInterface(ISupportErrorInfo *iface, REFIID riid, void **obj) +{ + SupportErrorInfo *This = impl_from_ISupportErrorInfo(iface); + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), obj); + + *obj = NULL; + + if (IsEqualGUID(riid,&IID_IUnknown) || IsEqualGUID(riid,&IID_ISupportErrorInfo)) { + *obj = iface; + ISupportErrorInfo_AddRef(iface); + return S_OK; + } + + return E_NOINTERFACE; +} This doesn't seem to be the right approach. You need to return here interfaces of an object that inherits your ISupportErrorInfo implementation - that's the COM rule. Also you probably don't want to create new SupportErrorInfo instance on each QI call. I'd suggest DispatchEx-like approach in this case (or even abuse DispatchEx object and add ISupportErrorInfo there). Jacek

2 5

Re: [PATCH 1/2] jscript: Use bytecode for binary negation implementation
by Marvin 21 Nov '11

21 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15559 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: qedit/tests: Add SampleGrabber COM aggregation test.
by Marvin 21 Nov '11

21 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15558 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2 === W2KPROSP4 (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2 === W2K8SE (32 bit mediadet) === mediadet.c:147: Test failed: CoCreateInstance failed with 80040154 mediadet.c:148: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 004015A2

2 1

Re: user32/tests: Drop superfluous function pointer casts.
by Marvin 21 Nov '11

21 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15553 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

2 1

re: ID3DXEffect test on win
by Dan Kegel 20 Nov '11

20 Nov '11

Hi Rico, I compiled the 32 bit wine tests on win7 64 bit using cygwin, and sure enough, there are 40 test failures there. You should probably avoid doing direct equality tests on floats; see e.g. compare() at line 47 of d3dx9_36/tests/mesh.c. You may have to tweak the slop value. (Google floating point comparison if you want the gory details of how tools like google test and boost's test_tools do it right.) effect.c:894: Test failed: 0 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 0 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 0 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 0 - f31: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 0 - f31: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f31: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f31: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 0 - f41: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 0 - f41: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 0 - f41: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[8] failed, got 0.203922, expected 0.203922 effect.c:1321: Test failed: 0 - f41: GetMatrix fvalue[12] failed, got 0.121569, expected 0.121569 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1438: Test failed: 0 - f41: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f3: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f3max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:1142: Test failed: 3 - f3max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f3max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f3max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:894: Test failed: 3 - f4: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4min: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4min: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4min: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4min: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4min: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:894: Test failed: 3 - f4max: GetValue value[2] failed, got 0x3e50d0d2, expected 0x3e50d0d1 effect.c:894: Test failed: 3 - f4max: GetValue value[3] failed, got 0x3df8f8fa, expected 0x3df8f8f9 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[2] failed, got 0.203922, expected 0.203922 effect.c:1142: Test failed: 3 - f4max: GetFloatArray favalue[3] failed, got 0.121569, expected 0.121569 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1211: Test failed: 3 - f4max: GetVector fvalue[3] failed, got 0.121569, expected 0.121569 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[2] failed, got 0.203922, expected 0.203922 effect.c:1461: Test failed: 3 - f4max: GetMatrixTranspose fvalue[3] failed, got 0.121569, expected 0.121569 effect: 1222410 tests executed (0 marked as todo, 60 failures), 0 skipped.

2 1

Re: [3/4] winemaker: Be less picky when detecting the target type (try 2)
by Vitaliy Margolen 20 Nov '11

20 Nov '11

On 11/19/2011 11:42 AM, André Hentschel wrote: > this catches more than one 0 after the space and possible 0s after the x > + if (/[[:space:]]0+x0*101$/) { For more then one you should use "+" not "*". "*" means any number, including 0. Vitaliy

2 1

Re: added moethod stub for HttpPrepareUrl in dlls/httpapi/httpapi_main.c
by Bruno Jesus 20 Nov '11

20 Nov '11

You have to use your full name (as advised before). See http://wiki.winehq.org/SubmittingPatches for more information. Also, gmail is breaking your patch, attach the patch file instead of pasting it to the email body. Best wishes, Bruno On Sat, Nov 19, 2011 at 09:24, ArasH <arash.cordi(a)gmail.com> wrote: > --- > dlls/httpapi/httpapi_main.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c > index 3375cb6..c5c8cda 100644 > --- a/dlls/httpapi/httpapi_main.c > +++ b/dlls/httpapi/httpapi_main.c > @@ -85,6 +85,27 @@ ULONG WINAPI HttpTerminate( ULONG flags, PVOID reserved ) > } > > /*********************************************************************** > + * HttpPrepareUrl (HTTPAPI.@) > + * parses, analyzes, and normalizes a non-normalized Unicode or punycode URL > + * so it is safe and valid to use in other HTTP functions. > + * > + * PARAMS > + * reserved [IO] reserved, must be NULL > + * flags [ I] reserved. must be zero > + * url [ I] a pointer to a string that represents the > non-normalized URL > + * prepared_url [ O] on success, a pointer to a string > representing the normalized URL. > + * > + * RETURNS > + * ERROR_SUCCESS if function succeeds, or error code if function fails > + * > + */ > +ULONG WINAPI HttpPrepareUrl( PVOID reserved, ULONG flags, PCWSTR url, > PWSTR *prepared_url) > +{ > + FIXME( "(%p, 0x%x, %p): stub!\n", reserved, flags, url ); > + return ERROR_SUCCESS; > +} > + > +/*********************************************************************** > * HttpDeleteServiceConfiguration (HTTPAPI.@) > * > * Remove configuration record from HTTP Server API configuration store > -- > 1.6.2.2 > > >

1 0

ID3DXEffect test on win
by Rico Schüller 19 Nov '11

19 Nov '11

Hi, I've written some tests for the ID3DXEffect interface. The test is attached as source. What I'd like to know is if there are some rounding issues on some win versions. The test needs d3dx9_36.dll. I tried it on wine with native d3dx9_36.dll and got around 60 rounding errors (only on the combination SetInt() and GetValue/FloatArray/Vector/Matrix/MatrixTranspose). It would be nice if there is anyone interested in running those and would report the result. I'm looking for results on XP/W7/Vista. If you don't have a cross compiler and like to try the test, I could send the executable. Cheers Rico

1 0

Re: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by Alexandre Julliard 18 Nov '11

18 Nov '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The tests clearly show that this commit is wrong. If there is an application > or a test case which fails because of this, it would be helpful to at least > mention it. It fixes the test for .bss protection, in ntdll:info.c. -- Alexandre Julliard julliard(a)winehq.org

4 8

Translations strangeness
by Luca Bennati 18 Nov '11

18 Nov '11

Hi all, I would like to clarify some doubts I have about Wine translations and its po/rc files: 1- Are the following highlighted strings errors from the script converting from rc to po or due to malformatted po files (seems not to recognize msgctx lines)? http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… http://source.winehq.org/transl/resource.php?branch=master&lang=009%3A01&re… 2- Are the following highlighted strings (and similar) translatable or they were wrongly recognized by script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… 3- How is it that the following highlighted strings are translated in po files but seems not to be taken in consideration from script? http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… http://source.winehq.org/transl/resource.php?branch=master&lang=010%3A00&re… None here) I took the italian translations as example because I'm its actual volunteer maintainer and I know them. In summary, is it our (the translators) or my fault or is the script lacking? Nonetheless, how can we solve those issues?

2 1

Re: [5/5]usp10: Itemize numbers outside of the basic ascii set in a seperate script.
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15519 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2KPROSP4 (32 bit usp10) === usp10.c:400: Test failed: 0:Wrong fRTL(1) usp10.c:400: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:400: Test failed: 0:Wrong BidiLevel(1) usp10.c:431: Test failed: 0:Wrong fRTL(1) usp10.c:431: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:431: Test failed: 0:Wrong BidiLevel(1) usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === WXPPROSP3 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos === W2K3R2SESP2 (32 bit usp10) === usp10.c:433: Test failed: Wrong number of items usp10.c:433: Test failed: 1:Wrong CharPos (3) usp10.c:433: Test failed: 1:Wrong fRTL(1) usp10.c:433: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:433: Test failed: 1:Wrong BidiLevel(1) usp10.c:433: Test failed: 2:Wrong CharPos

1 0

Re: [4/5]usp10: Windows breaks punctuation into 2 different script types.
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15518 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2KPROSP4 (32 bit usp10) === usp10.c:393: Test failed: 0:Wrong fRTL(1) usp10.c:393: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:393: Test failed: 0:Wrong BidiLevel(1) usp10.c:423: Test failed: 0:Wrong fRTL(1) usp10.c:423: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:423: Test failed: 0:Wrong BidiLevel(1) usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === WXPPROSP3 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel === W2K3R2SESP2 (32 bit usp10) === usp10.c:425: Test failed: Wrong number of items usp10.c:425: Test failed: 1:Wrong CharPos (3) usp10.c:425: Test failed: 1:Wrong fRTL(1) usp10.c:425: Test failed: 1:Wrong fLayoutRTL(1) usp10.c:425: Test failed: 1:Wrong BidiLevel(1) usp10.c:425: Test failed: 2:Wrong CharPos (6) usp10.c:425: Test failed: 2:Wrong fRTL usp10.c:425: Test failed: 2:Wrong fLayoutRTL usp10.c:425: Test failed: 2:Wrong BidiLevel

1 0

Re: [3/5]usp10: handle Combining Diacritical Marks
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15517 Your paranoid android. === WNT4WSSP6 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1) === W2KPROSP4 (32 bit usp10) === usp10.c:384: Test failed: 0:Wrong fRTL(1) usp10.c:384: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:384: Test failed: 0:Wrong BidiLevel(1) usp10.c:413: Test failed: 0:Wrong fRTL(1) usp10.c:413: Test failed: 0:Wrong fLayoutRTL(1) usp10.c:413: Test failed: 0:Wrong BidiLevel(1)

1 0

Re: [PATCH 5/5] jscript: Use bytecode interpreter for logical negation expression
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15516 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: ieframe: Fixed tests on IE9
by Marvin 18 Nov '11

18 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15514 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3165: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3132: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

2 1

Using native msvc*.dll: all or nothing?
by Dan Kegel 18 Nov '11

18 Nov '11

Given errors like err:module:find_forwarded_export function not found for forward 'msvcrt.__CxxFrameHandler3' used by L"C:\\windows\\system32\\msvcr90.dll". If you are using builtin L"msvcr90.dll", try using the native one instead. I'm starting to get the feeling that, if you're going to install any flavor of Microsoft C++ runtime libraries, you should install them all. Is that more or less correct? i.e. should winetricks add a verb that installs all of vcrun6, vcrun2003, vcrun2005, vcrun2008, and maybe vcrun2010 and encourage users to do that instead of installing the individual libraries?

2 1

Re: Re: Re: added remaining functions, data structures, definitions required by http api to include/
by Juan Lang 18 Nov '11

18 Nov '11

Hi Arash, >> I'm also concerned whether this was the product of copy/paste, which >> isn't allowed. Was it? > about that copy/paste stuff, > well I guess we eventually produce an almost identical header file with one > in the SDK > I mean everything in the header file is already exposed to the user and "IS" > part of API > am I not right? I might agree with you, but lawyers might not. As a result, we don't allow copy/paste code in Wine, even in headers. > just one more question if you don't mind! > should I use winsock for socket programming or native linux's? and > for some library I may need (regex for example) is there any restriction or > convection or something like that or I can use any third party lib? Native linux sockets are typically used, unless there's good reason for them not to be. 3rd party libraries are harder to work with. You typically have to choose something which you expect will be installed on every common platform, built appropriate configure checks to determine if the library is present at compile time, make your code fail gracefully if not, and dynamically load the library at runtime. Static linking is also viable, if you expect the library is commonly available, and if the license is compatible: LGPL and BSD are, GPL is not, just to give a few examples. It'd help more if we knew precisely what you're working on, and what you need e.g. regex for. --Juan

1 0

FOSDEM 2012 - CrossDesktop DevRoom Call for Talks
by Pau Garcia i Quiles 18 Nov '11

18 Nov '11

Hi, FOSDEM is one of the largest gatherings of Free Software contributors in the world and happens each February in Brussels (Belgium). One of the tracks will be the CrossDesktop DevRoom, which will host Desktop-related talks. We are now inviting proposals for talks about Free/Libre/Open-source Software on the topics of Desktop development, Desktop applications and interoperativity amongst Desktop Environments. This is a unique opportunity to show novel ideas and developments to a wide technical audience. Topics accepted include, but are not limited to: Enlightenment, Gnome, KDE, XFCE, Windows, Mac OS X, general desktop matters, applications that enhance desktops and web (when related to desktop). Talks can be very specific, such as developing mobile applications with Qt Quick; or as general as predictions for the fusion of Desktop and web in 5 years time. Topics that are of interest to the users and developers of all desktop environments are especially welcome. The FOSDEM 2011 schedule might give you some inspiration: http://archive.fosdem.org/2011/schedule/track/crossdesktop_devroom Please include the following information when submitting a proposal: your name, the title of your talk (please be descriptive, as titles will be listed with around 250 from other projects) and a short abstract of one or two paragraphs. The deadline for submissions is December 20th 2011. FOSDEM will be held on the weekend of 4-5 February 2012. Please submit your proposals to: crossdesktop-devroom(a)lists.fosdem.org ( https://lists.fosdem.org/listinfo/crossdesktop-devroom ) -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)

1 0

Re: mshtml: fix MSVC build in htmllocation.c
by Nikolay Sivov 17 Nov '11

17 Nov '11

On 11/17/2011 15:18, Thomas Faber wrote: > This removes the use of two Variable Length Arrays. > Instead of filling a local buffer, then allocating a new one using > SysAllocString[Len], the strings are now directly written to the latter > buffer. > Note that the 'len' variable in hunk 2 does not need to count in the > terminating null in this case because SysAllocStringLen automatically > adds one. > - WCHAR buf[url.dwSchemeLength + 1]; > + WCHAR *buf; > + buf = *p = SysAllocStringLen(NULL, url.dwSchemeLength + 1); > memcpy(buf, url.lpszScheme, url.dwSchemeLength * sizeof(WCHAR)); > buf[url.dwSchemeLength] = ':'; > - *p = SysAllocStringLen(buf, url.dwSchemeLength + 1); You don't need 'buf' variable after that.

1 0

Antw.: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece.
by André Hentschel 17 Nov '11

17 Nov '11

I would love to see such a tool, i could use it for some actctx tests in ntdll Gesendet mit meinem HTC ----- Reply message ----- Von: "Saulius Krasuckas" <saulius2(a)ar.fi.lt> An: "Alexandre Julliard" <julliard(a)winehq.org> Cc: <wine-devel(a)winehq.org> Betreff: ntdll: Revert 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece. Datum: Do., Nov. 17, 2011 18:49 On Thu, 17 Nov 2011, Alexandre Julliard wrote: > > The test requires a PE binary because obviously we can't test PE > protections on Unix binaries. That doesn't mean it doesn't exist. Just > build a crosstest: > > $ wine ntdll_crosstest.exe info.c > info.c:1296: Test failed: mbi.Protect is 0x8, expected 0x4 IIRC, some of tests already craft minimal PE binaries in manual way. So it would be nice to have some tool inside the tree to generate PEs independetly, no? Several years ago I've tried testing GetStdHandle() from within two PE binaries with different header flags set (IMAGE_SUBSYSTEM_WINDOWS_[GC]UI). For a start I have copied some code of manual PE crafting to build PE header. Then there came .text section's order. I realized it's sufficient to write small assembler file, run it through the gas crosscompiler, disasm it and parse the results to have _not only_ binary data for rebuilding PE, but also symbolic one. I wrote some awk-script then to convert .S file into C-function this way. With it it was easy to adjust options for crosscompiling gas/ld tools to get PE with needed structure. But maybe there is point in creating some universal in-tree tool? Or integrate the functionality into winegcc (or else) so as not to depend on a crosscompiling suite but still have readable and easy changeable source. Guys, what do you think? S.

1 0

Re: Re: added remaining functions, data structures, definitions required by http api to include/http
by Juan Lang 17 Nov '11

17 Nov '11

> can you be more specific please? Yes: +#ifndef __HTTP_H__ +#define __HTTP_H__ Don't do that, it's already #ifdef protected. +/*#if _WIN32_WINNT >= 0x0501*/ Dead code, just leave it out. +typedef struct _HTTP_REQUEST_V2 +{ + /* TODO : anonymous structure is not supported by C standard */ + /* struct HTTP_REQUEST_V1; */ For one thing, that's what the DUMMYSTRUCTNAME macro is for. For another, by omitting it, you've made the structure binary incompatible with the PSDK one for C code. Clearly that's wrong. I stopped reviewing here, you have many examples of the above error. I'm also concerned whether this was the product of copy/paste, which isn't allowed. Was it? --Juan

1 0

Re: [PATCH 1/1] ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets (try 2, resend).
by Juan Lang 17 Nov '11

17 Nov '11

Hi Erich, + * Bind the given socket exclusively to a specific interface. I know the style around here is to comment minimally, but I didn't find it clear what the behavior of this function is. For one thing, +static int interface_bind( int fd, struct sockaddr *addr ) (snip) + int ret = FALSE; (snip) + ret = TRUE; You're using #defines used with BOOL, so a BOOL return value would be a little clearer IMO. int, in the context of socket functions, often uses 0 => success, -1 => failure. Still, even with that change, + if (in_sock->sin_addr.s_addr == htonl(WS_INADDR_ANY)) + { + /* Not binding to specific interface, use default route */ + goto cleanup; + } + optlen = sizeof(sock_type); + if (getsockopt(fd, SOL_SOCKET, SO_TYPE, &sock_type, &optlen) == -1 + || sock_type != SOCK_DGRAM) + { + /* Not a UDP socket, interface-specific bind is irrelevant. */ + goto cleanup; These two blocks will use the default return value, FALSE, and it wasn't clear to me from the function name or comment that it should return FALSE in this case. Not that doing so is incorrect: just that it isn't obvious that that's the way it should behave. In this case, I feel a comment indicating that the function returns TRUE iff the function bound to a specific device, and that FALSE doesn't necessarily mean failure, is merited. Also, + /* Obtain the size of the IPv4 adapter list and allocate structure memory */ + if (GetAdaptersInfo(NULL, &adap_size) != ERROR_BUFFER_OVERFLOW) Why do all this outside the #ifdef SO_BINDTODEVICE guard? I'd rather you just had a different implementation of the function when SO_BINDTODEVICE isn't present that issues the warning and does nothing else. I'll let Alexandre comment on whether the approach itself is appropriate. Thanks, --Juan

2 1

Re: [PATCH 2/2] mshtml: Added tests of handling ActiveX objects without IQuickActivate interface implemented
by Alexandre Julliard 17 Nov '11

17 Nov '11

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/activex.c | 133 > ++++++++++++++++++++++++++++++------------ > 1 files changed, 95 insertions(+), 38 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so activex.c && touch activex.ok wine: Unhandled page fault on read access to 0x00000008 at address 0x6a76d2a6 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x6a76d2a6). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6a76d2a6 ESP:0032fab0 EBP:0032fac8 EFLAGS:00010206( R- -- I - -P- ) EAX:01824650 EBX:00000000 ECX:00000008 EDX:00000000 ESI:01824650 EDI:00000000 Stack dump: 0x0032fab0: 01824650 6ad31584 0182459c 018244c8 0x0032fac0: 018244c8 00000000 0032faf8 6a45f2cd 0x0032fad0: 018244c8 00000003 6ad316db 00000000 0x0032fae0: 018244c8 0032fb28 001ab708 01828bd8 0x0032faf0: 0171af60 00000000 0032fb48 6a4b7d29 0x0032fb00: 018244c8 00000000 0032fb28 6a617b0f Backtrace: =>0 0x6a76d2a6 in xul (+0xb2d2a6) (0x0032fac8) 1 0x6a45f2cd in xul (+0x81f2cc) (0x0032faf8) 2 0x6a4b7d29 in xul (+0x877d28) (0x0032fb48) 3 0x6a4b9648 in xul (+0x879647) (0x0032fb98) 4 0x6a4b73db in xul (+0x8773da) (0x0032fbc8) 5 0x555e04e7 NSContainer_Release+0x76(This=0x17978b8) [/home/julliard/wine/wine/dlls/mshtml/nsembed.c:1886] in mshtml (0x0032fbf8) 6 0x55585435 CustomDoc_Release+0x1c4(iface=0x135c8c) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2315] in mshtml (0x0032fc38) 7 0x5557f2e4 HTMLDocument_Release+0x13(iface=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:433] in mshtml (0x0032fc58) 8 0x687657a4 release_doc+0x23(doc=0x135b78) [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:1945] in mshtml_test (0x0032fc78) 9 0x6876a445 func_activex+0x18b4() [/home/julliard/wine/wine/dlls/mshtml/tests/activex.c:2060] in mshtml_test (0x0032fd58) 10 0x68763202 main+0x3a1(argc=*** Invalid address 0x00000008 *** , argv=*** Invalid address 0x0000000c *** Internal symbol error: unable to access memory location 0xc) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe28) 11 0x687becf5 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fe70) 12 0x6848858c call_process_entry+0xb() in kernel32 (0x0032fe88) 13 0x6848953f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1090] in kernel32 (0x0032fec8) 14 0x68375dd0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8) 15 0x68378abd call_thread_func+0x7c(entry=0x684894e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8) 16 0x68375dae call_thread_entry_point+0x11() in ntdll (0x0032ffc8) 17 0x6834dece start_process+0x1d(kernel_start=0x684894e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 18 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x6a76d2a6: call *0x8(%edx) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dinput: Delete the static critical section when unloading the dll.
by Vitaliy Margolen 17 Nov '11

17 Nov '11

On 11/16/2011 08:31 AM, Francois Gouget wrote: > --- > > I moved DllMain() to the end of the file so it comes after the variable > declaration. It's already forward declared few lines after DllMain(). So you should move that declaration instead. Hm... it seems this patch already committed. Alexadre, would you please give people at least 24 hours to review all patches sent to wine-patches before committing them? Vitaliy.

3 3

re: added remaining functions, data structures, definitions required by http api to include/http.h
by Dan Kegel 17 Nov '11

17 Nov '11

That's a lot of stuff. What needs it? Also, please avoid trivial whitespace changes.

2 1

Re: added remaining functions, data structures, definitions required by http api to include/http.h
by Frédéric Delanoy 16 Nov '11

16 Nov '11

On Wed, Nov 16, 2011 at 14:15, ArasH <arash.cordi(a)gmail.com> wrote: > --- > include/http.h | 1266 +++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 1251 insertions(+), 15 deletions(-) The patch should show your full name. See http://wiki.winehq.org/SubmittingPatches for more information.

1 0

Re: mshtml: Fixed some htmldoc.c tests on IE9
by Marvin 16 Nov '11

16 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15467 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37 === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2890: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2709: Test failed: unexpected call Exec_ShellDocView_37

2 1

Re: [PATCH 1/1] user32: Prioritize focus for dialog owner on EndDialog (resend).
by Marvin 16 Nov '11

16 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15456 Your paranoid android. === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Implement D3D10StateBlockMaskDisableCapture().
by Matteo Bruni 15 Nov '11

15 Nov '11

2011/11/15 Henri Verbeet <hverbeet(a)codeweavers.com>: > --- > + UINT end = start_idx + count; > + start_idx += 7; > + memset(&field[start_idx >> 3], 0, (end >> 3) - (start_idx >> 3)); Isn't that dangerous if count is < 7 (assuming that is a valid value)?

1 0

Re: [2/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Henri Verbeet 15 Nov '11

15 Nov '11

On 15 November 2011 00:12, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Tests show that only LPSURFACE and PIXELFORMAT can be set, and LPSURFACE is required > + * for PIXELFORMAT to work */ This may be ok, but note that the test doesn't actually test this. (E.g. does calling SetSurfaceDesc() with the original surface desc work? What about bits not in DDSD_ALL? Etc.) Also, as a general principle, I'd be happier about the ddraw tests if they actually tested all the different interface versions.

2 4

RFH: Solaris users with IPv6
by Juan Lang 15 Nov '11

15 Nov '11

Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, even autoconfigured ones, and feels like testing a patch, please let me know. I'll send the patch and a small test program. Thanks, --Juan

2 1

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts
by Henri Verbeet 15 Nov '11

15 Nov '11

That's a fair amount of magic constants in there. The ones in is_indic() are probably Script_Devanagari and Script_Malayalam_Numeric, I didn't look at the other two.

2 1

Re: [4/6] msxml3/dom: Properly return node prefix from get_prefix()
by Jacek Caban 15 Nov '11

15 Nov '11

Hi Nikolay, On 11/15/11 07:19, Nikolay Sivov wrote: > - if ((ns = xmlGetNsList(This->node->doc, This->node))) > + switch (This->node->type) > { > - if (ns[0]->prefix) *prefix = bstr_from_xmlChar( ns[0]->prefix ); > - xmlFree(ns); > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + { > + xmlNsPtr ns = This->node->ns; > + if (ns&& ns->prefix) > + *prefix = bstr_from_xmlChar(ns->prefix); > + break; > } > + default: > + FIXME("unsupported type %d\n", This->node->type); > + }; The idea behind node inheritance rewrite was to avoid such switches. If other node types should be handled differently, they simply shouldn't use node_get_prefix or the differences should be moved to child objects. Jacek

2 1

Re: msvcrt: Don't hold FILE critical section in some functions
by Alexandre Julliard 15 Nov '11

15 Nov '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -3117,25 +3098,20 @@ int CDECL MSVCRT_fputc(int c, MSVCRT_FILE* file) > */ > int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > { > - MSVCRT__lock_file(file); > - > /* Flush output buffer */ > if(file->_bufsiz == 0 && !(file->_flag & MSVCRT__IONBF)) { > msvcrt_alloc_buffer(file); > } > if(!(file->_flag & MSVCRT__IOWRT)) { > - if(file->_flag & MSVCRT__IORW) { > + if(file->_flag & MSVCRT__IORW) > file->_flag |= MSVCRT__IOWRT; > - } else { > - MSVCRT__unlock_file(file); > + else That doesn't look safe. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wininet: Give a name to the critical sections, make them static and delete them when unloading the dll.
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15430 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [4/4] ddraw: Size handling fixes for IDirect3DDevice::GetDesc
by Henri Verbeet 15 Nov '11

15 Nov '11

On 15 November 2011 00:13, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!HWDesc) > + { > + WARN("HWDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HWDesc->dwSize)) > + { > + WARN("HWDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HWDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } > + else if (!HelDesc) > + { > + WARN("HelDesc is NULL, returning DDERR_INVALIDPARAMS.\n"); > + return DDERR_INVALIDPARAMS; > + } > + else if(!check_d3ddevicedesc_size(HelDesc->dwSize)) > + { > + WARN("HelDesc->dwSize is %u, returning DDERR_INVALIDPARAMS.\n", HelDesc->dwSize); > + return DDERR_INVALIDPARAMS; > + } The "else" is redundant here. Please use consistent formatting. > + hw_caps.dwSize = sizeof(hel_caps) + 1; Strictly speaking that should be "sizeof(hw_caps) + 1". > + case 172: /* DirectX 3, IDirect3DDevice1 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); > + /* drop through */ > + case 204: /* DirectX 5, IDirect3DDevice2 */ > + ok(hw_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hw_caps.dwMaxTextureRepeat); > + ok(hel_caps.dwMaxTextureRepeat == 0xfefefefe, "dwMaxTextureRepeat was modified: %#x.\n", > + hel_caps.dwMaxTextureRepeat); This doesn't make a lot of sense, both cases are the same.

1 0

Re: wined3d: Disable WINED3DFMT_B8G8R8_UNORM.
by Stefan Dösinger 15 Nov '11

15 Nov '11

On Tuesday 15 November 2011 14:21:09 Matteo Bruni wrote: > + case WINED3DFMT_B8G8R8_UNORM: /* Usable in <=dx7 but not > enumerated in any case */ > + TRACE_(d3d_caps)("[FAILED] - Not enumerated on Windows\n"); > + return FALSE; The comment "Usable in <=dx7" is misleading. If I remember correctly your attempts at writing a test showed that systemmem surfaces can be created, but not video memory surfaces. I wouldn't be surprised if d3d8/9 also allow systemmem or scratch B8G8R8 surfaces. You can also remove the special handling for D3DFMT_R8G8B8 from d3d8/9's CheckDeviceFormat handling implementation now that wined3d doesn't report it as supported.

1 0

Re: [PATCH 1/2] ntdll: windows refuses to load an image, if sections overlap the header size as given in the SizeOfHeaders field (resend)
by Alexandre Julliard 15 Nov '11

15 Nov '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/loader.c | 79 ++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/virtual.c | 5 +++ > 2 files changed, 84 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c > index 4d420ea..bcef492 100644 > --- a/dlls/kernel32/tests/loader.c > +++ b/dlls/kernel32/tests/loader.c > @@ -692,9 +692,88 @@ static void test_section_access(void) > } > } > > +static void test_section_mapping(void) > +{ > + static const char filler[0x2000]; > + static const char section_data[] = "section data 1234567890"; > + DWORD total, written; > + HANDLE hfile; > + HMODULE hlib; > + SYSTEM_INFO si; > + char temp_path[MAX_PATH]; > + char dll_name[MAX_PATH]; > + BOOL ret; > + > + GetSystemInfo(&si); > + > + /* prevent displaying of the "Unable to load this DLL" message box */ > + SetErrorMode(SEM_FAILCRITICALERRORS); > + > + GetTempPath(MAX_PATH, temp_path); > + > + GetTempFileName(temp_path, "ldr", 0, dll_name); Please merge that test case into the existing loader tests instead of adding a new function to do the same thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 11/12] mshtml: Added more navigation tests
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15423 Your paranoid android. === TEST64_W7SP1 (32 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText === TEST64_W7SP1 (64 bit htmldoc) === htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2692: Test failed: unexpected command 6058 htmldoc.c:4725: Test failed: expected Invoke_AMBIENT_PALETTE htmldoc.c:4726: Test failed: expected GetOptionKeyPath htmldoc.c:2702: Test failed: unexpected call Exec_ShellDocView_37 htmldoc.c:2883: Test failed: unexpected cmd 109 of CGID_Explorer htmldoc.c:2789: Test failed: unexpected command 143 htmldoc.c:1704: Test failed: unexpected call SetStatusText

2 1

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try3)
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15426 Your paranoid android. === WVISTAADM (32 bit userenv) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/2] userenv: Improved CreateEnvironmentBlock implementation (try2)
by Alexandre Julliard 15 Nov '11

15 Nov '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +static void set_wow64_environment(WCHAR **env) > +{ > + static const WCHAR archW[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','C','T','U','R','E',0}; > + static const WCHAR arch6432W[] = {'P','R','O','C','E','S','S','O','R','_','A','R','C','H','I','T','E','W','6','4','3','2',0}; This stuff needs to be done depending on the 32/64 architecture of the child process, so it probably shouldn't be done here. The variables will be reset on every process startup anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] urlmon: Improve parsing of SCHEME_MK URIs
by Jacek Caban 15 Nov '11

15 Nov '11

Hi Andrew, On 11/14/11 21:12, Andrew Eikum wrote: > --- > dlls/urlmon/tests/uri.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/urlmon/uri.c | 15 +++++++-- > 2 files changed, 93 insertions(+), 3 deletions(-) The patch looks good to me, but could you please add a simpler test using CreateUri (using uri_tests array) as follow up. Thanks, Jacek

1 0

Re: ws2_32: Fix handling of NULL and empty hostname in getaddrinfo/GetAddrInfoW.
by Marvin 15 Nov '11

15 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15418 Your paranoid android. === WNT4WSSP6 (32 bit sock) === Timeout === W2KPROSP4 (32 bit sock) === Timeout

1 0

Re: [PATCH 2/5] d3d10: Add a stub ID3D10StateBlock implementation.
by Nikolay Sivov 15 Nov '11

15 Nov '11

On 11/14/2011 23:11, Henri Verbeet wrote: > +static ULONG STDMETHODCALLTYPE d3d10_stateblock_Release(ID3D10StateBlock *iface) > +{ > + struct d3d10_stateblock *stateblock = impl_from_ID3D10StateBlock(iface); > + ULONG refcount = InterlockedIncrement(&stateblock->refcount); > + > + TRACE("%p decreasing refcount to %u.\n", stateblock, refcount); > + > + if (!refcount) > + HeapFree(GetProcessHeap(), 0, stateblock); > + > + return refcount; > +} Decrement maybe?

1 0

Vista/w2k8/w7 users, please test mmdevapi with exclusive mode disabled
by Joerg-Cyril.Hoehle＠t-systems.com 14 Nov '11

14 Nov '11

Hi, Please test mmdevapi again using testbot job #15369 with exclusive mode disabled. Brian, it seems like you had some other app use audio while performing the tests. This would explain the DEVICE_IN_USE error: render.c:427: Test failed: Initialize(exclus., 8000x 8x1) returns 8889000a and the subsequent crash. My new version of the tests should prevent crashes in such a situation. Saulius, you need not perform many tests because of random GetPosition/Padding failures. I've not yet changed that part of the tests. Thank you for repeated testing, Jörg Höhle

2 1

Re: winemaker: Be less picky when detecting the target type
by Francois Gouget 14 Nov '11

14 Nov '11

On Fri, 11 Nov 2011, André Hentschel wrote: > seen some "broken" project files which still worked with msvc but not with winemaker > --- > tools/winemaker | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/winemaker b/tools/winemaker > index 2ee79ea..921f8ef 100755 > --- a/tools/winemaker > +++ b/tools/winemaker > @@ -589,16 +589,16 @@ sub source_scan_project_file($$$) > #print $prj_name; > next; > } elsif (/^# TARGTYPE/) { > - if (/[[:space:]]0x0101$/) { > + if (/0x.*101$/) { The various .* worry me a bit. Would something like [0-9a-fA-F]* be permissive enough? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 1

Re: [1/5]usp10: break with a better understanding on the handling of bidi strengths
by Alexandre Julliard 14 Nov '11

14 Nov '11

Aric Stewart <aric(a)codeweavers.com> writes: > + if (strength) > + { > + str = strength[cnt]; > + if (pwcInChars[cnt] == Numeric_space) > + str_space = TRUE; > + else > + str_space = FALSE; > + } str_space is not used for anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: taskmgr: Give a name and statically initialize PerfDataCriticalSection.
by Francois Gouget 14 Nov '11

14 Nov '11

On Mon, 14 Nov 2011, Francois Gouget wrote: [...] > static CRITICAL_SECTION PerfDataCriticalSection; > +static CRITICAL_SECTION_DEBUG PerfDataCriticalSection_debug = > +{ > + 0, 0, &PerfDataCriticalSection, > + { &PerfDataCriticalSection_debug.ProcessLocksList, &PerfDataCriticalSection_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": PerfDataCriticalSection") } > +}; [...] > + PerfDataCriticalSection.DebugInfo->Spare[0] = 0; > DeleteCriticalSection(&PerfDataCriticalSection); Actually I think unsetting Spare[0] is wrong for statically initialized critical sections because it causes RtlDeleteCriticalSection() to do an RtlFreeHeap() on DebugInfo which happens to also be statically allocated. So I'll rework this patch and some of my previous patches. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: dlls: Remove unneeded include directives in resource files.
by Marvin 14 Nov '11

14 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15373 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

re: [PATCH] ntdll: Use VALGRIND_RESIZEINPLACE_BLOCK when available
by Dan Kegel 12 Nov '11

12 Nov '11

You might want to compare with Bart's patch for the same thing, http://www.winehq.org/pipermail/wine-patches/2011-April/100570.html Bart asked for comments on it, but didn't get much feedback: http://www.winehq.org/pipermail/wine-devel/2011-May/090029.html My guess is changes like this are really hard to get in unless you can get Alexandre's full attention somehow. Maybe if it was demonstrated to find interesting bugs in wine...

1 0

Re: Include math.h in d3dx9math.inl as it uses sqrt().
by Henri Verbeet 12 Nov '11

12 Nov '11

Does the Microsoft header include math.h?

4 4

Re: d3dx9 [patch 1/2, try 4]: Implement D3DXCreatePolygon
by Rico Schüller 11 Nov '11

11 Nov '11

Am 10.11.2011 10:59, schrieb David Adam: > Hello, > > I tried to fix the remaining issues pointed by Matteo and Rico. > I kept the style of Misha Koshelev who already implemented many shapes in > the mesh.c file. > > Any more suggestions? > > David > > > Hi David, I still have some suggestions. Please review all TRACE and ok messages. I think they should mostly end with '\n' and they should not contain "useless" chars like ':' and spaces where not needed. Also you may save the ref value from the call before you compare it: + IDirect3DDevice9_Release(device); + ok(ref == 0, "Expected refcount = 0, received %d", ref); I think it is pretty useful to check the reference count in general for all release calls. Please review that part, so that it does what it should do! It's not only the line I mentioned as an example here! If you don't understand some parts and don't know exactly what to do, please ask. I'd prefer if the comparison would be within the if, otherwise you could compare to an uninitialized value, which could get bogus results (even if that only happens when other test fail, I think it's better than comparing uninitialized values): + if (polygon) ref = polygon->lpVtbl->Release(polygon); + ok(ref == 0, "Expected refcount = 0, received %d", ref); Please see my points as a suggestion. I think the answers to the patches showed a lot of issues, so please review the whole patch before sending it again, you may find some other not mentioned things. Note: Not the fastest sent patch will get in, but the "best" working solution. Cheers Rico

1 0

Re: Add dxerr.h
by Henri Verbeet 10 Nov '11

10 Nov '11

On 10 November 2011 02:27, Daniel Scharrer <dscharrer(a)gmail.com> wrote: > +#include <dxerr9.h> > + > +#define DXGetErrorStringA DXGetErrorString9A > +#define DXGetErrorStringW DXGetErrorString9W > +#define DXGetErrorString WINELIB_NAME_AW(DXGetErrorString) > + > +#define DXGetErrorDescriptionA DXGetErrorDescription9A > +#define DXGetErrorDescriptionW DXGetErrorDescription9W > +#define DXGetErrorDescription WINELIB_NAME_AW(DXGetErrorDescription) Which SDK version does this match?

2 1

Antw.: RFC: depending on getifaddrs in iphlpapi
by André Hentschel 10 Nov '11

10 Nov '11

Why? AFAIK getifaddr was added to at least openSolaris Last year and you still can use the old Code as fallback Gesendet mit meinem HTC ----- Reply message ----- Von: "Juan Lang" <juan.lang(a)gmail.com> An: "Michael Stefaniuc" <mstefani(a)redhat.com> Cc: "Wine Devel" <wine-devel(a)winehq.org> Betreff: RFC: depending on getifaddrs in iphlpapi Datum: Do., Nov. 10, 2011 18:41 >> I'm thinking of replacing the current IPv4 enumeration code, which >> uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning >> toward replacing, rather than adding side-by-side with the current >> code, is that getifaddrs is commonly available: it's available on all >> recent versions of Linux, as well as on FreeBSD and MacOS. There > recent versions of Linux as of which year? Good question. When I was writing this code in 2003, the stable version of Debian didn't support it. I haven't seen a Linux system that doesn't support it since then, but I've only checked periodically. >> might be some platform somewhere that's disenfranchised by this, but >> I'm not sure it's worth the code complexity to maintain the current >> code. > What about Solaris/OpenSolaris? That's the only other major system where > Wine can be made to run. Ah. Okay, that's an important objection. I'll go with keeping the current code, then. Thanks, --Juan

2 1

RFC: depending on getifaddrs in iphlpapi
by Juan Lang 10 Nov '11

10 Nov '11

Hi folks, right now iphlpapi uses autoconf to detect if getifaddrs is available, and only uses it to enumerate IPv6 addresses. I'm thinking of replacing the current IPv4 enumeration code, which uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning toward replacing, rather than adding side-by-side with the current code, is that getifaddrs is commonly available: it's available on all recent versions of Linux, as well as on FreeBSD and MacOS. There might be some platform somewhere that's disenfranchised by this, but I'm not sure it's worth the code complexity to maintain the current code. Any strenuous objections? Reasons to use getifaddrs rather than ioctls: 1. SIOCGIFCONF is actually pretty fiddly, and is the current code is broken on FreeBSD, or FreeBSD's support is broken (bug 27653.) 2. SIOCGIFFLAGS is apparently broken on current Linux versions. I haven't found any bug against Wine or Linux about that, I just noticed it while testing the existing code. Thanks, --Juan

2 2

RFC: ddraw: Fix conversion between D3DVIEWPORT and D3DVIEWPORT2
by Octavian Voicu 10 Nov '11

10 Nov '11

Hi, Attached is a series of patches to add better tests and fix Wine's implementation of the conversion between D3DVIEWPORT and D3DVIEWPORT2 structures in IDirect3DViewport / IDirect3DViewport2 / IDirect3DViewport3 implementation. I'm sending this to to wine-devel because next commit round will be on Monday, so I hope to get some feedback until then and fix any issues before sending to wine-patches. I'm also working on fixing IDirect3DViewport::TransformVertices, which at the very least does not work if viewport data is set using D3DVIEWPORT2. This will fix bug http://bugs.winehq.org/show_bug.cgi?id=11819, which is actually caused by Wine's buggy implementation of TransformVertices and has nothing to do with the z-buffer locking not begin implemented. I'm working on some tests and a fix, and will post them here when they are ready. Octavian -- Octavian Voicu (5): ddraw/tests: Remove some redundant d3d viewport tests. ddraw/tests: Add macro to verify viewport data bounds. ddraw/tests: Make ViewportTest loop through an array of tests. ddraw: Add error checking for IDirect3DViewportImpl_[GS]etViewport, with tests. ddraw: Add more viewport tests and make them pass under Windows and Wine. dlls/ddraw/tests/d3d.c | 329 ++++++++++++++++++++++++++++-------------------- dlls/ddraw/viewport.c | 114 ++++++++++------- 2 files changed, 260 insertions(+), 183 deletions(-)

1 0

Re: winspool.drv: Correct test for Device Capabilities (resend)
by Marvin 10 Nov '11

10 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15332 Your paranoid android. === WINEBUILD (build) === Can't determine base name

2 1

Re: [PATCH 3/3] wined3d: Report all FBO-attachable formats as suitable for render target usage.
by Matteo Bruni 10 Nov '11

10 Nov '11

2011/11/9 Matteo Bruni <mbruni(a)codeweavers.com>: > --- This patch is not correct, please ignore it...

1 0

Re: d3dx9_36/tests [patch 2/2, try 3]: Add tests for D3DXCreatePolygon
by Matteo Bruni 09 Nov '11

09 Nov '11

2011/11/9 David Adam <david.adam.cnrs(a)gmail.com>: > Better, but there are still issues: + if( polygon ) polygon->lpVtbl->Release(polygon); + if( ppBuffer ) ID3DXBuffer_Release(ppBuffer); You aren't setting those pointers to NULL (and your test shows that D3DXCreatePolygon doesn't touch them when the call fails), so those ifs actually are protecting nothing. In patch 1/2, LockVertex/IndexBuffer should not fail in normal circumstances, so it's probably better to use ERR instead of TRACE there. Also, please, try to fixup the code style. E.g. the preferred style for 'if's and loops is to have a whitespace between the keyword and the '(' and no whitespace between the parentheses and the condition. Stick with that. Don't use hungarian notation (ppBuffer ...), fix whitespaces around operators, etc

2 1

Strange window manager bug
by Alex Henrie 09 Nov '11

09 Nov '11

Does anyone have an idea of what could be causing http://bugs.winehq.org/show_bug.cgi?id=29027 ? -Alex

1 0

Re: [1/2] Revert "msi: Use MsgWaitForMultipleObjectsEx to do waits."
by Alexandre Julliard 09 Nov '11

09 Nov '11

Hans Leidekker <hans(a)codeweavers.com> writes: > This reverts commit 2556173f20ba9583044aaf31b16cbb2214d2b907. > It causes a regression in the Quicken 2011 installer. Does it really break because we are processing messages, or just because we don't wait properly? If so fixing the wait would seem a better choice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] winhttp: Convert string data to UTF-8 and add a corresponding content type header.
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15333 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:2158: Test failed: got 80072f78

1 0

Re: [PATCH 1/5] wined3d: Don't print FIXMEs for misaligned surface maps.
by Stefan Dösinger 09 Nov '11

09 Nov '11

On Tuesday 08 November 2011 20:48:55 Henri Verbeet wrote: > - FIXME("Partial block lock with %s\n", > debug_d3dpool(surface->resource.pool)); I added this fixme because we have to tests for the offset that is returned in this case. Do you have an application that triggers this fixme, or do you want to suppress the fixmes in the tests?

2 3

Re: mscoree: Implement ICorDebug CreateProcess (try 2)
by Alexandre Julliard 09 Nov '11

09 Nov '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Move DuplicateHandle to Create_Process. > Added Makefile.in (missing from first patch) > > Changelog: > mscoree: Implement ICorDebug CreateProcess You should put everything in cordebug.c, there's no need to have a separate file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] ddraw/tests: Add a test for YV12 partial block locks and lock offsets
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15324 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/4] ddraw: Set correct HEL and HAL color models
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15327 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/4] ddraw: Add more tests and fixes for SetSurfaceDesc
by Marvin 09 Nov '11

09 Nov '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15326 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Adopt a patch?
by Michael Ost 08 Nov '11

08 Nov '11

I have a patch for a bug that I won't be able to shepherd through the patch submission process for some time. The bug is that GetFileVersionInfoSize doesn't work for files with path names longer than 128 characters. The patch includes an untried unit test. And I've confirmed the behavior in Windows Vista. We use an older version of Wine, and my boss won't let me take the time right now to rework the patch for the newest Wine sources. If someone wants to they can take this patch, tweak it for the new wine, update it to wine-patch requirements and push it through the system. Otherwise I'll submit as soon as I can. Cheers, Michael Ost

2 1

Re: apphelp: add a stub for ApphelpCheckShellObject
by Dmitry Timoshkov 08 Nov '11

08 Nov '11

Austin English <austinenglish(a)gmail.com> wrote: > +BOOL WINAPI ApphelpCheckShellObject(REFCLSID ObjectCLSID, BOOL ShimIfNecessary, ULONGLONG *pullFlags) > +{ > + FIXME("stub: %s %p\n", debugstr_guid(ObjectCLSID), pullFlags ); > + return TRUE; > +} It's a common convention in Wine to avoid hungarian notation by all means. In this case naming variables something like 'clsid, shim, flags' woud be better. -- Dmitry.

1 0

Fwd: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon
by David Adam 08 Nov '11

08 Nov '11

Hello, any problem with this patch http://source.winehq.org/patches/data/80433 and this one http://source.winehq.org/patches/data/80434 Thanks in advance David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/10/30 Subject: d3dx9_36 [patch 1/2, resent]: Implement D3DXCreatePolygon To: wine-patches <wine-patches(a)winehq.org> Fix a possible crash when calling D3DXCreateMeshFVF. A+ David

3 2

Re: [10/11] ddraw/tests: Add assorted D3D3 DrawPrimitive/visual tests.
by Stefan Dösinger 08 Nov '11

08 Nov '11

On Tuesday 08 November 2011 01:14:22 Octavian Voicu wrote: > The idea behind using triangles was to fit everything in one screen so > I could debug it visually very easily. I'm thinking I can still have > that if I draw full-screen quads in a loop, like you suggest, then > blit one small rectangle to the primary surface, in different > positions for each test. I don't think that's necessary, I found those one-quad screens easier to debug than multi-quads, although that may be a matter of taste. > I think > we should cover special error cases if there are any (that is, if > D3DERR_INVALIDVERTEXTYPE is not returned for D3DVT_ constants). Well, you can't test them. D3DVT_LVERTEX is 2, and D3DFVF_XYZ is 2. The number 2 doesn't have any tags attached, so what you'd be testing is how drawPrimitive responds to D3DFVF_RESERVED0, not what it does with D3DVT_* enums. The statement in the SDK doesn't make sense with that in mind. > About the ddraw/visual tests: I think we need one structure for each > of d3d, d3d2, d3d3, d3d7, where to have most of the things we store > globally or in local vars now, and make the create/release functions > work with that. Yes, I was about to write something like that as a response to the cleanup patches. PS: You forgot to CC wine-devel, I assume this was by accident so I've added it to the reply again. You may want to resend your original mail to wine- devel.

2 2

Re: [01/11] ddraw/tests: Fix a couple of copy-paste typos in test messages.
by Stefan Dösinger 08 Nov '11

08 Nov '11

This patch is OK, the others need some discussion and work.

1 0

Re: [3/3] ddraw/tests: Add a partial block lock test
by Alexandre Julliard 08 Nov '11

08 Nov '11

Stefan Dösinger <stefan(a)codeweavers.com> writes: > @@ -4,7 +4,7 @@ > * Copyright (C) 2005 Antoine Chavasse (a.chavasse(a)gmail.com) > * Copyright (C) 2005 Christian Costa > * Copyright 2005 Ivan Leo Puoti > - * Copyright (C) 2007 Stefan Dösinger > + * Copyright (C) 2007-2011 Stefan Dösinger for CodeWeavers Adding a range of years in a copyright notice is usually discouraged, because it's only valid if you have actually made significant changes every year, which doesn't seem to be the case here. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 3/7] ntoskrnl: intialze unknown fields of the irp with 0xce in IoInitializeIrp
by Alexandre Julliard 08 Nov '11

08 Nov '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -864,6 +873,10 @@ VOID WINAPI IoCompleteRequest( IRP *irp, UCHAR priority_boost ) > > iosb = irp->UserIosb; > status = irp->IoStatus.u.Status; > + > + assert( status != STATUS_PENDING ); > + assert( status != 0xdeafbeef ); > + You can't assert on things that are set by the caller. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel