- wine-devel - winehq.org

Regression by author list?
by Damjan Jovanovic 04 Oct '11

04 Oct '11

Hi Where do we find that list of regressions by author, that was in Alexandre's keynote at Wineconf? Thank you Damjan Jovanovic

2 1

unable to compile wine from latest git
by Vijay Kiran Kamuju 04 Oct '11

04 Oct '11

Hi, I just downloaded the git and tried compile it. I just issued `make` command after doing `./configure` But it gave the below errors: make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/tools/wrc' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' rm -f dlls/libd3dcompiler.def && cp -p d3dcompiler_43/libd3dcompiler.def dlls/libd3dcompiler.def cp: cannot stat `d3dcompiler_43/libd3dcompiler.def': No such file or directory make: *** [dlls/libd3dcompiler.def] Error 1 Since the build of wine has changed a bit, i am unable to understand how to fix this issue. Thanks, Vijay

3 6

re: [1/3] kernel32/tests: Test K32GetProcessImageFileNameA() and improve the QueryFullProcessImageNameA() tests.
by Dan Kegel 04 Oct '11

04 Oct '11

Build fails here with -Werror: process.c: In function ‘test_GetProcessImageFileNameA’: process.c:1646: error: unused variable ‘image’ You seem to have two copies of that variable, one shadowing the other?

1 0

Alexandre's keynote
by Jeremy White 03 Oct '11

03 Oct '11

Thanks to Jon Parshall's hard work, we have Alexandre's keynote available here: http://www.youtube.com/watch?v=2rdDvMonTnQ Remember to have your libation at hand so you can play the game... <grin> Cheers, Jeremy

6 6

Re: [po]updated korean resource(2011-09-30)
by Francois Gouget 01 Oct '11

01 Oct '11

On Fri, 30 Sep 2011, Hwang YunSong(황윤성) wrote: [...] > #: winecfg.rc:88 > -#, fuzzy > msgid "(None)" > -msgstr "없음" > +msgstr "(없음)" I think you're missing a closing parenthesis here. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ question = ( to ) ? be : ! be; -- Wm. Shakespeare

1 0

Script for bisecting conformance test failures
by Francois Gouget 01 Oct '11

01 Oct '11

Would something like this be useful to include in Wine? If that's deemed interesting I can clean it up and submit it. I'm posting it here early in case it's useful for WineConf. It's a tool which you can use with git bisect to find the patch that causes a regression in a conformance test. It's used like this: git bisect start <bad> <good> git bisect run ./tools/testbisect dlls/gdi32/tests bitmap Come back a bit later and you have the bad patch. It can also be used with flaky tests by specifying the number of times to run a test. So if a test fails in 30% of the time you could only consider that it works if it succeeds 10 times in a row. You can even grep for a specific error if the test has other errors you don't care about. Finally you can also use it without git just to figure out if a test is flaky or not. For instance: $ ./tools/testbisect dlls/random/tests flaky 100 100 Failed 42 time(s) in 100 run(s) -> definitely flaky -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

1 0

re: [PATCH 2/2] cmd: Handle truncation for console reads
by Dan Kegel 01 Oct '11

01 Oct '11

What's motivating this change? Are you quite sure you know how ReadConsole behaves? I bet one could write a test for this that used SendInput to send keystrokes to be read by ReadConsole, and verify the end of line and end of buffer behavior...

2 1

re: [PATCH 1/2] cmd: Improve WCMD_fgets documentation
by Dan Kegel 01 Oct '11

01 Oct '11

+ * We can't use the native f* functions because of the filename syntax differences + * between DOS and Unix. That doesn't belong in a function comment; it's an implementation detail that belongs, at most, inside the function.

2 1

Favorite bug: deadlock preventing backtraces?
by Dan Kegel 01 Oct '11

01 Oct '11

On one of my boxes, if I run winmm/midi.ok in a loop, it will eventually deadlock/crash ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) wine: Critical section 00110060 wait failed at address 0x7bc3484a (thread 0022), starting debugger... err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main process heap section" wait timed out in thread 0022, blocked by 001f, retrying (60 sec) Sadly, no backtrace follows ( http://bugs.winehq.org/show_bug.cgi?id=28265 ). Since I'm not around when it finally happens, I haven't tried btall yet. I suppose I should write a shell script to watch for that error message in the log, and run btall then... any better ideas? (I did try giving winedbg a private heap, didn't seem to prevent the deadlock.)

2 2

Using ApiTrace to improve D3D/OpenGL performance
by Emanuele Oriani 30 Sep '11

30 Sep '11

Dear all, Just wanted to bring to your attention ApiTrace 2.0, http://zrusin.blogspot.com/2011/09/apitrace-20.html . Apparently this tool is quite fast and should allow to play back GL commands, to analyse performance and replay commands. This might be useful to understand where some bottlenecks of wined3d might be? What do you think? Cheers

2 2

design comments in code or in tests?
by Joerg-Cyril.Hoehle＠t-systems.com 30 Sep '11

30 Sep '11

Hi, here's another one you WineConf folks may want to discuss. I've already expressed that there are not enough comments in mmdevapi's code. I thought about adding some, but wondered whether there's any value in using the header format that old code in Wine uses/used for automated doc. Generation (whatever the exact format was). For instance, comments ought to document GetPosition's contract in sufficient detail: - 0 <= GetPosition <= sum of written samples (modulo Frequency) - underruns don't count, it's no wall clock - monotically increasing(?) - should reflect speaker position, not buffering (MSDN says that) Don't look up MSDN. If that were complete enough, I would not have had the need to write as many tests as I did. Then I thought about placing comments in dlls/*/tests/ instead, because the test code is thrown away less often than the dll code. Seriously. Regards, Jörg Höhle

1 0

Subject: [PATCH 1/2 (try2)] mmdevapi: Don't fail if dwChannelMask is not set correctly
by Joerg-Cyril.Hoehle＠t-systems.com 30 Sep '11

30 Sep '11

Hi, Andrew Eikum writes: >(try2): Remove the test found by testbot. My Win7 Home VM passed that >test, so it seems we can expect any behavior. I object to the removal of the test like that. It should be replaced with a comment to explain that the behaviour of IsFormatSupported is very surprising, hence skipped. Actually, that behaviour begs for even more tests to understand what's going on. So far I believed in the invariant: IsFormatSupported == S_OK <=> Initialize == S_OK which is verified using all standard formats (1-2 channels), with one exception on testbot: render.c:396: Initialize (1, 48000x16x1) returns 8889000f unlike IsFormatSupported ^1^ means in exclusive mode, and only there. Now you experienced A. on testbot: IsFormatSupported(dwChannelMask==FFFF) == S_OK, like Initialize which conforms to the above invariant and simply suggests that ChannelMask is not checked at all, therefore this code in Wine seems too much: + fmtex->dwChannelMask != 0 && + fmtex->dwChannelMask != get_channel_mask(pwfx->nChannels)) B. your own Win7 Home system, with dwChannelMask=ffff, IsFormatSupported returns + ok(hr == S_FALSE || hr == AUDCLNT_E_UNSUPPORTED_FORMAT while Initialize returns + ok(hr == S_OK, which is weird. When does IFS return UNSUPPORTED_FORMAT? When does it return S_FALSE? In the latter case, is the suggested format anything else than GetMixFormat? What does exclusive mode return? Unlike in Wine, the shared mode "audio engine" mixer is a completely different SW entity than the exclusive mode "audio device", so it's important to check both. This needs more testing. In particular, tests performed on HW that supports more than 2 channels are welcome. Based on your surprising test result, I'd guess yours is such a system. Unlike DSound, mmdevapi has no GetSpeakerConfig that I'm aware of (short of Device Topology), so I don't know how apps find out about multi-channel abilities. BTW, I believe + fmtex->dwChannelMask != get_channel_mask(pwfx->nChannels)) in Wine is bogus anyway, because it's arbitrary. There exist different 3/4/5/6 channel configurations. Regards, Jörg Höhle

1 0

winscard
by Vincent Hardy 30 Sep '11

30 Sep '11

Hi all, Here are four patches that are a partial but functional implementation of winscard. I installed "Belgian Electronic Identity Card MiddleWare" (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) I tested winscard by starting beid35gui.exe and I can see my identity card data. Moreover, this should help to solve this bug http://bugs.winehq.org/show_bug.cgi?id=26978. Are these 4 patches good enough to be sent to wine-patch ? winscard is really useful for me and probably for other people too. Vincent

5 4

Re: user32: Prioritize focus for dialog owner on EndDialog.
by Marvin 30 Sep '11

30 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14644 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

2 1

Buildbot status
by Dan Kegel 30 Sep '11

30 Sep '11

The buildbot is alive and well and has been finding real problems of various sorts roughly once a day for some time. I'm not spending much time on it anymore, just watching and tweaking occasionally. The number of spurious failures is tapering off as I slowly expand the blacklist and polish up the scripts. I plan to turn on email notifications to wine-devel once there have been no spurious failure reports for five days, probably sometime in October. http://wiki.winehq.org/BuildBot is up to date in case anyone's interested in details.

4 6

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.
by Francois Gouget 30 Sep '11

30 Sep '11

On Fri, 30 Sep 2011, Francois Gouget wrote: > This is necessary because LastError may already be set to > ERROR_INSUFFICIENT_BUFFER which would mislead the caller. And of course the older versions of Windows (up to XP SP3!) don't reset lasterror so the test bit of the patch cannot go in. I'd still argue that GetModuleFileNameW() should reset LastError though. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.
by Marvin 30 Sep '11

30 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14640 Your paranoid android. === WNT4WSSP6 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === W2KPROSP4 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === WXPPROSP3 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737

1 0

Re: gdiplus: Include an alpha channel in HBITMAPs created from Bitmaps.
by Vincent Povirk 29 Sep '11

29 Sep '11

Don't commit this. Seems I forgot about top-down vs. bottom-up dibs. On Thu, Sep 29, 2011 at 12:03 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > For bug 55549. >

1 0

Status for the ID3DXEffect interface
by Rico Schüller 29 Sep '11

29 Sep '11

Hi, I'd like to say a word for the effect interface in d3dx9_xx.dll, what's already done and what's on the todo list. The parser for binary effects works pretty much. It should nearly parse the effect files completely, but it should fail on effect files which contain functions (if anyone has a binary effect with a function, I'd be interested in it). It is also possible to Get/Set some values, but not yet all, because there are some tricky cases which I haven't figured out completely yet (an example is GetVector() on an D3DXPT_INT). I'm currently working on the correct applying for the states and making some progress with that. But it seems to me that there are a lot of special cases in that. Todo: - Apply the states - Handle parameter blocks - State savings: State saving and restoring in Begin/End is needed. - ASCII effects: The effect could be supplied as byte code or as ASCII text. - ID3DXEffectPool: The support for effect pools is needed. I'm not sure if it might be useful to post an example of a commented binary effect file to make the format "visible" without reading the code. At least it could help when writing the ASCII effect parser. Cheers Rico

1 0

[PATCH 0/5] CMD command line parsing (try 5)
by Martin Wilck 29 Sep '11

29 Sep '11

Contrary to what I said before, here is another attempt for my CMD patch series. Thanks to Frederic for reviewing this again, I made the suggested changes. Martin Wilck (5): cmd/tests: add tests for command line parsing cmd: use GetCommandline() rather than argv cmd: improve parsing of quotes in command line cmd: fix handling of special characters in command line cmd: fix parameter parsing of quotes and special chars programs/cmd/batch.c | 83 ++++++--- programs/cmd/tests/rsrc.rc | 6 + programs/cmd/tests/test_builtins.cmd.exp | 8 +- programs/cmd/tests/test_cmdline.cmd | 158 +++++++++++++++++ programs/cmd/tests/test_cmdline.cmd.exp | 77 +++++++++ programs/cmd/wcmdmain.c | 276 ++++++++++++------------------ 6 files changed, 407 insertions(+), 201 deletions(-) create mode 100644 programs/cmd/tests/test_cmdline.cmd create mode 100644 programs/cmd/tests/test_cmdline.cmd.exp -- 1.7.3.4

1 0

[PATCH 0/5] (4th attempt) CMD command line parsing
by Martin Wilck 29 Sep '11

29 Sep '11

This is my 4th attempt at fixing the cmd command line treatment. All patches pass the cmd tests with 0 errors both under wine and on the Test Bot, including NT. Whitespace issues are fixed, too. Apart from that, the code is the same as before. The size of my patches has been criticized - only patch 2/5 is really big, but it has to be that way to pass the tests. This will also be my last attempt to get this merged. If the patches don't get applied this time, I hope that the cmd Gurus (Frederic or Dan) will take up the bits they like and get them in over time. If there are any technical issues or bugs in my code, I'll of course take care (please email me privately, as I'm not monitoring wine-devel). A private side note: I estimate that I have spent at least 10x more effort and time to get the tests right and the patches submission-ready than I spent on fixing the actual Wine code. I believe this project needs to think over its policies. I fully understand that a project this big needs to take a lot of care to maintain qualitiy standards. But the way this is currently working is discouraging and frustrating for casual contributors like myself. Martin Wilck (5): cmd/tests: add tests for command line parsing cmd: use GetCommandline() rather than argv cmd: improve parsing of quotes in command line cmd: fix handling of special characters in command line cmd: fix parameter parsing of quotes and special chars programs/cmd/batch.c | 82 ++++++--- programs/cmd/tests/rsrc.rc | 6 + programs/cmd/tests/test_builtins.cmd.exp | 8 +- programs/cmd/tests/test_cmdline.cmd | 158 +++++++++++++++++ programs/cmd/tests/test_cmdline.cmd.exp | 77 +++++++++ programs/cmd/wcmdmain.c | 276 ++++++++++++------------------ 6 files changed, 406 insertions(+), 201 deletions(-) create mode 100755 programs/cmd/tests/test_cmdline.cmd create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp -- 1.7.3.4

4 6

Re: [PATCH] winex11: Make MapColor fall back to GetNearestIndex
by Alex Henrie 29 Sep '11

29 Sep '11

2011/9/29 David Kiefer <hevanen(a)googlemail.com>: > A possible solution is to have MapColor call GetNearestIndex as a last > resort instead. This both fixes the problem and results in acceptable > performance. Thanks for the tip. I've submitted a new patch which uses this solution instead, and it works better. 2011/9/29 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > I'm not really sure how useful it is to try to optimize parts of the > X11 code now that the DIB engine is progressing nicely. Once the DIB > engine is done this code will disappear anyway. No need for horrible > X11 hacks to offload any DIB rendering and converting the X11 result > back into a DIB. You're right: the DIB engine would be much better. What needs to be done to get the DIB engine to work with Age of Empires II? -Alex

1 0

Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior
by David Kiefer 29 Sep '11

29 Sep '11

While this patch indeed fixes bug 2666, it also kills performance, at least with Age of Empires II. The frame rate in the menu for me is about one frame every three seconds and about 1 fps in-game. With the patch, the work previously done by X11DRV_DIB_MapColor is now done by X11DRV_DIB_GetNearestIndex. Unlike GetNearestIndex, MapColor avoids traversing the entire palette most of the time by reusing the previous index in the destination bitmap if the color has not changed. However, MapColor only checks for exact matches and returns the first palette entry if none was found, effectively causing bug 2666. A possible solution is to have MapColor call GetNearestIndex as a last resort instead. This both fixes the problem and results in acceptable performance. David

2 1

Odd audio regression (interaction between two commits)
by Erich Hoover 29 Sep '11

29 Sep '11

A: 64b14c0ecdd13530a92ff636c451523a99253a0b (quartz: Start DirectSound renderer as soon as possible.) B: e786998daff4ad49521a4c9c39c172ddcdcad82a (dsound: Reimplement rendering devices on mmdevapi.) I've been working with the audio in Fallout 3 and Fallout New Vegas for some time and I noticed a regression recently where the audio stopped working properly after the main menu (commit B). This triggered a memory of a similar experience I had where commit A caused the same behavior, but it only did so for PulseAudio users. So, on a hunch, I reverted commit A on the latest git and found that the audio went back to normal again. I'm not entirely sure what commit A could do to cause this problem, and I know you guys are busy with the audio changes, so if someone could point me in the right direction then I will try and track this issue down. Thanks! Erich Hoover ehoover(a)mines.edu

1 0

winecfg: Remove driver selection from Audio tab.
by Joerg-Cyril.Hoehle＠t-systems.com 29 Sep '11

29 Sep '11

Hi, I'm not satisfied with the removal of the audio tree from winecfg. Beside allowing to switch or disable drivers, one key feature was to allow inspecting the devices that winmm found on this system. For instance, I've not yet had time to report a bug that since wine-1.3.25, one such entry shows an empty name IIRC. It allowed users to easily check whether e.g. Timidity was recognized or whether "MIDI through" was the only output. It allowed users to easily tell whether their 5:1 sound card was recognized beside the default device. Bugzilla shows 350 entries about winecfg & audio. It had a use. What are users supposed to do now? Regards, Jörg Höhle

9 18

Favorite bug: deadlock preventing backtraces?
by Joerg-Cyril.Hoehle＠t-systems.com 29 Sep '11

29 Sep '11

Dan Kegel wrote: >Sadly, no backtrace follows I've not had midi.ok crash on me, but now that you mention it, I've had occasional crashes of random reasons in various apps yet got no backtrace. I seem to remember that there have been times where backtraces would be produced more reliably. So perhaps 1/2 a suggestion would be to try how an older version behaves. It shouldn't matter with midi. But which older version to choose? Regards, Jörg Höhle

1 0

Re: d3dx9_26: Add custom ID3DXEffect interface.
by Erich Hoover 29 Sep '11

29 Sep '11

SetRawValue is at the end of the table, so it being extra will not influence any older application. So, you should be able to get the same functionality with way less code by adding that alternative GUID to the QueryInterface in d3dx9_36. Erich Hoover ehoover(a)mines.edu

5 8

Re: [PATCH] Enable X11DRV_DIB_GetImageBits_8 in all cases and optimize X11DRV_DIB_GetNearestIndex to fix bug 2666 and other strange behavior
by Frédéric Delanoy 29 Sep '11

29 Sep '11

Please do not include bug number in commit message summary line. Put something like 'fixes bug 123 in the commit header See http://wiki.winehq.org/SubmittingPatches for more info (e.g. "subject line" and "include a description" sections) Frédéric

2 3

Re: d3dx9_26: Add custom ID3DXEffect interface
by luis.busquets＠ilidium.com 29 Sep '11

29 Sep '11

And what about introducing wined3dx to wrap up all d3dx9, d3dx10, ... functions?

1 0

CreateDC and DRIVER_GetDriverName
by Bruno Jesus 28 Sep '11

28 Sep '11

Hi, I'm seeking advice as I really don't understand anything about wine display drawing (gdi, x11, ...). Every game created with an old win3.11 tool called Klik & Play do not work in wine because a driver called DIB is passed as parameter to CreateDC. Till today I've only seen a driver called DISPLAY being used by all sorts of applications. Looking at the DRIVER_GetDriverName [1] function I can see a list where 3 different drivers are supported. In an attempt to run an old game called Mortuum [2] I can see that it always fail due to this missing DIB driver: err:dc:CreateDCW no driver found for L"DIB" My lack of knowledge made me do a dirty hack in the CreateDCW function forcing the driver DISPLAY to be used instead of DIB and when I started the game it draw it's first screen and then crashed. What should be done to support the DIB driver name now that DIB is implemented in wine? [1] = http://source.winehq.org/source/dlls/gdi32/driver.c#L800 [2] = ftp://ftp.padua.org/pub/msdos/windows/games/local/mortuum.zip Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

Re: [PATCH] d3dx9_36: avoid using fabsf/fmaxf
by Marvin 28 Sep '11

28 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14617 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] d3dx9_36: avoid using fabsf/fmaxf
by Austin English 28 Sep '11

28 Sep '11

On Wed, Sep 28, 2011 at 01:51, Natanael Copa <ncopa(a)alpinelinux.org> wrote: > This fixes compiling on Alpine Linux and other uClibc based distros. > > This is related bug 28247 and commit 4cddd5ffdf0c568445365c6c62e7788d7dbbca7d > --- > dlls/d3dx9_36/tests/mesh.c | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c > index 6a78e64..c09607f 100644 > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -6160,7 +6160,7 @@ static void check_vertex_components(int line, int mesh_number, int vertex_number > { > FLOAT *got = (FLOAT*)(got_ptr + decl_ptr->Offset); > FLOAT *exp = (FLOAT*)(exp_ptr + decl_ptr->Offset); > - FLOAT diff = fabsf(*got - *exp); > + FLOAT diff = abs(*got - *exp); > ok_(__FILE__,line)(diff <= FLT_EPSILON, "Mesh %d: Got %f for vertex %d %s, expected %f.\n", > mesh_number, *got, vertex_number, usage_strings[decl_ptr->Usage], *exp); > break; > @@ -6169,7 +6169,7 @@ static void check_vertex_components(int line, int mesh_number, int vertex_number > { > D3DXVECTOR2 *got = (D3DXVECTOR2*)(got_ptr + decl_ptr->Offset); > D3DXVECTOR2 *exp = (D3DXVECTOR2*)(exp_ptr + decl_ptr->Offset); > - FLOAT diff = fmaxf(fabsf(got->x - exp->x), fabsf(got->y - exp->y)); > + FLOAT diff = max(abs(got->x - exp->x), abs(got->y - exp->y)); > ok_(__FILE__,line)(diff <= FLT_EPSILON, "Mesh %d: Got (%f, %f) for vertex %d %s, expected (%f, %f).\n", > mesh_number, got->x, got->y, vertex_number, usage_strings[decl_ptr->Usage], exp->x, exp->y); > break; > @@ -6178,8 +6178,8 @@ static void check_vertex_components(int line, int mesh_number, int vertex_number > { > D3DXVECTOR3 *got = (D3DXVECTOR3*)(got_ptr + decl_ptr->Offset); > D3DXVECTOR3 *exp = (D3DXVECTOR3*)(exp_ptr + decl_ptr->Offset); > - FLOAT diff = fmaxf(fabsf(got->x - exp->x), fabsf(got->y - exp->y)); > - diff = fmaxf(diff, fabsf(got->z - exp->z)); > + FLOAT diff = max(abs(got->x - exp->x), abs(got->y - exp->y)); > + diff = max(diff, abs(got->z - exp->z)); > ok_(__FILE__,line)(diff <= FLT_EPSILON, "Mesh %d: Got (%f, %f, %f) for vertex %d %s, expected (%f, %f, %f).\n", > mesh_number, got->x, got->y, got->z, vertex_number, usage_strings[decl_ptr->Usage], exp->x, exp->y, exp->z); > break; > @@ -6188,9 +6188,9 @@ static void check_vertex_components(int line, int mesh_number, int vertex_number > { > D3DXVECTOR4 *got = (D3DXVECTOR4*)(got_ptr + decl_ptr->Offset); > D3DXVECTOR4 *exp = (D3DXVECTOR4*)(exp_ptr + decl_ptr->Offset); > - FLOAT diff = fmaxf(fabsf(got->x - exp->x), fabsf(got->y - exp->y)); > - diff = fmaxf(diff, fabsf(got->z - exp->z)); > - diff = fmaxf(diff, fabsf(got->w - exp->w)); > + FLOAT diff = max(abs(got->x - exp->x), abs(got->y - exp->y)); > + diff = max(diff, abs(got->z - exp->z)); > + diff = max(diff, abs(got->w - exp->w)); > ok_(__FILE__,line)(diff <= FLT_EPSILON, "Mesh %d: Got (%f, %f, %f, %f) for vertex %d %s, expected (%f, %f, %f, %f).\n", > mesh_number, got->x, got->y, got->z, got->w, vertex_number, usage_strings[decl_ptr->Usage], exp->x, exp->y, exp->z, got->w); > break; > -- > 1.7.6.1 fmaxf was already removed in http://source.winehq.org/git/wine.git/commitdiff/49064869595a8d0c97a79055eb… -- -Austin

1 0

Re: [2/3] cmd: Avoid checking whether we're in console mode for every read (try 2)
by Eric Pouech 28 Sep '11

28 Sep '11

Le 28/09/2011 01:01, Frédéric Delanoy a écrit : > --- > programs/cmd/batch.c | 9 ++++----- > programs/cmd/builtins.c | 4 ++-- > programs/cmd/wcmd.h | 5 +++-- > programs/cmd/wcmdmain.c | 21 +++++++++++++-------- > 4 files changed, 22 insertions(+), 17 deletions(-) actually, console handles have their 2 lower bit set you could use it to even simplify further the code A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [PATCH 1/2] mmdevapi: Don't fail if dwChannelMask is not set correctly
by Marvin 28 Sep '11

28 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14610 Your paranoid android. === WVISTAADM (32 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === W2K8SE (32 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === W7PRO (32 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === W7PROX64 (32 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === TEST64_W7SP1 (32 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === W7PROX64 (64 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000 === TEST64_W7SP1 (64 bit render) === render.c:232: Test failed: IsFormatSupported(dwChannelMask = 0xffff) call returns 00000000

1 0

Re: browseui/tests: Skip some tests if IEnumACString is not supported.
by Marvin 28 Sep '11

28 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14608 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:250: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154 === WXPPROSP3 (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === W2K3R2SESP2 (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === WVISTAADM (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === W2K8SE (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === W7PRO (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === W7PROX64 (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === TEST64_W7SP1 (32 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === W7PROX64 (64 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0 === TEST64_W7SP1 (64 bit autocomplete) === autocomplete.c:261: Test failed: QueryInterface(IID_IEnumACString) failed: 0

1 0

Re: [1/3] cmd: Avoid reading char by char from console (try 2)
by Alexandre Julliard 28 Sep '11

28 Sep '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -181,13 +181,21 @@ WCHAR *WCMD_parameter (WCHAR *s, int n, WCHAR **where, WCHAR **end) { > * the LF (or CRLF) from the line. > */ > > -WCHAR *WCMD_fgets (WCHAR *s, int noChars, HANDLE h) { > - > - DWORD bytes; > - BOOL status; > +WCHAR *WCMD_fgets (WCHAR *s, int noChars, HANDLE h) > +{ > + DWORD bytes, charsRead, dummy; > + BOOL status, is_console_handle; > WCHAR *p; > > p = s; > + is_console_handle = !!GetConsoleMode(h, &dummy); > + if (is_console_handle) { > + status = ReadConsoleW(h, s, noChars, &charsRead, NULL); ReadConsole will fail if it's not a console, the check is redundant. -- Alexandre Julliard julliard(a)winehq.org

2 2

mmdevapi performance analysis
by Joerg-Cyril.Hoehle＠t-systems.com 28 Sep '11

28 Sep '11

Hi, While the 3D guys work on performance improvements, we audio guys kill it. Luckily gfx data is shuffled around in MB/s, audio only in hundred kB/s, so hopefully it doesn't weight that much. Let's have a look at how data wanders around with dsound, winmm and mmdevapi. waveOutWrite with mmdevapi: copy to mmdevapi ALSA/OSS buffer copy some in case of mmdevapi buffer wrap around write buffer to ALSA/OSS waveOutWrite old driver model: write header to ALSA/OSS waveOutWrite involving MSACM with mmdevapi: convert PCM to MSACM, writing to new buffer copy to mmdevapi ALSA/OSS buffer copy some in case of buffer wrap around write to ALSA/OSS Here, if msacm/waveform.c had the courage to delay conversion until GetBuffer time, some copying could be avoided as msacm would write directly into mmdevapi's buffer. Being overly protective ("I should convert before GetBuffer because afterwards I might not have enough time") ends up wasting CPU cycles, hence paradoxically increasing the probability of being late thus causing underruns. The cause for the impedance mismatch between winmm and mmdevapi is what I call "owner inversion". The app supplies winmm with a pointer to its data buffers. As mmdevapi does the same, some transfer is needed between both. Arguably, mmdevapi is not the best target for winmm in Wine... DSOUND_WaveQueue newest "reimplement rendering on mmdevapi" in 1.3.30: write to dsound secondary buffer mix secondary to primary buffer copy to mmdevapi buffer copy some more in case of mmdevapi buffer wrap around write buffer to ALSA/OSS It looks like the new code misses the opportunity to equate device buffer with primary buffer. Instead we've got a cascade of buffers. Why is dsound's primary (mixing target) not mmdevapi's buffer? What's the goal? Ideally, 1. ALSA's mmdevdrv Get/ReleaseBuffer use snd_pcm_mmap_begin/commit, avoiding copying from mmdevapi to ALSA; 2. mmdevapi's buffer becomes DSound's primary, avoiding copying from dsound to mmdevapi. This applies even to CoreAudio where there's not really an mmdevapi buffer. The result: DSound's mixer talks straight with the HW. This should be no surprise. mmdevapi's shared mode mixer probably has roots in dsound's. BTW, what prevents equating dsound's secondary buffers with mmdevapi's shared mode streams and let the underlying device perform the mixing? Regards, Jörg Höhle

1 0

Update on testbot
by Maarten Lankhorst 28 Sep '11

28 Sep '11

Hi all, I moved the windows 7 x64 vm with sp1 applied to the base pool now. This means that all submitted patches will be run on that vm as well. The original win7 vm is still available under its own name. Since all tests pass on that according to winehq tests I'm keeping it in the base pool. I hope to see all tests on the new vm fixed as well. They mostly appear to be related to the ie9 update, but msctf:inputprocessor and msi:install fail as well. ~Maarten

2 1

Re: mscoree: Add ICorDebug interface support (try 3)
by Vincent Povirk 28 Sep '11

28 Sep '11

It's OK to call CLRMetaHost methods directly with a NULL ICLRMetaHost instance. It's a singleton, and none of the methods use the interface. You might want to check whether you get a new ICorDebug interface every time you request one. I suspect you do. On Wed, Sep 28, 2011 at 1:21 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Changed to use ICLRRuntimeInfo::GetInterface, suggest by Vincent. > Moved the #undef to the header. > > > Changelog: > mscoree: Add ICorDebug interface support > > > Best Regards > Alistair Leslie-Hughes > > > > > >

1 0

Re: mscoree: Add ICorDebug interface support (try 3)
by Marvin 28 Sep '11

28 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14599 Your paranoid android. === W2K3R2SESP2 (32 bit debugging) === debugging.c:82: Test failed: CreateDebuggingInterfaceFromVersion returned 80070057

1 0

re: dsound: Place storage class before type qualifier
by Dan Kegel 28 Sep '11

28 Sep '11

Hi Andrew, doesn't seem to apply here: $ patch -p1 < 79377.patch patching file dlls/dsound/dsound_main.c Hunk #1 FAILED at 319. 1 out of 1 hunk FAILED -- saving rejects to file dlls/dsound/dsound_main.c.rej ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 27, 2011 at 2:50 PM Subject: Re: 79377: dsound: Place storage class before type qualifier To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/128 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed git Errors: error: patch failed: dlls/dsound/dsound_main.c:319 error: dlls/dsound/dsound_main.c: patch does not apply

1 0

Re: [PATCH] kernel32: make it possible to create a backtrace from a RaiseException exception in gdb
by Alexandre Julliard 27 Sep '11

27 Sep '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -60,6 +60,17 @@ static PTOP_LEVEL_EXCEPTION_FILTER top_filter; > typedef INT (WINAPI *MessageBoxA_funcptr)(HWND,LPCSTR,LPCSTR,UINT); > typedef INT (WINAPI *MessageBoxW_funcptr)(HWND,LPCWSTR,LPCWSTR,UINT); > > +#ifdef __i386__ > +/* without this, it's impossible to get a backtrace from the raised > + * exception in winedbg in gdb mode */ > +void RaiseException_helper(EXCEPTION_RECORD *r, void *f) DECLSPEC_HIDDEN; > +__ASM_GLOBAL_FUNC(RaiseException_helper, > + "mov 0x4(%esp),%eax\n\t" > + "push %eax\n\t" > + "mov 0xc(%esp),%eax\n\t" > + "call *%eax\n\t" > + "ret") > +#endif You shouldn't need anything like that. -- Alexandre Julliard julliard(a)winehq.org

2 3

re: winmm: waveOutReset returns all buffers.
by Dan Kegel 27 Sep '11

27 Sep '11

Fails to apply here. (Requires fuzz, which Alexandre says is verboten.) ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Mon, Sep 26, 2011 at 2:35 AM Subject: Re: 79321: winmm: waveOutReset returns all buffers. To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/63 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed git Errors: error: patch failed: dlls/winmm/waveform.c:1653 error: dlls/winmm/waveform.c: patch does not apply

2 2

Re: [PATCH] ntdll/signal_i386.c: RtlCaptureContext locals + args are 12 bytes instead of 8 (return address + CONTEXT * arg + %eax local
by Alexandre Julliard 27 Sep '11

27 Sep '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -1181,7 +1181,7 @@ __ASM_STDCALL_FUNC( RtlCaptureContext, 4, > __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") > "popl 0xc0(%eax)\n\t" /* context->EFlags */ > __ASM_CFI(".cfi_adjust_cfa_offset -4\n\t") > - "leal 8(%esp),%edx\n\t" > + "leal 0xc(%esp),%edx\n\t" > "movl %edx,0xc4(%eax)\n\t" /* context->Esp */ That's not really more correct, it's supposed to return the caller frame but there's no good way of doing that. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: mscoree: Add ICorDebug interface support (try 2)
by Vincent Povirk 27 Sep '11

27 Sep '11

You really should implement the .NET 4 version of this first (MSDN helpfully points to ICLRRuntimeInfo::GetInterface, which is CLRRuntimeInfo_GetInterface in our code), then implement the legacy version based on that, so everything is in one place. On Tue, Sep 27, 2011 at 6:34 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Add missing test file. > > Changelog: > mscoree: Add ICorDebug interface support > > > Best Regards > Alistair Leslie-Hughes > > > > >

1 0

Re: mscoree: Add ICorDebug interface support
by Vincent Povirk 27 Sep '11

27 Sep '11

Why aren't you using CLRRuntimeInfo_GetInterface for this?

1 0

Complaint about mmdevapi (COM?) logging
by Joerg-Cyril.Hoehle＠t-systems.com 27 Sep '11

27 Sep '11

Hi, I'm not satisfied with the current winmm+mmdevapi logging. I suspect that COM logging of other components is similarly bad. Consider the following snippet. It looks like a +relay log, not showing what I want to see. 0022:trace:winmm:waveOutWrite (0xc000, 0x21f140, 32) 0020:trace:winmm:WOD_PushData (0xc000) 0020:trace:alsa:AudioClient_GetBufferSize (0x48f7700)->(0x4b0e9c4) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e9c8) 0020:trace:alsa:AudioClock_GetFrequency (0x48f7700)->(0x4b0e930) 0020:trace:alsa:AudioClock_GetPosition (0x48f7700)->(0x4b0e928, (nil)) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e8b4) 0020:trace:alsa:AudioRenderClient_GetBuffer (0x48f7700)->(256, 0x4b0e9c0) 0020:trace:alsa:AudioClient_GetCurrentPadding (0x48f7700)->(0x4b0e938) 0020:trace:alsa:AudioRenderClient_ReleaseBuffer (0x48f7700)->(256, 0) 0020:trace:winmm:WOD_PushData (0xc000) I don't want those %p pointers, I want values. - What's the position? - What's the low-level driver's padding? - What's the mmdevapi padding? - How many samples did waveOutWrite() supply? - Where's any log line from the intermittent mmdevapi periodic timer callback? + The current log is easily compressible :-) The only concrete data is from GetBuffer/ReleaseBuffer: 256 frames, so GetCurrentPadding probably returned GetBuffersize (whose value I derive from the call to Initialize, not shown here) minus 256. The bad news is that you derive more from what you *don't* see in the log than what's written therein. This costs time and effort. E.g. GetBuffer wasn't called means buffer was full -- wait, perhaps there was no more queued data? Help! Why do I believe that logging of other COM dlls may be similarly bad? The anti-pattern is to have a TRACE at function entry! I'd rather move that down a few lines, after basic checking of parameters. At that time you can TRACE some meaningful values instead of pointers. Then you may even decide to put the TRACE at the end of the function, e.g. for GetCurrentPadding that makes a lot of sense, without the added cost of two TRACE lines. Basically, there's little value in an early TRACE because only in rare case will you want to know that the call may have been aborted by E_INVALIDARG or AUDCLNT_E_NOT_INITIALIZED -- not to mention that those return values are almost never logged, not even with +relay. Actually, the useful amount of logging is a function of code maturity. Initially, you're happy with logging every API call. Once you've tested that the basic input checks work exactly like in native, you want to see more from the inside. IOW, initial stubs contain nothing but TRACE. When you fill the function body, it is an error to leave the TRACE at the top, it should move down to the heart of the function where the interesting stuff happens. Regards, Jörg Höhle

2 1

Re: mscoree: Add ICorDebug interface support (try 2)
by Alexandre Julliard 27 Sep '11

27 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +#include "initguid.h" > +/* We need to undefine the MACRO CreateProcess since the ICorDebug interface > + has a function with this name. (Stops a compile issue). > + */ > +#undef CreateProcess > +#include "cordebug.h" This should go in the header. Check how other idl files are doing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 79358: mscoree: Add ICorDebug interface support
by Dan Kegel 27 Sep '11

27 Sep '11

build failed here - did you forget a file? ../../tools/makedep -C. -S../.. -T../.. assembly.c config.c cordebug.c corruntimehost.c metadata.c metahost.c mscoree_main.c debugging.c: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/mscoree/tests' make: *** [dlls/mscoree/tests/__depend__] Error 2 On Tue, Sep 27, 2011 at 4:20 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-default while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/109 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_2 > > Errors: > make[1]: *** [depend] Error 1 > make: *** [dlls/mscoree/tests/__depend__] Error 2 > >

1 0

Re: mscoree: Add ICorDebug interface support (try 2)
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14582 Your paranoid android. === W2K3R2SESP2 (32 bit debugging) === debugging.c:82: Test failed: CreateDebuggingInterfaceFromVersion returned 80070057

1 0

Re: mscoree: Add ICorDebug interface support
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14581 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msi/tests: Properly preserve pending file renames.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14578 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: wininet: Ignore the accept types array in HttpOpenRequestA if there are invalid pointers.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14577 Your paranoid android. === W7PRO (32 bit http) === http.c:2873: Test failed: HttpSendRequest failed: 12002

1 0

Re: shell32: Add definitions for the IEnumACString interface.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14562 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:250: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154 === W2KPROSP4 (32 bit autocomplete) === autocomplete.c:256: Test failed: obj->lpVtbl->QueryInterface(obj, &IID_IEnumACString, (LPVOID*)&unk) failed: 80004002

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14554 Your paranoid android. === WNT4WSSP6 (32 bit autocomplete) === autocomplete.c:249: Test failed: CoCreateInstance(&CLSID_ACLMulti, NULL, CLSCTX_INPROC, &IID_IEnumString, (LPVOID *)&obj) failed: 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14548 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154 === WNT4WSSP6 (32 bit referenceclock) === referenceclock.c:97: Test failed: Unable to create reference clock from system clock 80040154

1 0

Re: tests: Remove unneeded assert.h includes.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14540 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2KPROSP4 (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541 === W2K8SE (32 bit mediadet) === mediadet.c:105: Test failed: CoCreateInstance failed with 80040154 mediadet.c:106: Test failed: pM is NULL mediadet: unhandled exception c0000005 at 00401541

1 0

Re: msi/tests: Avoid #if 0 to make sure code still compiles.
by Marvin 27 Sep '11

27 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14533 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5998: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH 6/9 (try2)] winecfg: Replace DirectSound settings with Driver Diagnostics
by Alexandre Julliard 26 Sep '11

26 Sep '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -84,10 +84,11 @@ END > > STRINGTABLE > BEGIN > - IDS_ACCEL_FULL "Full" > - IDS_ACCEL_STANDARD "Standard" > - IDS_ACCEL_BASIC "Basic" > - IDS_ACCEL_EMULATION "Emulation" > + IDS_AUDIO_REG_SETTING "Registry driver setting: %s" > + IDS_AUDIO_REG_DEFAULT "(Default)" > + IDS_AUDIO_REG_DISABLED "(Disabled)" > + IDS_AUDIO_DRIVER "Selected driver: %s" > + IDS_AUDIO_DRIVER_NONE "(None)" Showing the detected driver is a good thing, but we shouldn't need to display the registry setting. The assumption is that users shouldn't have to worry about this. If it's important enough to show in winecfg then it has to be editable in winecfg too. -- Alexandre Julliard julliard(a)winehq.org

1 0

using (or not) blocking mode with OSS4
by Joerg-Cyril.Hoehle＠t-systems.com 26 Sep '11

26 Sep '11

Hi, I've had a glance at the OSS4 mmdevapi logs attached to bug #28056. Among others, it appears that every renderer iteration takes way too much time. One possible explanation is that OSS write() takes a lot of time to return, presumably in an attempt to write more than what's possible without blocking. If you look at AudioRenderClient_ReleaseBuffer and oss_write_data, you'll see that it writes as much as it has, without querying GETOSPACE. So it can block. open() is called without O_NONBLOCK, so write() will block when given too much data. I don't know yet whether O_NONBLOCK should be used. It's not what the OSS people recommend. One can argue that NONBLOCK is superfluous when write is limited via GETOSPACE. http://manuals.opensound.com/developer/open.html http://manuals.opensound.com/developer/audio_timing.html http://manuals.opensound.com/developer/SNDCTL_DSP_NONBLOCK.html What do you think about using (or not) blocking mode with OSS? W.r.t. ALSA, I'm considering keeping non-blocking mode but switch from a periodic timer to poll(ALSA_fd, period_timeout). Given a lot of data, poll would return after the timeout, but when underrun is close, this should allow to wake up closer to when data is actually needed. Regards, Jörg Höhle

2 1

re: po: Mark translations with mismatched printf format directives as fuzzy.
by Dan Kegel 26 Sep '11

26 Sep '11

Patch fails to apply here? error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 5:35 PM Subject: Re: 79310: po: Mark translations with mismatched printf format directives as fuzzy. To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/84 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed git Errors: error: patch failed: po/ko.po:11305 error: po/ko.po: patch does not apply

4 5

Before you leave for wineconf...
by Dan Kegel 26 Sep '11

26 Sep '11

... could you run http://kegel.com/wine/loop-fail.sh.txt overnight on the hardware you plan to bring, and email me the results? It creates a log file loop-fails.log which lists each test failure and how many loops it took to get there. Thanks!

2 2

Re: [1/2] kernel32: Add a test for VirtualProtect.
by Alexandre Julliard 26 Sep '11

26 Sep '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +static void test_VirtualProtect(void) > +{ > + static const struct test_data > + { > + DWORD prot_set, prot_get; > + } td[] = > + { > + { PAGE_NOACCESS, PAGE_NOACCESS }, > + { PAGE_READONLY, PAGE_READONLY }, > + { PAGE_READWRITE, PAGE_READWRITE }, > + { PAGE_WRITECOPY, 0 }, > + { PAGE_EXECUTE, PAGE_EXECUTE }, > + { PAGE_EXECUTE_READ, PAGE_EXECUTE_READ }, > + { PAGE_EXECUTE_READWRITE, PAGE_EXECUTE_READWRITE }, > + { PAGE_EXECUTE_WRITECOPY, 0 } You should also test various invalid combinations. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH 7/9] dsound: Reimplement rendering devices on mmdevapi
by Joerg-Cyril.Hoehle＠t-systems.com 26 Sep '11

26 Sep '11

Hi, I agree that dsound -> winmm -> mmdevapi is an abomination. However, this all goes too fast for me. We don't have a fool-proof mmdevapi yet (neither ALSA, nor OSS, nor CoreAudio). We don't have a bug-free winmm->mmdevapi yet. Since June, I've done nothing than analyse code and fix bugs to help The Wine project in my free time. My wife has already signaled that she's not pleased. I've installed zero SW for the children since that time. Well, my choice, but I'm growing tired. It appears that I've a biased view on the current audio situation because I see all the bugs. The user experience does not seem that bad, from what a few users told me. Currently, having dsound -> winmm -> mmdevapi may not be satisfying, but it helps to find hairy bugs fast (more apps use dsound than winmm). After the initial winmm transition, I did not even look at dsound or winmm bugs because there's no point in doing so when they depend on a mmdevapi which is not yet robust enough. So I concentrated on mmdevapi. It's only recently that I've started to look at winmm now that I believe to know well most remaining ALSA and CoreAudio mmdevapi bugs. I'm solely starting on OSS bugs. I believe users are happy to still have dsound HW acceleration in ALSA since 1.3.25 to compare it with the new HW emulation behaviour via mmdevapi. Is a 1.4 release target this year the reason for pushing out code fast? Regards, Jörg Höhle

2 1

Warning report for wine-1.3.29-5-gf04f0b3
by Jerome Leclanche 26 Sep '11

26 Sep '11

Operating System Linux azura 3.0.0-10-generic #16-Ubuntu SMP Fri Sep 2 18:32:04 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--enable-tests' '--disable-win64' '--with-wine64=/home/adys/src/wine/build64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' -- J. Leclanche

1 0

Quick Question
by Peter Wilson 26 Sep '11

26 Sep '11

Hi, Quick question, might be silly, but is there a version of Wine that can be installed on windows or linux to create apps for Mac? I just want to keep my mac clean and try run things in a dev environment, and apple are always so polite to make visualization a pain… Thank you very much for you help, Kind Regards, Peter Wilson

2 1

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Frédéric Delanoy 25 Sep '11

25 Sep '11

This patch fails; see http://source.winehq.org/patches/ and http://source.winehq.org/patches/data/79288.testfail Got a lot of errors on NT4, and 1 on other systems batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@' You might want to use @todo_wine@ as documented on http://wiki.winehq.org/CmdConformanceTests Patches generating at least 1 error on one of testbot's systems (NT included) have 0% chance of being committed (see http://wiki.winehq.org/SubmittingPatches) [I know NT4 is sometimes $#!+... be thankful win9x is not a prerequisite anymore... ;) ] Frédéric PS: "resend" is used for unchanged patches (or only rebased); in other cases you should use "try N"

1 1

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14502 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === TEST64_W7SP1 (64 bit msg) === Timeout

1 0

re: gdi32: Add traces for the gamma functions
by Dan Kegel 25 Sep '11

25 Sep '11

Looks like you forgot something: cc1: warnings being treated as errors dc.c: In function ‘GetDeviceGammaRamp’: dc.c:1289: error: too few arguments for format dc.c: In function ‘SetDeviceGammaRamp’: dc.c:1307: error: too few arguments for format make[1]: *** [dc.o] Error 1 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 25, 2011 at 12:10 PM Subject: Re: 79299: gdi32: Add traces for the gamma functions To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/69 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/gdi32] Error 2

2 1

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14499 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 4/5] cmd: fix handling of special characters in command line
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14498 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 3/5] cmd: improve parsing of quotes in command line
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14497 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 2/9] cmd: use GetCommandline() rather than argv
by Martin Wilck 25 Sep '11

25 Sep '11

Hi Dan, (re-cc'ing wine-devel) > Running it through the buildbot now... seems ok on first two tries, so > you may have accidentally fixed the problem. I'll resubmit to wine-patches shortly, probably tonight. >> > I ran the stuff through the bot, 0 errors everywhere except on NT (NT >> > fails totally, do I really need to investigate that?). > Yes, you may need to skip these tests on nt. > >> > I don't have a i7 machine, > It's probably just mine that gets lucky. Some tests > fail better on some machines than others. > Did you test with WINEDEBUG=warn+heap ? No, I didn't. I thought you wree telling me that that made your problem go away, so I didn't bother. I can do that of course if it helps. >> but I tested on a Westmere EX server I have access to, no >> problems with the conformance test. I also did some valgrind runs on >> that machine, but I have little experience in reading valgrind output. > > Did you follow http://wiki.winehq.org/Wine_and_Valgrind ? > Feel free to ask questions. Yes, I did. I am seeing no regressions (read: additional warnings and/or errors) between the trunk and my patched version. > A few notes: > + if (!in_quotes && (*p == ' ' || *p == '\t')) { > > Could you use isspaceW() ? I suppose not in the case statement below, > but you check this in several places, and the function might be clearer > (if it's correct)? Honestly, I didn't consider it. I tried to change as little as possible of the existing code. > Is there duplication between WCMD_parameter and WCMD_parse > that could be gotten rid of productively? Yes, there is, as I noted in an early posting on this subject. Indeed the two functions have essentially the same purpose. However I don't feel bold enough to try fixing that as long as my current stuff isn't accepted. Originally, all that I wanted to fix was 'echo "Hi"'. I have gone quite a few steps ahead from there with my current patch set. When I see this getting merged I'll consider further fixes, but I won't be able to follow up *much* further. Best regards Martin

2 1

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14496 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 51 (got '0 ', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2:

1 0

Re: [PATCH 1/5] cmd/tests: add tests for command line parsing
by Marvin 25 Sep '11

25 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14495 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 29 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 30 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 31 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 32 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 33 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 34 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 35 (got '1 ', wanted '0@space@@or_broken@3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 36 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 37 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 38 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 41 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 42 (got '2 ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 46 (got '5 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 47 (got '------- Testing CMD /C qualifier treatment ------------', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 50 (got '0 ', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 51 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 52 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 53 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 54 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 55 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 56 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 57 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 58 (got '{ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 59 (got '} ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 60 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 62 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 63 (got '! ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 64 (got '0 ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x54 position 0 in line 46 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@')

1 0

Re: advpack: Only do_ocx_reg (and thus DllRegisterServer) from RegisterOCX when 'N' is passed as a flag. Clarify documentation.
by James Hawkins 24 Sep '11

24 Sep '11

I'm very hesitant about this. MSDN has no documentation about RegisterOCX, so I'm not sure how you're justifying this change. It's been a long time since I worked on this, so I don't remember much, but I do remember testing this method and documenting the parameters correctly. Where are you getting information that 'I' is required when using 'N'? James On Tue, May 11, 2010 at 1:24 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This is my humble attempt of addressing Alexandre's feeback at > > http://www.winehq.org/pipermail/wine-devel/2010-May/083518.html > > It does pass testing for me, even on FreeBSD/i386, but I will say I did > not find the MSDN documentation I located too helpful/clear, and may have > been misled. > > As a next step we'd need to look into DllInstall. This change, hopefully, > is a move in the right direction, though. If not, some guidance or one of > the pros looking into it will be appreciated. > > Gerald > > --- > dlls/advpack/advpack.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/dlls/advpack/advpack.c b/dlls/advpack/advpack.c > index 112d38a..f040ec6 100644 > --- a/dlls/advpack/advpack.c > +++ b/dlls/advpack/advpack.c > @@ -486,8 +486,10 @@ HRESULT do_ocx_reg(HMODULE hocx, BOOL do_reg) > * NOTES > * OCX - Filename of the OCX to register. > * flags - Controls the operation of RegisterOCX. > - * 'I' Call DllRegisterServer and DllInstall. > - * 'N' Only call DllInstall. > + * 'I' Call DllInstall and, unless 'N' is specified as well, > + * DllRegisterServer. > + * 'N' Do not call DllRegisterServer; only valid if 'I' is > + * specified too. > * param - Command line passed to DllInstall. > */ > HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > @@ -519,8 +521,12 @@ HRESULT WINAPI RegisterOCX(HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show) > if (!hm) > goto done; > > - hr = do_ocx_reg(hm, TRUE); > - > + if(strchrW(str_flags,'I')) > + { > + if (!strchrW(str_flags,'N')) > + hr = do_ocx_reg(hm, TRUE); > + } > + > done: > FreeLibrary(hm); > HeapFree(GetProcessHeap(), 0, cmdline_copy); > -- > 1.6.6.2 > > >

2 3

Re: loop fails
by Dan Kegel 24 Sep '11

24 Sep '11

2011/9/24 André Hentschel <nerv(a)dawncrow.de>: > Hey Dan, > sadly i'm not going to be at wineconf this year, but i thought the results might help anyway. maybe i'm participating per IRC and it's my desktop computer anyway, so we'll see. > the script didn't end cleanly, there was a heap related crash that made it hang so i'm not sure about it. > > ended in the urlmon test: > > Backtrace: > =>0 0x7bc48485 RtlAllocateHeap+0xb5(heap=0x110000, flags=0x2, size=0x6000) [/home/dawncrow/dev/wine/132/dlls/ntdll/../../../include/wine/list.h:99] in ntdll (0x0032e328) > 1 0x696866b7 MSVCRT_malloc+0x36(size=0x6000) [/home/dawncrow/dev/wine/132/dlls/msvcrt/../../../dlls/msvcrt/heap.c:312] in msvcrt (0x0032e348) > 2 0x702d1962 in mozjs (+0x151961) (0x02326318) > 3 0x00000000 (0x010c6740) oooh. So it only took six loops to crash in urlmon, eh? (For the record, the script ran both dlls/urlmon/tests/protocol.ok and dlls/urlmon/tests/url.ok, don't know which one crashed.) Can you install debug gecko, e.g. by running http://kegel.com/wine/dgecko.sh.txt ( which just does the steps on http://wiki.winehq.org/Gecko ) and re-run? Also, out of six loops, you got the following test failures: 6 dlls/dsound/tests/ds3d.ok 6 dlls/dsound/tests/ds3d8.ok 6 dlls/wininet/tests/urlcache.ok 6 dlls/dsound/tests/dsound.ok 6 dlls/dsound/tests/dsound8.ok 5 dlls/winhttp/tests/winhttp.ok 5 dlls/vbscript/tests/run.ok 5 dlls/mshtml/tests/style.ok 5 dlls/mshtml/tests/htmldoc.ok 5 dlls/gdi32/tests/bitmap.ok 2 dlls/ws2_32/tests/sock.ok 1 dlls/user32/tests/msg.ok The urlcache one may go away if you clear out ~/.wine. The msg one probably would go away if you had the blessed window manager (does anyone know what the procedure there is these days?) The others seem interesting. If you were attending wineconf, I would have asked you to hit the appropriate developers up for help resolving them. Maybe you still can via email or irc... I'm looking forward to seeing loop-fail results from other folks. - Dan

2 1

Re: hhctrl.ocx: Don't show unimplemented buttons.
by Erich Hoover 24 Sep '11

24 Sep '11

> + case IDTB_NOTES: > + case IDTB_CONTENTS: > + case IDTB_INDEX: > + case IDTB_SEARCH: > + case IDTB_HISTORY: > + case IDTB_FAVORITES: > + /* These are officially unimplemented as of the Windows 7 SDK */ > + break; Could you point me to a link on this behavior? I'm pretty sure that many of these buttons send a signal that applications can hook into and override the default (do-nothing) behavior. Erich Hoover ehoover(a)mines.edu

3 2

Re: [1/4] ddraw/tests: Use sizeof instead of a magic number
by Stefan Dösinger 24 Sep '11

24 Sep '11

Am 24.09.2011 um 12:48 schrieb Stefan Dösinger: > <PGP.txt> WTF? What did my Mail client do here???

1 0

Congratulations! DIB engine 421
by Keith 24 Sep '11

24 Sep '11

Hi, Amazing I'm a long time follower of the project and to see a DIB engine implemented is a huge milestone given all the trials and tribulations leading up to it. Honestly never thought it would happen everyone needs to give themselves a pat on the back today :-) Regards, Keith

1 0

Re: dpnet: fill the DPN_SP_CAPS structure in IDirectPlay8Peer_GetSPCaps with some sane values + tests
by Marvin 23 Sep '11

23 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14486 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BF

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Andrew Talbot 23 Sep '11

23 Sep '11

Marcus Meissner wrote: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. > > CID 5033, 5034 > > Ciao, Marcus > --- > dlls/comdlg32/itemdlg.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c > index bc309c9..d9756c0 100644 > --- a/dlls/comdlg32/itemdlg.c > +++ b/dlls/comdlg32/itemdlg.c > @@ -1106,6 +1106,8 @@ static SIZE update_layout(FileDialogImpl *This) > SIZE ret; > > GetClientRect(This->dlg_hwnd, &dialog_rc); > + memset (&toolbar_rc, 0, sizeof(toolbar_rc)); > + memset (&filename_rc, 0, sizeof(filename_rc)); > > missing_width = max(0, 320 - dialog_rc.right); > missing_height = max(0, 200 - dialog_rc.bottom); Hi Marcus, Instead of using memset(), would it not be better to initialise the RECTs to zero when declaring them, as follows? RECT toolbar_rc = { 0 }; RECT filename_rc = { 0 }; -- Andy.

1 0

Re: [PATCH] comdlg32: Initialize 2 RECT to 0 (Coverity)
by Alexandre Julliard 23 Sep '11

23 Sep '11

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > If the filename and toolbar field are not present, we will be using > uninitialized RECTs, so initialize them. It's not clear that 0 is much better. If there's really a possibility for these things to be missing the layout should take that into account. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Bruno Jesus 23 Sep '11

23 Sep '11

On Fri, Sep 23, 2011 at 07:50, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Note: the 2 failing tests on test-bot that this patch will produce, are not real failures as winnt and win2000 will not run the test because of missing dpnet > > try 3: rewrote patch in a more straightforward way > > this makes previously sent tests pass, and fixes crash in bug http://bugs.winehq.org/show_bug.cgi?id=28008 Use the broken macro to skip or expect a different return from the tests that crash in NT and add a comment there. Example: http://source.winehq.org/source/dlls/ole32/tests/usrmarshal.c#L103 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)
by Marvin 23 Sep '11

23 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14466 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: mshtml: Add IHTMLCurrentStyle2/3/4 support
by Alexandre Julliard 23 Sep '11

23 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/mshtml/Makefile.in b/dlls/mshtml/Makefile.in > index 3933645..62a2d6f 100644 > --- a/dlls/mshtml/Makefile.in > +++ b/dlls/mshtml/Makefile.in > @@ -14,6 +14,7 @@ C_SRCS = \ > htmlbody.c \ > htmlcomment.c \ > htmlcurstyle.c \ > + htmlcurstyle2.c \ Please add this to the existing file. There are already way too many source files in this dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Highlighting Fall-throughs
by Andrew Talbot 23 Sep '11

23 Sep '11

Hi All, I am thinking of marking any unmarked places in switch statements where fall-through occurs. However, simply to do so would be to ignore the question of whether each fall-through is intentional or an oversight. I therefore propose to mark each new point with two comments (maybe separate, maybe combined): one to state that fall-through occurs and the other to point out that the validity of this particular fall-through has not yet been checked, maybe something like: select(x) { case 1: foo(); break; case 2: bar(); /* fall through */ /* unaudited */ default: baz(); } Is this all good, or is there a better way? Thanks, -- Andy.

3 4

Re: comctl32: Fix going to today with multiple calenders
by Nikolay Sivov 22 Sep '11

22 Sep '11

On 9/23/2011 00:03, André Hentschel wrote: > --- > dlls/comctl32/monthcal.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 5f8a36c..b330871 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam) > if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD, > menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL)) > { > - infoPtr->calendars[0].month = infoPtr->todaysDate; > - infoPtr->minSel = infoPtr->todaysDate; > - infoPtr->maxSel = infoPtr->todaysDate; > + MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate); > InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > } > This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed. Actually I planned to work on this tomorrow, including some other issues I just spotted.

2 2

Fwd: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation
by Dan Kegel 22 Sep '11

22 Sep '11

Didn't build here, did you forget to add dependency on ole32? ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -Wno-unused-but-set-variable -Wno-unused-but-set-parameter -o vwin32.o vwin32.c global.o: In function `create_object': /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:74: undefined reference to `CLSIDFromProgID' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:92: undefined reference to `CoGetClassObject' /home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/vbscript/global.c:114: undefined reference to `CoTaskMemFree' collect2: ld returned 1 exit status winegcc: ccache failed make[1]: *** [vbscript.dll.so] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Thu, Sep 22, 2011 at 8:01 AM Subject: Re: 79194: [PATCH 10/13] vbscript: Added CreateObject implementation To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/26 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 Errors: make: *** [dlls/vbscript] Error 2

2 1

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Jacek Caban 22 Sep '11

22 Sep '11

> === WNT4WSSP6 (32 bit createobj) === > createobj.c:734: Test failed: CoCreateInstance failed: 80040154 > createobj: unhandled exception c0000005 at 00402A21 These tests fail because testbot runs them regardless that vbscript.dll is not present on the machine. Jacek

1 0

IPv6 issue on TestBot?
by Francois Gouget 22 Sep '11

22 Sep '11

Connecting to https://testbot.winehq.org/ over IPv6 hangs for ages :-( This makes accessing it from my desktop very annoying. $ time wget -4 --quiet http://testbot.winehq.org/ real 0m2.150s user 0m0.000s sys 0m0.000s $ time wget -6 --quiet http://testbot.winehq.org/ ... still stuck after 6+ minutes $ telnet -6 testbot.winehq.org Trying 2001:888:2000:38:1000::2... ... same thing According to http://test-ipv6.com/ my desktop is configured just fine and I only have trouble with the TestBot. Could this be a firewall problem? (testbot exposing an IPv6 address but the firewall dropping any IPv6 packets) In the mean time I'm going to use my laptop which is still IPv4 only :-/ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A black hole is just God dividing by zero.

6 11

Re: [PATCH 12/13] vbscript: Added CreateObject tests (based on jscript ActiveXObject tests)
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14455 Your paranoid android. === WNT4WSSP6 (32 bit createobj) === createobj.c:734: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c0000005 at 00402A21

1 0

Re: [PATCH 07/13] vbscript: Added exit for statement support
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14454 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/13] vbscript: Added for..in statement tests
by Marvin 22 Sep '11

22 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14453 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case
by Juan Lang 22 Sep '11

22 Sep '11

--Juan

1 0

Remove the legalese from start.exe?
by Francois Gouget 22 Sep '11

22 Sep '11

Start has the following lines at the end of its usage message: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n" "This is free software, and you are welcome to redistribute it\n" "under certain conditions; run 'start /L' for details.\n" And also this resource: "start.exe version 0.2 Copyright (C) 2003, Dan Kegel\n" "This program is free software; you can redistribute it and/or\n" "modify it under the terms of the GNU Lesser Public License\n" "as published by the Free Software Foundation; either version 2.1\n" [...] "along with this program; if not, write to the Free Software\n" "Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.\n" "\n" "See the COPYING.LIB file for license information.\n" We also have another copy of this copyright notice in shell32 for the 'About Wine' dialog but without the 'start.exe' and 'COPYING.LIB' lines, and with 'This program' replaced with 'Wine'. One more copyright notice we have is this in msrle32.rc: "Wine MS-RLE video codec\n" "Copyright 2002 by Michael Guennewig" Now this is all legalese which is a pain to translate (weird vocabulary) and pretty scary too. And because of the small differences the copyright notice needs to be translated twice (though tools like Virtaal/Launchpad may notice the similarity and prefill a fuzzy translation). Also start.exe and msrle32.dll are the only ones to have these notices which seems pretty inconsistent. So what can we do to make this simpler? The simplest would be to remove all copyright notices from start.rc and msrle32.rc. (we would keep the ones in the source of course). I guess that would require Dan's and Michael's approval. The other options involve separating the strings that change from one tool to the next, from those that stay the same. This way the latter will only appear once in the PO file and thus need to be translated only once. The various parts can then trivially be concatenated when they are displayed. (unfortunately this does not help for the msrle32.rc case) For instance we could decide to only keep the 'COPYING.LIB' string and tack it to the end of the usage message. We could also make things more consistent by doing this in every tool. So in pseudo-code we would have something like this: /* Load the tool-specific usage message */ usage_message = load_string(IDS_USAGE); /* Load the generic copying.lib reference. This one is duplicated in * every tool but always the same. */ copying_reference = load_string(IDS_COPYING); /* Print both */ printf(usage_message); printf(copying_reference); Another option would be to reuse the exact same main copyright notice as in the About Wine dialog since we need to translate that anyway (I think it would work wrapping-wise). So the start.exe pseudo-code for showing the license would be something like this: /* Load the copyright notice header, that is: * start.exe version 0.2 Copyright (C) 2003, Dan Kegel * start.exe is part of Wine. */ notice_header = load_string(IDS_NOTICE_HEADER); /* Load the generic Wine copyright notice. Note that it * says 'Wine' like in the 'About Wine' dialog, not 'This program' * and would be the same in any other Wine tool: * Wine is free software; you can redistribute it and/or modify * ... */ notice_generic = load_string(IDS_NOTICE_GENERIC); /* Load the copyright notice trailer: * * See the COPYING.LIB file for license information. */ notice_trailer = load_string(IDS_NOTICE_TRAILER); /* Print all the parts together */ printf(notice_header); printf(notice_generic); printf(notice_trailer); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

3 4

[PATCH 3/5] winealsa.drv: Use the plughw instead of the hw interface for openening devices.
by Joerg-Cyril.Hoehle＠t-systems.com 22 Sep '11

22 Sep '11

Henri Verbeet [becoming an audio expert now?] wrote: >The default device may for example be a set of USB speakers or an USB >microphone, in which case you'd have just an output or just an input >respectively. My testcase has been to hack mmdevdrv.c and replace "default" with "plug:dmix" or "dmix" which is an output only device. Expected test result is to behave like most testbot.winehq.org and skip capture tests. Actual output (prior to your patch) last time I tried was some failures. I.e. the mmdevapi render and capture tests suggest that there's no default device for testbots that cannot capture. How does your alsa_try_open interact with devices that clang onto the underlying HW resource for several seconds? (PA does this) Regards, Jörg Höhle

2 1

winetest: Missing test.avi and msrle.avi files
by Francois Gouget 22 Sep '11

22 Sep '11

Two Wine tests are skipping tests because they are missing avi test files: * quartz:avisplitter needs a test.avi file: http://source.winehq.org/git/wine.git/?a=history;f=dlls/quartz/tests/avispl… avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test * winmm:mmio needs an msrle.avi file: http://test.winehq.org/data/b6153354dd28c57fb1f92f85df1f1ba751794fc1/mac_fg… mmio.c:77: Tests skipped: msrle.avi file is missing, skipping the test Interestingly there is a test.avi file in the Wine source tree: dlls/qedit/tests/test.avi So where can one procure these test files? Should quartz:avisplitter automatically find qedit:test's test.avi file? Can the missing files be added to Wine? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

2 2

Tests failing on OSX
by Stefan Dösinger 22 Sep '11

22 Sep '11

Hi, I'm attempting to set up a OSX testbot and I'm currently trying to get as many tests to work as possible. The following is a list of tests that fail currently. I'm hoping for comments if anybody knows more about them: (This is a 2006-era iMac, OSX 10.6, using the stock X server) > dinput8/device.c device.c:87: Test failed: We're not able to inject input into Windows dinput8 with events Fails sometimes, succeeds sometimes. > gdi32/dc > user32/monitor No Xvidmode support, so Get/SetDeviceGammaRamp fail. There's a win_skip for that already. Should we change it to skip(), or ignore it until we have a quartz driver? User32/monitor also fails because it can't change the display mode. > kernel32/change > ntdll/change > ntdll/directory Lots of test failures. I'm not sure what those tests do tbh > ntdll/exception "Test failed: Execution of data memory succeeded." Do I have to do anything special to enable NX support on OSX? > mmdevapi/capture Various Set*Volume calls fail > tests/shlexec Random failure: "shlexec.c:1023: test failed: Expected success (33), got failure (11), lpFile: C:\users\pts\Temp\wtb6bf.tmp\test file.shlexec" > urlmon/url > winmm/mci Test failed: mci resume waited Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) > ddraw/visual > d3d8/visual > d3d9/visual I'll investigate those. I bet they are GPU dependent. > ws2_32/sock A mixture of test failures and unexpected successes. > ddraw/d3d The window message test can't cope with the resolution change failure. I'll fix it. Using a virtual desktop works around the problem > ddraw/dsurface Crashes sometimes during cleanup in fbo-related GL calls. > d3dx9_36/math > d3dx9_36/texture I just sent patches for those. There was an issue with NaN sign bits and some GPU limitations the tests didn't account for.

5 13

Re: po: Update Russian translation
by Francois Gouget 21 Sep '11

21 Sep '11

This email is likely to get mangled but the gist of it will hopefully survive. > -"Синтаксис:\tIF [NOT] EXIST файл команда\n" > +"Синтаксис: IF [NOT] EXIST файл команда\n" > "IF [NOT] \"строка1\"==\"строка2\" команда\n" > "IF [NOT] ERRORLEVEL число команда\n" I believe the last two lines should be indented. > +"[/I] Если конечный каталог отсутствует и копируется более одного файла,\n" > +"местом назначения считается каталог.\n" [...] > +"[/A] Копирует только файлы с атрибутом \"архивный\".\n" > +"[/M] Копирует только файлы с атрибутом \"архивный\",\n" > +"при этом очищает атрибут.\n" > +"[/D | /D:m-d-y] Копирует только новые файлы или файлы, измененные\n" > +"после указанной даты. Если дата не указана, заменяет все старые файлы\n" > +"существующими новыми.\n" This one too could use some extra indentation where the description wraps to the next line. Also it is missing an extra trailing '\n'. > #: wordpad.rc:174 > msgid "inch" > msgstr "inch" Based on your exchange with Nikolay Sivov it sounds like this could be translated. > #: cmd.rc:291 xcopy.rc:40 > msgctxt "Yes key" > msgid "Y" > msgstr "" [...same for 'No key'...] > #: xcopy.rc:35 > msgid "%s? (Yes|No)\n" > -msgstr "" > +msgstr "%s? (Yes (да)|No (нет))\n" I believe this one is a bit ambiguous because it does not make it clear whether to type 'Yes' or 'да' (only the first character counts as the 'Yes key' anyway). My understanding is that the two standard ways to deal with this are: * "(Yes|No)" -> "(да|нет)" and "Y" -> "д" This is used for languages where typing the translated strings presents no special challenge. * "(Yes|No)" -> "(да (Y)|нет (N))" and "Y" -> "Y" If typing the translated strings is cumbersome for some reason (but I guess it's not the case here). In truth this approach is mostly used for accelerators. I guess that's because Alt cannot be combined with characters composed through dead keys or special input methods, and also because it avoids trouble with accelerator collisions in case two translations start with the same letter (like if 'Yes' and 'No' both both translated to words starting with 'C' for instance). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Vote Electronique: Les gens qui votent ne décident rien. Ceux qui comptent les votes décident de tout.

3 4

Re: [PATCH 5/5] vbscript: Added const statement tests
by Marvin 21 Sep '11

21 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14433 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing
by Frédéric Delanoy 21 Sep '11

21 Sep '11

On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > --- > programs/cmd/tests/rsrc.rc | 6 + > programs/cmd/tests/test_cmdline.cmd | 159 ++++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 219 +++++++++++++++++++++++++++++++ > 3 files changed, 384 insertions(+), 0 deletions(-) > create mode 100755 programs/cmd/tests/test_cmdline.cmd > create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp You might want to do a single "@echo off" at the start of the .cmd file. Echoing every command in the .exp isn't very helpful: you don't want to replicate the .cmd contents in the .exp file. Add comments or "subsections" as is done in test_builtins.cmd if necessary, or even better use descriptive results, like e.g. 'text in single quotes' if possible (Also the @ before every rem or echo just add visual clutter IMHO but that's due to the enabled echo mode)

2 3

re: [PATCH 2/9] cmd: use GetCommandline() rather than argv
by Dan Kegel 21 Sep '11

21 Sep '11

Hi Martin, on my i7 machine, your patch series fails every time for me when run normally. Here's the log: ]] ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok ]] ... ]] wine: cannot find L"C:\\windows\\system32\\tell;1;;2.exe" ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 50 (got '0 ', wanted '0@space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 53 (got 'error 9009', wanted '1@space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 59 (got 'error 9009', wanted '1@space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 62 (got 'error 9009', wanted '2@space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 75 (got '"hi"', wanted '"hi"') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 78 (got 'error 9009', wanted '1@space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 81 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 90 (got '1 ', wanted '1@space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 93 (got '0 ', wanted '0@space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 102 (got '3 ', wanted '3@space@') ]] Command exited with non-zero status 10 ]] make: *** [batch.ok] Error 10 ]] make: Target `test' not remade because of errors. When run with WINEDEBUG=warn+heap, it passes. Not sure what to make of that, but something's fishy, and the patch should not go in as is. You might try valgrind to see if it turns anything up. - Dan

3 4

Re: po: Update Russian translation
by Nikolay Sivov 21 Sep '11

21 Sep '11

On 9/20/2011 22:33, Alexander Lakhin wrote: > English strings removed, partial translation fixed too. > #: crypt32.rc:53 cryptdlg.rc:31 > -#, fuzzy > msgctxt "Certification Practice Statement" > msgid "CPS" > -msgstr "CPS" > +msgstr "РУЦ" What does that mean exactly? I didn't find such abbreviation anywhere. > #: jscript.rc:48 > -#, fuzzy > msgid "URI to be decoded is incorrect" > msgstr "URI содержит неверные символы" That's not a translation. > #: oleview.rc:114 > msgid "Ask for an in-process handler when calling CoGetClassObject" > msgstr "" > +"Запросить использование обработчика \"в процессе\" при вызове " > +"CoGetClassObject" "Использовать" is better here IMO, you just don't say the way you translated it. > "\n" > "Например:\n" > " wineconsole cmd\n" > -"Запустить командный процессор Wine в консоли Wine\n" > +"Открывает командное приглашение Wine в консоли Wine.\n" > "\n" This was better before change. > #: wordpad.rc:173 > -#, fuzzy > msgctxt "unit: inch" > msgid "in" > -msgstr "in" > +msgstr "дм" There's no common short name for inch AFAIK, "дм" is used for decimetre. > #: wordpad.rc:175 > -#, fuzzy > msgctxt "unit: point" > msgid "pt" > -msgstr "pt" > +msgstr "пт" I'm not sure about this.

2 1

Re: [PATCH 1/2] include: add a generic class factory template
by Octavian Voicu 20 Sep '11

20 Sep '11

On Tue, Sep 20, 2011 at 4:05 PM, Bernhard Loos <bernhardloos(a)googlemail.com> wrote: > +# define __WINE_GENERIC_CF_DLL_MAIN_CONTENT \ > + return __WINE_PS_ENTRY(DllMain(hInstDll, fdwReason, lpv)); I think __WINE_PS_ENTRY needs only be applied to DllMain, not its argument, so second line should read: + return __WINE_PS_ENTRY(DllMain)(hInstDll, fdwReason, lpv); Octavian

1 0

Daily builds of latest Git now available as Ubuntu packages
by Scott Ritchie 20 Sep '11

20 Sep '11

For an easier user testing experience, you can now install the latest git as a convenient Ubuntu package. The instructions are very similar to using the standard Ubuntu packages, however the PPA name is different. Instead of ppa:ubuntu-wine/ppa, you add ppa:ubuntu-wine/daily. >From a terminal: sudo add-apt-repository ppa:ubuntu-wine/daily sudo apt-get update sudo apt-get install wine1.3 The packages are versioned like wine1.3-1.3.27+daily-20110901. Limitations: The major version number is based on the latest released version of the Ubuntu packages, so on release days you might see something like 1.3.27+daily-20110909 which would actually be equivalent 1.3.28. If I get especially behind and don't update the official packages after Monday, you might even see a "1.3.27+daily" that's actually ahead of 1.3.28. In all cases wine --version should return what it normally does, however - this is just the package revision that is being wonky. Possible future: These packages are a convenient way to run some tests that may be much too slow for testbot to run against every patch, such as autohotkey-based application automation. Thanks, Scott Ritchie

6 9

Re: [PATCH 1/3] shell32: Don't call SendMessage inside critical section
by Alexandre Julliard 20 Sep '11

20 Sep '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -355,24 +351,34 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > if( !notify ) > continue; > > - ptr->pidlSignaled = ILClone(Pidls[0]); > + item = SHAlloc(sizeof(struct notification_recipients)); > + if(!item) { > + ERR("out of memory\n"); > + continue; > + } This one is never freed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] shell32: Be safe against removal of entries in SHChangeNotify
by Piotr Caban 20 Sep '11

20 Sep '11

Hi, On 09/19/11 20:52, André Hentschel wrote: > @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > EnterCriticalSection(&SHELL32_ChangenotifyCS); > > /* loop through the list */ > - LIST_FOR_EACH_ENTRY( ptr,&notifications, NOTIFICATIONLIST, entry ) > + LIST_FOR_EACH_ENTRY_SAFE( ptr, next,&notifications, NOTIFICATIONLIST, entry ) The function should not call SendMessage inside critical section. Cheers, Piotr

1 0

Re: [PATCH 4/5] vbscript: Added more tests
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14413 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/5] vbscript: Added support for short if statements
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14412 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] vbscript: Added support for rem statement-like comments
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14411 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] vbscript: Added support for ':' as statement separator
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14410 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [PATCH 1/3 try2] wshom.ocx: Added WshShell class factory implementation
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14406 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

re: [PATCH 1/3] wshom.ocx: Added WshShell class factory implementation
by Dan Kegel 20 Sep '11

20 Sep '11

build failed here? ../../tools/makedep -C. -S../.. -T../.. shell.c wshom_main.c wshom.rc wshom.idl wshom.idl wshom.tlb wshom_private.h: No such file or directory wshom_private.h was first included from shell.c:19 make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/wshom.ocx' make: *** [dlls/wshom.ocx/__depend__] Error 2 make: *** Waiting for unfinished jobs....

2 1

Re: msi: Print the string and not the pointer in a TRACE.
by Hans Leidekker 20 Sep '11

20 Sep '11

On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder, > awstring str; > UINT r; > > - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); > + TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); szPathBuf is an output buffer.

2 2

Re: [1/2] d3dx9: Implemented D3DXWeldVertices.
by Michael Mc Donnell 20 Sep '11

20 Sep '11

Hi Alexandre My D3DXWeldVertices patch set (see [1] and [2]) scrolled of the patches list . It has been reviewed by Stefan and others on wine-devel, so it should be ok. Do you see anything wrong with it? Should I resend it? Thanks, Michael Mc Donnell [1] http://www.winehq.org/pipermail/wine-patches/2011-August/105423.html [2] http://www.winehq.org/pipermail/wine-patches/2011-August/105422.html

1 0

Re: [PATCH 9/9] cmd/tests: adapt TODOs in test output (parameter passing)
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14400 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1@space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0@space@@or_broken@3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+@space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@')

1 0

Re: [PATCH 7/9] cmd/tests: adapt TODOs in test output (special characters)
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14399 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1@space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0@space@@or_broken@3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+@space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@')

1 0

Re: [PATCH 5/9] cmd/tests: fix TODOs in test output (quotes)
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14398 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1@space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0@space@@or_broken@3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+@space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

1 0

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14397 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1@space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0@space@@or_broken@3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+@space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

1 0

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing
by Marvin 20 Sep '11

20 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14396 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1@space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0@space@@or_broken@3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3@space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2@space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1@space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '0@space@') batch.c:298: Test failed: excess characters on line 135 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+@space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0@space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2@space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0@space@')

1 0

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())
by Frédéric Delanoy 19 Sep '11

19 Sep '11

On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: > Fix output after "cmd: use GetCommandline() rather than argv" patch. > This also fixes the test case where Wine would hang. Having path P1 fixing issue and P2 changing .cmd/.exp is wrong. Testsuite has to pass after every patch committed. The normal procedure is: P1 (add tests); P2 (add fixes + update results) In cases it's not possible, you may merge the two patches in a single patch

1 0

Something's rotten in git today...
by Dan Kegel 19 Sep '11

19 Sep '11

It might be just me, but I've seen five very strange test failures today out of about 30 build/test runs. Has anybody else noticed problems? Here they are, most recent first: ==== http://buildbot.kegel.com/builders/runtests-default/builds/72 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok err:rpc:I_RpcGetBuffer no binding err:rpc:I_RpcGetBuffer no binding service.c:152: Test failed: Expected success, got error 1060 err:rpc:I_RpcGetBuffer no binding service.c:176: Test failed: Expected ERROR_SERVICE_DOES_NOT_EXIST, got 123 ... ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\removeme\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:946: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffffffffffff, err=2, should be 0 ... ==== http://buildbot.kegel.com/builders/runtests-default/builds/70 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist make: *** [action.ok] Error 1 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:5393: Test failed: Directory not created ... make: *** [install.ok] Error 8 ==== http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/68 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok ... service.c:2084: Test failed: Winetest Sleep Service: QueryServiceStatusEx() failed le=1727 service.c:2085: Test failed: Winetest Sleep Service: should be stopped state=ff service.c:2092: Test failed: Winetest Sleep Service: the second try should yield the same error: 1728 != 1727 service.c:2098: Test failed: Winetest Sleep Service: 1727 != ERROR_SERVICE_NOT_ACTIVE service.c:2099: Test failed: Winetest Sleep Service: should be stopped state=deadbeef service.c:2188: Test failed: 1728 != ERROR_SERVICE_REQUEST_TIMEOUT service.c:2223: Test failed: Expected success, got error 6 ... make: *** [service.ok] Error 20 ==== http://buildbot.kegel.com/builders/runtests-default/builds/67 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist

6 8

Re: Old imagehlp patches
by Juan Lang 19 Sep '11

19 Sep '11

Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) > I don't know about wine development, but are these patches still likely to > work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're much too large to be merged at a single go, they lack tests, and they should be sent by their original author. I wouldn't hold your breath expecting these patches to go in as-is: if they weren't good enough in 2004-5, they're not any better now. You'd want someone who has an active interest in this area to have a go at them, I believe, unless you can convince the original author to take them up again. --Juan

3 2

Re: comctl32: Don't crash when getting a bad image list handle. (try 2)
by Nikolay Sivov 19 Sep '11

19 Sep '11

On 9/19/2011 17:32, Francois Gouget wrote: > --- > > Don't return from inside the block this time. > > dlls/comctl32/imagelist.c | 13 ++++++++++++- > dlls/comctl32/tests/imagelist.c | 17 +++++++++++++++-- > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c > index ec62370..83b8b44 100644 > --- a/dlls/comctl32/imagelist.c > +++ b/dlls/comctl32/imagelist.c > @@ -54,6 +54,7 @@ > #include "commoncontrols.h" > #include "imagelist.h" > #include "wine/debug.h" > +#include "wine/exception.h" > > WINE_DEFAULT_DEBUG_CHANNEL(imagelist); > > @@ -3587,7 +3588,17 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + BOOL valid; > + __TRY > + { > + valid = himl&& himl->lpVtbl ==&ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + valid = FALSE; > + } > + __ENDTRY > + return valid; > } Maybe use IsBadReadPtr() with sizeof(void*) is better? You need only vtable pointer to be accessible.

3 3

re: mscoree: Add .Net debugging interfaces
by Dan Kegel 19 Sep '11

19 Sep '11

Doesn't apply here: $ wget http://source.winehq.org/patches/data/79041 $ git reset --hard origin $ patch -p1 < 79041 patching file include/Makefile.in patching file include/cordebug.idl patch: **** malformed patch at line 998: -- $ git reset --hard origin $ git apply 79041 79041:99: trailing whitespace. interface ICorDebugValueBreakpoint; fatal: corrupt patch at line 999

1 0

Ole16 to Ole32 mapping
by Bruno Jesus 19 Sep '11

19 Sep '11

Hi, I would like some advice about Ole function redirection. The winsock16 dll maps some operations to ws2_32 dll, I thought I could do the same with Ole16disp to Oleaut32. For example the function SAFEARRAYALLOCDESCRIPTOR in Ole16disp have a similar counterpart named SafeArrayAllocDescriptor in Oleaut32. There are dozens of functions like this if you look in the spec files of these dlls. I added oleaut32 to the imports and started mapping by making one line functions, for example SAFEARRAYALLOCDESCRIPTOR simply return calling SafeArrayAllocDescriptor from Ole32. Is it ok to do it like this? I implemented SafeArrayAlloc[Descriptor/Data] and SafeArrayDestroy[Descriptor/Data] and they seem to be working, then I started implementing some of the others and testing with the application winverbs from bug #28113. Is there any msdn documentation like to these old functions? I would like to compare the function parameters in some cases. Thanks in advance, Bruno -- universe* god::bigbang (void); //and then it all began...

3 2

Re: [po]updated korean resource(2011-09-19)
by Francois Gouget 19 Sep '11

19 Sep '11

msgstr "" +"Wine is free software; you can redistribute it and/or modify it under the " +"terms of the GNU Lesser General Public License as published by the Free " +"Software Foundation; either version 2.1 of the License, or (at your option) " +"any later version.\n" +"\n" +"Wine is distributed in the hope that it will be useful, but WITHOUT ANY " +"WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS " +"FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for " +"more details.\n" +"\n" +"You should have received a copy of the GNU Lesser General Public License " +"along with Wine; if not, write to the Free Software Foundation, Inc., 51 " +"Franklin St, Fifth Floor, Boston, MA 02110-1301, USA." This is not a translation so I don't think it should be put in the PO file[1]. Copying the English string is not needed by Wine and it will only make it less likely that a proper translation is provided later. [1] Also Korean is not an RTL language so the 'Hebrew' exception does not apply<g>. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

Re: [PATCH 16/17] vbscript: Added interp_me implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14384 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 14/17] vbscript: Added support for SCRIPTITEM_ISVISIBLE named items
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14383 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/17] vbscript: Added error object stub implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14382 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/17] vbscript: Added is expression implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14380 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: vbscript: Make vbdisp_get_id() static.
by Jacek Caban 19 Sep '11

19 Sep '11

Hi Francois, On 09/18/11 19:37, Francois Gouget wrote: > --- > dlls/vbscript/vbdisp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c > index 14fb8b0..db1c864 100644 > --- a/dlls/vbscript/vbdisp.c > +++ b/dlls/vbscript/vbdisp.c > @@ -52,7 +52,7 @@ static BOOL get_func_id(vbdisp_t *This, const WCHAR *name, vbdisp_invoke_type_t > return FALSE; > } > > -HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > +static HRESULT vbdisp_get_id(vbdisp_t *This, BSTR name, vbdisp_invoke_type_t invoke_type, BOOL search_private, DISPID *id) > { > unsigned i; Good catch, but my recent patch series needs it being non-static. Jacek

1 0

Re: [PATCH 05/17] vbscript: Added interp_lteq implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14379 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 04/17] vbscript: Added interp_lt implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14378 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 03/17] vbscript: Added interp_gt implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14377 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/17] vbscript: Added interp_gteq implementation
by Marvin 19 Sep '11

19 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14376 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: comctl32: Don't crash when getting a bad image list handle.
by Alexandre Julliard 19 Sep '11

19 Sep '11

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -3587,7 +3588,15 @@ static const IImageListVtbl ImageListImpl_Vtbl = { > > static inline BOOL is_valid(HIMAGELIST himl) > { > - return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + __TRY > + { > + return himl && himl->lpVtbl == &ImageListImpl_Vtbl; > + } > + __EXCEPT_PAGE_FAULT > + { > + return FALSE; > + } > + __ENDTRY You can't return from a __TRY block. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.
by Jacek Caban 18 Sep '11

18 Sep '11

On 09/16/11 15:25, Francois Gouget wrote: > --- > > This fixes this test on the WNT4WSSP6 testbot machine. > It also helps on my NT4 VM but one would not notice because there's no > ieframes dll so WineTest does not even try to run this test! > > dlls/ieframe/tests/webbrowser.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c > index a36c134..0506be6 100644 > --- a/dlls/ieframe/tests/webbrowser.c > +++ b/dlls/ieframe/tests/webbrowser.c > @@ -212,7 +212,10 @@ static HRESULT _create_WebBrowser(unsigned line, IUnknown **unk) > > hres = CoCreateInstance(&CLSID_WebBrowser, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > &IID_IUnknown, (void**)unk); > - ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > + if (hres == REGDB_E_CLASSNOTREG) > + win_skip_(__FILE__,line)("WebBrowser is not supported\n"); > + else > + ok_(__FILE__,line)(hres == S_OK, "Creating WebBrowser object failed: %08x\n", hres); > return hres; > } The failure is valid here, it's the testbot that is not smart enough. The tested DLL is not present on WINNT, so the test should be skipped automatically, like winetest does. Jacek

2 3

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3)
by Marvin 18 Sep '11

18 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14371 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

re: msxml3: Fix printing NULL strings
by Dan Kegel 18 Sep '11

18 Sep '11

Hi Francois, your patch has a signedness problem which makes -Werror unhappy. (We could disable signedness warnings, but since we don't currently have any, it's nice to keep them out of the tree...) Here's the log from the buildbot: $ ccache gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o element.o element.c cc1: warnings being treated as errors element.c: In function ‘variant_from_dt’: element.c:666: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘element_get_dt’: element.c:732: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_nodeTypedValue’: element.c:789: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ element.c: In function ‘domelem_put_dataType’: element.c:937: error: pointer targets in passing argument 1 of ‘debugstr_a’ differ in signedness ../../include/wine/debug.h:259: note: expected ‘const char *’ but argument is of type ‘const xmlChar *’ make[1]: Leaving directory `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/msxml3' make[1]: *** [element.o] Error 1 make: *** [dlls/msxml3] Error 2

2 1

Re: quartz/tests: Skip some tests if not allowed to register filters.
by Marvin 18 Sep '11

18 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14367 Your paranoid android. === WNT4WSSP6 (32 bit filtermapper) === filtermapper.c:93: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:230: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:344: Test failed: CoCreateInstance failed with 80040154 filtermapper.c:402: Test failed: CoCreateInstance failed with 80040154

2 1

Re: shell32: Don't dereference NULL pointers when tracing.
by Octavian Voicu 18 Sep '11

18 Sep '11

On Sun, Sep 18, 2011 at 8:37 PM, Francois Gouget <fgouget(a)free.fr> wrote: > + TRACE("-- vmode %#x, flags %#x", view_params->pfs->ViewMode, view_params->pfs->fFlags); > + if (view_params->prcView) > + TRACE(", left %d, top %d, right %d, bottom %d", view_params->prcView->left, > + view_params->prcView->top, view_params->prcView->right, view_params->prcView->bottom); > + TRACE("\n"); I think it would look much nicer with wine_dbgstr_rect and it can handle NULL pointers. Octavian

1 0

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)
by Dan Kegel 18 Sep '11

18 Sep '11

2011/9/18 Dan Kegel <dank(a)kegel.com>: > Don't let this one languish - it makes a huge difference for me! I should mention: with your latest additions to the cmd tests, time to run the cmd tests is starting to go off the cliff, and is now above four minutes... but with your efficiency patch, it only takes four seconds.

3 2

Unimplemented function?
by Luis Carlos Busquets Pérez 18 Sep '11

18 Sep '11

It seems that there is a regression in wine 1.3.28. Before bi-secting, I woul dlike to understand how that can happen. Apparently PlaChessV5.exe crashes due to: wine: Call from 0x68215ca8 to unimplemented function msvcrt.dll._snwprintf_s, aborting but when I look at the spec file, the function is defined: @ varargs _snwprintf_s(ptr long long wstr) MSVCRT__snwprintf_s and it exists in wcs.c How is it that them it results as undefined? Luis

2 2

Creating register Resource.
by Alistair Leslie-Hughes 18 Sep '11

18 Sep '11

Hi, I'm attempting to create a RES file from the xmlparser.idl file. After I modify the Makefile with IDL_R_SRCS = xmlparser.idl The .res file is created, but no register information is generated. Have I missed something? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 17/19] vbscript: Added support for exit do statement
by Octavian Voicu 18 Sep '11

18 Sep '11

On Fri, Sep 16, 2011 at 2:30 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/vbscript/compile.c > +++ b/dlls/vbscript/compile.c > static HRESULT compile_while_statement(compile_ctx_t *ctx, while_statement_t *stat) > { > - unsigned start_addr; > + unsigned start_addr, prev_label; ... > + if(stat->stat.type != STAT_WHILE) { > + prev_label = ctx->while_end_label; > + if((ctx->while_end_label = alloc_label(ctx)) == -1) > + return E_OUTOFMEMORY; > + } ... > + if(stat->stat.type != STAT_WHILE) { > + label_set_addr(ctx, ctx->while_end_label); > + ctx->while_end_label = prev_label; > + } Hello, This patch introduces a compile warning (gcc 4.5.2, both x86 and amd64): ../compile.c:489:26: warning: ‘prev_label’ may be used uninitialized in this function While I can see there's no actual problem, how can we shut the compiler's mouth? It may even be the case that if we just put a prev_label = 0 initializer, static analyzers will start complaining it's a useless assignment. Octavian

1 0

re: Where is the best place to report a fscanf bug found under wine-1.3.27?
by Dan Kegel 18 Sep '11

18 Sep '11

> Today I discovered .. that the scanf family of functions was > introducing float (32-bit floating-point) noise into double (64-bit > floating-point) results. I see it here, too: $ sudo apt-get install mingw32 $ i586-mingw32msvc-gcc test_fscanf.c $ echo "1.1e+01 1.1e+00 1.1e-01 1.1e-02 1.1e-03 1.1e-04" | ~/wine-git/wine a.exe 1.10000000000000000e+001 1.10000000000000009e+000 1.10000001639127737e-001 1.10000003278255491e-002 1.10000004917383261e-003 1.10000006556511075e-004 You can work around it with 'winetricks vcrun6', after which the test program outputs: 1.10000000000000000e+001 1.10000000000000010e+000 1.10000000000000000e-001 1.09999999999999990e-002 1.10000000000000010e-003 1.10000000000000000e-004 So the problem is in wine's msvcrt.dll. You could narrow it down further by printing out the raw byte strings for the numbers and then sprinking that printout through the path from when scanf is called to where printf returns. (Or, I suppose, step through it with a debugger instead.) But the best place to report the bug is http://bugs.winehq.org - Dan

2 2

Re: [po]updated korean resource(2011-09-16)
by Francois Gouget 17 Sep '11

17 Sep '11

> #: attrib.rc:47 > -#, fuzzy > msgid "" > "ATTRIB - Displays or changes file attributes.\n" > "\n" The reason why this one was fuzzy is that the indentation changed. However the translation's indentation has not be updated (which might possibly be ok for Korean), and it also seems to be pretty inconsistent (e.g. between the +/- lines and the R/A/etc ones. Also the '[drive:]' should probably really be indented. #: cmd.rc:288 -#, fuzzy msgid "" "CMD built-in commands are:\n" "ASSOC\t\tShow or modify file extension associations\n" The translation is missing the XCOPY line (it's hard to spot in the middle of all these lines). Maybe I should add translator comments when I mark a translation as fuzzy. This way the real translator would not have to puzzle over what caused the string to be marked as fuzzy. I have not been doing it because I worry they may be tricky to remove with some PO editors (but maybe my fears are unfounded). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

1 0

re: Severe startup latencies for Windows applications run under wine
by Dan Kegel 17 Sep '11

17 Sep '11

Try oprofile instead. ( A really old intro is at http://www.winehq.org/wwn/249#oprofile%20&%20Wine )

4 4

Proof of concept - The crashbot
by Bruno Jesus 17 Sep '11

17 Sep '11

Hi, I would like your opinion about a project I may start based on BuildBot (if the Dan/license allows). It's named crashbot because it's intended to automate testing of applications that crash in wine. The main goal is reduce the amount of time wasted on retesting bugzilla applications that authors abandoned. It's intented to be as easy as this: 1 - Add a new application by setting it's name, bug number and direct download url; 2 - Add requirements to run using winetricks; 3 - Set the test schedule (interval in days/weeks between repetitions); 4 - See the results in a web page which will automatically update; 5 - Auto send an email if the application starts successfully. The crashbot will run in a tmpfs to avoid disk burning and will ever run applications in a clean prefix. It would extract the downloaded program if necessary. Wine would be recompiled daily based on latest git. In the future I would like to add support to some sort of window scripting with keyboard and mouse input so it can be used not only to test startup crashs but any other kind of test (including the program installation before run). I'm not targeting it to test games for now because it would run in a very basic computer with an embedded video board. Thanks in advance and apologies if this already exists or was discussed previously. Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

4 3

amd processors seem slow at running configure?
by Dan Kegel 17 Sep '11

17 Sep '11

My new AMD a8-3850 takes 77 seconds to run wine's configure script. (Using -C cuts the time by 40 seconds.) Austin's Phenom II X4 940 takes 61 seconds. My i7 takes 32 seconds... but even the lowly e7300 only takes 38 seconds. The same seems to hold for doing builds with ccache; AMD fares poorly there somehow compared to similar intel chips. Does anyone have an AMD-based system that can run configure in under 40 seconds?

5 6

re: Proof of concept - The crashbot
by Dan Kegel 16 Sep '11

16 Sep '11

Hi Bruno, it would of course be great. Check out http://code.google.com/p/winetricks/source/browse/trunk/tests/winetricks-te… for starters, we could just run that (or a subset of it) daily. It's fairly reliable, as I ran it manually every week for a while and weeded out a lot of flaky bits. When I get a chance, I'll try integrating that into buildbot. - Dan p.s. As Henri mentioned, it's been on people's minds for years. The graveyard is littered with previous attempts, e.g. http://web.archive.org/web/20070209153523/http://www.cxtest.org/ I think it's important to do the easy part first and not do anything fancy.

2 1

"make test" redux 2
by Dan Kegel 16 Sep '11

16 Sep '11

Wine's test suite is now nine years old, and thanks in large part to Ge's testbot, new tests tend to actually work on windows. There's a lot of passing tests at http://test.winehq.org, which is awesome. Wine developers routinely use it to avoid sending bad patches. And yet, some bad patches do get sent. Running all the incoming patches from wine-patches though the reliable subset of the tests automatically has been finding about one real bug a day. Sometimes I can warn the author soon enough that he can send a revised patch before the bad one is committed. Automated testing ftw! But sometimes bad patches don't fail during the few test runs currently done, get committed, and then start causing unrelated patches to fail randomly, poisoning future test runs until it the bug is fixed or the bad patch reverted. It would be nice if Alexandre reverted bad patches as soon as the buildbot started going red, without waiting for his usual daily batch of commits, and without waiting for someone to fix the bad patch. (Maybe this can be discussed at wineconf.) Right, so that's the story for keeping new bugs out of the tree. And then there are all the old bugs. Getting them fixed sometime would be nice; until then, the buildbot just skips known bad tests. Here are the tests that fail or crash sometimes for me when run normally on 32 bit systems. (This list is a lot bigger than the one I posted back in 2009, mostly because I'm running the tests a lot more, and noticing ones that only fail occasionally.) http://bugs.winehq.org/show_bug.cgi?id=28301 dlls/ddraw/tests/visual.ok http://bugs.winehq.org/show_bug.cgi?id=28257 dlls/kernel32/tests/pipe.ok http://bugs.winehq.org/show_bug.cgi?id=28220 dlls/kernel32/tests/process.ok http://bugs.winehq.org/show_bug.cgi?id=28295 dlls/mshtml/tests/htmldoc.ok http://bugs.winehq.org/show_bug.cgi?id=28290 dlls/shell32/tests/shelllink.ok http://bugs.winehq.org/show_bug.cgi?id=28323 dlls/urlmon/tests/protocol.ok http://bugs.winehq.org/show_bug.cgi?id=28108 dlls/urlmon/tests/url.ok http://bugs.winehq.org/show_bug.cgi?id=20149 dlls/user32/tests/static.ok http://bugs.winehq.org/show_bug.cgi?id=28038 dlls/wininet/tests/urlcache.ok http://bugs.winehq.org/show_bug.cgi?id=28102 dlls/ws2_32/tests/sock.ok And another handful that fail or crash sometimes for me when run with WINEDEBUG=warn+heap: http://bugs.winehq.org/show_bug.cgi?id=28260 dlls/dsound/tests/ds3d8.ok http://bugs.winehq.org/show_bug.cgi?id=28260 dlls/dsound/tests/ds3d.ok http://bugs.winehq.org/show_bug.cgi?id=28316 dlls/kernel32/tests/debugger.ok http://bugs.winehq.org/show_bug.cgi?id=28257 dlls/kernel32/tests/pipe.ok http://bugs.winehq.org/show_bug.cgi?id=28262 dlls/mshtml/tests/style.ok http://bugs.winehq.org/show_bug.cgi?id=28258 programs/cmd/tests/batch.ok There are also tests I don't run on the buildbot because they only pass on other systems with particular window managers or sound hardware or software: http://bugs.winehq.org/show_bug.cgi?id=8668 dlls/dsound/tests/ds3d8.ok http://bugs.winehq.org/show_bug.cgi?id=8668 dlls/dsound/tests/ds3d.ok http://bugs.winehq.org/show_bug.cgi?id=8668 dlls/dsound/tests/dsound8.ok http://bugs.winehq.org/show_bug.cgi?id=8668 dlls/dsound/tests/dsound.ok http://bugs.winehq.org/show_bug.cgi?id=28216 dlls/shell32/tests/shlfolder.ok http://bugs.winehq.org/show_bug.cgi?id=12053 dlls/user32/tests/input.ok http://bugs.winehq.org/show_bug.cgi?id=12053 dlls/user32/tests/msg.ok http://bugs.winehq.org/show_bug.cgi?id=12053 dlls/user32/tests/win.ok http://bugs.winehq.org/show_bug.cgi?id=28267 dlls/winhttp/tests/winhttp.ok http://bugs.winehq.org/show_bug.cgi?id=28109 dlls/winmm/tests/capture.ok http://bugs.winehq.org/show_bug.cgi?id=28071 dlls/winmm/tests/mci.ok http://bugs.winehq.org/show_bug.cgi?id=28048 dlls/winmm/tests/wave.ok More info at http://wiki.winehq.org/BuildBot - Dan

3 4

re: [2/3] pdh/tests: Make the test pass on Windows 2000.
by Dan Kegel 16 Sep '11

16 Sep '11

Build fails here? ccache gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o propsys.o propsys.c pdh.c: In function ‘test_PdhAddCounterA’: pdh.c:134: error: ‘PDH_INVALID_PATH’ undeclared (first use in this function) pdh.c:134: error: (Each undeclared identifier is reported only once pdh.c:134: error: for each function it appears in.) pdh.c: In function ‘test_PdhAddCounterW’: pdh.c:183: error: ‘PDH_INVALID_PATH’ undeclared (first use in this function) ../../../tools/make_ctests -o testlist.c propsys.c make[1]: *** [pdh.o] Error 1

2 1

Re: ieframe/tests: Some tests require that the user interface be in English. (resend)
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14330 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3070: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3070: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3070: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3070: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3146: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2463: Test failed: expected GetOverridesKeyPath webbrowser.c:2467: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2468: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2077: Test failed: put_Resizable failed: 80004001 webbrowser.c:2078: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2082: Test failed: put_Resizable failed: 80004001 webbrowser.c:2083: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2463: Test failed: expected GetOverridesKeyPath webbrowser.c:2467: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2468: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:402: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2077: Test failed: put_Resizable failed: 80004001 webbrowser.c:2078: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2082: Test failed: put_Resizable failed: 80004001 webbrowser.c:2083: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2463: Test failed: expected GetOverridesKeyPath webbrowser.c:2467: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2468: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:455: Test failed: unexpected nCmdID 29 webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:2613: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2733: Test failed: expected TranslateUrl webbrowser.c:2734: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2735: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2741: Test failed: ReadyState = 1, expected 4 webbrowser.c:2565: Test failed: ReadyState = 1, expected 4 webbrowser.c:785: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:801: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:808: Test failed: ReadyState = 1, expected 4 webbrowser.c:600: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:600: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:607: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1503: Test failed: unexpected call GetOptionKeyPath webbrowser.c:351: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:785: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:785: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:785: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:785: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:455: Test failed: unexpected nCmdID 26 webbrowser.c:455: Test failed: unexpected nCmdID 29 webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:886: Test failed: ReadyState = 1, expected 4 webbrowser.c:1514: Test failed: unexpected call GetDropTarget webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:2613: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3106: Test failed: doc != doc2 webbrowser.c:600: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:600: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:607: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1503: Test failed: unexpected call GetOptionKeyPath webbrowser.c:351: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:455: Test failed: unexpected nCmdID 26 webbrowser.c:455: Test failed: unexpected nCmdID 29 webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:1514: Test failed: unexpected call GetDropTarget webbrowser.c:953: Test failed: unexpected call GetContainer webbrowser.c:503: Test failed: unexpected call webbrowser.c:2606: Test failed: expected TranslateUrl webbrowser.c:2613: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2826: Test failed: expected RequestUIActivate webbrowser.c:2918: Test failed: Got 0x80004002 webbrowser.c:3113: Test failed: doc != doc2 webbrowser.c:3013: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: ieframe/tests: Don't crash if IWebBrowser2_get_LocationURL() fails.
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14329 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3049: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3049: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3049: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3049: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3125: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2056: Test failed: put_Resizable failed: 80004001 webbrowser.c:2057: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2061: Test failed: put_Resizable failed: 80004001 webbrowser.c:2062: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:381: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2056: Test failed: put_Resizable failed: 80004001 webbrowser.c:2057: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2061: Test failed: put_Resizable failed: 80004001 webbrowser.c:2062: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2712: Test failed: expected TranslateUrl webbrowser.c:2713: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2714: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2720: Test failed: ReadyState = 1, expected 4 webbrowser.c:2544: Test failed: ReadyState = 1, expected 4 webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:780: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:787: Test failed: ReadyState = 1, expected 4 webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:582: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:586: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:590: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1482: Test failed: unexpected call GetOptionKeyPath webbrowser.c:330: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:434: Test failed: unexpected nCmdID 26 webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:865: Test failed: ReadyState = 1, expected 4 webbrowser.c:1493: Test failed: unexpected call GetDropTarget webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3085: Test failed: doc != doc2 webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:582: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:586: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:590: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1482: Test failed: unexpected call GetOptionKeyPath webbrowser.c:330: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:434: Test failed: unexpected nCmdID 26 webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:1493: Test failed: unexpected call GetDropTarget webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2585: Test failed: expected TranslateUrl webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2805: Test failed: expected RequestUIActivate webbrowser.c:2897: Test failed: Got 0x80004002 webbrowser.c:3092: Test failed: doc != doc2 webbrowser.c:2992: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: ieframe/tests: Skip some tests on Windows if WebBrowser is not supported.
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14328 Your paranoid android. === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2056: Test failed: put_Resizable failed: 80004001 webbrowser.c:2057: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2061: Test failed: put_Resizable failed: 80004001 webbrowser.c:2062: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:381: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2056: Test failed: put_Resizable failed: 80004001 webbrowser.c:2057: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2061: Test failed: put_Resizable failed: 80004001 webbrowser.c:2062: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2442: Test failed: expected GetOverridesKeyPath webbrowser.c:2446: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2447: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2712: Test failed: expected TranslateUrl webbrowser.c:2713: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2714: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2720: Test failed: ReadyState = 1, expected 4 webbrowser.c:2544: Test failed: ReadyState = 1, expected 4 webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:780: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:787: Test failed: ReadyState = 1, expected 4 webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:582: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:586: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:590: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1482: Test failed: unexpected call GetOptionKeyPath webbrowser.c:330: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:764: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:434: Test failed: unexpected nCmdID 26 webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:865: Test failed: ReadyState = 1, expected 4 webbrowser.c:1493: Test failed: unexpected call GetDropTarget webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3085: Test failed: doc != doc2 webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:582: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:586: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:590: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1482: Test failed: unexpected call GetOptionKeyPath webbrowser.c:330: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:434: Test failed: unexpected nCmdID 26 webbrowser.c:434: Test failed: unexpected nCmdID 29 webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:1493: Test failed: unexpected call GetDropTarget webbrowser.c:932: Test failed: unexpected call GetContainer webbrowser.c:482: Test failed: unexpected call webbrowser.c:2585: Test failed: expected TranslateUrl webbrowser.c:2592: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2805: Test failed: expected RequestUIActivate webbrowser.c:2897: Test failed: Got 0x80004002 webbrowser.c:3092: Test failed: doc != doc2 webbrowser.c:2992: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9E2

1 0

Re: [PATCH 19/19] vbscript: Added do..while and do..until statements implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14325 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 18/19] vbscript: Added do until..loop statement implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14324 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 17/19] vbscript: Added support for exit do statement
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14323 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 16/19] vbscript: Added do while..loop statement implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14322 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 15/19] vbscript: Added while..wend statement implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14321 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/19] vbscript: Added class_terminate support
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14319 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/19] vbscript: Added class_initializer support
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14317 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/19 try2] vbscript: Added class functions parser implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14318 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 10/19] vbscript: Use default object value for objets in stack_pop_val
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14315 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 09/19] vbscript: Added support for default getters
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14314 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/19] vbscript: Added interp_set_member implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14313 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/19] vbscript: Added support for exit property statement
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14312 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/19] vbscript: Added compiler/runtime support for property getters/letters
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14311 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 05/19] vbscript: Added getters/setters parser implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14310 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 01/19] vbscript: Added class property parser implementation
by Marvin 16 Sep '11

16 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14307 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 2/5] ddraw: Use offscreen backbuffers.
by Stefan Dösinger 16 Sep '11

16 Sep '11

On Thursday 15 September 2011 20:01:50 Henri Verbeet wrote: > In principle this allows us to use more than one backbuffer in ddraw. It's > also a requirement for the next patch. I think this, and the next patch should be implemented in wined3d by handling D3DSWAPEFFECT_FLIP in essentially the same way you're handling them in ddraw in your patches. d3d8 and d3d9 apps can request multiple backbuffers and access them explicitly just like ddraw apps can. In patch 3 I'm not sure what happens when the app draws to the frontbuffer directly. Maybe I'm a bit too tired to see it, but doesn't that result in a blit of the surface onto itself?

2 3

ubuntu ppa -- nice to have on development version too
by Susan Cragin 16 Sep '11

16 Sep '11

There was discussion about putting a daily wine build on the ubuntu ppa. I'd like to put in a word for having it on the development version (currently oneiric) as well as the stable version (natty). Right now wine only seems to have a natty ppa.

2 2

Re: [PATCH] rpcrt4/rpc_transport.c: the named pipe can be used for multiple operations at the same time, so use overlapped operations for ReadFile and WriteFile
by Jérôme Gardou 15 Sep '11

15 Sep '11

Le 14/09/2011 14:19, Bernhard Loos a écrit : > --- > dlls/rpcrt4/rpc_transport.c | 53 +++++++++++++++++++++++------------------- > 1 files changed, 29 insertions(+), 24 deletions(-) > > Hi! I had a quite similar patch, but you beat me! Anyway, aren't those funtions susceptible to be called in a multithreaded environment? If so, having an unique event for all the read or write operations seems dangerous to me. Regards. Jérôme.

1 0

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length
by Bernhard Loos 15 Sep '11

15 Sep '11

On Thu, Sep 15, 2011 at 08:28:53AM, Marcus Meissner wrote: > On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote: > > --- > > dlls/oleaut32/olepicture.c | 148 +++++++++++++------------------------- > > dlls/oleaut32/tests/olepicture.c | 16 ++--- > > 2 files changed, 54 insertions(+), 110 deletions(-) > > Did make check work for you even? Marvin does not like it at least. > > This will break NonStatable streams, also seekability of streams can > not be assumed. > > Ciao, Marcus Windows never calls Stat on the stream, and it bails out, if Seek doesn't work, it certainly never reads until the end of the stream. Thats at least what happens on XP. This only breaks on jpeg images, so I suspect the difference is in the actual image rendering code. Wine always reads the complete image into memory and then creates the image from this memory buffer with IWICStream_InitializeFromMemory for example, while windows probably calls IWICStream_InitializeFromIStream. And this method reads a 4096 bytes chunk at first and depends on Read checking for the end of the stream. Bernhard

1 0

Re: msxml3: Move and Register xmlparser.idl in msxml3
by Austin English 15 Sep '11

15 Sep '11

On Thu, Sep 15, 2011 at 07:35, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > msxml3: Move and Register xmlparser.idl in msxml3 > > > Best Regards > Alistair Leslie-Hughes Howdy Alistair, You forgot to remove the include from include/Makefile.in, causing a build failure here: make[1]: Entering directory `/home/austin/wine-git/include' ../tools/makedep -C. -S.. -T.. activaut.idl activdbg.idl activscp.idl amstream.idl amvideo.idl asptlb.idl atliface.idl audioclient.idl audiopolicy.idl austream.idl bits.idl bits1_5.idl comcat.idl commoncontrols.idl control.idl cor.idl ctfutb.idl ctxtcall.idl d3d10.idl d3d10_1.idl d3d11.idl d3dcommon.idl ddstream.idl devicetopology.idl dimm.idl dispex.idl docobj.idl docobjectservice.idl downloadmgr.idl dxgi.idl endpointvolume.idl exdisp.idl fusion.idl gameux.idl hlink.idl htiframe.idl httprequest.idl iads.idl icftypes.idl iextag.idl imnact.idl imnxport.idl indexsrv.idl mediaobj.idl metahost.idl mimeinfo.idl mimeole.idl mlang.idl mmdeviceapi.idl mmstream.idl mscoree.idl msctf.idl msdadc.idl mshtmhst.idl mshtml.idl msinkaut.idl mstask.idl msxml.idl msxml2.idl msxml6.idl netcon.idl netfw.idl oaidl.idl objectarray.idl objidl.idl objsafe.idl ocidl.idl ocmm.idl oleacc.idl oledb.idl oleidl.idl optary.idl perhist.idl propidl.idl propsys.idl pstore.idl qedit.idl richole.idl sensevts.idl servprov.idl shdeprecated.idl shldisp.idl shobjidl.idl shtypes.idl strmif.idl structuredquerycondition.idl textstor.idl tom.idl unknwn.idl urlhist.idl urlmon.idl vmr9.idl wbemcli.idl wia_lh.idl wia_xp.idl wincodec.idl wine/itss.idl wine/svcctl.idl winsxs.idl wpcapi.idl wtypes.idl wuapi.idl xmllite.idl xmlparser.idl wine/winedxgi.idl stdole2.idl stdole2.tlb xmlparser.idl: No such file or directory make[1]: *** [depend] Error 1 make[1]: Leaving directory `/home/austin/wine-git/include' -- -Austin

1 0

re: [PATCH 13/19] vbscript: Added class functions parser implementation
by Dan Kegel 15 Sep '11

15 Sep '11

Fails here under WINEDEBUG=warn-heap: ../../../tools/runtest -q -P wine -M vbscript.dll -T ../../.. -p vbscript_test.exe.so run.c && touch run.ok wine: Unhandled page fault on read access to 0x55555555 at address 0x4004c1e4 (thread 0019), starting debugger... Backtrace: =>0 0x4004c1e4 add_class_function+0x29(ctx=0x33fad8, class_decl=0x151dd4, decl=0x151dbc) [dlls/vbscript/parser.y:638] 1 0x4004b63e parser_parse+0xee6(ctx=0x33fad8) [dlls/vbscript/parser.y:294] 2 0x4004c3a2 parse_script+0xae(ctx=0x33fad8, code="...", ret=0x33fbe8) [dlls/vbscript/compile.c:961] 4 0x40049685 VBScriptParse_ParseScriptText+0x12d(iface=0x125e5c, pstrCode="...", pstrItemName=0x0(nil), punkContext=(nil), pstrDelimiter=0x0(nil), dwSourceContextCookie=0, ulStartingLine=0, dwFlags=0, pvarResult=(nil), pexcepinfo=(nil)) [dlls/vbscript/vbscript.c:554] 5 0x684b796d parse_script+0x32c(flags=0x8, script_str="...") [dlls/vbscript/tests/run.c:683] 6 0x684b7e99 run_from_res+0x15b(name="lang.vbs") [dlls/vbscript/tests/run.c:784] 7 0x684b845c run_tests+0x4eb() [dlls/vbscript/tests/run.c:841] 8 0x684b854c func_run+0x7a() [dlls/vbscript/tests/run.c:871] 9 0x684bb2d3 run_test+0x9e(name="run.c") [dlls/vbscript/tests/../../../include/wine/test.h:556] 0x4004c1e4 add_class_function+0x29 [dlls/vbscript/parser.y:638] in vbscript: movl 0x0(%eax),%eax 638 if(!strcmpiW(iter->name, decl->name)) { On Thu, Sep 15, 2011 at 8:16 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/92 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > make: *** [run.ok] Error 5 > >

2 1

Re: ole32/tests: Fix compilation on systems that don't support nameless unions.
by Alexandre Julliard 15 Sep '11

15 Sep '11

Dan Kegel <dank(a)kegel.com> writes: > Also be a bit more uniform about using U() instead of .u when accessing LowPart. .u is better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length
by Marcus Meissner 15 Sep '11

15 Sep '11

On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote: > --- > dlls/oleaut32/olepicture.c | 148 +++++++++++++------------------------- > dlls/oleaut32/tests/olepicture.c | 16 ++--- > 2 files changed, 54 insertions(+), 110 deletions(-) Did make check work for you even? Marvin does not like it at least. This will break NonStatable streams, also seekability of streams can not be assumed. Ciao, Marcus > diff --git a/dlls/oleaut32/olepicture.c b/dlls/oleaut32/olepicture.c > index 8081785..725207f 100644 > --- a/dlls/oleaut32/olepicture.c > +++ b/dlls/oleaut32/olepicture.c > @@ -1324,15 +1324,13 @@ static HRESULT OLEPictureImpl_LoadAPM(OLEPictureImpl *This, > */ > static HRESULT WINAPI OLEPictureImpl_Load(IPersistStream* iface, IStream *pStm) { > HRESULT hr; > - BOOL headerisdata; > - BOOL statfailed = FALSE; > - ULONG xread, toread; > - ULONG headerread; > + ULONG xread, toread = 0; > BYTE *xbuf; > DWORD header[2]; > WORD magic; > - STATSTG statstg; > OLEPictureImpl *This = impl_from_IPersistStream(iface); > + ULARGE_INTEGER end, start; > + LARGE_INTEGER offset; > > TRACE("(%p,%p)\n",This,pStm); > > @@ -1348,104 +1346,56 @@ static HRESULT WINAPI OLEPictureImpl_Load(IPersistStream* iface, IStream *pStm) > * At least in Visual Basic 6, resource streams, valid headers are > * header[0] == "lt\0\0", > * header[1] == length_of_stream. > - * > - * Also handle streams where we do not have a working "Stat" method by > - * reading all data until the end of the stream. > */ > - hr = IStream_Stat(pStm,&statstg,STATFLAG_NONAME); > - if (hr != S_OK) { > - TRACE("stat failed with hres %x, proceeding to read all data.\n",hr); > - statfailed = TRUE; > - /* we will read at least 8 byte ... just right below */ > - statstg.cbSize.QuadPart = 8; > - } > + offset.QuadPart = 0; > > - toread = 0; > - headerread = 0; > - headerisdata = FALSE; > do { > - hr = IStream_Read(pStm, header, 8, &xread); > - if (hr != S_OK || xread!=8) { > - ERR("Failure while reading picture header (hr is %x, nread is %d).\n",hr,xread); > - return (hr?hr:E_FAIL); > - } > - headerread += xread; > - xread = 0; > - > - if (!memcmp(&(header[0]),"lt\0\0", 4) && (statfailed || (header[1] + headerread <= statstg.cbSize.QuadPart))) { > - if (toread != 0 && toread != header[1]) > - FIXME("varying lengths of image data (prev=%u curr=%u), only last one will be used\n", > - toread, header[1]); > - toread = header[1]; > - if (toread == 0) break; > - } else { > - if (!memcmp(&(header[0]), "GIF8", 4) || /* GIF header */ > - !memcmp(&(header[0]), "BM", 2) || /* BMP header */ > - !memcmp(&(header[0]), "\xff\xd8", 2) || /* JPEG header */ > - (header[0] == EMR_HEADER) || /* EMF header */ > - (header[1] > statstg.cbSize.QuadPart)|| /* invalid size */ > - (header[1]==0) > - ) {/* Found start of bitmap data */ > - headerisdata = TRUE; > - if (toread == 0) > - toread = statstg.cbSize.QuadPart-8; > - else toread -= 8; > - xread = 8; > - } else { > - FIXME("Unknown stream header magic: %08x\n", header[0]); > - toread = header[1]; > - } > - } > - } while (!headerisdata); > - > - if (statfailed) { /* we don't know the size ... read all we get */ > - int sizeinc = 4096; > - int origsize = sizeinc; > - ULONG nread = 42; > - > - TRACE("Reading all data from stream.\n"); > - xbuf = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, origsize); > - if (headerisdata) > - memcpy (xbuf, header, 8); > - while (1) { > - while (xread < origsize) { > - hr = IStream_Read(pStm,xbuf+xread,origsize-xread,&nread); > - xread += nread; > - if (hr != S_OK || !nread) > - break; > - } > - if (!nread || hr != S_OK) /* done, or error */ > - break; > - if (xread == origsize) { > - origsize += sizeinc; > - sizeinc = 2*sizeinc; /* exponential increase */ > - xbuf = HeapReAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, xbuf, origsize); > - } > - } > - if (hr != S_OK) > - TRACE("hr in no-stat loader case is %08x\n", hr); > - TRACE("loaded %d bytes.\n", xread); > - This->datalen = xread; > - This->data = xbuf; > - } else { > - This->datalen = toread+(headerisdata?8:0); > - xbuf = This->data = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, This->datalen); > - if (!xbuf) > - return E_OUTOFMEMORY; > - > - if (headerisdata) > - memcpy (xbuf, header, 8); > - > - while (xread < This->datalen) { > - ULONG nread; > - hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > - xread += nread; > - if (hr != S_OK || !nread) > - break; > - } > - if (xread != This->datalen) > - ERR("Could only read %d of %d bytes out of stream?\n",xread,This->datalen); > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_CUR, &start); > + if (FAILED(hr)) > + return hr; > + > + hr = IStream_Read(pStm, header, 8, &xread); > + if (FAILED(hr) || xread!=8) { > + ERR("Failure while reading picture header (hr is %x, nread is %d).\n",hr,xread); > + return (FAILED(hr)?hr:E_FAIL); > + } > + > + if (memcmp(&(header[0]),"lt", 2)) { > + if (!toread) { > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_END, &end); > + if (FAILED(hr)) > + return hr; > + toread = end.QuadPart - start.QuadPart; > + } > + offset.QuadPart = start.QuadPart; > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) > + return hr; > + break; > + } > + else { > + toread = header[1]; > + if (toread == 0) > + break; > + } > + } while (1); > + > + This->datalen = toread; > + xbuf = This->data = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, This->datalen); > + if (!xbuf) > + return E_OUTOFMEMORY; > + > + xread = 0; > + while (xread < This->datalen) { > + ULONG nread; > + hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > + xread += nread; > + if (FAILED(hr) || !nread) > + break; > } > + if (xread != This->datalen) > + ERR("Could only read %d of %d bytes out of stream?\n",xread,This->datalen); > + > if (This->datalen == 0) { /* Marks the "NONE" picture */ > This->desc.picType = PICTYPE_NONE; > return S_OK; > diff --git a/dlls/oleaut32/tests/olepicture.c b/dlls/oleaut32/tests/olepicture.c > index 54de1cb..b1fad94 100644 > --- a/dlls/oleaut32/tests/olepicture.c > +++ b/dlls/oleaut32/tests/olepicture.c > @@ -1063,20 +1063,14 @@ static HRESULT WINAPI NoStatStreamImpl_Read( > { > NoStatStreamImpl* const This = impl_from_IStream(iface); > void* supportBuffer; > - ULONG bytesReadBuffer; > - ULONG bytesToReadFromBuffer; > > - if (pcbRead==0) > - pcbRead = &bytesReadBuffer; > - bytesToReadFromBuffer = min( This->streamSize.u.LowPart - This->currentPosition.u.LowPart, cb); > supportBuffer = GlobalLock(This->supportHandle); > - memcpy(pv, (char *) supportBuffer+This->currentPosition.u.LowPart, bytesToReadFromBuffer); > - This->currentPosition.u.LowPart+=bytesToReadFromBuffer; > - *pcbRead = bytesToReadFromBuffer; > + memcpy(pv, (char *) supportBuffer+This->currentPosition.u.LowPart, cb); > + This->currentPosition.u.LowPart+=cb; > GlobalUnlock(This->supportHandle); > - if(*pcbRead == cb) > - return S_OK; > - return S_FALSE; > + if(pcbRead) > + *pcbRead = cb; > + return S_OK; > } > > static HRESULT WINAPI NoStatStreamImpl_Write( > -- Working, but not speaking, for the following german company: SUSE LINUX Products GmbH, HRB 16746 (AG Nuernberg) Geschaeftsfuehrer: Jeff Hawn, Jennifer Guild, Felix Imendoerffer

1 0

Re: [PATCH 19/19] vbscript: Added stop statement semi-stub implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14271 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 18/19] vbscript: Added this object to identifier lookup chanin
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14270 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 17/19] vbscript: Added interp_mcall implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14269 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/19] vbscript: Added class functions parser implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14266 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/19] vbscript: Added function storage specifiers support
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14265 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/19] vbscript: Added interp_new implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14262 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 04/19] vbscript: Added interp_set_ident implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14261 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 01/19] vbscript: Added class parser implementation
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14260 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14259 Your paranoid android. === W2KPROSP4 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 780109B3 === WXPPROSP3 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 77C46FA3 === W2K3R2SESP2 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 77BD7E23 === WVISTAADM (32 bit olepicture) === olepicture: unhandled exception c0000005 at 76F29B2B === W2K8SE (32 bit olepicture) === olepicture: unhandled exception c0000005 at 76149F09 === W7PRO (32 bit olepicture) === olepicture: unhandled exception c0000005 at 75CA9B60 === W7PROX64 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 777A9B60 === W7PROX64 (64 bit olepicture) === Timeout

1 0

Re: pdh/tests: Some tests require that the user interface be in English. (try 2)
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14256 Your paranoid android. === W2KPROSP4 (32 bit pdh) === pdh.c:157: Test failed: PdhAddCounterA failed 0xc0000bc4 pdh.c:204: Test failed: PdhAddCounterW failed 0xc0000bc4

1 0

Re: msi: Improve parsing of the package platform.
by Marvin 15 Sep '11

15 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14255 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6000: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: cmd/tests: Add RENAME tests
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14246 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

[RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl
by Jérôme Gardou 14 Sep '11

14 Sep '11

Hello. I've seen that this patch is in "pending" state, and I would like to know what is the problem with it. Also, if commenting the tests isn't a policy you want to enforce (that I would understand), I'm ready to skip them on wine, but how to? Those tests were made with midl from Visual Studio 10, with or without /Os option, and ran smoothly. http://www.winehq.org/pipermail/wine-patches/2011-August/106200.html Regards. Jérôme. Le 06/09/2011 00:50, Jérôme Gardou a écrit : > Also, the added function which seems to be useless permits to detect > the problem that the next patch fixes. > Enable -Oif, and the test of server.c line 947 (after patch > application) will fail. > --- > dlls/rpcrt4/tests/server.c | 46 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 1 + > 2 files changed, 47 insertions(+), 0 deletions(-) > > > > >

2 1

quartz: Fix converting between the media time and REFTIME
by Joerg-Cyril.Hoehle＠t-systems.com 14 Sep '11

14 Sep '11

Hi, I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. Is quartz very decoupled from the underlying audio information? Who stops the clock (if at all) while the stream is paused? BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell http://bugs.winehq.org/show_bug.cgi?id=20232#c10 However every time I tried, I found mciqtz too underpowered to be able to reasonably use it. :-( Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: wine wintest.exe mcishell open foo.wav alias w type mpegvideo status w length play w from 0 notify wait close w # lots of other commands are available open foo.avi alias a type mpegvideo window a state show status a length play a from 0 close a Omit the "type mpegvideo" and mciwave or mciavi will be used instead of mciqtz32.dll Regards, Jörg Höhle

3 2

re: [PATCH 11/21] vbscript: Added function parser implementation
by Dan Kegel 14 Sep '11

14 Sep '11

Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). On Wed, Sep 14, 2011 at 7:17 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/35 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > vbscript.c:443: Test failed: expected OnEnterScript > vbscript.c:444: Test failed: expected OnLeaveScript > make: *** [vbscript.ok] Error 2 > >

2 2

Re: [PATCH 1/3] server: certain access flags are illegal for OpenMutex
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14233 Your paranoid android. === WNT4WSSP6 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2KPROSP4 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WXPPROSP3 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K3R2SESP2 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === WVISTAADM (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W2K8SE (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PRO (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (32 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5 === W7PROX64 (64 bit sync) === sync.c:174: Test failed: ReleaseMutex should have failed with ERROR_NOT_OWNER instead of 5

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel