- wine-devel - winehq.org

Re: [PATCH 06/21] vbscript: Added function arguments compiler implementation
by Octavian Voicu 14 Sep '11

14 Sep '11

On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/vbscript/compile.c > +++ b/dlls/vbscript/compile.c > @@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx, function_decl_t *decl, functi > func->code_ctx = ctx->code; > func->type = decl->type; > > + func->arg_cnt = 0; > if(decl->args) { ... > + }else { > + decl->args = NULL; I think you want to set func->args to NULL at the last line. Cheers, Octavian

2 1

Re: [PATCH 19/21] vbscript: Added interp_xor implementation
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14230 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 10/21] vbscript: Added support for sub local variables
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14224 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 09/21] vbscript: Added exit sub statement implementation
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14223 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/21] vbscript: Added sub argument tests
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14222 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/21] vbscript: Added function compiler implementation
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14220 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 05/21] vbscript: Added function invocation supprot to do_icall
by Marvin 14 Sep '11

14 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14221 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: pdh/tests: Some tests require that the user interface be in English.
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14215 Your paranoid android. === W2KPROSP4 (32 bit pdh) === pdh.c:150: Test failed: PdhAddCounterA failed 0xc0000bc4 pdh.c:197: Test failed: PdhAddCounterW failed 0xc0000bc4

1 0

Re: ieframe/tests: Some tests require that the user interface be in English.
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14214 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3062: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3138: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2069: Test failed: put_Resizable failed: 80004001 webbrowser.c:2070: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2074: Test failed: put_Resizable failed: 80004001 webbrowser.c:2075: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:394: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2069: Test failed: put_Resizable failed: 80004001 webbrowser.c:2070: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2074: Test failed: put_Resizable failed: 80004001 webbrowser.c:2075: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2455: Test failed: expected GetOverridesKeyPath webbrowser.c:2459: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2460: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2725: Test failed: expected TranslateUrl webbrowser.c:2726: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2727: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2733: Test failed: ReadyState = 1, expected 4 webbrowser.c:2557: Test failed: ReadyState = 1, expected 4 webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:793: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:800: Test failed: ReadyState = 1, expected 4 webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:595: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:599: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1495: Test failed: unexpected call GetOptionKeyPath webbrowser.c:343: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:447: Test failed: unexpected nCmdID 26 webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:878: Test failed: ReadyState = 1, expected 4 webbrowser.c:1506: Test failed: unexpected call GetDropTarget webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3098: Test failed: doc != doc2 webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:592: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:595: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:599: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:603: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1495: Test failed: unexpected call GetOptionKeyPath webbrowser.c:343: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:447: Test failed: unexpected nCmdID 26 webbrowser.c:447: Test failed: unexpected nCmdID 29 webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:1506: Test failed: unexpected call GetDropTarget webbrowser.c:945: Test failed: unexpected call GetContainer webbrowser.c:495: Test failed: unexpected call webbrowser.c:2598: Test failed: expected TranslateUrl webbrowser.c:2605: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2818: Test failed: expected RequestUIActivate webbrowser.c:2910: Test failed: Got 0x80004002 webbrowser.c:3105: Test failed: doc != doc2 webbrowser.c:3005: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: shlwapi/tests: Some tests require that the user interface be in English.
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14213 Your paranoid android. === W2KPROSP4 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === WXPPROSP3 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W2K3R2SESP2 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W7PROX64 (32 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB === W7PROX64 (64 bit string) === string.c:562: Test failed: Formatted 0000027cf wrong: got 9,95 KB, expected 9.95 KB string.c:562: Test failed: Formatted 000018801 wrong: got 98,0 KB, expected 98.0 KB string.c:562: Test failed: Formatted 0000ff94e wrong: got 0,99 MB, expected 0.99 MB string.c:562: Test failed: Formatted 03fffffcf wrong: got 0,99 GB, expected 0.99 GB string.c:562: Test failed: Formatted fffffffa9b wrong: got 0,99 TB, expected 0.99 TB string.c:562: Test failed: Formatted 3fffffffffbe8 wrong: got 0,99 PB, expected 0.99 PB string.c:562: Test failed: Formatted ffffffffffffa9b wrong: got 0,99 EB, expected 0.99 EB string.c:610: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:610: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:610: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:610: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:610: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:610: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:610: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:610: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:610: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB string.c:587: Test failed: Formatted 0000ff94e wrong: got 1.023 KB, expected 1,023 KB string.c:587: Test failed: Formatted 03e7ffa9b wrong: got 1.023.999 KB, expected 1,023,999 KB string.c:587: Test failed: Formatted 03fffffcf wrong: got 1.048.576 KB, expected 1,048,576 KB string.c:587: Test failed: Formatted f9fffff94e wrong: got 1.048.575.999 KB, expected 1,048,575,999 KB string.c:587: Test failed: Formatted fffffffa9b wrong: got 1.073.741.823 KB, expected 1,073,741,823 KB string.c:587: Test failed: Formatted 3e7fffffffa9b wrong: got 1.073.741.823.999 KB, expected 1,073,741,823,999 KB string.c:587: Test failed: Formatted 3fffffffffbe8 wrong: got 1.099.511.627.775 KB, expected 1,099,511,627,775 KB string.c:587: Test failed: Formatted f9ffffffffffd35 wrong: got 1.099.511.627.776.000 KB, expected 1,099,511,627,776,000 KB string.c:587: Test failed: Formatted ffffffffffffa9b wrong: got 1.125.899.906.842.623 KB, expected 1,125,899,906,842,623 KB

1 0

Re: [1/3] msxml3: Add xmlparser interfaces
by Francois Gouget 13 Sep '11

13 Sep '11

On Wed, 7 Sep 2011, Alistair Leslie-Hughes wrote: > > Changelog: > msxml3: Add xmlparser interfaces This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl which is a bit strange because I cannot find this type in the Windows SDK. But in the Windows 7 SDK there is an XmlError enumeration type in xmllite.h that looks similar but subtly different. These two enumaration types share some error codes, in particular XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the Windows 7 SDK. So what's going on? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

3 5

Re: [2/3] dinput: Prevent apps from hiding mouse cursor in the ConfigureDevices dialog.
by Alexandre Julliard 13 Sep '11

13 Sep '11

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > @@ -377,6 +377,12 @@ static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM w > break; > } > > + case WM_ACTIVATE: > + /* Prevent mouse cursor from disappearing inside the dialog */ > + ShowCursor(1); > + > + break; That will screw up the cursor show count, you can receive multiple WM_ACTIVATE. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cmd: Use NUL/0 instead of 0x00
by Alexandre Julliard 13 Sep '11

13 Sep '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -374,7 +374,7 @@ void WCMD_HandleTildaModifiers(WCHAR **start, const WCHAR *forVariable, > points to the variable just after the modifiers. Process modifiers > in a specific order, remembering there could be duplicates */ > modifierLen = lastModifier - firstModifier; > - finaloutput[0] = 0x00; > + finaloutput[0] = '\0'; It's mostly a matter of taste, but I don't think '\0' is better than 0x00, it's just another complicated way of writing 0. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] shell32: Handle the directory parameter in ShellExecute functions (try 2 resend)
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14201 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\TEMP\wt1.tmp\newfolder\tmp\newfolder\tm', got 'C:\TEMP\wt1.tmp\newfolder\shell32_test.exe' === W2KPROSP4 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WXPPROSP3 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === W2K3R2SESP2 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WVISTAADM (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt7926.tmp\newfolder\etest\AppData\Local\Temp\wt7926.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt7926.tmp\newfolder\shell32_test.exe' === W2K8SE (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt4D32.tmp\newfolder\etest\AppData\Local\Temp\wt4D32.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt4D32.tmp\newfolder\shell32_test.exe' === W7PRO (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt70C.tmp\newfolder\etest\AppData\Local\Temp\wt70C.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt70C.tmp\newfolder\shell32_test.exe' === W7PROX64 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt11E4.tmp\newfolder\etest\AppData\Local\Temp\wt11E4.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt11E4.tmp\newfolder\shell32_test.exe' === W7PROX64 (64 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt329B.tmp\newfolder\etest\AppData\Local\Temp\wt329B.tmp\newfolder\etest\AppData\Loca', got 'C:\Users\winetest\AppData\Local\Temp\wt329B.tmp\newfolder\shell32_test64.exe'

1 0

Re: [1/2] shell32/tests: Fix path comparison (try 2)
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14200 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\TEMP\wt1.tmp\newfolder\tmp\newfolder\tm', got 'C:\TEMP\wt1.tmp\newfolder\shell32_test.exe' === W2KPROSP4 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WXPPROSP3 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === W2K3R2SESP2 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\winetest\LOCALS~', got 'C:\DOCUME~1\winetest\LOCALS~1\Temp\wt1.tmp\newfolder\shell32_test.exe' === WVISTAADM (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtE6E8.tmp\newfolder\etest\AppData\Local\Temp\wtE6E8.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wtE6E8.tmp\newfolder\shell32_test.exe' === W2K8SE (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt7849.tmp\newfolder\etest\AppData\Local\Temp\wt7849.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt7849.tmp\newfolder\shell32_test.exe' === W7PRO (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt6624.tmp\newfolder\etest\AppData\Local\Temp\wt6624.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt6624.tmp\newfolder\shell32_test.exe' === W7PROX64 (32 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt2944.tmp\newfolder\etest\AppData\Local\Temp\wt2944.tmp\newfolder\etest\AppData\Lo', got 'C:\Users\winetest\AppData\Local\Temp\wt2944.tmp\newfolder\shell32_test.exe' === W7PROX64 (64 bit shlexec) === shlexec.c:2242: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt188.tmp\newfolder\etest\AppData\Local\Temp\wt188.tmp\newfolder\etest\AppData\Loca', got 'C:\Users\winetest\AppData\Local\Temp\wt188.tmp\newfolder\shell32_test64.exe'

1 0

audio: when is a "Resource temporarily unavailable"?
by Joerg-Cyril.Hoehle＠t-systems.com 13 Sep '11

13 Sep '11

Hi, Bug #28056 involving FreeBSD and OSS exhibits: warn:oss:AudioRenderClient_ReleaseBuffer write failed: 35 (Resource temporarily unavailable) My own notes from times as old as wine-1.1.8 show the same error with ALSA: err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Resource temporarily unavailable The symbolic errno constant is EAGAIN=EWOULDBLOCK. Does anybody have a suspicion when/why this happens? - is audio simply not reliable? - is Wine not correctly driving audio output? - ...? FWIW, my test experiments outside Wine recently produced EWOULDBLOCK once despite non-blocking mode in ALSA, when attempting to write a small number of frames, less than period_size. Is this failure really temporary or would it be safer to close or reset the audio device given such an error value? What's your experience? Thank you, Jörg Höhle

2 1

re: [2/2] msxml3: Support creating IXMLParser Interface
by Dan Kegel 13 Sep '11

13 Sep '11

test fails here? xmlparser.c:41: Test failed: IXMLParser is not available (0x80040154) make: *** [xmlparser.ok] Error 1 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 13, 2011 at 7:45 AM Subject: Re: 78800: Subject: [2/2] msxml3: Support creating IXMLParser Interface To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. For more info about this message, see http://wiki.winehq.org/BuildBot The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/77 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 Errors: xmlparser.c:41: Test failed: IXMLParser is not available (0x80040154) make: *** [xmlparser.ok] Error 1

1 0

Re: [PATCH 03/22] vbscript: Added object member assignment tests
by Octavian Voicu 13 Sep '11

13 Sep '11

On Tue, Sep 13, 2011 at 12:36 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: +const char *debugstr_variant(const VARIANT *v) +{ ... + case VT_I2: + return wine_dbg_sprintf("{VT_I4: %d}", V_I2(v)); Should be "{VT_I2: %d}". Octavian

1 0

Re: [PATCH 22/22] vbscript: Added interp_exp implementation
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14188 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 20/22] vbscript: Added interp_div implementation
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14186 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 17/22] vbscript: Added interp_idiv implementation
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14185 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 15/22] vbscript: Added interp_mod implementation
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14184 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 12/22] vbscript: Added if statement tests
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14183 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/22] vbscript: Added support for variable assignment statements
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14182 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/22] vbscript: Added variable value expression support
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14181 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 05/22] vbscript: Added dim statement compiler implementation
by Marvin 13 Sep '11

13 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14180 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

RFC: Translating Wine's dialogs with PO files
by Francois Gouget 12 Sep '11

12 Sep '11

This is the next step in making full use of the PO files for translating Wine. But how to get there is unclear, hence this RFC. The issue with dialogs is that in RC files all the dialog and control sizes are hardcoded. For instance in the line below '208, 6, 56, 14' represent the x-left, y-top, width and height of the button: DEFPUSHBUTTON "Save As", IDOK, 208, 6, 56, 14, BS_DEFPUSHBUTTON | WS_GROUP | WS_TABSTOP The problem is that once translated to French, for instance, the label becomes 'Enregistrer sous' which is much longer and may require enlarging the button. But RC files do not contain the information needed to do that automatically. For instance they don't specify enlarging this button requires enlarging the 'Cancel' and 'Help' buttons below too. So how do we solve this problem? Option 1 - Automatically layout the dialogs at compile time ----------------------------------------------------------- Gtk applications solve this problem by storing all the information needed to automatically layout dialogs in an XML file. The size and location of all the controls is then computed at runtime, after the dialog has been translated. We could do something similar, it would go something like this: * Use some format that lets us store all the layout information as the primary definition for Wine's dialogs. * At compile time translate the dialogs. * For each translation, layout the dialog and generate an RC file containing the computed control coordinates and sizes. * Then compile the RC files as usual. (alternatively the last two steps could be merged) Questions: * Which format should we use to define the layout? - Glade is the format used by Gtk. However it seems pretty Gtk centric and the set of controls/properties it supports may not match the Windows ones. It's possible to add libraries of custom widgets so that may be a solution. http://en.wikipedia.org/wiki/Glade_Interface_Designer - It looks like Microsoft added support for auto-layout in WPF (Windows Presentation Foundation) for .Net applications. This information can be stored in XAML XML files. http://msdn.microsoft.com/en-us/library/ms750441.aspx https://github.com/yadyn/WPF-Task-Dialog/blob/master/TaskDialog/CommandLink… Does anyone know how this works? Is it something we would need to implement in Wine anyway? Does some project already have support for it? Mono maybe? - For completeness I'll also mention that WxWidget also has a cross-platform layout engine. http://docs.wxwidgets.org/2.9.2/overview_xrc.html However as far as I know, none of them has tools that can generate RC files. * How can we do the layout? - Can we reuse a third-party layout engine? Like the one used for Glade files? - Wouldn't that introduce troublesome build dependencies? - Would it be ok if these dependencies are needed only when in maintainer mode? (In maintainer mode a change to a PO file could trigger an update to the corresponding RC files which would then be committed with the PO file change.) - Should we instead implement it all by ourselves? * How can we mesure the size that strings will take at run time? We probably have all the code we need in Wine. But can we use it are compile time? Will the computed layout depend on the fonts that are installed on the system where Wine is compiled? This is particularly important for languages with non-latin characters such as Japanese, Hebrew or Telugu. Pros: * We would not have to manually layout dialogs ever again. Yay! * We might be able to reuse the graphical dialog design tools of the system we adopt, like Glade or possibly some .Net tools. * There would be no risk of the translation and layout getting out of sync. * We would no longer need one RC file per language, thus eliminating the risk that they become out of sync (e.g. adding a given window style to some but not all languages). Cons: * Just integrating support for the layout engine and generating RC files seems like a lot of work. * Potential for additional build-time third-party dependencies for the layout engine. * Would require rewritting all our dialogs so they have all the needed layout information. That is definitely a lot of work. Option 2 - Add layout information to RC files --------------------------------------------- The idea here is the same as for option 1 except that we would add the layout information as comments in the existing RC files. As a very rough exemple it could look something like this: #layout# start box(orientation = vertical, padding = 8) #layout# start button(expand = true, fill = true) DEFPUSHBUTTON "Save As", IDOK, 208, 6, 56, 14, BS_DEFPUSHBUTTON | WS_GROUP | WS_TABSTOP #layout# end button ... #layout# end box Pros: * Same as for option 1. Cons: * We would be inventing our own syntax. * Not as clean as option 1. * The comments would risk becoming out of sync with the dialogs (e.g. if a developper adds a button but not the comment specifying how it is to be layed out). wrc might be able to check that things are consistent though. * It would be as much work as option 1. * We would have no chance of leveraging an existing layout engine. Option 3 - Use per-language RC files to store hardcoded dialog layouts ---------------------------------------------------------------------- This solution would reuse the existing per-language RC files but would refresh their labels using the PO files. Here is how it would work: * Every control of a given dialog would need to have a unique id. This should only be an issue for static labels which currently tend to all have -1 as their id. So we would first have to reassign them different ids like -1, -2, -3 or stc1, stc2, stc3, etc. * For each control that has a label in a language-specific RC file, look for the corresponding '<dialog-id>+<control-id>' combination in the English RC file. If no match is found that's an error. * Take corresponding English label and use the PO file to translate it. * Use the translated label instead of the, potentially outdated, one that was in the language-specific RC file. * This could be done by wrc when generating a .res file. This way any PO file change would immediately be reflected in the build. Alternatively this could be a maintainer-only task that updates the language-specific RC files whenever a PO file patch is committed. We could even do both so the labels in the language-specific RC files don't become too out of date. * If a given dialog is missing from a language-specific RC file, we would do as if the English dialog data was present instead and proceed as described above. Pros: * The current RC files would not need extensive modifications. * In fact we could progressively simplify them by removing all the translated dialogs that don't change the layout. * This solution feels like it should be easier to put in place than an automatic layout one. Cons: * We would still need to manually layout or verify the layout of every single dialog for every single language :-( * The translators would have no idea that there is a dialog whose layout may need to be changed as a result of their changes to the PO file. Developpers would similarly be hard pressed to make the connection and would likely lack the motivation to update the dialog layouts. So the dialog layouts would likely continue to be rarely updated and possibly incorrect. Exactly like today. * For every dialog with a customized dialog the translations would be stored both in the language-specific RC file and in the PO file. This could be confusing. Option 4 - Put the sizes in special PO files -------------------------------------------- This would really be a very ugly hack. Like option 2 it requires that every control of a given dialog have a unique id. Then for each of them we would create PO file entries of the form: msgctxt "<rc-filename>:<dialog-id>:<control-id>" msgid "<x>:<y>:<width>:<height>" msgstr "" We then put all these 'messages' in a sizes-<lang>.po file. Whenever a control needs to be resized a 'translation' would be provided in the relevant sizes-<lang>.po file. We would only keep the English RC file and when compiling the resources for a given language wrc would check whether the sizes-<lang>.po file contains a translation of the size data for the current control. Pros: * Maybe the easiest solution to put in place. Cons: * Totally ugly. * Probably awful to work with to change the layout of a dialog. * All the drawbacks of Option 2. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

3 4

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy 12 Sep '11

12 Sep '11

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) > A+ Speaking of --command and --file options, they aren't documented either. I'm willing to update winedev guide, but I'd like more info first. I found that --file accepts the set of commands to execute (but winedbg exits afterwards), but what does --command do? Is there a way to specify initial commands to execute, then stay *inside* winedbg after the last command of the file is issued? Frédéric

2 2

re: [5/5] ddraw: Use a Z format suported by the driver in the visual test
by Dan Kegel 12 Sep '11

12 Sep '11

Fails to compile on gcc-2.95 here: visual.c: In function `enum_z_fmt': visual.c:61: request for member `u1' in something not a structure or union visual.c:61: request for member `u1' in something not a structure or union make[1]: *** [visual.o] Error 1 make: *** [dlls/ddraw/tests] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 1:56 PM Subject: Re: 78663: Subject: [5/5] ddraw: Use a Z format suported by the driver in the visual test To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-gcc295 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-gcc295/builds/31 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

1 1

Re: attrib: Add quotes to fix the usage message indentation.
by Alexandre Julliard 12 Sep '11

12 Sep '11

Francois Gouget <fgouget(a)free.fr> writes: > --- > > Start-of-line spaces are ignored in RC files. That syntax is not supported by RC, so it's best avoided. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)
by Alexandre Julliard 12 Sep '11

12 Sep '11

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > changes from try1: remove erraneous HeapFree That's not much better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Support for alternate data streams in NtCreateFile?
by Frédéric Delanoy 12 Sep '11

12 Sep '11

Hi, What is the support status of (NTFS) names streams in wine? I only see include/winnt.h:4788:#define FILE_NAMED_STREAMS 0x00040000 but it doesn't seem to be used anywhere else in the code. (there's probably no possible translation in most filesystems) NtCreateFile (hence cmd) currently happily creates files/directories with colons in them, while it probably shouldn't for most FS. I'm asking this because ':' is normally disallowed in file/dirnames (http://msdn.microsoft.com/en-us/library/aa365247(v=VS.85).aspx), and was trying to add tests in ntdll/tests/file.c, except when named streams are supported by the underlying FS. Should I test the flags returned from GetVolumeInformation, and add tests for both named-stream-allowed and non-named-stream allowed FSs? Or should I assume that named streams won't ever be implemented and assume colons are disallowed, without checking the FILE_NAMED_STREAMS flag? Frédéric

2 1

Re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames
by Alexandre Julliard 12 Sep '11

12 Sep '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > @@ -162,6 +162,7 @@ static void create_file_test(void) > '\\','f','a','i','l','i','n','g',0}; > static const WCHAR questionmarkInvalidNameW[] = {'a','f','i','l','e','?',0}; > static const WCHAR pipeInvalidNameW[] = {'a','|','b',0}; > + static const WCHAR colonInvalidNameW[] = {':','c',0}; That's not a good test file name... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 17/21] vbscript: Added '<>' expression implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14158 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 16/21] vbscript: Added interp_sub implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14157 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 15/21] vbscript: Added interp_add implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14156 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/21] vbscript: Added interp_neg implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14155 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 08/21] vbscript: Added hex literal implementation
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14153 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/21] vbscript: Added interpreter support for numeric literals
by Marvin 12 Sep '11

12 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14152 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Marking test cases as flaky?
by Dan Kegel 12 Sep '11

12 Sep '11

Hi folks, I've been running "make test" a lot lately, and occasionally (it happened five times today), a test will fail out of the blue, in one out of twenty or a hundred runs. It would be bad form for buildbot to reject a patch because of a spurious test failure, so I've been making a list of tests that fail, adding to it each time I run into a test that fails occasionally, and skipping the tests on that list during "make test". This is all fine... but one of the tests that fails occasionally is ddraw/visual.ok (see http://bugs.winehq.org/show_bug.cgi?id=28301 ). It really doesn't feel right to skip that entirely just because a few particular pixel comparisons fail sometimes. Plan A would be to fix the tests to not be flaky, but that's hard, and the buildbot needs a quick solution. Plan B might be to conditionally compile the flaky tests away, e.g.: --- a/dlls/ddraw/tests/visual.c +++ b/dlls/ddraw/tests/visual.c @@ -1490,6 +1490,7 @@ static void D3D1_TextureMapBlendTest(void) ok(hr == D3D_OK, "IDirect3DDevice3_EndScene failed, hr = %08x\n", hr); } +#ifndef WINE_SKIP_FLAKY_TEST_SEE_BUG_28301 color = D3D1_getPixelColor(DirectDraw1, Surface1, 5, 5); red = (color & 0x00ff0000) >> 16; green = (color & 0x0000ff00) >> 8; @@ -1513,6 +1514,7 @@ static void D3D1_TextureMapBlendTest(void) green = (color & 0x0000ff00) >> 8; blue = (color & 0x000000ff); ok(red == 0 && green == 0 && blue == 0xff, "Got color %08x, expected 000000ff or near\n", color); +#endif Then my blacklist would mostly be a bunch of -D definitions in CFLAGS, one per flaky test. Or we could use a single define for all flaky tests. I may try that privately, to increase buildbot's test coverage. Would something like that be useful for other people, or should I just stick with private patches? - Dan

4 8

Re: [PATCH] cmd: Add help info for xcopy
by Frédéric Delanoy 12 Sep '11

12 Sep '11

On Fri, Sep 9, 2011 at 09:16, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; > static const WCHAR nullW[] = {'\0'}; > > const WCHAR externals[][10] = { > - {'A','T','T','R','I','B','\0'} > + {'A','T','T','R','I','B','\0'}, > + {'X','C','O','P','Y','\0'} Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external. Frédéric

3 3

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().
by Octavian Voicu 11 Sep '11

11 Sep '11

On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget <fgouget(a)free.fr> wrote: > - assert(0 && "bad encoding in load_encoding_name"); > + assert("bad encoding in load_encoding_name"); Hello, assert() is a debug macro which generates some code such that, during runtime: if the argument is non-zero, nothing happens; if the argument is zero, a message like "Assertion `X' failed" is printed (where X is exactly the expression that was given as an argument to assert, string-ified). assert(X) is something like: "I assert that at this point in the code, X holds; if you get there and X doesn't hold, tell me and abort the program". So assert(0 && "msg") will always trigger an assertion failure and tell you something like "Assertion `0 && "msg"' failed" then exit, which is good. If you change it to assert("msg"), condition will always be true so assertion will never be triggered. Octavian

2 1

re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames
by Dan Kegel 11 Sep '11

11 Sep '11

Hi Frédéric, fails a test here: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok fixme:cryptnet:CryptGetObjectUrl unimplemented for 0 cryptnet.c:444: Test failed: Expected ERROR_FILE_NOT_FOUND or ERROR_PATH_NOT_FOUND, got 123 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 3:14 PM Subject: Re: 78678: Subject: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/44 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)
by Alexandre Julliard 11 Sep '11

11 Sep '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I sent basically this in February without any feedback, and it still > applies. It's still wrong, the parameter is used inside the #ifdef. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)
by Marvin 11 Sep '11

11 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14145 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: shell32/tests: Make test explicit about return pointer
by Marvin 11 Sep '11

11 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

re: msi: Properly check for a specified flag combination
by Dan Kegel 10 Sep '11

10 Sep '11

Test failed here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... err:msi:env_parse_flags Invalid flags: 00000007 err:msi:ITERATE_Actions Execution halted, action L"RemoveEnvironmentStrings" returned 1627 err:msi:env_parse_flags Invalid flags: 00000007 action.c:5588: Test failed: Expected ERROR_SUCCESS, got 1627 action.c:5594: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5597: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5609: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 fixme:ntdll:NtQueryInformationToken QueryInformationToken( ..., TokenElevationType, ...) semi-stub action.c:5666: Test failed: key not created action.c:5670: Test failed: key not created action.c:5674: Test failed: key not created ... Command exited with non-zero status 7 4.04user 0.50system 0:05.03elapsed 90%CPU (0avgtext+0avgdata 51216maxresident)k 0inputs+7360outputs (0major+17117minor)pagefaults 0swaps make: *** [action.ok] Error 7 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sat, Sep 10, 2011 at 12:33 PM Subject: Re: 78647: Subject: msi: Properly check for a specified flag combination To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/15 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: urlmon/tests: Removed a test that causes random failures on some machines
by Marvin 10 Sep '11

10 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14120 Your paranoid android. === WVISTAADM (32 bit sec_mgr) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

urlmon:sec_mgr failure on XP
by Francois Gouget 10 Sep '11

10 Sep '11

This test now fails on my Widnows XP VMs that have IE >= 7 with 'All zones reset to default level': http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-… sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' The patch that introduces the failures is 98d5dfb8 which was committed on the 5th. I did some experiments and I can get this test to pass if I do: * Go to the Internet Properties control panel * Security tab * Select 'Local intranet' * Click on the 'Sites' button * Deselect 'Automatically detect intranet network' * Deselect 'Include all local (intranet) sites not listed in other zones' * Click on 'OK' I also checked on Windows 7 and by default it has the first checkbox checked but the second one unchecked. Disabling 'Automatically detect intranet network' and enabling 'Include all local sites...' to match Windows XP causes the test to fail on Windows 7 too. Finally, on XP even if I deselect all the 'Include XXX' checkboxes but select the 'Automatically detect intranet network' one the test fails while with the same configuration it passes on Windows 7. So I think this reflects a difference in the way the intranet detection works. So I'm hoping that you can fix the test. The easiest fix would be to remove the 'file/testing/test.test' check. An alternative would be to check what the settings are and adjust the expected result or skip the test. But it seems like this would be much more complex. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

2 1

speeding up builds with ext4 and ccache tuning
by Dan Kegel 10 Sep '11

10 Sep '11

Here's a little brain dump about speeding up builds. I ran into two problems today: - disk slowness On a machine where builds were slow, the iozone benchmark showed I/O was half or two thirds as fast as a better machine. The slow system turned out to be ext3, whereas the fast ones were ext4. (It's also using gcc-2.95.3 for wine, whereas the others are using the system compiler.) Adding a 7200rpm disk with an ext4 filesystem, and putting both wine-git and ~/.ccache on it, sped up ./configure so that it matched the faster system... but builds were only sped up by 20%. Nice, but not sufficient. - ccache too strict? ccache helps hugely on most of my systems without any tuning, but wasn't working well on my slow system. After looking at ccache's statistics and log file for a while, I came across the CCACHE_SLOPPINESS environment variable; setting that to maximum sloppiness got the cache hit rate sky-high, and build times dropped by a factor of 2, making the slower box suddenly competitive with the faster system. The sloppy setting is probably inappropriate for general use, but ok for regression testing. Those two tweaks get the buildbot cycle time for the headless subset of tests with gcc-2.95 on my e7300 down under nine minutes, yay.

1 1

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.
by Francois Gouget 10 Sep '11

10 Sep '11

I'm actually not entirely happy with this patch. Wine actually hardcodes the fallback fonts to Liberation Serif and Tahoma. So we could instead check that if on Wine and the Windows fonts are not installed then we get the fallback fonts. It's a bit what the test was trying to do with Microsoft Sans Serif except that I also take exception with the todo_wine since the fix is not to change Wine but to install the missing font. Changing the test as I described would let us detect when Microsoft decides to ship other fonts instead of these. We would also issue an error if neither font was found, such as on FreeBSD 8.1 for instance as it is a hint that we should find some other/additional fallback font. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

4 4

The msctf:inputprocessor test is not reliable
by Francois Gouget 10 Sep '11

10 Sep '11

This test is not reliable on my Debian desktop. http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/linux_… inputprocessor.c:2117: Test failed: OnSetFocus expected current focus 0x12b070 got 0x12b0d0 inputprocessor.c:538: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:549: Test failed: Sink reports wrong previous focus If I run it in a loop it fails about once every twelve times: i=0;while ../../../tools/runtest inputprocessor.c && [ $i -lt 100 ];do i=`expr $i + 1`; echo $i; done Introducing a single Sleep(50) as shown below makes it totally reliable here. ShowWindow(wnd3,SW_SHOWNORMAL); SetFocus(wnd3); + Sleep(50); processPendingMessages(); test_CurrentFocus = FOCUS_SAVE; test_PrevFocus = FOCUS_SAVE; test_OnSetFocus = SINK_SAVE; SetFocus(wnd1); processPendingMessages(); sink_check_saved(&test_OnSetFocus,dm2,dm1,"OnSetFocus"); /* ^^^ Line that fails! */ That seems pretty hacky though. I suspect this is all because processPendingMessages() will exit if there's no pending message right after we call SetFocus() without giving enough time for the asynchronous X event to arrive. But I'm surprised that a single Sleep() fixes the issue, especially where it's placed. Also I don't know anything about msctf so I'm unsure how ThreadMgrEventSink_OnSetFocus() figures in all this. So should I just submit a patch to add that Sleep()? Or would it be better to change processPendingMessages() to look more like user32/tests/msg.c's flush_events() function although it looks like it's overkill for now? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy 10 Sep '11

10 Sep '11

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) Thanks for that quick response! Is there some doc on the internal commands, besides the code? http://www.winehq.org/docs/winedev-guide/dbg-config may be a bit out of date Frédéric

2 1

resource_check_usage Unhandled usage flags 0x8
by Luis C. Busquets Pérez 09 Sep '11

09 Sep '11

I do not from which exact version of wine, whenever I run Civilization IV bryond the sword, losts of fixmes appear with the message fixme:d3d:resource_check_usage Unhandled usage flags 0x8. Since those fixmes did not appear before I wonder if this is a bug. I do not understand how it is that the function resource_check_usage uses a flag that before it wasn't, was it? Can anybody clarify the usage of the flag 0x8 and if this is a bug?

2 1

Re: 78632: Subject: po: Update Japanese translation.
by Dan Kegel 09 Sep '11

09 Sep '11

Hi Akihiro, your patch does not apply here, perhaps it's slightly out of date? patching file po/ja.po Hunk #22 FAILED at 8231. Hunk #23 succeeded at 8271 (offset 1 line). Hunk #24 succeeded at 8347 with fuzz 2 (offset 1 line). Hunk #25 succeeded at 8540 (offset 1 line). Hunk #26 succeeded at 8549 (offset 1 line). Hunk #27 succeeded at 8566 (offset 1 line). Hunk #28 succeeded at 8581 (offset 1 line). Hunk #29 succeeded at 8647 (offset 1 line). Hunk #30 succeeded at 8791 (offset 1 line). Hunk #31 succeeded at 8888 (offset 1 line). Hunk #32 succeeded at 8912 (offset 1 line). Hunk #33 succeeded at 9004 (offset 1 line). Hunk #34 succeeded at 9045 (offset 1 line). Hunk #35 succeeded at 9872 (offset 1 line). Hunk #36 succeeded at 10329 (offset 1 line). Hunk #37 succeeded at 10490 (offset 1 line). Hunk #38 succeeded at 10733 (offset 1 line). Hunk #39 succeeded at 10758 (offset 1 line). Hunk #40 succeeded at 11246 (offset 1 line). Hunk #41 succeeded at 11260 (offset 1 line). Hunk #42 succeeded at 11381 (offset 1 line). Hunk #43 succeeded at 11415 (offset 1 line). 1 out of 43 hunks FAILED -- saving rejects to file po/ja.po.rej dank@pantry:~/wine-git$ git reset --hard origin HEAD is now at cb55d2a crypt32/tests: Remove dead assignment (clang). dank@pantry:~/wine-git$ git apply 78632 error: patch failed: po/ja.po:8198 error: po/ja.po: patch does not apply 2011/9/9 <buildbot(a)kegel.com>: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/0 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed git > > > For more info about this message, see http://wiki.winehq.org/BuildBot > > >

1 0

Re: [2/2] dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders
by Alexandre Julliard 09 Sep '11

09 Sep '11

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > + info = HeapAlloc(GetProcessHeap(), 0, req_size); > + > + info->pwszName = (LPWSTR)(info + 1); > + > + if(!pguidServiceProvider) > + { > + lstrcpyW(info->pwszName, dp_providerW); > + info->guid = CLSID_DP8SP_TCPIP; > + } > + else > + { > + lstrcpyW(info->pwszName, dp_adapterW); > + info->guid = adapter_guid; > + } > + > + *pSPInfoBuffer = *info; > + *pcReturned = 1; > + > + HeapFree(GetProcessHeap(), 0, info); This doesn't make sense, you are returning freed data. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14103 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: [1/2] dpnet: return success in IDirectPlay8PeerImpl_Initialize
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14102 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

1 0

Re: [PATCH 14/14] vbscript: Added null literal support
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14101 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 13/14] vbsctipy: Added empty literal support
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14100 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 09/14] vbscript: Added interp_equal implementation
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14098 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 06/14] vbscript: Added interp_not implementation
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14097 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 01/14] vbscript: Added support for |f a, b, c| call statement
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14094 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 03/14] vbscript: Added support for parentheses in expressions
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14096 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 02/14] vbscript: Added parser/compiler support for |option explicit|
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14095 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: winebuild: Create stubs for ARM
by Alexandre Julliard 09 Sep '11

09 Sep '11

André Hentschel <nerv(a)dawncrow.de> writes: > this improves the testresults, as some tests expect to get stubs through GetProcAddress but never use them. These tests should be fixed (or the functions implemented), it shouldn't be necessary to generate stubs for Winelib. -- Alexandre Julliard julliard(a)winehq.org

1 0

What is the PulseAudio underrun bug?
by Joerg-Cyril.Hoehle＠t-systems.com 09 Sep '11

09 Sep '11

Hi, As I see that the PA team is preparing release candidates for 1.0, I wonder whether the Wine team communicated them the issues we face. Browsing open tickets http://pulseaudio.org/report/1 I found nothing obvious. The PA bug, as I face it in Ubuntu Lucid, is not something that happens randomly after N minutes or hours. It is *immediately* detectable. Symptoms: 1. winecfg audio test hangs. But Wine is a complex program, so I wrote a trivial one as follows: - set generic hw_params - prefill snd_pcm_write with e.g. 100ms of data; - start ALSA or use hw_params_set_start_threshold; - print out snd_pcm_state, snd_pcm_avail_update and snd_pcm_delay in a loop. 2. avail_update and avail_delay will freeze approx. at the time underrun would have happened with plug:dmix or plughw:0. In particular, delay will not decrease below < 0. By contrast, dmix or hw would see avail_update grow continuously, far above buffer_size, while delay decreases towards minus infinity -- regardless of whether XRUN state was entered or still RUNNING playing silence. 3. Optionally, XRUN mode is never entered, PA claims to be RUNNING. (XRUN is not a necessity, depending on hw_params_set_silence_*) >From there on, more snd_pcm_write(N frames) will not be heard, and avail_update() and delay() will solely bump to reflect that N frames have been queued, and remain frozen. snd_pcm_reset() won't help. snd_pcm_drain() will surprisingly play the buffered audio. Note that in non-blocking mode, this function will return -11 with "dmix" or "hw" ALSA devices, so here again PA differs from others. It looks like PA's front end (claiming to be running) has lost sync with its backend (which apparently stopped). 4. I don't know why and when, but the damage is not always limited to this one process. Sometimes the PA server will need to be restarted (pactl exit) otherwise no more sound will play for more than a click's time. It obviously corrupted its data structures. Andrew Eikum found out that activating the handle_underrun configuration in the newest alsa plugin package (released 2011-01-31!) allows to work around the bug. However when I read the comment to the patch, http://git.alsa-project.org/?p=alsa-plugins.git;a=commit;h=c20d516e22962012… I've the impression that using handle_underrun is backwards and is *not* the recommended way to use PulseAudio. IOW, PA without handle_underrun is subject to the underrun bug and that is abnormal behaviour. Or was it? Does the brandnew PA RC exhibit sane behaviour? Which is the "need handle_underrun" ticket in PA's bug tracker? http://pulseaudio.org/report/1 Where on Ubuntu's launchpad? What do they now about the issue? Regards, Jörg Höhle

2 1

user32: Avoid drawing the caret out of the window
by Bruno Jesus 09 Sep '11

09 Sep '11

Please, ignore this patch. It's overkill to check the bounding box during every caret timer callback. I have found a better approach to this by checking inside SetCaretPos/ShowCaret. That's because the caret doesn't move by itself so it's useless to check everytime. Thanks, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

What is the PulseAudio underrun bug?
by Joerg-Cyril.Hoehle＠t-systems.com 09 Sep '11

09 Sep '11

Hi again, Something that I still have trouble understanding is: Why did I find out only 2 weeks ago that Ubuntu Lucid is affected? Perhaps because I'm mostly using Intrepid which works better as far as the dreaded Intel Xorg screen flicker, suspend/resume and audio are concerned. Why do the Wine users only observe random drop outs after some time? Why does it look like the new mmdevapi code accentuated the problem (does it?)? Perhaps because most apps use dsound and dsound does efforts to send a continuous stream of data to the audio device, without underruns. Likewise, MCIWAVE/MCIAVI/winmm:PlaySound send data in a tight loop. Perhaps because the current GetPosition in both mmdevapi and winmm is not trustworthy and may cause underruns when a sound ends? Perhaps because "underrun at end" is almost designed into winmm? (unless you end with waveOutReset) Also, there may be more than underruns which is broken in PA. Underruns do not explain why I sometimes need to restart the PA server, as mentioned in my prior point 4. Do underruns really happen on my xGHz machine? On my Ubuntu Lucid system, the dreaded Intel XOrg screen flicker is enough to cause some apps running at that time to lose audio. Moving from one virtual desktop or screen to another may cause paging. That's no proof, but underruns may happen more often than one would like. Apps must robustly handle them. Regards, Jörg Höhle

1 0

Re: winspool.drv: Correct test for Device Capabilities
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14060 Your paranoid android. === WINEBUILD (build) === Can't determine base name

3 2

Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
by Frédéric Delanoy 09 Sep '11

09 Sep '11

While debugging with winedbg, I sometimes stumble upon situations like those (especially for widely used names) Many symbols with name 'foo', choose the one you want (<cr> to abort): [1]: 0x1234567 foo in libwhatever.so.1 [2]: Local variable (in a register) of foo => 2 This can be cumbersome, e.g. when you don't want to see foo val in libc.so. Is it somehow possible to auto-select the "local value"? Frédéric

1 0

Re: [2/8] msi/test: Mark some test results as broken.
by Marvin 09 Sep '11

09 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14087 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6000: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: cmd: GOTO is a no-op and doesn't output anything in interactive mode
by Frédéric Delanoy 09 Sep '11

09 Sep '11

2011/9/9 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > This patch depends on my other non-yet-commited goto patch (Avoid rereading batch file for every call/goto executed) Shouldn't probably have sent it yet. Sorry for the inconvenience. Frédéric

1 0

crypt32: Test/correct CertGetNameString with NULL pvTypePara
by Juan Lang 08 Sep '11

08 Sep '11

Fix for bug 23287. --Juan

1 0

[PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Joerg-Cyril.Hoehle＠t-systems.com 08 Sep '11

08 Sep '11

Andrew Eikum asked: >It would be nice to have tests for this, >Are these part of the tests you're >planning on submitting after you get the fixes in? That is part of my tests, the latest testbot job is https://testbot.winehq.org/JobDetails.pl?Key=14067 You can see that I still need to compute position estimates based on the high performance timer as Sleep() is not accurate enough. >and a fix for coreaudio if needed. Likewise for patch 2/2. The Mac never returns S_FALSE, so there was nothing to change. I've yet another patch about IsFormatSupported in my queue, but it needs more testing. For instance, I've not yet tested inconsistent formats (bad blockalign) or non PCM formats (e.g. A-law, ADPCM). In short, it looks like IsFormatSupported simply suggests GetMixFormat() in shared mode, but would it suggest linear PCM when given A-law? Regards, Jörg Höhle

1 0

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Octavian Voicu 08 Sep '11

08 Sep '11

--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c> @@ -1310,17 +1313,14 @@ exit: > LeaveCriticalSection(&This->lock); > HeapFree(GetProcessHeap(), 0, formats); > > - if(hr == S_OK || !out){ > - CoTaskMemFree(closest); > - if(out) > - *out = NULL; > - }else if(closest){ > + if(hr == S_FALSE && out) { > closest->nBlockAlign = > closest->nChannels * closest->wBitsPerSample / 8; > closest->nAvgBytesPerSec = > closest->nBlockAlign * closest->nSamplesPerSec; > *out = closest; > - } > + } else > + CoTaskMemFree(closest); You are dereferencing 'closest' without checking if it's non-NULL. It can be NULL if control jumps to the 'exit' label for several cases. This only applies to winealsa; for wineoss there are no gotos. Octavian

1 1

gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.
by Francois Gouget 08 Sep '11

08 Sep '11

In Wine, accept their fallbacks if the native fonts are not installed. --- This is an alternative patch which is more strict as it only allows the hardcoded fallbacks, and only if running in Wine. diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 323461a..9c261d9 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -34,6 +34,7 @@ static const WCHAR MicrosoftSansSerif[] = {'M','i','c','r','o','s','o','f','t',' static const WCHAR TimesNewRoman[] = {'T','i','m','e','s',' ','N','e','w',' ','R','o','m','a','n','\0'}; static const WCHAR CourierNew[] = {'C','o','u','r','i','e','r',' ','N','e','w','\0'}; static const WCHAR Tahoma[] = {'T','a','h','o','m','a',0}; +static const WCHAR LiberationSerif[] = {'L','i','b','e','r','a','t','i','o','n',' ','S','e','r','i','f',0}; static void test_createfont(void) { @@ -289,42 +290,52 @@ static void test_getgenerics (void) GpStatus stat; GpFontFamily* family; WCHAR familyName[LF_FACESIZE]; + int has_native; ZeroMemory(familyName, sizeof(familyName)/sizeof(WCHAR)); + stat = GdipCreateFontFamilyFromName(MicrosoftSansSerif, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Microsoft Sans Serif is missing\n"); stat = GdipGetGenericFontFamilySansSerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Microsoft Sans Serif not installed\n"); - goto serif; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Tahoma as a fallback if Microsoft Sans Serif is missing */ + ok (lstrcmpiW(familyName, MicrosoftSansSerif) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, Tahoma) == 0), + "Expected Microsoft Sans Serif or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - if (!lstrcmpiW(familyName, Tahoma)) - todo_wine ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got Tahoma\n"); - else - ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -serif: + /* First check that Times New Roman is installed because if not + * Wine substitutes another serif font. + */ + stat = GdipCreateFontFamilyFromName(TimesNewRoman, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Times New Roman is missing\n"); stat = GdipGetGenericFontFamilySerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Times New Roman not installed\n"); - goto monospace; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Liberation Serif as a fallback if Times New Roman + * is missing + */ + ok (lstrcmpiW(familyName, TimesNewRoman) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, LiberationSerif) == 0), + "Expected Times New Roman or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - ok (lstrcmpiW(familyName, TimesNewRoman) == 0, - "Expected Times New Roman, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -monospace: stat = GdipGetGenericFontFamilyMonospace (&family); if (stat == FontFamilyNotFound) { -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

1 0

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Andrew Eikum 08 Sep '11

08 Sep '11

It would be nice to have tests for this, and a fix for coreaudio if needed. Likewise for patch 2/2. Are these part of the tests you're planning on submitting after you get the fixes in? Andrew On Thu, Sep 08, 2011 at 04:09:37PM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > Wine is currently leaking memory because of this bug. > My tests show that S_FALSE indicates a format suggestion, > otherwise the out pointer is NULL. > I think MSDN says that, but it's not particularly clear. > > Regards, > Jörg Höhle >

1 0

Re: dinput: Remove an unused debug channel.
by Lucas Zawacki 08 Sep '11

08 Sep '11

err.. I know there's no debugging going on right now, but I'm planning on submiting a couple more patches to this file and I'll print some debug info then. 2011/9/8 Francois Gouget <fgouget(a)free.fr>: > --- > dlls/dinput/config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/config.c b/dlls/dinput/config.c > index 1c6da6c..aedaa0e 100644 > --- a/dlls/dinput/config.c > +++ b/dlls/dinput/config.c > @@ -16,14 +16,12 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > -#include "wine/debug.h" > #include "wine/unicode.h" > #include "objbase.h" > #include "dinput_private.h" > #include "device_private.h" > #include "resource.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(dinput); > > typedef struct { > int nobjects; > -- > 1.7.5.4 > > > >

1 0

Re: cmd/tests: Add tests for combined CALLs/GOTOs
by Marvin 08 Sep '11

08 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14056 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: comctl32: Fix the wizard and property sheet dialog styles.
by Marvin 07 Sep '11

07 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14049 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/3] msxml3: Register XML Parser interfaces (try 2)
by Nikolay Sivov 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 2:04 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > msxml3: Register XML Parser interfaces > Do you really need this? I think existing coclasses are registered with .idl in /msxml3. Maybe just add new .idl in it?

3 2

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr
by Octavian Voicu 07 Sep '11

07 Sep '11

2011/9/7 André Hentschel <nerv(a)dawncrow.de>: > + if (!str || !*str) return NULL; > return strlwrW( str ); >+ if (!str || !*str) return NULL; > return struprW( str ); It seems strange to return NULL when called with an empty, non-NULL string. Maybe it should be `return str' instead (so it covers both the NULL and empty cases sensibly), though strlwrW/struprW seems to be able to cope with zero-length strings as the NULL char is mapped to NULL. Octavian

1 0

Re: ntdll: check for string and stringlength in _wcslwr and _wcsupr
by Nikolay Sivov 07 Sep '11

07 Sep '11

2011/9/7 André Hentschel <nerv(a)dawncrow.de>: > Fixes http://bugs.winehq.org/show_bug.cgi?id=28303 (str="") > --- > dlls/ntdll/wcstring.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/wcstring.c b/dlls/ntdll/wcstring.c > index 7f0035d..d75f10e 100644 > --- a/dlls/ntdll/wcstring.c > +++ b/dlls/ntdll/wcstring.c > @@ -47,6 +47,7 @@ INT __cdecl NTDLL__wcsicmp( LPCWSTR str1, LPCWSTR str2 ) > */ > LPWSTR __cdecl NTDLL__wcslwr( LPWSTR str ) > { > + if (!str || !*str) return NULL; > return strlwrW( str ); > } > > @@ -65,6 +66,7 @@ INT __cdecl NTDLL__wcsnicmp( LPCWSTR str1, LPCWSTR str2, INT n ) > */ > LPWSTR __cdecl NTDLL__wcsupr( LPWSTR str ) > { > + if (!str || !*str) return NULL; > return struprW( str ); > } > Please add tests for that.

1 0

Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)
by Nikolay Sivov 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 2:05 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Use a skip if we cannot create the control. > > Changelog: > msxml3: Support creating IXMLParser Interface > > > Best Regards > Alistair Leslie-Hughes > > (not related to patch contents) First time I saw this on a list I thought - god dammit, another parser interface. But looking at methods list it's probably a first candidate to be independent from libxml2 without any loss in functionality or big overhead like XPath or XSL things. We'll see. Is it mentioned as obsolete by any chance? Seems to be a kind of low level parser.

3 3

Re: ntdll: Fix two buffer overflow conditions in RtlDosPathNameToNtPathName_U.
by Vitaliy Margolen 07 Sep '11

07 Sep '11

On 09/06/2011 06:23 AM, Octavian Voicu wrote: > First one is an off-by-one error: RtlGetFullPathName_U, on success, returns > the number of bytes written, without counting the terminating NULL. The > allocated size for ntpath->Buffer didn't account for that NULL byte, so > for UNC paths the NULL byte would be overflown. > > Second one is caused by an USHORT overflow in ntpath->MaximumLength. > Calling the function with a path longer than 65535-8 bytes would allocate > a much shorter buffer and lead to a buffer overflow. > > -- > Steps to reproduce second issue are described here: > http://packetstormsecurity.org/files/view/76170/wine-overflow.txt > > Funny fact: Windows had the same USHORT overflow bug: > http://www.securityfocus.com/archive/1/323508 > --- > dlls/ntdll/path.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/dlls/ntdll/path.c b/dlls/ntdll/path.c > index 3207720..6138fa8 100644 > --- a/dlls/ntdll/path.c > +++ b/dlls/ntdll/path.c > @@ -383,8 +383,14 @@ BOOLEAN WINAPI RtlDosPathNameToNtPathName_U(PCWSTR dos_path, > if (!(ptr = RtlAllocateHeap(GetProcessHeap(), 0, sz))) return FALSE; > sz = RtlGetFullPathName_U(dos_path, sz, ptr, file_part); > } > + sz += (1 /* NUL */ + 4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + if (sz> MAXWORD) > + { > + if (ptr != local) RtlFreeHeap(GetProcessHeap(), 0, ptr); > + return FALSE; > + } > > - ntpath->MaximumLength = sz + (4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + ntpath->MaximumLength = sz; > ntpath->Buffer = RtlAllocateHeap(GetProcessHeap(), 0, ntpath->MaximumLength); > if (!ntpath->Buffer) > { The fix is not entirely correct. UNICODE_STRING does not have to have a terminating \0 character. The code should not use str* functions on not zero-terminated strings. Vitaliy

2 2

Re: winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol (resend)
by Alexandre Julliard 07 Sep '11

07 Sep '11

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Hi, > > [unmodified & sent alone. There's no apply failure in testbot.] > > With this patch, MacOS will be the first to correctly implement the allowed ordering of Get and ReleaseBuffer according to my rendering tests (see bug #27937). > > [...capture mode] >>I believe that ReleaseBuffer(0) always returns S_OK, like in the render case. > Verified indeed. But I've not finalized capture code yet (I'm not > familiar with capture, so it takes more time). > > Because my patch changes the type of getbuf_last, I had to slightly modify AudioCaptureClient already: > @@ -1781,7 +1797,7 @@ static HRESULT WINAPI AudioCaptureClient_GetBuffer(IAudioCaptureClient *iface, > *flags = 0; > This->written_frames += *frames; > This->inbuf_frames -= *frames; > - This->getbuf_last = TRUE; > + This->getbuf_last = 1; This fake patch fragment in the message confuses git apply. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] cmd: Remove attrib from builtins list
by Frédéric Delanoy 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 09:09, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > This series remove attrib from the builtins list. Only the brief description in the global help is kept. > An externals list of commands shipped with cmd.exe is created so when the help builtins is called, the > requested help is obtained by invoking the command with the /? option as for native cmd.exe. > --- > programs/cmd/cmd.rc | 1 - > programs/cmd/wcmd.h | 91 +++++++++++++++++++++++------------------------ > programs/cmd/wcmdmain.c | 1 - > 3 files changed, 45 insertions(+), 48 deletions(-) You should probably commit the po changes as well, as is usually done

3 4

Re: [PATCH 2/2] cmd: Launch the command with the /? option for external commands shipped with cmd.exe
by Frédéric Delanoy 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 09:10, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + WCHAR space_slashdot_ask[] = {' ', '/','?','\0'}; space_slash_questionmark would probably be a more appropriate name

1 0

Re: winecfg: Specify a context for the 'Letter' paper size. (try 2)
by Octavian Voicu 07 Sep '11

07 Sep '11

On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget <fgouget(a)free.fr> wrote: > Actually, paper size is the more common term. ... > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc ... > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper size#Letter" While paper size is probably the most commonly used meaning within Wine, it seems pretty obvious to me that in this context "Letter" means "letter of the alphabet", because it refers to the letter that is used for mapping drives in winecfg (A, B, ... Z). Octavian

1 0

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy 07 Sep '11

07 Sep '11

"help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

2 1

Re: [3/3] msxml3: Support creating IXMLParser Interface
by Marvin 07 Sep '11

07 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android. === WNT4WSSP6 (32 bit xmlparser) === xmlparser.c:39: Test failed: failed to create IXMLParser

1 0

buildbot status
by Dan Kegel 07 Sep '11

07 Sep '11

- stability problems The buildbot cluster is not ready for prime time yet. My ubuntu 11.04-based slaves tend to lock up within a day with either an OOM failure, an X livelock, or something else. So I brought an ubuntu 10.04.3 slave online and moved the buildmaster off onto its own machine; let's see what breaks next. - Slave speed Here is the complete build-and-test time (and the build time alone) for four CPUs: 54 (48) celeron @ 2.80 GHz (headless, so it's not running all tests) 17 (10) E8400 @ 3.00GHz 14 (6) Q9300 @ 2.50GHz 12 (4) i7 920 @ 2.67GHz I will probably stick with slaves that are core 2 duo or better, so patches can get fast feedback.

5 15

Re: winecfg: Specify a context for the 'Letter' paper format.
by André Hentschel 06 Sep '11

06 Sep '11

Am 07.09.2011 00:48, schrieb Francois Gouget: > It's likely that letter does not always translate the same way for the paper format and the alphabet characters. > --- > > This is more to provide context for the translator than to avoid > conflicts. > > programs/winecfg/winecfg.rc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc > index 5689e7c..26cf504 100644 > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc > @@ -77,7 +77,7 @@ BEGIN > IDS_DRIVE_LETTERS_EXCEEDED "You cannot add any more drives.\n\nEach drive must have a letter, from A to Z, so you cannot have more than 26." > IDS_SYSTEM_DRIVE_LABEL "System drive" > IDS_CONFIRM_DELETE_C "Are you sure you want to delete drive C?\n\nMost Windows applications expect drive C to exist, and will die messily if it doesn't. If you proceed remember to recreate it!" > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper format#Letter" > IDS_COL_DRIVEMAPPING "Drive Mapping" > IDS_NO_DRIVE_C "You don't have a drive C. This is not so great.\n\nRemember to click 'Add' in the Drives tab to create one!\n" > END Isn't it the wrong context name? #msgctxt#Driveletter# would be better -- Best Regards, André Hentschel

1 0

re: dnsapi: Use internal name_skip function
by Dan Kegel 06 Sep '11

06 Sep '11

Hi André, your patch failed to build on an ubuntu 10.04 system here: ccache gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o name.o name.c In file included from ns_parse.c:39: ../../include/winbase.h:1583: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../../include/winbase.h:1584: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [ns_parse.o] Error 1 Inserting #include <stdarg.h> before including winbase.h makes the compiler happy. - Dan ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 6, 2011 at 3:41 PM Subject: Re: 78446: Subject: dnsapi: Use internal name_skip function To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/13 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

2 1

Testbot 64 bit mingw?
by Stefan Dösinger 06 Sep '11

06 Sep '11

Hi, The ddrawmodes test has a problem on W7PROX64 when running as a 64 bit binary. The test times out, and debugging showed that it freezes in crash_callbackA, in dlls/ddraw/tests/ddrawmodes.c. The function is supposed to crash, DirectDrawEnumerateA catches the exception and returns DDERR_INVALIDPARAMS. The line in question is: *(volatile char*)0 = 2; I can reproduce the freeze on my local system with the binaries built by the testbot. I cannot reproduce them with my own 64 bit binaries, or with the ones from http://test.winehq.org/builds. Thus I suspect that a problem with mingw is preventing the test from working. The 32 bit build works fine, even on a 64 bit Windows system. The mingw version I'm using on my local system: $ x86_64-pc-linux-gnu-gcc --version x86_64-pc-linux-gnu-gcc (Gentoo 4.5.2 p1.1, pie-0.4.5) 4.5.2 Stefan

1 0

Re: [1/2] shell32/tests: Fix path comparison
by Marvin 06 Sep '11

06 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14016 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:193: Test failed: WaitForSingleObject(hProcess) returned 258

1 0

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste
by Alexandre Julliard 06 Sep '11

06 Sep '11

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > MENUITEM "Select &All", IDM_SELECTALL > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > MENUITEM SEPARATOR > MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT > MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES > @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as Back&ground", IDM_SETWALLPAPER > MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > - MENUITEM "Cu&t", IDM_CUT > + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT > MENUITEM "&Copy", IDM_COPY > MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE That's not a very useful context. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)
by Frédéric Delanoy 06 Sep '11

06 Sep '11

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos for help command > - update po files > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. I've got test failures with your patch ("make test" in programs/cmd/tests) First error: batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 (got 'r.test not found before delete, bad', wanted 'r.test found before delete, good') Also, beware that testbot won't test your patch on windowses since it doesn't change any file in tests/ directory (you might want to submit it manually with, say, a small change in test_builtins.cmd and/or test_builtins.exp) See http://wiki.winehq.org/CmdConformanceTests (recently written) if you need help with the keywords, etc. Frédéric

2 2

Fwd: [ANNOUNCE] Git User's Survey 2011
by Andrew Eikum 06 Sep '11

06 Sep '11

It's that time of year again. I thought I'd forward this on to wine-devel since we're all Git users here. ----- Forwarded message from Jakub Narebski <jnareb(a)gmail.com> ----- Date: Mon, 5 Sep 2011 02:43:20 +0200 From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2011 User-Agent: KMail/1.9.3 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2011 page (https://git.wiki.kernel.org/index.php/GitSurvey2011) and discussed on the git mailing list. The survey would be open from 5 September till 3 October 2011. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2011 https://www.survs.com/survey/VCAGZA8CT5 There is also alternate version which does not require cookies, but it doesn't allow one to go back to response and edit it. https://www.survs.com/survey/MRRGT8OEFV P.S. At request I can open a separate channel in survey, with a separate survey URL, so that responses from particular site or organization could be separated out. Please send me a email with name of channel, and I will return with a separate survey URL to use. -- Git Development Community -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message -----

1 0

script to run all good tests / all flaky tests / etc.
by Dan Kegel 06 Sep '11

06 Sep '11

The buildbot does three things to get fast, reliable test runs: - it runs a 'safe' set of tests in the background, without DISPLAY set, in a different wineprefix; this saves three minutes - it has a blacklist of known flaky or broken tests, listing how it's broken and linking to the bug report - it kills wineserver after the run (since some tests leave processes around) I hoisted these out of the buildbot config and into a separate script, http://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests.sh As a bonus, you can ask it to run all the flaky tests instead of all the good ones, which might be useful if you're trolling for test bugs to fix. Here's the current blacklist from that script: # Blacklist format # test condition [bug] # Tests may appear multiple times in the list. # Supported conditions: # FLAKY - fails sometimes # CRASHY - crashes sometimes # SYS - always fails on some systems, not on others # HEAP - fails or crashes if warn+heap # NOTTY - test fails if output redirected # BAD64 - always fails on 64 bits cat > /tmp/blacklist.txt <<_EOF_ dlls/kernel32/tests/heap.ok HEAP dlls/dsound/tests/ds3d8.ok SYS 8668 dlls/dsound/tests/ds3d.ok SYS 8668 dlls/dsound/tests/dsound8.ok SYS 8668 dlls/dsound/tests/dsound.ok SYS 8668 dlls/user32/tests/input.ok SYS 12053 dlls/user32/tests/msg.ok SYS 12053 dlls/user32/tests/win.ok SYS 12053 dlls/oleaut32/tests/tmarshal.ok BAD64 26768 dlls/ieframe/tests/ie.ok BAD64 26768 dlls/ws2_32/tests/sock.ok CRASHY 28012 dlls/wininet/tests/urlcache.ok FLAKY 28038 dlls/winmm/tests/wave.ok SYS 28048 dlls/winmm/tests/mci.ok SYS 28071 dlls/urlmon/tests/url.ok FLAKY 28108 dlls/winmm/tests/capture.ok SYS 28109 dlls/shell32/tests/shlfolder.ok SYS 28216 dlls/kernel32/tests/process.ok NOTTY 28220 dlls/d3dx9_36/tests/shader.ok HEAP 28255 dlls/kernel32/tests/pipe.ok HEAP 28257 programs/cmd/tests/batch.ok HEAP 28258 dlls/dsound/tests/ds3d8.ok HEAP 28260 dlls/dsound/tests/ds3d.ok HEAP 28260 dlls/mshtml/tests/style.ok HEAP 28262 dlls/winhttp/tests/winhttp.ok SYS 28267 programs/wscript/tests/run.ok BAD64 28285 dlls/msctf/tests/inputprocessor.ok FLAKY 28288 _EOF_

2 2

Re: uxtheme: Return error on invalid parameters
by Alexandre Julliard 06 Sep '11

06 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > uxtheme: Return error on invalid parameters Get/SetPropW already check the handle, don't add redundant checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros. (try 2)
by Alexandre Julliard 06 Sep '11

06 Sep '11

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID, LPFNADDPROPSHEETPAGE, LPA > /* > * Property sheet support (structures) > */ > +#ifndef _WIN32 > +typedef const VOID* PROPSHEETPAGE_RESOURCE; > +#elif defined(UNICODE) > +typedef LPCDLGTEMPLATEW PROPSHEETPAGE_RESOURCE; > +#else > +typedef LPCDLGTEMPLATEA PROPSHEETPAGE_RESOURCE; > +#endif That one should be disallowed too. And testing _WIN32 isn't useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [The Official Wine Wiki] Update of "ConformanceTests"
by Joerg-Cyril.Hoehle＠t-systems.com 06 Sep '11

06 Sep '11

François Gouget asked: >> + * Depending on OSX settings, the firewall will ask whether to >> allow incoming network access for tests involving server sockets. >Does it cause test failures? Sorry, I've not tracked it down. Either I click "agree" fast enough (they occur towards the end of the ~20 minutes winetest.exe run) and the tests proceed, or presumably the test exe is killed after a timeout. I tend to "babysit" test execution for that reason (and because I only went online for the purpose of test execution, bug #20219). >Does one have to disable the firewall? I configured the Mac too long ago to remember. Presumably it's a matter of restrictive configuration, otherwise other users would have raised the topic already. Regards, Jörg Höhle

1 0

Re: [2/2] ntdll: Allow reading from a VPROT_WRITECOPY protected memory
by Dmitry Timoshkov 06 Sep '11

06 Sep '11

André Hentschel wrote: > As per tests in kernel32:loader it seems linux&co allows reads on PROT_WRITE areas, but solaris doesn't and crashes. > This fixes this issue. > - if (vprot & VPROT_WRITECOPY) prot |= PROT_WRITE; > + if (vprot & VPROT_WRITECOPY) prot |= PROT_READ | PROT_WRITE; Do you mean that the recently added test for resource section access mapping crashes on Solaris? If yes, then the fix should be done in different place. -- Dmitry.

2 3

Re: comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros.
by Alexandre Julliard 06 Sep '11

06 Sep '11

Francois Gouget <fgouget(a)free.fr> writes: > @@ -213,6 +247,27 @@ DECL_WINELIB_TYPE_AW(PROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPCPROPSHEETHEADER) > DECL_WINELIB_TYPE_AW(LPFNPSPCALLBACK) > +#ifdef UNICODE > +typedef PROPSHEETPAGEW_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEW_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEW_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEW_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEW_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEW_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEW_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERW_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERW_V2_SIZE > +#else > +typedef PROPSHEETPAGEA_LATEST PROPSHEETPAGE_LATEST; > +typedef LPPROPSHEETPAGEA_LATEST LPPROPSHEETPAGE_LATEST; > +typedef LPCPROPSHEETPAGEA_LATEST LPCPROPSHEETPAGE_LATEST; > +#define PROPSHEETPAGE_V1_SIZE PROPSHEETPAGEA_V1_SIZE > +#define PROPSHEETPAGE_V2_SIZE PROPSHEETPAGEA_V2_SIZE > +#define PROPSHEETPAGE_V3_SIZE PROPSHEETPAGEA_V3_SIZE > +#define PROPSHEETPAGE_V4_SIZE PROPSHEETPAGEA_V4_SIZE > +#define PROPSHEETHEADER_V1_SIZE PROPSHEETHEADERA_V1_SIZE > +#define PROPSHEETHEADER_V2_SIZE PROPSHEETHEADERA_V2_SIZE > +#endif Please use the appropriate Winelib macros to define A/W mappings. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: Property sheets must be able to redraw themselves even if no page is selected.
by Marvin 05 Sep '11

05 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13992 Your paranoid android. === WVISTAADM (32 bit propsheet) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Undocumented registry settings
by Vitaliy Margolen 05 Sep '11

05 Sep '11

Henri, Would you mind documenting recently added registry entries to wined3d on Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find description of "AlwaysOffscreen". Vitaliy.

2 2

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Henri Verbeet 05 Sep '11

05 Sep '11

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); > + vals = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(LARGE_INTEGER)); ... > + keys = HeapReAlloc(GetProcessHeap(), 0, keys, > + capacity * sizeof(WCHAR*)); > + vals = HeapReAlloc(GetProcessHeap(), 0, vals, > + capacity * sizeof(LARGE_INTEGER)); Memory allocations can fail. You also never free these, but I suppose that happens implicitly on process termination.

2 1

Re: msxml3: Correct MSXML Object Safety tests (try 2)
by Alexandre Julliard 05 Sep '11

05 Sep '11

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Add the enabled test as well. > > Changelog: > msxml3: Correct Object Safety tests It doesn't work here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok domdoc.c:4706: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 domdoc.c:7532: Test failed: expected INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA got 2 make[1]: *** [domdoc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32/tests: Test for correct storage creation.
by Vincent Povirk 05 Sep '11

05 Sep '11

You might just want to try reopening the file and checking its CLSID, instead of directly checking the contents. That should make it more obvious that something is seriously wrong. With the direct checks, it's hard to figure out what the test actually means. Anyway, this should be easy to fix. We just need to keep track of whether the file has ever had a header, instead of assuming the header is valid if the file is large enough to have one.

1 0

Re: [1/2] programs: Add a stub implementation of regasm.exe.
by Vincent Povirk 05 Sep '11

05 Sep '11

On Windows, this is a .NET assembly. We should probably do it the same way.

1 0

Re: [dsound] InstanceId holds a pointer, so it needs to be as wide as a pointer.
by Michael Stefaniuc 05 Sep '11

05 Sep '11

Hello Dan, Dan Kegel wrote: > Not that we do anything with it... still the correct fix would be to rewrite the driver to use a more modern header version than DirectX 5. I guess that's part of Andrew's dsound rewrite. bye michael

1 0

re: configure.ac: add -Werror to default compiler options
by Dan Kegel 05 Sep '11

05 Sep '11

(Reviving http://www.winehq.org/pipermail/wine-devel/2008-September/069266.html ) After http://www.winehq.org/pipermail/wine-patches/2011-August/106150.html and http://www.winehq.org/pipermail/wine-patches/2011-August/106151.html, configuring with -Wall -Werror gives the right results, judging by a quick diff of config.h and config.status. (sys/asoundlib.h is not detected, but that's ok, it's marked as obsolete, and wine uses alsa/asoundlib.h instead.) This takes care of Maarten's concerns from the earlier thread. Then building yields only a tiny handful of errors: dllfunc.c: In function ‘AMovieDllRegisterServer2’: dllfunc.c:180: warning: dereferencing type-punned pointer will break strict-aliasing rules qualitycontrol.c: In function ‘QualityControlImpl_Notify’: qualitycontrol.c:70: warning: dereferencing type-punned pointer will break strict-aliasing rules transform.c: In function ‘TransformFilterImpl_QueryInterface’: transform.c:248: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../include/winternl.h: In function ‘get_vm86_teb_info’: ../../include/winternl.h:2660: warning: dereferencing type-punned pointer will break strict-aliasing rules ... register.c: In function ‘create_registrar’: register.c:66: warning: dereferencing type-punned pointer will break strict-aliasing rules Those are potential, if unlikely, bugs; we ought to either fix them or add -fno-strict-aliasing to CFLAGS for the seven or so affected .c files. At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. - Dan

7 9

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc
by Jacek Caban 05 Sep '11

05 Sep '11

Hi Thomas, AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why are you changing it? Jacek

2 1

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)
by Eric Pouech 05 Sep '11

05 Sep '11

this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

1 0

Re: [1/5] ddraw: Add some NULL pointer tests
by Marvin 05 Sep '11

05 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13949 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

2 1

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().
by Stefan Dösinger 05 Sep '11

05 Sep '11

On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > These are no longer needed since present can handle these now. I think we can remove the entire special case and just do a blit. This hack is related to the ddraw windowed backbuffer hack you removed a while ago, except that the back->front blit is used by a handful of fullscreen apps too.

2 3

Re: [2/4] msi/tests: Fix a number of test messages.
by Marvin 05 Sep '11

05 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [2/3] winhttp/tests: Initialize a variant with a known value.
by Marvin 05 Sep '11

05 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android. === W7PRO (32 bit winhttp) === winhttp.c:1971: Test failed: failed to send request 12152 winhttp.c:1977: Test failed: got 12019

1 0

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)
by Octavian Voicu 05 Sep '11

05 Sep '11

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + static WCHAR string[MAX_PATH]; Why make this static? It's only a temporary buffer and it's only used once, when building the cache. Octavian

2 1

Re: cmd: Avoid unneeded local variable in WCMD_goto
by Frédéric Delanoy 04 Sep '11

04 Sep '11

2011/9/4 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) Please ignore this patch. The changes it brings are incorporated in another patch ("cmd: Avoid rereading batch file for every call/goto executed") Frédéric

1 0

WINEDEBUG=warn+heap make test crashes in dsound?
by Dan Kegel 04 Sep '11

04 Sep '11

Hi Michael, is this up your alley? You've been looking at dsound recently, iirc. - Dan export WINEDEBUG=warn+heap ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so ds3d.c && touch ds3d.ok ALSA lib pcm_pulse.c:1008:(_snd_pcm_pulse_open) Unknown field handle_underrun ... ds3d.c:467: Test failed: buffer size changed after SetFormat() - previous size was 88200, current size is 22052 fixme:dsound3d:IDirectSound3DListenerImpl_QueryInterface Unknown IID {31efac30-515c-11d0-a9aa-00aa0061be93} wine: Unhandled page fault on read access to 0xfeef021a at address 0x68d6775f (thread 002c), starting debugger... Backtrace: =>0 0x68d6775f IDirectSound3DListenerImpl_Release+0xe9(iface=0x1d5170) [/home/dank/wine-git/dlls/dsound/sound3d.c:791] in dsound (0x0033f768) 1 0x684bce32 test_primary_3d_with_listener+0x677(lpGuid=(nil)) [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1228] in dsound_test (0x0033f868) 2 0x684bd181 dsenum_callback+0x183(lpGuid=(nil), lpcstrDescription="Primary Sound Driver", lpcstrModule="", lpContext=0x0(nil)) [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1283] in dsound_test (0x0033f8a8) 3 0x68d558e4 a_to_w_callback+0xe0(guid=(nil), descW="Primary Sound Driver", modW="", data=0x33fc80) [/home/dank/wine-git/dlls/dsound/dsound_main.c:291] in dsound (0x0033f938) 4 0x68d55c3b DirectSoundEnumerateW+0x2ab(lpDSEnumCallback=0x68d55803, lpContext=0x33fc80) [/home/dank/wine-git/dlls/dsound/dsound_main.c:370] in dsound (0x0033fc68) 5 0x68d55985 DirectSoundEnumerateA+0x88(lpDSEnumCallback=0x684bcffd, lpContext=0x0(nil)) [/home/dank/wine-git/dlls/dsound/dsound_main.c:321] in dsound (0x0033fc98) 6 0x684bd50d ds3d_tests+0x2a() [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1307] in dsound_test (0x0033fcc8) 7 0x684bd5cd func_ds3d+0x7b() [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1326] in dsound_test (0x0033fcf8) 8 0x684d04d3 run_test+0x9e(name="ds3d.c") [/home/dank/wine-git/dlls/dsound/tests/../../../include/wine/test.h:556] in dsound_test (0x0033fd58)

2 1

RFC - The ProductName registry entry
by Bruno Jesus 04 Sep '11

04 Sep '11

Louis Lenders sent the following url patch to fix bug #28065, it was rejected because it fixes the product name so even if you set other version inside winecfg the registry entry will still say "Windows XP". http://www.winehq.org/pipermail/wine-patches/2011-August/105414.html I have made a small change to winecfg to make it save the correct ProductName based on the selected OS and would like comments. If I ever send my patch to git Louis Lenders patch will need to get in too because we would need a default ProductName setting in registry and his patch was correct because the default wine OS is XP, am I right? The patch is quite simple and it tries to never let 2 ProductName exist in different windows versions. Thanks in advance, Bruno

1 0

bug in OLEPictureImpl_Load (and possibly other stream readers)
by Michael Blumenkrantz 04 Sep '11

04 Sep '11

Hi, I have been working with Bernhard Loos (jhgf) for the past couple days to track down the source of http://bugs.winehq.org/show_bug.cgi?id=28235, and today I am happy to report that I have finally located it!. Attached are two files: olefail.cpp - the source olefail.txt - actually olefail.exe renamed to evade mailing list filters :) This is a tiny demo app, most of which is copied right out of MSDN, which showcases the problem. To break it down: *On Windows, OLEPictureImpl_Load will read exactly 2 bytes for the header to attempt to determine the length in the case that the stat() member function of the stream interface is broken. This is acknowledged in a large block comment at olepicture.c:1339. Wine then ignores this fact and reads 8 bytes. This is just the tip of the bug, however! *The major bug is that after this, at olepicture.c:1412, wine decides to attempt to read a buffer of unknown size and content UNTIL THE END OF THE BUFFER. While this may work for reading a string, when reading a binary buffer you MUST know the size. I'm sure we all know this :) *Unless the stream reader interface is fairly smart at this point and returns 0 bytes read (which seems unlikely if the stat() mechanism is broken), wine is guaranteed to crash. The solution here is to remove the broken "try until you die" method of attempting to read more than 2 bytes of the unknown buffer. Instead, simply return an error as Windows does and move on.

1 0

Re: [PATCH 1/2] d3dx9: Do not allocate ctab memory, reuse the shader blob.
by Rico Schüller 03 Sep '11

03 Sep '11

Please do not apply, it breaks some else which doesn't have a test, yet. Am 03.09.2011 09:32, schrieb Rico Schüller: > --- > dlls/d3dx9_36/shader.c | 11 +--------- > dlls/d3dx9_36/tests/shader.c | 43 > ++++++++++++++++++++++++++++++++--------- > 2 files changed, 34 insertions(+), 20 deletions(-) > > > >

1 0

Re: [PATCH 1/2] d3dx9: Do not allocate ctab memory, reuse the shader blob.
by Marvin 03 Sep '11

03 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13934 Your paranoid android. === WVISTAADM (32 bit shader) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

[patch] Fake display interface
by Jari Vetoniemi 02 Sep '11

02 Sep '11

Hello, I personally hate when applications decide to change my screen resolution without asking me, or some applications just won't run inside window. So I did fake display interface for the winex11.drv. It allows you to send any display resolution and frequency to the application, but it does not change resolution. It's small and simple patch, and won't probably ever be included into the mainline wine. However I'll post it here as it might be useful for some. To enable, create string key UseFakeDisp with value Y in H_C_U/Software/Wine/X11 Driver Default fake resolution is 800x600 60HZ, you can change default with registry keys FakeDispHeight, FakeDispWidth, FakeDispFreq You can also use env variable WINE_FAKEDISP=WIDTHxHEIGHT_FREQ (eg. WINE_FAKEDISP=1024x768_60) Might improve it later to use the same syntax for default resolution and allow multiple fake resolutions to be defined with ; separator. This is also useful for dual head setups where you may want to run game or application fullscreen on other monitor while still keeping the other alive. There is also interesting side effect: While some applications throw error or won't run on resolutions they don't support, some applications that don't support them still run with the resolution specified. Eg. I can run Ys games with 1440x900 resolution where they normally would not run, and they look great. Cheers.

2 1

Re: [PATCH] server: if a debugger is attached to a process, the DEBUG_ONLY_THIS_PROCESS should get set
by Alexandre Julliard 02 Sep '11

02 Sep '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -825,6 +825,9 @@ int set_process_debug_flag( struct process *process, int flag ) > { > char data = (flag != 0); > > + process->create_flags = (process->create_flags & ~(DEBUG_PROCESS | DEBUG_ONLY_THIS_PROCESS)) > + | flag; > + I don't think this belongs in set_process_debug_flag, that's a different flag. Also I don't see what DEBUG_PROCESS is here for. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/201 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

3 3

re: po: Fix some typography issues in the Czech translation.
by Dan Kegel 02 Sep '11

02 Sep '11

This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here. Buildbot said: Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git and here's what I get when I do it by hand: $ wget http://source.winehq.org/patches/data/78249 $ git apply 78249 typocz.patch:31: trailing whitespace. msgstr "Ověřte prosím, že název souboru byl zadán správně" typocz.patch:40: trailing whitespace. "Chcete ho vytvořit?" typocz.patch:49: trailing whitespace. "Chcete ho přepsat novým?" typocz.patch:54: trailing whitespace. msgstr "Nedovolený(é) znak(y) v cestě k souboru" typocz.patch:63: trailing whitespace. "Chcete ho přepsat novým?" error: patch failed: po/cs.po:210 error: po/cs.po: patch does not apply

3 4

Re: 78262: Subject: [2/6] dinput: Added enumerated devices to ConfigureDevices dialog (try 3)
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/208 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

3 2

Re: regedit: Remove the printing code
by Frédéric Delanoy 02 Sep '11

02 Sep '11

2011/9/1 André Hentschel <nerv(a)dawncrow.de>: > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives That's not a reason IMHO. What should be done is fix the printing so it works like on windows (or put an error box: "not yet implemented", or similar)

1 0

Re: [PATCH 10/10] mshtml: Added more IHTMLElement_{put, get}_onclick tests
by Marvin 02 Sep '11

02 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13915 Your paranoid android. === W2K3R2SESP2 (32 bit events) === Timeout === W2K8SE (32 bit events) === Timeout

1 0

Re: [PATCH 6/6] jscript/tests: Added decodeURI tests
by Marvin 02 Sep '11

02 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13910 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/6] jscript: Throw exception on error in JSGlobal_encodeURIComponent
by Marvin 02 Sep '11

02 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13909 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)
by Marvin 02 Sep '11

02 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13889 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead

4 4

Re: regedit: Remove the printing code
by Jerome Leclanche 02 Sep '11

02 Sep '11

To be fair, that feature is available on Windows. 2011/9/1 André Hentschel <nerv(a)dawncrow.de>: > It does nothing (except confusing) > beside that i doubt someone wants to print registry hives > > --- > programs/regedit/En.rc | 1 - > programs/regedit/framewnd.c | 77 ------------------------------------------- > programs/regedit/regedit.rc | 3 -- > programs/regedit/resource.h | 3 -- > 4 files changed, 0 insertions(+), 84 deletions(-) > > diff --git a/programs/regedit/En.rc b/programs/regedit/En.rc > index 35411d2..512f528 100644 > --- a/programs/regedit/En.rc > +++ b/programs/regedit/En.rc > @@ -162,7 +162,6 @@ END > IDC_REGEDIT ACCELERATORS > { > "^F", ID_EDIT_FIND > - "^P", ID_REGISTRY_PRINT > VK_DELETE, ID_EDIT_DELETE, VIRTKEY > VK_F1, ID_HELP_HELPTOPICS, VIRTKEY > VK_F2, ID_EDIT_RENAME, VIRTKEY > diff --git a/programs/regedit/framewnd.c b/programs/regedit/framewnd.c > index 0cdedec..0f8b485 100644 > --- a/programs/regedit/framewnd.c > +++ b/programs/regedit/framewnd.c > @@ -392,71 +392,6 @@ static BOOL ExportRegistryFile(HWND hWnd) > return TRUE; > } > > -static BOOL PrintRegistryHive(HWND hWnd, LPCWSTR path) > -{ > -#if 1 > - PRINTDLGW pd; > - > - ZeroMemory(&pd, sizeof(PRINTDLGW)); > - pd.lStructSize = sizeof(PRINTDLGW); > - pd.hwndOwner = hWnd; > - pd.hDevMode = NULL; /* Don't forget to free or store hDevMode*/ > - pd.hDevNames = NULL; /* Don't forget to free or store hDevNames*/ > - pd.Flags = PD_USEDEVMODECOPIESANDCOLLATE | PD_RETURNDC; > - pd.nCopies = 1; > - pd.nFromPage = 0xFFFF; > - pd.nToPage = 0xFFFF; > - pd.nMinPage = 1; > - pd.nMaxPage = 0xFFFF; > - if (PrintDlgW(&pd)) { > - /* GDI calls to render output. */ > - DeleteDC(pd.hDC); /* Delete DC when done.*/ > - } > -#else > - HRESULT hResult; > - PRINTDLGEXW pd; > - > - hResult = PrintDlgExW(&pd); > - if (hResult == S_OK) { > - switch (pd.dwResultAction) { > - case PD_RESULT_APPLY: > - /*The user clicked the Apply button and later clicked the Cancel button. This indicates that the user wants to apply the changes made in the property sheet, but does not yet want to print. The PRINTDLGEX structure contains the information specified by the user at the time the Apply button was clicked. */ > - break; > - case PD_RESULT_CANCEL: > - /*The user clicked the Cancel button. The information in the PRINTDLGEX structure is unchanged. */ > - break; > - case PD_RESULT_PRINT: > - /*The user clicked the Print button. The PRINTDLGEX structure contains the information specified by the user. */ > - break; > - default: > - break; > - } > - } else { > - switch (hResult) { > - case E_OUTOFMEMORY: > - /*Insufficient memory. */ > - break; > - case E_INVALIDARG: > - /* One or more arguments are invalid. */ > - break; > - case E_POINTER: > - /*Invalid pointer. */ > - break; > - case E_HANDLE: > - /*Invalid handle. */ > - break; > - case E_FAIL: > - /*Unspecified error. */ > - break; > - default: > - break; > - } > - return FALSE; > - } > -#endif > - return TRUE; > -} > - > static BOOL CopyKeyName(HWND hWnd, LPCWSTR keyName) > { > BOOL result; > @@ -677,12 +612,6 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > case ID_REGISTRY_EXPORTREGISTRYFILE: > ExportRegistryFile(hWnd); > break; > - case ID_REGISTRY_PRINT: > - { > - const WCHAR empty = 0; > - PrintRegistryHive(hWnd, &empty); > - break; > - } > case ID_EDIT_DELETE: > { > HWND hWndDelete = GetFocus(); > @@ -831,12 +760,6 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) > HeapFree(GetProcessHeap(), 0, keyPath); > } > break; > - case ID_REGISTRY_PRINTERSETUP: > - /*PRINTDLG pd;*/ > - /*PrintDlg(&pd);*/ > - /*PAGESETUPDLG psd;*/ > - /*PageSetupDlg(&psd);*/ > - break; > case ID_REGISTRY_OPENLOCAL: > break; > case ID_REGISTRY_EXIT: > diff --git a/programs/regedit/regedit.rc b/programs/regedit/regedit.rc > index 8d3b333..a5a1ad3 100644 > --- a/programs/regedit/regedit.rc > +++ b/programs/regedit/regedit.rc > @@ -33,8 +33,6 @@ BEGIN > MENUITEM "&Import Registry File...", ID_REGISTRY_IMPORTREGISTRYFILE > MENUITEM "&Export Registry File...", ID_REGISTRY_EXPORTREGISTRYFILE > MENUITEM SEPARATOR > - MENUITEM "&Print...\tCtrl+P", ID_REGISTRY_PRINT > - MENUITEM SEPARATOR > MENUITEM "E&xit", ID_REGISTRY_EXIT > END > POPUP "&Edit" > @@ -150,7 +148,6 @@ BEGIN > ID_REGISTRY_IMPORTREGISTRYFILE "Imports a text file into the registry" > ID_REGISTRY_EXPORTREGISTRYFILE > "Exports all or part of the registry to a text file" > - ID_REGISTRY_PRINT "Prints all or part of the registry" > /* ID_HELP_HELPTOPICS "Opens registry editor help" */ > ID_HELP_ABOUT "Displays program information, version number and copyright" > END > diff --git a/programs/regedit/resource.h b/programs/regedit/resource.h > index 020765e..1d5934e 100644 > --- a/programs/regedit/resource.h > +++ b/programs/regedit/resource.h > @@ -77,7 +77,6 @@ > #define ID_EDIT_NEW_DWORDVALUE 32788 > #define ID_REGISTRY_IMPORTREGISTRYFILE 32789 > #define ID_REGISTRY_EXPORTREGISTRYFILE 32790 > -#define ID_REGISTRY_PRINT 32793 > #define ID_HELP_HELPTOPICS 32794 > #define ID_HELP_ABOUT 32795 > #define ID_WINDOW_CASCADE 32797 > @@ -113,8 +112,6 @@ > #define ID_REGISTRY_RESTORE 32829 > #define ID_REGISTRY_SAVEKEY 32830 > #define ID_REGISTRY_SELECTCOMPUTER 32831 > -#define ID_REGISTRY_PRINTSUBTREE 32832 > -#define ID_REGISTRY_PRINTERSETUP 32833 > #define ID_REGISTRY_SAVESUBTREEAS 32834 > #define IDS_LICENSE 32835 > #define IDS_ERROR 32836 > -- > > Best Regards, André Hentschel > > >

1 0

Re: kernel32: Fix writing to a pipe in WriteConsoleW().
by Eric Pouech 02 Sep '11

02 Sep '11

Le 03/08/2011 18:07, Francois Gouget a écrit : > WriteFile() checks if the handle corresponds to the console and if it > does invokes WriteConsoleA(). This barely escaped an infinite loop but > messed up the string encoding as CP_UNIXCP is usually different from > CP_ACP. > --- > > I noticed this issue while testing the net.exe tool. After making it > use WineConsole() I was getting the following outputs: > > $ wine net stop > Spécifie le service à arrêter. > $ ./wine net stop | cat > Sp├®cifie le service ├á arr├¬ter. > > It turns out that it's because we only get through the WineConsoleW() -> > WriteFile() -> WriteConsoleA() loop in the second case. could you elaborate a bit more. in case of wine ... | cat, the standard output should be a pipe not a console so writeconsoleW is supposed to fail so it would make more sense to simply let WriteConsoleW fail when is_console_handle(hConsoleOutput) is FALSE ? (similar functions as WriteConsoleA, ReadConsoleA/W should be protected the same way) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 4

Re: Separate list for bots
by Dan Kegel 02 Sep '11

02 Sep '11

Sorry for the mail storm, I've disabled mail again. (I out running errands all afternoon/evening, or I probably would have done that sooner.) As it happens, there is already a nearly unused mailing list for wine test results; I'll send results there from now on, at least until we work out more of the kinks. http://www.winehq.org/mailman/listinfo/wine-tests-results In this case, Henri had a proposed fix; maybe if Alexandre had committed it, the storm of error messages would have ceased. It's funny; I can't reproduce that crash manually, only through the buildbot. But I do see the tail overwrite clearly with warn+heap; perhaps it's time to add a bot that flags new warn+heap errors. - Dan

1 0

Re: 78291: Subject: urlmon/tests: Print out the wrong mime
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/235 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78287: Subject: po: Update German translation
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/231 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78286: Subject: Polish translation for release 1.3.27
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/230 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78285: Subject: [PATCH] po: Update Japanese translation.
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/229 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78284: Subject: user32: Fix support for CB_SETDROPPEDWIDTH in combobox
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/228 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78283: Subject: [PATCH] po: Update Japanese translation.
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/227 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Separate list for bots
by Peter Urbanec 02 Sep '11

02 Sep '11

wine-devel has been seeing more and more robot generated messages. Would it make sense to create wine-bots list for buildbot, testbot and friends? Automated messages could go to author, wine-bots with Reply-To: and Followup-To: pointing at wine-devel That way wine-devel could be returned to humans again. :-)

2 1

Re: 78278: Subject: [po]updated korean resource
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/223 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78276: Subject: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/219 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78273: Subject: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by buildbot＠kegel.com 02 Sep '11

02 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/218 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78272: Subject: widl: duplicate type in case of argument with range attribute
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/217 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78271: Subject: rpcrt4:properly unmarshall EMUM16 discriminant
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/216 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78270: Subject: widl: duplicate type in case of argument with range attribute
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/215 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78269: Subject: Polish translation for release 1.3.27
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/214 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78268: Subject: view: Install it inside Wine
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/213 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [1/6] dinput: Added ConfigureDevices dialog (try 3)
by Octavian Voicu 01 Sep '11

01 Sep '11

On Thu, Sep 1, 2011 at 9:34 PM, Lucas Fialho Zawacki <lfzawacki(a)gmail.com> wrote: > +STRINGTABLE > +BEGIN > + IDS_ACTIONCOLUMN "Action" > + IDS_OBJECTCOLUMN "Object" > +END I think you should only keep the string table in dinput.rc. The dialog(s) should go in En.rc so they can be localized, like it's done in winecfg [1]. You probably should also add this to both .rc files: LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT Octavian [1] http://source.winehq.org/git/wine.git/tree/HEAD:/programs/winecfg

1 0

Re: 78267: Subject: [6/6] dinput: Working CANCEL and RESET buttons in ConfigureDevices dialog (try 3)
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/212 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: documentation: Remove ChangeLog.*.
by Octavian Voicu 01 Sep '11

01 Sep '11

On Wed, Aug 31, 2011 at 3:25 PM, Octavian Voicu wrote: > They are not used anymore. Last change was with the release of wine 1.0. > Sent as attachment because of the huge lines. Alexandre, This patch was sent before I got your reply on wine-devel, so you can ignore it. Probably was in the moderation queue because it is totally huge... Octavian

1 0

Re: 78264: Subject: [5/6] dinput: Added possibility to change the action mapping in the ConfigureDevices dialog (try 3)
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/211 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78265: Subject: [3/6] dinput: Added object/action enumeration to ConfigureDevices dialog (try 3)
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/209 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78261: Subject: [1/6] dinput: Added ConfigureDevices dialog (try 3)
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/207 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78266: Subject: regedit: Remove the printing code
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/206 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78260: Subject: [PATCH 5/5] wined3d: Make the device parameter to wined3d_device_get_clip_plane() const.
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/205 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13899 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead

1 0

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13898 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@

1 0

Re: 78259: Subject: [PATCH 4/5] wined3d: Make the device parameter to wined3d_device_get_light_enable() const.
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/204 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [PATCH 4/5] cmd: fix handling of special characters
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13897 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0@space@

1 0

Re: [PATCH 3/5] cmd: improve treatment of quotes in command line
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13896 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@

1 0

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13895 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@

1 0

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by Marvin 01 Sep '11

01 Sep '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13894 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p@space@"1,2:p"@space@"2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1@space@p",2:2@space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0@space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine@0@space@

1 0

Re: 78258: Subject: [PATCH 3/5] wined3d: Get rid of some redundant else statements in IWineD3DSurfaceImpl_BltOverride().
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/203 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs
by Henri Verbeet 01 Sep '11

01 Sep '11

On 1 September 2011 11:01, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > case 32: > if(DDPixelFormat->u2.dwStencilBitDepth == 8) > return WINED3DFMT_D24_UNORM_S8_UINT; > - else > + else if (DDPixelFormat->u2.dwStencilBitDepth == 4) > return WINED3DFMT_S4X4_UINT_D24_UNORM; I'm not sure if this is intentional or not, but you fallthrough to the default case here. If that's intentional, a /* Fallthrough */ or similar comment wouldn't hurt. On the other hand, you do explicitly handle it in the no-stencil case.

2 1

Re: [1/7] cmd: Add support for LSS comparison operator in if statements
by Alexandre Julliard 01 Sep '11

01 Sep '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > + else if ((s = StrStrIW (p, lssW))) { > + s += 3; > + a = StrToIntW(condition); > + b = StrToIntW(WCMD_parameter (s, 0, NULL)); I don't think you want to use strstr for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix a few pointer cast warnings.
by Alexandre Julliard 01 Sep '11

01 Sep '11

Jerome Leclanche <adys.wh(a)gmail.com> writes: > From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 > From: Jerome Leclanche <adys@azura> > Date: Thu, 1 Sep 2011 12:51:26 +0100 > Subject: [PATCH] setupapi: Fix a few pointer cast warnings. That's just hiding the pointer truncation bug. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab
by Dan Kegel 01 Sep '11

01 Sep '11

On Wed, Aug 31, 2011 at 1:10 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/161 > BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=wine-patches&m=131134541100364&w=2 I see that the July 22nd version seems to have interesting strings, but the August 31st version has all question marks when it comes to non-ascii text. What happened between the two? http://source.winehq.org/patches/data/78217, which is where I pulled the patch from, also has the question marks.

2 2

Re: services: Issue a fixme when a service fails to start.
by Octavian Voicu 01 Sep '11

01 Sep '11

On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) > argv[0] = service->name; > argv[1] = NULL; > err = service_start(service, 1, argv); > - /* FIXME: do something if the service failed to start */ > + if (err != ERROR_SUCCESS) > + WINE_FIXME("do something if the service failed to start %d\n", err); Why not print something more informative? This looks nice and also tells you which service did not start: WINE_FIXME("Auto-start service %s failed to start: %d\n", wine_dbgstr_w(service->name), err); Octavian

1 0

Re: file
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
by Stefan Dösinger 01 Sep '11

01 Sep '11

On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote: > This imlicitly gets rid of the "auto" option as well, since there's no way > to explicitly specify it. This will no doubt cause its share of > regressions, but I prefer actually fixing those bugs to running into the > surface implementation switching code every time I try to fix something in > ddraw. This will break 2D-only apps in situations where OpenGL is not available. It would be a good idea to use SURFACE_GDI automatically in those situations. (I'm not sure if ddraw without GL works at all right now, we have no systems that run the tests with this setup) It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with me, it's not like those apps are working at the moment, and I guess the switching breaks more than it fixes.

2 3

winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol.
by Joerg-Cyril.Hoehle＠t-systems.com 01 Sep '11

01 Sep '11

Hi, I've one idea left about what may have caused the 2 apply failures. The patches are in my git queue just above wine-1.3.27 and the unrelated Valgrind hacks, so in theory, they should work. However the patches depend on each other, but since I reused the subject line of patches originally submitted with several days spacing between them, I forgot to add [PATCH 1/N] this week. The order is: 0001-winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol. 0002-mmdevapi: Do not mix frames and bytes. (in git now, but should not interfere) 0003-mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them. Perhaps you tried out UINT32 first? Please try Get/Release first. My apology for the trouble, Jörg Höhle

1 0

Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog
by Alexandre Julliard 01 Sep '11

01 Sep '11

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > +static INT_PTR CALLBACK ConfigureDevicesDlgProc(HWND dialog, UINT uMsg, WPARAM wParam, LPARAM lParam) > +{ > + static LPDIACTIONFORMATW lpdiaf; > + static DIDevicesData devices_data; > + static ConfigureDevicesData *conf_data; > + > + switch(uMsg) > + { > + case WM_INITDIALOG: > + /* Initialize action format and enumerate devices */ > + conf_data = (ConfigureDevicesData*) lParam; > + lpdiaf = conf_data->params->lprgFormats; It doesn't make sense to pass the info as WM_INITDIALG parameter if it's going to be stored in global variables anyway. A better way would be to store this in the window info. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: 78223: Subject: configure: fix configure failures under -Werror -Wall
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/168 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: 78222: Subject: configure: AC_C_CONST is obsolete
by buildbot＠kegel.com 01 Sep '11

01 Sep '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/167 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

WineHQ Maintenance.
by Jeremy Newman 01 Sep '11

01 Sep '11

We will be performing upgrades and maintenance to the WineHQ.org server starting at 1800 CDT on Wednesday August 31st. This process will take the server off-line for about an hour. The Websites (www,appdb,forums), and Mailing lists, and Git will be off-line during this period. -Newman

1 1

Re: fake patch #2 just to test error emails
by buildbot＠kegel.com 31 Aug '11

31 Aug '11

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/166 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot

1 0

Re: cmd/tests: Add README doc file
by Alexandre Julliard 31 Aug '11

31 Aug '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > programs/cmd/tests/README | 120 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 120 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/README That sort of thing should be on the wiki. READMEs in the source are never maintained properly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: 78214: Subject: winusb: add new stub dll (resend)
by Dan Kegel 31 Aug '11

31 Aug '11

On Wed, Aug 31, 2011 at 1:00 PM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/158 > BUILD FAILED: failed git > > > For more info about this message, see http://wiki.winehq.org/BuildBot The error was fatal: corrupt patch at line 32 Your email program may have removed whitespace from the patch. Try attaching the patch instead of including it inline.

1 0

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
by Frédéric Delanoy 31 Aug '11

31 Aug '11

On Tue, Aug 30, 2011 at 00:34, Martin Wilck <mwilck(a)arcor.de> wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > Follow-up patches will fix the marked TODOs. > --- > programs/cmd/tests/rsrc.rc | 6 + > programs/cmd/tests/test_parsing.cmd | 158 +++++++++++++++++++++++++++++++ > programs/cmd/tests/test_parsing.cmd.exp | 77 +++++++++++++++ > 3 files changed, 241 insertions(+), 0 deletions(-) > create mode 100644 programs/cmd/tests/test_parsing.cmd > create mode 100644 programs/cmd/tests/test_parsing.cmd.exp Some of those tests are already present in the test_builtins.cmd* (e.g. the spacing tests) You should probably integrated your tests in there: that makes it easier to spot regressions and helps prevent tests duplication Also, see http://www.winehq.org/pipermail/wine-devel/2011-August/091817.html Frédéric Delanoy

2 6

d3dx9_36/tests: Fix printing a NULL string
by Joerg-Cyril.Hoehle＠t-systems.com 31 Aug '11

31 Aug '11

André Hentschel suggested: >Should stop the crash on Solaris and maybe others >- trace("parent_data = (%p) -> %s\n", parent_data, (char *)parent_data); >+ trace("parent_data (%p) -> %s\n", parent_data, parent_data ? (char *)parent_data : "(null)"); This is sooo backwards. You don't want to try and find all places where (null) may be printed. I remember seeing (null) in logs here and there, so you're telling us that turning on Wine logs in Solaris can randomly crash Wine because it crashes on printf("%s", NULL)? I'm very surprised. I thought Solaris was one of the first machines - decades ago - where I observed "(null)" for NULL. (Or is that really glibc only?) Regards, Jörg Höhle

5 6

Re: [PATCH 2/5] ddraw: Get rid of the surface implementation switching code.
by Alexandre Julliard 31 Aug '11

31 Aug '11

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Despite what the comment says, switching the implementation of an already > created surface isn't so straightforward. > --- > dlls/ddraw/ddraw.c | 179 +-------------------------------------------- > dlls/ddraw/surface.c | 25 ------- > dlls/wined3d/swapchain.c | 4 +- > include/wine/wined3d.h | 1 - > 4 files changed, 6 insertions(+), 203 deletions(-) This one is causing crashes on 64-bit: ../../../../wine/tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so ../../../../wine/dlls/d3d8/tests/buffer.c && touch buffer.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x2b631b0deede (thread 0021), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 64-bit code (0x00002b631b0deede). Register dump: rip:00002b631b0deede rsp:000000000023f3a0 rbp:000000000023f45a eflags:00010246 ( R- -- I Z- -P- ) rax:0000000000000001 rbx:0000000000000000 rcx:0000000000000018 rdx:000000000023f459 rsi:000000000023f45a rdi:0000000000000000 r8:000000000023f45c r9:000000000023f45b r10:000000000023f45c r11:000000000023f330 r12:000000000023f459 r13:0000000000000000 r14:000000000003b5e0 r15:00002b631b0f00e0 Stack dump: 0x000000000023f3a0: 0000000000000000 0000000000000094 0x000000000023f3b0: 0000000000032ed0 0000000000000094 0x000000000023f3c0: 0000000000032ed0 000000000003e9f0 0x000000000023f3d0: 0000000000000000 00002b631b0307df 0x000000000023f3e0: ffffffffffffffff ffffff00ffffffff 0x000000000023f3f0: 0000000000202020 0000000020000000 0x000000000023f400: 0000000000000000 00000000ffffff00 0x000000000023f410: 0000000000000254 0000000000000000 0x000000000023f420: 0000000000000000 0000000000000000 0x000000000023f430: 0000000000000000 0000000000000000 0x000000000023f440: 0000000000000000 0000000000000000 0x000000000023f450: 5b5b5b5b5b5b5b5b 0808080018000020 Backtrace: =>0 0x00002b631b0deede getDepthStencilBits+0x2e(format=(nil), depthSize="", stencilSize="") [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/utils.c:2598] in wined3d (0x000000000023f45a) 1 0x00002b631b0307df context_choose_pixel_format+0xfe(device=0x3e9f0, hdc=0x254, color_format=0x3b5e0, ds_format=(nil), auxBuffers=0, findCompatible=0) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:1139] in wined3d (0x0000000000032ed0) 2 0x00002b631b034b79 context_create+0xc8(swapchain=0x58b80, target=0x358f0, ds_format=(nil)) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:1350] in wined3d (0x0000000000032ed0) 3 0x00002b631b0d297b swapchain_get_context+0x7a(swapchain=0x58b80) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/swapchain.c:1179] in wined3d (0x00000000000358f0) 4 0x00002b631b03a155 context_acquire+0x314(device=0x3e9f0, target=0x358f0) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/context.c:2455] in wined3d (0x00000000000358f0) 5 0x00002b631b047858 wined3d_device_init_3d+0x497(device=0x3e9f0, present_parameters=0x23f810) [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/device.c:1335] in wined3d (0x0000000000032ed0) 6 0x00002b631add142a device_init+0x1b9(device=0x36710, parent=0x2f380, wined3d=0x32eb0, adapter=<is not available>, device_type=<is not available>, focus_window=(nil), flags=0x40, parameters=0x23fae0) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/../../../wine/dlls/d3d8/device.c:3112] in d3d8 (0x000000000023fae0) 7 0x00002b631add194b IDirect3D8Impl_CreateDevice+0x10a(iface=0x2f380, adapter=0, device_type=D3DDEVTYPE_HAL, focus_window=(nil), flags=0x40, parameters=0x23fae0, device=0x23fb38) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/../../../wine/dlls/d3d8/directx.c:371] in d3d8 (0x0000000000036710) 8 0x00002b6316db08d7 func_buffer+0x196() [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/dlls/d3d8/tests/buffer.c:61] in d3d8_test (0x000000000023fb38) 9 0x00002b6316dd06c7 run_test+0x126(name="../../../../wine/dlls/d3d8/tests/buffer.c") [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/include/wine/test.h:556] in d3d8_test (0x00002b6316dd95d7) 10 0x00002b6316dd11f6 main+0x115(argc=<is not available>, argv=0x106f0) [/home/julliard/wine/build/obj-elf64/dlls/d3d8/tests/../../../../wine/include/wine/test.h:624] in d3d8_test (0x00000000000106f0) 11 0x00002b6316dd13fe __wine_spec_exe_entry+0xcd(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x00002b630ed8a908) 12 0x000000007b87217f start_process+0xbe(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1056] in kernel32 (0x00002b6316dd1330) 13 0x00002b630f5e5f7b call_thread_func+0x6a(entry=0x7b8720c0, arg=0x7fffffbef000, frame=0x23f459) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3189] in ntdll (0x00007fffafa61d40) 14 0x00002b630f5df856 call_thread_entry_point+0x29() in ntdll (0x00007fffafa61d40) 15 0x00002b630f5b0b66 start_process+0x15(kernel_start=0x23fec8) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2612] in ntdll (0x00007fffafa61d40) 16 0x00002b630ea64213 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fffafa61d40) 17 0x00002b630ea64269 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 18 0x00002b630f5b673e LdrInitializeThunk+0x3dd(kernel_start=0x7b8720c0, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2668] in ntdll (0x00007fffffbef000) 19 0x000000007b8788d2 __wine_kernel_init+0x921() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1257] in kernel32 (0x00007fffafa62fd0) 20 0x00002b630f5b7174 __wine_process_init+0x253() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2877] in ntdll (0x00007fffafa6321c) 21 0x00002b630ea621ef wine_init+0x29e(argc=<is not available>, argv=0x7fffafa637a8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fffafa632b0) 22 0x000000007bf00de1 main+0x70(argc=0x3, argv=0x7fffafa637a8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:228] in <wine-loader> (0x0000000000000003) 23 0x00002b630efedead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fffafa63798) [/home/aurel32/eglibc/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 24 0x000000007bf00ca9 _start+0x28() in <wine-loader> (0x0000000000000000) 0x00002b631b0deede getDepthStencilBits+0x2e [/home/julliard/wine/build/obj-elf64/dlls/wined3d/../../../wine/dlls/wined3d/utils.c:2598] in wined3d: movl (%rbx),%edi 2598 switch (format->id) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] msi: reorder tables to optimize condition evaluation
by Dan Kegel 31 Aug '11

31 Aug '11

On Wed, Aug 31, 2011 at 3:10 AM, <buildbot(a)buildbot.kegel.com> wrote: > The Buildbot has detected a failed build on builder runtests while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/136 > BUILD FAILED: failed shell_3 > > > For more info about this message, see http://wiki.winehq.org/BuildBot This breaks loading of wine's gecko here: ../../../tools/runtest -q -P wine -M ieframe.dll -T ../../.. -p ieframe_test.exe.so webbrowser.c && touch webbrowser.ok wine: Unhandled page fault on write access to 0xa06291fc at address 0x407537e9 (thread 002c), starting debugger... Backtrace: =>0 WHERE_execute+0x17a(view=0x11fe58, record=(nil)) [dlls/msi/where.c:821] 1 SELECT_execute+0x9d(view=0x138408, record=(nil)) [dlls/msi/select.c:181] 2 MSI_ViewExecute+0xb4(query=0x11fce0, rec=(nil)) [dlls/msi/msiquery.c:457] 3 get_product_code+0x55(db=0x12e6f0) [dlls/msi/package.c:1393] 4 get_local_package+0x58(filename="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", localfile="??") [dlls/msi/package.c:1477] 5 MSI_OpenPackageW+0x1f8(szPackage="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", pPackage=0x33fb14) [dlls/msi/package.c:1546] 6 MsiInstallProductW+0xb3(szPackagePath="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi", szCommandLine=0x0(nil)) [dlls/msi/msi.c:245] 7 install_file+0x24(file_name="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi") [dlls/appwiz.cpl/addons.c:164] 8 install_from_unix_file+0x22b(file_name="/usr/share/wine/gecko/wine_gecko-1.3-x86.msi") [dlls/appwiz.cpl/addons.c:207] 9 install_from_default_dir+0x11f() [dlls/appwiz.cpl/addons.c:276] 10 install_wine_gecko+0x2f() [dlls/appwiz.cpl/addons.c:490] 11 start_params+0x3f(params="install_gecko") [dlls/appwiz.cpl/appwiz.c:978] 12 CPlApplet+0x61(hwndCPL=0x6002e, message=0xa, lParam1=0, lParam2=0x12dbce) [dlls/appwiz.cpl/appwiz.c:1013] 13 Control_DoLaunch+0x524(panel=0x33fd50, hWnd=0x6002e, wszCmd="appwiz.cpl install_gecko") [dlls/shell32/control.c:820] in shell32 (0x0033fd20) 14 Control_RunDLLW+0xde(hWnd=0x6002e, hInst=(nil), cmd="appwiz.cpl install_gecko", nCmdShow=0x5) [dlls/shell32/control.c:846] in shell32 (0x0033fd80) 15 launch+0x35(what="appwiz.cpl install_gecko") [programs/control/control.c:55] 16 wWinMain+0x182(hInst=0x684c0000, hPrev=(nil), lpszCmdLine="appwiz.cpl install_gecko", nCmdShow=0x1) [programs/control/control.c:85] 17 wmain+0x10c(argc=0x3, argv=0x110380) [dlls/winecrt0/exe_wmain.c:50] 0x407537e9 WHERE_execute+0x17a [dlls/msi/where.c:821] in msi: movl %edx,0x0(%eax) 821 tables[i++] = table;

1 0

hhctrl: IDTB_XXX resource strings
by Francois Gouget 31 Aug '11

31 Aug '11

The native hhctrl.ocx does not have any resrouce strings. My understanding is that we have them in Wine because we use them as tooltips for the toolbar items. That's good I guess. However a number of them make no sense at all and are a pain to translate. For instance: IDTB_NOTES "IDTB_NOTES" IDTB_BROWSE_FWD "IDTB_BROWSE_FWD" IDTB_BROWSE_BACK "IDT_BROWSE_BACK" or IDTB_JUMP1 "Jump1" IDTB_JUMP2 "Jump2" What's the difference between 'Jump1' and 'Jump2'? Also I have found no proper documentation on this. So does anyone know what to put there so we have strings that correctly describe what these toolbar buttons do? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ question = ( to ) ? be : ! be; -- Wm. Shakespeare

2 6

Re: [PATCH 4/5] mountmgr.sys: Also unlink a:: drive when removing a dos device
by Alexandre Julliard 31 Aug '11

31 Aug '11

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -818,6 +818,7 @@ NTSTATUS remove_dos_device( int letter, const char *udi ) > if ((path = get_dosdevices_path( &p ))) > { > p[0] = 'a' + drive->drive; > + unlink( path ); That's not done on purpose, to make it more likely that we use the same drive letter next time the device is mounted. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/5] kernel32: Add UDF support
by Alexandre Julliard 31 Aug '11

31 Aug '11

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > Based on Steven Wallace work. > Should fix the wine side of bug #26273 It fails here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c && touch volume.ok volume.c:105: Tests skipped: can't test removing fake drive volume.c:359: Test failed: GetVolumeInformationA root failed, last error 66 volume.c:401: Test failed: GetVolumeInformationA with \ failed, last error 66 volume.c:423: Test failed: GetVolumeInformationA failed, last error 66 volume.c:434: Test failed: GetVolumeInformationA failed, last error 66 volume.c:445: Test failed: GetVolumeInformationA failed, root=C:\, last error=66 volume.c:451: Test failed: GetVolumeInformationA did fail, root=\\?\C:\, last error=66 volume.c:458: Test failed: GetVolumeInformationA did fail, root=\\.\C:\, last error=66 volume.c:486: Test failed: GetVolumeInformationA failed, root=\\?\Volume{00000000-0000-0000-0000-000000000043}\, last error=66 make[1]: *** [volume.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 3/5] kernel32: Improve GetVolumeInformation filesystem flags
by Alexandre Julliard 31 Aug '11

31 Aug '11

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > if (fsname) lstrcpynW( fsname, ntfsW, fsname_len ); > if (filename_len) *filename_len = 255; > - if (flags) *flags = FILE_CASE_PRESERVED_NAMES; > + if (flags) *flags = FILE_NAMED_STREAMS | FILE_SUPPORTS_ENCRYPTION | FILE_SUPPORTS_OBJECT_IDS > + | FILE_SUPPORTS_REPARSE_POINTS | FILE_SUPPORTS_SPARSE_FILES | FILE_VOLUME_QUOTAS > + | FILE_FILE_COMPRESSION | FILE_PERSISTENT_ACLS | FILE_UNICODE_ON_DISK > + | FILE_CASE_PRESERVED_NAMES | FILE_CASE_SENSITIVE_SEARCH; I'm not sure it's a good idea to claim features we don't support. Do you have an app that needs this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: fix potential crash when loading unsupported files (with tests) (try 2) (resend)
by Alexandre Julliard 31 Aug '11

31 Aug '11

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -1238,6 +1260,12 @@ static void test_LoadImage(void) > test_LoadImageFile("JPG", jpgimage, sizeof(jpgimage), "jpg", 0); > test_LoadImageFile("PNG", pngimage, sizeof(pngimage), "png", 0); > > + /* Corrupted images */ > + test_LoadCorruptedImageFile("corrupted_BMP", bmpimage, sizeof(bmpimage), "bmp", 1); > + test_LoadCorruptedImageFile("corrupted_GIF", gifimage, sizeof(gifimage), "gif", 0); > + test_LoadCorruptedImageFile("corrupted_JPG", jpgimage, sizeof(jpgimage), "jpg", 0); > + test_LoadCorruptedImageFile("corrupted_PNG", pngimage, sizeof(pngimage), "png", 0); > + That's an interesting test, but it has nothing to do with your fix. We shouldn't crash on loading corrupted files, but we shouldn't crash if idReserved is 0 either. Your proposed fix is just hiding the problem. Checking idReserved may or may not be a good idea, independently of fixing that crash, but that would need a different test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd/tests: Test del /s recursion in subdirectories with colons.
by Frédéric Delanoy 31 Aug '11

31 Aug '11

On Tue, Aug 30, 2011 at 14:19, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > -- > Issue was fixed by 94d2312fe2fdd77669ac826afa24e6821571ebba. This test is to > prevent future regressions, as suggested by Frederic. > > Windows doesn't accept colons in directory names, so it will just fail on the > mkdir/rmdir commands and not affect the tests. > > --- > programs/cmd/tests/test_builtins.cmd | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd > index 1250e89..34c44f5 100644 > --- a/programs/cmd/tests/test_builtins.cmd > +++ b/programs/cmd/tests/test_builtins.cmd > @@ -854,6 +854,7 @@ rmdir del_q_dir > echo ------------ Testing del /s -------------- > mkdir "foo bar" > cd "foo bar" > +mkdir "foo:" > echo hi > file1.dat > echo there > file2.dat > echo bub > file3.dat > @@ -868,6 +869,7 @@ for %%f in (1 2 3) do if exist file%%f.dat echo Del /s failed on file%%f > for %%f in (1 2 3) do if exist file%%f.dat del file%%f.dat > if exist "file with spaces.dat" echo Del /s failed on "file with spaces.dat" > if exist "file with spaces.dat" del "file with spaces.dat" > +rmdir "foo:" > cd .. > rmdir "foo bar" You don't test the result of your 'mkdir "foo:"'. You can't know from the test whether the dir was created and removed, or never existed. You should use something like "if exist ... echo blablabla", or a 'dir /b' in a directory to verify it's not created. Be aware that error messages are generally lost/discarded, so you have to test differently

2 3

Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks (resend)
by Alexandre Julliard 31 Aug '11

31 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { > + if (TRACE_ON(timestamp)) > + { > + LARGE_INTEGER now; > + extern timeout_t server_start_time; Don't add extern statements all over the place, there are functions to return tick counts. Also you probably want a more readable formatting. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] msi: speed up WHERE statement evaluation by evaluating the condition as early as possible
by Alexandre Julliard 31 Aug '11

31 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -639,6 +715,8 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record ) > while ((table = table->next)); > > rows = msi_alloc( wv->table_count * sizeof(*rows) ); > + memset( rows, 0xFF, sizeof( rows ) ); > + If the goal is to set them to -1, please do that explicitly. Also defining some appropriate constant for invalid rows would be even better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Fix a few incorrect pointer/integer casts on x64.
by Michael Stefaniuc 31 Aug '11

31 Aug '11

Hello Octavian, in general please use the ULongToHandle*() / HandleToULong() macro family instead of the explicit casting. Octavian Voicu wrote: > --- > dlls/ieframe/iexplore.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/ieframe/iexplore.c b/dlls/ieframe/iexplore.c > index 99e3003..82c2e79 100644 > --- a/dlls/ieframe/iexplore.c > +++ b/dlls/ieframe/iexplore.c > @@ -937,7 +937,7 @@ static HDDEDATA WINAPI dde_proc(UINT type, UINT uFmt, HCONV hConv, HSZ hsz1, HSZ > switch(type) { > case XTYP_CONNECT: > TRACE("XTYP_CONNECT %p\n", hsz1); > - return (HDDEDATA)!DdeCmpStringHandles(hsz1, ddestr_openurl); > + return (HDDEDATA)(INT_PTR)!DdeCmpStringHandles(hsz1, ddestr_openurl); > > case XTYP_EXECUTE: { > WCHAR *url; > @@ -961,7 +961,7 @@ static HDDEDATA WINAPI dde_proc(UINT type, UINT uFmt, HCONV hConv, HSZ hsz1, HSZ > break; > } > > - ret = (HDDEDATA)open_dde_url(url); > + ret = (HDDEDATA)(ULONG_PTR)open_dde_url(url); This is the only user of open_dde_url() so that helper might as well return a HDDEDATA instead of an ULONG. But that's something for Jacek to decide. > > heap_free(url); > return ret; > @@ -999,7 +999,7 @@ static void init_dde(void) > if(!ddestr_openurl) > WARN("Failed to create string handle: %u\n", DdeGetLastError(dde_inst)); > > - res = (ULONG)DdeNameService(dde_inst, ddestr_iexplore, 0, DNS_REGISTER); > + res = (UINT)(UINT_PTR)DdeNameService(dde_inst, ddestr_iexplore, 0, DNS_REGISTER); > if(res != DMLERR_NO_ERROR) > WARN("DdeNameService failed: %u\n", res); > } thanks bye michael

1 0

Testing edge cases and undocumented behavior
by Joerg-Cyril.Hoehle＠t-systems.com 31 Aug '11

31 Aug '11

Scott Ritchie wrote: >There was a bit of a philosophical discussion on #winehackers about the >merits of creating tests for functions that might be testing undefined >or unimportant behavior. Windows behaves one way, we behave another, >the tests measure this delta, but it's unknown if this will actually >improve a real world application. Vincent Povirk wrote an excellent reply. I hope somebody will turn that into a Wiki page. >More broadly, should we resist any change without a particular >(real-world) application in hand that needs it? This is stupid because you're always late. Like a fireman. a) Somebody who wrote the bug report is waiting for the bug to be fixed ASAP. b) It takes a lot of effort to analyse huge and cryptic log files to find out what the particular delta is. >Or should we err on the side of testable behavior, What you test is what you know. It's not erring. If you don't know what the behaviour should be, you can't add a FIXME pointing out that Wine deviates from native behaviour. When I asked about testing depth w.r.t. the MCI a few years ago, Paul Vriens advised to test to the bones. IMHO that's good advice. I recommend beginners to start writing tests *first*. Doing so, you learn a lot about the component Wine purports to mimic. You can then even start to predict failures! Somehow I believe I'm a very untypical Wine contributor. I'm not bug driven. Quite to the contrary, my thesis is that once you've tested a component to the bones *and* replicated the observable behaviour, there will be few opportunities left for people to report bugs. The basic alternative is that if you have free time now, you can either try to understand obscure logs of some component you're not exactly familiar with and more or less well documented, perhaps single-step your way through the debugger, *OR* you can spend time shedding light on said component via tests, mostly working with logs you control because you're working with full source to your test and the Wine code. That's what I was doing with the audio parts of the MCI before WinMM was rewritten to use mmdevapi. Now that's what I'm doing with mmdevapi. After that, should I still have the energy, I'll look at WinMM audio. Other benefit: - Tests get executed daily whereas an application X can be made to work in wine-X yet break again in X+1 until somebody notices. Regards, Jörg Höhle

4 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel