- wine-devel - winehq.org

Re: dlls/tests: Assorted spelling fixes
by Marvin 03 Aug '11

03 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13236 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout === WVISTAADM (32 bit win) === win.c:1157: Test failed: first call to SetShellWindow(hwnd1) win.c:1159: Test failed: wrong shell window: 0002010E win.c:1196: Test failed: SetShellWindow(hwnd4) win.c:1198: Test failed: wrong shell window: 0002010E - expected hwnd4 win.c:1201: Test failed: wrong next window for hwnd4: 000200EE - expected 0 win.c:1212: Test failed: wrong shell window: 0002010E - expected hwnd4 win.c:1222: Test failed: wrong next window for hwnd4 after SetWindowPos(): 000200EE - expected 0

1 0

Re: cmd: mkdir: complain properly if no arg given (resending)
by Frédéric Delanoy 03 Aug '11

03 Aug '11

On Thu, Aug 4, 2011 at 00:21, Dan Kegel <dank(a)kegel.com> wrote: > Also output the error to stderr, as native does. > > Resending to make testbot happy (first time the odd numbering confused it). You should probably send the WCMD_output_stderr implementation as a separate patch, since it's not mkdir-specific Frédéric

1 0

Re: oleaut32/tests: Skip tests if typelib can't be registered
by Octavian Voicu 03 Aug '11

03 Aug '11

2011/8/3 André Hentschel <nerv(a)dawncrow.de> > a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6 > Doesn't look like a valid commit... which one is that? Octavian

2 1

Re: net: Convert to Unicode. (take 2)
by Francois Gouget 03 Aug '11

03 Aug '11

On Wed, 3 Aug 2011, Francois Gouget wrote: [...] > I sort of modeled this after ipconfig's ipconfig_vprintfW() function. > However that function has a WriteFile() fallback in case WriteConsole() > fails. But I don't see what's the point of this or when using > WriteFile() instead of WriteConsole() would work. So I'm hoping someone > can enlighten me as I see no reason for these two tools to handle things > so differently. But in any case I see this as being the subject of a > separate patch so I think this one can go in. So I think I figured that part out. If I write a simple test application that just does a WriteConsoleW() call and run it on Windows XP SP3, I get the following: * foo.exe -> Works. * foo.exe >foo.txt -> WriteConsoleW() fails, foo.txt is empty. * foo.exe | more -> WriteConsoleW() fails, the message is lost. So ipconfig must have been written so that it works on Windows even if its output is redirected. In Wine applications don't need to fall back to WriteFile() because that's already done by WriteConsoleW(). So the question is: Do we care if these applications don't work right on Windows if their output is redirected? Or from a different point of view: Should these applications take advantage of this Wine-specific behavior or stick to the letter of the API? (Similarly Wine's WriteConsole() will accept a NULL lpNumberOfCharsWritten parameter, not Windows (up to XP SP3 at least). So if we decide our apps are Wine-only, then we could get rid of these annoying 'count' variables.) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 2

NtQuerySystemInformation and exposing unix_pid
by Paul Vriens 03 Aug '11

03 Aug '11

Hi, I would like to add some per-process information in NtQuerySystemInformation with respect to cpu-usage. The wine server doesn't currently expose the unix_pid so I can't use /proc/<pid>/* information. Would it be ok to expose the unix_pid in some of the server calls (like next_process)? Or should all this information (and the /proc handling) go into the server? -- Cheers, Paul.

2 2

Re: user32: fix potential crash when loading unsupported files (with tests)
by Alexandre Julliard 03 Aug '11

03 Aug '11

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -1002,6 +1002,54 @@ static unsigned char gif4pixel[42] = { > 0x02,0x00,0x00,0x02,0x03,0x14,0x16,0x05,0x00,0x3b > }; > > +/* Corrupted images */ > +/* 1x1 pixel corrupted bmp */ > +static unsigned char corruptedbmpimage[38] = { > +0x42,0x4d,0x26,0x00,0x01,0x00,0x00,0x00,0x00,0x00,0x22,0x00,0x00,0x00,0x0c,0x00, > +0x00,0x00,0x01,0x00,0x01,0x00,0x01,0x00,0x01,0x00,0xff,0xff,0xff,0x00,0x55,0x55, > +0x55,0x00,0x00,0x00,0x00,0x00 > +}; You should modify the data in place like other tests already do. There's no reason to duplicate it all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Skip tests if interface is not accessable
by Alexandre Julliard 03 Aug '11

03 Aug '11

André Hentschel <nerv(a)dawncrow.de> writes: > The hole test_ function depends on succeeding here (more than i thought first) Actually you'd want to skip even more than that, the real failure is earlier. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Update GLSL spam filter for recent fglrx versions.
by Stefan Dösinger 03 Aug '11

03 Aug '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 03.08.2011 um 17:31 schrieb Matteo Bruni: > Users tend to get confused by those messages on the terminal. Since we > already have code to filter irrelevant GLSL compiler messages, let's > update it. I think the plan a while ago was to remove the spam filter and not print driver messages as FIXMEs(just as WARNs or TRACEs) when the compile was successful. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOOWwJAAoJEN0/YqbEcdMwRF8QAIMOF0XTEsl8+DSmBsuDzIX4 dSjR96gAtHlQGaq11P4Auv2cX1slykcLQrfJWy4zPOCty97psJHQSzSmiEqiRyK2 7Eqa8iKvlqsXJhBQmkOWZM3XBIUIdsfsZrT+jo7jDOjnwF0CNZ7DP6ch3q01gWOw UWlNukHd2qZ29Awq5zuf6T9O45/4W1i85XPrWzLlzhAGeQ7dhTHzddpLfjO1Tb5B GxcmeSmyBP2RMEgjl6eXGk2mgz9OmjSPJrFTgaav0l5mCvhO/HcRczqhvtV08DDd gO3WCvxRywOwL78cOrudM1Aqd8o33etYK0hQGT3zw1kreXbFL7rPS/APs38ZF/53 m+3pRg2JtJiQQmWSjM4ou4H15H72Z8zoXMxAvvguL8YveuFNu2Q18SfLkNc9Qhwv sMtRkxM55ap0D8RAYw60eWORlPYBwMD8zF1lKz3xImIemoMflo7CSrvrWv7KUXJE 0IPOGpJyCtTIrShfh6Hvj53FwWb16FfphETnvwFffY7k42mkbwU+Sa76aZ9Wklnl DODFQ2VLgMtCyO/3he2b4rc2KAlc567HKJI2ND8hYXvQH8M2q6ebps5LrphglPnb 87e3jdBcNBISJ0t2/jamNRFj+uPY2UNoga+5xKwnC1uqKe1m9mmzfvm25SIAMBbE bihjIFyAg+Bv5Z6Lrzag =Qbf6 -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/3] winmm: Memory related fixes.
by Alexandre Julliard 03 Aug '11

03 Aug '11

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Hi, > > IMHO, this does not need further splitting. We have had that big 100KB patch which introduced > the bugs and don't need N patches of a fraction that size each to fix them one by one. > Instead, we need to find and remove them quickly so users can be happy again with sound in Wine. They would go in more quickly if you would simply follow the rules. Independent changes should be separate patches. There are many good reasons for this, that I'm sure you can figure out. -- Alexandre Julliard julliard(a)winehq.org

1 0

mmdevapi tests
by Joerg-Cyril.Hoehle＠t-systems.com 03 Aug '11

03 Aug '11

Hi, I've a couple of mmdevapi tests that I could put into submittable form soon, however there's one big problem: There are three different backends (ALSA, OSS, MacOS) and each one needs a different set of todo_wine. How to deal with that? In the past, when I worked alone (e.g. on the MCI), I simply submitted problematic tests only after I had patches that prevented Wine from crashing or possibly even implemented the functionality. Now of course, I could open an issue (one per backend?), append the patch and say "Wine must pass this". However that won't get as much test coverage (by neither native machines, nor Wine boxes). What do you suggest? Jörg Höhle

2 1

Re: [PATCH 1/2] comctl32: Fix to ComboBoxEx processing of WM_ENABLE message
by Nikolay Sivov 03 Aug '11

03 Aug '11

On 8/3/2011 02:49, Richard Bradbrook wrote: > comctl32: Fix to ComboBoxEx processing of WM_ENABLE message > This fixes some of the issues mentioned in bug 27920 Hi, Richard. Few comments: > +static LRESULT COMBOEX_Enable (COMBOEX_INFO *infoPtr, BOOL enable) > +{ > + TRACE("hwnd=%p, enable=%s\n", infoPtr->hwndSelf, enable ? "TRUE":"FALSE"); No need for a trace here, all messages are already traced at procedure level. Also please add tests that show disabled edit box and disabled combo after switching ComboEx state.

1 0

Re: advapi32: Add stub TraceMessage, TraceMessageVa
by Hans Leidekker 03 Aug '11

03 Aug '11

On Wed, 2011-08-03 at 13:01 +1000, Alistair Leslie-Hughes wrote: -@ stub TraceMessage -@ stub TraceMessageVa +@ varargs TraceMessage(long long ptr long) +@ stdcall TraceMessageVa(long long ptr long ptr) These functions take a TRACEHANDLE as the first argument which is an int64.

1 0

re: GSoC: dinput8 Action Mapping
by Dan Kegel 02 Aug '11

02 Aug '11

Lucas asked: > Should I correct the tabs and align the > parameters in the function prototype when I implement them? If you do a significant rewrite of a function, or are implementing it for the first time, I think it's ok to use more standard code style in your new code, or to update the style of adjacent old code (like a prototype) related to your change.

7 28

Re: [PATCH 1/3] shell32/tests: Add verification of known folders parsing names.
by Alexandre Julliard 02 Aug '11

02 Aug '11

Mariusz Pluciński <vshader(a)gmail.com> writes: > + KNOWN_FOLDER(FOLDERID_AddNewPrograms, NO_CSIDL, "AddNewProgramsFolder", KF_CATEGORY_VIRTUAL, GUID_NULL, NULL, "::{21EC2020-3AEA-1069-A2DD-08002B30309D}\\::{15eae92e-f17a-4431-9f28-805e482dafd4}\0" > + "shell:::{26EE0668-A00A-44D7-9371-BEB064C98683}\\0\\::{15eae92e-f17a-4431-9f28-805e482dafd4}\0\0" /* 6.1 */), This is now way past a reasonable line length. Please format this differently. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] shell32: Implement SHCreateDefaultContextMenu and CDefFolderMenu_Create2 (try 2)
by Alexandre Julliard 02 Aug '11

02 Aug '11

Jay Yang <jkelleyy(a)gmail.com> writes: > Added TRACE statements and removed some stray comments > --- > dlls/shell32/Makefile.in | 1 + > dlls/shell32/composite_cmenu.c | 275 ++++++++++++++++++++++++++++++++++++++++ Please put that in some existing files, there are already way too many files in shell32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ieframe: Moved WebBrowser object tests to ieframe
by Marvin 02 Aug '11

02 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13166 Your paranoid android. === WNT4WSSP6 (32 bit ie) === ie.c:61: Test failed: Could not create InternetExplorer instance: 80040154 ie: unhandled exception c0000005 at 004012F2 === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3046: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3122: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2439: Test failed: expected GetOverridesKeyPath webbrowser.c:2443: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2444: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2053: Test failed: put_Resizable failed: 80004001 webbrowser.c:2054: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2058: Test failed: put_Resizable failed: 80004001 webbrowser.c:2059: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2439: Test failed: expected GetOverridesKeyPath webbrowser.c:2443: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2444: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:378: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2053: Test failed: put_Resizable failed: 80004001 webbrowser.c:2054: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2058: Test failed: put_Resizable failed: 80004001 webbrowser.c:2059: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2439: Test failed: expected GetOverridesKeyPath webbrowser.c:2443: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2444: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:431: Test failed: unexpected nCmdID 29 webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:2589: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2709: Test failed: expected TranslateUrl webbrowser.c:2710: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2711: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2717: Test failed: ReadyState = 1, expected 4 webbrowser.c:2541: Test failed: ReadyState = 1, expected 4 webbrowser.c:761: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:777: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:784: Test failed: ReadyState = 1, expected 4 webbrowser.c:576: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:576: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:583: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:587: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1479: Test failed: unexpected call GetOptionKeyPath webbrowser.c:327: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:761: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:761: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:761: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:761: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:431: Test failed: unexpected nCmdID 26 webbrowser.c:431: Test failed: unexpected nCmdID 29 webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:862: Test failed: ReadyState = 1, expected 4 webbrowser.c:1490: Test failed: unexpected call GetDropTarget webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:2589: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3082: Test failed: doc != doc2 webbrowser.c:576: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:576: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:579: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:583: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:587: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1479: Test failed: unexpected call GetOptionKeyPath webbrowser.c:327: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:431: Test failed: unexpected nCmdID 26 webbrowser.c:431: Test failed: unexpected nCmdID 29 webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:1490: Test failed: unexpected call GetDropTarget webbrowser.c:929: Test failed: unexpected call GetContainer webbrowser.c:479: Test failed: unexpected call webbrowser.c:2582: Test failed: expected TranslateUrl webbrowser.c:2589: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2802: Test failed: expected RequestUIActivate webbrowser.c:2894: Test failed: Got 0x80004002 webbrowser.c:3089: Test failed: doc != doc2 webbrowser.c:2989: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040B512

2 1

Re: [PATCH] user32: GetMenuItemRect works without draw if the menu isn't a popup
by Andy Clayton 01 Aug '11

01 Aug '11

On Aug 1, 2011 10:25 AM, "Alexandre Julliard" <julliard(a)winehq.org> wrote: > > Andy Clayton <q3aiml(a)gmail.com> writes: > > > + itemMenu = MENU_GetMenu(hMenu); > > + if (itemMenu == NULL) > > + return FALSE; > > + > > + if ((itemMenu->Height == 0 || itemMenu->Width == 0) && itemMenu->wFlags ^ MF_POPUP) > > That flag test doesn't make sense. What are you trying to check here? > I am trying to check is if it is a menu bar, because in that case GetMenuItemRect works so long as the menu is attached to a window (according to MSDN, anyways). Is there a better way I should be checking this? I guess I overlooked MF_SYSMENU. I also now see that I should instead be calling MenuBarCalcSize, and that my testing has found it returning values even if not attached via SetMenu, though maybe they are not meaningful. Clearly I need to take a second look at this. Sorry for so many mistakes. Andy

1 0

Re: [PATCH] user32: GetMenuItemRect works without draw if the menu isn't a popup
by Alexandre Julliard 01 Aug '11

01 Aug '11

Andy Clayton <q3aiml(a)gmail.com> writes: > + itemMenu = MENU_GetMenu(hMenu); > + if (itemMenu == NULL) > + return FALSE; > + > + if ((itemMenu->Height == 0 || itemMenu->Width == 0) && itemMenu->wFlags ^ MF_POPUP) That flag test doesn't make sense. What are you trying to check here? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: net: The service dependency messages take a Unicode string as a parameter.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Francois Gouget <fgouget(a)free.fr> writes: > Update the corresponding translations. It would be better to use Unicode printfs everywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine crashtests
by Vitaly Perov 01 Aug '11

01 Aug '11

Is it possible to add a test to show that Wine crashes?

3 7

NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation
by Paul Vriens 01 Aug '11

01 Aug '11

Hi, I was trying out the latest SysInternals Process Explorer and it struck me that the overall CPU % stayed at 0. Adding some values to the sppi structure fixed this but I'm just wondering what values to use: sppi[cpus-1].Reserved1[0].QuadPart = (ULONGLONG)remainder[0] * 10000000 / clk_tck; This Reserved1[0] is the DPC Time but I'm wondering what values from /proc/stat to use here (remainder[0] is I/O wait). We could always make up something of course but being accurate would be nicer. -- Cheers, Paul.

2 2

Re: Re: riched20/tests: fix test_EM_FINDWORDBREAK comments
by Marvin 01 Aug '11

01 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13103 Your paranoid android. === WVISTAADM (32 bit editor) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: riched20/tests: fix test_EM_FINDWORDBREAK comments
by Austin English 01 Aug '11

01 Aug '11

Forgot patch. On Jul 31, 2011 10:20 PM, "Dan Kegel" <dank(a)kegel.com> wrote: > In test_EM_FINDWORDBREAK_[WA], the descriptions of u+f020 and u+ff20 > were mixed up. > Fix that, and clean up a couple others slightly. > >

1 0

Re: ddraw: Do not increase wined3d texture refcount in IDirect3DDevice7_GetTexture.
by Stefan Dösinger 31 Jul '11

31 Jul '11

On Friday 29 July 2011 17:17:45 Ričardas Barkauskas wrote: > This makes it behave like similar place in d3d8. The subject is confusing, otherwise it looks OK.

1 0

Winhelp crash in assertion(0) if .hlp file is not found
by Bruno Jesus 31 Jul '11

31 Jul '11

Hello, I've been in the list for a long time as a reader and after years I finally managed to get a development computer and restarted playing with current wine git. There are about 15 bugs on bugzilla but none of them are related to this. I'm trying the list first before opening a bug. It's quite simple to reproduce, although I'm not sure if I can attach the hlp file here since it's from windows. The crash happens because the help file needs another help file. There is a button on the screen called Glossary that needs a file called glossary.hlp. If this file does not exist wine asks me to point it, if I answer No or yes and then cancel file selection wine crashes on an assert. The following lines are displayed on the console: fixme:winhelp:WINHELP_GetWindowInfo Couldn't find window info for glossary winhelp.c:270: WINHELP_GetWindowInfo: Assertion `0' failed. wine: Assertion failed at address 0xb78f0424 (thread 003b), starting debugger... The following lines are from file winhelp.c, around line 270. ... if (strcmp(name, "main") != 0) { WINE_FIXME("Couldn't find window info for %s\n", name); assert(0); return NULL; } ... The function WINHELP_OpenHelpWindow does not resist WINHELP_GetWindowInfo returning NULL. That was why the assert(0) was added inside it to abort the program execution (as far as I see). There are 3 calls like this (one on winhelp.c and the others on macro.c): ... WINHELP_OpenHelpWindow(HLPFILE_PageByHash, hlpfile, lHash, WINHELP_GetWindowInfo(hlpfile, wndname), show); ... My approach to fix this is quite simple: instead of splitting the above lines on different places and add a check for each of them the easier way is to simply make OpenHelpWindow resist null pointers and do not open anything because the user was already warned and asked for the nonexistent file. The proposed solution (if I may call adding one "if" a solution) is attached. If anyone has the problematic hlp file that was the cause to add the assert(0) please send me. Looks like the assert is there since wine 1.0 according to http://source.winehq.org/source/programs/winhlp32/winhelp.c?v=wine-1.0 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

2 4

Re: [PATCH 1/5] mshtml: Added semi-stub implementation of IHTMLWindow2::status property
by Marvin 31 Jul '11

31 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13084 Your paranoid android. === WVISTAADM (32 bit dom) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: mshtml: Added semi-stub implementation of IHTMLWindow2::status property
by Jacek Caban 31 Jul '11

31 Jul '11

Please ignore this one. I will send proper version with other mshtml patches. Thanks, Jacek

1 0

Re: [1/2] cmd/tests: Add FOR /D tests (try 2)
by Octavian Voicu 30 Jul '11

30 Jul '11

2011/7/29 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > +rem for /d %%i in (ba*) do echo %%i>> tmp > +rem sort < tmp > +rem del tmp I believe you can also use this syntax [put for instruction in parentheses, add | sort at the end]: (for ... ...) | sort Btw, it's a horrible hack, but until you'll have a wine sort you can test with (for ... ...) | Z:\usr\bin\sort :) Octavian

2 2

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)
by Paul Vriens 29 Jul '11

29 Jul '11

On 07/29/2011 01:29 AM, Octavian Voicu wrote: > + else > + win_skip("Not on WOW64, skipping test.\n"); Why a win_skip()? Isn't a normal skip() more appropriate? -- Cheers, Paul.

2 1

Re: [PATCH 8/9] wscript: implemented Host_get_Application (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13007 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 7/9] wscript: implemented Host_put_Interactive (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13006 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 6/9] wscript: implemented Host_get_Interactive (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13005 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 5/9] wscript: implemented Arguments2_get_length (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13004 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 4/9] wscript: implemented Arguments2_Count (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13003 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 2/9] wscript: added arguments.c; implemented Host_get_Arguments (resend)
by Marvin 29 Jul '11

29 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13001 Your paranoid android. === W7PROX64 (32 bit) === run.c:180: Test failed: test.JS: L"WScript.FullName = " run.c:180: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 1/2] winmm: Trivial code simplifications and fixes.
by Henri Verbeet 29 Jul '11

29 Jul '11

On 29 July 2011 09:46, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > these fixes all trivial errors I mentioned recently but one, plus a few ones I discovered since then. > These need to be separate patches, of course. I'd also encourage everyone to just use git send-email for sending patches.

2 2

Re: patch for dlls/gdi32/dib.c: fixes crash
by Octavian Voicu 29 Jul '11

29 Jul '11

On Wed, Jul 27, 2011 at 6:44 PM, Wolfgang Walter <wine(a)stwm.de> wrote: > - char src_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *src_info = (BITMAPINFO *)src_bmibuf; > - char dst_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )]; > - BITMAPINFO *dst_info = (BITMAPINFO *)dst_bmibuf; There's another instance of that in GetDIBits. Allocating 2KB+ (2 x 1064 bytes) of data on the stack is not very reasonable I guess. Octavian

3 3

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches
by Alexandre Julliard 29 Jul '11

29 Jul '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, > > if (wait_handle) > { > - NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > - status = io->u.Status; > + status = NtWaitForSingleObject( wait_handle, (options & FILE_SYNCHRONOUS_IO_ALERT), NULL ); > + if (status == STATUS_USER_APC) > + { > + async->interrupted = TRUE; > + status = STATUS_CANCELLED; /* not really, the ioctl completes and event and the handle > + itself get signaled */ > + } This looks wrong. You can't claim it was cancelled if it's still running. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/7] cmd/tests: Add FOR /D tests
by Alexandre Julliard 29 Jul '11

29 Jul '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > programs/cmd/tests/test_builtins.cmd | 6 ++++++ > programs/cmd/tests/test_builtins.cmd.exp | 11 +++++++++++ > 2 files changed, 17 insertions(+), 0 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok batch.c:239: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 225 (got 'baz', wanted 'baz') make: *** [batch.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

ancient email messages being sent, or at least archived, again?
by Dan Kegel 29 Jul '11

29 Jul '11

What's with messages like http://www.winehq.org/pipermail/wine-bugs/2011-July/285020.html ?

2 1

Re: Nvidia GeForce GTX560 Ti detection fix
by Henri Verbeet 28 Jul '11

28 Jul '11

On 28 July 2011 22:46, <gwen(a)derpymail.com> wrote: > This patch fixes the problem that a GeForce GTX560 Ti GPU is not being > detected in current build. (http://bugs.winehq.org/show_bug.cgi?id=27924) > The change itself looks reasonable enough, though I don't have the hardware to verify the strings. Please use git to generate patches though, and include proper author information. See also http://wiki.winehq.org/SubmittingPatches.

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2)
by Marvin 28 Jul '11

28 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12984 Your paranoid android. === WVISTAADM (32 bit shlfolder) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Don't treat a button as a dialog (valgrind)
by Marvin 28 Jul '11

28 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12982 Your paranoid android. === WNT4WSSP6 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2KPROSP4 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WXPPROSP3 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K3R2SESP2 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === WVISTAADM (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W2K8SE (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PRO (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (32 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON === W7PROX64 (64 bit dialog) === dialog.c:641: Test failed: Button1 style not set to BS_DEFPUSHBUTTON dialog.c:644: Test failed: Button2's style not changed to BS_PUSHBUTTON

1 0

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths.
by Marvin 28 Jul '11

28 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === WNT4WSSP6 (32 bit shlfolder) === Timeout === W2KPROSP4 (32 bit shlfolder) === Timeout

1 0

Re: ieframe: Moved ie.c tests to ieframe
by Marvin 28 Jul '11

28 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12968 Your paranoid android. === WNT4WSSP6 (32 bit ie) === ie.c:62: Test failed: Could not create InternetExplorer instance: 80040154 ie: unhandled exception c0000005 at 004012F2

2 1

Re: ieframe: Moved ie.c tests to ieframe
by Marvin 28 Jul '11

28 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12967 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Bug status transitions ~ bug 27908
by wylda＠volny.cz 28 Jul '11

28 Jul '11

Hi, there is bug 27908, which i closed as invalid, because user did not used latest fixed version. AJ says: If there was a bug then it's FIXED. Based on that, even if the user has a crash in 1.0.1 and opens _now_ a bug and one day later says "it is FIXED in 1.3.25", then it should be marked as FIXED. Because i noticed before, that this is handled differently, i'm writing here about above rule, which unify that. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete.

3 2

Re: [PATCH 7/8] wscript: implemented Host_get_Application (resend)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12934 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 6/8] wscript: implemented Host_put_Interactive (resend)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12933 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 5/8] wscript: implemented Host_get_Interactive (resend)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12932 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 4/8] wscript: implemented Arguments2_get_length (resend)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12931 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 3/8] wscript: implemented Arguments2_Count (resend)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12930 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Re: [PATCH 1/8] wscript: added arguments.c; implemented Host_get_Arguments (try 2)
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12928 Your paranoid android. === W7PROX64 (32 bit) === run.c:177: Test failed: test.JS: L"WScript.FullName = " run.c:177: Test failed: test.JS: L"WScript.Path = "

1 0

Wine and ALSA hw:0, plug:hw, "default" devices, what's the target?
by Joerg-Cyril.Hoehle＠t-systems.com 27 Jul '11

27 Jul '11

Hi, I've never seen a documentation of what Wine expects from the ALSA/OSS/CoreAudio device. - A bare bones "hw:0" device with all its restrictions, e.g. stereo 16bit only? As Wine provides no mixer, this would disallow playing multiple sounds concurrently (bug #NN) on most current sound cards. Some people seem to setup Wine via the registry to use that. - "plug:hw" which can convert 8bit mono to 16bit stereo and provides resampling? (I forgot about the difference with "plughw") - The "dmix" device, which only supports a single rate (typically 48000, see /usr/share/alsa/alsa.conf:defaults.pcm.dmix.rate), accepts only 32bit int(!) samples and restricts #channels like hw:0? This allows to open multiple devices. - The "plug:dmix" device, which chains a resampler and converter with dmix so that it can accept any PCM format? - "pulse", which like "plug:dmix" accepts any PCM format? - "default", which presumably maps to either plug:dmix or pulse so as to accept any PCM format and open multiple devices? It seems obvious Wine needs something as flexible as "pulse" or "plug:dmix" (pure "dmix" won't fit because Wine and apps don't cope well with the 32 bits samples requirement). Does mmdevapi change the equation, happy with dmix instead of plug:dmix as long as both rates are the same? Given that, can't Wine delegate more to the OS? It seems quite stupid to e.g. write a resampler for Wine when ALSA and MacOS' Coreaudio already include one. (On MacOS, couldn't mmdevapi map more to MacOS' audio filter chains?) What's the point of Winealsa's mmdevapi code iterating through ALSA's hw:N devices? IMHO only CoreAudio EXCLUSIVE mode can make use of them. It's a no-no for SHAREDMODE. Or is the plan to be really happy with exclusive access to hw:0 (preventing non Wine apps from doing audio!?!) and implement in Wine's mmdevapi a true mixer as well as a high quality resampler for SHAREDMODE with RATEADJUST and WINMM needs? Who can shed some light? Regards, Jörg Höhle

1 0

Re: kernel32/tests/debugger: remove win9x hacks
by Dmitry Timoshkov 27 Jul '11

27 Jul '11

Austin English <austinenglish(a)gmail.com> wrote: > - if (disposition == REG_CREATED_NEW_KEY) > - win_skip("'dbg,event,order' test doesn't finish on Win9x/WinMe\n"); > - else > - crash_and_debug(hkey, test_exe, "dbg,event,order"); > + crash_and_debug(hkey, test_exe, "dbg,event,order"); You should check 'disposition' instead of removing it altogether. -- Dmitry.

1 0

Re: kernel32/tests/atom: remove win9x hacks
by Dmitry Timoshkov 27 Jul '11

27 Jul '11

Austin English <austinenglish(a)gmail.com> wrote: > len = GlobalGetAtomNameA( (ATOM)i, buf, 2); > - if (!len) /* the NT way */ > - { > - ok(GetLastError() == (i ? ERROR_MORE_DATA : ERROR_INVALID_PARAMETER) || > - GetLastError() == 0xdeadbeef, /* the Win 9x way */ > - "wrong error conditions %u for %u\n", GetLastError(), i); > - } > - else /* the Win 9x way */ > - { > - ok(GetLastError() == 0xdeadbeef, > - "wrong error conditions %u for %u\n", GetLastError(), i); > - } > + ok(GetLastError() == ERROR_MORE_DATA || GetLastError() == ERROR_INVALID_PARAMETER, > + "wrong error conditions %u for %u\n", GetLastError(), i); > } You should add an ok(!len) check here. > len = GlobalGetAtomNameA(atom, out, 10); > - if (!len) /* the NT way */ > - { > - ok(GetLastError() == ERROR_MORE_DATA, "wrong error code (%u instead of %u)\n", GetLastError(), ERROR_MORE_DATA); > - } > - else /* the Win9x way */ > - { > - ok(GetLastError() == 0xdeadbeef, "wrong error code (%u instead of %u)\n", GetLastError(), 0xdeadbeef); > - } > + ok(GetLastError() == ERROR_MORE_DATA, "wrong error code (%u instead of %u)\n", GetLastError(), ERROR_MORE_DATA); And here. -- Dmitry.

1 0

Re: gdi32/tests/mapping: remove win9x hacks
by Dmitry Timoshkov 27 Jul '11

27 Jul '11

Austin English <austinenglish(a)gmail.com> wrote: > - if (is_win9x) > - { > - expect_viewport_ext(hdc, dpi_x, dpi_y); > - expect_window_ext(hdc, 254, -254); > - } > - else > - { > - expect_viewport_ext(hdc, res_x, -res_y); > - ok( GetWindowExtEx( hdc, &size ), "GetWindowExtEx failed\n" ); > - ok( rough_match( size.cx, size_cx * 10 ) || > - rough_match( size.cx, MulDiv( res_x, 254, dpi_x )), /* Vista uses a more precise method */ > - "expected cx %d or %d, got %d\n", size_cx * 10, MulDiv( res_x, 254, dpi_x ), size.cx ); > - ok( rough_match( size.cy, size_cy * 10 ) || > - rough_match( size.cy, MulDiv( res_y, 254, dpi_y )), /* Vista uses a more precise method */ > - "expected cy %d or %d, got %d\n", size_cy * 10, MulDiv( res_y, 254, dpi_y ), size.cy ); > - } > + ok( GetWindowExtEx( hdc, &size ), "GetWindowExtEx failed\n" ); > + ok( rough_match( size.cx, size_cx * 10 ) || > + rough_match( size.cx, MulDiv( res_x, 254, dpi_x )), /* Vista uses a more precise method */ > + "expected cx %d or %d, got %d\n", size_cx * 10, MulDiv( res_x, 254, dpi_x ), size.cx ); > + ok( rough_match( size.cy, size_cy * 10 ) || > + rough_match( size.cy, MulDiv( res_y, 254, dpi_y )), /* Vista uses a more precise method */ > + "expected cy %d or %d, got %d\n", size_cy * 10, MulDiv( res_y, 254, dpi_y ), size.cy ); > expect_world_transform(hdc, 1.0, 1.0); > expect_LPtoDP(hdc, MulDiv(1000 / 10, res_x, size_cx), -MulDiv(1000 / 10, res_y, size_cy)); You've lost 'expect_viewport_ext(hdc, res_x, -res_y);' from the 'else' block. -- Dmitry.

1 0

Re: kernel32/tests/sync: remove win9x hacks
by Marvin 27 Jul '11

27 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12916 Your paranoid android. === W7PRO (32 bit sync) === sync.c:849: Test failed: ChangeTimerQueueTimer

1 0

Re: [3/3] ddraw/tests: Add a couple of fog tests.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12866 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [3/3] d3d9/tests: Add a couple of fog tests.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12862 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: comctl32: Remove dead increments (clang)
by Marcus Meissner 26 Jul '11

26 Jul '11

On Tue, Jul 26, 2011 at 09:15:57PM +0200, André Hentschel wrote: > --- > dlls/comctl32/propsheet.c | 1 - > dlls/comctl32/rebar.c | 2 -- > 2 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/dlls/comctl32/propsheet.c b/dlls/comctl32/propsheet.c > index f711399..3dd0713 100644 > --- a/dlls/comctl32/propsheet.c > +++ b/dlls/comctl32/propsheet.c > @@ -543,7 +543,6 @@ static BOOL PROPSHEET_CollectPageInfo(LPCPROPSHEETPAGEW lppsp, > /* Extract the caption */ > psInfo->proppage[index].pszText = p; > TRACE("Tab %d %s\n",index,debugstr_w( p )); > - p += lstrlenW( p ) + 1; > > if (dwFlags & PSP_USETITLE) > { > diff --git a/dlls/comctl32/rebar.c b/dlls/comctl32/rebar.c > index 99bde77..8d4e6f3 100644 > --- a/dlls/comctl32/rebar.c > +++ b/dlls/comctl32/rebar.c > @@ -1576,8 +1576,6 @@ REBAR_SizeToHeight(REBAR_INFO *infoPtr, int height) > iRow++; > } > } > - else > - extra -= REBAR_SizeChildrenToHeight(infoPtr, first_visible(infoPtr), infoPtr->uNumBands, extra / infoPtr->uNumRows, &fChanged); > > if (fChanged) > REBAR_Layout(infoPtr); REBAR_SizeChildrenToHeight might set fChanged here, or? Ciao, Marcus

1 0

Re: comctl32: Remove dead increments (clang)
by Reece Dunn 26 Jul '11

26 Jul '11

2011/7/26 André Hentschel <nerv(a)dawncrow.de>: > --- a/dlls/comctl32/rebar.c > +++ b/dlls/comctl32/rebar.c > @@ -1576,8 +1576,6 @@ REBAR_SizeToHeight(REBAR_INFO *infoPtr, int height) > iRow++; > } > } > - else > - extra -= REBAR_SizeChildrenToHeight(infoPtr, first_visible(infoPtr), infoPtr->uNumBands, extra / infoPtr->uNumRows, &fChanged); IIUC, this should not remove the |REBAR_SizeChildrenToHeight| call, only the |extra -=| bit as |REBAR_SizeChildrenToHeight| is updating the |infoPtr| output parameter. - Reece

1 0

d3d8/tests: make sure to use return values (LLVM/Clang)
by Austin English 26 Jul '11

26 Jul '11

-- -Austin

4 8

Re: richedit: Implement WB_DELIMITER and remove todo_wine's in tests.
by Paul Vriens 26 Jul '11

26 Jul '11

On 07/26/2011 03:36 AM, James McKenzie wrote: > if (wbuf[0] == 0x20 || wbuf[0] == 0xf020) > - todo_wine > - ok(result == delimiter_tests[i].isdelimiter, > - "wanted ISDELIMITER_W(0x%x) %d, got %d\n", > - delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result); > + ok(result == delimiter_tests[i].isdelimiter, > + "wanted ISDELIMITER_W(0x%x) %d, got %d\n", > + delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result); > else > ok(result == delimiter_tests[i].isdelimiter, > "wanted ISDELIMITER_W(0x%x) %d, got %d\n", > @@ -7122,10 +7121,9 @@ static void test_EM_FINDWORDBREAK_A(void) > SendMessageW(hwndRichEdit, WM_SETTEXT, 0, (LPARAM)buf); > result = SendMessage(hwndRichEdit, EM_FINDWORDBREAK, WB_ISDELIMITER, 0); > if (buf[0] == 0x20) > - todo_wine > - ok(result == delimiter_tests[i].isdelimiter, > - "wanted ISDELIMITER_A(0x%x) %d, got %d\n", > - delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result); > + ok(result == delimiter_tests[i].isdelimiter, > + "wanted ISDELIMITER_A(0x%x) %d, got %d\n", > + delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result); > else Hi James, I think that the if/else was introduced to accommodate the todo_wine(). I guess you can remove more lines as the 'if' now contains the same code as the 'else'. -- Cheers, Paul.

1 0

Re: [8/9] winhttp: Implement IWinHttpRequest::SetRequestHeader.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12827 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [7/9] winhttp: Implement IWinHttpRequest::GetResponseHeader.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12826 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [6/9] winhttp: Add some parameter checks.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12824 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/9] winhttp: Implement IWinHttpRequest::SetProxy.
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12823 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msvcrt/tests: remove unused assignments (LLVM/Clang)
by Frédéric Delanoy 26 Jul '11

26 Jul '11

On Tue, Jul 26, 2011 at 03:48, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin Already sent similar patches. Not sure AJ likes those.

2 1

Re: cmd: mkdir should complain if directory already exists (try 2)
by Frédéric Delanoy 26 Jul '11

26 Jul '11

On Tue, Jul 26, 2011 at 07:39, Dan Kegel <dank(a)kegel.com> wrote: > Changes since last try: > - fix remaining todo_wine's > - add one more testcase for invalid paths (one that doesn't trigger > help message) > - simplified create_full_path > - avoid generating error message in race case where somebody else > creates an intermediate directory first Maybe a bit nitpickings, but echo mkdir foo slash star errorlevel %ErrorLevel% could be more readable with echo mkdir foo/* errorlevel %ErrorLevel% / and * are not to be escaped, so don't mind expanding them "litteraly" Frédéric

1 0

Re: [PATCH 3/4] ntdll: implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformati
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12805 Your paranoid android. === W7PROX64 (64 bit pipe) === No test summary line found

1 0

Re: [PATCH 2/4] kernel32, ntdll, server: implement permission checks for named pipes
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12804 Your paranoid android. === W7PROX64 (64 bit pipe) === No test summary line found

1 0

Re: [PATCH 1/4] server, ntdll: get rid of the blocking parameter for ioctls. blockingness depends on the overlapped flag for
by Marvin 26 Jul '11

26 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12803 Your paranoid android. === W7PROX64 (64 bit pipe) === No test summary line found

1 0

Questions on WINE releases and stability
by louis＠museresearch.com 26 Jul '11

26 Jul '11

Hi, I am a developer for a product which makes heavy use of WINE. Right now, we're deciding which newer version of WINE to go to, and I thought the wine-devel community might have some insight. I did read the WineReleaseCriteria entry on the wiki, but still have some questions. If anyone could answer some things that I've been wondering about, it would go a long way towards helping us make an informed decision. So, here goes: - Does the development branch of WINE go through a battery of tests before it is posted? What kind of criteria has to be met before a development release is made available on the main page? - It's my understanding that the stable branch only has select features and patches ported over (from the wiki: "..with only minimal changes merged in"). Would this mean that if I compared a stable release with a development release from around the same time that the two releases would have significant differences? Specifically, I'm wondering about 1.2.3 vs. 1.3.15. - Is 64-bit support in version 1.2.3 generally usable and stable, or is the current development release a lot more mature in that respect? Your expertise would be appreciated! Louis

4 3

Re: comdlg32/tests: make sure to use a return value (LLVM/Clang)
by Marvin 25 Jul '11

25 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12798 Your paranoid android. === W7PROX64 (32 bit itemdlg) === itemdlg: unhandled exception c0000005 at 75B94C19

1 0

I need someone to present at the Desktop summit in my steed (Berlin)
by Scott Ritchie 25 Jul '11

25 Jul '11

External events are preventing me from leaving the country these next few weeks, and I'll be missing the Desktop Summit in Berlin on Monday, Aug 8th. This is the venue to talk to our friends responsible for Freedesktop.org, Gnome, KDE, Unity, and others. https://www.desktopsummit.org/program https://www.desktopsummit.org/venue The stated topic is "Making Wine less broken", although this can be more constructively phrased as "What Wine needs from the Desktop". Many of the recent problems with the Wine user experience have come from desktop environments breaking some of their historical "windows-like way" of doing things while not considering the Wine case: this conference presents us with an opportunity to engage and have Wine handled properly. Any volunteers? I'd be more than willing to talk with you personally and adapt the presentation however you like. Also if you have any particular content that you'd like to make sure gets said, post it in this thread as well :) Thanks, Scott Ritchie

1 0

Re: [PATCH] mmdevapi: Try loading multiple audio drivers from the registry
by Octavian Voicu 25 Jul '11

25 Jul '11

On Tue, Jul 26, 2011 at 12:46 AM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: + for(p = driver_name; p; p = next + 1){ + next = strchrW(p, ','); + if(next) + *next = '\0'; + + if(load_driver(p)) + return TRUE; + + TRACE("Failed to load driver: %s\n", wine_dbgstr_w(driver_name)); + } This crashes if no driver can be loaded (next will be NULL, then you'll have p = NULL + 1). Octavian

1 0

Re: cmd/tests: Add tests for stdout redirection and appending operators
by Marvin 25 Jul '11

25 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12796 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS
by Alexandre Julliard 25 Jul '11

25 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +/* Attempt to determine if we are running on OSS or ALSA's OSS compatability > + * layer. There is no official way to do that, so just check for validity > + * as best as possible, without rejecting valid OSS implementations. */ > +static BOOL verify_actually_oss(void) > +{ > + int mixer_fd; > + oss_sysinfo sysinfo; > + HKEY key; > + > + static const WCHAR drv_key[] = {'S','o','f','t','w','a','r','e','\\', > + 'W','i','n','e','\\','D','r','i','v','e','r','s',0}; > + static const WCHAR drv_value[] = {'A','u','d','i','o',0}; > + static const WCHAR ossW[] = {'O','S','S'}; > + > + /* if the user has specified a driver explicitly, then succeed > + * if they want OSS and fail if they don't */ > + if(RegOpenKeyW(HKEY_CURRENT_USER, drv_key, &key) == ERROR_SUCCESS){ > + WCHAR driver_name[256]; > + DWORD size = sizeof(driver_name); > + > + if(RegQueryValueExW(key, drv_value, 0, NULL, (BYTE*)driver_name, > + &size) == ERROR_SUCCESS){ > + RegCloseKey(key); > + if(!lstrcmpiW(ossW, driver_name)) > + return TRUE; > + return FALSE; > + } > + > + RegCloseKey(key); > + } It's not the driver's business to check the configuration key. If there's really a need to know if some other driver was configured, this info should be passed from the driver loader. But it would be preferable to avoid that. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 4/4] shell32/tests: Add verification of known folders relative paths.
by Alexandre Julliard 25 Jul '11

25 Jul '11

Mariusz Pluciński <vshader(a)gmail.com> writes: > Checks relative path for each known folder. This one crashes here: ../../../../wine/tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so ../../../../wine/dlls/shell32/tests/shellpath.c && touch shellpath.ok fixme:shell:_SHGetUserProfilePath unsupported for user other than current or default fixme:shell:knownfolder_GetRedirectionCapabilities 0x23f440 fixme:shell:foldermanager_GetFolderByName L"Windows", 0x23f428 wine: Unhandled page fault at address 0x2ae22d17351a (thread 0021), starting debugger... Unhandled exception: page fault in 64-bit code (0x00002ae22d17351a). fixme:dbghelp_dwarf:compute_location Only supporting one breg (r8/336 -> rcx/330) Register dump: rip:00002ae22d17351a rsp:000000000023dd20 rbp:0000000000000000 eflags:00010246 ( R- -- I Z- -P- ) rax:0000ff000000ffff rbx:000000000023f410 rcx:0000000000000018 rdx:0000000000000000 rsi:00000000ffffffff rdi:ff000000ffffff00 r8:00000000000000ff r9:0000000000000007 r10:000000000023d370 r11:0000000000000000 r12:ff000000ffffff00 r13:00002ae22d17b380 r14:0000000000035e92 r15:0000000000010000 Stack dump: 0x000000000023dd20: 000000000023f410 0000000000000000 0x000000000023dd30: 000000000023f408 00002ae22d17b380 0x000000000023dd40: 0000000000035e92 00002ae22d14a5e2 0x000000000023dd50: 000000000003e1f0 00002ae22d17b3a0 0x000000000023dd60: 0000000000000025 00002ae200000001 0x000000000023dd70: 000000000023ec40 0000000000000000 0x000000000023dd80: 0000000000000000 000000000023f408 0x000000000023dd90: 006c006c00000000 0064007200000000 0x000000000023dda0: 0000000000000680 000000680023e400 0x000000000023ddb0: 000000000023ee50 000000000023ec40 0x000000000023ddc0: 000000000023ea30 000000000023e820 0x000000000023ddd0: 000000000023f270 000000000023f400 Backtrace: =>0 0x00002ae22d17351a wine_dbgstr_wn+0x1ca(str=*** invalid address 0xff000000ffffff00 ***, n=0xffffffff) [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/include/wine/test.h:471] in shell32_test (0x0000000000000000) 1 0x00002ae22d14a5e2 test_knownFolders+0x1591() [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/include/wine/test.h:66] in shell32_test (0x0000000000000000) 2 0x00002ae22d14c80a func_shellpath+0xb09() [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/dlls/shell32/tests/shellpath.c:1555] in shell32_test (0x000000000000001a) 3 0x00002ae22d172b47 run_test+0x126(name="../../../../wine/dlls/shell32/tests/shellpath.c") [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/include/wine/test.h:556] in shell32_test (0x00002ae22d185df4) 4 0x00002ae22d173676 main+0x115(argc=<is not available>, argv=0x10710) [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/include/wine/test.h:624] in shell32_test (0x0000000000010710) 5 0x00002ae22d17387e __wine_spec_exe_entry+0xcd(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in shell32_test (0x00002ae225108908) 6 0x000000007b87221f start_process+0xbe(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1056] in kernel32 (0x00002ae22d1737b0) 7 0x00002ae225963bab call_thread_func+0x6a(entry=0x7b872160, arg=0x7fffffbef000, frame=0x0(nil)) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3189] in ntdll (0x00007fff728e05c0) 8 0x00002ae22595d486 call_thread_entry_point+0x29() in ntdll (0x00007fff728e05c0) 9 0x00002ae22592e766 start_process+0x15(kernel_start=0x23fec8) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2612] in ntdll (0x00007fff728e05c0) 10 0x00002ae224de2223 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff728e05c0) 11 0x00002ae224de2279 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 12 0x00002ae22593436e LdrInitializeThunk+0x3dd(kernel_start=0x7b872160, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2668] in ntdll (0x00007fffffbef000) 13 0x000000007b878a32 __wine_kernel_init+0x921() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1257] in kernel32 (0x00007fff728e1850) 14 0x00002ae225934da4 __wine_process_init+0x253() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2877] in ntdll (0x00007fff728e1a9c) 15 0x00002ae224de01ff wine_init+0x29e(argc=<is not available>, argv=0x7fff728e2028, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x00007fff728e1b30) 16 0x000000007bf00de1 main+0x70(argc=0x3, argv=0x7fff728e2028) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:228] in <wine-loader> (0x0000000000000003) 17 0x00002ae22536bead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff728e2018) [/home/aurel32/eglibc/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 18 0x000000007bf00ca9 _start+0x28() in <wine-loader> (0x0000000000000000) 0x00002ae22d17351a wine_dbgstr_wn+0x1ca [/home/julliard/wine/build/obj-elf64/dlls/shell32/tests/../../../../wine/include/wine/test.h:471] in shell32_test: cmpw $0,(%rdi) 471 while (*end) end++; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] msi: Don't create a temporary copy of the package.
by Alexandre Julliard 25 Jul '11

25 Jul '11

Hans Leidekker <hans(a)codeweavers.com> writes: > There's no need for it now that we open the package in transacted mode. This breaks the Gecko install: fixme:msi:MSI_OpenDatabaseW open failed r = 80030005 for L"Z:\\home\\julliard\\wine\\wine\\..\\gecko\\wine_gecko-1.2.0-x86.msi" err:appwizcpl:install_file MsiInstallProduct failed: 1627 -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Joerg-Cyril.Hoehle＠t-systems.com 25 Jul '11

25 Jul '11

Hi, I spent several evenings reviewing the code, here are my findings. The Good + You did it! + outer layer (wave*) uses hwave, inner layer uses device parameter (except WINMM_Pause/Reset which break this separation). + ValidateAndLock pattern + Invoking driver callbacks outside of critical sections, when all slots are in a sane state again. + Removed overhead of pass-through mapper in case of direct format match. However, this may make computations of position and DoneHeaders more complicated. Indeed, I have not yet understood the logic in MarkDoneHeaders and associated queues. Trivia - Some more comments are needed. - Why does WINMM_Pause call IAC_Stop yet set device->stopped = FALSE? - Document that g_device_handles MUST ONLY be modified within the player thread (otherwise MsgWait operates on undefined data), demonstrating that (part of) wave*Open must be handled there. - Express units of entities in WINMM_DEVICE, like you do with last_clock_pos - if(wait == 1 - WAIT_OBJECT_0) should be WAIT_OBJECT_0 + 1 (same by chance) Same with if(wait == g_devhandle_count - WAIT_OBJECT_0) - The caller of WINMM_BeginPlaying supplying the device argument will have locked it already, thus Enter/LeaveCS therein is superfluous. Generally, functions that take a WINMM_Device* parameter should receive it locked by the caller. - Memory leak in WINMM_PrepareHeader in case of acmStreamPrepareHeader error - WOD_Open/WID_Open:cb_info is unused, memcpy(&cb_info,...) useless. Same for WOD/WID_Close - WINMM_OpenDevice passed_fmt HeapAlloc is unchecked Prefer a stack-allocated WAVEFORMATEX and set passed_fmt = &stack_var - Prefer C structure copy over memcpy Logic - I don't see a protection against waveInClose(waveOUThandle); It would be trivial to add a flag to WINMM_GetDeviceFromHWAVE except in WINMM_Pause/Reset. - WINMM_Pause/Reset should take a device pointer, not hwave (which would additionally resolve the above point). - WAVERR_STILLPLAYING is unknown to waveoutClose. It's not a bug, it's a feature? (close would imply stop like the MCI?? but how to unprepare the headers in such a case? IMHO the WINMM API is not designed for a close while playing and only STILLPLAYING makes sense) - nBlockAlign is not sanitized and copied into device->bytes_per_frame. I mentioned long ago tests I wrote that supply incorrect avgbytes and blockalign to winmm yet don't disturb playback in native. IIRC I did not submit them because Wine would not work correctly with them. - device->bytes_per_frame is misdefined and/or misused. It's initialised from the original format (e.g. MP3) but compared in PushData via queue_frames with PCM frames from IAC::GetBuffer. Design - Too bad out_caps.dwSupport is now set within winmm, not the ALSA/OSS/CoreAudio drivers. I loose hope that one day WAVECAPS_VOLUME will be set according to the host OS caps. - How to avoid code duplication among WINMM_MapDevice and msacm32.drv/wavemap.c:wodOpen? - WAVE_FORMAT_DIRECT is missing. It is said to prevent use of ACM (de)compressors. My understanding (untested) is that ACM transforms (e.g. frequency, channels) would still be used. - WINMM_TryDeviceMapping opens the ACM twice, once with ACM_STREAMOPENF_QUERY, then for real. I recommend to open only once, because opening the ACM is an extremely expensive operation, known for delays. All drivers are loaded and queried in turn. I believe this is why people can't seem to Valgrind the winmm/wave and other tests: it just takes sooo much time repeatedly loading and unloading all the drivers! - It may not be a good idea to handle all of wave*Open within the data push thread. Open may take ages, during which no data will be supplied to concurrently playing or recording sounds. Xruns are likely. - Questionable use of BUFFERFLAGS_SILENT in WOD_PushData. When no data is available now, the buffer is flooded with silence, hence data submitted shortly afterwards will be delayed by as much (PulseAudio will accumulate 2 seconds of buffer data...), not by a minimal amount. - The old drivers used ALSA_NearMatch(rate,pcm_rate). There's nothing like this currently in winmm to prevent using a very different rate. My observation is that snd_pcm_set_rate_near() will happily yield 48000 when asked for 8000! Such a variation should be refused by winmm (accepted by dsound?), or a rate converter be silently plugged in. However the code currently ignores ALSA's actual rate and performs all computations using the original one. - Why do you use EVENTCALLBACK? Wine's mmdevapi (currently) signals events periodically from a timer. Winmm could do that itself. - I'm not sure what to think about the observation that waveOutWrite returns an error when BeginPlaying fails yet the header was inserted into the queue. The app may expect the header and data to be reusable for something else because of the error, while Wine may play it from a subsequent BeginPlaying and hit undefined memory. Well, BeginPlaying as of today always returns OK, but the flaw remains. BeginPlaying should be considered a performance optimization hint (start playing fast instead of after the next timer tick) and therefore not need a return value. After enqueuing, NOERROR should be the only return value. - What about mapping some AUDCLNT_E_* to MMSYSERR_*? Regards, Jörg Höhle

2 1

Re: [docs] winedev: Update code columns limit (resend)
by Francois Gouget 25 Jul '11

25 Jul '11

On Mon, 4 Jul 2011, André Hentschel wrote: [...] > - Code is usually limited to 80 columns. This helps prevent > - mailers mangling patches by line wrap. Also it generally > + Code is usually limited to 100 columns. It generally I'd prefer to keep the 80 columns recommandation. With 80 columns one can nicely fit files side by side on a laptop with a typical 1024 horizontal resolution whereas with 100 colums one would end up with the hair comb effect thus making the code unreadable. Also 100 seems close enough to 80 that I'm not sure it actually provides any of the benefits that longer lines are supposed to provide (if they are supposed to provide any). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

7 6

Re: po: Use non-breaking spaces where required by the French typography rules.
by Frédéric Delanoy 25 Jul '11

25 Jul '11

2011/7/23 Francois Gouget <fgouget(a)free.fr>: > > Except where they may be sent to a command line terminal. > --- > > I did some tests and non-breaking spaces don't seem to cause any issue > in the GUI. Did you use thin/normal non-breaking spaces? Keep in mind that the space "width" and breakability rules change slightly between e.g. France and French-speaking Canada, and that some (most?) translation tools don't allow you to easily view/enter those characters. TBH I'm not quite sure it's worth the trouble ATM Frédéric

2 2

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS
by Vitaliy Margolen 25 Jul '11

25 Jul '11

On 07/22/2011 08:35 AM, Andrew Eikum wrote: > > This is really crude, but does seem to work. I tested it correct with just > ALSA 1.0.24; ALSA 1.0.24's snd-pcm-oss and snd-pcm-mixer modules; and on > OSS4.2. It was also tested by Gerald Pfeifer on FreeBSD 8.2 and 9.0. > > This lets us attempt to load the OSS driver, and if that fails, then try the > ALSA driver. Automatic driver selection! You forgetting, that users can select multiple drivers in winecfg now. And that's what some people have in their registry. The actual approach is seems fishy to me as well. The reason ALSA driver is 1st is because most systems has it as the main sound subsystem. Putting something [oss] first in the list, and failing if it wasn't explicitly asked for defeats the whole idea about something being default, and having alternate fallback(s). With same logic one would add all other sound drivers and make them fail, unless explicitly asked for. Vitaliy.

2 1

Statur of DIB Engine
by Massimo Del Fedele 25 Jul '11

25 Jul '11

Having seen many patches related to DIB engine lately, I built latest sources and tried it.... No speed enhancements on AutoCAD, my test app. So, I wonder if the engine is already working, at least partially, or not. If yes, there's some switch/environment variable to enable it ? Sorry for asking here but, besides of git commits I've seen no explanation about what's happening. Also some users of my old engine, which are blocked to an old wine version (it is no more applicable to git tree since some time, because of recent changes....) would like to know what's going on. Ciao Max

4 6

Re: cmd: mkdir should complain if directory already exists
by Frédéric Delanoy 25 Jul '11

25 Jul '11

On Sun, Jul 24, 2011 at 20:58, Dan Kegel <dank(a)kegel.com> wrote: > Fixes bug 27383. There's trailing whitespace on the line preceding "if (!create_full_path(param1)) {" Seems ok otherwise

1 0

Re: [PATCH 3/4] ntdll: implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformati
by Marvin 25 Jul '11

25 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12778 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: [PATCH 2/4] kernel32, ntdll, server: implement permission checks for named pipes
by Marvin 25 Jul '11

25 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12777 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: [PATCH 1/4] server, ntdll: get rid of the blocking parameter for ioctls. blockingness depends on the overlapped flag for
by Marvin 25 Jul '11

25 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12776 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Need help at collecting ActionMapping data
by Lucas Zawacki 24 Jul '11

24 Jul '11

Hello everyone. As you may know I'm working on the dinput8 action mapping support and at the moment I've pretty much finished the mouse and keyboard and just need to get my patches in. For the next part, however, I'm going to need to analyze lot's of data generated by different joysticks to figure out how the mapping works. Some things are already clear for me, but I have only some simple USB joysticks here and thus would like your help to collect more useful data. If any of you has any sort of joystick (simple gamepads, driving wheels and whatnot) and would like to help, I've set up a little app that uses the DI8 action mapping API to construct a mapping for every connected joystick and outputs it to the terminal. You just need to run it, redirect the output to a file and email it back to me. Telling me which version of windows you're running would be nice. If you want to help but can't use windows, wine with native dinput8.dll is fine too. The program can be found here: https://github.com/downloads/lfzawacki/dinput-samples/devices_test.exe The code is here: https://github.com/lfzawacki/dinput-samples/blob/master/devices_test.cpp Thanks in advance Cheers

2 3

re: urlmon: Fix various typos/misspellings
by Dan Kegel 24 Jul '11

24 Jul '11

Hi Frédéric, >-/* List of 3 character top level domain names Windows seems to recognize. >+/* List of 3 characters top level domain names Windows seems to recognize. That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.) The other changes seem ok. - Dan

5 6

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)
by Jacek Caban 23 Jul '11

23 Jul '11

Hi Hans, On 07/23/11 09:52, Hans Leidekker wrote: > @@ -2107,7 +2107,7 @@ static void test_IWinHttpRequest(void) > HRESULT hr; > IWinHttpRequest *req; > BSTR method, url, response = NULL, status_text = NULL; > - VARIANT async, empty, timeout; > + VARIANT async, empty, timeout, body; > VARIANT_BOOL succeeded; > LONG status; > > @@ -2241,6 +2241,13 @@ static void test_IWinHttpRequest(void) > ok( hr == S_OK, "got %08x\n", hr ); > SysFreeString( response ); > > + VariantInit( &body ); > + V_VT( &body ) = VT_ERROR; > + hr = IWinHttpRequest_get_ResponseBody( req, &body ); > + ok( hr == S_OK, "got %08x\n", hr ); > + ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &body ) ); > + > + ok( hr == S_OK, "got %08x\n", hr ); This duplicates the above test. Did you mean to test the result of VariantClear here (otherwise there is a leak)? Thanks, Jacek

2 1

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)
by Marvin 23 Jul '11

23 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12710 Your paranoid android. === W2K8SE (32 bit winhttp) === winhttp.c:926: Test failed: failed to receive response 12152 winhttp.c:933: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:937: Test failed: failed unexpectedly 12019 winhttp.c:938: Test failed: unexpected size 0 winhttp.c:943: Test failed: failed unexpectedly 12019

2 1

Re: [1/3] configure.ac: fix libpthread detection on Haiku
by Alexandre Julliard 22 Jul '11

22 Jul '11

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * configure.ac: fix libpthread detection on Haiku > > Haiku has a single library, libroot.so, for all POSIX functions. There > is no separate libc, libm, libpthread, etc. I'd suggest to file bugs with Haiku, they should provide compatibility libraries, that stuff is very much standard. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] programs: Add rule for cross-building modules.
by Alexandre Julliard 22 Jul '11

22 Jul '11

Octavian Voicu <octavian.voicu(a)gmail.com> writes: > Allows cross-building modules similar to how tests are cross-built. > > For each module, a MODULE_cross.exe target is added to cross-build the module. > No other targets are affected. > > Cross-building doesn't work if the module uses libwine or the associated > includes. Currently only notepad_cross.exe can be built using this method, > but next patch makes it possible to also build winetest_cross.exe. > > [I always found it annoying that make crosstest only builds executables for > individual tests. This patch series makes it also build an executable for > winetest.] There's a reason for that. Tests are very limited in what they are allowed to use from Wine, but programs aren't. In particular you can't use any of the portability routines or configure check for cross builds. You really need a separate build tree to cross-compile programs. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody.
by Jacek Caban 22 Jul '11

22 Jul '11

Hi Hans, On 07/22/11 16:00, Hans Leidekker wrote: > --- > dlls/winhttp/request.c | 13 +++++++++++-- > dlls/winhttp/tests/winhttp.c | 9 ++++++++- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c > index 0c4c726..a73be22 100644 > --- a/dlls/winhttp/request.c > +++ b/dlls/winhttp/request.c > @@ -2747,8 +2747,17 @@ static HRESULT WINAPI winhttp_request_get_ResponseBody( > IWinHttpRequest *iface, > VARIANT *body ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + struct winhttp_request *request = impl_from_IWinHttpRequest( iface ); > + DWORD err; > + > + TRACE("%p, %p\n", request, body); > + > + if ((err = request_read_body( request, INFINITE ))) return HRESULT_FROM_WIN32( err ); > + > + VariantInit( body ); > + V_VT( body ) = VT_ARRAY|VT_UI1; > + V_ARRAY( body ) = request->buffer; The caller is responsible for freeing the result, so it will destroy your internal data. I think you should create an array here and not use it to store the data internally. Also VariantInit call is not needed if you set both type and value of variant. Jacek

2 2

Re: urlmon: Added support for javascript URIs
by Marvin 22 Jul '11

22 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12690 Your paranoid android. === WVISTAADM (32 bit uri) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 2/2] ntdll: Use swapping method to return . and .. as first entries.
by Alexandre Julliard 22 Jul '11

22 Jul '11

Grazvydas Ignotas <notasas(a)gmail.com> writes: > @@ -1522,76 +1538,76 @@ static int read_directory_getdents( int fd, IO_STATUS_BLOCK *io, void *buffer, U > } > > io->u.Status = STATUS_SUCCESS; > + de = (KERNEL_DIRENT64 *)data; > > + /* read first 2 entries so we can handle "." and ".." */ > + lseek( fd, 0, SEEK_SET ); > res = getdents64( fd, data, size ); You should find a way to do this only when you do encounter '.' and '..', not on every call. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: winecfg: Add missing checking of HeapAlloc return values.
by Alexandre Julliard 22 Jul '11

22 Jul '11

Grazvydas Ignotas <notasas(a)gmail.com> writes: > --- > programs/winecfg/winecfg.c | 18 +++++++++++++----- > programs/winecfg/winecfg.h | 14 ++++++++++---- > 2 files changed, 23 insertions(+), 9 deletions(-) That sort of thing is not useful. It's going to crash a little later, and it's not something that's going to happen in winecfg anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] comctl32: Send CBEM_DELETEITEM when CB_RESETCONTENT is received
by Nikolay Sivov 22 Jul '11

22 Jul '11

On 7/22/2011 06:59, Jay Yang wrote: > diff --git a/dlls/comctl32/comboex.c b/dlls/comctl32/comboex.c > index 3402a71..4888519 100644 > --- a/dlls/comctl32/comboex.c > +++ b/dlls/comctl32/comboex.c > @@ -1557,6 +1557,11 @@ static void COMBOEX_ResetContent (COMBOEX_INFO *infoPtr) > > item = infoPtr->items; > while (item) { > + NMCOMBOBOXEXW nmcit; > + memset (&nmcit.ceItem, 0, sizeof(nmcit.ceItem)); > + nmcit.ceItem.mask=~0; > + COMBOEX_CopyItem (item,&nmcit.ceItem); > + COMBOEX_NotifyItem (infoPtr, CBEN_DELETEITEM,&nmcit); > next = item->next; > COMBOEX_FreeText (item); > Free (item); First of all no need for memset probably, and it's common rule I think (well for me at least) to avoid unneeded initialization. As we have message to delete a single item, it's probably time to think about factoring out item deletion helper (that sends notification too). Actually it seems strange for me that this control uses list to store item data, cause messages are clearly index based. So first thing I'd like to see with that is to change item storage to use DPA array as others controls do. But if you don't have time for that now, I could try to do it myself.

2 2

Re: [PATCH 1/2] comctl32: Add tests for CB_RESETCONTENT
by Nikolay Sivov 22 Jul '11

22 Jul '11

On 7/22/2011 06:59, Jay Yang wrote: > Tests that CBEM_DELETEITEM notifications are received when CB_RESETCONTENT is sent to a comboex control. > --- > dlls/comctl32/tests/comboex.c | 28 ++++++++++++++++++++++++++++ > 1 files changed, 28 insertions(+), 0 deletions(-) Better way to test that is to use message sequence test. Look at listview test to see how WM_NOTIFY/id pairs are logged.

1 0

Wininet set_cookie must handle not only <name>=<value> but also <name> = <value>
by Bruno Jesus 22 Jul '11

22 Jul '11

Hello, while running uTorrent 3 I see the following fixme several times: fixme:wininet:set_cookie Unknown additional option L"expires = Sat,23-Jul-2011 02:20:13 GMT" After searching the source code I realized the expires parameter is already implemented but wine finds the entry names only if there's no space between the parameter name and the equal sign, here is a small piece of wininet.c around line 440 and 470. ... static const WCHAR szExpires[] = {'e','x','p','i','r','e','s','=',0} ... else if (strncmpiW(ptr, szExpires, 8) == 0) ... After searching msdn I found this article with an example that uses spaces: http://msdn.microsoft.com/en-us/library/aa385326%28v=vs.85%29.aspx bReturn = InternetSetCookie(TEXT("http://www.adventure_works.com"), NULL, TEXT("TestData = Test; expires = Sat,01-Jan-2000 00:00:00 GMT")); Looks like the cookie above is valid. I also found this other article telling about the data format: http://msdn.microsoft.com/en-us/library/aa384321%28v=vs.85%29.aspx After reading parts of the cookies RFC I found this note: http://www.ietf.org/rfc/rfc2109.txt ... NOTE: The syntax above allows whitespace between the attribute and the = sign. ... The newer version of the cookie rfc has the very same note: http://www.ietf.org/rfc/rfc2965.txt Please, don't bother to answer if this was already noted and is to be fixed. Also sorry for not pointing a solution. I'll study more on this later but I can say in advance that windows xp sets the cookie correctly when there is the space. I guess I'll start by adding tests for this on the file tests/internet.c Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began...

1 0

Re:
by Lucas Zawacki 21 Jul '11

21 Jul '11

Sorry, this is a duplicate for the [3/4] patch, you can disregard it. 2011/7/21 Lucas Fialho Zawacki <lfzawacki(a)gmail.com>: > --- > dlls/dinput/joystick.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 59 insertions(+), 1 deletions(-) > > diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c > index b5c028c..2d8a818 100644 > --- a/dlls/dinput/joystick.c > +++ b/dlls/dinput/joystick.c > @@ -500,9 +500,67 @@ HRESULT WINAPI JoystickWGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface, > LPCWSTR lpszUserName, > DWORD dwFlags) > { > + JoystickGenericImpl *This = impl_from_IDirectInputDevice8W(iface); > + DIDATAFORMAT data_format; > + DIOBJECTDATAFORMAT *obj_df = NULL; > + int i, action = 0, num_actions = 0; > + unsigned int offset = 0; > + > FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > > - return DI_NOEFFECT; > + if (This->base.acquired) return DIERR_ACQUIRED; > + > + data_format.dwSize = sizeof(data_format); > + data_format.dwObjSize = sizeof(DIOBJECTDATAFORMAT); > + data_format.dwFlags = DIDF_RELAXIS; > + data_format.dwDataSize = lpdiaf->dwDataSize; > + > + /* count the actions */ > + for (i=0; i < lpdiaf->dwNumActions; i++) > + if (IsEqualGUID(&This->base.guid, &lpdiaf->rgoAction[i].guidInstance)) > + num_actions++; > + > + if (num_actions == 0) return DI_NOEFFECT; > + > + This->base.num_actions = num_actions; > + > + /* Construct the dataformat and actionmap */ > + obj_df = HeapAlloc(GetProcessHeap(), 0, sizeof(DIOBJECTDATAFORMAT)*num_actions); > + data_format.rgodf = (LPDIOBJECTDATAFORMAT)obj_df; > + data_format.dwNumObjs = num_actions; > + > + This->base.action_map = HeapAlloc(GetProcessHeap(), 0, sizeof(ActionMap)*num_actions); > + > + for (i = 0; i < lpdiaf->dwNumActions; i++) > + { > + if (IsEqualGUID(&This->base.guid, &lpdiaf->rgoAction[i].guidInstance)) > + { > + LPDIDATAFORMAT df = This->base.data_format.wine_df; > + DWORD inst = DIDFT_GETINSTANCE(lpdiaf->rgoAction[i].dwObjID); > + DWORD type = DIDFT_GETTYPE(lpdiaf->rgoAction[i].dwObjID); > + LPDIOBJECTDATAFORMAT obj; > + > + if (type == DIDFT_PSHBUTTON) type = DIDFT_BUTTON; > + if (type == DIDFT_RELAXIS) type = DIDFT_AXIS; > + > + obj = dataformat_to_odf_by_type(df, inst, type); > + > + memcpy(&obj_df[action], obj, df->dwObjSize); > + > + This->base.action_map[action].uAppData = lpdiaf->rgoAction[i].uAppData; > + This->base.action_map[action].offset = offset; > + obj_df[action].dwOfs = offset; > + offset += (type & DIDFT_BUTTON) ? 1 : 4; > + > + action++; > + } > + } > + > + IDirectInputDevice8_SetDataFormat(iface, &data_format); > + > + HeapFree(GetProcessHeap(), 0, obj_df); > + > + return IDirectInputDevice8WImpl_SetActionMap(iface, lpdiaf, lpszUserName, dwFlags); > } > > HRESULT WINAPI JoystickAGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface, > -- > 1.7.0.4 >

1 0

Re: netapi32: add msvcrt to importlibs
by Alexandre Julliard 21 Jul '11

21 Jul '11

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > hi, this fixes bug http://bugs.winehq.org/show_bug.cgi?id=27827 > > Creo Elements expects msvcrt to be loaded, and fails to start. > > Dependancywalker on windows shows netapi32 loads the msvcrt. I guess > when more netapi32 functions will be implemented in future this will > become a "real" necessary dependency It won't help if it's not used, and you'd need to use msvcrt headers too. I don't think it's the right place to fix this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Experimental website for tracking translation issues
by Francois Gouget 21 Jul '11

21 Jul '11

I have started running a script that can check for translation issues in PO files against Wine's PO files. The issues it checks for include: * Mismatched printf format specifiers. * Mismatched trailing ellipsis. * Other mismatched trailing punctuation like full stop, question mark, space, etc. * Mismatched line feeds, trailing or not. * Spaces followed by line feeds. * Untranslated strings. Obviously some of these result in false positives. For instance 'Document' is written exactly the same in English and in French so to the script it will look like it was not translated. If you send me the corresponding error lines I'll make sure they are ignored by putting them in an 'ignore' file. So here's the web site: http://fgouget.free.fr/wine-po/ A typical report looks like this: L71: msgid or msgstr does not end in '[.]{3}' L75: msgid or msgstr does not end in '[.]{3}' You'd typically have the report and the corresponding PO file (here pl.po) open side by side, and jump to the PO lines mentionned in the report to investigate each of them. These are two ellipsis issues by the way. As you can see it's quite primitive. That's both because I'm not much of a web developer guy and because I'm still unsure how much interest there is in this. Also there's an open-source tool that does the same type of checks and more, though it seems to lack a way to handle false positives. It's pofilter from the translate-toolkit package. This tool is integrated with Pootle (the online PO file editor), so maybe this will do all we need once we put our PO files online for translation. In the meantime if any translator is interested in seeing what potential issues lie in their PO files... I'd particularly appreciate help with cleaning up the ellipsis, trailing spaces and untranslated string issues. See wine-patches for a handful of patches I'm sending based on the initial reports. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

3 7

Re: po: French translation tweaks and fixes.
by Frédéric Delanoy 20 Jul '11

20 Jul '11

2011/7/20 Francois Gouget <fgouget(a)free.fr>: > --- > po/fr.po | 108 ++++++++++++++++++++++++++++++++------------------------------ > 1 files changed, 56 insertions(+), 52 deletions(-) @@ -6857,7 +6859,7 @@ msgstr "Corbeille" #: shlwapi.rc:27 msgid "%ld bytes" -msgstr "%ld bytes" +msgstr "%ld octets" #: shlwapi.rc:28 msgid " hr" Bytes and octets are different things; octets have exactly 8 bits while bytes can have more (or less) -"Start est fourni sans AUCUNE GARANTIE ; pour les détails lancez avec " +"Start est fourni sans AUCUNE GARANTIE ; pour plus de détails lancez le avec\n" Should be "lancez-le" #: winefile.rc:101 msgid "root fs" -msgstr "root fs" +msgstr "fs racine" Maybe "sdf racine" for "système de fichiers"? Frédéric

3 3

[PATCH 4/4] winmm: Fix check for DCB_NULL callback type
by Joerg-Cyril.Hoehle＠t-systems.com 20 Jul '11

20 Jul '11

Andrew Eikum wrote: >- if(info->flags & DCB_NULL) >+ if((info->flags & DCB_TYPEMASK) == DCB_NULL) Instead of add ing a special case, I suggest to simplify the code: always call DriverCallback and declare void WINMM_NotifyClient. You currently ignore its return value anyway. Using void is consistent with an ealier notification patch of mine around April this year. Michael, wouldn't it be possible to add a function to the static checkers to be able to detect static functions whose return is systematically ignored and rewrit these and their callers to use void? I came across another occurence of that pattern no later than yesterday (mcimidi IIRC). Regards, Jörg Höhle

2 1

Re: [PATCH 2/2] ntdll: Set restart_scan on first call to NtQueryDirectoryFile.
by Alexandre Julliard 20 Jul '11

20 Jul '11

Grazvydas Ignotas <notasas(a)gmail.com> writes: > @@ -2004,6 +2004,8 @@ NTSTATUS WINAPI NtQueryDirectoryFile( HANDLE handle, HANDLE event, > fstat( fd, &st ); > curdir.dev = st.st_dev; > curdir.ino = st.st_ino; > + if (lseek( fd, 0, SEEK_CUR ) == 0) > + restart_scan = TRUE; That won't work if we already returned '.' and '..'. -- Alexandre Julliard julliard(a)winehq.org

4 10

Re: comctl32: Improve the stub of TaskDialogIndirect to display a simple message box pending a full implementation
by Reece Dunn 20 Jul '11

20 Jul '11

On 20 July 2011 15:39, Jeff Latimer <lats(a)yless4u.com.au> wrote: > This should allow more apps to run. My mail import has blown up and I > may have messed up the format of the patch. The patch is line wrapped -- you need to send the patch as an attachment in a form that gets recognised as an octet stream (using the .patch extension should do this). > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON | TDCBF_CANCEL_BUTTON)) > + uType &= MB_YESNOCANCEL; > + else > + if (pTaskConfig->dwCommonButtons & (TDCBF_YES_BUTTON | > TDCBF_NO_BUTTON)) > + uType &= MB_YESNO; This will not work as intended -- (a & (b | c)) will evaluate true if a contains either b or c, equivalent to ((a & b) || (a & c)). You need to use ((a & b) == b) instead. - Reece

1 0

Re: po: Remove English strings from the Polish translation.
by Jacek Caban 20 Jul '11

20 Jul '11

Hi Francois, On 07/20/11 16:14, Francois Gouget wrote: > --- > po/pl.po | 88 +++++++++++++++++++++++++++++++------------------------------- > 1 files changed, 44 insertions(+), 44 deletions(-) > Separator, diagram and folder are the right Polish translations (that happen to be identical to English). Others should, obviously, be removed. Jacek

2 2

Re: [PATCH 1/5] quartz: Rather than assert, continue when IAsyncReader::WaitForNext is flushing and break when it actually times out.
by Alexandre Julliard 20 Jul '11

20 Jul '11

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -479,13 +488,27 @@ static void PullPin_Thread_Process(PullPin *This) > else > { > /* FIXME: This is not well handled yet! */ > - ERR("Processing error: %x\n", hr); > if (hr == VFW_E_TIMEOUT) > { > - assert(!pSample); > + struct timeval tve; > + > + /* > + * Calculate the time elapsed in IAsyncReader::WaitForNext > + * in order to determine whether a timeout actually occurred > + * or whether the pin is flushing. > + */ > + timersub(&tv2, &tv1, &tve); > + if (!timercmp(&tve, &tvw, <) && pSample != NULL) > + { > + ERR("Non-NULL sample returned with VFW_E_TIMEOUT.\n"); > + break; > + } That's really ugly. Surely there's a better way to do this than measuring the elapsed time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin 19 Jul '11

19 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12606 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: d3dx9_36: Use SUCCEEDED instead of !FAILED.
by Matteo Bruni 19 Jul '11

19 Jul '11

2011/7/19 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > dlls/d3dx9_36/mesh.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c > index 94a291f..d8f72c4 100644 > --- a/dlls/d3dx9_36/mesh.c > +++ b/dlls/d3dx9_36/mesh.c > @@ -3376,7 +3376,7 @@ HRESULT WINAPI D3DXLoadMeshFromXResource(HMODULE module, > if (!resinfo) return D3DXERR_INVALIDDATA; > > hr = load_resource_into_memory(module, resinfo, &buffer, &size); > - if (!FAILED(hr)) return D3DXERR_INVALIDDATA; > + if (SUCCEEDED(hr)) return D3DXERR_INVALIDDATA; > > return D3DXLoadMeshFromXInMemory(buffer, size, options, device, adjacency, > materials, effect_instances, num_materials, mesh); > -- > 1.7.6 > > > Isn't that supposed to be "if (FAILED(hr))" ? If I'm not mistaken, now it is returning failure when the resource is correctly loaded... Thumbs up for Michael's scripts finding real bugs ;)

2 1

Re: use Lithuanian letter in my name
by Frédéric Delanoy 19 Jul '11

19 Jul '11

On Mon, Jul 18, 2011 at 23:53, Nerijus Baliunas <nerijus(a)users.sourceforge.net> wrote: > --- > AUTHORS | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Maybe you should ensure that the name you commit your patches with (foo in 'foo <email>') is correctly spelled as well. I believe the authors list is generated from wine git's patch authors Frédéric

3 2

Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)
by Alexandre Julliard 18 Jul '11

18 Jul '11

Travis Athougies <iammisc(a)gmail.com> writes: > +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, D3DXHANDLE parameter) > +{ > + UINT i; > + > + for (i = 0; i < This->desc.Constants; i++) > + if ((ctab_constant *)parameter == &This->constants[i]) > + return (ctab_constant *)parameter; This doesn't look like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 1

Rejected or commited?
by wylda＠volny.cz 18 Jul '11

18 Jul '11

Hi, I just noticed that patch 76524 is "Rejected". But there is the same patch commited as 48d03555a7a6931ee8ba0952ccb92c70925c6bed. Duno, if some other patch should not be merged instead. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete.

2 1

Re: jscript: Properly handle aggregation attempt
by Marvin 18 Jul '11

18 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12575 Your paranoid android. === W2KPROSP4 (32 bit jscript) === jscript.c:615: Test failed: CoCreateInstance failed: 80070057, expected CLASS_E_NOAGGREGATION

1 0

Re: [PATCH 3/3] vbscript: Added creation tests
by Marvin 18 Jul '11

18 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12573 Your paranoid android. === WNT4WSSP6 (32 bit vbscript) === vbscript.c:38: Test failed: CoCreateInstance failed: 80040154 vbscript: unhandled exception c0000005 at 004012F2

1 0

Re: mshtml: Added IHTMLStyle::pageBreakAfter property implementation
by Marvin 18 Jul '11

18 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12568 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === WVISTAADM (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === W2K8SE (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null)

1 0

Re: [PATCH 02/10] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Alexandre Julliard 18 Jul '11

18 Jul '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -774,6 +775,28 @@ static void test_query_object(void) > pNtClose( handle ); > } > > +static void test_type_mismatch(void) > +{ > + HANDLE h; > + NTSTATUS res; > + OBJECT_ATTRIBUTES attr; > + > + attr.Length = sizeof(attr); > + attr.RootDirectory = 0; > + attr.ObjectName = NULL; > + attr.Attributes = 0; > + attr.SecurityDescriptor = NULL; > + attr.SecurityQualityOfService = NULL; > + Please avoid messing up the indentation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] dsound/tests: Add tests to check notifications after duplicate.
by Alexandre Julliard 18 Jul '11

18 Jul '11

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/dsound/tests/dsound.c | 178 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 178 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c && touch dsound.ok dsound.c:1066: Test succeeded inside todo block: expected 1. got 1 make[1]: *** [dsound.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32: handle %I... formats in user32.wsprintf* (try 2)
by Alexandre Julliard 18 Jul '11

18 Jul '11

Dan Kegel <dank(a)kegel.com> writes: > + i64 = 0x100000000LL; Don't use LL constants. > @@ -257,14 +282,25 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, > case WPR_SIGNED: > len = sprintf( number, "%d", arg->int_view ); > break; > + case WPR_SIGNED64: > + len = sprintf( number, "%lld", arg->int64_view ); > + break; Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/11] wscript: fixed running script from outside its directory (resend)
by Alexandre Julliard 18 Jul '11

18 Jul '11

Michał Ziętek <smierc.w.wenecji(a)gmail.com> writes: > @@ -347,7 +347,7 @@ int WINAPI wWinMain(HINSTANCE hInst, HINSTANCE hPrevInst, LPWSTR cmdline, int cm > return 1; > } > > - ext = strchrW(filename, '.'); > + ext = strrchrW(filename, '.'); That's not much better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Implment IHTMLDocument2 elementFromPoint
by Jacek Caban 18 Jul '11

18 Jul '11

Hi Alistair, On 07/18/11 06:29, Alistair Leslie-Hughes wrote: > Hi, > Fixmes http://bugs.winehq.org/show_bug.cgi?id=27682 > > > Changelog: > mshtml: Implment IHTMLDocument2 elementFromPoint > First of all, tests please. + nsIDOMElement *nselem = NULL; + nsresult nsres; + HRESULT hres; + HTMLDOMNode *node; You use tabs in the whole patch. + nsIDOMNSDocument *pNSDoc; Please don't add such variable names. Jacek

1 0

Re: mshtml: Handle the failure case in get_nsstyle_attr.
by Jacek Caban 18 Jul '11

18 Jul '11

Hi Gerald, On 07/15/11 22:49, Gerald Pfeifer wrote: > --- > dlls/mshtml/htmlstyle.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index cd1f6b5..3e76e61 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -468,6 +468,8 @@ HRESULT get_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, BSTR > > nsAString_GetData(&str_value, &value); > hres = nsstyle_to_bstr(value, flags, p); > + if( FAILED(hres) ) > + return hres; > nsAString_Finish(&str_value); Good catch, but you add a leak here. Jacek

1 0

Re: [PATCH 10/10] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin 18 Jul '11

18 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12563 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: ole32: Remove dead code.
by Nikolay Sivov 18 Jul '11

18 Jul '11

On Mon, Jul 18, 2011 at 9:43 AM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > > MSHLFLAGS_NORMAL == 0. > --- > dlls/ole32/compobj_private.h | 4 +--- > dlls/ole32/stubmanager.c | 19 ++----------------- > 2 files changed, 3 insertions(+), 20 deletions(-) > > Maybe it should be like 'flags == MSHLFLAGS_NORMAL' ?

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin 16 Jul '11

16 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12529 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/12] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Marvin 16 Jul '11

16 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12528 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin 16 Jul '11

16 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12527 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in an nonalertable mode
by Marvin 16 Jul '11

16 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12526 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: Glitch-free iTunes?
by Dan Kegel 16 Jul '11

16 Jul '11

Keith wrote: > http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… > Can you make a goal of supporting iTunes with no glitches? ... > Just this one app could be huge for Linux on the desktop. The main problem is driver support, I think (mainly usb, but probably also cd-r). There is some work on usb support going on; see http://wiki.winehq.org/USB I haven't tried that myself. (Has anyone tried this with iTunes yet?) According to $ winedump -j import ~/".wine/drive_c/Program Files/Common Files/Apple/Mobile Device Support/Drivers/usbaapl.sys" | grep offset offset 00009250 ntoskrnl.exe offset 00009264 HAL.dll offset 00009278 WMILIB.SYS offset 0000928c USBD.SYS support for wmilib.sys might need to be added for this app. And I suspect the pcworld guy was using an outdated version of wine (given the problems he reported with the package manager ui). Otherwise, current iTunes seems to be working reasonably well in current wine. I just downloaded and installed iTunes 10.3.1 with wine-1.3.23. I did have to set win7 mode, and I do have to click through one dialog saying it won't be able to burn cd's, but I can use the iTunes store to search for movies and play their trailers nicely; I can listen to internet radio or a local .mp3 for 5-10 minutes with no hint of trouble. So: yeah, we know it's an important app. But it's hard. Feel free to help out. - Dan

8 9

Re: [PATCH 02/12] kernel32/tests: make sure the pipe is opened in nonalertable mode
by Alexandre Julliard 15 Jul '11

15 Jul '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > --- > dlls/kernel32/tests/pipe.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so pipe.c && touch pipe.ok pipe.c:484: Test failed: ConnectNamedPipe pipe.c:494: Test failed: ReadFile pipe.c:497: Test failed: WriteFile pipe.c:503: Test failed: DisconnectNamedPipe Segmentation fault (core dumped) make: *** [pipe.ok] Error 139 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2] cmd/tests: Add tests for recursive rmdir
by Marvin 15 Jul '11

15 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12505 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc1def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel nonzero, bad', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7 === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x65 position 0 in line 125 (got 'errorlevel just right, good', wanted 'ok, foo created') batch.c:214: Test failed: unexpected char 0x61 position 0 in line 126 (got 'abc0def', wanted '1') batch.c:214: Test failed: unexpected char 0x65 position 0 in line 127 (got 'errorlevel zero, good', wanted 'ok, foo\bar created') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 128 (got '7 should be 7', wanted '----------- Testing rmdir -----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 129 (got '7 should still be 7', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 130 (got '-----------Testing GOTO-----------', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 131 (got 'goto with no leading space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 132 (got 'goto with a leading space worked', wanted 'dir removed') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 133 (got 'goto with a leading tab worked', wanted '0') batch.c:214: Test failed: unexpected char 0x67 position 0 in line 134 (got 'goto with a following space worked', wanted '0') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 135 (got '-----------Done, jumping to EOF-----------', wanted 'file not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 136 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 137 (got 'ok, foo created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 138 (got '7', wanted '0') batch.c:214: Test failed: unexpected char 0x6f position 0 in line 139 (got 'ok, foo\bar created', wanted 'non-empty dir not removed') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 140 (got '----------- Testing rmdir -----------', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 141 (got '7', wanted 'recursive rmdir succeeded') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 142 (got 'dir removed', wanted '-----------Testing Errorlevel-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 143 (got '7', wanted '1') batch.c:214: Test failed: unexpected char 0x64 position 0 in line 144 (got 'dir removed', wanted 'errorlevel just right, good') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 145 (got '7', wanted 'abc0def@or_broken@abc1def') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 146 (got '7', wanted 'errorlevel zero, good@or_broken@errorlevel nonzero, bad') batch.c:214: Test failed: unexpected char 0x66 position 0 in line 147 (got 'file not removed', wanted '7 should be 7') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 148 (got '7', wanted '7 should still be 7') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 149 (got 'non-empty dir not removed', wanted '-----------Testing GOTO-----------') batch.c:214: Test failed: unexpected char 0x37 position 0 in line 150 (got '7', wanted 'goto with no leading space worked') batch.c:214: Test failed: unexpected char 0x6e position 0 in line 151 (got 'non-empty dir not removed', wanted 'goto with a leading space worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 152 (got 'recursive rmdir succeeded', wanted 'goto with a leading tab worked') batch.c:214: Test failed: unexpected char 0x72 position 0 in line 153 (got 'recursive rmdir succeeded', wanted 'goto with a following space worked') batch.c:214: Test failed: unexpected char 0x2d position 0 in line 154 (got '-----------Testing Errorlevel-----------', wanted '-----------Done, jumping to EOF-----------') batch.c:228: Test failed: too long output, got additional 7

2 1

Re: [PATCH 10/11] wscript: implemented Host_get_Interactive
by Jacek Caban 15 Jul '11

15 Jul '11

Hi Michał, On 07/15/11 03:22, Michał Ziętek wrote: > --- > programs/wscript/host.c | 7 +++++-- > programs/wscript/main.c | 26 +++++++++++++++++++++++++- > programs/wscript/wscript.h | 2 ++ > 3 files changed, 32 insertions(+), 3 deletions(-) > +static const WCHAR* get_arg_beginning(const WCHAR* arg) +{ + const WCHAR *beg = arg; + while(*beg == '/' || *beg == '-') { + ++beg; + } + return beg; +} This won't do what you want it to. Jacek

1 0

Re: shell32: Fix cast in RecycleBinMenu_InvokeCommand
by Alexandre Julliard 14 Jul '11

14 Jul '11

Jay Yang <jkelleyy(a)gmail.com> writes: > @@ -240,7 +240,7 @@ static HRESULT WINAPI RecycleBinMenu_InvokeCommand(IContextMenu2 *iface, > LPCSTR verb = pici->lpVerb; > if(!HIWORD(verb)) > { > - switch((UINT)verb) > + switch((UINT_PTR)verb) Actually the HIWORD() is more problematic. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32: Make ISFHelper_fnCopyItems actually copy the items (try 2)
by Alexandre Julliard 14 Jul '11

14 Jul '11

Jay Yang <jkelleyy(a)gmail.com> writes: > Removed an unused variable. Still failing ("ret may be used uninitialized"). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] d3dx9_36: Added support for structs and arrays to ID3DXConstantTable (Try 2)
by Matteo Bruni 14 Jul '11

14 Jul '11

2011/7/14 Travis Athougies <iammisc(a)gmail.com>: > Needed for Assassin's Creed Brotherhood and Dead Space 2. > > Changes from last patch: > - New way of distinguishing handles from strings > - Support for parent constants in ID3DXConstantTable::GetConstantByName and ID3DXConstantTable::GetConstant > - Implemented ID3DXContantTable::GetConstantElement > You should split the reworking of D3DXHANDLEs into a separate patch. GetConstantElement could be on its own patch too, probably.

1 0

Bad flag check
by Francois Gouget 14 Jul '11

14 Jul '11

One of my scripts noticed that the following code does not make sense in dlls/winmm/waveform.c: static DWORD WINMM_NotifyClient(WINMM_CBInfo *info, WORD msg, DWORD_PTR param1, DWORD_PTR param2) { if(info->flags & DCB_NULL) return MMSYSERR_NOERROR; That's because DCB_NULL is 0 so this condition is always false. What was the intent? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

2 1

Fwd: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9
by Michael Mc Donnell 14 Jul '11

14 Jul '11

Hi Stefan sorry for the duplicate email. I forgot to also send it to wine-devel. On Fri, Jun 17, 2011 at 12:02 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 16 June 2011 10:49:19 Michael Mc Donnell wrote: >> I've added the test you outlined. It shows you're correct that >> GetDeclaration only writes up to D3DDECL_END(). I've changed the >> implementation so that it caches the number of elements and only >> writes up to D3DDECL_END(). > Looks good to me. Great! >> You're right it could potentially read undefined memory depending on >> the compiler semantics. I think the safest thing is just to read up to >> D3DDECL_END() in the passed in declaration, then it will never read >> undefined memory (except if the programmer makes a mistake). > Looks good, but please write a WARN message in every case where you return an > error to the application. We believe that we handled the error condition > correctly, so there's no need for a FIXME, but the broken app behavior may > have been triggered by some other problem in Wine, so the message is more > important than a simple TRACE. Ok I've added WARN message for every case where it returns an error to the application. I've also reworded the WARN where it uses an invalid declaration but still must return D3D_OK.

4 36

Visual Studio project to compile the d3d code
by Stefan Dösinger 14 Jul '11

14 Jul '11

Hi, After two people told me they might have use for my Visual Studio setup to compile wined3d I finally got around to put it on my git server. You can download it with GIT_SSL_NO_VERIFY=1 git clone https://84.112.174.163/~git/wined3d_vs What is this good for? My aims were to have Microsoft-Style debug symbols to use various Windows development tools. The also aim was to to work without Mingw, Msys or any other Unix tool besides git, mostly because mingw+msys is a pain. It performs an out-of-tree build of ddraw, d3d8, d3d9, the tests, wined3d and a few dependencies. Just put the files next to the wine sources, the project essentially loads the source files from ../wine/*. I also have d3dx9_36.dll in the project, but it doesn't link at the moment because d3dcompiler.dll is missing and some math functions. The testlist.c files for the tests cannot be autogenerated yet. The main issue is that this project is a stripped-down reimplementation of the wine build system. The source files and library exports are hardcoded, so if they change the msvc project needs manual adjustments. It would be much nicer to use the msvcmaker script for that, but I wasn't aware of this script when I started this. No additional software besides Visual Studio 2010 is needed, except for d3dx9_36 which needs the DirectX SDK. I just noticed that the d3d8 tests hardcode a path to the SDK sdk too, that is a bug that I can fix. I tried to compile the tests and d3d client libs with the MS headers to test our header compatibility but ran into some difficulties. The generated binaries also have no dependencies except the msvc2010 C runtime(msvcr100.dll) One word about licensing: I didn't find any obstacles that prevent personal use of MSVC Express, but please double-check the EULAs. Redistribution of Microsoft code is a problem however. The project setup doesn't deliberately include any MS code in the binaries, but it is possible that some functions from the C runtime is inlined, so to stay on the safe side I don't redistribute any binaries built from Visual Studio. There are a bunch of warnings left in the code. I fixed the warnings in wined3d.dll, d3d8.dll, d3d9.dll and the d3d8 tests, or silenced some warnings that I considered too pedantic or hard to fix. ddraw.dll, the ddraw tests and d3dx9 and the d3d9 tests have a number of legitimate warnings left. Stefan

2 5

Re: [PATCH 03/12] ntdll/tests: add a number of tests for the Nt pipe functions and ioctls
by Marvin 14 Jul '11

14 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12469 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout === W2K3R2SESP2 (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c000000d pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === WVISTAADM (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W2K8SE (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 === W7PRO (32 bit pipe) === pipe.c:154: Test failed: NtCreateNamedPipeFile returned c0000022 pipe.c:157: Test failed: NtCreateNamedPipeFile returned c0000008 pipe.c:162: Test failed: NtCreateNamedPipeFile returned 0 pipe.c:378: Test failed: IOAPC ran too early

1 0

Re: [PATCH 12/12] ntdll/tests: add some todo_wines to the new pipe test
by Marvin 14 Jul '11

14 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12472 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/12] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Marvin 14 Jul '11

14 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12471 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

New API functions for loading external dlls
by Saulius Krasuckas 13 Jul '11

13 Jul '11

It seems MS announced three new functions yesterday: SetDefaultDllDirectories AddDllDirectory RemoveDllDirectory These are "to help developers correctly and securely load external libraries". [1] I remember some talk about SetDllDirectory() in the past [2], so now it's interesting how these two ways would coexist. Plus, could the new way help to simplify loading Gecko / XPCOM [3] by a chance? Probably not:) S. [1] http://support.microsoft.com/KB/2533623 [2] http://www.winehq.org/pipermail/wine-patches/2005-August/019625.html [3] http://source.winehq.org/source/dlls/mshtml/nsembed.c?v=wine-1.1.8#L144

1 0

Re: [PATCH 02/12] wscript: added helper function for tests
by Juan Lang 12 Jul '11

12 Jul '11

Hi Michal, please combine this with patch 3, it doesn't make sense on its own. --Juan

1 0

Re: d3dx9_36: Provide a replacement for signbit() if it is missing.
by Alexandre Julliard 12 Jul '11

12 Jul '11

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -292,6 +292,10 @@ ssize_t pwrite( int fd, const void *buf, size_t count, off_t offset ); > int readlink( const char *path, char *buf, size_t size ); > #endif /* HAVE_READLINK */ > > +#ifndef HAVE_SIGNBIT > +#define signbit(x) (copysign(1, (x)) < 0) > +#endif /* !defined(HAVE_SIGNBIT) */ This isn't quite correct for floats, and it's not much more portable. I'd suggest to fix the code instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke
by Nikolay Sivov 12 Jul '11

12 Jul '11

On Tue, Jul 12, 2011 at 1:19 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke > + case DISPID_PICT_RENDER: + if (wFlags & DISPATCH_METHOD) + { + TRACE("DISPID_PICT_RENDER %d %d %d %d %d %d %d %d %d %d\n", + V_VT(&pDispParams->rgvarg[0]), V_VT(&pDispParams->rgvarg[1]), + V_VT(&pDispParams->rgvarg[2]), V_VT(&pDispParams->rgvarg[3]), + V_VT(&pDispParams->rgvarg[4]), V_VT(&pDispParams->rgvarg[5]), + V_VT(&pDispParams->rgvarg[6]), V_VT(&pDispParams->rgvarg[7]), + V_VT(&pDispParams->rgvarg[8]), V_VT(&pDispParams->rgvarg[9])); + + return IPicture_Render(&This->IPicture_iface, (HDC)V_I4(&pDispParams->rgvarg[9]), + V_I4(&pDispParams->rgvarg[8]), V_I4(&pDispParams->rgvarg[7]), + V_I4(&pDispParams->rgvarg[6]), V_I4(&pDispParams->rgvarg[5]), + V_I4(&pDispParams->rgvarg[4]), V_I4(&pDispParams->rgvarg[3]), + V_I4(&pDispParams->rgvarg[2]), V_I4(&pDispParams->rgvarg[1]), + (LPCRECT)&V_I4(&pDispParams->rgvarg[0])); + } + break; Correct me if I'm wrong, isn't it supposed to coerce arguments here? > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

RE: oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke
by wylda＠volny.cz 12 Jul '11

12 Jul '11

Hi, isn't there a white space issue? (trailing) Regards, W.

1 0

Re: [PATCH 4/9 (try5)] winmm: Implement waveIn* on top of MMDevAPI
by Alexandre Julliard 12 Jul '11

12 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/winmm/waveform.c | 622 > +++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 574 insertions(+), 48 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so capture.c && touch capture.ok wine: Unhandled page fault on write access to 0x00000018 at address 0x68e9a0ab (thread 0009), starting debugger... Unhandled exception: page fault on write access to 0x00000018 in 32-bit code (0x68e9a0ab). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68e9a0ab ESP:0032fc2c EBP:0032fc68 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:68ec468c ECX:00110064 EDX:00000000 ESI:0012c0f8 EDI:00128df0 Stack dump: 0x0032fc2c: 686a71ec 00128df0 00129c80 6869e7f0 0x0032fc3c: 686a71ec 00128df0 6869e7f0 0032fc68 0x0032fc4c: 00000000 00000001 6869ef24 0032fc78 0x0032fc5c: 686a71ec 00128df0 6869e7f0 0032fcc8 0x0032fc6c: 686864c1 00128df0 6869ef24 00000000 0x0032fc7c: 6869dbd5 00000002 00000000 00000000 Backtrace: =>0 0x68e9a0ab IDirectSoundCaptureImpl_Release+0xdb(iface=0x128df0) [/home/julliard/wine/wine/dlls/dsound/capture.c:1027] in dsound (0x0032fc68) 1 0x686864c1 IDirectSoundCapture_test+0x350(dsco=0x128df0, initialized=0, lpGuid=(nil)) [/home/julliard/wine/wine/dlls/dsound/tests/capture.c:175] in dsound_test (0x0032fcc8) 2 0x686881b1 func_capture+0x220() [/home/julliard/wine/wine/dlls/dsound/tests/capture.c:207] in dsound_test (0x0032fd38) 3 0x6869da3e run_test+0x14d(name="capture.c") [/home/julliard/wine/wine/dlls/dsound/tests/../../../include/wine/test.h:556] in dsound_test (0x0032fd88) 4 0x6869e507 main+0x156(argc=0xffffffff, argv=(nil)) [/home/julliard/wine/wine/dlls/dsound/tests/../../../include/wine/test.h:624] in dsound_test (0x0032fe48) 5 0x6869e6dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in dsound_test (0x0032fe90) 6 0x7b85ac4c call_process_entry+0xb() in kernel32 (0x0032fea8) 7 0x7b85bc4f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1087] in kernel32 (0x0032fee8) 8 0x7bc73908 call_thread_func+0xb() in ntdll (0x0032fef8) 9 0x7bc7706e call_thread_entry_point+0x6d(entry=0x7b85bbf0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 10 0x7bc4c16e start_process+0x1d(kernel_start=0x7b85bbf0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 11 0x6802996d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x68e9a0ab IDirectSoundCaptureImpl_Release+0xdb [/home/julliard/wine/wine/dlls/dsound/capture.c:1027] in dsound: movl $0x0,0x18(%eax) 1027 device->lock.DebugInfo->Spare[0] = 0; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: BuildActionMap and SetActionMap stubs for generic joystick
by Michael Stefaniuc 12 Jul '11

12 Jul '11

Hello Lucas, for the future please stop adding the LPJUNK for COM interfaces, e.g. LPDIRECTINPUTDEVICE8W, use IDirectInputDevice8W* instead. In addition to the normal issues with the LPJUNK it hides the fact that this are interfaces making it hard to review that the COM rules aren't violated. It also complicates my COM cleanup script to the point that I've started to automatically replace PJUNK and LPJUNK with IJunk*. thanks bye michael Lucas Fialho Zawacki wrote: > --- > dlls/dinput/joystick.c | 60 +++++++++++++++++++++++++++++++++++++ > dlls/dinput/joystick_linux.c | 8 ++-- > dlls/dinput/joystick_linuxinput.c | 8 ++-- > dlls/dinput/joystick_osx.c | 8 ++-- > dlls/dinput/joystick_private.h | 6 ++++ > 5 files changed, 78 insertions(+), 12 deletions(-) > > diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c > index 1be6f31..68dcc6a 100644 > --- a/dlls/dinput/joystick.c > +++ b/dlls/dinput/joystick.c > @@ -426,6 +426,66 @@ HRESULT WINAPI JoystickAGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8A iface, > return JoystickWGenericImpl_GetDeviceState(IDirectInputDevice8W_from_impl(This), len, ptr); > } > > + > +HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, > + LPDIACTIONFORMATW lpdiaf, > + LPCWSTR lpszUserName, > + DWORD dwFlags) > +{ > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > + > + return DI_NOEFFECT; > +} > + > +HRESULT WINAPI JoystickAGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8A iface, > + LPDIACTIONFORMATA lpdiaf, > + LPCSTR lpszUserName, > + DWORD dwFlags) > +{ > + JoystickGenericImpl *This = impl_from_IDirectInputDevice8A(iface); > + DIACTIONFORMATW diafW; > + HRESULT hr; > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = JoystickWGenericImpl_BuildActionMap(&This->base.IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); > + HeapFree(GetProcessHeap(), 0, diafW.rgoAction); > + > + return hr; > +} > + > +HRESULT WINAPI JoystickWGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface, > + LPDIACTIONFORMATW lpdiaf, > + LPCWSTR lpszUserName, > + DWORD dwFlags) > +{ > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > + > + return DI_NOEFFECT; > +} > + > +HRESULT WINAPI JoystickAGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface, > + LPDIACTIONFORMATA lpdiaf, > + LPCSTR lpszUserName, > + DWORD dwFlags) > +{ > + JoystickGenericImpl *This = impl_from_IDirectInputDevice8A(iface); > + DIACTIONFORMATW diafW; > + HRESULT hr; > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = JoystickWGenericImpl_SetActionMap(&This->base.IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + HeapFree(GetProcessHeap(), 0, diafW.rgoAction); > + > + return hr; > +} > + > /* > * This maps the read value (from the input event) to a value in the > * 'wanted' range. > diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c > index 5541522..3ad592d 100644 > --- a/dlls/dinput/joystick_linux.c > +++ b/dlls/dinput/joystick_linux.c > @@ -682,8 +682,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -718,8 +718,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c > index c11edc7..afdee1e 100644 > --- a/dlls/dinput/joystick_linuxinput.c > +++ b/dlls/dinput/joystick_linuxinput.c > @@ -1417,8 +1417,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -1453,8 +1453,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 439c8ad..756a682 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -972,8 +972,8 @@ static const IDirectInputDevice8AVtbl JoystickAvt = > IDirectInputDevice2AImpl_SendDeviceData, > IDirectInputDevice7AImpl_EnumEffectsInFile, > IDirectInputDevice7AImpl_WriteEffectToFile, > - IDirectInputDevice8AImpl_BuildActionMap, > - IDirectInputDevice8AImpl_SetActionMap, > + JoystickAGenericImpl_BuildActionMap, > + JoystickAGenericImpl_SetActionMap, > IDirectInputDevice8AImpl_GetImageInfo > }; > > @@ -1008,8 +1008,8 @@ static const IDirectInputDevice8WVtbl JoystickWvt = > IDirectInputDevice2WImpl_SendDeviceData, > IDirectInputDevice7WImpl_EnumEffectsInFile, > IDirectInputDevice7WImpl_WriteEffectToFile, > - IDirectInputDevice8WImpl_BuildActionMap, > - IDirectInputDevice8WImpl_SetActionMap, > + JoystickWGenericImpl_BuildActionMap, > + JoystickWGenericImpl_SetActionMap, > IDirectInputDevice8WImpl_GetImageInfo > }; > > diff --git a/dlls/dinput/joystick_private.h b/dlls/dinput/joystick_private.h > index a332e24..71d91f1 100644 > --- a/dlls/dinput/joystick_private.h > +++ b/dlls/dinput/joystick_private.h > @@ -86,4 +86,10 @@ HRESULT WINAPI JoystickWGenericImpl_Poll(LPDIRECTINPUTDEVICE8W iface) DECLSPEC_H > HRESULT WINAPI JoystickAGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8A iface, DWORD len, LPVOID ptr) DECLSPEC_HIDDEN; > HRESULT WINAPI JoystickWGenericImpl_GetDeviceState(LPDIRECTINPUTDEVICE8W iface, DWORD len, LPVOID ptr) DECLSPEC_HIDDEN; > > +HRESULT WINAPI JoystickAGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8A iface, LPDIACTIONFORMATA lpdiaf, LPCSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > +HRESULT WINAPI JoystickWGenericImpl_BuildActionMap(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, LPCWSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > + > +HRESULT WINAPI JoystickAGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface, LPDIACTIONFORMATA lpdiaf, LPCSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > +HRESULT WINAPI JoystickWGenericImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, LPCWSTR lpszUserName, DWORD dwFlags) DECLSPEC_HIDDEN; > + > #endif /* __WINE_DLLS_DINPUT_JOYSTICK_PRIVATE_H */

1 0

Re: [PATCH] libv4l: Fixed videodev.h header moving away from glibc to libv4l-devel
by Alexandre Julliard 12 Jul '11

12 Jul '11

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > As seen in openSUSE 12.1 development, <linux/videodev.h> is no longer, ioctls > come from the libv4l compat library. We should probably switch to version 2 instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Raw Input Patch Update 16
by Vincas Miliūnas 12 Jul '11

12 Jul '11

This time submitting the full implementation to wine-devel and only the first patch to wine-patches. Changelog of the full implementation: * Rewritten test assertion messages to just state the reason of failure * Improved WM_INPUT posting, so it would be reflected using the GetQueueStatus function * Added proper GetRawInputBuffer implementation, that requires selecting and removing messages from the message queue, but that's how it works * Added releasing of allocated resources for raw input when destroying a process * Fixed DefRawInputProc to return -1 in case of an error instead of an error code. Also improved function's tests * Added tests and made RegisterRawInputDevices atomic, so there would be no changes if one of submitted registrations fails * Added tests to check for the correct GetQueueStatus(QS_RAWINPUT) status * Added tests to check for empty input queue before sending input using GetInputState * Tests of GetRegisteredRawInputDevices and RegisterRawInputDevices need to be paired and have both as a dependency, so split their tests into 4 parts to make smaller blocks of code * Moved raw input server request handlers to the bottom of the source file, like in the other files * Applied aligned formatting for groups of assignment statements * Other minor refactorings Zipped version - http://dl.dropbox.com/u/6901628/try16.zip Also I need to note the lack of applications that make extensive use of the raw input API. There are just a few games and they are convenient with just the mouse movement data.

2 1

Re: cmd/tests: Add test for parameter detection
by Marvin 11 Jul '11

11 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12408 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2KPROSP4 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WXPPROSP3 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K3R2SESP2 (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === WVISTAADM (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W2K8SE (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter') === W7PRO (32 bit) === batch.c:214: Test failed: unexpected char 0x69 position 0 in line 77 (got 'if seems to not detect /c as parameter', wanted ' if seems to not detect /c as parameter')

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Vitaliy Margolen 11 Jul '11

11 Jul '11

On 07/08/2011 12:01 PM, Lucas Fialho Zawacki wrote: > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); You can use strcpyW instead. Or even lstrcpynW to guard against buffer overflow. > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) You need to modify ascii version of SetActionMap as well. Vitaliy.

1 0

build error in dlls/d3dx9_36/tests/math.c
by Marcus Meissner 11 Jul '11

11 Jul '11

Hi, I get on dlls/d3dx9_36/tests/math.c: (Code added in a6b40624dbc457ba7b0b4b307b1eb88617c67197 by Misha Koshelev <misha680(a)gmail.com>) gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme nt -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -DLDAP_DEPRECATED=1 -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-prot ector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o mesh.o mesh.c math.c: In function 'test_D3DXFloat_Array': math.c:2251: error: 'INFINITY' undeclared (first use in this function) math.c:2251: error: (Each undeclared identifier is reported only once math.c:2251: error: for each function it appears in.) math.c:2253: error: 'NAN' undeclared (first use in this function) make[1]: *** [math.o] Error 1 NAN and INFINITY variables are ISO C 99 features and would need #define _ISOC99_SOURCE at the beginning of the source. Would such a patch be accepted? Or perhaps add 0.0/0.0 1.0/0.0 or similar constructs? Ciao, Marcus

4 3

Re: xlive preliminary implementation
by Damjan Jovanovic 11 Jul '11

11 Jul '11

On Sat, Jul 9, 2011 at 10:24 AM, Giovanni Ongaro <giovanni.nicola(a)ticino.com> wrote: > Hi, i am a compuer scientist in the age of 46, > i have written a partial porting of xliveless to the wine git tree > adding the xlive dll. > > Right now it is in this state: > > Section 8 runs but does not save > > FUEL runs but does not save > > Red faction Guerrilla starts but i do not know if it saves > > Bulletstorm seems to save ok > > Batman Arkham Asylum runs and saves ok > > Street fighter 4 gives error after starting launcher > > Alarm for cobra 11 the syndicate does not start > > Fallout 3 runs and saves ok > > > > Your changes to dlls/xlive were not included in your patch, you probably forgot to do "git add dlls/xlive" first: --- configure | 777 ++++++++++++++++++++++++++++------------------------------ configure.ac | 1 + 2 files changed, 375 insertions(+), 403 deletions(-) Also you don't need to send changes to configure, only configure.ac. Otherwise thank you for your contribution. Damjan Jovanovic

1 0

Re: xmllite: Implement CreateXmlWriter
by Octavian Voicu 11 Jul '11

11 Jul '11

On Sun, Jul 10, 2011 at 1:17 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Subject: [PATCH] Implement CreateXmlWriter ... > +/* > + * XMLLite IXmlReader tests > + * ... > +typedef struct _xmlreader > +{ > + IXmlWriter IXmlWriter_iface; > + LONG ref; > +} xmlwriter; Looks like you have some copy-paste errors (IXmlReader and _xmlreader). Cheers, Octavian

1 0

Some notes from wineconf about the 1.4 release -- are we on track?
by Scott Ritchie 10 Jul '11

10 Jul '11

According to Alexandre... 1.4 will be out "sometime in 2011" At the time of wineconf we already had several new features: animated cursors, 64-bit Gecko, native cursor themes, AcceptEx support, mono packages Goals for the 1.4 release: Successful 64-bit make test Successful 32-bit make test ;) RTL support Transparency/compositing XInput2 USB support Audio redesign DIB Engine There were also these suggestions: Addons or plugins of some sort - eg a theme for GTK-grabbing Dosbox integration - possibly using Windows versions as add-on - get rid of Winedos code Plus, of course, the general goal of making more applications work :) It seems like we're making serious progress. Have any of these stalled or become less important? Has any new big feature not listed above been done that's worth listing? Is "sometime in 2011" still the best guess for 1.4's release? Thanks, Scott Ritchie

3 2

Re: d3dx9_36: Use cross-platform versions of infinity and NaN.
by Marvin 09 Jul '11

09 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12221 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K3R2SESP2 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === WVISTAADM (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W2K8SE (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PRO (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18. === W7PROX64 (32 bit math) === math.c:2275: Test failed: Got ffff, expected 7fff or 7fff for index 18.

3 4

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard 09 Jul '11

09 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -198,21 +1771,25 @@ UINT WINAPI waveOutGetErrorTextA(UINT uError, LPSTR lpText, UINT uSize) > */ > UINT WINAPI waveOutGetErrorTextW(UINT uError, LPWSTR lpText, UINT uSize) > { > - UINT ret = MMSYSERR_BADERRNUM; > - > - if (lpText == NULL) ret = MMSYSERR_INVALPARAM; > - else if (uSize == 0) ret = MMSYSERR_NOERROR; > - else if ( > - /* test has been removed because MMSYSERR_BASE is 0, and gcc did emit > - * a warning for the test was always true */ > - (/*uError >= MMSYSERR_BASE && */ uError <= MMSYSERR_LASTERROR) || > - (uError >= WAVERR_BASE && uError <= WAVERR_LASTERROR)) { > - if (LoadStringW(hWinMM32Instance, > - uError, lpText, uSize) > 0) { > - ret = MMSYSERR_NOERROR; > - } > - } > - return ret; > + TRACE("(%u, %p, %u)\n", uError, lpText, uSize); > + > + if(!WINMM_StartDevicesThread()) > + return MMSYSERR_ERROR; > + > + if(!lpText) > + return MMSYSERR_INVALPARAM; > + > + if(uSize == 0) > + return MMSYSERR_NOERROR; > + > + if(uError > MMSYSERR_LASTERROR || uError < WAVERR_BASE || > + uError > WAVERR_LASTERROR) > + return MMSYSERR_BADERRNUM; This doesn't do what you want (and that sort of change could easily be a separate patch). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/10] user32/tests: Added DefRawInputProc tests (try 15)
by Alexandre Julliard 09 Jul '11

09 Jul '11

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > + ret = pDefRawInputProc(&input, 0, sizeof(RAWINPUTHEADER)); > + ok(ret == S_OK, "Given (&input, 0, sizeof), " > + "DefRawInputProc should acknowledge that no data was provided\n"); > +} That's not really testing anything. Also please avoid that sort of error message, describing the input is useless, it's just noise that is going to bitrot. A simple "DefRawInputProc returned %x" would be a lot more useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/5] dinput: Added device's owner username set by SetActionMap and the respective GetProperty to retrieve it
by Lucas Zawacki 08 Jul '11

08 Jul '11

I realized this patch and the next are wrong and don't work, despite the tests passing. No need to bother reading them. 2011/7/8 Lucas Fialho Zawacki <lfzawacki(a)gmail.com>: > --- > dlls/dinput/device.c | 22 ++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5d81227..99c854c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -953,6 +953,16 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + if (strlenW(This->owner) == 0) return S_FALSE; > + > + memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR)); > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1459,10 +1469,22 @@ HRESULT WINAPI IDirectInputDevice8WImpl_SetActionMap(LPDIRECTINPUTDEVICE8W iface > LPCWSTR lpszUserName, > DWORD dwFlags) > { > + IDirectInputDeviceImpl *This = impl_from_IDirectInputDevice8W(iface); > DIPROPDWORD dp; > + DWORD username_size = MAX_PATH; > + WCHAR username[MAX_PATH]; > > FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, debugstr_w(lpszUserName), dwFlags); > > + /* NULL username defaults to the logged user */ > + if (lpszUserName == NULL) > + { > + GetUserNameW(username, &username_size); > + lpszUserName = username; > + } > + > + memcpy(This->owner, lpszUserName, strlenW(lpszUserName)*sizeof(WCHAR)); > + > if (lpdiaf->dwBufferSize > 0) > { > dp.diph.dwSize = sizeof(DIPROPDWORD); > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 503698a..6df8d93 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR owner[MAX_PATH]; /* username of the device's owner */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > -- > 1.7.0.4 >

1 0

re: wined3d: Introduce quirk for proper RGBA16 support.
by Dan Kegel 08 Jul '11

08 Jul '11

It seems to work... but in Mass Effect 2 Demo with the patch, the initial cinematics (where Shepard is trying to put out the fire, and you're prompted to answer "There's no time to argue", are very jerky, and CPU usage is very high. I didn't have that problem without the patch.

1 1

Re: [PATCH 2/9] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard 08 Jul '11

08 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static inline HWAVE WINMM_MakeHWAVE(UINT mmdevice, BOOL is_out, UINT device) > +{ > + return (HWAVE)((1 << 15) | ((!!is_out) << 14) | (mmdevice << 8) | device); > +} > + > +static inline void WINMM_DecomposeHWAVE(HWAVE hwave, UINT *mmdevice_index, > + BOOL *is_out, UINT *device_index, UINT *junk) > +{ > + *device_index = ((UINT)hwave & 0xFF); > + *mmdevice_index = ((UINT)hwave >> 8) & 0x3F; > + *is_out = ((UINT)hwave >> 14) & 0x1; > + *junk = (UINT)hwave >> 15; > +} This (and the same thing in various other places) will cause pointer conversion warnings on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Fix SETUPDI_OpenDrvKey
by Alexandre Julliard 08 Jul '11

08 Jul '11

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > @@ -3728,8 +3728,13 @@ static HKEY SETUPDI_OpenDrvKey(struct DeviceInfo *devInfo, REGSAM samDesired) > WCHAR devId[10]; > > sprintfW(devId, fmt, devInfo->devId); > - RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > - RegCloseKey(classKey); > + l = RegOpenKeyExW(classKey, devId, 0, samDesired, &key); > + if (!l) { > + RegCloseKey(classKey); > + } else { > + SetLastError(ERROR_KEY_DOES_NOT_EXIST); > + return INVALID_HANDLE_VALUE; > + } You are leaking the key now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin (try 2)
by Alexandre Julliard 08 Jul '11

08 Jul '11

Jay Yang <jkelleyy(a)gmail.com> writes: > +static void test_query_recyclebin(void) > +{ > + SHQUERYRBINFO info1={sizeof(info1),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; > + SHQUERYRBINFO info2={sizeof(info2),0xdeadbeefdeadbeefLL,0xdeadbeefdeadbeefLL}; You can't use LL constants. -- Alexandre Julliard julliard(a)winehq.org

1 0

Bug #2082
by Charles Welton 08 Jul '11

08 Jul '11

This is one of the longest standing bugs which don't get much love from developers. Today I took some time with traces and wrote a test case which fails against git: http://bugs.winehq.org/attachment.cgi?id=35469 What is happening? When there's a child window to the ddraw window over it(the ddraw window), wined3d doesn't draw over the child. Windows, however, doesn't care about children and draws over them. Note that the DC is the same for both(according to traces). Not only that, the child window have different positions when in fullscreen or virtual desktop. As for the fix, I have yet to find the culprit dll(s) for this. Unfortunately I don't have the experience with wine's code and would like suggestions as to where to begin. -- Charles Welton

2 1

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)
by Juan Lang 08 Jul '11

08 Jul '11

Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

3 3

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin 07 Jul '11

07 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)
by Marvin 07 Jul '11

07 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin
by Marvin 07 Jul '11

07 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12300 Your paranoid android. === WNT4WSSP6 (32 bit recyclebin) === No test summary line found === W2KPROSP4 (32 bit recyclebin) === No test summary line found === WXPPROSP3 (32 bit recyclebin) === No test summary line found === W2K3R2SESP2 (32 bit recyclebin) === No test summary line found === WVISTAADM (32 bit recyclebin) === No test summary line found === W2K8SE (32 bit recyclebin) === No test summary line found === W7PRO (32 bit recyclebin) === No test summary line found

1 0

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu 07 Jul '11

07 Jul '11

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -132,21 +132,21 @@ static void test_fileops( void ) > rewind(file); > for (i = 0, c = EOF; i < sizeof(outbuffer); i++) Isn't c = EOF in for initialization also a dead assignment? Octavian

2 1

Re: msvcrt/tests: Remove dead assignment (Clang)
by Octavian Voicu 07 Jul '11

07 Jul '11

2011/7/7 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > c = outbuffer[sizeof(outbuffer) - 1]; > ok(ungetc(c, file) == c, "ungetc did not return its input for bufmode=%x\n", bufmodes[bufmode]); > ok(!feof(file), "feof after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > - ok((c = fgetc(file)) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > + ok(fgetc(file) != EOF, "getc after ungetc returned EOF for bufmode=%x\n", bufmodes[bufmode]); > ok(c == outbuffer[sizeof(outbuffer) - 1], > "getc did not return ungetc'd data for bufmode=%x\n", bufmodes[bufmode]); Also, this change doesn't look like it's removing a dead assignment, but it does make the test ok(c == outbuffer[sizeof(outbuffer) - 1], ...) always succeed. Octavian

2 1

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.
by Juan Lang 07 Jul '11

07 Jul '11

Hi Jacek, > These are functions that I missed when revieweing Gecko headers. I will > probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have: current Wine + current gecko = crash By changing the calling convention in Wine, we have: Wine <= 1.3.23 + current gecko = crash Wine 1.3.24-?? + current gecko = no crash Wine ?? + current gecko = crash Wine ?? + new gecko = no crash Wine <= 1.3.23 + new gecko = crash By doing a new gecko release, we have: any Wine + current gecko = crash any Wine + new gecko = no crash --Juan

2 3

Re: [PATCH 1/2] kernel32: Fixes various 'profile' functions (profile.c). (try 3)
by Alexandre Julliard 07 Jul '11

07 Jul '11

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > kernel32: Fixes various 'profile' functions. > Try 2: Formatting change. > Try 3: Splitted tests/profile.c patch You can't split it that way. What you need is to split each separate fix together with its own test fix. Also please use a subject message that describes what you are fixing, not just "fixes various functions". -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
by Nikolay Sivov 07 Jul '11

07 Jul '11

On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext > + ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface); + + TRACE("(%p,%d), stub!\n", iface, dwHelpStringContext); It's not a stub anymore. + + This->typelib->typelib_header.helpcontext = dwHelpStringContext; Could you please get rid of this ugly naming here and use something like 'context' for variable. + + return S_OK; } > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: msxml3: Don't format xml output if we should be preserving whitespace.
by Marvin 06 Jul '11

06 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12283 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WXPPROSP3 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === WVISTAADM (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W2K8SE (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root> === W7PRO (32 bit domdoc) === domdoc.c:9104: Test failed: got L"<root><foo><bar/></foo></root>", expected <root>

1 0

Re: kernel32: Fixes various 'profile' functions.
by André Hentschel 06 Jul '11

06 Jul '11

spotted with a quick look on it: Am 06.07.2011 18:54, schrieb Christian Inci: > kernel32: Fixes various 'profile' functions. > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index a2bd5b5..da7661c 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -316,6 +316,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > PROFILESECTION **next_section; > PROFILEKEY *key, *prev_key, **next_key; > DWORD dwFileSize; > + BOOL no_section = TRUE; > > TRACE("%p\n", hFile); > > @@ -440,6 +441,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > next_section = &section->next; > next_key = &section->key; > prev_key = NULL; > + no_section = FALSE; formatting! > @@ -1179,6 +1183,7 @@ INT WINAPI GetPrivateProfileStringA( LPCSTR section, LPCSTR entry, > ret = len - 1; > } > buffer[ret] = 0; > + buffer[ret+1] = 0; > } really? -- Best Regards, André Hentschel

1 0

Re: ws2_32: Remove dead assignment (Clang)
by Marcus Meissner 06 Jul '11

06 Jul '11

On Wed, Jul 06, 2011 at 10:34:45AM +0200, Frédéric Delanoy wrote: > --- > dlls/ws2_32/socket.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 4fc65ab..91aab01 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5874,7 +5874,7 @@ SOCKET WINAPI WSAAccept( SOCKET s, struct WS_sockaddr *addr, LPINT addrlen, > { > case CF_ACCEPT: > if (addr && addrlen) > - addr = memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); > + memcpy(addr, &src_addr, (*addrlen > size) ? size : *addrlen ); This is wrong. Keep the addrlen check. Ciao, Marcus

1 1

Re: shell32: Remove dead assignments (Clang)
by Nikolay Sivov 06 Jul '11

06 Jul '11

2011/7/6 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > dlls/shell32/shelllink.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c > index 07fe7aa..fff0e79 100644 > --- a/dlls/shell32/shelllink.c > +++ b/dlls/shell32/shelllink.c > @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave( > Stream_WriteLocationInfo( stm, This->sPath, &This->volume ); > > if( This->sDescription ) > - r = Stream_WriteString( stm, This->sDescription ); > + Stream_WriteString( stm, This->sDescription ); > This is questionable. If you write to a provided stream it's ok for it to fail write operation, this needs a test. Method return value should probably reflect write failure.

1 0

Re: [PATCH] ntdll/tests: Added tests for ObjectTypeInformation class in NtQueryObject
by Vitaliy Margolen 06 Jul '11

06 Jul '11

On 07/05/2011 07:20 PM, Austin Lund wrote: > + todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) + sizeof(WCHAR), "unexpected len %u\n", len ); What is that magic number "88"? If it's a size of some structure - then please use it explicitly. Vitaliy.

1 0

Re: [1/10] dinput: Implement IDirectInput::RunControlPanel.
by Vitaliy Margolen 06 Jul '11

06 Jul '11

On 07/05/2011 06:18 AM, Andrew Nguyen wrote: > --- > dlls/dinput/dinput_main.c | 15 ++++++++- > dlls/dinput/tests/Makefile.in | 1 + > dlls/dinput/tests/dinput.c | 69 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 84 insertions(+), 1 deletions(-) > create mode 100644 dlls/dinput/tests/dinput.c Patches look good to me. Vitaliy.

1 0

Re: d3dx9_36: Push down the scope of two variables. (RESEND)
by Alexandre Julliard 05 Jul '11

05 Jul '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste (IOW, not something you should "fix" in other people's code). -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH 1/5] d3dx9_36: Implement D3DXHANDLE more robustly
by Henri Verbeet 05 Jul '11

05 Jul '11

On 5 July 2011 23:45, Travis Athougies <iammisc(a)gmail.com> wrote: > Fixes bug 26583. > > Allows deadspace 2 to run without native dlls. This contains no useful information about what issue this is supposed to fix, unless you expect people to actually debug it themselves first. And I even went through the trouble to lookup the bug. > +static WORD new_handle_with_desc_and_name(ID3DXConstantTableImpl* This, D3DXCONSTANT_DESC* desc, LPCSTR name, LPCSTR full_name) > +{ > + ++This->handle_count; > + if (This->handles) > + This->handles = HeapReAlloc(GetProcessHeap(), 0, This->handles, sizeof(ctab_handle) * This->handle_count); > + else > + This->handles = HeapAlloc(GetProcessHeap(), 0, sizeof(ctab_handle) * This->handle_count); > + > + This->handles[This->handle_count - 1].desc = *desc; > + This->handles[This->handle_count - 1].desc.Name = strdup(name); > + This->handles[This->handle_count - 1].full_name = strdup(full_name); > + > + return This->handle_count; > +} That's just terrible.

1 0

Re: [PATCH 1/2] d3dx9/line: Implement Begin and End methods. (try 2)
by Charles Welton 05 Jul '11

05 Jul '11

Is there a reason why this patch and it's brother weren't merged in yet? This has been sitting for a few days and no comments about it yet. On 06/29/2011 07:08 PM, Charles Welton wrote: > Since the last patch spent some time without comments and wasn't > commited, I'm resending. > > Try 2 because of TRACE calls and whitespace fixes. > > --- > dlls/d3dx9_36/line.c | 73 > +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 69 insertions(+), 4 deletions(-) > > -- Charles Welton

2 1

Re: [4/9] msxml3: Implement IXMLDOMNodeList::QueryInterface(IEnumVARIANT).
by Nikolay Sivov 05 Jul '11

05 Jul '11

On Tue, Jul 5, 2011 at 8:11 PM, Adam Martinson <amartinson(a)codeweavers.com> wrote: > --- > dlls/msxml3/nodelist.c | 33 ++++++++++++++++++++++++++++++++- > dlls/msxml3/selection.c | 34 ++++++++++++++++++++++++++++++++-- > 2 files changed, 64 insertions(+), 3 deletions(-) > > + else if ( IsEqualGUID( riid, &IID_IEnumVARIANT ) ) + { + if (!This->enumv && + (This->enumv = create_nodelist_enum(&This->IXMLDOMNodeList_iface))) + IXMLDOMNodeList_Release(iface); /* create_nodelist_enum() adds a ref, and we don't here. */ + + if (!This->enumv) + { + *ppvObject = NULL; + return E_OUTOFMEMORY; + } + + IEnumVARIANT_AddRef(This->enumv); + *ppvObject = This->enumv; + return S_OK; + } Shouldn't this->enumv be protected somehow to work with multiple threads? I know that so called FreeThreaded* thing is only reported to be supported, but still. Maybe something like pointer exchange call will work.

2 1

Re: [PATCH] wscript: implemented Host_get_BuildVersion
by Paul Vriens 05 Jul '11

05 Jul '11

On 07/04/2011 11:28 PM, Michał Ziętek wrote: > +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

1 0

Re: winedevice: eliminate the driver_name global variable
by Alexandre Julliard 05 Jul '11

05 Jul '11

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate the driver_name global variable > > This is part of general refactoring to make the driver loading code reusable. Have you fixed it since last time or is it the same patch? Either way it's still crashing. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 03/10] winmm: Implement waveOut* on top of MMDevAPI
by Alexandre Julliard 05 Jul '11

05 Jul '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +static MMRESULT WINMM_SendDeviceThreadMessage(UINT msg, WPARAM wp) > +{ > + DWORD wait; > + MMRESULT res; > + > + EnterCriticalSection(&g_devthread_lock); > + > + if(!PostThreadMessageW(g_devthread_id, msg, wp, (DWORD_PTR)&res)){ > + ERR("PostThreadMessage failed: %d\n", GetLastError()); > + LeaveCriticalSection(&g_devthread_lock); > + return MMSYSERR_ERROR; > + } > + > + wait = WaitForSingleObject(g_devthread_evt, INFINITE); > + > + LeaveCriticalSection(&g_devthread_lock); If you are going to wait for a reply it would be better to create a HWND_MESSAGE window and do a SendMessage to it, then you get all the synchronization for free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Glitch-free iTunes?
by Keith Curtis 05 Jul '11

05 Jul '11

Hi; Here is a rant about iTunes: http://www.pcworld.com/businesscenter/article/229398-2/day_3_dude_wheres_my… You guys are doing great, but I think it would be better if you were to work more in priority order. There are 200M devices, last I checked. I don't think iTunes has ever properly worked in WINE. It seems like Apple keep revising it and so the current WINE never works with the current iTunes. Can you make a goal of supporting iTunes with no glitches? I know many of you are volunteers, but it is globally efficient if the installation number plays into the priority of the bugs. Just this one app could be huge for Linux on the desktop. Warm regards, -Keith

9 12

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet 05 Jul '11

05 Jul '11

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + if ((!texture && old_texture_type != GL_NONE) || (texture && texture->target != old_texture_type)) > + { Actually, just thought of this now, but I'm not sure you can do this like that. The way you're using old_texture_type it's context state, not device state.

1 0

Re: [3/6] wined3d: Use dummy textures for all the texture targets when the texture is unset.
by Henri Verbeet 05 Jul '11

05 Jul '11

On 4 July 2011 22:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + TRACE("Dummy 2D texture %d given name %d.\n", i, device->dummyTextureName[i]); This is pretty minor, but those are unsigned.

1 0

Re: gdi32: Make GdiTransparentBlt clipping aware (try2)
by Alexandre Julliard 05 Jul '11

05 Jul '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -392,6 +394,15 @@ BOOL WINAPI GdiTransparentBlt( HDC hdcDest, int xDest, int yDest, int widthDest, > hdcWork = CreateCompatibleDC(hdcDest); > bmpWork = CreateCompatibleBitmap(hdcDest, widthDest, heightDest); > oldWork = SelectObject(hdcWork, bmpWork); > + use_clip_rect = GetClipBox(hdcDest, &clip_rect); > + if(use_clip_rect) { > + clip_rect.left -= xDest; > + clip_rect.top -= yDest; > + clip_rect.right -= xDest; > + clip_rect.bottom -= yDest; > + IntersectClipRect(hdcWork, clip_rect.left, clip_rect.top, clip_rect.right, clip_rect.bottom); > + } You need to handle logical coordinates mapping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/6] wined3d: Don't apply and invalidate the framebuffer when clearing the device's fb (try 2)
by Henri Verbeet 05 Jul '11

05 Jul '11

On 5 July 2011 10:27, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - /* TODO: This is not necessary if the framebuffer is the device's current framebuffer */ > - context_invalidate_state(context, STATE_FRAMEBUFFER, device->StateTable); But you do need to invalidate if it isn't.

1 0

Re: propkeydef.h: Fixed DEFINE_PROPERTYKEY define
by Alexandre Julliard 05 Jul '11

05 Jul '11

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -33,18 +33,16 @@ > #ifdef INITGUID > #ifdef __cplusplus > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - EXTERN_C const PROPERTYKEY name = \ > + EXTERN_C const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY; \ > - const PROPERTYKEY name = \ > + const PROPERTYKEY DECLSPEC_SELECTANY name = \ > { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } }, pid } > #endif > #else > #define DEFINE_PROPERTYKEY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8, pid) \ > - EXTERN_C const PROPERTYKEY name DECLSPEC_HIDDEN DECLSPEC_SELECTANY > + EXTERN_C const PROPERTYKEY name Do you really want to remove DECLSPEC_HIDDEN? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Misha Koshelev : d3dx9_36: Implement and add tests for D3DXFloat16To32Array .
by Michael Stefaniuc 05 Jul '11

05 Jul '11

Hello Misha, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: a6b40624dbc457ba7b0b4b307b1eb88617c67197 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6b40624dbc457ba7b0b4b307… > > Author: Misha Koshelev <misha680(a)gmail.com> > Date: Wed Jun 29 11:16:29 2011 -0400 > > d3dx9_36: Implement and add tests for D3DXFloat16To32Array. > > --- > > dlls/d3dx9_36/d3dx9_36.spec | 2 +- > dlls/d3dx9_36/math.c | 32 +++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 60 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 93 insertions(+), 1 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c > index 5ad1924..aa3f135 100644 > --- a/dlls/d3dx9_36/tests/math.c > +++ b/dlls/d3dx9_36/tests/math.c > @@ -2215,6 +2216,64 @@ static void test_D3DXVec_Array(void) ... > + { NAN, 0x7fff, 0x7fff, 131008.0f, 131008.0f }, > + { -NAN, 0xffff, 0xffff, -131008.0f, -131008.0f }, this breaks compilation on systems that don't have NAN. bye michael

1 0

Re: oleaut32: use the locale settings for digit group sizes
by Marvin 05 Jul '11

05 Jul '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12210 Your paranoid android. === WNT4WSSP6 (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === WVISTAADM (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W2K8SE (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789' === W7PRO (32 bit varformat) === varformat.c:427: Test failed: VT 3|0x0000 Format #,#: expected 0x00000000, '12,34,56,789', got 0x00000000, '123,456,789'

1 0

Re: [PATCH 01/10] user32/tests: Added client-side raw input function tests (try 12)
by André Hentschel 04 Jul '11

04 Jul '11

Am 04.07.2011 16:29, schrieb Vincas Miliūnas: > Changelog: Hi, even if you have 10 patches, maybe first try to get the tests in. Divide and Conquer! That's at least a bit less mess on wine-patches for now, and is easier for you and AJ i guess. -- Best Regards, André Hentschel

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel