- wine-devel - winehq.org

Re: kernel32: Implement CreateSymbolicLinkA/W by reusing a modified IoCreateSymbolicLink
by Vitaliy Margolen 10 May '11

10 May '11

On 05/09/2011 04:02 PM, André Hentschel wrote: > Also for http://bugs.winehq.org/show_bug.cgi?id=27108 I'm afraid that according to msdn kernel32's CreateSymbolicLink has absolutely nothing to do with ntdll's NtCreateSymbolicLinkObject. Other then similar name. The kernel32's creates file system symlinks (for files) and reparse points (for directories). Ntdll's NtCreateSymbolicLinkObject creates object manager's symlinks only. At leas in Wine they don't apply to file systems. Vitaliy.

1 0

Re: kernel32: Implement CreateSymbolicLinkA/W by reusing a modified IoCreateSymbolicLink
by Juan Lang 09 May '11

09 May '11

Hi André, + NtCreateSymbolicLinkObject( &handle, STANDARD_RIGHTS_REQUIRED | 0x1 /* SYMBOLIC_LINK_ALL_ACCESS */, + &attr, &targetstr ); + RtlFreeUnicodeString(&linkstr); + RtlFreeUnicodeString(&targetstr); + /* FIXME: store handle somewhere */ + return handle != INVALID_HANDLE_VALUE; Your fixme already indicates you need to do something different: you're introducing a handle leak. Since the caller has no access to it, what's its use? Simply close it. Also, rather than test the handle value, NtCreateSymbolicLinkObject already has a more direct way to return success: its return value. I'd suggest you use that instead. Finally, any reason you don't call CreateSymbolicLinkW from CreateSymbolicLinkA? This is the usual way we implement things, and avoids having to fix two places if one turns out to be incorrect. Thanks, --Juan

1 0

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel
by Marvin 09 May '11

09 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10820 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 5)
by Vitaliy Margolen 09 May '11

09 May '11

On 05/09/2011 07:42 AM, Charles Davis wrote: > Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. > Try 4: Fix unused variable warning. > Try 3: Add support for IDE drives. > Try 2: Don't depend on the SCSI generic driver on Linux. > - RtlCreateUnicodeStringFromAsciiz( &nameW, "FirstBusTimeScanInMs" ); > + static const WCHAR bus_scan_timeW[] = {'F','i','r','s','t','B','u','s','S','c','a','n','T','i','m','e','I','n','M','s',0}; These do not match. > > + if (devtype) > + { > + if (!(type = p_libhal_device_get_property_string( ctx, udi, "storage.drive_type",&error ))) > + *devtype = ~0; > + else if (!strcmp( type, "disk" ) || !strcmp( type, "floppy" )) > + *devtype = 0x00; > + else if (!strcmp( type, "tape" )) > + *devtype = 0x01; > + else if (!strcmp( type, "cdrom" )) > + *devtype = 0x05; > + else if (!strcmp( type, "raid" )) > + *devtype = 0x0C; > + else > + *devtype = ~0; > + } Please don't use magic numbers here. Also these numbers are wrong. From winbase.h: #define DRIVE_UNKNOWN 0 #define DRIVE_NO_ROOT_DIR 1 #define DRIVE_REMOVABLE 2 #define DRIVE_FIXED 3 #define DRIVE_REMOTE 4 /* Win32 additions */ #define DRIVE_CDROM 5 #define DRIVE_RAMDISK 6 Missing "DeviceName"="Cdrom0" for cdroms. Also names of devices do not match. This can potentially break some software: -"Identifier"="ATA Hitachi HDS72202JKAO" +"Identifier"="ATA Hitachi HDS72202" -"Identifier"="ATA WDC WD7500AAKS-030.0" +"Identifier"="ATA WDC WD7500AAKS-0" -"Identifier"="SAMSUNG DVDWBD SH-B083L SB01" +"Identifier"="SAMSUNG DVDWBD SH-B083L" Vitaliy.

2 1

Re: [PATCH try5] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 09 May '11

09 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > + FreeLibrary(WININET_hModule); > + return ERROR_SUCCESS; It can still crash here. > +static void delayed_collect_connections(void) > +{ > + static const WCHAR wininet_dllW[] = {'w','i','n','i','n','e','t','.','d','l','l',0}; > + > + if(collector_running) > + return; > + > + if(!LoadLibraryW(wininet_dllW)) > + return; You probably don't want that inside the lock. Also GetModuleHandleEx is probably better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH try5] wininet: Added support for persistent HTTP connections
by Marvin 09 May '11

09 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10813 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:972: Test failed: unexpected call ReportResult protocol.c:977: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2690: Test failed: Read failed: 00000001

2 1

Re: audio: remove extraneous parentheses around equality comparisons
by Paul Chitescu 09 May '11

09 May '11

If you're at it can you move the variable at the right side of the comparison? if (((mr->msg_tosave + 1) % mr->ring_buffer_size) == mr->msg_toget)

1 0

Re: [PATCH] msi: Fixed check_flag_combo macro (Coverity)
by Alexandre Julliard 09 May '11

09 May '11

Marcus Meissner <meissner(a)suse.de> writes: > The macro was always FALSE, as > x & y == ~y > is always FALSE. x& y == y was clearly intended. > CID 1448 It doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok action.c:5578: Test failed: Expected ERROR_SUCCESS, got 1627 action.c:5587: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5599: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5656: Test failed: key not created action.c:5660: Test failed: key not created action.c:5664: Test failed: key not created make: *** [action.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [2/2] urlmon: Honor E_ABORT for URLDownloadToFile status callbacks
by Alexandre Julliard 09 May '11

09 May '11

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > --- > dlls/urlmon/download.c | 27 +++++++++++++++-- > dlls/urlmon/tests/url.c | 74 ++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 94 insertions(+), 7 deletions(-) > From de69f682d1b11c3b23969ad02756162232ea9403 Mon Sep 17 00:00:00 2001 > From: Thomas Mullaly <tmullaly(a)codeweavers.com> > Date: Sun, 1 May 2011 00:30:17 -0400 > Subject: urlmon: Honor E_ABORT for URLDownloadToFile status callbacks It doesn't work here: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so job.c && touch job.ok job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 job.c:378: Test failed: Bad state: 4 etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 9/9] mmdevapi/tests: Add tests for volume control interfaces
by Alexandre Julliard 09 May '11

09 May '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/mmdevapi/tests/capture.c | 389 > ++++++++++++++++++++++++++++++++++++++ > dlls/mmdevapi/tests/render.c | 414 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 803 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -p mmdevapi_test.exe.so capture.c && touch capture.ok capture.c:648: Test failed: Activation failed with 80004005 wine: Unhandled page fault on read access to 0x00000000 at address 0x68677fb5 (thread 0033), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68677fb5). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68677fb5 ESP:0032fc30 EBP:0032fd38 EFLAGS:00010206( R- -- I - -P- ) EAX:00000000 EBX:6868915c ECX:0032fbe0 EDX:0032fce4 ESI:6868399a EDI:0032fcf8 Stack dump: 0x0032fc30: 00000000 686839a4 80004005 00000000 0x0032fc40: 0032fd14 00000000 00000000 00124b60 0x0032fc50: 0032fce4 7bc9ed90 0032fc78 7bc68211 0x0032fc60: 3d4ccccd 00000040 0032fca8 80004005 0x0032fc70: 9999999a 3fd99999 00000001 0032fce4 0x0032fc80: 3d4ccccd 00000017 00000000 7ffdf044 Backtrace: =>0 0x68677fb5 func_capture+0x8a5() [/home/julliard/wine/wine/dlls/mmdevapi/tests/capture.c:650] in mmdevapi_test (0x0032fd38) 1 0x6868287e run_test+0x14d(name="capture.c") [/home/julliard/wine/wine/dlls/mmdevapi/tests/../../../include/wine/test.h:556] in mmdevapi_test (0x0032fd88) 2 0x68683347 main+0x156(argc=0, argv=0x68677fb5) [/home/julliard/wine/wine/dlls/mmdevapi/tests/../../../include/wine/test.h:624] in mmdevapi_test (0x0032fe48) 3 0x6868351c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mmdevapi_test (0x0032fe90) 4 0x7b8596cc call_process_entry+0xb() in kernel32 (0x0032fea8) 5 0x7b85a2ff start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fee8) 6 0x7bc73808 call_thread_func+0xb() in ntdll (0x0032fef8) 7 0x7bc76f6e call_thread_entry_point+0x6d(entry=0x7b85a2a0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 8 0x7bc4c15e start_process+0x1d(kernel_start=0x7b85a2a0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 9 0x6802998d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x68677fb5 func_capture+0x8a5 [/home/julliard/wine/wine/dlls/mmdevapi/tests/capture.c:650] in mmdevapi_test: movl 0x0(%eax),%ecx 650 hr = IAudioClient_Initialize(ac2, AUDCLNT_SHAREMODE_SHARED, -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Assorted spelling and case fixes.
by Marvin 09 May '11

09 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10800 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: winspool.drv: Add stubs for IsValidDevmodeW and IsValidDevmodeA.
by Marvin 09 May '11

09 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10796 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: ddraw: Add tests for SetCooperativeLevel
by Marvin 09 May '11

09 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10792 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [4/5] d3dx9: Implement D3DXMESHOPT_ATTRSORT vertex reordering.
by Matteo Bruni 08 May '11

08 May '11

2011/5/6 Dylan Smith <dylan.ah.smith(a)gmail.com>: > +struct vertex_attrib_duplication { > + DWORD attrib; > + DWORD vertex_index; > + struct vertex_attrib_duplication *ptr; > +}; ... > + struct vertex_attrib_duplication **heads = NULL; /* head of list for each vertex */ You probably want to use Wine lists (from include/wine/list.h) instead of your own implementation. > + heads = HeapAlloc(GetProcessHeap(), 0, This->numvertices * sizeof(*heads) + max_entries * sizeof(*duplications)); > + duplications = (struct vertex_attrib_duplication *)(heads + This->numvertices); I'm not sure why you are usually sticking together many arrays in a single allocation. Economizing on the number of HeapAllocs is not a great reason IMHO.

2 2

Re: [2/5] d3dx9: Implement D3DXMESHOPT_COMPACT for ID3DXMesh::OptimizeInplace.
by Matteo Bruni 08 May '11

08 May '11

2011/5/6 Dylan Smith <dylan.ah.smith(a)gmail.com>: ... > + new_vertex_buffer_size = This->numvertices; ... > + new_vertex_buffer_size *= vertex_size; > + hr = IDirect3DDevice9_CreateVertexBuffer(This->device, new_vertex_buffer_size, > + vertex_desc.Usage, This->fvf, vertex_desc.Pool, &vertex_buffer, NULL); ... + for (i = 0; i < new_num_vertices; i++) + CopyMemory(new_vertices + i * vertex_size, orig_vertices + vertex_remap_ptr[i] * vertex_size, vertex_size); Is this correct, i.e. should the new vertex buffer be big as much as the old one? I expected it to be just big enough to keep all the remaining vertices (new_num_vertices). Maybe this is so to match some native behavior?

2 1

Re: [1/5] d3dx9: Implement ID3DXMesh::CloneMesh without vertex buffer conversion.
by Matteo Bruni 08 May '11

08 May '11

2011/5/6 Dylan Smith <dylan.ah.smith(a)gmail.com>: > --- Just a couple of nitpicks: > + This->vertex_buffer->lpVtbl->AddRef(This->vertex_buffer); You should probably use the macros where they are around (D3D9 objects have them, as opposed to the mesh objects which don't for some strange reason). > + CopyMemory(data_out, data_in, This->numvertices * vertex_size); It's usually preferred to use memcpy(). I see that there are already a couple of uses of CopyMemory, in your previous patches, I didn't notice them...

1 0

Re: tools: Upgrade the config.guess/config.sub scripts
by Austin English 08 May '11

08 May '11

2011/5/7 André Hentschel <nerv(a)dawncrow.de>: > from git://git.sv.gnu.org/config.git without the whitespace changes > --- > tools/config.guess | 17 ++++++++++------- > tools/config.sub | 49 +++++++++++++++++++++++++++++++++++-------------- > 2 files changed, 45 insertions(+), 21 deletions(-) > > diff --git a/tools/config.guess b/tools/config.guess > index 4c8f032..1f28e79 100755 > --- a/tools/config.guess > +++ b/tools/config.guess > @@ -92,7 +92,7 @@ if test $# != 0; then > exit 1 > fi > > -trap 'exit 1' HUP INT TERM > +trap 'exit 1' 1 2 15 > > # CC_FOR_BUILD -- compiler used by this script. Note that the use of a > # compiler to aid in system detection is discouraged as it requires > @@ -106,7 +106,7 @@ trap 'exit 1' HUP INT TERM > > set_cc_for_build=' > trap "exitcode=\$?; (rm -f \$tmpfiles 2>/dev/null; rmdir \$tmp 2>/dev/null) && exit \$exitcode" 0 ; > -trap "rm -f \$tmpfiles 2>/dev/null; rmdir \$tmp 2>/dev/null; exit 1" HUP INT PIPE TERM ; > +trap "rm -f \$tmpfiles 2>/dev/null; rmdir \$tmp 2>/dev/null; exit 1" 1 2 13 15 ; > : ${TMPDIR=/tmp} ; > { tmp=`(umask 077 && mktemp -d "$TMPDIR/cgXXXXXX") 2>/dev/null` && test -n "$tmp" && test -d "$tmp" ; } || > { test -n "$RANDOM" && tmp=$TMPDIR/cg$$-$RANDOM && (umask 077 && mkdir $tmp) ; } || Looks like http://bugs.winehq.org/show_bug.cgi?id=16622 has re-emerged: http://git.savannah.gnu.org/gitweb/?p=config.git;a=commitdiff;h=2ec80f0dba7… -- -Austin

1 0

Re: riched20:tests Add conformance test for EM_FINDWORDBREAK function.
by André Hentschel 08 May '11

08 May '11

Am 08.05.2011 05:14, schrieb James McKenzie: > > + if (winetest_debug > 1) { > test_WM_CHAR(); > test_EM_FINDTEXT(); > test_EM_GETLINE(); > @@ -7090,6 +7368,8 @@ START_TEST( editor ) > test_WM_GETDLGCODE(); > test_zoom(); > test_dialogmode(); > + } > + test_EM_FINDWORDBREAK(); > Hi, i guess you didn't meant to include that in your patch. -- Best Regards, André Hentschel

2 1

Re: ntdll: Make RtlReAllocateHeap() preserve V-bit information when run under Valgrind
by Marcus Meissner 08 May '11

08 May '11

On Sat, May 07, 2011 at 06:33:08PM +0200, Bart Van Assche wrote: > Hello, > > A patch I submitted about five weeks ago had the status "Pending" on the patch status page during about four weeks. I can't see this patch anymore on the patch status page today. Anyone who can tell me what happened or which steps I should take next ? > > The patch itself can be found here: http://www.winehq.org/pipermail/wine-patches/2011-April/100570.html If you got no reply or indication on a patch within a week, you can consider it lost ;) To do then: - Ask yourself if the patch is good (tm) - Ask by e-mail or in IRC (#winehackers) on what could be improved with it. >From a brief look ... I think your patch seems to be doing more than one thing at once. Please seperate multiple changes into multiple small patches. Ciao, Marcus

1 0

RFC: doc for message contexts additions in PO files
by Frédéric Delanoy 08 May '11

08 May '11

Hi guys, I've put together the following doc for the introduction of message contexts. It's still a bit raw but I'd improve it for the wiki version. Could you please have a look and help proofread it? I'd like to ensure I didn't miss an important step. Thanks in advance. Frédéric Delanoy PS: BTW what is the reference version? en_US.po or en.po? ********* Adding one/more message contexts (ADD LINK TO EXTERNAL DOC) (QUICK MC EXPLANATION) Prerequisite: enable maintainer mode using ./configure --enable-maintainer-mode (you might have to add some development packages; check with your distribution for infos). 1. Locate strings to be "altered" Say you have in your localized po file: #: file1.rc:123 file2.rc:456 msgid "ambiguous word" msgstr "translation" and you want to disambiguate, you'd do the following 2. Find appropriate translations - check the respective rc entries (in file1.rc line 123) FOO "ambiguous word" (in file2.rc line 456) BAR "ambiguous word" and find their meaning/context (e.g. using some code browsing tools, like cscope to find references; running the program is recommanded, ...) 3. Add the messages contexts - The following syntax is used: "translation" -> "#msgctxt#your context#translation" - You end up with sthg like FOO "#msgctxt#context #ambiguous word#" Similarly BAR "#msgctxt#context 2#ambiguous word#" 3. Run 'make depend && make' 4. Edit your po file to add the new translations 5. Ideally, remove the "#, fuzzy" automatically inserted in the En_US.po reference file (and En.rc ). 6. Run 'make' again and test your changes.

2 1

Re: gdi32: Remove a set but unused variable
by Gerald Pfeifer 07 May '11

07 May '11

I admit I am surprised that Commit: 46988651d91fbea7f611287e5d8320239e72108d URL: http://source.winehq.org/git/wine.git/?a=commit;h=46988651d91fbea7f611287e5… Author: Nicolas Le Cam <niko.lecam at gmail.com> Date: Fri Apr 29 23:57:09 2011 +0200 gdi32: Remove a set but unused variable. has been applied, for I had proposed this very patch a year ago when Alexandre had rejected it with It seems pretty clear that it should be used, not removed. [ http://www.winehq.org/pipermail/wine-devel/2010-May/083517.html ] I tried to take that into account by updating the patch accordingly http://www.winehq.org/pipermail/wine-patches/2010-May/088317.html which, unexplicably to me, broke the tests so it was not applied: http://www.winehq.org/pipermail/wine-devel/2010-May/083850.html Now my original patch was re-submitted by Nicolas and applied. Was Alexandre's analysis incorrect in the original case, did he just fail to catch the mistake this time around, or is it something else? Gerald

1 0

Re: Jerome Leclanche : wine.desktop: Remove the nonexistent application/ x-win-lnk MIME type.
by Francois Gouget 07 May '11

07 May '11

On Thu, 5 May 2011, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: db03d247158ee44c06935b5e23fbf37485d8c8bf > URL: http://source.winehq.org/git/wine.git/?a=commit;h=db03d247158ee44c06935b5e2… > > Author: Jerome Leclanche <adys.wh(a)gmail.com> > Date: Wed May 4 19:01:33 2011 +0100 > > wine.desktop: Remove the nonexistent application/x-win-lnk MIME type. I'm not sure this patch is correct: on my Debian Testing machine application/x-win-lnk is defined in /usr/share/mime/packages/kde.xml which comes from the kdelibs5-data. I also found a reference to this package in the kdebase-runtime Fedora 11 runtime. So this MIME type may not be standard (heck it has the 'x-' prefix anyway) but KDE seems to know / be using it. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

4 4

Huge frustration
by Roland Kaeser 07 May '11

07 May '11

Hello Please take the following not personal but the huge pent-up frustration constrains me to say a few words. I've just tested one of my "longest waiting" apps to get working on linux: CorelDraw X3/X4. And I had to see that it fails already with the same errors. I tooke a short look into the bug database to see all the related bugs: http://bugs.winehq.org/show_bug.cgi?id=11687 open (not even confirmed) since more than 3 years http://bugs.winehq.org/show_bug.cgi?id=14123 open since 2008-06-25 http://bugs.winehq.org/show_bug.cgi?id=3599 open (new) since 2005-10-15 http://bugs.winehq.org/show_bug.cgi?id=3611 open (new) since 2005-10-17 I know we had this discussion already a lot of times but after six acc. three years its time for me to say something again. I know also thats a lot more fun developing directx routines instead of fixing old bugs but sometimes You should also think about the "other" generality which uses the computer not just to play games. It would be understandeable to me if its written in the bug that the fix of this bug will consume a lot of resources and its impossible to fix this, but just to ignore it is not "the proper way to behave". I'm sure that there are many more of the above bugs which nobody has has ever took seriously a lock at it. Has anybody ever imagined how many apps depending on such bugs which prevents them to get running on Linux? Maybe all of the above bugs are only related to CorelDraw but its also possible that dozens or hundrets of other apps also fail with the same problems but nobody has ever wrote a bug report or saw it in the bug database and thought that it will be fixed cause its already reported? Just take a look at: http://www.inside-it.ch/frontend/insideit?_d=_article&site=ic&news.id=22515 English version: http://arstechnica.com/civis/viewtopic.php?f=14&t=1122655 The most of their problems where related to special windows apps running only in goverment institutions and where not able to run on Linux (wine). How many of these problems whould not even ever have been occured if such small bugs like the above whoud be fixed which makes all of those apps runnable on linux. Sorry to say that but Your politics just to develop things which makes fun or are interesting is also part of the above problem. Regards Roland

5 4

Re: [1/2] mmsystem.dll16: fix MCI_STATUS mapping for digitalvideo
by Damjan Jovanovic 06 May '11

06 May '11

On Thu, May 5, 2011 at 9:23 PM, Eric Pouech <eric.pouech(a)orange.fr> wrote: > Le 05/05/2011 15:30, Damjan Jovanovic a écrit : > > Changelog: > * mmsystem.dll16: fix MCI_STATUS mapping for digitalvideo > > Damjan Jovanovic > > > Hi Damjan, > > I wonder if storing the device type (or at least information to select the > two types of mapping) in the allocated structure for mapping instead of > calling for the device type at each unmap operation wouldn't be a preferable > solution > A+ > > -- > Eric Pouech Hi Eric It might be even more preferable to store the device type in a local variable. The allocated structure is way too complex already. Damjan Jovanovic

1 0

Re: [PATCH try4] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 06 May '11

06 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > + /* FIXME: do the check also for SSL connections */ > + if(!netconn->useSSL) { > + res = NETCON_recv(netconn, &b, 1, MSG_PEEK|MSG_DONTWAIT, &len); > + if((res == ERROR_SUCCESS && len == 1) || res == WSAEWOULDBLOCK) > + break; This doesn't build with winsock (MSG_DONTWAIT is not defined). I'm also not sure what is the purpose of that check. If it's to check if remote has closed the connection, you need to do that by handling the error on the first send. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH try4] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 06 May '11

06 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > try4: Check idle connection before using it in an attempt to catch > closed connection sooner, avoiding some request resends. It hopefully > fixes observed problem with tests. It does, but there's a new problem: it sometimes crashes in the collect_connections thread during the winhttp tests, because wininet has been unloaded while the thread is still running. Probably the thread needs to grab a library reference, though a collection mechanism that doesn't require a separate thread would be even better. I can still put the patch in for now, since the failure is not very frequent. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH try4] wininet: Added support for persistent HTTP connections
by Marvin 06 May '11

06 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10757 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:972: Test failed: unexpected call ReportResult protocol.c:977: Test failed: hrResult = 00000000, expected: 80004004 protocol.c:2690: Test failed: Read failed: 00000001

2 1

Re: po: Update French translation
by Nicolas Le Cam 06 May '11

06 May '11

> #: regedit.rc:88 > -#, fuzzy > msgid "Modify Binary Data..." > -msgstr "Modifier les données &binaires" > +msgstr "Modifier les données &binaires..." I'm not sure you can add a keyboard accelerator if there isn't one in the original message. -- Nicolas Le Cam

2 3

winscard/tests: Add test base functions of winscard.dll
by Joerg-Cyril.Hoehle＠t-systems.com 06 May '11

06 May '11

Sergey, >+ * Unit test suite for AVI Functions >+ * Copyright 2008 Detlef Riekenberg +#include "wingdi.h" >+#include "vfw.h" Please try and hide better the copy&paste origin of the code :-) >rezult result + ok(winscard_rezult != SCARD_F_INTERNAL_ERROR I recommend tests to be stricter, e.g. ok(result == SCARD_S_SUCCESS || result == SCARD_E_XYZ || broken(result == SCARD_E_...) Here's work done last year by Yauheni Baltouski and Aliaksei Hud. They are not working on winscard any more. I'd be pleased to eventually see winscard tests in Wine. Maybe you could merge this work? I *hope* I attached the latest version of the patch. If yes, it was verified last year to pass on: - native machines with and without card readers; - testbot, incl. w9x machines; - 64 bit? can't remember; - stock Linux (Ubuntu Lucid); - Linux with Mounir Idrassi's winscard dll (in which case the todo_wine succeed) and a card reader. It contains a good mixture of win_skip(), broken() and todo_wine to that effect. I had not submitted these tests in the past because IIRC there's still a resource leak (FreeLibrary following LoadLibrary; SCardFreeMemory following SCardListReaders AUTOALLOCATE) and some style issues (casts inside ok("%ld") formats) as well as IMHO too many redundant trace("testing X\n"), see $WINETEST_REPORT_SUCCESS. In their patch, LoadLibrary was necessary instead of a statically linked .exe because not all native systems provide winscard.dll Nowadays, successful tests on w9x are not considered important anymore, so this might be superfluous (but I don't know whether one can expect winscard on all machines since NT). +#ifndef SCARD_AUTOALLOCATE +#define SCARD_AUTOALLOCATE (DWORD)(-1) +#ifndef SCARD_SCOPE_USER +#define SCARD_SCOPE_USER 0x0000 was necessary because Wine's winscard.h does not yet provide enough definitions. -- Completing winscard.h would be a useful patch on its own. This test was considered the first of a series: small enough yet still doing something useful (ListReaders), but not yet depending on the presence of a chip card. Final comments on your initial patch: + mszReaders = malloc(cchReaders); HeapAlloc() is recommended in Wine, i.e. programming against the MS API. +START_TEST(winscard_api) Just name it winscard. Keep the name short because you use it on the command line. You don't initialize SCARD_READERSTATE as MSDN requires it for SCardGetStatusChange: "Important Each member of each structure in this array must be initialized to zero" and you don't check whether SCardListReaders returned at least one string in mszReaders for you to feed into SCardGetStatusChange. Regards, Jörg Höhle >From 3a936d8e0c100aee0da324d4d32e92368eefde88 Mon Sep 17 00:00:00 2001 From: Yauheni Baltouski <ybaltouski(a)gmail.com> Date: Tue, 29 Jun 2010 11:25:24 +0300 Subject: winscard/test: add initial test cases --- configure.ac | 1 + dlls/winscard/tests/Makefile.in | 11 +++ dlls/winscard/tests/scard.c | 180 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 192 insertions(+), 0 deletions(-) create mode 100644 dlls/winscard/tests/Makefile.in create mode 100644 dlls/winscard/tests/scard.c diff --git a/configure.ac b/configure.ac index 61f376e..0309abc 100644 --- a/configure.ac +++ b/configure.ac @@ -2661,6 +2661,7 @@ WINE_CONFIG_TEST(dlls/winmm/tests) WINE_CONFIG_DLL(winnls.dll16,enable_win16) WINE_CONFIG_DLL(winnls32,,[winnls32]) WINE_CONFIG_DLL(winscard,,[winscard]) +WINE_CONFIG_TEST(dlls/winscard/tests) WINE_CONFIG_DLL(winsock.dll16,enable_win16) WINE_CONFIG_DLL(winspool.drv,,[winspool]) WINE_CONFIG_TEST(dlls/winspool.drv/tests) diff --git a/dlls/winscard/tests/Makefile.in b/dlls/winscard/tests/Makefile.in new file mode 100644 index 0000000..879481b --- /dev/null +++ b/dlls/winscard/tests/Makefile.in @@ -0,0 +1,11 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +TESTDLL = winscard.dll +IMPORTS = kernel32 ntdll + +C_SRCS = \ + scard.c + +@MAKE_TEST_RULES@ diff --git a/dlls/winscard/tests/scard.c b/dlls/winscard/tests/scard.c new file mode 100644 index 0000000..fd751c8 --- /dev/null +++ b/dlls/winscard/tests/scard.c @@ -0,0 +1,180 @@ +/* + * Unit tests for winscard.dll functions + * + * Copyright 2010 Yauheni S Baltouski + * + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> +#include <stdio.h> + +#include "windef.h" +#include "winbase.h" +#include "winerror.h" +#include "winver.h" + +#include <winscard.h> +#include "wine/test.h" + +#ifndef SCARD_AUTOALLOCATE +#define SCARD_AUTOALLOCATE (DWORD)(-1) +#endif + +#ifndef SCARD_SCOPE_USER +#define SCARD_SCOPE_USER 0x0000 +#endif + +static const CHAR winscardDll[] = "winscard.dll"; + +static LONG (WINAPI *pSCardEstablishContext)(DWORD ,LPCVOID, LPCVOID, LPSCARDCONTEXT); +static LONG (WINAPI *pSCardReleaseContext)(SCARDCONTEXT); +static LONG (WINAPI *pSCardListReadersA)(SCARDCONTEXT,LPCSTR,LPSTR,LPDWORD); +static LONG (WINAPI *pSCardListReadersW)(SCARDCONTEXT,LPCSTR,LPSTR,LPDWORD); + +static SCARDCONTEXT hSC; +static LPTSTR szReaders; +static DWORD cchReaders = SCARD_AUTOALLOCATE; + +static void test_SCardEstablishContext(void) { + LONG lReturn; + + trace("testing SCardEstablishContext\n"); + + lReturn = pSCardEstablishContext(SCARD_SCOPE_USER, + NULL, + NULL, + &hSC); + todo_wine + { + ok((SCARD_S_SUCCESS==lReturn || broken(SCARD_E_NO_SERVICE==lReturn /*service disabled */)), + "can't execute SCardEstablishContext, SCardEstablishContext ptr = %p, return = %ld\n", + pSCardEstablishContext, + (long)lReturn); + } +} + +static void test_SCardReleaseContext(void) { + LONG lReturn; + + trace("testing SCardReleaseContext\n"); + if (hSC) { + + lReturn = pSCardReleaseContext(hSC); } + + todo_wine + { + ok(SCARD_S_SUCCESS==lReturn && hSC, + "can't execute SCardReleaseContext, SCardReleaseContext ptr = %p, SCARDCONTEXT=%lx, return=%ld\n", + pSCardReleaseContext, + (long int)hSC, + (long)lReturn); + } +} + +static void test_SCardListReadersA(void) { + LONG lReturn; + + trace("testing SCardListReadersA\n"); + if (hSC) { + + lReturn = pSCardListReadersA(hSC, + NULL, + (LPTSTR)&szReaders, + &cchReaders); } + + todo_wine + { + ok((lReturn == SCARD_S_SUCCESS || lReturn == SCARD_E_NO_READERS_AVAILABLE) && hSC, + "can't execute SCardListReadersA, SCardListReadersA ptr = %p, SCARDCONTEXT=%lx, return=%ld\n", + pSCardListReadersA, + (long int)hSC, + (long)lReturn); + } +} + +static void test_SCardListReadersW(void) { + LONG lReturn; + + trace("testing SCardListReadersW\n"); + if (hSC) { + + lReturn = pSCardListReadersW(hSC, + NULL, + (LPTSTR)&szReaders, + &cchReaders);} + + todo_wine + { + ok((lReturn == SCARD_S_SUCCESS || lReturn == SCARD_E_NO_READERS_AVAILABLE) && hSC, + "can't execute SCardListReadersW, SCardListReadersW ptr = %p, SCARDCONTEXT=%lx, return=%ld\n", + pSCardListReadersW, + (long int)hSC, + (long)lReturn); + } +} + +static BOOL init_winscard(void){ +#define GET_PROC(func) \ + (p ## func = (void *)GetProcAddress(module, #func)) + HMODULE module=NULL; + trace("testing winscard initialization\n"); + module = LoadLibraryA(winscardDll); + if (!module) + { + win_skip("No winscard.dll found - aborting"); + return FALSE; + } + else { + + trace("loading winscard SCardEstablishContext\n"); + GET_PROC(SCardEstablishContext); + todo_wine ok(pSCardEstablishContext!=NULL, "can't initialize winscard SCardEstablishContext, error=%lx\n", (long int)GetLastError()); + if (pSCardEstablishContext==NULL) return FALSE; + + trace("loading winscard SCardReleaseContext\n"); + GET_PROC(SCardReleaseContext); + todo_wine ok(pSCardReleaseContext!=NULL, "can't initialize winscard SCardReleaseContext, error=%lx\n", (long int)GetLastError()); + if (pSCardReleaseContext==NULL) return FALSE; + + trace("loading winscard SCardListReadersA\n"); + GET_PROC(SCardListReadersA); + todo_wine ok(pSCardListReadersA!=NULL, "can't initialize winscard SCardListReadersA, error=%lx\n", (long int)GetLastError()); + if (pSCardListReadersA==NULL) return FALSE; + + trace("loading winscard SCardListReadersW\n"); + GET_PROC(SCardListReadersW); + todo_wine ok(pSCardListReadersW!=NULL, "can't initialize winscard SCardListReadersW, error=%lx\n", (long int)GetLastError()); + if (pSCardListReadersW==NULL) return FALSE; + + return TRUE; + } +#undef GET_PROC +} + + +START_TEST(scard) +{ + if (init_winscard()) { + test_SCardEstablishContext(); + if (hSC) + { + test_SCardListReadersW(); + test_SCardListReadersA(); + test_SCardReleaseContext();/*must be at end of tests*/ + } + } +} -- 1.7.0.4

1 0

avicap32: fix build with recent kernel headers
by Rafał Mużyło 06 May '11

06 May '11

Attached patch seems to fix build problem with recent kernel headers, where v4l1 was removed. I'm sending it here first (instead straight to wine-patches), as I have no real way of testing it - I only know it builds. As such, I haven't bothered yet with keeping consistant folding style. In case of any questions, CC me. PS.: qcap *might* need a similar, though far more complex fix.

2 1

Re: winscard/tests: Implement test for two functions of winscard.dll
by Marvin 06 May '11

06 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10750 Your paranoid android. === WXPPROSP3 (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W2K3R2SESP2 (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === WVISTAADM (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W2K8SE (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W7PRO (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6

1 0

Re: winscard/tests: Implement test for two functions of winscard.dll
by Marvin 06 May '11

06 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10749 Your paranoid android. === WXPPROSP3 (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W2K3R2SESP2 (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === WVISTAADM (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W2K8SE (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6 === W7PRO (32 bit winscard_api) === winscard_api.c:37: Test failed: Can't connect to pcscd daemon 8010001d winscard_api.c:39: Test failed: Error call SCardIsValidContext 6

1 0

Strange zero operation in dlls/riched20/tests/editor.c (Coverity)
by Marcus Meissner 05 May '11

05 May '11

Hi Dylan, folks, Coverity sees following constructs in dlls/riched20/tests/editor.c introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da + SendMessage(hwndRichEdit, WM_CHAR, 22, + (MapVirtualKey('V', MAPVK_VK_TO_VSC) << 16) & 1); (several more of similar) The 4th argument is always 0 (because of (x<<16)&1). You added that Dylan, was perhaps |1 intended for a repeat count of 1? Ciao, Marcus

2 1

Re: [3/3] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load(). (try 2)
by Nikolay Sivov 05 May '11

05 May '11

On 5/5/2011 00:38, Adam Martinson wrote: > > Fixes bugs 14864 + 16453. > --- > dlls/msxml3/domdoc.c | 27 +++++++++++++ > dlls/msxml3/tests/domdoc.c | 94 > +++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 120 insertions(+), 1 deletions(-) > + case VT_ARRAY|VT_UI1: > + { > + SAFEARRAY *psa = V_ARRAY(&source); > + xmlChar *str; > + LONG len; > + UINT dim = SafeArrayGetDim(psa); > + > + switch (dim) > + { > + case 0: > + ERR("SAFEARRAY == NULL\n"); > + hr = E_INVALIDARG; > + break; > + case 1: > + /* Only takes UTF8 strings. > + * NOT NULL-terminated. */ > + SafeArrayAccessData(psa, (void**)&str); > + SafeArrayGetUBound(psa, 1,&len); > + hr = load_utf8(This, str, ++len, isSuccessful); > + SafeArrayUnaccessData(psa); > + break; > + default: > + FIXME("unhandled SAFEARRAY dim: %d\n", dim); > + hr = E_NOTIMPL; > + } > + } This could be simplified. SafeArrayGetUBound will fail for case 0 for example, and unhandled dimension should be WARN, IMO.

2 3

Re: [2/3] msxml3/domdoc: Add an internal function to load from a UTF8 string.
by Nikolay Sivov 05 May '11

05 May '11

On 5/5/2011 00:38, Adam Martinson wrote: > --- > dlls/msxml3/domdoc.c | 85 > +++++++++++++++++++++++++++++-------------------- > 1 files changed, 50 insertions(+), 35 deletions(-) You don't need a separate helper for that. doparse() should do fine with "UTF-8" encoding parameter to force encoding. Also will it preserve existing document or will really create empty one on error is a question.

2 3

Re: cmd: WCMD_delete: simplify logic, avoid assigning variable to i tself (try 2)
by Alexandre Julliard 05 May '11

05 May '11

Dan Kegel <dank(a)kegel.com> writes: > Simpler version suggested by Henri. > I'm hoping this is enough of an improvement to be worth it. It would be better to build a simple mask and test against that, instead of all that silliness with booleans. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 4)
by Alexandre Julliard 05 May '11

05 May '11

Charles Davis <cdavis(a)mymail.mines.edu> writes: > + case 0x05: > + data = "CdRomPeripheral"; > + snprintf(buffer, sizeof(buffer), "Cdrom%d", cdrom_no++); > + break; This needs to be set to the device name that mountmgr has assigned to it. That's the point of doing this in mountmgr: making sure that all the information derives from a single source. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH try3] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 05 May '11

05 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > try3: I've included better content draining in this patch (that I was > hoping to do as follow-up previously, due to already big size of the > patch). That fixes observed test failures. Older wininet implementations > don't have it, so the test fails for them. I'm getting a different failure now: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:1074: Test failed: Read 0 bytes instead of 13 make: *** [http.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load().
by Nikolay Sivov 04 May '11

04 May '11

On 5/3/2011 08:07, Adam Martinson wrote: > > Fixes bug 14864. > --- > dlls/msxml3/domdoc.c | 255 > ++++++++++++++++++++++++++------------------------ > 1 files changed, 134 insertions(+), 121 deletions(-) > > + case VT_ARRAY|VT_UI1: > + { > + SAFEARRAY* psa; > + BSTR bstr; > + psa = V_ARRAY(&source); > + bstr = bstr_from_xmlChar(psa->pvData); > + hr = domdoc_loadXML(iface, bstr, isSuccessful); > + SysFreeString(bstr); > + return hr; > + } > + break; Is it really supposed to be utf8 array? Or this will work cause one-byte chars match utf8? Also I don't like this method dependency, I think the proper way is to call IXMLDOMDocument3_loadXML(iface...) here. Or another way to avoid call through vtable - introduce something called domdoc_load_xml(This...) and use it in both places, but I think it's not worth it.

2 5

Re: [PATCH 2/2 try2] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 04 May '11

04 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > try2: Using GetTickCount64() for timestamps > > --- > dlls/urlmon/tests/protocol.c | 2 +- > dlls/urlmon/tests/url.c | 20 +- > dlls/wininet/http.c | 567 > ++++++++++++++++++++++++------------------ > dlls/wininet/internet.c | 2 +- > dlls/wininet/internet.h | 42 +++- > dlls/wininet/netconnection.c | 138 ++++------- > dlls/wininet/tests/http.c | 32 +-- > 7 files changed, 427 insertions(+), 376 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:2621: Test failed: expected 1 retrievals, got 0 http.c:2628: Test failed: count was wrong http.c:2629: Test failed: http data wrong http.c:2649: Test succeeded inside todo block: expected 1 retrievals make: *** [http.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: winscard/tests: Add test base functions of winscard.dll
by Marvin 04 May '11

04 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10722 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

FAQ translation possible?
by Frédéric Delanoy 04 May '11

04 May '11

Hi, I'm currently revising/translating WineHQ's website French translation. Translating the help, I remarked the FAQ is maintained in the wiki section. Wouldn't it make sense to move the FAQ to the wine website repository so as to ease translation? FAQ is probably one of the most important things to translate IMO. Is the wiki page somehow translatable (preferably using WineHQ's language cookie setting)? Or is it more important to remain it to the wiki for quick update/review? Frédéric Delanoy

3 5

signal(SIGCHLD,SIG_DFL) before exec()
by Ilya Basin 04 May '11

04 May '11

Hi list. I suffer from this bug: http://bugs.winehq.org/show_bug.cgi?id=27014 In wine sources there're not so many places where exec(3) family is used. In some places SIGCHLD and SIGPIPE are restored to default before calling exec(), in others they aren't. What's the difference? Can anyone explain me the why SIGCHLD not restored to default before calling execvp() here: http://source.winehq.org/source/libs/port/spawn.c?v=wine-1.3.19#L42 int spawnvp(int mode, const char *cmdname, const char *const argv[]) { ... if (mode == _P_OVERLAY) { execvp(cmdname, (char **)argv); /* if we get here it failed */ #ifdef ENOTSUP if (errno != ENOTSUP) /* exec fails on MacOS if the process has multiple threads */ #endif return -1; } Because it's not forked and if execvp() fails, we end up with the default handler?

1 0

Re: [PATCH 2/2] wininet: Added support for persistent HTTP connections
by Alexandre Julliard 03 May '11

03 May '11

Jacek Caban <jacek(a)codeweavers.com> writes: > +static DWORD64 collector_timeout; > + > +static DWORD64 current_time(void) > +{ > + ULARGE_INTEGER timeout; > + SYSTEMTIME st; > + FILETIME ft; > + > + GetSystemTime(&st); > + SystemTimeToFileTime(&st, &ft); > + > + timeout.u.LowPart = ft.dwLowDateTime; > + timeout.u.HighPart = ft.dwHighDateTime; > + > + return timeout.QuadPart; > +} That's a lot of complexity for a timestamp, GetTickCount() would work just as well, as long as you do the comparisons correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] d3d8/tests: Fix some failure messages in test_depth_stencil_size().
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10709 Your paranoid android. === WXPPROSP3 (32 bit device) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\d3d8_test.exe, error 32

2 1

Re: [PATCH 4/5] d3d8/tests: Add a Reset test.
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10710 Your paranoid android. === WXPPROSP3 (32 bit device) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\d3d8_test.exe, error 32

1 0

msvcrt: Add tests to show that utime() can take a NULL-pointer for the utimbuf structure field
by Joerg-Cyril.Hoehle＠t-systems.com 03 May '11

03 May '11

Louis, >Anything i could do to improve to get it in? Perhaps http://source.winehq.org/patches/ shows that you should get rid of the one apply failure. Basically, your patch does the right thing, as MSDN says "If times is a NULL pointer, the modification time is set to the current local time." -- like POSIX. >-#if(0) /* FIXME: this test crashes wine, remove this line when wine is fixed */ People here prefer if(0) so that the compiler can still validate the form of the code. I've been even been using if (winetest_debug>1) so I can direct testbot to run the additional test. Finally, why not merge the two? After all, it's one change, and several tests. Why do you call it test_utime() since you don't verify the effects of utime()? Regards, Jörg Höhle

1 0

Re: [PATCH 2/4] wintrust: Added CryptSIPPutSignedDataMsg implementation (for PE files)
by Piotr Caban 03 May '11

03 May '11

On 05/03/11 13:07, Piotr Caban wrote: > --- > dlls/wintrust/crypt.c | 66 ++++++++++++++++++++++++++++++++++++++++++------ > 1 files changed, 57 insertions(+), 9 deletions(-) Patches 2 and 3 in this series are not correct. Please ignore them.

1 0

Re: [PATCH 3/4] d3dx9: Implement ID3DXBaseEffect::GetPixelShader().
by Henri Verbeet 03 May '11

03 May '11

2011/5/3 Rico Schüller <kgbricola(a)web.de>: > +#define SAFE_ADDREF(x) if(x) IUnknown_AddRef(x) > +#define SAFE_RELEASE(x) if(x) IUnknown_Release(x) That's not so safe, actually. Consider e.g. what happens when "x" has side effects, or when you write something like "if (cond) SAFE_ADDREF(x); else return;". If you really want this an inline function should do just as well, but for the handful of uses I see in this series it just obfuscates the code.

1 0

msvcrt: Add tests to show that utime() can take a NULL-pointer for the utimbuf structure field
by Louis Lenders 03 May '11

03 May '11

See http://www.winehq.org/pipermail/wine-patches/2011-April/101371.html Anything i could do to improve to get it in?

1 0

Re: ddraw (try 2): Add a few tests for Setcooperativelevel
by Marvin 03 May '11

03 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10695 Your paranoid android. === WNT4WSSP6 (32 bit ddrawmodes) === ddrawmodes.c:800: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 ddrawmodes.c:803: Test failed: SetCooperativelevel(DDSCL_CREATEDEVICEWINDOW | DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN) returned: 80070057 ddrawmodes.c:828: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/2] d3d9/tests: Added a test for resetting an invisible, inactive window to fullscreen mode.
by Marvin 02 May '11

02 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10677 Your paranoid android. === WXPPROSP3 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K3R2SESP2 (32 bit device) === device: unhandled exception c0000005 at 0040320F === WVISTAADM (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K8SE (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PRO (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (64 bit device) === Timeout

2 1

Re: [PATCH 2/2] wined3d: Turn off message filtering temporarily in the Reset() method to allow certain messages (e.g. WM_ACTIVATEAPP) through.
by Henri Verbeet 02 May '11

02 May '11

On 2 May 2011 13:18, John Edmonds <pocketcookies2(a)gmail.com> wrote: > Toki Tori and RUSH both depend on receing WM_ACTIVATEAPP before they will start. These messages are currently getting filtered out. > This resolves bug #25640. It doesn't look right to me to filter messages during IWineD3DDevice_ReleaseFocusWindow() but not IWineD3DDevice_AcquireFocusWindow(). Maybe it just shouldn't filter at all.

2 2

Working on UpdateSemantics or D3DXWeldVertices in D3DX9?
by Michael Mc Donnell 02 May '11

02 May '11

Hi Guys! I'm doing Google Summer of Code 2011 and found out that some of the functions I was to implement have been implemented while my application was being processed. This means I have to find some other functions in D3DX9 to implement. I see that UpdateSemantics and D3DXWeldVertices are unimplemented in D3DX9, and was wondering if anyone is working on these? Cheers, Michael

1 0

Re: comctl32: avoid using ZeroMemory()
by Marcus Meissner 02 May '11

02 May '11

On Mon, May 02, 2011 at 10:52:50AM -0500, Austin English wrote: > Avoids a Clang bug: > http://bugs.winehq.org/show_bug.cgi?id=26754 clang cannot even survive a simple memset() to 0? Ciao, Marcus

2 1

Re: [2/2] comctl32/mru: Ignore size field when creating with -W calls
by Alexandre Julliard 02 May '11

02 May '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -210,11 +210,11 @@ typedef INT (CALLBACK *MRUStringCmpFnA)(LPCSTR lhs, LPCSTR rhs); > typedef INT (CALLBACK *MRUStringCmpFnW)(LPCWSTR lhs, LPCWSTR rhs); > typedef INT (CALLBACK *MRUBinaryCmpFn)(LPCVOID lhs, LPCVOID rhs, DWORD length); > > -typedef struct tagCREATEMRULISTA > +typedef struct tagMRUINFOA > { > DWORD cbSize; > - DWORD nMaxItems; > - DWORD dwFlags; > + UINT uMax; > + UINT fFlags; > HKEY hKey; > LPSTR lpszSubKey; > union Please do the renamings as a separate patch. -- Alexandre Julliard julliard(a)winehq.org

2 1

D3D performance debugging report
by Stefan Dösinger 02 May '11

02 May '11

Hi, I spent a few hours debugging wined3d performance today. No, I found no magic fix for the slowness, just some semi-usable data. First I wrote a hacky patch to avoid redundant FBO applications. This gave a tiny, tiny performance increase, see http://www.winehq.org/pipermail/wine- devel/2011-April/089832.html. The main investigation concerned redundant shader applications. The aim was to find out how many of our glBindProgramARB calls are re-binding the same program, and how much this costs. Depending on the game between 20% to 90% of all BindProgram calls are redundant. I'll attach my debug hack so others can test their own apps. I used ARB shaders for testing because they can apply vertex and fragment programs separately. This brings up two questions: (a) How much does this cost (b) Why does this happen The costs: In my draw overhead tester hacking out the redundant apply calls improved performance a lot, from about 101 fps to 157 fps. The biggest part of that are the GL calls. Without them but the remaining shader logic I get 144 fps. Unfortunately this does not translate to any performance gains in real apps. I tried to filter out the redundant apply calls in the simplest way possible: Track the current value per wined3d_context and check before calling glBindProgramARB. This gave the 144 fps in the draw overhead tester, but no measurable increase in any other apps(I tested StarCraft 2, HL2, Team Fortress 2, World in Conflict and a few others) Given the amount of redundant apply calls and the cost of them in the draw overlay tester I have expected at least some improvement. Certainly not a 50% performance increase(the draw overlay tester performs no shader changes at all in the draw loop), but at least a 2-3% gain. So far I have no explanation why I didn't see that. But why do those redundant apply calls happen? It seems like the state dirtification comes all the way from the stream sources and/or vertex declaration. STREAMSRC is linked to VDECL, which is linked to VERTEXSHADER, which in turn reapplies the pixel shader. This means redundant vertex and pixel shader applications. Separating those states will be a major challenge. The vdecl<->vshader link shouldn't be needed any more, except in rare cases where GL_ARB_vertex_array_bgra is not supported and the application switches one attribute from D3DDECL_D3DCOLOR to a non-d3dcolor attribute. If the vertex shader changes we still have to reparse the vertex declaraion and reapply the stream sources because the vshader determines the stream numbers. Maybe we can reduce the number of times this happens by ordering stream usages and indices to make sure shaders with compatible input get the same stream ordering. vdecl and streamsrc are pretty related. If the vdecl is changed we have to reapply the stream sources. The other way around shouldn't cause problems though. There's no need to reapply every stream except the changed ones and there's no need to reapply the vertex shader. The vertex and pixel shader are linked for a few reasons: The shader backend API offers only a function to set both. Basic GLSL only offers a function to set both at once(GL_ARB_separate_shader_objects changes that). And even in ARB the pixel shader input may require some changes in the vertex shader output to get Shader Model 3.0 varyings right. The shader backend API can be changed, but it has to be done in a way that doesn't hurt GLSL without ARB_separate_shader_objects. If we have classic GLSL we have to keep the link. With ARB we can conditionally reapply the vertex shader if the ps_input_signature is changed. To complicate matters there are additional states that affect the shaders, like fog, textures, clipping. We don't keep track of those dependencies. So it's a lot of work to clean up these state dependencies and we don't know how much it'll gain us :-( Stefan

4 8

Re: [PATCH 1/2] d3d9/tests: Added a test for resetting an invisible, inactive window to fullscreen mode.
by Henri Verbeet 02 May '11

02 May '11

On 2 May 2011 13:18, John Edmonds <pocketcookies2(a)gmail.com> wrote: > + /*Pull all currently available messages. We don't care about messages generated after this loop exits.*/ > + while(PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) > + { > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } You should probably use flush_events() for that.

1 0

Re: [PATCH 2/2] wined3d: Turn off message filtering temporarily in the Reset() method to allow certain messages (e.g. WM_ACT
by Marvin 02 May '11

02 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10678 Your paranoid android. === WXPPROSP3 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K3R2SESP2 (32 bit device) === device: unhandled exception c0000005 at 0040320F === WVISTAADM (32 bit device) === device: unhandled exception c0000005 at 0040320F === W2K8SE (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PRO (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (32 bit device) === device: unhandled exception c0000005 at 0040320F === W7PROX64 (64 bit device) === Timeout

1 0

Re: wininet: Use test.winehq.org for post tests
by Marvin 02 May '11

02 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10676 Your paranoid android. === WVISTAADM (32 bit http) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 1/5] mmdevapi: Add InitializeDriver() method to drivers
by Alexandre Julliard 02 May '11

02 May '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > @@ -72,11 +73,19 @@ static BOOL load_driver(const WCHAR *name) > } > > #define LDFC(n) do { drvs.p##n = (void*)GetProcAddress(drvs.module, #n);\ > - if(!drvs.p##n) return FALSE; } while(0); > + if(!drvs.p##n) { FreeLibrary(drvs.module); return FALSE; } } while(0); > + LDFC(InitializeDriver); > LDFC(GetEndpointIDs); > LDFC(GetAudioEndpoint); > #undef LDFC > > + hr = drvs.pInitializeDriver(); > + if(FAILED(hr)){ > + TRACE("Driver initialization failed: %08x\n", hr); > + FreeLibrary(drvs.module); > + return hr; > + } If you are going to call it on load, you could just as well do the init in the driver on DLL_PROCESS_ATTACH and avoid the extra method. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/5] cmd: WCMD_delete: simplify logic, avoid assigning variable to itself
by Henri Verbeet 02 May '11

02 May '11

On 2 May 2011 02:23, Dan Kegel <dank(a)kegel.com> wrote: > - if (attribute && !negate) { > - stillOK = stillOK; > - } else if (!attribute && negate) { > - stillOK = stillOK; > - } else { > + if (attribute == negate) > stillOK = FALSE; > - } If you just write that as "if (!attribute == !negate)" you avoid both the assumption that TRUE is defined to 1 and the ugly "!= 0"'s. Or you could build actual attribute masks first and compare those instead, which may even be readable.

1 0

re: comctl32: realloc or free and alloc
by Dan Kegel 02 May '11

02 May '11

Alexey wrote: > i currently digg in comctl32 to find why my app fails. I found that > string conversation AtoW in some places silently fails. The problem is > that the destination for string is just a fresh pointer (not NULL). > Str_SetPtrAtoW check if it is NULL pointer and if not it trys to > ReAlloc. There was no Alloc before so ReAlloc returns NULL The code looks like it assumes that pointer is always managed by Alloc/ReAlloc/Free. In what context is the destination a fresh, non-Alloc'd pointer? Perhaps that's where the bug lies. Your proposed solution would pass a non-Alloc'd pointer to Free, which doesn't seem good. - Dan

4 9

Re: [PATCH 4/5] winecoreaudio.drv: Implement IAudioSessionControl::GetState
by Ken Thomases 01 May '11

01 May '11

Hi, On Apr 29, 2011, at 3:50 PM, Andrew Eikum wrote: > + LIST_FOR_EACH_ENTRY(client, &This->session->clients, ACImpl, entry){ > + OSSpinLockLock(&client->lock); > + if(client->playing == StatePlaying){ > + *state = AudioSessionStateActive; I think the session should be considered active if a client is in StateInTransition, too. Regards, Ken

1 0

Re: ddraw: Add a few tests for Setcooperativelevel
by Marvin 01 May '11

01 May '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10649 Your paranoid android. === WNT4WSSP6 (32 bit ddrawmodes) === ddrawmodes.c:800: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 ddrawmodes.c:803: Test failed: SetCooperativelevel(DDSCL_CREATEDEVICEWINDOW | DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN) returned: 80070057 ddrawmodes.c:828: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel
by Marvin 30 Apr '11

30 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10648 Your paranoid android. === WNT4WSSP6 (32 bit ddrawmodes) === ddrawmodes.c:520: Test failed: EnumDisplayModes returned: 80070057 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [Bug 26975] configure can't find OSSv4 (both Wine and OSSv4 is current from git and mercurial respectively)
by Brock York 30 Apr '11

30 Apr '11

Interestingly enough I just had this error and it was solved by sudo apt-get install oss4-base oss4-dev

1 0

gecko and native msvcrt
by Dan Kegel 30 Apr '11

30 Apr '11

While testing a game with current gecko, I saw the error wine: Call from 0x7bc4ad90 to unimplemented function msvcrt.dll._snwprintf_s, aborting The game needed a native msvcrt, so I had installed one with winetricks, and it didn't export that function. So it seems that new gecko is incompatible with old msvcrt, and using native msvcrt as a workaround for bugs in wine's version is going to be harder than it used to be. Time to fix more of them msvcrt bugs, I guess... And/or find a more up to date msvcrt.dll for winetricks.

4 5

Re: [PATCH] dinput: Mark internal symbols as hidden
by Vitaliy Margolen 30 Apr '11

30 Apr '11

On 04/29/2011 01:31 AM, Marcus Meissner wrote: > --- > dlls/dinput/device_private.h | 148 +++++++++++++++++++++--------------------- > 1 files changed, 74 insertions(+), 74 deletions(-) What exactly is this supposed to to? This is inside header file, everything declared in it is internal to dinput. Why do we need some extra declarations on it? Vitaliy.

7 10

comctl32: realloc or free and alloc
by Alexey Fisher 30 Apr '11

30 Apr '11

Hallo, i currently digg in comctl32 to find why my app fails. I found that string conversation AtoW in some places silently fails. The problem is that the destination for string is just a fresh pointer (not NULL). Str_SetPtrAtoW check if it is NULL pointer and if not it trys to ReAlloc. There was no Alloc before so ReAlloc returns NULL. Because there is no other checks, Str_SetPtrAtoW just go back without converting the string. Here is affected code: dlls/comctl32/comctl32undoc.c:999 > BOOL Str_SetPtrAtoW (LPWSTR *lppDest, LPCSTR lpSrc) > { > TRACE("(%p %s)\n", lppDest, lpSrc); > > if (lpSrc) { > INT len = MultiByteToWideChar(CP_ACP,0,lpSrc,-1,NULL,0); > LPWSTR ptr = ReAlloc (*lppDest, len*sizeof(WCHAR)); > > if (!ptr) { > ERR("last error %x\n", GetLastError()); > return FALSE; > } > MultiByteToWideChar(CP_ACP,0,lpSrc,-1,ptr,len); > *lppDest = ptr; > } > else { > Free (*lppDest); > *lppDest = NULL; > } > > return TRUE; > } The question is, is it appropriate reaction of ReAlloc and if it so, may be it make more sense to do this: --- a/dlls/comctl32/comctl32undoc.c +++ b/dlls/comctl32/comctl32undoc.c @@ -998,18 +998,26 @@ INT Str_GetPtrAtoW (LPCSTR lpSrc, LPWSTR lpDest, INT nMaxLen) */ BOOL Str_SetPtrAtoW (LPWSTR *lppDest, LPCSTR lpSrc) { - TRACE("(%p %s)\n", lppDest, lpSrc); + TRACE("(%p, %s)\n", *lppDest, debugstr_a(lpSrc)); if (lpSrc) { + if (*lppDest) { + Free (*lppDest); + *lppDest = NULL; + } INT len = MultiByteToWideChar(CP_ACP,0,lpSrc,-1,NULL,0); - LPWSTR ptr = ReAlloc (*lppDest, len*sizeof(WCHAR)); + LPWSTR ptr = Alloc (len*sizeof(WCHAR)); - if (!ptr) + if (!ptr) { + ERR("Can't allocait memory size: %u," + " for string %s.\n", len*sizeof(WCHAR), lpSrc); return FALSE; + } MultiByteToWideChar(CP_ACP,0,lpSrc,-1,ptr,len); *lppDest = ptr; } else { + TRACE("lpSrc = NULL, nothing to convert.\n"); Free (*lppDest); *lppDest = NULL; } -- Regards, Alexey

1 0

Re: wined3d: If Wine fails to acquire the focus window, allow the wndproc function to continue receiving messages.
by Henri Verbeet 30 Apr '11

30 Apr '11

On 30 April 2011 01:23, John Edmonds <pocketcookies2(a)gmail.com> wrote: > @@ -6559,6 +6559,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Reset(IWineD3DDevice *iface, > { > ERR("Failed to acquire focus window, hr %#x.\n", hr); > wined3d_swapchain_decref(swapchain); > + This->filter_messages = filter; > return hr; > } This patch looks right in principle. Note that if you're running into this code you probably have problems elsewhere though.

1 0

re: msvbvm60: add stub dll
by Dan Kegel 29 Apr '11

29 Apr '11

Austin wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=19816 That bug is "Add implementation of MSVBVM60". I don't think a stub fixes it. What apps benefit from having a stub? - Dan

1 0

Fix WineHQ bug #19762
by Joerg-Cyril.Hoehle＠t-systems.com 29 Apr '11

29 Apr '11

Kai Wasserbäch wrote: >as bug #19762 is open for some time now, fully bisected, the solution applied for >several versions in my Debian packages ([0]) without reports about breakage, I >hearby propose the reversion of commit 67631163. http://bugs.winehq.org/show_bug.cgi?id=19762#c21 That commit is another example of a commit that introduced a regression while fixing another regression in another app. This does not prove that commit wrong, however, the burden is now on you (us) to prove it in order to change git. It's not an impossible task. Even code that seemed to be backed by tests in Wine was changed when the tests were proven wrong/incomplete. For a start, it may be worth testing that other app and see if it still needs that commit in current Wine. Does anybody know the bug number of that other app's original issue? Finally, are there any tests that support either behavior? Regards, Jörg Höhle

1 0

Re: Fix WineHQ bug #19762
by Henri Verbeet 29 Apr '11

29 Apr '11

On 29 April 2011 12:29, Kai Wasserbäch <curan(a)debian.org> wrote: > several versions in my Debian packages ([0]) without reports about breakage, I > hearby propose the reversion of commit 67631163. Wylda tried to reach the I don't think reverting that commit is the right thing to do, it's just going to break something else instead.

1 0

Re: [1/5] wined3d: Add missing temporary variable declaration to ARB shader backend.
by Stefan Dösinger 29 Apr '11

29 Apr '11

> + shader_addline(buffer, "TEMP TB;\n"); Which shader instruction uses this? Afair vertex shaders should only use TA, but there's no proper infrastructure that manages that.

2 2

Re: msvcrt: fix utime to correctly handle a NULL-pointer for the utimbuf structure field
by Marvin 29 Apr '11

29 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10627 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: po: Update French translation
by Nicolas Le Cam 29 Apr '11

29 Apr '11

Hi Frédéric, Le 29 avril 2011 00:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > #: winerror.mc:441 > msgid "No more search handles\n" > -msgstr "Il n'y a plus de descripteurs de recherche\n" > +msgstr "Il n'y a plus de descripteur de recherche\n" This one isn't correct. There's not only one handle when available but many so it should take an 's' in the negative form too. Thanks for your work ! -- Nicolas Le Cam

2 1

Re: [2/5] wined3d: Remove rcp special handling of 0 from the ARB shader backend.
by Stefan Dösinger 28 Apr '11

28 Apr '11

On Thursday 28 April 2011 00:34:24 Matteo Bruni wrote: > This should fix http://bugs.winehq.org/show_bug.cgi?id=26780 I see this patch was committed, I think I should really read wine-patches more often. I added the RCP 0 handling because StarCraft 2 needed it. Did you test this with SC2? Specifically, the Water was black without proper handling of rcp 0

1 0

Re: comctl32/tests: Remove practically unused parameters from test functions
by Vitaliy Margolen 28 Apr '11

28 Apr '11

On 04/27/2011 01:14 AM, Nikolay Sivov wrote: > Remove practically unused parameters from test functions > So how is global variable any better then local variable passed as function parameter? IMHO this is s wrong thing to do - to move everything as global variables just to move it back whenever need arises. Vitaliy.

3 3

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)
by Austin English 28 Apr '11

28 Apr '11

On Thu, Apr 28, 2011 at 14:52, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > --- > Now using atexit function to cleanup up the output file on errors, and > parsing errors are signaled using a boolean error variable. > > diff --git a/include/rmxftmpl.x b/include/rmxftmpl.x > new file mode 100644 > index 0000000..e7144b0 > --- /dev/null > +++ b/include/rmxftmpl.x > @@ -0,0 +1,268 @@ > +xof 0302txt 0064 > +// Copyright (C) 2011 Dylan Smith > +// > +// This library is free software; you can redistribute it and/or > +// modify it under the terms of the GNU Lesser General Public > +// License as published by the Free Software Foundation; either > +// version 2.1 of the License, or (at your option) any later version. > +// > +// This library is distributed in the hope that it will be useful, > +// but WITHOUT ANY WARRANTY; without even the implied warranty of > +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +// Lesser General Public License for more details. > +// > +// You should have received a copy of the GNU Lesser General Public > +// License along with this library; if not, write to the Free Software > +// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA Looks like some C99 comments slipped in. -- -Austin

2 1

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)
by David Adam 28 Apr '11

28 Apr '11

1 0

Re: [po]update korean resource
by Nikolay Sivov 28 Apr '11

28 Apr '11

On 4/28/2011 13:25, Hwang YunSong(???) wrote: > updated > #: hhctrl.rc:73 > -#, fuzzy > -msgctxt "table of contents" > +msgctxt "????????+??? ?????????" > msgid "&Home" > -msgstr "???" > +msgstr "???(&H)" msgctxt is not a thing to translate as I understand it. It's an additional identifier to distinguish multiple translation variations.

1 0

Re: wined3d/state: Treat unrecognized D3DZBUFFERTYPEs as D3DZB_TRUE. (try 2)
by Henri Verbeet 28 Apr '11

28 Apr '11

I'm not so convinced there's value in this, considering there are no known applications depending on this. Stefan thinks it's useful anyway. If you do want to spend the effort to make this go in, note that this affects ddraw and d3d8 as well, not just d3d9. The test should probably just have a loop in depth_buffer_test() itself, or even write a test specific for this purpose. The wined3d part might as well handle the state as a BOOL, considering WINED3DZB_USEW isn't handled all that different from WINED3DZB_TRUE, except for the FIXME.

3 2

Re: [4/5] wined3d: Fix pow handling with special values in ARB backend.
by Matteo Bruni 28 Apr '11

28 Apr '11

Actually, this patch seems to break Bioshock with UseGLSL=disabled. Please drop/revert this one for the time being...

1 0

[Fwd: po files]
by Łukasz Wojniłowicz 28 Apr '11

28 Apr '11

3 3

mmsystem: Improve 16 bit mapping for MCI_WHERE/PUT/FREEZE/UNFREEZE.
by Joerg-Cyril.Hoehle＠t-systems.com 28 Apr '11

28 Apr '11

Hi, Damjan Jovanovic wrote: >In the meanwhile I've found another problem: mciavi32 always deadlocks >when MCI_WAIT is not set:[...] ShowWindow() Looks like bug #21060 and the others http://bugs.winehq.org/show_bug.cgi?id=21060#c2 - bug #12908, bug #15669, bug #18363 involving ShowWindow; - bug #14785, bug #21060 involving EnterCriticalSection. But perhaps there's only a single issue. It would be nice if somebody who knows about windows and their messages would look at these. Regards, Jörg Höhle

1 0

mmsystem: Improve 16 bit mapping for MCI_WHERE/PUT/FREEZE/UNFREEZE.
by Joerg-Cyril.Hoehle＠t-systems.com 28 Apr '11

28 Apr '11

Damjan, can you recommend any downloadable 16bit app that stresses the MCI? It's good that you noticed that RECT16 and RECT do not have the same size (whack!). Yet I'm surprised that you left MCI_WINDOW untouched. I believe that the apps that use MCI_WHERE/PUT etc. (i.e. MCIAVI) are likely to use MCI_WINDOW as well to set the window handle. Does no FIXME appear in your console? http://source.winehq.org/source/dlls/mmsystem.dll16/mci16.c#L182 The comment there is obsolete. dwFlags is available and could be used like I did in db0df4c067fd6b701905aaef735c4729fca9d73f Regards, Jörg Höhle

2 1

Re: [PATCH 3/3] msvcrt: Updated spec file
by Alexandre Julliard 28 Apr '11

28 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +@ cdecl -arch=win32 __p___argc() > +@ cdecl -arch=win32 __p___argv() > +@ cdecl -arch=win32 __p___initenv() > +@ cdecl -arch=win32 __p___mb_cur_max() MSVCRT____mb_cur_max_func > +@ cdecl -arch=win32 __p___wargv() > +@ cdecl -arch=win32 __p___winitenv() > +@ cdecl -arch=win32 __p__acmdln() > +@ cdecl -arch=win32 __p__amblksiz() > +@ cdecl -arch=win32 __p__commode() > +@ cdecl -arch=win32 __p__daylight() MSVCRT___p__daylight > +@ cdecl -arch=win32 __p__dstbias() > +@ cdecl -arch=win32 __p__environ() > +@ stub -arch=win32 __p__fileinfo #() > +@ cdecl -arch=win32 __p__fmode() > +@ cdecl -arch=win32 __p__iob() MSVCRT___iob_func > +@ stub -arch=win32 __p__mbcasemap #() > +@ cdecl -arch=win32 __p__mbctype() > +@ cdecl -arch=win32 __p__osver() > +@ cdecl -arch=win32 __p__pctype() MSVCRT___pctype_func > +@ cdecl -arch=win32 __p__pgmptr() > +@ stub -arch=win32 __p__pwctype #() > +@ cdecl -arch=win32 __p__timezone() MSVCRT___p__timezone > +@ cdecl -arch=win32 __p__tzname() > +@ cdecl -arch=win32 __p__wcmdln() > +@ cdecl -arch=win32 __p__wenviron() > +@ cdecl -arch=win32 __p__winmajor() > +@ cdecl -arch=win32 __p__winminor() > +@ cdecl -arch=win32 __p__winver() > +@ cdecl -arch=win32 __p__wpgmptr() I just changed this the other way around recently. These are exported in at least some 64-bit versions. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] Add undocumented function to unify MultiByteToWideChar conversation
by Alexey Fisher 28 Apr '11

28 Apr '11

MultiByteToWideChar are called directly only from one function. All other colls in comctl32 go thrue this function. It was recovered with from dissassambled code. Signed-off-by: Alexey Fisher <bug-track(a)fisher-privat.net> --- dlls/comctl32/comctl32undoc.c | 41 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/comctl32undoc.c b/dlls/comctl32/comctl32undoc.c index ff94051..6eb6c0f 100644 --- a/dlls/comctl32/comctl32undoc.c +++ b/dlls/comctl32/comctl32undoc.c @@ -560,6 +560,47 @@ INT WINAPI AddMRUStringW(HANDLE hList, LPCWSTR lpszString) } /************************************************************************** + * comctl_MultiByteToWideChar (internal) + * Convert Multibyte string to WideChar string. + * + * PARAMS + * CodePage [I] COdepage of lpMultiByteStr + * lpMultiByteStr [I] multibyte string + * + * RETURNS + * Pointer to lpWideCharStr [O] or NULL if failed. Do not forget to + * Free the lpWideCharStr after use! + */ +LPWSTR comctl_MultiByteToWideChar(UINT CodePage, LPCSTR lpMultiByteStr) +{ + LPWSTR lpWideCharStr; + int len; + + if (lpMultiByteStr == NULL || lpMultiByteStr == -1) + return NULL; + + if (IsBadReadPtr(lpMultiByteStr, 1)) + return NULL; + + len = MultiByteToWideChar(CodePage, NULL, lpMultiByteStr, -1, NULL, NULL); + if (!len) + len = 1; + + lpWideCharStr = LocalAlloc(len * sizeof(WCHAR), 0); + if (!lpWideCharStr) + return NULL; + + if (!MultiByteToWideChar(CodePage, 1, lpMultiByteStr, -1, + lpWideCharStr, len)) { + LocalFree(lpWideCharStr); + lpWideCharStr = NULL; + return NULL; + } + + return lpWideCharStr; +} + +/************************************************************************** * AddMRUStringA [COMCTL32.153] * * See AddMRUStringW. -- 1.7.4.1

3 6

Re: infosoft/tests: COM cleanup in infosoft.c.
by Marvin 27 Apr '11

27 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10605 Your paranoid android. === WVISTAADM (32 bit infosoft) === infosoft.c:185: Test failed: failed infosoft.c:199: Test failed: failed === W2K8SE (32 bit infosoft) === infosoft.c:185: Test failed: failed infosoft.c:199: Test failed: failed === W7PRO (32 bit infosoft) === infosoft.c:185: Test failed: failed infosoft.c:199: Test failed: failed === W7PROX64 (32 bit infosoft) === infosoft.c:185: Test failed: failed infosoft.c:199: Test failed: failed === W7PROX64 (64 bit infosoft) === infosoft.c:185: Test failed: failed infosoft.c:199: Test failed: failed

2 1

Question on Conformance Test
by James McKenzie 27 Apr '11

27 Apr '11

All: I am writing a conformance test for the richedit function EM_FINDWORDBREAK. I realize that WindowsNT 4.0 is our base configuration and most of the values process the same. However, a couple of values process differently for Windows NT 4.0/Windows2000, WindowsXP/Windows2003 and Windows Vista onward. What would be the BEST method of annotating this: Per the development guide: ok ( GetLastError() == WINXP_ERROR || GetLastError() == WINNT40_ERROR, ...); or: ok ( GetLastError() == WINXP_ERROR || Broken (GetLastError() == WINNT40_ERROR)); In other words, should I avoid the use of Broken() in this case, as the returned value is correct? Thank you. James McKenzie

3 2

Re: wined3d: Track when the FBO is dirty. (try 4)
by Adam Martinson 27 Apr '11

27 Apr '11

On Tuesday 26 April 18:16:27 Henri Verbeet wrote: > This is mostly the same as the previous version. Yes, it's just rebased. I'm happy to change it however you see fit, but I need to know what you'd like changed and how.

1 0

winealsa.drv: Add mmdevapi driver.
by Joerg-Cyril.Hoehle＠t-systems.com 27 Apr '11

27 Apr '11

Andrew, + fmt->Format.nSamplesPerSec = 41100; + fmt->nSamplesPerSec != 41100 && 44100. IIRC, there was an error exactly like this somewhere in the old drivers. But why does your IsFormatSupported only accept 48kHz, 44.1, 22.050, etc.? Do the native drivers behave like this? Is this a reasonable subset such that Wine behaves the same on most HW (disregarding CONTINUOUS_RATE)? dump_fmt + TRACE("cbSize: %u\n", fmt->cbSize); Old Wine code contains several comments about never ever reading cbSize in the WAVE_FORMAT_PCM case because it's a potential read past the structure and may cause a segmentation fault. Is it not a valid concern anymore? WAVEFORMATEX contains the cbSize slot. However if the winmm:wave* functions pass through their argument to mmdevapi, it may well end up to be the smaller PCMWAVEFORMAT only. IsFormatSupported MSDN says that CoTaskMemFree will be used to free the output variable ppClosestMatch. Wine uses clone_format=>HeapAlloc to allocate it. Does CoTaskMemFree match HeapAlloc? I'd have expected CoTaskMemAlloc, but I've never used these OLE functions. + switch(fmt->wBitsPerSample){ + case 64: + if(!snd_pcm_format_mask_test(formats, SND_PCM_FORMAT_FLOAT64_LE)){ vs. + if(fmt->wBitsPerSample != 32){ + WARN("Unsupported float size: %u\n", fmt->wBitsPerSample); IsFormatSupported may accept 64 bit fp samples, but Initialize will refuse it. Did you add that code to hear about sound cards that process 64 bits so we know they exist? Regards, Jörg Höhle

3 4

Re: wined3d: Track when the FBO is dirty. (try 4)
by Adam Martinson 27 Apr '11

27 Apr '11

On Wednesday 27 Apr 2011 01:19:51 Stefan Dösinger wrote: > > > On Tuesday 26 April 2011 19:35:06 Adam Martinson wrote: > > - FIXME("Unrecognized D3DZBUFFERTYPE value %#x.\n", > > + WARN("treating unrecognized D3DZBUFFERTYPE value %#x as > WINED3DZB_TRUE.\n", > > stateblock->state.render_states[WINED3DRS_ZENABLE]); > > + /* falltrough */ > > + case WINED3DZB_TRUE: > Please provide a test for this. Will do, but this is for http://source.winehq.org/patches/data/73534 not http://source.winehq.org/patches/data/73533.

2 1

Re: wined3d: Track when the FBO is dirty. (try 4)
by Henri Verbeet 27 Apr '11

27 Apr '11

This is mostly the same as the previous version.

2 1

Question on Conformance Test
by Joerg-Cyril.Hoehle＠t-systems.com 27 Apr '11

27 Apr '11

Hi, James McKenzie wrote: >I realize that WindowsNT 4.0 is our base configuration IMHO that doesn't matter. Winecfg's default changed from w95 to w2k to xp while I was looking. >What would be the BEST method of annotating this: >ok ( GetLastError() == WINXP_ERROR || GetLastError() == WINNT40_ERROR, ...); >or: >ok ( GetLastError() == WINXP_ERROR || Broken (GetLastError() == WINNT40_ERROR)); You judge: - If you feel both results are quite logical, use ||. - I've used broken() to document which values Wine shall *not* return. That's IMHO an underestimated use of broken(). - OTOH, I've used || specifically when I thought Wine might/should perhaps change behavior in the future, such that no future patch would be needed to turn GetLastError() == WINXP_ERROR || broken(GetLastError() == WINNT40_ERROR) into broken(GetLastError() == WINXP_ERROR || GetLastError() == WINNT40_ERROR - ... which never prevented me from writing todo_wine ok(broken(NT.../*what Wine returns today*/) || XP /*what I want it to return*/, ... (rather than that, put broken last). Regards, Jörg Höhle

1 0

Re: wined3d: Track when the FBO is dirty. (try 4)
by Stefan Dösinger 26 Apr '11

26 Apr '11

On Tuesday 26 April 2011 19:35:06 Adam Martinson wrote: > - FIXME("Unrecognized D3DZBUFFERTYPE value %#x.\n", > + WARN("treating unrecognized D3DZBUFFERTYPE value %#x as WINED3DZB_TRUE.\n", > stateblock->state.render_states[WINED3DRS_ZENABLE]); > + /* falltrough */ > + case WINED3DZB_TRUE: Please provide a test for this.

1 1

Re: wined3d/query: Add support for timestamp queries.
by Stefan Dösinger 26 Apr '11

26 Apr '11

I think timestamp queries are supposed to return GPU-side timestamps. Otherwise I don't see the point in adding a complex d3d query around QueryPerformanceFrequency. There's GL_ARB_timer_query which looks like it does what you need.

1 0

Re: wined3d/state: Treat unrecognized D3DZBUFFERTYPEs as WINED3DZB_TRUE.
by Henri Verbeet 26 Apr '11

26 Apr '11

Nope.

1 0

Re: wined3d/query: Add support for timestamp queries.
by Henri Verbeet 26 Apr '11

26 Apr '11

On 26 April 2011 19:35, Adam Martinson <amartinson(a)codeweavers.com> wrote: > +#include "d3d10.h" I don't think so.

1 0

Re: [PATCH 3/4] dsound: Implement capture buffer based on mmdevapi, try 2
by Andrew Eikum 26 Apr '11

26 Apr '11

It would be nice if you used more descriptive variable names. For example: +struct IDirectSoundCaptureBufferImpl +{ + DWORD buf_size; + DWORD pos; What units are these sizes and positions in? Frames? Bytes? Time? What position is being represented here, read, write, or something else? Using more descriptive names helps when understanding and verifying code like this: + pos1 = This->pos; + if (This->playing) + { + pos2 = This->format->nSamplesPerSec / 100; + pos2 *= This->format->nBlockAlign; + pos2 += pos1; + if (!This->looping && pos2 > This->buf_size) + pos2 = 0; + else + pos2 %= This->buf_size; + } + else + pos2 = pos1; + pos2 %= This->buf_size; Are all of these positions in Bytes? I hope so... (Remember this has tripped things up in the past, see bbbf72ddcb). If everything is always in bytes, maybe make a note of that near the variable declarations, and then verify that it's true throughout the code. Also, why is pos1 a separate variable here? These patches are all missing quite a lot of error handling, which really makes me hesitate. Especially on some important calls: + IAudioCaptureClient_GetBuffer(buf->cap_dev, &data, &read, &flags, &pos, 0); + IAudioClient_GetDevicePeriod(This->dev, &default_period, &min_period); + IAudioClient_Start(This->dev); Knowing when these functions fail will help debugging if something goes wrong. Much worse to suddenly crash four function calls later due to invalid default_period value than to just error out appropriately when the error occurs. This doesn't matter a whole lot, but I think it would be more clear to use a separate object here, instead of a separate refcount: struct IDirectSoundCaptureBufferImpl { IDirectSoundCaptureBuffer8 IDirectSoundCaptureBuffer8_iface; - LONG ref; + IDirectSoundNotify IDirectSoundNotify_iface; + LONG ref, notify_ref; If not, at least a comment explaining why two refcounts are needed. Obviously a test would improve it even more, if one doesn't already exist.

1 0

Re: cmd: handle spaces in directory names in del /s
by Alexandre Julliard 26 Apr '11

26 Apr '11

Dan Kegel <dank(a)kegel.com> writes: > @@ -771,13 +771,16 @@ BOOL WCMD_delete (WCHAR *command, BOOL expectDir) { > > DIRECTORY_STACK *nextDir; > WCHAR subParm[MAX_PATH]; > + static const WCHAR quoteW[] = { '"', 0 }; > > /* Work out search parameter in sub dir */ > - strcpyW (subParm, thisDir); > + strcpyW (subParm, quoteW); > + strcatW (subParm, thisDir); > strcatW (subParm, fd.cFileName); > strcatW (subParm, slashW); > strcatW (subParm, fname); > strcatW (subParm, ext); > + strcatW (subParm, quoteW); That's ugly. File names should not go through command processing again. -- Alexandre Julliard julliard(a)winehq.org

1 0

requesting review and/or testing for directsound changes
by Maarten Lankhorst 26 Apr '11

26 Apr '11

Hi all, with http://repo.or.cz/w/wine/multimedia.git and http://repo.or.cz/w/openal-soft.git you should be able to get the benefits of openal-soft's mixer while continuing to use whatever driver you want for mmdevapi. As a result directsound will only support openal-soft, but multi channel is suddenly supported, as is support for the floating point format. 24-bits and 32-bits int are currently not, but as soon as that capability is added to openal-soft.git wine will have a nice working dsound implementation with support for a lot of things that are missing now. The resampling code will also be a lot better and you should expect a higher quality when resampling is used. The capture changes should work nicely, and I don't expect a problem with that, since it's based on openal. The rendering code is essentially reviving the old dsound-openal, and outputting it to mmdevapi. Note: 24-bits and 32-bits int are unsupported and will most likely cause a crash, disable the #if 1 in get_fmtstr_EXT to prevent lying about support. It was put in place so the wine dsound tests would pass. A dsound.dll.so binary with openal-soft.git statically linked in can be found at: http://www.astro.rug.nl/~lankhorst/dsound.dll.so If you're using pulseaudio, patch your 32-bits alsa-plugins with the attached patch, or silence may occur when using the new mmdevapi drivers. Cheers, Maarten

2 1

Re: dinput/tests: Initial tests for Action Mapping. Added some tests for the creation of a DirectInput8 Interface and a dummy call of EnumDevicesBySemantics.
by Austin English 26 Apr '11

26 Apr '11

On Sun, Apr 24, 2011 at 18:12, Lucas Fialho Zawacki <lfzawacki(a)gmail.com> wrote: Howdy Lucas, > + hr = CoCreateInstance(&CLSID_DirectInput8, 0, 1, &IID_IDirectInput8A, (LPVOID*)&pDI); > + if (hr == DIERR_OLDDIRECTINPUTVERSION || > + hr == DIERR_BETADIRECTINPUTVERSION || > + hr == REGDB_E_CLASSNOTREG) > + { > + skip("ActionMapping requires dinput8\n"); > + return; > + } > + ok(SUCCEEDED(hr), "DirectInput8 Create failed: hr=%08x\n", hr); > + if (FAILED(hr)) return; > + > + hr = IDirectInput8_Initialize(pDI,hinst, 0x0800 /* DirectInput8 */ ); > + if (hr == DIERR_OLDDIRECTINPUTVERSION || hr == DIERR_BETADIRECTINPUTVERSION) > + { > + skip("ActionMapping requires dinput8\n"); > + return; > + } You probably should use win_skip here, Wine shouldn't have missing dinput8 support. Cheers, Austin

3 2

Re: d3dx9_36: Fix uninitialized variable warnings.
by Matteo Bruni 26 Apr '11

26 Apr '11

2011/4/26 Nicolas Le Cam <niko.lecam(a)gmail.com>: > msdn tells us to use 0 to disable colorkey [1]. Let me know if you > think it isn't the correct things to do. > > [1] http://msdn.microsoft.com/en-us/library/bb172902%28v=vs.85%29.aspx > > -- > Nicolas Le Cam > Argh, this was already spotted by Gerald Pfeifer some time ago and I told him I was going to send a patch, which didn't happen yet... I'm sending it now (I prefer to fix this in a different way), assuming your patch wasn't already committed by AJ.

2 1

Google Summer of Code 2011 is on!
by Austin English 26 Apr '11

26 Apr '11

We've got five projects this year: Jay Yang - Implement the Explorer - http://socghop.appspot.com/gsoc/project/google/gsoc2011/yangjay/8001 Lucas Fialho Zawacki - Implementation of DirectInput8 Action Mapping feature - http://socghop.appspot.com/gsoc/project/google/gsoc2011/lfzawacki/8001 Michael Mc Donnell - Implement Missing Mesh Functions in Wine’s D3DX9 - http://socghop.appspot.com/gsoc/project/google/gsoc2011/mmd/9001 Michal Zietek - Implementing WScript API - http://socghop.appspot.com/gsoc/project/google/gsoc2011/misiek/6001 Pluciński Mariusz - Extending gameux.dll by Games Explorer Shell Extension - http://socghop.appspot.com/gsoc/project/google/gsoc2011/vshader/29001 Congrats everyone! Now get coding :-). -- -Austin

2 1

re: VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by Dan Kegel 25 Apr '11

25 Apr '11

Nikolay wrote: >> Who has authority to approve it? > A patch? Alexandre Julliard, he's the only project maintainer. > Send a patch to wine-patches at winehq.org when you think > it's ready and you'll get some feedback if it's not. Be sure to send it to winetestbot first, and fix any problems it finds; see http://wiki.winehq.org/SubmittingPatches - Dan

2 1

ERROR: Compile wine tests on WINDOWS with MS C/C++
by Gerold Jens Wucherpfennig 25 Apr '11

25 Apr '11

Regarding: 5.5.4. Standalone, using the Microsoft C++ Toolkit of http://www.winehq.org/docs/winedev-guide/testing-windows : I tried to compile dlls/rasapi32/test/rasapi.c on Windows and got these error messages: Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.30729.01 for 80x86 Copyright (C) Microsoft Corporation. All rights reserved. rasapi.c .\wine/test.h(66) : error C2143: syntax error : missing '{' before 'const' .\wine/test.h(70) : error C2054: expected '(' to follow 'inline' .\wine/test.h(71) : error C2085: 'winetest_strcmpW' : not in formal parameter li st .\wine/test.h(71) : error C2143: syntax error : missing ';' before '{' -- Gerold

2 1

Re: [PATCH 6/6] mmdevapi/tests: Add tests for IAudioClock
by Alexandre Julliard 25 Apr '11

25 Apr '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > + pcpos = 0; > + hr = IAudioClock_GetPosition(acl, &pos, &pcpos); > + ok(hr == S_OK, "GetPosition failed: %08x\n", hr); > + ok(pos == 0, "GetPosition returned non-zero pos before being started: %lld\n", pos); Please avoid %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/6] wineoss.drv: Add MMDevAPI driver
by Alexandre Julliard 25 Apr '11

25 Apr '11

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +{ > + int i, mixer_fd; > + oss_sysinfo sysinfo; > + static int print_once = 0; > + > + TRACE("%d %p %p %p\n", flow, ids, num, def_index); > + > + mixer_fd = open("/dev/mixer", O_RDONLY, 0); > + if(mixer_fd < 0){ > + ERR("OSS /dev/mixer doesn't seem to exist\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; > + } > + > + if(ioctl(mixer_fd, SNDCTL_SYSINFO, &sysinfo) < 0){ > + close(mixer_fd); > + > + if(errno == EINVAL){ > + ERR("OSS version too old, need at least OSSv4\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; You'll need a configure check too, things like the oss_sysinfo type don't exist on OSSv3. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)
by Alexandre Julliard 25 Apr '11

25 Apr '11

Charles Davis <cdavis(a)mymail.mines.edu> writes: > Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. It's still not listing my /dev/hda CD drive. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().
by Henri Verbeet 25 Apr '11

25 Apr '11

2011/4/20 Rico Schüller <kgbricola(a)web.de>: > +inline LPSTR get_partial_string(LPCSTR name, char initial, char final) That should probably be static instead of inline. Also, get_parameter_by_name() looks like it could be split up, and you can probably avoid the copy in get_partial_string().

2 1

Style updates for source.winehq/patches
by Jerome Leclanche 24 Apr '11

24 Apr '11

Attached patch to tools.git/patches/patches.css adds the necessary styling for a WineHQ-style patch status page: http://i.imgur.com/5ToSc.png The div class="main" needs to be replaced by the html attached in the other file. I can write a patch for it if it's to be included, but I cannot test it. Is it worth doing? J. Leclanche

1 0

Re: VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by Nikolay Sivov 23 Apr '11

23 Apr '11

On 4/23/2011 22:46, John Fremlin wrote: > Nikolay Sivov<bunglehead(a)gmail.com> writes: > >> On 4/23/2011 22:22, John Fremlin wrote: >>> Nikolay Sivov<bunglehead(a)gmail.com> writes: >>> >>>> On 4/23/2011 19:00, John Fremlin wrote: >>>>> Europeans write dates generally as dd-mm-yyyy. This makes sense. So does >>>>> yyyy-mm-dd. Native will parse dates written yyyy-mm-dd correctly. Wine for some >>>>> reasons assumes they are yyyy-dd-mm. This is not a date ordering used anywhere >>>>> as far as I know and contradicts the MS behaviour. >>>>> >>>>> I've submitted http://bugs.winehq.org/show_bug.cgi?id=26902 >>>>> >>>>> I've included a patch which fixes the problem and adds a testcase. Is >>>>> there anything I can do to improve the chances that this fairly >>>>> unambiguous fix meets the next release? -- I have some secret and >>>>> cunning plans which are unfortunately predicated on this being fixed. >>>>> @@ -3458,6 +3458,7 @@ static void test_VarDateFromStr(void) >>>>> DFS("02.01.1970"); EXPECT_DBL(25570.0); >>>>> DFS("02.13.1970"); EXPECT_DBL(25612.0); >>>>> DFS("02-13-1970"); EXPECT_DBL(25612.0); >>>>> + DFS("2020-01-11"); EXPECT_DBL(43841.0); >>>> Hi, John. >>>> >>>> This is locale-dependent thing, so it will need at least more tests >>>> for different locales (locales with different default month/day order >>>> I mean). >>> Hi Nikolay, >>> >>> Is there really ever a locale which actually parses ydm under the native >>> implementation? >> Not really, as far as I know. My point was to test with different >> pattern anyway. For example for >> yyyy/mm/dd and dd/mm/yyyy locales. Also this particular test is not >> very descriptive cause >> month and day in it both fit month or day range, so you can't tell how >> it's interpreted. > I don't understand the confusion here? > > The single test extra test is explicitly for a date that can only be > converted either as y-m-d or the imaginary Wine-only y-d-m format. That > should be interpreted in exactly one way, and it is interpreted > incorrectly at the moment. The patch fixes that. Yes, I got it. Wine converts 2020-01-11 string as 1st of November while native treats it as 11th of January. What I meant that test data should be clear about what field is day and what's a month. For your case it could be '2020-01-30' to make 30 invalid value for a month. > If you want extra tests, I'm sure they'd be great, but I think this > pretty unambiguously represents an improvement. About additional tests, what about cases like '2020-20-01' on locales that use 'mm/dd/yyyy' or '2020-01-30' for locales that are 'dd/mm/yyyy'? Even if you're sure patch doesn't break that it's always better to add more tests (maybe some tests for that are in already). > Who has authority to approve it? A patch? Alexandre Julliard, he's the only project maintainer. Send a patch to wine-patches(a)winehq.org when you think it's ready and you'll get some feedback if it's not.

1 0

VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales
by John Fremlin 23 Apr '11

23 Apr '11

Europeans write dates generally as dd-mm-yyyy. This makes sense. So does yyyy-mm-dd. Native will parse dates written yyyy-mm-dd correctly. Wine for some reasons assumes they are yyyy-dd-mm. This is not a date ordering used anywhere as far as I know and contradicts the MS behaviour. I've submitted http://bugs.winehq.org/show_bug.cgi?id=26902 I've included a patch which fixes the problem and adds a testcase. Is there anything I can do to improve the chances that this fairly unambiguous fix meets the next release? -- I have some secret and cunning plans which are unfortunately predicated on this being fixed.

2 3

Re: Matching Windows 7 folder locations?
by newsletter [at] Schiermeier-Software 23 Apr '11

23 Apr '11

Hello Dan, wdrwo> Windows 7 changed the folders in c:/users/$USERNAME around a bit. not only 'a bit'. There are a lot of changes in the folder structure since Vista: See URL: <http://msdn.microsoft.com/en-us/library/dd378457(v=VS.85).aspx> -- Joerg Schiermeier

1 0

Missing backtrace when debugging a game
by Jerome Leclanche 23 Apr '11

23 Apr '11

I'm currently trying to debug http://bugs.winehq.org/show_bug.cgi?id=25977. Even when running "winedbg bin/release/loader.exe", this is what happens: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00365327). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:00365327 ESP:0033dd20 EBP:000003d9 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:00000000 ECX:0018e268 EDX:00000011 ESI:0018e268 EDI:0016e560 Stack dump: 0x0033dd20: 00000000 0018e268 003670f9 0033dd9c 0x0033dd30: 0033fb68 0002002a 001712b0 00000005 0x0033dd40: 100d2e46 00401920 0002002a 0033e39c 0x0033dd50: 0033ddc8 7edb2ff4 00000000 00000000 0x0033dd60: 00000000 00000000 00000690 0000041a 0x0033dd70: 0000002c 00000000 00000001 ffffffff 000c: sel=0067 base=00000000 limit=00000000 16-bit rw- Backtrace: 0x00365327: movl 0x0(%eax),%ecx Wine-dbg>bt Backtrace: Any advice, or idea why this would happen? Furthermore, is it a bug with winedbg, and worth filing? J. Leclanche

3 2

Matching Windows 7 folder locations?
by Dan Kegel 23 Apr '11

23 Apr '11

Windows 7 changed the folders in c:/users/$USERNAME around a bit. My Documents is now just a link to the new folder Documents Application Data is now just a link to the new folder AppData/Roaming Local Settings is now just a link to the new folder AppData/Local How is this going to affect Wine? Well-behaved apps that use CSIDL_PERSONAL to get at "My Documents" or "Documents" will work regardless, but users or badly behaved apps might start expecting the shorter directory names sometime. (I always hated the spaces, anyway.)

3 2

Re: user32: Fix Jittery Mouse movement
by Vitaliy Margolen 23 Apr '11

23 Apr '11

On 04/22/2011 02:06 PM, EG Galano wrote: > This fixes jittery mouse movement in Combat Arms. This was introduced > in commit 79c2e55b5a6331d15788f65a929e9e002c2f8b05 > > This is likely the same issue discussed here but I don't have a copy > to test: http://forum.winehq.org/viewtopic.php?t=11759&sid=9d9518057d4c0ef51be8c37d9… > - if (ret && (prev_x != new_x || prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y ); > + if (ret && (prev_x != new_x && prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y ); Obviously this is wrong. Something else is at fault here. Vitaliy.

2 1

Managing word agreements in PO translations?
by Frédéric Delanoy 22 Apr '11

22 Apr '11

Hi, In various languages, there are multiple forms/agreements for a pronoun/adjective. In French, for instance masculine and feminine forms exist; in other languages (like German IIRC) there's even a neutral form (other languages may also be more complicated) while agreements in English are limited, e.g. there's only one form for masculine/feminine/plural adjectives. This makes translating short English words problematic. In my case, I've a problem with the following PO entry #: comctl32.rc:44 crypt32.rc:198 progman.rc:78 winecfg.rc:76 msgid "None" According to context, it can be translated (in French) as either "Aucun" or "Aucune" (agreements on the same word). Admitedly, it could be translated with "Aucun(e)" but that seems more like a workaround and feels a bit weird (user shouldn't see partially incorrect/odd translations because of technical issues) OTOH, creating a distinct msgcontext for every agreement in every supported language may be overkill, although the number of affected msgids is limited. What's your opinion on how to handle that, folks? Frédéric Delanoy NB: This obviously posed no problem before the rc->po migration, since it was duplicated in different rc files

2 3

Re: d3d8: Attempting to set a NULL rt is legal in d3d8
by Henri Verbeet 22 Apr '11

22 Apr '11

Tests, please. Also, at least with the current code this is still going to fail because wined3d disallows setting RT0 to NULL.

3 4

Re: [2/2] wined3d: Scale the depthbias factor by the depth buffer's depth
by Henri Verbeet 22 Apr '11

22 Apr '11

On 22 April 2011 13:17, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + scale = 0; I thought you cared about the warnings MSVC generates for this kind of thing. :)

2 1

Instrumenting wined3d library
by Emanuele Oriani 22 Apr '11

22 Apr '11

Hi guys, I'd like to instrument wined3d in order to get to the bottom of the two issues with StarCraft II: - low FPS when we don't set affinity of all threads on one core - low FPS when shader level is > MEDIUM Which kind of function should I instrument? I've instrumented all the non static in 'context.c', 'buffer.c' and 'device.c', but I guess that I should instrument all the static function IWineD3DDeviceImpl_* in 'device.c', right? What kind of functions should I instrument? Cheers, Ema

2 1

Creating tests for rasapi32.dll
by Gerold Jens Wucherpfennig 22 Apr '11

22 Apr '11

Hi, I want to try to create some tests for rasapi32.dll. May I just create some tests and do the implementation later? For the time being that will mean that RASAPI32 tests will fail, because of missing code in rasapi.c. Is that OK? I haven't created DLL-tests yet... Regards Gerold

3 2

Re: [PATCH 5/5] ddraw: Destroy the ddraw surface after the wined3d texture is destroyed.
by Stefan Dösinger 21 Apr '11

21 Apr '11

Hi, I guess the obvious next step is to let wined3d manage the surface creation by getting rid of the CreateAdditionalSurface mess and let IWineD3DDeviceParent::CreateSurface handle this. I guess we should also get rid of the complex_array attachment list and handle those attachment by querying the wined3d container for the backbuffer or mipmap sublevel list. And while AddAttachedSurface mostly serves the function of SetDepthStencilSurface I'm afraid we won't be able to get rid of the manual attachment list - but we should probably replace it with a wine list(*) Anyway, thanks for cleaning up this mess. I feel guilty because I should have done this long ago :-/ Cheers, Stefan (*) I think I did that at some point, maybe is was another case of written but never finished patches. Or maybe I did this with some other surface list... On Wednesday 20 April 2011 22:09:27 Henri Verbeet wrote: > --- > dlls/ddraw/surface.c | 34 ++++++++++++++++++++++++++-------- > 1 files changed, 26 insertions(+), 8 deletions(-) > > diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c > index 16b831a..84082c5 100644 > --- a/dlls/ddraw/surface.c > +++ b/dlls/ddraw/surface.c > @@ -180,10 +180,13 @@ static ULONG WINAPI > ddraw_surface7_AddRef(IDirectDrawSurface7 *iface) > > TRACE("%p increasing refcount to %u.\n", This, refCount); > > - if (refCount == 1 && This->WineD3DSurface) > + if (refCount == 1) > { > EnterCriticalSection(&ddraw_cs); > - IWineD3DSurface_AddRef(This->WineD3DSurface); > + if (This->WineD3DSurface) > + IWineD3DSurface_AddRef(This->WineD3DSurface); > + if (This->wined3d_texture) > + wined3d_texture_incref(This->wined3d_texture); > LeaveCriticalSection(&ddraw_cs); > } > > @@ -256,9 +259,7 @@ static void > ddraw_surface_cleanup(IDirectDrawSurfaceImpl *surface) > > TRACE("surface %p.\n", surface); > > - if (surface->wined3d_texture) /* If it's a texture, destroy the > wined3d texture. */ - > wined3d_texture_decref(surface->wined3d_texture); > - else if (surface->wined3d_swapchain) > + if (surface->wined3d_swapchain) > { > IDirectDrawImpl *ddraw = surface->ddraw; > > @@ -388,7 +389,10 @@ static ULONG WINAPI > ddraw_surface7_Release(IDirectDrawSurface7 *iface) > LeaveCriticalSection(&ddraw_cs); > return ref; > } > - ddraw_surface_cleanup(This); > + if (This->wined3d_texture) /* If it's a texture, destroy the > wined3d texture. */ + > wined3d_texture_decref(This->wined3d_texture); > + else > + ddraw_surface_cleanup(This); > LeaveCriticalSection(&ddraw_cs); > } > > @@ -3491,6 +3495,20 @@ const struct wined3d_parent_ops > ddraw_surface_wined3d_parent_ops = ddraw_surface_wined3d_object_destroyed, > }; > > +static void STDMETHODCALLTYPE ddraw_texture_wined3d_object_destroyed(void > *parent) +{ > + IDirectDrawSurfaceImpl *surface = parent; > + > + TRACE("surface %p.\n", surface); > + > + ddraw_surface_cleanup(surface); > +} > + > +static const struct wined3d_parent_ops ddraw_texture_wined3d_parent_ops = > +{ > + ddraw_texture_wined3d_object_destroyed, > +}; > + > HRESULT ddraw_surface_create_texture(IDirectDrawSurfaceImpl *surface) > { > const DDSURFACEDESC2 *desc = &surface->surface_desc; > @@ -3513,10 +3531,10 @@ HRESULT > ddraw_surface_create_texture(IDirectDrawSurfaceImpl *surface) format = > PixelFormat_DD2WineD3D(&surface->surface_desc.u4.ddpfPixelFormat); if > (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP) > return > IWineD3DDevice_CreateCubeTexture(surface->ddraw->wineD3DDevice, > desc->dwWidth, - levels, 0, format, pool, surface, > &ddraw_null_wined3d_parent_ops, &surface->wined3d_texture); + > levels, 0, format, pool, surface, &ddraw_texture_wined3d_parent_ops, > &surface->wined3d_texture); else > return IWineD3DDevice_CreateTexture(surface->ddraw->wineD3DDevice, > desc->dwWidth, desc->dwHeight, - levels, 0, format, pool, > surface, &ddraw_null_wined3d_parent_ops, &surface->wined3d_texture); + > levels, 0, format, pool, surface, > &ddraw_texture_wined3d_parent_ops, &surface->wined3d_texture); } > > HRESULT ddraw_surface_init(IDirectDrawSurfaceImpl *surface, > IDirectDrawImpl *ddraw,

1 0

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.
by Alexandre Julliard 21 Apr '11

21 Apr '11

Charles Davis <cdavis(a)mymail.mines.edu> writes: > --- > dlls/kernel32/Makefile.in | 1 - > dlls/kernel32/oldconfig.c | 404 ------------------------------------------ > dlls/kernel32/process.c | 3 - > dlls/mountmgr.sys/hal.c | 116 ++++++++++++ > dlls/mountmgr.sys/mountmgr.c | 138 ++++++++++++++ > dlls/mountmgr.sys/mountmgr.h | 3 + > 6 files changed, 257 insertions(+), 408 deletions(-) > delete mode 100644 dlls/kernel32/oldconfig.c It doesn't seem to work here, I don't get any devices. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: winex11.drv: Ignore the zero-size owners used by Delphi apps when deciding whether to add NET_WM_STATE_SKIP_TASKBAR.
by Alexandre Julliard 21 Apr '11

21 Apr '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch reverts a part of 61e50e15ba45ad54655f98619f5ef33917033165 and > fixes the regression reported in the bug 26670. This will cause spurious task bar entries in many apps. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::append(size_t, char) implementation.
by Piotr Caban 21 Apr '11

21 Apr '11

Hi, On 04/18/11 23:53, Vincas Miliūnas wrote: > My remark: (The method is implemented by reusing existing code) this->size+count<this->size is the same as count< 0 and throwing a "string too long" exception in that case is not semantic. count is an unsigned variable so it cannot be smaller then 0. My intention was to make sure there's no overflow. This check is not needed because MSVCP_basic_string_char_npos-this->size <= count already makes sure this->size+count has small enough value. +basic_string_wchar* __thiscall MSVCP_basic_string_wchar_append_len_wchar( + basic_string_wchar *this, size_t count, wchar_t c) +{ + TRACE("%p %lu %lc\n", this, (unsigned long)count, c); It's probably not allowed to use %lc format. Cheers, Piotr

2 1

Re: d3dxof/tests: Make expected value in string and comparison match.
by Marvin 20 Apr '11

20 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10525 Your paranoid android. === WVISTAADM (32 bit d3dxof) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: msvcrt: Added _resetstkoflw implementation
by Alexandre Julliard 20 Apr '11

20 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +/********************************************************************* > + * _resetstkoflw (MSVCRT.@) > + */ > +int CDECL _resetstkoflw(void) > +{ > + MEMORY_BASIC_INFORMATION mbi; > + SYSTEM_INFO info; > + DWORD prot; > + void *alloc; > + > + GetSystemInfo(&info); > + if(!VirtualQuery(&mbi, &mbi, sizeof(mbi))) > + return 0; > + > + alloc = VirtualAlloc((char*)mbi.BaseAddress, info.dwPageSize, MEM_COMMIT, PAGE_READWRITE); > + if(!alloc) > + return 0; > + > + return VirtualProtect(alloc, info.dwPageSize, PAGE_GUARD|PAGE_READWRITE, &prot); This doesn't make sense to me, why do you need a VirtualAlloc in there? And what about the limits in the TEB? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 03/10] msvcrt: Use callback based printf in fprintf functions family (try2)
by Alexandre Julliard 19 Apr '11

19 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/file.c | 118 > ++++++++++------------------------------------------ > 1 files changed, 22 insertions(+), 96 deletions(-) This one is causing console apps to output null characters. You'll have to spend more time on this patch series, it doesn't seem quite ready. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add rmxftmpl.h with contents generated from rmxftmpl.x.
by Alexandre Julliard 19 Apr '11

19 Apr '11

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > +#ifndef __WINE_RMXFTMPL_H > +#define __WINE_RMXFTMPL_H > + > +/* sizeof(D3DRM_XTEMPLATES) */ > +#define D3DRM_XTEMPLATE_BYTES 3278 > + > +/* Contents of D3DRM_XTEMPLATES generated using: > + * ../tools/binencxftmpl rmxftmpl.x | xxd -i > + */ You should generate the whole file, it shouldn't need to be updated by hand. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: serial: Fix race for IOCTL_SERIAL_WAIT_ON_MASK
by Alexandre Julliard 19 Apr '11

19 Apr '11

Wolfgang Walter <wolfgang.walter(a)stwm.de> writes: > set status field of piosb to STATUS_PENDING before calling wait_on(). If wait_on > returns with STATUS_PENDING don't touch piosb. > > Reason: if wait_on returns with STATUS_PENDING it started a thread which > itself modifies the status field. In general the iosb is not modified until the operation completes. -- Alexandre Julliard julliard(a)winehq.org

2 3

Cairo Graphics
by Jaime Rave 19 Apr '11

19 Apr '11

Hey Guys, On some of the bugs that i have reported to freedesktop, i have been asked about why Wine is making calls like XDrawSegmentand not using Cairo to handle the 2d drawing which always provides consistent behavior regardless of drivers[1]. I have also read that cairo support "X Window System, Quartz, Win32, image buffers, PostScript, PDF, and SVG file output. Experimental backends includeOpenGL <http://www.cairographics.org/OpenGL/>, XCB, BeOS, OS/2, and DirectFB"[2]. So it will also works with Wayland when this is ready :D. So i think this is a good way to make Wine more graphic driver agnostic and improve the behavior on MacOS without having to write a complete new driver just for Quartz. So i would like to know your thoughts, if Cairo could improve some stuff or if is not related or useless to the project Greetings Jaime Rave [1] https://bugs.freedesktop.org/show_bug.cgi?id=22770#c14 [2] http://www.cairographics.org/

2 1

Re: [PATCH 06/10] msvcrt: Added sprintf_p_l implementation (try2)
by Alexandre Julliard 19 Apr '11

19 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -552,6 +552,74 @@ int FUNC_NAME(pf_printf)(FUNC_NAME(puts_clbk) pf_puts, void *puts_ctx, const API > return written; > } > > +#ifndef PRINTF_WIDE > +/* This functions stores sizes of arguments. It uses args[0] > + * internally (in the following way): > + * 0x1 - using positional parameters > + * 0x2 - not using positional parameters > + * 0x4 - error occurred > + */ > +static printf_arg arg_clbk_size(void *ctx, int pos, int type, __ms_va_list *valist) > +{ > + static const printf_arg ret; > + printf_arg *args = ctx; > + > + if(pos == -1) { > + args[0].get_int |= 1; > + return ret; > + } else > + args[0].get_int |= 2; > + > + if(pos<1 || pos>MSVCRT__ARGMAX || (args[pos].get_int && args[pos].get_int!=type)) > + args[0].get_int |= 4; > + else > + args[pos].get_int = type; > + return ret; > +} Using magic values like this is ugly, please add proper defines. Also you probably want to fix the name of the function and the comments. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] Fix SystemProcessorPerformanceInformation to include DPC and Interrupt times
by Alexandre Julliard 19 Apr '11

19 Apr '11

"Ray Hinchliffe (RH)" <ray(a)rh-software.com> writes: > 1) When possible report DPC and Interrupt times > > 2) Fix _APPLE_ to return times in 100ns units and zero the unset members > > 3) Change the failure code to return 100ns values > > 4) Expunge unnecessary use of RtlAllocateHeap() etc.. Separate changes should be separate patches. > @@ -1241,8 +1241,9 @@ typedef struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION { > LARGE_INTEGER IdleTime; > LARGE_INTEGER KernelTime; > LARGE_INTEGER UserTime; > - LARGE_INTEGER Reserved1[2]; > - ULONG Reserved2; > + LARGE_INTEGER DpcTime; > + LARGE_INTEGER IntTime; > + ULONG IntCount; You can't change the public definition. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: psapi: Forward EmptyWorkingSet implementation to kernel32
by Dmitry Timoshkov 19 Apr '11

19 Apr '11

Jacek Caban <jacek(a)codeweavers.com> wrote: > +BOOL WINAPI K32EmptyWorkingSet(HANDLE hProcess) > +{ > + return SetProcessWorkingSetSize(hProcess, (SIZE_T)-1, (SIZE_T)-1); > +} You need to export it from kernel32. Also using ~0 instead of casting -1 would be better IMHO. -- Dmitry.

2 1

re: Cairo Graphics
by Dan Kegel 19 Apr '11

19 Apr '11

Wrappers like Cairo Graphics, Phonon, and OpenAL sound nice, but can get in the way of reliably reproducing win32 behavior.

1 0

Re: Patch to fix GetThreadTimes() to work for all threads - fixes Bug 20230
by Vitaliy Margolen 19 Apr '11

19 Apr '11

On 04/18/2011 12:45 AM, Ray Hinchliffe (RH) wrote: > The patch works by reading from /proc/<pid>/task/<tid>/stat. If this in not > possible it will report the fix messages as before. > Given that SystemProcessorPerformanceInformation uses /proc/stat I expect this Thanks for the patch, however there are several issues with it: - Don't attach changes to automatically generated files (server/trace.c, server/request.h, etc). Only server/protocol.def should be included, which you didn't even modify. - Keep formatting of the original file you modifying. No whitespace only changes, no funky new formatting styles. - Please use Windows types instead of system types for integers (ULONG instead of unsigned long) > + sprintf( buf, "/proc/%u/task/%u/stat", reply->unix_pid, reply->unix_tid ); Please don't call any functions in the server call context. Also you not using this buffer if server call fails, or if the thread is the same. Vitaliy.

1 0

How to debug steam based games
by Brock York 19 Apr '11

19 Apr '11

Hey I was wondering how/what is the best approach to debug steam games under wine. If I launch the actual exe file in the steam folders of the game it just just opens and runs steam then killing the process I launched then actually launching the game. The only way I've found to get any useful output is to launch steam itself from the command line with the debugging options enabled there. Is this the only way to get debugging information from steam games without cracking them? Thanks Regards Brock

2 1

Re: ntdll: Add Windows XP x64
by Alexandre Julliard 18 Apr '11

18 Apr '11

Ken Sharp <kennybobs(a)o2.co.uk> writes: > Windows XP x64 has an updated kernel to XP, so just setting XP in > winecfg will still cause apps to fail. IE8 for XP x64 is an example. This should most likely be done automatically on 64-bit. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: wintrust: Implement IsCatalogFile
by Austin English 18 Apr '11

18 Apr '11

On Sat, Apr 16, 2011 at 12:34, Juan Lang <juan.lang(a)gmail.com> wrote: > Since I didn't see an updated patch from Austin, here's what I think > should suffice. Without knowing the app that depends on it, I can't > be certain. Sorry, I had a busy weekend, thanks for fixing it. It works great here! -- -Austin

1 0

Re: serial: improve handling of usb2serial adapters
by Austin English 18 Apr '11

18 Apr '11

2011/4/18 Wolfgang Walter <wolfgang.walter(a)stwm.de>: Please, one patch per email. Thanks for helping Wine! -- -Austin

1 0

Can someone ban tiaotiao (tiaotiao213@hotmail.com -- link spammer) <EOM>
by Reece Dunn 18 Apr '11

18 Apr '11

1 0

DEC Alpha Support
by André Hentschel 18 Apr '11

18 Apr '11

Hi all, i would like to remove the remaining Alpha support code, because of all our ports Alpha is the most incomplete and it seems it has no chance to get some love. Further Alpha chips aren't produced anymore since years AFAIK. Any Objections? -- Best Regards, André Hentschel

1 0

Re: ntdll: Remove more path trailing chars. (try 2)
by Alexandre Julliard 18 Apr '11

18 Apr '11

Vincent Pelletier <plr.vincent(a)gmail.com> writes: > Add tests via FindFirstFileA. You need tests for the low-level ntdll functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 02/10] msvcrt: Use callback based printf in cprintf functions family
by Alexandre Julliard 18 Apr '11

18 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > +printf_arg arg_clbk_valist(void *ctx, int arg_pos, size_t size, __ms_va_list *valist) > +{ > + printf_arg ret; > + > + if(size == sizeof(LONGLONG)) > + ret.get_longlong = va_arg(*valist, LONGLONG); > + else if(size == sizeof(int)) > + ret.get_int = va_arg(*valist, int); > + else { > + ERR("Incorrect size\n"); > + ret.get_int = 0; > + } You can't do that, you need to use the correct type in va_arg. Different types can be passed differently even if they have the same size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] Fix d3dx9_parse_effect_typedef for stuctures.
by Rico Schüller 18 Apr '11

18 Apr '11

The patch has the wrong description, I'll fix and resend that. Am 18.04.2011 10:26, schrieb Rico Schüller: > --- > dlls/d3dx9_36/effect.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > >

1 0

Re: Fix to bug 25504 for gnutls based schannel
by Hans Leidekker 18 Apr '11

18 Apr '11

On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote: > #ifdef SONAME_LIBGNUTLS > #include <gnutls/gnutls.h> > +#include <gcrypt.h> > +#include <pthread.h> > +#include <errno.h> > +GCRY_THREAD_OPTION_PTHREAD_IMPL; You should add a separate configure check for libgcrypt. Use of pthreads reveals an implementation detail of Wine threads, I think it would be cleaner to supply Win32 implementations of the locking functions via GCRY_THREAD_OPTION_USER.

5 6

Re: Wine: Use the compiler option -Wpointer-arith if available.
by Michael Stefaniuc 17 Apr '11

17 Apr '11

On 04/17/2011 01:19 AM, Gerald Pfeifer wrote: > GCC provides an option -Wpointer-arith and describes it as follows: > > Warn about anything that depends on the "size of" a function type > or of `void'. GNU C assigns these types a size of 1, for > convenience in calculations with `void *' pointers and pointers to > functions. > > This does not trigger on my Wine builds, but then we should not invoke Of course it doesn't triggers in Wine as -Wpointer-arith is already enabled. I made heavy use of that when I did my pointer cast killing spree a few years ago. > sizeof(void) or sizeof(some_function). ;-) It should help catch any > such bad future uses of sizeof. > > Gerald > --- > configure.ac | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6047744..0ae6625 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1715,6 +1715,7 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > + WINE_TRY_CFLAGS([-Wpointer-arith]) > WINE_TRY_CFLAGS([-Wstrict-prototypes]) > WINE_TRY_CFLAGS([-Wtype-limits]) > WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) bye michael

2 1

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs
by Gerold Jens Wucherpfennig 17 Apr '11

17 Apr '11

Getting symbol names and ordinal numbers from Windows DLLs for Wine DLLs. I think it's not allowed to do a "winedump <dllname>.lib" But what to do else? Regards Gerold

3 3

Re: crypt32: Fix length-handling of 'decodeBase64Block'
by Marvin 16 Apr '11

16 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10497 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

RAS.h
by Gerold Jens Wucherpfennig 16 Apr '11

16 Apr '11

Hi, I want to complete the rasapi32.dll, but the header file RAS.h of wine is incomplete. It hasn't been changed since 1998. >From where may I copy the missing parts? >From the Windows SDK documentation? I think I may not be allowed to directly copy it from Windows' ras.h Best Regards Gerold

2 1

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig 16 Apr '11

16 Apr '11

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

2 1

Windres and wine
by Gerold Jens Wucherpfennig 16 Apr '11

16 Apr '11

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

2 1

Re: inetcpl: Update French translation
by Nicolas Le Cam 15 Apr '11

15 Apr '11

Hi Frédéric, Le 13 avril 2011 23:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > --- > dlls/inetcpl.cpl/cpl_Fr.rc | 42 > +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 41 insertions(+), 1 deletions(-) > > diff --git a/dlls/inetcpl.cpl/cpl_Fr.rc b/dlls/inetcpl.cpl/cpl_Fr.rc > index 1244ff6..432a8c3 100644 > --- a/dlls/inetcpl.cpl/cpl_Fr.rc > +++ b/dlls/inetcpl.cpl/cpl_Fr.rc > @@ -2,7 +2,7 @@ > * Internet control panel applet > * French language support > * > - * Copyright 2010 Frédéric Delanoy > + * Copyright 2010-2011 Frédéric Delanoy > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -49,6 +49,46 @@ BEGIN > > END > > +/* "Delete browsing history" dialog */ > +IDD_DELETE_HISTORY DIALOG 0, 0, 250, 250 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +FONT 8, "MS Shell Dlg" > +CAPTION "Effacer l'historique de navigation" > +BEGIN > + > + AUTOCHECKBOX "Fichiers internet temporaires\nCopies en cache de > pages web, d'images et de certificats.", > + IDC_DELETE_TEMP_FILES, 10, 8, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Cookies\nFichiers sauvés sur votre ordinateur par des > sites web, qui y stockent des informations comme des préférences utilisateur > et des informations de connexion", > You should use sauvegardés instead of sauvés which doesn't apply to computers. I would also use "qui y stockent des choses comme les préférences utilisateurs et les informations de connexion". It better follows the original text and avoid a repetition. > + IDC_DELETE_COOKIES, 10, 32, 230, 35, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Historique\nListe des sites web accédés.", > + IDC_DELETE_HISTORY, 10, 73, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Données de formulaires\nNoms d'utilisateur et autres > informations entrées dans des formulaires.", > + IDC_DELETE_FORM_DATA, 10, 98, 230, 30, BS_TOP | > BS_MULTILINE > + AUTOCHECKBOX "Mots de passe\nMots de passe entrés dans des > formulaires et sauvegardés.", > + IDC_DELETE_PASSWORDS, 10, 128, 230, 30, BS_TOP | > BS_MULTILINE > + DEFPUSHBUTTON "Annuler", IDCANCEL, 185, 228, 60, 15, WS_GROUP > + PUSHBUTTON "Effacer", IDOK, 120, 228, 60, 15, WS_GROUP > + > +END > + > +/* "Security" propsheet */ > +IDD_SECURITY DIALOG 0, 0, 320, 220 > +STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > +FONT 8, "MS Shell Dlg" > +CAPTION "Security" > +BEGIN > + > + CONTROL "Listview", IDC_SEC_LISTVIEW, "SysListView32", > + LVS_ICON | LVS_ALIGNLEFT | LVS_AUTOARRANGE | LVS_SINGLESEL > | LVS_SHOWSELALWAYS | WS_BORDER | WS_VSCROLL, > + 4, 4, 312, 58 > + LTEXT "", IDC_SEC_ZONE_INFO, 4, 68, 312, 20 > + GROUPBOX "", IDC_SEC_GROUP, 4, 88, 312, 126 > + CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > + TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > + LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > + LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > +END > + > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > -- > 1.7.4.3 > > > > -- Nicolas Le Cam

3 2

W and A functions in wine DLLs
by Gerold Jens Wucherpfennig 15 Apr '11

15 Apr '11

Hi, I just want to know how to implement functions in a DLL. If I remember correctly I should implement the W function and call it in the implementation of the A function. Do I have to do some string manipulation functions in the A function? I'm looking forward to reading from you. Best Regards, Gerold

1 0

Re: winedevice: eliminate some globals
by Alexandre Julliard 15 Apr '11

15 Apr '11

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * winedevice: eliminate some globals > > The long term goal of this patch is to make the driver loading code > reusable for loading drivers outside winedevice, for use with USB > drivers etc. It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:944: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffff, err=2, should be 0 file.c:931: Tests skipped: Either no authority to volume, or is todo_wine for \\?\C:\ err=5 should be 3 file.c:1000: Test failed: CreateFileA did not open \\?\C:, last error=2 file.c:1059: Test failed: CreateFileA did not open \\.\C:, last error=2 file.c:1078: Test failed: GetVolumeNameForVolumeMountPointA failed, for C:\, last error=2 file.c:1157: Test failed: GetVolumeNameForVolumeMountPointA not functioning make: *** [file.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Windres and wine
by Gerold Jens Wucherpfennig 15 Apr '11

15 Apr '11

Hi, I have created GUI dialog with ResEdit. That rc-file shall be used in wine. The problem is that wine doesn't have a Windres.exe. Is it possible to make a c-file from the rc-file? Best Regards Gerold

1 0

Quartz Driver patches (NOT for inclusion in Wine)
by Charles Davis 15 Apr '11

15 Apr '11

Hi, A while ago, I started work on my own Quartz Driver. This was before I finished my "Deobjectivizer" tool, so only some of the pure Quartz stuff (no Cocoa) is implemented. My intent after finishing "Deobjectivizer" was to start implementing windowing and other vital pieces of the driver (i.e. the pieces that need Cocoa to work). I know now that CodeWeavers is working on their own version of the Quartz Driver. So, I don't need to continue working on this. That's why I've decided to post all of my Quartz Driver patches here, on the off-chance that CW may wish to use some of them. They are all licensed under the LGPL 2.1, the same license as Wine itself. If they don't want to use any of them, that's OK. I just thought we could get this done faster if we took some of the work that I and others have done. If this is the wrong place to post this, I apologize, and I would really appreciate a pointer in the right direction. Chip

1 0

Try to implement my first stub function - AbortPrinter() - (try 4)
by Loïc Maury 15 Apr '11

15 Apr '11

Hello, From what was said from the last comments, I have modified the code and I have added the test patch. What do you think ? Thank you Loïc

2 2

RE: winex11: Retrieve raw mouse events through XInput2 while the cursor is clipped.
by Vitaliy Margolen 15 Apr '11

15 Apr '11

It's great to see so much progress in this area! Great gob so far. However this isn't enough. Cursor doesn't have to be clipped to receive mouse event's. As far as dinput goes, it will read mouse events regardless where the pointer is if device is acquired in background mode. Or this isn't the final commit yet? Vitaliy.

2 1

Re: wintrust: add a stub for IsCatalogFile()
by Juan Lang 14 Apr '11

14 Apr '11

Hi Austin, it wouldn't be hard to implement this with CryptSIPRetrieveSubjectGuid: if it returns the GUID for .cat files, return TRUE. --Juan

1 0

Re: [PATCH] Allow for RPC_S_NO_CONTEXT_AVAILABLE return status
by Alexandre Julliard 14 Apr '11

14 Apr '11

"Ray Hinchliffe (RH)" <ray(a)rh-software.com> writes: > @@ -196,7 +196,8 @@ static RpcPktHdr *handle_bind_error(RpcConnection *conn, RPC_STATUS error) > default: > FIXME("unexpected status value %d\n", error); > /* fall through */ > - case RPC_S_INVALID_BOUND: > + case RPC_S_INVALID_BOUND: > + case RPC_S_NO_CONTEXT_AVAILABLE: > reject_reason = REJECT_REASON_NOT_SPECIFIED; > break; Please explain why this happens and why this is the right error to return. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging wine itself with GDB
by joedude＠winedev1.nospam.homeip.net 13 Apr '11

13 Apr '11

I was taking a look at http://wiki.jswindle.com/index.php/Debugging_Wine to see how to debug wine with gdb, and there was reference to starting up gdb using wine-pthread, but I see no such executable now. I can attach gdb after it starts to run, but then do not get all the symbol information. There is wine-preloader but it seems to want an ELF file as an argument.

2 1

massively "skipped" tests being shown
by Saulius Krasuckas 13 Apr '11

13 Apr '11

Hello, there is something wrong with WRT result page/parser [1] (or with TestBot too) since yesterday. All tests' results from TestBot are shown as "skipped by user request", eg. for XP [2]. Results from physical machines are present, currently only one (af-xpsp3-nv) which shows 12 failures. But in the daily summary we see 28 failures for XP. [3] Sounds like a bug or two:) S. [1] http://test.winehq.org/data/ [2] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/index_… [3] http://test.winehq.org/data/e5c3883c923d345848315a39a090607bdddac936/

2 1

Re: [PATCH 2/4] inetcpl: Fill the security listview with zones
by Nikolay Sivov 13 Apr '11

13 Apr '11

Some minor things regarding listview. On Wed, Apr 13, 2011 at 7:33 AM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > --- > dlls/inetcpl.cpl/security.c | 131 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 131 insertions(+), 0 deletions(-) > > +static void add_zone_to_listview(secdlg_data *sd, DWORD *pindex, DWORD zone) > +{ > + DWORD lv_index = *pindex; > + ZONEATTRIBUTES *za = &sd->zone_attr[lv_index]; > + LVITEMW lvitem; > + HRESULT hr; > + INT iconid = 0; > + HMODULE hdll = NULL; > + WCHAR * ptr; > + HICON icon; > + > + TRACE("item %d (zone %d)\n", lv_index, zone); > + > + sd->zones[lv_index] = zone; > + > + memset(&lvitem, 0, sizeof(LVITEMW)); This reset shouldn't be needed, cause control checks for mask field and doesn't access other fields. > + > + if (ListView_InsertItemW(sd->hlv, &lvitem) >= 0) { > + /* activate first item in the listview */ > + if (! lv_index) { > + lvitem.state = LVIS_FOCUSED | LVIS_SELECTED; > + lvitem.stateMask = LVIS_FOCUSED | LVIS_SELECTED; > + SendMessageW(sd->hlv, LVM_SETITEMSTATE, 0, (LPARAM) &lvitem); > + } > + SendMessageW(sd->hlv, LVM_SETIMAGELIST, LVSIL_NORMAL, (LPARAM)sd->himages); > + You could use macros here too, if you prefer that.

1 0

po: Update US English resource
by Ken Sharp 13 Apr '11

13 Apr '11

http://www.winehq.org/pipermail/wine-devel/2011-April/089585.html (I lost the original mail - along with a bunch of others) I'm confused as to what the .po files are for. ise/ize will be correct if the .rc file default is British English. Without updating the .po file for US English I don't see how else this can be updated - unless it is simply the way it was before with LANG_ and SUBLANG_, but then what are the .po files for? I can't find any details in the Wiki and I'm afraid I wasn't around when they were introduced...

1 0

ntdll: Add support for Windows XP 64-bit
by Ken Sharp 13 Apr '11

13 Apr '11

Morning all, Could someone far smarter than me please take a look at the attached patch? Windows XP 64-bit runs NT kernel 5.2, whereas 32-bit runs 5.1. Any 64-bit app expecting XP 64-bit will fail (such as IE8 for NT 5.2). The patch lets the installer continue, but I'm not sure if it is enough to be accepted. For example, do I need to "winxp,winxp64", here? http://source.winehq.org/source/dlls/ntdll/version.c?v=wine-1.3.17#L172 TIA, Ken.

1 0

Re: wined3d: Track when the FBO is dirty. (try 3)
by Henri Verbeet 12 Apr '11

12 Apr '11

On 7 April 2011 18:51, Adam Martinson <amartinson(a)codeweavers.com> wrote: > - context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + > + if (rt_count == device->adapter->gl_info.limits.buffers && > + rts == device->render_targets && > + depth_stencil == device->depth_stencil) > + { > + if (context->device_fbo != NULL) > + { > + context_apply_device_fbo(context); > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; > + } > + } > + else > + { > + context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + } That's not very pretty. > @@ -6709,6 +6721,7 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as render target %u.\n", surface, i); > device->render_targets[i] = NULL; > + fbo_dirty = TRUE; > } > } > > @@ -6716,7 +6729,10 @@ void device_resource_released(struct IWineD3DDeviceImpl *device, struct wined3d_ > { > ERR("Surface %p is still in use as depth/stencil buffer.\n", surface); > device->depth_stencil = NULL; > + fbo_dirty = TRUE; That code should never execute, hence the ERR.

2 3

Re: [2/2] comctl32/tab: Use dpa to store item data
by Henri Verbeet 12 Apr '11

12 Apr '11

On 10 April 2011 07:56, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Use dpa to store item data > This seems to break text on winecfg tabs for me.

3 4

Re: user32: Fix the single menu item activation using a hot key.
by Marvin 12 Apr '11

12 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10449 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

__CxxFrameHandler unsupported on wine64?
by Peter Urbanec 12 Apr '11

12 Apr '11

I have an application that requires MFC80.DLL. When I install only the MFC80.DLL file from the vcredist package, I end up with the following errors: wine: Call from 0x7fd606a3148b to unimplemented function MSVCR80.dll.__CxxFrameHandler, aborting So, I had a quick look at the wine source and found a comment in dlls/msvcrt/cppexcept.c that says: /* CxxFrameHandler is not supported on non-i386 */ I don't think that this is quite right, given that Microsoft's MFC80.DLL attempts to call __CxxFrameHandler. Is it more likely that wine only provides an i386 implementation? If so, is there any chance that someone may be able to provide x86_64 implementation in the near future? It's way over my head :-( Best regards, Peter Urbanec

2 1

Re: [3/3] wined3d: only acquire a context in buffer::PreLoad if we have to
by Henri Verbeet 12 Apr '11

12 Apr '11

You can't just resend this unmodified if you're leaving buffer creation in.

2 1

Re: [PATCH 4/4] d3d9: COM cleanup for the IDirect3DSwapChain9 iface.
by Michael Stefaniuc 12 Apr '11

12 Apr '11

Please ignore this patch for now as it conflicts with Henri's patch. bye michael On 04/12/2011 10:23 AM, Michael Stefaniuc wrote: > --- > dlls/d3d9/d3d9_private.h | 7 ++--- > dlls/d3d9/device.c | 8 +++--- > dlls/d3d9/swapchain.c | 61 ++++++++++++++++++++++++++++++---------------- > 3 files changed, 47 insertions(+), 29 deletions(-)

1 0

Re: dbghelp: get rid of a couple unused variables (try 2)
by Eric Pouech 11 Apr '11

11 Apr '11

Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: dbghelp: get rid of a couple unused variables
by Andrew Nguyen 11 Apr '11

11 Apr '11

On 04/11/2011 12:41 AM, Austin English wrote: > This ignores the side effects of the dwarf2_parse_u2 function.

2 1

Re: gdi32/dibdrv: The dib debug channel is unused so remove it.
by Huw Davies 11 Apr '11

11 Apr '11

On Sun, Apr 10, 2011 at 06:45:51PM +0200, Francois Gouget wrote: > It might get used soon but then it's easy to add back anyway. Very soon in fact - it gets used in the PatBlt patch I just sent ;-)

1 0

Re: d3dx9_36: Make get_parameter_{handle,struct}() static.
by luis.busquets＠ilidium.com 11 Apr '11

11 Apr '11

Shouldn't this be inline? > --- > dlls/d3dx9_36/effect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 1e3de0c..a03e8a3 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -91,12 +91,12 @@ static void skip_dword_unknown(const char **ptr, > unsigned int count) > } > } > > -struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > +static struct d3dx_parameter *get_parameter_struct(D3DXHANDLE handle) > { > return (struct d3dx_parameter *) handle; > } > > -D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > +static D3DXHANDLE get_parameter_handle(struct d3dx_parameter *parameter) > { > return (D3DXHANDLE) parameter; > } > -- > 1.7.4.1 > > > >

1 0

Ubuntu's new UI has glitches that affect Wine...
by Dan Kegel 11 Apr '11

11 Apr '11

Ubuntu 11.04 beta 1 is out, http://www.ubuntu.com/testing/natty/beta There are aleady about six bug reports about how its new UI interacts with Wine: https://launchpad.net/ubuntu/+bugs?field.searchtext=unity+wine If you're an ubuntu user, please try out Natty Beta, review those bugs, and vote for the ones that affect you. And file more if you find any! - Dan

1 1

Introducing "Deobjectivizer"
by Charles Davis 11 Apr '11

11 Apr '11

Hi, I've been working on a secret Clang-based project for a while, and now I'm ready to share it with the world. Introducing the "Deobjectivizer". This is a program that scans framework bundle headers for Objective-C constructs, and generates procedural C wrappers around them, so you can call them from C. It uses Clang's libraries to parse, analyze, and rewrite Objective-C headers into pure C headers, and then generate corresponding source files containing the wrapper implementations. The implementation of this tool is a little hackish at the moment, but it suffices to generate a wrapper around the entire Foundation framework (at least). With this, we don't have to use Objective-C just to use Cocoa anymore. The Mac OS X Quartz driver can go forward now! The QuickTime decoder can use QTKit now instead of the 32-bit only Carbon QuickTime interface, allowing it to work on 64-bit (if and when Wine supports it on Mac). It might even be possible to integrate Win32 screen-savers with Mac OS X using this (the ScreenSaver framework is Objective-C based). I've attached the source so you can play with my newest creation. At the moment, it can only be built on Mac OS X (only one of two platforms, the other being iOS, where a program like this makes sense anyway). Feel free to make changes; the sources are licensed under the same license as Clang itself. We can't incorporate it into Wine directly because it is written in C++ (and maybe because of the license), but we can detect its presence at compile time (in configure) and use it to generate pure C wrappers that Wine can use. Comments welcome. What do you think? Chip

1 0

Re: gdiplus: Make get_font_hfont() static.
by Vincent Povirk 10 Apr '11

10 Apr '11

I'm planning to use this from GdipAddPathString. On Sun, Apr 10, 2011 at 11:45 AM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 2 -- > dlls/gdiplus/graphics.c | 2 +- > 2 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 1629ae6..bfa33ef 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -58,8 +58,6 @@ extern void calc_curve_bezier_endp(REAL xend, REAL yend, REAL xadj, REAL yadj, > > extern void free_installed_fonts(void); > > -extern void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont); > - > extern BOOL lengthen_path(GpPath *path, INT len); > > extern GpStatus trace_path(GpGraphics *graphics, GpPath *path); > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 336929f..6a5ef7f 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -1654,7 +1654,7 @@ end: > return stat; > } > > -void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > +static void get_font_hfont(GpGraphics *graphics, GDIPCONST GpFont *font, HFONT *hfont) > { > HDC hdc = CreateCompatibleDC(0); > GpPointF pt[3]; > -- > 1.7.4.1 > > > >

1 0

Try to implement my first stub function - AbortPrinter() - (try 3)
by Loïc Maury 10 Apr '11

10 Apr '11

Hello, I try always to implement my first stub function - AbortPrinter. The last time, I send into Wine patch mailling list, but the patch was not correct. Now I think the format for the patch is correct (no whitespace, etc…). More over, I have modified the value if(!job->portname) by if(!portname), because after the test "if(!job->portname)", I print trace of portname, but before he was initialized into the "if condition" and can to not enter into this condition. What do you think ? Thank you Loïc

3 3

Fwd: d3dx9_36 [patch 1/3; try 9]: Remove useless includes
by David Adam 10 Apr '11

10 Apr '11

Any feedback for the reasons why this patch and the following ones were not commited? Thanks in advance A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2011/4/6 Subject: d3dx9_36 [patch 1/3; try 9]: Remove useless includes To: wine-patches <wine-patches(a)winehq.org>

1 0

Must multimedia players check the message queue and invoke DispatchMessage?
by Joerg-Cyril.Hoehle＠t-systems.com 10 Apr '11

10 Apr '11

Hi, In Bug #3930 http://bugs.winehq.org/show_bug.cgi?id=3930#c41 I conjectured that: 1. Since w2k, winmm hijacks the application's thread to play multimedia content. Wine does this as well with MCI_WAIT, but it should as well affect winmm:playSound, winmm:midi* and winmm:wave*. 2. Consequently, the players must implement a message loop and dispatch regular window messages using DispatchMessageA/W Currently, Wine does not. This IMHO has potential for dead locks. Music and animations can play for a long time and messages ought to be serviced. I'm not familiar with windows messages at all. What do you think about the consequence? Point 1 explains why tests reveal the current thread as the one executing all callbacks but one since w2k. Point 2 should be testable by playing a long piece of video or music and prequeuing or injecting (how?) some windows events. How to test this in a convincing manner? Would the obligation to service messages disappear if the players ran in their own thread (like w9x seems to do)? Thanks for your help, Jörg Höhle

5 8

Project: x86 to ARM binary translator
by Yale Zhang 09 Apr '11

09 Apr '11

Fellow developers, I'm thinking of starting a VM project to allow running x86 Windows apps on ARM Android. This will obviously involve binary translation. I've read about QEMU's tiny code generator and think for a usable experience, the intermediate micro-op representation will have to be abandoned, and use a more efficient, though less portable x86 to ARM translator. I also saw some Google SOC project that tried to incorporate LLVM into QEMU, but with disastrous slow down if done naively. I still think it's worth to do so, but lots of care will need to be done to only optimize code that needs it like Sun's HotSpot Java compiler does. Questions: 1. How useful would this be and how much interest? Obviously, this will be a huge project, and I just want to gauge the interest before I jump in. Microsoft will be releasing Windows for ARM soon, so there will be no need to worry about running Office, Matlab, Visual C++, etc on ARM, leaving only legacy applications and games to benefit from binary translation. I'm mostly interested in seeing some 3D games run on my Xoom. 2. What's the best design: whole system VM (qemu) or process VM (qemu & wine)? Process VM: + easier to incorporate 3D acceleration at API level + uses less memory + better performance (e.g. no need for MMU translation when accessing memory) + much better integration with host OS - needs to maintain custom Windows API implementation (Wine) Whole system VM: + simpler, more unified to implement + much better support for apps that are dependent on new, proprietary, obscure Windows libraries, interfaces (moot because Office, Matlab, etc will soon be available for ARM) Given the aims of only running legacy applications and games, it seems a foregone conclusion that Wine's process VM approach is best. Comments? 3. Will Wine ever incorporate binary translation? My proposed design will obviously use Wine's implementation of the Windows API, which is huge. I'm not sure how disruptive of a change binary translation will be to Wine. If Wine does incorporate binary translation, maybe they can change the name to Wine Is Now an Emulator If your're interested in this project, please reply.

6 7

Re: [PATCH 4/5] wined3d: Merge the IWineD3DSwapChain::Destroy() implementations.
by Alexandre Julliard 08 Apr '11

08 Apr '11

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > They're mostly the same, except for the GL version also destroying its > contexts, and being a bit more careful about the order in which backbuffers > are destroyed. > --- > dlls/wined3d/swapchain.c | 175 ++++++++++++++++----------------------------- > 1 files changed, 62 insertions(+), 113 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddrawmodes.c && touch ddrawmodes.ok wine: Unhandled page fault on read access to 0x00000f2c at address 0x687550fa (thread 0021), starting debugger... Unhandled exception: page fault on read access to 0x00000f2c in 32-bit code (0x687550fa). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:687550fa ESP:0032f910 EBP:0032f948 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000021 EBX:6884b244 ECX:00110064 EDX:00000000 ESI:00000000 EDI:00000001 Stack dump: 0x0032f910: 00001302 00131ef0 00000000 00000000 0x0032f920: 00000000 00000000 00000000 00110014 0x0032f930: 0000ff00 000000ff 687550db 6884b244 0x0032f940: 00131848 00000001 0032f9a8 6880052b 0x0032f950: 00134d58 00000000 00131ef0 7bc73cfc 0x0032f960: 00000002 00129f28 00000000 000004b0 Backtrace: =>0 0x687550fa context_destroy+0x2a(This=0x134d58, context=(nil)) [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d (0x0032f948) 1 0x6880052b IWineD3DBaseSwapChainImpl_Destroy+0x18a(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:65] in wined3d (0x0032f9a8) 2 0x688006a1 IWineD3DBaseSwapChainImpl_Release+0x40(iface=0x131848) [/home/julliard/wine/wine/dlls/wined3d/swapchain.c:125] in wined3d (0x0032f9e8) 3 0x686d25b9 D3D7CB_DestroySwapChain+0x58(swapchain=0x131848) [/home/julliard/wine/wine/dlls/ddraw/ddraw.c:2621] in ddraw (0x0032fa18) 4 0x6875d317 IWineD3DDeviceImpl_UninitGDI+0x66(iface=0x134d58, D3DCB_DestroySwapChain=0x686d2560) [/home/julliard/wine/wine/dlls/wined3d/device.c:2300] in wined3d (0x0032fa78) 5 0x686f8f6e ddraw_surface7_Release+0x1cd(iface=0x129f28) [/home/julliard/wine/wine/dlls/ddraw/surface.c:396] in ddraw (0x0032fad8) 6 0x68689c21 func_ddrawmodes+0x2720() [/home/julliard/wine/wine/dlls/ddraw/tests/ddrawmodes.c:583] in ddraw_test (0x0032fd38) 7 0x686adc9e run_test+0x14d(name="ddrawmodes.c") [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:556] in ddraw_test (0x0032fd88) 8 0x686ae767 main+0x156(argc=0xffffffff, argv=(nil)) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:624] in ddraw_test (0x0032fe48) 9 0x686ae93c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ddraw_test (0x0032fe90) 10 0x7b859a6c call_process_entry+0xb() in kernel32 (0x0032fea8) 11 0x7b85a69f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fee8) 12 0x7bc74c78 call_thread_func+0xb() in ntdll (0x0032fef8) 13 0x7bc776b0 call_thread_entry_point+0x6f(entry=0x7b85a640, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffc8) 14 0x7bc4d27a start_process+0x29(kernel_start=0x7b85a640) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2606] in ntdll (0x0032ffe8) 15 0x6802996d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 0x687550fa context_destroy+0x2a [/home/julliard/wine/wine/dlls/wined3d/context.c:1615] in wined3d: cmpl %eax,0xf2c(%esi) 1615 if (context->tid == GetCurrentThreadId() || !context->current) -- Alexandre Julliard julliard(a)winehq.org

2 1

ntdll: Remove more path trailing chars.
by Joerg-Cyril.Hoehle＠t-systems.com 08 Apr '11

08 Apr '11

Hi, Juan Lang wrote: >Vincent Pelletier wrote: >> Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any >> sense. >> I saw that it is discouraged (forbidden ?) to depend on OS version in tests, >> so I will avoid that path unless asked to follow it. >You'd want to use "ok(pass || broken(fail /* NT4 */)". No! Juan, while you generally give excellent advice, please think again about that one suggestion. It means tests never fail on native, which renders the test useless. What I've been doing several times is to write a detector and have the tests expect the specific NT/non-NT value. static BOOL TrueButNT = TRUE; Don't query OS version! Instead, the first test that sees the difference in behaviour does this: ok(rc == DO || broken(rc == DONT /* NT */), "bla\n"); TrueButNT = (rc==DONT) ? FALSE : TRUE; All later tests use ok(rc == TrueButNT, "bla2\n"); It even works with todo_wine. Any other means to detect NT *that is relevant for your test* is fine, i.e. don't query the DLL version or use some function outside of your test domain. Typical detectors are different GetLastError() values. I call this "coherence testing". Regards, Jörg Höhle

2 1

Re: wine.inf: Add shell handler for .url files.
by Jacek Caban 08 Apr '11

08 Apr '11

Hi Hans, On 4/8/11 9:22 AM, Hans Leidekker wrote: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" I'm not sure about other changes, but this should go to shdocvw. I have a patch in my queue for that. Jacek

1 0

Re: wine.inf: Add shell handler for .url files.
by Damjan Jovanovic 08 Apr '11

08 Apr '11

On Fri, Apr 8, 2011 at 9:22 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=26673 > --- > tools/wine.inf.in | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index d4a457b..048b5bb 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -161,6 +161,7 @@ HKCR,.lnk,,2,"lnkfile" > HKCR,.msi,,2,"Msi.Package" > HKCR,.msp,,2,"Msi.Patch" > HKCR,.rtf,,2,"rtffile" > +HKCR,.url,,2,"InternetShortcut" > HKCR,.wri,,2,"wrifile" > HKCR,chm.file,,2,"Compiled HTML Help File" > HKCR,chm.file\shell\open\command,,2,"%10%\hh.exe %1" > @@ -215,21 +216,25 @@ HKCR,xmlfile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,xmlfile\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,xmlfile\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,xmlfile\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,ftp,"URL Protocol",2,"" > HKCR,ftp\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,ftp\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,ftp\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,ftp\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,ftp\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,http,"URL Protocol",2,"" > HKCR,http\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,http\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,http\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,http\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,https,"URL Protocol",2,"" > HKCR,https\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > HKCR,https\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,https\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,https\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,mailto,"URL Protocol",2,"" > HKCR,mailto\shell\open\command,,2,"%11%\winebrowser %1" > ; FIXME: the following should be done by the dll registration > HKCR,TypeLib\{00020430-0000-0000-C000-000000000046}\1.0\0\win16,,,"stdole.tlb" > -- Aren't most Internet-related file associations created by dlls/mshtml/mshtml.inf instead of tools/wine.inf.in, and should we maybe change that or move your patch there? Damjan

2 1

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.
by Dylan Smith 07 Apr '11

07 Apr '11

On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc <mstefani(a)redhat.de>wrote: > The COM methods are already __stdcall. > --- > dlls/riched20/txthost.c | 128 > ++++++++++++++-------------------------------- > 1 files changed, 39 insertions(+), 89 deletions(-) > > COM methods are supposed to use the stdcall calling convention, but the native riched20 and the native headers just defines ITextHost and ITextServices to be a c++ class (i.e. using the thiscall calling convention). Just look at the native TextServ.h header.

4 6

Google Summer of Code project
by Michał Ziętek 07 Apr '11

07 Apr '11

Hello, My name is Michal Zietek, I am studying Computer Science at Wroclaw University of Technology. I would like to take part at Google Summer of Code. Lately I saw Jacek Caban presenting Wine at the university and he said there could be a possibility to start in Google Summer of Code and work on Wine. I talked to Jacek about project related to WScript. I am interested in working on this project but I can't find it on the Google Summer of Code website. The only place I found any information is http://www.winehq.org/pipermail/wine-devel/2011-February/088839.html Do you consider putting this project into Google Summer of Code? Best regards, Michal Zietek.

4 3

Re: [2/4] wined3d: Track when the FBO is dirty.
by Henri Verbeet 07 Apr '11

07 Apr '11

On 21 March 2011 21:57, Adam Martinson <amartinson(a)codeweavers.com> wrote: > @@ -2102,6 +2121,7 @@ BOOL context_apply_clear_state(struct wined3d_context *context, IWineD3DDeviceIm > if (rt_count < context->gl_info->limits.buffers) > memset(context->blit_targets + rt_count, 0, (context->gl_info->limits.buffers - rt_count) * sizeof(*rts)); > context_apply_fbo_state(context, GL_FRAMEBUFFER, rt_count, context->blit_targets, depth_stencil, SFLAG_INTEXTURE); > + context->device_fbo = context->current_fbo; You can't do that. > @@ -4801,6 +4801,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Clear(IWineD3DDevice *iface, DWORD rect > } > > device_get_draw_rect(device, &draw_rect); > + IWineD3DDeviceImpl_MarkFBODirty(device); What is this for? > +static inline void IWineD3DDeviceImpl_MarkFBODirty(IWineD3DDeviceImpl *This) This doesn't need to be in wined3d_private.h, it's only used from device.c. > + int i; > + for (i = 0; i < This->numContexts; ++i) numContexts is unsigned. What would happen when the current draw fbo entry would get evicted from the cache? Also, while the patch avoids redundant lookups for draws, it doesn't do a lot for clears. Is that intentional because it's not worth it, or is there a different reason for that?

2 4

[PATCH 2/6] winmm: DriverCallback ignores a 0 CALLBACK_WINDOW.
by Joerg-Cyril.Hoehle＠t-systems.com 07 Apr '11

07 Apr '11

Hi, any feedback on winmm:DriverCallback patches 2-6? - Although I superseded patch 1/6, the others are unchanged, hence I did not resend them. - I thought about merging patches 2+3+5 into one or two. After all, they all change the one tiny DriverCallback function. E.g. patch 2 fixes the corner case where Wine delivers a spurious message to the thread message queue, while patch 5 generalizes the behaviour that MS mentions (and I tested), i.e. ignore any 0 dwCallback. OTOH, split is split. - It may seem weird to go to some effort to make DriverCallback return the exact same values as native *and* then change all drivers to ignore that value, so the patches may be considered superfluous. Yet we strive to be bug-compatible. Regards, Jörg Höhle

2 1

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking
by Alexandre Julliard 07 Apr '11

07 Apr '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) > BYTE vprot = view->prot[((const char *)page - (const char *)view->base) >> page_shift]; > if (vprot & VPROT_GUARD) > { > + struct _TEB *teb = NtCurrentTeb(); > VIRTUAL_SetProt( view, page, page_size, vprot & ~VPROT_GUARD ); > - if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) > - NtCurrentTeb()->Tib.StackLimit = page; > + if ((char *)page - page_size == teb->DeallocationStack) > + teb->Tib.StackLimit = page; > + else if ((char*)addr > (char*)teb->Tib.StackLimit + page_size && > + teb->Tib.StackLimit == (char*)teb->DeallocationStack + page_size && > + (view = VIRTUAL_FindView( (char*)teb->Tib.StackLimit, 0))) > + { > + vprot = view->prot[((char*)teb->Tib.StackLimit - (char*)view->base) >> page_shift]; > + VIRTUAL_SetProt( view, teb->Tib.StackLimit, page_size, vprot | VPROT_GUARD); > + teb->Tib.StackLimit = (char*)teb->Tib.StackLimit + page_size; > + } Why do you want to lookup the view again? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: gsoc theming
by Reece Dunn 07 Apr '11

07 Apr '11

On 4 April 2011 13:08, Andrew Green <greeniekin(a)gmail.com> wrote: > Hi, > I hate to message you on this email. I have messaged the mailing > lists. Though I became more confused than anything. Can you please keep the discussions on the mailing list? Thanks. > I would like to propose a project where comctl32 is implement > correctly in windows for google summer of code. > As far as i know windows uses SxS to load version 6 of comctl allowing > theming. This is correct -- an application needs to add a manifest file to tell it to load version 6 of the comctl32 DLL in order to get theming support on Windows. > It also uses windows class redirection to hijack controls > from user32 to be themed(I don't know if it somehow uses subclassing). This is how it is implemented in wine. > The confusing thing on the mailing list i was told not to make a > separate version of comctl32. Which is understandable from a code > maintenance point of view. Though contradicts what the gsoc ideas page > says > "control is overridden by a themed drawing version by subclassing. > This is not the way it is implemented on Windows and this causes > drawing issues and other nasty issues." > As someone who is to be a mentor of this section. What is the goal? > and if subclassing is the option, how is this meant to work? There isn't a contradition. AFAICS, the subclassing works -- the subclassed window procedure gets called correctly. The drawing issues can be seen clearly on the button controls -- if the button changes state (enabled <-> disabled, pressed, etc.) then it gets drawn without theming. This is because the button control in Wine does not call WM_PAINT to do the drawing, which the themed button overrides. Therefore, you will need to either: 1/ convince Alexandre through tests that these tests do call WM_PAINT [*] and update the non-themed control accordingly; or 2/ implement the state tracking/logic in the themed button and have it call WM_PAINT [*]. [*] or the correct custom drawing messages. HTH, - Reece

3 2

Re: Wanted: TestBot maintainer
by Деян Стоянов 07 Apr '11

07 Apr '11

Hi Greg, I'm system administrator in application development unit of company "Information services" Plc. ( about us on http://www.is-bg.net/site_io/?cat=77 ). I am Vmware Certified Professional of VI3 and so far of VI4, and I have good experience with VMware Infrastructure. Also I have no problem with support various operation systems Windows 98, NT, 2000, XP, Vista, 7. Also I have experience with Linux Debian derivations, as well i manage with success other Linux distributions. I am interested to see how TestBot works, and maintain indefinitely. I spoke with my employer for time to maintain the TestBot, and I have a positive answer. I remain at your disposal, and I expect your response. Best regards Deyan Stoyanov

1 0

Wanted: TestBot maintainer
by Greg Geldorp 07 Apr '11

07 Apr '11

Due to personal circumstances I won't be able to maintain the TestBot much longer. I'm looking for a volunteer to take over this responsibility. I can offer the hardware on which the bot runs for another 2 years or so. You'll get full access to the hardware. It helps if you have a bit of experience with VMware vSphere, but that's not absolutely required. Day-to-day operations have been running pretty smooth for the last couple of months, so the demand on your time won't be that great. There's the occasional account request that needs to be approved and that's pretty much it. Every now and then the VMs should be updated using Windows Update. The code itself seems to be reasonably stable. It's all Perl. If you're interested or would like more info, please let me know. Greg.

2 1

Re: configure.ac: add a --without-prelink option
by Vitaliy Margolen 07 Apr '11

07 Apr '11

On 04/06/2011 07:53 PM, Austin English wrote: > Prelink is only available on Linux. It's not a reason to disable the warning. Without prelink, or other means to set load addresses of core dlls, compiled Wine won't be compatible with some programs. Mainly copy protection. Vitaliy.

2 1

Re: user32: Add a test for activating a menu consisting from a single menu item using a hot key.
by Marvin 06 Apr '11

06 Apr '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10366 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel