- wine-devel - winehq.org

New winetricks 20110311b: winetricks is dead, long live winetricks
by Dan Kegel 11 Mar '11

11 Mar '11

winetricks-20110311b is now released. Changes since winetricks-20110123 (for anyone who has not been using the alpha versions): - manages multiple wineprefixes - apps are now installed into separate wineprefixes by default - gui now split into separate pages for games, benchmarks, apps, dlls, fonts - gui now shows approximate disk requirement and install times - gui now lets you pick silent installation mode - apps that are broken (e.g. have drm that wine can't handle) are now hidden by default, gui has a button to reveal them - 70 games added, including Dragon Age II demo, Starcraft II demo, Mass Effect 2, and Mass Effect 2 demo - many updates and bugfixes Changes since winetricks-alpha-20110310: - mdac25, mdac27 removed, as downloads no longer available - mdac28: updated to sp1 - sizes/times in gui updated. (Most show download + install time; a future release will show just install time.) For bug tracker, mailing lists, and wiki, see http://winetricks.org Download url: http://winetricks.org/winetricks

1 0

re: links down
by Dan Kegel 11 Mar '11

11 Mar '11

Looks like 2.8 sp1 is still up, though: http://www.microsoft.com/downloads/en/details.aspx?familyid=78cac895-efc2-4… I'll update winetricks, thanks. (And I'll put together a fast link checker for winetricks; doing a full run with an empty cache takes too long to be a good way of noticing broken links.) Wish I'd noticed this sooner!

1 0

Re: programs/dxdiag: beginnings of support for /t option
by Henri Verbeet 11 Mar '11

11 Mar '11

On 10 March 2011 20:35, Drew Goodwin <drew(a)drewgoodwin.com> wrote: > I'm a CS student at UCLA. I and some classmates are adding features to > wine's dxdiag. Here's the first patch, with code by Steve Feng, Andrew > Freer, and myself, properly copyrighted and licensed under the LGPL. Once > this is accepted, we will send a series of patches to support the remaining > sections in the /t option and the /x option, and add a working gui. > Just some random comments, this is by no means a proper review: > -EXTRADEFS = -DWINE_NO_UNICODE_MACROS > +EXTRADEFS = -DWINE_NO_UNICODE_MACROS -D__WINE__ What do you need __WINE__ for? > +IMPORTS = advapi32 comdlg32 comctl32 d3d9 d3dx9 ddraw dsound dxguid gdi32 kernel32 ole32 oleaut32 shell32 user32 winmm > + That's a lot of imports, do you really need all of those in this patch? > +HINSTANCE g_hinstance; The way you're using this, that's just a slightly odd way to write "NULL". > + sysinfo = malloc(sizeof(DxDiag_SystemInfo)); You should typically use HeapAlloc() for memory allocation in Wine, except for rare cases where you pass the result to a library function that free()'s it. You also leak the sysinfo, but perhaps that's ok as long as you exit right after being done with it. The "g_dxdiagcom_root" global isn't very useful, just pass it to OutputPlainFile() directly.

1 0

Re: cryptnet/tests: Partially revert commit de6e33f306a3b1b424ad1a9c41e85d3692ef9e4d
by Joris Huizer 11 Mar '11

11 Mar '11

Hello, I found a small (copy/paste) mistake in this patch: - /* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH */ - ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH), + /* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH, older w2k: CRYPT_E_ASN1_BADTAG */ + ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH || + broken(GetLastError() == CRYPT_E_NO_MATCH)), The comment indicates the alternative error, but the actual code doesn't check that one HTH, Joris

1 0

Re: wininet(4/7): Implement commiting a url cache entry that already existed (try 2)
by Alexandre Julliard 11 Mar '11

11 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > With the previous patches applied, this no longer fails for me on > Alexandre's apparently corrupt index.dat. Note that the index.dat I sent you was created from scratch, by running the wininet tests in an empty wineprefix. So if it's really corrupt it means wininet has corrupted it. It would probably be a good idea to fix this first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Ignore XML Property ResolveExternals
by Nikolay Sivov 11 Mar '11

11 Mar '11

On 3/11/2011 13:46, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Ignore XML Property ResolveExternals Please correct naming: static const WCHAR PropertyNewParserW[] = {'N','e','w','P','a','r','s','e','r',0}; static const WCHAR PropValueXPathW[] = {'X','P','a','t','h',0}; static const WCHAR PropValueXSLPatternW[] = {'X','S','L','P','a','t','t','e','r','n',0}; +static const WCHAR PropValueResolveExternalsW[] = {'R','e','s','o','l','v','e','E','x','t','e','r','n','a','l','s',0}; It's not a value, it's a property with boolean value, so it's PropertyResolveExternalsW. > > > Best Regards > Alistair Leslie-Hughes

1 0

Re: wininet(7/7): Delete the cache file when it's no longer referenced (resend)
by Marvin 11 Mar '11

11 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9868 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: wininet(6/7): Delete cache entries when their use count reaches 0
by Marvin 11 Mar '11

11 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9867 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 6/6] user32: Add support for sequence-based animated cursors.
by Henri Verbeet 11 Mar '11

11 Mar '11

On 10 March 2011 07:42, Erich Hoover <ehoover(a)mines.edu> wrote: > @@ -940,6 +954,7 @@ done: > #define ANI_seq__ID RIFF_FOURCC('s', 'e', 'q', ' ') > #define ANI_fram_ID RIFF_FOURCC('f', 'r', 'a', 'm') > #define ANI_rate_ID RIFF_FOURCC('r', 'a', 't', 'e') > +#define ANI_seq_ID RIFF_FOURCC('s', 'e', 'q', ' ') Just happened to notice this, but I doubt there's much point in having two different defines for sequence chunks.

2 1

Re: [4/4] d3d8: Test depth stencil size mismatches
by Henri Verbeet 10 Mar '11

10 Mar '11

On 10 March 2011 22:58, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -264,6 +264,8 @@ struct IDirect3DSurface8Impl > > /* If set forward refcounting to this object */ > IUnknown *forwardReference; > + > + UINT width, height; > }; You could just ask wined3d for the surface size.

2 1

Re: [PATCH 3/4] mshtml: Added IHTMLPrivateWindow_GetAddressBarUrl implementation
by Marvin 10 Mar '11

10 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9859 Your paranoid android. === WXPPROSP3 (32 bit htmldoc) === htmldoc.c:3564: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3526: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3557: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3564: Test failed: unexpected address bar url: L"about:replace" === WVISTAADM (32 bit htmldoc) === htmldoc.c:3564: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3526: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3557: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3564: Test failed: unexpected address bar url: L"about:replace" === W7PRO (32 bit htmldoc) === htmldoc.c:3564: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3526: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3557: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3564: Test failed: unexpected address bar url: L"about:replace" === W7PROX64 (32 bit htmldoc) === htmldoc.c:3564: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3526: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3557: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3564: Test failed: unexpected address bar url: L"about:replace" === W7PROX64 (64 bit htmldoc) === htmldoc.c:3564: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3526: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3557: Test failed: unexpected address bar url: L"about:blank" htmldoc.c:3564: Test failed: unexpected address bar url: L"about:replace"

1 0

Wine Gecko 1.2.0 RC1
by Jacek Caban 10 Mar '11

10 Mar '11

Hi all, I'm happy to announce that the new update of Wine Gecko packages is almost there. It took long time since last beta to get to RC point from beta, not only because of many changes on our side, but mostly because of delays in Mozilla release process. We've done everything I've hoped to be done (and even more than I expected). I'm also happy that it was much better tested than previous times (mostly because they were available for so long). So far I'm aware of only one regression in Outlook that probably won't block the release because it seems to be a problem on Wine side (I can't be sure as I wasn't able to reproduce it so far). If I've missed something, please let me know. I'd appreciate help with testing. Builds are on Sourceforge [1]. To use it, just grab MSI files and put it into the directory where usually CAB files would go and apply the attached patch. Please let me know about any regression you notice. * CHANGES * - The CAB file is created without external dependencies Thanks to Alexandre for cabinet work. - We use MSI installers Thanks to Hans for winemsibuilder and preparing scripts that made it possible. - winedbg works with Gecko debug builds Thanks to Eric for many fixes to dbghelp/winedbg. Once he will merge his work to Wine, we will be able to use winedbg for comfortable Gecko debugging - win64 build now works - a few bug fixes - I've got rid of some Gecko ugly things like using API hooks * FURTHER PLANS * Firefox 4 RC1 came out yesterday and is expected to be the final build (so far nothing that would require another RC was found). Mozilla estimates release to be out in a week or two. I'm tempted to not wait and release early next week (so that it will live in Git for at least a few days before Wine release), but we will see how it will work. If we'd find any new blocker, it would most likely mean that we will release a week later. * FOR PACKAGERS * If you are interested in building the packager yourself from sources (so far I've heard about Debian and Fedora attempts to do so), everything is ready to support it now. Building instructions changed a bit after switching to use MSI files, but I've made things as easy as possible. Building the package itself is a matter of invoking one script with proper arguments. The tricky part is that Wine is needed for building, so we get circural build-time dependency. The script, however, makes sure that Wine doesn't need Gecko during compiling Gecko, so it shouldn't be a big problem to handle. Also, unless you manually set WINEPREFIX, the script created a temporary wineprefix directory, so there is nothing to worry if your ~/.wine is in broken state. It can also use Wine from its build dir if you set WINE_BUILD_DIR environment variable. Please let me know if there are more problems than need to be addressed and feel free to contact me if you have any questions. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.2.0-rc1/

3 4

Re: wininet(6/10): Implement commiting a url cache entry that already existed
by Alexandre Julliard 10 Mar '11

10 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > As a nice side effect, the aggravating fixme about not knowing what to > do disappears. The tests just hang for me: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok fixme:wininet:set_cookie persistent cookies not handled (L"expires=Sat, 09 Apr 2011 14:14:39 GMT; path=/") fixme:wininet:InternetSetOptionW Option 43 STUB fixme:wininet:InternetSetOptionW Option 44 STUB fixme:wininet:CommitUrlCacheEntryInternal Trying to delete entry of unknown format "\x00\x00\x00\x00" -- Alexandre Julliard julliard(a)winehq.org

2 1

Links down
by Diego Diaz 10 Mar '11

10 Mar '11

sh winetricks mdac25 Executing wget -O mdac_typ.exe -nd -c --read-timeout=300 --retry-connrefused --header Accept-Encoding: gzip,deflate http://download.microsoft.com/download/e/e/4/ee4fe9ee-6fa1-4ab6-ab8c-fe1769… --2011-03-10 16:16:31-- http://download.microsoft.com/download/e/e/4/ee4fe9ee-6fa1-4ab6-ab8c-fe1769… Resolving download.microsoft.com... 77.67.20.40, 77.67.20.51, 77.67.20.64 Connecting to download.microsoft.com|77.67.20.40|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2011-03-10 16:16:32 ERROR 404: Not Found. ------------------------------------------------------ Note: command 'wget -O mdac_typ.exe -nd -c --read-timeout=300 --retry-connrefused --header Accept-Encoding: gzip,deflate http://download.microsoft.com/download/e/e/4/ee4fe9ee-6fa1-4ab6-ab8c-fe1769…' returned status 8. Aborting. ------------------------------------------------------ ------------------------------------------------------ mdac25 failed ************************************************************************************************************************************************* sh winetricks mdac28 Executing wget -O MDAC_TYP.EXE -nd -c --read-timeout=300 --retry-connrefused --header Accept-Encoding: gzip,deflate http://download.microsoft.com/download/c/d/f/cdfd58f1-3973-4c51-8851-49ae37… --2011-03-10 16:16:09-- http://download.microsoft.com/download/c/d/f/cdfd58f1-3973-4c51-8851-49ae37… Resolving download.microsoft.com... 77.67.20.40, 77.67.20.24 Connecting to download.microsoft.com|77.67.20.40|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2011-03-10 16:16:10 ERROR 404: Not Found. ------------------------------------------------------ Note: command 'wget -O MDAC_TYP.EXE -nd -c --read-timeout=300 --retry-connrefused --header Accept-Encoding: gzip,deflate http://download.microsoft.com/download/c/d/f/cdfd58f1-3973-4c51-8851-49ae37…' returned status 8. Aborting. ------------------------------------------------------ ------------------------------------------------------ mdac28 failed

1 0

New winetricks 20110310-alpha: new verbs csi6_demo, farmsim2011_demo, mono210
by Dan Kegel 10 Mar '11

10 Mar '11

Version 20110310-alpha adds two games csi6_demo - CSI: Fatal Conspiracy Demo farmsim2011_demo - Farming Simulator 2011 Demo plus a new version of mono (2.10). There are a couple gui changes: it adds a help button and a button to unhide broken titles,and adds a scary warning to the dinput and directx9 verb menu items. It also fixes a number of bugs. For bug tracker, mailing lists, and wiki, see http://winetricks.org Download url: http://winetricks.org/winetricks-alpha There's also an announcements mailing list for package maintainers now: http://groups.google.com/group/winetricks-announce Changes since 20110306-alpha: vbrun5, vbrun6: fix install check. vc2005trial: fix regression caused by 7zip installing into its own wineprefix. richtx32: fix install check Print unix file rather than windows file when install check fails, it's much less mysterious. farmsim2011_demo: fix media type Avoid syntax error if which returns empty string list-installed: no longer need kludge. Also sort the inputs rather than the outputs so output shows up faster. firefox4: update to rc1 mono210: new verb w_download: fix penpenxmas and autohotkey right this time w_download: don't set user-agent, it breaks sourceforge download csi6_demo: new verb farmsim2011_demo: new verb. sammax301_demo: fix typo (it's not 304) Add gui option for showing broken apps. Not great, but it'll do for now. Main menu is called 'main', so call prefix menu 'prefix'... masseffect2_demo: use wine-hotfix-6971 if present. Also fix -q support. tahoma: fix install check grr. really fix navigation, I hope. help: new verb, just opens winetricks.org/help in a browser. This is the very first entry on the first menu of the gui. fix breakage in zenity menus remove dead code dxdiag: list under 'dlls' rather than 'apps', since it's usually used in the context of some other app. Make directx9 warning more obvious. OS reporting didn't work well, so put wine version in that slot Fix navigation when returning back from apps Fix KDE support in top menu. Fix time/space columns in German and (kind of) Danish. d3dcompiler_43: new verb by Rico; marked as broken to hide it from casual users until wine can handle more d3d10 dinput: add scary warning

1 0

Re: [1/2] wininet: Partially implement FreeUrlCacheSpaceW. (try 2)
by Alexandre Julliard 10 Mar '11

10 Mar '11

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> writes: > @@ -1660,6 +1660,16 @@ BOOLAPI DeleteUrlCacheEntryA(LPCSTR); > BOOLAPI DeleteUrlCacheEntryW(LPCWSTR); > #define DeleteUrlCacheEntry WINELIB_NAME_AW(DeleteUrlCacheEntry) > > +/* FCS_ flags and FreeUrlCacheSpace are no longer documented */ > +#define FCS_PERCENT_CACHE_SPACE 0 /* guessed value */ > +#define FCS_PERCENT_DISK_SPACE 1 /* guessed value */ > +#define FCS_ABSOLUTE_SIZE 2 /* guessed value */ Where do these come from then? If you made them up they shouldn't go in a public header. -- Alexandre Julliard julliard(a)winehq.org

2 2

d3dxcreatebox patch
by David Adam 10 Mar '11

10 Mar '11

Hello, is there any problem with my d3dxcreatebox patch? Thanks in advance for any feedback. A+ David

3 5

Re: winecfg: Protect from closing the root key.
by Alexandre Julliard 10 Mar '11

10 Mar '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch should fix the crash reported in the bug #26367. A better way would be to use RegOpenKeyExW. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/6] user32: Add support for retrieving individual animated frames.
by Alexandre Julliard 10 Mar '11

10 Mar '11

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -101,19 +93,40 @@ struct cursoricon_object > UINT width; > UINT height; > POINT hotspot; > + UINT delay; /* delay between this frame and the next (in jiffies) */ > + BOOL is_ani; /* whether this object is a static cursor or an animated cursor */ > UINT num_frames; /* number of frames in the icon/cursor */ > UINT num_steps; /* number of sequence steps in the icon/cursor */ > - UINT delay; /* global delay between frames (in jiffies) */ > - struct cursoricon_frame frames[1]; /* icon frame information */ > }; Some of these fields don't make sense for a static cursor. Also please try to do this change in smaller steps. -- Alexandre Julliard julliard(a)winehq.org

1 0

hooking into wine (GL video capturing app)
by Christian Parpart 10 Mar '11

10 Mar '11

Hey all, a few years ago I once developed an application for recording the video of the 3D games I played via wine (and cedega). This all worked quite fine these days and I remember that cedega's wine engine used other libX11 functions to process events than wine itself did or still does. In my software, I am overriding the specific library functions I want to hook in, such as glXSwapBuffers, XNextEvent, XCheckIfEvent, ... and then do LD_PRELOAD_LIBRARY this when starting wine. Note, only wine used to use XCheckIfEvent but cedega used some other function to process events, IIRC. This all worked fine back in the days I developed it, now I want to resurrect this project and found myself in troubles. That is, I can successfully hook into OpenGL library functions, but I just cannot find a trace on why my XCheckIfEvent is not being used by wine. A few days back one guy at IRC told me that I have to look at the wine's x11drv source code, which I did, but all I can see, is, that wine indeed still seems to use XCheckIfEvent(). Checking my running wine app (with my library preloaded) using lsof I can see that my library is indeed successfully hooked up into the process image at least, and so do my hooks to the OpenGL functions work. As a test, I also hooked up into XOpenDisplay from libX11, it worked, but still, XCheckIfEvent() does not, and my only clue is, that this piece of code of wine isn't actually the one processing the events. As a side note, I need to hook up into libX11 to capture keyboard input to actually start/stop video recording / screenshotting on keyboard events. Can anyone please help me out here why I cannot grap wine's keyboard events? In case of interest, the following is the link to the source code in question: http://redmine.xzero.ws/projects/captury/repository/revisions/master/entry/… Best regards, Christian Parpart.

2 1

Re: USB Osciloscope
by Archie Robertson 10 Mar '11

10 Mar '11

> Hello, > > What WINE version do you try to use? > What do you put to the WINE registry? > Could you send me ezusb.sys and a starting WINE log with > WINEDEBUG=+winedevice,+ntoskrnl,+usbhub ? > > Thanks, > Alexander Here is the information you have requested. I had trouble emailing the driver, so I put them on my web server at www.robertsonrobots.com/ezusb.sys Thanks for the help, Archie wine-1.0.1 REGEDIT4 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB] [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004] [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&1] "Capabilities"=dword:00000084 "Class"="DSO" "ClassGUID"="{4C696E6B-2049-6E73-7472-756D656E7473}" "CompatibleIDs"=hex(7):55,53,42,5c,43,6c,61,73,73,5f,66,65,26,53,75,62,43,6c,61,\ 73,73,5f,30,33,26,50,72,6f,74,5f,30,30,00,55,53,42,5c,43,6c,61,73,73,5f,66,\ 65,26,53,75,62,43,6c,61,73,73,5f,30,33,00,55,53,42,5c,43,6c,61,73,73,5f,66,\ 65,00,00 "ConfigFlags"=dword:00000000 "DeviceDesc"="Link Instruments DSO-8502" "Driver"="{4C696E6B-2049-6E73-7472-756D656E7473}\\0001" "HardwareID"=hex(7):55,53,42,5c,56,69,64,5f,33,31,39,35,26,50,69,64,5f,30,30,30,\ 34,26,52,65,76,5f,30,30,30,35,00,55,53,42,5c,56,69,64,5f,33,31,39,35,26,50,\ 69,64,5f,30,30,30,34,00,00 "LocationInformation"="DSO-8502" "Mfg"="Link Instruments" "Service"="ezusb" "UINumber"=dword:00000000 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&1\Device Parameters] "SymbolicName"="\\??\\USB#Vid_3195&Pid_0004#5&c1e6cce&0&1#{a5dcbf10-6530-11d2-901f-00c04fb951ed}" [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&1\LogConf] [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&2] "Capabilities"=dword:00000084 "Class"="DSO" "ClassGUID"="{4C696E6B-2049-6E73-7472-756D656E7473}" "CompatibleIDs"=hex(7):55,53,42,5c,43,6c,61,73,73,5f,66,65,26,53,75,62,43,6c,61,\ 73,73,5f,30,33,26,50,72,6f,74,5f,30,30,00,55,53,42,5c,43,6c,61,73,73,5f,66,\ 65,26,53,75,62,43,6c,61,73,73,5f,30,33,00,55,53,42,5c,43,6c,61,73,73,5f,66,\ 65,00,00 "ConfigFlags"=dword:00000000 "DeviceDesc"="Link Instruments DSO-8502" "Driver"="{4C696E6B-2049-6E73-7472-756D656E7473}\\0000" "HardwareID"=hex(7):55,53,42,5c,56,69,64,5f,33,31,39,35,26,50,69,64,5f,30,30,30,\ 34,26,52,65,76,5f,30,30,30,35,00,55,53,42,5c,56,69,64,5f,33,31,39,35,26,50,\ 69,64,5f,30,30,30,34,00,00 "LocationInformation"="DSO-8502" "Mfg"="Link Instruments" "Service"="ezusb" "UINumber"=dword:00000000 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&2\Device Parameters] "SymbolicName"="\\??\\USB#Vid_3195&Pid_0004#5&c1e6cce&0&2#{a5dcbf10-6530-11d2-901f-00c04fb951ed}" [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Enum\USB\Vid_3195&Pid_0004\5&c1e6cce&0&2\LogConf] REGEDIT4 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\ezusb] "ErrorControl"=dword:00000001 "ImagePath"="\"system32\\\\driver\\\\ezusb.sys\"" "Start"=dword:00000003 "Type"=dword:00000001 [HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\ezusb\Security] "Security"=hex:01,00,14,80,a0,00,00,00,ac,00,00,00,14,00,00,00,30,00,00,00,02,\ 00,1c,00,01,00,00,00,02,80,14,00,ff,01,0f,00,01,01,00,00,00,00,00,01,00,00,\ 00,00,02,00,70,00,04,00,00,00,00,00,18,00,fd,01,02,00,01,01,00,00,00,00,00,\ 05,12,00,00,00,00,00,00,00,00,00,1c,00,ff,01,0f,00,01,02,00,00,00,00,00,05,\ 20,00,00,00,20,02,00,00,00,00,00,00,00,00,18,00,8d,01,02,00,01,01,00,00,00,\ 00,00,05,0b,00,00,00,20,02,00,00,00,00,1c,00,fd,01,02,00,01,02,00,00,00,00,\ 00,05,20,00,00,00,23,02,00,00,00,00,00,00,01,01,00,00,00,00,00,05,12,00,00,\ 00,01,01,00,00,00,00,00,05,12,00,00,00 phoenox@firebird:~/.wine/drive_c/DSO8000$ WINEDEBUG=+winedevice, +ntoskrnl,+usbhub wine ezusb.sys trace:winedevice:ServiceMain starting service L"MountMgr" trace:winedevice:load_driver loading driver L"C:\\windows\\system32\ \drivers\\mountmgr.sys" trace:ntoskrnl:IoCreateDevice (0x7ee8c480, 0, L"\\Device\ \MountPointManager", 0, 0, 0, 0x7ec048ac) trace:ntoskrnl:IoCreateSymbolicLink L"\\??\\MountPointManager" -> L"\ \Device\\MountPointManager" trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\\Harddisk0", 0, 0, 0, 0x7ec047f8) trace:ntoskrnl:IoCreateSymbolicLink L"\\??\\PhysicalDrive0" -> L"\ \Device\\Harddisk0" trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume1", 0, 0, 0, 0x7ec3a540) trace:ntoskrnl:IoCreateSymbolicLink L"\\DosDevices\\C:" -> L"\\Device\ \HarddiskVolume1" trace:ntoskrnl:IoCreateSymbolicLink L"\\??\ \Volume{00000000-0000-0000-0000-000000000043}" -> L"\\Device\ \HarddiskVolume1" trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume1", 0, 0, 0, 0x7ec3a568) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume2", 0, 0, 0, 0x7ec3a568) trace:ntoskrnl:IoCreateSymbolicLink L"\\DosDevices\\D:" -> L"\\Device\ \HarddiskVolume2" trace:ntoskrnl:IoCreateSymbolicLink L"\\??\ \Volume{00000000-0000-0000-0000-000000000044}" -> L"\\Device\ \HarddiskVolume2" trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume1", 0, 0, 0, 0x7ec3a590) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume2", 0, 0, 0, 0x7ec3a590) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume3", 0, 0, 0, 0x7ec3a590) trace:ntoskrnl:IoCreateSymbolicLink L"\\DosDevices\\H:" -> L"\\Device\ \HarddiskVolume3" trace:ntoskrnl:IoCreateSymbolicLink L"\\??\ \Volume{00000000-0000-0000-0000-000000000048}" -> L"\\Device\ \HarddiskVolume3" trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume1", 0, 0, 0, 0x7ec3a5b8) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume2", 0, 0, 0, 0x7ec3a5b8) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume3", 0, 0, 0, 0x7ec3a5b8) trace:ntoskrnl:IoCreateDevice (0x1117b0, 20, L"\\Device\ \HarddiskVolume4", 0, 0, 0, 0x7ec3a5b8) trace:ntoskrnl:IoCreateSymbolicLink L"\\DosDevices\\Z:" -> L"\\Device\ \HarddiskVolume4" trace:ntoskrnl:IoCreateSymbolicLink L"\\??\ \Volume{00000000-0000-0000-0000-00000000005a}" -> L"\\Device\ \HarddiskVolume4" trace:winedevice:init_driver init done for L"MountMgr" obj 0x7ee8c480 trace:winedevice:init_driver - DriverInit = 0x7ec383c0 trace:winedevice:init_driver - DriverStartIo = (nil) trace:winedevice:init_driver - DriverUnload = (nil) trace:winedevice:init_driver - MajorFunction[0] = (nil) trace:winedevice:init_driver - MajorFunction[1] = (nil) trace:winedevice:init_driver - MajorFunction[2] = (nil) trace:winedevice:init_driver - MajorFunction[3] = (nil) trace:winedevice:init_driver - MajorFunction[4] = (nil) trace:winedevice:init_driver - MajorFunction[5] = (nil) trace:winedevice:init_driver - MajorFunction[6] = (nil) trace:winedevice:init_driver - MajorFunction[7] = (nil) trace:winedevice:init_driver - MajorFunction[8] = (nil) trace:winedevice:init_driver - MajorFunction[9] = (nil) trace:winedevice:init_driver - MajorFunction[10] = (nil) trace:winedevice:init_driver - MajorFunction[11] = (nil) trace:winedevice:init_driver - MajorFunction[12] = (nil) trace:winedevice:init_driver - MajorFunction[13] = (nil) trace:winedevice:init_driver - MajorFunction[14] = 0x7ec37630 trace:winedevice:init_driver - MajorFunction[15] = (nil) trace:winedevice:init_driver - MajorFunction[16] = (nil) trace:winedevice:init_driver - MajorFunction[17] = (nil) trace:winedevice:init_driver - MajorFunction[18] = (nil) trace:winedevice:init_driver - MajorFunction[19] = (nil) trace:winedevice:init_driver - MajorFunction[20] = (nil) trace:winedevice:init_driver - MajorFunction[21] = (nil) trace:winedevice:init_driver - MajorFunction[22] = (nil) trace:winedevice:init_driver - MajorFunction[23] = (nil) trace:winedevice:init_driver - MajorFunction[24] = (nil) trace:winedevice:init_driver - MajorFunction[25] = (nil) trace:winedevice:init_driver - MajorFunction[26] = (nil) trace:winedevice:init_driver - MajorFunction[27] = (nil) err:module:attach_process_dlls "USBD.SYS" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"C:\\DSO8000\ \ezusb.sys" failed, status c0000142

2 1

Re: [PATCH 3/3] msi: Add an offset to sequence numbers belonging to files added by a patch.
by Hans Leidekker 10 Mar '11

10 Mar '11

On Thu, 2011-03-10 at 02:20 +0100, David Hedberg wrote: > +static UINT msi_set_patch_offsets(MSIPACKAGE *package) > +{ > + static const WCHAR query_media[] = { > + 'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ','M','e','d','i','a',' ', > + 'W','H','E','R','E',' ','S','o','u','r','c','e',' ','I','S',' ','N','O','T',' ','N','U','L','L',0}; You should order the list by DiskId to protect against installers with multiple sources for a given file sequence number. We do this elsewhere, and although I'm not sure it matches native it will at least give consistent behavior. Also, MSDN tells me the Source column is ignored if the Cabinet column is empty. > UINT msi_apply_patch_db( MSIPACKAGE *package, MSIDATABASE *patch_db, MSIPATCHINFO *patch ) > { > UINT i, r = ERROR_SUCCESS; > @@ -640,6 +796,7 @@ UINT msi_apply_patch_db( MSIPACKAGE *package, MSIDATABASE *patch_db, MSIPATCHINF > return r; > > msi_set_media_source_prop( package ); > + msi_set_patch_offsets( package ); There can be more than one transform in the patch that modifies the Media table. It's unlikely, but it may mean that offsets need to be applied after each transform that modifies the Media table instead of after each patch.

1 0

Re: wininet: Reimplement IsUrlCacheEntryExpired
by Marvin 09 Mar '11

09 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9825 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/5] d3dx9: Support triangulation of complex glyphs in D3DXCreateText.
by Alexandre Julliard 09 Mar '11

09 Mar '11

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > +static void sort_vertex_indices(struct point2d_index *start, int count) > +{ > + struct point2d_index *current, *middle_value, *last; > + int below_count; > + > + if (count <= 1) > + return; > + > + /* quick sort */ > + last = start + count - 1; > + middle_value = last--; > + current = start; > + while (current <= last) > + { > + if (compare_vertex_indices(current, middle_value) < 0) { > + current++; > + } else { > + swap_vertex_indices(current, last); > + last--; > + } > + } > + swap_vertex_indices(current, middle_value); > + > + below_count = current - start; > + sort_vertex_indices(start, below_count); > + sort_vertex_indices(current + 1, count - below_count - 1); > +} Is there a reason for not using qsort? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 4/4] d3d9: Surfaces always have resource type WINED3DRTYPE_SURFACE.
by Stefan Dösinger 08 Mar '11

08 Mar '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Actually I think we have a test that shows that if the surface is part of a texture it has resource type WINED3DRTYPE_TEXTURE. (Unverified, it's too late so I am too lazy to look for the exact test atm) Am 08.03.2011 um 19:41 schrieb Henri Verbeet: > --- > dlls/d3d9/device.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c > index 1dd6895..e008b31 100644 > --- a/dlls/d3d9/device.c > +++ b/dlls/d3d9/device.c > @@ -1081,8 +1081,7 @@ static HRESULT WINAPI IDirect3DDevice9Impl_ColorFill(IDirect3DDevice9Ex *iface, > > /* This method is only allowed with surfaces that are render targets, or > * offscreen plain surfaces in D3DPOOL_DEFAULT. */ > - if (!(desc.usage & WINED3DUSAGE_RENDERTARGET) > - && (desc.pool != WINED3DPOOL_DEFAULT || desc.resource_type != WINED3DRTYPE_SURFACE)) > + if (!(desc.usage & WINED3DUSAGE_RENDERTARGET) && desc.pool != WINED3DPOOL_DEFAULT) > { > wined3d_mutex_unlock(); > WARN("Surface is not a render target, or not a stand-alone D3DPOOL_DEFAULT surface\n"); > -- > 1.7.3.4 > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNdrJeAAoJEN0/YqbEcdMwx3kP/0FGwYvZM7+YUz1atAfcpTQH mFsaWRKCMac9FHWHsoK++HyeN0R0F69NMnJzH33u2xxhrM6DvPfHsDrP0kcySHDN 3sVP/87U1cdHaVmURjnx6o0+3elj/IikmM0rGkTT3eityItp5hgj+OiizuD+wwQ5 jxrcsvI1tS4iZe+j+2s8zt1zJYhGNhJRI5n8IFCpPP3MXFqDPxxiUwua7MRweWx3 MRZQVkmJ4/3Jy5rTKjf4LROBqY2ZLP8Yeyo0jgAS3Wn+1LEJqKtgEhz03/rxGNPQ Lwpx+1gLsl2XonbZMPUXfhoE4ETi70S7OC2Z3EVOBY+XbEPRdEq6qIsoAQwFfHFQ AVo8qjSndjcd9sxQ4MQyarxHfRuL9OlCnO+WKfMOHo1WFdBg7I8uPrYKuZmlDZ2c lEwSOgh2Td0PCs0Gha0uqt8Gav5t1M40zKoGE2Lmd8gKAu4+Ot1IwbhU0tebaKMC JUD0d83oNgxbPsoKUdbbnq4oeDBMNnnFKQ18m9H7N1LABe9hzE13IfcxCfVLWfzk CtJlYWBeqa5hD5Chf1eNMuZEHyooaRhgy6Q0Vd5DVVpTMj9JzURIo7Mnb43GG9QT H7EkmVR2Ivn8ZHzF7nqeAJxqcWQKPmpn5/RTqapPbVx5mN7CYIICj5pvkJi8A0Zs Qvn8oiJ+qivoIPKlIyTP =Pm4w -----END PGP SIGNATURE-----

2 1

re: winegcc preprocessor macro containing wine version?
by Dan Kegel 08 Mar '11

08 Mar '11

Robert McDonald asked: > I want to be able to define a structure if I'm compiling with Wine 1.2.2 > but not with Wine 1.3.15, since the structure definition exists in the > latter but not the former. Is there a preprocessor macro pre-defined by > winegcc that holds the Wine version? #include "config.h" gives you PACKAGE_VERSION, but that's a string. Looking at 'git blame commctrl.h, I see that MCM_SETCALENDARBORDER is a preprocessor symbol of similar vintage to TASKDIALOG_BUTTON, testing for that should suffice. (But Wine doesn't implement task dialogs, hope you're not expecting them to work. There has been some interest in implementing it, and some code is floating around, but I haven't heard anything concrete yet.) - Dan

2 1

winealsa.drv: Waveout rewrite to allow multiple waveopens
by Joerg-Cyril.Hoehle＠t-systems.com 08 Mar '11

08 Mar '11

Maarten, let me apologize for barely taking the time to look at the extra patches you write outside of the main git tree. I hope other people find more time to try them out with real apps and report on their findings. Here are a few comments of mine on your winealsa rewrite (beside bug #22261, comment #6). - It's been a pleasure to hear mciwave+winealsa open multiple devices concurrently with dmix mixing all playing sounds thanks to this rewrite. - wodNotifyDoneList is called from within a critical section in wodTick(). This may break havoc with DCB_FUNCTION callbacks, as the driver does not appear to be re-entrant. EnterCriticalSection offers no protection from within the same thread. Some apps are known to call waveOutClose() from within the DONE callback. Of course you may delegate this issue to a solution to bug #3930. I'd be curious if you have any ideas about how to delay notification to a later point in time, "until it is safe to do" -- native appears to delay as well. - You may wish to look into bug #22880. Lemmix is a small (143KB) downloadable application that opens two waveout devices. It plays both music and sound effects on Mac OS using the winecoreaudio driver, but fails to do so with your ALSA driver, although both devices open and WINEDEBUG=+wave shows calls to waveOutWrite. I could not figure out what goes wrong. - I've seen old apps ask for ~7000 samples per second. Your limit of 8000 is too high. Here's a patch to use DSBFREQUENCY_* like the other devices do. Lemmix needs it (although I did not investigate why the msacm/pcmconverter did not kick in and resample to a higher frequency). >From 54224dbf35354036934d7791acafe0353cbef7bc Mon Sep 17 00:00:00 2001 From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= <hoehle(a)users.sourceforge.net> Date: Sat, 5 Mar 2011 19:28:00 +0100 Subject: winealsa: Use DSBFREQUENCY_* as lower and upper bounds. --- dlls/winealsa.drv/waveout.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 23560cc..b15164b 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -225,7 +225,7 @@ static DWORD wodGetDevCaps(waveimpl *dev, LPWAVEOUTCAPSW lpCaps, DWORD dwSize) { static snd_pcm_format_t get_format(WAVEFORMATEX *wfx) { WAVEFORMATEXTENSIBLE *wfe = (WAVEFORMATEXTENSIBLE *)wfx; - if (!wfx->nChannels || wfx->nSamplesPerSec < 8000 || wfx->nSamplesPerSec > 192000) + if (!wfx->nChannels || wfx->nSamplesPerSec < DSBFREQUENCY_MIN || wfx->nSamplesPerSec > DSBFREQUENCY_MAX) return SND_PCM_FORMAT_UNKNOWN; if (wfx->wFormatTag == WAVE_FORMAT_PCM) { -- 1.5.6.3 Regards, Jörg Höhle

2 1

winegcc preprocessor macro containing wine version?
by Robert McDonald 08 Mar '11

08 Mar '11

I want to be able to define a structure if I'm compiling with Wine 1.2.2 but not with Wine 1.3.15, since the structure definition exists in the latter but not the former. Is there a preprocessor macro pre-defined by winegcc that holds the Wine version? Maybe that's not the best long-term solution but that will help for awhile. #if defined ...? typedef struct tagTASKDIALOG_BUTTON { int nButtonID; ctstr pszButtonText; } TASKDIALOG_BUTTON, MsgBoxOption; #else typedef TASKDIALOG_BUTTON MsgBoxOption; #endif -- Robert McDonald BitTorrent, Inc.

1 0

Re: widl: Pass the switchtype attribute from an alias to the base type
by Alexandre Julliard 08 Mar '11

08 Mar '11

Eric Kohl <eric.kohl(a)t-online.de> writes: > Hi, > > this patch ensures that client and server code for non-encapsulated > unions is generated correctly. The switchtype attribute must be passed > to from a type alias to the base type in order to get recognized by > write_union_tfs(). Modifying the base type doesn't seem right. You should add some test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] wininet: Partially implement FreeUrlCacheSpaceW.
by Alexandre Julliard 08 Mar '11

08 Mar '11

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> writes: > + if (file == INVALID_HANDLE_VALUE) > + { > + if (GetLastError() == ERROR_SHARING_VIOLATION) > + { > + WCHAR title[128]; > + LoadStringW(WININET_hModule, IDS_CACHE_IN_USE, message, sizeof(message)/sizeof(*message)); > + LoadStringW(WININET_hModule, IDS_WARNING, title, sizeof(title)/sizeof(*title)); > + MessageBoxW(NULL, message, title, MB_OK); > + } I don't think you want to show message boxes, particularly not for such harmless errors. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet(3/7): Account for disk space used by cache
by Alexandre Julliard 08 Mar '11

08 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > +{ > + ULARGE_INTEGER currentSize, addedSize, limit; > + > + currentSize.u.LowPart = pHeader->dwCacheUsageLow; > + currentSize.u.HighPart = pHeader->dwCacheUsageHigh; > + addedSize.u.HighPart = fileSizeHigh; > + addedSize.u.LowPart = fileSizeLow; > + currentSize.QuadPart += addedSize.QuadPart; > + limit.u.LowPart = pHeader->dwCacheLimitLow; > + limit.u.HighPart = pHeader->dwCacheLimitHigh; > + if (commit) > + { > + pHeader->dwCacheUsageLow = currentSize.u.LowPart; > + pHeader->dwCacheUsageHigh = currentSize.u.HighPart; > + } > + return currentSize.QuadPart > limit.QuadPart; You should store the fields as large integer in the header structure, that would save a lot of redundant manipulations. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] msi: Assume a file is present if the target exists with the same size and there's no file version or hash to verif
by Marvin 08 Mar '11

08 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9778 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5993: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [2/3] msi: Load media info even if there's no file to install.
by Marvin 08 Mar '11

08 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9777 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5958: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

New winetricks-alpha 20110306: new game Crysis 2 Demo and seven others, new dll dinput, lots of bug fixes; ie8 now works
by Dan Kegel 08 Mar '11

08 Mar '11

Another fortnight, another Winetricks. Version 20110306-alpha has a slightly cleaned up gui, a handful of bugfixes and sha1sum updates, eight new games (crysis2_demo_mp, diablo2, dragonage, masseffect2_demo, penpenxmas, rayman2_demo, sammax301_demo, and secondlife), one new dll (dinput), and one new setting (vd=640x480). It removes ie68, which is no longer needed, now that ie8 works. It isolates all apps in their own wineprefix by default now, not just games. The option --isolate-games is gone, and a new option --no-isolate was added. And finally, it's not quite as slow at putting up menus. Also, there's some real doc at http://winetricks.org for end users as well as for developers. Download url: http://winetricks.org/winetricks-alpha svn repository / bug tracker: http://winetricks.org Changes since 20110222: Update disk space & time install requirements diablo2: waiting for updater window isn't enough, you have to wait for it to say it's finished! Cope with empty USERNAME, which happens when using startx. hegemony_gold: updated sha1sum Added 'folder' verb to open current wineprefix with xdg-open Show title of installed app rather than absolute path in comment at top, give example of how to install all prereqs firefox: update to 3.6.15, fix system menu. corefonts: Trebuc filenames have mixed case. Fixes bug winezeug-203. Install apps and benchmarks into their own prefixes, too. Show prefix name uniformly in window title. Move ie to dlls, call dlls 'Windows dlls or components'. Add option --no-isolate-games, make --isolate-games the default annihilate: actually ask permission before annihilating the wineprefix. gta_vc: ported, updated. Better fix for bug winezeug-25, should fix new bug winezeug-229 w_download: fix progress indicator gui for locales that use , as a decimal separator. Pointed out by kmiksi. Fixes bug winezeug-232. Add a paragraph at the top about what tools this script uses. Cleaned up comments at top. Moved version ID to very top. vc2005trial: update workarounds for wine-1.3.15 Last changeset was missing wildcards on two patterns Speed up common case of w_pathconv -u 3x by writing it in shell. Suggestion by Christian Storgaard. rayman2_demo: new verb. Based on a patch by Shannon. Make --optout take effect earlier. winetricks_stats_init: always quote W_CACHE dinput: new verb by Shannon, for winehq bug 21159 vd=640x480: new verb, by Shannon diablo2: ported and updated. (Next up: diablo2bc, battle chest version.) crysis2_demo_mp: fix non-q mode, use SetWinDelay to simplify. Patch by Phil. W_CACHE_WIN should just be a drive letter and colon in wine penpenxmas: new verb (based on a patch by Manpreet Sangha) crysis2_demo_mp: new verb by Austin sammax301_demo: new verb by Phil secondlife: ported and updated w_download: autohotkey's download server doesn't like curl's user agent, so use a more common one masseffect2_demo: partly fix windows install. (Clicks still not working.) w_mount: Port support for windows mounts of iso volumes. winetricks_read_volume_name: hexdump is not portable, use od instead w_read_key: create directory before storing key sims3: update to latest version, mention drm problem as showstopper masseffect2: mark as broken drm. masseffect2, masseffect2_demo: move workaround descriptions into w_workaround arg. masseffect2_demo: port verb firefox4: updated to beta12 dragonage: ported verb. Flickers terribly in movies for me :-( osmos_demo: bug 24416 fixed in 1.3.8 w_warn: in -q mode, time out after 5 seconds. Get rid of debug print. sims3: if we want menus to work, we have to install dotnet20. Move sudo detect after gui detect; fixes running winetricks-alpha from system menu ie68: no longer needed, now that ie8 works w_warn: text passed to zenity must be escaped ie8: make -q not fail install test. Fix --gui option, which was ignored because variable was reset after option was processed winetricks_set_wineprefix: Comment out debug print annihilate: only delete .desktop files. Use localized name for Desktop directory. Move silent option to top level menu ie8: set TabProcGrowth=0 to avoid hang. Fixes winezeug bug 159. Thanks to MatthiasLichter. Fix running on cygwin (W_DRIVE_C was wrong)

2 7

Try to fix bug 25999 , patch for dlls/mshtml/navigate.c
by Qian Hong 07 Mar '11

07 Mar '11

Hi Jacek, It seems http://bugs.winehq.org/show_bug.cgi?id=25999 has no update from Wine developers, my friend Zhuo Wei has write a patch for it, tests in dlls/mshtml/tests are run on Wine, ( according to http://www.winehq.org/docs/winedev-guide/testing-wine ), every test passes successfully, could you help to review it ? Thanks a lot! >From c5ee98396123c6cccdd295025a6b5aceb87dc0f7 Mon Sep 17 00:00:00 2001 From: Zhuo Wei <zhuo.wei.math(a)gmail.com> Date: Mon, 7 Mar 2011 23:58:09 +0800 Subject: Make sure This->bsc.doc will be initialized while opening a zero byte html file, fix bug 25999 . modified: dlls/mshtml/navigate.c --- dlls/mshtml/navigate.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..0e7a298 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -985,8 +985,6 @@ static HRESULT read_stream_data(nsChannelBSC *This, IStream *stream) read = 0; hres = IStream_Read(stream, This->nsstream->buf+This->nsstream->buf_size, sizeof(This->nsstream->buf)-This->nsstream->buf_size, &read); - if(!read) - break; This->nsstream->buf_size += read; @@ -1014,6 +1012,9 @@ static HRESULT read_stream_data(nsChannelBSC *This, IStream *stream) on_start_nsrequest(This); } + if(!read) + break; + This->bsc.readed += This->nsstream->buf_size; nsres = nsIStreamListener_OnDataAvailable(This->nslistener, -- 1.7.1 -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: [5/5] msi: Manage one assembly cache per major version of the .NET runtime.
by Vincent Povirk 07 Mar '11

07 Mar '11

> + static const WCHAR szVersion11[] = {'v','1','.','1','.','4','3','2','2',0}; > + static const WCHAR szVersion20[] = {'v','2','.','0','.','5','0','7','2','7',0}; No v4.0.30319 ?

2 1

Re: [1/5] msi/tests: Check the result of get_system_dirs and get_user_dirs.
by Marvin 07 Mar '11

07 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9724 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5967: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [PATCH] NTDLL atom.c documentation.
by Juan Lang 07 Mar '11

07 Mar '11

Hi Max, + * http://www.geoffchappell.com/studies/windows/win32/ntdll/history/names40.htm Please don't link to his site. As I said in an unrelated message to wine-patches last week, he used disassembly when performing his analysis: http://www.geoffchappell.com/viewer.htm?doc=notes/index.htm I wouldn't want to endorse such an effort implicitly by linking to him: future Wine developers could be misled. Thanks, --Juan

3 3

d3dcompiler_41: reflection interface.
by Rico Schüller 06 Mar '11

06 Mar '11

Hi, attached is a hacky patch which forwards the reflection interface from d3dcompiler_41 to d3dcompiler_43. I have a question to that implementation: DEFINE_GUID is used twice (dlls/dxguid/dx10guid.c and dlls/d3dcompiler_41/reflection.c) which could be bad. But the define was removed from the d3d11shader.h from ms, so it isn't officially available anymore. Should that be in a separate header to reduce redundancy or is the usage of both defines fine here? Cheers Rico

2 2

Re: d3dx9_36 [patch 2/3, resend]: Add tests for D3DXcreateTeapot
by Marvin 06 Mar '11

06 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: d3dx9_36 [patch 1/3, resend]: Add tests for D3DXCreateBox
by Marvin 06 Mar '11

06 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

USB Osciloscope
by Archie Robertson 06 Mar '11

06 Mar '11

I have a USB osciloscope (Link Instruments DSO 8002) that I am quite motivated to get working in wine. I have followed the instructions to install the USB patches. The osciloscope software works fine in demo mode, but it still cannot find the device. I have spent some time messing around with this, but I am new to wine, so I am a little lost. I am a half decent c programmer, so If somebody could point me in the right direction I should be able to get this working. I have gotten error message usbd.sys failed to load. I don't know if this program requires functions that wine does not support or I have just failed to install something correctly. I have attached lsusb and winedump -x output Any help would be greatly appreciated.

6 5

Re: urlmon/tests: Add a '\n' to an ok() call.
by Marvin 05 Mar '11

05 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9680 Your paranoid android. === WVISTAADM (32 bit url) === url.c:1535: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: olefont - fixed initial cyLogical value in IFont constructor. fixed get_Size to return same value as Window. (try 2)
by Marvin 05 Mar '11

05 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9673 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: WineHQ Bug 26271
by Dan Kegel 04 Mar '11

04 Mar '11

Dmitry Timoshkov wrote: > Are you going to encourage packagers to include whatever patches > they deem to be "an important feature" for the users, and still claim > that provide an official Wine binary package? There's a middle ground: ship both vanilla and patched wine, and make vanilla the default. I can even imagine distros packaging them up so they can both be installed at the same time. For instance, vanilla wine might be /usr/bin/wine as usual, but one patched for bug 6971 might be /usr/libexec/wine/wine-1.3-hotfix-6971/bin/wine. The patched one would be buried (kind of like gcc's internal files are buried) so they're easy for frontends like winetricks to use when present, but hard for casual users to accidentally use. Bug 6971 is the only one that comes to mind immediately as worth the effort, as it makes many games unplayable ( http://appdb.winehq.org/viewbugs.php?bug_id=6971 ). It occurs to me that fixing or providing a hotfix for this one bug, would get rid of most of PlayOnLinux's incentive to provide their own patched builds of wine. - Dan

1 0

Re: ws2_32: sendmsg on OS/X and BSD returns EMSGSIZE error for size 0
by Alexandre Julliard 04 Mar '11

04 Mar '11

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa ) > wsa->iovec[wsa->first_iovec].iov_len -= n; > } > } > + /* BSD and OS/X return EMSGSIZE if hdr.msg_iovlen is 0 */ > + else if ( hdr.msg_iovlen == 0 && errno == EMSGSIZE) > + ret = 0; This should never happen. We should always have at least one iov at that point, the callers should make sure of that. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: wininet(5/6): Obey cache directives and flags regarding caching
by Alexandre Julliard 04 Mar '11

04 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > From 13fce7b5e1efa74219d334bbce6661bd49a00601 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Wed, 2 Mar 2011 10:41:12 -0800 > Subject: [PATCH 08/19] Obey cache directives and flags regarding caching It fails here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:661: Test failed: expected ReportProgress_CACHEFILENAMEAVAILABLE Also the url.c test hangs forever. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Implement FindNextUrlCacheEntryW
by Alexandre Julliard 04 Mar '11

04 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > Brought to you by copy and paste. There's no reason to duplicate all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fixed default cyLogical in IFont constructor
by Marvin 04 Mar '11

04 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9650 Your paranoid android. === WNT4WSSP6 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2KPROSP4 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WXPPROSP3 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K3R2SESP2 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === WVISTAADM (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W2K8SE (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PRO (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (32 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0. === W7PROX64 (64 bit olefont) === olefont.c:106: Test failed: default scaling: default: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: default: gS after SR: Lo=130000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: default: hFont has lf.lfHeight=-20, expected -18. olefont.c:106: Test failed: default scaling: ratio1: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio1: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio1: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: ratio2: get_Size: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:129: Test failed: set ratio: ratio2: gS after SR: Lo=195000, Hi=0; expected Lo=180000, Hi=0. olefont.c:141: Test failed: set ratio: ratio2: hFont has lf.lfHeight=-39, expected -36. olefont.c:106: Test failed: default scaling: zero size: get_Size: Lo=97500, Hi=0; expected Lo=0, Hi=0. olefont.c:129: Test failed: set ratio: zero size: gS after SR: Lo=130000, Hi=0; expected Lo=0, Hi=0. olefont.c:141: Test failed: set ratio: zero size: hFont has lf.lfHeight=-10, expected 0. olefont.c:106: Test failed: default scaling: rounding: get_Size: Lo=195000, Hi=0; expected Lo=186000, Hi=0. olefont.c:129: Test failed: set ratio: rounding: gS after SR: Lo=130000, Hi=0; expected Lo=186000, Hi=0.

1 0

RFC: mmap override patch #2
by Chris Robinson 03 Mar '11

03 Mar '11

An updated attempt at the mmap override patch that I previously sent. This version properly uses a signed type for the mmap wrapper (as off_t/off64_t are signed types), fixes a few things with the munmap wrapper relating to truncated and sliced file_views, and implements a mremap wrapper for Linux. There's some debugging stuff left in the mremap wrapper since I have yet to catch anything that uses it, particularly using ERR instead of TRACE and an explicit abort() call so it isn't missed. There's also a %lld formatter in the mmap wrapper that will be fixed later. I'd be interested to hear how well it does or doesn't work, as well as any comments or critiques on the code.

1 0

Please help me with document extraction.
by Max TenEyck Woodbury 03 Mar '11

03 Mar '11

As my previous efforts have probably informed you, I am interested in documentation. My initial efforts were _not_ on target and had missed the existing 'c2man.pl' tool. I am in the process of correcting my failure on that. I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will listen to any advice. The c2man.pl code is extensive and sparsely commented. In order to understand what it does, I've made a transcription of it with a more compact style and lots more comments. I check the rewrite against the source code so there should not be any serious errors. There are also a number of what I believe to be defects in the original and places where my comments may be inappropriate or my style may be very objectionable. _This_ is what I need help with. Would someone be willing to review my rewrite? If so, send me e-mail so I can arrange to get a copy of it to you. P.S. to AJ et al. There is a _lot_ of documentation embedded in the wine code, but it is hard to find at the moment. I'd like to see it indexed and this is the program that does the extraction and indexing. Advice on making this new version available and active are in order. Max

4 11

Re: wininet(2/6): Store entries in url cache with valid expiration date
by Alexandre Julliard 03 Mar '11

03 Mar '11

Juan Lang <juan.lang(a)gmail.com> writes: > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && *nextPtr == ':' && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wMinute = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + ret = FALSE; > + num = strtoulW(ptr, &nextPtr, 10); > + if (nextPtr > ptr && isspaceW(*nextPtr) && num <= 59) > + { > + ptr = nextPtr + 1; > + st.wSecond = (WORD)num; > + ret = TRUE; > + } > + } > + if (ret) > + { > + static const WCHAR gmt[]= { 'G','M','T',0 }; > + > + ret = FALSE; > + while (isspaceW(*ptr)) > + ptr++; > + if (!strcmpW(ptr, gmt)) > + ret = TRUE; > + } You may want to consider using 'return', it's quite convenient... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] mshtml: Added support for indexed access to form elements
by Alexandre Julliard 03 Mar '11

03 Mar '11

Jacek Caban <jacek(a)codeweavers.com> writes: > + /* FIXME: Implement in more generic and safe way */ > + for(ptr = name; *ptr && isdigitW(*ptr); ptr++) > + i = i*10 + (*ptr-'0'); What's wrong with strtoulW? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: mountmgr.sys: start detecting USB devices
by Maarten Lankhorst 03 Mar '11

03 Mar '11

Hi Damjan, Op 02-03-11 18:52, Damjan Jovanovic schreef: > Changelog: > * mountmgr.sys: start detecting USB devices I'd love to get this kind of work in, but since libhal has been deprecated for a while, wouldn't it be better to use libudev directly instead of expanding our usage of libhal? Cheers, Maarten

2 1

Why am I getting create_view out of memory?
by Peter Urbanec 03 Mar '11

03 Mar '11

I've got a heavily multithreaded 64-bit app that uses a lot of memory. After a while, I see this: fixme:virtual:create_view out of memory in virtual heap for 0x7f94465b0000-0x7f94466d6000 fixme:virtual:create_view out of memory in virtual heap for 0x7f9446640000-0x7f94466d3000 fixme:virtual:create_view out of memory in virtual heap for 0x7f9446690000-0x7f94466da000 fixme:virtual:create_view out of memory in virtual heap for 0x7f94466b0000-0x7f94466d5000 Could someone please explain to me what's going on here? Quick look at the code indicates that there is a 4MB heap used for "views" (I have no idea what these are) and presumably that heap is exhausted. Is this likely a resource leak somewhere? Some memory stats on the app I'm running: Process: PeakVirtualSize 3f2baf000, VirtualSize 3eccd0000 PeakWorkingSetSize 3762d6000, WorkingSetSize 3689ac000 PeakPagefileUsage 3f2baf000, PagefileUsage 3eccd0000 Global: TotalPhys 3eb4f2000, AvailPhys 0c4d8000 TotalPageFile 66b984000, AvailPageFile 1733eb000 TotalVirtual 7ffffffdffff, AvailVirtual 7ffc1330ffff Cheers, Peter Urbanec

2 1

Re: WineHQ Bug 26271
by Dmitry Timoshkov 03 Mar '11

03 Mar '11

[Please do not exclude wine-devel when repying] Andreas Bierfert <andreas.bierfert(a)lowlatency.de> wrote: > > That's precisely my point. How many users are prepared to compile Wine > > from source when they report a bug with such a Wine build, and > > somebody > > asks them to either use a package without custom patches or compile > > Wine > > om their own instead? > > I am not a normal user but the packager. Hence I at least hope to have a > better understanding of what bugs should go upstream and what bugs are > related to some packaging issues or custom patches. In this way I have > no problem to rebuild or try fixes or whatever seems necessary to get > the bug fixed. The question was not about the packager, but about the normal users who has a problem and wants to report a bug. What is a difference between users using your package and crossover/ies4linux/playonlinux/etc. or whatever packager who includes say unofficial DIB engine patches? > > It's very doubtful in the first > > place that the term "official" should be used for such packages. Are > > you going > > to encourage packagers to include whatever patches they deem to be "an > > important > > feature" for the users, and still claim that provide an official Wine > > binary > > package? > > That raises more interesting questions: How would you describe an > official build? What do you do if some libraries are not available and > hence cannot build a full featured wine? But is this really the > important question? There is a Wine wiki page for packagers, and the bugs reporting instructions I pointed out already. Both of them imply using "not modified in any way Wine source". > Of course you may ask the question: Why does the fedora maintainer > include pulseaudio patches in the fedora wine package. And I am glad to > give you an answer: The default fedora spin has been using pulseaudio > for quite some time. It is an important feature of fedora. As I like to > provide users with an out-of-the-box experience wherever possible, it is > my duty to see and investigate where this can be provided for users. In the first place you should ask yourself, what makes you feel that those pulseaudio patches are really necessary? What doesn't work? Have you reported bugs? Where? Have you tested without pulseaudio in the system and can claim that it's the problems implied by Wine and not pulseaudio bugs? > I never understood why wine upstream was so reluctant about including > the pulseaudio patches. They do work well, there are people who maintain > the patches and there is a big userbase for pulseaudio these days. See the relevant bug report about pulseaudio support in Wine, it's been explain many times already. [skipped] -- Dmitry.

1 0

Re: wininet(3/6): Default to 10 minutes expiration for cache entries
by Dmitry Timoshkov 03 Mar '11

03 Mar '11

Juan Lang <juan.lang(a)gmail.com> wrote: > + if (!expirationFound) > + { > + SYSTEMTIME st; > + > + /* With no known age, default to 10 minutes until expiration. */ > + GetSystemTime(&st); > + if (st.wMinute < 50) > + st.wMinute += 10; > + else > + { > + st.wHour += 1; > + st.wMinute -= 50; > + } > + SystemTimeToFileTime(&st, &request->expires); > } Well, st.wHour could also everflow, it shuild be easier to add an appropriate period to the resulting 64-bit number. -- Dmitry.

1 0

Re: winex11.drv: Ensure that wintab xinput_handle is not NULL.
by John Klehm 03 Mar '11

03 Mar '11

On Mon, Feb 28, 2011 at 8:50 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > --- > dlls/winex11.drv/wintab.c | 13 ++++++++++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > Nice find on this code path being able to run without loading xinput. I have a couple comments: You don't need to guard inside GetCurrentPacket. It's only called when WT_PACKET is passed to the global tablet event hwnd message queue. WT_PACKET is only sent to that queue from XInput event handlers that get registered when xinput is loaded. In short GetCurrentPacket won't get called if xinput isn't loaded so I don't believe it needs the xinput check. As for the AttachEventQueue and WTInfoW checks: I think we'd achieve the same end by having a loaded check in WTOpen just like we do in WTInfo. The benefit would be that we'd let the app know sooner that something was wrong. As it is right now we try to load but don't return 0 if we fail to load in dll/wintab32/context.c:WTInfoT: 370 if (gLoaded == FALSE) 371 LoadTablet(); 372 If we return 0 when loading fails in the dll/wintab32 WTInfo and WTOpen entry points we save the trouble of running through a bunch of function calls that are doomed to fail anyway. Even worse in most places in the wintab code we don't check if the winex11 calls succeed or fail. This would require modifications to LoadTablet and its winex11 buddy LoadTabletInfo so they could bubble up the failure. Regards, --John Klehm

2 1

Re: WineHQ Bug 26271
by Dmitry Timoshkov 03 Mar '11

03 Mar '11

Andreas Bierfert <andreas.bierfert(a)lowlatency.de> wrote: > could you please stop arguing about the validity of the bug. What you > are stating in comment 6 is really not exclusive. The Fedora wine > packages are in fact 'prepackaged binary'. Using the term 'prepackaged binary' doesn't make the package suddenly valid for WineHQ bugzilla, since it clearly contains not supported patches. Same applies for instance to crossover, ies4linux, wineskin or any other. > For the Fedora users pulse support in wine is an important feature. This > is why the patches are in the Fedora build in the first place. I'd much > rather have them included with upstream... Maybe sometime wine will gain > openal support for audio input/output and this issue will go away. Once again, packages with custom patches can't be supported through WineHQ bugzilla for obvious reasons. If the packager knows what he/she is dooing by including such patches - he/she should take the full resposibility for that, including accepting bug reports for his package. If he/she doesn't want to carry the support burden then using Wine source without any custom patches is the way to go. -- Dmitry.

4 6

Re: [PATCH] shldocvw: Fixed typo = vs == (Coverity)
by Marcus Meissner 02 Mar '11

02 Mar '11

On Fri, Feb 25, 2011 at 09:30:21PM +0100, Eric Pouech wrote: > Le 25/02/2011 14:16, Marcus Meissner a écrit : > >CID1801 > >--- > > dlls/shdocvw/shlinstobj.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/dlls/shdocvw/shlinstobj.c b/dlls/shdocvw/shlinstobj.c > >index d272c91..067e678 100644 > >--- a/dlls/shdocvw/shlinstobj.c > >+++ b/dlls/shdocvw/shlinstobj.c > >@@ -376,7 +376,7 @@ HRESULT SHDOCVW_GetShellInstanceObjectClassObject(REFCLSID rclsid, REFIID riid, > > > > /* Figure if there is an 'Instance' subkey for the given CLSID and acquire a handle. */ > > if (!StringFromGUID2(rclsid, wszInstanceKey + 6, CHARS_IN_GUID) || > >- !(wszInstanceKey[5+CHARS_IN_GUID]='\\') || /* Repair the null-termination. */ > >+ !(wszInstanceKey[5+CHARS_IN_GUID] == '\\') || /* Repair the null-termination. */ > > ERROR_SUCCESS != RegOpenKeyExW(HKEY_CLASSES_ROOT, wszInstanceKey, 0, KEY_READ,&hInstanceKey)) > > { > > /* If there is no 'Instance' subkey, then it's not a Shell Instance Object. */ > are you sure about the fix ? > it looks like it's intentional that the test always succeed (it just > replaces the null termination char written in StringFromGUID2 with a > '\\') > (and this would explain the comment as well ;-) > I'm not familiar with the code... just being suspicious This was right, I fixed it. :) Ciao, Marcus

1 0

Re: t2embed: Add stub for _TTEmbedFont
by Dmitry Timoshkov 02 Mar '11

02 Mar '11

André Hentschel <nerv(a)dawncrow.de> wrote: > diff --git a/dlls/t2embed/t2embed.spec b/dlls/t2embed/t2embed.spec > index 2566fa2..729a71b 100644 > --- a/dlls/t2embed/t2embed.spec > +++ b/dlls/t2embed/t2embed.spec > @@ -11,7 +11,7 @@ > @ stub TTRunValidationTests > @ stub _TTCharToUnicode@24 > @ stub _TTDeleteEmbeddedFont@12 > -@ stub _TTEmbedFont@44 > +@ stdcall _TTEmbedFont(ptr long long ptr ptr ptr ptr ptr long long ptr) This change is not correct, the exported name is _TTEmbedFont@44. -- Dmitry.

1 0

Re: [PATCH 5/5] mshtml: Added more attribute object tests
by Marvin 02 Mar '11

02 Mar '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9625 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === Timeout === W2K8SE (32 bit dom) === Timeout

1 0

Problems with change to cursor and keyboard handling
by Erich Hoover 02 Mar '11

02 Mar '11

The recent changes to the cursor and keyboard handling absolutely kill performance in Fallout: New Vegas. The cursor changes cause the mouse to jump around (when you move the mouse while using the keyboard) and the keyboard-specific changes cause the entire game to lock up temporarily about once a second when moving solely by keyboard. I believe I've narrowed down the problem with the keyboard changes (the issue is caused by commit bc4afb078677095468d4ee8f9a15c18cbb47bbbf, see attached proposed fix), but I did not have time this evening to explore the root cause of the cursor problem. Since I'm not certain why this particular line in the commit was changed in the first place, I figured I'd bring it up here, in case I'm missing something, before sending the attached to wine-patches. Erich Hoover ehoover(a)mines.edu

1 0

Re: hhctrl.ocx: Decode HTML entities in contents and index
by Alexandre Julliard 01 Mar '11

01 Mar '11

Owen Rudge <orudge(a)codeweavers.com> writes: > +static int cmp(const void *key, const void *element) > +{ > + HtmlEntity *entity = (HtmlEntity *) element; > + return strncmpW((LPCWSTR) key, entity->string, lstrlenW(entity->string)); > +} This won't work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Check for the Palette before using it
by Henri Verbeet 01 Mar '11

01 Mar '11

2011/2/28 André Hentschel <nerv(a)dawncrow.de>: > *Pal = wined3d_palette_get_parent(wined3d_palette); > - IDirectDrawPalette_AddRef(*Pal); > + if (*Pal) IDirectDrawPalette_AddRef(*Pal); > + else hr = DDERR_NOPALETTEATTACHED; This doesn't make sense, the parent shouldn't be NULL. You should figure out what sets it to NULL. You also may want to try warn+heap to see if it's getting free'd or corrupted somewhere.

1 0

Fwd: Applications for Mentoring Organizations Now Being Accepted
by Dan Kegel 01 Mar '11

01 Mar '11

So, shall I do the honors? ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce <google-summer-of-code-announce(a)googlegroups.com> Hi all, We're pleased to announce the applications for mentoring organizations for Google Summer of Code 2011 are now being accepted [1]. Please go Melange [2] to apply on behalf of your organization. Please note that the application period [3] closes on 11 March at 23:00 UTC [4]. [1] - http://google-opensource.blogspot.com/2011/02/mentoring-organization-applic… [2] - http://www.google-melange.com [3] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ti… [4] - http://goo.gl/paMZU Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Announce" group. To post to this group, send email to google-summer-of-code-announce(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-announce+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-announce?hl=en.

2 1

Re: shlwapi/tests: remove win9x hacks (try 2)
by Nikolay Sivov 28 Feb '11

28 Feb '11

On 3/1/2011 01:28, Austin English wrote: > Apparently it's flaky on win2k...cleared WTB: > https://testbot.winehq.org/JobDetails.pl?Key=9585 > - /* shlwapi on Win98 SE does not appear to apply delimiters to the output > - * and does not correctly handle extremely large values. */ > - ok(!strcmp(result->kb_size, szBuff) || > - (result->kb_size_broken&& !strcmp(result->kb_size2, szBuff)), > - "Formatted %x%08x wrong: got %s, expected %s\n", > + ok(!strcmp(result->kb_size, szBuff), "Formatted %x%08x wrong: got %s, expected %s\n", > (LONG)(result->value>> 32), (LONG)result->value, szBuff, result->kb_size); I think it's better to keep comments that describe version dependent behaviour even if it's not tested by default now.

1 0

Re: ntprint/tests: remove win9x hacks
by Marvin 28 Feb '11

28 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9577 Your paranoid android. === WNT4WSSP6 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2KPROSP4 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WXPPROSP3 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K3R2SESP2 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WVISTAADM (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K8SE (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PRO (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (64 bit ntprint) === Timeout

1 0

Re: shlwapi/tests: remove win9x hacks
by Marvin 28 Feb '11

28 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9576 Your paranoid android. === W2KPROSP4 (32 bit string) === string: unhandled exception c0000005 at 77C84DD7

1 0

Re: gdi32: Fixes GetDIBits for top-down destination bitmaps (Bug #26236).
by Alexandre Julliard 28 Feb '11

28 Feb '11

John Edmonds <pocketcookies2(a)gmail.com> writes: > Resolves Bug #26236. Please update the test cases to catch this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36: Stub ID3DXRenderToSurface, with tests
by Henri Verbeet 28 Feb '11

28 Feb '11

On 27 February 2011 20:22, Misha Koshelev <misha680(a)gmail.com> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID riid, void **ppobj) > +{ > + ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface); You don't actually need "This" here. > + return D3D_OK; S_OK is more appropriate for QueryInterface. > + WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj); > + return E_NOINTERFACE; > +} You should set "*ppobj" to NULL here, unless there's a reason not to.

1 0

Re: jscript: Fixed corner cases in parseInt implementation
by Marvin 28 Feb '11

28 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9558 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine
by Joerg-Cyril.Hoehle＠t-systems.com 28 Feb '11

28 Feb '11

Hi, I used to run Valgrind with the additional options --malloc-fill=A5 --free-fill=DE around Wine 1.2 times. Now I retried it and it crashes Wine 1.3.13 and 1.3.14 (it fails to load kernel32.dll). It turns out that malloc-fill is harmless, -free-fill causes havoc currently. Am I the only one using or seeing this (Ubuntu Lucid)? Thanks for your help, Jörg Höhle

3 3

Re: gdi32: first look for a printer driver name in the registry (try 6)
by André Hentschel 27 Feb '11

27 Feb '11

Hi, Now you entirely remove the ini-stuff, why? and why do you use a OR (||) for the registry function? -- Best Regards, André Hentschel

2 1

Re: [2/2] msxml3: Reject xmlns attribute to be added to element
by Marvin 27 Feb '11

27 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9543 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 90909090 === WXPPROSP3 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 749BCF8E === W2K3R2SESP2 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 90909090 === WVISTAADM (32 bit domdoc) === domdoc: unhandled exception c0000005 at FF85F88B === W2K8SE (32 bit domdoc) === domdoc: unhandled exception c0000005 at FF8B9090 === W7PRO (32 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057 === W7PROX64 (32 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057 === W7PROX64 (64 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057

1 0

Re: msxml3/tests: Remove broken test and parameter check
by Nikolay Sivov 27 Feb '11

27 Feb '11

On 2/27/2011 22:09, Nikolay Sivov wrote: > Test was recently enabled, and it crashes on several machines, > including mine. QueryInterface generally should never check for return > pointer. > Ignore that please, there's another line to remove.

1 0

Re: [PATCH 1/5] d3dcompiler: Fix SystemValueType for pixelshader output signature.
by Henri Verbeet 27 Feb '11

27 Feb '11

2011/2/27 Rico Schüller <kgbricola(a)web.de>: > +static BOOL case_insensitive_compare(const char *s1, const char *s2) Isn't that called strcasecmp()?

1 0

Patches to fix GetDIBits for top down destination bitmaps
by John Edmonds 27 Feb '11

27 Feb '11

Please ignore the patches http://source.winehq.org/patches/data/71716 and http://source.winehq.org/patches/data/71711. I was having trouble with my mail client and accidentally sent the same code 3 times.

1 0

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.
by Nikolay Sivov 27 Feb '11

27 Feb '11

On 2/26/2011 23:01, Gerald Pfeifer wrote: > --- > dlls/comctl32/tooltips.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index a2e58e0..445845c 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW) > > > static LRESULT > -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit, > - BOOL isW) > +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit) > { > TTTOOL_INFO *toolPtr; > INT nTool; > @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > > case TTM_HITTESTA: > case TTM_HITTESTW: > - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, > - uMsg == TTM_HITTESTW); > + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); > + > case TTM_NEWTOOLRECTA: > case TTM_NEWTOOLRECTW: > return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); This should properly handle text instead of removing A/W case.

2 1

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)
by Misha Koshelev 27 Feb '11

27 Feb '11

> Hi Misha, > > ... > > I'm attaching your patch with some modifications (mostly I took some > missing pieces from my old, way broken, patch). It seems to help a bit > but it's not perfect yet. It fixes handling of > 65520.0 values and > denormalized numbers. The interesting bit was to have some ad-hoc > rounding for the denormalized case. > The current implementation doesn't match native on some rounding > cases, but it's not clear what really the issue is. If you replace >= > with a > in "if (tmp - mantissa >= 0.5f) mantissa++;" you essentially > switch some failing cases with others. Maybe it has something to do > with floating point CPU rounding mode, but that seems unlikely to me. > Some testing under Windows is also needed. > > Ok, that's all. Please continue your work, correct 32/16 bit float > conversion functions are really a good thing to have (and you can fix > the implementation in wined3d after this is done ;)) > Hi Guys, Just thought I'd forward to the list (I hope it's ok Matteo). I'm pretty stumped. Matteo's patches were a big help. I did test on Windows and saw same result. My own (very unhelpful) diagnosis of the pattern is that, for the mantissa values: 2018.5 should round to 2018 2019.5 should round to 2020 2016.5 should round to 2016 2017.5 should round to 2018 2014.5 should round to 2014 2015.5 should round to 2016 2012.5 should round to 2012 2013.5 should round to 2014 1954.5 should round to 1954 1955.5 should round to 1956 1952.5 should round to 1952 1953.5 should round to 1954 1950.5 should round to 1950 1951.5 should round to 1952 1948.5 should round to 1948 1949.5 should round to 1950 I have attached a patch that makes this explicit and has just one failing test. Unfortunately, if we change the increment from 0xfff to 0xff, we seem to have a lot more disagreements. If anyone has any ideas pls let me know. I am stumped. I am going to see if perhaps I can make the relevant game work better by stubbing, and, if so, will submit a stub patch for now. Thank you Misha p.s. Note: the singles2halfp function is not mine, and is licensed under the BSD license. I modified it slightly to see if it would make things better. It didn't. It is not meant to actually be included in Wine but is useful for testing. http://www.mathworks.com/matlabcentral/fileexchange/23173 Thank you

2 2

Re: [3/3] comctl32/tests: Add a statusbar test for setting number of parts to zero.
by Marvin 27 Feb '11

27 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9486 Your paranoid android. === WNT4WSSP6 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2KPROSP4 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === WXPPROSP3 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2K3R2SESP2 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === WVISTAADM (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W2K8SE (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PRO (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PROX64 (32 bit status) === status.c:412: Test failed: Expected 1, got 0 === W7PROX64 (64 bit status) === status.c:412: Test failed: Expected 1, got 0

2 1

Re: kernel32/tests: remove win9x hacks (try 2)
by Damjan Jovanovic 26 Feb '11

26 Feb '11

On Wed, Feb 23, 2011 at 11:38 AM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > > So test.winehq.org doesn't test Win9x any more, but why are we throwing away perfectly good Win9x tests that took years to get in?

6 10

Re: [wiki] Fix Link to MoinMoin
by John Klehm 26 Feb '11

26 Feb '11

2011/2/26 André Hentschel <nerv(a)dawncrow.de>: > - 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://moinmoin.wikiwikiweb.de/">MoinMoin Powered</a>' > + 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://www.moinmo.in/">MoinMoin Powered</a>' Death to www? Just http://moinmo.in/ perhaps? Regards, --John

1 0

Slides for Wine talk at Scale tomorrow
by Dan Kegel 26 Feb '11

26 Feb '11

Anyone going to be at Scale in Los Angeles this weekend? I'll be giving a talk there tomorrow afternoon, showing off how well Wine works and demonstrating how to use and extend winetricks. Draft slides are up at http://kegel.com/wine/scale9x/ I still have time to tweak them, so if you have suggestions

2 2

Re: gdi32/tests: remove win9x hacks
by Marvin 25 Feb '11

25 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9519 Your paranoid android. === WVISTAADM (32 bit icm) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: crypt32/tests: remove win9x hacks
by Marvin 25 Feb '11

25 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9515 Your paranoid android. === WNT4WSSP6 (32 bit store) === store.c:962: Test failed: Expected 1 certificates, got 2 store.c:1761: Test failed: Expected CRYPT_E_ASN1_BADTAG, got 80093005

1 0

Dynamic OpenSSL import library
by Tim Burrell 25 Feb '11

25 Feb '11

Hi all, I'm one of TransGaming's R&D developers working on our portability products. We've recently done a cleanup and refactoring to the OpenSSL loading routines; rather than loading the libraries in a few different places we moved the code into an OpenSSL importer that consolidates the loading into a separate library. Our importer does some additional things that might not be overly useful to Wine, such as detecting and loading different versions of the OpenSSL libraries at runtime (rather that using the version detected while configuring), but the cleanup and refactoring worked out quite well, and we think the code would still be valuable to Wine. We could port this code back to the Wine tree, but it will take some effort to do so. Also, our current implementation of the dynamic OpenSSL importer isn't complete; we're only loading the specific functions we've needed up until now. Before going to the effort of completing the library, and porting it back to the Wine tree, I thought I'd reach out first to see if it's even something that's of interest? If it is, great, we can complete the library and submit some patches for review, but if the concept isn't of interest then we'll just continue using it internally. I've attached a copy of the main C file from the OpenSSL import library, so you can get an idea for what it will look like. Keeping in mind that it's not finished yet, and needs some cleaning up, does this approach look acceptable? Also attached is a patch (that won't directly apply) that should give an idea of its intended usage. Anyone have thoughts / questions? Thanks, Tim. -- Tim Burrell TransGaming <http://transgaming.com> Inc. 431 King Street West, Suite 600 Toronto, Ontario, Canada M5V 1K4

3 2

Is the Call for Translators forum sticky still needed?
by Rosanne DiMesio 25 Feb '11

25 Feb '11

The original post asked for help leading up to the release of 1.2. That's obviously outdated, and the thread now just attracts spammers. Should it be updated, or simply removed? -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: gdi32: Fix 64-bit pointer issues when copying upside-down bitmaps.
by Marcus Meissner 25 Feb '11

25 Feb '11

On Fri, Feb 25, 2011 at 11:41:31PM +1100, Peter Urbanec wrote: > --- > dlls/gdi32/dib.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c > index 0619304..595eb9b 100644 > --- a/dlls/gdi32/dib.c > +++ b/dlls/gdi32/dib.c > @@ -885,7 +885,7 @@ INT WINAPI GetDIBits( > */ > if (bmp->dib->dsBmih.biHeight < 0) > { > - sbits += (srcwidthb * (abs(bmp->dib->dsBmih.biHeight) - 2 * startscan - 1)); > + sbits += (srcwidthb * (LONG)(abs(bmp->dib->dsBmih.biHeight) - 2 * startscan - 1)); Please enlighten us to the problem you are fixing? I see no 64bit pointer relation...? Ciao, Marcus

2 1

Re: winspool.drv: return maximum possible size of the buffer when no buffer is specified
by Alexandre Julliard 25 Feb '11

25 Feb '11

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -7247,7 +7247,7 @@ static BOOL get_job_info_2(job_t *job, JOB_INFO_2W *ji2, LPBYTE buf, DWORD cbBuf > else > { > /* align DEVMODE to a DWORD boundary */ > - shift= (4 - ( (DWORD_PTR) ptr & 3)) & 3; > + shift= ptr ? (4 - ( (DWORD_PTR) ptr & 3)) & 3 : 3; It should most likely align from the start of the data, not from the pointer value. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: first look for a printer driver name in the registry (try 5)
by Dmitry Timoshkov 25 Feb '11

25 Feb '11

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!hKey) RegCloseKey(hKey); This one is still not fixed. -- Dmitry.

2 1

Re: [PATCH] gdi32: Fix glyph orientation for inverted axis in compatible mode.
by Dmitry Timoshkov 25 Feb '11

25 Feb '11

Alexander Kochetkov <al.kochet(a)gmail.com> wrote: > This is for the test application attached to the bug #22996 > I'm not sure, should I remove FT_IS_SCALABLE? How can I test the patch with non > scalable font? Could you please give me some advice? Testing with a non-scalable font should be easy, just use System instead of Arial as a font name. Regaring FT_IS_SCALABLE your patch just follows current logic and changes nothing. -- Dmitry.

1 0

Re: localspl/tests: test cleanup
by Marvin 25 Feb '11

25 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9481 Your paranoid android. === WVISTAADM (32 bit localmon) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

More FAQ reverts
by Vitaliy Margolen 25 Feb '11

25 Feb '11

In case kjensen will start looking why I reverted his changes - they are wrong. Obviously he didn't test them. > $1 "`wine winepath -u "$2"`" | sed 's/ /\\ /' Not sure how piping output of a native command through sed will fix "argument to the program contain spaces it will not work". The argument with spaced does perfectly work with current script. That's why there are two pairs of double quotes. > @="/bin/sh ~/bin/run_linx_program ooffice \"%1\"" This is bogus, Wine does not perform *NIX shell expansions (~ is a shell expansion). Vitaliy.

1 0

GSOC idea to implement the explorer
by Andrew Green 25 Feb '11

25 Feb '11

I was just looking at the Google summer of code(GSOC) ideas and noticed "implement the explorer". This grabbed my attention as I have recently been working on a windows xp explorer clone. Also it mentions a reference to ReactOS explorer written in c++. Well there is a second explorer which is planned to be more true to the xp implementation and written in c. Currently it's called explorer new as it is not yet complete and is just a shell. I was wondering if it was possible to share this code. As it would probably be beneficial in the long term. It already has support for shell extensions. When running under windows I can add any extension such as Quick launch, language bar and so on. Here is a pic of my working copy(trunk doesn't have this theming yet. Though I should finish it soon) http://img156.imageshack.us/f/yaytheme.png/ This is just an idea. I know it's very incomplete. Though it is showing promise. Here is a link to the "GSOC implement the explorer" page I mentioned http://wiki.winehq.org/SummerOfCode#head-18241c95194e4e1c597bd2923cf296084f… Any comments and ideas are much appreciated.

4 5

Re: oleaut32/tests: fix a couple todo_wine's
by Marvin 25 Feb '11

25 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9472 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] user32: Fixed some more sideeffect functions in assert() (Coverity)
by Marvin 24 Feb '11

24 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9451 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: msvcrt/tests: Don't test function directly when reporting errno
by Marvin 24 Feb '11

24 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9458 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: urlmon/tests: Add BINDSTATUS_DECODING progress case
by Jacek Caban 24 Feb '11

24 Feb '11

Hi André, On 2/24/11 6:52 PM, André Hentschel wrote: > happens on nt, xp and 2k3 That's the effect of switching winehq.org to using gzip. I think we need to change all different http-related tests to use a centralized place for tests. Something like set of PHP scripts on test.winehq.org or a new domain that would give use more control over http headers and content is something I have in minnd. Current solution of using random URLs that happen to be good for specific task has proven to be wrong and results in less strict tests than we could achieve otherwise. Also BINDSTATUS_DECODING should be sent by IE older than 7 and we don't want to allow it on Wine. Anyway, I think the fix should be more sophisticated. Jacek

1 0

Re: gdi32: Use graphics mode specified at the EMF creation time when playing EMR_EXTTEXTOUT record.
by Alexander Kochetkov 24 Feb '11

24 Feb '11

> + > + SetGraphicsMode(hdc, old_mode); > break; > } > Hi, Dmitry Timoshkov! Needs to reselect font again after restore old_mode in case pExtTextOutW-> iGraphicsMode != old_mode. Otherwise, the font will remain with the wrong glyph orientation. I can write a test demonstrating the problem. Resect font is needed only if pExtTextOutW-> iGraphicsMode is GM_COMPATIBLE. This is performance optimization for GM_ADVANCED. Thank, you!

1 1

Re: [PATCH 5/7] mshtml: Added attribute object tests
by Marvin 24 Feb '11

24 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9448 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === W2K8SE (32 bit dom) === dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6923: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0

Re: [PATCH 1/7] mshtml: Added IHTMLElement4 stub implementation
by Marvin 24 Feb '11

24 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9447 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === WVISTAADM (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 === W2K8SE (32 bit dom) === dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002 dom.c:6851: Test failed: Could not get {3051042D-98B5-11CF-BB82-00AA00BDCE0B} interface: 80004002

1 0

Re: gdi32: Fix the glyph rotation transformation matrix.
by Alexander Kochetkov 24 Feb '11

24 Feb '11

Hi, Dmitry Timoshkov! The patch brakes rotation for modes with positive axis. Try apply this patch to the test application attached to the bug #22996.

1 1

Re: kernel32/tests: remove win9x hacks
by Paul Vriens 24 Feb '11

24 Feb '11

On 02/23/2011 10:15 AM, Austin English wrote: > SetLastError(0xdeadbeef); > ret = GetFullPathNameW(NULL, 0, NULL, NULL); I think you can get rid of the above two as well as they are merely used to trigger the ERROR_CALL_NOT_IMPLEMENTED. > - is_win9x = !ret&& GetLastError() == ERROR_CALL_NOT_IMPLEMENTED; > - > - if (is_win9x) > - win_skip("Skipping some tests that cause GetFullPathNameA to crash on Win9x\n"); -- Cheers, Paul.

4 3

Apologies to the List
by James McKenzie 24 Feb '11

24 Feb '11

First, my tirade was not intended to be as such. I wanted to pull the patch because it was incorrect and I did not want anyone else working on it while I silently trimmed it and made it better. Second, I realize this has affected my 'Jeremy White' score. I hope that AJ understands why the code was pulled and that this happens frequently with a project this large. I am aware that the code was placed into the LGPL at the time it was posted to Wine Patches. Third, I will be posting here three patches for riched20/test/editor.c. It is my desire that these patches be examined, with a critical eye and feedback applied. Be brutal, be blunt and most of all be helpful. If I write back that I don't understand what you are talking about, I really don't and may need additional guidance (examples, pointing out other code with a similar purpose.) This is how we grow and learn. Very respectfully, James McKenzie

3 5

Re: include: Add an errno number
by Alexandre Julliard 23 Feb '11

23 Feb '11

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -23,6 +23,7 @@ > > # define EPERM 1 > # define ENOENT 2 > +# define ENOFILE ENOENT I don't see that in the MS headers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] user32: make DIB_GetBitmapInfo checks stricter
by Alexandre Julliard 23 Feb '11

23 Feb '11

Wolfram Sang <wolfram(a)the-dreams.de> writes: > @@ -988,6 +988,9 @@ static void test_LoadImage(void) > bmpimage[0x18]++; /* biWidth > 65535 */ > test_LoadImageFile("BMP (too wide)", bmpimage, sizeof(bmpimage), "bmp", 0); > bmpimage[0x18]--; > + bmpimage[0x11]++; /* biSize > 2^24 */ > + test_LoadImageFile("BMP (broken biSize)", bmpimage, sizeof(bmpimage), "bmp", 0); > + bmpimage[0x11]--; That's not a very convincing test. You should test more interesting sizes like intermediate values, off-by-one, etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: avicap32: Use define instead of hardcoded value
by André Hentschel 23 Feb '11

23 Feb '11

sry, please ignore that one. -- Best Regards, André Hentschel

1 0

Re: comctl32: Add missing break (Coverity)
by Nikolay Sivov 23 Feb '11

23 Feb '11

On 2/23/2011 19:28, Amine Khaldi wrote: > CIDs 1581 and 1583. > @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, > WPARAM wParam, LPARAM lParam, > > case VK_UP: > step = -1; > + break; > case VK_DOWN: > /* by default, step is 1 */ > oldItem = SendMessageW (infoPtr->hwndSelf, CB_GETCURSEL, 0, 0); This is wrong. > @@ -2297,6 +2297,7 @@ static LRESULT > TOOLBAR_Cust_AvailDragListNotification(const CUSTDLG_INFO *custIn > TOOLBAR_Cust_AddButton(custInfo, hwnd, nIndexFrom, nIndexTo); > } > } > + break; > case DL_CANCELDRAG: > /* Clear drag arrow */ > DrawInsert(hwnd, hwndList, -1); Why? Looks to me it's fine to clear on dropped case too. Coverity is a bit paranoid about missed breaks. Also don't include completely unrelated changes to one patch. > > Regards, > Amine. > > >

3 4

Re: d3dcompiler_43: Add missing break (Coverity)
by Matteo Bruni 23 Feb '11

23 Feb '11

2011/2/23 Amine Khaldi <amine.khaldi(a)reactos.org>: > CID 1585. > > Regards, > Amine. > This doesn't seem to be the correct fix. With that break you aren't going to return any string and that will cause problems thereafter. You should replace the "case 2:" with "default:" instead (like BWRITERSPR_RASTOUT some rows above). BTW, thanks for the patches!

1 0

Re: gdi32: first look for a printer driver name in the registry (try 3)
by Dmitry Timoshkov 23 Feb '11

23 Feb '11

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!hKey) RegCloseKey(hKey); This is a typo. -- Dmitry.

1 0

Re: [PATCH] user32: remove side effect code out of asserts() (Coverity)
by Marvin 23 Feb '11

23 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: comctl32: Add missing break (Coverity)
by Marcus Meissner 23 Feb '11

23 Feb '11

On Wed, Feb 23, 2011 at 05:28:28PM +0100, Amine Khaldi wrote: > CIDs 1581 and 1583. > > Regards, > Amine. the comboex one seems to be intended to fall through to the next case. Ciao, Marcus

1 0

Re: [PATCH] cryptui: fixed bad sizeof() (Coverity)
by Vitaliy Margolen 23 Feb '11

23 Feb '11

On 02/22/2011 09:30 PM, Marcus Meissner wrote: > Hi, > > CID 1181. copying a pointer to a struct into a struct is likely bad, > fixed. > > - memcpy(&infoW,&info, sizeof(info)); > + memcpy(&infoW, info, sizeof(*info)); Should probably use direct struct copying instead: infoW = *info; Vitaliy.

2 1

Re: [2/5] msxml3: Remove appendChild() forward (try2)
by Jacek Caban 23 Feb '11

23 Feb '11

On 2/23/11 1:21 PM, Nikolay Sivov wrote: > - TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild); > - > - hr = IXMLDOMNode_get_nodeType(newChild,&type); > + hr = IXMLDOMNode_get_nodeType(child,&type); > if(FAILED(hr) || type == NODE_ATTRIBUTE) { > - if(outNewChild) *outNewChild = NULL; > + if (outChild) *outChild = NULL; > return E_FAIL; > } This check for an attribute node shouldn't be needed here. Attribute node may just return failure instead of forwarding the call. Also I'd expect the same from other nodes that can't have children, like text node. Jacek

2 2

Re: [1/5] msxml3: Remove forward to removeChild() method for nodes
by Nikolay Sivov 23 Feb '11

23 Feb '11

On 2/23/2011 03:33, Nikolay Sivov wrote: > Remove forward to removeChild() method for nodes > > Ignore that please, I'll resend all 5 patches soon.

1 0

Coverity Scans Revived
by Amine Khaldi 23 Feb '11

23 Feb '11

Hello folks, Recently we (myself and Urias from Haiku) have been working on getting the coverity scans up and running again. I'm happy to announce that we succeeded ! :) I submitted a scan and the results are up online. I'll submit further scans when necessary, like it's already done with clang analyzer scans. Have fun ! Regards, Amine.

1 0

New winetricks-alpha 20110222-alpha: new verbs d3dx11_43, dragonage2_demo, regedit, shell, taskmgr, winecfg
by Dan Kegel 23 Feb '11

23 Feb '11

Right, it's only been a couple days, but here's a new winetricks already. This release adds dragonage2_demo (released earlier today -- hey, we're starting to keep up!) as well as the handy verbs d3dx11_43, regedit, shell, taskmgr, and winecfg, and a few bugfixes. Download url: http://winetricks.org/winetricks-alpha svn repository / bug tracker: http://winetricks.org Changes since 20110219b-alpha: Dan Kegel: Added Status column to gui, containing 'cached' if game installer is cached. bioshock_demo: add mwo=force for bug 6971 cnc3_demo: fixed install check d3dx11_43: new verb dragonage2_demo: new verb Display install size and time for (some) games. Fix 'winetricks-alpha list'. Thanks to doh123 for pointing out the problem. Pre-check checkboxes for things that are already installed. (winezeug bug 128) regedit: new verb shell: new verb (handy for debugging) taskmgr: new verb tmnationsforever: mention portaudio workaround for choppiness winecfg: new verb Changes since 20110219-alpha: hko: removed, since they no longer offer the torrent download. utorrent: updated to 2.2.1beta. hegemony_demo: update sha1sum gecko is no longer a real verb, so remove media type. Fixes one reported failure in test suite. dc2ba_demo: updated sha1sum d3dxof: fix location of downloaded file msls31: fix typo that broke downloading with clean cache. Fixes ie6. Also mention where files are being downloaded to in console.

1 0

Re: gdi32: first look for a printer driver name in the registry (try 2)
by Vitaliy Margolen 23 Feb '11

23 Feb '11

On 02/22/2011 09:28 AM, Vitaly Perov wrote: > Fixed possible hKey leak since last send > > + static const WCHAR user_printers_reg_key[] = { 'S','o','f','t','w','a','r','e','\\', The actual key doesn't look like have anything to do with printers. Please use variable name that more corresponds to the actual content of the unicode string. > + if (!res && !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) > + { > + TRACE("Get value from registry\n"); > + } Message is not really helpful. And just hides empty if() case. It's better to reverse logic to check for error and combine with the win.ini check. Something like: if ((RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ, &hKey) || RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size) && !GetProfileStringW(devicesW, device, empty_strW, driver, size)) > WARN("Unable to find %s in [devices] section of win.ini\n", debugstr_w(device)); This should also mention registry. > + if (!res) RegCloseKey(hKey); Instead of using res, initialize hKey to NULL and close it if it's not NULL. It's more foolproof. Vitaliy

1 0

RFC: Patch to change what sets the is_win9x in riched20/tests
by James McKenzie 23 Feb '11

23 Feb '11

All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. It uses a called function, lstrcmpW and if it does not exist, the variable is set to a false value. This change has been tested on the testbot for Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no discrepancies were found. Comments on this patch are appreciated. I would like to submit this for inclusion into the Wine code base on Friday. James McKenzie

2 2

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)
by Rico Schüller 22 Feb '11

22 Feb '11

Hi, I have a small hint to the D3DXFloat32To16Array function. It seems that some values are handled in some other way. A small test: D3DXFLOAT16 res; union p { float f; DWORD d; } x; x.d = 0x33000800; D3DXFloat32To16Array(&res, &x.f, 1); ok(res.value == 1, "Failed %f %x\n", x.f, res.value); This fails with the current implementation. It's not the only value, there are a couple of them which are of by one. This could be easily seen by loading both d3dx36.dll (wine and native) and comparing the values directly. Cheers Rico Am 18.02.2011 02:18, schrieb Misha Koshelev: > Fixes bug 25769. Extensively vetted by Stefan Dosinger. Passes winetestbot: > https://testbot.winehq.org/JobDetails.pl?Key=9366 > > Thank you > Misha > --- > dlls/d3dx9_36/d3dx9_36.spec | 4 +- > dlls/d3dx9_36/math.c | 105 +++++++++++++++++++++++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 69 ++++++++++++++++++++++++++++ > include/d3dx9math.h | 18 +++++++ > include/d3dx9math.inl | 31 +++++++++++++ > 5 files changed, 225 insertions(+), 2 deletions(-) > > >

2 3

Re: gdi32: first look for a printer driver name in the registry
by Dmitry Timoshkov 22 Feb '11

22 Feb '11

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ, &hKey) > + && !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey(hKey); > + } You are leaking hKey if RegOpenKeyExW() succeeds but RegQueryValueExW() does not. -- Dmitry.

1 0

Re: gdi32: first look for a printer driver name in the registry
by Jacek Caban 22 Feb '11

22 Feb '11

Hi Vitaly, On 2/22/11 4:01 PM, Vitaly Perov wrote: > + if (!RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ,&hKey) > +&& !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver,&size)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey(hKey); > + } You leak hKey on RegQueryValueExW failure. Jacek

1 0

wined3d profiling
by Tobias Jakobi 22 Feb '11

22 Feb '11

Hey there, I'm experiencing some performance problems with wined3d. The affected game is FEAR (demo does the trick). At first I thought it was related to running the demo on my Intel i965, but I got the same problem running the demo on my Radeon HD4750@r600g. If anyone wants to test this himself: http://www.gamershell.com/download_10167.shtml Performance collapses (kinda SW rendering level) after exiting the first underground section. My guess is that the water plane rendering is causing the issue. So anyway, I wanted to profile this one, but gprof doesn't seem to work so well with wine. I tried to only compile wined3d with -pg, but this doesn't seem to have any effect. At least I don't get any gmon.out after the process exits. What is the recommended way of profiling wine components? oprofile? Thanks, Tobias

3 2

Re: oleaut32: Implement ITypeInfo_GetNames Stub/Proxy (resend)
by Huw Davies 22 Feb '11

22 Feb '11

On Tue, Feb 22, 2011 at 09:02:38PM +1100, Alistair Leslie-Hughes wrote: > >From 6aa7bfa0c06b746ee64daf56f2b02e6f38542d54 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 18 Feb 2011 12:04:56 +1100 > Subject: [PATCH] Implement ITypeInfo_GetNames Stub/Proxy > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/oleaut32/usrmarshal.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) This looks good to me. I'm not sure why this function is marked as [call_as], I expect they originally had planned to allow for a NULL pcNames if cMaxNames == 1 (rather like IEnum*_Next). However a quick test shows that this doesn't appear to be the case. Huw.

1 0

Re: fix sharing handling for CreateFile
by Marvin 21 Feb '11

21 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9411 Your paranoid android. === W2K3R2SESP2 (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === WVISTAADM (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W2K8SE (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PRO (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PROX64 (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PROX64 (64 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5

1 0

winetricks
by Mariusz Janeczko 21 Feb '11

21 Feb '11

Could you correct link to msxml3 in winetricks instaler ? Fhx

1 0

Two enhancement requests for winetricks
by Dan Kegel 21 Feb '11

21 Feb '11

OK, filed http://code.google.com/p/winezeug/issues/detail?id=127 "want uninstall" and http://code.google.com/p/winezeug/issues/detail?id=128 "want status" - Dan

6 11

Re: [PATCH 2/2] jscript: Added more uninitialization tests
by Marvin 21 Feb '11

21 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9399 Your paranoid android. === WVISTAADM (32 bit jscript) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: ws2_32: make gethostbyname fail if WSAStartup was not called before
by Alexandre Julliard 21 Feb '11

21 Feb '11

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -1104,6 +1106,7 @@ int WINAPI WSAStartup(WORD wVersionRequested, LPWSADATA lpWSAData) > /* don't do anything with lpWSAData->lpVendorInfo */ > /* (some apps don't allocate the space for this field) */ > > + WSAStartup_called = TRUE; > TRACE("succeeded\n"); > return 0; There's already a counter for tracking WSAStartup calls. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdiplus: Implement in-memory font-storage
by Vincent Povirk 21 Feb '11

21 Feb '11

I approve of this product and/or service. On Mon, Feb 21, 2011 at 3:54 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > --- > > > >

1 0

Re: server: Fix compilation on systems with a two-argument sched_setaffinity prototype.
by Michael Stefaniuc 21 Feb '11

21 Feb '11

Hello Andrew! Andrew Nguyen wrote: > This lets Wine compile successfully on CentOS 3. CentOS 3? Alexandre was bitching about RHEL 5 being "prediluvian" ... RHEL 3 has a 2.4.21 based kernel, is over 7 years old and EOL. I'm not sure it is worth spending the effort to make current Wine compile and run on such an old system. bye michael

3 2

Re: msxml3: Assign the IBindStatusCallback as soon as it created.
by Jacek Caban 21 Feb '11

21 Feb '11

On 2/18/11 10:24 AM, Alistair Leslie-Hughes wrote: > Hi, > This stops a crash in httprequest_get_responseText, when running from > a webpage since "This->bsc" was NULL. > Tests, please. Jacek

1 0

Re: mshtml: Implement IHTMLAnchorElement get/put target
by Jacek Caban 21 Feb '11

21 Feb '11

On 2/18/11 9:54 AM, Alistair Leslie-Hughes wrote: > static HRESULT WINAPI HTMLAnchorElement_get_target(IHTMLAnchorElement *iface, BSTR *p) > { > HTMLAnchorElement *This = impl_from_IHTMLAnchorElement(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString target_str; > + nsresult nsres; > + HRESULT hres = S_OK; > + > + TRACE("(%p)->(%p)\n", This, p); > + > + nsAString_Init(&target_str, NULL); > + nsres = nsIDOMHTMLAnchorElement_GetTarget(This->nsanchor,&target_str); > + if(NS_SUCCEEDED(nsres)) { > + const PRUnichar *target; > + > + nsAString_GetData(&target_str,&target); > + *p = *target ? SysAllocString(target) : NULL; > + }else { > + ERR("GetHref failed: %08x\n", nsres); > + hres = E_FAIL; > + } > + > + nsAString_Finish(&target_str); > + return hres; > } Please use use return_nsstr here. Jacek

1 0

Re: msxml3: Add IObjectWithSite support to IXMLHttpRequest
by Jacek Caban 21 Feb '11

21 Feb '11

On 2/17/11 10:47 AM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IObjectWithSite support to IXMLHttpRequest > More tests, please. Jacek

1 0

Re: USB Device Support - Nokia PC Suite
by Mike Yates 20 Feb '11

20 Feb '11

After rebooting, I did get a full list of "fixme" lines:- mike@myvmubuntu:~$ wine .wine/drive_c/Program\ Files/Nokia/Nokia\ PC\ Suite\ 7/PCSuite.exe fixme:userenv:GetUserProfileDirectoryW 0x100 (nil) 0x32f43c err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded fixme:msxml:domdoc_get_readyState stub! (0x16c9a0)->(0x32ec38) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" fixme:font:WineEngAddFontResourceEx Ignoring flags 10 fixme:font:WineEngAddFontResourceEx Ignoring flags 10 fixme:font:WineEngAddFontResourceEx Ignoring flags 10 fixme:font:WineEngAddFontResourceEx Ignoring flags 10 fixme:msxml:domdoc_get_readyState stub! (0x181780)->(0x32eb94) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" fixme:msxml:domdoc_get_readyState stub! (0x1af030)->(0x32eac8) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded fixme:wtsapi:WTSRegisterSessionNotification Stub 0x50076 0x00000001 fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe794 0xbbe790 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4f8 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe350 0xbbe34c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe0bc 0xbbe0b4 fixme:wtsapi:WTSFreeMemory Stub (nil) err:module:import_dll Library irprops.cpl (which is needed by L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe" failed, status c0000135 err:ole:CoGetClassObject class {0af10cec-2ecd-4b92-9581-34f6ae0637f3} not registered err:ole:CoGetClassObject no class object {0af10cec-2ecd-4b92-9581-34f6ae0637f3} could be created for context 0x1 fixme:ole:CoInitializeSecurity (0x5af948,-1,(nil),(nil),4,3,(nil),0,(nil)) - stub! fixme:ole:CoResumeClassObjects stub fixme:advapi:RegisterEventSourceW ((null),L"ServiceLayer"): stub fixme:advapi:ReportEventW (0xcafe4242,0x0004,0x0000,0x00000000,(nil),0x0001,0x00000000,0x8be7c0,(nil)): stub fixme:advapi:DeregisterEventSource (0xcafe4242) stub fixme:ole:LPSAFEARRAY_UserSize size interfaces fixme:ole:LPSAFEARRAY_UserMarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserUnmarshal marshal interfaces fixme:msxml:domdoc_get_readyState stub! (0x1a9570)->(0x32eaf8) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" fixme:msxml:domdoc_get_readyState stub! (0x1a9570)->(0x32ec08) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" fixme:msxml:domdoc_get_readyState stub! (0x1a9570)->(0x32eb98) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" fixme:win:FlashWindowEx 0x32d7d4 fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4fc fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe26c 0xbbe264 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdef8 0xbbdef4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc64 0xbbdc5c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe794 0xbbe790 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe500 0xbbe4f8 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbe350 0xbbe34c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbe0bc 0xbbe0b4 fixme:wtsapi:WTSFreeMemory Stub (nil) err:module:import_dll Library irprops.cpl (which is needed by L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe" failed, status c0000135 fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdfbc 0xbbdfb8 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdd28 0xbbdd20 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdfbc 0xbbdfb8 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdd28 0xbbdd20 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:win:RegisterDeviceNotificationW (hwnd=0x5008c, filter=0x73e938,flags=0x00000000) returns a fake device notification handle! fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0xbbdeb8 0xbbdeb4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0xbbdc24 0xbbdc1c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) fixme:htmlhelp:HtmlHelpW HH case HH_INITIALIZE not handled. err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0x1abda0c 0x1abda08 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0x1abd778 0x1abd770 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0x1abda0c 0x1abda08 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0x1abd778 0x1abd770 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0x1abe2a8 0x1abe2a4 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0x1abe014 0x1abe00c fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateSessionsW Stub (nil) 0x00000000 0x00000001 0x1abde64 0x1abde60 fixme:wtsapi:WTSFreeMemory Stub (nil) fixme:wtsapi:WTSEnumerateProcessesW Stub (nil) 0x00000000 0x00000001 0x1abdbd0 0x1abdbc8 fixme:wtsapi:WTSFreeMemory Stub (nil) err:module:import_dll Library irprops.cpl (which is needed by L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\Program Files\\PC Connectivity Solution\\Transports\\NclMSBTSrv.exe" failed, status c0000135 [here I pressed "Click here to connect a phone"] fixme:ole:LPSAFEARRAY_UserSize size interfaces fixme:ole:LPSAFEARRAY_UserMarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserUnmarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserSize size interfaces fixme:ole:LPSAFEARRAY_UserMarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserUnmarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserSize size interfaces fixme:ole:LPSAFEARRAY_UserMarshal marshal interfaces fixme:ole:LPSAFEARRAY_UserUnmarshal marshal interfaces fixme:msxml:domdoc_get_readyState stub! (0x14c0d00)->(0x33bcc8) I/O warning : failed to load external entity "ConfServer.dtd" err:msxml:domdoc_validateNode Could not load the external subset "ConfServer.dtd" wine: Unhandled page fault on read access to 0x01531000 at address 0x7d5e8f93 (thread 005f), starting debugger... fixme:win:FlashWindowEx 0x32b85c [here I got "The program GetConnected.exe has encountered a serious problem and needs to close..... or a deficiency in Wine..."]

3 2

new winetricks-alpha 20110219-alpha: added wineprefix selection screen
by Dan Kegel 19 Feb '11

19 Feb '11

Another day, another winetricks-alpha. (Well, it *is* alpha.) winetricks-alpha version 20110219's gui now starts with a wineprefix selection dialog. If you just click OK, it uses the default wineprefix. When using the gui, games can only be installed into their own sandboxed prefix. This keeps them from bumping into each other and making them spill their coffee, or worse. (This feature may seem odd, but it's how PlayOnLinux works, and it was specifically requested by Vitaliy Margolen in http://www.winehq.org/pipermail/wine-devel/2011-January/088332.html ) It now has an option to delete the selected wineprefix, and if you do, it also deletes any xdg desktop menuitems that refer to it. Comments welcome. There are some quirks left to work out with the new gui behavior, so caveat downloador. Download url: http://winetricks.org/winetricks-alpha svn repository / bug tracker: http://winetricks.org Changelog: Dan Kegel: In pickprefix menu, sense dosdevices rather than user.reg; makes new wineprefixes show up immediately Deleting a wineprefix also deletes its menu items. Make default wineprefix the, um, default in pickprefix. Games are reachable only via pickprefix menu now. Experimental gui change: outer dialog is now prefix selection. Needs polish and testing still. algodoo_demo: wait for installer to finish in non-silent case Remove dead code for run and uninstall modes/menus.

2 2

No longer possible for users to submit AppDB test reports for the current stable release
by Rosanne DiMesio 19 Feb '11

19 Feb '11

With the release of 1.3.14, the current stable release has dropped off the list of versions for which users can submit AppDB test reports, though 1.0.0 and 1.0.1 remain on the list. Can someone please fix this? http://bugs.winehq.org/show_bug.cgi?id=24763 -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

System-wide WoW64 setup
by Jerome Leclanche 19 Feb '11

19 Feb '11

I've recently finished setting up WoW64 with the help of this guide [http://wiki.winehq.org/Wine64] and kevlarman on #winehackers. However, I'm running into a lot of trouble to install it system-wide. Git tree lives at ~/src/wine and my build dirs are ~/src/wine/build and ~/src/wine/build64. A first make install from build64 leads to this (as expected): adys@azura:~$ wineboot exec: 52: wine: not found Following it by a make install from build32 I get: adys@azura:~$ wineboot /usr/bin/wineserver: error while loading shared libraries: libwine.so.1: wrong ELF class: ELFCLASS32 And if I reinstall from build64 above it, I get: adys@azura:~$ wineboot /usr/bin/wine: error while loading shared libraries: libwine.so.1: wrong ELF class: ELFCLASS64 No improvement with a full clean and a reinstall starting by build32: adys@azura:~$ wineboot bash: /usr/bin/wineboot: No such file or directory ... adys@azura:~$ wineboot /usr/bin/wine: error while loading shared libraries: libwine.so.1: wrong ELF class: ELFCLASS64 The guide doesn't mention a system-wide setup. Am I doing something wrong here? -- J. Leclanche

2 2

Re: comctl32: Fix read of uninitialized data in LISTVIEW_GetItemExtT when LVIF_TEXT is not set (Valgrind).
by Nikolay Sivov 19 Feb '11

19 Feb '11

On 2/19/2011 03:34, Alexander Scott-Johns wrote: I think it's enough to add a mask check here: --- if (bResult && lpLVItem->pszText != pszText) --- to keep a single call of GetItem.

2 2

Re: USB Device Support - Nokia PC Suite
by Mike Yates 19 Feb '11

19 Feb '11

Stefan D?singer wrote:- > ln -s /dev/ttyACM0 "~/.wine/dosdevices/com0:" or something like that. It may be "COM0:" or "com0" without the :. > Then ttyACM0 is available as COM 0, but it is a classic serial port. If the app is looking for a usb to serial device > with a specific USB vendor and device ID it won't find the port. Thanks Stefan, that's a good start. The "Click here to connect a phone" still induces a wine crash but takes longer thinking about it. The "Settings/Manage Connections" now doesn't crash now but brings up an empty list of connections to choose from. Unfortunately these are both too separated from a console launch to capture any "fixme" lines, I only get this one from the main program:- mike@myvmubuntu:~$ wine .wine/drive_c/Program\ Files/Nokia/Nokia\ PC\ Suite\ 7/PCSuite.exe fixme:userenv:GetUserProfileDirectoryW 0xfc (nil) 0x32f43c mike@myvmubuntu:~$ I'll try different COM ports and let you know...

2 1

USB Device Support
by James Mckenzie 19 Feb '11

19 Feb '11

Alexander: Before I go off and try to update your USB device support for the latest Wine release, are you continuing to maintain this code current to the Wine Development and Wine Stable trunks? Also, the USB Device Support in Wine Wiki page needs an update. The code at snicky.com is no longer available. Thank you for your efforts to support USB devices in Wine. James McKenzie

6 5

[PATCH] winegcc - do not create .exe.so
by Pali Rohár 18 Feb '11

18 Feb '11

Hello, I created patch which implement correct _start section in ELF shared libraries/binaries which generate winegcc. Into _start section this patch add calling execve syscall which start wine with all arguments. So it is not needed to generate shell wrapper and .exe.so binary. This replace code on: http://wiki.winehq.org/Winelib_binaries_as_ELF_executables_not_.exe.so $ winegcc app.c --> generate only a.exe (shared object ELF binary), no aditional a.exe.so $ ./a.exe --> start binary correctly without shell wrapper -- Pali Rohár pali.rohar(a)gmail.com

1 1

new winetricks-alpha 20110218-alpha: new verbs office2007pro, sketchup, starcraft2_demo, wowtrial, 14 others; new option --isolate-games
by Dan Kegel 18 Feb '11

18 Feb '11

Another month, another winetricks-alpha. winetricks-alpha version 20110218 adds the following new verbs: atmosphir deusex2_demo dsoundhw=emulation eve fable_tlc fifa11_demo hegemony_demo hon imvu kotor1 kotor2 lhp_demo mb_warband_demo office2003pro office2007pro sketchup starcraft2_demo videomemorysize wowtrial and four new options: --gui Force gui progress indications even when run from commandline --isolate-games Puts games in their own sandboxed wineprefix. Experimental. --noclean Leave temp files when verbs done. Useful when debugging. --showbroken Gui normally hides apps known not to work with current wine. This shows them anyway. and one new feature: Commands are now logged to $WINEPREFIX/winetricks.log so user has a record of what he did to the bottle and updates a number of download URLs, most notably mxsml3. The script can be downloaded from winetricks.org at the obvious url: http://winetricks.org/winetricks-alpha (The old download url at kegel.com/wine/winetricks-alpha still works, too.) Bug tracker and svn repository are at http://winetricks.googlecode.com Changelog: Phil Blankenship: deusex2_demo: ported. eve: ported. kotor1, kotor2: new verbs lhp_demo: ported. mb_warband_demo: ported. Scott Jackson: icodecs: support -q. wowtrial: ported, updated. Dan Kegel: atmosphir: new verb fable_tlc: ported, updated fifa11_demo: ported. Patch by Scott and me. dsoundhw=emulation: new verb hon: ported and updated verb imvu: ported & updated starcraft2_demo: new verb. (Also die slightly earlier if a verb fails.) videomemorysize: ported verb. 3dmark06: mark as broken because of winehq bug 9210 3dmark2001: observed a hang, so added a few delays, that usually helps Obey W_CACHE even on mac. Pick good WINETRICKS_POST even if WINETRICKS_DIR is not set. Replaced tabs with spaces. There should be no tabs in this file. alldlls: fixed verb, it wasn't getting invoked properly aoe_trial: didn't have any delays after WinWait, and hung on a recent run. Add missing delays. atmosphir: fix media type, bug found by Scott Jackson bfbc2: add little delay at point of an observed hang bfbc2: added missing delays, since it hung once today bug 21517 was fixed in wine-1.3.8, so don't apply it with new enough wine bugfix: Abort if install check fails after install bugfix: Don't crash immediately if WINEPREFIX is set but does not exist bugfix: Don't reference undefined variable programfilesdrive bugfix: Don't unset DISPLAY in early_wine, it breaks later runs of autohotkey. bugfix: Fixed typo in w_override_app_dlls bugfix: Use %windir%\Temp rather than %windir%\_temp, since on Windows 7, there were mysterious permission problems installing vc2005express with the nonstandard _temp directory. bugfix: User complained that w_die wasn't fatal. Sure enough, need to check subshell exit status explicitly. bugfix: When unmounting, also eject. This should help multidisc titles. bugfix: add parameter checking on w_override_dlls to catch a common thinko bugfix: w_read_key: also strip spaces from key bugfix: w_read_key: some systems don't like [ -], so try posix syntax cod1: typo: KEY should be W_KEY deadspace2: added draft verb. deadspace2: mark as broken (and fix install check) dxdiag: also install help file early_wine: don't disable mshtml, it breaks later autodownload of gecko. See winezeug bug 223. firefox4: die rather than warn if trying to install with too old a wine firefox4: update url flash: updated, fixes winezeug 228. fontfix: can't claim it has an installed file unless it always installs it. Also, fixed a typo that caused anything without an installed_file1 fail if used from inside a verb that does. gameux=disabled was broken; fixed. Support generic dll={disabled|builtin|native}. gothic4_demo: ported from wisotool, marked as broken kotor2: shorten name to make it fit in dialog mono28: fix list-installed and list-cached mono28: updated to mono-2.8.2 msxml3: microsoft download page vanished, so use cnet. ole2: removed, since it seems broken, and I don't know how useful it is. opensymbol: updated url and sha1sum psdkwin7: fix fixme, don't muck with registry on windows shockwave: updated sha1sum sims3: fix non-q mode vc2005trial: fix regression caused by recent change that created both Temp and temp. vc2005trial still broken, but at least it gets further now. vc2005trial: marked as broken w_declare_exe: allow declaring more than one executable per verb w_download_torrent no longer needs pkg argument, following example of other download functions. w_override_app_dlls: accept b as synonym for builtin, etc. w_override_dlls: don't suggest w_call w_workaround_wine_bug: 2nd argument implemented, with nicer range syntax, e.g. 1.3.8, means 'works in wine-1.3.8 and later' wowtrial: use color of progress bar to detect completion. Also wait a bit longer for server detection. Shannon Vanwagner: dmsynth: fix install check hegemony_demo: ported office2003pro, office2007pro: new verbs sketchup: new verb

1 0

Re: gdi32: Do not leak the hfont list (Valgrind).
by Alexandre Julliard 18 Feb '11

18 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok wine: Unhandled page fault on read access to 0x00000008 at address 0x68979799 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x68979799). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68979799 ESP:0032e580 EBP:0032e5f8 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:689aed9c ECX:00131178 EDX:0000de98 ESI:00131168 EDI:689b2af8 Stack dump: 0x0032e580: 689b2ae0 7bc48c77 00000018 00000002 0x0032e590: 0032e5bc 0032e5a4 00000000 7bc35d41 0x0032e5a0: 00110014 4d430002 0013483c 00000004 0x0032e5b0: 00000000 00000000 0000de98 689aed9c 0x0032e5c0: 689b2b80 0000de98 689b2ae0 68986533 0x0032e5d0: 689b2b80 00000000 00000000 7bc9e92c Backtrace: =>0 0x68979799 WineEngDestroyFontInstance+0x69(handle=0xde98) [/home/julliard/wine/wine/dlls/gdi32/freetype.c:3906] in gdi32 (0x0032e618) 1 0x6896ea72 FONT_DeleteObject+0x11(handle=0xde98) [/home/julliard/wine/wine/dlls/gdi32/font.c:611] in gdi32 (0x0032e678) 2 0x68986e58 DeleteObject+0x247(obj=0xde98) [/home/julliard/wine/wine/dlls/gdi32/gdiobj.c:875] in gdi32 (0x0032e6b8) 3 0x689756eb free_font+0x9a(font=<is not available>) [/home/julliard/wine/wine/dlls/gdi32/freetype.c:3099] in gdi32 (0x0032e6f8) 4 0x68975694 free_font+0x43(font=<is not available>) [/home/julliard/wine/wine/dlls/gdi32/freetype.c:3091] in gdi32 (0x0032e778) 5 0x689799de WineEngDestroyFontInstance+0x2ad(handle=0x7060) [/home/julliard/wine/wine/dlls/gdi32/freetype.c:3950] in gdi32 (0x0032e798) 6 0x6896ea72 FONT_DeleteObject+0x11(handle=0x7060) [/home/julliard/wine/wine/dlls/gdi32/font.c:611] in gdi32 (0x0032e7f8) 7 0x68986e58 DeleteObject+0x247(obj=0x7060) [/home/julliard/wine/wine/dlls/gdi32/gdiobj.c:875] in gdi32 (0x0032f128) 8 0x68f35603 ME_HandleMessage+0x3ab2(editor=0x3328e8, msg=0x2, wParam=0, lParam=0, unicode=0, phresult=0x32f1cc) [/home/julliard/wine/wine/dlls/riched20/editor.c:2780] in riched20 (0x0032f1e8) 9 0x68f3798c RichEditWndProc_common+0x18b(hWnd=0x620056, msg=<is not available>, wParam=0, lParam=0, unicode=0) [/home/julliard/wine/wine/dlls/riched20/editor.c:4491] in riched20 (0x0032f208) 10 0x68f37de6 RichEditWndProcA+0x25(hWnd=0x620056, msg=0x2, wParam=0, lParam=0) [/home/julliard/wine/wine/dlls/riched20/editor.c:4516] in riched20 (0x0032f238) 11 0x688b508a WINPROC_wrapper+0x19() in user32 (0x0032f288) 12 0x688b6a1c call_window_proc+0x5b(hwnd=0x620056, msg=0x2, wp=0, lp=0, result=0x32f9cc, arg=0x68f37dc0) [/home/julliard/wine/wine/dlls/user32/winproc.c:242] in user32 (0x0032f918) 13 0x688b5a3c WINPROC_CallProcWtoA+0x16b(callback=<is not available>, hwnd=<is not available>, msg=0x2, wParam=0, lParam=0, result=0x32f9cc, arg=0x68f37dc0) [/home/julliard/wine/wine/dlls/user32/winproc.c:857] in user32 (0x0032f968) 14 0x688b7e26 WINPROC_call_window+0x1b5(hwnd=0x620056, msg=0x2, wParam=0, lParam=0, result=0x32f9cc, unicode=0x1, mapping=1753936523) [/home/julliard/wine/wine/dlls/user32/winproc.c:901] in user32 (0x0032f9d8) 15 0x6887a491 call_window_proc+0x90(hwnd=<is not available>, msg=0x2, wparam=0, lparam=0, unicode=0x1, same_thread=0x1, mapping=1753936523) [/home/julliard/wine/wine/dlls/user32/message.c:2201] in user32 (0x0032fa58) 16 0x6887e906 send_message+0x1f5(info=0x32fa70, res_ptr=0x32fa9c, unicode=0x1) [/home/julliard/wine/wine/dlls/user32/message.c:3042] in user32 (0x0032faa8) 17 0x6887edac SendMessageW+0x4b(hwnd=0x620056, msg=0x2, wparam=0, lparam=0) [/home/julliard/wine/wine/dlls/user32/message.c:3165] in user32 (0x0032fb18) 18 0x688a974b WIN_SendDestroyMsg+0x6a(hwnd=0x620056) [/home/julliard/wine/wine/dlls/user32/win.c:1603] in user32 (0x0032fb68) 19 0x688a9efa DestroyWindow+0x259(hwnd=0x620056) [/home/julliard/wine/wine/dlls/user32/win.c:1706] in user32 (0x0032fbe8) 20 0x686954dc test_zoom+0xd4b() [/home/julliard/wine/wine/dlls/riched20/tests/editor.c:6769] in riched20_test (0x0032fd38) 21 0x6869b7ea func_editor+0x4959() [/home/julliard/wine/wine/dlls/riched20/tests/editor.c:7152] in riched20_test (0x0032fd88) 22 0x6869ddde run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/riched20/tests/../../../include/wine/test.h:556] in riched20_test (0x0032fe48) 23 0x6869dfd7 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/riched20/tests/../../../include/wine/test.h:624] in riched20_test (0x0032fe90) 24 0x6869eb5c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in riched20_test (0x0032fea8) 25 0x7b858fec call_process_entry+0xb() in kernel32 (0x0032fee8) 26 0x7b85b85b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fef8) 27 0x7bc73358 call_thread_func+0xb() in ntdll (0x0032ffc8) 28 0x7bc73530 call_thread_entry_point+0x6f(entry=0x7b85b800, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffe8) 29 0x7bc4deca start_process+0x29(kernel_start=0x7b85b800) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2606] in ntdll (0x00000000) 0x68979799 WineEngDestroyFontInstance+0x69 [/home/julliard/wine/wine/dlls/gdi32/freetype.c:3906] in gdi32: cmpl %edx,0x8(%eax) 3906 if(hflist->hfont == handle) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Assign the IBindStatusCallback as soon as it created.
by Nikolay Sivov 18 Feb '11

18 Feb '11

On 2/18/2011 12:24, Alistair Leslie-Hughes wrote: > Hi, > This stops a crash in httprequest_get_responseText, when running from > a webpage since "This->bsc" was NULL. > > > Changelog: > msxml3: Assign the IBindStatusCallback as soon as it created. You mean at this point? --- hr = GetHGlobalFromStream(This->bsc->stream, &hglobal); --- Could you add a test case for that please? > > > Best Regards > Alistair Leslie-Hughes

1 0

Re: Patch about combobox with label
by Andrew Eikum 18 Feb '11

18 Feb '11

On 02/18/2011 06:42 AM, yannick kuhn wrote: > I found a bug in wine 1.2.2 (I work with ubuntu 10.10). When we have a combobox > which have a label on top, wine recalculate the position of the rectangle > because posChanging->cy is taller than newComboHeight. > Then, The combobox can be hidden by the label. > > You can found the file combo.c in wine-1.2.2/dlls/user32/combo.c I can't comment about the content of your patch, but a few things need to be fixed. First, is this something you can create a test case for? If so, please do. Second, your mail won't apply with git-apply. You should send patches using git-format-patch, and from the latest version of Wine from Git. The Wine maintainer will decide if the patch should be pulled into the next stable version of Wine. Please see <http://wiki.winehq.org/SubmittingPatches> for some pointers on patch submission. Thanks, and good luck! Andrew

1 0

Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 18 Feb '11

18 Feb '11

>I haven't investigated very closely, but my impression is that you >want to use libsquish. I'm not sure if it has C bindings, or if the >API is entirely right for what we need, but maybe they accept patches. Yes, there are bindings, but wouldn't this pose the same legal problems as libtxc_dxtn?

2 1

FW: [Bug 25654] Anarchy Online 18.4.x unable to mouse-look or mouse-steer
by Janne Hakonen 18 Feb '11

18 Feb '11

> http://bugs.winehq.org/show_bug.cgi?id=25654 > > --- Comment #11 from llie(a)nano.exofire.net 2011-02-16 22:56:20 CST --- > What is the status of RawDeviceInput for Wine? I've browsed the forum, the bug > list, and the developer's To-Do list, and although there is an item regarding > relative mouse position versus absolute mouse position, there is nothing > currently planned for RawDeviceInput, but there are at least 4 open bugs for > games that is affected by not having RawDeviceInput implemented. > > Is there no generalized solution to this problem because of the > relative/absolute mouse position issue? It seems a lot of games each has its > own patch to support RawDeviceInput. > Hi, Could someone kindly comment to Llies's questions about raw mouse input? Thanks in advance, Janne Hakonen

1 0

Anyone using Wine D3D under Parallels?
by Misha Koshelev 18 Feb '11

18 Feb '11

I am trying some simple patches for: http://bugs.winehq.org/show_bug.cgi?id=24642 and noticed that although glxinfo reports: misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render direct rendering: Yes OpenGL renderer string: Parallels using NVIDIA GeForce GT 330M OpenGL Engine I get: misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ wine Tag.exe err:winediag:X11DRV_WineGL_InitOpenglInfo The Mesa OpenGL driver is using software rendering, most likely your OpenGL drivers haven't been installed correctly fixme:d3d_caps:wined3d_guess_card No card selector available for GL vendor 4 and card vendor 0000. fixme:win:EnumDisplayDevicesW ((null),0,0x32e6f4,0x00000000), stub! and I get different results under Parallels than running directly on the Mac This does not seem to cause a problem for other game demos, such as http://bugs.winehq.org/show_bug.cgi?id=24642, but the message is still there. Any ideas? Thank you Misha p.s. I compiled wine git with: ./configure CPPFLAGS='-I/usr/X11/include' LIBS='-lGL -lGLU' LDFLAGS='-L/usr/X11/lib' make && sudo make install and am using the command: DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" wine ... on the Mac side. Thank you.

3 8

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)
by Stefan Dösinger 18 Feb '11

18 Feb '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I had another quick look, it looks OK to me. Am 18.02.2011 um 02:18 schrieb Misha Koshelev: > Fixes bug 25769. Extensively vetted by Stefan Dosinger. Passes winetestbot: > https://testbot.winehq.org/JobDetails.pl?Key=9366 > > Thank you > Misha > --- > dlls/d3dx9_36/d3dx9_36.spec | 4 +- > dlls/d3dx9_36/math.c | 105 +++++++++++++++++++++++++++++++++++++++++++ > dlls/d3dx9_36/tests/math.c | 69 ++++++++++++++++++++++++++++ > include/d3dx9math.h | 18 +++++++ > include/d3dx9math.inl | 31 +++++++++++++ > 5 files changed, 225 insertions(+), 2 deletions(-) > <0001-d3dx9-Implement-D3DXFloat32To16Array-and-D3DXFloat16To.txt> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNXi4tAAoJEN0/YqbEcdMw6VUP/A7c8w4vyRmYiZvc4FF10ReG qefW/tBwHx1YT/ifGj0HXMneV8S04NnrUBAXkvctdfBS9ZtCFJevt59oqAJVM0w+ cQeCA/+AF/a7FEIFdo4PyfKqWIlagdDzwFfn8QC3bDMDxRsX0IbMhKeDtVz+vutZ xIKQtOlWdDGN/RUZtXohwVoCbrct/Byvh/ZSkV5K+zibX+i0zG6QPLeKdOc1bnnr OiTlg/K1pBMbseE0CLPW6XC3g3W+mX1bSm6U9tuwAFTs+yPsCXy1enLPqrEmJbmA TRQMW2MwQO9fSS+78YWRsAoPAN4UonI4wQGsTlBPr4OHhAiR9rSz4YHNAs6Lo8DB 7TUh26iNdt9vJ9QaTzKnHjkfjS13vvhNtfHcAwIFrYe/o1l/m/SlLOTP6j60QvBp upvHGkA3N+UkzkdY1A1L91O/sqtvMFtKmeH7OOQz11fGGJtBQelMmZb76u65mz7e ARGiEjJRVtN76baiXQa4hxjF9mBuCbcsJ94Q6vuEsku5imLkDoxoVb7bcd0tMpjU EpGMeUeyLv0udLAgR3Edd6bKqlZGXdxzqsb6/4r0LitW38VIfZ3phZ9dvpwtZAvs 7DAF6DwxbmCqbhn97ch2cHTqq0cxpuUUUbYN0b4RzghCdKyeMgAHqtAbmVuQqljM ydNgloRFGwLX4MMpgGB5 =kAiK -----END PGP SIGNATURE-----

1 0

re: project help...
by Dan Kegel 18 Feb '11

18 Feb '11

"ejaj on resurgence" wrote: > m a new comer here...its great.....well i just wanna know if wine is gonna be project in GSOC-11....wud be glad if soo...i wanna get into it....so sum 1 plz help me out here...lotsa thnx... Well, yes, but you'll need a computer, it's kind of hard to develop wine on a mobile phone :-)

1 0

Re: winmm: Simplify MCI_DumpCommandTable a bit. (RETRY)
by Alexandre Julliard 18 Feb '11

18 Feb '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Ping. Any objection to this, given that this has not been used for > quite a while? The variable is here for documentation, you don't want to remove it. You can comment it out if it's not used. -- Alexandre Julliard julliard(a)winehq.org

2 1

Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?
by Misha Koshelev 18 Feb '11

18 Feb '11

Dear All: Looking at d3dx9 bugs, bug 24899 requires D3DXCreateRenderToSurface. This, somewhat barebones, patch, implements core functionality of D3DXCreateRenderToSurface, along with a barebones ID3DXRenderToSurface implementation. I was wondering, in order to get this patch accepted into the wine code base, how much more of ID3DXRenderToSurface needs to be implemented? Thank you Misha

3 3

project help...
by ejaj on resurgence 17 Feb '11

17 Feb '11

m a new comer here...its great.....well i just wanna know if wine is gonna be project in GSOC-11....wud be glad if soo...i wanna get into it....so sum 1 plz help me out here...lotsa thnx...

1 0

A patch trying to fix Bug 25999 - wine builtin IE crash while opening file with zero bytes
by Qian Hong 17 Feb '11

17 Feb '11

Dear All, I'm trying to fix http://bugs.winehq.org/show_bug.cgi?id=25999 Below is my patch. This my first patch, I wonder weather it is ugly, I'm grateful for any advice. >From 0598dc0acf14a18d28e78e7b924384c46040a81e Mon Sep 17 00:00:00 2001 From: Qian Hong <fracting(a)gmail.com> Date: Fri, 18 Feb 2011 04:46:41 +0800 Subject: modified: dlls/mshtml/navigate.c --- dlls/mshtml/navigate.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index bb71c79..f978e8e 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1106,7 +1106,8 @@ static HRESULT async_stop_request(nsChannelBSC *This) IBindStatusCallback_AddRef(&This->bsc.IBindStatusCallback_iface); task->bsc = This; - push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); + if(This->bsc.doc) + push_task(&task->header, stop_request_proc, This->bsc.doc->basedoc.doc_obj->basedoc.task_magic); return S_OK; } -- Thanks very much! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

1 0

Re: user32: Use the windows created by the SetParent() test to get a more predictable active/focus window state.
by Alexandre Julliard 17 Feb '11

17 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Hopefully this should fix recently introduced test failures seen on some > test machines. It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so win.c && touch win.ok win.c:3479: Test failed: GetActiveWindow() = 0x5500c2 win.c:3479: Test failed: GetFocus() = 0x5500c2 make[1]: *** [win.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

winmm/tests: remove dead assignment (LLVM/Clang)
by Joerg-Cyril.Hoehle＠t-systems.com 17 Feb '11

17 Feb '11

Hi, Austin suggests: >--- a/dlls/winmm/tests/wave.c >- first = FALSE; -1 Some times you value consistency more than elimination of superfluous assignments. All parts are written like this: if ((flags & WAVE_FORMAT_DIRECT) == WAVE_FORMAT_DIRECT) { if (!first) strcat(msg, "|"); strcat(msg, "WAVE_FORMAT_DIRECT"); first = FALSE; } and you don't want to eliminate that one line in the last part just because it happens to be the last one TODAY. What if tomorrow another flag is added last and the programmer oversees that s/he needs to reintroduce that first=FALSE statement? Removing regularity is just error-prone and in the way of maintainability. Try to keep the code regular and all parts alike, without exception for the last one. It reminds me of the annoying issue with the trailing comma in structure initialisations, which lead some people to instead use a style like this (well known in functional programming): ... , value_n , value_n+1 }; Isn't there a way to silence several complains from Clang which I consider stupid? Regards, Jörg

1 0

Re: mshtml: Implement IHTMLAnchorElement_put_href
by Jacek Caban 17 Feb '11

17 Feb '11

Hi Alistair, On 2/17/11 10:45 AM, Alistair Leslie-Hughes wrote: > + IHTMLAnchorElement *anchor = _get_anchor_iface(line, unk); > + BSTR str; > + HRESULT hres; > + > + str = a2bstr(exhref); > + hres = IHTMLAnchorElement_put_href(anchor, str); > + ok_(__FILE__,line)(hres == S_OK, "get_href failed: %08x\n", hres); > + > + _test_disp_value(line, unk, exhref); You leak str here. Jacek

1 0

Re: ntdll/signal_arm.c: Implement segv_handler
by Dmitry Timoshkov 17 Feb '11

17 Feb '11

chris.nousco(a)gmail.com wrote: > From: JinSung Kang <chris.nousco(a)gmail.com> > > Improve that segv_handler function check page_fault and setting up exception handler. > It is possbible whether read fault or write fault. It looks like the formatting of your patches is messed up because of using a non-standard tab size (4?). -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (try 2)
by Dmitry Timoshkov 17 Feb '11

17 Feb '11

Austin English <austinenglish(a)gmail.com> wrote: > + r = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELONG(100,50)); > + ok(r, "failed\n"); Please use a more informative failure message. > r = SendMessage(hwnd, WM_NOTIFYFORMAT, 0, NF_QUERY); > + todo_wine expect(2, r); 2 is NFR_UNICODE. -- Dmitry.

1 0

Re: comctl32/tests: make sure to use return values (LLVM/Clang) (1/6)
by Marvin 17 Feb '11

17 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9336 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2KPROSP4 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WXPPROSP3 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W2K3R2SESP2 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === WVISTAADM (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W2K8SE (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 14) listview.c:3764: Test failed: Expected 1, got 2 === W7PRO (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (32 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2 === W7PROX64 (64 bit listview) === listview.c:3054: Test failed: Horizontal spacing inconsistent (200 != 16) listview.c:3764: Test failed: Expected 1, got 2

2 1

Re: wintrust/tests: Fix a leak (valgrind)
by Marvin 16 Feb '11

16 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9309 Your paranoid android. === W2K8SE (32 bit softpub) === softpub.c:742: Test failed: expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got 80092003

1 0

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Alexandre Julliard 16 Feb '11

16 Feb '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -381,9 +386,40 @@ static HRESULT WINAPI xslprocessor_Invoke( > static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) > { > xslprocessor *This = impl_from_IXSLProcessor( iface ); > + IXMLDOMNode *input_node; > + HRESULT hr; > > - FIXME("(%p): stub\n", This); > - return E_NOTIMPL; > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); > + > + /* try IXMLDOMNode directly first */ > + if (V_VT(&input) == VT_UNKNOWN) > + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); > + else if (V_VT(&input) == VT_DISPATCH) > + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); > + > + if (hr != S_OK) You need to handle the default case somehow. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)
by Joris Huizer 16 Feb '11

16 Feb '11

Hello, I think I found a (possible) little issue in the patch: If one would pass a VARIANT of incorrect type to the xslprocessor_put_input() function (say type BSTR), the first type checks fail and leave hr uninitialised; in case it happened to have the value S_OK the other if block is skipped - assigning the uninitialised input_node; static HRESULT WINAPI xslprocessor_put_input( IXSLProcessor *iface, VARIANT input ) { xslprocessor *This = impl_from_IXSLProcessor( iface ); + IXMLDOMNode *input_node; + HRESULT hr; (assume hr happens to be S_OK) - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(%s)\n", This, debugstr_variant(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input), &IID_IXMLDOMNode, (void**)&input_node); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input), &IID_IXMLDOMNode, (void**)&input_node); (both false) + + if (hr != S_OK) + { //... + } (skipped) + + if (hr == S_OK) + { + if (This->input) IXMLDOMNode_Release(This->input); + This->input = input_node; + } (executed, assigning garbage to This->input) + + return hr; } HTH, Joris

1 0

Re: gameux/gamestatistics.c: Make sure each VARIANT is cleared after use (valgrind)
by Alexandre Julliard 16 Feb '11

16 Feb '11

Joris Huizer <joris_huizer(a)yahoo.com> writes: > @@ -511,24 +511,27 @@ static HRESULT GAMEUX_loadStatisticsFromFile(struct GAMEUX_STATS *data) > > if(SUCCEEDED(hr)) > { > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + VARIANT categoryIndex, categoryName; > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrIndex, &categoryIndex); > + if( hr == S_OK && V_VT(&categoryIndex) != VT_BSTR) > hr = E_FAIL; > > if(SUCCEEDED(hr)) > { > - i = StrToIntW(V_BSTR(&vValue)); > - hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &vValue); > - if( hr == S_OK && V_VT(&vValue) != VT_BSTR) > + i = StrToIntW(V_BSTR(&categoryIndex)); > + hr = IXMLDOMElement_getAttribute(categoryElement, bstrName, &categoryName); > + if( hr == S_OK && V_VT(&categoryName) != VT_BSTR) > hr = E_FAIL; > } > + VariantClear(&categoryIndex); You should only clear it when it has been successfully set. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine64 issues in dlls/msvcr90/tests/msvcr90.c
by Peter Urbanec 16 Feb '11

16 Feb '11

As of a few days ago, I'm seeing the following errors when building wine64 with gcc (Gentoo 4.5.2 p1.0, pie-0.4.5) 4.5.2 dlls/msvcr90/tests/msvcr90.c:137:14: warning: 'do_call_func1' defined but not used dlls/msvcr90/tests/msvcr90.c:147:14: warning: 'do_call_func2' defined but not used dlls/msvcr90/tests/msvcr90.c: Assembler messages: dlls/msvcr90/tests/msvcr90.c:150: Error: invalid instruction suffix for `push' When building wine32, there seem to be no problems. Is anyone else seeing this when building wine64?

1 0

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)
by Jacek Caban 16 Feb '11

16 Feb '11

On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: > Changelog: > mshtml: Ignore IActiveScript interface for IXMLHTTPRequest mshtml? + else if ( IsEqualGUID( riid,&IID_IActiveScript)) + { + TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject); + *ppvObject = NULL; + return E_NOINTERFACE; + } else { FIXME("Unsupported interface %s\n", debugstr_guid(riid)); As discussed on wine-devel, please just change the later FIXME to TRACE instead. Jacek

2 3

Re: comctl32/tests: Add two casts to avoid comparisons of different int types.
by Marvin 16 Feb '11

16 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9229 Your paranoid android. === W7PROX64 (64 bit tab) === tab.c:1330: Test failed: got 69cc80, expected dededede

3 3

[PATCH] Implement software DXT1 compression
by alberto＠mattea.info 16 Feb '11

16 Feb '11

This patch adds conversion functions from WINED3DFMT_B8G8R8_UNORM, WINED3DFMT_B5G5R5A1_UNORM and WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_DXT1. It uses code slighty modified from libtxc_dxtn. It fixes at least LEGO Stunt Rally, probably other games too. I didn't implement dxt3 and dxt5 since I haven't got any apps to test, but if someone has similar problems (black textures) with them and wants to test, let me know, and I will add them as well. I would also like some feedback about the patent situation, e.g. if the patch can be mainlined as it is or if it would be better to load libtxc_dxtn directly at runtime. Alberto

3 2

valgrind results - now with better debug info
by Austin English 15 Feb '11

15 Feb '11

Howdy all, I've added a few more suppressions, and after a suggestion by Nikolay, added some debugging symbols: austin@debian:~/src/winezeug/valgrind$ dpkg -l | grep dbg ii cups-dbg 1.4.5-2 Common UNIX Printing System(tm) - debugging symbols ii libc6-dbg 2.11.2-11 Embedded GNU C Library: detached debugging symbols ii libgsm1-dbg 1.0.13-3 Shared libraries for GSM speech compressor (debug symbols) ii libsane-dbg 1.0.21-9 API development library for scanners [debug symbols] ii libsane-extras-dbg 1.0.21.2 API library for scanners -- extra backends [debug symbols] ii libxml2-dbg 2.7.8.dfsg-2 Debugging symbols for the GNOME XML library ii libxslt1-dbg 1.1.26-6 XSLT 1.0 processing library - debugging symbols ii zlib1g-dbg 1:1.2.3.4.dfsg-3 compression library - development if you need a debugging symbol package to get better info from a crash, please let me know. The current suppressions used are at: http://winezeug.googlecode.com/svn/trunk/valgrind/valgrind-suppressions Please let me know if you have more to add I've filed bugs for most results, see: http://bugs.winehq.org/buglist.cgi?query_format=advanced&emailreporter1=1&s… as always, results are at: http://austinenglish.com/logs/valgrind/ Cheers, Austin

1 0

Re: D3DXCreateTorus patch... thoughts?
by David Adam 15 Feb '11

15 Feb '11

Here is cool link to show what D3DXCreateTorus does: http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip A+ David

2 1

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 15 Feb '11

15 Feb '11

Hi Stefan. I'm not really into opengl internals, so I think the best solution for now is to implement 1), and give complete support when the blitting code will be in a better shape. Would this be okay? if (!context->valid) { context_release(context); FIXME("No gl context, cannot perform conversion\n"); return; } Thanks

1 0

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 15 Feb '11

15 Feb '11

> An idea that was proposed before was to delegate the conversion (and the > patents burden) to the OpenGL drivers, something like using > glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure > whether there are hidden issues with that approach (except, well, requiring > an OpenGL driver with compressed textures support), but at a first glance > it doesn't look as something particularly hard to do. Good idea. This new patch implements this approach. It seems to be working perfectly at least with the nvidia blob. It is also much smaller than the previous one, and doesn't require hacks like inverting colors and so on.

2 1

Re: [website] Turn on gzip compression
by Jeremy Newman 15 Feb '11

15 Feb '11

Actually, a better way to accomplish this is to add: php_flag zlib.output_compression On to the .htaccess file. I'm a little surprised it was not there already. -N On 02/15/2011 01:02 PM, André Hentschel wrote: > First make sure that works with your server... > --- > site | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/site b/site > index 5a7bd46..a776199 100644 > --- a/site > +++ b/site > @@ -5,6 +5,8 @@ > by Jeremy Newman<jnewman(a)codeweavers.com> > */ > > +ob_start("ob_gzhandler"); > + > // load modules and defines > $file_root = realpath(dirname(__FILE__)); > require("{$file_root}/include/incl.php"); > @@ -114,4 +116,5 @@ $html->page = $html->template("local", PAGE); > $html->showpage(); > > // done > +ob_end_flush(); > ?>

1 0

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.
by Marvin 15 Feb '11

15 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9273 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045

3 2

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)
by Alexandre Julliard 15 Feb '11

15 Feb '11

Daniel <danielfsantos(a)att.net> writes: > @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > - /* FIXME: add support for user style pens */ > + > logpen.lopnStyle = elp->elpPenStyle; > logpen.lopnWidth.x = elp->elpWidth; > logpen.lopnWidth.y = 0; > logpen.lopnColor = elp->elpColor; > + user_style_size = elp->elpNumEntries; > + user_style = elp->elpStyleEntry; This can't work, the data will be freed before you use it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] urlmon: Read remaining protocol data if report_data was called after binding finished.
by Marvin 15 Feb '11

15 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9272 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] Fixed several links in the documentation...
by Alexandre Julliard 15 Feb '11

15 Feb '11

max(a)mtew.isa-geek.net writes: > @@ -204,7 +204,7 @@ int CDECL MSVCRT__chdir(const char * newdir) > /********************************************************************* > * _wchdir (MSVCRT.@) > * > - * Unicode version of _chdir. > + * Unicode version of MSVCRT__chdir. You don't want to use the internal name here, it's not useful for users. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Fixed GetDIBits for top-down bitmaps (try 2).
by Alexandre Julliard 15 Feb '11

15 Feb '11

Jack Edmonds <pocketcookies2(a)gmail.com> writes: > gdi32/dib.c: Reversed source bitmap pointer instead of destination bitmap pointer. > Removed check for destination bitmap height when determining whether to copy the source bitmap upside down. > gdi32/tests/bitmap.c: Added a test for copying between top-down bitmaps. The rest of the code won't cope so well with a negative source width. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor
by Jacek Caban 15 Feb '11

15 Feb '11

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > Basic put_input() method for IXSLProcessor > + IXMLDOMNode *old_input = This->input; + HRESULT hr; - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input),&IID_IXMLDOMNode, (void**)&This->input); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input),&IID_IXMLDOMNode, (void**)&This->input); + + if (hr != S_OK) + { + IXMLDOMDocument *doc; + + hr = DOMDocument_create(&CLSID_DOMDocument, NULL, (void**)&doc); + if (hr == S_OK) + { + hr = IXMLDOMDocument_QueryInterface(doc,&IID_IXMLDOMNode, (void**)&This->input); + IXMLDOMDocument_Release(doc); + } + } + + if (hr == S_OK&& old_input) IXMLDOMNode_Release(old_input); Failure of QueryInterface call will set This->input to NULL (you probably want it not changed and even if not, that's a leak). It's probably better idea to have local pointer to the new input instead of old one and change it once you know the function will succeed. Jacek

2 2

Re: [4/5] msxml3/xsl: Store output stream for processor
by Jacek Caban 15 Feb '11

15 Feb '11

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > + case VT_UNKNOWN: > + hr = IUnknown_QueryInterface(V_UNKNOWN(&output),&IID_IStream, (void**)&This->output); > + break; You leak This->output here. Jacek

1 0

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)
by Daniel 15 Feb '11

15 Feb '11

grr, please disregard previous patches. I've discovered a problem that can lead to use of un-initialized values. Daniel On 02/15/2011 01:09 AM, Daniel wrote: > Clean up per Vitaliy's direction. Also found a FIXME comment that needed > to be removed. > > Daniel > > >

1 1

Re: gdi32: correct substitutions (take 2)
by Dmitry Timoshkov 15 Feb '11

15 Feb '11

Rafał Mużyło <galtgendo(a)gmail.com> wrote: > Corrected version of the previous patch. > This time I'm not adding a new helper function, just putting it in one > place. > Corrections: > - as oppossed to get_font_subst, reverse check can have more than one > result, so changed to adjust all of them > - just in case a->a substitution would result, explicitly prevent that > (perhaps gdi32 handles it gracefully, but it's still redundant) Did you test that Windows handles font substitutions this way? -- Dmitry.

1 0

Re: Re: [PATCH] Implement software DXT1 compression
by alberto＠mattea.info 14 Feb '11

14 Feb '11

Hi Stefan, thanks for your answer. I've checked the nvidia texture tools but, sadly, I think it's impossible to use them in wine: while they have c bindings, those bindings lack the essential function nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, nvttOutputHandler outputHandler, nvttImageHandler imageHandler) (commented out in the headers), so the output can only be written to a file. What about going the mesa way, where the drivers aren't linked with any s3tc library, but load it at runtime if it is present? Any idea is welcome.

2 1

Re: wine is passing make test again :-)
by Greg Geldorp 14 Feb '11

14 Feb '11

> From: Andre Hentschel > and now without the 9x stuff the result page looks better again, someone > just need to fix his user32 test :) Frankly, I'm a bit surprised and disappointed to see that people are not taking responsibility for fixing failures they introduced in tests. I don't expect to have time to clean up after them for the next month or so. Greg.

3 2

kernel32/process: Add stderr redirection for native linux programs started from windows program
by Igor Egorov 14 Feb '11

14 Feb '11

A week ago I submitted a patch for stderr redirection (http://www.winehq.org/pipermail/wine-patches/2011-February/098578.html), is there still something wrong with it? Will it be accepted?

2 1

Re: Austin English : shell32/tests: Don't check return values inside of if(0) ( LLVM/Clang).
by Charles Davis 14 Feb '11

14 Feb '11

Austin, Static analyzer checks for unreachable assignments (like the ones that were removed in this patch) were turned off in Clang trunk recently (as of r125415). Looks like Clang was wrong ;). Chip

2 1

Re: winex11.drv: Add PS_USERSTYLE support to pens
by Vitaliy Margolen 14 Feb '11

14 Feb '11

On 02/14/2011 03:55 AM, Daniel wrote: > Hello all. This only covers the screen. Support still needs to be added > to printers. > + case PS_USERSTYLE: { > + for(i = 0; i < physDev->pen.dash_len ; i++) { Please follow file style - curly braces on separate line. No braces for single line blocks. > + /* Should be limited to 16 or less */ > + char x11_user_style[16]; > + physDev->pen.dash_len = user_style_size > 16 ? 16 : user_style_size; Should use MAX_DASHLEN instead of magic numbers. Could use "min()" for simplicity. > + x11_user_style[i] = (char)(user_style[i] > 255 ? 255 : user_style[i]); Why not copy directly into physDev->pen.dashes? No need for typecast - it's done automatically. Vitaliy.

1 0

Re: kernel32: Implement and test GetVolumePathNamesForVolumeName.
by Alexandre Julliard 14 Feb '11

14 Feb '11

Hans Leidekker <hans(a)codeweavers.com> writes: > BOOL WINAPI GetVolumePathNamesForVolumeNameW(LPCWSTR volumename, LPWSTR volumepathname, DWORD buflen, PDWORD returnlen) > { > - FIXME("(%s, %p, %d, %p), stub!\n", debugstr_w(volumename), volumepathname, buflen, returnlen); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + static const WCHAR prefixW[] = > + {'\\','\\','?','\\','V','o','l','u','m','e','{','0','0','0','0','0','0','0','0','-','0','0','0','0','-', > + '0','0','0','0','-','0','0','0','0','-','0','0','0','0','0','0','0','0','0','0'}; > + static const WCHAR fmtW[] = {'%','c',':','\\',0}; > + > + TRACE("%s, %p, %u, %p\n", debugstr_w(volumename), volumepathname, buflen, returnlen); > + > + if (!volumename || strlenW( volumename ) != 49 || > + volumename[47] != '}' || memcmp( volumename, prefixW, sizeof(prefixW) )) > + { > + SetLastError( ERROR_INVALID_NAME ); > + return FALSE; > + } > + if (returnlen) > + { > + *returnlen = 5; > + } > + if (buflen < 5 || !volumepathname) > + { > + SetLastError( ERROR_MORE_DATA ); > + return FALSE; > + } > + sprintfW( volumepathname, fmtW, strtolW( volumename + 45, NULL, 16 ) ); > + volumepathname[4] = 0; > + return TRUE; Please don't make assumption about volume guids. This should be implemented by retrieving the correct data from mountmgr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] mshtml: Add IDispatchEx support to IXMLHTTPRequest
by Marvin 14 Feb '11

14 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9250 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === WXPPROSP3 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === WVISTAADM (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W2K8SE (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PRO (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PROX64 (32 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002 === W7PROX64 (64 bit domdoc) === domdoc.c:3449: Test failed: ret 80004002

1 0

wine is passing make test again :-)
by Austin English 13 Feb '11

13 Feb '11

Looks like Jacek and Gentoo have the magic combination. It's passed 4 days in a row: http://test.winehq.org/data/ae3e768a2e1f9c21b355798c8fbf473db3d83434/wine_j… http://test.winehq.org/data/bf640445c748b0588616da201e8ff8f3b1c778e9/wine_j… http://test.winehq.org/data/780f9b3b4fe8ff17784860a2a65b4ecab268436a/wine_j… http://test.winehq.org/data/745a50c9dbb03d37db58ff53136e93f00943bc0d/wine_j… now let's see if we can spread the love to someone else :-). -- -Austin

2 2

D3DXCreateTorus patch... thoughts?
by Misha Koshelev 13 Feb '11

13 Feb '11

This is for http://bugs.winehq.org/show_bug.cgi?id=23930 Based on my prior mesh patches. Test bot reports success: https://testbot.winehq.org/JobDetails.pl?Key=9240 Thank you Misha

1 0

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.
by Nicolas Le Cam 13 Feb '11

13 Feb '11

2011/2/8 Jack Edmonds <jack@jack-desktop.> > Fixes bug 25698 and addresses one of the test cases in bug 24278 (possibly > resolves bug 24278 but more testing is required to be sure). > > dib.c: Fills BITMAPINFOHEADER with correct width and height when bits == > NULL and copying from a top-to-bottom bitmap. > For top-to-bottom bitmaps, reverses the source pointer rather than the > destination pointer. > Ignoring the case when both source and destination are top-to-bottom > bitmaps and treating this as if the destination is only a top-to-bottom > bitmap. > --- > dlls/gdi32/dib.c | 113 > ++++++++++++++++++++++++--------------------- > dlls/gdi32/tests/bitmap.c | 112 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 173 insertions(+), 52 deletions(-) > > diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c > index 5067e49..bf7a525 100644 > --- a/dlls/gdi32/dib.c > +++ b/dlls/gdi32/dib.c > @@ -636,54 +636,6 @@ INT WINAPI GetDIBits( > > switch (bpp) > { > - case 0: /* query bitmap info only */ > - if (core_header) > - { > - BITMAPCOREHEADER* coreheader = (BITMAPCOREHEADER*) info; > - coreheader->bcWidth = bmp->bitmap.bmWidth; > - coreheader->bcHeight = bmp->bitmap.bmHeight; > - coreheader->bcPlanes = 1; > - coreheader->bcBitCount = bmp->bitmap.bmBitsPixel; > - } > - else > - { > - info->bmiHeader.biWidth = bmp->bitmap.bmWidth; > - info->bmiHeader.biHeight = bmp->bitmap.bmHeight; > - info->bmiHeader.biPlanes = 1; > - info->bmiHeader.biSizeImage = > - DIB_GetDIBImageBytes( bmp->bitmap.bmWidth, > - bmp->bitmap.bmHeight, > - bmp->bitmap.bmBitsPixel ); > - if (bmp->dib) > - { > - info->bmiHeader.biBitCount = bmp->dib->dsBm.bmBitsPixel; > - switch (bmp->dib->dsBm.bmBitsPixel) > - { > - case 16: > - case 32: > - info->bmiHeader.biCompression = BI_BITFIELDS; > - break; > - default: > - info->bmiHeader.biCompression = BI_RGB; > - break; > - } > - } > - else > - { > - info->bmiHeader.biCompression = (bmp->bitmap.bmBitsPixel > > 8) ? BI_BITFIELDS : BI_RGB; > - info->bmiHeader.biBitCount = bmp->bitmap.bmBitsPixel; > - } > - info->bmiHeader.biXPelsPerMeter = 0; > - info->bmiHeader.biYPelsPerMeter = 0; > - info->bmiHeader.biClrUsed = 0; > - info->bmiHeader.biClrImportant = 0; > - > - /* Windows 2000 doesn't touch the additional struct members if > - it's a BITMAPV4HEADER or a BITMAPV5HEADER */ > - } > - lines = abs(bmp->bitmap.bmHeight); > - goto done; > - > case 1: > case 4: > case 8: > @@ -877,10 +829,10 @@ INT WINAPI GetDIBits( > LPBYTE dbits = bits, sbits = (LPBYTE) bmp->dib->dsBm.bmBits + > (startscan * srcwidthb); > unsigned int x, y, width, widthb; > > - if ((height < 0) ^ (bmp->dib->dsBmih.biHeight < 0)) > + if (bmp->dib->dsBmih.biHeight < 0) > { > - dbits = (LPBYTE)bits + (dstwidthb * (lines-1)); > - dstwidthb = -dstwidthb; > + sbits += (srcwidthb * (abs(bmp->dib->dsBmih.biHeight) - > startscan - 1)); > + srcwidthb = -srcwidthb; > } > > switch( bpp ) { > @@ -1086,7 +1038,64 @@ INT WINAPI GetDIBits( > } > } > } > - else lines = abs(height); > + else /* query bitmap info only */ > + { > + if (core_header) > + { > + BITMAPCOREHEADER* coreheader = (BITMAPCOREHEADER*) info; > + if (bmp->dib) > + { > + coreheader->bcWidth = bmp->dib->dsBmih.biWidth; > + coreheader->bcHeight = bmp->dib->dsBmih.biHeight; > + } > + else > + { > + coreheader->bcWidth = bmp->bitmap.bmWidth; > + coreheader->bcHeight = bmp->bitmap.bmHeight; > + } > + coreheader->bcPlanes = 1; > + coreheader->bcBitCount = bmp->bitmap.bmBitsPixel; > + } > + else > + { > + if (bmp->dib) > + { > + info->bmiHeader.biHeight = bmp->dib->dsBmih.biHeight; > + info->bmiHeader.biWidth = bmp->dib->dsBmih.biWidth; > + info->bmiHeader.biBitCount = bmp->dib->dsBm.bmBitsPixel; > + switch (bmp->dib->dsBm.bmBitsPixel) > + { > + case 16: > + case 32: > + info->bmiHeader.biCompression = BI_BITFIELDS; > + break; > + default: > + info->bmiHeader.biCompression = BI_RGB; > + break; > + } > + } > + else > + { > + info->bmiHeader.biWidth = bmp->bitmap.bmWidth; > + info->bmiHeader.biHeight = bmp->bitmap.bmHeight; > + info->bmiHeader.biCompression = (bmp->bitmap.bmBitsPixel > > 8) ? BI_BITFIELDS : BI_RGB; > + info->bmiHeader.biBitCount = bmp->bitmap.bmBitsPixel; > + } > + info->bmiHeader.biPlanes = 1; > + info->bmiHeader.biSizeImage = > + DIB_GetDIBImageBytes( bmp->bitmap.bmWidth, > + bmp->bitmap.bmHeight, > + bmp->bitmap.bmBitsPixel ); > + info->bmiHeader.biXPelsPerMeter = 0; > + info->bmiHeader.biYPelsPerMeter = 0; > + info->bmiHeader.biClrUsed = 0; > + info->bmiHeader.biClrImportant = 0; > + > + /* Windows 2000 doesn't touch the additional struct members if > + it's a BITMAPV4HEADER or a BITMAPV5HEADER */ > + } > + lines = abs(bmp->bitmap.bmHeight); > + } > > /* The knowledge base article Q81498 ("DIBs and Their Uses") states > that > if bits == NULL and bpp != 0, only biSizeImage and the color table > are > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index d0d7a9c..a76d437 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -3050,6 +3050,116 @@ static void test_32bit_bitmap_blt(void) > DeleteDC(hdcScreen); > } > > +static void test_GetDIBits_info_query(void) > +{ > + BITMAPINFO bi; > + HBITMAP bmp; > + HDC hdc; > + int *picture; > + > + hdc = GetDC(NULL); > + > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + bmp = CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Test with a BITMAPINFOHEADER.*/ > + bi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(bi.bmiHeader.biHeight == 2, "Height should be 2."); > + ok(bi.bmiHeader.biWidth == 2, "Width should be 2."); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Now test with a BITMAPCOREHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPCOREHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(((BITMAPCOREHEADER*)&bi)->bcHeight == 2, "Height should be 2."); > + ok(((BITMAPCOREHEADER*)&bi)->bcWidth == 2, "Width should be 2."); > + /*Clean up.*/ > + DeleteObject(bmp); > + > + /*Test top to bottom bitmap.*/ > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=-2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + bmp = CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Test with a BITMAPINFOHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPINFOHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(bi.bmiHeader.biHeight == -2, "Height should be -2."); > + ok(bi.bmiHeader.biWidth == 2, "Width should be 2."); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Now test with a BITMAPCOREHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPCOREHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(((BITMAPCOREHEADER*)&bi)->bcHeight == (WORD)-2, "Height should be > -2."); > + ok(((BITMAPCOREHEADER*)&bi)->bcWidth == (WORD)2, "Width should be > 2."); > + /*Clean up.*/ > + DeleteObject(bmp); > +} > + > +static void test_GetDIBits_single_pixel_destination(void) > +{ > + BITMAPINFO bi; > + HBITMAP bmptb, bmpbt; > + HDC hdc; > + int pixelOut; > + int *picture; > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + > + /*Get the device context for the screen.*/ > + hdc=GetDC(NULL); > + > + /*Create the bottom to top image (image's bottom scan line is at the > top in memory).*/ > + bmpbt=CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Now that we have a pointer to the pixels, we write to them.*/ > + picture[0]=1; > + picture[1]=2; > + picture[2]=3; > + picture[3]=4; > + /*Create the top to bottom image (images' bottom scan line is at the > bottom in memory).*/ > + bi.bmiHeader.biHeight=-2; /*We specify that we want a top to bottom > image by specifying a negative height.*/ > + bmptb=CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Write to this top to bottom bitmap.*/ > + picture[0]=1; > + picture[1]=2; > + picture[2]=3; > + picture[3]=4; > + > + bi.bmiHeader.biWidth=1; > + > + bi.bmiHeader.biHeight=2; > + GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==1, "Bottom-up -> bottom-up should have first scanline."); > + GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==3, "Top-down -> bottom-up should have last scanline."); > + > + bi.bmiHeader.biHeight=-2; > + GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==1, "Bottom-up -> top-down should have first scanline."); > + GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==3, "Top-down -> top-down should have last scanline."); > + > + DeleteObject(bmpbt); > + DeleteObject(bmptb); > +} > + > START_TEST(bitmap) > { > HMODULE hdll; > @@ -3080,4 +3190,6 @@ START_TEST(bitmap) > test_bitmapinfoheadersize(); > test_get16dibits(); > test_clipping(); > + test_GetDIBits_single_pixel_destination(); > + test_GetDIBits_info_query(); > } > -- > 1.7.1 > > > > Hi Jack, You forgot trailing \n in the ok() calls. -- Nicolas Le Cam

2 1

Wine and Summer of Code 2011
by Dan Kegel 13 Feb '11

13 Feb '11

http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/fa… says projects can apply starting on Feb 28. In preparation, I moved the 2010 projects from http://wiki.winehq.org/SummerOfCode to http://wiki.winehq.org/SummerOfCode/PreviousProjects I also added a DSS Provider project idea, removed the gstreamer idea since that's implemented, and tidied up the dxdiag idea a bit. Who's interested in mentoring this year? And can y'all think of any fresh ideas for the suggested projects list, or ideas that should be retired? - Dan

6 5

vblank timestamps and page flipping in DRI2
by Saulius Krasuckas 13 Feb '11

13 Feb '11

There are some news on the $Subject: [1]. (have a look at the chapter "Fine tuned") I thought it could help Wine fixing such bugs as 6086, 13085, 17260, 22362 [2]. I'll paste the text in just for archiving purposes: --- quote --- Fine tuned The kernel hackers have extended the DRM infrastructure to include "precision vblank timestamps", which are explained in detail in the commit comment and are relevant to OpenML (Open Media Library) conformity. This feature enables the kernel to provide timestamps with an accuracy of a few microseconds, allowing applications to detect when the rendering of a new image has started ("double-buffer swap"). This can, for instance, be relevant for applications where it is important to precisely co-ordinate the audio output, or the control of other devices, with the rendering of the image. The technology was first implemented for experimental psychology and neuroscience applications, but it can also be applied to provide (more) jerk-free video playback, animations or desktop effects. Such timestamps can also be utilised by the new page flipping feature available via DRI2. This feature improves the way the kernel synchronises the release of an updated image with the moment the graphics hardware starts rendering the new image (Vsync). Synchronising the release avoids such distortions as flickering, tearing or incomplete rendering, as it prevents situations where one half of a displayed image is part of the old image while the other half is part of the new image . for instance with individual movie frames. In kernel version 38, the graphics driver support required for both features will be available via the AMD drivers (1, 2) and the Intel drivers (1, 2). The NVIDIA drivers currently only support page flipping (1, 2). --- quote --- S. [1] http://www.h-online.com/open/features/Kernel-Log-Coming-in-2-6-38-Part-1-Gr… [2] http://bugs.winehq.org/show_bug.cgi?id=6086 http://bugs.winehq.org/show_bug.cgi?id=13085 http://bugs.winehq.org/show_bug.cgi?id=17260 http://bugs.winehq.org/show_bug.cgi?id=22362

2 1

Tiny imap message appender written in perl
by Krzysztof Nikiel 13 Feb '11

13 Feb '11

It's a kind of side effect of my Wine patching. Sending those patches traditional way was an epic fail. Mail client wrapped lines, git-imap-send provided by Debian don't support SSL. I have modified my tiny imap downloader to append new messages to specified box. It uses Net::SSLeay module. Maybe it will be useful to someone.

2 2

Tiny imap message appender written in perl different attachment
by Krzysztof Nikiel 13 Feb '11

13 Feb '11

This attachment may be better: #!/usr/bin/perl # SSL IMAP message appender # Copyright (C) 2011 Krzysztof Nikiel use Socket; use Net::SSLeay qw(die_now die_if_ssl_error); Net::SSLeay::load_error_strings(); Net::SSLeay::SSLeay_add_ssl_algorithms(); Net::SSLeay::randomize(); $g_port=993; $g_tag=1; $g_ret=""; if ($#ARGV < 3) { print "usage: $0 server user box pass file1 ...\n", "\tAppends files to the specified IMAP box.\n\n"; exit; } $g_serv=shift @ARGV; $g_user=shift @ARGV; $g_box=shift @ARGV; $g_pass=shift @ARGV; sub imapclient { my $dest_serv, $port, $dest_ip, $dest_serv_params; my $ctx, $res; my $res; my @boxlist; my $boxok = 0; $port = $g_port; $port = getservbyname($port, 'tcp') unless $port =~ /^\d+$/; $dest_ip = gethostbyname($g_serv); $dest_serv_params = sockaddr_in($port, $dest_ip); socket(S, &AF_INET, &SOCK_STREAM, 0) or die "socket: $!"; connect(S, $dest_serv_params) or die "connect: $!"; select(S); $| = 1; select(STDOUT); # The network connection is now open, lets fire up SSL $ctx = Net::SSLeay::CTX_new() or die_now("Failed to create SSL_CTX $!"); $g_ssl = Net::SSLeay::new($ctx) or die_now("Failed to create SSL $!"); Net::SSLeay::set_fd($g_ssl, fileno(S)); # Must use fileno $res = Net::SSLeay::connect($g_ssl); print "Cipher '" . Net::SSLeay::get_cipher($g_ssl) . "'\n"; # IMAP client starts here print "\nconnecting to $g_serv\n"; imapread(); showresp(); unless ($g_ret =~ /^\* OK/) {return}; print "logging in as $g_user\n"; $res = imapcmd("LOGIN $g_user $g_pass"); imapread(); showresp(); print "reading mailbox list\n"; $res = imapcmd("LIST \"\" \*"); imapread(); unless (testresp($g_ret)) { print "LIST failed\n"; goto logout; } #print "list ret: '$g_ret'\n"; @boxlist=(); foreach (split /\n/,$g_ret) { if (/^* LIST [^"]*"[^"]*"[^"]*"([^"]*)"/) { push @boxlist,$1; } } foreach (@boxlist) { print "$_\n"; if ("$_" eq "$g_box") {$boxok = 1} } if (!$boxok) {print "Warning: can't find '$g_box' in mailbox names\n"} foreach (@ARGV) { imapappend("$g_box", $_); } logout: print "logging out\n"; $res = imapcmd("LOGOUT"); imapread(); showresp(); if ($g_ret =~ /^\* BYE/) {print "LOGOUT OK\n"}; do { imapread(); showresp(); } while ($g_ret ne ""); #end of IMAP code shutdown S, 1; # Half close --> No more output, sends EOF to server $res = Net::SSLeay::read($g_ssl); # Perl returns undef on failure print $res; Net::SSLeay::free($g_ssl); # Tear down connection Net::SSLeay::CTX_free($ctx); close S; } sub imapappend { my $res, $resp; my $box = @_[0]; my $file = @_[1]; my @msg = (); print "reading from '$file'..."; if (!open(MSG,"<",$file)) { print "Warning: can't open $file\n"; return; } $size = 0; while(<MSG>) { chomp; push @msg,$_; $size += length; $size += 2; } close MSG; print $#msg + 1, " lines; $size bytes\n"; print "appending to \"$box\"\n"; $res = imapcmd("APPEND \"$box\" {$size}"); imapread(); showresp(); unless ($g_ret =~ /^+/) {return}; foreach (@msg) { $res = sslwrite("$_"); } $res = sslwrite(""); imapread(); showresp(); } sub showresp { print $g_ret; } sub imapread { $g_ret = Net::SSLeay::read($g_ssl); $g_ret =~ s/\r//g; } sub imapcmd { my ($msg) = @_; my $res; $g_tag += 1; return sslwrite("TAG$g_tag $msg"); } sub sslwrite { my ($msg) = @_; my $res; $res = Net::SSLeay::ssl_write_all($g_ssl, "$msg\r\n"); return $res; } sub testresp { if (@_[0] =~ /TAG(\d+) OK/) { if ($1 == $g_tag) {return 1} } return 0; } imapclient();

1 0

Re: winex11.drv: map_window should honor iconic state
by Alexandre Julliard 13 Feb '11

13 Feb '11

Alexander Lakhin <exclusion(a)gmail.com> writes: > + data->iconic = (new_style & WS_MINIMIZE) != 0; > + > if (!data->embedded) > { > update_net_wm_states( display, data ); > sync_window_style( display, data ); > wine_tsx11_lock(); > XMapWindow( display, data->whole_window ); > + if (data->iconic) > + XIconifyWindow( display, data->whole_window, DefaultScreen(display) ); This is handled by setting the initial window state in the wm hints. If there's somewhere that the state isn't set correctly, that's what should be fixed. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: gdi32: Add an EnumFontFamilies test to see how it handles various font faces.
by Marvin 13 Feb '11

13 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9230 Your paranoid android. === WNT4WSSP6 (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === W2KPROSP4 (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === WXPPROSP3 (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === W2K3R2SESP2 (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === WVISTAADM (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === W2K8SE (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated === W7PRO (32 bit font) === font.c:3495: Test failed: expected Arial Bold got Arial font.c:3545: Test failed: font Arial Bold should not be enumerated font.c:3495: Test failed: expected Arial Bold Italic got Arial font.c:3553: Test failed: font Arial Bold Italic should not be enumerated

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel