- wine-devel - winehq.org

Re: avifil32: Skip tests when we couldn't create or open the AVI file
by GOUJON Alexandre 11 Feb '11

11 Feb '11

On 01/30/2011 07:29 PM, Alexandre Goujon wrote: > --- > dlls/avifil32/tests/api.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/dlls/avifil32/tests/api.c b/dlls/avifil32/tests/api.c > index 14ad4b4..c1ba878 100644 > --- a/dlls/avifil32/tests/api.c > +++ b/dlls/avifil32/tests/api.c > @@ -338,6 +338,12 @@ static void create_avi_file(const COMMON_AVI_HEADERS *cah, char *filename) > > ok(hFile != INVALID_HANDLE_VALUE, "Couldn't create file\n"); > > + if(hFile == INVALID_HANDLE_VALUE) > + { > + win_skip("Could not create the AVI file\n"); > + return; > + } > + > WriteFile(hFile,&cah->fh, sizeof(deffh),&written, NULL); > WriteFile(hFile,&cah->mah, sizeof(MainAVIHeader),&written, NULL); > WriteFile(hFile, streamlist, sizeof(streamlist),&written, NULL); > @@ -380,6 +386,12 @@ static void test_default_data(void) > ok(res != REGDB_E_CLASSNOTREG, "Unable to open file: error5=%u\n", REGDB_E_CLASSNOTREG); > ok(res == 0, "Unable to open file: error=%u\n", res); > > + if(res != 0) > + { > + win_skip("Could not open the file.\n"); > + return; > + } > + > res = AVIFileGetStream(pFile,&pStream0, 0, 0); > ok(res == 0, "Unable to open video stream: error=%u\n", res); I know I sent this patch about two weeks ago but I thought it was pending because of the 1.3.13 release. So, does anyone has an idea how to make this patch applied in the current tree ? The context is that we don't fail when we couldn't create or open the AVI file. (I think the title of the patch is explicit) Thus, we call "WriteFile(hFile" in the first part of the test even if hFile == INVALID_HANDLE_VALUE. In the second part, we call "AVIFileGetStream(pFile" even if "AVIFileOpen(&pFile" failed. I can also resend this appending [resent]. Just let me know what to do. Thanks !

3 3

Re: ole32/tests: make sure to use a return value (LLVM/Clang) (2/3)
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9189 Your paranoid android. === WNT4WSSP6 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2KPROSP4 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === WXPPROSP3 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2K3R2SESP2 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === WVISTAADM (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W2K8SE (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PRO (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PROX64 (32 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005 === W7PROX64 (64 bit ole2) === ole2.c:1660: Test failed: IOleObject_SetExtent failed with error 0x80040005

1 0

Re: shell32/tests: make sure return values are used (LLVM/Clang) (4/7)
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9177 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2210: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: msi/tests: make sure to use a return value (LLVM/Clang) (2/2)
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9162 Your paranoid android. === WVISTAADM (32 bit db) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Add test for nested default Button in Dialogs
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9151 Your paranoid android. === WVISTAADM (32 bit dialog) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [3/3] user32: SetParent() needs to map window rectangle to the new parent.
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9136 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: rpcrt4/tests: remove a dead assignment (LLVM/Clang)
by Marvin 10 Feb '11

10 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9120 Your paranoid android. === WNT4WSSP6 (32 bit ndr_marshall) === ndr_marshall: unhandled exception c0000005 at 004081C6

2 1

Re: ntdll: Increase buffer size for debugging functions
by Alexandre Julliard 09 Feb '11

09 Feb '11

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > Since warn+debugstr takes user data increase and basically does > WARN("%s\n", msg); the buffer size is too small, increasing the size > makes the lord of the rings online launcher print messages to WARN > without crashing That's just hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

error message for ddraw
by David Adam 09 Feb '11

09 Feb '11

When I test the following test rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_FULLSCREEN | DDSCL_EXCLUSIVE | DDSCL_CREATEDEVICEWINDOW); ok(rc==DDERR_INVALIDPARAMS, "Expected DDERR_INVALIDPARAMS, received %x\n", rc); in my vista box, I receive the following failing message ddrawmodes: test failed: expected DDERR_INVALIDPARAMS, received 8876035a. But I don't know what is this message. Does anyone know what means this message? Thanks in advance A+ David

2 1

Try to Implement my first Stub function - AbortPrinter() - (try 2).
by Loïc Maury 09 Feb '11

09 Feb '11

Hello, After the various comments, I have modified the patch. What do you think ? Thank You Loïc

4 8

Patch 21026 superseded by patch 71118.
by Max TenEyck Woodbury 09 Feb '11

09 Feb '11

No text.

1 0

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt
by Matteo Bruni 09 Feb '11

09 Feb '11

> + /* We need the for loop, since we need to convert the integer to a float */ > + for (i = 0; i < count && i < desc.RegisterCount; i++) > + { > + row[0] = (float)n[i]; The cast is unneeded, and the comment above is too.

2 2

Re: d3dx9_36: make sure return values are used (LLVM/Clang)
by Matteo Bruni 09 Feb '11

09 Feb '11

hr = IDirect3DTexture9_GetLevelDesc(texture, 0, &desc); + ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, D3D_OK); Copy-paste error, it should be GetLevelDesc in the ok() message. :)

1 0

Re: user32: Add message tests for SetParent().
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9096 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: d3dx9_36: Implement a few tests for D3DXCreateBox
by Stefan Dösinger 09 Feb '11

09 Feb '11

Am Mittwoch 09 Februar 2011, 07:34:21 schrieb David Adam: > + wnd = CreateWindow("static", "d3dx9_test", 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL); The class "static" doesn't work on Windows 7, I am afraid you'll need a proper window class. And I think a CreateWindow failure should count as test failure, it's a stupid reason to skip the entire test. (The other d3dx9 tests may have the same issue)

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.
by Alexandre Julliard 09 Feb '11

09 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This test is supposed to show the root of the problem with the test > application attached to the bug 13951. It appears that the check performed > by server/window.c,is_top_level_window() is not correct (which leads to > a SetWindowPos() failure to set foreground window), and probably should be > replaced by simple (win->style & (WS_CHILD | WS_POPUP)) != WS_CHILD. Maybe, but the test doesn't really demonstrate that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mshtml/tests: make sure return values are used (LLVM/Clang)
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9073 Your paranoid android. === WXPPROSP3 (32 bit dom) === No test summary line found

1 0

Re: secur32/tests: make sure a return value is used (LLVM/Clang)
by Marvin 09 Feb '11

09 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9068 Your paranoid android. === WNT4WSSP6 (32 bit ntlm) === ntlm.c:1231: Test failed: AcquireCredentialsHande() returned SEC_E_INVALID_TOKEN ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:885: Test failed: cbSecurityTrailer should be 16 but is 0 ntlm.c:423: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:433: Test failed: expected SEC_E_INTERNAL_ERROR or SEC_I_CONTINUE_NEEDED, got SEC_E_NO_IMPERSONATION ntlm.c:445: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:457: Test failed: expected SEC_E_BUFFER_TOO_SMALL, got SEC_E_INSUFFICIENT_MEMORY ntlm.c:1031: Test failed: MakeSignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1061: Test failed: Crypt trailer not as expected. ntlm.c:1075: Test failed: Crypt message not as expected. ntlm.c:1097: Test failed: DecryptMessage returned SEC_E_MESSAGE_ALTERED, not SEC_E_OK. ntlm.c:1099: Test failed: Failed to decrypt message correctly. ntlm.c:1127: Test failed: MakeSignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1135: Test failed: VerifySignature returned SEC_E_INVALID_TOKEN, not SEC_E_OK ntlm.c:1139: Test failed: EncryptMessage returned SEC_E_INVALID_TOKEN, not SEC_E_OK. ntlm.c:1157: Test failed: Crypt message not as expected. ntlm.c:1176: Test failed: DecryptMessage returned SEC_E_INVALID_TOKEN, not SEC_E_OK.

1 0

Re: comctl32/tests: Use a function instead of a macro for CheckSize test
by Vitaliy Margolen 09 Feb '11

09 Feb '11

On 02/08/2011 04:45 PM, EG Galano wrote: > This fixes the warnings: > comctl32/tests/tab.c:525: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:545: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:568: warning: logical `&&' with non-zero constant > will always evaluate as true > comctl32/tests/tab.c:1015: warning: logical `&&' with non-zero > constant will always evaluate as true > > for me on Debian gcc 4.3.2 Time to file bug for the compiler. Yes macro looks bad and that's not the way I would have done it now, but there is not a single place where "non-zero constant" is used directly with logical AND. Also what Nikolay said. Vitaliy.

1 0

Re: comctl32/tests: Use a function instead of a macro for CheckSize test
by Nikolay Sivov 08 Feb '11

08 Feb '11

On 2/9/2011 02:45, EG Galano wrote: Main problem with that - you will lost ok() context in test output, line numbers will be always the same. Look like it's resolved in other places - a thin macro to pass a line number to a function and ok_(, <linenumber>) test inside.

1 0

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)
by Juan Lang 08 Feb '11

08 Feb '11

Hi Janne, + handle = NULL; + ZeroMemory(&overlapped, sizeof(overlapped)); + overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); + ret = gNotifyAddrChange(&handle, &overlapped); + ok(ret == ERROR_IO_PENDING, "NotifyAddrChange returned %d, expected ERROR_IO_PENDING\n", ret); + ok(handle != INVALID_HANDLE_VALUE, "NotifyAddrChange returned invalid file handle\n"); This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrChange succeeded and attempt to do a wait on an invalid handle value, resulting in a crash. Thanks, --Juan

2 1

Re: po: Update French translation
by Paul Vriens 08 Feb '11

08 Feb '11

On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: > #: avifil32.rc:27 > +#, fuzzy > msgid "Waveform: %s" > msgstr "Waveform : %s" > > #: avifil32.rc:28 > +#, fuzzy > msgid "Waveform" > msgstr "Waveform" Hi, Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are ignored for translations: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1898f22ca5d2d79750e98… -- Cheers, Paul.

2 1

Re: [PATCH 3/5] d3dx9_36: Implemented ID3DXConstantTable_SetVector and ID3DXConstantTable_SetVectorArray
by Matteo Bruni 08 Feb '11

08 Feb '11

> + if (is_vertex_shader(This->desc.Version)) > + IDirect3DDevice9_SetVertexShaderConstantF(device, desc.RegisterIndex + i, (float *)fvector, > + desc.RegisterCount); You should probably just use 1 instead of desc.RegisterCount in SetVertexShaderConstantF, as you are already in a loop for each vector. Also, why are you casting a (float *) to a (float *)? Especially after creating a float array just for that. However, making you use a temporary array to convert struct D3DXVECTOR4 to (float *) was somewhat my bad suggestion I believe. My concern was that the structure maybe didn't have its fields packed (with some padding between the fields of the structure for alignment reasons) and just casting the struct pointer to (float *) would not give correct results. Looking at the definition of D3DXVECTOR4 (and assuming it is correct), it appears to not be the case, so you can simply cast it to (float *). Then you can remove the for loop altogether and just set min(count, desc.RegisterCount) registers in the Set{Vertex/Pixel}ShaderConstantF call. Sorry for not being clear enough / giving wrong directions. Please add a "(try n)" suffix to the email subject when you're sending new versions of a patch.

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9039 Your paranoid android. === W7PROX64 (64 bit win) === win.c:3480: Test failed: SetForegroundWindow() failed

2 1

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9028 Your paranoid android. === WNT4WSSP6 (32 bit clipping) === clipping.c:438: Test failed: expected 0,0-0,0, got 0,0-800,600

3 2

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9030 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

1 0

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9029 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

1 0

Re: mstask/tests: make sure return values are used (LLVM/Clang)
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9011 Your paranoid android. === WNT4WSSP6 (32 bit task_trigger) === task_trigger.c:165: Test failed: Failed to setup test_task

2 1

Re: gdi32: Text output of records EMR_EXTTEXTOUTA/W depend on field iGraphicsMode
by Austin English 08 Feb '11

08 Feb '11

On Mon, Feb 7, 2011 at 15:49, Alexander Kochetkov <al.kochet(a)gmail.com> wrote: > Fix for bug #22996, and likely for bug #16557. > > BTW, I think, what the same problem exist with EMR_POLYTEXTOUTA/W records. Forgot the patch. -- -Austin

1 0

Re: inetcomm/tests: make sure to use return values (LLVM/Clang)
by Marvin 08 Feb '11

08 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9009 Your paranoid android. === WXPPROSP3 (32 bit mimeole) === No test summary line found

1 0

Re: comctl32/tests: Fixed variable type, removed sign comparison warning.
by Nikolay Sivov 07 Feb '11

07 Feb '11

On 2/8/2011 00:26, Marko Nikolic wrote: > --- > dlls/comctl32/tests/trackbar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/tests/trackbar.c b/dlls/comctl32/tests/trackbar.c > index ac67d50..714a321 100644 > --- a/dlls/comctl32/tests/trackbar.c > +++ b/dlls/comctl32/tests/trackbar.c > @@ -953,7 +953,7 @@ static void test_ignore_selection(HWND hWndTrackbar){ > static void test_initial_state(void) > { > HWND hWnd; > - DWORD ret; > + HRESULT ret; > > hWnd = create_trackbar(0, hWndParent); This is wrong, did you mean LRESULT?

1 0

Killing WineAPI project on SourceForge.
by Max TenEyck Woodbury 07 Feb '11

07 Feb '11

No feedback and apparently no interest in the WineAPI project on SourceForge. Understandable since there is now a WineAPI on the regular Wine Wiki. Unless someone objects, I'm going to ask that it be shutdown on SourceForge. Max

5 6

Including winegcc-built shared library in Debian binary package
by Robert McDonald 07 Feb '11

07 Feb '11

I've got a Debian binary package configured. A wrapper script is installed in /usr/bin that invokes wine on the winegcc-built shared library that implements the program. The shared library is installed in /usr/lib and then ldconfig is run during the installation process. The shared library build product seems to be a special case because it is built by winegcc and referenced on the wine command line when run. I've got questions about this even though the product works OK as packaged. Is there a more appropriate installation directory than /usr/lib for the shared library (although lintian complains if I don't put it in /usr/lib)? Does ldconfig need to be run after installing/uninstalling the shared library (other than to satisfy lintian complaints if ldconfig isn't run from postinst/postrm)? Is there any reason to bother with version numbering the shared library (other than using one version number for all library releases just to keep lintian happy by having the version number) since the library is prepared by winegcc and will only be loaded by wine? To look for answers, I've done the following: * searched the web * searched the WineHQ web site and read the FAQ there * scanned the subject lines of a couple of months of this mailing list * read http://wiki.winehq.org/Packaging * used https://wiki.ubuntu.com/PackagingGuide/Complete for some packaging instructions * read http://www.bytehold.com/index.php/projects/176-debian-binary-package-and-re… for general instructions in setting up a Debian binary package * read http://www.pathname.com/fhs/ for recommendations on locating files URLs to relevant resources would be welcome. -- Robert McDonald BitTorrent, Inc.

2 1

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases.
by André Hentschel 07 Feb '11

07 Feb '11

Hi, in todo_wine blocks only ok() calls should be made. So consider splitting them down to "todo_wine ok(..." for each. > -CancelIPChangeNotify > CreateProxyArpEntry > DeleteIPAddress > DeleteProxyArpEntry > EnableRouter > FlushIpNetTable > GetAdapterIndex > -NotifyAddrChange > -NotifyRouteChange > +NotifyRouteChange + CancelIPChangeNotify this change regarding CancelIPChangeNotify is also not needed. -- Best Regards, André Hentschel

2 1

Re: oleaut32: Fix copying an array of 0 elements
by Marvin 07 Feb '11

07 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8987 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2KPROSP4 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === WXPPROSP3 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2K3R2SESP2 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === WVISTAADM (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W2K8SE (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PRO (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PROX64 (32 bit safearray) === safearray: unhandled exception c0000005 at 0040E5A5 === W7PROX64 (64 bit safearray) === Timeout

1 0

Patch to fix ntdll:exception tests on Mac OS
by Charles Davis 07 Feb '11

07 Feb '11

Hi, This is a small patch I wrote to fix the exception tests on Mac OS X. Right now, if you look at the Mac results I submitted, you'll notice that there are two failures. The first failure happens because Mach doesn't allow the 'global' flag to be set when setting the debug registers. Changing the test not to set the global flag causes the test to pass. I get the feeling, though, that there is a good reason the global flag was set, so I'm reluctant to send that change in. The other failure happens because 32-bit Mac OS only protects stacks from execution. If you clear PROT_EXEC on any other data, you can still execute code from it. (64-bit Mac OS, on the other hand, always respects the PROT_EXEC flag.) I changed ntdll on 32-bit Mac OS to report DEP as permanently disabled, but I wonder if this was the right change to make. I just want to know: am I doing the right thing here? If not, what should I do instead to fix the tests? Chip

1 0

Re: user32: Don't try to move mouse to (-1,0).
by Vitaliy Margolen 06 Feb '11

06 Feb '11

On 02/05/2011 07:10 AM, Jacek Caban wrote: > > This trigers screen edge action on KDE, which is 'Present Windows' in > default configuration. mouse_event() generates relative mouse movement events unless MOUSEEVENTF_ABSOLUTE is specified. If you don't want a pointer to get near the edge then you should use SetCursorPos() instead. Vitaliy.

2 1

re: Wine FAQ edits
by Dan Kegel 06 Feb '11

06 Feb '11

Hi Albert, http://wiki.winehq.org/FAQ?action=diff&rev2=384&rev1=383 looks like it was a pretty big edit. Try smaller ones, and try to do just one kind of change per edit.

7 20

re: Pulling Patch
by Dan Kegel 06 Feb '11

06 Feb '11

James McKenzie wrote: > Since my Mac is dying I have decided to return to the Windows world. > > Please pull any and all patches. I have envoked the right to copyright > and none of my code can or will be used in Wine. Sorry to see you go, but... why would you want to prohibit people from using your patches? (I only see two typo changes committed: http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=James+Mc… Presumably you don't mean those, since they were trivial comment changes.) I guess you mean patches like http://www.winehq.org/pipermail/wine-patches/2010-June/089537.html When you sent those to wine-patches, weren't you placing them under the LGPL? - Dan

4 5

RE: shell32/tests: Clean make new folder test (Valgrind)
by Michael Mc Donnell 05 Feb '11

05 Feb '11

Hi! What is the reason this patch by Nikolay Sivov was not included in the latest version of wine? It fixes a clean-up bug on some Windows XP machines, and tidies up the code nicely. Wine-patches archive link: http://www.winehq.org/pipermail/wine-patches/2011-January/098342.html Regards, Michael Mc Donnell P.S. Thanks Nikolay for fixing my first win32 test.

1 0

Re: user32: Don't try to move mouse to (-1,0).
by Marvin 05 Feb '11

05 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8925 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Pulling Patch
by James McKenzie 05 Feb '11

05 Feb '11

Since my Mac is dying I have decided to return to the Windows world. Please pull any and all patches. I have envoked the right to copyright and none of my code can or will be used in Wine. Thank you. James McKenzie

2 1

Re: winspool.drv: make sure to use return values (LLVM/Clang)
by Marvin 05 Feb '11

05 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8921 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Wine API documentation questions.
by Max TenEyck Woodbury 05 Feb '11

05 Feb '11

I've been going through the Wine API documentation and there seem to be some things that I think should be changed: - There are references to Wine documents that do not include links to the pages. The links should be included. - Some 'implementation' sections claim that the API is not declared but there are declarations, just not in headers that 'c2man' is looking at. It should also look in any sub-directories (except for 'tests') of the '-I' directories it is told about for additional headers. (I have very little skill with Perl at present, so someone else might be able to add this much faster than I will be able to do it.) - There are quite a few APIs implemented but without standard documentation. All accessible APIs should have enough documentation so that there is a page for it, even if it is only a synopsis. - Mangled interface names only appear in their mangled form. The documentation should include the demangled name as well. Should the demangled names also appear in the indexes? - The 'synopsis' does not include needed '#include' directives. This may need to be fixed in each API description rather than trying to get 'c2man' to generate it. - The name of the file containing the implementation is included in each 'implementation' section and includes a link to the appropriate repository source entry. The name of the appropriate header is also included, but does not include a link. A link should be included. Max

1 0

Re: kernel32/process: Add stderr redirection for native linux programs started from windows program
by Austin English 05 Feb '11

05 Feb '11

On Fri, Feb 4, 2011 at 18:22, Igor Egorov <atohom(a)gmail.com> wrote: > This is my first patch, not sure if I done all right. I didn't look at the actual change, but: > mode change 100644 => 100755 dlls/kernel32/process.c doesn't seem necessary to me. -- -Austin

2 1

Re: gdi32/tests: make sure to use return value (LLVM/Clang)
by Marvin 05 Feb '11

05 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8891 Your paranoid android. === WVISTAADM (32 bit font) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Tray icon not showing up if wine was run previously with DISPLAY unset?
by Dan Kegel 04 Feb '11

04 Feb '11

So, I've got this shell script that does something like h=`wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great. However, if the user has selected to run wine in a virtual desktop, running winepath will start up and then shut down the virtual desktop, which is visually annoying. Second try: unset DISPLAY when running winepath, e.g. h=`DISPLAY= wine winepath -w $HOME` ... wine autohotkey run-setup.ahk Works great; now winepath doesn't pop up the desktop. Except now autohotkey's tray icon doesn't show up at all, which makes it hard to debug the autohotkey script. (The setup that autohotkey runs can access X just fine, so the problem seems confined to the tray icon.) Is the lack of tray icon a wine bug, or a user error? Third try: wait for wineserver to exit before starting autohotkey h=`DISPLAY= wine winepath -w $HOME` ... wineserver -w wine autohotkey run-setup.ahk but that's slower, and will hang if the user is running a wine app. I guess I could do "sleep 5" but that's an awful kludge. Probably I'll go back to letting the ugly virtual desktop pop up. So, what's the proper way to run one app under wine *without* X while letting other apps run wine *with* X? - Dan

2 1

Re: loader: Build the preloader for ARM
by Alexandre Julliard 04 Feb '11

04 Feb '11

André Hentschel <nerv(a)dawncrow.de> writes: > +unsigned int wld_modulo( const unsigned int a, const Elf32_Word b ) > +{ > +#ifdef __ARM_EABI__ > + unsigned int i; > + if(b > a) return a; > + for(i = 0; i * b < a + b; i++) > + if(i * b > a - b) return (a - i * b); > + return 0; That's very inefficient, there are better ways... -- Alexandre Julliard julliard(a)winehq.org

4 5

the patches around ok()
by Joris Huizer 04 Feb '11

04 Feb '11

Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris

2 1

Re: kernel32/tests/thread.c: Don't call in ok()
by Henri Verbeet 04 Feb '11

04 Feb '11

On 4 February 2011 17:15, Joris Huizer <joris_huizer(a)yahoo.com> wrote: > Subject: kernel32/tests/thread.c: Don't call in ok() Why not?

2 1

Try to Implement my first Stub function - AbortPrinter().
by Loïc Maury 04 Feb '11

04 Feb '11

Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a document was spooled. I saw that the API printer functions are in dlls/winspool.drv/info.c I understood that there are 4 structures used, *opened_printer_t* for manage a printer, *jobqueue_t* for a list of job for a printer, *started_doc_t* who manage a document, and *job_t* for manage a job. I am on Mac Os 10.6, with CUPS. Here is the code, what do you think ? BOOL WINAPI AbortPrinter(HANDLE hPrinter) { PRINTER_INFO_5W *pi5 = NULL; BOOL ret = FALSE; opened_printer_t *printer; struct list *cursor, *cursor2; job_t *job = 0; DWORD jobDocId; DWORD needed; LPWSTR portname; #if defined(__APPLE__) EnterCriticalSection(&printer_handles_cs); printer = get_opened_printer(hPrinter); if(!printer) { ERR("The handle for the printer is invalid.\n"); SetLastError(ERROR_INVALID_HANDLE); goto end; } TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) ,debugstr_w(printer->printername) ,printer->backend_printer ,printer->queue->ref ,list_count(&printer->queue->jobs)); /* No jobs to manage. */ if(list_count(&printer->queue->jobs) == 0) { ERR("No job in the list.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } if(printer->doc) { TRACE("Document inside for job id : %d\n", printer->doc->job_id); jobDocId = printer->doc->job_id; } else { ERR("No document.\n"); SetLastError(ERROR_SPL_NO_STARTDOC); goto end; } /* For each jobs, get the job document in the double linked list */ LIST_FOR_EACH_SAFE(cursor, cursor2, &printer->queue->jobs) { /* Take a job. */ job = LIST_ENTRY(cursor, job_t, entry); TRACE("(job id : %d, filename : %s, portname : %s, document title : %s, printer name %s)\n",job->job_id ,debugstr_w(job->filename) ,debugstr_w(job->portname) ,debugstr_w(job->document_title) ,debugstr_w(job->printer_name)); if(jobDocId == job->job_id) { TRACE("(hf : %p, job id : %d)\n",printer->doc->hf ,printer->doc->job_id); /* Get portname. */ if (!job->portname) { GetPrinterW(hPrinter, 5, NULL, 0, &needed); pi5 = HeapAlloc(GetProcessHeap(), 0, needed); GetPrinterW(hPrinter, 5, (LPBYTE)pi5, needed, &needed); portname = pi5->pPortName; } TRACE("portname : %s\n", debugstr_w(portname)); /* Cups Port */ if(!strncmpW(portname, CUPS_Port, strlenW(CUPS_Port))) { TRACE("Remove job from the list.\n"); list_remove(cursor); CloseHandle(printer->doc->hf); DeleteFileW(job->filename); HeapFree(GetProcessHeap(), 0, job->document_title); HeapFree(GetProcessHeap(), 0, job->printer_name); HeapFree(GetProcessHeap(), 0, job->portname); HeapFree(GetProcessHeap(), 0, job->filename); HeapFree(GetProcessHeap(), 0, job->devmode); HeapFree(GetProcessHeap(), 0, job); job = 0; ret = TRUE; if(pi5) HeapFree(GetProcessHeap(), 0, pi5); } else FIXME("only CUPS for now.\n"); } } end: LeaveCriticalSection(&printer_handles_cs); TRACE("return %d\n", ret); return ret; #else TRACE("Only CUPS for Mac Os is managed for now.\n"); return FALSE; #endif } Merci Loïc

4 4

Re: msvcr90: Fixed a typo
by Nikolay Sivov 04 Feb '11

04 Feb '11

On 2/4/2011 18:33, André Hentschel wrote: > --- > dlls/msvcr90/msvcr90.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msvcr90/msvcr90.c b/dlls/msvcr90/msvcr90.c > index 2c811cb..d2a61dd 100644 > --- a/dlls/msvcr90/msvcr90.c > +++ b/dlls/msvcr90/msvcr90.c > @@ -315,7 +315,7 @@ const char * __thiscall MSVCRT_type_info_name_internal_method(type_info * _this, > if (!_this->name) > { > /* Create and set the demangled name */ > - /* Nota: mangled name in type_info struct always start with a '.', while > + /* Note: mangled name in type_info struct always start with a '.', while > * it isn't valid for mangled name. > * Is this '.' really part of the mangled name, or has it some other meaning ? > */ Maybe 'starts with' ?

2 1

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.
by Alexandre Julliard 04 Feb '11

04 Feb '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + SetLastError(0xdeadbeef); > +todo_wine > + ok(SetForegroundWindow(popup), "SetForegroundWindow() error %d\n", GetLastError()); It would be interesting to test what the foreground window is actually set to. > + SetLastError(0xdeadbeef); > + ok(DestroyWindow(parent), "DestroyWindow() error %d\n", GetLastError()); Please don't add invalid uses of GetLastError again, this was cleaned up recently. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.
by Joris Huizer 04 Feb '11

04 Feb '11

Hello Dmitry Timoshkov, I noticed a small issue in your patch: > > - ret = DestroyWindow(parent); > - ok( ret, "DestroyWindow() error %d\n", > GetLastError()); > + ok(DestroyWindow(parent), "DestroyWindow() > error %d\n", GetLastError()); Please don't merge the call with the ok() statement; the GetLastError() call might be executed before the function to be tested, thus giving the old value. (There has been some cleaning up for this issue recently) The same goes for a few tests you added: > + SetLastError(0xdeadbeef); > + ok(SetForegroundWindow(popup), > "SetForegroundWindow() error %d\n", GetLastError()); > + SetLastError(0xdeadbeef); > +todo_wine > + ok(SetForegroundWindow(popup), > "SetForegroundWindow() error %d\n", GetLastError()); > + > + SetLastError(0xdeadbeef); > + ok(DestroyWindow(parent), "DestroyWindow() > error %d\n", GetLastError()); > + HTH, Joris

2 1

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen 04 Feb '11

04 Feb '11

> > It doesn't need a try-except block, just better wrap-around handling. > Ah, you mean to enhance the if-check? Well..., to me it seems that there is a problem with the 2nd check: "(void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase" If frame is 0xffffffff or close to it (e.g. 0xfffffffc), adding 1 to its address makes it overflow and the left side becomes 0x3, or 0x0 in 0xfffffffc's case. And that would make the check fail. I would propose that this would be corrected with an additional overflow check. There are two 4 byte values that needs to be read: next frame address and return address. So, it would be checked that address of last byte of return address (frame + 7 bytes) is not smaller than current frame address, right? The if-check would then be as follows: if (((void *)frame < NtCurrentTeb()->Tib.StackLimit) || ((void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase) || ((ULONG_PTR)frame & 3) || ((ULONG)((char *)frame + 7) < (ULONG)frame)) ... I'm not quite sure if casting pointers to ULONG for comparison is wise move, but can't think anything else for that. Do you think there is any problems with this approach? Other alternative could be to just simply check if the frame pointer equals to 0xfffffffc, that, combined with "(ULONG_PTR)frame & 3" should handle all cases near 0xffffffff. Best Regards, Janne

2 3

Re: wined3d/arb_program_shader: Small optimization in state_texfactor_arbfp().
by Stefan Dösinger 04 Feb '11

04 Feb '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 03.02.2011 um 23:01 schrieb Adam Martinson: > > Oddly enough this gives us an average 1.8% boost in the 3DMark06 batch size tests. Impressive. One more thing you could investigate(but that doesn't affect this patch): Try to figure out why this code is called in the first place. The only situation when this should happen is if the app is using fixed function fragment processing. I wouldn't expect that 3Dmark06 does that. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNS8aYAAoJEN0/YqbEcdMwI1AQAJder+8LZILzdT+8tA2YiwZ+ ZEVOi4S2voFASHUVJbYuWIXkzzVu6fQlZXw/KCyvdQaslpTWQFFc/cOMXcCVjVs5 puJJDydjCyI8FZF7ec8dCIjCHqBH4S91kxDjRmWGifdp1Qd6h/f7o1xyhOHG62xG XZbY1xx3DhQ7lRxRtsdqqq22MM5cOqR4mCen2YPGsd04rlwsxW6zuxZ32oBof0rO ggzBW1F2WdDHeT6rcDK5Iv7R4zdSCtl6IXfsMaT1frTcd8Mo/9jLj7GaLMnQ/UtG JkyQbCP59AOtEKU8nwrISn71YMRkCBHOttaIAVhr6Nq02eNmcxWomSbIsb293LzP fQHFDPJ2aO161AimO/7Nk6DbGniUtlgRGhPhrK+YJvrAhftrtZ2gFUaN3QLJgcKA HHhkU00NsBXOJvz8YuGFDRVmpPpCLcGM7gvMIyjYy3x3W1FWO4giNxnj6CxqHmLs ohkAbsLEnJohhpTyVEaQKTG0Zq49s5WcvkjQbmncqKdP2D9NHmi50FI8MbJJxXAu mMW6sA6oExn31Fnm1/pQOWCZk8hidK1hRN7f25nSRa58q7bSvNT/Gw3kk6S8T5CU yL3r5UIb64ss4QmtXY8SPIR9IDNvmnYUX4/Av/iKpZrSRHCHzpYX7Eecp2jdV/ta jgKpR4VaDyemyij093oW =LXas -----END PGP SIGNATURE-----

1 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (resend)
by Paul Vriens 04 Feb '11

04 Feb '11

On 02/04/2011 09:32 AM, Austin English wrote: > - ret = funcs->pfnObjectTrust(&data); > + funcs->pfnObjectTrust(&data); > + ok(ret == S_FALSE, "Expected S_FALSE, got %08x\n", ret); This doesn't look correct (you are removing the assignment and then check it). I know that this code path will never be taken, but still. -- Cheers, Paul.

2 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (1/4)
by Juan Lang 04 Feb '11

04 Feb '11

Hey Austin, + ok(ret == S_FALSE, "Expected S_OK, got %08x\n", ret); Copy/pasto. --Juan

2 1

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (3/4)
by Juan Lang 04 Feb '11

04 Feb '11

Hey Austin, ok(ret, "WintrustSetRegPolicyFlags failed: %d\n", GetLastError()); size = sizeof(flags1); r = RegQueryValueExA(key, State, NULL, NULL, (LPBYTE)&flags1, &size); - ok(flags1 == flags3, "Got %08x flags instead of %08x\n", flags1, flags3); + ok(!r || r == ERROR_FILE_NOT_FOUND, "RegQueryValueEx failed: %d\n", r); + if (!r) + ok(flags1 == flags3, "Got %08x flags instead of %08x\n", flags1, flags3); It seems to me that the introduction of ERROR_FILE_NOT_FOUND weakens the test. (Testing r should be done, thanks for fixing that.) I assume that, since WintrustSetRegPolicyFlags should have succeeded, the registry value should now exist. Is there a test failure you're also trying to fix? Thanks, --Juan

2 1

updated LLVM/Clang static analysis results (and valgirind :-))
by Austin English 04 Feb '11

04 Feb '11

Original results: Date: Thu Jan 20 22:59:57 2011 All Bugs 2922 Argument with 'nonnull' attribute passed null 99 Idempotent operation 154 Dead assignment 1464 Dead increment 155 Dead initialization 22 Array subscript is undefined 5 Assigned value is garbage or undefined 96 Branch condition evaluates to a garbage value 10 Called function pointer is null (null dereference) 6 Dereference of null pointer 757 Dereference of undefined pointer value 8 Division by zero 12 Function call argument is an uninitialized value 49 Garbage return value 9 Result of operation is garbage or undefined 74 Undefined allocation of 0 bytes 2 New results: All Bugs 2817 Argument with 'nonnull' attribute passed null 100 Idempotent operation 156 Dead assignment 1368 Dead increment 152 Dead initialization 22 Array subscript is undefined 4 Assigned value is garbage or undefined 96 Branch condition evaluates to a garbage value 9 Called function pointer is null (null dereference) 6 Dereference of null pointer 757 Dereference of undefined pointer value 8 Division by zero 12 Function call argument is an uninitialized value 46 Garbage return value 7 Result of operation is garbage or undefined 72 Undefined allocation of 0 bytes 2 Available at: http://austinenglish.com/logs/clang_analyzer/index.html and valgrind logs: http://austinenglish.com/logs/valgrind/ if you've looked at valgrind logs and see errors that should be suppressed, please email me and I'll add them. Cheers, Austin

1 0

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler (try 2)
by Marvin 04 Feb '11

04 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8839 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler
by Marvin 04 Feb '11

04 Feb '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8838 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg.c:5649: Test failed: WM_SETTEXT on a button: 3: the msg 0x0138 was expected, but got msg 0x8000 instead === W7PROX64 (64 bit msg) === Timeout

1 0

Re: RFC: Adding Mac support to secur32/schannel.c
by James Mckenzie 03 Feb '11

03 Feb '11

Juan Lang <juan.lang(a)gmail.com> wrote: I'll make this quick and address a comment here from Juan from the viewpoint of someone building Wine from scratch using one of the porting services: Fink. > >Besides, I'm still not convinced that GnuTLS on the Mac is such an >onerous problem. This is not just a Codeweavers' problem but a problem that: 1. MacOSX provides native TLS support. 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get around some of the code issues. Both of the known UNIX to MacOSX porting projects provide GnuTLS but have to patch it to build and work on MacOSX without stepping on the existing capabilities. Interfacing the existing TLS capabilities to appear as the GNU product may be a solution to this. I tend to agree with Ken Thomases for MacOSX we should be using the native code vice adding a package that may not provide full TLS functionality and moving towards schannel functionality to the higher levels of code in Wine. Thank you for reading this. James McKenzie

4 5

Re: RFC: Adding Mac support to secur32/schannel.c
by James Mckenzie 03 Feb '11

03 Feb '11

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >On 2/3/11 9:22 AM, James Mckenzie wrote: >> 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get around some of the code issues. Both of the >>known UNIX to MacOSX porting projects provide GnuTLS but have to patch it to build and work on MacOSX without stepping on >>the existing capabilities. >What are you talking about? MacPorts doesn't need patches for GnuTLS anymore. Looking at GnuTLS's Portfile, there are no >patch files pulled in and no reinplace (i.e. sed -ie) operations. It was my understanding that MacPorts did have them. I'll look at Fink tonight and see if there still is a patch file needed with the latest version. In any case, Mac users should be using build in functionality and as few as possible (none if possible) external 'Unix' add-on packages. For a while, they will be needed. >> I tend to agree with Ken Thomases for MacOSX we should be using the native code vice adding a package that may not provide full TLS functionality and moving towards schannel functionality to the higher levels of code in Wine. >I'm for that. In fact, my humble opinion is that Wine on Mac should only use libraries that are part of the OS (i.e. only >dylibs in /usr/lib and frameworks in /System/Library/Frameworks). There are a whole host of benefits, not the least of >which is that it makes binary distribution easier (to date, Mac OS is one of the few platforms that does not have >an official binary distribution) and it could potentially expand our user-base (since users would no longer have to have >MacPorts or Fink or Gentoo Prefix or use a third-party distro just to run Wine). +1 :) It would be a great thing if we did not have to have 'special' builds for MacOSX and we could send out either an installable package or a disk image as the project. James McKenzie > >We've got a long way to go in that department, unfortunately. :( > >Chip > >

1 0

RFC: Adding Mac support to secur32/schannel.c
by Ken Thomases 03 Feb '11

03 Feb '11

Hi, I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship it and its dependencies with Wine for Mac OS X, I think it's better (especially for security-related functionality) to use the system-provided library. I'm attaching a patch. It is _not_ intended as a proposed commit. It's just a proof-of-concept that shows the direction that I'm going. I plan to introduce a new internal interface (the schan_imp_* stuff in my patch) and incrementally refactor the code to hide uses of GnuTLS behind that interface. Then, I'm thinking of breaking the GnuTLS implementation out into a separate module, schannel_gnutls.c. Then, I'd add a second implementation module, schannel_mac.c, based on the Mac Secure Transport API (as shown in the patch). Each of the two modules would be made "empty" by preprocessor conditionals, as appropriate. I'd appreciate a review of this general plan. Thanks, Ken

8 18

Re: user32/tests: Test for behavior of WM_SETTEXT handler
by Alexandre Julliard 03 Feb '11

03 Feb '11

Alexander LAW <exclusion(a)gmail.com> writes: > + { WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine doesn't*/ > + { WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine doesn't*/ > + { WM_APP, sent|wparam|lparam, 0, 0 }, > + { WM_PAINT, sent }, > + { WM_NCPAINT, sent|defwinproc|optional }, /* FIXME: Wine sends it */ You can't add 'optional' to hide Wine bugs; if the message is sent on Windows it should be a todo_wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: gdi32: Upper 24 bits of a character range must be same.
by Greg Geldorp 03 Feb '11

03 Feb '11

Hi, I'm sure you've noticed that this change causes some failures on a Simplified Chinese-language test machine, see http://test.winehq.org/data/5ae2b0f219cb5aed2bdf32746a57a699a32767a2/xp_wtb… Can you take a look at that please? I'm wondering if it wouldn't make more sense to use GetCharABCWidthsW instead of the Ansi version for this test? Thanks, Greg.

2 1

Re: msvcrt: Partially implement type_info::name_internal_method()
by Alexandre Julliard 03 Feb '11

03 Feb '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -260,3 +307,24 @@ int CDECL _atoflt( _CRT_FLOAT *value, char *str ) > { > return _atoflt_l( value, str, NULL ); > } > + > +/********************************************************************* > + * ?_name_internal_method@type_info@@QBEPBDPAU__type_info_node@@@Z (MSVCR90.@) > + */ > +DEFINE_THISCALL_WRAPPER(MSVCRT_type_info_name_internal_method,8) > +const char * __thiscall MSVCRT_type_info_name_internal_method(type_info * _this, struct __type_info_node *node) > +{ > + /* this is a forward to type_info::name() */ > +#ifdef __i386__ > + static const char *typeinfo_name = "?name@type_info@@QBEPBDXZ"; > + void* (WINAPI *p)(void*); > +#else > + static const char typeinfo_name[] = "?name@type_info@@QEBAPEBDXZ"; > + void* (__cdecl *p)(void*); > +#endif > + static int once; > + > + if (node && !once++) FIXME("type_info_node parameter ignored\n"); > + p = (void*)GetProcAddress(GetModuleHandleA("msvcrt.dll"), typeinfo_name); > + return call_func1(p, _this); > +} I think it would be better to duplicate the implementation after all. Sorry for misleading you with the GetProcAddress suggestion, I hadn't realized that it would require the thiscall mess. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.
by Henri Verbeet 03 Feb '11

03 Feb '11

On 3 February 2011 01:00, Tobias Jakobi <liquid.acid(a)gmx.net> wrote: > *bumping* > > This patch never went into master, although it's _very_ important. Wine > users see a lot of D3D problems (mostly missing textures) since mesa drivers > don't support s3tc "out-of-the-box" (libtxc_dxtn needs to be available). > This leads to a lot of 'false' bug reports, which are in fact driver issues. > > Requesting to finally push this to master. > I'm not entirely sure on how to do this properly. Making it an ERR would be too loud for applications that never use s3tc textures, as a WARN it's never going to be seen unless you look at the debug channel. Printing a message in wined3d in CreateSurface() would probably work, but the resulting check would end up being pretty ugly because we'd have to check 5 different formats. You can't do much more than a WARN for a generic check either, because some formats may be legitimately missing / unimplemented. Note that the situation with floating point formats isn't much better.

2 1

Re: wined3d: Update clip planes when switching to/from offscreen rendering.
by Stefan Dösinger 02 Feb '11

02 Feb '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 31.01.2011 um 15:13 schrieb Matteo Bruni: > It should fix http://bugs.winehq.org/show_bug.cgi?id=25877 > <0001-wined3d-Update-clip-planes-when-switching-to-from-offs.txt> If we change the shader code to write gl_ClipVertex and result.clip before applying the y inversion then we should be able to avoid this. That should also make it more compatible to fixed function vertex processing - here the clipping is performed before the projection matrix is applied. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRssNAAoJEN0/YqbEcdMwZv8P+wbbhcamRsg42fMzJ02jKLcT s4p19OqKPZEdVvzsfQCe4e7KGgGdZUefMWsY2ib9AK21cQXB3R9fnyl5TMDcuxuh EojJvAQCVd/hgnz7tserUJT6rS/W08BPsdHM4dgxdnhRTzi2FAc7l3NgFOONJXpG i8HfcmD2AgaGOam6Wriv3SD8fM0zrfmpZdJDH1moCefqptEEWD9adwWRSMhaMvTl rlj1gDR9cRC9fsxur2U1f5NuXN0AY+a+5VPQHElZV2bP9ulheoa9nYuXU+8F7OhK RyIJ2DO4vpaLpEbXW/amtUWnlBSk0n7k3F9w/fcthOmUvlPHOBY7i2Ukf4j84vQD AhpN7Yf4cFZaSV8q/gww+U9H1udelidiTEL05OKQJUohnM1F9/cRnXbXmmA5Nuia rQlcCnm12cw1ClykdrY7B/hDCqGOPnnmPp580kW1LlEtidYyGbG35seyHxNqcNcQ RWlvVsGwvlzgex7qWf9hT34KOcUzMKZdlehfvtQn0Fjrcf+/3s5EvrtG4Mw6qHNh aBFNaeB8LkV36hu71r/1yxsqHO+taYt1/Ho8poANYbOplV9FCpd0nXeK8n7rqCPx L5TVgSJVd4n354FlguuIUAiFlXxcxFN2CJlN2Hd4dwhZZhGBh+4LH+XhjUtzX4ge 15usBq4VUhhssvv6dVys =urcm -----END PGP SIGNATURE-----

3 5

Wine FAQ edits
by Albert Lee 02 Feb '11

02 Feb '11

Hi Vitaliy, I notice you have reverted my edits to the FAQ on the wiki ( http://wiki.winehq.org/FAQ?action=info ). As I was trying to clarify the shell metacharacter information and operating system/platform support, and add new file association instructions, I would like to know why this happened and what changes should be done. -Albert

2 3

re: ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Dan Kegel 02 Feb '11

02 Feb '11

Qian wrote: >1. If a function is implemented in wine dll as a stup, then usually >this function won't cause crash, >and the wine debug will output "fix:me ...stup" rather then >"Unimplemented function", is it right? I think "stub" is somewhat ambiguous, it can mean either something without an implementation, or something with a very minimal implementation. But yes, if something is listed in dlls/*/*.spec as a stub, you get 'Unimplemented function', and if something is listed in grep FIXME.*stub dlls/*/*.c as a stub, you get "fixme: ... stub". >2. If a function is listed in the Wine API guide, >http://source.winehq.org/WineAPI/ , and marked as stup, >then this function must be implemented as a stup in wine source code, >is it right? The Wine API guide is not a very reliable guide, it might be out of date. Better to just look in the source code. - Dan

2 1

Re: crypt32: Fix quoting-behaviour
by Juan Lang 01 Feb '11

01 Feb '11

Hi Christian, I'm afraid this patch is incorrect. In particular, - chars = CertRDNValueToStrA( - rdn->rgRDNAttr[j].dwValueType, - &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, - psz ? csz - ret : 0); + if ((dwStrType & 0x000000ff) == CERT_X500_NAME_STR) + chars = quote_string_a( + rdn->rgRDNAttr[j].dwValueType, + &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, + psz ? csz - ret : 0); + else + chars = CertRDNValueToStrA( + rdn->rgRDNAttr[j].dwValueType, + &rdn->rgRDNAttr[j].Value, psz ? psz + ret : NULL, + psz ? csz - ret : 0); This change (and the corresponding one to CertNameToStrW) is incorrect. I tested a couple of strings with CERT_SIMPLE_NAME_STR, and they are also quoted. I can try to take these over if you like, or you can continue to work on them. Let me know what you prefer. --Juan

1 0

Re: [dlls/shdocvw] Initialize variable (Coverity)
by Nikolay Sivov 01 Feb '11

01 Feb '11

On 2/1/2011 17:14, Paul Vriens wrote: > Hi, > > Addresses Coverity #1090. > > If CoCreateInstance() fails we check the uninitialized urlfile variable. Same story with urlobj. In fact it looks better to try CoCreateInstance first, before anything else like lstrcpy and just return earlier on failure.

2 2

Re: gdiplus: C++ fixes for headers
by Paul Chitescu 01 Feb '11

01 Feb '11

On Tuesday 01 February 2011 09:49:46 am Iain Arnell wrote: > To fix inclusion of gdiplus.h under C++, this patch: > * adds missing class declaration for GpPen > * adds missing class declaration for CharacterRange > * fixes PenAlignment/GpPenAlignment declaration > * avoids redeclaration of PixelFormat > > Simple testcase: > > cat >test.cpp <<EOF > #include <windows.h> > #include <gdiplus.h> > EOF > wineg++ -c test.cpp > --- > include/gdiplusenums.h | 2 +- > include/gdiplusgpstubs.h | 2 ++ > include/gdiplusimaging.h | 4 ++-- > include/gdiplustypes.h | 25 +++++++++++++++++++++++++ > 4 files changed, 30 insertions(+), 3 deletions(-) > > diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h > index 82f20eb..dc03b29 100644 > --- a/include/gdiplusenums.h > +++ b/include/gdiplusenums.h > @@ -734,7 +734,7 @@ typedef enum StringTrimming StringTrimming; > typedef enum FontStyle FontStyle; > typedef enum StringFormatFlags StringFormatFlags; > typedef enum HotkeyPrefix HotkeyPrefix; > -typedef enum PenAlignment GpPenAlignment; > +typedef enum PenAlignment PenAlignment; > typedef enum PaletteFlags PaletteFlags; > typedef enum ImageCodecFlags ImageCodecFlags; > typedef enum CombineMode CombineMode; > diff --git a/include/gdiplusgpstubs.h b/include/gdiplusgpstubs.h > index 3edc1f4..5a65cd8 100644 > --- a/include/gdiplusgpstubs.h > +++ b/include/gdiplusgpstubs.h > @@ -22,6 +22,7 @@ > #ifdef __cplusplus > > class GpGraphics {}; > +class GpPen {}; > class GpBrush {}; > class GpHatch : public GpBrush {}; > class GpSolidFill : public GpBrush {}; > @@ -92,6 +93,7 @@ typedef WrapMode GpWrapMode; > typedef Color GpColor; > typedef FlushIntention GpFlushIntention; > typedef CoordinateSpace GpCoordinateSpace; > +typedef PenAlignment GpPenAlignment; > typedef PenType GpPenType; > > #endif > diff --git a/include/gdiplusimaging.h b/include/gdiplusimaging.h > index 42a00cb..3e9f6ee 100644 > --- a/include/gdiplusimaging.h > +++ b/include/gdiplusimaging.h > @@ -110,7 +110,7 @@ public: > UINT Width; > UINT Height; > INT Stride; > - PixelFormat PixelFormat; > + INT PixelFormat; /* MSDN: "PixelFormat PixelFormat;" */ > VOID* Scan0; > UINT_PTR Reserved; > }; > @@ -177,7 +177,7 @@ typedef struct BitmapData > UINT Width; > UINT Height; > INT Stride; > - PixelFormat PixelFormat; > + INT PixelFormat; /* MSDN: "PixelFormat PixelFormat;" */ > VOID* Scan0; > UINT_PTR Reserved; /* undocumented: stores the lock mode */ > } BitmapData; > diff --git a/include/gdiplustypes.h b/include/gdiplustypes.h > index 4f97432..b84c74e 100644 > --- a/include/gdiplustypes.h > +++ b/include/gdiplustypes.h > @@ -199,6 +199,31 @@ public: > INT Height; > }; > > +class CharacterRange > +{ > +public: > + CharacterRange() > + { > + First = Length = 0; > + } > + > + CharacterRange(IN INT first, IN INT length) > + { > + First = first; > + Length = length; > + } > + > + CharacterRange& operator=(IN const CharacterRange& rhs) > + { > + First = rhs.First; > + Length = rhs.Length; > + return *this; > + } > +public: > + INT First; > + INT Length; > +}; > + > #else /* end of c++ typedefs */ > > typedef struct Point Wouldn't be better to wrap the offending C with: #ifdef __cplusplus extern "C" { #endif ... #ifdef __cplusplus } #endif

2 1

Re: programs: Add winemsibuilder.
by Joris Huizer 01 Feb '11

01 Feb '11

While skimming through the new patches, I found: > +WCHAR *encode_stream( const WCHAR *in ) > +{ > + DWORD c, next, count; > + WCHAR *out, *p; > + > + count = strlenW( in ); > + if (count > MAX_STREAM_NAME) > + return NULL; > + > + count += 2; > + out = HeapAlloc( GetProcessHeap(), 0, count > * sizeof(WCHAR) ); > + p = out; You aren't checking for out-of-memory condition here. As you seem to cover all the other possible errors, I thought to let you know HTH, Joris

1 0

Re: [PATCH 1/5] shell32: Added SHCNRF_InterruptLevel flag support to SHChangeNotifyRegister
by Alexandre Julliard 01 Feb '11

01 Feb '11

Piotr Caban <piotr(a)codeweavers.com> writes: > void InitChangeNotifications(void) > { > + watched_directories = 0; > + interrupts_server_terminate = CreateEventW(NULL, FALSE, FALSE, NULL); > + interrupts_server = CreateThread(NULL, 0, interrupts_server_thread, NULL, 0, NULL); > } This needs to be done on demand. You can't create a thread in every process on the off chance that it would use interrupt notifications. Probably you can use the thread pool for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Test for behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Marvin 31 Jan '11

31 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8777 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Wine Gecko 1.2.0 beta1
by Jacek Caban 31 Jan '11

31 Jan '11

Hi all, We're nearing the time for the next Gecko update. Beta builds are done and available on Sourceforge [1]. To use them, you need to download the .cab file, put it as you usually do into the right directory (most likely wine_gecko-1.2.0-beta1-x86.cab, see [2] for details) and apply the attached patch to recent Wine git version. The plan for release is other than we usually did and we have still some work to do. I hope to do the release short after Firefox 4 release, which is scheduled for the end of February. Firefox is nearing final beta and we will branch together with RC branch for Firefox 4. This should give us more stability in the code base than we usually had. We've never succeeded in avoiding regressions with the new Gecko releases and I hope to improve this situation. This early beta build is one part of the plan. It would be great if you could use it for some time or try some apps with it. I'm most interested in reports about regression, but also general stability and improvements. * Changes - We use Firefox 4 beta11pre codebase - Some regression caused by integration with new parser are fixed (affected among others CS4 installer, STO, EQ2) - IO fixes for custom protocol handlers, mostly affecting .chm files and Outlook If you hit a blank-page bug, some page elements don't work or just a crash, there is a big chance that this build will fix it. Of course it's always nice to test everything regardless if it's currently working or not. * TODO - win64 fix It currently crashes, that's a regression. I've decided to do the beta release anyways, but it's an obvious blocker for further releases. I've put win64 builds on Sourceforge in case anyone is interested in looking at them, but the problem seems to be in the build, not in Wine. - MSI packages This beta still uses .cab files done on Windows. We're planning to do some work on it with Hans and Alexandre so that the final release will use MSI files. - dbghelp fixes winedbg has problems with debug info from Gecko debug build, making debugging possibilities quite limited and backtraces lacking most of the calls. This is not related to Gecko release itself, but still it would be great to have it fixed. - Getting rid of ugly hacks that Firefox uses Esp. API hooks. I don't think it's acceptable for us. - Tests and fixes The more tests, the better. I really hope to get community help here. * For packagers If you're considering building the next Gecko release yourself, it's probably a good idea to try the compilation now. It requires very recent mingw-w64, so a package update (or creating a new package if it's not yet available for the distro) will most likely be needed. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.2.0-beta1/ [2] http://wiki.winehq.org/Gecko

2 2

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen 31 Jan '11

31 Jan '11

Hi Alexandre Julliard, I see you had another idea of how to correct the RtlCaptureStackBackTrace() function. I tested your implementation with Anarchy Online's item store (ingame web browser based on Awesomium) and with AwesomiumGL (sample app from Awesomium's SDK). With AwesomiumGL I did, after a while (scrolling in an image heavy site), got it to crash: wine: Unhandled page fault on read access to 0xfffffffc at address 0x7bc7586b (thread 002e) To file dlls/ntdll/signal_i386.c, line 2438: frame = (ULONG *)*frame; (inside the skipping loop). And, so, if 'frame' is 0xfffffffc, then the added check, unfortunately, will not cut it. With Anarchy Online, I browsed quite a lot within the item store, changing pages, and finally just left the window open for ~20 minutes. No crash so far, so the correction might have worked for the game or then I just didn't wait long enough ;) Should I still add the try-except blocks to RtlCaptureStackBackTrace() and tests for 0xfffffffc value also? Please advice. Best Regards, Janne

2 1

Re: msvcrt: Add type_info::name_internal_method() as alias for ::name()
by Marvin 31 Jan '11

31 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8775 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 00543C08 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 00533C78 === WVISTAADM (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 00D5129D === W2K8SE (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 01961298 === W7PRO (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 009212A5 === W7PROX64 (32 bit msvcr90) === msvcr90: unhandled exception c000001d at 005212A4

1 0

Re: [PATCH 2/4] d3d9/tests: Check ColorFill() return codes in color_fill_test() (LLVM/Clang).
by Marvin 31 Jan '11

31 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8768 Your paranoid android. === WXPPROSP3 (32 bit visual) === No test summary line found

1 0

Re: [PATCH] Clarify 'fixme'...
by Charles Davis 31 Jan '11

31 Jan '11

On 1/31/11 12:01 PM, max(a)mtew.isa-geek.net wrote: > @@ -2519,7 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > - FIXME("entry already in cache - don't know what to do!\n"); > + FIXME("hash matces - collision check needed.\n"); Typo "matces" -> "matches". Chip

1 0

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().
by Alexandre Julliard 31 Jan '11

31 Jan '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > If there is no current clipping region ExtSelectClipRgn(hdc, hrgn, RGN_DIFF) > creates its own default clipping region which in most cases doesn't match > neither a visible region nor the window extents attached to the DC. It will get intersected with the visible region anyway, so it shouldn't matter as long as it's large enough. Why does it make a difference? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()
by Alexandre Julliard 31 Jan '11

31 Jan '11

Peter Schlaile <peter(a)schlaile.de> writes: > Fix: X11DRV_SetDIBits() shouldn't silently change Bitmap protection, so > we now restore the protection bits, that were present before instead of > always changing to READONLY. No, it needs to be read-only so that we can detect further changes. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. No it shouldn't, 0 is correct. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [3/3] d3d9: account for another different behavior in the viewport test
by Stefan Dösinger 31 Jan '11

31 Jan '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I just noticed that I sent the other two mails with my gmail account, so they got stuck in moderation. This patch should apply on its own, but depending on what Alexandre commits today I'll resend the patches after today's commit wave. Am 31.01.2011 um 11:21 schrieb Stefan Dösinger: > The alternative to this patch is to remove the test entirely, as it now accepts all possible outcomes on windows. I prefer to keep it because the behavior it accepts as non-broken(invalid viewport = "default" viewport) is required by some ddraw apps. We also have a test in ddraw, but it isn't quite as straightforward. > > <0011-d3d9-account-for-another-different-behavior-in-the-v.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNRsifAAoJEN0/YqbEcdMwUSAP/2HphIB7RzKXuS/q52t5mCvt b9yFQ/9ci11GWlzWG7okm72Z+hUdC4bIMPxIalWM7/VKPzsSB7Qg2EvwpMTGq0r5 lAX3WFFqWqCNoAZd7JnQO6LqX0TR4wJOCxIjAYSw+WlZW7tYNVFEsw3mPTUxqggR 88wVQ8C5oBAW3Rns6QGYmxyw+R6Xryh3pdukxBP2DS6jQDkqodq9L6JU24YHHy0z OFEZCIAl8VqhTfgTeO5pqJ7e4ujGyT0U25h8rmIuhMt8DFRdxTSE4agib4haFrLb jLEUAVqjSrV4EX1A+iisryBYCCOGpGT9vYKB5Xw169fzkjd2XMQ9C3udE/VznGWo grcWX9CJxm1XzR/AYuNh+pNSq+wZPxwrlJrOmcW4EC1o1X/OdXr+KtZFX2ldkGwF v6LCel4WPN5G4+mKryNnPMRDPo69ccZr2iKTdMQFs7nm0NZGxPNnj3o7eGDP92pq DNUboQ3EoZ3ow9c8vpfeGgxk647jgJwpeOzUKj7ON3l5XyFvoEAAv2pFwRp/lpn8 3ioLYDePd7VBcf6cT9ckI0Qptx2hM8yRyd1r+qC4jGv8ydQnHmAu+w61cmSrpl3X EYpvHmFYEdkJjDKcn2Z1gYekg4RisXcd/CVBWfZHLudpibEab+3NQp7wb+HwNscu 2P/hz0RIdqEC7BBQf6bJ =Vxnq -----END PGP SIGNATURE-----

1 0

Re: [PATCH] [patch] Already in cache means nothing more to do...
by Alexandre Julliard 31 Jan '11

31 Jan '11

max(a)mtew.isa-geek.net writes: > @@ -2519,11 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > - FIXME("entry already in cache - don't know what to do!\n"); > -/* > - * SetLastError(ERROR_FILE_NOT_FOUND); > - * return FALSE; > - */ > + error = ERROR_SUCCESS; The entry is not necessarily the same even if the hash matches. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen 31 Jan '11

31 Jan '11

Hi again, I've been working to implement the tests for RtlCaptureStackBackTrace(), but I have encountered a problem. The function, according to MSDN should be available only in Windows XP and newer OSes. Now, when I ran these tests on Testbot using all base VMs, the tests were run also on W2KPROSP4 and WNT4WSSP6. However, the function seems to buggy in those. It throws access violation whenever it is not skipping frames. Here's the test patch I used: http://testbot.winehq.org/GetFile.pl?JobKey=8606&StepKey=1 In both cases, test on patch's line 83 failed and call on line 92 crashed the test. In other VMs the tests succeeded and none crashed. Is there some way I could prevent/skip these tests to be run on Windows NT4 and 2000? Best Regards, Janne Hakonen

3 5

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()
by Vitaliy Margolen 31 Jan '11

31 Jan '11

On 01/30/2011 04:16 AM, Peter Schlaile wrote: > Hi, > > find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. This should be a separate patch. Vitaliy.

2 2

RFC: Final Proposed Riched20 EM_SETMARGINS Test
by James McKenzie 31 Jan '11

31 Jan '11

All: Constructive Criticism requested so that this can be made better. I've decided to use two loops in the test: One for fonts. Second for actual tests. This allows for quick and easy expansion. The check code for font changes might be removed, but does no harm by remaining. This patch is based on git as of Friday, January 28. I could find no font that changed the Margin from zero for the EC_USEFONTINFO lparam test case. If someone knows of a font that will do so, please advise as well so I can include it. Thank you. James McKenzie

1 0

Re: [PATCH 2/2] mshtml: Added support for recursive script runners
by Marvin 30 Jan '11

30 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8753 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Policy regarding 3rd party "windows" distributions and winetest
by Dan Kegel 30 Jan '11

30 Jan '11

I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed?

5 6

MapleStory Wine Bug
by Jack Edmonds 30 Jan '11

30 Jan '11

I recently submitted a bug (http://bugs.winehq.org/show_bug.cgi?id=25934). I'm not sure if I did a good job on the submission, but if I did, I was thinking it would be a good first bug to work on so as to introduce me to the Wine source code. I was wondering if someone could help me get started on it.

2 1

Re: user32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Marvin 30 Jan '11

30 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8728 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x0111 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x0111 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0138 was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg sequence is not complete: expected 8000 - actual 0000 msg.c:5644: Test failed: SETTEXT on a button: 2: the msg 0x0135 was expected, but got msg 0x002b instead msg.c:5644: Test failed: SETTEXT on a button: 3: the msg 0x002b was expected, but got msg 0x8000 instead msg.c:5644: Test failed: SETTEXT on a button: 4: the msg sequence is not complete: expected 8000 - actual 0000 === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH 1/2] winecoreaudio: Don't use Component Manager on Mac OS 10.6.
by Charles Davis 30 Jan '11

30 Jan '11

On 1/29/11 6:40 PM, James McKenzie wrote: > Chip: > > I'm assuming that this has been checked on Tiger/Leopard and it works. I checked that it would work if the AudioComponent header weren't present (which it isn't pre-SL). > > I don't have a Leopard system here and I'm reluctant to try it on one of > the systems I have Tiger installed on (it is a PowerPC Mac.) I can't imagine why... :) Chip

1 0

RE: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Greg Geldorp 29 Jan '11

29 Jan '11

From: Greg Geldorp <ggeldorp(a)vmware.com> > From: Erich Hoover > > On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > > > ... > > > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, > > > the shdocvw:webbrowser test doesn't have a history of occasional > > > crashes. There are a few failures, but none of them are due to access > > > violations. Which kind of indicates that the crash is because of the > > > changes you made. > > > I know it sucks to investigate failures that don't repro consistently, > > > but I do think some more testing would be good here. Of course, if > > > there's any info you need about the VM just let me know. > > > > Well, I commandeered a XP SP3 box this morning and ran that exact same > > set of tests successfully 10,000 times. I don't have access to a Win7 > > box or I would have run the tests on that. Thoughts? > > I'll do a similar test on Win7 tomorrow and let you know the results. I started by running your test binary 10,000 times on W7PROX64. Not a single crash, so that looked kind of promising. Just to be sure, I then ran the binary on a dual-core Win7 x64 machine (the W7PROX64 VM has only one core assigned to it). This resulted in an immediate crash. Tried a few more times, it crashed 9 out of 10 times. To make sure that these crashes are related to your patch, I ran the test without your patch on the same dual-core machine. First few tries didn't produce crashes, I then ran it in a loop 10,000 times. Not a single crash. So, it looks like your patch introduces some multi-threading issue. I haven't investigated further, perhaps I'll have some time over the weekend to dig a bit deeper. Greg.

2 3

Re: winex11.drv: When copying window bits exclude an update region only if the parent doesn't clip its children.
by Alexandre Julliard 29 Jan '11

29 Jan '11

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1624,7 +1624,8 @@ static void move_window_bits( struct x11drv_win_data *data, const RECT *old_rect > hdc_src = hdc_dst = GetDCEx( data->hwnd, 0, DCX_CACHE ); > } > > - ExcludeUpdateRgn( hdc_dst, data->hwnd ); > + if (!parent || !(GetWindowLongW( parent, GWL_STYLE ) & WS_CLIPCHILDREN)) > + ExcludeUpdateRgn( hdc_dst, data->hwnd ); I don't see what the parent clipping has to do with this. Could you please explain? -- Alexandre Julliard julliard(a)winehq.org

2 1

Ubuntu 10.04 x86-64 test failures -- dsound:ds3d and mmdevapi
by Reece Dunn 28 Jan '11

28 Jan '11

=== Observations === 1/ The dsound:ds3d tests fail when using the ALSA audio driver on 64-bit (K)Ubuntu, but succeed with the OSS audio driver. 2/ The mmdevapi tests fail with a "Device not found"/"No driver" error (hr = 0x88780078) when running with the OSS driver. For the mmdevapi failures, the tests should skip when intercepting a "Device not found" error. === Steps to Reproduce === Machine: Ubuntu 10.04 64-bit with NVidia binary drivers. 1/ Build the latest version of wine with no special options -- `./configure && make` 2/ Remove any previously run test result -- `find . -type f | grep .ok | xargs rm` 3/ Ensure running in a clean wine prefix -- `rm -rf ~/.wine` 4/ Run the tests -- `make test` This will download the gecko package and then fail in the dsound:ds3d tests with: ds3d.c:467: Test failed: buffer size changed after SetFormat() - previous size was 88200, current size is 22052 This error seems to be specific to 64-bit versions of the Ubuntu family, looking at the http://test.winehq.org/data/ results. 5/ Open winecfg -- `./wine winecfg` 6/ Select the Audio tab This should being up a message to recommend a driver (as no driver is set in the registry) and then select the ALSA driver. 7/ Switch the audio driver from ALSA to OSS and press OK. 8/ Re-run the tests -- `make test` This passes the ds3d tests, but fails with: ../../../tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -p mmdevapi_test.exe.so dependency.c && touch dependency.ok err:quartz:DSoundRender_create Cannot create Direct Sound object (88780078) fixme:ole:CoCreateInstance no instance created for interface {56a86895-0ad4-11ce-b03a-0020af0ba770} of class {79376820-07d0-11cf-a24d-0020afd79767}, hres is 0x88780078 dependency.c:85: Test failed: Activating bf failed: 0x88780078 9/ Open winecfg -- `./wine winecfg` 10/ Switch the audio driver from OSS back to ALSA and press OK. 11/ Re-run the tests -- `make test` The mmdevapi tests now pass. - Reece

3 4

Re: Alexander Scott-Johns : ole32: Add support for rendering METAFILEPICT clipboard objects.
by Nikolay Sivov 28 Jan '11

28 Jan '11

On 1/28/2011 21:30, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 0f4fbd30f6bf3d2ef471d3d75307c7fa8a7df137 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=0f4fbd30f6bf3d2ef471d3d75… > > Author: Alexander Scott-Johns<alexander.scott.johns(a)googlemail.com> > Date: Tue Jan 25 15:09:21 2011 +0000 > > ole32: Add support for rendering METAFILEPICT clipboard objects. > > --- > dlls/ole32/clipboard.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 96 insertions(+), 1 deletions(-) > > +/*************************************************************************** > + * get_data_from_metafilepict > + */ > +static HRESULT get_data_from_metafilepict(IDataObject *data, FORMATETC *fmt, HGLOBAL *mem) > +{ > + HGLOBAL copy; > + HRESULT hr; > + FORMATETC mem_fmt; > + STGMEDIUM med; > + > + *mem = NULL; > + > + mem_fmt = *fmt; > + mem_fmt.tymed = TYMED_MFPICT; > + > + hr = IDataObject_GetData(data,&mem_fmt,&med); > + if(FAILED(hr)) return hr; > + > + hr = dup_metafilepict(med.u.hMetaFilePict,&copy); > + if(FAILED(hr)) return hr; 'med' should be released here on failure. > + > + *mem = copy; > + > + ReleaseStgMedium(&med); > + > + return hr; > +} > + > /***********************************************************************

1 0

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry
by Eric Pouech 28 Jan '11

28 Jan '11

Le 19/01/2011 13:07, Alexandre Julliard a écrit : > Eric Pouech<eric.pouech(a)orange.fr> writes: > >> you mean hardwiring the missing keys (potentially different according to >> terminal type) in the code? > If they depend on terminal type they belong in terminfo, not in the > registry. > as I said, terminfo is not fully populated it misses lots of ctrl-<key> (left arrow, right arrow...) and has not been updated lately most of the common text editors come with their own config files for example, /etc/inputrc has the missing bindings for libreadline (and of course it depends on $TERM) so, updating terminfo isn't the solution would you consider inclusion in hklm (instead of hkcu) ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 2/2] msvcrt: Use the _set_error_mode value to switch between a dialogbox and stderr for C runtime messages
by Alexandre Julliard 28 Jan '11

28 Jan '11

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -134,8 +135,9 @@ static void DoMessageBox(LPCSTR lead, LPCSTR message) > void CDECL _amsg_exit(int errnum) > { > TRACE("(%d)\n", errnum); > - /* FIXME: text for the error number. */ > - if (MSVCRT_app_type == 2) > + > + if ((MSVCRT_error_mode == MSVCRT__OUT_TO_MSGBOX) || > + ((MSVCRT_error_mode == MSVCRT__OUT_TO_DEFAULT) && (MSVCRT_app_type != 1))) If you want to change the app type check that should be a separate patch, with its own justification. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: User32: Replicate Windows behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*
by Vitaliy Margolen 28 Jan '11

28 Jan '11

On 01/27/2011 11:51 PM, Alexander LAW wrote: > > > + if (style & WS_VISIBLE) { > + HDC hdc = GetDC(hWnd); > + HBRUSH hbrush; > + RECT client, rc; > + HWND parent = GetParent(hWnd); Please follow the style of the file - curly brace goes on a separate line. Please if you can't set your editor to have tab character equal 8 spaces - don't use tabs! Use space characters only. > + if (!parent) parent = hWnd; > + UINT ctlMessage=((btn_type==BS_PUSHBUTTON || > btn_type==BS_DEFPUSHBUTTON || btn_type==BS_PUSHLIKE)?WM_CTLCOLORBTN: > WM_CTLCOLORSTATIC); This is not c++ inline declarations are not allowed. Please cut this line down it's too long. Also please add corresponding test to msg.c tests to validate the change. Vitaliy.

1 0

Re: winex11.drv: Implement synthesizing the CF_ENHMETAFILE clipboard format from CF_METAFILEPICT.
by Vitaliy Margolen 28 Jan '11

28 Jan '11

On 01/27/2011 07:42 PM, Alexander Scott-Johns wrote: > > > > > + FIXME("Called to synthesize unknown format 0x%08x\n", wFormatID); Formats defined as decimal, so you should print it as decimal. > + if ((lpSource = X11DRV_CLIPBOARD_LookupData(CF_ENHMETAFILE)) && lpSource->hData) > + { > + bret = TRUE; > + } Just do "return TRUE". It will remove one level of indentation. > + void *mf_bits = HeapAlloc(GetProcessHeap(), 0, size_mf_bits); > + GetMetaFileBitsEx(pmfp->hMF, size_mf_bits, mf_bits); Please check if allocation succeeded. Vitaliy.

1 0

Re: [PATCH 1/2] msvcrt: Add private define and header tests for _set_error_mode options
by Marvin 28 Jan '11

28 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8692 Your paranoid android. === WNT4WSSP6 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2KPROSP4 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WXPPROSP3 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K3R2SESP2 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === WVISTAADM (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W2K8SE (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PRO (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (32 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2 === W7PROX64 (64 bit headers) === headers.c:343: Test failed: Defines (MSVCRT_)_OUT_TO_MSGBOX are different: 2 vs. 1 headers.c:344: Test failed: Defines (MSVCRT_)_OUT_TO_STDERR are different: 1 vs. 2

1 0

Re: [1/2] shell32: Implement IShellDispatch::NameSpace
by Marvin 28 Jan '11

28 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8684 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH] winecoreaudio: Fix deprecation warnings.
by Alexandre Julliard 28 Jan '11

28 Jan '11

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -198,10 +222,19 @@ int AudioUnit_CreateInputUnit(void* wwi, AudioUnit* out_au, > UInt32* outFrameCount) > { > OSStatus err = noErr; > +#ifdef HAVE_AUDIOUNIT_AUDIOCOMPONENT_H > + /* Apple has threatened to rip out the Component Manager. > + * Protect ourselves from that. > + */ > + AudioComponentDescription description; > + AudioComponent component; > +#else > ComponentDescription description; > Component component; > +#endif It would be better to have a set of compatibility defines at the top instead of spreading #ifdefs all through the code. And please split independent changes into separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Where can I get OpenCL for Fedora 14.
by Max TenEyck Woodbury 28 Jan '11

28 Jan '11

For the first time in several years, I did a fresh install on this machine and I am in the process of getting all the tweaks back in place. Part of that process is assuring that wine's configure script has all the pieces it can use. I have found almost everything. What I am missing is OpenCL (that is C as in Charles). I see stuff for Apple, but not for Fedora.i386 (cpu is intel.core2 and an Nvidia card). Search results are inconclusive - I checked the first five pages and found nothing specifically about .rpm files. Where can I get an .rpm or tarball that contains a usable OpenCL implementation for Fedora 14? Max

6 8

Wine Source Study
by Pankaj Swami 28 Jan '11

28 Jan '11

Please help me..... I am last year Computer Engineering student & I want to study wine source code but I'm unable to decide from where to start studying wine source code.........? I have wine source code.

1 0

Another milestone
by Greg Geldorp 28 Jan '11

28 Jan '11

Today we had a clean winetest.exe run on all 31 TestBot VMs for the first time. Although there are still failures on other test machines and some tests fail occasionally on TestBot, I still think this is a significant milestone. Hopefully the "Wine" column on http://test.winehq.org/data/ will soon start to show some yellow spots too! Greg.

2 1

Re: msvcrt: Forward _realloc_crt to realloc
by Marvin 27 Jan '11

27 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8669 Your paranoid android. === WVISTAADM (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77497580 === W2K8SE (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 778A814C === W7PRO (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 772D2B79 === W7PROX64 (32 bit msvcr90) === msvcr90: unhandled exception c0000005 at 77E03100 === W7PROX64 (64 bit msvcr90) === No test summary line found

1 0

Re: [4/4] gdi32: Move common code into helper function.
by Nikolay Sivov 27 Jan '11

27 Jan '11

On 1/27/2011 12:23, Kusanagi Kouichi wrote: > On 2011-01-26 19:28:29 +0300, Nikolay Sivov wrote: >> On 1/26/2011 19:09, Kusanagi Kouichi wrote: >>> -static LPSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pByteLen) >>> +static LPWSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT pLen) >>> { >> It's better to change naming too, since it's won't return char >> string anymore. > What name do you think is better? > Is FONT_GetCharsByRange or FONT_GetCharsByRangeAToW OK? I think FONT_GetCharsByRangeW would be fine. Note that I don't know this code, and probably it should be done another way to avoid conversion in a first place (if possible at all).

1 0

Re: shdocvw: Implement IWebBrowser::ExecWB and IWebBrowser::QueryStatusWB.
by Erich Hoover 27 Jan '11

27 Jan '11

On Thu, Jan 27, 2011 at 3:53 AM, Greg Geldorp <ggeldorp(a)vmware.com> wrote: > ... > Looking at http://test.winehq.org/data/tests/shdocvw:webbrowser.html, the > shdocvw:webbrowser test doesn't have a history of occasional crashes. > There are a few failures, but none of them are due to access violations. > Which kind of indicates that the crash is because of the changes you > made. > I know it sucks to investigate failures that don't repro consistently, > but I do think some more testing would be good here. Of course, if there's > any info you need about the VM just let me know. Well, I commandeered a XP SP3 box this morning and ran that exact same set of tests successfully 10,000 times. I don't have access to a Win7 box or I would have run the tests on that. Thoughts? Erich Hoover ehoover(a)mines.edu

2 1

Re: [ActiveX] Wine builtin IE crash while login to https://www.alipay.com/
by Jacek Caban 27 Jan '11

27 Jan '11

Hi Qian, On 1/26/11 9:06 AM, Qian Hong wrote: > However, sence Wine buitin IE began to support ActiveX, I have also > tested alipay.com with wine buitin IE, just for reporting. Support for ActiveX in Wine IE is a fairly new feature and it still quite limited. Honestly I've tested it mostly with Flash ActiveX version (which was my main interest in implementing it). I don't expect much more to work, but I'd be interested in results of real-world tests with other controls/requirements. Please file a bug about it (in mshtml component) and CC me. Jacek

1 0

Re: [ActiveX]crash while open https://mybank.icbc.com.cn/icbc/perbank/index.jsp use wine buitin IE
by Saulius Krasuckas 27 Jan '11

27 Jan '11

* On Thu, 27 Jan 2011, Juan Lang wrote: > > > By the way, will wine builtin IE support vbscript in the future? ICBC > > online bank required vbscript. > > That's a pretty open-ended question. I haven't seen anyone volunteer > to work on this in some time, so I'd say the odds are not so good. ABBYY FormFiller software (used to fill data for electronic tax declaration system at the state level in our country) also requires vbscript.dll to parse data validation rules. There is workaround, though. You just run "winetricks wsh56vb". S.

3 2

Re: shell32/tests: Remove shlwapi dependency
by Marvin 26 Jan '11

26 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8618 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: winex11.drv: initialize drawable (clang)
by Henri Verbeet 25 Jan '11

25 Jan '11

2011/1/25 André Hentschel <nerv(a)dawncrow.de>: > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > then the if condition is reliable I don't think that can happen unless hwnd is NULL and top is non-NULL, which looks like invalid input to me.

2 1

Re: kernel32: Removing - key from keybindings.
by Trygve Vea 25 Jan '11

25 Jan '11

On Tue, Jan 25, 2011 at 8:35 PM, Trygve Vea <trygve.vea(a)gmail.com> wrote: > Fixes bug 25856, introduced in 2a219b948c451213fb4554352b86f3784a8f7e32. > It seems that Eric Pouech already posted an identical patch, which has been applied. This is then unnecessary. I apologize for the noise. -- Trygve Vea

1 0

wine-patches
by Vincent Hardy 25 Jan '11

25 Jan '11

Hi, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Am I blacklisted ? Vincent

2 1

Re: po: Update the Dutch translation
by Alexandre Julliard 25 Jan '11

25 Jan '11

Sven Baars <sven.wine(a)gmail.com> writes: > Hey, > > All those po editors piss me off. First, the changes I make don't get > saved, then they do get saved but magically disappear when I try to > send them. Now I used poedit, which is apparently the only one that > works, and this one makes whole bunch of changes by itself. > > If this unacceptable, could someone please tell me how to work with > this stuff? Or would it be better to just use a normal editor? Maybe > emacs? And how could I recover the actual changes I made (and not the > ones poedit made) if this patch is not acceptable? You should run it through msgmerge before sending. Something like msgmerge nl.po wine.pot > nl.po.new -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)
by Loïc Maury 25 Jan '11

25 Jan '11

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + /* At this point, we know that we have media, because in Mac OS X, the + * device file is only created when media is present. */ + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

4 5

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)
by Loïc Maury 25 Jan '11

25 Jan '11

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

1 0

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s
by Eric Pouech 25 Jan '11

25 Jan '11

the spec should read wstr instead of ptr A+ 2011/1/25 <wine-bugs(a)winehq.org> > http://bugs.winehq.org/show_bug.cgi?id=25402 > > Andrew Millington <andrew.millington(a)gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Keywords| |patch > > --- Comment #5 from Andrew Millington <andrew.millington(a)gmail.com> > 2011-01-25 01:23:06 CST --- > After applying http://source.winehq.org/patches/data/70240 it complains > about > unimplemented function d3dx9_36.dll.D3DXFloat32To16Array and that is bug > #25769. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are watching all bug changes. > > > -- -- Eric Pouech

1 0

Re: [PATCH 2/4] wined3d: Add support for the NULL format.
by Stefan Dösinger 25 Jan '11

25 Jan '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > - if (surface) > + if (surface && surface->resource.format->id != WINED3DFMT_NULL) Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNPqNaAAoJEN0/YqbEcdMwWFwP/0KW7THyiplBKi6csC7b6qWi i7Bi3VG5UMRomIDUyWMTlH+mwLqP7+AchzVYEHAM/blhe5yqemDc2YAN2f2/aNtV cbWoaIilTNF3PKH11wVvtUowidrwHmr9eV+SmHplvhdpJCTGKqU0ZxmNgl2DDiSD iPVfCmL6RE1e5n9i11AH7aQIcZjwPTEQBQlLR5IB1zpcnXab0r7vyTU44f0HkcJ0 785ast6QuG7lawibe7PmRz41VcFCtSMZF3QGgEujAn+frtYhqjVLdP8LITWZ+1mL jPfCWEQX1vlgbdMogykfnKSfm5oxaDMsrU3vMskwUGWFZCX+M7ffHIfy7cpy8HUt YVz4kqeaLr1xeZEsEaAQqjNal1PXoJCJSVA6ckV7VhB0+OkXpcH4i8ifdCtRv1PJ 0V/vryBBQgM9AczBQI8lb1c7w7lQL9EzttpNwbbC3mBTsT3/7EHJRuxR8EStIgzC 8gyTXveyBGuJel8Bwx6M+tBSskCNKFzPN7MKkvIE2+X5NSYj5eI05GSQRMl/eush jZWe+ls9GYgl76bL8+By1RRTsXGizPdW8UnX6HhzMfBErU1Z7IZbbqEiTMgXFOJL 0v0UXfLecE/mHlgrauk7b0C51JMtTXq5uuSOQ8uxFz/t2KcElja6pY4/nkN3DoLe I/cZaSyeQ3B5lTVTeZt/ =UA0G -----END PGP SIGNATURE-----

2 1

Static analysis scan
by Amine Khaldi 24 Jan '11

24 Jan '11

Hello folks, I've set up a static analysis scan using clang static analyzer. The results are available at http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin for the web space. Please feel free to fix the defects. I'll run future scans when the defects get fixed progressively. Have fun ;) With best regards, Amine.

2 1

Re: oleaut32/typelib2: Use implementation pointer to trace ICreateTypeInfo2
by Michael Stefaniuc 24 Jan '11

24 Jan '11

Hello Nikolay, On 01/24/2011 01:01 AM, Nikolay Sivov wrote: > Use implementation pointer to trace ICreateTypeInfo2 > diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c > index 8260ef2..5c843a1 100644 > --- a/dlls/oleaut32/typelib2.c > +++ b/dlls/oleaut32/typelib2.c > @@ -2322,6 +2321,7 @@ static HRESULT WINAPI ICreateTypeInfo2_fnAddVarDesc( > > /* increment the number of variable elements */ > This->typeinfo->cElement += 0x10000; > +ERR("count=%d\n", This->typeinfo->cElement); this looks like some leftover debug line. > > return status; > } bye michael

2 1

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.
by Jacek Caban 24 Jan '11

24 Jan '11

On 1/18/11 7:31 PM, Erich Hoover wrote: > On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban <jacek(a)codeweavers.com <mailto:jacek@codeweavers.com>> wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is implementing client's IOleCommandTarget. It's something different from document's one. > I understand that, but apparently the native implementation (testing on the test bot WXPPROSP3) sends the command to the client > IOleCommandTarget instead of the document IOleCommandTarget (at least under the conditions of the webbrowser tests). That is what I mean by hijacking, the command is going to the "wrong" target. My guess would be that there is some sort of priority mechanism, though I have no idea how it would work (except maybe "if there's a client/container then send to that target, else send to the document target). That sounds reasonable. > I've attached a test where I disabled the client/container, and you > can see that it then gets passed through (QueryStatusWB will return success instead of passing through the client target and returning failure): > https://testbot.winehq.org/JobDetails.pl?Key=8408 Hmm, it means that another run of tests (at least required subset of existing test_WebBrowser) with client's IOleCommandTarget disabled would be interesting. Do you feel like writing it? Otherwise we'd need at least a FIXME in this case. Jacek

2 5

Re: gdi32: Prevent character code from wrapping around.
by Alexandre Julliard 24 Jan '11

24 Jan '11

Kusanagi Kouichi <slash(a)ac.auone-net.jp> writes: > If lastChar is 0xffffffff, FONT_GetCharsByRangeA falls into > infinite loop and crash. You probably want more sanity checks (with tests), characters above 0xffff wouldn't make sense anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] To: wine-patches@winehq.org
by Alexandre Julliard 24 Jan '11

24 Jan '11

Eric Pouech <eric.pouech(a)orange.fr> writes: > [Kernel32]: in bare console with curses, ensure control stream is sent to tty (even when some fd:s are redirected) There doesn't seem to be much point in initializing input if we can't see the output. On the contrary, I think we should err on the side of not initializing anything unless really necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Questioning the depth_clamp_test in d3d8:visual
by Joerg-Cyril.Hoehle＠t-systems.com 24 Jan '11

24 Jan '11

Hi, Trying to understand bugs #10636 and #19773 , I glanced at the d3d8 visual.ok directx test results. It appears that the green colour on test.winehq does not mean much. - All (any exception?) WTB machines skip the tests because d3d8 is not installed. - Same for Francois Gouget's virtual machines. That alone explains green colour. - Wylda's *real* machine #1 (NVidia gfx) produces 5 errors: visual.c:1411: Test failed: color 0x00ffffff. visual.c:1413: Test failed: color 0x00ffffff. visual.c:1415: Test failed: color 0x00ffffff. - "geniuh"'s (NVidia) machine as well. - Saulius' (NVidia) XP and w7 machines shows only these 3 errors. - Wylda's Intel-based machine #2 passes the tests. Hurray! - One unknown win7 machine with Intel gfx also passes them. - Aurimas' machine produces one different error (also Intel gfx). BTW, Wylda recently mentioned that the d3d tests produce vastly different graphics on his 2 machines. My conclusion: the tests only prove that Wine wants to mimic Intel graphics, but they do not account for the variety of observed test results. Danger: one may draw false conclusions from the ok() and wrongly generalize supposed behaviour of the tested functions. Looking at Wine test data (from 1.3.12), it appears that Wine implements exactly the opposite behaviour: the NVidia (+ 1 ATI) machines pass the tests, e.g. behave like Intel on native, while the Intel gfx one (eeepc) produces the 3 errors known from native NVidia! This smells wrong... Regards, Jörg Höhle

3 2

Re: server: fix connect failures on newer kernels
by Marcus Meissner 24 Jan '11

24 Jan '11

On Mon, Jan 24, 2011 at 12:21:15AM -0500, Mike Kaplinskiy wrote: > For some reason the newer kernels report POLLOUT|POLLERR|POLLHUP when > connect() fails. Strip the POLLOUT in this case. This (hopefully) > fixes bug 25456. > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 1b81544..3c6425e 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -3965,7 +3965,7 @@ static void test_ConnectEx(void) > closesocket(listener); > listener = INVALID_SOCKET; > > - address.sin_port = 1; > + address.sin_port = htons(1); > > bret = pConnectEx(connector, (struct sockaddr*)&address, addrlen, NULL, 0, &bytesReturned, &overlapped); > ok(bret == FALSE && GetLastError(), "ConnectEx to bad destination failed: " > diff --git a/server/sock.c b/server/sock.c > index d37a316..134efb0 100644 > --- a/server/sock.c > +++ b/server/sock.c > @@ -388,6 +388,9 @@ static void sock_poll_event( struct fd *fd, int event ) > > if (sock->state & FD_CONNECT) > { > + if (event & POLLOUT && event & (POLLERR|POLLHUP)) > + event &= ~POLLOUT; Add more braces to make the operator precedence a bit more clear... (just a style issue though) Ciao, Marcus

2 1

new winetricks 20110123: work around bug in wine-1.3.12. new winetricks-alpha 20110123: ditto, plus new verbs cnc3_demo, guildwars, hphbp_demo, nfsshift_demo, sims3, spotify, vc2005trial
by Dan Kegel 24 Jan '11

24 Jan '11

Another week, another winetricks. This release is mainly to add a workaround for http://bugs.winehq.org/show_bug.cgi?id=25838 in wine-1.3.12, which broke winetricks. winetricks-alpha version 20110123 adds the following new verbs: cnc3_demo: Command and Conquer 3 demo guildwars: Guild Wars hphbp_demo: Harry Potter Half Blood Prince demo nfsshift_demo: Need For Speed: Shift demo sims3: The Sims 3 spotify: the popular music service vc2005trial: Visual C++ 2005 Trial winetricks version 20110123 adds no new verbs. Both scripts can be downloaded from winetricks.org at the obvious urls: http://winetricks.org/winetricks http://winetricks.org/winetricks-alpha (The old download url at kegel.com/wine/winetricks still works, too.) Bug tracker and svn repository are at http://winetricks.googlecode.com ----------------------------------- Changelog for winetricks-alpha: Dan Kegel: Work around wine bug 25838 :-( Ported verbs hphbp_demo, sims3 from wisotool Fix mingw PATH (again) Add example to help for 'list' command w_download{,_manual}: get rid of need to specify package name. w_download_manual: open destination folder in desktop for user python26_comtypes: metadata should be "year", not "date". Shortened title for psdkwin7 to fit window. Shannon Vanwagner: New verb spotify Phil Blankenship: Ported verbs cnc3_demo, guildwars, nfsshift_demo, vc2005trial from wisotool. ----------------------------------- Changelog for winetricks: Dan Kegel: Work around wine bug 25838 :-( Austin English: update opensymbol url/sha1sum ----------------------------------- Enjoy!

1 0

wine-1.3.12 broke winetricks :-(
by Dan Kegel 24 Jan '11

24 Jan '11

Looks like wine-1.3.12 went out without the fix for http://bugs.winehq.org/show_bug.cgi?id=25838 I've checked a workaround into winetricks, and will do a release, but I bet a few users will be confused...

1 0

3Dmark2001se & heap corruption
by wylda＠volny.cz 23 Jan '11

23 Jan '11

Hi, as there is a strong Valgrind wave these days ;) and i failed to find the problem myself here is a little exercise for anyone interested: 1. WINEDEBUG=warn+heap wine 3DMark2001SE.exe 2. Under selected test -> (click) Clear -> (tab) Custom -> (check) "Game2 Dragothic Low Detail" -> OK 3. (click) Benchmark At the end, console is flooded by many: Heap 0x110000: block 0x2c41070 tail overwritten at 0x2c410a1 (byte 0/15 == 0x00) Heap 0x110000: block 0x1c46b08 tail overwritten at 0x1c46b39 (byte 0/39 == 0x00) W.

4 6

re: Correction to crash inside RtlCaptureStackBackTrace() + test case
by Dan Kegel 23 Jan '11

23 Jan '11

Hi Janne, I haven't reviewed your code, but I can suggest sending each patch as a separate message to wine-patches, and using titles more like ntdll: test corrupt stack frame in RtlCaptureStackBackTrace() ntdll: handle corrupt stack frame in RtlCaptureStackBackTrace() and mention clearly that this fixes the online store in Anarchy Online (if it does). Also, please send the test patch by itself through winebot before posting and verify that it passes on all flavors of windows. See http://wiki.winehq.org/SubmittingPatches Thanks!

2 1

Re: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)
by Marvin 23 Jan '11

23 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === WNT4WSSP6 (32 bit device) === device.c:168: Test failed: DirectInputCreate() failed: 80040154

3 5

Winetricks game verbs - good or bad? (was: Re: New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, ...)
by Dan Kegel 23 Jan '11

23 Jan '11

On Mon, Jan 17, 2011 at 7:33 PM, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > On 01/17/2011 11:30 AM, Dan Kegel wrote: >> New version 20110117-alpha adds the following new verbs: >> >> firefox4 - beta9 of Firefox's new web browser >> ut3 - the first-person shooter Unreal Tournament 3 (requires dvd) > > Isn't that exactly why we marked all other scripts like this a "third party > unsupported tools"? I suspect PlayOnLinux got the cold shoulder because they use old versions of wine, they use their own patches, they don't have a 'real' version control system for game scripts, and they didn't communicate with the wine community. So problem reports from PlayOnLinux users weren't very helpful for Wine developers. Winetricks doesn't encourage users to run old or patched wine, and I'm not a stranger on wine-devel. In fact, if we play our cards right, winetricks might actually reduce the number of clueless support requests. People have trouble following the HOWTOs in the appdb. A winetricks verb for a game should be like a perfectly automated little implementation of the HOWTO, with bug workarounds clearly marked, and skipped automatically when using new enough wine. Better still, since it's automated, we can run it nightly to make sure it doesn't break. What concrete problems do you see with winetricks having verbs for popular games? - Dan

2 3

FYI: GCC-4.6 rebuild tests
by Susan Cragin 23 Jan '11

23 Jan '11

GCC-4.6 has more build failures than mine. Here's the info. They don't test wine, apparently. It's not on the list. Maybe I can add it, or get it added. -----Forwarded Message----- >From: Matthias Klose <doko(a)ubuntu.com> >Sent: Jan 19, 2011 10:28 AM >To: ubuntu-devel <ubuntu-devel-announce(a)lists.ubuntu.com>, ubuntu-devel <ubuntu-devel(a)lists.ubuntu.com> >Subject: GCC-4.6 rebuild tests > >[ Note that GCC-4.6 will not be used for natty / 11.04, but > we consider using this version for the O-series / 11.10 ] > >A test rebuild of natty/main using the current GCC version from the trunk was >finished last week. While only one internal compiler error was found, some more >build failures were seen due to new warnings and more strict frontends. A list >of build failure can be seen at > >http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-201101… > >If a package appears in the `superseded' section, it doesn't mean that the build >failure with GCC-4.6 is fixed. > >Some comments and hints for fixes can be found at > > https://wiki.ubuntu.com/GCC4.6 > >Please extend the wiki page if appropriate. > >To work on the build failures, please use either the gcc-snapshot package from >natty or the gcc-4.6 package from the ubuntu-toolchain-r/test PPA. > >A large number of build failures is seen for packages building with -Werror. The >compiler packages above were changed to add a -Wno-error=unused-but-set-variable >when -Werror is found. Despite this local change the these packages need to >build without this local change. > > Matthias > >PS: Fixing build failures with GCC-4.5 in natty should still have priority ;) > >-- >ubuntu-devel-announce mailing list >ubuntu-devel-announce(a)lists.ubuntu.com >https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-announce

2 1

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case
by André Hentschel 23 Jan '11

23 Jan '11

Am 23.01.2011 18:20, schrieb Janne Hakonen: > Hi, > > This is my first attempt to post patches to Wine and it would be great if you could review these. > > First patch (0001-2-2-ntdll-Added-try-except-blocks-to-RtlCaptureStackBa.txt) is a correction to a crash situation where application crashes if RtlCaptureStackBackTrace() is called and one of the frame pointers of call stack is invalid, pointing usually to 0xffffffff, sometimes to other invalid locations. > The correction wraps the offending code inside __try â�� __except blocks so that a resulting access violation is caught before it can crash the calling application. > > Second patch (0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test case for the correction. > It changes one of the frame pointers to invalid value and then calls RtlCaptureStackBackTrace(). The test fails on Wineâ��s HEAD (without the first patch), but passes successfully on Windows 7. Havenâ��t tested this on other OSes. I created a new signal.c file for the test case under ntdll/tests since I couldnâ��t find more fitting place. > > This crash can be reproduced with Anarchy Online game when trying to open an in-game browser. Also reproducible with AwesomiumGL sample application from Awesomiumâ��s SDK. The crash (among other problems) is reported to bugzilla at: http://bugs.winehq.org/show_bug.cgi?id=25206. > > Best Regards, > Janne Hakonen Hi and welcome to wine development! First i see is that your mail application wrapped the patch ( that is when long likes brake down into the next line ). Then you have a whitespace issue in the makefile i think... further you should consider using IsBadReadPtr instead of try...except, but i'm not sure if that would work. If you solved the issues, you can send the patch to wine-patches(a)winehq.org and can track the status at source.winehq.org/patches -- Best Regards, André Hentschel

2 1

Correction to crash inside RtlCaptureStackBackTrace() + test case
by Janne Hakonen 23 Jan '11

23 Jan '11

Hi, This is my first attempt to post patches to Wine and it would be great if you could review these. First patch (0001-2-2-ntdll-Added-try-except-blocks-to-RtlCaptureStackBa.txt) is a correction to a crash situation where application crashes if RtlCaptureStackBackTrace() is called and one of the frame pointers of call stack is invalid, pointing usually to 0xffffffff, sometimes to other invalid locations. The correction wraps the offending code inside __try – __except blocks so that a resulting access violation is caught before it can crash the calling application. Second patch (0002-1-2-ntdll-tests-Added-a-test-for-RtlCaptureStackBackTr.txt) is a test case for the correction. It changes one of the frame pointers to invalid value and then calls RtlCaptureStackBackTrace(). The test fails on Wine’s HEAD (without the first patch), but passes successfully on Windows 7. Haven’t tested this on other OSes. I created a new signal.c file for the test case under ntdll/tests since I couldn’t find more fitting place. This crash can be reproduced with Anarchy Online game when trying to open an in-game browser. Also reproducible with AwesomiumGL sample application from Awesomium’s SDK. The crash (among other problems) is reported to bugzilla at: http://bugs.winehq.org/show_bug.cgi?id=25206. Best Regards, Janne Hakonen

1 0

Re: gdi32/tests: Skip font metrics test on non-English systems
by Dmitry Timoshkov 23 Jan '11

23 Jan '11

"Greg Geldorp" <ggeldorp(a)vmware.com> wrote: > --- > dlls/gdi32/tests/font.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) That test is supposed to pass at least on russian locale. On which locale does the test fail for you? -- Dmitry.

2 4

Re: Wine: Downgrade lack of libxslt from configure warning to notice.
by Marcus Meissner 23 Jan '11

23 Jan '11

On Wed, Jan 19, 2011 at 11:37:17PM +0100, Gerald Pfeifer wrote: > On Sat, 28 Jun 2008, Gerald Pfeifer wrote: > > [ Still running into this, and compared to the others where we only > > use WINE_NOTICE_WITH, like CUPS or HAL this really seems very low > > importance. ] > > > > On a test system of mine which does not feature too many packages I am > > getting the following: > > > > configure: libsane development files not found, scanners won't be supported. > > configure: libgphoto2 development files not found, digital cameras won't be supported. > > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > > configure: libcapi20 development files not found, ISDN won't be supported. > > configure: WARNING: libxslt development files not found, xslt won't be supported. > > > > Looking that libxslt only seems to be used by msxml3, I am wondering > > whether this really is worth a warning? > > > > How about the patch below? > > So I found this older patch of mine in a TODO folder and am wondering > whether it can be considered. It not, that's fine too and I'll remove > it over here; an explicit NACK would be nice in that case. As libxslt missing reduces the msxml3 functionality it is definitely worth a warning. Ciao, Marcus

1 0

USB architecture: driver loading question
by Damjan Jovanovic 23 Jan '11

23 Jan '11

Hi There's essentially 2 ways USB could work in Wine[1]: 1. Process per driver, but special-case loading and initializing USBD.SYS Like my previous patchset: http://www.winehq.org/pipermail/wine-patches/2010-November/095883.html http://www.winehq.org/pipermail/wine-patches/2010-November/095884.html 2. Dedicated process for USB, in which USBD.SYS loads first, and it loads USB device drivers (possibly > 1) into the same process as the need arises. What's the right way? Which approach is going to get my patches accepted? Thank you Damjan [1] Because the steps are as follows: 1. USB device is plugged in 2. USB hub driver looks up the driver based on the device class/vendor/product IDs 3. The device driver gets loaded and DriverEntry() gets called on it 4. AddDevice() gets called on the driver, specifying the device 5. Only then, the driver calls things lower in the stack, to do USB I/O The driver needn't load any other driver in its DLL import table, and even if it did, drivers loaded through the import table don't have their DriverEntry() called, so they cannot do anything on load. Even if we rely on most USB drivers loading USBD.SYS, USBD.SYS needs to do steps 1-4 first, but it wouldn't have control passed to it until step 5, hence it can't ever do anything. The only way out is one of the following: 1. Process-per-driver, but when a driver loads USBD.SYS, USBD.SYS is special-cased by winedevice, ie. it has a special export called on it at load which specifies the other driver and gives it a chance to create a separate thread for steps 1-4. 2. Dedicated process for USB, in which USBD.SYS loads first, and it loads USB device drivers (possibly > 1) into the same process as the need arises.

1 0

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 2)
by Loïc Maury 23 Jan '11

23 Jan '11

Hello, I have add comment in the code for the patch. Thank you Loïc --- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..d65850d 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +/* At this point, we know that we have media, because in Mac OS X, the + * device file is only created when media is present. */ +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

2 1

winscard
by vince 22 Jan '11

22 Jan '11

Hi all, I'm back with a smaller and reworked winscard patch. In respond to Vitaly Margolen (http://www.winehq.org/pipermail/wine-devel/2010-September/087017.html) 1. I used configure to get the so name of the library. 2. I removed trailing spaces. 3. When this patch is approved, I will make a new patch for SCardListReadersA. Is this patch ready for wine-patch ? Thanks for your help. Vincent.

2 1

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions
by Matteo Bruni 22 Jan '11

22 Jan '11

2011/1/20 Travis Athougies <iammisc(a)gmail.com>: > +static void test_setting_basic_table(IDirect3DDevice9 *device) > +{ > + static const D3DXMATRIX mvp = { > + 0.514f, 0.626f, 0.804f, 0.786f, > + 0.238f, 0.956f, 0.374f, 0.483f, > + 0.109f, 0.586f, 0.900f, 0.255f, > + 0.898f, 0.411f, 0.932f, 0.275f}; This throws some warnings here. Apparently you have to put some additional braces around that initializer. + ok(out[0] == (float)iarray[0] && out[4] == (float)iarray[1] && out[8] == (float)iarray[2] && + out[12] == (float)iarray[3], "SetIntArray did not properly set a float array: out={%f, %f, %f, %f}, should" + " be {%d, %d, %d, %d}\n", out[0], out[4], out[8], out[12], iarray[0], iarray[1], iarray[2], iarray[3]); The float casts are unneeded. The tests look generally OK to me otherwise, albeit they are somewhat wordy. Oh, please notice that some tests fail on Windows. The testbot can't create a d3d device so it skips these tests, but on my Win7 box I get this: shader.c:462: Test failed: The first row of mvp was not set correctly, got {0.51 4000, 0.238000, 0.109000, 0.898000}, should be {0.514000, 0.626000, 0.804000, 0. 786000} shader.c:465: Test failed: The second row of mvp was not set correctly, got {0.6 26000, 0.956000, 0.586000, 0.411000}, should be {0.238000, 0.956000, 0.374000, 0 .483000} shader.c:468: Test failed: The third row of mvp was not set correctly, got {0.80 4000, 0.374000, 0.900000, 0.932000}, should be {0.109000, 0.586000, 0.900000, 0. 255000} shader.c:471: Test failed: The fourth row of mvp was not set correctly, got {0.7 86000, 0.483000, 0.255000, 0.275000}, should be {0.898000, 0.411000, 0.932000, 0 .275000} shader.c:530: Test failed: The excess elements of the array were not set correct ly, out={0.000000, 0.000000, 0.000000, 0.000000}, should be {0.010000, 0.020000, 0.030000, 0.040000} shader: 248 tests executed (0 marked as todo, 5 failures), 0 skipped. The matrix seems to have its rows and columns switched (probably this has to do with row-major vs column-major matrix storage - http://msdn.microsoft.com/en-us/library/bb509706%28v=VS.85%29.aspx). So you have to fix your SetMatrixArray implementation to account for that (and update the tests accordingly). The other failing test shows that actually the excess elements are not set, apparently. A last thing. I noticed that you never set the vertex shader in the d3d9 device. I'd say: don't change that. This shows that ID3DXConstantTable doesn't pay attention to the vertex shader currently set and it is responsibility of the application programmer to call these functions with the correct shader program.

3 3

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.
by Damjan Jovanovic 22 Jan '11

22 Jan '11

Should we reconsider libicns? Apple's APIs obviously can't be relied upon. On Fri, Jan 21, 2011 at 2:58 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > > For http://bugs.winehq.org/show_bug.cgi?id=25778 > --- > dlls/windowscodecs/icnsformat.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > >

4 4

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray
by Matteo Bruni 21 Jan '11

21 Jan '11

2011/1/20 Travis Athougies <iammisc(a)gmail.com>: > + /* D3DXMATRIX is a union, one of whose elements is an array, so it can be cast to a float pointer */ > + if (is_vertex_shader(This->desc.Version)) > + IDirect3DDevice9_SetVertexShaderConstantF(device, desc.RegisterIndex + i, (float *)(matrix + i), > + desc.RegisterCount); > + else > + IDirect3DDevice9_SetPixelShaderConstantF(device, desc.RegisterIndex + i, (float *)(matrix + i), > + desc.RegisterCount); Can't you just pass matrix->m[i] as parameter, instead of that cast?

3 6

Translating a same message used in different contexts
by Akihiro Sagawa 21 Jan '11

21 Jan '11

Hi, I'm one of Japanese translators of Wine. A few weeks ago, Wine's string resources were moved to one po format file. So I started translation about it. And now I face to a problem which is a same msgid text used in different contexts, like "Desktop" used in shell32.rc. One of its contexts is a real path name of a desktop (IDS_DESKTOPDIRECTORY). That is "C:\Users\foo\Desktop"'s Desktop. In other contexts, it makes a localized name (IDS_DESKTOP). That is shown in a common dialog box. In the previous Japanese resource, the former was "Desktop" and the latter was localized. However, in the po file, they merged into one! Therefore we need to distinguish above contexts somehow. But I'm afraid I don't familiar with gettext and wrc. Could someone please resolve this issue? Akihiro Sagawa

3 5

RE: shell32/tests: Add tests for IShellDispatch::NameSpace.
by Greg Geldorp 21 Jan '11

21 Jan '11

> === W7PROX64 (32 bit shelldispatch) === > shelldispatch.c:80: Test failed: bad title I suppose the title here was "Program Files (x86)", it would be good to print the title that you got (using wine_dbgstr_w()). This test will probably fail when running as 32-bit executable on any Windows 64-bit version. I also expect it to fail on some non-English Windows versions (e.g. I think German uses "Programme" instead of "Program Files"). Greg.

1 0

Re: shell32/tests: Add tests for IShellDispatch::NameSpace.
by Marvin 21 Jan '11

21 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8506 Your paranoid android. === W7PROX64 (32 bit shelldispatch) === shelldispatch.c:80: Test failed: bad title

1 0

winepath breakage?
by Dan Kegel 20 Jan '11

20 Jan '11

Hi Eric, thanks again for your tireless efforts in debugging and console stuff! Stefan alerted me to the following winetricks breakage: http://bugs.winehq.org/show_bug.cgi?id=25838 Could you have a look and decide who needs to give here - winepath, kernel32, or the poor user scripts? Hopefully not the latter. Thanks, Dan

1 0

Implementing basic_string::substr in msvcp90
by Daniel Mierswa 20 Jan '11

20 Jan '11

Hey list, I was wondering how to implement substr in msvcp90/string.c. I followed the already existing code when implementing some operators and other things my application needed but I'm not sure how to construct a new string (rather allocate) and return it as it's the case with substr. Any ideas on this? Thanks in advance. -- Mierswa, Daniel If you still don't like it, that's ok: that's why I'm boss. I simply know better than you do. --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

1 0

Hebrew PO and some issues
by Yaron Shahrabani 20 Jan '11

20 Jan '11

I copied all the strings that shouldn't be translated, if anyone has a better suggestion be my guest. I don't want all the apps that shouldn't be translated listed in the PO. Also I need seperate translations for the same term, Ready should be translated differently among files. There are also strings that are similar between apps I should translate and apps I should so I'm a little confused about it, can I create seperate entries manually? The problem is that if I edit manually these entries will be deleted in the next update... Translating the apps in the old style was way better for me, how can I get back to that? Kind regards, Yaron Shahrabani <Hebrew translator>

1 0

Re: comctl32/tests: Fix failures for 120DPI display
by Nikolay Sivov 20 Jan '11

20 Jan '11

On 1/20/2011 13:40, Greg Geldorp wrote: > --- > dlls/comctl32/tests/listview.c | 5 +++-- > dlls/comctl32/tests/rebar.c | 2 +- > dlls/comctl32/tests/treeview.c | 4 ++++ > 3 files changed, 8 insertions(+), 3 deletions(-) > @@ -4163,7 +4163,8 @@ static void test_getcolumnwidth(void) > SendMessage(hwnd, LVM_INSERTITEMA, 0, (LPARAM)&itema); > ret = SendMessage(hwnd, LVM_GETCOLUMNWIDTH, 0, 0); > hdc = GetDC(hwnd); > - todo_wine expect(GetDeviceCaps(hdc, LOGPIXELSX), ret); > +trace("ggeldorp %d %d\n", GetDeviceCaps(hdc, LOGPIXELSX), ret); > + todo_wine expect(((GetDeviceCaps(hdc, LOGPIXELSX) + 15) / 16) * 16, ret); > ReleaseDC(hwnd, hdc); > DestroyWindow(hwnd); > } Minor thing, you forgot to remove a trace.

1 0

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov 19 Jan '11

19 Jan '11

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

re: today's git does not compile
by Susan Cragin 19 Jan '11

19 Jan '11

>Try switching from -O2 to -O1 with > configure CFLAGS="-g -O1" >and rebuild. Does that help? Yes. That works. >Regardless of whether that gets you past the problem, >please file a bug in launchpad against gcc-4.5. >Ideally they'd want you to run with -save-temps and give >them a copy of pen.i. https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/704633 Here's the bug. I http://www.network-theory.co.uk/docs/gccintro/gccintro_36.html Dan, I can't work the -save-temps option. All three give me "no input files." /wine-git$ gcc -save-temps /wine-git$ gcc -save-temps=cwd (or =obj) gcc: no input files

3 3

setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)
by Qian Hong 19 Jan '11

19 Jan '11

Dear All, while testing a USB production tool with unofficial USB patches + native oleaut32.dll, I got a crashing and such logs: wine: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status, aborting wine: Unimplemented function setupapi.dll.CM_Get_DevNode_Status called at address 0x7b839292 (thread 002f), starting debugger... Unhandled exception: unimplemented function setupapi.dll.CM_Get_DevNode_Status called in 32-bit code (0x7b839292). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7b839292 ESP:003158b8 EBP:0031591c EFLAGS:00000246( - -- I Z- -P- ) EAX:7b82540d EBX:7b887ff4 ECX:00000000 EDX:80000100 ESI:80000100 EDI:00000001 Stack dump: 0x003158b8: 0031593c 00000008 00020108 80000100 0x003158c8: 00000001 00000000 7b839292 00000002 0x003158d8: 7ebc3d60 7ebc42a9 00003218 00003218 0x003158e8: 00000001 00000000 989c7900 00000000 0x003158f8: 00000004 7eba6cfb 7ebd2ff4 00000000 0x00315908: 00000000 0031595c 7b83924a 00000111 Backtrace: =>0 0x7b839292 RaiseException+0x52(code=0x80000100, flags=0x1, nbargs=0x2, args=0x31593c) [/home/fracting/wine-git/dlls/kernel32/except.c:84] in kernel32 (0x0031594c) ... Should I post a new bug? Best wishes! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

4 4

re: today's git does not compile
by Susan Cragin 19 Jan '11

19 Jan '11

https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/704633 Bug successfully updated and confirmed by a member of Ubuntu's testing team, so we're off to the races.

1 0

kernel32: Correctly parse the input strings for advanced keys.
by James Eder 19 Jan '11

19 Jan '11

On systems without the appropriate curses development files, compilation is broken here: gcc -m32 -c -I/home/james/build/wine/wine-git/dlls/kernel32 -I. -I/home/james/build/wine/wine-git/include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_NORMALIZE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o term.o /home/james/build/wine/wine-git/dlls/kernel32/term.c /home/james/build/wine/wine-git/dlls/kernel32/term.c:368:10: error: conflicting types for ‘TERM_FillInputRecord’ /home/james/build/wine/wine-git/dlls/kernel32/console_private.h:40:17: note: previous declaration of ‘TERM_FillInputRecord’ was here make[1]: *** [term.o] Error 1 make[1]: Leaving directory `/home/james/build/wine/wine-32/dlls/kernel32' make: *** [dlls/kernel32] Error 2 Jim

1 0

Fail to use USB-Key/USB-Shield with wine USB patch :cannot start service 'SCardSvr':win error code:0x00000424
by Qian Hong 19 Jan '11

19 Jan '11

Dear All, Thanks to the USB patch ( http://goo.gl/qc7ry ) , I have a chance to try weather there is some way to use my usbkey on my Linux. After applying the patch and setting follow the wiki , I still fail to use my usbkey.As I know, the USB patch just work for a few devices, I wonther if my usbkey works too. If possible , I'd like to help to test everything about the wine USB patch to make the usbkey works, also I need your help. Thank you very much :) First of all, let's see something about the usbkey. My usbkey is also called G&D USB-Shield, it is required by ICBC persional internet banking while online trading. Unfortunately, ICBC website is IE-only, ActiveX and VBscript are required. Here is the login entry: http://goo.gl/gWW7Q and the G&D USB-Shield driver for Windows, safesign_icbc_per.exe : http://goo.gl/LM588 ( from http://goo.gl/Ft4Ub) Infact, we don't have to login ICBC for testing the usbkey,because there is a tool called Token Administration Utility, it allow us manager the usbkey with a client program. After install the USB-Shield driver, we can see tokenadmin.exe in "Program Files/ICBCEbankTools/G&D/Management Utility", and that is the Token Administration Utility. Here is the screenshot of tokenadmin.exe on Windows XP: http://goo.gl/raKOm (Sorry for the Chinese in the screenshot, I don't know how to display English in a Chinese version Windows, if anyone know please tell me, I will upload a new screenshot , thanks :) Here is more infomation about the G&B usbkey: lsusb -v http://goo.gl/iOBW7 However, while installing G&B usbkey driver on wine, something is wrong like below: cannot start service 'SCardSvr':win error code:0x00000424 Now, here is the whole process: My enviroment: Ubuntu 10.10 x86_64; wine1.3.11 from git; Applying latest usb patch followed Wine USB wiki; configure & make & install success, no error; Step 1: winetricks-alpha -q mfc42 winetricks-alpha -q crypt32 ( mfc42 and native crypt32.dll are required to install safesign_icbc_per.exe ) Step 2: wine 'safesign_icbc_per.exe' The full log is here : http://goo.gl/fpu3j After this step, we can see the *.sys files: ~/.wine/drive_c/windows/system32/drivers$ ls Chip_smc.sys eps2kt1.sys mountmgr.sys usbic2k.sys Chip_usb.sys ic2kenum.sys usbhub.sys Step 3: Follow the wiki, copy the regist key-value from Windows XP to WIne: Here are all the reg files I imported: http://goo.gl/ZHXfo Step 4: wine tokenadmin.exe It will open a window without useful information,unlike that in Windows XP , here is the screenshot: http://goo.gl/YPYtz And here is the log: wine tokenadmin.exe fixme:winscard:SCardReleaseStartedEvent stub fixme:winscard:SCardEstablishContext (2,(nil),(nil),0x32f2f4) stub fixme:winscard:SCardEstablishContext (2,(nil),(nil),0x659130) stub I have tryed to remove ~/.wine and copy the scardsvr.exe from Windows to wine system32 folder,then do all the thing again, but it seems not work, there is no difference. Would you tell me what shall i do next ? Thanks! Best Wishes! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

5 16

Re: [PATCH 3/3] dinput: Combine ASCII and Unicode device create callbacks. Add tests.
by Marvin 19 Jan '11

19 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8419 Your paranoid android. === WNT4WSSP6 (32 bit device) === device.c:164: Test failed: DirectInputCreate() failed: 80040154

2 1

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry
by Alexandre Julliard 19 Jan '11

19 Jan '11

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -690,6 +690,9 @@ HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-99 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"IsInstalled",2,1 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Locale",2,"*" > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Version",2,"4,74,9273,0" > +; Some missing key mapping in libterm > +HKCU,Software\Wine\Term,"^[[1;5C",3,01,01,4d,27,08,00 > +HKCU,Software\Wine\Term,"^[[1;5D",3,01,01,4b,25,08,00 There shouldn't be any need to create Wine-specific keys from wine.inf, especially not under HKCU. The code should be using appropriate defaults if the key is missing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineGCC]: correctly manage the -V option (gcc expects to be among the first ones, with -b)
by Alexandre Julliard 19 Jan '11

19 Jan '11

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -969,7 +972,7 @@ static void build(struct options* opts) > if (fake_module) return; /* nothing else to do */ > > /* link everything together now */ > - strarray_addall(link_args, get_translator(opts)); > + strarray_addall(link_args, get_translator(opts, NULL)); Why do you want to use a different version when linking? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32/tmarshal: Remove S_OK value assumptions, fix potential stream leak
by Alexandre Julliard 19 Jan '11

19 Jan '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Remove S_OK value assumptions, fix potential stream leak Returning an error value and 0 on success is a common pattern, using a magic constant for 0 is not an improvement. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [10/10] shell32: Fix initial reference count for a new IAutoComplete instance.
by Nikolay Sivov 19 Jan '11

19 Jan '11

On 1/15/2011 11:28, Andrew Nguyen wrote: > Spotted with Valgrind. > --- > dlls/shell32/autocomplete.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(- This doesn't look right. If initial count is zero this failure code will decrement to -1: --- if (FAILED (IUnknown_QueryInterface (_IUnknown_ (lpac), riid, ppv))) { IUnknown_Release (_IUnknown_ (lpac)); return E_NOINTERFACE; } --- I think it's better to add another _Release().

1 0

New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, dxdiagn, pngfilt; new svn repo, download url
by Dan Kegel 19 Jan '11

19 Jan '11

Another fortnight, another winetricks. New version 20110117-alpha adds the following new verbs: firefox4 - beta9 of Firefox's new web browser ut3 - the first-person shooter Unreal Tournament 3 (requires dvd) hegemonygold_demo - the strategy game Hegemony Gold, dxdiag - Microsoft's native dxdiag app plus many less noticable improvements. It should be ready to replace classic winetricks now... let me know if you find it lacking. Also, to celebrate the new version (and foil domain squatters), I've given it an easier to remember download url: http://winetricks.org/winetricks-alpha and svn repository / bug tracker: http://winetricks.googlecode.com (The old download url at kegel.com/wine/winetricks-alpha will still work, they're symlinked.) Changelog: Dan Kegel: Added new verbs dxdiag, dxdiagn, firefox4, pngfilt vc2005express: switched to offline installer to make regression testing easier ie6: make png images work (thanks to Qian Hong for the bug report) Allow changing -q from main menu Experimentally mention WINEPREFIX in window title to help avoid user confusion Don't make zenity bigger than the screen, if we can help it. Leave less cruft in wineprefix (in particular, autohotkey) Sped up script a bit more in cygwin Phil Blankenship: Ported most of the remaining verbs from classic winetricks Shannon Vanwagner: Added new verb hegemenygold_demo Scott Jackson: Added new verb ut3

4 3

Re: [PATCH] sdfmlsdkf
by Austin English 18 Jan '11

18 Jan '11

On Tue, Jan 18, 2011 at 12:39 PM, Eric Pouech <eric.pouech(a)orange.fr> wrote: I think you messed up the patch subject ;-). -- -Austin

1 0

Re: today's git does not compile
by Susan Cragin 18 Jan '11

18 Jan '11

> It's not wine's fault, and you're not missing any dependencies; the >> new version of gcc is probably buggy, and the bug is triggered by >> something inside wine. > >If you've compiled Wine before and are re-using object files from an >old gcc it's possible that there is a conflict between the object >files from before and the object files with your new version of gcc. >So, you could try a "make clean" and then compile again. > >Erich Hoover >ehoover(a)mines.edu I tried "make distclean" and also tried a new wine-git download... so far nothing. On with the flags test.

1 0

re: today's git does not compile
by Dan Kegel 18 Jan '11

18 Jan '11

Susan wrote: > I have the latest version of Natty Narwhal > gcc (Ubuntu/Linaro 4.5.2-1ubuntu6) 4.5.2 >... >gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o pen.o pen.c >pen.c: In function ‘X11DRV_SelectPen’: >pen.c:31:12: internal compiler error: Segmentation fault >Please submit a full bug report, >with preprocessed source if appropriate. >See <file:///usr/share/doc/gcc-4.5/README.Bugs> for instructions. It's not wine's fault, and you're not missing any dependencies; the new version of gcc is probably buggy, and the bug is triggered by something inside wine. Try switching from -O2 to -O1 with configure CFLAGS="-g -O1" and rebuild. Does that help? Regardless of whether that gets you past the problem, please file a bug in launchpad against gcc-4.5. https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/693686 and https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/690194 are similar bugs you could use as examples. Ideally they'd want you to run with -save-temps and give them a copy of pen.i.

2 2

today's git does not compile
by Susan Cragin 18 Jan '11

18 Jan '11

Could there be a new dependency that isn't summoned by build-dep? Or is it me? I have the latest version of Natty Narwhal gcc (Ubuntu/Linaro 4.5.2-1ubuntu6) 4.5.2 gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o pen.o pen.c pen.c: In function ‘X11DRV_SelectPen’: pen.c:31:12: internal compiler error: Segmentation fault Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.5/README.Bugs> for instructions. make[1]: *** [pen.o] Error 1 make[1]: Leaving directory `/home/susan/wine/dlls/winex11.drv' make: *** [dlls/winex11.drv] Error 2 susan@ubuntu:~/wine$ cd

2 1

Re: Working implementation of the ping
by Devaev Maxim 18 Jan '11

18 Jan '11

On Thu, 02 Dec 2010 22:09:39 +0300, Devaev Maxim <mdevaev(a)etersoft.ru> wrote: > The implementation uses a library icmp.dll. Non-root user in Linux > can not work with icmp, special permission is required capabilities. > I > made it so that in case of error simulates the ping delay. Why this patch is not accepted in upstream?

1 0

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.
by Jacek Caban 18 Jan '11

18 Jan '11

Hi Erich, On 1/15/11 12:14 AM, Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Adds support for the IWebBrowser(2)_ExecWB function by passing the > requested operations through to IOleCommandTarget_Exec. With this > patch (and patch 1) the print button in hhctrl.ocx operates properly. > ChangeLog: > shdocvw: Implement IWebBrowser_ExecWB. + IOleCommandTarget* target; + HRESULT hres; + + TRACE("(%p)->(%d %d %s %p)\n", This, cmdID, cmdexecopt, debugstr_variant(pvaIn), pvaOut); + + hres = IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&target); document may be NULL here. + if(FAILED(hres)) + return hres; + hres = IOleCommandTarget_Exec(target, NULL, cmdID, cmdexecopt, pvaIn, pvaOut); + IOleCommandTarget_Release(target); Please write a test case for this. MSDN seems wrong in this case. It indicates in one place that we should use CGID_MSHTML as group GUID, and NULL in the other. The test should make it clean, which version is true. Jacek

2 3

Re: [2/2] msi/tests: More tests for publishing and unpublishing assemblies.
by Alexandre Julliard 18 Jan '11

18 Jan '11

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > dlls/msi/tests/action.c | 84 +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 82 insertions(+), 2 deletions(-) This breaks subsequent tests: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:4251: Test failed: File not installed install.c:4280: Test failed: File not installed install.c:4283: Test failed: File not installed install.c:4286: Test failed: File not installed install.c:4292: Test failed: File not installed install.c:4624: Tests skipped: Run in interactive mode to run source path tests. install.c:4774: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 wine: Unhandled page fault on read access to 0x00000000 at address 0x68875090 (thread 0040), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68875090). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68875090 ESP:0032e7f0 EBP:0032f098 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:688d1710 ECX:00110064 EDX:00000000 ESI:001752c0 EDI:001752e4 Stack dump: 0x0032e7f0: 0012da08 688c1840 0000000c 0032ee54 0x0032e800: 00000134 000000c8 00000002 00000032 0x0032e810: 00000000 000000c8 00000002 00174c30 0x0032e820: 00000006 00000000 00000001 00174c42 0x0032e830: 00000004 00174ae0 0000000c 00174c38 0x0032e840: 0000000b 688c1840 001749a0 00172cc0 Backtrace: =>0 0x68875090 ready_media+0x300(package=0x1742b8, file=0x1736c8, mi=0x1752c0) [/home/julliard/wine/wine/dlls/msi/../../include/winbase.h:2280] in msi (0x0032f118) 1 0x68866333 ACTION_InstallFiles+0x212(package=0x1742b8) [/home/julliard/wine/wine/dlls/msi/files.c:245] in msi (0x0032f168) 2 0x6883005f ACTION_HandleStandardAction+0xae(package=<is not available>, action="InstallFiles", rc=0x32f19c) [/home/julliard/wine/wine/dlls/msi/action.c:7315] in msi (0x0032f1b8) 3 0x68831e8f ACTION_PerformAction+0x3e(package=0x1742b8, action="InstallFiles", script=0xffffffff) [/home/julliard/wine/wine/dlls/msi/action.c:7338] in msi (0x0032f208) 4 0x68833e8f ITERATE_Actions+0x1de(row=0x16f070, param=0x1742b8) [/home/julliard/wine/wine/dlls/msi/action.c:1009] in msi (0x0032f268) 5 0x688853a0 MSI_IterateRecords+0x6f(view=0x130790, count=0x0(nil), func=0x68833cb0, param=0x1742b8) [/home/julliard/wine/wine/dlls/msi/msiquery.c:193] in msi (0x0032f2b8) 6 0x6882f1d3 ACTION_ProcessExecSequence+0x102(package=0x1742b8, UIran=<is not available>) [/home/julliard/wine/wine/dlls/msi/action.c:1094] in msi (0x0032f328) 7 0x6883e2e7 MSI_InstallPackage+0x476(package=0x1742b8, szPackagePath="msitest.msi", szCommandLine="INSTALLLEVEL=10 PROPVAR=42") [/home/julliard/wine/wine/dlls/msi/action.c:7517] in msi (0x0032f378) 8 0x6887b563 MsiInstallProductW+0x82(szPackagePath="msitest.msi", szCommandLine="INSTALLLEVEL=10 PROPVAR=42") [/home/julliard/wine/wine/dlls/msi/msi.c:243] in msi (0x0032f3c8) 9 0x68880901 MsiInstallProductA+0x180(szPackagePath="msitest.msi", szCommandLine="INSTALLLEVEL=10 PROPVAR=42") [/home/julliard/wine/wine/dlls/msi/msi.c:218] in msi (0x0032f788) 10 0x686e0523 test_MsiConfigureProductEx+0x3e2() [/home/julliard/wine/wine/dlls/msi/tests/install.c:4778] in msi_test (0x0032fd38) 11 0x686ee4b1 func_install+0x3a50() [/home/julliard/wine/wine/dlls/msi/tests/install.c:6419] in msi_test (0x0032fd88) 12 0x687adc0e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:556] in msi_test (0x0032fe48) 13 0x687ade07 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:624] in msi_test (0x0032fe90) 14 0x687ae98c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032fea8) 15 0x7b858dac call_process_entry+0xb() in kernel32 (0x0032fee8) 16 0x7b85b61b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1086] in kernel32 (0x0032fef8) 17 0x7bc73150 call_thread_func+0xb() in ntdll (0x0032ffc8) 18 0x7bc73320 call_thread_entry_point+0x6f(entry=0x7b85b5c0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2475] in ntdll (0x0032ffe8) 19 0x7bc4dd2a start_process+0x29(kernel_start=0x7b85b5c0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2606] in ntdll (0x00000000) 0x68875090 ready_media+0x300 [/home/julliard/wine/wine/dlls/msi/../../include/winbase.h:2280] in msi: movzwl 0x0(%edx,%eax,1),%ecx 2280 while ((*p++ = *src++)); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] shdocvw: Implement basic back/forward history support (resend)
by Jacek Caban 18 Jan '11

18 Jan '11

Hi Owen, On 1/18/11 1:35 AM, Owen Rudge wrote: > This resend removes a superfluous function. Parts 1-3 are unaffected. > > --- > dlls/shdocvw/dochost.c | 1 + > dlls/shdocvw/ie.c | 6 +--- > dlls/shdocvw/iexplore.c | 12 +++++++- > dlls/shdocvw/navigate.c | 66 > +++++++++++++++++++++++++++++++++++++++++++++ > dlls/shdocvw/resource.h | 2 + > dlls/shdocvw/shdocvw.h | 12 ++++++++ > dlls/shdocvw/webbrowser.c | 6 +--- > 7 files changed, 95 insertions(+), 10 deletions(-) First of all, tests please. Navigation history is more complicated than your approach. The most important thing is that documents reporting DOCHOST_DOCCANNAVIGATE are handling navigation themselves. HTMLDocument, about which we care the most, is such document. It means that most of the work should be done in mshtml and shdocvw should only notify mshtml about navigation back/forward. diff --git a/dlls/shdocvw/iexplore.c b/dlls/shdocvw/iexplore.c index 3b652cb..cac04a3 100644 --- a/dlls/shdocvw/iexplore.c +++ b/dlls/shdocvw/iexplore.c This part is fine can be a separated patch. Jacek

1 0

Re: [1/1][user32.dll]Adding Arabic Translation resources
by James McKenzie 18 Jan '11

18 Jan '11

On 1/8/11 7:05 PM, Nowres wrote: > From a5d9d1e4599ce5a6c2f45df7948182401526f997 Mon Sep 17 00:00:00 2001 > From: Nowres Rafid <nss.zpeedzter(a)gmail.com > <mailto:nss.zpeedzter@gmail.com>> > Date: Sun, 9 Jan 2011 00:54:00 +0000 > Subject: [user32]Adding Arabic translation resources > [Patch code deleted] Your patches are appearing in both the message and as a separate attachment. Also, your patches will not apply to current git code. Can you check your patches before sending them to the Patches list and please check if your git is current. Please review the Wiki article on how to create and send patches, please. James McKenzie

1 0

Re: msvcrt: Add _atoflt and _atoflt_l implementations (try2)
by Alexandre Julliard 17 Jan '11

17 Jan '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > I'm not sure about MSVCR_ types inside msvcr80, for wrappers it's > enough to have an empty struct pointers, if we really need proper > types please let me know. You should be using the real definitions from the msvcrt headers. Also you want the implementation in msvcr90, that's where the common implementations and tests go. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Richedit: Test Patch for EM_SETMARGINS
by James McKenzie 17 Jan '11

17 Jan '11

All: I would like comments on this patch. Thank you. James McKenzie

5 13

Re: wined3d: don't set cube and volume POW2 caps if np2 textures are supported
by Alexandre Julliard 17 Jan '11

17 Jan '11

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From aa344834084ef89c654011804e6e2faccafe1e5e Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Stefan=20D=C3=B6singer?= <stefan(a)codeweavers.com> > Date: Sun, 21 Nov 2010 18:08:41 +0100 > Subject: [PATCH] wined3d: don't set cube and volume POW2 caps if np2 textures are supported It doesn't work here: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so texture.c && touch texture.ok texture.c:236: Test failed: Returned mipmaps 9, expected 10 texture.c:242: Test failed: Returned mipmaps 6, expected 7 texture.c:381: Test failed: Returned mipmaps 9, expected 10 make: *** [texture.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

4 7

Re: [PATCH 1/1][winecfg]Adding Arabic translation resources
by Yaron Shahrabani 17 Jan '11

17 Jan '11

Hey Nowres, I should have told you earlier. Translated and RTLed winecfg is pretty difficult to use, I think you better leave this one untranslated and get to it when things will settle, agreed? Kind regards, Yaron Shahrabani <Hebrew translator> 2011/1/17 Nowres <nss.zpeedzter(a)gmail.com> > From 2c3da96493709ec6b11a026c72876daa753c514a Mon Sep 17 00:00:00 2001 > From: Nowres Rafid <nss.zpeedzter(a)gmail.com> > Date: Sun, 16 Jan 2011 23:37:22 +0000 > Subject: [winecfg]Adding Arabic translation resources > > --- > programs/winecfg/Ar.rc | 343 > ++++++++++++++++++++++++++++++++++++++++++ > programs/winecfg/Makefile.in | 1 + > 2 files changed, 344 insertions(+), 0 deletions(-) > create mode 100644 programs/winecfg/Ar.rc > > diff --git a/programs/winecfg/Ar.rc b/programs/winecfg/Ar.rc > new file mode 100644 > index 0000000..738928f > --- /dev/null > +++ b/programs/winecfg/Ar.rc > @@ -0,0 +1,343 @@ > +/* > + * WineCfg resources > + * Arabic Language Support > + * > + * Copyright 2011 Nowres Rafid <nss.zpeedzter(a)gmail.com> > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + * > + */ > + > +#include "config.h" /* Needed for the PACKAGE_STRING definition */ > +#include "resource.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_ARABIC, SUBLANG_NEUTRAL > + > +IDR_WINECFG MENU > +BEGIN > + POPUP "" > + BEGIN > + MENUITEM "ضبط", IDC_AUDIO_CONFIGURE > + END > +END > + > +IDD_ABOUTCFG DIALOGEX 0, 0, 260, 220 > +STYLE WS_CHILD > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL "", IDC_ABT_PANEL, "STATIC", SS_OWNERDRAW, 0, 0, 260, > 140 > + LTEXT PACKAGE_NAME,IDC_ABT_TITLE_TEXT,105,30,55,30 > + LTEXT PACKAGE_VERSION,IDC_ABT_PANEL_TEXT,160,43,140,8 > + CONTROL "",IDC_ABT_WEB_LINK,"SysLink", LWS_TRANSPARENT, > 105,53,106,8 > + LTEXT "هذا البرنامج حر, يمكنك توزيعه أو إجراء تغييرات عليه > شرط الإلتزام ببنود رخصة GNU Lesser General Public License\n الصادرة من طرف > منظمة البرامج الحرة وذلك بنسختها 2.1 أو أي نسخة لاحقة.", > + IDC_ABT_LICENSE_TEXT,105,64,145,60 > + GROUPBOX " معلومات تسجيل وندوز ", IDC_STATIC, 15, 155, 230, 55 > + LTEXT "المالك:", IDC_STATIC, 22, 171, 40, 20 > + EDITTEXT IDC_ABT_OWNER, 75, 171, 160, 13, ES_AUTOHSCROLL | > WS_TABSTOP > + LTEXT "المنظمة:", IDC_STATIC, 22, 185, 50, 20 > + EDITTEXT IDC_ABT_ORG, 75, 185, 160, 13, ES_AUTOHSCROLL | > WS_TABSTOP > +END > + > +IDD_APPCFG DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " إعدادات البرامج ",IDC_STATIC, 8,4,244,210 > + LTEXT "يستطيع واين تقليد إصدارات مختلفة من وندوز لكل برنامج. > هذه الخانة مرتبطة بخانتي المكتبات والرسوميات لكي تمكنك من ضبط إعدادات النظام > بصورة إجمالية أو حسب إحتياجات كل برنامج.", > + IDC_STATIC,15,20,235,30 > + CONTROL "البرامج",IDC_APP_LISTVIEW,"SysListView32",WS_BORDER | > WS_TABSTOP | LVS_LIST | LVS_SINGLESEL | LVS_SHOWSELALWAYS, > + 15,50,230,120 > + PUSHBUTTON "إضافة برنامج",IDC_APP_ADDAPP, 90,174,75,14 > + PUSHBUTTON "إزالة برنامج",IDC_APP_REMOVEAPP, 170,174,75,14 > + LTEXT "نسخة وندوز:",IDC_STATIC,17,196,58,8 > + COMBOBOX IDC_WINVER,83,194,163,56,CBS_DROPDOWNLIST | WS_VSCROLL > | WS_TABSTOP > +END > + > +IDD_GRAPHCFG DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " إعدادات النوافذ ",IDC_STATIC,8,4,244,84 > + CONTROL "السماح لتطبيقات DirectX بمنع المؤشر من الخروج من > نوافذها",IDC_DX_MOUSE_GRAB,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,15,20,230,8 > + CONTROL "السماح لمدير النوافذ بأن يقوم > بزخرفتها",IDC_ENABLE_DECORATED,"Button",BS_AUTOCHECKBOX | > WS_TABSTOP,15,32,230,8 > + CONTROL "السماح لمدير النوافذ بالتحكم > بها",IDC_ENABLE_MANAGED,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,15,44,230,8 > + CONTROL "محاكاة سطح مكتب إفتراضي",IDC_ENABLE_DESKTOP,"Button", > + BS_AUTOCHECKBOX | WS_TABSTOP,15,56,230,8 > + LTEXT "حجم سطح المكتب:",IDC_DESKTOP_SIZE,15,70,74,8,WS_DISABLED > + LTEXT "X",IDC_DESKTOP_BY,129,70,8,8,WS_DISABLED > + EDITTEXT IDC_DESKTOP_WIDTH,84,68,40,12,ES_AUTOHSCROLL | ES_NUMBER | > WS_DISABLED > + EDITTEXT IDC_DESKTOP_HEIGHT,137,68,40,12,ES_AUTOHSCROLL | ES_NUMBER > | WS_DISABLED > + > + GROUPBOX " Direct3D ",IDC_STATIC,8,95,244,49 > + LTEXT "دعم Vertex Shader: ",IDC_STATIC,15,110,80,32 > + COMBOBOX IDC_D3D_VSHADER_MODE,100,108,145,70,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + CONTROL "السماح باستخدام Pixel Shader إن > أمكن",IDC_D3D_PSHADER_MODE,"Button",BS_AUTOCHECKBOX | > WS_TABSTOP,15,126,230,10 > + > + GROUPBOX " دقة الشاشة ",IDC_STATIC,8,151,244,63 > + CONTROL "", IDC_RES_TRACKBAR, > "msctls_trackbar32",WS_TABSTOP,12,161,187,15 > + EDITTEXT IDC_RES_DPIEDIT,204,161,23,13,ES_NUMBER|WS_TABSTOP > + LTEXT "dpi",IDC_STATIC,235,163,10,8 > + LTEXT "هذا نموذج لنص يستخدم 10 نقاط بخط > Tahoma",IDC_RES_FONT_PREVIEW,15,180,230,28 > +END > + > +IDD_DLLCFG DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " إستبدالات الDLL ",IDC_STATIC,8,4,244,210 > + LTEXT "يمكن تحديد مكتبات الربط الديناميكية (DLL)\nلتكون إما > ضمنية (مزودة من طرف واين) أو أصلية (مأخوذة من وندوز أو مرفقة ببرنامج)." > + ,IDC_STATIC,16,16,220,32 > + LTEXT "إستبدال جديد للمكتبة:",IDC_STATIC,16,58,100,8 > + COMBOBOX IDC_DLLCOMBO,16,68,140,14,CBS_DROPDOWN | WS_VSCROLL | > WS_TABSTOP | CBS_SORT | CBS_LOWERCASE > + PUSHBUTTON "إضافة",IDC_DLLS_ADDDLL, 164,68,82,13 > + LTEXT "الإستبدالات الحالية:",IDC_STATIC,16,86,100,8 > + LISTBOX IDC_DLLS_LIST,16,96,140,112,WS_BORDER | WS_TABSTOP | > WS_VSCROLL > + PUSHBUTTON "تعديل...",IDC_DLLS_EDITDLL,164,96,82,14 > + PUSHBUTTON "إزالة",IDC_DLLS_REMOVEDLL,164,114,82,14 > +END > + > +IDD_LOADORDER DIALOG 80, 90, 110, 92 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL > +CAPTION "تعديل الإستبدال" > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " ترتيب التحميل ",IDC_STATIC,8,4,94,66 > + CONTROL "الضمنية (واين)",IDC_RAD_BUILTIN,"Button", > BS_AUTORADIOBUTTON | WS_GROUP,16,14,75,10 > + CONTROL "الأصلية (وندوز)",IDC_RAD_NATIVE,"Button", > BS_AUTORADIOBUTTON,16,24,75,10 > + CONTROL "الضمنية ثم الأصلية",IDC_RAD_BUILTIN_NATIVE,"Button", > BS_AUTORADIOBUTTON,16,34,75,10 > + CONTROL "الأصلية ثم الضمنية",IDC_RAD_NATIVE_BUILTIN,"Button", > BS_AUTORADIOBUTTON,16,44,75,10 > + CONTROL "تعطيل",IDC_RAD_DISABLE,"Button", > BS_AUTORADIOBUTTON,16,54,75,10 > + DEFPUSHBUTTON "موافق",IDOK,8,74,45,14,WS_GROUP > + PUSHBUTTON "إلغاء",IDCANCEL,57,74,45,14,WS_GROUP > +END > + > +IDD_DRIVECHOOSE DIALOG 60, 70, 170, 60 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL > +CAPTION "إختر حرفاً للقرص" > +FONT 8, "MS Shell Dlg" > +BEGIN > + COMBOBOX IDC_DRIVESA2Z,15,10,75,230,CBS_DROPDOWNLIST | WS_VSCROLL | > WS_TABSTOP > + DEFPUSHBUTTON "موافق",IDOK,105,10,45,14,WS_GROUP > + PUSHBUTTON "إلغاء",IDCANCEL,105,30,45,14,WS_GROUP > +END > + > +IDD_DRIVECFG DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " ربط الأقراص ",IDC_STATIC,8,4,244,195 > + LTEXT "لقد فشل الإتصال بمدير التركيب, إعدادات القرص لايمكن > تغييرها.", IDC_STATIC_MOUNTMGR_ERROR, 15,30,190,76 > + CONTROL "Listview",IDC_LIST_DRIVES,"SysListView32",LVS_REPORT > | LVS_AUTOARRANGE | LVS_ALIGNLEFT | > + LVS_SINGLESEL | WS_BORDER | WS_TABSTOP, 15,18,232,76 > + PUSHBUTTON "إضافة...",IDC_BUTTON_ADD,15,98,37,14 > + PUSHBUTTON "إزالة",IDC_BUTTON_REMOVE,56,98,37,14 > + PUSHBUTTON "تحديد تلقائي...",IDC_BUTTON_AUTODETECT,176,98,70,14 > + > + /* editing drive details */ > + LTEXT "المسار:",IDC_STATIC_PATH,15,123,24,9 > + EDITTEXT IDC_EDIT_PATH,41,120,160,13,ES_AUTOHSCROLL | > WS_TABSTOP > + PUSHBUTTON "إستعراض",IDC_BUTTON_BROWSE_PATH,206,120,40,13 > + > + LTEXT "النوع:",IDC_STATIC_TYPE,15,138,21,10 > + COMBOBOX IDC_COMBO_TYPE,41,135,77,60,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + > + PUSHBUTTON "إعدادات > متقدمة",IDC_BUTTON_SHOW_HIDE_ADVANCED,186,135,60,13 > + LTEXT "الجهاز:",IDC_STATIC_DEVICE,15,153,26,9 > + EDITTEXT IDC_EDIT_DEVICE,41,150,160,13,ES_AUTOHSCROLL | > WS_TABSTOP > + PUSHBUTTON "إستعراض...",IDC_BUTTON_BROWSE_DEVICE,206,150,40,13 > + > + LTEXT "ملصق:",IDC_STATIC_LABEL,15,168,26,12 > + EDITTEXT IDC_EDIT_LABEL,41,165,78,13,ES_AUTOHSCROLL | > WS_TABSTOP > + LTEXT "التسلسل:",IDC_STATIC_SERIAL,15,183,26,12 > + EDITTEXT IDC_EDIT_SERIAL,41,180,78,13,ES_AUTOHSCROLL | > WS_TABSTOP > + > + CONTROL "إظهار الملفات المبتدئة > بنقطة",IDC_SHOW_DOT_FILES,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,8,205,230,8 > +END > + > +IDD_AUDIOCFG DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " إختيار المعرف ",IDC_STATIC,8,4,244,160 > + LTEXT "إختر معرف الصوت بتحديد خانة المعرف المطلوب. يتم تعطيل > الصوت بترك كل خانات المعرفات فارغة. كما أنه من غير المحبذ إختيار عدة معرفات > في آن واحد.\n لضبط معرف إضغط زر الفأرة الأيمن ",IDC_STATIC,15,20,227,40 > + CONTROL "الأجهزة",IDC_AUDIO_TREE,"SysTreeView32",WS_BORDER | > WS_TABSTOP,15,60,155,95 > + PUSHBUTTON "إختبار الصوت",IDC_AUDIO_TEST,180,60,59,14 > + PUSHBUTTON "لوحة التحكم",IDC_AUDIO_CONTROL_PANEL,180,80,59,14 > + GROUPBOX " DirectSound ",IDC_STATIC,8,170,244,44 > + LTEXT "تسريع الجهاز:",IDC_STATIC,15,180,90,10 > + COMBOBOX IDC_DSOUND_HW_ACCEL,100,178,150,70,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + LTEXT "تردد العينة الإفتراضي:",IDC_STATIC,15,197,70,8 > + COMBOBOX IDC_DSOUND_RATES,90,195,42,76,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + LTEXT "عدد بايتات العينة الإفتراضي:",IDC_STATIC,137,197,80,8 > + COMBOBOX IDC_DSOUND_BITS,220,195,30,56,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > +END > + > +IDD_DESKTOP_INTEGRATION DIALOG 0, 0, 260, 220 > +STYLE WS_CHILD | WS_DISABLED > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" > +BEGIN > + GROUPBOX " المظهر ",IDC_STATIC,8,4,244,106 > + LTEXT "الموضوع:",IDC_STATIC,15,16,130,8 > + COMBOBOX IDC_THEME_THEMECOMBO,15,24,130,14,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + PUSHBUTTON "تنصيب موضوع...",IDC_THEME_INSTALL,152,23,93,14 > + LTEXT "اللون:",IDC_THEME_COLORTEXT,15,40,112,8 > + COMBOBOX IDC_THEME_COLORCOMBO,15,48,112,14,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + LTEXT "الحجم:",IDC_THEME_SIZETEXT,135,40,110,8 > + COMBOBOX IDC_THEME_SIZECOMBO,135,48,110,14,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP > + LTEXT "العنصر:",IDC_STATIC,15,64,112,8 > + COMBOBOX IDC_SYSPARAM_COMBO,15,74,112,120,CBS_DROPDOWNLIST | > WS_VSCROLL | WS_TABSTOP | CBS_SORT > + LTEXT > "اللون:",IDC_SYSPARAM_COLOR_TEXT,135,64,25,8,WS_DISABLED > + PUSHBUTTON "",IDC_SYSPARAM_COLOR,135,74,25,13,WS_DISABLED | > BS_OWNERDRAW > + LTEXT > "الحجم:",IDC_SYSPARAM_SIZE_TEXT,166,64,30,8,WS_DISABLED > + EDITTEXT IDC_SYSPARAM_SIZE,166,74,23,13,ES_AUTOHSCROLL | > WS_TABSTOP | WS_DISABLED > + CONTROL "",IDC_SYSPARAM_SIZE_UD,UPDOWN_CLASS,UDS_SETBUDDYINT | > WS_DISABLED,187,74,15,13 > + PUSHBUTTON "الخط...",IDC_SYSPARAM_FONT,208,74,37,13,WS_DISABLED > + GROUPBOX " المجلدات ",IDC_STATIC,8,114,244,100 > + CONTROL "Listview",IDC_LIST_SFPATHS,"SysListView32",LVS_REPORT > | LVS_AUTOARRANGE | LVS_ALIGNLEFT | > + LVS_SINGLESEL | WS_BORDER | WS_TABSTOP, 15,126,230,64 > + CONTROL "يربط > ل:",IDC_LINK_SFPATH,"Button",BS_AUTOCHECKBOX|WS_TABSTOP|WS_DISABLED,15,195,50,13 > + EDITTEXT > IDC_EDIT_SFPATH,65,195,125,13,ES_AUTOHSCROLL|WS_TABSTOP|WS_DISABLED > + PUSHBUTTON > "إستعراض...",IDC_BROWSE_SFPATH,195,195,50,13,WS_DISABLED > +END > + > +STRINGTABLE > +BEGIN > + IDS_TAB_APPLICATIONS "البرامج" > + IDS_TAB_DLLS "المكتبات" > + IDS_TAB_DRIVES "الأقراص" > + IDS_CHOOSE_PATH "إختر من فضلك مجلد يونيكس المطلوب" > + IDS_HIDE_ADVANCED "إخفاء" > + IDS_SHOW_ADVANCED "إظهار المزيد" > + IDS_NOTHEME "(بدون موضوع)" > + IDS_TAB_GRAPHICS "الرسوميات" > + IDS_TAB_DESKTOP_INTEGRATION "الإدماج مع سطح المكتب" > + IDS_TAB_AUDIO "الصوت" > + IDS_TAB_ABOUT "حول" > + IDS_WINECFG_TITLE "ضبط واين" > + IDS_WINECFG_TITLE_APP "ضبط واين الخاص ب %s" > + IDS_THEMEFILE "(*.msstyles; *.theme) ملفات المواضيع" > + IDS_THEMEFILE_SELECT "إختر ملف موضوع" > + IDS_AUDIO_MISSING "لايوجد أي معرف محدد حاليا في السجل.\n\nلقد تم > إختيار أفضل معرف بصورة تلقائية.\nيمكنك إستخدام هذا المعرف أو أي معرف آخر > متاح.\n\nيجب الضغط على تطبيق ليتم تثبيت التغييرات." > + IDS_SHELL_FOLDER "المجلد" > + IDS_LINKS_TO "يربط ل" > +END > + > +STRINGTABLE > +BEGIN > + IDS_DLL_WARNING "تغيير ترتيب التحميل الخاص بهذه المكتبة غبر > محبذ.\nهل أنت متأكد من هذا التغيير؟" > + IDS_DLL_WARNING_CAPTION "تحذير: مكتبة خاصة بالنظام" > + IDS_DLL_NATIVE "الأصلية" > + IDS_DLL_BUILTIN "الضمنية" > + IDS_DLL_NATIVE_BUILTIN "الأصلية ثم الضمنية" > + IDS_DLL_BUILTIN_NATIVE "الضمنية ثم الأصلية" > + IDS_DLL_DISABLED "معطل" > + IDS_DEFAULT_SETTINGS "الإعدادات الإفتراضية" > + IDS_EXECUTABLE_FILTER "برامج واين > (*.exe,*.exe.so)\0*.exe;*.exe.so\0" > + IDS_USE_GLOBAL_SETTINGS "إستخدام الإعدادات الشاملة" > + IDS_SELECT_EXECUTABLE "إختر ملف برنامج" > +END > + > +STRINGTABLE > +BEGIN > + IDS_SHADER_MODE_HARDWARE "بالجهاز" > + IDS_SHADER_MODE_NONE "بدون" > +END > + > +STRINGTABLE > +BEGIN > + IDS_DRIVE_UNKNOWN "تحديد تلقائي" > + IDS_DRIVE_FIXED "قرص صلب محلي" > + IDS_DRIVE_REMOTE "Network share" > + IDS_DRIVE_REMOVABLE "قرص مرن" > + IDS_DRIVE_CDROM "CD-ROM" > + IDS_DRIVE_LETTERS_EXCEEDED "لايمكنك إضافة قرص آخر, هناك 26 حرف وقد > استخدمتها كلها." > + IDS_SYSTEM_DRIVE_LABEL "قرص النظام" > + IDS_CONFIRM_DELETE_C "هل أنت متأكد من أنك تريد حذف القرص > C؟\n\nأغلب برامج وندوز تتوقع وجود هذا القرص وسيموتون بشكل فضيع إن لم يجدوه, > إن كنت تريد الإستمرار تذكر أن تعيد إنشاءه." > + IDS_COL_DRIVELETTER "الحرف" > + IDS_COL_DRIVEMAPPING "يعوض" > + IDS_NO_DRIVE_C "لاتملك قرص C وهذا أمر غير جيد, تذكر ان > تضيف هذا القرص يالضغط على إضافة" > +END > + > +STRINGTABLE > +BEGIN > + IDS_ACCEL_FULL "كامل" > + IDS_ACCEL_STANDARD "عادي" > + IDS_ACCEL_BASIC "أساسي" > + IDS_ACCEL_EMULATION "محاكاة" > + IDS_DRIVER_ALSA "معرف ALSA" > + IDS_DRIVER_ESOUND "معرف EsounD" > + IDS_DRIVER_OSS "معرف OSS" > + IDS_DRIVER_JACK "معرف JACK" > + IDS_DRIVER_NAS "معرف NAS" > + IDS_DRIVER_COREAUDIO "معرف CoreAudio" > + IDS_OPEN_DRIVER_ERROR "تعذر فتح %s" > + IDS_SOUNDDRIVERS "معرفات الصوت" > + IDS_DEVICES_WAVEOUT "أجهزة مخرج Wave" > + IDS_DEVICES_WAVEIN "أجهزة مدخل Wave" > + IDS_DEVICES_MIDIOUT "أجهزة مخرج MIDI" > + IDS_DEVICES_MIDIIN "أجهزة مدخل MIDI" > + IDS_DEVICES_AUX "أجهزة Aux" > + IDS_DEVICES_MIXER "أجهزة Mixer" > + IDS_UNAVAILABLE_DRIVER "لقد تم في السجل إيجاد معرف غير > متوفر!\n\nهل تريد حذف '%s' من السجل؟" > + IDS_WARNING "تحذير" > +END > + > +STRINGTABLE > +BEGIN > + IDC_SYSPARAMS_BUTTON "Controls Background" > + IDC_SYSPARAMS_BUTTON_TEXT "Controls Text" > + IDC_SYSPARAMS_DESKTOP "سطح المكتب" > + IDC_SYSPARAMS_MENU "خلفية القائمة" > + IDC_SYSPARAMS_MENU_TEXT "خلفية النص" > + IDC_SYSPARAMS_SCROLLBAR "Scrollbar" > + IDC_SYSPARAMS_SELECTION "خلفية التحديد" > + IDC_SYSPARAMS_SELECTION_TEXT "نص التحديد" > + IDC_SYSPARAMS_TOOLTIP "خلفية مربع النصائح" > + IDC_SYSPARAMS_TOOLTIP_TEXT "نص مربع النصائح" > + IDC_SYSPARAMS_WINDOW "خلفية النوافذ" > + IDC_SYSPARAMS_WINDOW_TEXT "نص النوافذ" > + IDC_SYSPARAMS_ACTIVE_TITLE "شريط العنوان النشط" > + IDC_SYSPARAMS_ACTIVE_TITLE_TEXT "نص العنوان النشط" > + IDC_SYSPARAMS_INACTIVE_TITLE "شريط العنوان غير النشط" > + IDC_SYSPARAMS_INACTIVE_TITLE_TEXT "نص العنوان غير النشط" > + IDC_SYSPARAMS_MSGBOX_TEXT "نص مربع الرسائل" > + IDC_SYSPARAMS_APPWORKSPACE "مساحة عمل التطبيقات" > + IDC_SYSPARAMS_WINDOW_FRAME "إطار النافذة" > + IDC_SYSPARAMS_ACTIVE_BORDER "الحدود النشيطة" > + IDC_SYSPARAMS_INACTIVE_BORDER "الحدود غير النشيطة" > + IDC_SYSPARAMS_BUTTON_SHADOW "Controls Shadow" > + IDC_SYSPARAMS_GRAY_TEXT "النص الرمادي" > + IDC_SYSPARAMS_BUTTON_HILIGHT "Controls Highlight" > + IDC_SYSPARAMS_BUTTON_DARK_SHADOW "Controls Dark Shadow" > + IDC_SYSPARAMS_BUTTON_LIGHT "Controls Light" > + IDC_SYSPARAMS_BUTTON_ALTERNATE "Controls Alternate Background" > + IDC_SYSPARAMS_HOT_TRACKING "Hot Tracked Item" > + IDC_SYSPARAMS_ACTIVE_TITLE_GRADIENT "تدريج شريط العنوان النشط" > + IDC_SYSPARAMS_INACTIVE_TITLE_GRADIENT "تدرج شريط العنوان غير النشط" > + IDC_SYSPARAMS_MENU_HILIGHT "Menu Highlight" > + IDC_SYSPARAMS_MENUBAR "شريط القائمة" > +END > diff --git a/programs/winecfg/Makefile.in b/programs/winecfg/Makefile.in > index bc956e7..b5cdcaf 100644 > --- a/programs/winecfg/Makefile.in > +++ b/programs/winecfg/Makefile.in > @@ -16,6 +16,7 @@ C_SRCS = \ > x11drvdlg.c > > RC_SRCS = \ > + Ar.rc \ > Bg.rc \ > Cs.rc \ > Da.rc \ > -- > 1.7.1 > > > > >

1 0

Re: [PATCH 2/3] jscript: Get rid of the jsdisp_addref() and jsdisp_release() wrappers.
by Jacek Caban 16 Jan '11

16 Jan '11

Hi Michael, Please leave there functions (and to_disp from your next patch). I have plans for them related to GC implementation, that I hope to find time to implement at some point. Thanks, Jacek

1 0

RE: RFC: Richedit: Test Patch for EM_SETMARGINS
by Greg Geldorp 16 Jan '11

16 Jan '11

From: James McKenzie > I'll have to figure out how to change the > resolution on the test bot and or my local copy of WindowsXP SP2 (not > upgradable, no Internet connection to that system. I've now changed the resolution to 1024x768 and 120DPI on VM WXPPRODPY16 from their previous values of 800x600 and 96DPI. The other thing special about this VM is that it has a screen depth of 16 bits while all other VMs have a depth of 32 bits. I wonder how many tests this will break... Greg.

2 1

Re: ntdll: Stop when we can't map the shared user data
by Vitaliy Margolen 16 Jan '11

16 Jan '11

On 01/14/2011 01:49 PM, André Hentschel wrote: > It can happen that the adress 0x7ffe0000 is blocked by some loaded libraries already. > + if (status) > + { > + MESSAGE( "wine: failed to map the shared user data: %x\n", status ); > + exit(1); > + } Most well behaved programs don't need it. However most copy-protection systems do use this area. As well as badly behaved programs (mostly of MS origin). If you running on different architecture then x86 it can be anywhere, since you won't be running native windows programs anyway. However some king of checking would be nice for all platforms. But don't think it warrants an exit. Vitaliy.

2 1

Re: [1/5] kernel32/tests: Free environment block in the child process when it is unused. (try 2)
by Marvin 16 Jan '11

16 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8357 Your paranoid android. === WNT4WSSP6 (32 bit process) === process.c:1020: Test failed: Misc:CurrDirA expected 'C:\WINNT', got '(null)' Timeout === W2KPROSP4 (32 bit process) === Timeout === WXPPROSP3 (32 bit process) === Timeout === W2K3R2SESP2 (32 bit process) === Timeout === WVISTAADM (32 bit process) === process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process.c:1020: Test failed: Misc:CurrDirA expected 'C:\Windows', got '(null)' process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB process: unhandled exception c0000005 at 774966AB Timeout === W2K8SE (32 bit process) === process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process.c:1020: Test failed: Misc:CurrDirA expected 'C:\Windows', got '(null)' process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 process: unhandled exception c0000005 at 778A5844 Timeout === W7PRO (32 bit process) === process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process.c:1020: Test failed: Misc:CurrDirA expected 'C:\Windows', got '(null)' process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 process: unhandled exception c0000005 at 772D1F70 Timeout === W7PROX64 (32 bit process) === process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process.c:1020: Test failed: Misc:CurrDirA expected 'C:\Windows', got '(null)' process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 process: unhandled exception c0000005 at 77DFDE64 Timeout === W7PROX64 (64 bit process) === process.c:549: Test failed: Child process termination process.c:554: Test failed: StartupInfoA:cb expected 104, but got 0 process.c:555: Test failed: StartupInfoA:lpDesktop expected 'Winsta0\Default', got '(null)' process.c:556: Test failed: StartupInfoA:dwX expected 0, but got 1 process.c:557: Test failed: StartupInfoA:dwY expected 0, but got 1 process.c:558: Test failed: StartupInfoA:dwXSize expected 0, but got 1 process.c:559: Test failed: StartupInfoA:dwYSize expected 0, but got 1 process.c:560: Test failed: StartupInfoA:dwXCountChars expected 0, but got 1 process.c:561: Test failed: StartupInfoA:dwYCountChars expected 0, but got 1 process.c:562: Test failed: StartupInfoA:dwFillAttribute expected 0, but got 1 process.c:563: Test failed: StartupInfoA:dwFlags expected 1, but got 0 process.c:564: Test failed: StartupInfoA:wShowWindow expected 1, but got 0 No test summary line found

1 0

Re: [1/5] kernel32/tests: Free environment block in the child process when it is unused.
by Marvin 16 Jan '11

16 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8354 Your paranoid android. === WXPPROSP3 (32 bit process) === process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process.c:1020: Test failed: Misc:CurrDirA expected 'C:\WINDOWS', got '(null)' process: unhandled exception c0000005 at 7C928C0B process: unhandled exception c0000005 at 7C928C0B process.c:1412: Test failed: Console:SizeX expected 80, but got 0 process.c:1413: Test failed: Console:SizeY expected 300, but got 0 process.c:1414: Test failed: Console:CursorX expected 0, but got 1 process.c:1415: Test failed: Console:CursorY expected 0, but got 1 process.c:1416: Test failed: Console:Attributes expected 7, but got 0 process.c:1417: Test failed: Console:winLeft expected 0, but got 1 process.c:1418: Test failed: Console:winTop expected 0, but got 1 process.c:1419: Test failed: Console:winRight expected 79, but got 0 process.c:1420: Test failed: Console:winBottom expected 24, but got 0 process.c:1421: Test failed: Console:maxWinWidth expected 80, but got 0 process.c:1422: Test failed: Console:maxWinHeight expected 45, but got 0 process.c:1423: Test failed: Console:InputCP expected 437, but got 0 process.c:1424: Test failed: Console:OutputCP expected 437, but got 0 process.c:1425: Test failed: Console:InputMode expected 167, but got 0 process.c:1426: Test failed: Console:OutputMode expected 3, but got 0 process.c:1430: Test failed: Wrong console CP (expected 1252 got 437/437) process.c:1431: Test failed: Wrong console-SB CP (expected 1252 got 437/437) process.c:1436: Test failed: Wrong console mode process.c:1437: Test failed: Wrong console-SB mode process.c:1439: Test failed: Wrong cursor position process.c:1475: Test failed: Should have received 'This is a std-handle inheritance test.' process.c:1482: Test failed: StdHandle:msg expected 'This is a std-handle inheritance test.', got '(null)' process: unhandled exception c0000005 at 7C928C0B process.c:1511: Test failed: ExitCode:value expected 3221225477, but got 0 === W7PROX64 (64 bit process) === process.c:1020: Test failed: Misc:CurrDirA expected 'C:\Windows', got '(null)' process.c:1412: Test failed: Console:SizeX expected 80, but got 0 process.c:1413: Test failed: Console:SizeY expected 300, but got 0 process.c:1414: Test failed: Console:CursorX expected 0, but got 1 process.c:1415: Test failed: Console:CursorY expected 0, but got 1 process.c:1416: Test failed: Console:Attributes expected 7, but got 0 process.c:1417: Test failed: Console:winLeft expected 0, but got 1 process.c:1418: Test failed: Console:winTop expected 0, but got 1 process.c:1419: Test failed: Console:winRight expected 79, but got 0 process.c:1420: Test failed: Console:winBottom expected 24, but got 0 process.c:1421: Test failed: Console:maxWinWidth expected 80, but got 0 process.c:1422: Test failed: Console:maxWinHeight expected 44, but got 0 process.c:1423: Test failed: Console:InputCP expected 850, but got 0 process.c:1424: Test failed: Console:OutputCP expected 850, but got 0 process.c:1425: Test failed: Console:InputMode expected 423, but got 0 process.c:1426: Test failed: Console:OutputMode expected 3, but got 0 process.c:1430: Test failed: Wrong console CP (expected 1252 got 850/850) process.c:1431: Test failed: Wrong console-SB CP (expected 1252 got 850/850) process.c:1436: Test failed: Wrong console mode process.c:1437: Test failed: Wrong console-SB mode process.c:1439: Test failed: Wrong cursor position process.c:1474: Test failed: Reading from child process.c:1475: Test failed: Should have received 'This is a std-handle inheritance test.' process.c:1482: Test failed: StdHandle:msg expected 'This is a std-handle inheritance test.', got '(null)' process.c:1511: Test failed: ExitCode:value expected 3221226356, but got 0

1 0

Hello, I'm new here
by CaStarCo 16 Jan '11

16 Jan '11

Hello, I'm new in this list and I would help in many things :p . I haven't much time, but I supose I can do little tasks. Ehm.. I've decided to collaborate because I have a little idea, but I don't know if it's really possible or if it's very difficult (i think no, but I don't know if I'm right). My idea is to modify the .lnk files of many programs when are installed to use icons not inside the executables, but more beautiful png images, helping to integrate the windows applications in the desktop. An example is the Spotify app, this application have a really small icon inside its executable, but when this image is used in a dock like Docky looks really ugly. If wine could make usage of many free (free as freedom) artwork instead of these icons, then the desktop will look more beautiful. ( I've tried to modify the .lnk files but i cant do it because are binary files and i cant find documentation about its structure) Bye , thanks for your atention :) . -- - Per la llibertat del coneixement - - Per la llibertat de la ment... -

3 2

Configuration warning
by Taeksang Yoo 16 Jan '11

16 Jan '11

configure: WARNING: OpenCL/opencl.h: present but cannot be compiled configure: WARNING: OpenCL/opencl.h: check for missing prerequisite headers? configure: WARNING: OpenCL/opencl.h: see the Autoconf documentation configure: WARNING: OpenCL/opencl.h: section "Present But Cannot Be Compiled" configure: WARNING: OpenCL/opencl.h: proceeding with the compiler's result configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Hello Wine developers. While compiling wine 1.3.11 on Mac OS X 10.6.6 using F3-bgmusic.patch and wine-1.3.11-xinput2.patch I got this error. If you need to know anything else please let me know; I reported the error as requested. Taeksang Yoo

2 1

semi-updated valgrind results
by Austin English 16 Jan '11

16 Jan '11

I ran the tests with Valgrind for wine 1.3.11 on Debian Squeeze. I haven't yet updated the suppressions file (I'd appreciate feedback on what to add :p), so the logs are a bit noisy... But, if you're curious, see http://austinenglish.com/logs/valgrind/ I haven't yet setup the tests on that machine to run daily, I may do so eventually, especially if it proves useful :-). -- -Austin

2 2

tests/amstream.c doesn't test anything
by Joerg-Cyril.Hoehle＠t-systems.com 15 Jan '11

15 Jan '11

Hi, please take a look at test.winehq.org http://test.winehq.org/data/tests/amstream:amstream.html It appears that almost all native machines perform 0 tests on amstream. As no skip is flagged, results appear all green. The only exception are Wylda's XP machines. They execute 16 tests but fail one of them. Can we conclude that the amstream tests are in a bad shape, despite green colour? Or that some amstream components are optional and should be installed on more test bots? (Note that the amstream.dll is present, otherwise the message would be different) Most Wine machines also execute 0 tests, except Nicolas Le Cam's (nlc) amstream.c:163: Test marked todo: IDirectDrawMediaStream_CreateSample returned: 80004001 What's different about these machines? Should I take this to bugzilla? I know next to nothing about amstream. It is about streaming to audio or a DirectDraw surface. http://msdn.microsoft.com/en-us/library/dd390909%28v=VS.85%29.aspx Regards, Jörg Höhle

4 3

re: Fail to use USB-Key/USB-Shield with wine USB patch
by Dan Kegel 15 Jan '11

15 Jan '11

Qian wrote: > My usbkey is also called G&D USB-Shield, it is required by > ICBC persional internet banking while online trading. > Unfortunately, ICBC website is IE-only, ActiveX and VBscript are required. > ... In fact, we don't have to login ICBC for testing the usbkey, > because there is a tool called Token Administration Utility, Thanks for the nice summary and the links. Hopefully someone will have time to look into the problem. I fear that the fact that it installs several drivers makes it unlikely it will be able to work in wine, but who knows. Also, even if the USB problems are worked out, there might be a bunch of crypto features that still need to be implemented/fixed. - Dan p.s. It looks like the software your bank uses is described here: http://www.aeteurope.com/aet/aet-europe/_www/en/pub/products/safesign/safes… (And it looks like they have a Linux version of their software, including the Token Administration Utility, but that won't help you.) They mention that they conform to the "windows smart card infrastructure" described in http://msdn.microsoft.com/en-us/library/bb905527.aspx The "base csp" described there is at http://www.microsoft.com/downloads/en/details.aspx?FamilyID=e8095fd5-c7e5-4… but won't install on non-licensed versions of windows, like wine.

1 0

Testbot not accepting patch
by Travis Athougies 15 Jan '11

15 Jan '11

Hi there, I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on wine-patches (the error on the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this? Thanks, Travis. -- Travis Athougies

7 8

64bit debugging or 32/64bit wine coexistence?
by Geoff Hart 15 Jan '11

15 Jan '11

I'm on Fedora 14, using 64bit Wine 1.3.10, to do Winelib development. Seems to work fine, except, I ran into winedbg problems, like: http://www.winehq.org/pipermail/wine-devel/2010-September/086933.html I saw Eric's response: http://www.winehq.org/pipermail/wine-devel/2010-October/087241.html but I presume it will take sometime for that to trickle into Fedora's repos. So, I thought I'd try using 32bit development, in the mean time. However: ghart@32 ~ $ winegcc -m32 crash.c -o crash32 /usr/bin/ld: Relocatable linking with relocations from format elf64-x86-64 (/usr/lib64/wine/libwinecrt0.a(exe_entry.o)) to format elf32-i386 (crash32.6JRMXE.o) is not supported winebuild: /usr/bin/ld failed with status 1 winegcc: winebuild failed I presumed this was because I needed to use WINEARCH=win32, so I tried: ghart@32 ~ $ rm -fr ~/.win32 ghart@32 ~ $ WINEPREFIX=~/.win32 WINEARCH=win32 winecfg wine: created the configuration directory '/vhe/emu/users/ghart/.win32' wine: cannot find L"C:\\windows\\system32\\wineboot.exe" err:process:start_wineboot failed to start wineboot, err 2 Ends up with an incomplete ~/.win32. In contrast: ghart@32 ~ $ rm -fr ~/.win64 ghart@32 ~ $ WINEPREFIX=~/.win64 WINEARCH= winecfg wine: created the configuration directory '/vhe/emu/users/ghart/.win64' Could not load wine-gecko. HTML rendering will be disabled. fixme:system:SetProcessDPIAware stub! fixme:iphlpapi:NotifyAddrChange (Handle 0x63be914, overlapped 0x63be918): stub wine: configuration in '/vhe/emu/users/ghart/.win64' has been updated. seems to function properly. ghart@32 ~ $ locate wineboot /usr/bin/wineboot /usr/lib/wine/fakedlls/wineboot.exe /usr/lib64/wine/wineboot.exe.so /usr/lib64/wine/fakedlls/wineboot.exe I wondered why no /usr/lib/wine/wineboot.exe.so ghart@32 ~ $ ls /usr/lib/wine/wine*.so /usr/lib/wine/winebrowser.exe.so /usr/lib/wine/winemapi.dll.so /usr/lib/wine/winecfg.exe.so /usr/lib/wine/winemenubuilder.exe.so /usr/lib/wine/wineconsole.exe.so /usr/lib/wine/winemine.exe.so /usr/lib/wine/winecoreaudio.drv.so /usr/lib/wine/winepath.exe.so /usr/lib/wine/wined3d.dll.so /usr/lib/wine/wineps16.drv16.so /usr/lib/wine/winedbg.exe.so /usr/lib/wine/wineps.drv.so /usr/lib/wine/winedevice.exe.so /usr/lib/wine/winepulse.drv.so /usr/lib/wine/winefile.exe.so /usr/lib/wine/winevdm.exe.so /usr/lib/wine/winegstreamer.dll.so /usr/lib/wine/winex11.drv.so /usr/lib/wine/winejoystick.drv.so I then wondered if this is some Fedora packaging issue: root@mspl001 ~ # yum install wine.i686 Loaded plugins: auto-update-debuginfo, presto, refresh-packagekit Setting up Install Process Resolving Dependencies --> Running transaction check ---> Package wine.i686 0:1.3.10-1.fc14 set to be installed --> Processing Dependency: wine-wow(x86-32) = 1.3.10-1.fc14 for package: wine-1.3.10-1.fc14.i686 --> Running transaction check ---> Package wine-wow.i686 0:1.3.10-1.fc14 set to be installed --> Processing Conflict: wine-1.3.10-1.fc14.x86_64 conflicts wine-wow(x86-32) = 1.3.10-1.fc14 --> Finished Dependency Resolution Error: wine conflicts with wine-wow To me this suggests that wine.i686 is exclusively for 32bit, which I'm hesitant use (I'd like to have both 32 and 64 bit compilations at least, even if debugging is limited to 32bit). I googled around quite a bit, and saw others mention problems similar to mine, but didn't spot any resolution. Can anyone suggest a solution for either the 64bit winedbg or 32bit winegcc usage? thanks, Geoff

2 1

Re: [01/10] msvcr90/tests: Avoid casting away const and avoid potential overflows in comparison functions.
by Marcus Meissner 15 Jan '11

15 Jan '11

On Sat, Jan 15, 2011 at 02:27:49AM -0600, Andrew Nguyen wrote: > --- > dlls/msvcr90/tests/msvcr90.c | 27 +++++++++++++++++++++------ > 1 files changed, 21 insertions(+), 6 deletions(-) > > > diff --git a/dlls/msvcr90/tests/msvcr90.c b/dlls/msvcr90/tests/msvcr90.c > index 24a6517..9c07d64 100644 > --- a/dlls/msvcr90/tests/msvcr90.c > +++ b/dlls/msvcr90/tests/msvcr90.c > @@ -446,25 +446,40 @@ static void test_wcsncat_s(void) > } > > -static __cdecl int strcomparefunc(void *context, const void *a, const void*b) > +static __cdecl int strcomparefunc(void *context, const void *a, const void *b) > { > + const char *p = a, *q = b; > + > ok (a != b, "must never get the same pointer\n"); > ++*(int *) context; > - return lstrcmpA(*(char**)a,*(char**)b); > + > + return lstrcmpA(p, q); As testbot wrote, this change is wrong. :) should be const char *p = *a, *q = *b; I guess. Ciao, Marcus

2 1

Re: [02/10] ntdll/tests: Avoid casting away const and avoid potential overflows in comparison functions.
by Marvin 15 Jan '11

15 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8309 Your paranoid android. === WNT4WSSP6 (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W2KPROSP4 (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === WXPPROSP3 (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W2K3R2SESP2 (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === WVISTAADM (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W2K8SE (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W7PRO (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W7PROX64 (32 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is World string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully string.c:1232: Test failed: badly sorted, strarr[3] is . string.c:1233: Test failed: badly sorted, strarr[4] is Hello string.c:1235: Test failed: badly sorted, strarr[6] is Sorted === W7PROX64 (64 bit string) === string.c:1229: Test failed: badly sorted, strarr[0] is Hello string.c:1230: Test failed: badly sorted, strarr[1] is ! string.c:1231: Test failed: badly sorted, strarr[2] is Wine string.c:1232: Test failed: badly sorted, strarr[3] is World string.c:1233: Test failed: badly sorted, strarr[4] is Hopefully string.c:1234: Test failed: badly sorted, strarr[5] is Sorted string.c:1235: Test failed: badly sorted, strarr[6] is .

1 0

Re: [01/10] msvcr90/tests: Avoid casting away const and avoid potential overflows in comparison functions.
by Marvin 15 Jan '11

15 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8308 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === WVISTAADM (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === W2K8SE (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === W7PRO (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === W7PROX64 (32 bit msvcr90) === msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Hopefully msvcr90.c:587: Test failed: badly sorted, strarr[3] is Sorted msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is . msvcr90.c:590: Test failed: badly sorted, strarr[6] is Wine === W7PROX64 (64 bit msvcr90) === msvcr90.c:584: Test failed: badly sorted, strarr[0] is Wine msvcr90.c:585: Test failed: badly sorted, strarr[1] is World msvcr90.c:586: Test failed: badly sorted, strarr[2] is Sorted msvcr90.c:587: Test failed: badly sorted, strarr[3] is . msvcr90.c:588: Test failed: badly sorted, strarr[4] is Hello msvcr90.c:589: Test failed: badly sorted, strarr[5] is ! msvcr90.c:590: Test failed: badly sorted, strarr[6] is Hopefully

1 0

Re: msvcrt: Add _atoflt and _atoflt_l implementations
by Alexandre Julliard 14 Jan '11

14 Jan '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -333,6 +333,123 @@ double CDECL MSVCRT__atof_l( const char *str, MSVCRT__locale_t locale) > } > > /********************************************************************* > + * _atoflt_l (MSVCRT.@) > + * > + * Not exported by native msvcrt > + */ It is exported, that's why it's in the spec file. The non _l version isn't, but it doesn't need to be, the wrappers can go in the individual msvcr* dlls. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [3/3] dsound/tests: Add IEEE float buffer tests for dsound8
by Alexandre Julliard 14 Jan '11

14 Jan '11

Owen Rudge <orudge(a)codeweavers.com> writes: > --- > dlls/dsound/tests/ds3d8.c | 7 ++++++- > dlls/dsound/tests/dsound8.c | 33 +++++++++++++++++++++++---------- > 2 files changed, 29 insertions(+), 11 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound8.c && touch dsound8.ok dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) dsound8.c:816: Test failed: IDirectSound_CreateSoundBuffer() returned: 8878001e (nil) make: *** [dsound8.ok] Error 24 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msxml3: Fixed memory leak (coverity)
by Jacek Caban 14 Jan '11

14 Jan '11

On 1/14/11 2:01 PM, Jacek Caban wrote: > --- > dlls/msxml3/httprequest.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) It's actually a Valgrind fix. The commit message is a typo. Sorry about that. Jacek

1 0

Procedure for adding message contexts to PO messages?
by Frédéric Delanoy 14 Jan '11

14 Jan '11

Hi, I'm quite green wrt PO files and was reviewing French PO file after recent rc -> po migration. So I read somewhat about PO format and Wine's "PO support code". I wonder how to add message contexts, and thought it might be this way: 1. Add msgctxt "myContext" next to the associated msgid "myMsgid" string in en.po 2. Replace myMsgid by #msgctxt#myContext#myMsgid in the relevant rc file (e.g. IDS_MY_KEY, "#msgctxt#myContext#myMsgid") 3. Translate Is that the correct procedure? Or am I missing something? I suppose, if there are multiple contexts (which should always be the case when introducing contexts, otherwise "#." extracted comments should be used IMHO), rc files key should be duplicated as well, so we'd rather have sthg like that? (originally) IDS_MY_KEY, "myMsgid" becomes IDS_MY_KEY1, "#msgctxt#myContext1#myMsgid" IDS_MY_KEY2, "#msgctxt#myContext2#myMsgid" with source code references adapted, or maybe IDS_MY_KEY, "myMsgid" IDS_MY_KEY1, "#msgctxt#myContext1#myMsgid" where IDS_MY_KEY uses the most common, "default" context. This would also minimize the amount of changes to be done in source files. Thanks for clarifications, Frédéric PS: For interested people, here's the "reference" I found : http://pology.nedohodnik.net/doc/user/ch-poformat.html

2 2

Re: Alexandre Julliard : winedump: Try to load the PDB string table from file number 4 too.
by Eric Pouech 14 Jan '11

14 Jan '11

Le 12/01/2011 20:16, Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: 4f574ee942be99c7401a3bef472a81d0f2bb0b5b > URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f574ee942be99c7401a3bef4… > > Author: Alexandre Julliard<julliard(a)winehq.org> > Date: Wed Jan 12 10:45:54 2011 +0100 > > winedump: Try to load the PDB string table from file number 4 too. > > > > Alexandre visiblement tu as un exemplaire de pdb sous la main différent de ceux que j'ai vu peux-tu me le passer (sauf si contrat spécifique CW bien sûr) j'ai toujours trouvé curieux les index constants pour certains streams dans les PDB, donc si j'en ai des différents, ca pourrait aider à trouver l'indirection (potentielle) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 3

wineqtdecoder: Initial version of the video decoder using Mac OS/X QuickTime Framework.
by Joerg-Cyril.Hoehle＠t-systems.com 14 Jan '11

14 Jan '11

Aric, your post 1.3.9 patch needs additional autoconf help to detect systems where the QT framework developer files are not installed. wine fails to build here (MacOS 10.5.8) qtvdecoder.c:63:40: error: QuickTime/ImageCompression.h: No such file or directory qtvdecoder.c:139: error: expected specifier-qualifier-list before "ImageDescriptionHandle" I've configured my Mac as described in the "lightweight build" section of http://wiki.winehq.org/MacOSX/Building I propose to install the framework (likely located on the install DVD) on my machine after a patch to detect its absence goes into git, so that we know the detection works correctly. Regards, Jörg Höhle

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel