- wine-devel - winehq.org

Re: libs/wine: Fix regression caused by 5af634fd3b7ff7e4d6f8af34f6139315fdbbc8c4 for non-x86 architectures
by Austin English 14 Jan '11

14 Jan '11

2011/1/13 André Hentschel <nerv(a)dawncrow.de>: > --- > libs/wine/config.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libs/wine/config.c b/libs/wine/config.c > index e15012b..2c365a4 100644 > --- a/libs/wine/config.c > +++ b/libs/wine/config.c > @@ -456,7 +456,7 @@ const char *wine_get_build_id(void) > /* exec a binary using the preloader if requested; helper for wine_exec_wine_binary */ > static void preloader_exec( char **argv, int use_preloader ) > { > -#ifdef linux > +#ifdef linux && defined(__i386__) && defined(__x86_64__) > if (use_preloader) > { > static const char preloader[] = "wine-preloader"; > -- Causes a warning here: ./config.c:459:14: warning: extra tokens at end of #ifdef directive Additionally, you're mixing ifdef and if defined. I used the below patch on powerpc, which works well: diff --git a/libs/wine/config.c b/libs/wine/config.c index 4a2bced..7fce02b 100644 --- a/libs/wine/config.c +++ b/libs/wine/config.c @@ -456,7 +456,7 @@ const char *wine_get_build_id(void) /* exec a binary using the preloader if requested; helper for wine_exec_wine_binary */ static void preloader_exec( char **argv, int use_preloader ) { -#ifdef linux +#if defined (__linux__) && (defined(__i386__) || defined(__x86_64__)) if (use_preloader) { static const char preloader[] = "wine-preloader"; -- -Austin

1 0

Re: [2/7] kernel32: Improve parameter validation for ReadConsoleOutputCharacterA.
by Marvin 13 Jan '11

13 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8232 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

3 3

Re: kernel32/tests: Use the right return type and a better failed test message
by Marvin 12 Jan '11

12 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8267 Your paranoid android. === W7PRO (32 bit pipe) === Failure running script in VM: Exceeded timeout limit of 135 sec === W7PROX64 (32 bit pipe) === Failure running script in VM: Exceeded timeout limit of 135 sec

1 0

Re: [PATCH] windowscodecs/tests: Fix crash introduced with eaf394a9ac4c.
by Marvin 12 Jan '11

12 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8269 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W2K8SE (32 bit converter) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\windowscodecs_test.exe === W7PRO (32 bit converter) === No test summary line found === W7PROX64 (32 bit converter) === No test summary line found

1 0

Re: [PATCH 1/3] msvcr90: Implement _set_abort_behavior [try2]
by Alexandre Julliard 12 Jan '11

12 Jan '11

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -36,6 +36,11 @@ static MSVCRT_purecall_handler purecall_handler = NULL; > > static const char szMsgBoxTitle[] = "Wine C++ Runtime Library"; > > +#ifndef _WRITE_ABORT_MSG > +#define _WRITE_ABORT_MSG 1 > +#define _CALL_REPORTFAULT 2 > +#endif These should go in msvcrt.h with the appropriate prefix and corresponding test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Partially implement _set_abort_behavior
by Detlef Riekenberg 12 Jan '11

12 Jan '11

On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote: > Date: Wed, 12 Jan 2011 00:46:26 +0300 > Subject: [PATCH 1/1] Partially implement _set_abort_behavior Please search the patches queue first. try 2: http://source.winehq.org/patches/data/70231 try 1: http://source.winehq.org/patches/data/70136 > +static int MSVCRT_abort_behavior = MSVCRT__WRITE_ABORT_MSG | > MSVCRT__WRITE_CALL_REPORTFAULT; - _set_abort_behavior get unsigned int, but you use an int. Why? - mingw header have the same name as msdn. Why are you using different names? > /********************************************************************* > + * _set_abort_behavior (MSVCRT.@) > + * > + * Not exported by native msvcrt, added in msvcr80 > + */ > +int CDECL MSVCRT__set_abort_behavior(int flags, int mask) > +{ - need unsigned int > diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h > > +/* _set_abort_behavior codes */ > +#define MSVCRT__WRITE_ABORT_MSG 1 > +#define MSVCRT__WRITE_CALL_REPORTFAULT 2 > + > +int __cdecl MSVCRT__set_abort_behavior(int,int); - correct location is stdlib.h - names are wrong - need unsigned int > -- By by ... Detlef

2 1

windowscodecs: Use Mac OS X native ICNS support, not libicns
by Joerg-Cyril.Hoehle＠t-systems.com 12 Jan '11

12 Jan '11

Ken, Thank you! Indeed I never installed libicns on my Mac (why use an external library on the particular OS that created the need for ICNS format support?) and even reverted Damjan's patch to still create .png images like the Linux systems. Then I use sips -i to create .command files with icons -- as I explained on the Wiki. http://wiki.winehq.org/MacOSX/FAQs >Besides being referenced by .desktop files which aren't used, Why not instead create .command files like I explain on the Wiki? Basically, instead of xyz.desktop: Path=/foo/bar Exec=env WINEPREFIX=... wine ... Icon=... create a xyz.command: #! /bin/sh cd /foo/bar && exec env WINEPREFIX=... wine ... >the ICNS files are written to /tmp, as things stand. Good. It's valuable to have a place where to obtain the icons even after the installer finishes. I'm used to peeking at ~/.local/share/icons to see which icons I can associate with .command files on MacOS (and .desktop on Linux). In my particular case, it's useful to have the .png because I can use it for both Linux and MacOS. Regards, Jörg Höhle FWIW, I've compiled 1.3.11 which includes your patch but have not tested it yet.

1 0

Re: d3d9/tests: Skip tests if not running in the foreground
by Marvin 12 Jan '11

12 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8260 Your paranoid android. === W2K8SE (32 bit device) === Can't copy TestLauncher to VM: Cannot connect to the virtual machine

1 0

windowscodecs: Use Mac OS X native ICNS support, not libicns.
by Ken Thomases 12 Jan '11

12 Jan '11

Hi Damjan, I was intrigued to see the ICNS support you added to windowscodecs some months ago. Neat work! However, I'm confused about why you used the third-party libicns library. As near as I can tell, the ICNS support is only used on Mac OS X and it's not likely to ever be used elsewhere. If that's the case, why did you not build it on top of the native ICNS support built into Mac OS X? Using the native frameworks would avoid one more external dependency that would need to be shipped with Wine on the Mac. I'm attaching a patch that changes to using the ApplicationServices framework instead of libicns. I wanted to get your input before sending it to wine-patches. What do you think? Thanks, Ken ----------------------------------------------------------------------- The ICNS support is only used on Mac OS X and is not anticipated to be used on any other platform. So, we can rely on the native frameworks rather than a third-party dependency. --- configure.ac | 16 +-- dlls/windowscodecs/Makefile.in | 1 + dlls/windowscodecs/icnsformat.c | 270 ++++++++++++++++----------------------- include/config.h.in | 10 +- 4 files changed, 119 insertions(+), 178 deletions(-)

3 5

Re: [PATCH 1/3] winemenubuilder: Icon heights/widths of 0 mean 256, for Vista icons.
by Damjan Jovanovic 12 Jan '11

12 Jan '11

The 256x256 pixel icons are designed to be viewed in that size. They can, and often do, contain a different picture to the smaller icons. When you scale them down to a smaller size, they look bad. On MacOS that may not matter since multiple icon sizes are written and the best is chosen, but on freedesktops we only write 1 icon size at the moment, and then it gets scaled to something like 64x64, so it really does make a difference. Install eMule and see its icons on Gnome as an example. On Tue, Jan 11, 2011 at 5:48 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > > The existing code would always prefer a smaller icon because it was > misinterpreting 256x256 icons as 0x0. > --- > programs/winemenubuilder/winemenubuilder.c | 32 +++++++++++++++------------ > 1 files changed, 18 insertions(+), 14 deletions(-) > > > > >

2 3

wineserver hitting kernel bug?
by André Hentschel 12 Jan '11

12 Jan '11

Hi all, i get err:process:start_wineboot failed to start wineboot, err 1359 which of course leads to major problems, i tracked it down to server/process.c in function process_poll_event it hits the line if (event & (POLLERR | POLLHUP)) kill_process( process, 0 ) because event is 0x19 what can cause that? maybe a kernelbug? that's with ext3 and after working around https://bugs.launchpad.net/ubuntu/+source/linux-ti-omap4/+bug/697004/ yes, it is on ARM (pandaboard) uname -a : Linux panda 2.6.35-903-omap4 #19-Ubuntu SMP PREEMPT Wed Nov 17 16:11:04 UTC 2010 armv7l GNU/Linux -- Best Regards, André Hentschel

3 3

Re: windowscodecs/tests: COM cleanup for converter.c.
by Marvin 11 Jan '11

11 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8249 Your paranoid android. === WXPPROSP3 (32 bit converter) === No test summary line found === WVISTAADM (32 bit converter) === converter: unhandled exception c0000005 at 7749794D === W2K8SE (32 bit converter) === converter: unhandled exception c0000005 at 778A8C6B

1 0

sc2 performance (was: Wine and D3D)
by Dan Kegel 11 Jan '11

11 Jan '11

emaentra(a)ngi.it wrote: >If during my tests I set the affinity of the executable (and >subsequently all its threads) to a particular core I have to say that >core gets fully used and FPS are better than general That's interesting. what cpu, gpu, and version of wine do you have, and what is the fps before and after pinning the game to one cpu? You should use, say, the fps on launching into one of the default scenarios without touching anything so that we can get a reproducible measurement. Tell us what mouseclicks to use to replicate your measurement. Or, if you think it's needed, right after launch, select all units and have them start moving, and use the lowest fps seen during those few seconds.

3 3

AppDB: Do not upload screenshots of error messages, installers, game menus
by Joerg-Cyril.Hoehle＠t-systems.com 11 Jan '11

11 Jan '11

Hi, the AppDB screenshot submission pages mentions this rule - Do not upload screenshots of error messages, installers, game menus yet it is continuously violated and e.g. screenshots of game menus are accepted, including recently. Is it still a useful rule? If yes, should matching screenshots be removed? While we are at it, should there be a rule about accepting or not screenshots showing bugs such as graphical artefacts? Probably it's better to have a screenshot with bugs than have none. Just curious, Jörg Höhle

3 3

re: crypt32: Fix Quote-Handling (try 2)
by Juan Lang 11 Jan '11

11 Jan '11

Hi Christian, on second thought I don't have too much to say about this, other than style comments: take them or leave them. +/* Only use this function internally. */ This comment isn't all that useful. You might indicate that quotes are only needed by CertNameToStr when the string type is CERT_X500_NAME_STR, but that might be clear enough from the code. Also, since CertRDNValueToStr doesn't need quote_string, you should probably invert the order in which they appear in the file. Thanks, --Juan

2 2

Re: crypt32: Added Quoting-Tests
by Juan Lang 11 Jan '11

11 Jan '11

Hi Christian, -static BYTE bin1[] = { 0x55, 0x53 }; -static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, +static BYTE bin1[] = { 0x55, 0x53 }; +static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74, 0x61 }; Please don't introduce whitespace-only changes, it's harder to see what your patch is doing. + { "0", CERT_RDN_PRINTABLE_STRING, + { sizeof(bin9), bin9 }, "abc\"def" }, Since these changes pass on unpatched wine, they don't demonstrate the necessity for your patch. We need tests that show what the existing problem is. --Juan

2 5

Re: advapi32: Only attempt multibyte conversion in SetEntriesInAclA when ptstrName is a string.
by Alexandre Julliard 11 Jan '11

11 Jan '11

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/advapi32/security.c | 19 ++++++++++++------- > 1 files changed, 12 insertions(+), 7 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so security.c && touch security.ok security.c:1449: Tests skipped: Well known SIDs starting from 62 are not implemented security.c:2681: Test failed: SetEntriesInAclA failed: 87 security.c:2682: Test failed: returned acl was NULL security.c:2694: Test failed: SetEntriesInAclA failed: 87 security.c:2695: Test failed: returned acl was NULL security.c:2720: Test failed: SetEntriesInAclA failed: 87 security.c:2721: Test failed: returned acl was NULL security.c:2728: Test failed: SetEntriesInAclA failed: 87 security.c:2729: Test failed: returned acl was NULL make[1]: *** [security.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] comctl32/rebar: Implemented dragging between rows
by Joris Huizer 11 Jan '11

11 Jan '11

Hello, In this patch, in function REBAR_HandleUDDrag: + if(yOff < 0) + { + /* Place the band above the current top row */ + DPA_DeletePtr(infoPtr->bands, iHitBand); + hitBand->fStyle &= RBBS_BREAK; + REBAR_GetBand(infoPtr, 0)->fStyle |= RBBS_BREAK; + infoPtr->iGrabbedBand = DPA_InsertPtr( + infoPtr->bands, 0, hitBand); + } It looks like that should have been: hitBand->fStyle &= ~RBBS_BREAK; HTH, Joris

1 0

Re: [4/7] kernel32/tests: Demonstrate an input event handling peculiarity with WriteConsoleInputW.
by Eric Pouech 11 Jan '11

11 Jan '11

Hi Andrew, I think the test should be enhanced by checking the information about mouse position it seems that windows coalesce two mouse messages, but does it also occur when the position is different (a cursory look seems to indicate that you resend the same coordinate for mouse move) I'd expect coalesce operation to happen only if coordinates are the same A+ 2011/1/11 Andrew Nguyen <anguyen(a)codeweavers.com> > --- > dlls/kernel32/tests/console.c | 165 > +++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 159 insertions(+), 6 deletions(-) > > > > > > > -- -- Eric Pouech

2 1

Re: po: Fix rc->po misconverted iccvid French translation
by Alexandre Julliard 11 Jan '11

11 Jan '11

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > --- > po/fr.po | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) There are many more issues to fix. One of the motivations for po files is to reduce the patch churn caused by translations, so please don't send a separate patch for each string, do a review pass over the whole file and fix everything you can. The po format makes it easy to find places that need work. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [3/7] kernel32: Improve parameter validation for ReadConsoleOutputAttribute.
by Marvin 11 Jan '11

11 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8233 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: fusion/tests: Add some tests for IAssemblyCache_QueryAssemblyInfo.
by Marvin 11 Jan '11

11 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8223 Your paranoid android. === W7PROX64 (32 bit asmcache) === No test summary line found

1 0

Re: gdiplus: Support for indexed formats in GdipBitmapSetPixel
by Paul Vriens 11 Jan '11

11 Jan '11

On 01/11/2011 02:26 AM, MP wrote: > + case PixelFormat8bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat4bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; > + case PixelFormat1bppIndexed: > + setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); > + break; Hi, Didn't check the other part of the patch for correctness but you are calling the same function here for 3 different formats. -- Cheers, Paul.

1 0

Re: crypt32: Fix Quote-Handling
by Juan Lang 10 Jan '11

10 Jan '11

Hi Christian, > As tested on Windows(R) 7 Home Premium x64, "CertRDNValueToStr" Doesn't > handle the quoting. > Instead it's made on "CertNameToStr" with CERT_X500_NAME_STR flag. Adding tests that demonstrate that would help a great deal. A minor comment regarding the patch itself: +/* Only use this function internally. */ +static DWORD QuoteCertRDNValueToStrA(DWORD dwValueType, PCERT_RDN_VALUE_BLOB pValue, Don't use Hungarian notation for internal functions, it's hard to distinguish them from Win32 API functions. --Juan

2 1

Re: makefiles: Ignore mo files
by Alexandre Julliard 10 Jan '11

10 Jan '11

Luca Bennati <lucak3(a)gmail.com> writes: > They get automatically generated if you use poedit to translate This should go in your local config, .gitignore is for files generated by the standard build process. -- Alexandre Julliard julliard(a)winehq.org

1 0

Spammer on Wike
by Vitaliy Margolen 09 Jan '11

09 Jan '11

Would Wiki admin please ban 201.21.186.95 ip? This user been spamming for the past several days. Vitaliy.

1 0

user32/test failing in cursoricon with proper results
by James Mckenzie 09 Jan '11

09 Jan '11

All: I just ran the user32 tests to validate what I am seeing with my richedit test in progress but the test failed in the cursoricon check with valid results. Before I open a bug report, can anyone on a Mac validate that they receive 23 errors with valid test results? Thank you. James McKenzie

2 1

Re: Wine and D3D
by Emanuele Oriani 09 Jan '11

09 Jan '11

Hi Stefan, First of all thanks for the answer. It's a shame you lost that presentation, but it'd be great if you could in some way point out what are the current issues and where we spend CPU time (did I understand correctly). I don't have much free time, but would be more than happy to contribute as much as I can. About SC2 specifically, how do I execute the +d3d9,tid command line? Keep in mind SC2.exe is a (child detached) process spawned by the 'parent' launcher (it's not so straightforward to execute it without launcher because of dlls and other stuff) so would it be like: wine +d3d9,tid SC2Switcher.exe (where SC2Switcher.exe is the launcher)? More information about the CPU usage. If during my tests I set the affinity of the executable (and subsequently all its threads) to a particular core I have to say that core gets fully used and FPS are better than general... apparently with multiple cores set the OS tries to balance the workload, thus decreasing the FPS. I'll be looking into dlls/wined3d/context.c as well. Thanks again, Cheers, Ps. When I said multiple threads directly invoke SleepEx, didn't mean it's a bad thing, just we have like 10+ threads which are inactive 95~99% of the time... and themselves set into this state I reckon. On 08/01/11 23:20, Stefan Dösinger wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > I am afraid some of your conclusions are not correct, more about that at the end of the mail. Basically most of the performance issues are caused by wined3d and the opengl driver requiring too much CPU time. That slows down the game as-is, and means that the GPU can never live up to its full potential(except if you have a really weak GPU). > > Unfortunately that is not one single bug, but rather 10-15 issues that sum up - and that is just covering the simplest possible rendering cases(just draw a few vertices), by adding extra stuff like textures, dynamic resources, render target switches, etc there will be many more. Fixing that will require a lot of work. > > I gave a talk about this topic at wineconf 2010, but unfortunately there was no recording and I even lost my slides. However, one thing survived: My very basic drawprim benchmark at https://84.112.174.163/git/?p=perftest;a=summary (self-signed certificate). With it you can benchmark how fast wine can dispatch draw calls and optimize this very basic functionality. Once this benchmark is fixed we'll have to write many more for other d3d features(shader changes, resource loading, texture changes, thread switching, etc etc etc). So it is a lot of work. Coding help is always welcome of course :-) > > Cheers, > Stefan > > Am 08.01.2011 um 19:34 schrieb Emanuele Oriani: >> My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. >> >> And, potentially they're using multi-threaded rendering as well. > Not as far as I know, but it is easy to check: Run the game with +d3d9,+tid and see if there are d3d drawing calls from multiple threads. If the game switches threads every now and then I wouldn't count it as multithreaded, if it constantly calls d3d from more than one thread it is multithreaded. >> I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. > No, not necessarily. The threads may be waiting for something, e.g. user input or network messages. Waiting threads don't have to be a bug, quite to the contrary. > >> This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). >> Could it be related to the rendering infrastructure? > I doubt it, I guess that depends on the cpufreq settings and your CPU. I'd expect cpufreq to clock down all but one core. > >> I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). >> During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. >> What happened with that? >> How is currently multi-threaded D3D rendering implemented in wine? > It is implemented pretty much in the way I outlined it in 2006. dlls/wined3d/context.c is responsible for multithreading, see context_acquire() and context_release(). > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.16 (Darwin) > > iQIcBAEBAgAGBQJNKPE3AAoJEN0/YqbEcdMwo9EP/jfJyeZlVx0AsHoxWLtZ77OV > ttBwCsIKs4IqJyJXgv8hNkeNQaDwk0QoJqxHkw/2AlGDO2sdaNR9EGbRMTmtH3OP > 8x+UeiEntJRP3zHamxRxCus6F86cEqfca9PV/PYiVLSCdIb7v2i091n4z6o2nk7t > b5yutdJsMx7jgH1QLCluS2dWs50SgFw/UXgs3nTGmg0vPefhDd4846uBKgi+yCL9 > Ol5RcRz8N8VxD3dJTCgjKt8kPxlIRFiIB9Og3F9T4UowmVMTiYKvuJ/TTz/jAgTe > zHzNqwNjSXScupRTFWV9EesJZKkYY5+GO0JVX1OXMWbeWG0vdmgaAsUhkLc4PHIF > kFUdAnx9uOlu//F5opL9LGzwiyTfsAXNVstEs7m1jCpBoed80OfZMFNY0wH5wN9h > 3c5kWIY1UoIaWkeMNLt+O3k6Xwsbfl0UAo6tgBxzx6sBff6MNxzCR6mZdz+hwhE7 > eekK3N+r5nvOp9yuCQTdm+PEoaH/uPRPTqt2Z8zhABeZMdrzjcXghWRc+7dkwFic > nw7qKEGoXW0zt+p58HAM8PbhMlhp6L784U3/Td11y7moXlcPh7MiaUcgYq1kBALf > nOaBinWgGmzhvU5ub6l6HwAMpZl6MEKn0GeHBUMBuLhEgYdXG/l7K4hxXgYvyulg > ySRGDcxFEqJezQPHNg9w > =diUG > -----END PGP SIGNATURE----- >

2 1

ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by maury loïc 09 Jan '11

09 Jan '11

Hello, it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. merci Loïc --- dlls/ntdll/cdrom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..185f397 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +#elif defined(__APPLE__) + return STATUS_SUCCESS; #else FIXME("not supported on this O/S\n"); return STATUS_NOT_SUPPORTED; -- 1.7.3.2

3 3

Re: [1/1][user32.dll]Adding Arabic Translation resources
by Yaron Shahrabani 09 Jan '11

09 Jan '11

Hi Nowres, just looked at your patch, there are some things missing, when you translate a dialog you should add EXSTYLE WS_EX_LAYOUTRTL. For example, instead of this header: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" It should be like this: +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +EXSTYLE WS_EX_LAYOUTRTL +CAPTION "إخ&تيار النافذة" +FONT 8, "MS Shell Dlg" Kind regards, Yaron Shahrabani <Hebrew translator> 2011/1/9 Nowres <nss.zpeedzter(a)gmail.com> > From a5d9d1e4599ce5a6c2f45df7948182401526f997 Mon Sep 17 00:00:00 2001 > From: Nowres Rafid <nss.zpeedzter(a)gmail.com> > Date: Sun, 9 Jan 2011 00:54:00 +0000 > Subject: [user32]Adding Arabic translation resources > > --- > dlls/user32/Makefile.in | 1 + > dlls/user32/resources/user32_Ar.rc | 89 > ++++++++++++++++++++++++++++++++++++ > 2 files changed, 90 insertions(+), 0 deletions(-) > create mode 100644 dlls/user32/resources/user32_Ar.rc > > diff --git a/dlls/user32/Makefile.in b/dlls/user32/Makefile.in > index 3dbde26..e33d83e 100644 > --- a/dlls/user32/Makefile.in > +++ b/dlls/user32/Makefile.in > @@ -51,6 +51,7 @@ C_SRCS = \ > wsprintf.c > > RC_SRCS = \ > + resources/user32_Ar.rc \ > resources/user32_Bg.rc \ > resources/user32_Ca.rc \ > resources/user32_Cs.rc \ > diff --git a/dlls/user32/resources/user32_Ar.rc > b/dlls/user32/resources/user32_Ar.rc > new file mode 100644 > index 0000000..5dd397c > --- /dev/null > +++ b/dlls/user32/resources/user32_Ar.rc > @@ -0,0 +1,89 @@ > +/* > + * User32 > + * Arabic language support > + * > + * Copyright 2010 Nowres Rafid > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +#include "resources.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_ARABIC, SUBLANG_DEFAULT > + > +SYSMENU MENU > +{ > + MENUITEM "إسترجا&ع", 61728 > + MENUITEM "تحري&ك", 61456 > + MENUITEM "حج&م", 61440 > + MENUITEM "تصغي&ر", 61472 > + MENUITEM "تكبي&ر", 61488 > + MENUITEM SEPARATOR > + MENUITEM "إغلا&ق\tAlt-F4", 61536 > + MENUITEM SEPARATOR > + MENUITEM "Wine معلومات حو&ل", 61761 > +} > + > +EDITMENU MENU > +{ > + POPUP "" > + BEGIN > + MENUITEM "إلغاء التغيير&ات", EM_UNDO > + MENUITEM SEPARATOR > + MENUITEM "ق&ص", WM_CUT > + MENUITEM "نس&خ", WM_COPY > + MENUITEM "لصق&", WM_PASTE > + MENUITEM "مس&ح", WM_CLEAR > + MENUITEM SEPARATOR > + MENUITEM "تحد&يد الكل", EM_SETSEL > + END > +} > + > +MSGBOX DIALOG 100, 80, 216, 168 > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | WS_POPUP | WS_VISIBLE | WS_CAPTION | > WS_SYSMENU > +BEGIN > + ICON "", 1088, 8, 20, 16, 16, WS_CHILD | WS_VISIBLE > + LTEXT "", 100, 32, 4, 176, 48, WS_CHILD | WS_VISIBLE | WS_GROUP | > SS_NOPREFIX > + PUSHBUTTON "موافق&", 1, 16, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إلغ&اء", 2, 64, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إنه&اء", 3, 112, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "إعادة المحاول&ة", 4, 160, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "تجاه&ل", 5, 208, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "نع&م", 6, 256, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "ك&لا", 7, 304, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > + PUSHBUTTON "أعد& المحاولة", 10, 352, 56, 40, 14, WS_CHILD | > WS_VISIBLE | WS_TABSTOP > + PUSHBUTTON "إستمرا&ر", 11, 400, 56, 40, 14, WS_CHILD | WS_VISIBLE > | WS_TABSTOP > + PUSHBUTTON "مس&اعدة", 9, 448, 56, 40, 14, WS_CHILD | WS_VISIBLE | > WS_TABSTOP > +END > + > +MDI_MOREWINDOWS DIALOG 20, 20, 232, 122 > +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "إخ&تيار النافذة" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LISTBOX MDI_IDC_LISTBOX, 5, 7, 222, 90, WS_VSCROLL | > WS_HSCROLL /* defined in mdi.h */ > + DEFPUSHBUTTON "مو&افق", IDOK, 75, 100, 35, 14 > + PUSHBUTTON "إلغ&اء", IDCANCEL, 120, 100, 35, 14 > +END > + > + > +STRINGTABLE > +{ > + IDS_ERROR "خطأ" > + IDS_MDI_MOREWINDOWS "نوا&فذ أخرى" > +} > -- > 1.7.1 > > > > >

1 0

Wine and D3D
by Emanuele Oriani 08 Jan '11

08 Jan '11

Hi wine developers, I'm a wine user and StarCraft II player. Unluckily Blizzard has left D3D only mode in win32 executable. The game doesn't use CPU/GPU at 100%, but on Linux what happens is that we have a lot less FPS than windows. To get some more FPS, like 50% more, we set one core (or all cores) to max frequency and then we set the 'affinity' of SC2.exe to that core only (to set the affinity I created a simple executable). This way performance is better indeed, but nowhere near windows. (I've opened a bug for this matter http://bugs.winehq.org/show_bug.cgi?id=24558 ). My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. And, potentially they're using multi-threaded rendering as well. I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). Could it be related to the rendering infrastructure? I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. What happened with that? How is currently multi-threaded D3D rendering implemented in wine? Thanks again, Cheers, Ema! ;-) Ps. Thanks to wine and a simple 'fprinft' I managed to easily instrument the SleepEx function and gather such valuable information. Now I'd like to do the same for D3D part, understand why the main renderer thread goes to sleep (or not) and if it goes to sleep actively or it's waiting on some mutex, or something else.

1 0

wiki work, wine64 portability issues
by Thomas Heckel 08 Jan '11

08 Jan '11

Hi all, I was just cleaning up some "Janitorial" sections on wine wiki. Now several questions arise: Just for interest I looked for a kind of wine64 portability guide to link to the http://wiki.winehq.org/PortabilityFixes . Are there any documents with source patterns which have been fixed to get Wine 64-bit ready? I think some of the listed janitorial tasks are already finished. E.g. there weren't any commits for 16bit separation for a longer time (Alexandre?). I don't have any overview if this tasks are really finished or if there are still some sections remaining? As a proposal to be discussed for the "wiki people": I would like to make a category "CategoryAbout" to collect the wiki articles which are (should) directly linked from the about page on the winheq.org site. I think this would be a good first way to solve the still existing old/duplicated pages between wiki and winheq.org pages. What do you think? Thanks in advance, Thomas

1 0

Re: ws2_32: Add default case for family in debugstr_wsaioctl.
by Juan Lang 08 Jan '11

08 Jan '11

Hi Gerald, > This mimicks what we already do a few lines above for buf_type. It's also unneeded: switch(ioctl & 0x18000000) There are only 4 possible combinations of ioctl & 0x18000000. Three are covered in this switch statement, and the fourth is eliminated due to the outer switch statement. You'd be adding dead code. --Juan

2 1

Wine and D3D
by Emanuele Oriani 08 Jan '11

08 Jan '11

Hi wine developers, I'm a wine user and StarCraft II player. Unluckily Blizzard has left D3D only mode in win32 executable. The game doesn't use CPU/GPU at 100%, but on Linux what happens is that we have a lot less FPS than windows. To get some more FPS, like 50% more, we set one core (or all cores) to max frequency and then we set the 'affinity' of SC2.exe to that core only (to set the affinity I created a simple executable). This way performance is better indeed, but nowhere near windows. (I've opened a bug for this matter http://bugs.winehq.org/show_bug.cgi?id=24558 ). My fear is that Blizzard has introduced some sort of FPS limit and probably wine doesn't cope very well with that. And, potentially they're using multi-threaded rendering as well. I've done some thread analysis and apparently the many threads the game execute stay in sleep (they actively invoke SleepEx) for 95% of the time, which is very strange. This is why if we leave the CPU frequency in 'Ondemand' mode it goes to 800MHz (or the lowest frequency). Could it be related to the rendering infrastructure? I know OpenGL is essentially mono-threaded (I've used it for quite a bit in the past years). During some research I came across a Stefan's email from July 2006, were he was proposing the right thing (imho) to do to support multi-threaded D3D: a GL rendered thread per device/buffer. What happened with that? How is currently multi-threaded D3D rendering implemented in wine? Thanks again, Cheers, Ema! ;-) Ps. Thanks to wine and a simple 'fprinft' I managed to easily instrument the SleepEx function and gather such valuable information. Now I'd like to do the same for D3D part, understand why the main renderer thread goes to sleep (or not) and if it goes to sleep actively or it's waiting on some mutex, or something else.

1 0

Forum/mailing list link broken?
by Rosanne DiMesio 07 Jan '11

07 Jan '11

Replies from the mailing list are not showing up on the forum in some cases. A user mentioned it in this thread: http://forum.winehq.org/viewtopic.php?t=10782. I checked the mailing list archives, and there are other threads that have replies from mailing list users that never appeared on the forum. -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 5

Re: [PATCH 3/2] msvcrt: Implement _wcslwr_s
by Eric Pouech 07 Jan '11

07 Jan '11

Le 07/01/2011 15:42, Detlef Riekenberg a écrit : > based on _strlwr_s > > This let Radiotracker go further > > > /********************************************************************* > + * _wcslwr_s (MSVCRT.@) > + */ > +int CDECL _wcslwr_s(WCHAR *str, MSVCRT_size_t len) > +{ > + WCHAR *ptr = str; > + > + if (!str || !len) > please use the MSVCRT_CHECK_PMT as done in the other _s msvcrt's functions A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: Wine for Solaris 10 x86 roadblocks
by seeger＠cise.ufl.edu 07 Jan '11

07 Jan '11

+------ "Ron Whites" wrote (Fri, 7-Jan-2011, 12:23 -0600): | | I downloaded Solaris 10 x86 on 12/6/2010 (how do I know the build/ver?) NB: SunOS 5.N (plus networking, windowing, etc.) <=> Solaris N. On a SPARC box (most easily available Sol10): % uname -a SunOS <hostname> 5.10 Generic_141444-09 sun4v sparc SUNW,SPARC-Enterprise-T5220 % cat /etc/release Solaris 10 10/09 s10s_u8wos_08a SPARC Copyright 2009 Sun Microsystems, Inc. All Rights Reserved. Use is subject to license terms. Assembled 16 September 2009 (BTW, "wos" stands for "wad of stuff".) And on an x86 system running Solaris 11 Express: % uname -a SunOS <hostname> 5.11 snv_151a i86pc i386 i86pc % cat /etc/release Oracle Solaris 11 Express snv_151a X86 Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. Assembled 04 November 2010 (BTW, "snv" stands for "Solaris next version".) Do note that packaging and patching have changed radically in OpenSolaris and Solaris 11, and that free access to security patches is no more. Solaris 11 Express may have better driver support for your hardware. You might want to search for the hardware compatibility list, though beware that it may not be perfectly up to date, as it depends on user submissions. Also, there is something of a fork from OpenSolaris, called OpenIndiana, which is another option to consider. The Solaris story is a bit complicated, beyond the scope of this reply. 8-) | ./tools/wineinstall again. | this time I received a line 149 syntax error Most random software these days isn't regularly maintained on Solaris. In this case, most shell scripts require a POSIX standard shell, though bash-specific extensions frequently creep in. On Solaris 10 /bin/sh is the old SVR4 Bourne shell, while on Solaris 11 it is ksh93. The /usr/bin utilities are legacy versions on Solaris 10, while the standards compliant utilities are in /usr/xpg4/bin. On Solaris 11, /usr/gnu/bin is placed first on the default user path. "getconf PATH" is the standard method to obtain a standard PATH, but it seems that no one observes it, and its output hasn't been updated for Solaris 11 (which also has /usr/xpg6/bin). So, generally, scripts will be problematic. | A bug report at | http://wine.1045685.n5.nabble.com/Bug-19321-New-Syntax-error-during-inst | allation-td1605805.html | | That says Don't use 'wineinstall script', do './configure && make | install' instead. Yup. | Solaris10 doesn't have a make pre-installed and I can't find where I can | get one, so I am presently stuck again. A full install will have a make, but it will be in /usr/ccs/bin/, which is included in the output of "getconf PATH". However, the Sun compilers are a separate install. But, instead you will need gcc and gnu make to compile wine. These might already be in /usr/sfw/bin (Solaris 11 has them in /usr/gnu/bin, with symlinks to them in /usr/bin, e.g. "gmake"). Precompiled packages are available at sunfreeware.com, opencsw.org and blastwave.org, as well as sunfreepacks. | Sure seems a lot of road blocks so far, can anybody offer some | information to get me over the hurdles? The OpenSolaris releases from Sun were geared to be both more complete with some popular software and more familiar to Linux users. With the Oracle acquistion there are no more of these, but the Solaris Express preview releases are available with more restrictive licensing. I can send configure options for Solaris 11, but I have never built wine on Solaris 10. HTH, Chuck

1 0

Wine for Solaris 10 x86 roadblocks
by Ron Whites 07 Jan '11

07 Jan '11

I am a newbie to Solaris as well as Wine. I downloaded Solaris 10 x86 on 12/6/2010 (how do I know the build/ver?) and loaded it in a Virtual Machine on my Windows 7 Desktop. Then recently I have been trying to get Wine om Solaris 10 working so far with no success. I downloaded Swine-sol10-1.1.40.7z from http://www.sunfreepacks.com/ but I have not been able to unpack this by using "p7zip -d Swine-sol10-1.1.40.7z" on my solaris. It returns immediately to the terminal prompt and it apparently does nothing but gives no error. So at http://www.winehq.org/announce/1.1.19 I found another Wine-1.1.19.tar.bz2 I used bunzip and then tar to get just Wine-1.1.19 I then did "./tools/wineinstall and encountered an error saying I couldn't/shouldn't install under ROOT so after making a user account via useradd I did ./tools/wineinstall again. this time I received a line 149 syntax error looking on the web I found A bug report at http://wine.1045685.n5.nabble.com/Bug-19321-New-Syntax-error-during-inst allation-td1605805.html That says Don't use 'wineinstall script', do './configure && make install' instead. Solaris10 doesn't have a make pre-installed and I can't find where I can get one, so I am presently stuck again. Sure seems a lot of road blocks so far, can anybody offer some information to get me over the hurdles?

2 1

Re: {USB}Fail to patch 0002-Re-generate-some-files.txt
by James Mckenzie 07 Jan '11

07 Jan '11

Qian Hong <fracting(a)gmail.com> wrote: >Sent: Jan 6, 2011 9:56 PM >To: James McKenzie <jjmckenzie51(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: {USB}Fail to patch 0002-Re-generate-some-files.txt > >Dear James, thanks for reply. I think the current vesion of this patch is >for wine1.3.10, the upload date is Dec 26. >I'll try to attempt it. > I had not checked this as the last version was posted some time ago. I'll have to look at it and see if it applies to the soon to be released (if not released by the time I get to my Wine build machine) 1.3.11. James McKenzie

1 0

{USB}Fail to patch 0002-Re-generate-some-files.txt
by Qian Hong 07 Jan '11

07 Jan '11

Dear all, After checkout latest wine from git, I tried to apply the USB support patches, but something is wrong. Checking out from the WineHQ Git repository:(Follow GitWine wiki) $git clone git://source.winehq.org/git/wine.git ~/wine-git $cd ~/wine-git Get the wine usb patches: (Follow wine USB wiki) ftp> cd pub/people/amorozov/usb/current ftp> get 0001-Add-support-of-native-Windows-drivers-for-USB-tokens.txt ftp> get 0002-Re-generate-some-files.txt Apply the patches: $git am 0001-Add-support-of-native-Windows-drivers-for-USB-tokens.txt Applying: Add support of native Windows drivers for USB tokens. $git am 0002-Re-generate-some-files.txt Applying: Re-generate some files. error: patch failed: configure:11442 error: configure: patch does not apply error: patch failed: configure.ac:2775 error: configure.ac: patch does not apply Patch failed at 0001 Re-generate some files. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Could anyone tell me what did I have done wrong? Many thanks! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

2 2

Wine and Fontconfig
by Yaron Shahrabani 06 Jan '11

06 Jan '11

Elad, an Hebrew user suggests: In several Wine apps Hebrew is displayed as square glyphs since there are no builting Hebrew glyphs in Wine's font (bug #23537). The question is why does Wine use the internal font as the default? The easier solution would be to use the "system" fonts as configured in fontconfig. Windows can have a custom font as well so it shouldn't cause and difficulty. This way we won't have to look for a font editing specialist that will add glyphs to wine's fonts. This problem can affect many languages as well, not just Hebrew, that lacks the required glyphs. Using the fonts from fontconfig might solve the problem and will lead to a better integreation. The fonts in Wine apps will look just like the fonts used by the rest of the apps in the system. Kind regards, Yaron Shahrabani <Hebrew translator>

2 1

Unable to download USB patch from ftp://ftp.etersoft.ru/pub/people/amorozov/usb
by Qian Hong 06 Jan '11

06 Jan '11

Dear All, While trying usb device in wine, I follow this page : http://wiki.winehq.org/USB , The Official Wine Wiki. It says, "Some functions used by USB drivers are implemented on top of libusb-0.1/1.0 by Alexander Morozov from Etersoft (amorozov(a)etersoft.ru). Now only some USB software protection tokens are working. Patches: ftp://ftp.etersoft.ru/pub/people/amorozov/usb" But I can't connect to ftp.etersoft.ru , ping ftp.etersoft.ru : PING updates.etersoft.ru (212.176.200.18) 56(84) bytes of data. 64 bytes from legirus.ru (212.176.200.18): icmp_req=1 ttl=40 time=371 ms 64 bytes from legirus.ru (212.176.200.18): icmp_req=2 ttl=40 time=371 ms 64 bytes from legirus.ru (212.176.200.18): icmp_req=3 ttl=40 time=371 ms Port 21 is open. Could anyone give me some tip? Thanks! -- Regards, Qian Hong - Send from Ubuntu http://www.ubuntu.com/

2 2

New winetricks 20110105: improved download error recovery, added first-run optin dialog. New winetricks 20110105-alpha: menu divided into categories, added 35 games
by Dan Kegel 06 Jan '11

06 Jan '11

Another month, another Winetricks - or, rather, two new Winetricks. New version 20110105 has only two notable changes: 1. it will retry a corrupt download for you (this should get rid of most cryptic warnings about needing to rename a file and retry), 2. a first run dialog now asks whether you'd like to help winetricks development by reporting usage stats. You should only see this dialog once (and only if you're using the gui, and only if you're using zenity). This has been very helpful already, as people have been running it from svn. Please let me know what you think of it. Online as always at http://kegel.com/wine/winetricks Experimental new version 20110105-alpha has a few further changes: 3. The menu is now broken up by category; there's now a top-level menu which gives you a choice of category (dll, font, app, or setting). This ought to make the menu a little less overwhelming. Let me know what you think of the new menu navigation. 4. There's now a progress dialog during downloads in gui mode. 5. It should work better when the user has removed the Z: drive. 6. It's been refactored to make adding new verbs much easier (you no longer have to edit the script in multiple places to add a verb, and you can even put verbs in external files). 7. Added 35 games. (A bunch more remain to be ported from wisotool.) 8. Removed (or, rather, haven't ported yet) a number of less-common verbs. The statistics gathered by the new version will tell us which of the remaining verbs to port first. The experimental version is only at http://kegel.com/wine/winetricks-alpha SVN and bug tracker are online at http://winezeug.googlecode.com Changes in version 20110105: Dan Kegel: - remove old synonym dotnet2 for dotnet20 - mpc: remove broken call to append_path - handle 'winetricks win31 vista' properly - make dotnet20sp2 warn that it's broken. Don't list in menu. - w_download: don't redownload if no expected checksum given. Also remove == typo from r2207. - don't declare checksum error unless, y'know, there was a checsum error - as favor for etersoft, avoid referring directly to zenity/kdialog/xmssage to avoid pulling them all in as dependencies when building a package - automatically retry download once if cached file has wrong checksum - ie8: avoid writing to / (just like ie7 fix). Don't bother running ie8 when finished; point user to workaround instead. Also move a verb that got sandwiched between ie6 and ie7. - ie7: when / is writable as on macosx, move z: out of the way during ie7 install to avoid scribbling temporary files in /. Had to run with WINEDEBUG=warn+heap to avoid memory bugs in setupapi? - when reporting usage, also report version. - in zenity gui case, ask user on first run whether to opt in to usage reporting. - on MacOS X, put cache in /home/dank/Library/Caches - delete msxml6.dll before running installer. Fixes bug 211. - tahoma: don't download to top of cache - finish renaming WINETRICKS_UNIXQUIET to W_UNATTENDED_DASH_Q - make cabextract quiet Austin English: - add win31 verb (needed internally by ole2)

5 6

RE: WyldBot
by Greg Geldorp 06 Jan '11

06 Jan '11

From: wylda(a)volny.cz > WyldBOT1 and WyldBOT2 are not VM, but true physical older-machines > made only for wine-testing. This is great, it's good to have physical machines for testing too. > I used to run WylBOT 3x per week, but there were no changes or > effort to fix things, so i reduced the WylBOT run to once a week Would you be willing to consider some integration with TestBot? It isn't always immediately clear what the root cause of a failure is, so sometimes a bit of experimentation is required. Having to experiment by submitting official patches to wine-patches isn't an ideal solution. If it were possible to submit patches via TestBot then I think more people would be interested in fixing failures. It would require WyldBOT to be available at predictable times (24x7 would be best, but I guess "during the weekend" would work too). We'd have to find some way to exchange files and start a job on WyldBOT in a secure way, but that seems doable. Greg.

3 2

Re: [PATCH 1/4] server: Make it possible to report many filesystem events
by Alexandre Julliard 06 Jan '11

06 Jan '11

Piotr Caban <piotr(a)codeweavers.com> writes: > diff --git a/server/protocol.def b/server/protocol.def > index 6245f4c..29a4c7a 100644 > --- a/server/protocol.def > +++ b/server/protocol.def > @@ -1449,6 +1449,7 @@ enum char_info_mode > obj_handle_t handle; > @REPLY > int action; /* type of change */ > + int next_length; /* next file name length */ > VARARG(name,string); /* name of directory entry that changed */ > @END Returning the next length won't work, because there's no guarantee that it will be the same file that we return the next time around, there can be multiple threads watching that handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw/tests: Force some tests to pass on XP/Win2003 Wow64
by Stefan Dösinger 06 Jan '11

06 Jan '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'd say the D3DPTEXTURECAPS_PERSPECTIVE tests can be removed. They are here to demonstrate some behavior the game RollCage depends on. Newer drivers show some different behavior, I suspect they "fix" rollcage with an app specific hack. Am 06.01.2011 um 13:08 schrieb Greg Geldorp: > --- > dlls/ddraw/tests/d3d.c | 23 ++++++++++++++++++----- > 1 files changed, 18 insertions(+), 5 deletions(-) > > > > <0001-ddraw-tests-Force-some-tests-to-pass-on-XP-Win2003-W.patch> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) iQIcBAEBAgAGBQJNJd5KAAoJEN0/YqbEcdMwq5cP/RGuOU0wpkzgxjdXLSkvI4R+ X8LNhLJOwRYJeQr8i2oYWvJ96VopronT9ZsIBbQErarHCY/CMEaMpUgUPQ01ko9K r5rrL/hBHSilmVcKJ8ToTKOgclnIfdIJDTJRR6nESSaBJsFuL6iH3RwD45nNeNOC jnYBscvFhgLJYOKFcdPGcnFXCzWNhJLZD9BXFOXsH5DhEaI/neB7aGiTSMpiRTbd SZmCWydkEV22Rd4h2JvwuxKFxN2ANZKkIH1W83sdOvKhEsSZM/mPDu7kTtLuUrS9 1lohtr1L/ehFXb2+NKUj+J+KZCp8sYw9CFD3kGN+/teIE41E0wzvih8kW+BISRkS LgwvvSwODly1K8SNduSWYad5rbKNqsHbSnLa+M18EkqOuDzjm4gFF7iyXmmLwvjm zKP8GrbYPQg4kITCqooO05xtmtPUH4tFik1ZIT7uj/OInPqUaDCf8k1SAQQfN9Jz EArZAaxmesNE9tRGuVM2s2HfEGco1fgmeJm+abCfZng89l26T30SMApJuw3e5kDq RBYQf8VcHgg1Jnzt4YRUFlwiYSMYBqVUow5mHu7lEphil5iKEEcf0ZJFtSpZHtuU GHFe2gMix91ren1GpRVSFs7k4QoNyBXhp6r4xOjgS1KINjxlmFsN6ex+vKRMbedC FTYVe/2U/ecfL2PE/u4D =Y3ex -----END PGP SIGNATURE-----

1 0

Test timeouts
by Greg Geldorp 06 Jan '11

06 Jan '11

Although the number of timeouts in msi tests has dropped considerably after Hans decided to do something about them, they're unfortunately not completely gone. It seems that the remaining timeouts have a strong dependency on the environment. It's possible to tweak the environment (disable system restore points, for TestBot I found it makes a difference on which physical disk the virtual disk files are located) but the goal should be to have the tests run consistently on whatever the environment happens to be. Perhaps it's time to accept that some tests in some environments can simply take longer than the current winetest.exe timeout value of 2 minutes. I can think of 3 possible solutions: 1) Simply increase the timeout value in winetest.exe. Extremely simple to implement, but perhaps not very elegant. 2) Pass the timeout value as a command line parameter to winetest.exe. This has the advantage that the timeout can be adjusted for the environment (creating a system restore point on an older machine with lots of stuff installed will take longer than creating a system restore point on a fresh high-end machine), it does put the responsibility for determining a suitable timeout on the shoulders of the tester. That's probably no problem for regular testers, but we can't expect the occasional tester to do this. 3) Have a variable timeout per testset. One possible way to implement this would be to have the test executables recognize an additional command line parameter "--timeouts". When called with this parameter, the test executable tries to load a resource string containing a list of testset-specific timeout values, for msi it could be something like "action:180;install:180;msi:300". Testsets not included in the resource string would get the default timeout of 120 sec, if the resource string is not present all testsets would get that default. I believe this can be implemented in wine/test.h, so the only change required to the tests themselves would be to add the resource string to tests that require a different timeout. Instead of calling the test executable with the "--list" command line parameter winetest.exe would call it with "--timeouts", which would produce a list of the testssets with their timeouts. The advantage of this method is that it's quite flexible. It is a bit more work to implement. Personally, I have a slight preference for solution 3) but I can live with the others too. Obviously I'm willing to implement whatever solution we choose. Greg.

4 6

RE: msi/tests: Mark a test result on some old Wow64 platforms as broken.
by Greg Geldorp 06 Jan '11

06 Jan '11

Hi Hans, > + RegDeleteKeyA(prodkey, ""); Since prodkey was possibly opened with KEY_WOW64_64KEY, you'll probably need delete_key() here. Greg.

1 0

Re: [PATCH 2/2] shell32: Don't fill SHITEMID data with random values if file doesn't exist
by Alexandre Julliard 06 Jan '11

06 Jan '11

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -538,6 +538,8 @@ static char* UNIXFS_build_shitemid(char *pszUnixPath, LPBC pbc, void *pIDL) { > if (stat(pszUnixPath, &fileStat)){ > if (must_exist || errno != ENOENT) > return NULL; > + > + memset(&fileStat, 0, sizeof(struct stat)); That may not be random, but it's still wrong values. It seems to me that this is what the IFileSystemBindData should be used for. -- Alexandre Julliard julliard(a)winehq.org

1 0

"N" shows up as missing on the translations status website
by Sven Baars 05 Jan '11

05 Jan '11

Hey all, since today, the "N" string shows up as missing on http://source.winehq.org/transl/ even though it's there in the po file. This happened for both xcopy and cmd. In the po file it says #: cmd.rc:257 xcopy.rc:41 msgctxt "No key" msgid "N" msgstr "N" so this is probably because the string is present in both cmd and xcopy. Just thought I'd let you know. Sven

2 1

/ is writable on mac... leading to lots of awkward msi droppings?
by Dan Kegel 05 Jan '11

05 Jan '11

Quentin Paris informs me that the root directory is user-writable on MacOSX (shudder), which means our beloved z: mapping leads to lots of garbage directories named e.g. /fd91216cc2ce81eb2ce16a058619 after running msi installers. Is this something Wine's msi could avoid doing?

4 4

WyldBot
by wylda＠volny.cz 05 Jan '11

05 Jan '11

Hi, i take the chance to make this info publicaly aware, so adding wine-devel > Hi, > your WyldBot has some Audio/Video issues in it's > XP machines no other machines have, in which VM do > they run? WyldBOT1 and WyldBOT2 are not VM, but true physical older-machines made only for wine-testing. WyldBOT1 has more OS so little explanation here: * WyldBOT1-ie6 was cleanlly installed, patched and never run wine-test (to avoid broken registry thing by wine-testsuite sometime ago), than made image of that partition * for WyldBOT1-ie7, i restored image of WyldBOT1-ie6 and installed IE7 on top of it * for WyldBOT1-ie8, i restored image of WyldBOT1-ie6 and installed IE8 on top of it * for WyldBOT1 64bit edition i did exactly same installation steps like in 32bit * for WyldBOT2 i did exactly same installation steps like in WyldBOT1-ie6, but runs on different HW box (it's not the same image like WyldBOT1-ie6, only same installation steps) So things works that way, that when i power up that machine and boot into WyldBOT-recovery and then * recovery takes the first image from second HDD * changes boot.ini sequence * reboots and then boots into WyldBOT1-ie6 * WyldBOT1-ie6 waits 120sec to finish all services startup and not disturb winetest * downloads the wine test suite from FTP + some testing video file etc. * it does the winetesting * changes boot.ini and to boot into Wylbot recovery * Wylbot recovery takes another image * and so on and after last image the machine si turned off This Chrismas time (after 8months) Wylbot was restored just for windows update and updated images were store again. Once on wine-devel, i noticed some speculation, that it uses old drivers, so nvidia drivers got updated too on all WyldBOT1. I used to run WylBOT 3x per week, but there were no changes or effort to fix things, so i reduced the WylBOT run to once a week (i do my best not to miss friday's release, but sometime i run it on saturday/sunday. Maybe when the relese would be around 17h UTC, i could make it friday-regular ;) As WyldBOT2 was unlucky and did not get those fresh updates as his brother WyldBOT1, i didn't turn it on recently. WyldBOT1's HW: MB: Asus P5K-E WiFi AP Bios rev. 1305 Intel Core 2 Quad Processor Q9550 sSpec Number: SLB8V CPU SPeed: 2.83GHz Bus speed: 1333MH z L2 Cache size: 12MB Package Type: LGA775 Technology: 45nm 8GB RAM Kingston HyperX DDR2 2x KHX8500D2T1K2/4G (DDR800), CAS: 5-5-5-18 Nvidia 8600GT latest driver 260.99, latest DirectX June2010 redist v9.29.1962 (2010-06-07) Soundcard Asus's onboard (i guess it uses "SoundMAX ADI Audio Driver") Some printers Wheel wingman formula force gp2 Wheel Microsoft (thurstmaster??) If interested in details let me know, i can look closer at home. > Btw: you can use the winetest option "-i" to add a > description of the machine... That's a pity, that i didn't have this info one week back, when i did the image jobs. But maybe it's stored on the FTP in control file, so won't be a hard job - don't know now. > > Best Regards, André Hentschel PS1: On Monday i noticed, that other machines have D3Dcompiler_43 installed, but mine's not even if i cleanly installed June's 2010 DirectX. Do you guys use for testing those messy free-dll downloads??? PS2: Wylbot2 has Intel Graphic Card and used to have completely different 2D/3D?? testing-pictures (those red, greens,... flashing shapes). But i didn't find a time to report the differences.

1 0

Re: d3dcompiler_43/tests: fixed nonconformant C string literals in HLSL test suite
by Henri Verbeet 05 Jan '11

05 Jan '11

On 4 January 2011 22:25, Travis Athougies <iammisc(a)gmail.com> wrote: > + "float4 test(float x: TEXCOORD0): COLOR" > + "{" > + " const float pi2 = 6.2831853;" > + " float calcd_sin = (sin(x * pi2) + 1)/2;" > + " float calcd_cos = (cos(x * pi2) + 1)/2;" > + " return float4(calcd_sin, calcd_cos, 0, 0);" > + "}"; Some newlines probably wouldn't hurt.

1 0

Re: kernel32/tests: Don't test function directly when reporting GetLastError()
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8130 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2KPROSP4 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === WXPPROSP3 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2K3R2SESP2 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === WVISTAADM (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2K8SE (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PRO (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PROX64 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PROX64 (64 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting

1 0

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8127 Your paranoid android. === WVISTAADM (32 bit clipboard) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

re: include: Add ONCE macro for making debug output less noisy
by Dan Kegel 04 Jan '11

04 Jan '11

Alexandre wrote: >> +#define WINE_ONCE(do_once) ... > > I don't think that buys anything over spelling it out explicitly. It makes it easier to grep for, which might be useful if you want to find all the places it's used to throttle messages that shouldn't be happening in the first place.

1 0

Re: include: Add ONCE macro for making debug output less noisy
by Alexandre Julliard 04 Jan '11

04 Jan '11

Sven Baars <sven.wine(a)gmail.com> writes: > @@ -250,6 +250,12 @@ static inline const char *wine_dbgstr_longlong( ULONGLONG ll ) > #define WINE_DPRINTF wine_dbg_printf > #define WINE_MESSAGE wine_dbg_printf > > +#define WINE_ONCE(do_once) \ > + do{ static int wine_once_var; \ > + if (!wine_once_var) { \ > + wine_once_var = 1; \ > + do_once; } } while(0) I don't think that buys anything over spelling it out explicitly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemaker: Add def file support
by Alexandre Julliard 04 Jan '11

04 Jan '11

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2480,7 +2498,9 @@ sub generate_project_files($) > my $canon=canonize("@$target[$T_NAME]"); > $canon =~ s/_so$//; > > - if (@$target[$T_TYPE] == $TT_DLL) { > + if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & $TF_HASDEF)) { > + print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:%.dll=lib%.def)\n"; > + } elsif (@$target[$T_TYPE] == $TT_DLL) { There's no reason to add a lib prefix. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: Parital Implement InitiateSystemShutdown(Ex) (try 2)
by Alexandre Julliard 04 Jan '11

04 Jan '11

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -232,6 +233,10 @@ BOOL WINAPI InitiateSystemShutdownExA( LPSTR lpMachineName, LPSTR lpMessage, > DWORD dwTimeout, BOOL bForceAppsClosed, BOOL bRebootAfterShutdown, > DWORD dwReason) > { > + if (!lpMachineName && !lpMessage && !dwTimeout) > + ExitWindowsEx(bRebootAfterShutdown ? EWX_REBOOT : 0 | > + bForceAppsClosed ? EWX_FORCE : 0, > + dwReason); > FIXME("%s %s %d %d %d %d\n", debugstr_a(lpMachineName), > debugstr_a(lpMessage), dwTimeout, bForceAppsClosed, > bRebootAfterShutdown, dwReason); I don't think you want to call user32 functions here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Revert vertex blend capabilities patch
by Stefan Dösinger 04 Jan '11

04 Jan '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yep, the patch(f41fdb22...) should be reverted. As I explained on IRC, the correct approach is to implement a replacement shader for the vertex pipeline and implement vertex blending in it. Henri has a rebased version of my ARBvp experiments from 2008. Am 04.01.2011 um 05:42 schrieb Jeremy Chin: > My previous patch was accepted as f41fdb225cf1e1df494237664ce92e51179f3725, though Henri Verbeet pointed out it was incorrect. stefan on IRC warned that announcing blend capabilities without supporting them may cause issues, hence the revert.<0002-Revert-wined3d-Update-detection-of-vertex-blend-ca.txt> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) iQIcBAEBAgAGBQJNIxBHAAoJEN0/YqbEcdMw8boQAIy4oDcaDv90bSyxMZJ4HwZy q/bKznK807Rt6UmL8p4OplFLdAOF+mMnqDmNT9vZxr5k7rWC3GDtW+5nohKwyl74 rpQI71lSTo1lixjPP0t+t2bASl9mQ/Gb2AfPqiFsG0dZmKxwP7aa/25h01ZucHTc c39j234nXxQ1po5j00PoaA0Ya5yeCQ3edFdBMSPorPTdYLVGuHWSA4qdVQdf6mq4 /luSIkMp/MUygqEMCvT9/elaRjCG1dJ9RE4JBXOCtK5CgkCxN+MdnVrTguGeWTtc UV2rwNTZA+4KZouegDQPeHb2qKoQRuNWLdM07/yvCE5rVDJBiAem+MYOjJ3LHsP2 nB3Vfff2zmC6mp+544aQIKFtu0RC2IVU+AbcdmRV6yDwbNK3/wZb3ZV1LcOZ5Z1h 9m5uINreq1R54FnjA1xaYPmWMutN8jVYn2SBPfLA11dKh0sFwsjS4PkUPH1fbAOi nmjwtd7r1z6AyoaP12XIrXGkTNSx8bMHQ9twfWq4D8IqbefMYtrkh896F/wfTIQI nT0FGeDL3gCafpW+wkGQT78tVMZXCAIx2rb+C3sZd/KcQzVCMcgbfFY6R5LnrYVf k+M6CsM0ZyAfIyMpkEFwruMAV0zYQ6NAMhFL4muiyRjY4UA2YvtLhPrNjOp5LAi0 EfbvhcGcDQeh4W45ljuv =HOqP -----END PGP SIGNATURE-----

1 0

Re: configure: Use -Wundef if supported by the compiler.
by Alexandre Julliard 04 Jan '11

04 Jan '11

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I verified this does not cause any warning on FreeBSD 8.1 test > builds, and all the tools like bison and flex in somewhat current > versions. It's broken here with bison 2.4.1: make[1]: Entering directory `/home/julliard/wine/wine/libs/wpp' gcc -m32 -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wundef -Wwrite-strings -Wpointer-arith -Werror -g -O2 -o ppy.tab.o ppy.tab.c ppy.tab.c:336:6: error: "YYENABLE_NLS" is not defined ppy.tab.c:910:6: error: "YYLTYPE_IS_TRIVIAL" is not defined make[1]: *** [ppy.tab.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/9] kernel32: Improve parameter validation for WriteConsoleInputW. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8097 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

2 1

Re: [9/9] kernel32: Improve parameter validation for FillConsoleOutputAttribute. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8104 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [8/9] kernel32/tests: Add tests for FillConsoleOutputCharacterA. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8103 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [9/9] kernel32: Improve parameter validation for FillConsoleOutputAttribute. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8104 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [6/9] kernel32: Improve parameter validation for WriteConsoleOutputAttribute. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8101 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [5/9] kernel32: Improve parameter validation for WriteConsoleOutputCharacterA. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8100 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [3/9] kernel32: Improve parameter validation for WriteConsoleInputA. (try 3)
by Marvin 04 Jan '11

04 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8098 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

How to find out locking problem
by wylda＠volny.cz 03 Jan '11

03 Jan '11

Happy New Year! i notice, that since 1.3 i get quite offten locking issue. It looks like, that last OK version was 1.2-rc7. This problem happens in Bioshock on load/save, but i noticed that other users have same problem with games on the same game engine. Could someone help me, what should i do in this lockin-case as first, please? Thanks in advance! Regards W. ... fixme:thread:SetThreadIdealProcessor (0x734): stub err:ntdll:RtlpWaitForCriticalSection section 0x7deac200 "x11drv_main.c: X11DRV_CritSection" wait timed out in thread 001a, blocked by 0041, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x5486584 "?" wait timed out in thread 0045, blocked by 0044, retrying (60 sec)

2 1

Re: [PATCH] wine: pass $LDFLAGS also to $LDDLLFLAGS
by Alexandre Julliard 03 Jan '11

03 Jan '11

Marcus Meissner <marcus(a)jet.franken.de> writes: > This is helpful if you need to pass in special LDFLAGS, like -flto. LDFLAGS are already specified on the link command line, I don't think they should get hardcoded into winegcc. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: How to find out locking problem
by Dan Kegel 03 Jan '11

03 Jan '11

Sometimes it helps to run winedbg from another window and get the stacks of all running processes with the command bt all With luck, you can then see which two code paths are competing for the lock.

5 6

Re: [02/13] kernel32: Avoid checking the output parameter for GetNumberOfConsoleInputEvents.
by Alexandre Julliard 03 Jan '11

03 Jan '11

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -991,9 +991,7 @@ BOOL WINAPI GetNumberOfConsoleInputEvents( HANDLE handle, LPDWORD nrofevents ) > req->handle = console_handle_unmap(handle); > req->flush = FALSE; > if ((ret = !wine_server_call_err( req ))) > - { > - if (nrofevents) *nrofevents = reply->read; > - } > + *nrofevents = reply->read; That sort of change is in general not a good idea. Most of these functions have an exception handler on Windows so NULL pointers get caught. Even if the handler has been removed in Win7, that doesn't mean there aren't apps that depend on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] urlmon: Add some error handling to the http protocol. (try 2)
by Jacek Caban 03 Jan '11

03 Jan '11

Hi David, The patch looks much better now, but needs a bit more. BTW, this would be better tested on protocol level (like we do in protocol.c) than moniker binding, but this will do too. On 1/3/11 3:47 AM, David Hedberg wrote: > Try 2: Better tests, among other things. > --- > dlls/urlmon/http.c | 173 +++++++++++++++++++++++++++++++++++++- > dlls/urlmon/tests/url.c | 211 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 373 insertions(+), 11 deletions(-) > > @@ -2546,11 +2670,19 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) > SET_EXPECT(QueryInterface_IHttpNegotiate); > SET_EXPECT(QueryInterface_IWindowForBindingUI); > SET_EXPECT(QueryService_IWindowForBindingUI); > + SET_EXPECT(GetWindow_IWindowForBindingUI); > SET_EXPECT(BeginningTransaction); > SET_EXPECT(QueryInterface_IHttpNegotiate2); > SET_EXPECT(GetRootSecurityId); > SET_EXPECT(OnProgress_FINDINGRESOURCE); > SET_EXPECT(OnProgress_CONNECTING); > + if(flags& BINDTEST_INVALID_CN) { > + SET_EXPECT(QueryInterface_IHttpSecurity); > + SET_EXPECT(QueryService_IHttpSecurity); > + SET_EXPECT(OnSecurityProblem); > + if(SUCCEEDED(onsecurityproblem_hres)) > + SET_EXPECT(GetWindow_IHttpSecurity); > + } > } > if(!no_callback) { > if(test_protocol == HTTP_TEST || test_protocol == HTTPS_TEST || test_protocol == FTP_TEST > @@ -2600,6 +2732,47 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) > ok(hres == INET_E_DATA_NOT_AVAILABLE, > "IMoniker_BindToStorage failed: %08x, expected INET_E_DATA_NOT_AVAILABLE\n", hres); > ok(unk == NULL, "istr should be NULL\n"); > + }else if(flags& BINDTEST_INVALID_CN) { > + if(invalid_cn_accepted) { > + todo_wine CHECK_NOT_CALLED(QueryInterface_IHttpSecurity); > + todo_wine CHECK_NOT_CALLED(QueryService_IHttpSecurity); > + todo_wine CHECK_NOT_CALLED(OnSecurityProblem); > + }else { > + CHECK_CALLED(QueryInterface_IHttpSecurity); > + CHECK_CALLED(QueryService_IHttpSecurity); > + CHECK_CALLED(OnSecurityProblem); > + if(onsecurityproblem_hres != S_OK || security_problem == ERROR_INTERNET_SEC_CERT_ERRORS) { > + CHECK_NOT_CALLED(QueryInterface_IInternetBindInfo); > + CHECK_NOT_CALLED(QueryService_IInternetBindInfo); > + CHECK_CALLED(QueryInterface_IHttpNegotiate); > + CHECK_CALLED(BeginningTransaction); > + CHECK_CALLED(QueryInterface_IHttpNegotiate2); > + CHECK_CALLED(GetRootSecurityId); > + CLEAR_CALLED(GetWindow_IWindowForBindingUI); > + CLEAR_CALLED(QueryInterface_IWindowForBindingUI); > + CLEAR_CALLED(QueryService_IWindowForBindingUI); > + if(onsecurityproblem_hres == S_FALSE) { > + if(security_problem == ERROR_INTERNET_SEC_CERT_ERRORS) > + CLEAR_CALLED(OnProgress_FINDINGRESOURCE); > + else > + CHECK_CALLED(OnProgress_FINDINGRESOURCE); > + CHECK_CALLED(GetWindow_IHttpSecurity); > + }else { > + todo_wine CHECK_NOT_CALLED(OnProgress_FINDINGRESOURCE); > + CHECK_NOT_CALLED(GetWindow_IHttpSecurity); > + } > + } > + } > + if(binding_hres != S_OK) { > + ok(hres == binding_hres, "Got %08x\n", hres); > + ok(unk == NULL, "Got %p\n", unk); > + }else if(invalid_cn_accepted) { > + todo_wine ok(hres == S_OK, "IMoniker_BindToStorage failed: %08x\n", hres); > + todo_wine ok(unk != NULL, "unk == NULL\n"); > + }else { > + ok(hres == S_OK, "IMoniker_BindToStorage failed: %08x\n", hres); > + ok(unk != NULL, "unk == NULL\n"); > + } This is making tests even harder to maintain than they are now. I guess you're duplicating checking called function here because of returning on failure a few lines later. It's the return that shouldn't be there. You can change it to if(FAILED(hres) && !(flags & BINDTEST_INVALID_CN)) return; if you don't want to deal with existing problems in error handling. Jacek

1 0

Re: [2/3] kernel32: Added stubs for IDN functions
by Alexandre Julliard 03 Jan '11

03 Jan '11

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > @@ -1219,6 +1219,11 @@ > @ stdcall lstrlen(str) lstrlenA > @ stdcall lstrlenA(str) > @ stdcall lstrlenW(wstr) > +@ stdcall NormalizeString(long wstr long wstr long) > +@ stdcall IsNormalizedString(long wstr long) > +@ stdcall IdnToAscii(long wstr long wstr long) > +@ stdcall IdnToNameprepUnicode(long wstr long wstr long) > +@ stdcall IdnToUnicode(long wstr long wstr long) Please insert them at the correct location, the entry points are sorted. Also output parameters can't be wstr. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [03/13] kernel32: Improve parameter validation for WriteConsoleInputW.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8070 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

2 1

Re: [4/6] kernel32: Improve parameter validation for WriteConsoleInputA. (try 2)
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8084 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [5/6] kernel32: Avoid checking the output parameter for WriteConsoleOutputCharacterW. (try 2)
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8085 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [3/6] kernel32: Improve parameter validation for WriteConsoleInputW. (try 2)
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8083 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [10/13] kernel32: Avoid checking the output parameter for FillConsoleOutputAttribute.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8077 Your paranoid android. === WXPPROSP3 (32 bit console) === No test summary line found === W7PROX64 (64 bit console) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: [13/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputAttribute.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8080 Your paranoid android. === WVISTAADM (32 bit console) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation === W7PROX64 (32 bit console) === No test summary line found

1 0

Re: [12/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputCharacterA.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8079 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [11/13] kernel32: Avoid checking the output parameter for ReadConsoleOutputCharacterW.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8078 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [08/13] kernel32: Avoid checking the output parameter for FillConsoleOutputCharacterW.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8075 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [09/13] kernel32/tests: Add tests for FillConsoleOutputCharacterA.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8076 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [06/13] kernel32: Remove superfluous output parameter check in WriteConsoleOutputCharacterA.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8073 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [07/13] kernel32: Avoid checking the output parameter for WriteConsoleOutputAttribute.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8074 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Re: [04/13] kernel32: Improve parameter validation for WriteConsoleInputA.
by Marvin 03 Jan '11

03 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8071 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Patch failed to apply

1 0

Question on yHeight values for CHARFORMAT2A/CHARFORMAT2W
by James McKenzie 03 Jan '11

03 Jan '11

All: It is interesting that I am getting NEGATIVE values for this. I've ran this against the testbot and received 195 as the value for the System font in WindowsXP/WindowsVista/Windows7 but when I run this against Wine installed on a Mac, I get -240. Is this expected behavior or should I file a bug? Thank you. James McKenzie

1 0

re: RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR
by Dan Kegel 03 Jan '11

03 Jan '11

How about this: #define WINE_ONCE(x) { static int wine_once_var##__LINE__; if (!wine_once_var##__LINE__++) { x; }} Example use: - static int once; - if (!once++) FIXME_(keyboard)("(%p,%d,0x%08x,%X): stub\n",hwnd,id,modifiers,vk); + WINE_ONCE(FIXME_(keyboard)("(%p,%d,0x%08x,%X): stub\n",hwnd,id,modifiers,vk));

2 2

Re: msctf/tests: Wait a bit for registrations to become active on Win7
by Marvin 02 Jan '11

02 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8042 Your paranoid android. === W7PRO (32 bit inputprocessor) === inputprocessor.c:749: Test failed: Activation came unexpectedly inputprocessor.c:757: Test failed: Deactivation came unexpectedly === W7PROX64 (32 bit inputprocessor) === inputprocessor.c:749: Test failed: Activation came unexpectedly inputprocessor.c:225: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:246: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:757: Test failed: Deactivation came unexpectedly === W7PROX64 (64 bit inputprocessor) === inputprocessor.c:749: Test failed: Activation came unexpectedly inputprocessor.c:225: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:246: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:757: Test failed: Deactivation came unexpectedly

1 0

Re: wined3d: Update detection of vertex blend capabilities
by Henri Verbeet 02 Jan '11

02 Jan '11

On 2 January 2011 10:52, Jeremy Chin <rekless(a)fastmail.fm> wrote: > Newer video cards have stopped reporting the ARB_VERTEX_BLEND GL capability, > but ARB_VERTEX_PROGRAM implies the same capability. > I don't think so. If this works at all it's probably because you're passing some previous value of gl_max (like GL_MAX_TEXTURE_UNITS_ARB) for the number of blend matrices.

1 0

RFC: include: Add '_ONCE' variants of DPRINTF, FIXME, WARN and ERR
by Sven Baars 02 Jan '11

02 Jan '11

Hey all, adding '_ONCE' variants of DPRINTF, FIXME, WARN and ERR is a topic that came up before on wine devel. The first version of the attached patch was submitted by Max TenEyck Woodbury, but was deferred until after wine 1.2. I still thought it was a good idea to have the _ONCE variants, so I mailed Max, but he said he backed out after finding out it was not feasible to do it right. I fixed some errors in his patch, but as Max pointed out to me, for compilers that don't support variadic macros, it's not possible to create a scope block to declare the static variable in. This is because of the (void)wine_dbg_printf call at the end of the (non-variadic) __WINE_DPRINTF_ONCE macro. wine_dbg_printf is a variadic function, any code after that function call breaks the macro (so a ';}while(0)' can't be added to close the scope). AFAIK, this is the reason why a do{...}while(0) loop can't be used as it's done in the others. Now I was wondering if there is a solution to this, or if it's ok to implement the _ONCE variants with the current patch. Using the current patch would mean that with a compiler that doesn't support C99, you would still have you at lot of the FIXMEs/WARNs where you don't want them. This would not be a problem right after the implementation, but only after replacing constructions like static int once; if(!once++) FIXME() with the corresponding _ONCE(). It wouldn't really break anything though. Also, it'd probably be better to replace #elif defined(__SUNPRO_C) with something like #elif __STDC_VERSION__ >= 199901L because that's what you're actually looking for. This would mean that the non-variadic _ONCE implementation is less of a problem, because more compilers would use the variadic __WINE_DPRINTF_ONCE macro. The #ifdef __GNUC__ would still remain because of their own implementation of variadic macros (from before C99). Have a happy new year! Sven --- include/wine/debug.h | 44 +++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 43 insertions(+), 1 deletions(-)

1 0

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os
by James Mckenzie 01 Jan '11

01 Jan '11

maury loïc <lmaury(a)gmail.com> wrote: > >Hello Ken and the Wine community, > Please bottom post or post directly to a question. Please do not top post. > >On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > >> Hi Loïc, >> >> On Dec 30, 2010, at 4:20 AM, maury loïc wrote: >> >> > it's my first patch, and it implement the CDROM_Verify() >> > to work on Mac Os. >> >> I think most people are going to need more explanation for why this is a >> legitimate way to implement this function on Mac OS X. :) >> >> Cheers, >> Ken >> >> >For what i understood, The function CDROM_Verify(), verify if the media is >present on the device, and Wine try to open >the device(in Mac Os case), before call the CDROM_Verify(). > >But Mac Os manage the device differently from the other Os. It create the >device, only if the media >is already present. Logically, CDROM_Verify() return success, because when >we are in CDROM_Verify() >we already know the device. > >What do you think ? > This has been critically examined by several people and if the solution were this simple it would have been put in place a long time ago. Charles Davis has spend over a year looking at how to implement CDROM functionality for MacOSX. So, here is my question: How can the community be 100% certain that: 1. The device has EXACTLY the same name on every available MacOSX installation? 2. How can you be 100% certain that if the 'device' exists that the code will end up in CDROM_Verify()? James McKenzie (Another Mac User/Wine Tester.)

4 6

happy new year!
by Dan Kegel 01 Jan '11

01 Jan '11

May all your tests be green, and all your patches pass peer review :-)

3 2

Re: comctl32/tests: Add test for horizontal spacing to test_hittest.
by Marvin 01 Jan '11

01 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8018 Your paranoid android. === WNT4WSSP6 (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W2KPROSP4 (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === WXPPROSP3 (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W2K3R2SESP2 (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === WVISTAADM (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W2K8SE (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W7PRO (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W7PROX64 (32 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96) === W7PROX64 (64 bit listview) === listview.c:3036: Test failed: Horizontal spacing inconsistent (200 != 96)

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 01 Jan '11

01 Jan '11

>>> Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >>> >>> Otherwise ld might not be able to 'find' it when starting the program. >>> >>> James McKenzie >>> >> James... >> You've just exhausted my technical knowledge. How do I do / find that? >Susan: > >For the BASH shell: >Type in set and look for the LD_LIBRARY_PATH line. >for the CSH/KSH shell: >Type in env >Look for the LD_LIBRARY_PATH line. > >Hopefully, /usr/local/lib is there. > >BTW, to make Wine work on a Mac, I have to add this line.... > >James McKenzie Typed "set" Did word search on "library." Nothing.

4 3

re: 64-bit Notepad2 crashes
by Dan Kegel 01 Jan '11

01 Jan '11

'set' is not a good way to check the environment, since it also shows shell variables that are not yet exported. The portable way to check the environment is 'env'.

2 1

Re: NEW: Arabic Translation support in User32.dll (Basic Support)
by Andrew Nguyen 01 Jan '11

01 Jan '11

On 12/31/2010 08:41 AM, Nowres wrote: > Hello, > > here's a basic support for Arabic language in user32.dll > work in progress in other programs to complete support for this language. > > Nowres Rafid. > > > > Changes should be sent as a patch in unified diff format, preferably generated with Git. See http://wiki.winehq.org/SubmittingPatches for detailed guidelines.

1 0

Another tests milestone hit
by Greg Geldorp 31 Dec '10

31 Dec '10

Today we hit another milestone: the first 0-failure run of the 64-bit tests. All tests passed on both the WXPX64 and W2K3R2SEX64 machines. Sadly I missed my personal goal of having all tests pass on at least one VM for every Windows version by the end of the year, we still don't have a Win7 machine that passes all tests. I have a partial fix for msctf:inputprocessor (put a "Sleep(2000);" after the call to test_RegisterCategory()) but in spite of spending quite a bit of time on it haven't made much further progress. So anyone with msctf expertise: your help would be greatly appreciated. Same for ole32:clipboard and ole32:usrmarshal. A big thank you to all the people who contributed tests and fixed existing tests. I think a lot of progress has been made in the month since WineConf and the tests are in much better shape now. Greg.

2 1

sound issues (which are not cared since 1.3.1)
by wylda＠volny.cz 31 Dec '10

31 Dec '10

Hi guys, there are bug reports showing random crashes with audio on, during winecfg etc. I was bit by those too... There is probably something wrong how regressions are handled here, which goes on and thus there are unneeded bugreports which cost everyone's time to read, evaluate, search, mark, retest... Why don't you use revert more offen like kernel guys? Back to the sound issue - my zero programming skill standing just on sound despair, i guess in dlls/winealsa.drv/mixer.c ALSA_MixerInit() should be int card, err, capcontrols=0 otherwise things like: mixdev[mixnum].chans += capcontrols; mixdev[mixnum].lines = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(line) * mixdev[mixnum].chans); mixdev[mixnum].controls = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(control) * CONTROLSPERLINE*mixdev[mixnum].chans); goes crazy like in http://bugs.winehq.org/show_bug.cgi?id=25231#c2. Could someone review this piece of code, please? Thanks, W.

2 2

re: JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder
by Dan Kegel 31 Dec '10

31 Dec '10

Yegor wrote: > it's my first contribution to wine... Welcome! > so I wanted to start with some simple task. Changing memory allocation might not be simple. Your patch touches two different DLLs. You should probably split this patch up, one patch per dll. Also, the fact that your change to d3dcompiler_43 only changes a malloc and not a corresponding free is interesting. Is there a leak? Better run this past the author of that code. > The source code could be compiled without problems after applying the patch. Verifying that it compiles isn't enough. You also have to verify by eye that this change doesn't introduce any alloc/free mismatches, and check that it doesn't introduce any conformance test regressions. Since not all tests pass, you need to run the tests first without your change, and then with your change, and understand any differences in the results. Since you're messin' with malloc, you should also do that with WINEDEBUG=+heap. - Dan

2 2

Re: oleview: Fix a null pointer crash
by Alexandre Julliard 31 Dec '10

31 Dec '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix a null pointer crash This is an internal function, the caller should take care of this. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msvcrxx: Forward _setjmp on x86_64
by Alexandre Julliard 31 Dec '10

31 Dec '10

André Hentschel <nerv(a)dawncrow.de> writes: > needed for ratGPU > --- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- Please fix all the msvcrt dlls, not just these two. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite
by Vitaliy Margolen 31 Dec '10

31 Dec '10

On 12/30/2010 12:23 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style. Adding more invalid strings because file already contains some of them isn't a valid reason for broken code. Vitaliy.

2 1

Re: oledb32: Use correct 32/64-bit typedefs
by Marvin 31 Dec '10

31 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7981 Your paranoid android. === WNT4WSSP6 (32 bit convert) === Can't copy TestLauncher to VM: Cannot connect to the virtual machine === WVISTAADM (32 bit convert) === No test summary line found === W2K8SE (32 bit convert) === No test summary line found

1 0

Re: gdi32/tests: Don't test function directly when reporting GetLastError()
by Marvin 31 Dec '10

31 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7979 Your paranoid android. === WXPPROSP3 (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === W7PRO (32 bit gdiobj) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\gdi32_test.exe === WVISTAADM (32 bit pen) === No test summary line found === W2K8SE (32 bit pen) === No test summary line found

1 0

Re: imagehlp/tests: Don't test function directly when reporting GetLastError()
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7970 Your paranoid android. === W7PRO (32 bit integrity) === No test summary line found

1 0

Re: riched32/tests: Don't test function directly when reporting GetLastError()
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7969 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PRO (32 bit editor) === No test summary line found

1 0

Re: mscms/tests: Fix test message
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7968 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

IGNORE MY LAST POST. I'm away from home and don't have my glasses with me. >Wine build complete. >susan@ubuntu:~/wine$ wine checkinstall >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > > >

1 0

Re: wininet/tests: Don't call GetLastError() twice
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7966 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

>>>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>>> >>contain any dwarf information >>>>> >>maybe you're loading another instance of libwine? >>>>> >>A+ >>>>> >> >>>>> >>-- >>>>> >>Eric Pouech >>>>> > >>>>> >I did a search of the file system. >>>>> > >>>>> >Under /usr/local/lib64 I have >>>>> >libwine.so (link) >>>>> >libwine.so.1 (link) >>>>> >libwine.so.1.0 >>>>> >wine [folder} >>> >>>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>>I got the following error: >>>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> >>Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >> >>Otherwise ld might not be able to 'find' it when starting the program. >> >>James McKenzie >> >susan@ubuntu:~$ ldd /usr/local/bin/wine > linux-gate.so.1 => (0xf77c6000) > libwine.so.1 => not found > libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) > libc.so.6 => /lib32/libc.so.6 (0xf762f000) > /lib/ld-linux.so.2 (0xf77c7000) > >Eureka, I think. > Just compiled today's git. Could compile but not install. Here's the message. Wine build complete. susan@ubuntu:~/wine$ wine checkinstall wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory

1 0

Re: kernel32/tests: Skip some debugger tests on 64-bit
by Jacek Caban 30 Dec '10

30 Dec '10

On 12/30/10 4:31 PM, Greg Geldorp wrote: > I get very different results for the kernel32:debugger tests depending on > which compiler I use. With VS2008, the test runs fine. With mingw64 > 4.4.1-1a (used by the TestBot build VM), the child process that's supposed > to crash keeps running, re-executing the instruction that causes the > exception (an assignment through a NULL pointer) again and again. With > mingw64 4.4.0 (used by Alexandre to build winetest.exe) the child process > terminates, but doesn't launch the debugger. FWIW here are results with GCC 4.5.1, mingw-w64 SVN: http://testbot.winehq.org/JobDetails.pl?Key=7956 It fails as well. > One other observation is that the function table in mingw64-generated > executables seems to be borked (or at least incompatible with what the > Microsoft tools expect). When running "dumpbin /unwindinfo" on > mingw64-generated executables, no unwind info is displayed. Since the > function table/unwind info is closely related to exception handling on > x64, I'm blaming the test failures on mingw64. That's not yet supported by GCC. Proper unwind info as well as SEH exception support is planned for GCC 4.6. Jacek

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

-----Original Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Dec 30, 2010 10:38 AM >To: Susan Cragin <susancragin(a)earthlink.net>, Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >Susan Cragin <susancragin(a)earthlink.net> wrote: >>Sent: Dec 30, 2010 8:30 AM >>To: Marcus Meissner <marcus(a)jet.franken.de> >>Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >>Subject: Re: 64-bit Notepad2 crashes >> >>>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>>> >>contain any dwarf information >>>> >>maybe you're loading another instance of libwine? >>>> >>A+ >>>> >> >>>> >>-- >>>> >>Eric Pouech >>>> > >>>> >I did a search of the file system. >>>> > >>>> >Under /usr/local/lib64 I have >>>> >libwine.so (link) >>>> >libwine.so.1 (link) >>>> >libwine.so.1.0 >>>> >wine [folder} >> >>Then I ran ldconfig on the 64-bit, and then tried wine notepad. >>I got the following error: >>wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory > >Does this 'path' exist in LD_LIBRARY_PATH or equivilent? > >Otherwise ld might not be able to 'find' it when starting the program. > >James McKenzie > susan@ubuntu:~$ ldd /usr/local/bin/wine linux-gate.so.1 => (0xf77c6000) libwine.so.1 => not found libpthread.so.0 => /lib32/libpthread.so.0 (0xf778c000) libc.so.6 => /lib32/libc.so.6 (0xf762f000) /lib/ld-linux.so.2 (0xf77c7000) Eureka, I think.

1 0

Re: 64-bit Notepad2 crashes
by James Mckenzie 30 Dec '10

30 Dec '10

Susan Cragin <susancragin(a)earthlink.net> wrote: >Sent: Dec 30, 2010 8:30 AM >To: Marcus Meissner <marcus(a)jet.franken.de> >Cc: Wine Developers <wine-devel(a)winehq.org>, Eric Pouech <eric.pouech(a)orange.fr> >Subject: Re: 64-bit Notepad2 crashes > >>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >>> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>> >>contain any dwarf information >>> >>maybe you're loading another instance of libwine? >>> >>A+ >>> >> >>> >>-- >>> >>Eric Pouech >>> > >>> >I did a search of the file system. >>> > >>> >Under /usr/local/lib64 I have >>> >libwine.so (link) >>> >libwine.so.1 (link) >>> >libwine.so.1.0 >>> >wine [folder} > >Then I ran ldconfig on the 64-bit, and then tried wine notepad. >I got the following error: >wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory Does this 'path' exist in LD_LIBRARY_PATH or equivilent? Otherwise ld might not be able to 'find' it when starting the program. James McKenzie

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

>On Thu, Dec 30, 2010 at 07:22:31AM -0500, Susan Cragin wrote: >> >> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >> >>if you've compiled wine yourself, it's strange that libwine.so doesn't >> >>contain any dwarf information >> >>maybe you're loading another instance of libwine? >> >>A+ >> >> >> >>-- >> >>Eric Pouech >> > >> >I did a search of the file system. >> > >> >Under /usr/local/lib64 I have >> >libwine.so (link) >> >libwine.so.1 (link) >> >libwine.so.1.0 >> >wine [folder} >> > >> >Under /usr/local/lib64/wine I have >> >libwinecrt0.a >> >libwined3d.def >> >> I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. >> And I downloaded yesterday's git. >> And now I'm getting a different error. >> wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory >> This error is for all wine commands, including wine --version >> >> I have the same files under /usr/local/lib64 >> but under user/local/lib64/wine I have lots of so's and def's. >> ?? > >Is /etc/ld.so.conf listing /usr/local/lib64 ? >Did you try running "ldconfig" once? > >Ciao, Marcus No, it is not listing it. It lists only: include /etc/ld.so.conf.d/*.conf Then I checked ld.so.conf.d, which is a directory containing the following conf files: GL lib32asound2 libasound2 libc x86_64-linux-gnu So, I compared those files to those generated with my 32-bit partition. The last file is replaced by the following: i686-linux-gnu.conf and i-486-linux-gnu.conf Then I ran ldconfig on the 64-bit, and then tried wine notepad. I got the following error: wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory ?Susan

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >>if you've compiled wine yourself, it's strange that libwine.so doesn't >>contain any dwarf information >>maybe you're loading another instance of libwine? >>A+ >> >>-- >>Eric Pouech > >I did a search of the file system. > >Under /usr/local/lib64 I have >libwine.so (link) >libwine.so.1 (link) >libwine.so.1.0 >wine [folder} > >Under /usr/local/lib64/wine I have >libwinecrt0.a >libwined3d.def I purged wine yesterday and hand-removed all wine files I could find, including my repository and prefix. And I downloaded yesterday's git. And now I'm getting a different error. wine: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory This error is for all wine commands, including wine --version I have the same files under /usr/local/lib64 but under user/local/lib64/wine I have lots of so's and def's. ??

2 1

[PATCH] JanitorialProjects/ReplaceMalloc: remove malloc and free from dlls folder
by Yegor Yefremov 30 Dec '10

30 Dec '10

Hello, it's my first contribution to wine, so I wanted to start with some simple task. After fixing the files mentioned in the attached patch, following files in dlls folder still contain malloc/free calls: dlls/ntdll/server.c: if (!(tmp_dir = malloc( p + 1 - config_dir ))) fatal_error( "out of memory\n" ); dlls/msvcrt/heap.c: * malloc (MSVCRT.@) dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/printf.c: str = malloc(1024); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem1 = malloc(size1); dlls/msvcrt/tests/heap.c: mem = malloc(0); dlls/msvcrt/tests/file.c: buffer = malloc( len * sizeof(WCHAR) ); dlls/msvcrt/tests/cpp.c: * or at program exit malloc() checking if these methods haven't been As far as I understand those files test the core functionality and should use malloc. If this is so, then malloc/free replacement for dlls is complete. The source code could be compiled without problems after applying the patch. I'm behind a firewall and couldn't clone the repository even via http (for some other projects it is functioning). That's why my patch was made with quilt. Best regards, Yegor

2 1

Re: 64-bit Notepad2 crashes
by Susan Cragin 30 Dec '10

30 Dec '10

>> ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 >if you've compiled wine yourself, it's strange that libwine.so doesn't >contain any dwarf information >maybe you're loading another instance of libwine? >A+ > >-- >Eric Pouech I did a search of the file system. Under /usr/local/lib64 I have libwine.so (link) libwine.so.1 (link) libwine.so.1.0 wine [folder} Under /usr/local/lib64/wine I have libwinecrt0.a libwined3d.def Do you want copies of so.1.0?

1 0

Re: shlwapi/tests: Fix typo
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7951 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msi/tests: Don't test function directly when reporting GetLastError()
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7950 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: urlmon/tests: Don't test function directly when reporting GetLastError()
by Marvin 30 Dec '10

30 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7948 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: comdlg32/tests: Don't test function directly when reporting GetLastError()
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7933 Your paranoid android. === WVISTAADM (32 bit filedlg) === No test summary line found === W7PRO (32 bit filedlg) === No test summary line found

1 0

Re: dsound/tests: Don't test function directly when reporting GetLastError()
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7930 Your paranoid android. === WVISTAADM (32 bit dsound) === No test summary line found

1 0

Re: setupapi/tests: Don't test function directly when reporting GetLastError() (try 2)
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7929 Your paranoid android. === WVISTAADM (32 bit devinst) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\setupapi_test.exe, error 32 === W7PRO (32 bit devinst) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: shlwapi/tests: Don't test function directly when reporting GetLastError()
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7932 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

64-bit Notepad2 crashes
by Susan Cragin 29 Dec '10

29 Dec '10

I just compiled today's git wine-1.3.10-82-g10b1a7e and tried to run Notepad2's 64-bit version. Below is the crash. Wine's Notepad appears to work fine. Can anyone tell if I should file a wine bug or a Notepad2 bug? I'm on Ubuntu Natty. Thanks. $ wine64 Notepad2 fixme:heap:HeapSetInformation 0x2b4000 0 0x22fce0 4 fixme:commdlg:GetFileName95 Flags 0x02000000 not yet implemented wine: Unhandled page fault on read access to 0x00000026 at address 0x7f3a9dd5cafb (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000026 in 64-bit code (0x00007f3a9dd5cafb). Register dump: rip:00007f3a9dd5cafb rsp:000000000022b470 rbp:000000000022b860 eflags:00010202 ( R- -- I - - - ) rax:0000000000000000 rbx:0000000000000026 rcx:0000000000000026 rdx:0000000000000026 rsi:000000000022bd40 rdi:0000000000000000 r8:000000000022afa0 r9:0000000000000004 r10:0000000000000000 r11:0000000000000246 r12:0000000000000001 r13:0000000000000001 r14:0000000000000000 r15:0000000000000000 Stack dump: 0x000000000022b470: 0000000000000000 0000000000000000 0x000000000022b480: 0000000000000000 0000000000000000 0x000000000022b490: 0000000000000000 0000000000000000 0x000000000022b4a0: 0000000000000000 0000000000000000 0x000000000022b4b0: 0000000000000000 0000000000000000 0x000000000022b4c0: 0000000000000000 0000000000000000 0x000000000022b4d0: 0000000000000000 0000000000000000 0x000000000022b4e0: 0000000000000000 0000000000000000 0x000000000022b4f0: 0000000000000000 0000000000000000 0x000000000022b500: 0000000000000000 0000000000000000 0x000000000022b510: 0000000000000026 000000000022bd40 0x000000000022b520: 0000000000000000 00007f3a9dd5e951 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) 0x00007f3a9dd5cafb PathIsUNCW+0x7b in shlwapi: cmpw $5c,(%rbx) Modules: Module Address Debug info Name (83 modules) ELF 7b800000- 7bbb5000 Deferred kernel32<elf> \-PE 7b820000- 7bbb5000 \ kernel32 ELF 7be00000- 7c103000 Deferred <wine-loader> PE 140000000- 140167000 Deferred notepad2 ELF 7f3a978cd000- 7f3a97ae0000 Deferred msimg32<elf> \-PE 7f3a978d0000- 7f3a97ae0000 \ msimg32 ELF 7f3a97ae0000- 7f3a97ce9000 Deferred librt.so.1 ELF 7f3a97ce9000- 7f3a97eed000 Deferred libgpg-error.so.0 ELF 7f3a97eed000- 7f3a98108000 Deferred libresolv.so.2 ELF 7f3a98108000- 7f3a9830b000 Deferred libkeyutils.so.1 ELF 7f3a9830b000- 7f3a9854f000 Deferred libdbus-1.so.3 ELF 7f3a9854f000- 7f3a987c9000 Deferred libgcrypt.so.11 ELF 7f3a987c9000- 7f3a989da000 Deferred libtasn1.so.3 ELF 7f3a989da000- 7f3a98be2000 Deferred libkrb5support.so.0 ELF 7f3a98be2000- 7f3a98de6000 Deferred libcom_err.so.2 ELF 7f3a98de6000- 7f3a9900d000 Deferred libk5crypto.so.3 ELF 7f3a9900d000- 7f3a992d1000 Deferred libkrb5.so.3 ELF 7f3a992d1000- 7f3a994e2000 Deferred libavahi-client.so.3 ELF 7f3a994e2000- 7f3a996ee000 Deferred libavahi-common.so.3 ELF 7f3a996ee000- 7f3a9998f000 Deferred libgnutls.so.26 ELF 7f3a9998f000- 7f3a99bc4000 Deferred libgssapi_krb5.so.2 ELF 7f3a99bc4000- 7f3a99e14000 Deferred libcups.so.2 ELF 7f3a99e76000- 7f3a9a0b0000 Deferred uxtheme<elf> \-PE 7f3a99e80000- 7f3a9a0b0000 \ uxtheme ELF 7f3a9a0b0000- 7f3a9a2b6000 Deferred libxfixes.so.3 ELF 7f3a9a2b6000- 7f3a9a4c0000 Deferred libxcursor.so.1 ELF 7f3a9a4c0000- 7f3a9a6c3000 Deferred libxcomposite.so.1 ELF 7f3a9a6c3000- 7f3a9a8cc000 Deferred libxrandr.so.2 ELF 7f3a9a8cc000- 7f3a9aad6000 Deferred libxrender.so.1 ELF 7f3a9aad6000- 7f3a9acdc000 Deferred libxxf86vm.so.1 ELF 7f3a9acdc000- 7f3a9aedf000 Deferred libxinerama.so.1 ELF 7f3a9aedf000- 7f3a9b0e5000 Deferred libxdmcp.so.6 ELF 7f3a9b0e5000- 7f3a9b2e8000 Deferred libxau.so.6 ELF 7f3a9b2e8000- 7f3a9b505000 Deferred libxcb.so.1 ELF 7f3a9b505000- 7f3a9b70a000 Deferred libuuid.so.1 ELF 7f3a9b70a000- 7f3a9b925000 Deferred libice.so.6 ELF 7f3a9b925000- 7f3a9bc5c000 Deferred libx11.so.6 ELF 7f3a9bc5c000- 7f3a9be6e000 Deferred libxext.so.6 ELF 7f3a9be6e000- 7f3a9c076000 Deferred libsm.so.6 ELF 7f3a9c093000- 7f3a9c358000 Deferred winex11<elf> \-PE 7f3a9c0b0000- 7f3a9c358000 \ winex11 ELF 7f3a9c3c7000- 7f3a9c5f0000 Deferred libexpat.so.1 ELF 7f3a9c5f0000- 7f3a9c826000 Deferred libfontconfig.so.1 ELF 7f3a9c826000- 7f3a9ca3e000 Deferred libz.so.1 ELF 7f3a9ca3e000- 7f3a9ccc5000 Deferred libfreetype.so.6 ELF 7f3a9cce2000- 7f3a9cf24000 Deferred winspool<elf> \-PE 7f3a9ccf0000- 7f3a9cf24000 \ winspool ELF 7f3a9cf24000- 7f3a9d1e9000 Deferred comdlg32<elf> \-PE 7f3a9cf30000- 7f3a9d1e9000 \ comdlg32 ELF 7f3a9d1e9000- 7f3a9d410000 Deferred imm32<elf> \-PE 7f3a9d1f0000- 7f3a9d410000 \ imm32 ELF 7f3a9d410000- 7f3a9d6a3000 Deferred rpcrt4<elf> \-PE 7f3a9d420000- 7f3a9d6a3000 \ rpcrt4 ELF 7f3a9d6a3000- 7f3a9da23000 Deferred ole32<elf> \-PE 7f3a9d6d0000- 7f3a9da23000 \ ole32 ELF 7f3a9da23000- 7f3a9dd1e000 Deferred comctl32<elf> \-PE 7f3a9da30000- 7f3a9dd1e000 \ comctl32 ELF 7f3a9dd1e000- 7f3a9dfae000 Export shlwapi<elf> \-PE 7f3a9dd30000- 7f3a9dfae000 \ shlwapi ELF 7f3a9dfae000- 7f3a9e3e8000 Deferred shell32<elf> \-PE 7f3a9dfc0000- 7f3a9e3e8000 \ shell32 ELF 7f3a9e3e8000- 7f3a9e601000 Deferred version<elf> \-PE 7f3a9e3f0000- 7f3a9e601000 \ version ELF 7f3a9e601000- 7f3a9e87d000 Deferred advapi32<elf> \-PE 7f3a9e610000- 7f3a9e87d000 \ advapi32 ELF 7f3a9e87d000- 7f3a9eb44000 Deferred gdi32<elf> \-PE 7f3a9e890000- 7f3a9eb44000 \ gdi32 ELF 7f3a9eb44000- 7f3a9eedb000 Deferred user32<elf> \-PE 7f3a9eb60000- 7f3a9eedb000 \ user32 ELF 7f3a9f17f000- 7f3a9f38c000 Deferred libnss_files.so.2 ELF 7f3a9f38c000- 7f3a9f598000 Deferred libnss_nis.so.2 ELF 7f3a9f598000- 7f3a9f7b2000 Deferred libnsl.so.1 ELF 7f3a9f7b2000- 7f3a9f9bb000 Deferred libnss_compat.so.2 ELF 7f3a9f9bb000- 7f3a9fbd1000 Deferred libgcc_s.so.1 ELF 7f3a9fbd1000- 7f3a9fe55000 Deferred libm.so.6 ELF 7f3a9fe55000- 7f3aa0145000 Deferred ntdll<elf> \-PE 7f3a9fe70000- 7f3aa0145000 \ ntdll ELF 7f3aa0148000- 7f3aa034c000 Deferred libdl.so.2 ELF 7f3aa034c000- 7f3aa06cf000 Deferred libc.so.6 ELF 7f3aa06d0000- 7f3aa08ee000 Deferred libpthread.so.0 ELF 7f3aa090b000- 7f3aa0c3d000 Export libwine.so.1 ELF 7f3aa0c3f000- 7f3aa0e61000 Deferred ld-linux-x86-64.so.2 ELF 7fffd69ff000- 7fffd6a00000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\susan\Notepad2.exe 0000001b 0 00000009 0 <== 0000000e services.exe 00000016 0 00000015 0 00000014 0 00000010 0 0000000f 0 00000011 winedevice.exe 00000018 0 00000017 0 00000013 0 00000012 0 00000019 explorer.exe 0000001a 0 Backtrace: =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) err:seh:setup_exception stack overflow 2560 bytes in thread 0009 eip 00007f3a9fe9ce7b esp 0000000000130c00 stack 0x130000-0x131000-0x230000

3 2

Re: [PATCH 1/3 resend] jscript: Don't unescape '\v'.
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7912 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] jscript: Don't unescape '\v'.
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7908 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/3] jscript: Return 'unknown' in typeof operator for native object's values that can't be retrieved
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7909 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 29 Dec '10

29 Dec '10

>> >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> >> Stack dump: >> >> 0x000000000022b470: 0000000000000000 0000000000000000 >> >> 0x000000000022b480: 0000000000000000 0000000000000000 >> >> 0x000000000022b490: 0000000000000000 0000000000000000 >> >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >> >[snip] >> >> Backtrace: >> >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) >> > >> >The stack has been blitzed? Or is this local variables (even though >> >PathIsUNCW doesn't have any)? It's hard to know what's going on >> >without a proper stack trace. PathIsUNCW is such a small function, the >> >problem is almost certainly further up the call chain. >> >> Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? >> >> There used to be a place to post log files so people could look at them... but I've forgotten where it is. > >I was not able to reproduce this here on openSUSE 11.3, >using Notepad2-4.1.24-x86-64.zip from http://www.flos-freeware.ch/notepad2.html > >Is this the one you used? > >The sourcecode shows it calling PathIsUNCW just with a stackbuffer in >src/Dialog.c, which should be safe. > >Ciao, Marcus That is the one I used. To be clear about what I did, that file on the download site is an installation exe. I opened the compressed file and just used the program's exe and ini files by copying them to my home directory. I have compiled three logs, all, seh & relay, and have compressed them, and a copy of the program and ini file I used, and have downloaded all to the following. https://www.yousendit.com/download/RlRxT20zT2JYSHhjR0E9PQ I did not configure any special compiler optimizations. I am running Ubuntu's Natty 64-bit Studio with linux 2.6.37-11-generic.

1 0

Re: 64-bit Notepad2 crashes
by Susan Cragin 29 Dec '10

29 Dec '10

-----Original Message----- >From: Austin Lund <austin.lund(a)gmail.com> >Sent: Dec 28, 2010 6:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: Wine Developers <wine-devel(a)winehq.org> >Subject: Re: 64-bit Notepad2 crashes > >On 29 December 2010 04:47, Susan Cragin <susancragin(a)earthlink.net> wrote: >> Stack dump: >> 0x000000000022b470: 0000000000000000 0000000000000000 >> 0x000000000022b480: 0000000000000000 0000000000000000 >> 0x000000000022b490: 0000000000000000 0000000000000000 >> 0x000000000022b4a0: 0000000000000000 0000000000000000 >> 0x000000000022b4b0: 0000000000000000 0000000000000000 >[snip] >> Backtrace: >> =>0 0x00007f3a9dd5cafb PathIsUNCW+0x7b() in shlwapi (0x000000000022b860) > >The stack has been blitzed? Or is this local variables (even though >PathIsUNCW doesn't have any)? It's hard to know what's going on >without a proper stack trace. PathIsUNCW is such a small function, the >problem is almost certainly further up the call chain. Well, anybody up for seeing a couple of thousand lines of WINEDEBUG-+all, or should I run relay only? There used to be a place to post log files so people could look at them... but I've forgotten where it is.

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (msvcr80, 90 and 100 benefits from this) (resend)
by Alexandre Julliard 29 Dec '10

29 Dec '10

Arno Teigseth <arnotixe(a)gmail.com> writes: > @@ -47,9 +76,16 @@ static void __cdecl test_invalid_parameter_handler(const wchar_t *expression, > const wchar_t *function, const wchar_t *file, > unsigned line, uintptr_t arg) > { > - /* we just ignore handler calls */ > + /* we USED TO just ignore handler calls */ > + CHECK_EXPECT(invalid_parameter_handler); > + ok(expression == NULL, "expression is not NULL\n"); > + ok(function == NULL, "function is not NULL\n"); > + ok(file == NULL, "file is not NULL\n"); > + ok(line == 0, "line = %u\n", line); > + ok(arg == 0, "arg = %lx\n", (UINT_PTR)arg); msvcrt doesn't allow changing the handler. Invalid parameter tests have to be in msvcr90. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite/tests: Use an iface instead of a vtbl pointer in testinput.
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7894 Your paranoid android. === WVISTAADM (32 bit reader) === No test summary line found === W7PRO (32 bit reader) === No test summary line found

2 1

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt take 4 Can't believe I forgot to commit before creating the patch...
by James Mckenzie 29 Dec '10

29 Dec '10

Arno Teigseth <arnotixe(a)gmail.com> wrote: > You'll have to resend both parts of the patch for the testbot to recognize them. Use (resend) in the subject line for us humans. James McKenzie

1 0

Re: [PATCH 2/2] Added ui64tow_s tests for msvcrt (The function was moved from msvcr90 to msvcrt so that msvcr80, 90 and 100
by Marvin 29 Dec '10

29 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7897 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: ntdll/tests: Don't test function directly when reporting GetLastError()
by Marvin 28 Dec '10

28 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7877 Your paranoid android. === W7PROX64 (32 bit exception) === No test summary line found === WVISTAADM (32 bit directory) === TestLauncher.c:89: Test failed: Can't open test executable C:\winetest\ntdll_test.exe, error 32

1 0

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value [try 2]
by Alexandre Julliard 28 Dec '10

28 Dec '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -49,6 +49,7 @@ echo %UNKNOWN%S > echo P%UNKNOWN% > echo P%UNKNOWN%S > echo %ERRORLEVEL > +cmd /c exit 0 > echo %ERRORLEVEL% > echo %ERRORLEVEL%%ERRORLEVEL% > echo %ERRORLEVEL%ERRORLEVEL% It already has a defined value. What is this supposed to fix? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implement _fcvt_s. (resend)
by Alexandre Julliard 28 Dec '10

28 Dec '10

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > @@ -1127,9 +1127,9 @@ int CDECL _ecvt_s( char *buffer, MSVCRT_size_t length, double number, int ndigit > /* special case - inf */ > if(number == HUGE_VAL || number == -HUGE_VAL) > { > - memset(buffer, '0', ndigits); > + memset(buffer, '0', max(ndigits, 0)); > memcpy(buffer, infret, min(ndigits, sizeof(infret) - 1 ) ); > - buffer[ndigits] = '\0'; > + buffer[max(ndigits, 0)] = '\0'; You'd have to fix the memcpy too, though the whole thing doesn't make much sense if ndigits is negative. Probably needs to be rethought, with some test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/8] jscript: Ensure that the whole script is parsed
by Marvin 28 Dec '10

28 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7868 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/8] jscript: Better syntax error tests
by Marvin 28 Dec '10

28 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7867 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox
by Henri Verbeet 28 Dec '10

28 Dec '10

On 28 December 2010 11:25, David Adam <david.adam.cnrs(a)gmail.com> wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER* adjacency) > +/************************************************************************* > + * D3DXCreateMeshFVF > + */ > +HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 pDevice, FLOAT fWidth, FLOAT fHeight, FLOAT fDepth, LPD3DXMESH *ppMesh, LPD3DXBUFFER *ppAdjacency) Seriously.

1 0

Re: 64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin 28 Dec '10

28 Dec '10

>On Mon, Dec 27, 2010 at 12:41:37PM -0500, Susan Cragin wrote: >> I maybe should have filed this as a bug. >> I know Wine had a regression in 64-bit, and that such regression received a patch. >> I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. >> wine-1.3.10-48-g1288078 > > >Was the the first try or the second? >wineboot after a new version might take a bit. >It takes nearly no time here. > >Could you bisect to the slow down? Perhaps some printer stuff? > >Ciao, Marcus I think I've solved what is probably my problem. Notepad when started with the command "wine64" runs quickly. Notepad started with "wine" ran very slowly on one 64-bit partition that I've fiddled with a lot, and not at all on a cleaner 64-bit partition. Sorry for the confusion.

1 0

Re: [PATCH 1/2] mshtml: COM cleanup for the nsIWebBrowserChrome iface.
by Michael Stefaniuc 27 Dec '10

27 Dec '10

Forgot to mention that this patch applies on top of Jacek's "mshtml: Fixed unsafe cast in CreateChromeWindow2 implementation" patch. On 12/27/2010 11:27 PM, Michael Stefaniuc wrote: > --- > dlls/mshtml/mshtml_private.h | 3 +- > dlls/mshtml/nsembed.c | 97 +++++++++++++++++++++-------------------- > dlls/mshtml/nsio.c | 8 ++-- > 3 files changed, 55 insertions(+), 53 deletions(-) bye michael

1 0

64-bit works but Notepad takes a long time to come up, using today's git
by Susan Cragin 27 Dec '10

27 Dec '10

I maybe should have filed this as a bug. I know Wine had a regression in 64-bit, and that such regression received a patch. I updated git today and tried it out. Notepad loads, but it loads very slowly. I think it took about 2 minutes. Maybe more. wine-1.3.10-48-g1288078

2 1

Re: spoolss/tests: Skip tests on Win7
by Paul Vriens 27 Dec '10

27 Dec '10

On 12/27/2010 12:35 PM, Greg Geldorp wrote: > --- > dlls/spoolss/tests/spoolss.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > But that means we will skip on Wine as well (when/if implemented). Is that OK? -- Cheers, Paul.

2 2

Re: [PATCH 2/2] jscript: Added ScriptEngine*Version functions implementation
by Marvin 27 Dec '10

27 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7836 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] jscript: Added ScriptEngine() implementation
by Marvin 27 Dec '10

27 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7835 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml: COM cleanup for the IHTMLWindow2 iface.
by Jacek Caban 27 Dec '10

27 Dec '10

On 12/27/10 12:50 PM, Michael Stefaniuc wrote: > --- > Jacek, I don't like the usage of impl_from_IHTMLWindow2() in > HTMLWindow_invoke() as that isn't a method of the IHTMLWindow2 vtbl. Can > you please cross check that and clean it up if necessary? That's fine itself, the IUnknown passed there is defined by HTMLWindow object and it's IHTMLWindow2 iface in this case. However it can be done better and we can avoid this particular impl_from_IHTMLWindow2 call. I will send a patch after your patch will be in Git. Thanks, Jacek

1 0

Hebrew version of Wine History
by Yaron Shahrabani 27 Dec '10

27 Dec '10

Hey, I translated the Wine History into Hebrew several weeks ago and I noticed that although the patches are in, when I click on Wine's History on the Hebrew website I'm being taken to the English version of the document in Wine's wiki. Wine's history is pretty important to the Israeli community in various aspects, can it be fixed? Kind regards, Yaron Shahrabani <Hebrew translator>

2 1

Re: [PATCH] cmd/tests: Make sure, that ERRORLEVEL has a defined value
by Marvin 26 Dec '10

26 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7830 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 73 (got '0', wanted '5') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2KPROSP4 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WXPPROSP3 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K3R2SESP2 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === WVISTAADM (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W2K8SE (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PRO (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (32 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55') === W7PROX64 (64 bit) === batch.c:223: Test failed: unexpected char 0x30 position 0 in line 74 (got '00', wanted '55')

1 0

Feature Request: winefile: some way to open terminal in current folder
by Ilya Basin 26 Dec '10

26 Dec '10

A typical scenario: - download a file with uTorrent - select "Open containing folder" - ??? - use a native program to work with the downloaded file I think, it would be convenient to add a button to start a terminal or do "xdg-open ."

1 0

None
by paulo lesgaz 25 Dec '10

25 Dec '10

http://2nax.awardspace.com/page.php

3 2

d3dxcreatebox
by David Adam 25 Dec '10

25 Dec '10

Hello, is there any problem with the patch for D3DXCreateBox? I think it was not commited. Thanks in advance for any feedback? A+ David

2 1

Re: [2/2]setupapi/tests: Don't test function directly when reporting GetLastError()
by Marvin 24 Dec '10

24 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7825 Your paranoid android. === WNT4WSSP6 (32 bit misc) === No test summary line found

1 0

Re: Eryk Wieliczko : msvcrt/tests: Add _fcvt_s tests.
by Eryk Wieliczko 24 Dec '10

24 Dec '10

Quick question: why todo_wine? Respectfully, Eryk Wieliczko 2010/12/23 Alexandre Julliard <julliard(a)winehq.org>: > Module: wine > Branch: master > Commit: b74ef16d99f3c2f7e4a0a7e453c71b6da2c70310 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b74ef16d99f3c2f7e4a0a7e45… > > Author: Eryk Wieliczko <ewdevel(a)gmail.com> > Date: Wed Dec 22 23:10:56 2010 +0100 > > msvcrt/tests: Add _fcvt_s tests. > > --- > > dlls/msvcrt/tests/printf.c | 29 +++++++++++++++++++++++++++-- > 1 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c > index 87efd16..d32ef73 100644 > --- a/dlls/msvcrt/tests/printf.c > +++ b/dlls/msvcrt/tests/printf.c > @@ -40,6 +40,8 @@ static int (__cdecl *p__vsnwprintf_s)(wchar_t *str, size_t sizeOfBuffer, > __ms_va_list valist); > static int (__cdecl *p__ecvt_s)(char *buffer, size_t length, double number, > int ndigits, int *decpt, int *sign); > +static int (__cdecl *p__fcvt_s)(char *buffer, size_t length, double number, > + int ndigits, int *decpt, int *sign); > > static void init( void ) > { > @@ -49,6 +51,7 @@ static void init( void ) > p__vscwprintf = (void *)GetProcAddress(hmod, "_vscwprintf"); > p__vsnwprintf_s = (void *)GetProcAddress(hmod, "_vsnwprintf_s"); > p__ecvt_s = (void *)GetProcAddress(hmod, "_ecvt_s"); > + p__fcvt_s = (void *)GetProcAddress(hmod, "_fcvt_s"); > } > > static void test_sprintf( void ) > @@ -799,7 +802,7 @@ static void test_xcvt(void) > "_fcvt() decimal point wrong, got %d expected %d\n", decpt, > test_cvt_testcases[i].expdecpt_f); > ok( sign == test_cvt_testcases[i].expsign, > - "_ecvt() sign wrong, got %d expected %d\n", sign, > + "_fcvt() sign wrong, got %d expected %d\n", sign, > test_cvt_testcases[i].expsign); > } > > @@ -823,7 +826,29 @@ static void test_xcvt(void) > free(str); > } > else > - win_skip("_ecvt_s not available\n"); > + win_skip("_ecvt_s not available\n"); > + > + if (p__fcvt_s) > + { > + str = malloc(1024); > + for( i = 0; strcmp( test_cvt_testcases[i].expstr_e, "END"); i++){ > + decpt = sign = 100; > + err = p__fcvt_s(str, 1024, test_cvt_testcases[i].value, test_cvt_testcases[i].nrdigits, &decpt, &sign); > + ok(err == 0, "_fcvt_s() failed with error code %d", err); > + ok( 0 == strncmp( str, test_cvt_testcases[i].expstr_f, 15), > + "_fcvt_s() bad return, got \n'%s' expected \n'%s'\n", str, > + test_cvt_testcases[i].expstr_e); > + ok( decpt == test_cvt_testcases[i].expdecpt_f, > + "_fcvt_s() decimal point wrong, got %d expected %d\n", decpt, > + test_cvt_testcases[i].expdecpt_e); > + ok( sign == test_cvt_testcases[i].expsign, > + "_fcvt_s() sign wrong, got %d expected %d\n", sign, > + test_cvt_testcases[i].expsign); > + } > + free(str); > + } > + else > + todo_wine win_skip("_fcvt_s not available\n"); > } > > static int __cdecl _vsnwprintf_wrapper(wchar_t *str, size_t len, const wchar_t *format, ...) > > > >

2 1

Dear friend!
by paulo lesgaz 24 Dec '10

24 Dec '10

Dear friend, How are you recently? I bought a laptop from a website: www.yedew.com last week. I have got the product. Its quality is very good and the price is competitive. They also sell phones, TV, psp, motor and so on. By the way, they import product from Korea and sell new and original products. They have good reputation and have many good feedbacks. If you need these products, look at this website will be a clever choice. I am sure you will get many surprise and benefits. Greetings!

1 0

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite
by Michael Stefaniuc 23 Dec '10

23 Dec '10

Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: > Tests to ensure the HLSL compiler won't crash on malformed input. > > --- > dlls/d3dcompiler_43/tests/hlsl.c | 87 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 87 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dcompiler_43/tests/hlsl.c b/dlls/d3dcompiler_43/tests/hlsl.c > index 1f8e31c..a6a6099 100644 > --- a/dlls/d3dcompiler_43/tests/hlsl.c > +++ b/dlls/d3dcompiler_43/tests/hlsl.c > @@ -556,6 +556,92 @@ static void test_trig(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geo > } > } > > +static void test_fail(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *qquad_geometry, > + IDirect3DVertexShader9 *vshader_passthru) > +{ > + static const char *undefined_variable_shader = > + "float4 test(float2 pos: TEXCOORD0) : COLOR \ > + { \ > + return y; \ > + }"; please use proper C string literals. Escaping the newline is a gcc extension. You can use string literal concatenation to split the string on multiple lines. Something like this would do: "float4 test(float2 pos: TEXCOORD0) : COLOR" "{" " return y;" "}"; bye michael

3 2

(no subject)
by Greg Geldorp 23 Dec '10

23 Dec '10

Ok, it didn't last very long, but for a brief period we had only greens for 4 different Windows versions on http://test.winehq.org, see attached screenshot. Nice to see some progress J Greg.

1 0

Re: uninstaller: Run msiexec if the WindowsInstaller value is set.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > programs/uninstaller/main.c | 23 +++++++++++++++++++---- > 1 files changed, 19 insertions(+), 4 deletions(-) Note that appwiz.cpl will need the same change (of course uninstaller should really be calling appwiz.cpl in the first place). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] Added function _ui64tow_s to MSVCRT (sorry sent the last mail from the wrong address)
by Alexandre Julliard 23 Dec '10

23 Dec '10

Arno Teigseth <arnotixe(a)gmail.com> writes: > --- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/string.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 2 deletions(-) Please add it to all the msvcrt versions that need it, not only to msvcr90. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] shell32: Add IInputObject stub to ExplorerBrowser. (try 2)
by Alexandre Julliard 23 Dec '10

23 Dec '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + hr = IInputObject_TranslateAcceleratorIO(pio, &msg_a); > + todo_wine ok(hr == found ? S_OK : S_FALSE, "Got 0x%08x (%04x)\n", hr, i); That doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Death to win9x?
by Joerg-Cyril.Hoehle＠t-systems.com 23 Dec '10

23 Dec '10

Dan Kegel wrote: >I'm all for removing stuff that nobody needs anymore. Who said nobody needs Win9x anymore? > I imagine there >are still a few popular older apps that will force us to keep some old >win9x behaviors around, though, so we probably won't be able >to remove the 'emulate win98' choice from winecfg any time soon. Probably half of the apps I bought during the last years work with Win9X. Just the other day I saw a mciSendCommand16 in a log. Well, 16bit != win9x. Is it "Death to 16bit" you meant? What's the motivation behind removing stuff *now* suddenly? Is it the perceived effort needed to fix the tests to all green colour on testbot's win9x machines? Why was this topic not discussed recently at Wineconf? It would be a very bad idea to remove win9x from testbot. We need these old systems to understand what behaviour old apps expect. And I'm very thankful to Greg for his testbot service. Without it, we would know next to nothing about win9x. The fact that a random old app works in native XP (in compatibility mode) teaches us nothing for Wine. Unless we start to run winetest in compatibility mode! I've already mentioned in the past the idea to run testbot sometimes with all broken() disabled, to assess failures on newer systems. broken() may shadow errors in the tests and lull Wine developers into wrong beliefs. Paul Vriens wrote: >The little bits and pieces we have in our code should stay as we >probably need that to cope with old apps that expect a different behavior. Actually, I've even been thinking about implementing the opposite behaviour: Old APIs are mostly used by old apps, while newer apps moved to newer ones (e.g. DirectSound, then mmdev). Therefore it would make a lot of sense to have old APIs (e.g. WINMM/MCI/VfW) mimic the behaviour observable when these apps were developed: win9x! (win3.x?) We don't even know whether MS' compatibility mode does precisely that. Regards, Jörg Höhle

7 10

Phoronix benchmarked opengl games on wine...
by Dan Kegel 23 Dec '10

23 Dec '10

http://www.phoronix.com/scan.php?page=article&item=wine_win7_2010 "With this testing we ran eight games/benchmarks natively under Ubuntu 10.10, the Windows binaries under the stable Wine 1.2.1, the Windows binaries under the Wine 1.3.9 development snapshot, and then finally under Microsoft Windows 7 Professional. The test profiles used had included OpenArena, Urban Terror, Warsow, Nexuiz, Lightsmark, Unigine Sanctuary, Unigine Tropics, and Unigine Heaven. The OpenGL renderer was used with all of them... >From this first round of 2010 Wine vs. Ubuntu vs. Windows 7 testing it is tough to draw any conclusions. About the only conclusion to draw would be that you cannot draw any definitive conclusions about the Wine performance compared to the native performance on either Linux or Windows. ... Stay tuned for our expanded Wine testing and to see how the Linux performance compares with some more popular Windows-only Direct3D-rendered games."

1 0

Re: shell32/tests: Fix a typo
by Marvin 23 Dec '10

23 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7800 Your paranoid android. === W7PROX64 (64 bit shlexec) === shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt9698.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

New winetricks 20101222: new verbs icodecs, msnasn1, opensymbol, wmi, xmllite; removed obsolete verbs audioio, dcom98, eadm, urlmon
by Dan Kegel 22 Dec '10

22 Dec '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Lots of bugfixes. wsh57 now works with vb scripts. The code has undergone some spring cleaning, so watch out for regressions. (We've fixed a few already.) In particular, the audioio, dcom98, eadm, and urlmon verbs are gone, let me know if you really need those! There's a new --optin commandline option that will tells winetricks to phone home after each run with info about which verbs really get used. Please consider using this, it will help future winetricks development. (You only have to give that option once, it sticks. You can turn it off with the --optout option, or by removing ~/.cache/winetricks.) Longer Changelog: Detlef Riekenberg: wmi: new verb Andrew Nguyen: steam: install corefonts first gfw: Avoid extracting the entire Win2k SP4 redist for msasn1.dll Austin English: Always use quiet and overwrite options for unzip. (issue 196) Lots of win64 fixes audioio: removed cmake: support silent install d3dx9_xx: only extract the desired dll (faster) dotnet11: work around wine bug 25120 eadm: remove, it's useless and its sha1sum changes way too often ie6: get rid of ie6 online installer, rename ie6_full to ie6 (which works around the inseng bug), support quiet installs mono28: bump to mono 2.8.1 mono28: remove mono registry keys, they are set by default in Wine since 1.2 msxml3: fix install opensymbol: added font set_psm: should set PixelShaderMode, not RenderTargetLockMode. (Issue 197) unset_winver: wine changed version setting, so make this a synonym for winver xp vcrun2003: use the correct programfiles directory. Fixes win64 install. w_call: if the subshell fails, exit immediately, otherwise w_die() is useless winver: update how setting a windows version works. w_warn: should return 0 in case of no-gui xact: fix for WINEPREFIXes with spaces/special characters Dan Kegel: Many small changes to start obeying new coding convention. Fix a few bugs found when running on windows Fix places where paths weren't quoted (bug 179). Thanks to Roberto Neri. Add --option, --optout options to control experimental opt-in usage tracking. crypt32: it was really broken, but works now. dcom98: it's obsolete, and causes problems, so removed. dotnet30: have to set XP mode now for install to work dotnet35: improved recipe per Louis, good enough to let some apps start icodecs: brought back, thanks to Alan Alberghini for the new URL. msasn1: new verb. urlmon: remove for now wsh57: improve so wscript hello.vbs works xmllite: new verb. (Hangs at end unless you give -q)

2 2

The Windows version of the "octave --version" command exposes an uncommon X network transparency issue for wine
by Alan W. Irwin 22 Dec '10

22 Dec '10

I have been downloading lots of free software packages for Windows that are dependencies of PLplot so that I can add additional components of PLplot for my tests of PLplot under wine. Normally, I do all such testing on an X-terminal, and wine normally works without X transparency issues for everything I have tested up to now on wine. These tests include Windows GUI installers for lots of different free software packages and PLplot device drivers that generate interactive plots for the Windows platform. I have not done any such tests for games. This just-encountered network-transparency trouble occurred for the Windows version of octave, and the reason I am bringing it up here is to find out if this is a known issue or a new bug that I should report on your bug tracker. Here are the details. I am running a 32-bit version of wine-1.3.9 that I have built and installed on Debian testing 64-bit hardware. The GUI installer for octave obtained from "http://prdownloads.sourceforge.net/octave/Octave_Windows%20-%20MinGW/Octave…" worked fine under wine (on the X-terminal). I chose everything to be default other than the install prefix location. I am also using the latest version of Windows bash from MSYS and start running it as follows wineconsole --backend=curses MinGW/msys/1.0/bin/bash.exe Under that bash if I set the PATH to include the bin directory where octave.exe resides and run octave --version directly (i.e., not from an X-terminal) I get a good result which consists of the usual GNU octave version message. If I do the same thing from my X-terminal (where all X applications like the xterm where the wineconsole command is executed are running on a remote machine over the office LAN and a local X server on the X-terminal box transparently handles the X display, keyboard, and mouse), then I get the following errors (subject to rewrapping) bash.exe-3.1$ octave --version X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 1 (X_CreateWindow) Serial number of failed request: 208 Current serial number in output stream: 210 Since a rather large number of wineconsole or wine commands I have been running recently (including the octave installer GUI itself) work without issues for an X-terminal, my working hypothesis is the Windows version of octave (which can know absolutely nothing about X) generates a special version of a normal display request to wine that wine for some reason cannot handle in a network-transparent way when translating that display request to X. Are there known network transparency issues still remaining for some small subset of the display requests translated into X by wine or is this a new X network transparency bug for wine that I should report? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

3 3

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by jacek＠codeweavers.com 22 Dec '10

22 Dec '10

On 12/22/10 2:17 PM, David Hedberg wrote: > Hi Jacek, > On Wed, Dec 22, 2010 at 13:07, Jacek Caban<jacek(a)codeweavers.com> wrote: >>> + if(security_problem) { >>> + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, >> You shouldn't need the cast here. > I get warnings if I leave the casts out though, and I can't see any obvious problem with the declarations. Any ideas? I've read your patch wrongly, sorry. Please avoid using IUnknown_QueryService. It's an ugly named helper function and it causes confusions like mine. Explicitly QIing for IServiceProvider and calling QueryService on it is the way to go. Cheers, Jacek

1 0

Re: [PATCH 2/2] shell32: Add IInputObject stub to IExplorerBrowser.
by Alexandre Julliard 22 Dec '10

22 Dec '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + WPARAM supported_key_accels[] = { /* Win7 */ > + VK_RETURN, VK_PRIOR, VK_NEXT, VK_END, VK_HOME, VK_LEFT, VK_UP, VK_RIGHT, > + VK_DOWN, VK_F10, 0 }; > + MSG msg_a = { > + hwnd, > + supported_key_accels[1], This doesn't make sense, you should be passing a keyboard message here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] urlmon: Add some error handling to the http protocol.
by Jacek Caban 22 Dec '10

22 Dec '10

Hi David, On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/http.c | 99 +++++++++++++++++++++++++++++++++++++++++++++-- > dlls/urlmon/tests/url.c | 25 ++++++++++++ > 2 files changed, 120 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c > index cfa2fc6..1ed5e15 100644 > --- a/dlls/urlmon/http.c > +++ b/dlls/urlmon/http.c > @@ -80,6 +80,92 @@ static LPWSTR query_http_info(HttpProtocol *This, DWORD option) > return ret; > } > > +static HRESULT handle_http_error(HttpProtocol *This, DWORD error) > +{ > + IWindowForBindingUI *wfb_ui; > + IHttpSecurity *http_security; > + BOOL security_problem; > + HRESULT hres; > + > + switch(error) { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + security_problem = TRUE; > + break; > + default: > + security_problem = FALSE; > + } > + > + if(security_problem) { > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, You shouldn't need the cast here. > +&IID_IHttpSecurity,&IID_IHttpSecurity, (void **)&http_security); > + if(SUCCEEDED(hres)) { > + hres = IHttpSecurity_OnSecurityProblem(http_security, error); > + IHttpSecurity_Release(http_security); > + > + if(hres == S_OK || hres == E_ABORT) > + return E_ABORT; > + if(hres == RPC_E_RETRY) > + return RPC_E_RETRY; > + if(hres != S_FALSE) > + return INET_E_SECURITY_PROBLEM; > + } > + } > + > + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink, > +&IID_IWindowForBindingUI,&IID_IWindowForBindingUI, (void **)&wfb_ui); Same here. > + if(SUCCEEDED(hres)) { > + HWND hwnd; > + const IID *iid_reason; > + > + if(security_problem) > + iid_reason =&IID_IHttpSecurity; > + else if(error == ERROR_INTERNET_INCORRECT_PASSWORD) > + iid_reason =&IID_IAuthenticate; > + else > + iid_reason =&IID_IWindowForBindingUI; > + > + hres = IWindowForBindingUI_GetWindow(wfb_ui, iid_reason,&hwnd); > + if(SUCCEEDED(hres)&& hwnd) > + { > + DWORD res; > + > + res = InternetErrorDlg(hwnd, This->base.request, error, > + FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS | FLAGS_ERROR_UI_FLAGS_GENERATE_DATA, > + NULL); > + > + if(res == ERROR_INTERNET_FORCE_RETRY || res == ERROR_SUCCESS) > + hres = RPC_E_RETRY; > + else > + hres = E_FAIL; > + } > + IWindowForBindingUI_Release(wfb_ui); > + } > + > + if(hres == RPC_E_RETRY) > + return hres; > + > + switch(error) > + { > + case ERROR_INTERNET_SEC_CERT_DATE_INVALID: > + case ERROR_INTERNET_SEC_CERT_CN_INVALID: > + case ERROR_INTERNET_INVALID_CA: > + case ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED: > + return INET_E_INVALID_CERTIFICATE; > + case ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR: > + case ERROR_INTERNET_HTTPS_TO_HTTP_ON_REDIR: > + case ERROR_HTTP_REDIRECT_NEEDS_CONFIRMATION: > + return INET_E_REDIRECT_FAILED; > + default: > + return INET_E_DOWNLOAD_FAILURE; > + } > +} > + > static ULONG send_http_request(HttpProtocol *This) > { > INTERNET_BUFFERSW send_buffer = {sizeof(INTERNET_BUFFERSW)}; > @@ -282,13 +368,18 @@ static HRESULT HttpProtocol_open_request(Protocol *prot, IUri *uri, DWORD reques > if(!res) > WARN("InternetSetOption(INTERNET_OPTION_HTTP_DECODING) failed: %08x\n", GetLastError()); > > - error = send_http_request(This); > + do { > + error = send_http_request(This); > > - if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > - return S_OK; > + if(error == ERROR_IO_PENDING || error == ERROR_SUCCESS) > + return S_OK; > + > + hres = handle_http_error(This, error); > + > + } while(hres == RPC_E_RETRY); > > WARN("HttpSendRequest failed: %d\n", error); > - return INET_E_DOWNLOAD_FAILURE; > + return hres; > } > > static HRESULT HttpProtocol_end_request(Protocol *protocol) > diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c > index 875294b..c2cf152 100644 > --- a/dlls/urlmon/tests/url.c > +++ b/dlls/urlmon/tests/url.c > @@ -91,10 +91,12 @@ DEFINE_EXPECT(QueryInterface_IInternetBindInfo); > DEFINE_EXPECT(QueryInterface_IAuthenticate); > DEFINE_EXPECT(QueryInterface_IInternetProtocol); > DEFINE_EXPECT(QueryInterface_IWindowForBindingUI); > +DEFINE_EXPECT(QueryInterface_IHttpSecurity); > DEFINE_EXPECT(QueryService_IAuthenticate); > DEFINE_EXPECT(QueryService_IInternetProtocol); > DEFINE_EXPECT(QueryService_IInternetBindInfo); > DEFINE_EXPECT(QueryService_IWindowForBindingUI); > +DEFINE_EXPECT(QueryService_IHttpSecurity); > DEFINE_EXPECT(BeginningTransaction); > DEFINE_EXPECT(OnResponse); > DEFINE_EXPECT(QueryInterface_IHttpNegotiate2); > @@ -627,6 +629,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > IServiceProvider *service_provider; > IHttpNegotiate *http_negotiate; > IHttpNegotiate2 *http_negotiate2; > + IHttpSecurity *http_security; > LPWSTR ua = (LPWSTR)0xdeadbeef, accept_mimes[256]; > LPWSTR additional_headers = (LPWSTR)0xdeadbeef; > BYTE sec_id[100]; > @@ -708,6 +711,18 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, > ok(hres == E_FAIL, "GetRootSecurityId failed: %08x, expected E_FAIL\n", hres); > ok(size == no_callback ? 512 : 13, "size=%d\n", size); > > + if(!no_callback) { > + SET_EXPECT(QueryService_IHttpSecurity); > + SET_EXPECT(QueryInterface_IHttpSecurity); > + } > + hres = IServiceProvider_QueryService(service_provider,&IID_IHttpSecurity, > +&IID_IHttpSecurity, (void**)&http_security); > + ok(hres == E_NOINTERFACE, "QueryService failed: 0x%08x\n", hres); > + if(!no_callback) { > + CHECK_CALLED(QueryService_IHttpSecurity); > + CHECK_CALLED(QueryInterface_IHttpSecurity); > + } > + > IServiceProvider_Release(service_provider); > > IInternetProtocolSink_AddRef(pOIProtSink); > @@ -1212,6 +1227,11 @@ static HRESULT WINAPI ServiceProvider_QueryService(IServiceProvider *iface, > return E_NOTIMPL; > } > > + if(IsEqualGUID(&IID_IHttpSecurity, guidService)) { > + CHECK_EXPECT(QueryService_IHttpSecurity); > + return E_NOTIMPL; > + } > + > ok(0, "unexpected service %s\n", debugstr_guid(guidService)); > return E_NOINTERFACE; > } > @@ -1292,6 +1312,11 @@ static HRESULT WINAPI statusclb_QueryInterface(IBindStatusCallbackEx *iface, REF > CHECK_EXPECT2(QueryInterface_IWindowForBindingUI); > return E_NOINTERFACE; > } > + else if(IsEqualGUID(&IID_IHttpSecurity, riid)) > + { > + CHECK_EXPECT2(QueryInterface_IHttpSecurity); > + return E_NOINTERFACE; > + } > else > { > ok(0, "unexpected interface %s\n", debugstr_guid(riid)); Please add some real tests. At least a connection to an invalid certificate should be easy to achieve. Cheers, Jacek

2 1

Shell.Application
by Alexander Morozov 22 Dec '10

22 Dec '10

Some Windows programs use Shell.Application object (sample: http://bugs.winehq.org/show_bug.cgi?id=8987). This object has IShellDispatch, IShellDispatch2, IShellDispatch3, ... interfaces (http://www.com.it-berater.org/COM/windows_shell/interfaces/IShellDispatch.h…). If IShellDispatch is sufficient for some application and I am going to add its declaration should I add IShellDispatch2, 3, ..., 5 in addition?

1 0

Re: [PATCH 5/6] urlmon: Add new on_error function to protocol vtbl.
by Jacek Caban 22 Dec '10

22 Dec '10

Hi David On 12/22/10 12:50 AM, David Hedberg wrote: > --- > dlls/urlmon/protocol.c | 6 +++++- > dlls/urlmon/urlmon_main.h | 1 + > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/dlls/urlmon/protocol.c b/dlls/urlmon/protocol.c > index 669343b..bb17453 100644 > --- a/dlls/urlmon/protocol.c > +++ b/dlls/urlmon/protocol.c > @@ -107,7 +107,11 @@ static void request_complete(Protocol *protocol, INTERNET_ASYNC_RESULT *ar) > TRACE("(%p)->(%p)\n", protocol, ar); > > if(!ar->dwResult) { > - WARN("request failed: %d\n", ar->dwError); > + if(protocol->vtbl->on_error) > + protocol->vtbl->on_error(protocol, ar->dwError); > + else > + WARN("request failed: %d\n", ar->dwError); We want it in all protocol handlers. Please add stubs (with FIXME) to all of them and remove NULL-check here. Also you will leave the object in an invalid state if we're in a middle of downloading at this point. You can limit this patch to the first request_complete notification (using FLAG_FIRST_CONTINUE_COMPLETE flag) or make sure we're doing things right. Cheers, Jacek

1 0

RE: shdocvw/tests: need to save .url before committing extra props for
by Greg Geldorp 22 Dec '10

22 Dec '10

Discard this one, should have run the modified tests on Wine too... Greg.

1 0

Re: [PATCH 1/3] msvcrt/tests: Add _fcvt_s tests.
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7749 Your paranoid android. === W2KPROSP4 (32 bit printf) === printf: unhandled exception c0000005 at 77FCD79A === WXPPROSP3 (32 bit printf) === printf: unhandled exception c0000005 at 7C911689 === W2K3R2SESP2 (32 bit printf) === printf: unhandled exception c0000005 at 7C82CAC2

1 0

Re: sane.ds: sync resource headers
by Michael Stefaniuc 21 Dec '10

21 Dec '10

On 12/21/2010 08:00 PM, André Hentschel wrote: > --- > dlls/sane.ds/sane_Ko.rc | 2 +- > dlls/sane.ds/sane_Ro.rc | 2 ++ > 2 files changed, 3 insertions(+), 1 deletions(-) > diff --git a/dlls/sane.ds/sane_Ro.rc b/dlls/sane.ds/sane_Ro.rc > index 5b162fd..20893a6 100644 > --- a/dlls/sane.ds/sane_Ro.rc > +++ b/dlls/sane.ds/sane_Ro.rc > @@ -1,4 +1,6 @@ > /* > + * Romanian resources for Twain > + * > * Copyright 2006 CodeWeavers, Aric Stewart > * Copyright 2008 Michael Stefaniuc > * That wasn't an omission on my part but I explicitly leave that out as that info is redundant. And people tend to forget to update that when they copy the file. bye michael

2 2

Possible problem with Natty 64-bit compile
by Susan Cragin 21 Dec '10

21 Dec '10

I have downloaded the git, compiled and installed wine as 64-bit on the current 64-bit version of Natty. This all works fine, no errors I can see, but then it doesn't run. My executables can be found, including: /usr/local/bin/wine64 and wine64-preloader But I can't run anything. A "wine" command tells me wine isn't installed, which I guess it isn't, and "wine64" gives me a segmentation fault. Do I need a symlink? ubuntu$ wine notepad The program 'wine' can be found in the following packages: * wine-bin-unstable * wine1.2 * wine1.0 Try: sudo apt-get install <selected package> ubuntu:~$ wine64 notepad Segmentation fault ubuntu:~$

2 1

Re: kernel32/tests: Quote command line arguments that might contain spaces
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7737 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:320: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtFF83.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2644 != 2046 debugger.c:306: Test failed: Timed out waiting for the child to crash debugger.c:313: Test failed: wrong exit code : 00000103 debugger.c:331: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtD465.tmp': read=0 debugger.c:336: Test failed: wrong debugger argument count: -26989168 debugger.c:337: Test failed: the child and debugged pids don't match: 2768 != 2046 Timeout === W7PROX64 (32 bit process) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test.exe

1 0

Re: kernel32/tests: Remove check of environment variables against registry
by Marvin 21 Dec '10

21 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7738 Your paranoid android. === W7PROX64 (64 bit environ) === TestLauncher.c:200: Test failed: Can't locate import module name in C:\winetest\kernel32_test64.exe

1 0

RFC: New winetricks options --optin, --optout
by Dan Kegel 21 Dec '10

21 Dec '10

I'm interested in which winetricks verbs people are using, mostly so I can nuke the ones that nobody cares about, but also so I can pay more attention to making sure popular ones work. So I added an --optin option to winetricks; if you give that option, winetricks will report which verbs you use. You can turn this off again with --optout. This is only in svn, not yet in the released version, and it's only a commandline thing; GUI users are currently unaffected. See http://code.google.com/p/winezeug/source/detail?r=2137 I kind of expect not many people to find that option and turn it on, so it seemed safe to add. If the community agrees, at some point I'll change the GUI to ask users on first run whether they want to help winetricks development by reporting usage information. Comments? - Dan

3 2

Re: user32/cursoricon: Fix an uninitialized pointer.
by Adam Martinson 20 Dec '10

20 Dec '10

On 12/20/2010 01:40 PM, Adam Martinson wrote: > --- > dlls/user32/cursoricon.c | 15 +++++++++------ > 1 files changed, 9 insertions(+), 6 deletions(-) > > This is wrong, please ignore it.

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7721 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7720 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus.
by James Mckenzie 20 Dec '10

20 Dec '10

Damian Dixon <damian.dixon(a)gmail.com> wrote: >Sent: Dec 20, 2010 1:28 PM >To: wine-patches(a)winehq.org >Cc: damian.dixon(a)gmail.com >Subject: advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. Updated tests to remove todo_wine for QueryServiceStatus. > Please rebase to current git. James McKenzie

1 0

Re: jscript: Exception tests clean up.
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7719 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Nikolay Sivov 20 Dec '10

20 Dec '10

On 12/20/2010 20:29, Damian Dixon wrote: > --- > dlls/advapi32/service.c | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) You can't split this in two patches, cause tests should run without failures after each patch. So in your case remove todo_wine in the same patch.

1 0

Re: [1/2] advapi32: Added check for NULL pointer being passed to QueryServiceStatus for either parameter. SetLastError is set according to tests in tests/service.c and in accordance with platform.
by Andrew Nguyen 20 Dec '10

20 Dec '10

On 12/20/2010 11:29 AM, Damian Dixon wrote: > + if (!lpservicestatus) > + { > + OSVERSIONINFOW osVi; > + /* Get windows version emulating */ > + osVi.dwOSVersionInfoSize = sizeof(osVi); > + GetVersionExW(&osVi); > + if (osVi.dwPlatformId == VER_PLATFORM_WIN32_NT) > + { > + if (osVi.dwMajorVersion > 4) > + { > + SetLastError(ERROR_INVALID_ADDRESS); > + } > + else > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + } > + } > + return FALSE; > + } > + You shouldn't need to check the Windows version. Setting the last error to a reasonable value for a particular platform is sufficient.

1 0

Re: [2/2] advapi32/tests: Remove todo_wine so change made in QueryServiceStatus does not cause a failure
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7718 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: shell32/tests: Mark Win7 behaviour as broken
by Alexandre Julliard 20 Dec '10

20 Dec '10

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/shell32/tests/shlview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) When marking results as broken you have to explain why it's reasonable to consider it broken. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll/tests: Remove tests for overlong instructions
by Alexandre Julliard 20 Dec '10

20 Dec '10

"Greg Geldorp" <ggeldorp(a)vmware.com> writes: > The "overlong instruction" test produces different results on different > test machines. Since it fails on other machines besides the TestBot VMs I > don't think this is a TestBot problem. Do you have evidence that it also fails on real hardware? -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATH try2] widl: Added support for registering alternative progids.
by Alexandre Julliard 20 Dec '10

20 Dec '10

Jacek Caban <jacek(a)codeweavers.com> writes: > This will be needed for jscript registration. This seems very ad-hoc. Unless there are many other places that need it, I think it should be handled manually in jscript. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Added Date.setYear implementation.
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7715 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: libs/wine: check for empty string in WINEPREFIX
by Alexandre Julliard 20 Dec '10

20 Dec '10

André Hentschel <nerv(a)dawncrow.de> writes: > see http://bugs.winehq.org/show_bug.cgi?id=25554 I don't think that's necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by cheer_xiao 20 Dec '10

20 Dec '10

Hi Susan, On Dec 19, 2010 8:59 PM, "Susan Cragin" <susancragin(a)earthlink.net> wrote: > > I'm compiling from git onto 64-bit Natty, which is in Alpha. > > Wine's apt-get build-dep script seems to be missing the following. > > configure: OpenCL 32-bit development files not found, OpenCL won't be supported. > configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled > > I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: > python-pyopencl > but still got the warning. > > I know it's too early to mention this, since Natty's still in Alpha. I'm running Ubuntu Lucid and have this problem too. As with Natty, Lucid's repo has development files for gstreamer, but installing them doesn't eliminate the warning about gstreamer. Lucid's repo doesn't contain dev files for OpenCL, either. If I'm not mistaken support for OpenCL was added recently, as I didn't get that warning several weeks ago. I guess this problem could be solved simply by compiling some packages and passing some arguments to ./configure, but as a newbie I'm too looking forward to an answer.

3 2

Wine and serial port AGAIN
by Pavel Troller 20 Dec '10

20 Dec '10

Hi! As a technician, I need often to use some form of serial port communication. My recent experience is with a program for programming TYT radios from China. They supply a simple windows app, which allows to program all the features of the radio, which cannot be accomplished using the radio keyboard only. The program works perfectly in wine, with one exception - a physical comms with the radio. It complains that it doesn't receive a response from the radio, while the radio crashes - it stops working, when a programming attempt is made, and has to be power-cycled. The radio is connected using a USB cable, which contains just a regular PL-2303 USB to serial converter, which is perfectly supported in Linux. Port assignment for wine is also done, proof of which is, that the radio crashes upon the programming request. The data volume to be programmed is small, just a few hundreds of bytes. It's really stupid that I can prepare my data in the program only, and then I need to ask my colleague with real windows to perform a programming job :-(. The program can be freely downloaded from the TYT pages: http://www.tyt888.com/WebEditor/UploadFile/201096144939483.rar but a real radio is needed to debug the comms problem. I've captured the console output with WINEDEBUG=+comm, which is attached. It contains a log of three consecutive attempts to program the radio. I'm ready to do more debugging, but I don't know, how to proceed now. With regards, Pavel.

5 15

64-bit compilation on Ubuntu-Natty -- build-dep script misses two dependencies
by Susan Cragin 20 Dec '10

20 Dec '10

I'm compiling from git onto 64-bit Natty, which is in Alpha. Wine's apt-get build-dep script seems to be missing the following. configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled I was able to find gstreamer but did not find any development files for OpenCL in the Ubuntu repository. I did install this: python-pyopencl but still got the warning. I know it's too early to mention this, since Natty's still in Alpha.

2 1

Re: secur32/tests: Fix tests for some 2k machines
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7712 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W7PROX64 (32 bit schannel) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: qmgr/tests: Fix tests for some 2k machines
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7710 Your paranoid android. === W7PROX64 (64 bit qmgr) === No test summary line found

1 0

Re: schannel/tests: Fix tests for some 2k machines
by Marvin 20 Dec '10

20 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7711 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

TestBot changes
by Greg Geldorp 19 Dec '10

19 Dec '10

I've made some changes to TestBot over the last week. The most important change is the addition of an extra physical server. About half of the VMs have been moved over to this new server. This should speed up testing a bit. Other changes include upgrading the hypervisor to ESX 4.1, applying Windows Update patches to various VMs and fixing some problems in the TestBot scripts. I'll probably continue tweaking things for the next week or so, which means there can be unexpected failures. For those interested in the setup of TestBot, it currently consists of 3 physical machines: 1) Dell PowerEdge SC1435, quad-core AMD Opteron 2.2GHz, 16GB memory, 1.4TB storage, running VMware ESX 4.1. Hosts about half of the NT4+ VMs plus the website/engine VM. 2) Dell PowerEdge R310, quad-core Intel Xeon X3430 2.4GHz, 16GB memory, 550GB storage, running VMware ESX 4.1. Hosts the other half of the NT4+ VMs. This is the new machine. 3) Whitebox, quad-core Intel Core i7 975 3.33GHz, 6GB memory, 450GB storage, running VMware Server on top of openSuSE 11.3. Hosts the Win9x VMs. Greg.

1 0

Re: programs/notepad/Nl.rc and programs/winecfg/Nl.rc: patch for Dutch translation (resend)
by Austin English 19 Dec '10

19 Dec '10

On Sat, Dec 18, 2010 at 9:15 AM, Albert Pool <albertpool(a)solcon.nl> wrote: > Hello, > > I have fixed some English texts which had appeared in the Dutch > translation of notepad and winecfg. The previous mail with these patch > seems not to be arrived at you, so I've resent it. You forgot the patch :-). -- -Austin

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel